#archived-modding-development | Hollow Knight | Page 513

jolly oriole Apr 14, 2021, 3:09 PM

#

i didn't even make it full quality

#

it's still compressed to like 16% or something

vocal spire Apr 14, 2021, 3:10 PM

#

👀

floral blade Apr 14, 2021, 4:05 PM

#

is there a way to explore a prefab ? or one of those objects that are assigned as public properties on another scripts ?

floral blade Apr 14, 2021, 6:20 PM

#

can anyone think of a reason why it would render like this ?

Screenshot_2021-04-14_at_11.49.29_PM.png

#

when the original sprite is this ?

cedar hemlock Apr 14, 2021, 6:21 PM

#

reverse the colour of the sprite

floral blade Apr 14, 2021, 6:22 PM

#

but it doesn't seem like invert, white parts would become black then right ? instead of red ?

cedar hemlock Apr 14, 2021, 6:22 PM

#

hmm yeah right

floral blade Apr 14, 2021, 6:24 PM

#

what's going on here ?

Screenshot_2021-04-14_at_11.53.57_PM.png

cedar hemlock Apr 14, 2021, 6:24 PM

#

red still red

floral blade Apr 14, 2021, 6:24 PM

#

is it only rendering the red channel ?

#

so everything red is red , white is red , every other pure color is black ?

cedar hemlock Apr 14, 2021, 6:25 PM

#

wierd tho

prime urchin Apr 14, 2021, 6:27 PM

#

might be a single channel texture

#

would fit with the only red deal

floral blade Apr 14, 2021, 6:30 PM

#

right ,but when customKnight loads a sprite it just makes a new texture

texture.tex = new Texture2D(2, 2);
texture.tex.LoadImage(texBytes, true);

would this still apply ?

prime urchin Apr 14, 2021, 6:38 PM

#

Hmm - yeah, not sure, I have admittedly little experience working with the graphical side of things

jolly oriole Apr 14, 2021, 6:39 PM

#

may be difference of texture replacing vs sprite replacing

prime urchin Apr 14, 2021, 6:39 PM

#

I guess it could also be some sort of shader?

floral blade Apr 14, 2021, 6:41 PM

#

i tried setting the shader to Sprites/Default

floral blade Apr 14, 2021, 6:41 PM

#

jolly oriole may be difference of texture replacing vs sprite replacing

i mean it's a ParticleSystemRenderer's material's texture that i am updating here would that have a sprite to replace ?

jolly oriole Apr 14, 2021, 6:43 PM

#

then idk

floral blade Apr 14, 2021, 6:43 PM

#

so updating the shared material did this , the other particles that spawn when the shade hits the player got the correct texture 😐

Screenshot_2021-04-15_at_12.12.57_AM.png

#

in fact i think i might have replaced most if not all black orbs

Screenshot_2021-04-15_at_12.14.09_AM.png

#

but the ones i wanted to replace are still red 😐

floral blade Apr 14, 2021, 7:15 PM

#

setting shader to "Standard" got me this.

seems like alpha channel is gone now and the image seems dull like its at reduced brightness? sorry if this is a super noob question 😅 but what shader are we normally supposed to use when trying to render a png with transparency?

Screenshot_2021-04-15_at_12.31.48_AM.png

cedar hemlock Apr 14, 2021, 7:16 PM

#

textures got dark for me2 when using vs

vocal spire Apr 14, 2021, 7:16 PM

#

new Material(Shader.Find(“Sprites/Default”))?

floral blade Apr 14, 2021, 7:25 PM

#

^ doing this seemed to have broken it , i'll try it again and report back

cedar hemlock Apr 14, 2021, 7:25 PM

#

amazing

jolly oriole Apr 14, 2021, 7:30 PM

#

the shade's particles apparently uses the Sprites/Default shader

floral blade Apr 14, 2021, 7:31 PM

#

var psr = x.GetComponent<ParticleSystemRenderer>();
var xM = new Material(Shader.Find("Sprites/Default"));//psr.material;
xM.mainTexture = CustomKnight.Textures["Orb"].tex;
psr.material = xM;

this makes it still go back to the red only thingy 😦

floral blade Apr 14, 2021, 7:31 PM

#

jolly oriole the shade's particles apparently uses the `Sprites/Default` shader

which aligns with this i think

jolly oriole Apr 14, 2021, 7:33 PM

#

x.GetComponent<ParticleSystemRenderer>().material.mainTexture = CustomKnight.Textures["Orb"].tex;

does this work?

floral blade Apr 14, 2021, 7:37 PM

#

i'm so sorry , i just found the issue and feel like an absolute idiot

cedar hemlock Apr 14, 2021, 7:37 PM

#

what was the issue

floral blade Apr 14, 2021, 7:38 PM

#

in my quest to figure out how to set the particle's color assuming they were colored not textured i had set particleSystem.main.startColor = Color.red , when that didn't work it got burried under a lot of commented code
but was still getting applied 😦

copper nacelle Apr 14, 2021, 7:39 PM

#

it happens

floral blade Apr 14, 2021, 7:39 PM

#

i'm so sorry for wasting everyone's time , and thanks for helping me anyways!

fair rampart Apr 14, 2021, 9:45 PM

#

dudeeee its not depleting my soul when I heal in lightbringer

#

Zaliant, I dont even know

#

I attract bugs

#

and not in the good way

gilded lotus Apr 14, 2021, 9:47 PM

#

fair rampart Apr 14, 2021, 9:47 PM

#

oh

#

I thought I was in modding help

stone elm Apr 15, 2021, 1:04 AM

#

I don't think I fully understand the tips you gave, 56, about FSM stuff for 1.5. Take a look at: https://github.com/CallumMoseley/HollowKnight.RandomizerMod/blob/master/RandomizerMod3.0/Actions/ChangeShinyIntoItem.cs
I haven't made any significant changes to this file. The FSM is still working improperly. All the states already exist and all transition differences are just those pointing to different states in the same FSM. Is there something obvious to you that I'm missing? This uses SereCore's PlayMakerExtensions; maybe I misunderstood but is there anything there in particular that needed changing? I feel a little dumb for asking about the same issue repeatedly but hopefully I can progress past it soon. tisoweary

GitHub

CallumMoseley/HollowKnight.RandomizerMod

My attempt at creating a new version of Multiworld which works with rando 3.0 features - CallumMoseley/HollowKnight.RandomizerMod

timber breach Apr 15, 2021, 2:52 AM

#

Hey i want to get into modding bosses. Were should i get started?

dusty obsidian Apr 15, 2021, 4:09 AM

#

howdy howdy. trying to make a skin. i have spritepacker working fine. how im currently doing it is opening all the pngs in a folder for a certain animation(?) (eg. opening all pngs in Knight -> Idle) and adding what i want in clip studio paint

ive noticed there are a lot of overlap (specifically the head) for a lot of sprites, but they cant be check->replace in spritepacker because the cloak’s different/theyre offset by a few pixels. is there a good way to locate these so you can make sure your skin is consistent where it should be? entirely understandable if there isnt and i should keep checking/rotating old sprites and copying the relevant bits ive made onto new sprites or deal with the fact that some of the heads which were identical in the original wont be in my skin. just want to make sure im not taking an unnecessarily tedious route to spriting!

floral blade Apr 15, 2021, 4:33 AM

#

I'm all for generating sprites , but someone would need to manually tag these spots in terms of their coordinates and that sounds like a lot of effort.
Depending on the level of tagging, It could allow to generate skins in a similar way to vessel maker.

#

beesive

dusty obsidian Apr 15, 2021, 4:37 AM

#

sounds like there isnt anything that would identify similarities/generate all sprites sharing the similarity. dang :^( ty 4 the response! :^)

floral blade Apr 15, 2021, 4:38 AM

#

Yeah atleast not easily I think

dusty obsidian Apr 15, 2021, 4:40 AM

#

really makes me appreciate the work spriters do! they deserve more recognition (^: the main file is ginormous, and theres no easy way/shortcut to reskinning

copper nacelle Apr 15, 2021, 5:36 AM

#

stone elm I don't think I fully understand the tips you gave, 56, about FSM stuff for 1.5....

The AddTransition/ClearTransitions extensions in SereCore are probably wrong if you didn't change those

#

https://github.com/fifty-six/HollowKnight.Vasi/commit/f955419e20e80de92bc53c59a04c3d63e757c86e if you look at the diff for FsmUtil that's basically what you need to change

#

It uses ToFsmState instead of ToState now

jolly oriole Apr 15, 2021, 6:33 AM

#

btw, another change, probably worse to find out: some fsm events got renamed

steady comet Apr 15, 2021, 6:57 AM

#

jolly oriole btw, another change, probably worse to find out: some fsm events got renamed

Uhh... is there a list of which ones? Or do we just have to find out?

jolly oriole Apr 15, 2021, 7:02 AM

#

find out, i know that TALK_FINISH was changed to CONVO_FINISH

steady comet Apr 15, 2021, 7:12 AM

#

Isn't it CONVO_FINISH in 1432?

jolly oriole Apr 15, 2021, 7:26 AM

#

afaik it was one of those and was changed to the other

#

found it

#

hmmm, maybe tc waits for even more fps in hk: https://www.youtube.com/watch?v=nY20fDmlW7M

primal latch Apr 15, 2021, 9:30 AM

#

        public static bool OnEnemyEnable(GameObject enemy, bool isAlreadyDead)
        {
            string normalName;
            if (enemy.name.Contains("(Clone)"))
            {
                normalName = enemy.name.Remove(enemy.name.Length - 7, 7);
            }
            else if (enemy.name.Contains("("))
            {
                normalName = enemy.name.Remove(enemy.name.Length - 4, 4);
            }
            else
            {
                normalName = enemy.name;
            }
            if(!patched.Contains(normalName))
            {
                if (Dictionaries.EnemyTextures.ContainsKey(normalName))
                {
                    enemy.transform.gameObject.GetComponent<tk2dSprite>().GetCurrentSpriteDef().material.mainTexture = Dictionaries.EnemyTextures[normalName];
                }
                patched.Add(normalName);
            }

            Modding.Logger.Log($"normal name: {normalName}");
            return isAlreadyDead;
        }
        private static List<string> patched = new List<string>();```
Something in this code apparently causes infinite loading screens. It uses the hook ```ModHooks.Instance.OnEnableEnemyHook += SpritePatcher.OnEnemyEnable;``` The EnemyTextures dictionary is a dictionary with a string as key and a texture as data. When this piece of code is disabled everything works fine

cedar hemlock Apr 15, 2021, 9:32 AM

#

you forgot a `

primal latch Apr 15, 2021, 9:32 AM

#

where?

cedar hemlock Apr 15, 2021, 9:33 AM

#

ofter enable to make it like this xD

primal latch Apr 15, 2021, 9:36 AM

#

primal latch ```csharp public static bool OnEnemyEnable(GameObject enemy, bool isAlre...

please ping me with an answer

jolly oriole Apr 15, 2021, 10:32 AM

#

Only some general things, might not be the cause, but debugging it shouldn't be an issue as errors clearly state where it crashes

"".Replace(" (Clone)", "") > if (enemy.name.Contains("(Clone)")) and the entire inside
"".Substring(0, "".LastIndexOf("(")) > else if (enemy.name.Contains("(")) and the entire inside

primal latch Apr 15, 2021, 10:59 AM

#

That isn’t the problem. The normal name itself works. It is something in the part after that. Thanks for the improvements though

#

It does fix some wacky things with unused strings in the compiled assembly

steady comet Apr 15, 2021, 11:03 AM

#

What appears in the modlog? Nothing?

primal latch Apr 15, 2021, 11:09 AM

#

Nothing

#

It just kind of sits there

steady comet Apr 15, 2021, 11:10 AM

#

I assume the first time you get the infinite load is the same as the first time you enter a scene with an enemy to be retextured?

jolly oriole Apr 15, 2021, 11:11 AM

#

then i'll assume there is a ton of things in output_log if it isn't in modlog

primal latch Apr 15, 2021, 11:13 AM

#

steady comet I assume the first time you get the infinite load is the same as the first time ...

Nope. Just any scene

primal latch Apr 15, 2021, 11:13 AM

#

jolly oriole then i'll assume there is a ton of things in output_log if it isn't in modlog

I’ll take a look

primal latch Apr 15, 2021, 11:16 AM

#

primal latch I’ll take a look

I mean later today. I don’t have my fast laptop near my rn

steady comet Apr 15, 2021, 11:17 AM

#

primal latch Nope. Just any scene

If it breaks on any scene, then the problem shouldn't be with the bottom code that doesn't execute, right?

primal latch Apr 15, 2021, 11:18 AM

#

steady comet If it breaks on any scene, then the problem shouldn't be with the bottom code th...

IDK. As far as I know it happends on any scene.

steady comet Apr 15, 2021, 11:22 AM

#

Side issue - I wonder if cutting of the brackets is actually what you want to be doing; like, it seems the enemy name is something like Fly 1 rather than Fly (1) - at least according to debug mod

primal latch Apr 15, 2021, 11:23 AM

#

steady comet Side issue - I wonder if cutting of the brackets is actually what you want to be...

That is unity. If you have placed several instances of the same object in a scene it adds (NUMBER) to the end

steady comet Apr 15, 2021, 11:23 AM

#

Definitely with the brackets, in the enemy.name field?

primal latch Apr 15, 2021, 11:24 AM

#

steady comet Definitely with the brackets, in the enemy.name field?

Is this scentence correct?

#

I don't understand it

steady comet Apr 15, 2021, 11:26 AM

#

What I meant is, I believe that enemy.name will not have brackets (if I write code that says

public static bool OnEnemyEnable(GameObject enemy, bool isDead)
        {
          Log(enemy.name);
          return isDead;
        }

there are no parentheses in the entries printed to the log).

midnight canyon Apr 15, 2021, 11:26 AM

#

Some do, some don't

primal latch Apr 15, 2021, 11:27 AM

#

indeed

steady comet Apr 15, 2021, 11:27 AM

#

IDK I don't know unity

jolly oriole Apr 15, 2021, 11:28 AM

#

you can get

Spitter
Spitter (1)
Spitter (Clone)
Spitter (clone) (Clone)
Spitter (1) (clone)

and yes, i think both versions of clone exist

steady comet Apr 15, 2021, 11:29 AM

#

Is this TC 🍝 or Unity 🍝?

primal latch Apr 15, 2021, 11:30 AM

#

steady comet Is this TC 🍝 or Unity 🍝?

unity

deep wave Apr 15, 2021, 11:30 AM

#

that makes a change sideax2uHappy

jolly oriole Apr 15, 2021, 11:30 AM

#

tc, as unity calls them (1), (2)...

#

or only one version of clone (idk if capitalized or not though), when instantiating from code

light zodiac Apr 15, 2021, 12:25 PM

#

in the docs it says in the SceneChanged part that:
It’s recommended to use the internal SceneLoaded hook instead of the the api’s by using UnityEngine.SceneManagement.SceneManager.sceneLoaded However you’ll probably want to delay this by a frame by using a coroutine.
i dont get how to start a coroutine before the hook is called.

ornate rivet Apr 15, 2021, 12:26 PM

#

Do StartCoroutine(yourThing()); inside the hook

#

honestly the frame delay isn't necessary a lot of times so I would test it without the delay first

jolly oriole Apr 15, 2021, 12:29 PM

#

i mean, also an alternative is the activescenechanged hook, and it works for all of my use cases

#

~~with all my use cases being setting the map width and height~~

ornate rivet Apr 15, 2021, 12:29 PM

#

oh yea ^

light zodiac Apr 15, 2021, 12:34 PM

#

to wait a frame i say yield return null;?

jolly oriole Apr 15, 2021, 12:35 PM

#

yes

#

just please don't do this in a while loop, it will crush frames

ornate rivet Apr 15, 2021, 12:37 PM

#

oh whoops

vocal spire Apr 15, 2021, 12:37 PM

#

Time to crush frames!

jolly oriole Apr 15, 2021, 12:43 PM

#

i mean, pressgtodab reduced my main menu fps from 800-900 to just 300

#

though it was a

while (HeroController.instance != null) yield return null;

copper nacelle Apr 15, 2021, 12:45 PM

#

any unsafeInstance

jolly oriole Apr 15, 2021, 12:45 PM

#

i didn't write that code, i just changed to hook herocontroller.awake i think, made it work with save+exit

vocal spire Apr 15, 2021, 12:46 PM

#

HeroController.awake is clearly superior to frame murder

copper nacelle Apr 15, 2021, 12:46 PM

#

pretty sure it won't eat your frames if you don't use instance

#

findobjectoftype every frame is not the tech

jolly oriole Apr 15, 2021, 12:47 PM

#

yea, i don't use yield return null at all in my code, except for a single instance

steady comet Apr 15, 2021, 12:50 PM

#

Is there a difference between yield return null and yield return new WaitForEndOfFrame()?

copper nacelle Apr 15, 2021, 12:52 PM

#

yes

#

steady comet Apr 15, 2021, 12:54 PM

#

Woah that chart looks shroompog

stone elm Apr 15, 2021, 1:57 PM

#

copper nacelle The AddTransition/ClearTransitions extensions in SereCore are probably wrong if ...

So I actually proxied the extension functions so I could use FSMUtil's AddTransition but still use SereCore's ClearTransitions. Check this out:

public static class FsmStateExtensionsProxy
    {
        public static void RemoveActionsOfType<T>(this FsmState fsm) where T: FsmStateAction
        {
            PlayMakerExtensions.RemoveActionsOfType<T>(fsm);
        }

        public static FsmState GetState(this PlayMakerFSM fsm, string stateName)
        {
            return FsmUtil.GetState(fsm, stateName);
        }

        public static void ClearTransitions(this FsmState fsm)
        {
            PlayMakerExtensions.ClearTransitions(fsm);
        }

        public static void AddTransition(this FsmState fsm, string state, string transitionTo)
        {
            FsmUtil.AddTransition(fsm, state, transitionTo);
        }

        public static void AddAction(this FsmState fsm, FsmStateAction action)
        {
            FsmUtil.AddAction(fsm, action);
        }

        public static T[] GetActionsOfType<T>(this FsmState fsm) where T: FsmStateAction
        {
            return PlayMakerExtensions.GetActionsOfType<T>(fsm);
        }

        public static void AddFirstAction(this FsmState fsm, FsmStateAction action)
        {
            PlayMakerExtensions.AddFirstAction(fsm, action);
        }
    }

The thing is, SereCore's ClearTransitions looks "fine" in how it works. Here is its source:

    public static void ClearTransitions(this FsmState self)
    {
        self.Transitions = new FsmTransition[0];
    }

It seems like it's fine since it seems like assigning directly onto FsmState.Transitions is done elsewhere, and in Vasi, seemingly without issue.

It seems to me that the problem is elsewhere but I'm unsure what it could be. I'm trying to open the FSM in FSMViewer2 but I literally can't find the FSM/which file to open for that scene.

cedar hemlock Apr 15, 2021, 1:57 PM

#

how do you do the colours?

stone elm Apr 15, 2021, 1:58 PM

#

Code block is three backticks, you just put the language on the first line.

```cs

#

Of course you close the code block with three backticks but that's hard to demo without making a block

cedar hemlock Apr 15, 2021, 2:00 PM

#

yeah ik how to do the code block but the colours is smth new to me

copper nacelle Apr 15, 2021, 2:12 PM

#

did you build vasi from source?

#

or is that modcommon fsmutil x5fiftPrime

stone elm Apr 15, 2021, 2:13 PM

#

I did build from source and it isn't modcommon, just checked.

vocal spire Apr 15, 2021, 2:13 PM

#

cedar hemlock yeah ik how to do the code block but the colours is smth new to me

Add csharp to the end of the first set of things

copper nacelle Apr 15, 2021, 2:14 PM

#

does your source have the 1.5 update

stone elm Apr 15, 2021, 2:14 PM

#

Yup, I checked history and pulled latest.

cedar hemlock Apr 15, 2021, 2:14 PM

#

vocal spire Add csharp to the end of the first set of things

amazing

copper nacelle Apr 15, 2021, 2:14 PM

#

hmm

#

no exceptions or anything yeah?

stone elm Apr 15, 2021, 2:15 PM

#

Not in modlog... But I forgot to check the unity logs. There might be something there.

#

Nope, nothing

copper nacelle Apr 15, 2021, 2:20 PM

#

you know which fsm is dying yeah?

stone elm Apr 15, 2021, 2:20 PM

#

Yeah, Shiny Control in scene Tutorial_01

#

FsmViewer calls it Shiny Item (1)- Shiny Control

copper nacelle Apr 15, 2021, 2:22 PM

#

https://github.com/fifty-six/HollowKnight.Pale-Prince/blob/master/Pale Prince/Prince.cs#L245

#

add the debug section to whatever's modifying the fsm

stone elm Apr 15, 2021, 2:27 PM

#

I had a print to say when a state is entered and it always got stuck at Charm?. I'll add more of the debug statements now

#

[DEBUG]:[RandomizerMod] - End: Pause
[DEBUG]:[RandomizerMod] - Transitioning to: Init
[DEBUG]:[RandomizerMod] - Start: Init
[DEBUG]:[RandomizerMod] - End: Init
[DEBUG]:[RandomizerMod] - Transitioning to: PD Bool?
[DEBUG]:[RandomizerMod] - Start: PD Bool?
[DEBUG]:[RandomizerMod] - End: PD Bool?
[DEBUG]:[RandomizerMod] - Transitioning to: Fling?
[DEBUG]:[RandomizerMod] - Start: Fling?
[DEBUG]:[RandomizerMod] - Start: Fling R
[DEBUG]:[RandomizerMod] - End: Fling R
[DEBUG]:[RandomizerMod] - Transitioning to: In Air
[DEBUG]:[RandomizerMod] - Start: In Air
[DEBUG]:[RandomizerMod] - End: In Air
[DEBUG]:[RandomizerMod] - Transitioning to: null
[DEBUG]:[RandomizerMod] - Start: Land
[DEBUG]:[RandomizerMod] - End: Land
[DEBUG]:[RandomizerMod] - Transitioning to: Idle
[DEBUG]:[RandomizerMod] - Start: Idle
[DEBUG]:[RandomizerMod] - End: Idle
[DEBUG]:[RandomizerMod] - Transitioning to: null
[DEBUG]:[RandomizerMod] - Start: Hero Down
[DEBUG]:[RandomizerMod] - End: Hero Down
[DEBUG]:[RandomizerMod] - Transitioning to: Charm?
[DEBUG]:[RandomizerMod] - Start: Charm?
[DEBUG]:[RandomizerMod] - End: Charm?
[DEBUG]:[RandomizerMod] - Transitioning to: null```
Yeah, looks like transitions are broken.

copper nacelle Apr 15, 2021, 2:31 PM

#

Log the ToState and see if it's set instead

#

Because if something's not updated it'll be using ToState instead of ToFsmState

stone elm Apr 15, 2021, 2:42 PM

#

[DEBUG]:[RandomizerMod] - Test ToState: Charm?
[DEBUG]:[RandomizerMod] - Transitioning to: Charm?
[DEBUG]:[RandomizerMod] - Start: Charm?
[DEBUG]:[RandomizerMod] - End: Charm?
[DEBUG]:[RandomizerMod] - Test ToState: 
[DEBUG]:[RandomizerMod] - Transitioning to: null```

#

No ToState and null ToFsmState... Weird.

#

I fixed it by not using (serecore's) ClearTransitions and using Vasi's ChangeTransition on each event that needed changing.

#

Of course now it gets stuck on the next state since that one uses ClearTransitions

#

Why would clearing transitions that way cause it to break? Hmmm....

vocal spire Apr 15, 2021, 2:49 PM

#

How are you adding back transitions?

stone elm Apr 15, 2021, 2:51 PM

#

Vasi's method:

public static void AddTransition(this FsmState state, FsmEvent @event, string toState)
{
    state.Transitions = state.Transitions.Append
        (
            new FsmTransition
            {
                FsmEvent = @event,
                ToFsmState = state.Fsm.GetState(toState)
            }
        )
        .ToArray();
}
        
[PublicAPI]
public static void AddTransition(this FsmState state, string eventName, string toState)
{
    state.AddTransition(new FsmEvent(eventName), toState);
}

jolly oriole Apr 15, 2021, 2:53 PM

#

FsmEvent.GetFsmEvent(eventName)

#

Instead of new

vocal spire Apr 15, 2021, 2:53 PM

#

Yeah

#

It’s trying to transition with a non existent transition

stone elm Apr 15, 2021, 2:54 PM

#

I'll change that and recompile Vasi to give it a shot

#

That doesn't fix the issue

#

New function:

[PublicAPI]
public static void AddTransition(this FsmState state, string eventName, string toState)
{
    state.AddTransition(FsmEvent.GetFsmEvent(eventName), toState);
}

#

Hold on, I may have been an idiot and not updated the vasi in my mods folder

#

Yes, that is the fix. Thanks SF, Someone.

#

56, I'll PR this into your repo for you, unless you plan to do it right now.

copper nacelle Apr 15, 2021, 3:08 PM

#

Sure

#

Does that create the event if it doesn't exist?

jolly oriole Apr 15, 2021, 3:10 PM

#

yes

copper nacelle Apr 15, 2021, 3:10 PM

#

interesting

jolly oriole Apr 15, 2021, 3:11 PM

#

findfsmevent doesn't

copper nacelle Apr 15, 2021, 3:13 PM

#

Oh is this adding a transition from finished?

stone elm Apr 15, 2021, 3:15 PM

#

That what my code is doing, at least. PR here: https://github.com/fifty-six/HollowKnight.Vasi/pull/1

copper nacelle Apr 15, 2021, 3:17 PM

#

mrw 3 commits

#

I can merge but fwiw I'd recommend using FsmEvent.Finished instead of the string

jolly oriole Apr 15, 2021, 3:17 PM

#

and 2 of those just spaces

stone elm Apr 15, 2021, 3:18 PM

#

I KNOW, OK?

#

I hate whitespace diffs

#

It bugs me

#

Anyway, thanks for the tip. I'll use the member rather than a string literal

copper nacelle Apr 15, 2021, 3:20 PM

#

yeah I just commented because you can squash

stone elm Apr 15, 2021, 3:20 PM

#

I'm just lazy... unless stupid whitespace is involved. Then I get hollowwoke

#

Sorry for cluttering your history. 🙂

light zodiac Apr 15, 2021, 5:51 PM

#

Is there a way to take control away from the player?

copper nacelle Apr 15, 2021, 5:52 PM

#

RelinquishControl

light zodiac Apr 15, 2021, 5:56 PM

#

Thank youu

floral blade Apr 15, 2021, 6:16 PM

#

so i know an object's name but not it's prefab's can i still somehow instantiate it?
the GO is "Arrow Prompt New" and it's prefab to the best of my understanding is available in an FSMStateAction "ShowPromptMarker"

vocal spire Apr 15, 2021, 6:17 PM

#

Fsm page of apidocs

floral blade Apr 15, 2021, 6:17 PM

#

i dont see a open scene list in FSMavalonia

jolly oriole Apr 15, 2021, 6:20 PM

#

rip

steady comet Apr 15, 2021, 6:20 PM

#

Open resources.assets

floral blade Apr 15, 2021, 6:20 PM

#

selecting the resources.assets file brings me here

Screenshot_2021-04-15_at_11.49.24_PM.png

steady comet Apr 15, 2021, 6:20 PM

#

IIRC there's an Arrow Prompt object in there

copper nacelle Apr 15, 2021, 6:20 PM

#

i don't see how this has to do with instantiating it

#

you just get the fsm action and take the gameObject off that

floral blade Apr 15, 2021, 6:22 PM

#

copper nacelle you just get the fsm action and take the gameObject off that

this is what i want to know how to do. i saw the fsm action using ilspy and i dont know how to access it

#

var x = Object.FindObjectsOfType<PromptMarker>();
Logger.Info(this,x[0].gameObject.name);

i did this hack to get the name of the go in hopes that would help 😐

copper nacelle Apr 15, 2021, 6:24 PM

#

I mean if that finds it you could instantiate it with that

floral blade Apr 15, 2021, 6:25 PM

#

copper nacelle I mean if that finds it you could instantiate it with that

it only finds if it is active like if i am right infront of the bench or elderbug the prompt comes up and i can find it

jolly oriole Apr 15, 2021, 6:25 PM

#

though Resources.FindObjectsOfTypeAll<Promptmarker>() is probably better

copper nacelle Apr 15, 2021, 6:25 PM

#

Yeah ok then get the fsm which spawns it

floral blade Apr 15, 2021, 6:26 PM

#

copper nacelle Yeah ok then get the fsm which spawns it

i would like to do this yes

copper nacelle Apr 15, 2021, 6:26 PM

#

do you know what fsm it is

floral blade Apr 15, 2021, 6:26 PM

#

i only know the stateAction thanks to ilspy

#

also i feel like i am missing some fsms in fsmviewer avalonia because i dont see the "spitter-spitter" from the apidocs

jolly oriole Apr 15, 2021, 6:29 PM

#

RestBench - Bench Control - In Range - ShowPromptMarker

floral blade Apr 15, 2021, 6:29 PM

#

jolly oriole though `Resources.FindObjectsOfTypeAll<Promptmarker>()` is probably better

this would load even if the go is not active?

jolly oriole Apr 15, 2021, 6:30 PM

#

yes, reads that in unity's docs

floral blade Apr 15, 2021, 6:31 PM

#

jolly oriole RestBench - Bench Control - In Range - ShowPromptMarker

how did you acquire this info ?
and do i just go.LocateMyFsm this string ?

jolly oriole Apr 15, 2021, 6:31 PM

#

i just used fsm viewer

#

you'd probably want only the fsm name, so Bench Control

floral blade Apr 15, 2021, 6:32 PM

#

jolly oriole i just used fsm viewer

the windows one?

floral blade Apr 15, 2021, 6:32 PM

#

jolly oriole you'd probably want only the fsm name, so Bench Control

okay i'll try this and report back

vocal spire Apr 15, 2021, 6:32 PM

#

You pinged NoPingNeeded twice 🤔

floral blade Apr 15, 2021, 6:34 PM

#

wait. i dont know which go to call this LocateMyFsm on, because i'm trying to find the go

vocal spire Apr 15, 2021, 6:34 PM

#

GameObject.Find(goname)

#

Or preload

floral blade Apr 15, 2021, 6:35 PM

#

is "RestBench" the go name in this context?

vocal spire Apr 15, 2021, 6:35 PM

#

Yes

#

You also need to find it in the correct scene after waiting a frame

jolly oriole Apr 15, 2021, 6:36 PM

#

the restbench is the one from Town btw

floral blade Apr 15, 2021, 6:39 PM

#

and to figure out which scene the object is from you need the FSM Viewer?

vocal spire Apr 15, 2021, 6:39 PM

#

Usually you know the scene before the object but yes

copper nacelle Apr 15, 2021, 6:40 PM

#

need is a strong word

vocal spire Apr 15, 2021, 6:40 PM

#

Good point

floral blade Apr 15, 2021, 6:42 PM

#

could i probably figure out scene name using ilspy ?

i'd been figuring out object names by logging the collider's go's name on slashHit

vocal spire Apr 15, 2021, 6:42 PM

#

No

floral blade Apr 15, 2021, 6:42 PM

#

could i log it on scene enter ?

vocal spire Apr 15, 2021, 6:42 PM

#

Also grenade told you the scene name

#

Yes

#

You can also look in the pins for multiple sources of scene names

floral blade Apr 15, 2021, 6:43 PM

#

yes for this one i'm going to try that one, i'm trying to figure out what would be my workflow for the next time i want to access some random object

languid marsh Apr 15, 2021, 7:09 PM

#

does anyone know why the hollow point mod does not work? I can see the gun but not equip it?

copper nacelle Apr 15, 2021, 7:11 PM

#

'

floral blade Apr 15, 2021, 7:34 PM

#

Town - RestBench - Bench Control - In Range - ShowPromptMarker
so this is Scene - go- FSM - State - StateAction ?

copper nacelle Apr 15, 2021, 7:34 PM

#

no

#

GameObject - Fsm - State - Action I assume

floral blade Apr 15, 2021, 7:34 PM

#

yeah gotcha!

#

ty

cedar hemlock Apr 15, 2021, 7:48 PM

#

is there an problem with
https://github.com/ricardosouzag/ModInstaller/pull/85
and
https://github.com/ricardosouzag/ModInstaller/pull/83
?

copper nacelle Apr 15, 2021, 7:49 PM

#

idk what happens with subfolders

#

i'll merge it anyways ig

jolly oriole Apr 15, 2021, 8:01 PM

#

floral blade Town - RestBench - Bench Control - In Range - ShowPromptMarker so this is Scene ...

yes

floral blade Apr 15, 2021, 8:18 PM

#

i now have a garden of popups with no text , the textMeshPro component seems to be null, but this is progress!

vocal spire Apr 15, 2021, 8:18 PM

#

Nice

jolly jungle Apr 15, 2021, 9:02 PM

#

What are you trying to make?

vocal spire Apr 15, 2021, 9:02 PM

#

Gardening simulator mod?

floral blade Apr 15, 2021, 9:05 PM

#

as an exercise in getting a better understanding of how it all works, i'm trying to get HK's internal UI systems to popup with custom text / behaviour etc.

#

but if it fails then gardening simulator is always there

#

the garden is really coming along well 😛

copper nacelle Apr 15, 2021, 9:14 PM

#

beautiful

floral blade Apr 15, 2021, 9:19 PM

#

it Finally worked

#

apparently there's a "SetTextMeshProGameText" Monobehavior on the GO, which would replace the text, nuking it solved my SetTexts not working

vocal spire Apr 15, 2021, 10:23 PM

#

Can also set it to use a different key to input into the language stuff

floral blade Apr 15, 2021, 10:34 PM

#

can we add new items into the language thingy ?

cloud axle Apr 15, 2021, 10:43 PM

#

someone should try and make a boss with the shield guy, it would be cool if someone did do it

boreal barn Apr 16, 2021, 1:10 AM

#

does anyone here know where I can find the background assets for Nosk den? I can't find them anywhere in the google folder of sprites & assets (checked npcs, bosses, area backgrounds, etc)

vocal spire Apr 16, 2021, 3:05 AM

#

cloud axle someone should try and make a boss with the shield guy, it would be cool if some...

Already done by someone else

vocal spire Apr 16, 2021, 3:06 AM

#

boreal barn does anyone here know where I can find the background assets for Nosk den? I can...

You could try using hkedit(link in the pins)

boreal barn Apr 16, 2021, 3:18 AM

#

which pin?

primal latch Apr 16, 2021, 5:35 AM

#

?pins

finite forumBOT Apr 16, 2021, 5:35 AM

#

Check the pinned messages for more information - https://cdn.discordapp.com/attachments/187137504393035776/823796522751623168/unknown.png

heavy patrol Apr 16, 2021, 6:36 AM

#

My apologies, but does debugger show what sounds are currently playing, or perhaps another mod? Trying to find certain sound effects

jolly oriole Apr 16, 2021, 6:36 AM

#

afaik no such mod exists currently

rough pulsar Apr 16, 2021, 8:27 AM

#

so uh

#

i skipped the web installing processes and i tested SharpZipLib

cedar hemlock Apr 16, 2021, 8:28 AM

#

and that broke everything

rough pulsar Apr 16, 2021, 8:28 AM

#

yeah i think

cedar hemlock Apr 16, 2021, 8:28 AM

#

amazing

rough pulsar Apr 16, 2021, 8:28 AM

#

my memory is not that clear on that one though i might try it again

#

AND i was using 0.88 of SharpZipLib

#

JUST BECAUSE it was the only version that supported .NET Framework 3.5 projects

cedar hemlock Apr 16, 2021, 8:29 AM

#

lol

#

you can try seeing if you can make a pr to the modinstaller to get it working

rough pulsar Apr 16, 2021, 8:30 AM

#

hm

cedar hemlock Apr 16, 2021, 8:30 AM

#

or just edit the code and compile it for yourself

rough pulsar Apr 16, 2021, 8:30 AM

#

yeah i would do the latter

cedar hemlock Apr 16, 2021, 8:30 AM

#

although its difficult to look at an big project

#

will take some time

rough pulsar Apr 16, 2021, 8:30 AM

#

i wouldn't want to go to the trouble of making a pr, waiting a few hours then testing the modinstaller to see it works, fail, make another pr...

rough pulsar Apr 16, 2021, 8:31 AM

#

cedar hemlock although its difficult to look at an big project

while i was looking at the source code of modinstaller i found a variable that leads to the modlinks.xml

cedar hemlock Apr 16, 2021, 8:31 AM

#

oh and i reccomend de-grading the thing in modlinks to version 1.1.0

rough pulsar Apr 16, 2021, 8:31 AM

#

i can redirect it to my own modlinks.xml

cedar hemlock Apr 16, 2021, 8:31 AM

#

or any other version that works

rough pulsar Apr 16, 2021, 8:33 AM

#

i'll work on a fix on my mod today i guess

#

so wait

#

modinstaller1 doesn't install stuff from subfolders or nah?

cedar hemlock Apr 16, 2021, 8:33 AM

#

?

#

the madethe name <Name>x86_64/discord_game_sdk.bundle</Name>

rough pulsar Apr 16, 2021, 8:34 AM

#

like, the files i placed inside modlinks.xml

#

so modinstaller1 also works with that

cedar hemlock Apr 16, 2021, 8:34 AM

#

so the name becomes x86_64/discord_game_sdk.bundle

rough pulsar Apr 16, 2021, 8:34 AM

#

hm...

cedar hemlock Apr 16, 2021, 8:34 AM

#

1 is identical to 2 but 2 is made in an different software or smth

rough pulsar Apr 16, 2021, 8:34 AM

#

ik

#

so.

#

what happens if i run a shell command inside my mod

#

powershell works

#

but that makes it windows-only

#

which i don't absolutely want

cedar hemlock Apr 16, 2021, 8:53 AM

#

cmd also exists on mac and linux

#

so you'll want to use cmd

#

and not powershell

rough pulsar Apr 16, 2021, 8:53 AM

#

so

#

i can execute curl in mac and linux and be fine? @cedar hemlock

cedar hemlock Apr 16, 2021, 8:54 AM

#

i have no idea

#

ask google

rough pulsar Apr 16, 2021, 8:54 AM

#

HOLD ON.

#

If I remember correctly, there's an entire library that's built-in inside C# .NET

#

Which is of course, PowerShell related

#

I might be able to execute PS commands from there

cedar hemlock Apr 16, 2021, 8:55 AM

#

amazing

#

but is it in 3.5 yet

rough pulsar Apr 16, 2021, 8:56 AM

#

hm

#

idk

#

actually i have planned to buy an usb stick and install linux ubuntu or fedora there

cedar hemlock Apr 16, 2021, 8:56 AM

#

you can also try to execute it via modinstaller which is 4.5 or 4 i dont rly know

rough pulsar Apr 16, 2021, 8:56 AM

#

sooo

cedar hemlock Apr 16, 2021, 8:56 AM

#

but thats a strech

rough pulsar Apr 16, 2021, 8:56 AM

#

yeah

#

that's some sort of a strecth

#

apparently

#

it is located inside...

#

System.Management.Automation;

#

#

WAIT.....

cedar hemlock Apr 16, 2021, 9:00 AM

#

2002!?

#

that old?

rough pulsar Apr 16, 2021, 9:01 AM

#

the one at bottom is powershell date

#

YEAH

#

THAT OLD

cedar hemlock Apr 16, 2021, 9:01 AM

#

wow

rough pulsar Apr 16, 2021, 9:01 AM

#

I DON'T KNOW WHY MODDING API USES IT

cedar hemlock Apr 16, 2021, 9:01 AM

#

its not the api

rough pulsar Apr 16, 2021, 9:01 AM

#

oh

#

right

#

unity 2017

#

i forgot.

cedar hemlock Apr 16, 2021, 9:01 AM

#

its tc

rough pulsar Apr 16, 2021, 9:01 AM

#

~~WHY TEAM CHERRY~~

cedar hemlock Apr 16, 2021, 9:01 AM

#

lol

jolly oriole Apr 16, 2021, 9:09 AM

#

because the game's latest update is from 2017???

#

or 2018, idk

cedar hemlock Apr 16, 2021, 9:10 AM

#

gonna call you NPN now

#

no SFG anymore

cedar hemlock Apr 16, 2021, 9:19 AM

#

rough pulsar ~~WHY TEAM CHERRY~~

just wait for 1.5

#

then we have 4.5+

rough pulsar Apr 16, 2021, 9:20 AM

#

?!

#

well

#

its only beta.

cedar hemlock Apr 16, 2021, 9:23 AM

#

_ _

rough pulsar Apr 16, 2021, 9:25 AM

#

popopogggogogg

#

imagine teamcherry upgrading to that

cedar hemlock Apr 16, 2021, 9:26 AM

#

ehm

rough pulsar Apr 16, 2021, 9:26 AM

#

excrpt.....

#

modding api will break

#

probably

cedar hemlock Apr 16, 2021, 9:26 AM

#

thats what gonna happen

cedar hemlock Apr 16, 2021, 9:26 AM

#

rough pulsar probably

they are already fixing it

rough pulsar Apr 16, 2021, 9:26 AM

#

ohhh pog

cedar hemlock Apr 16, 2021, 9:26 AM

#

there is already 1.5 api that works half iirc

rough pulsar Apr 16, 2021, 9:27 AM

#

hmmmm

cedar hemlock Apr 16, 2021, 9:27 AM

#

but mods that dont get fixed will break

rough pulsar Apr 16, 2021, 9:27 AM

#

i hope the api fixes the issue when it sees a non-.net library

rough pulsar Apr 16, 2021, 9:27 AM

#

cedar hemlock but mods that dont get fixed will break

i can just change the targeted framework to... that version?

#

in visual studio

cedar hemlock Apr 16, 2021, 9:27 AM

#

yes

#

and fix some other things that change with unity 2020.2

rough pulsar Apr 16, 2021, 9:28 AM

#

meh

#

it only creates one gameobject

#

which has 2 standard functions that seem universal in every unity version

#

start() & update()

cedar hemlock Apr 16, 2021, 9:28 AM

#

not many things will rly break

#

unity tries to let old things still work

rough pulsar Apr 16, 2021, 9:29 AM

#

unity do be working on backwards compability

cedar hemlock Apr 16, 2021, 9:29 AM

#

so not much needs to be changed

cedar hemlock Apr 16, 2021, 9:29 AM

#

rough pulsar unity do be working on backwards compability

half

rough pulsar Apr 16, 2021, 9:29 AM

#

ur

#

ye

primal latch Apr 16, 2021, 11:17 AM

#

When will 1.5 release?

deep wave Apr 16, 2021, 11:18 AM

#

whenever TC feels like it feelspkman

ornate rivet Apr 16, 2021, 11:22 AM

#

hopefully never

jolly oriole Apr 16, 2021, 11:43 AM

#

hopefully soon enough, 32bit is ass

vocal spire Apr 16, 2021, 12:11 PM

#

I prefer never since I wouldn’t need to update mods which requires effort

primal latch Apr 16, 2021, 1:03 PM

#

jolly oriole hopefully soon enough, 32bit is ass

I agree. This would make memory management easier. 64 bit would have never caused issue for Fyremoth

steady comet Apr 16, 2021, 1:08 PM

#

C sharp question - is there a stylistic way to get a value from a dictionary, with a default if the key's not present? Something like D.get(key, default) in python

vocal spire Apr 16, 2021, 1:11 PM

#

steady comet C sharp question - is there a stylistic way to get a value from a dictionary, wi...

Idk if there’s already a method like that, but you could make an extension that does something like
if (D.ContainsKey(key))
return D[key];
return default;

copper nacelle Apr 16, 2021, 1:12 PM

#

containskey x5fiftPrime

stone elm Apr 16, 2021, 1:12 PM

#

TryGetValue

copper nacelle Apr 16, 2021, 1:12 PM

#

yeah

#

dict.TryGetValue(key, out var x) ? x : default;

steady comet Apr 16, 2021, 1:13 PM

#

I'm currently using TryGetValue but IDK it seems a bit redundant

stone elm Apr 16, 2021, 1:13 PM

#

if (dict.TryGetValue(key, out var val))
{
    //do stuff with val
}
else
{
    //key doesnt exist
}

copper nacelle Apr 16, 2021, 1:13 PM

#

.net 4 has an extension for a default value

stone elm Apr 16, 2021, 1:14 PM

#

TryGetValue is the least redundant since it affects the least number of lookups, I believe.

copper nacelle Apr 16, 2021, 1:14 PM

#

🙂

stone elm Apr 16, 2021, 1:14 PM

#

ReSharper used to yell at me for doing anything else, back when I used that

steady comet Apr 16, 2021, 1:14 PM

#

palehmm

#

I guess I'll do that then - thanks 🙂

stone elm Apr 16, 2021, 1:17 PM

#

You could also just create your own extension method. Very valid way to go about it.

copper nacelle Apr 16, 2021, 1:17 PM

#

yeah

jolly oriole Apr 16, 2021, 1:44 PM

#

primal latch I agree. This would make memory management easier. 64 bit would have never cause...

I think you pinged the one person named "No Ping Needed"

primal latch Apr 16, 2021, 1:48 PM

#

Oops

muted gust Apr 16, 2021, 3:28 PM

#

I found some skin of silksong.

jolly oriole Apr 16, 2021, 3:33 PM

#

crazy

cedar hemlock Apr 16, 2021, 7:14 PM

#

https://github.com/ricardosouzag/ModInstaller/pull/87 help the DRPC is breaking the moddingapi

torn birch Apr 17, 2021, 12:56 AM

#

How do I make FSMView work? I put the repo on github desktop and downloaded+extracted the zip, but neither one seems to work. Is there something else I should do to get it working?

copper nacelle Apr 17, 2021, 1:01 AM

#

why

#

code ≠ executable

#

unless you built it in which case the cldb needs to be in the same folder

torn birch Apr 17, 2021, 1:07 AM

#

I'm sorry, I have zero experience with this stuff whatsoever, so does this mean I need to download it as an exe then run it?

#

I'm an absolute caveman rn

copper nacelle Apr 17, 2021, 1:07 AM

#

there is a releases tab

#

on the right side of the site

torn birch Apr 17, 2021, 1:08 AM

#

ok

#

I'm there now

#

so do I download the cube icon thingy?

copper nacelle Apr 17, 2021, 1:11 AM

#

idk what this means

ornate rivet Apr 17, 2021, 1:12 AM

#

yea download the cube

torn birch Apr 17, 2021, 1:15 AM

#

ok

#

I did, now what? Do I extract it? Where should I extract it to?

ornate rivet Apr 17, 2021, 1:16 AM

#

anywhere

#

it will be a folder with a .exe file

torn birch Apr 17, 2021, 1:17 AM

#

okay, I got it to run

#

now what? It's just all a blank screen

#

well like I see all the bits of it, but I don't see any playmaker scripts

#

is it because I didn't buy playmaker or something?

light zodiac Apr 17, 2021, 1:46 AM

#

https://radiance.host/apidocs/PlayMakerFSM.html

copper nacelle Apr 17, 2021, 4:07 AM

#

https://forum.unity.com/threads/unity-future-net-development-status.1092205/

Unity Forum

Unity Future .NET Development Status

We’ve had a good bit of interest on various forum threads about Unity’s plans for C# and .NET in the future. Microsoft has been pushing the .NET...

primal latch Apr 17, 2021, 6:45 AM

#

How do you switch out the sprite atlas for the beastiary?

tepid reef Apr 17, 2021, 7:29 AM

#

How do you edit dialogue text? As in change what a character says?

steady comet Apr 17, 2021, 7:32 AM

#

tepid reef How do you edit dialogue text? As in change what a character says?

Use language hook https://radiance.host/apidocs/Hooks.html#languagegethook

primal latch Apr 17, 2021, 2:26 PM

#

How do you switch out the sprite atlas for the beastiary?

vocal spire Apr 17, 2021, 3:25 PM

#

primal latch How do you switch out the sprite atlas for the beastiary?

You don’t. You replace every spriterenderer’s sprite that uses it

primal latch Apr 17, 2021, 3:26 PM

#

ok

cedar hemlock Apr 17, 2021, 3:27 PM

#

does anybody know how to make a boss do 1 damage? part 2

light zodiac Apr 17, 2021, 3:36 PM

#

Take health hook. Return damage/2

cedar hemlock Apr 17, 2021, 3:36 PM

#

we tried that before

light zodiac Apr 17, 2021, 3:37 PM

#

and...

cedar hemlock Apr 17, 2021, 3:37 PM

#

well if it worked i wouldn't be here

light zodiac Apr 17, 2021, 3:38 PM

#

#archived-modding-development message

Iirc this is what you did last time

cedar hemlock Apr 17, 2021, 3:58 PM

#

private int damagetaken(int damage)
        {
            return (1);
        }

#

that?

light zodiac Apr 17, 2021, 4:02 PM

#

Ig

cedar hemlock Apr 17, 2021, 4:02 PM

#

lg?

#

idk what that means

dusty obsidian Apr 17, 2021, 4:03 PM

#

ig = i guess. probably

jolly oriole Apr 17, 2021, 4:03 PM

#

i guess ig

cedar hemlock Apr 17, 2021, 4:09 PM

#

light zodiac Take health hook. Return damage/2

it worked thx

#

(why didn't we (you guys(i did nothing)) come up with this earlier lol)

#

will it break overcharmed?

#

lets find out

#

yes

light zodiac Apr 17, 2021, 4:14 PM

#

Why would it?

cedar hemlock Apr 17, 2021, 4:14 PM

#

yes it will

#

look guys im doing pv overcharmed

primal latch Apr 17, 2021, 5:45 PM

#

@cedar hemlock check if the player is overcharmed

#

Using the PlayedData class

cedar hemlock Apr 17, 2021, 5:45 PM

#

I already did that

#

I know a little about coding :)

primal latch Apr 17, 2021, 5:47 PM

#

Yeah. You could have just forgotten it. In what way does it break it?

cedar hemlock Apr 17, 2021, 5:47 PM

#

Just still does 1 damage

#

Instead of 2

primal latch Apr 17, 2021, 5:48 PM

#

But you wanted to halve the damage right?

cedar hemlock Apr 17, 2021, 5:48 PM

#

Just wanted 1 instead of 2 by specific bosses

#

Dont start about selecting 1 boss as i already know that

primal latch Apr 17, 2021, 5:50 PM

#

Check the scene name? Create a list with all the scenes with bosses that you want to halve and check if that list contains the current scene

cedar hemlock Apr 17, 2021, 6:02 PM

#

cedar hemlock **Dont** start about selecting 1 boss as i already know that

B r u h

jolly oriole Apr 17, 2021, 6:03 PM

#

i mean for everything i know, changing the DamageHero components of a boss results in only that much damage taken, so ¯_(ツ)_/¯

vocal spire Apr 17, 2021, 7:58 PM

#

jolly oriole i mean for everything i know, changing the `DamageHero` components of a boss res...

Id go with this route too.

#

Overriding the damage this way makes even radiant bosses deal 1 damage

crystal topaz Apr 18, 2021, 10:17 PM

#

I was making a dark souls themed skin and when I was testing some of the sprites I noticed that the sprites were messing up a lot idk how to fix it because at first I thought that I colored a part that was supposed to be transparent but that wasn’t the case

torn birch Apr 19, 2021, 1:58 AM

#

hey, quick question, is it possible to make a script without FSMViewer to mod the game?

copper nacelle Apr 19, 2021, 1:58 AM

#

yeah

torn birch Apr 19, 2021, 1:58 AM

#

I want to add some extra events that trigger when number keys are pressed, how would I do that?

#

Would I add an extra script?

copper nacelle Apr 19, 2021, 1:59 AM

#

Least effort is just have a mod which uses HeroUpdateHook and uses Input.GetKey

torn birch Apr 19, 2021, 1:59 AM

#

ok

#

is heroUpdateHook on the playerData api doc?

copper nacelle Apr 19, 2021, 2:00 AM

#

No

torn birch Apr 19, 2021, 2:00 AM

#

what does it do?

copper nacelle Apr 19, 2021, 2:00 AM

#

It's invoked when HeroController's Update is invoked

torn birch Apr 19, 2021, 2:00 AM

#

so when a key is pressed?

copper nacelle Apr 19, 2021, 2:01 AM

#

No

#

~0-2 times per frame

torn birch Apr 19, 2021, 2:01 AM

#

ok

#

so it just registers things

#

sorry i have never made a mod previously so I have no clue what im doing

light zodiac Apr 19, 2021, 2:03 AM

#

Is there any noticable difference between hercontroller update and the normal public void update function

torn birch Apr 19, 2021, 2:04 AM

#

so the if statement would be on each heroupdatehook and then check if the key was pressed, then run the if statement?

copper nacelle Apr 19, 2021, 2:06 AM

#

light zodiac Is there any noticable difference between hercontroller update and the normal pu...

Not really, the only real difference is that it's setup for you, only runs in game, and doesn't require your own MonoBehaviour as you're just adding onto another

torn birch Apr 19, 2021, 2:07 AM

#

so the heroupdatehook is similar to the public void thing that triggers once per frame?

copper nacelle Apr 19, 2021, 2:14 AM

#

basically

light zodiac Apr 19, 2021, 2:14 AM

#

copper nacelle Not really, the only real difference is that it's setup for you, only runs in ga...

Ok thank you

fair rampart Apr 19, 2021, 2:16 AM

#

Ahahah lil lurien mask pops up when your soul comes out I’m so happy that I’m actually seeing progress in game now

#

Little mask pop

torn birch Apr 19, 2021, 2:24 AM

#

thats awesome my guy

#

good luck on ur project 🙂

fair rampart Apr 19, 2021, 2:25 AM

#

👍tysm

torn birch Apr 19, 2021, 3:07 AM

#

How do I use HeroUpdateHook?

light zodiac Apr 19, 2021, 3:11 AM

#

In public overide void initialize add this line
ModHooks.Instance.HeroUpdateHook += function name

Then let the IDE create the function for your
Then do if (Input.GetKey(Keycode.{key you want})) and then put what you want to do when button is pressed

torn birch Apr 19, 2021, 3:14 AM

#

ok

cedar hemlock Apr 19, 2021, 12:04 PM

#

is there a way to change the amount of damage of only 1 damage type?

#

for example only explosion damage?

jolly oriole Apr 19, 2021, 12:05 PM

#

there is always a way, but i'd need to check if there is an ez one

#

looking at it, you'd need to manually add things, as the damage type is basically this enum:

public enum HazardType
{
    NON_HAZARD = 0,
    NORMAL,
    SPIKES,
    ACID,
    LAVA,
    PIT
}

cedar hemlock Apr 19, 2021, 12:08 PM

#

hmm

#

lava?

jolly oriole Apr 19, 2021, 12:09 PM

#

not implemented

#

but there

cedar hemlock Apr 19, 2021, 12:09 PM

#

but no explosion grubsad

jolly oriole Apr 19, 2021, 12:09 PM

#

explosion is the normal type

cedar hemlock Apr 19, 2021, 12:10 PM

#

but if i change the damage of normal then all normal damage will change and not only explosion

jolly oriole Apr 19, 2021, 12:10 PM

#

yes

#

this is how lava is implemented

cedar hemlock Apr 19, 2021, 12:11 PM

#

is there a way to only change explosion or not?

jolly oriole Apr 19, 2021, 12:11 PM

#

let me look at an explosion object, maybe

#

found the jellyfish explosions

cedar hemlock Apr 19, 2021, 12:25 PM

#

whats it called?

jolly oriole Apr 19, 2021, 12:25 PM

#

"Gas Explosion Uumuu"

cedar hemlock Apr 19, 2021, 12:27 PM

#

and how do i make it 0?

jolly oriole Apr 19, 2021, 12:27 PM

#

On.DamageHero.Start += yourmethod;

...

private void yourmethod(orig, self)
{
    orig(self);
    if (self.transform.parent != null && self.transform.parent.gameObject.name != "Gas Explosion Uumuu") return;
    self.damageDealt = 0;
}

light zodiac Apr 19, 2021, 12:28 PM

#

whats orig(self)

jolly oriole Apr 19, 2021, 12:28 PM

#

the on hook stuff

#

didn't want to write the types

#

just wrote that directly in discord

cedar hemlock Apr 19, 2021, 12:29 PM

#

where do i place On.DamageHero.Start +=

jolly oriole Apr 19, 2021, 12:29 PM

#

constructor or initialize of your mod probably

cedar hemlock Apr 19, 2021, 12:29 PM

#

doesn't work in initialize

jolly oriole Apr 19, 2021, 12:29 PM

#

why not

cedar hemlock Apr 19, 2021, 12:30 PM

#

Error    CS0117    'DamageHero' does not contain a definition for 'Start'

jolly oriole Apr 19, 2021, 12:31 PM

#

change Start to OnEnable

#

didn't check if DamageHero had a Start method

cedar hemlock Apr 19, 2021, 12:31 PM

#

Error    CS0029    Cannot implicitly convert type 'void' to 'On.DamageHero.hook_OnEnable'

jolly oriole Apr 19, 2021, 12:32 PM

#

i mean, just write On.DamageHero.Start += yourmethod and let your ide auto complete it

deep wave Apr 19, 2021, 12:32 PM

#

did you write yourmethod() or something

cedar hemlock Apr 19, 2021, 12:32 PM

#

ok i forgot to add the thing after += xD

#

lemme try

jolly oriole Apr 19, 2021, 12:36 PM

#

Explosion gameobject names

Gas Explosion Uumuu (DH-component is on a child gameobject)
Gas Explosion Recycle L (DH-component directly on gameobject)
Gas Explosion Recycle M (DH-component directly on gameobject)

cedar hemlock Apr 19, 2021, 12:36 PM

#

hmm

#

normal contact damage does 2

#

explosions too

jolly oriole Apr 19, 2021, 12:37 PM

#

hm :/

cedar hemlock Apr 19, 2021, 12:42 PM

#

and aparently your code is stronger then the code from yesterday that made all damage 1

#

i took damage from a hidden mosswalker

vocal spire Apr 19, 2021, 12:45 PM

#

What’s your code in the hook

cedar hemlock Apr 19, 2021, 12:46 PM

#

jolly oriole ```cs On.DamageHero.Start += yourmethod; ... private void yourmethod(orig, sel...

^

jolly oriole Apr 19, 2021, 12:46 PM

#

except it's OnEnable

cedar hemlock Apr 19, 2021, 12:46 PM

#

private void explodamage(On.DamageHero.orig_OnEnable orig, DamageHero self)
        {
            orig(self);
            if (self.transform.parent != null && self.transform.parent.gameObject.name != "Gas Explosion Uumuu") return;
            self.damageDealt = 0;
        }

#

i prob did smth wrong?

vocal spire Apr 19, 2021, 12:47 PM

#

Looks right

cedar hemlock Apr 19, 2021, 12:48 PM

#

then why it broke lol

vocal spire Apr 19, 2021, 12:49 PM

#

Maybe log the damage and the parent name(log null if parent is null) to make sure everything is right?

cedar hemlock Apr 19, 2021, 12:49 PM

#

what do i log?

vocal spire Apr 19, 2021, 12:49 PM

#

...

cedar hemlock Apr 19, 2021, 12:49 PM

#

self.damageDealt?

vocal spire Apr 19, 2021, 12:49 PM

#

I just said it

#

Yes

cedar hemlock Apr 19, 2021, 12:54 PM

#

ehm

#

[INFO]:[ModManager] - Initializing
[INFO]:[ModManager] - Initialized
[INFO]:[API] - Loading ModdingApi Global Settings.

#

is all

jolly oriole Apr 19, 2021, 12:54 PM

#

are you sure your game is working?

cedar hemlock Apr 19, 2021, 12:54 PM

#

yes xD

#

this is very wierd

vocal spire Apr 19, 2021, 12:57 PM

#

What’s in the mods folder

vocal spire Apr 19, 2021, 12:58 PM

#

cedar hemlock yes xD

~~#archived-modding-help time I don’t believe you~~

cedar hemlock Apr 19, 2021, 12:59 PM

#

ok fixed it

#

i just deleted the moddingapi.globalsettings

vocal spire Apr 19, 2021, 1:00 PM

#

Fun

cedar hemlock Apr 19, 2021, 1:01 PM

#

[INFO]:[TransMod] - 0
[INFO]:[TransMod] - 0
[INFO]:[TransMod] - 0
[INFO]:[TransMod] - 0
[INFO]:[TransMod] - 0
[INFO]:[TransMod] - 0
[INFO]:[TransMod] - 0
[INFO]:[TransMod] - 0
[INFO]:[TransMod] - 0
[INFO]:[TransMod] - 0
[INFO]:[TransMod] - 0

#

seems like 0

#

i got hit 2 times

vocal spire Apr 19, 2021, 1:01 PM

#

That’s bc it’s only logging the ones being set to 0

#

You need to rewrite the if statement

cedar hemlock Apr 19, 2021, 1:02 PM

#

to?

#

wait

vocal spire Apr 19, 2021, 1:02 PM

#

Fine I’ll rewrite it

#

private void explodamage(On.DamageHero.orig_OnEnable orig, DamageHero self)
        {
            orig(self);
            if (self.transform.parent != null && self.transform.parent.gameObject.name == "Gas Explosion Uumuu") self.damageDealt = 0;
           
            Log(damageDealt + self.transform.parent ? self.transform.parent.name : null);
        }

#

Disclaimer: all code I write on discord in the next like 7 hours is written on mobile

cedar hemlock Apr 19, 2021, 1:05 PM

#

Error    CS0103    The name 'damageDealt' does not exist in the current context

vocal spire Apr 19, 2021, 1:05 PM

#

Easy fix

#

I’ll let you fix that imma go do conversation

cedar hemlock Apr 19, 2021, 1:09 PM

#

Error    CS0019    Operator '+' cannot be applied to operands of type 'Transform' and 'Transform'
``` is what i get when i ask the lightbulb

vocal spire Apr 19, 2021, 1:09 PM

#

What did you change to fix error 1?

cedar hemlock Apr 19, 2021, 1:10 PM

#

i just did what the lightbulb suggested

#

i tried all the options

vocal spire Apr 19, 2021, 1:10 PM

#

Can you send the new code

cedar hemlock Apr 19, 2021, 1:11 PM

#

private void explodamage(On.DamageHero.orig_OnEnable orig, DamageHero self)
        {
            orig(self);
            if (self.transform.parent != null && self.transform.parent.gameObject.name == "Gas Explosion Uumuu") self.damageDealt = 0;

            Log(message: damageDealt + self.transform.parent ? self.transform.parent.name : null);
        }
```is the last option

vocal spire Apr 19, 2021, 1:12 PM

#

Have you tried solving it without the lightbulb

#

I still see the first problem

#

Fine I’ll do it

jolly oriole Apr 19, 2021, 1:13 PM

#

Log($"Damage: {self.damageDealth}, Parent: '{self.transform.parent}'");

cedar hemlock Apr 19, 2021, 1:14 PM

#

what did i do wrong (or copied over wrong)?

#

just so i know how to fix later

vocal spire Apr 19, 2021, 1:15 PM

#

First problem was damageDealt was supposed to be self.damageDealt

cedar hemlock Apr 19, 2021, 1:15 PM

#

i tried that

vocal spire Apr 19, 2021, 1:16 PM

#

cedar hemlock ```cs private void explodamage(On.DamageHero.orig_OnEnable orig, DamageHero self...

This doesn’t show that

cedar hemlock Apr 19, 2021, 1:16 PM

#

no but i tried that before

#

but i got the plus error

vocal spire Apr 19, 2021, 1:16 PM

#

Then why did you change it back

cedar hemlock Apr 19, 2021, 1:16 PM

#

Error    CS0019    Operator '+' cannot be applied to operands of type 'int' and 'Transform'

#

because that

#

Log(self.damageDealt + self.transform.parent ? self.transform.parent.name : null);

vocal spire Apr 19, 2021, 1:16 PM

#

But that would result in the first error

#

Just use what grenade sent, don’t want to write more code

cedar hemlock Apr 19, 2021, 1:19 PM

#

ok the 2 damage contact damage was caused by me

#

but with the new code still 2 damage

#

[INFO]:[TransMod] - Damage: 2, Parent:

vocal spire Apr 19, 2021, 1:20 PM

#

The parent is null then

#

I think?

#

Try logging the name of the object instead of the parent

cedar hemlock Apr 19, 2021, 1:22 PM

#

whats it called

#

just "Name"?

jolly oriole Apr 19, 2021, 1:22 PM

#

just put it as self.gameObject, also logs name

cedar hemlock Apr 19, 2021, 1:22 PM

#

ok

#

this ok?

#

jolly oriole Apr 19, 2021, 1:24 PM

#

yes, maybe

around both parent and name {}, so it's easier to know if there are extra spaces at the front or back

cedar hemlock Apr 19, 2021, 1:27 PM

#

[INFO]:[TransMod] - Damage: 2, Parent: , name: Gas Explosion Recycle L(Clone) (UnityEngine.GameObject)

jolly oriole Apr 19, 2021, 1:28 PM

#

jolly oriole Explosion gameobject names ``` Gas Explosion Uumuu (DH-component is on a child g...

oh, one of these

vocal spire Apr 19, 2021, 1:28 PM

#

Check if the gameobject’s name contains(or equals) any of those

#

Then set the damage

cedar hemlock Apr 19, 2021, 1:29 PM

#

ok lemme try

jolly oriole Apr 19, 2021, 1:29 PM

#

i mean, at that point one could change the if to if (self.gameObject.name.Contains("Explosion") || (self.transform.parent != null && self.transform.parent.gameObject.name.Contains("Explosion"))) self.damageDealt = 0;

vocal spire Apr 19, 2021, 1:29 PM

#

That should do it

#

Explosives defused

cedar hemlock Apr 19, 2021, 1:30 PM

#

yeah

#

well that didn't work

vocal spire Apr 19, 2021, 1:32 PM

#

Logging?

cedar hemlock Apr 19, 2021, 1:32 PM

#

not so fast

#

just the same

#

no

vocal spire Apr 19, 2021, 1:34 PM

#

cedar hemlock ``` [INFO]:[TransMod] - Damage: 2, Parent: , name: Gas Explosion Recycle L(Clone...

Still says 2 instead of 0?

cedar hemlock Apr 19, 2021, 1:34 PM

#

[INFO]:[TransMod] - Damage: 0, Parent: , name: -Gas Explosion Recycle L(Clone) (UnityEngine.GameObject)-

#

i added the -

vocal spire Apr 19, 2021, 1:34 PM

#

It says 0 damage

cedar hemlock Apr 19, 2021, 1:34 PM

#

it says 0 but i still get hit 2

vocal spire Apr 19, 2021, 1:34 PM

#

Hmmm

#

Multiple explosion objects maybe?

cedar hemlock Apr 19, 2021, 1:35 PM

#

modlog says only that

vocal spire Apr 19, 2021, 1:35 PM

#

Show your code

cedar hemlock Apr 19, 2021, 1:35 PM

#

wait-

#

huh?

#

[INFO]:[TransMod] - Damage: 2, Parent: , name: -Lil Jellyfish(Clone) (UnityEngine.GameObject)-
[INFO]:Creating hpbar for Lil Jellyfish(Clone)
[INFO]:[EnemyHPBar] - Added hp bar to Lil Jellyfish(Clone)
[INFO]:[TransMod] - Damage: 0, Parent: , name: -Gas Explosion Recycle L(Clone) (UnityEngine.GameObject)-
[INFO]:[EnemyHPBar] - Enemy Jellyfish Baby (6) ded
[INFO]:Creating hpbar for New Game Object
[INFO]:[EnemyHPBar] - Enemy Jellyfish Baby (5) ded
[INFO]:Creating hpbar for New Game Object

#

it says damage 2 for -Lil Jellyfish(Clone) (UnityEngine.GameObject)-

vocal spire Apr 19, 2021, 1:36 PM

#

So?

cedar hemlock Apr 19, 2021, 1:37 PM

#

i add Lil Jellyfish also?

vocal spire Apr 19, 2021, 1:37 PM

#

That’s just a normal enemy

cedar hemlock Apr 19, 2021, 1:37 PM

#

but why 2

#

it only did 1

vocal spire Apr 19, 2021, 1:37 PM

#

I guess you can add it

#

Might work

jolly oriole Apr 19, 2021, 1:39 PM

#

hm, afaik lil jellyfish should just spawn the other explosion thing, but adding it might work

vocal spire Apr 19, 2021, 1:39 PM

#

Tc spaghetti code

cedar hemlock Apr 19, 2021, 1:39 PM

#

            if (self.gameObject.name.Contains("Explosion") || (self.transform.parent != null && self.transform.parent.gameObject.name.Contains("Explosion")) || self.gameObject.name.Contains("Lil Jellyfish") || (self.transform.parent != null && self.transform.parent.gameObject.name.Contains("Lil Jellyfish"))) self.damageDealt = 0;

```?

jolly oriole Apr 19, 2021, 1:40 PM

#

looks horrible but good

vocal spire Apr 19, 2021, 1:40 PM

#

Yep

cedar hemlock Apr 19, 2021, 1:40 PM

#

nice

vocal spire Apr 19, 2021, 1:40 PM

#

I’ll rewrite it more nicely

cedar hemlock Apr 19, 2021, 1:41 PM

#

while you do it i try if it works

jolly oriole Apr 19, 2021, 1:42 PM

#

it works

cedar hemlock Apr 19, 2021, 1:42 PM

#

yep

jolly oriole Apr 19, 2021, 1:42 PM

#

the flying fucks already have 2 damage

#

the explosion doesn't even damage you because of iframes

vocal spire Apr 19, 2021, 1:43 PM

#

if (self.name.Contains(“Explosion”) || self.name.Contains(“Lil Jellyfish) || (self.transform.parent != null && (self.transform.parent.name.Contains(“Explosion”) || self.transform.parent.name.Contains(“Lil Jellyfish”))))

cedar hemlock Apr 19, 2021, 1:44 PM

#

lol

vocal spire Apr 19, 2021, 1:44 PM

#

Well discord ruined it

#

Also replace quotes with your quotes since mobile bad

cedar hemlock Apr 19, 2021, 1:45 PM

#

if (self.name.Contains("Explosion") || self.name.Contains("Lil Jellyfish") || (self.transform.parent != null &&  (self.transform.parent.name.Contains("Explosion") || self.transform.parent.name.Contains("Lil Jellyfish"))))

vocal spire Apr 19, 2021, 1:46 PM

#

Looks right

#

Slightly shorter than yours

cedar hemlock Apr 19, 2021, 1:46 PM

#

slightly

cedar hemlock Apr 19, 2021, 2:32 PM

#

ok got it into a charm thx for the help

cedar hemlock Apr 19, 2021, 2:52 PM

#

is there a way to detect when uumuu is defeated?

potent dirge Apr 19, 2021, 3:09 PM

#

I believe there's a boolean for it, yea

#

if you check in debugmod there's an example of it being used in the bosshandler/respawn boss in this scene func

cedar hemlock Apr 19, 2021, 3:41 PM

#

i cant find anything

steady comet Apr 19, 2021, 3:42 PM

#

PlayerData.Instance.GetBool(nameof(PlayerData.killedMegaJellyfish))

cedar hemlock Apr 19, 2021, 3:42 PM

#

thx

steady comet Apr 19, 2021, 3:43 PM

#

(or something like that)

covert cosmos Apr 19, 2021, 4:00 PM

#

how do I mod hollow knight ? I just want to change text

cedar hemlock Apr 19, 2021, 4:01 PM

#

you want to change text for a mod or just want to change text only for you?

covert cosmos Apr 19, 2021, 4:01 PM

#

changing every single soul into soup

jolly jungle Apr 19, 2021, 4:01 PM

#

lmao

covert cosmos Apr 19, 2021, 4:01 PM

#

on the base game

cedar hemlock Apr 19, 2021, 4:01 PM

#

hmm

#

can be done without making a mod but will take time

covert cosmos Apr 19, 2021, 4:02 PM

#

like, the charm would be call Soup Catcher

jolly jungle Apr 19, 2021, 4:02 PM

#

Pretty sure you can check for strings you get, then parse them for Soul and replace

cedar hemlock Apr 19, 2021, 4:02 PM

#

but i have no idea how to change text via a mod

jolly jungle Apr 19, 2021, 4:02 PM

#

Pretty sure you can check for strings you get, then parse them for Soul and replace

#

Use the language hook

covert cosmos Apr 19, 2021, 4:02 PM

#

where are strings ?

jolly jungle Apr 19, 2021, 4:03 PM

#

Language hook gives you every string as it's displayed

#

There may be a more efficient way

#

But right now I'd just use that, get every string, and look for "soul" in them and replace with "soup"

covert cosmos Apr 19, 2021, 4:04 PM

#

so I should go on the games files ?$

jolly jungle Apr 19, 2021, 4:04 PM

#

What

#

No

#

Here

#

https://radiance.host/apidocs

#

This here explains all you need to start making a mod, in general

covert cosmos Apr 19, 2021, 4:04 PM

#

tysm

jolly jungle Apr 19, 2021, 4:04 PM

#

And this https://radiance.host/apidocs/Hooks.html#languagegethook

#

Is the language hook I'm referring to

covert cosmos Apr 19, 2021, 4:11 PM

#

there is, I guess, a way to convert those into a .dll file

Capture_decran_2021-04-19_a_18.10.59.png

cedar hemlock Apr 19, 2021, 4:12 PM

#

you have to have an IDE

#

google it

#

idk if vs works on mac

covert cosmos Apr 19, 2021, 4:12 PM

#

if not ?

cedar hemlock Apr 19, 2021, 4:13 PM

#

use a different one

#

vs is just a IDE

light zodiac Apr 19, 2021, 4:14 PM

#

Open the sln file, add the references and compile

covert cosmos Apr 19, 2021, 4:14 PM

#

with what do I open it ?

cedar hemlock Apr 19, 2021, 4:15 PM

#

an IDE

covert cosmos Apr 19, 2021, 4:15 PM

#

oh

#

ok

cedar hemlock Apr 19, 2021, 4:15 PM

#

wait a sec

covert cosmos Apr 19, 2021, 4:15 PM

#

I'm waiting

cedar hemlock Apr 19, 2021, 4:15 PM

#

https://nl.lmgtfy.app/#gsc.tab=0&gsc.q=IDE for Mac

covert cosmos Apr 19, 2021, 4:15 PM

#

ty

#

wtf

#

oh hopefully there are versions else than nederland for languages

cedar hemlock Apr 19, 2021, 4:16 PM

#

grimmpalm

light zodiac Apr 19, 2021, 4:17 PM

#

Just Google IDE for mac

cedar hemlock Apr 19, 2021, 4:17 PM

#

im very smort

jolly jungle Apr 19, 2021, 4:18 PM

#

lmao ruttie zotewheeze

covert cosmos Apr 19, 2021, 4:18 PM

#

you died

#

killed by uumuu ?

#

I'm very smart : Ik how to read

jolly jungle Apr 19, 2021, 4:19 PM

#

Oh right it's that cool add on that kaan made

#

Well, it's a mod, technically

cedar hemlock Apr 19, 2021, 4:20 PM

#

im trying to get when uumuu dies

jolly jungle Apr 19, 2021, 4:20 PM

#

Wdym?

cedar hemlock Apr 19, 2021, 4:20 PM

#

im trying to log when uumuu dies

#

i was being stupid

#

made a stupid error

jolly jungle Apr 19, 2021, 4:21 PM

#

As in, when during the animation?

cedar hemlock Apr 19, 2021, 4:21 PM

#

just if uumuu is dead

jolly jungle Apr 19, 2021, 4:21 PM

#

oh lmao

#

What are you gonna use it for?

light zodiac Apr 19, 2021, 4:21 PM

#

Mod

cedar hemlock Apr 19, 2021, 4:21 PM

#

giving the player a charm

jolly jungle Apr 19, 2021, 4:21 PM

#

Ah, cool

cedar hemlock Apr 19, 2021, 4:21 PM

#

it worked

#

now its spamming my modlog

jolly jungle Apr 19, 2021, 4:22 PM

#

Woo, nice hollowknice

covert cosmos Apr 19, 2021, 4:22 PM

#

2 geo

#

omg

jolly jungle Apr 19, 2021, 4:22 PM

#

cedar hemlock now its spamming my modlog

shroompog zotewheeze

cedar hemlock Apr 19, 2021, 4:22 PM

#

oh god

covert cosmos Apr 19, 2021, 4:22 PM

#

you killed an explosive jellyfish

cedar hemlock Apr 19, 2021, 4:22 PM

#

need to close the game quick

covert cosmos Apr 19, 2021, 4:23 PM

#

58 minutes remaining$

#

dont mind the $ at the end of my messages btw

covert cosmos Apr 19, 2021, 4:25 PM

#

covert cosmos there is, I guess, a way to convert those into a .dll file

is there a way to do the opposite of that ?

cedar hemlock Apr 19, 2021, 4:26 PM

#

what you have there is the opposite of an .dll

light zodiac Apr 19, 2021, 4:26 PM

#

Dnspy

cedar hemlock Apr 19, 2021, 4:26 PM

#

ohno

#

if (uuwuugone != 0)
            {
                ModHooks.Instance.HeroUpdateHook += uumuu;
            }

#

what do i do wrong

covert cosmos Apr 19, 2021, 4:27 PM

#

I want to turn a .dll mod into a folder, a .sln etc.

deep wave Apr 19, 2021, 4:27 PM

#

dnspy or ilspy

cedar hemlock Apr 19, 2021, 4:27 PM

#

but you have the .sln already

#

just search for the source code on github

deep wave Apr 19, 2021, 4:28 PM

#

if you already have project files, you can compile those into a .dll
if you need to look at a dll (mainly assembly-csharp.dll) to understand how the game works, dnspy is pretty good

covert cosmos Apr 19, 2021, 4:30 PM

#

the emote is named flag_ug btw

#

I want to get the non .dll file of Howwow kwnight

cedar hemlock Apr 19, 2021, 4:30 PM

#

search for howwow on github

covert cosmos Apr 19, 2021, 4:31 PM

#

didn't work

cedar hemlock Apr 19, 2021, 4:31 PM

#

it not on github hornetshock

covert cosmos Apr 19, 2021, 4:32 PM

#

sad

cedar hemlock Apr 19, 2021, 4:33 PM

#

why is it spamming my modlog!?

#

if (uuwuugone == false)
            {
                ModHooks.Instance.HeroUpdateHook += uumuu;
            }
...
private void uumuu()
        {
            if (PlayerData.instance.GetBool(nameof(PlayerData.killedMegaJellyfish)) == true)
            {
                uuwuugone = true;
                Log("uumuugone?");
                Log(uuwuugone);
            }
        }

#

what did i do wrong

jolly jungle Apr 19, 2021, 4:34 PM

#

cedar hemlock ``` if (uuwuugone != 0) { ModHooks.Instance.HeroUpda...

Where is this palehmm

cedar hemlock Apr 19, 2021, 4:34 PM

#

the if?

light zodiac Apr 19, 2021, 4:34 PM

#

You could just do a normal hero update Hook and in the hook check for uuwuu

cedar hemlock Apr 19, 2021, 4:35 PM

#

in initialize

light zodiac Apr 19, 2021, 4:35 PM

#

Not other way around

jolly jungle Apr 19, 2021, 4:35 PM

#

Oh, alright

#

And when is heroupdatehook called?

jolly oriole Apr 19, 2021, 4:35 PM

#

jolly jungle And when is heroupdatehook called?

look at the api docs, every frame

jolly jungle Apr 19, 2021, 4:36 PM

#

Uh
So, what this does is supposed to just spam logs, right?

#

Until uumuu is killed

cedar hemlock Apr 19, 2021, 4:36 PM

#

ok so i have at the start just bool uuwuugone = false;, then if it is still false then i do ModHooks.Instance.HeroUpdateHook += uumuu; but when i make it true in private void uumuu it just keeps doing ModHooks.Instance.HeroUpdateHook += uumuu;

jolly jungle Apr 19, 2021, 4:36 PM

#

I think

cedar hemlock Apr 19, 2021, 4:37 PM

#

but when uumuu dies it still spams

jolly jungle Apr 19, 2021, 4:37 PM

#

wait there's a thing in playerdata called killedmegajellyfish?

cedar hemlock Apr 19, 2021, 4:37 PM

#

but while doing Log(uuwuugone); it says its true

jolly jungle Apr 19, 2021, 4:37 PM

#

Oh I know

#

ou don't remove the hook

#

No?

#

Unless that's not what you asked

#

Anyways gtg, brb

cedar hemlock Apr 19, 2021, 4:38 PM

#

i want that when uumuu dies the ModHooks.Instance.HeroUpdateHook += uumuu; stops

#

but why does it not stop

#

when uuwuugone is true

floral furnace Apr 19, 2021, 4:39 PM

#

you have to unhook it i think

cedar hemlock Apr 19, 2021, 4:40 PM

#

what is unhook

#

and how

floral furnace Apr 19, 2021, 4:40 PM

#

ModHooks.Instance.HeroUpdateHook -= uumuu

cedar hemlock Apr 19, 2021, 4:40 PM

#

ah

floral furnace Apr 19, 2021, 4:40 PM

#

detaches itself from your method

#

that bool does nothing for your method hook

jolly jungle Apr 19, 2021, 4:43 PM

#

Good luck ruttie sethsalute

cedar hemlock Apr 19, 2021, 4:45 PM

#

it did nothing

light zodiac Apr 19, 2021, 5:03 PM

#

Check if the charm is gotten and then make uuwuugone false

vocal spire Apr 19, 2021, 6:33 PM

#

cedar hemlock it did nothing

Show your new code

cedar hemlock Apr 19, 2021, 6:33 PM

#

i just did it differently

#

i just did

 if (PlayerData.instance.GetBool(nameof(PlayerData.killedMegaJellyfish)) == true && uuwuugone == false)
            {

light zodiac Apr 19, 2021, 6:34 PM

#

light zodiac Check if the charm is gotten and then make uuwuugone false

So this worked?

cedar hemlock Apr 19, 2021, 6:34 PM

#

cedar hemlock i just did ``` if (PlayerData.instance.GetBool(nameof(PlayerData.killedMegaJel...

never tried that since ^this^ solution worked

cedar hemlock Apr 19, 2021, 7:37 PM

#

how does a mod "fail to load"

#

like, what are the criteria

#

because HKMP does not work without modcommon, but does not fail to load

jolly oriole Apr 19, 2021, 7:42 PM

#

cedar hemlock how does a mod "fail to load"

crash during initialize

cedar hemlock Apr 19, 2021, 7:43 PM

#

ok

copper nacelle Apr 19, 2021, 7:46 PM

#

modcommon ax2uC

cedar hemlock Apr 19, 2021, 7:59 PM

#

it will be changed to vasi later (or all dependancies will be removed)

jolly oriole Apr 19, 2021, 8:11 PM

#

fsmutil 6.0, or are there then 7?

torn birch Apr 19, 2021, 9:21 PM

#

how could I revive a boss?

copper nacelle Apr 19, 2021, 9:21 PM

#

Depends on the boss

#

Debug has a feature you could take a look at for most bosses

#

Generally it falls into one of two categories

#

You set a bool or you change a SceneData element

torn birch Apr 19, 2021, 9:21 PM

#

ok

#

what about False Knight?

copper nacelle Apr 19, 2021, 9:22 PM

#

https://github.com/fifty-six/HollowKnight.DebugMod/blob/master/Source/BossHandler.cs#L52

torn birch Apr 19, 2021, 9:23 PM

#

okay, looks good! Thanks!

#

so line 52 is for False Knight? Each subsequent line is the next boss?

#

Am I seeing that right>

copper nacelle Apr 19, 2021, 9:26 PM

#

Yeah

#

This one sets a bool on an fsm

torn birch Apr 19, 2021, 9:28 PM

#

ok, I think

#

so if it was false, false knight would be dead, if not, he would drop down and fight the player?

#

Sorry if I'm a bit slow

covert cosmos Apr 19, 2021, 10:09 PM

#

The download of the ISE finally finished !

torn birch Apr 19, 2021, 10:18 PM

#

Nice!

#

What IDE should I use for modding?

#

Is there a specific one?

#

I've been using Notepad++

copper nacelle Apr 19, 2021, 10:23 PM

#

Visual Studio Community or Rider is what I'd recommend

#

VS Code also works though it's more lightweight

torn birch Apr 19, 2021, 10:27 PM

#

alright

#

I'll use VSC for now

#

Is there any starting lines I need before I start the script?

copper nacelle Apr 19, 2021, 10:29 PM

#

Not really

#

You'll end up needing usings

torn birch Apr 19, 2021, 10:35 PM

#

Just the three unity usually gives, right?

copper nacelle Apr 19, 2021, 10:37 PM

#

idk what unity gives ngl

torn birch Apr 19, 2021, 10:37 PM

#

oh

#

nvm then

#

where whould I save it?

#

Does it get saved under HK?

copper nacelle Apr 19, 2021, 10:42 PM

#

what

#

You put your compiled dll in the Mods folder

torn birch Apr 19, 2021, 10:44 PM

#

ok

torn birch Apr 19, 2021, 11:00 PM

#

how do I change the players position, like move them to a different room or reposition them within the room they're in?

copper nacelle Apr 19, 2021, 11:02 PM

#

HeroController.instance.transform.position

torn birch Apr 19, 2021, 11:03 PM

#

ok

#

Where can I find names for all the rooms in the code?

copper nacelle Apr 19, 2021, 11:05 PM

#

you don't

#

they're pinned though

torn birch Apr 19, 2021, 11:08 PM

#

ok

#

which pinned message? Also, how do I change the player's soul meter?

#

And also, how would I change the bossData for False Knight?

#

To make it so it will be true and revive him if he's been defeated previously

lost bear Apr 20, 2021, 12:34 AM

#

A'ight my thing got lost in the other chat,, so hopefully this is a better place to ask..

I'm making a custom knight, and would like some help on how to keep an edit to the outline consistent- like how to not make something jitter between frames

#

#

Gonna make him some little wings or somethin, still deciding on how exactly to make them, but..

#

Really just need help gettin started

copper nacelle Apr 20, 2021, 12:35 AM

#

you probably want SpritePacker

#

https://youtu.be/Rb8_Qvtdco0

YouTube

Bob Fred

Hollow Knight | Sample Custom Knight Workflow Using Krita and Sprit...

An example of a workflow for creating Hollow Knight custom knight skins using Krita and SpritePacker by Magegihk.

Download Krita: https://krita.org/en/download/krita-desktop/
Download Spritepacker: https://github.com/magegihk/HollowKnight.SpritePacker/releases

Music: In a Sentimental Mood, Duke Ellington & John Coltrane

▶ Play video

lost bear Apr 20, 2021, 12:35 AM

#

Gonna check that out real quick

#

I'll have to download that stuff, then. How do they get all the frames to be like that?

#

All I have is the whole sheet, and there's no way they cropped every single frame

#

thkhands

#

Unless they did but god I hope not

#

#

Or do you select one of those animations and just

#

Hmm

dusty obsidian Apr 20, 2021, 12:56 AM

#

@lost bear i downloaded sprites from this video. animations are grouped in folders https://www.youtube.com/watch?v=B3bV9SFryfg&feature=youtu.be

YouTube

InkScarlet alias l'Encre Écarlate

How make Hollow Knight's skins with SpritePacker (active the subtit...

ENG
You asked me a lot of times how I do skins so I decided to make a video about it.
I used Google Translate because the english is not my language.

SpritePacker: https://drive.google.com/open?id=1L0MNDMQE6s40zVF132zjwYjc-bSaBYDv
Sprite folder: https://drive.google.com/drive/folde...

▶ Play video

lost bear Apr 20, 2021, 12:57 AM

#

thank you!

dusty obsidian Apr 20, 2021, 12:57 AM

#

eg. this is the dash folder

lost bear Apr 20, 2021, 12:57 AM

#

that'll help a lot

#

which folders should I download for a reskin of just the knight? there's a lot of folders here wow

#

not doing any of the magics right now or any of that

#

~~some of them don't say knight, then have the knight hiding in there~~

dusty obsidian Apr 20, 2021, 1:02 AM

#

i think? most people focus on the Knight folder first

lost bear Apr 20, 2021, 1:02 AM

#

alright, I just saw that one and... that's a big folder lmao

#

thanks a bunch

#

:D

dusty obsidian Apr 20, 2021, 1:02 AM

#

i know OTL

#

:^)

lost bear Apr 20, 2021, 1:03 AM

#

wonder what I should change on the boyye

#

wings are one idea..

#

another was like, tiny fluffy wings and a halo, or..

#

so many possibilities agh

#

well, I appreciate your help! I'll prolly pop by again once I get the hang of this stuff and figure out what I'm gonna do.

lost bear Apr 20, 2021, 2:05 AM

#

ok.. once again need a little help, agh

#

#

it wanted sprites in there, so I did that

#

#

it's all the "knight" folder sprites

#

renamed "knight" --> "sprites" because the spritepacker was looking for a "sprites" location

#

but now spritepacker just isn't opening for me

#

confused

#

Should I have downloaded the entire, bigger sprite folder, with every folder of sprites?

copper nacelle Apr 20, 2021, 2:11 AM

#

the people in modding-discussion prob know better ngl

#

skin dev is usually over there

lost bear Apr 20, 2021, 2:13 AM

#

I'll see if they can glance here then, and ask there in the future

copper nacelle Apr 20, 2021, 2:15 AM

#

thanks

lost bear Apr 20, 2021, 2:15 AM

#

thank you too ;w;

torn birch Apr 20, 2021, 2:40 AM

#

which pinned message has the names of the rooms in the game?

#

Also, how do I change the player's soul meter?
And also also, how would I change the bossData bool for False Knight?
To make it so it will be true should revive him if he's been defeated previously, right?

light zodiac Apr 20, 2021, 2:41 AM

#

torn birch which pinned message has the names of the rooms in the game?

torn birch Apr 20, 2021, 2:42 AM

#

ok.

light zodiac Apr 20, 2021, 2:42 AM

#

torn birch Also, how do I change the player's soul meter? And also also, how would I change...

Hercontroller.instance.AddMPCharge

torn birch Apr 20, 2021, 2:43 AM

#

I'm an absolute moron for not seeing that scenes thing lmao

copper nacelle Apr 20, 2021, 2:43 AM

#

i prefer the literal list ngl

#

b

torn birch Apr 20, 2021, 2:44 AM

#

what app is good for viewing rar on windows?

light zodiac Apr 20, 2021, 2:44 AM

#

Google?

copper nacelle Apr 20, 2021, 2:44 AM

#

7zip

torn birch Apr 20, 2021, 2:44 AM

#

ok

#

also is it herocontroller or hercontroller?

copper nacelle Apr 20, 2021, 2:50 AM

#

hero

torn birch Apr 20, 2021, 3:13 AM

#

ok

#

thx

fair rampart Apr 20, 2021, 4:51 AM

#

Let’s goo I found out which sprite that kept showing up as unedited . So with that one sprite edited the standing still animation has come to a complete shroompog

dusty obsidian Apr 20, 2021, 5:33 AM

#

hell yea!

fair rampart Apr 20, 2021, 5:42 AM

#

We have officially reached progress zote

lost bear Apr 20, 2021, 5:43 AM

#

omg that's too cute

cedar hemlock Apr 20, 2021, 7:12 AM

#

https://github.com/ricardosouzag/ModInstaller/pull/89 this one being reviewed would be nice

#

it fixes the "sequence contains no matching element" error (if this fix works ofc)

cedar hemlock Apr 20, 2021, 7:24 AM

#

torn birch To make it so it will be true and revive him if he's been defeated previously

debugmod has an respawn boss function

jolly oriole Apr 20, 2021, 7:26 AM

#

copper nacelle Debug has a feature you could take a look at for most bosses

i think so

cedar hemlock Apr 20, 2021, 7:28 AM

#

why did he ask it again then xD
then im just giving irrelevant info :elderC:

covert cosmos Apr 20, 2021, 9:48 AM

#

UH

#

I have IntelliJ IDEA installed

#

namespace is the name of the mod right ?

jolly oriole Apr 20, 2021, 9:55 AM

#

covert cosmos I have IntelliJ IDEA installed

isn't that a java ide?

covert cosmos Apr 20, 2021, 10:00 AM

#

it works for C# as well

#

is there a way to find the non dll file for this mod ? (folder+readme+license+sln file)

deep wave Apr 20, 2021, 10:02 AM

#

you could ask gradow for the source

#

they might also have it on their github

#

otherwise you can decompile

covert cosmos Apr 20, 2021, 10:03 AM

#

deep wave otherwise you can decompile

how ?

covert cosmos Apr 20, 2021, 10:05 AM

#

deep wave they might also have it on their github

and no, Gradow's github doesn't have any public repositories

cedar hemlock Apr 20, 2021, 10:15 AM

#

use
```cs
_ _
```

covert cosmos Apr 20, 2021, 10:16 AM

#

where ?

cedar hemlock Apr 20, 2021, 10:16 AM

#

when putting in code

#

way better

#

🇳🇱

#

no deutch

#

i dont get why you put flags everywhere but if you do do the right flag

#

now it looks like im talking to air sadcowgrub

covert cosmos Apr 20, 2021, 10:23 AM

#

cedar hemlock now it looks like im talking to air <:sadcowgrub:594102870966665216>

you are

light zodiac Apr 20, 2021, 10:24 AM

#

Remove the display this text

covert cosmos Apr 20, 2021, 10:25 AM

#

oh shit ye

#

what

#

oh I sent the wrong one

#

{
    public class SoupMod : Mod
    {
        public SoupMod() : base("SoupMod") { }

        public string LanguageGet( string key, string sheet )
        {
            if( key == "Soul" )
                return "Soup";
            return Language.GetInternal(key, sheet);
        }

        public string LanguageGet( string key, string sheet )
        {
            return "Soul" + key + "Soup" + Language.GetInternal(key, sheet);
        }

        }
    }
}```

#

so 'LanguageGet' is supposed to find on the game's text if there are "Soul" written and replace it by "Soup" ? or I'm totally wrong

deep wave Apr 20, 2021, 10:28 AM

#

covert cosmos and no, Gradow's github doesn't have any public repositories

considering gradow owns the modinstaller repo i find that hard to believe thonkeline

covert cosmos Apr 20, 2021, 10:29 AM

#

I didn't found the good Gradow I guess

deep wave Apr 20, 2021, 10:29 AM

#

https://github.com/ricardosouzag/translationmod would you look at that zote

covert cosmos Apr 20, 2021, 10:29 AM

#

ok the name wasn't gradow

#

ok it doesn't help me at all hollowsad

cedar hemlock Apr 20, 2021, 10:33 AM

#

why the embed

#

it takes up my whole screen lol

covert cosmos Apr 20, 2021, 11:10 AM

#

covert cosmos so 'LanguageGet' is supposed to find on the game's text if there are "Soul" writ...

nobody knows ?

potent dirge Apr 20, 2021, 11:14 AM

#

I don't know how languageget works, but ngl that looks very not right in slightest ax2uHmm

jolly jungle Apr 20, 2021, 11:15 AM

#

fair rampart We have officially reached progress <:zote:562358113374568477>

Eyoooo that's cute af, also next time post it in #modding-discussion

jolly jungle Apr 20, 2021, 11:16 AM

#

covert cosmos ```namespace SoupMod { public class SoupMod : Mod { public SoupM...

Hm, This seems off

#

key is the name of the string, you use that to get the string itself with Language.GetInternal(key, sheet)

#

What you need to do is call getinternal and stuff the string in a variable (for convenience), then you start parsing the string for "soul" and replace those with "soup", then return the final string

#

If this is confusing I'll try to explain again

#

Also I might be using the word parse wrong

covert cosmos Apr 20, 2021, 11:20 AM

#

hm

#

and how can I parse the string ?

potent dirge Apr 20, 2021, 11:22 AM

#

with google peepoArrive

#

and then you ask more if you can't figure out suggested solutions that already exist, for any reason (it makes no sense, it's outdated, it isn't compatible with the hk .net version, etc, anything)

#

(sorry if this came across as rude, but trust me, it will help a ton for individual understanding and problem solving to learn how to Google problems properly)

covert cosmos Apr 20, 2021, 11:32 AM

#

also there was one } too much

torn birch Apr 20, 2021, 2:43 PM

#

I see in the code there's a bool for FK in the debug mod. If I change it to true, would he respawn?

jolly jungle Apr 20, 2021, 2:57 PM

#

Depends what the bool does

#

Try and find out

cedar hemlock Apr 20, 2021, 3:00 PM

#

public List<bool> gotCharms = new List<bool>() { true, true, true, true };

#

how do i change only 1 of these

#

i only want the 2nd one to be true or false without touching the other ones

#

i cant just do

bool lala = true
...
public List<bool> gotCharms = new List<bool>() { true, lala, true, true };

copper nacelle Apr 20, 2021, 3:03 PM

#

gotCharms[1]

dark wigeon Apr 20, 2021, 3:03 PM

#

can't do gotCharms[1] = blah?

stone elm Apr 20, 2021, 3:04 PM

#

It sounds like you're capable of editing the list initializer, so why not just put false there? Am I missing something maybe?

cedar hemlock Apr 20, 2021, 3:05 PM

#

if i were to just change it to false all the other ones will also be forced the one i have in the new one

stone elm Apr 20, 2021, 3:06 PM

#

That didn't make sense to me, but if you just change the second to false it will not affect the others after list initialization.

#

new List<bool>() { true, false, true, true };
Does not affect the other list items.

cedar hemlock Apr 20, 2021, 3:07 PM

#

not?

#

won't it make the 1st, 3rd and 4th ones true?

stone elm Apr 20, 2021, 3:08 PM

#

No, it's a new list being initialized. That code is functionally (and literally, once compiled) the same as

gotCharms = new List<bool>();
gotCharms.Add(true);
gotCharms.Add(false);
gotCharms.Add(true);
gotCharms.Add(true);