#archived-modding-development | Hollow Knight | Page 511

cedar hemlock Apr 7, 2021, 12:30 PM

#

prob with cap

steady comet Apr 7, 2021, 12:30 PM

#

If you want to be sure then do what 𓁿 said

rough pulsar Apr 7, 2021, 12:30 PM

#

hmmmmmmm

cedar hemlock Apr 7, 2021, 12:30 PM

#

just say mulhima lol

rough pulsar Apr 7, 2021, 12:30 PM

#

oki

light zodiac Apr 7, 2021, 12:30 PM

#

there's also a end credits scene

rough pulsar Apr 7, 2021, 12:31 PM

#

End_Credits right

steady comet Apr 7, 2021, 12:38 PM

#

Actually, what you could do is download Benchwarp, turn on Show Room Names in the settings and it'll show the room name in the bottom left of the screen

light zodiac Apr 7, 2021, 12:50 PM

#

does it also show for endings?

light zodiac Apr 7, 2021, 12:50 PM

#

rough pulsar End_Credits right

yea but in caps

rough pulsar Apr 7, 2021, 12:52 PM

#

i added the endings strings

#

the ones i didn't add was end_credits, mrmushroom scene and stag travel

light zodiac Apr 7, 2021, 12:53 PM

#

oh wait, dont hook onto this, use SceneChanged and log target scene

vocal spire Apr 7, 2021, 12:53 PM

#

~~Ah yes, language gets scene names~~

light zodiac Apr 7, 2021, 12:54 PM

#

i am very smart thank you

jolly oriole Apr 7, 2021, 1:01 PM

#

could also just dump scene names from the global managers

copper nacelle Apr 7, 2021, 1:02 PM

#

do be already pinned

jolly oriole Apr 7, 2021, 1:09 PM

#

with the amount of question regarding scene names, i don't think that it's pinned

#

but i also refuse to check

copper nacelle Apr 7, 2021, 1:10 PM

#

elderC

rough pulsar Apr 7, 2021, 1:13 PM

#

what about it

#

i'm adding one more functionality someone suggested: customizable strings

#

though i'm making them with keywords but i'll give them very unusual names

light zodiac Apr 7, 2021, 1:20 PM

#

customizable strings?

rough pulsar Apr 7, 2021, 1:20 PM

#

like

#

you can customize and add something so like

#

you can add anything next to the room you're in

#

"Colosseum of Fools (doing the funny challenge)"

#

instead of just

#

"Colosseum of Fools"

#

I am writing the guide first because that's the time I can set keywords for value displays

rough pulsar Apr 7, 2021, 1:39 PM

#

i'm going to add everything i can zote

jolly oriole Apr 7, 2021, 1:45 PM

#

wth are those abreviations

rough pulsar Apr 7, 2021, 1:45 PM

#

the ones after the horizontal line won't be used much so i seperated them

jolly oriole Apr 7, 2021, 1:46 PM

#

you could've started those with m_ or something

rough pulsar Apr 7, 2021, 1:46 PM

#

hmmm

#

suree

#

now that i have that idea

#

i might give them proper names

#

it looks... way cleaner

light zodiac Apr 7, 2021, 1:52 PM

#

rough pulsar i'm going to add everything i can <:zote:562358113374568477>

forcing people to read the readme. nice

rough pulsar Apr 7, 2021, 1:52 PM

#

no.

#

its not in the main readme or anything

#

also

#

uh adding those are entirely optional

#

people can choose whether they want custom strings or not

#

it will still function normally

rough pulsar Apr 7, 2021, 1:54 PM

#

light zodiac forcing people to read the readme. nice

wdym "forcing people to read the readme"

#

also

#

the readme is only for installation guide

light zodiac Apr 7, 2021, 1:54 PM

#

where do you have to put these values

rough pulsar Apr 7, 2021, 1:54 PM

#

in the modsettings

#

which will only be used for custom strings

#

entirely optional

#

zote

rough pulsar Apr 7, 2021, 1:56 PM

#

light zodiac where do you have to put these values

if you don't put the values in the modsettings it will work fine too

#

so uh question

#

in ModSettings based class it sets the values loaded from the modsettings file right

#

oh wait i think i get it nvm

#

nvm i give up

light zodiac Apr 7, 2021, 2:23 PM

#

Whats the problem?

copper nacelle Apr 7, 2021, 2:24 PM

#

me when i wake up in the morning

rough pulsar Apr 7, 2021, 2:25 PM

#

hm

#

is there an alternative to HeroUpdateHook that uh

#

runs every frame even if the knight isn't there?

#

and is there any way to detect if the knight object exists

copper nacelle Apr 7, 2021, 2:26 PM

#

just add your own monobehaviour to a gameobject you instantiate and set as dontdestroyonload

#

check if HeroController.instance is/isn't null

rough pulsar Apr 7, 2021, 2:26 PM

#

oki

#

luckily visual studio gives me sum stuff related to unityengine when i do funny stuff shroompog

#

wait how do you make C# events again

#

let me google it up

jolly oriole Apr 7, 2021, 2:39 PM

#

copper nacelle check if HeroController.instance is/isn't null

Just please dont to this in a coroutine

copper nacelle Apr 7, 2021, 2:40 PM

#

prob check unsafeInstance or w/e

solemn rivet Apr 7, 2021, 2:40 PM

#

jolly oriole Just please dont to this in a coroutine

do it, I dare you

copper nacelle Apr 7, 2021, 2:41 PM

#

yeah checking .UnsafeInstance in a coro should be fine

#

the issue is with the other one

#

because that does FindObjectOfType every frame

#

ax2uHappy

solemn rivet Apr 7, 2021, 2:42 PM

#

findobjects in general are no good anyways

jolly oriole Apr 7, 2021, 2:42 PM

#

I mean, having them once in Start or awake is fine

solemn rivet Apr 7, 2021, 2:43 PM

#

yeah

#

once or twice is fine

#

but every frame

jolly oriole Apr 7, 2021, 2:43 PM

#

Utterly decimates frames

solemn rivet Apr 7, 2021, 2:43 PM

#

tru

rough pulsar Apr 7, 2021, 2:59 PM

#

i made funny rpc mod into toggleable

#

funny

#

when you toggle it off it will just do........ one thing

#

jolly oriole Apr 7, 2021, 3:00 PM

#

RIP discord, idk when - 2021

rough pulsar Apr 7, 2021, 3:01 PM

#

discord, more like
disposed

solemn rivet Apr 7, 2021, 3:02 PM

#

that's what happens when microsoft buys you

rough pulsar Apr 7, 2021, 3:02 PM

#

fuck

#

more funny error messages.

#

more funny error messages.

jolly oriole Apr 7, 2021, 3:03 PM

#

what would happen if facebook buys discord?

rough pulsar Apr 7, 2021, 3:03 PM

#

WHOA

rough pulsar Apr 7, 2021, 3:03 PM

#

jolly oriole what would happen if facebook buys discord?

add "display facebook friends"

#

or "invite facebook friends"

jolly oriole Apr 7, 2021, 3:04 PM

#

i heard that the toggle thing during gameplay displays the toggleable mods differently than that on the main menu

rough pulsar Apr 7, 2021, 3:04 PM

#

yeah.....

#

it does

jolly oriole Apr 7, 2021, 3:04 PM

#

and there's no need to @ me, i will read every single message here

#

... sooner or later

rough pulsar Apr 7, 2021, 3:05 PM

#

i know

#

hmmmm

#

oh shit

#

i forgot to initialize the RPC

#

that's why it's not working zote

#

fricc

#

errr

#

i mean

#

i didn't institiate the gameobject

#

DANGIT

#

not what i wanted to display

#

:')

#

OH WAIT I CHECKED IF PLAYERDATA WAS NULL

#

not the HeroController

#

am stupid af

jolly oriole Apr 7, 2021, 3:12 PM

#

i mean, you could just check if the scene is a gameplay scene

rough pulsar Apr 7, 2021, 3:12 PM

#

ok so hollow knight just stops responding after i toggle the RPC mod off

floral blade Apr 7, 2021, 3:12 PM

#

would you be reseting the status or something on unload ?

rough pulsar Apr 7, 2021, 3:12 PM

#

hmm

#

i was disposing the gameobject so it wouldn't keep using memory i guess

floral blade Apr 7, 2021, 3:13 PM

#

like save the status when started and reset the same when stopping might be cool

rough pulsar Apr 7, 2021, 3:13 PM

#

not this happened

#

rough pulsar Apr 7, 2021, 3:13 PM

#

floral blade like save the status when started and reset the same when stopping might be cool

i might try doing that........

#

i'll go to %temp%\HollowKnightDRPC and create a new file there that keeps the epoch time

#

the only data that will be stored there will just be a single int

#

so it will uh

#

it will take up 4 bytes as an int instead of storing a string which will be 12 bytes or 13

#

or i can just store the string instead

#

more memory cost but no one cares

floral blade Apr 7, 2021, 3:23 PM

#

which file has the monarch wings "wing" animation ? is it Wings.png it seemed like it is more of a cutscene sheet at the first glance

rough pulsar Apr 7, 2021, 3:32 PM

#

POGGERS

cedar hemlock Apr 7, 2021, 3:32 PM

#

menus?

rough pulsar Apr 7, 2021, 3:32 PM

#

m

#

in menu*

#

fuc

cedar hemlock Apr 7, 2021, 3:32 PM

#

im in...

rough pulsar Apr 7, 2021, 3:33 PM

#

oh pogger

cedar hemlock Apr 7, 2021, 3:33 PM

#

can you guess where i am

rough pulsar Apr 7, 2021, 3:33 PM

#

right below the city of tears well?

#

no?

cedar hemlock Apr 7, 2021, 3:33 PM

#

thats a long term for waterways

rough pulsar Apr 7, 2021, 3:34 PM

#

i might named something wrong

cedar hemlock Apr 7, 2021, 3:34 PM

#

for me its normal

rough pulsar Apr 7, 2021, 3:34 PM

#

ok good

#

i forgot to reset the assets pepogrub

#

because am too smart. obviosuly

cedar hemlock Apr 7, 2021, 3:37 PM

#

yes ofcourse

#

very "obviosuly"

rough pulsar Apr 7, 2021, 3:38 PM

#

funny discord bug!

cedar hemlock Apr 7, 2021, 3:38 PM

#

you gonna add blue masks?

rough pulsar Apr 7, 2021, 3:39 PM

#

oh yeah

#

i will

cedar hemlock Apr 7, 2021, 3:39 PM

#

instead of 5/5 7/7

#

or seperate

rough pulsar Apr 7, 2021, 3:39 PM

#

i'm gonna just

#

7/5

cedar hemlock Apr 7, 2021, 3:39 PM

#

nice

rough pulsar Apr 7, 2021, 3:39 PM

#

RPCLLOW (CHECKREADME)DISCORD

cedar hemlock Apr 7, 2021, 3:40 PM

#

its at the right place at least

rough pulsar Apr 7, 2021, 3:40 PM

#

oh

#

after you toggle the mod it just stops working

#

ain't that so funny

cedar hemlock Apr 7, 2021, 3:41 PM

#

you mean when you turn it on, off and on again?

rough pulsar Apr 7, 2021, 3:41 PM

#

cedar hemlock you mean when you turn it on, off and on again?

yea

#

this works i hope

#

now i'll go to the funny king's pass

#

and collect some blue hearts

#

lifeblooodd mm

#

what if lifeblood was in real life

cedar hemlock Apr 7, 2021, 3:43 PM

#

it aint workin

rough pulsar Apr 7, 2021, 3:43 PM

#

what isn't workng?

#

the lifeblood?

cedar hemlock Apr 7, 2021, 3:43 PM

#

oh no

#

when the mods are loading it just displays normal

rough pulsar Apr 7, 2021, 3:43 PM

#

what

cedar hemlock Apr 7, 2021, 3:44 PM

#

you can try to increase load priority

cedar hemlock Apr 7, 2021, 3:44 PM

#

rough pulsar what

when you see the bar

#

the mod isn't loaded yet

#

so its just normal

rough pulsar Apr 7, 2021, 3:44 PM

#

w

cedar hemlock Apr 7, 2021, 3:45 PM

#

how

rough pulsar Apr 7, 2021, 3:45 PM

#

ok so what is the default load priority?

cedar hemlock Apr 7, 2021, 3:45 PM

#

did i die to flukenest

cedar hemlock Apr 7, 2021, 3:45 PM

#

rough pulsar ok so what is the default load priority?

alphabetic

rough pulsar Apr 7, 2021, 3:45 PM

#

you died to flukemarm

cedar hemlock Apr 7, 2021, 3:45 PM

#

if you dont give one

cedar hemlock Apr 7, 2021, 3:45 PM

#

rough pulsar you died to flukemarm

im stupid

rough pulsar Apr 7, 2021, 3:45 PM

#

i'll just set the load priority to 10

rough pulsar Apr 7, 2021, 3:46 PM

#

cedar hemlock the mod isn't loaded yet

so if i set load priority it loads before the loading bar or what

cedar hemlock Apr 7, 2021, 3:46 PM

#

no

rough pulsar Apr 7, 2021, 3:46 PM

#

it just loads before other mods

cedar hemlock Apr 7, 2021, 3:46 PM

#

the funny looking bar are the mods loading

rough pulsar Apr 7, 2021, 3:46 PM

#

based on priority

cedar hemlock Apr 7, 2021, 3:46 PM

#

so it will be loading first or smth

rough pulsar Apr 7, 2021, 3:47 PM

#

so this is the test i am making my mod go through

cedar hemlock Apr 7, 2021, 3:48 PM

#

although if it loads before the dependency will it break 🤔

rough pulsar Apr 7, 2021, 3:48 PM

#

load a save that isn't normal game mode
quit
load any save that isn't the same game mode
collect lifeblood

rough pulsar Apr 7, 2021, 3:48 PM

#

cedar hemlock although if it loads before the dependency will it break 🤔

what is the modcommon's priority?

cedar hemlock Apr 7, 2021, 3:48 PM

#

the M

#

you can look at the source

#

if it has an custom load priority

rough pulsar Apr 7, 2021, 3:49 PM

#

ok quitting to menu works

#

it said "quitting to menu" for a brief second

#

thats good

#

"Opening save..."

cedar hemlock Apr 7, 2021, 3:49 PM

#

black egg

light zodiac Apr 7, 2021, 3:50 PM

#

What's the (1 of 1) next to geo

rough pulsar Apr 7, 2021, 3:50 PM

#

light zodiac What's the (1 of 1) next to geo

idk.

#

oh

#

i tried something

#

like

#

the "party" object

#

i thought it would display to the bottom of the "State"

#

it just displays it next to the state....

#

i'll get rid of it x)

#

F

cedar hemlock Apr 7, 2021, 3:52 PM

#

quick edit lol

rough pulsar Apr 7, 2021, 3:52 PM

#

it said Cinematic_Stag_travel

#

both of them correct now?

#

oh it works, awesome

#

12/8 masks

#

mmm

#

funny

cedar hemlock Apr 7, 2021, 3:56 PM

#

wow

#

now make it 18/0

jolly oriole Apr 7, 2021, 3:56 PM

#

imagine not having 21/21 Masks

rough pulsar Apr 7, 2021, 3:57 PM

#

sooo

#

what is joniBlueHealth or whatever is it called

#

fu

#

i rested on a bench

light zodiac Apr 7, 2021, 3:57 PM

#

The health you get from jonis

rough pulsar Apr 7, 2021, 3:57 PM

#

really?

cedar hemlock Apr 7, 2021, 3:57 PM

#

makes sense

rough pulsar Apr 7, 2021, 3:58 PM

#

so if i don't have joni's blessing equipped it just becomes 0?

cedar hemlock Apr 7, 2021, 3:58 PM

#

ye

jolly oriole Apr 7, 2021, 3:58 PM

#

https://radiance.host/apidocs/PlayerData.html

rough pulsar Apr 7, 2021, 3:58 PM

#

ok so that's poggers

#

also

#

i would like to set the "elapsed" time to be the save file's playtime but...

#

discord only displays maximum 24 hours

#

sooo

#

it would overflow

#

for some reason

cedar hemlock Apr 7, 2021, 4:00 PM

#

what happens when it "overflows"

rough pulsar Apr 7, 2021, 4:00 PM

#

it just becomes 00:00

jolly oriole Apr 7, 2021, 4:00 PM

#

just print is as a string?

rough pulsar Apr 7, 2021, 4:00 PM

#

i can't set the 4th line (timestamp) to be a custom string

#

if you are using english language it would display as "00:00 elapsed"

#

in turkish it would display "00:00 geçti"

#

oh and also

#

someone who tried my mod found something

cedar hemlock Apr 7, 2021, 4:03 PM

#

what

rough pulsar Apr 7, 2021, 4:03 PM

#

in city of tear's elevator, it says Resting Grounds instead of city of tears elevator

cedar hemlock Apr 7, 2021, 4:03 PM

#

oh that was me :)

rough pulsar Apr 7, 2021, 4:03 PM

#

as you can see, me being dumb just decided to set it to resting grounds

cedar hemlock Apr 7, 2021, 4:04 PM

#

smort

#

Crossroads_49B

rough pulsar Apr 7, 2021, 4:04 PM

#

yea. i fixed it

#

funny

jolly oriole Apr 7, 2021, 4:07 PM

#

i mean, you could've preloaded something nonexistent of every scene, then check with a scenemanager.start hook which scenename corresponds to which map area

rough pulsar Apr 7, 2021, 4:08 PM

#

yeah i could have

#

i don't think joniHealthBlue works........

#

i'll just check if joni's blessing is equipped

#

i think they may have set ModCommon's load priority to int.MaxValue

light zodiac Apr 7, 2021, 4:13 PM

#

rough pulsar funny

You choudlve just checked if jonis charm was equipped

rough pulsar Apr 7, 2021, 4:13 PM

#

light zodiac You choudlve just checked if jonis charm was equipped

i know i did that rn

#

7 JONI MASKS

cedar hemlock Apr 7, 2021, 4:14 PM

#

18?

rough pulsar Apr 7, 2021, 4:14 PM

#

was 7 joni masks for a brief second

cedar hemlock Apr 7, 2021, 4:15 PM

#

now 18 soulpensive

rough pulsar Apr 7, 2021, 4:16 PM

#

WHAT

cedar hemlock Apr 7, 2021, 4:21 PM

#

what

#

?

rough pulsar Apr 7, 2021, 4:22 PM

#

#

anyways

#

hmmm

#

i will give the 1.1.1 beta dll here i guess

#

📎 HollowKnightDRPC.dll

cedar hemlock Apr 7, 2021, 4:23 PM

#

what if you have this mod twice?

#

what will hapen

rough pulsar Apr 7, 2021, 4:24 PM

#

mmmmmm

#

idk

cedar hemlock Apr 7, 2021, 4:25 PM

#

smth new to try

light zodiac Apr 7, 2021, 4:26 PM

#

rough pulsar

HoW dO I iNsTaLl ThIs MoD It GiVeS mE eRrOr WhEn I LoAd tHe GaMe

rough pulsar Apr 7, 2021, 4:26 PM

#

i think

cedar hemlock Apr 7, 2021, 4:27 PM

#

cHeCk ThE ReAdMe (x1000)

rough pulsar Apr 7, 2021, 4:27 PM

#

this is the only mod in existence that requires extra steps to install

#

discord game sdk is to blame >:(

rough pulsar Apr 7, 2021, 4:45 PM

#

and now...

#

i'm gonna create another funny pull request

vocal spire Apr 7, 2021, 4:50 PM

#

rough pulsar this is the only mod in existence that requires extra steps to install

Heard of dependencies?

rough pulsar Apr 7, 2021, 4:51 PM

#

vocal spire Heard of dependencies?

Discord Game SDK is not a .NET Framework DLL, and uh

#

if i add it to...

#

the mods folder

#

modding API just says "nope" and none of the mods work

#

so that doesn't work!

#

the only way to install dependencies is uh

vocal spire Apr 7, 2021, 4:52 PM

#

rough pulsar Discord Game SDK is not a .NET Framework DLL, and uh

Still extra steps

rough pulsar Apr 7, 2021, 4:52 PM

#

yea

#

i tried adding discord game sdk to the mods folder

#

it doesn't simply work

vocal spire Apr 7, 2021, 4:54 PM

#

Ik

#

I’m just stating your mod isn’t the only one with extra steps

#

If you don’t count dependencies, take player data tracker

rough pulsar Apr 7, 2021, 4:54 PM

#

player data tracker also requires another dependency that isn't a mod?

cedar hemlock Apr 7, 2021, 4:54 PM

#

Yeah

vocal spire Apr 7, 2021, 4:54 PM

#

Website

rough pulsar Apr 7, 2021, 4:55 PM

#

oh dang

#

though

jolly oriole Apr 7, 2021, 4:55 PM

#

let your mod unpack the sdk into streaming assets folder

vocal spire Apr 7, 2021, 4:55 PM

#

What if it unpacks after that folder is already loaded?

stone elm Apr 7, 2021, 4:55 PM

#

I've gotten away with putting dependencies in the Managed folder, although all my dependencies have been managed code

jolly oriole Apr 7, 2021, 4:56 PM

#

i mean, you can put dependencies like the sdk into the zip of your mod with the pathing, which 56 just doesn't like, but currently it still works afaik

vocal spire Apr 7, 2021, 4:56 PM

#

I thought you could do that but wasn’t completely sure

rough pulsar Apr 7, 2021, 4:56 PM

#

m mm m m m

#

sooooo

vocal spire Apr 7, 2021, 4:57 PM

#

I thought you could do that but wasn’t completely sure

rough pulsar Apr 7, 2021, 4:57 PM

#

i'll try checking if i can just

#

check if the dependencies exist.

#

before executing any discord-related code

#

i have proof that it will work, because in my mod

#

it logs that Discord SDK is initializing

#

right after that? discord related code

#

if you don't have dependencies installed it will say "discord sdk is initializing" then it will display an error right after that.

#

so installing dependencies is a great way

vocal spire Apr 7, 2021, 4:58 PM

#

confusion

rough pulsar Apr 7, 2021, 4:59 PM

#

soo

#

i'll try to install dependencies right above the imaginary red line

#

the question is

#

the question is

#

how do i locate the dll again pepogrub

stone elm Apr 7, 2021, 5:01 PM

#

The thought of a mod auto-downloading DLLs into my game makes me a little queasy tbh

rough pulsar Apr 7, 2021, 5:01 PM

#

queasy?

vocal spire Apr 7, 2021, 5:01 PM

#

It was always possible

stone elm Apr 7, 2021, 5:01 PM

#

It sure is, but hasn't been done yet. All 'auto-downloads' have been SHA verified so far.

jolly oriole Apr 7, 2021, 5:02 PM

#

sha verify your discord sdk download

vocal spire Apr 7, 2021, 5:02 PM

#

Yeah

stone elm Apr 7, 2021, 5:02 PM

#

Please do

vocal spire Apr 7, 2021, 5:02 PM

#

If it updates, you update your mod

rough pulsar Apr 7, 2021, 5:03 PM

#

i'll first try checking if the directories exist tho

#

but

jolly oriole Apr 7, 2021, 5:03 PM

#

(or if available keep using the 'old' sdk so you don't have to push updates to make the newer sdks work)

vocal spire Apr 7, 2021, 5:03 PM

#

time to add viruses to pale court

rough pulsar Apr 7, 2021, 5:03 PM

#

but

#

i want to know how can i programmatically locate my own dll?

vocal spire Apr 7, 2021, 5:03 PM

#

Might need to update if discord updates tho

rough pulsar Apr 7, 2021, 5:03 PM

#

that's the first step i have to cross

vocal spire Apr 7, 2021, 5:03 PM

#

rough pulsar i want to know how can i programmatically locate my own dll?

How do you download it

#

You can just do ..\ to go out one folder

rough pulsar Apr 7, 2021, 5:03 PM

#

OH

#

right

#

i'm stupid

vocal spire Apr 7, 2021, 5:04 PM

#

So Assembly.GetExecutungAssembly().Location or something and then navigate the hk files(might be different for mac)

rough pulsar Apr 7, 2021, 5:04 PM

#

so

#

the mod exists in hollowknightdata\Managed\Mods

#

i think

vocal spire Apr 7, 2021, 5:05 PM

#

You can check rn

rough pulsar Apr 7, 2021, 5:05 PM

#

if i go like ..\..\Plugins

cedar hemlock Apr 7, 2021, 5:05 PM

#

But with _

rough pulsar Apr 7, 2021, 5:05 PM

#

it will go to the right plugins

vocal spire Apr 7, 2021, 5:05 PM

#

Yee

rough pulsar Apr 7, 2021, 5:05 PM

#

alright so that's awesome

#

the real difficulty is

#

you know.

#

it's to download a zip then unzip it

#

right?

#

there are no official zip/unzip tools in .NET Framework 3.5

cedar hemlock Apr 7, 2021, 5:07 PM

#

Just get a cmd to do it or smth

#

No idea

#

(Can you open an cmd with a .dll???)

rough pulsar Apr 7, 2021, 5:08 PM

#

sadly this doesn't work in .NET Framework 3.5

#

oh yeah

#

you can open a cmd in dll

#

since a dll is, you know

#

attached to the

#

exe

#

wait

#

i will experiment something real quick

cedar hemlock Apr 7, 2021, 5:08 PM

#

Then why dont say the cmd to unzip it

rough pulsar Apr 7, 2021, 5:10 PM

#

wait

#

is there a program in Windows folder that allows us to unzip/zip files?

cedar hemlock Apr 7, 2021, 5:10 PM

#

Cant explorer do it?

rough pulsar Apr 7, 2021, 5:10 PM

#

i don't think so

cedar hemlock Apr 7, 2021, 5:11 PM

#

Afaik it can

#

Lemme search rq

rough pulsar Apr 7, 2021, 5:11 PM

#

ok you do that

#

i can just

cedar hemlock Apr 7, 2021, 5:11 PM

#

https://support.microsoft.com/en-us/windows/zip-and-unzip-files-f6dde0a7-0fec-8294-e1d3-703ed85e7ebc#:~:text=To unzip files,folder to a new location.

#

Why so loooongg

rough pulsar Apr 7, 2021, 5:12 PM

#

open notepad by doing Process.Start(@"C:\Windows\notepad.exe");

#

b

cedar hemlock Apr 7, 2021, 5:12 PM

#

Add in the readme what it is gonna do

#

Otherwise people are gonna go crazy

#

b?

rough pulsar Apr 7, 2021, 5:15 PM

#

hold on

#

can't i just use the command from the powershell?

#

you know powershell

cedar hemlock Apr 7, 2021, 5:15 PM

#

Yes

rough pulsar Apr 7, 2021, 5:15 PM

#

command prompt but better ~~except no one uses it~~

cedar hemlock Apr 7, 2021, 5:15 PM

#

Also yes

#

Bc its blue

#

Cmd is black

rough pulsar Apr 7, 2021, 5:16 PM

#

it also can extract zip files within 1 command unlike command prompt which does it in like

#

13 lines

cedar hemlock Apr 7, 2021, 5:17 PM

#

Nice

#

I never even touched it lol

rough pulsar Apr 7, 2021, 5:19 PM

#

hold on

#

let me see if i can execute powershell with parameters

cedar hemlock Apr 7, 2021, 5:20 PM

#

Expand-Archive lol

rough pulsar Apr 7, 2021, 5:20 PM

#

hmm

#

OH YEAH

#

IT DOES

#

HECK YEA

cedar hemlock Apr 7, 2021, 5:20 PM

#

Hope that windows defender isn't gonna go crazy

rough pulsar Apr 7, 2021, 5:21 PM

#

I CAN JUST DO

#

Process.Start("powershell Expand-Archive -LiteralPath 'zip path here' -DestinationPath 'extract path here'");

cedar hemlock Apr 7, 2021, 5:21 PM

#

Amazing

rough pulsar Apr 7, 2021, 5:23 PM

#

Ohhh shit

#

It executes from the hollow_knight.exe file so

#

that makes sense

#

it's attached to the game

#

so I have to do hollowknight_Data\Plugins

cedar hemlock Apr 7, 2021, 5:24 PM

#

Yep

#

Between hollow and knight needst to be _

#

And some caps

rough pulsar Apr 7, 2021, 5:27 PM

#

oki

#

i'll try if this code works

#

oh wait

#

oh wait

#

i forgot to delete the thing after else

#

fixed i

#

works

cedar hemlock Apr 7, 2021, 5:34 PM

#

Nice

rough pulsar Apr 7, 2021, 5:34 PM

#

ok so

#

now i have to download the dependencies

#

it's simply easy to do tbh

cedar hemlock Apr 7, 2021, 5:35 PM

#

Check how modinstaller does it

rough pulsar Apr 7, 2021, 5:35 PM

#

modinstaller uses .NET Framework 4.7.2 though

#

which has ZipArchive and stuff

cedar hemlock Apr 7, 2021, 5:36 PM

#

Or make modinstaller do it for you

rough pulsar Apr 7, 2021, 5:36 PM

#

i would but

#

hhh

#

it takes me a long time to comprehend a project's source code i haven't even looked at

cedar hemlock Apr 7, 2021, 5:36 PM

#

lol

#

Is prob all in modmanager.cs

#

But player data tracker does also download multiple files

#

Why dont you do that to

rough pulsar Apr 7, 2021, 5:38 PM

#

wdym?

cedar hemlock Apr 7, 2021, 5:38 PM

#

Make the modinstaller download the zip

#

Or am i being stupid again

rough pulsar Apr 7, 2021, 5:38 PM

#

no you're not

#

every solution works in the programming land hollowwoke

#

but

cedar hemlock Apr 7, 2021, 5:39 PM

#

Oh ok

rough pulsar Apr 7, 2021, 5:39 PM

#

i don't think i can find the code where it actually checks the <File> section and such

#

am stupid and i almost never touched the System.Xml namespace

cedar hemlock Apr 7, 2021, 5:40 PM

#

my phone died at 3% im back

cedar hemlock Apr 7, 2021, 5:44 PM

#

rough pulsar i don't think i can find the code where it actually checks the <File> section an...

?

#

just add it to the files it downloads?

rough pulsar Apr 7, 2021, 5:44 PM

#

no

#

it will just download it to the Mods folder

#

which i don't want

#

at all

cedar hemlock Apr 7, 2021, 5:45 PM

#

cant you make it move?

jolly oriole Apr 7, 2021, 5:45 PM

#

btw about the zip thing

#

don't you need a specific command for each OS?

cedar hemlock Apr 7, 2021, 5:46 PM

#

you mean just windows and mac or window 7 and 10?

rough pulsar Apr 7, 2021, 5:46 PM

#

jolly oriole don't you need a specific command for each OS?

you're right

#

but uh i don't think i can uh

#

find a proper library that does it for me?

rough pulsar Apr 7, 2021, 5:47 PM

#

cedar hemlock you mean just windows and mac or window 7 and 10?

they mean "windows and mac" probably

jolly oriole Apr 7, 2021, 5:47 PM

#

gimme a sec, i have something to differentiate OSes (can just set a temp string var that later just executes the command)

#

public static string UNZIP_COMMAND
{
    get
    {
        return SystemInfo.operatingSystemFamily switch
        {
            OperatingSystemFamily.Windows => "windows command",
            OperatingSystemFamily.Linux => "linux command",
            OperatingSystemFamily.MacOSX => "mac command",
            _ => null
        };
    }
}

you can have this somewhere in the class you're unzipping in

rough pulsar Apr 7, 2021, 5:49 PM

#

hm thank

stone elm Apr 7, 2021, 5:52 PM

#

You are likely best off using a library to enable zipfile interfacing rather than depending on what a user's system may have installed. (Not so bad on Windows but maybe Mac varies. Likely Linux varies widely.)

rough pulsar Apr 7, 2021, 5:54 PM

#

dangit

#

I GUESS there is a library for that.

#

SharpZipLib

jolly oriole Apr 7, 2021, 5:56 PM

#

DotNetZip apparently is also an option

#

link before the archive shuts down in 1 jul 2021: https://archive.codeplex.com/?p=dotnetzip

rough pulsar Apr 7, 2021, 5:57 PM

#

it's much older

#

:c

#

i think

#

oh looks like i already have it

#

the reason i'm using 0.86.0 is because

#

it's the only version i can install rn

jolly oriole Apr 7, 2021, 5:58 PM

#

but you'd need to ship that in your mod (or at least in the mod's zip), y'know?

rough pulsar Apr 7, 2021, 5:59 PM

#

oh yeah

#

you're right

#

i can do that

#

so i try doing this

jolly oriole Apr 7, 2021, 6:03 PM

#

i think (i might be wrong), the paths are relative to the mod's dll

rough pulsar Apr 7, 2021, 6:03 PM

#

No

#

not at all

light zodiac Apr 7, 2021, 6:03 PM

#

rough pulsar so i try doing this

won't this only work for windows?

rough pulsar Apr 7, 2021, 6:03 PM

#

#archived-modding-development message

jolly oriole Apr 7, 2021, 6:04 PM

#

well then, you'll need a special case for mac

rough pulsar Apr 7, 2021, 6:04 PM

#

why

stone elm Apr 7, 2021, 6:04 PM

#

Nothing about that screenshot seems 'windows only' to me.

rough pulsar Apr 7, 2021, 6:04 PM

#

are the paths relative to the mod's dll in mac?

light zodiac Apr 7, 2021, 6:04 PM

#

mac has contents instead of hollow_knight_Data

jolly oriole Apr 7, 2021, 6:04 PM

#

because there the mod is under resources/hollow_knight_data/managed/mods

#

or contents

#

idk

stone elm Apr 7, 2021, 6:04 PM

#

Ah, paths, I suppose that makes sense

rough pulsar Apr 7, 2021, 6:05 PM

#

wait

#

?saves

finite forumBOT Apr 7, 2021, 6:05 PM

#

Saves

Windows File Paths: (Assumes Default Steam Install Path, Adjust accordingly for DRM Free or Non-Standard Steam Path)

Game Files: C:\Program Files (x86)\Steam\steamapps\common\Hollow Knight\```
** **
Mac File Paths:
```Save Files: ~/Library/Application Support/unity.Team Cherry.Hollow Knight/
Game Files: ~/Library/Application Support/Steam/steamapps/common/Hollow Knight/hollow_knight.app/```
** **
Linux File Paths:
```Save Files: ~/.config/unity3d/Team Cherry/Hollow Knight/
Game Files: ~/.local/share/Steam/steamapps/common/Hollow Knight/```

light zodiac Apr 7, 2021, 6:05 PM

#

mac mods => contents -> resources -> data -> managed -> mods

rough pulsar Apr 7, 2021, 6:05 PM

#

what

light zodiac Apr 7, 2021, 6:06 PM

#

but there's also contents -> managed -> mods that custom knight uses

stone elm Apr 7, 2021, 6:06 PM

#

If you just need the SDK to be available then it should be placed anywhere the process would look for dependencies. .NET tries quite a few paths. Putting it in the same directory as the EXE probably works.

floral blade Apr 7, 2021, 6:06 PM

#

switch (SystemInfo.operatingSystemFamily)
{
case OperatingSystemFamily.MacOSX:
DATA_DIR = Path.GetFullPath(Application.dataPath + "/Resources/Data/Managed/Mods/");
break;
default:
DATA_DIR = Path.GetFullPath(Application.dataPath + "/Managed/Mods/" );
break;
}
this seems to work for me

stone elm Apr 7, 2021, 6:06 PM

#

Dependencies don't necessarily have to be in the mods folder. They just need to be in a directory where they can be found.

rough pulsar Apr 7, 2021, 6:06 PM

#

floral blade switch (SystemInfo.operatingSystemFamily) { case Ope...

only mac has different path?

floral blade Apr 7, 2021, 6:07 PM

#

rough pulsar *only* mac has different path?

comes from custom knight i think, might not handle linux have not tested personally on it

#

https://docs.unity3d.com/ScriptReference/Application-dataPath.html

#

seems like win & linux have similar paths

rough pulsar Apr 7, 2021, 6:16 PM

#

i'm looking at sharpziplib wiki

#

apparently this works

#

i can't even...

#

foreach-inception

#

oh wait i can just use

#

fastzip

#

code so far (windows)

#

oh wait i didn't add the sharpziplib dll

light zodiac Apr 7, 2021, 6:39 PM

#

add the line at the endcs Directory.Delete(@"\hollow_knight_Data\Managed\Mods")

rough pulsar Apr 7, 2021, 6:40 PM

#

you're funny person

#

discord hates me now.

floral blade Apr 7, 2021, 6:54 PM

#

funny rate limited ?

rough pulsar Apr 7, 2021, 6:54 PM

#

forbidden soulpensive

floral blade Apr 7, 2021, 6:55 PM

#

this happened with me and google drive 😛

#

restart your internet connection if you dont have a static ip

rough pulsar Apr 7, 2021, 6:55 PM

#

H M.

#

ok

#

i guess i'll die for a brief second

#

oh no

stone elm Apr 7, 2021, 6:57 PM

#

It probably means your token or other auth method is invalid.

rough pulsar Apr 7, 2021, 6:57 PM

#

w

#

#

the only server related code is this

floral blade Apr 7, 2021, 7:00 PM

#

rough pulsar the only server related code is this

you were probably forbidden because of a rate limit , did u delete -> download -> repeat super fast too many times ?

rough pulsar Apr 7, 2021, 7:00 PM

#

yah i did

floral blade Apr 7, 2021, 7:01 PM

#

rough pulsar yah i did

and is it working now that you restarted network ?

rough pulsar Apr 7, 2021, 7:01 PM

#

they have a shitty bandwidth if they forbid

#

no

#

it stilld oesn't work hollowblob

floral blade Apr 7, 2021, 7:01 PM

#

did you restart your router / modem ?

rough pulsar Apr 7, 2021, 7:01 PM

#

i did

#

and no i don't have a static ip

floral blade Apr 7, 2021, 7:02 PM

#

hmm... it might be vpn time then

rough pulsar Apr 7, 2021, 7:02 PM

#

also quick question

#

does the rate limit go after a day

floral blade Apr 7, 2021, 7:03 PM

#

rough pulsar does the rate limit go after a day

dunno how they've set it up but usually it works after a while

rough pulsar Apr 7, 2021, 7:03 PM

#

a short while

#

like

#

only a few minutes?

floral blade Apr 7, 2021, 7:04 PM

#

yeah but sometimes hours / sometimes days. depends on how they've set it up

#

best suggestion right now would be to download the file over vpn once and keep using it till you really need it again

rough pulsar Apr 7, 2021, 7:04 PM

#

hmmm

#

i'll just

#

use a copy

#

i have rn

floral blade Apr 7, 2021, 7:05 PM

#

rough pulsar use a copy

oh that works too

light zodiac Apr 7, 2021, 7:05 PM

#

send the dll i can test it if you want

rough pulsar Apr 7, 2021, 7:05 PM

#

really

#

ok

#

📎 HollowKnightDRPC.dll

#

oH and also

#

this too

#

📎 ICSharpCode.SharpZipLib.dll

#

you need both

light zodiac Apr 7, 2021, 7:06 PM

#

rough pulsar

mods folder?

rough pulsar Apr 7, 2021, 7:06 PM

#

yes

#

uh

#

first if you have x86 and x86_64 folders in the plugins

#

delete them

#

bruh i can just download the zip just fine @floral blade

#

well

#

thats weird

floral blade Apr 7, 2021, 7:13 PM

#

you can download it via browser but not via code ?

rough pulsar Apr 7, 2021, 7:13 PM

#

yeah

floral blade Apr 7, 2021, 7:13 PM

#

are they detecting UA 😮

#

see if you can download using curl ?

rough pulsar Apr 7, 2021, 7:14 PM

#

wait

#

what's ua

light zodiac Apr 7, 2021, 7:14 PM

#

i downloaded both mods and tried to open the game and got the DRPC failed to load

Modlog[INFO]:[HollowKnightDRPC] - Mod initializing [INFO]:[HollowKnightDRPC] - DLL Location: C:\Program Files (x86)\Steam\steamapps\common\Hollow Knight [INFO]:[HollowKnightDRPC] - Dependencies don't exist [ERROR]:[API] - Error: System.Net.WebException: The remote server returned an error: (403) Forbidden. [ERROR]:[API] - at System.Net.HttpWebRequest.CheckFinalStatus (System.Net.WebAsyncResult result) [0x00000] in <filename unknown>:0 [ERROR]:[API] - at System.Net.HttpWebRequest.SetResponseData (System.Net.WebConnectionData data) [0x00000] in <filename unknown>:0

rough pulsar Apr 7, 2021, 7:14 PM

#

light zodiac i downloaded both mods and tried to open the game and got the DRPC failed to loa...

unpog

light zodiac Apr 7, 2021, 7:14 PM

#

it didn't unzip

floral blade Apr 7, 2021, 7:14 PM

#

rough pulsar what's ua

user agent

rough pulsar Apr 7, 2021, 7:15 PM

#

the zip is 0kb it didn't even download

#

@floral blade

#

not only that, there's another entire problem with the zip thingy

[ERROR]:[API] - Error: System.NotSupportedException: CodePage 437 not supported
[ERROR]:[API] -   at System.Text.Encoding.GetEncoding (Int32 codepage) [0x00000] in <filename unknown>:0 
[ERROR]:[API] -   at ICSharpCode.SharpZipLib.Zip.ZipConstants.ConvertToString (System.Byte[] data, Int32 count) [0x00000] in <filename unknown>:0 
[ERROR]:[API] -   at ICSharpCode.SharpZipLib.Zip.ZipConstants.ConvertToStringExt (Int32 flags, System.Byte[] data, Int32 count) [0x00000] in <filename unknown>:0 
[ERROR]:[API] -   at ICSharpCode.SharpZipLib.Zip.ZipFile.ReadEntries () [0x00000] in <filename unknown>:0 
[ERROR]:[API] -   at ICSharpCode.SharpZipLib.Zip.ZipFile..ctor (System.IO.Stream stream) [0x00000] in <filename unknown>:0

jolly oriole Apr 7, 2021, 7:20 PM

#

crazy

stone elm Apr 7, 2021, 7:20 PM

#

floral blade you were probably forbidden because of a rate limit , did u delete -> download -...

rate limits dont return 403, they return 423

#

or was it 422, either way, discord wouldnt return 403 on rate limits most likely

#

i doubt even they are that bad 😐

rough pulsar Apr 7, 2021, 7:20 PM

#

auto dependency download might be anything but a real thing soulpensive

#

in this mod

stone elm Apr 7, 2021, 7:21 PM

#

What is the problem with bundling it with the mod again? Was it the fact that it would be in the Mods folder? Why not just write code to move it out gorbbrain

rough pulsar Apr 7, 2021, 7:21 PM

#

move it out

#

w

light zodiac Apr 7, 2021, 7:21 PM

#

a quick google shows 403 is a permissions error

rough pulsar Apr 7, 2021, 7:21 PM

#

wdym

stone elm Apr 7, 2021, 7:22 PM

#

From Mods folder to somewhere else where the modloader won't break on it

#

like to ../

#

I might've missed something, but this was all due to modloader breaking due to native dll in Mods folder, yes?

rough pulsar Apr 7, 2021, 7:22 PM

#

OH SHIT i have a b...

#

nvm...

rough pulsar Apr 7, 2021, 7:22 PM

#

stone elm I might've missed something, but this was all due to modloader breaking due to n...

yeah

stone elm Apr 7, 2021, 7:22 PM

#

And you want to download it because it's not easy/recommended to bundle the DLL so that it DOESN'T end up in Mods right?

rough pulsar Apr 7, 2021, 7:23 PM

#

modloader completely dies when it sees a native dll

#

yes

#

question

light zodiac Apr 7, 2021, 7:23 PM

#

could it be possible to create a new folder in mods

rough pulsar Apr 7, 2021, 7:23 PM

#

a real quick question

light zodiac Apr 7, 2021, 7:23 PM

#

to contain those files

rough pulsar Apr 7, 2021, 7:23 PM

#

if i create a subfolder in my zip

#

then

#

e.g

#

the discord game sdk files will be located in "/x86/..." and "/x86/..." right

stone elm Apr 7, 2021, 7:24 PM

#

Yeah, that'd probably work to put a sub-directory in Mods. IDK if the modloader loads from subdirs

rough pulsar Apr 7, 2021, 7:24 PM

#

sooooooooo

#

i can make my mod move those folders to

#

uh

#

the plugins folder

stone elm Apr 7, 2021, 7:24 PM

#

Yeah, probably

rough pulsar Apr 7, 2021, 7:24 PM

#

we are a bunch of geniuses

#

dam

#

oki

#

let me try

floral blade Apr 7, 2021, 7:27 PM

#

stone elm or was it 422, either way, discord wouldnt return 403 on rate limits most likely

google drive did that to me like 2 days ago so i have trust issues

rough pulsar Apr 7, 2021, 7:28 PM

#

damn

stone elm Apr 7, 2021, 7:28 PM

#

google drive rude af not following standards

rough pulsar Apr 7, 2021, 7:28 PM

#

bad company

#

smh

#

if this solution doesn't work idk what will work

stone elm Apr 7, 2021, 7:29 PM

#

Embed the DLL as embedded resource then shit it out into a folder on runtime

#

There's plan D

rough pulsar Apr 7, 2021, 7:30 PM

#

OH?

#

IT WORKS

#

IT WORKS

#

OH MY FUCKING GOD

#

!!!!!!!!!!!

light zodiac Apr 7, 2021, 7:30 PM

#

lfg

rough pulsar Apr 7, 2021, 7:30 PM

#

LFG!!!!!!!!!!!

#

now

stone elm Apr 7, 2021, 7:31 PM

#

pogtamer

rough pulsar Apr 7, 2021, 7:31 PM

#

should i just remove the "CHECK README" in the modlinks.xml lol

#

it's no longer necessary

#

except explaining what it does

floral blade Apr 7, 2021, 7:31 PM

#

he's just a head now lmao

rough pulsar Apr 7, 2021, 7:31 PM

#

i hope it doesn't break anything though.

rough pulsar Apr 7, 2021, 7:32 PM

#

floral blade he's just a head now lmao

are you working on HKMP?

floral blade Apr 7, 2021, 7:32 PM

#

how do i make a copy of a transform ?

floral blade Apr 7, 2021, 7:32 PM

#

rough pulsar are you working on HKMP?

yes

rough pulsar Apr 7, 2021, 7:32 PM

#

what

#

copy of a transforM???

floral blade Apr 7, 2021, 7:32 PM

#

yes i think i copied it by reference and modified it to send that other player under ground

#

i meant to only spawn another obj below them

#

i'll just try to make a new one

rough pulsar Apr 7, 2021, 7:34 PM

#

ok so

#

if i remove the string "check readme" from mod name in modlinks.xml

#

would it break anything in modinstaller

floral blade Apr 7, 2021, 7:47 PM

#

is it possible that 'Object.Destroy' wont destroy an object but simply freeze it in place ?

rough pulsar Apr 7, 2021, 7:47 PM

#

i think it will just.......destroy

floral blade Apr 7, 2021, 7:48 PM

#

hmm i must be messing something else up because these objects just freeze on screen

rough pulsar Apr 7, 2021, 7:48 PM

#

should i just push another commit to my pull request before it gets pushed shroompog

#

i need to be quick

cedar hemlock Apr 7, 2021, 7:49 PM

#

yes?

#

why not

rough pulsar Apr 7, 2021, 7:49 PM

#

oh shi

#

hmmm

#

nvm

#

i'll do it

prime urchin Apr 7, 2021, 7:50 PM

#

you should be able to convert pull requests to drafts so they won't be merged before they're ready

rough pulsar Apr 7, 2021, 7:50 PM

#

ok

#

done

#

oh wait

#

i forgot to add support for mac too-

#

ok itssoulgood

cedar hemlock Apr 7, 2021, 7:53 PM

#

amazing

rough pulsar Apr 7, 2021, 7:55 PM

#

wheres the

light zodiac Apr 7, 2021, 7:55 PM

#

instead of naming it x64 or something, name it hkdrpc

rough pulsar Apr 7, 2021, 7:55 PM

#

itssoulpoggers emote

light zodiac Apr 7, 2021, 7:55 PM

#

so people know what it is

rough pulsar Apr 7, 2021, 7:55 PM

#

light zodiac instead of naming it x64 or something, name it hkdrpc

hmmmmm you're right

light zodiac Apr 7, 2021, 7:55 PM

#

and if possible make 1 folder

cedar hemlock Apr 7, 2021, 7:55 PM

#

ehh nobody gonna look in the plugins folder

light zodiac Apr 7, 2021, 7:56 PM

#

its in the mods folder

rough pulsar Apr 7, 2021, 7:56 PM

#

no

light zodiac Apr 7, 2021, 7:56 PM

#

nvm

cedar hemlock Apr 7, 2021, 7:56 PM

#

xD

rough pulsar Apr 7, 2021, 7:56 PM

#

still gonna do it anyways tamershrug

cedar hemlock Apr 7, 2021, 7:56 PM

#

fun

rough pulsar Apr 7, 2021, 7:59 PM

#

it's 8.12 MB x)

#

itssoulgood

cedar hemlock Apr 7, 2021, 8:01 PM

#

ehh not that bad

rough pulsar Apr 7, 2021, 8:01 PM

#

yeah we've seen far worse, right?

cedar hemlock Apr 7, 2021, 8:01 PM

#

i know a dll thats 25 mb

#

idk what it was called tho

rough pulsar Apr 7, 2021, 8:02 PM

#

i know a mod thats indie crossover

#

which is

#

more than 100 mb

cedar hemlock Apr 7, 2021, 8:02 PM

#

nice

#

~~(my mod is more than 25 mb)~~

rough pulsar Apr 7, 2021, 8:03 PM

#

oh your mod is player data tracker?

#

nice

cedar hemlock Apr 7, 2021, 8:03 PM

#

but indie crossover and my mod being big makes sense

light zodiac Apr 7, 2021, 8:03 PM

#

cedar hemlock ~~(my mod is more than 25 mb)~~

what is your mod

cedar hemlock Apr 7, 2021, 8:03 PM

#

rough pulsar oh your mod is player data tracker?

?

#

no

rough pulsar Apr 7, 2021, 8:03 PM

#

oh

#

wait

cedar hemlock Apr 7, 2021, 8:03 PM

#

its not released ye

#

t

rough pulsar Apr 7, 2021, 8:03 PM

#

ok

cedar hemlock Apr 7, 2021, 8:03 PM

#

theres a little sprinkle released

rough pulsar Apr 7, 2021, 8:03 PM

#

you fixed someone else's sha1

#

itssoulgood

cedar hemlock Apr 7, 2021, 8:04 PM

#

i fixed hollow points SHA1

#

im the cleanup crew or smth

rough pulsar Apr 7, 2021, 8:04 PM

#

you'll probably never have to fix my mod's sha1

cedar hemlock Apr 7, 2021, 8:04 PM

#

eventually yes

rough pulsar Apr 7, 2021, 8:05 PM

#

well

#

i might make a mistake

#

in sha1

jolly oriole Apr 7, 2021, 8:05 PM

#

imagine only fixing sha1s

rough pulsar Apr 7, 2021, 8:05 PM

#

who knows

cedar hemlock Apr 7, 2021, 8:05 PM

#

jolly oriole imagine only fixing sha1s

grubsad

#

gtg now

#

bye

rough pulsar Apr 7, 2021, 8:05 PM

#

wait

#

question

#

do i have to add the rest of files in

#

nnnnn

#

the zip?

cedar hemlock Apr 7, 2021, 8:06 PM

#

what "rest"

rough pulsar Apr 7, 2021, 8:06 PM

#

the folders

cedar hemlock Apr 7, 2021, 8:06 PM

#

just put all the files in 1 zip

#

including any other zips

#

cus thats always fun

#

beware that it will all be placed in mods

rough pulsar Apr 7, 2021, 8:07 PM

#

do i have to add the <File> field for the rest of these files

cedar hemlock Apr 7, 2021, 8:07 PM

#

if you put it in a zip then only the zip

#

if you want the folders seperate out of a zip then yes

#

but bye now

rough pulsar Apr 7, 2021, 8:08 PM

#

ok

#

i'm still as confused

#

so

#

do the files get installed even if the files aren't included in modlinks.xml

#

so

#

if i don't add the files inside x86 and x86_64 those files to the modlinks.xml inside those folders will be installed or nah

#

ok

#

i think so

floral blade Apr 7, 2021, 8:21 PM

#

mastersmirk anime split second sword clash

rough pulsar Apr 7, 2021, 8:27 PM

#

anime

jolly oriole Apr 7, 2021, 8:55 PM

#

downloads that aren't sha verified pog

vocal spire Apr 7, 2021, 8:56 PM

#

🤔

#

Yeah

#

I’m not downloading a foreign dll to my device and loading it

rough pulsar Apr 7, 2021, 9:07 PM

#

i'll only add 2files here even though there are 7 other files that i haven't added inside the zip shroompog

#

i probably should add them as well

stone elm Apr 7, 2021, 9:09 PM

#

If you're downloading files through your mod then adding the shas to the modinstaller repo doesn't constitute verification

rough pulsar Apr 7, 2021, 9:09 PM

#

no

#

i'm not downloading files through my mod

#

the files ARE inside the zip

#

my mod will be moving those files to the Plugins folder

stone elm Apr 7, 2021, 9:10 PM

#

You aren't downloading the zip? Sorry, I didn't keep up in the last hour

rough pulsar Apr 7, 2021, 9:10 PM

#

do i have to add those files as well

#

i guess i will do so. tamershrug

#

though

#

since my mod will be moving those files...

#

what will happen if the modinstaller doesn't see the files in place?

stone elm Apr 7, 2021, 9:11 PM

#

If you are downloading any files through your mod then no, adding them does nothing.
If the files are packaged with your mod somehow, then yes add them.

#

Nothing, most likely

rough pulsar Apr 7, 2021, 9:11 PM

#

the files are packaged in my mod

#

like

#

this is the files inside the zip

#

x86 has 2 files

#

x86_64 has 5 files

stone elm Apr 7, 2021, 9:12 PM

#

Uhhh, I do not know if modinstaller does sha checks on files in subdirs... Let me look

rough pulsar Apr 7, 2021, 9:13 PM

#

like

#

do i have to add cases for them

stone elm Apr 7, 2021, 9:13 PM

#

I understand the question, I'm searching for the answer.

rough pulsar Apr 7, 2021, 9:14 PM

#

OK thanks

stone elm Apr 7, 2021, 9:16 PM

#

Yeah, looks like what you put up as an example should probably work.

rough pulsar Apr 7, 2021, 9:16 PM

#

hope it works

jolly oriole Apr 7, 2021, 9:18 PM

#

you don't need those, only things in the mods folder and the disabled folder are sha1 checked

#

but just to be sure i'd also add those

stone elm Apr 7, 2021, 9:21 PM

#

It (seems to) check them by using the filename as a relative path, so putting a folder in there seems like it'll work

#

I only spent 5 minutes looking at the source tho

rough pulsar Apr 7, 2021, 9:22 PM

#

#

jolly oriole Apr 7, 2021, 9:22 PM

#

i spent a bit just looking at https://github.com/ricardosouzag/ModInstaller/blob/master/ModInstaller/ModManager.cs#L836, maybe another method can handle subfolders

rough pulsar Apr 7, 2021, 9:25 PM

#

i added shitton of lines in modlinks.xml

jolly oriole Apr 7, 2021, 9:25 PM

#

and?

#

if it's necessary, so be it

rough pulsar Apr 7, 2021, 9:26 PM

#

those files are necessary for auto dependency to work

#

since it will

#

yknow

#

move those files into the plugins folder

#

also it has been a few months since i signed up for this zote

#

offtopic but i thought i would mention it

jolly oriole Apr 7, 2021, 9:38 PM

#

what's the easiest method to reset the ingame achievements of a machine? (don't worry, it's not AchievementHandler.ResetAllAchievements(), as that only resets the achievements of the steam/gog account)

floral blade Apr 8, 2021, 1:35 AM

#

anyone know how to get the input on the right stick of a controller ?

copper nacelle Apr 8, 2021, 1:48 AM

#

prob just use incontrol

#

I think there's a ref to the axis device somewhere in the input stuff

floral blade Apr 8, 2021, 1:50 AM

#

i mean left axis is sortof mapped to vertical and horizontal , dash button seems to mess up horizontal tho so i'm not sure

floral blade Apr 8, 2021, 1:53 AM

#

copper nacelle I think there's a ref to the axis device somewhere in the input stuff

is there any way to get this ?

copper nacelle Apr 8, 2021, 1:53 AM

#

I mean from what I remember there's a field

#

but I cba getting out of bed and actually finding it rn

floral blade Apr 8, 2021, 1:54 AM

#

could you point me in the direction of how i could find it ?

vocal spire Apr 8, 2021, 2:41 AM

#

floral blade could you point me in the direction of how i could find it ?

unity docs?

#

google?

floral blade Apr 8, 2021, 2:45 AM

#

just realised by running ILSpy on the dll that incontrol is already in the game

#

WAIT. you can basically see the entire code with ILSpy?

#

i thought it'll all be Assembly code

#

my world has just expanded i have world sense now

vocal spire Apr 8, 2021, 2:55 AM

#

smh

#

lol

#

how did you mod before?

floral blade Apr 8, 2021, 2:59 AM

#

vocal spire how did you mod before?

by asking you guys what things were?

#

and looking at existing mod's codes

#

to figure out what properties/methods exist

vocal spire Apr 8, 2021, 3:00 AM

#

🤔

#

makes sense

#

somebody should update the api docs

#

my excuse for not doing it: bad at github

floral blade Apr 8, 2021, 3:03 AM

#

now should this not work ?

#

i get 0 values for both of these

floral blade Apr 8, 2021, 3:05 AM

#

vocal spire somebody should update the api docs

yeah especially for Macs 😅 i think i am using older version of mod api because i wasn't able to compile it with c# 9

vocal spire Apr 8, 2021, 3:07 AM

#

floral blade now should this not work ?

how are you logging that. 2. try setting the device property in the listenForInput method

floral blade Apr 8, 2021, 3:09 AM

#

Logger.Info logs to modlog , imma try the second one

vocal spire Apr 8, 2021, 3:10 AM

#

floral blade Logger.Info logs to modlog , imma try the second one

I should of said when

floral blade Apr 8, 2021, 3:12 AM

#

vocal spire I should of said when

listenForInput runs everyframe, and setting device in that function worked, i guess i was setting it before it was initialised

vocal spire Apr 8, 2021, 3:18 AM

#

Ok

#

nice

floral blade Apr 8, 2021, 3:19 AM

#

thanks for the help hollowblob

vocal spire Apr 8, 2021, 3:24 AM

#

np

rough pulsar Apr 8, 2021, 8:44 AM

#

so

#

i think i should destroy the GameObject i created

#

that runs the Update() function

#

which is one of the two methods that have Discord related code

#

idrk

#

might try that

jolly oriole Apr 8, 2021, 8:46 AM

#

if you want it toggleable, maybe just set the gameobject inactive in unload and active in initialize

rough pulsar Apr 8, 2021, 8:46 AM

#

do the variables persist through toggled off states?

jolly oriole Apr 8, 2021, 8:46 AM

#

yea

#

it's just that e.g. update doesn't run while the go is inactive

rough pulsar Apr 8, 2021, 8:46 AM

#

does it run the Initialize() function when i toggle it back on?

light zodiac Apr 8, 2021, 8:47 AM

#

your unload is empty zote

jolly oriole Apr 8, 2021, 8:47 AM

#

yes, you'd need code to check for an existing instance

rough pulsar Apr 8, 2021, 8:47 AM

#

light zodiac your unload is empty <:zote:562358113374568477>

i just emptied it before publishing it zote

#

modinstaller doesn't install things from subfolders inside zips!!!! oh no!!!!

#

what do i do now

cedar hemlock Apr 8, 2021, 8:54 AM

#

what

#

why not

rough pulsar Apr 8, 2021, 8:54 AM

#

i don't know

cedar hemlock Apr 8, 2021, 8:55 AM

#

put a zip in a zip

rough pulsar Apr 8, 2021, 8:55 AM

#

i added the <File> stuff for each file, inside subfolders too

cedar hemlock Apr 8, 2021, 8:55 AM

#

problem fixed

rough pulsar Apr 8, 2021, 8:55 AM

#

cedar hemlock put a zip in a zip

does the modinstaller extract zips inside zips or my mod has to do it itself?

cedar hemlock Apr 8, 2021, 8:56 AM

#

your mod has to do it afaik

#

sadly

jolly oriole Apr 8, 2021, 8:56 AM

#

you could simply ask @copper nacelle if it should work like you did or if you have to do that yourself

cedar hemlock Apr 8, 2021, 8:56 AM

#

~~(my solutions aren't great)~~

rough pulsar Apr 8, 2021, 8:57 AM

#

you already pinged 56

cedar hemlock Apr 8, 2021, 8:57 AM

#

yes

rough pulsar Apr 8, 2021, 8:57 AM

#

i don't think they are online

cedar hemlock Apr 8, 2021, 8:57 AM

#

he did

rough pulsar Apr 8, 2021, 8:57 AM

#

they are DND but

#

not online

cedar hemlock Apr 8, 2021, 8:57 AM

#

just wait

#

he'll see it

#

~~eventually~~

light zodiac Apr 8, 2021, 8:58 AM

#

rough pulsar modinstaller doesn't install things from subfolders inside zips!!!! oh no!!!!

The pr isn't merged yet

cedar hemlock Apr 8, 2021, 8:58 AM

#

lol

jolly oriole Apr 8, 2021, 8:58 AM

#

i can't remember the last time 56 wasn't dnd

jolly oriole Apr 8, 2021, 8:59 AM

#

light zodiac The pr isn't merged yet

could also be the reason

cedar hemlock Apr 8, 2021, 8:59 AM

#

SF merge it

rough pulsar Apr 8, 2021, 8:59 AM

#

wait isn't the pr merged

cedar hemlock Apr 8, 2021, 8:59 AM

#

this is interesting

rough pulsar Apr 8, 2021, 8:59 AM

#

sf can't you just

#

merge it

jolly oriole Apr 8, 2021, 8:59 AM

#

i can't merge

cedar hemlock Apr 8, 2021, 8:59 AM

#

rough pulsar wait isn't the pr merged

they dont merge instantly

rough pulsar Apr 8, 2021, 9:00 AM

#

i know

cedar hemlock Apr 8, 2021, 9:00 AM

#

jolly oriole i can't merge

why not lol

rough pulsar Apr 8, 2021, 9:00 AM

#

56 usually* merges in like

#

few or several hours after

cedar hemlock Apr 8, 2021, 9:00 AM

#

5 days

rough pulsar Apr 8, 2021, 9:00 AM

#

the PR

cedar hemlock Apr 8, 2021, 9:00 AM

#

one more *

#

too much *

rough pulsar Apr 8, 2021, 9:01 AM

#

what even is this mod

cedar hemlock Apr 8, 2021, 9:01 AM

#

yes

jolly oriole Apr 8, 2021, 9:01 AM

#

plando

cedar hemlock Apr 8, 2021, 9:01 AM

#

it changes item based on xml

light zodiac Apr 8, 2021, 9:01 AM

#

Readme docs
https://docs.google.com/document/d/1NmYCR8diRropqFDm9-n1aR0_XuQSHRdfxgsY4WrVmSs/edit?usp=sharing

cedar hemlock Apr 8, 2021, 9:01 AM

#

we need that pinned

jolly oriole Apr 8, 2021, 9:01 AM

#

unsolicited links smh

cedar hemlock Apr 8, 2021, 9:02 AM

#

random links are fun

light zodiac Apr 8, 2021, 9:02 AM

#

jolly oriole unsolicited links smh

fixed

cedar hemlock Apr 8, 2021, 9:02 AM

#

make it a bit.ly

light zodiac Apr 8, 2021, 9:03 AM

#

if someone gave a bit.ly link i wouldnt click it

jolly oriole Apr 8, 2021, 9:03 AM

#

for visibility:
https://github.com/ricardosouzag/ModInstaller/pull/82
https://github.com/ricardosouzag/ModInstaller/pull/83

cedar hemlock Apr 8, 2021, 9:03 AM

#

light zodiac if someone gave a bit.ly link i wouldnt click it

true

rough pulsar Apr 8, 2021, 9:04 AM

#

56 wya

#

smh

cedar hemlock Apr 8, 2021, 9:07 AM

#

how do i see who can merge

rough pulsar Apr 8, 2021, 9:12 AM

#

collaborators?

cedar hemlock Apr 8, 2021, 9:12 AM

#

SFG is there and he cant merge

#

i am there, you are there

#

we cant merge

#

(can people with merge powers merge their own thing?)

light zodiac Apr 8, 2021, 9:13 AM

#

that's contributors

cedar hemlock Apr 8, 2021, 9:14 AM

#

afaik the guys who can merge are:

#

56

#

gradow

#

homothetyhk

#

sry for typo's

rough pulsar Apr 8, 2021, 9:15 AM

#

cedar hemlock (can people with merge powers merge their own thing?)

collaborators don't need to make PRs to commit

#

they can just...

#

commit

cedar hemlock Apr 8, 2021, 9:16 AM

#

i saw homothety do it

#

he made a pr then merged it

#

idk why

#

~~(or am i stupid again)~~

rough pulsar Apr 8, 2021, 9:16 AM

#

contributors are only contributors

#

the ones that have committed previously

#

they don't gain any power of some sort

#

afaik

cedar hemlock Apr 8, 2021, 9:17 AM

#

nope

rough pulsar Apr 8, 2021, 9:17 AM

#

except the cool contributor badge

cedar hemlock Apr 8, 2021, 9:17 AM

#

yes

#

cool

#

is there a github page for modinstaller2?

#

or only the .exe's in the pins?

rough pulsar Apr 8, 2021, 9:20 AM

#

https://github.com/fifty-six/Modinstaller2

#

yeet

#

the embed

cedar hemlock Apr 8, 2021, 9:21 AM

#

why can you not yeet embeds in mobile

#

its just suffering

rough pulsar Apr 8, 2021, 9:21 AM

#

just do

#

https://google.com

cedar hemlock Apr 8, 2021, 9:22 AM

#

https://yeetembeds.nl

#

amazing

rough pulsar Apr 8, 2021, 9:51 AM

#

do these two variables do anything?

rough pulsar Apr 8, 2021, 10:13 AM

#

ok so i want to know

#

can you load into Godhome safely with LoadScene()

cedar hemlock Apr 8, 2021, 10:18 AM

#

where would it place you

jolly oriole Apr 8, 2021, 10:20 AM

#

no

copper nacelle Apr 8, 2021, 10:28 AM

#

good morning

#

that's not going to work with installer1 no

#

I think it would with installer2

floral blade Apr 8, 2021, 10:30 AM

#

copper nacelle good morning

morning , i just unlocked new super powers yesterday after you'd left sherma

copper nacelle Apr 8, 2021, 10:30 AM

#

But the first one just iterates over the zip contents and puts the dll in mods with 0 regards for folder structure

#

nice

rough pulsar Apr 8, 2021, 10:33 AM

#

also @copper nacelle would this work, in order to get whether broken vessel is defeated?

#

if not what should i do

copper nacelle Apr 8, 2021, 10:36 AM

#

this ain't it

#

there's straight up a killed bool

rough pulsar Apr 8, 2021, 10:36 AM

#

well

#

what string do i use

jolly oriole Apr 8, 2021, 10:36 AM

#

GetVariable<idkwhattype>("whatever that statue thing is called").isUnlocked

rough pulsar Apr 8, 2021, 10:36 AM

#

to check if broken vessel dead

jolly oriole Apr 8, 2021, 10:37 AM

#

then getbool(killedbrokenvessel) probs

rough pulsar Apr 8, 2021, 10:37 AM

#

i don't think i know what i'm doing

#

i completely lost my mind nvm a a a a a a

midnight canyon Apr 8, 2021, 10:40 AM

#

PlayerData.instance.killedInfectedKnight?

rough pulsar Apr 8, 2021, 10:41 AM

#

how do you manually save the game inside the mod

copper nacelle Apr 8, 2021, 10:42 AM

#

I think you'd just call SaveGame on GameManager but haven't ever tried

jolly oriole Apr 8, 2021, 10:42 AM

#

why would you need to manually save the game?

jolly oriole Apr 8, 2021, 10:43 AM

#

midnight canyon `PlayerData.instance.killedInfectedKnight`?

and to this, shouldn't one do PlayerData.instance.GetBool("killedInfectedKnight") instead?

rough pulsar Apr 8, 2021, 10:45 AM

#

huh

#

ok

#

i NEVER realized GameManager exists

midnight canyon Apr 8, 2021, 10:46 AM

#

jolly oriole and to this, shouldn't one do `PlayerData.instance.GetBool("killedInfectedKnight...

I haven't needed .GetBool() or anything of the sort yet so you're probably right

floral blade Apr 8, 2021, 10:49 AM

#

if i were to let the player spawn objects on the screen, but not infinitely does it make sense to have an array of go's that i just reuse by resetting them ?
do i have to initialise them all to new go's if i do :

private GameObject[] pool = new GameObject[25];

copper nacelle Apr 8, 2021, 10:50 AM

#

yeah

#

to both

floral blade Apr 8, 2021, 10:51 AM

#

so the new keyword here only makes a new array with null values , hmm

fair rampart Apr 8, 2021, 10:51 AM

#

Just asking where do you make your mods?

copper nacelle Apr 8, 2021, 10:53 AM

#

what does this mean