#archived-modding-development | Hollow Knight | Page 507

vocal spire Mar 19, 2021, 1:33 PM

#

Did you make sure to build the mod again?

cedar hemlock Mar 19, 2021, 1:34 PM

#

ehm

#

shit

#

im stoopid

#

[INFO]:[Thing] - SceneIsValid
[ERROR]:[UNITY] - NullReferenceException: Object reference not set to an instance of an object
[ERROR]:[UNITY] - TransHK.Rareclass.Find (Scene scene, System.String name)
[ERROR]:[UNITY] - TransHK.TransMod+<SetSprite>d__5.MoveNext ()
[ERROR]:[UNITY] - UnityEngine.SetupCoroutine.InvokeMoveNext (IEnumerator enumerator, IntPtr returnValueAddress)
[ERROR]:[UNITY] - UnityEngine.MonoBehaviour:StartCoroutine(IEnumerator)
[ERROR]:[UNITY] - TransHK.TransMod:SceneChanged(Scene, Scene)
[ERROR]:[UNITY] - UnityEngine.SceneManagement.SceneManager:UnloadScene(String)
[ERROR]:[UNITY] - <BeginSceneTransitionRoutine>c__AnonStorey13:<>m__2()
[ERROR]:[UNITY] - <BeginRoutine>c__Iterator0:MoveNext()
[ERROR]:[UNITY] - UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
[ERROR]:[UNITY] - 
[INFO]:[TransMod] - Scenechanged

#

📎 ModLog.txt

vocal spire Mar 19, 2021, 1:38 PM

#

Well

cedar hemlock Mar 19, 2021, 1:39 PM

#

it starts right at

Log("SceneIsValid");
                GameObject retGo;
                foreach (var go in scene.GetRootGameObjects())
                {
                    if (go.name == name)
                    {
                        Log("if (go.name == name)");
                        return go;
                    }
                    retGo = go.transform.Find(name).gameObject;
                    if (retGo != null)
                    {
                        Log("if retGo != null");
                        return retGo;
                    }
                }

vocal spire Mar 19, 2021, 1:40 PM

#

Ohhh I think I see the problem

#

Let me rewrite something for you

#

public static class Rareclass
    {
        public static void Log(string s)
        {
            Modding.Logger.Log($"[Thing] - {s}");
        }
        public static GameObject Find(this Scene scene, string name)
        {
            Log("NewMethodCalled");
            if (scene.IsValid())
            {
                Log("SceneIsValid");
                Transform retGo;
                foreach (var go in scene.GetRootGameObjects())
                {
                    if (go.name == name)
                    {
                        Log("if (go.name == name)");
                        return go;
                    }
                    retGo = go.transform.Find(name);
                    if (retGo != null)
                    {
                        Log("if retGo != null");
                        return retGo.gameObject;
                    }
                }
            }
            return null;
        }
    }

cedar hemlock Mar 19, 2021, 1:42 PM

#

omgomg

#

finally

#

thysm

jolly oriole Mar 19, 2021, 1:43 PM

#

uhm, i may forgot unity 2017 quircks

#

as retGo = go.transform.Find(name); can give null

#

@jolly oriole fix that when you're home

cedar hemlock Mar 19, 2021, 1:45 PM

#

so if i want to change sprites of bosses, i have to:
1 . change if (arg1.name != "Room_Final_Boss_Core") return; to the correct scene
2. change var boss = arg1.Find("Hollow Knight Boss"); to the right name
Right?

vocal spire Mar 19, 2021, 1:46 PM

#

There are many ways to do it

#

That is one of them

cedar hemlock Mar 19, 2021, 1:46 PM

#

ok

#

so this gonna be in customknight+ ? lol

vocal spire Mar 19, 2021, 2:01 PM

#

Nah frogcore

#

Oh you mean replacing sprites?

#

Maybe

#

Anyways time to update frogcore on the installer since it’s been broken for a while now

#

Also gonna add some ez tk2d sprite replacement stuff

cedar hemlock Mar 19, 2021, 2:06 PM

#

imma make it so the scene and boss arent hardcoded

vocal spire Mar 19, 2021, 2:07 PM

#

Where did I leave the frogcore source

cedar hemlock Mar 19, 2021, 2:07 PM

#

idk

vocal spire Mar 19, 2021, 2:07 PM

#

Found

#

Time to make people fear me

#

With the power

#

Of frog

cedar hemlock Mar 19, 2021, 2:08 PM

#

nice

vocal spire Mar 19, 2021, 2:09 PM

#

Jk frogcore is tiny compared to other core mods

vocal spire Mar 19, 2021, 2:11 PM

#

vocal spire Of frog

What’s wrong with frog?

cedar hemlock Mar 19, 2021, 2:13 PM

#

it has to be capital

#

F

#

bruh whats wrong withstring selectedBoss = "Hollow Knight Boss";

#

nvm

jolly jungle Mar 19, 2021, 2:50 PM

#

vocal spire > <:knightno:722660227144482856> What’s wrong with frog?

Nah it was a reply to the sentence as a whole

#

Time to make people fear me
With the power
Of frog

cedar hemlock Mar 19, 2021, 3:22 PM

#

why is it when i click in the middle of the line when i type it replaces stuff that is already there

jolly oriole Mar 19, 2021, 3:41 PM

#

when the insert key was pressed, the cursor slightly changes and the typing is change to replace the text at the current position

cedar hemlock Mar 19, 2021, 3:43 PM

#

oh

#

i must have accidently pressed it

jolly oriole Mar 19, 2021, 4:01 PM

#

@cedar hemlock
it's easy, just requires this nonsense

private void SceneChanged(Scene arg0, Scene arg1)
{
    if (arg1.name != "Room_Final_Boss_Core") return;
    GameManager.instance.StartCoroutine(SetSprite());

    // Change audio
    var sm = arg1.Find("_SceneManager").GetComponent<SceneManager>();
    var mc = sm.GetAttr<SceneManager, MusicCue>("musicCue");
    var ci = mc.GetAttr<MusicCue, MusicCue.MusicChannelInfo[]>("channelInfos");

    // ToDo replace null with custom audioclip
    ci[MusicChannels.Main].SetAttr<MusicCue.MusicChannelInfo, AudioClip>("clip", null);
    // ToDo replace null with custom audioclip
    ci[MusicChannels.MainAlt].SetAttr<MusicCue.MusicChannelInfo, AudioClip>("clip", null);
    // ToDo replace null with custom audioclip
    ci[MusicChannels.Action].SetAttr<MusicCue.MusicChannelInfo, AudioClip>("clip", null);
    // ToDo replace null with custom audioclip
    ci[MusicChannels.Sub].SetAttr<MusicCue.MusicChannelInfo, AudioClip>("clip", null);
    // ToDo replace null with custom audioclip
    ci[MusicChannels.Tension].SetAttr<MusicCue.MusicChannelInfo, AudioClip>("clip", null);
    // ToDo replace null with custom audioclip
    ci[MusicChannels.Extra].SetAttr<MusicCue.MusicChannelInfo, AudioClip>("clip", null);

    mc.SetAttr<MusicCue, MusicCue.MusicChannelInfo[]>("channelInfos", ci);
    sm.SetAttr<SceneManager, MusicCue>("musicCue", mc);
}

with the first 4 lines (and the last one) already existing

cedar hemlock Mar 19, 2021, 4:01 PM

#

nice

#

95 errors shroompog

jolly oriole Mar 19, 2021, 4:03 PM

#

poggers

cedar hemlock Mar 19, 2021, 4:03 PM

#

lemme change some things

#

14 a lil better

#

8...

#

Error CS1069 The type name 'AudioClip' could not be found in the namespace 'UnityEngine'. This type has been forwarded to assembly 'UnityEngine.AudioModule, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' Consider adding a reference to that assembly.

#

a bunch of times

#

so i just add the reference for this right?

#

2 now..

#

2 times this:

#

do you know what reference i need to add?

stone elm Mar 19, 2021, 4:14 PM

#

Visual studio has helpful hints if it detects the reference you're looking for. Look for the lighbulb at the left of the line.

jolly oriole Mar 19, 2021, 4:15 PM

#

either modcommon, ~~sfcore~~ or maybe vasi (honestly don't know about this one)

#

but le me check if theres a no dependency workaround for that

stone elm Mar 19, 2021, 4:15 PM

#

There's a small chance VS figured it out, but if the assembly isn't there in the first place then yeah

cedar hemlock Mar 19, 2021, 4:15 PM

#

i dont see an lightbulb

stone elm Mar 19, 2021, 4:16 PM

#

Then maybe it doesn't know. Was just a thought. I'm just trying to throw out tips since you seem new to VS and C#.

cedar hemlock Mar 19, 2021, 4:17 PM

#

yeah i can a bit java so i know a bit c#

stone elm Mar 19, 2021, 4:18 PM

#

Well, you know the syntax well enough. There are enough fundamental differences that it probably feels a little tough I imagine. A weird difference here or there

jolly oriole Mar 19, 2021, 4:18 PM

#

cedar hemlock ```Error CS1061 'SceneManager' does not contain a definition for 'SetAttr'...

but at this point i'd suggest referencing modcommon to do that, makes a lot of things easier

cedar hemlock Mar 19, 2021, 4:18 PM

#

yeah i was helping someone so i am a bit busy :)

#

hmm

#

modcommon doesnt work

#

vasi then

#

still nothing

jolly oriole Mar 19, 2021, 4:24 PM

#

hm

#

modcommon should have that afaik

#

oh wow

cedar hemlock Mar 19, 2021, 4:25 PM

#

TransMod_-_Microsoft_Visual_Studio_19-3-2021_17_24_57.png

jolly oriole Mar 19, 2021, 4:26 PM

#

Modding.ReflectionHelper.SetAttr(theObjectToChange, "nameOfTheField", valueYouWantSet, true);

cedar hemlock Mar 19, 2021, 4:26 PM

#

hm

#

do i place that in scenechanged?

#

and what do i want to change, whats the field, whats the value

jolly oriole Mar 19, 2021, 4:30 PM

#

1 sec

cedar hemlock Mar 19, 2021, 4:30 PM

#

it your code so you prob know :)

jolly oriole Mar 19, 2021, 4:33 PM

#

private void SceneChanged(Scene arg0, Scene arg1)
{
    if (arg1.name != "Room_Final_Boss_Core") return;
    GameManager.instance.StartCoroutine(SetSprite());

    // Change audio
    var sm = arg1.Find("_SceneManager").GetComponent<SceneManager>();
    var mc = Modding.ReflectionHelper.GetAttr<SceneManager, MusicCue>(sm, "musicCue");
    var ci = Modding.ReflectionHelper.GetAttr<MusicCue, MusicCue.MusicChannelInfo[]>(mc, "channelInfos");

    // ToDo replace null with custom audioclip
    Modding.ReflectionHelper.SetAttr(ci[MusicChannels.Main], "clip", null);
    // ToDo replace null with custom audioclip
    Modding.ReflectionHelper.SetAttr(ci[MusicChannels.MainAlt], "clip", null);
    // ToDo replace null with custom audioclip
    Modding.ReflectionHelper.SetAttr(ci[MusicChannels.Action], "clip", null);
    // ToDo replace null with custom audioclip
    Modding.ReflectionHelper.SetAttr(ci[MusicChannels.Sub], "clip", null);
    // ToDo replace null with custom audioclip
    Modding.ReflectionHelper.SetAttr(ci[MusicChannels.Tension], "clip", null);
    // ToDo replace null with custom audioclip
    Modding.ReflectionHelper.SetAttr(ci[MusicChannels.Extra], "clip", null);

    Modding.ReflectionHelper.SetAttr(mc, "channelInfos", ci);
    Modding.ReflectionHelper.SetAttr(sm, "musicCue", mc);
}

cedar hemlock Mar 19, 2021, 4:35 PM

#

and:

#

Error    CS0411    The type arguments for method 'ReflectionHelper.SetAttr<TObject, TField>(TObject, string, TField)' cannot be inferred from the usage. Try specifying the type arguments explicitly.

jolly oriole Mar 19, 2021, 4:36 PM

#

cedar hemlock ```Error CS0266 Cannot implicitly convert type 'MusicChannels' to 'int'. A...

oh yea, but hovering should give you an option to put a cast there, you can do that

jolly oriole Mar 19, 2021, 4:36 PM

#

cedar hemlock ``` Error CS0411 The type arguments for method 'ReflectionHelper.SetAttr<T...

yea, let me quickly change those 6 lines

#

the 6 lines

// ToDo replace null with custom audioclip
Modding.ReflectionHelper.SetAttr(ci[(int) MusicChannels.Main], "clip", (AudioClip) null);
// ToDo replace null with custom audioclip
Modding.ReflectionHelper.SetAttr(ci[(int) MusicChannels.MainAlt], "clip", (AudioClip) null);
// ToDo replace null with custom audioclip
Modding.ReflectionHelper.SetAttr(ci[(int) MusicChannels.Action], "clip", (AudioClip) null);
// ToDo replace null with custom audioclip
Modding.ReflectionHelper.SetAttr(ci[(int) MusicChannels.Sub], "clip", (AudioClip) null);
// ToDo replace null with custom audioclip
Modding.ReflectionHelper.SetAttr(ci[(int) MusicChannels.Tension], "clip", (AudioClip) null);
// ToDo replace null with custom audioclip
Modding.ReflectionHelper.SetAttr(ci[(int) MusicChannels.Extra], "clip", (AudioClip) null);

cedar hemlock Mar 19, 2021, 4:38 PM

#

hovering over it

#

it says alt-enter

#

add explicit cast...

jolly oriole Mar 19, 2021, 4:39 PM

#

also good

#

yes

cedar hemlock Mar 19, 2021, 4:39 PM

#

i clicked it and did nothing

#

nothing

jolly oriole Mar 19, 2021, 4:40 PM

#

fixed the code a bit above, should have everything

cedar hemlock Mar 19, 2021, 4:40 PM

#

jolly oriole oh yea, but hovering should give you an option to put a cast there, you can do t...

why did this not work

#

did i do something wrong?

jolly oriole Mar 19, 2021, 4:41 PM

#

vs being vs, idk

cedar hemlock Mar 19, 2021, 4:42 PM

#

so do i place an audio file in mods or will there be an folder

jolly oriole Mar 19, 2021, 4:43 PM

#

you can load an audioclip in any way, shape or form unity provides and pass it as one (or multiple) of the null parameters

vocal spire Mar 19, 2021, 4:43 PM

#

I suggest assetbundling

jolly oriole Mar 19, 2021, 4:43 PM

#

assetbundling for a single audioclip sux ass

cedar hemlock Mar 19, 2021, 4:43 PM

#

wait

vocal spire Mar 19, 2021, 4:43 PM

#

good point

jolly oriole Mar 19, 2021, 4:43 PM

#

although for thk it would be 6-7, at which point it could be good again

cedar hemlock Mar 19, 2021, 4:44 PM

#

cedar hemlock so do i place an audio file in mods or will there be an folder

can i just place the audio file in mods or can i do it in a folder or do i need to do smth to the wav

vocal spire Mar 19, 2021, 4:44 PM

#

how are you loading it?

cedar hemlock Mar 19, 2021, 4:44 PM

#

okay from the beginning

#

i place the .dll in mods

vocal spire Mar 19, 2021, 4:45 PM

#

well how are you loading the audio file in the dll

cedar hemlock Mar 19, 2021, 4:45 PM

#

oh do i need to do the same as the image

vocal spire Mar 19, 2021, 4:45 PM

#

nah

#

but I suggest doing that since you don't have to give out anything more than a dll

cedar hemlock Mar 19, 2021, 4:46 PM

#

ok but if i want do do it only for myself can i just place the wav in mods?

vocal spire Mar 19, 2021, 4:46 PM

#

yes

cedar hemlock Mar 19, 2021, 4:46 PM

#

okay

vocal spire Mar 19, 2021, 4:46 PM

#

but you need to load the file from there

#

unlike loading from the resources like the image

cedar hemlock Mar 19, 2021, 4:47 PM

#

so how do i tell it the wav is in ... ?

vocal spire Mar 19, 2021, 4:47 PM

#

well I closed visual studio so I'll type from memory

cedar hemlock Mar 19, 2021, 4:47 PM

#

nice

vocal spire Mar 19, 2021, 4:48 PM

#

Path.WithoutExtention(Path.WithoutExtention(Assembly.GetExecutingAssembly().Name.FullName)))I think

cedar hemlock Mar 19, 2021, 4:49 PM

#

do i type the path at FullName?

#

oh and where

vocal spire Mar 19, 2021, 4:49 PM

#

or Assembly.GetExecutingAssembly().Name.FullName + @"\..\..\"

cedar hemlock Mar 19, 2021, 4:50 PM

#

in the scene changed?

vocal spire Mar 19, 2021, 4:50 PM

#

cedar hemlock oh and where

where you load the file, it's the path you put in

vocal spire Mar 19, 2021, 4:50 PM

#

cedar hemlock in the scene changed?

nonono

vocal spire Mar 19, 2021, 4:50 PM

#

cedar hemlock do i type the path at FullName?

no

#

fine, I'll open visual studio again

cedar hemlock Mar 19, 2021, 4:50 PM

#

lol

vocal spire Mar 19, 2021, 4:55 PM

#

File.ReadAllBytes(Assembly.GetExecutingAssembly().Location + @"\..\filename");

cedar hemlock Mar 19, 2021, 4:56 PM

#

at ..\ i place the path

vocal spire Mar 19, 2021, 4:56 PM

#

this will return a byte array that you can put in one of WavUtility's methods

vocal spire Mar 19, 2021, 4:56 PM

#

cedar hemlock at \..\ i place the path

no

#

place the file name

#

currently it gets the path to the mods folder by getting the path to the dll file(contains the dll file's name)

cedar hemlock Mar 19, 2021, 4:56 PM

#

File.ReadAllBytes(Assembly.GetExecutingAssembly().Location + @"\PathHere?\filename duh");

vocal spire Mar 19, 2021, 4:57 PM

#

no

cedar hemlock Mar 19, 2021, 4:57 PM

#

hmm

#

okay so only the filename needs to be changed

vocal spire Mar 19, 2021, 4:57 PM

#

Assembly.GetExecutingAssembly().Location + @"\..\" gets you to the mods folder

cedar hemlock Mar 19, 2021, 4:58 PM

#

Assembly.GetExecutingAssembly().Location + @"\..\hereifiwanttodoitinanotherfolder\Filename"

#

right?

vocal spire Mar 19, 2021, 4:59 PM

#

yes

cedar hemlock Mar 19, 2021, 4:59 PM

#

okay

#

then how do i do it into the Modding.ReflectionHelper ?

vocal spire Mar 19, 2021, 5:00 PM

#

do you have WavUtilityyet

cedar hemlock Mar 19, 2021, 5:00 PM

#

nope

vocal spire Mar 19, 2021, 5:00 PM

#

vocal spire ```File.ReadAllBytes(Assembly.GetExecutingAssembly().Location + @"\..\filename")...

you need to put the bytes from this into one of it's methods

cedar hemlock Mar 19, 2021, 5:01 PM

#

which one?```
var sm = arg1.Find("_SceneManager").GetComponent<SceneManager>();
var mc = Modding.ReflectionHelper.GetAttr<SceneManager, MusicCue>(sm, "musicCue");
var ci = Modding.ReflectionHelper.GetAttr<MusicCue, MusicCue.MusicChannelInfo[]>(mc, "channelInfos");

vocal spire Mar 19, 2021, 5:02 PM

#

add this class to your project
https://github.com/deadlyfingers/UnityWav/blob/master/WavUtility.cs

GitHub

deadlyfingers/UnityWav

WAV utility for saving and loading wav files in Unity - deadlyfingers/UnityWav

cedar hemlock Mar 19, 2021, 5:02 PM

#

ehm

#

all of that?

jolly oriole Mar 19, 2021, 5:02 PM

#

that's btw broken for anything loaded from memory, untiy paths and multichannel

vocal spire Mar 19, 2021, 5:02 PM

#

oh

#

cool

#

now I know why it didn't work before

#

it's probably better I switched to assetbundling anyways since it was a lot of audio clips

cedar hemlock Mar 19, 2021, 5:03 PM

#

cedar hemlock *all* of that?

?

vocal spire Mar 19, 2021, 5:03 PM

#

yes

#

use the ToAudioClip method with the path as the perameter

cedar hemlock Mar 19, 2021, 5:04 PM

#

all

#

wth

vocal spire Mar 19, 2021, 5:04 PM

#

yes

#

probably

cedar hemlock Mar 19, 2021, 5:04 PM

#

all 400 lines lol

vocal spire Mar 19, 2021, 5:05 PM

#

unless you want to erase anything not used by the method I described or the methods used by that and so on

vocal spire Mar 19, 2021, 5:05 PM

#

cedar hemlock all 400 lines lol

welcome to code

cedar hemlock Mar 19, 2021, 5:05 PM

#

65 errors zote

vocal spire Mar 19, 2021, 5:05 PM

#

you need to reference unityengine.audiomodule or something btw

#

well I gtg

#

see ya

cedar hemlock Mar 19, 2021, 5:06 PM

#

that needed for sfgrenades to so i already have it

cedar hemlock Mar 19, 2021, 5:06 PM

#

vocal spire see ya

bye

#

a lot of shit doesn't exist in the current context

vocal spire Mar 19, 2021, 5:07 PM

#

Back

#

Can you show the exact errors

cedar hemlock Mar 19, 2021, 5:07 PM

#

speed

vocal spire Mar 19, 2021, 5:08 PM

#

Yes

cedar hemlock Mar 19, 2021, 5:08 PM

#

ok wait a se

#

c

#

fixed it

#

i needed using System; and using System.Text;

stone elm Mar 19, 2021, 5:09 PM

#

Those are the kinds of things visual studio can fill in for you

cedar hemlock Mar 19, 2021, 5:10 PM

#

yeah i didn't look for the lightbulb

#

i just looked at the source

vocal spire Mar 19, 2021, 5:10 PM

#

lol

stone elm Mar 19, 2021, 5:10 PM

#

https://docs.microsoft.com/en-us/visualstudio/ide/common-quick-actions?view=vs-2019

vocal spire Mar 19, 2021, 5:10 PM

#

Always look at the lightbulb

stone elm Mar 19, 2021, 5:10 PM

#

Well, you can do things the hard way or use the IDE

jolly oriole Mar 19, 2021, 5:10 PM

#

never use ide

#

always write code in discord chat

vocal spire Mar 19, 2021, 5:11 PM

#

Well that’s 1/2 my life at this point

stone elm Mar 19, 2021, 5:11 PM

#

jolly oriole always write code in discord chat

only the craziest

vocal spire Mar 19, 2021, 5:11 PM

#

Write code in discord

stone elm Mar 19, 2021, 5:11 PM

#

I knew a guy that wrote ASP classic in notepad to make a web game... It scared me.

jolly oriole Mar 19, 2021, 5:11 PM

#

stone elm only the craziest

<#archived-modding-development message>

stone elm Mar 19, 2021, 5:12 PM

#

jolly oriole <https://discord.com/channels/283467363729408000/327461802311155714/822508143811...

I require no proof of your black magic

cedar hemlock Mar 19, 2021, 5:12 PM

#

lol

vocal spire Mar 19, 2021, 5:12 PM

#

stone elm I knew a guy that wrote ASP classic in notepad to make a web game... It scared m...

I was writing in notepad on my school pc for unity for a while

stone elm Mar 19, 2021, 5:13 PM

#

That almost sounds like you had no choice, since school pcs can be locked down. But still, though, way too much effort for me. The most basic I've gone is vscode. I'm a poser. zotedisgust

vocal spire Mar 19, 2021, 5:14 PM

#

I got vscode eventually tho. Slightly better

prime urchin Mar 19, 2021, 5:14 PM

#

only slightly? basic notepad is a nightmare

cedar hemlock Mar 19, 2021, 5:14 PM

#

how do i add the Wavutil or whatever

vocal spire Mar 19, 2021, 5:15 PM

#

You copy everything in the GitHub file and paste it in a .cs file in visual studio

cedar hemlock Mar 19, 2021, 5:15 PM

#

no

#

i meant something else

#

ehm

vocal spire Mar 19, 2021, 5:15 PM

#

Getting a audio clip from it?

cedar hemlock Mar 19, 2021, 5:16 PM

#

how do i get the bites into the things that need it

vocal spire Mar 19, 2021, 5:16 PM

#

vocal spire Getting a audio clip from it?

Aka this

cedar hemlock Mar 19, 2021, 5:16 PM

#

or does it go automaticly using wavutils

vocal spire Mar 19, 2021, 5:16 PM

#

Just do AudioClip myclip = WavUtility.ToAudioClip(path);

#

Grenade said the bytes way doesn’t work

cedar hemlock Mar 19, 2021, 5:17 PM

#

oh okay

#

do i need the @ ?

jolly oriole Mar 19, 2021, 5:17 PM

#

https://raw.githubusercontent.com/SFGrenade/CustomBgm/master/WavUtility.cs this one has everything working afaik

vocal spire Mar 19, 2021, 5:18 PM

#

Yay

vocal spire Mar 19, 2021, 5:18 PM

#

cedar hemlock do i need the @ ?

Yes, also the assembly stuff since that’s part of the path

cedar hemlock Mar 19, 2021, 5:19 PM

#

ok i gtg now

#

thanx for the help!

vocal spire Mar 19, 2021, 5:19 PM

#

Np

cedar hemlock Mar 19, 2021, 6:00 PM

#

Oh and btw if i want to change sprites of multiple enemies can that be done in one cs or do i need to make multiple

#

I meant that can you define that you want img 1 fir this and img 2 for that etc

light zodiac Mar 19, 2021, 6:14 PM

#

When i write the line

public class ClassName : Mod, ITogglableMod

It gives me this error:
error CS0535: 'ClassName' does not implement interface member 'ITogglableMod.Unload()'

Can someone help me with this

steady comet Mar 19, 2021, 6:16 PM

#

light zodiac When i write the line ```cs public class ClassName : Mod, ITogglableMod ``` It g...

You need to implement the "Unload" method if you want it to be an ITogglableMod - an example of what this would look like is e.g. here https://github.com/homothetyhk/HollowKnight.InfiniteNotches/blob/master/InfiniteNotches/InfiniteNotches.cs

light zodiac Mar 19, 2021, 6:18 PM

#

So in that method I only do -= the function I want to run?

steady comet Mar 19, 2021, 6:19 PM

#

Basically, in Unload you reverse everything you do in Initialize

#

So if there's only one function you want your mod to run while it's loaded, then you should just -= that function in the unload

light zodiac Mar 19, 2021, 6:21 PM

#

Thank you

cedar hemlock Mar 19, 2021, 7:18 PM

#

cedar hemlock Oh and btw if i want to change sprites of multiple enemies can that be done in o...

?

vocal spire Mar 19, 2021, 7:18 PM

#

Can be done in one cs

cedar hemlock Mar 19, 2021, 7:18 PM

#

okay

vocal spire Mar 19, 2021, 7:19 PM

#

Show your code that checks what the scene name is

cedar hemlock Mar 19, 2021, 7:20 PM

#

USceneManager.activeSceneChanged += SceneChanged;

 private void SceneChanged(Scene arg0, Scene arg1)
        {
            if (arg1.name != Bossscene) return;
            {
                GameManager.instance.StartCoroutine(SetSprite(arg1));

#

i think thats everything

#

oh and string Bossscene = "Room_Final_Boss_Core";

vocal spire Mar 19, 2021, 7:21 PM

#

Ok

cedar hemlock Mar 19, 2021, 7:21 PM

#

oh and have no idea if it works

vocal spire Mar 19, 2021, 7:22 PM

#

Let me rewrite a little for ya

cedar hemlock Mar 19, 2021, 7:22 PM

#

cedar hemlock imma make it so the scene and boss arent hardcoded

i havent tested it since here

#

ok thk still works

#

the music doesn't

vocal spire Mar 19, 2021, 7:26 PM

#

Replace csharp string Bossscene = "Room_Final_Boss_Core";
With

Dictionary<string, string> Bossscenes = new Dictionary<string, string>() { "Room_Final_Boss_Core", " Hollow Knight Boss" }; ```

cedar hemlock Mar 19, 2021, 7:27 PM

#

Error    CS0246    The type or namespace name 'Dictionary<,>' could not be found (are you missing a using directive or an assembly reference?)

vocal spire Mar 19, 2021, 7:28 PM

#

cedar hemlock `USceneManager.activeSceneChanged += SceneChanged;` ``` private void SceneChan...

Replace scene changed with

 private void SceneChanged(Scene arg0, Scene arg1)
        {
            if (Bossscenes.Contains(arg1.name)
            {
                GameManager.instance.StartCoroutine(SetSprite(arg1));

cedar hemlock Mar 19, 2021, 7:28 PM

#

the music part is totaly broken lol

vocal spire Mar 19, 2021, 7:28 PM

#

cedar hemlock ``` Error CS0246 The type or namespace name 'Dictionary<,>' could not be f...

Again refer to the lightbulb

vocal spire Mar 19, 2021, 7:29 PM

#

cedar hemlock the music part is totaly broken lol

What music plays

cedar hemlock Mar 19, 2021, 7:29 PM

#

lightbulb say fix formatting but it doesn't work

cedar hemlock Mar 19, 2021, 7:29 PM

#

vocal spire What music plays

defualt

#

gonna try adding it to the dll

vocal spire Mar 19, 2021, 7:31 PM

#

cedar hemlock gonna try adding it to the dll

Then you need to use sfg’s ver of WavUtility

cedar hemlock Mar 19, 2021, 7:32 PM

#

Error    CS7036    There is no argument given that corresponds to the required formal parameter 'value' of 'Dictionary<string, string>.Add(string, string)'```

vocal spire Mar 19, 2021, 7:32 PM

#

cedar hemlock lightbulb say fix formatting but it doesn't work

I think you need to add using System.Collections or using System.Collections.Generic

cedar hemlock Mar 19, 2021, 7:32 PM

#

i did that

vocal spire Mar 19, 2021, 7:32 PM

#

Oh let me quickly fix that

cedar hemlock Mar 19, 2021, 7:35 PM

#

sfg version doesn't use WavUtitlity or smth

#

(its in my code)

#

nvm fixed it

#

oh and my Bossscene does not work

vocal spire Mar 19, 2021, 7:37 PM

#

Back, had to do something

#

Yeah leme fix that

#

Replace csharp string Bossscene = "Room_Final_Boss_Core";
With

Dictionary<string, string> Bossscenes = new Dictionary<string, string>() { { "Room_Final_Boss_Core", " Hollow Knight Boss" } }; ```

cedar hemlock Mar 19, 2021, 7:38 PM

#

if (arg1.name != Bossscene) return;
            {

#

but i gtg now

fair rampart Mar 19, 2021, 7:46 PM

#

can someone help me use uuwuu

copper nacelle Mar 19, 2021, 7:49 PM

#

this is modding development

fair rampart Mar 19, 2021, 7:50 PM

#

oh

jolly oriole Mar 19, 2021, 8:02 PM

#

how does foreach (var item in defaultItemList) throw an NRE when initialized with defaultItemList = new List<Item>();???

prime urchin Mar 19, 2021, 8:03 PM

#

seems impossible if that's the only code

#

either the list isn't actually being initialized before or it is and it has a null item that's being used

#

or it's being set to null somewhere inbetween

jolly oriole Mar 19, 2021, 8:05 PM

#

i mean

copper nacelle Mar 19, 2021, 8:05 PM

#

are you sure it's the foreach

jolly oriole Mar 19, 2021, 8:05 PM

#

yes

prime urchin Mar 19, 2021, 8:05 PM

#

sure it's not the list in the component that's null?

jolly oriole Mar 19, 2021, 8:05 PM

#

the function got to the '8' log before stopping

copper nacelle Mar 19, 2021, 8:06 PM

#

put a log before the add

jolly oriole Mar 19, 2021, 8:06 PM

#

oh yea, should've tried those

#

trying now

#

ofc it's the add

#

i never initialized that list

#

no need to test

copper nacelle Mar 19, 2021, 8:08 PM

#

gaming

jolly oriole Mar 19, 2021, 8:09 PM

#

well, works now

copper nacelle Mar 19, 2021, 8:09 PM

#

if this is 1.5 you can setup a pdb and not have to log spam

#

very nice qol improvement

jolly oriole Mar 19, 2021, 8:10 PM

#

i'll continue to log spam as long as 1432 exists

#

it's 1432 btw

copper nacelle Mar 19, 2021, 8:11 PM

#

I'm sorry for your loss

jolly oriole Mar 19, 2021, 8:11 PM

#

making it work on 1432 first, who knows which century 1.5 will release

jolly oriole Mar 19, 2021, 8:29 PM

#

the entire inventory is fucked pog

vocal spire Mar 19, 2021, 9:04 PM

#

Nice

jolly oriole Mar 19, 2021, 9:06 PM

#

i'm somewhat close to done now, somehow completely missed an entire go with fsms on it

jolly oriole Mar 19, 2021, 9:43 PM

#

CallMethodProper error on Enemy List -> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.IndexOutOfRangeException: Array index is out of range.

nice

jolly oriole Mar 19, 2021, 10:17 PM

#

poggers, menu screen broke

vocal spire Mar 19, 2021, 10:17 PM

#

Yay

#

Found the problem

#

~~boss mod core not found~~

#

Jk

jolly oriole Mar 19, 2021, 10:19 PM

#

that's dynamic optional mod dependency

vocal spire Mar 19, 2021, 10:19 PM

#

Cool

#

For tot’s boss?

jolly oriole Mar 19, 2021, 10:19 PM

#

idk, for testing

#

NullReferenceException: Object reference not set to an instance of an object
  at SFCore.Utils.FsmUtil.ChangeTransition

sadge

vocal spire Mar 19, 2021, 10:20 PM

#

Cool, my favorite null reference, fsm utils

jolly oriole Mar 19, 2021, 10:42 PM

#

nvm i figured out why

#

fuck gamecameras immediatly destroying itself

fresh cipher Mar 20, 2021, 3:26 AM

#

jolly oriole poggers, menu screen broke

this is PC right

vocal spire Mar 20, 2021, 3:28 AM

#

fresh cipher this is PC right

...yes? Mods only work on pc. Also this is modding-development

light zodiac Mar 20, 2021, 7:15 AM

#

Does anyone know where i can find the source code of royal dreamer

honest violet Mar 20, 2021, 7:51 AM

#

hey everyone, it was suggested to me that this would be the place to ask if a HK mod could be added to the ModInstaller? I really love that mod but because it changes the same file as the API's, I can't use it in my game if I want all the other cool mods available in the installer

merry lotus Mar 20, 2021, 7:56 AM

#

The installer itself just adds .dll files, and installs the moddingAPI. Is this a mod you made that you're trying to get something integrated to the API, or is this a mod that you like that just uses a different method of modding?

honest violet Mar 20, 2021, 8:06 AM

#

merry lotus The installer itself just adds `.dll` files, and installs the moddingAPI. Is thi...

it's not my mod, but i'm not sure how to answer the second question, i'm not very knowledgeable in that subject. when you dl the mod, you get the Assembly_Sharp.dll file and that's it

honest violet Mar 20, 2021, 8:31 AM

#

oh btw it's the "no cost for wayward compass & gathering swarm" mod

cedar hemlock Mar 20, 2021, 8:31 AM

#

easy mod?

light zodiac Mar 20, 2021, 8:31 AM

#

free utility mod?

cedar hemlock Mar 20, 2021, 8:31 AM

#

cus thats on the installer

cedar hemlock Mar 20, 2021, 8:34 AM

#

vocal spire Replace ```csharp string Bossscene = "Room_Final_Boss_Core"; ``` With ```cshar...

so your code makes it so != cant be used in if (arg1.name != Bossscene) anyone have a fix?

#

the lightbulb doesn't help

honest violet Mar 20, 2021, 8:41 AM

#

cedar hemlock cus thats on the installer

I'm so sorry I'm very confused. English isn't my native language so I'm not sure what you're saying. Is there a mod that does this already in the installer, is that what you're saying?

cedar hemlock Mar 20, 2021, 8:41 AM

#

easy mod is on the installer

#

that makes wayward compass and swarm free

honest violet Mar 20, 2021, 8:44 AM

#

but if I enable easy mod, will it make everything else easier? or can i just toggle whatever part of easy mod i want to use?

cedar hemlock Mar 20, 2021, 8:45 AM

#

it will make everything else easier

#

and please, #modding-discussion

honest violet Mar 20, 2021, 8:56 AM

#

sorry, in modding discussion they said to come here. so there's no way to add another mod to the installer? since i don't want the game to be easier

cedar hemlock Mar 20, 2021, 8:57 AM

#

no in modding help they said you to come here and you can pr the modlinks

#

https://github.com/ricardosouzag/ModInstaller/pulls

GitHub

ricardosouzag/ModInstaller

API Mod Installer for HK. Contribute to ricardosouzag/ModInstaller development by creating an account on GitHub.

honest violet Mar 20, 2021, 9:00 AM

#

i don't understand you, i'm sorry. i'm not frustrated by you, just not understanding anything pr or modlinks. it's ok i can give up on this, it's not very important and i suppose if there was an easy way someone would have told already. thanks for giving answers, ruttie.

cedar hemlock Mar 20, 2021, 9:01 AM

#

ok

cedar hemlock Mar 20, 2021, 9:24 AM

#

bruh

#

the textures completely broke

#

ok nvm

#

fixed the textures

#

idk why it was if (arg1.name != Bossscene) so i made it if (arg1.name == Bossscene)

cedar hemlock Mar 20, 2021, 10:21 AM

#

btw the music is totally broken without errors in modlog

jolly oriole Mar 20, 2021, 12:07 PM

#

honest violet oh btw it's the "no cost for wayward compass & gathering swarm" mod

I have once uploaded a file called "freeutility.dll" to this discord, just search for uploaded files by me

cedar hemlock Mar 20, 2021, 12:07 PM

#

He wants to add it to the modinstaller

#

Oh and is it okay if i just copy everything from custombgm into the mod im making or should i do,it in another

jolly oriole Mar 20, 2021, 12:28 PM

#

I mean, i don't know why you'd want 2 mods for your single use case

honest violet Mar 20, 2021, 1:20 PM

#

jolly oriole I have once uploaded a file called "freeutility.dll" to this discord, just searc...

hey, yes a member linked me your file and I was able to use it. thank you for making it!

jolly oriole Mar 20, 2021, 1:20 PM

#

np

vocal spire Mar 20, 2021, 3:31 PM

#

cedar hemlock so your code makes it so != cant be used in `if (arg1.name != Bossscene)` anyone...

I already gave you stuff to replace

cedar hemlock Mar 20, 2021, 3:31 PM

#

Hmm maybe i missed it or smth

vocal spire Mar 20, 2021, 3:31 PM

#

Let me find it

vocal spire Mar 20, 2021, 3:32 PM

#

vocal spire Replace scene changed with ```csharp private void SceneChanged(Scene arg0, Scen...

This

cedar hemlock Mar 20, 2021, 3:33 PM

#

Ok ill see if it works

vocal spire Mar 20, 2021, 3:33 PM

#

Also show the code in the SetSprite method

#

Needs a little editing

cedar hemlock Mar 20, 2021, 4:02 PM

#

vocal spire This

Error CS1929 'Dictionary<string, string>' does not contain a definition for 'Contains' and the best extension method overload 'PlayMakerUtilsDotNetExtensions.Contains(VariableType[], VariableType)' requires a receiver of type 'VariableType[]'

vocal spire Mar 20, 2021, 4:02 PM

#

Change Contains to ContainsKey

cedar hemlock Mar 20, 2021, 4:03 PM

#

bruh

#

it worked

#

       private IEnumerator SetSprite(Scene arg1)
        {
            Log("Setting sprites");
            var boss = arg1.Find(selectedBoss);
            boss.GetComponent<tk2dSprite>().GetCurrentSpriteDef().material.mainTexture = _tex;
            yield return null;
        }

#

readonly string selectedBoss = "Hollow Knight Boss";

jolly oriole Mar 20, 2021, 4:04 PM

#

apparently i managed to make the fsm just stop working upon reaching this action and i don't know how.
as in: it literally just stops, no further logs, no exception, nothing

vocal spire Mar 20, 2021, 4:20 PM

#

       private IEnumerator SetSprite(Scene arg1)
        {
            Log("Setting sprites");
            var boss = arg1.Find(Bossscenes[arg1.name]);
            boss.GetComponent<tk2dSprite>().GetCurrentSpriteDef().material.mainTexture = _tex;
            yield return null;
        }

cedar hemlock Mar 20, 2021, 4:20 PM

#

yes

vocal spire Mar 20, 2021, 4:20 PM

#

Just need to do some stuff with the texture stuff to make it work with multiple scenes/bosses

cedar hemlock Mar 20, 2021, 4:21 PM

#

update: try using Bossscene instead of Bossscenes as that easier

vocal spire Mar 20, 2021, 4:21 PM

#

?

#

Wdym

cedar hemlock Mar 20, 2021, 4:21 PM

#

arg1.Find(Bossscenes[arg1.name]) needs to be arg1.Find(Bossscene[arg1.name])

vocal spire Mar 20, 2021, 4:21 PM

#

Ok

#

Thought bossscenes made more sense as it can contain multiple boss scenes

cedar hemlock Mar 20, 2021, 4:22 PM

#

yeah i can change it later

#

its easier if i change Bossscenes to Bossscene then changing everything else :)

vocal spire Mar 20, 2021, 4:23 PM

#

Ok

cedar hemlock Mar 20, 2021, 4:29 PM

#

btw sfgrenade why is your music you provided for bgm so loud lol

#

i need to set the music so low lol

jolly oriole Mar 20, 2021, 4:29 PM

#

because it's poggers

cedar hemlock Mar 20, 2021, 4:29 PM

#

lol

vocal spire Mar 20, 2021, 4:30 PM

#

Is it the music from the vc?

#

If so, awesome

cedar hemlock Mar 20, 2021, 4:30 PM

#

from github

jolly oriole Mar 20, 2021, 4:31 PM

#

https://github.com/SFGrenade/CustomBgm/releases/download/v1.0/S81-195.Grey.Prince.Zote.wav this one

jolly oriole Mar 20, 2021, 4:32 PM

#

vocal spire Is it the music from the vc?

and yes

vocal spire Mar 20, 2021, 4:32 PM

#

Nice

cedar hemlock Mar 20, 2021, 4:32 PM

#

i managed to break blue hk again

jolly oriole Mar 20, 2021, 4:32 PM

#

nice

vocal spire Mar 20, 2021, 4:33 PM

#

Nice

cedar hemlock Mar 20, 2021, 4:33 PM

#

hmm

#

did they really add descriptions? xD

jolly oriole Mar 20, 2021, 4:34 PM

#

... the items have descriptions in the base game

vocal spire Mar 20, 2021, 4:34 PM

#

lol

cedar hemlock Mar 20, 2021, 4:34 PM

#

oohh im stupid

vocal spire Mar 20, 2021, 4:34 PM

#

Remove hunter’s notes time

cedar hemlock Mar 20, 2021, 4:34 PM

#

i always forget that

vocal spire Mar 20, 2021, 4:34 PM

#

vocal spire *Remove hunter’s notes time*

Or will they be a part of item helper

jolly oriole Mar 20, 2021, 4:34 PM

#

vocal spire *Remove hunter’s notes time*

maybe i'll put the amount for things like rancid eggs there

vocal spire Mar 20, 2021, 4:34 PM

#

Ohhh

#

That makes sense

jolly oriole Mar 20, 2021, 4:35 PM

#

easiest solution to that problem as well

#

after that i only need to fix the lazy fsm not working anymore when opening the inventory on that screen

vocal spire Mar 20, 2021, 4:36 PM

#

What does the normal inventory look like?

jolly oriole Mar 20, 2021, 4:36 PM

#

vocal spire Mar 20, 2021, 4:38 PM

#

Are you going to leave the space there blank, or do something like space out the stuff on the left?

jolly oriole Mar 20, 2021, 4:38 PM

#

blank is easy

#

and i also need to test it when one has no items

vocal spire Mar 20, 2021, 4:40 PM

#

Ok

cedar hemlock Mar 20, 2021, 4:40 PM

#

also your code might have broken the custom texture

vocal spire Mar 20, 2021, 4:40 PM

#

How?

#

What happened to it?

cedar hemlock Mar 20, 2021, 4:41 PM

#

idk modlogs doesn't give errors and thk just doesn't change

vocal spire Mar 20, 2021, 4:41 PM

#

Is Qol installed and enabled?

cedar hemlock Mar 20, 2021, 4:41 PM

#

yes

vocal spire Mar 20, 2021, 4:41 PM

#

Hmmm

cedar hemlock Mar 20, 2021, 4:41 PM

#

do i need to reference?

vocal spire Mar 20, 2021, 4:41 PM

#

Show where you define Bossscene

#

No

cedar hemlock Mar 20, 2021, 4:42 PM

#

Dictionary<string, string> Bossscene = new Dictionary<string, string>() { { "Room_Final_Boss_Core", " Hollow Knight Boss" } };

vocal spire Mar 20, 2021, 4:43 PM

#

Hmm

cedar hemlock Mar 20, 2021, 4:43 PM

#

how does the texture part know what selectedboss is?

vocal spire Mar 20, 2021, 4:44 PM

#

Wdym

#

Can you show where you define selected boss?

cedar hemlock Mar 20, 2021, 4:44 PM

#

it isn't there

vocal spire Mar 20, 2021, 4:45 PM

#

Ok

#

Did you remove it?

cedar hemlock Mar 20, 2021, 4:45 PM

#

i thought it was in your code as you added " Hollow Knight Boss" } };

vocal spire Mar 20, 2021, 4:45 PM

#

Ok

#

Just making sure it’s the same value

#

Can you show your code in scene changed

cedar hemlock Mar 20, 2021, 4:46 PM

#

private void SceneChanged(Scene arg0, Scene arg1)
        {
            if (Bossscene.ContainsKey(arg1.name))
            {

                GameManager.instance.StartCoroutine(SetSprite(arg1));

vocal spire Mar 20, 2021, 4:47 PM

#

Looks right

cedar hemlock Mar 20, 2021, 4:47 PM

#

ok i changed some things let me try again

vocal spire Mar 20, 2021, 4:47 PM

#

Did you make sure you built the mod

cedar hemlock Mar 20, 2021, 4:47 PM

#

vocal spire Did you make sure you built the mod

yes

vocal spire Mar 20, 2021, 4:49 PM

#

Gtg

#

Phone at 1%

cedar hemlock Mar 20, 2021, 4:49 PM

#

bruh fixed it

vocal spire Mar 20, 2021, 4:49 PM

#

What changed

cedar hemlock Mar 20, 2021, 4:50 PM

#

i changed " Hollow Knight Boss" to "Hollow Knight Boss"

vocal spire Mar 20, 2021, 4:50 PM

#

Did I seriously leave a space

cedar hemlock Mar 20, 2021, 4:50 PM

#

yes lol

vocal spire Mar 20, 2021, 4:50 PM

#

I blame coding on phone

#

It’s gonna die now

cedar hemlock Mar 20, 2021, 4:50 PM

#

bye

vocal spire Mar 20, 2021, 4:50 PM

#

Goodbye

jolly oriole Mar 20, 2021, 5:03 PM

#

how does this look?

cedar hemlock Mar 20, 2021, 5:04 PM

#

i liked it when there was a line

jolly oriole Mar 20, 2021, 6:50 PM

#

btw, idk if anybody else had a similar problem of an fsm just not continueing to function, stopping dead without an exception

leaden hedge Mar 20, 2021, 7:05 PM

#

i had an issue where fsms would point to the wrong tab, then crash

jolly oriole Mar 20, 2021, 7:08 PM

#

i figured it out, apparently completely misread the state name

#

and even then the stopping was because i didn't change back a number (when i changed it for testing)

jolly oriole Mar 20, 2021, 7:09 PM

#

leaden hedge i had an issue where fsms would point to the wrong tab, then crash

ah, i was talking about the in game fsm, but resolved

leaden hedge Mar 20, 2021, 7:09 PM

#

oh

jolly oriole Mar 20, 2021, 7:09 PM

#

i also had some weird interactions with the viewer

leaden hedge Mar 20, 2021, 7:10 PM

#

is there a fix to arrays starting at 1 for some reason

jolly oriole Mar 20, 2021, 7:11 PM

#

i never had an array start at one, or do you mean this kinda thing?

leaden hedge Mar 20, 2021, 7:11 PM

#

iswtg if you ask what transtrans does in here

#

yeah that

jolly oriole Mar 20, 2021, 7:11 PM

#

that's just display

#

starts at 0 in the second line

leaden hedge Mar 20, 2021, 7:11 PM

#

yes i know its just displaying wrong

jolly oriole Mar 20, 2021, 7:11 PM

#

oh

leaden hedge Mar 20, 2021, 7:11 PM

#

its putting the 0th element at position 1 in the array

jolly oriole Mar 20, 2021, 7:18 PM

#

apparently not

#

the avalonia version shows that the first 'index' indicates the array

jolly oriole Mar 20, 2021, 7:47 PM

#

i love a thorough modlog

vocal spire Mar 20, 2021, 7:47 PM

#

Hello

#

Very thorough

stone elm Mar 20, 2021, 7:48 PM

#

I have rookie numbers

jolly oriole Mar 20, 2021, 7:48 PM

#

i only bloated my modlog so i see everything about this pfsm

vocal spire Mar 20, 2021, 7:49 PM

#

jolly oriole how does this look?

👍

jolly oriole Mar 20, 2021, 9:08 PM

#

sadge, closing and reopening works now though

vocal spire Mar 20, 2021, 9:08 PM

#

Nice also not nice

marble hollow Mar 20, 2021, 9:12 PM

#

ah yes my favourite item, d̵͂͊f̸̒͝e̶͑̽w̸̓̕ȑ̶̒f̷̅̽r̵̂̀d̵̅̊s̶͐͠ẗ̷̰́ǧ̷̳f̷͋̽w̵̛͝r̵̈́̈́y̷̖̔h̴͂̇a̷̎̆w̶͈̋t̸̓̀

vocal spire Mar 20, 2021, 9:13 PM

#

Same

languid goblet Mar 20, 2021, 9:16 PM

#

inventory overhaul?

vocal spire Mar 20, 2021, 9:17 PM

#

For item helper(thing that allows adding of more items to the equipment menu)

#

I made one, but it was really bad, so sfg is making a much better one

jolly oriole Mar 20, 2021, 9:18 PM

#

basically, i'm copying the journal and make it work with items/equipment

vocal spire Mar 20, 2021, 9:19 PM

#

I tried making a new panel at one point but it all died

jolly oriole Mar 20, 2021, 9:19 PM

#

more progress now, the cursor doesn't disappear when closing the inventory for no reason

vocal spire Mar 20, 2021, 9:19 PM

#

It was centered at the lower left portion of the screen, and moving the cursor causes millions of null references

jolly oriole Mar 20, 2021, 9:26 PM

#

gaming

ornate rivet Mar 20, 2021, 9:33 PM

#

that's very nice

#

UI Master SFG

jolly oriole Mar 20, 2021, 9:48 PM

#

ornate rivet UI Master SFG

thanks!

jolly oriole Mar 21, 2021, 12:21 AM

#

@vocal spire customknight thing (idk if you still work on it): kingsoul/voidheart shows with the original texture instead of the skin one

vocal spire Mar 21, 2021, 12:21 AM

#

Ok

#

I thought there was already a fix made

#

For now it only edits the knight though(will add more in the future, might make it use sprite collection names to replace stuff)

jolly oriole Mar 21, 2021, 12:46 AM

#

https://github.com/ricardosouzag/ModInstaller/pull/67 now poggers

jolly jungle Mar 21, 2021, 7:52 AM

#

Damn, this is cool

#

How would one make something like this from scratch?

cedar hemlock Mar 21, 2021, 11:25 AM

#

So i decided to look into custom charms, but there's one problem...
if i equip a charm and leave the equipment menu it doesn't stay equiped or smth

#

i seems equiped and its there but i can just equip it again

#

and again and again

vocal spire Mar 21, 2021, 12:29 PM

#

cedar hemlock So i decided to look into custom charms, but there's one problem... if i equip a...

Your equipment bools are messed up. Did you make sure to include everything from the example grenade made for charms?

jolly oriole Mar 21, 2021, 2:12 PM

#

nice

ornate rivet Mar 21, 2021, 2:22 PM

#

rip

vocal spire Mar 21, 2021, 2:22 PM

#

Confusion

jolly oriole Mar 21, 2021, 2:23 PM

#

test for the item limit with random sprites from the game

#

result: it just works nicely

ornate rivet Mar 21, 2021, 2:24 PM

#

ah ok

jolly oriole Mar 21, 2021, 2:25 PM

#

the random sprites might just be sometimes a bit bigger than the inventory items (e.g. the black blanker or whatever that is)

fair rampart Mar 21, 2021, 7:57 PM

#

Heyo, Quick question: Would it be possible to mod a Character creator into the game? My Idea was to have all the knight assets be redone as a blank masked one and then stack 5 Layers on top of each other like so.

Eyes
Horns 1
Horns 2
Cloak colour
Blank mask

fair rampart Mar 21, 2021, 8:35 PM

#

Also if this works, the sprite combination would has to have a saved designation I presume, so this could be applied onto the multiplayer mod 🤔 chose the code corespondent to your combination you want to have and ad it into a config or better yet in game

cedar hemlock Mar 21, 2021, 8:37 PM

#

Check the source code of decorationmaster

dark wigeon Mar 21, 2021, 8:42 PM

#

@fair rampart unity can load shaders directly from assets files if they are referenced by a scene

#

so I just make a blank scene and then reference the assets files

#

but all assets from the assets files are loaded when referenced in editor so I strip out all other assets other than shaders

#

and yes available in scene view

#

I've tried that
not sure what you're trying but the actual setup is a bit complicated

jolly jungle Mar 21, 2021, 8:50 PM

#

Hello hello hello everyone

#

A few questions

#

Why is it necessary to search for FindObjectsOfType<HealthManager>() and not just look directly for the name of whatever it is?

jolly oriole Mar 21, 2021, 8:53 PM

#

because in a scene there can be

Crystal Flyer
Crystal Flyer (1)
Crystal Flyer (2)
...

and GameObject.Find() requires a specific name

dark wigeon Mar 21, 2021, 8:53 PM

#

no sources just guessing

#

umm

#

can you send me what you have

#

I can explain better with an example

jolly jungle Mar 21, 2021, 8:55 PM

#

jolly oriole because in a scene there can be ``` Crystal Flyer Crystal Flyer (1) Crystal Flye...

So, there isn't any sort of FindObjectsWithNameContainingSpecificString?

#

Hm

#

What about just returning all things in scene?

jolly oriole Mar 21, 2021, 8:56 PM

#

you'd need to write your own method for that

jolly jungle Mar 21, 2021, 8:57 PM

#

jolly oriole you'd need to write your own method for that

Welp clownkin

#

Would that be the only way to reskin non-enemy objects or is there something I missed?

#

Please be something I missed

jolly oriole Mar 21, 2021, 8:59 PM

#

jolly jungle Would that be the only way to reskin non-enemy objects or is there something I m...

you could search for SpriteRenderers, as most non enemy things aren't animated

jolly jungle Mar 21, 2021, 8:59 PM

#

And static objects like breakable environment?

jolly oriole Mar 21, 2021, 9:00 PM

#

idk, would probably be dependent on each object

jolly jungle Mar 21, 2021, 9:00 PM

#

Damnit

#

We'll get there when we get there, I suppose

#

What about particle effects?

#

Wait those are particle effects

#

So they have stuff special to them

#

Hm

#

Alright what about things like the background/foreground/etc.?

dark wigeon Mar 21, 2021, 9:05 PM

#

just a little more detail about that:
I would manually create a blank scene and blank shader .assets file and copy the needed shader bytes to your shader .assets file rather than copying whole game files
you can create a blank assets file with the scene creator here https://github.com/nesrak1/HKWorldEdit2/blob/master/Assets/Editor/Bundler/BundleCreator.cs#L12
I think as long as it's a valid assets file renamed with .unity extension it should load it as a scene.
to reference it, just create a blank gameobject, create a blank material, then attach the material to the gameobject.
details on creating a blank asset and filling it here: https://github.com/nesrak1/AssetsTools.NET#create-new-asset-from-scratch
so the main issue why you can't just include the shader into the scene is because unity has bugs and apparently putting a shader into a scene crashes the editor
so instead it goes in another assets file (which has to be outside the editor Assets folder otherwise the editor crashes due to an assertion)
you can reference the other assets file by changing the assets file's dependencies array. the index of the dependency into the array starts at 1 not 0.
you can create a dependency like this: https://github.com/nesrak1/HKWorldEdit2/blob/master/Assets/Editor/Bundler/Loader.cs#L211
so if you only have one reference and it's to that assets file that holds the shader, you want to point it towards fileid 1 and pathid whatever path it is in that file.
so basically you point the material's shader pointer towards the shader and save and you should be good to go.

#

@fair rampart

#

it would probably be better for me to write some generic code, that way there's no confusion

jolly jungle Mar 21, 2021, 9:07 PM

#

btw kein what're you making?

foggy yew Mar 21, 2021, 9:13 PM

#

Hey sooo
I have this absolute crazy idea to replace every enemy with primal aspids and do it with gatling aspids
How would i do that?(To replace every enemy with the primal aspids)

dark wigeon Mar 21, 2021, 9:14 PM

#

yep raw shader bytes

#

just copy the asset data directly

#

there's not really a good built in way so just get a binaryreader, set its position at assetInfo.absoluteFilePos and then read assetInfo.curFileSize bytes

#

there is no such thing as an asset file

#

there are assets files and then assets

#

yeah ok whatever I make mistakes too

#

asset is the raw bytes for a thing like shader or texture or gameobject

#

assets file is the file that holds assets

#

if your project is in raw mode instead of text mode, project assets files are the same format as compiled game assets files

#

except I think type tree, but that's it, that's just so that when you upgrade it knows which fields are what

charred topaz Mar 22, 2021, 4:29 AM

#

Hey @dark wigeon, do you know if it's possible to change what assemblies are referenced in an asset bundle? When I look at the data inside of the built asset bundle for InfernoKingGrimm, it's looking for the IKG scripts under "Assembly-CSharp.dll". But the scripts are actually under InfernoKingGrimm.dll when I go to load the mod in HK. Would there be any way of changing this so that it references the correct assembly? I'm unable to use asmdefs to change the assemblies because of how my project is structured.

dark wigeon Mar 22, 2021, 4:41 AM

#

you can just do that in uabe

#

export dump the MonoScript that references Assembly-CSharp.dll, change it in the text file and reimport it

#

this isn't a new beta hk bundle right

#

oh I guess you probably want that to happen automatically after bundle build?

#

but if you really do want to postprocess the bundle you can script it, it just takes a bit of setup

charred topaz Mar 22, 2021, 4:57 AM

#

dark wigeon you can just do that in uabe

Yeah, I was trying to see if I can get my mod updated to the latest HK Beta, wasn't sure if using UABE was possible in that version yet. I had a working (but jank) system working that did the assembly change, but that's bricked in the beta.

dark wigeon Mar 22, 2021, 4:57 AM

#

https://github.com/nesrak1/UABEA/

GitHub

nesrak1/UABEA

c# uabe for newer versions of unity. Contribute to nesrak1/UABEA development by creating an account on GitHub.

charred topaz Mar 22, 2021, 5:01 AM

#

cool
is it also something I can use through C# or through command line to automate the process?

dark wigeon Mar 22, 2021, 5:01 AM

#

nothing on command line but you can use the library in c#

charred topaz Mar 22, 2021, 5:02 AM

#

ok, I'll take a look at it later

dark wigeon Mar 22, 2021, 5:02 AM

#

https://github.com/nesrak1/AssetsTools.NET#loading-bundle-files

GitHub

nesrak1/AssetsTools.NET

Read and write unity assets/bundle files, based on https://github.com/DerPopo/UABE/ - nesrak1/AssetsTools.NET

jolly oriole Mar 22, 2021, 6:38 AM

#

charred topaz Hey <@!259387134547460096>, do you know if it's possible to change what assembli...

I make unity reference my assembly by having 2 assemblies, one with just monobehaviours that i put in the project and one with everything that i put out on the modinstaller

jolly oriole Mar 22, 2021, 7:53 AM

#

(the one with just monobehaviours i also removed all function bodies and references to the modded assembly-csharp)

naive nimbus Mar 22, 2021, 12:09 PM

#

Someone is actually using this for a mod!!! I'm so happy!!

jolly jungle Mar 22, 2021, 3:43 PM

#

Oh I thought they made it themselves

cedar hemlock Mar 22, 2021, 3:43 PM

#

vocal spire Your equipment bools are messed up. Did you make sure to include everything from...

so i fixed it, but where do i add the custom decriptions, names and effects?

cedar hemlock Mar 22, 2021, 3:44 PM

#

jolly jungle Oh I thought they made it themselves

no, im not an artist :)

jolly jungle Mar 22, 2021, 3:45 PM

#

You don't need to be an artist to make textures tamershrug

cedar hemlock Mar 22, 2021, 3:45 PM

#

eh its less work lol

jolly oriole Mar 22, 2021, 3:45 PM

#

cedar hemlock so i fixed it, but where do i add the custom decriptions, names and effects?

Language get hook, next to the bool hook

cedar hemlock Mar 22, 2021, 3:46 PM

#

ok

paper valve Mar 22, 2021, 3:46 PM

#

hello hi everyone

#

would you know where i can find good tutorials/documentation on how to start creating hk mods ?

jolly jungle Mar 22, 2021, 3:47 PM

#

https://radiance.host/apidocs

#

Right here

cedar hemlock Mar 22, 2021, 3:48 PM

#

jolly oriole Language get hook, next to the bool hook

so do i just copy

if (key.StartsWith("CHARM_NAME_"))
            {
                int charmNum = int.Parse(key.Split('_')[2]);
                if (charmHelper.charmIDs.Contains(charmNum))
                {
                    return "CHARM NAME";
                }
            }

and paste it again, then change "CHARM_NAME_" to "CHARM_NAME_X" X being thenumber?

#

or do i change the number elsewhere?

paper valve Mar 22, 2021, 3:49 PM

#

jolly jungle https://radiance.host/apidocs

you are so cool, thank you :)

jolly oriole Mar 22, 2021, 3:51 PM

#

cedar hemlock so do i just copy ``` if (key.StartsWith("CHARM_NAME_")) { ...

Gimme a minute or two (or 5) to get on my pc, i cant give detailed code help with shitcord mobile

cedar hemlock Mar 22, 2021, 3:52 PM

#

take your time :)

jolly oriole Mar 22, 2021, 4:00 PM

#

so

#

if (key.StartsWith("CHARM_NAME_"))
{
    int charmNum = int.Parse(key.Split('_')[2]);
    if (charmHelper.charmIDs.Contains(charmNum))
    {
        return "CHARM NAME";
    }
}

is written the same way the bool handling is.
if you only add a single charm, you could write

if (key.Equals($"CHARM_NAME_{charmHelper.charmIDs[0]}")) return "My Custom Charm Name";

if you have multiple on the other hand, it could be

// possible to have this somewhere in the class
private string[] charmNames = { "Name 1", "Name 2", ... };

...

// In the language get hook
if (key.StartsWith("CHARM_NAME_"))
{
    // get the charm id of the charm name convo key
    int charmNum = int.Parse(key.Split('_')[2]);
    // check if charm id is one of our own
    if (charmHelper.charmIDs.Contains(charmNum))
    {
        // return custom name set above
        return charmNames[charmHelper.charmIDs.IndexOf(charmNum)];
    }
}

#

let me quickly add comments

cedar hemlock Mar 22, 2021, 4:09 PM

#

so in (charmNum)) i type the number of the charm to change?

vocal spire Mar 22, 2021, 4:09 PM

#

cedar hemlock so in `(charmNum))` i type the number of the charm to change?

No

jolly oriole Mar 22, 2021, 4:10 PM

#

no, as that is supplied by the request of a string

jolly jungle Mar 22, 2021, 4:10 PM

#

paper valve you are so cool, thank you :)

No problem and thanks :D

cedar hemlock Mar 22, 2021, 4:11 PM

#

so, then at (key.Split('charmnumhere??')[2]);

vocal spire Mar 22, 2021, 4:12 PM

#

No

cedar hemlock Mar 22, 2021, 4:12 PM

#

im stupid

jolly oriole Mar 22, 2021, 4:12 PM

#

the only thing to change would either be

the "My Custom Charm Name" in

if (key.Equals($"CHARM_NAME_{charmHelper.charmIDs[0]}")) return "My Custom Charm Name";

or
2. the private string[] charmNames = { "Name 1", "Name 2", ... }; in

// possible to have this somewhere in the class
private string[] charmNames = { "Name 1", "Name 2", ... };

...

// In the language get hook
if (key.StartsWith("CHARM_NAME_"))
{
    // get the charm id of the charm name convo key
    int charmNum = int.Parse(key.Split('_')[2]);
    // check if charm id is one of our own
    if (charmHelper.charmIDs.Contains(charmNum))
    {
        // return custom name set above
        return charmNames[charmHelper.charmIDs.IndexOf(charmNum)];
    }
}

vocal spire Mar 22, 2021, 4:12 PM

#

In private string[] charmNames

cedar hemlock Mar 22, 2021, 4:12 PM

#

oh okay i get it now

#

i messed smth up lol

#

#

oh wait

#

i might know the issue

#

hmm

#

that just reversed it

jolly oriole Mar 22, 2021, 4:25 PM

#

well, it does look like it actually loaded the name though

cedar hemlock Mar 22, 2021, 4:25 PM

#

yes

#

i'll just reset the OnLanguageGethook

#

hmm

#

the code you gave me is different from the example

jolly oriole Mar 22, 2021, 4:28 PM

#

possible

cedar hemlock Mar 22, 2021, 4:28 PM

#

when i use the code from the example the name no longer works

#

yours:

if (key.StartsWith("CHARM_NAME_"))
{
    // get the charm id of the charm name convo key
    int charmNum = int.Parse(key.Split('_')[2]);
    // check if charm id is one of our own
    if (charmHelper.charmIDs.Contains(charmNum))
    {
        // return custom name set above
        return charmNames[charmHelper.charmIDs.IndexOf(charmNum)];
    }
}

the example:

if (key.StartsWith("CHARM_NAME_"))
            {
                int charmNum = int.Parse(key.Split('_')[2]);
                if (charmHelper.charmIDs.Contains(charmNum))
                {
                    return "CHARM NAME";
                }
            }

jolly oriole Mar 22, 2021, 4:29 PM

#

the only difference being that i replaced the return value with something that can be customized per charm

cedar hemlock Mar 22, 2021, 4:29 PM

#

yea

#

it's interresting bc the example code is also made for multiple charms, but then gives code that is only used to change all the names to one thing

jolly oriole Mar 22, 2021, 4:32 PM

#

yea, i could update it rn, which i think i'll do rn

cedar hemlock Mar 22, 2021, 4:33 PM

#

ok so i got the names and desc's working, now the effects

jolly oriole Mar 22, 2021, 4:34 PM

#

i never tried something with effects, but you may want to activate/deactivate the effects in the charmupdatehook https://radiance.host/apidocs/Hooks.html#charmupdatehook

cedar hemlock Mar 22, 2021, 4:35 PM

#

and where do i put the effects?

jolly oriole Mar 22, 2021, 4:35 PM

#

that has to be managed by each mod on it's own, i don't have helpers for that

cedar hemlock Mar 22, 2021, 4:36 PM

#

ok and how do i do that?

jolly oriole Mar 22, 2021, 4:36 PM

#

good question

cedar hemlock Mar 22, 2021, 4:36 PM

#

is it in the docs or somewhere else..?

cedar hemlock Mar 22, 2021, 4:36 PM

#

jolly oriole good question

that's never a good sign

#

on the docs i see if (PlayerData.instance.GetBool("equippedCharm_27")), so is the number of the charms equippedCharm_41, equippedCharm_42, equippedCharm_43 and equippedCharm_44?

jolly oriole Mar 22, 2021, 4:42 PM

#

well, that depends on the loaded mods

#

so ig a method similar to the language hook would be good

#

but something like

if (PlayerData.instance.GetBool($"equippedCharm_{charmHelper.charmIDs[0]}"))
{
  // code here for one charm
}
if (PlayerData.instance.GetBool($"equippedCharm_{charmHelper.charmIDs[1]}"))
{
  // code here for one charm
}
if (PlayerData.instance.GetBool($"equippedCharm_{charmHelper.charmIDs[2]}"))
{
  // code here for one charm
}
if (PlayerData.instance.GetBool($"equippedCharm_{charmHelper.charmIDs[3]}"))
{
  // code here for one charm
}

for 4 charms would be ideal

jolly jungle Mar 22, 2021, 4:43 PM

#

Btw ruttie did you finish the blue hollow knight reskin thing?

jolly oriole Mar 22, 2021, 4:44 PM

#

especially if the effects severely differ from one another

cedar hemlock Mar 22, 2021, 4:44 PM

#

jolly jungle Btw ruttie did you finish the blue hollow knight reskin thing?

you mean if he is blue now?

#

if yes, yes

jolly jungle Mar 22, 2021, 4:45 PM

#

Cool

#

Do you have screenshot or not right now

#

As in, do you happen to have a screenshot, or not yet

cedar hemlock Mar 22, 2021, 4:46 PM

#

https://drive.google.com/file/d/1v6ITE0y_0goGGhvRr2RdvjdY_wQsdpex/view?usp=sharing

Google Drive

Hollow Knight 2021-03-20 10-34-30.mp4

jolly jungle Mar 22, 2021, 4:47 PM

#

It, uh

#

Looks not blue zote

cedar hemlock Mar 22, 2021, 4:47 PM

#

lol

#

it's cause of the particles

#

thats a rly bad picture for the drive to take lol

#

to change the particles will take some time

cedar hemlock Mar 22, 2021, 4:49 PM

#

jolly oriole but something like ```cs if (PlayerData.instance.GetBool($"equippedCharm_{charmH...

what kind of hook should i use? one similar to ModHooks.Instance.GetPlayerBoolHook?

cedar hemlock Mar 22, 2021, 4:50 PM

#

jolly jungle It, uh

i do have an better pic tho

jolly oriole Mar 22, 2021, 4:51 PM

#

cedar hemlock what kind of hook should i use? one similar to `ModHooks.Instance.GetPlayerBoolH...

that code is specifically for inside the charmupdate hook similar to the joni's blessing code that is found in the api docs

cedar hemlock Mar 22, 2021, 4:51 PM

#

oh okay

#

it works! thx

#

is there an doc somewhere with all the charm effects?

#

(the code for them ofc)

jolly oriole Mar 22, 2021, 5:03 PM

#

no, they're scattered throught the game

cedar hemlock Mar 22, 2021, 5:03 PM

#

sad

jolly oriole Mar 22, 2021, 5:04 PM

#

some in HeroController.CharmUpdate (or gamemanager, idk), some in fsms, some only in attack methods

cedar hemlock Mar 22, 2021, 5:06 PM

#

but ehm

#

where are fsm's actually?

jolly oriole Mar 22, 2021, 5:06 PM

#

in the game files, you can use software like https://github.com/nesrak1/HollowKnightFSMView/releases/latest to look at those

cedar hemlock Mar 22, 2021, 5:20 PM

#

ok then how do i give the charms textures

jolly oriole Mar 22, 2021, 5:23 PM

#

when doing

charmHelper.customSprites = new Sprite[] { new Sprite(), new Sprite(), new Sprite(), new Sprite() };

supply loaded sprites instead of the new Sprite() x4
load the sprites the same way you loaded the thk spritesheet

cedar hemlock Mar 22, 2021, 5:24 PM

#

yeah so...

jolly jungle Mar 22, 2021, 5:24 PM

#

cedar hemlock i do have an better pic tho

Yooo that's cool

cedar hemlock Mar 22, 2021, 5:25 PM

#

jolly oriole when doing ```cs charmHelper.customSprites = new Sprite[] { new Sprite(), new Sp...

does

var boss = arg1.Find(Bossscene[arg1.name]);
            boss.GetComponent<tk2dSprite>().GetCurrentSpriteDef().material.mainTexture = _tex;
            yield return null;
``` also support multiple textures??

paper valve Mar 22, 2021, 5:25 PM

#

whats the easiest thing i can create in order to get the hand of it

cedar hemlock Mar 22, 2021, 5:26 PM

#

try making things cost geo

paper valve Mar 22, 2021, 5:26 PM

#

wdym

cedar hemlock Mar 22, 2021, 5:26 PM

#

i also started with that and miserably failed

cedar hemlock Mar 22, 2021, 5:27 PM

#

paper valve wdym

if you dash you lose 5 geo or smth

#

if you need help i have the code for it

jolly oriole Mar 22, 2021, 5:28 PM

#

cedar hemlock does ``` var boss = arg1.Find(Bossscene[arg1.name]); boss.GetCompon...

i mean, if you do it multiple times after another then yes

cedar hemlock Mar 22, 2021, 5:28 PM

#

wdym

#

if i re-use this code for the charms will the charms not become like thk?

#

i mean how do i tell the code to use one texture for this and the other texture for that etc

jolly oriole Mar 22, 2021, 5:32 PM

#

personally i do something like https://github.com/SFGrenade/MoreHealing/blob/master/Consts/TextureStrings.cs to load my images as sprites and supply them to the charmhelper like https://github.com/SFGrenade/MoreHealing/blob/master/MoreHealing.cs#L54

cedar hemlock Mar 22, 2021, 5:35 PM

#

soo in tmpTextures.Add(QuickerFocusKey, QuickerFocusFile); QuickerFocusFile is the name of the image?

light zodiac Mar 22, 2021, 5:35 PM

#

How do I make a settings file for my mod (Like Qol.GlobalSettings)?

cedar hemlock Mar 22, 2021, 5:36 PM

#

https://radiance.host/apidocs/ModdingAPI.html#saving-data

cedar hemlock Mar 22, 2021, 5:37 PM

#

cedar hemlock soo in `tmpTextures.Add(QuickerFocusKey, QuickerFocusFile);` QuickerFocusFile i...

oh no nvm

light zodiac Mar 22, 2021, 5:41 PM

#

cedar hemlock https://radiance.host/apidocs/ModdingAPI.html#saving-data

Thanks, i missed that part 🙃

cedar hemlock Mar 22, 2021, 5:41 PM

#

np

charred topaz Mar 22, 2021, 5:51 PM

#

dark wigeon https://github.com/nesrak1/AssetsTools.NET#loading-bundle-files

I'm probably missing something here, but is there a reason why all the assets are showing up as null when I attempt to iterate through them? The bundle seems to show up just fine in UABE.

dark wigeon Mar 22, 2021, 5:52 PM

#

the assstsFiles list is actually now only for backend stuff and doesn't get set anywhere by the library

#

just use LoadAllAssetsFromBundle

#

can you send me the bundle? I'll just write it for you

charred topaz Mar 22, 2021, 5:55 PM

#

ok, in a second

#

I was just wondering how would I be able to read the base field information on the assets. When I tried calling that method, I couldn't find a "table" property on them

#

📎 weavercore_bundle

#

📎 infernogrimmmod_bundle

jolly oriole Mar 22, 2021, 6:13 PM

#

nick, idk if you've read this, but could be an alternative to the fix after building you're doing rn: <#archived-modding-development message>

dark wigeon Mar 22, 2021, 6:16 PM

#

he said "I'm unable to use asmdefs to change the assemblies because of how my project is structured."

#

not sure exactly what he meant but I assumed he was saying that wasn't an option

vernal widget Mar 22, 2021, 6:16 PM

#

Does anyone know whats happening with the new multiplayer mod

cedar hemlock Mar 22, 2021, 6:16 PM

#

#modding-discussion

vernal widget Mar 22, 2021, 6:17 PM

#

Oh sorry

jolly oriole Mar 22, 2021, 6:17 PM

#

dark wigeon not sure exactly what he meant but I assumed he was saying that wasn't an option

oh

charred topaz Mar 22, 2021, 6:25 PM

#

jolly oriole nick, idk if you've read this, but could be an alternative to the fix after buil...

That is one of the first things I tried, but it comes at a cost. Basically I also have an assembly called HollowKnight.dll in my project, that contains a bunch of things that are from HK's Assembly-CSharp (IMod, NonBouncer, the TMPRO library, etc). When the asset bundle gets built, I want to reference "Assembly-CSharp.dll" instead of "HollowKnight.dll", so any scripts from that assembly get loaded properly when I go to launch the game. The problem is that I cannot rename "HollowKnight.dll" to "Assembly-CSharp.dll" in the project, because it's not possible to add a reference to "Assembly-CSharp" in the editor, thus disallowing me from using anything in that assembly in WeaverCore.dll or InfernoKingGrimm.dll in the project

jolly oriole Mar 22, 2021, 6:28 PM

#

yeah, the way i do it is to have 2 seperate projects, one specifically for unity where i remove everything relating to the modded assembly and only leave normal unity/c# in (not even function bodies), but unity doesn't care if the types aren't exactly the same (like 2 different enums), though the thing with tmpro is probably bad, maybe possible to just put the .cs files generated by something like utinyripper somewhere into the assets folder, as those are then referenced to assembly-csharp

#

so i get funny looking classes like

light zodiac Mar 22, 2021, 6:34 PM

#

I was trying to make a Global Settings file and I'm getting an error

Code in the new Settings.cs filecs public class GlobalModSettings : ModSettings { public int health = PlayerData.instance.GetInt("maxHealth"); public int blue_hearts = 0; public int soul = 0; }

Code in the main.cs file cs public GlobalModSettings Settings = new GlobalModSettings(); public override ModSettings GlobalSettings { get => Settings; set => Settings = (GlobalModSettings) value; }

In the docs it says to do Settings.health but that gives me an error

copper nacelle Mar 22, 2021, 6:34 PM

#

what is the error

#

calling getint in a settings file is not the move ngl

jolly oriole Mar 22, 2021, 6:35 PM

#

but in theory shouldn't show an error

#

at least not in the ide

copper nacelle Mar 22, 2021, 6:36 PM

#

yeah just warning in advance

light zodiac Mar 22, 2021, 6:36 PM

#

copper nacelle what is the error

The name 'Settings.health' does not exist in the current context.

copper nacelle Mar 22, 2021, 6:36 PM

#

instance method?

light zodiac Mar 22, 2021, 6:37 PM

#

I'm not following

jolly oriole Mar 22, 2021, 6:37 PM

#

can you rename Settings to _globalSettings?

copper nacelle Mar 22, 2021, 6:37 PM

#

where are you doing this

jolly oriole Mar 22, 2021, 6:37 PM

#

as Settings is reserved for save settings afaik

copper nacelle Mar 22, 2021, 6:38 PM

#

it do be

light zodiac Mar 22, 2021, 6:39 PM

#

copper nacelle where are you doing this

in an internal class in the function private void Start()

copper nacelle Mar 22, 2021, 6:39 PM

#

internal class x5fiftM

#

that is an instance member you can't just say Settings.health wherever you want

dark wigeon Mar 22, 2021, 6:40 PM

#

@charred topaz

📎 ModifyBundle.cs

#

I tested with ModifyBundle infernogrimmmod_bundle InfernoKingGrimm.dll

light zodiac Mar 22, 2021, 6:41 PM

#

copper nacelle that is an instance member you can't just say Settings.health wherever you want

so how do i check the health value from the settings file in my code?

copper nacelle Mar 22, 2021, 6:42 PM

#

have a static member or pass the settings to your class

charred topaz Mar 22, 2021, 6:43 PM

#

dark wigeon I tested with `ModifyBundle infernogrimmmod_bundle InfernoKingGrimm.dll`

Awesome! I do have some irl stuff I need to do, so I can try it out later

jolly jungle Mar 22, 2021, 6:48 PM

#

Suppose I have multiple enemies I want to reskin

jolly oriole Mar 22, 2021, 6:49 PM

#

ok

jolly jungle Mar 22, 2021, 6:49 PM

#

Can I go over all things with a HealthManager and then just do ifs for every name?

jolly oriole Mar 22, 2021, 6:49 PM

#

is probably the most memory efficient and performant option

jolly jungle Mar 22, 2021, 6:49 PM

#

Wonderful

#

Thanks

#

So should taking off the Where but keeping the Select do it?

#

Eh who cares let's just try

jolly oriole Mar 22, 2021, 6:51 PM

#

i'd remove the where

cedar hemlock Mar 22, 2021, 6:53 PM

#

jolly jungle Suppose I have multiple enemies I want to reskin

If you're done mind telling me how you did it?

light zodiac Mar 22, 2021, 7:13 PM

#

copper nacelle have a static member or pass the settings to your class

Thanks

light zodiac Mar 22, 2021, 7:22 PM

#

jolly oriole can you rename `Settings` to `_globalSettings`?

doing that worked Thank you

#

grublove

jolly jungle Mar 22, 2021, 7:42 PM

#

Any idea why two references just disappeared?

#

Microsoft.CSharp and System.Net.Http

#

Went poof all of a sudden

#

I didn't touch them

jolly oriole Mar 22, 2021, 7:44 PM

#

milliS

jolly jungle Mar 22, 2021, 7:45 PM

#

So, any ideas, or just panic?

jolly oriole Mar 22, 2021, 7:46 PM

#

no idea

jolly jungle Mar 22, 2021, 7:47 PM

#

And why the, ah, panic?

jolly oriole Mar 22, 2021, 7:47 PM

#

because it went poof

jolly jungle Mar 22, 2021, 7:48 PM

#

Ah of course zote

#

is hk still in .net framework 3.5?

jolly oriole Mar 22, 2021, 7:55 PM

#

1432 yes

jolly jungle Mar 22, 2021, 7:55 PM

#

Hm

#

Damnit

#

So apparently the first one of the two is not meant to exist in 3.5 or something

#

Still can't figure out the second

#

And the poofing part was me misunderstanding an error, it was more of "adhgs help why are these here please make them poof"

cedar hemlock Mar 22, 2021, 7:57 PM

#

will 1.5 also updat the net framework?

jolly jungle Mar 22, 2021, 7:58 PM

#

I think so

#

That's why I asked

vocal spire Mar 22, 2021, 7:59 PM

#

cedar hemlock will 1.5 also updat the net framework?

Yes, to 4.0 I think

cedar hemlock Mar 22, 2021, 7:59 PM

#

ok nice

#

will there be a big difference?

jolly oriole Mar 22, 2021, 8:00 PM

#

not really but still kinda

vocal spire Mar 22, 2021, 8:00 PM

#

Yes, but actually no

jolly jungle Mar 22, 2021, 8:01 PM

#

More like no, but actually yes

cedar hemlock Mar 22, 2021, 8:01 PM

#

then i will probably be back here why my shit aint working

jolly oriole Mar 22, 2021, 8:01 PM

#

well hk 1.5 won't change that much, but a lot of the mapi will change with the 1.5 release

jolly jungle Mar 22, 2021, 8:01 PM

#

Depending on how complicated it is, it can be as simple as updating references

cedar hemlock Mar 22, 2021, 8:01 PM

#

nice

jolly jungle Mar 22, 2021, 8:02 PM

#

Btw what did you want to see earlier ruttie?

vocal spire Mar 22, 2021, 8:02 PM

#

All my mods will require SFCore since I can’t be bothered to do global settings the new way

jolly jungle Mar 22, 2021, 8:02 PM

#

The new way?

jolly oriole Mar 22, 2021, 8:02 PM

#

generic mods get yeeted out of mapi

vocal spire Mar 22, 2021, 8:03 PM

#

You can do the “new” way currently if you want to get used to it

cedar hemlock Mar 22, 2021, 8:04 PM

#

jolly jungle Btw what did you want to see earlier ruttie?

how to reskin multiple enemy's zote

vocal spire Mar 22, 2021, 8:04 PM

#

Remember the code I gave you that was based off a dictionary

cedar hemlock Mar 22, 2021, 8:05 PM

#

ye

#

its 21:06 here so i probably wont be messing with it now tho

vocal spire Mar 22, 2021, 8:06 PM

#

So add more stuff to the dictionary’s initializer, and do some stuff with more textures

cedar hemlock Mar 22, 2021, 8:06 PM

#

ok

jolly jungle Mar 22, 2021, 8:07 PM

#

Alright problem solved, all I needed to do was violently remove the references

vocal spire Mar 22, 2021, 8:07 PM

#

Cool

#

Violence is always the answer

jolly jungle Mar 22, 2021, 8:07 PM

#

Clearly

#

Anyone knows what GameObject.DestroyAll() does?

#

Couldn't find anything about it

jolly oriole Mar 22, 2021, 8:12 PM

#

https://docs.unity3d.com/2017.4/Documentation/ScriptReference/GameObject.html

#

wait

#

is it a helper method from modcommon or something?

jolly jungle Mar 22, 2021, 8:13 PM

#

Also Destroy doesn't work for me

jolly jungle Mar 22, 2021, 8:13 PM

#

jolly oriole is it a helper method from modcommon or something?

tamershrug

#

it's the only thing it elts me do

#

When I write destroy

#

jolly oriole Mar 22, 2021, 8:14 PM

#

it's an extension

jolly jungle Mar 22, 2021, 8:14 PM

#

I also tried Destroy(x)

jolly oriole Mar 22, 2021, 8:14 PM

#

idk which mod adds that though

vocal spire Mar 22, 2021, 8:14 PM

#

GameObject.Destroy(instance) is the normal way objects are destroyed

jolly oriole Mar 22, 2021, 8:14 PM

#

oh yea, destroy is a static method

jolly jungle Mar 22, 2021, 8:15 PM

#

So what should I write

#

?

jolly oriole Mar 22, 2021, 8:15 PM

#

GameObject.Destroy(go) or UnityEngine.Object.Destroy(go)

jolly jungle Mar 22, 2021, 8:15 PM

#

ohhhh

#

I see

vocal spire Mar 22, 2021, 8:15 PM

#

GameObject.Destroy(UnityEngine.Object instance)

jolly jungle Mar 22, 2021, 8:15 PM

#

so that's why it didn't recognise it

#

thanks

cedar hemlock Mar 22, 2021, 8:21 PM

#

bro don't go talking too complicated with me lol

#

(im not very good at unity and coding)

jolly jungle Mar 22, 2021, 9:45 PM

#

Why's it tiny?

#

Or, more to the point, how do I fix this?

#

Should I just get a better sprite?

jolly oriole Mar 22, 2021, 9:47 PM

#

one of the sprite.create parameters is pixelperunit, set that to 66 (or 200/3 to be exact)

jolly jungle Mar 22, 2021, 9:47 PM

#

Why that?

#

Is that a constant in the game?

vocal spire Mar 22, 2021, 9:47 PM

#

No

#

(?)

jolly oriole Mar 22, 2021, 9:47 PM

#

because for no reason the in game sprites are somehow 1.5 times as large as custom ones (while showing in uabe as normal)

jolly jungle Mar 22, 2021, 9:48 PM

#

Hm

#

What about spritesheets?

jolly oriole Mar 22, 2021, 9:48 PM

#

i have no clue why you'd use a spritesheet for a single image

jolly jungle Mar 22, 2021, 9:49 PM

#

Oh no

#

I meant

#

If I load the spritesheets together with this

#

What do i do?

#

How would I differentiate between them?

jolly oriole Mar 22, 2021, 9:49 PM

#

i have no clue how to do that

vocal spire Mar 22, 2021, 9:49 PM

#

Wdym

#

Loading multiple images?

jolly jungle Mar 22, 2021, 9:50 PM

#

I'm loading a bunch

#

Both single sprites and spritesheets

vocal spire Mar 22, 2021, 9:50 PM

#

Are you asking how to load multiple or something else?

jolly jungle Mar 22, 2021, 9:50 PM

#

Something else

#

The spritesheets seem to be correct scale

jolly oriole Mar 22, 2021, 9:51 PM

#

i mean, if the spritesheets are for things like enemies it is perfectly fine to do the same

vocal spire Mar 22, 2021, 9:51 PM

#

Well do what grenade said

#

Sheets are different(tk2d stuff)

jolly jungle Mar 22, 2021, 9:51 PM

#

jolly oriole i mean, if the spritesheets are for things like enemies it is perfectly fine to ...

Oh, k

jolly oriole Mar 22, 2021, 9:51 PM

#

as the texture itself doesn't get altered, just how big the texture is displayed on a sprite

jolly jungle Mar 22, 2021, 9:51 PM

#

For what spritesheets will this not work?

vocal spire Mar 22, 2021, 9:51 PM

#

Wdym

jolly oriole Mar 22, 2021, 9:52 PM

#

one would have to test

jolly jungle Mar 22, 2021, 9:52 PM

#

Ah zote

pure nova Mar 22, 2021, 9:52 PM

#

Aren't sprite sheets made by Unity itself?

jolly jungle Mar 22, 2021, 9:52 PM

#

So if I ever see anything at x1.5 scale, I'll know what caused it

vocal spire Mar 22, 2021, 9:52 PM

#

pure nova Aren't sprite sheets made by Unity itself?

No?

pure nova Mar 22, 2021, 9:53 PM

#

Oh, I must be thinking of something else then.

jolly oriole Mar 22, 2021, 9:53 PM

#

pure nova Aren't sprite sheets made by Unity itself?

you can make spritesheets in unity, but TC has both single sprites in images and spritesheets created using an extension called toolkit2d, which afaik is different from unitys one

pure nova Mar 22, 2021, 9:54 PM

#

Oh, I see.

#

Oh, it seems I've used "Oh," more than one time in a row.

jolly jungle Mar 22, 2021, 9:54 PM

#

Aight, it works!

#

Thanks :D

vocal spire Mar 22, 2021, 9:55 PM

#

pure nova Oh, it seems I've used "Oh," more than one time in a row.

Oh, me too

jolly jungle Mar 22, 2021, 9:55 PM

#

Oh, we all do, sometimes

jolly oriole Mar 22, 2021, 9:55 PM

#

nah

vocal spire Mar 22, 2021, 9:55 PM

#

Oh, nice

coarse lintel Mar 22, 2021, 10:42 PM

#

pure nova Aren't sprite sheets made by Unity itself?

iirc Unity does have the ability to make sprite sheets? I swear I've read that before.

#

oh god I'm snail

#

Pepege

pure nova Mar 22, 2021, 10:49 PM

#

Oh, Shal, it seems you're worthy of the snail role. But to be fair, seeing as how late am I to your message, so am I.

dark wigeon Mar 23, 2021, 12:38 AM

#

yes unity actually makes better packed spritesheets than tk2d

cedar hemlock Mar 23, 2021, 11:03 AM

#

when the update comes how fast will the api be updated?

#

is it a big task or are there only minor differences

nimble lake Mar 23, 2021, 11:32 AM

#

cedar hemlock when the update comes how fast will the api be updated?

Are you talking about the beta?

#

I think they would rather wait for it to fully release

cedar hemlock Mar 23, 2021, 11:32 AM

#

when 1.5 is released

#

cause i'll be .net 4.6+ and unity will be 2020(.2 i think?) so there will be lots to change

nimble lake Mar 23, 2021, 11:34 AM

#

mhm

#

I remember when they just released the beta

#

There were a lot of changes and discussion about that here

#

Even after 1.5 is fully released, it'll be a while before it's supported like it is now

cedar hemlock Mar 23, 2021, 11:35 AM

#

yeah probably

cedar hemlock Mar 23, 2021, 11:37 AM

#

jolly oriole personally i do something like <https://github.com/SFGrenade/MoreHealing/blob/ma...

so i tried that and horribly failed

#

i managed to break the charms in not only 1 but 2 ways

jolly oriole Mar 23, 2021, 11:38 AM

#

cedar hemlock when the update comes how fast will the api be updated?

pretty fast, though i did just remember i had another change for the mapi i'd like to put in there before 1.5 releases

cedar hemlock Mar 23, 2021, 11:38 AM

#

oh ok

#

so i have this:

public const string Charm1 = "Lifeblood Crystal";
        private const string Charm1File = "Lifeblood.Resources.Charm1.png";
...
Assembly asm = Assembly.GetExecutingAssembly();
            dict = new Dictionary<string, Sprite>();
            Dictionary<string, string> tmpTextures = new Dictionary<string, string>();
            tmpTextures.Add(Charm1, Charm1File);
...

            charmHelper.customSprites = new Sprite[] { ts.Get(TextureStrings.Charm1), ts.Get(TextureStrings.QuickestFocusKey), ts.Get(TextureStrings.DeeperFocusKey), ts.Get(TextureStrings.DeepestFocusKey) };

#

and i named the file with the texture Lifeblood.Resources.Charm1.png

#

and made it an embedded recource

#

im missing something

jolly oriole Mar 23, 2021, 12:03 PM

#

depending on the project structure you may have another path instead of "Lifeblood.Resources.Charm1.png" (possibly "Lifeblood.Charm1.png", but generally "Project.OptionalFolder1.OptionalFolder2.Filename.extension")

cedar hemlock Mar 23, 2021, 12:04 PM

#

ooohhh

#

im stupid

#

i thought Lifeblood.Resources.Charm1.png needed to be the name of the image

jolly oriole Mar 23, 2021, 12:47 PM

#

lol

vocal spire Mar 23, 2021, 12:48 PM

#

lol

nimble lake Mar 23, 2021, 12:58 PM

#

jolly oriole pretty fast, though i did just remember i had another change for the mapi i'd li...

oh well then

#

What's mapi?

cedar hemlock Mar 23, 2021, 1:02 PM

#

moddingapi

cedar hemlock Mar 23, 2021, 1:31 PM

#

what is #region blabla ... #endregion for

#

why do they all turn in to this

nimble lake Mar 23, 2021, 1:47 PM

#

What is the Modding reference?

#

I opened up some old projects and a lot of them are missing the Modding namespace and I don't know what is it referencing

cedar hemlock Mar 23, 2021, 1:48 PM

#

its so you dont have to type modding.modhooks and you can just use modhooks

#

you type at the top using modding;

nimble lake Mar 23, 2021, 1:49 PM

#

cedar hemlock you type at the top `using modding;`

That's the one that's missing

#

Where can I find it?

cedar hemlock Mar 23, 2021, 1:49 PM

#

just type it

#

at the top

#

or do you mean

#

nvm

nimble lake Mar 23, 2021, 1:49 PM

#

stone elm Mar 23, 2021, 1:49 PM

#

cedar hemlock what is `#region blabla ... #endregion` for

It does nothing other than group code. It depends on your style, I personally hate them with a deep passion.

nimble lake Mar 23, 2021, 1:49 PM

#

i mean it's missing

cedar hemlock Mar 23, 2021, 1:50 PM

#

you need to reference the assembly.csharp

light zodiac Mar 23, 2021, 1:50 PM

#

nimble lake

add assembly-csharp.dll as a reference

cedar hemlock Mar 23, 2021, 1:50 PM

#

you go to the assembly explorer

#

solution*

#

and right click references

nimble lake Mar 23, 2021, 1:50 PM

#

wait what? but it was already referenced

cedar hemlock Mar 23, 2021, 1:50 PM

#

and add a reference to asembly.csharp

light zodiac Mar 23, 2021, 1:50 PM

#

make sure that the one you're referencing is the modding api

#

you might have referenced the vanilla one

cedar hemlock Mar 23, 2021, 1:51 PM

#

ye

nimble lake Mar 23, 2021, 1:51 PM

#

light zodiac you might have referenced the vanilla one

ohh, yea that was the issue, thanks

cedar hemlock Mar 23, 2021, 1:51 PM

#

stone elm It does nothing other than group code. It depends on your style, I personally ha...

sfgrenade used them in his morehealing mod and i just copied them over and was confused lol

copper nacelle Mar 23, 2021, 1:54 PM

#

yeah they just collapse stuff in an ide

#

and give me brain cancer

cedar hemlock Mar 23, 2021, 1:55 PM

#

cedar hemlock why do they all turn in to this

someone help?

light zodiac Mar 23, 2021, 1:56 PM

#

i used PlayerData.instance.healthBlue = 2; to add 2 lifeblood masks when a scene is changed. When the scene loads, the life blood masks do get added (i can see the lifeblood hit animation and my white masks dont decrease when i get hit) but the lifeblood masks doesn't show up in the HUD. How can i fix that?

copper nacelle Mar 23, 2021, 1:57 PM

#

suffer

#

don't set it

#

use EventRegister.SendEvent("ADD BLUE HEALTH")

cedar hemlock Mar 23, 2021, 1:57 PM

#

afaik they only get added to the ui when the scene changed

cedar hemlock Mar 23, 2021, 1:59 PM

#

copper nacelle use EventRegister.SendEvent("ADD BLUE HEALTH")

w/ ADD BLUE HEALTH you mean PlayerData.instance.healthBlue = 2;

#

?

copper nacelle Mar 23, 2021, 2:00 PM

#

no

#

i in fact

#

mean literally do not that

cedar hemlock Mar 23, 2021, 2:00 PM

#

what

#

then what is "ADD BLUE HEALTH"

copper nacelle Mar 23, 2021, 2:01 PM

#

it adds blue health

cedar hemlock Mar 23, 2021, 2:01 PM

#

ohh

#

you literally

#

do addblue health

#

what

#

does "ADD BLUE HEALTH" give you health?

#

no right?

copper nacelle Mar 23, 2021, 2:02 PM

#

yes

#

it gives you blue health

#

that is why it says

#

add blue health

cedar hemlock Mar 23, 2021, 2:02 PM

#

but where do you put the amount

copper nacelle Mar 23, 2021, 2:03 PM

#

it gives you 1

#

loop it

cedar hemlock Mar 23, 2021, 2:03 PM

#

huh

#

crazy

light zodiac Mar 23, 2021, 2:03 PM

#

copper nacelle use EventRegister.SendEvent("ADD BLUE HEALTH")

Thank you

copper nacelle Mar 23, 2021, 2:03 PM

#

alternatively you can try setting it

#

and then doing EventRegister.SendEvent("UPDATE BLUE HEALTH")

#

but i think i had some issue with that

#

maybe i'm misremembering though

cedar hemlock Mar 23, 2021, 2:11 PM

#

so is this a bit good:

        private bool dash()
        {
            EventRegister.SendEvent("ADD BLUE HEALTH");
            bluehealth++;
            if (bluehealth != 2) 
            {
                dash();
            }           
            throw new NotImplementedException();
        }

#

hmm no

#

sry lemme change it

#

so thats better?

copper nacelle Mar 23, 2021, 2:12 PM

#

what

cedar hemlock Mar 23, 2021, 2:12 PM

#

is that good

copper nacelle Mar 23, 2021, 2:13 PM

#

no

cedar hemlock Mar 23, 2021, 2:13 PM

#

or am i stupid

copper nacelle Mar 23, 2021, 2:13 PM

#

why are you doing this recursively

#

why is there still a throw

#

and why is it called dash

cedar hemlock Mar 23, 2021, 2:13 PM

#

ModHooks.Instance.DashPressedHook += dash; :P

copper nacelle Mar 23, 2021, 2:14 PM

#

fair enough

#

you should be returning true

cedar hemlock Mar 23, 2021, 2:14 PM

#

ok

#

doesn't do shit

copper nacelle Mar 23, 2021, 2:17 PM

#

interesting

#

show

cedar hemlock Mar 23, 2021, 2:17 PM

#

code?

copper nacelle Mar 23, 2021, 2:17 PM

#

yeah

cedar hemlock Mar 23, 2021, 2:18 PM

#

public override void Initialize()
        {
        ModHooks.Instance.DashPressedHook += dash;
        }

int bluehealth = 1;
        private bool dash()
        {
            EventRegister.SendEvent("ADD BLUE HEALTH");
            bluehealth++;
            if (bluehealth != 2) 
            {
                dash();
            }
            return true;
        }

copper nacelle Mar 23, 2021, 2:18 PM

#

why is it still recursive

#

why do you have an instance field

cedar hemlock Mar 23, 2021, 2:18 PM

#

wdym

#

what do i need to change

ornate rivet Mar 23, 2021, 2:24 PM

#

you call dash in dash

cedar hemlock Mar 23, 2021, 2:24 PM

#

oh

ornate rivet Mar 23, 2021, 2:24 PM

#

and bluehealth is an instance field

vocal spire Mar 23, 2021, 2:24 PM

#

lol

vocal spire Mar 23, 2021, 2:25 PM

#

cedar hemlock why do they all turn in to this

You don’t have the got charm bools right this time

cedar hemlock Mar 23, 2021, 2:25 PM

#

great

#

which bool?

vocal spire Mar 23, 2021, 2:26 PM

#

Show your bool hooks

#

Autocorrect evil

cedar hemlock Mar 23, 2021, 2:26 PM

#

yes

#

private void initCallbacks()
        {
            /// Hooks
            ModHooks.Instance.GetPlayerBoolHook += OnGetPlayerBoolHook;
            ModHooks.Instance.SetPlayerBoolHook += OnSetPlayerBoolHook;
            ModHooks.Instance.GetPlayerIntHook += OnGetPlayerIntHook;
            ModHooks.Instance.SetPlayerIntHook += OnSetPlayerIntHook;
            ModHooks.Instance.AfterSavegameLoadHook += initSaveSettings;
            ModHooks.Instance.ApplicationQuitHook += SaveCHEGlobalSettings;
            ModHooks.Instance.LanguageGetHook += OnLanguageGetHook;
            ModHooks.Instance.CharmUpdateHook += OnCharmUpdate;

        }

vocal spire Mar 23, 2021, 2:27 PM

#

No, I meant the OnGet(and set)PlayerBoolHook(s)

cedar hemlock Mar 23, 2021, 2:27 PM

#

ohso

#

private bool OnGetPlayerBoolHook(string target)
        {
            if (Settings.BoolValues.ContainsKey(target))
            {
                return Settings.BoolValues[target];
            }
            #region Custom Charms
            if (target.StartsWith("gotCharm_"))
            {
                int charmNum = int.Parse(target.Split('_')[1]);
                if (charmHelper.charmIDs.Contains(charmNum))
                {
                    return Settings.gotCharms[charmHelper.charmIDs.IndexOf(charmNum)];
                }
            }
            if (target.StartsWith("newCharm_"))
            {
                int charmNum = int.Parse(target.Split('_')[1]);
                if (charmHelper.charmIDs.Contains(charmNum))
                {
                    return Settings.newCharms[charmHelper.charmIDs.IndexOf(charmNum)];
                }
            }
            if (target.StartsWith("equippedCharm_"))
            {
                int charmNum = int.Parse(target.Split('_')[1]);
                if (charmHelper.charmIDs.Contains(charmNum))
                {
                    return Settings.equippedCharms[charmHelper.charmIDs.IndexOf(charmNum)];
                }
            }
            #endregion
            return PlayerData.instance.GetBoolInternal(target);
        }

#

and

#

private void OnSetPlayerBoolHook(string target, bool val)
        {
            if (Settings.BoolValues.ContainsKey(target))
            {
                Settings.BoolValues[target] = val;
                return;
            }
            #region Custom Charms
            if (target.StartsWith("gotCharm_"))
            {
                int charmNum = int.Parse(target.Split('_')[1]);
                if (charmHelper.charmIDs.Contains(charmNum))
                {
                    Settings.gotCharms[charmHelper.charmIDs.IndexOf(charmNum)] = val;
                    return;
                }
            }
            if (target.StartsWith("newCharm_"))
            {
                int charmNum = int.Parse(target.Split('_')[1]);
                if (charmHelper.charmIDs.Contains(charmNum))
                {
                    Settings.newCharms[charmHelper.charmIDs.IndexOf(charmNum)] = val;
                    return;
                }
            }
            if (target.StartsWith("equippedCharm_"))
            {
                int charmNum = int.Parse(target.Split('_')[1]);
                if (charmHelper.charmIDs.Contains(charmNum))
                {
                    Settings.equippedCharms[charmHelper.charmIDs.IndexOf(charmNum)] = val;
                    return;
                }
            }
            #endregion
            PlayerData.instance.SetBoolInternal(target, val);
        }

vocal spire Mar 23, 2021, 2:28 PM

#

Show the settings class you have

cedar hemlock Mar 23, 2021, 2:29 PM

#

this one?

#

private void initSaveSettings(SaveGameData data)
        {
            // Charms
            Settings.gotCharms = Settings.gotCharms;
            Settings.newCharms = Settings.newCharms;
            Settings.equippedCharms = Settings.equippedCharms;
            Settings.charmCosts = Settings.charmCosts;
        }

vocal spire Mar 23, 2021, 2:29 PM

#

No

#

The class

#

For your settings

#

Maybe named something like CHESaveSettings

cedar hemlock Mar 23, 2021, 2:29 PM

#

initglobalsettings?

vocal spire Mar 23, 2021, 2:30 PM

#

No

cedar hemlock Mar 23, 2021, 2:30 PM

#

vocal spire Maybe named something like CHESaveSettings

oh that

vocal spire Mar 23, 2021, 2:30 PM

#

The class

cedar hemlock Mar 23, 2021, 2:30 PM

#

        {
            SaveGlobalSettings();
        }

cedar hemlock Mar 23, 2021, 2:30 PM

#

vocal spire The **class**

ohh

vocal spire Mar 23, 2021, 2:30 PM

#

Class

cedar hemlock Mar 23, 2021, 2:31 PM

#

~~Class~~

#

the whole class