#notmyfault
#archived-modding-development
solemn rivet
copper nacelle
solemn rivet
I think the first version didn't have the Windows descriptor
I think it was added later
copper nacelle
was it angle
copper nacelle
echgod
solemn rivet
idk y it migrated to github
copper nacelle
fucker
solemn rivet
who
solemn rivet
makes sense
he did make a bunch of changes to the code of the installer to add linux/mac support
copper nacelle
how much do i have to pay you to give me a built version without the word windows
building is so much effort
solemn rivet
can it be the version with the search functionality?
solemn rivet
including the pepega if == installed
copper nacelle
it is a knife with legs
solemn rivet
uh huh
ornate rivet
𓌬𓌬𓌬𓌬𓌬
copper nacelle
i despise windows
copper nacelle
i just want to be able to create a build without having to copy it over to an environment with actual filesystem flags
solemn rivet
kek
copper nacelle
bitch i will remove your kidneys
ornate rivet
yooooo
ornate rivet
I'll give you all my kidneys
copper nacelle
idr when it swapped to UnixLink
there used to be Modding API Linux/Mac or something
solemn rivet
did you change the modlinks?
copper nacelle
me?
solemn rivet
ye
copper nacelle
when/what/why
i have changed many things
I don't think UnixLink is my fault though
might be though
it do be
interesting
solemn rivet
debug version, so won't update
copper nacelle
yes
solemn rivet
bruh
copper nacelle
otherwise i can't change modlinks
solemn rivet
I need to ask angle to host it for me
deep wave
yo just downloaded modinstaller2 for windows ONLY
copper nacelle
:echprime:
copper nacelle
listen if you have a good way to create .app on windows i'm all ears
The structure itself is fine, but you can't set it executable properly afaik
solemn rivet
and angle is gonna kill me if I ask him to reset it
copper nacelle
is he
copper nacelle
that's true
solemn rivet
I'm just lazy
copper nacelle
.done
copper nacelle
🥴
ornate rivet
5yusuf6
merry lotus
So wait, is it possible that making the ModdingAPI change today has got people's bloatware antivirus scanners going crazy?
Would it only not have been acting up before, because essentially enough people had used MO1/MO2 with that software on, that it was essentially considered trusted?
Like, the impression I'm almost getting from the last few problems in #archived-modding-help is that the installers are getting pseudo-quarantined by their software.
midnight narwhal
https://paste.mod.gg/fepogozele.cpp anyone have any idea why this isnt working? It seems to make QoL mod throw a NullReferenceException, and it doesnt spawn anything or throw any errors itself
copper nacelle
So wait, is it possible that making the ModdingAPI change today has got people's...
autoupdater if anything
au.exe permission gets denied
midnight narwhal
what's the qol exception
[ERROR]:[UNITY] - NullReferenceException: Object reference not set to an instance of an object
[ERROR]:[UNITY] - QoL.Modules.FastMenus+<FadeOutCanvasGroup>d__10.MoveNext ()
[ERROR]:[UNITY] - UnityEngine.SetupCoroutine.InvokeMoveNext (IEnumerator enumerator, IntPtr returnValueAddress)
[ERROR]:[UNITY] - UnityEngine.MonoBehaviour:StartCoroutine(IEnumerator)
[ERROR]:[UNITY] - <HideSaveProfileMenu>c__Iterator1F:DMD<UIManager+<HideSaveProfileMenu>c__Iterator1F::MoveNext>(<HideSaveProfileMenu>c__Iterator1F)
[ERROR]:[UNITY] - UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
[ERROR]:[UNITY] -
oop sorry ping
copper nacelle
is this 1.5
midnight narwhal
wha
copper nacelle
did you build qol from source
midnight narwhal
no
copper nacelle
are you on 1.4.3.2
midnight narwhal
yes
copper nacelle
and it's only with that code you linked?
midnight narwhal
lemme check
oop nvm it still threw the exception
it still throws it even with my mod disabled
although with my mod enabled it just removes some of the enemies
https://paste.mod.gg/vipebegori.cpp this is the only other code in my mod
copper nacelle
i mean does it happen w/out your mod as a whole
midnight narwhal
yeah
midnight narwhal
lol
copper nacelle
where even does it happen
midnight narwhal
when i load in
midnight narwhal
ok but if its unrelated i still dont know why my thingy isnt working
copper nacelle
the gruzzer spawning thing?
copper nacelle
does it log
midnight narwhal
im testing it without qol to see if that does anything
it logs the "Spawned Gruzzer!"
but nothing spawns
midnight narwhal
lmao
jolly oriole
https://github.com/Ayugradow/ModInstaller/blob/bdcc2f301515dea8e915f2f3e44c33d3c62a7d8c/ModInstaller/ModManager.cs#L451 apparently _apiLink can be null?
jolly oriole
i just started it
deep wave
The updater should run before that check
is the updater being run in form1_load?
and then exiting using application.exit()?
afaik application.exit should wait for load() to end before actually terminating, so all the checks that happen in load still occur while AU is starting, and THEN modinstaller closes
deep wave
application.exit is polite, ie will wait for the process to finish everything it wants to do first
including the load routine
deep wave
i politely decine your offer
solemn rivet
she hates us
you know what the pro move is
one that I should have done ages ago
screw that autoupdater
every time I update the modinstaller I should change something in the modlinks so only the most up-to-date version works
then everyone will be forced to manually update
thanks for coming to my TED talk
jolly jungle
https://github.com/thegodfriend/buzzbo
This is the project right now, please forgive the mess
copper nacelle
ngl there is no release here
jolly jungle
So a zip
copper nacelle
if you're doing zip you just want like a readme + the dll at the base directory
yeah
jolly jungle
Alright
jolly jungle
@copper nacelle this good? https://github.com/thegodfriend/buzzbo/releases/tag/v0.4.2.0
copper nacelle
That's true
solemn rivet
Amazing
copper nacelle
@dark wigeon sorry to be a bother but if you're not busy at some point is there any chance you could push the scenes menu
dark wigeon
yes I can
copper nacelle
tyty
copper nacelle
yeet
dark wigeon
what
copper nacelle
search
dark wigeon
did you like dnspy it
dark wigeon
wow
there's a wpf version of fsmview avalonia somewhere that runs on .net framework
I have like two tests today so maybe sometime at the end of the day
I still want to fix variable bug
midnight narwhal
else if (fsm.FsmName == "Hatcher")
{
fsm.InsertMethod("Fire", 11, () =>
{
for(int i = 0; i < 5; i++)
{
var act = fsm.GetAction<SetFsmGameObject>("Fire", 10);
GameObject child = Object.Instantiate(act.gameObject.GameObject.Value);
child.SetActive(true);
child.transform.position = fsm.gameObject.transform.position;
}
});
}
when i use this it spawns the but they just stay still and dont do anything, how would i fix it?
ornate rivet
We resurrect crossroads
that's what I've been saying
jolly oriole
gimme short list of differences: crossroads <-> modinstaller 1
ornate rivet
```
else if (fsm.FsmName == "Hatcher")
{
fsm...
might have to enable the fsm or send it some event
copper nacelle
crossroads is like an ancient installer that was beat by modinstaller
it was made in unity
midnight narwhal
might have to enable the fsm or send it some event
how would i enable its fsm?
vocal spire
it was made in unity
Scary
vocal spire
how would i enable its fsm?
MonoBehaviour.enabled
solemn rivet
that's the point
we make it in unity
then we build it for every platform
way better than avalonia
midnight narwhal
MonoBehaviour.enabled
what
ornate rivet
thefsm.enable = true
the real problem is probably that it's waiting for an event though
vocal spire
Yeah
vocal spire
then we build it for every platform
Good idea
solemn rivet
🐸🍾
vocal spire
🐸
solemn rivet
poorman's frogchamp
ornate rivet
if the fsm isn't on the fsmviewer, print out the object's hierarchy using yourgameobject.printhierarchytree()
or whatever the method is called
vocal spire
It will generate a file in the mods folder
jolly oriole
is that method base or modcommon
vocal spire
Modcommon I think
solemn rivet
gimme short list of differences: crossroads <-> modinstaller 1
I meant to reply to this but whatever
copper nacelle
think I would rather shoot myself than do ui in unity
ornate rivet
cant wait for kerr to be summonsed here after 50 years
solemn rivet
courtesy of 56
jolly oriole
that's enough unity ui for the rest of the year
copper nacelle
did it look that bad
solemn rivet
I mean
copper nacelle
I thought it had a background at least
copper nacelle
prob
ornate rivet
wouldnt rule out the possibility of 56 sabotage
midnight narwhal
ok i got the hierarchy for the game object, what should i be looking for
ornate rivet
the fsm
midnight narwhal
it seems like its fsm is called "Control" but im probably wrong
dark wigeon
what gameobject?
midnight narwhal
the hatcher child
woeful igloo
Anyone know where I can find the damage from 'super dashing' into an enemy? Trying to set it so the damage is amplified when wearing a certain charm/gives invincibility when super dashing into an enemy with this charm.
jolly jungle
Which fsms did you look in?
ornate rivet
it seems like its fsm is called "Control" but im probably wrong
that sounds right
just send the hierarchy tree here
dark wigeon
I'm not entirely sure what gameobject is being spawned
all of the gameobject refs are null in fsm view
I don't know if the hatcher baby spawners are actually just the babies
deep wave
gradow what
this could be a potential reason why modinstaller1 could be breaking fantastically atm
this is why _apiLink is being null 
jolly oriole
are the 1.3.x mapi versions for past steam betas?
copper nacelle
1315 was a patch bro
jolly oriole
according to GoG:
R: 1.0.2.8
R: 1.1.1.8
R: 1.2.2.1
B: 1.3.2.8
B: 1.3.3.3
B: 1.3.3.7
R: 1.4.2.4
B: 1.4.2.7
B: 1.4.2.8
R: 1.4.3.2
obv R for release, B for beta
copper nacelle
well it's wrong
jolly oriole
or did it just got on gog with 1.4.x
leaden hedge
they are racist against blue things
copper nacelle
so fucking racist
jolly oriole
could've been a private beta (only password protected), idk why that would be the case though
leaden hedge
it was a dlc patch
copper nacelle
yeah
leaden hedge
1.0 no dlc
1.1 hd
1.2 gt
1.3 lb
1.4 gg
copper nacelle
It had a beta before releasing but it did release
jolly oriole
sadge though
leaden hedge
maybe its not there because its not a major content release
and they are like "who would ever want to play lifeblood again" 
copper nacelle
why
jolly oriole
inventory venting
leaden hedge
they are sprites from a jp game
its jewel and event
theres also "chage" for charge
copper nacelle
suffering
deep wave
all the versions available on gog are specifically useful for speedrunners
so that's probably why
copper nacelle
bro what about the hot 107 runs
dark wigeon
wow a pr
dark wigeon
because avalonia
copper nacelle
that's true
copper nacelle
awful
copper nacelle
🥴
copper nacelle
what
astral oxide
i should really get back into modding this game
current plan: you've heard of uumuu, you've heard of uuwuu, now get ready for uuuuu
ornate rivet
sigh
astral oxide
one question before getting to that though for a different possible mod:
has anyone ever managed to mod in extra mask shards into the world to give the player more masks
solemn rivet
gradow what
it's fixed in the current ver
the thing is, the autoupdater was supposed to prevent that issue from ever happening
but it clearly doesn't
dark wigeon
linux not supported because no one uses linux
basically all ui frameworks suck
the solution is clearly to use all of them: http://haxeui.org/
for windows and mac
linux is "community supported"
which just means they won't do it
also isn't maui just renamed xamarin
yeah there was a big github issue on it
yeah haxeui can do wxwidgets and qt but it's haxe
wait a second
haxe compiles to c#
gg
midnight narwhal
one question before getting to that though for a different possible mod:
has any...
wtf sploopo from fargaming
vocal spire
one question before getting to that though for a different possible mod:
has any...
I don’t think there’s an example, but it should be as easy as preloading the mask shard, instantiating it in the correct scene, and setting some Playerdata stuff in a fsm on it to different stuff. I think you might need to edit the mask ui since it caps or something? I think somebody mentioned that a while ago or something
jolly oriole
one question before getting to that though for a different possible mod:
has any...
The more difficult psrt id that the game only displays up to 11 normal masks (all 9 base game ones + heart charm)
jolly oriole
fair rampart
Thanks
lime cobalt
Curious about something, how hard would it be to change frames and/or animations on a mod?
jolly jungle
I think they mean texture, yeah
copper nacelle
that's not particularly hard
solemn rivet
pixel knight is a shader right?
or was it glitch knight
idk what its called
the thing you made years ago 56
copper nacelle
yeah
glitch knight is a shader
the invert one applied a texture transformation in just normal code
solemn rivet
icic
vocal spire
Cool
lime cobalt
oh that, I was talking about Hollow Point
I don't know why but the way the gun doesn't really interact well with the Knights other actions at times is kinda bothering me so I was wondering if it was possible to make changes to it
deep wave
hollow point's source code is publically available
copper nacelle
it's not a texture change
lime cobalt
ahh right, github
copper nacelle
there's just a gameobject parented to the knight
lime cobalt
Well I'll get it and see what if me or people I know can do something...hopefully
lime cobalt
Well I found the github anyway, thank you though
ornate rivet
there's just a gameobject parented to the knight
imagine parenting when you can set the position every frame and be part of the pale champion gang
copper nacelle
please my eyes
jolly jungle
Gas attacks dont affect mosskin enemies, doesnt work either on vanilla, im not sure if this is a vanilla bug or a feature due to lore reasons.
What does this even mean
ornate rivet
stuff like the spore gas charm thing don't affect mosskin enemies
might be because of lore (spore doesnt harm them because they are related) or might be a glitch
just realized, he means the DD-crest gas, not the sporeshroom gas
woeful igloo
So, err, how does one get their mod added to the community folder?
copper nacelle
pr modlinks
woeful igloo
pr modlinks?
woeful igloo
Ohhhh. Thanks!
woeful igloo
Okay, made a modlink. Who do I send it to? I assume there's an admin who has access to the shared folder to add to it?
copper nacelle
you make a pull request on github
or you can just give me the modlink if that's easier
wicked spear
How do I use sprite packer in krita
native pelican
I noticed that the latest code in the modding API would break grassbag, because grassbag accesses ModSettings.BoolValues which seems to be removed now. There's a new version of GrassBag (with a new name) that doesn't do that anymore, so it's fine, but figured I'd mention since it might not be obvious that change breaks backcompat.
jolly oriole
the 1432 mapi or updates of 1.5 one?
native pelican
I'm not sure, lemme just find the commit so I can be precise.
vocal spire
I noticed that the latest code in the modding API would break grassbag, because ...
Compatibility already ded
jolly oriole
native pelican
<https://github.com/seresharp/HollowKnight.Modding/commit/e12475f852f62609af811f...
Yep! Just found it too
jolly oriole
yeah, that's already for the 1.5 beta patch
newest 1432 one would be https://github.com/seresharp/HollowKnight.Modding/commit/13d6a87c0f272ba10101b6201a0a8d6a8cc01820
native pelican
cool 👍
I'm a bit confused by those versioning numbers, but sounds like there's at least two major versions of the modding API in the works that aren't compatible with eachother. So sounds like all is well.
jolly oriole
1432 is current hk release and 1.5 are the beta patches put out the last days (1.4.3.2 and 1.5.numbers)
native pelican
Aha! They're HK releases. Thank you, I think I'm understandin gbetter now.
I hope they didn't add more grass in 1.5 🤔
copper nacelle
yeah 1.5 breaks every mod anyways due to net 4 so I took it as an opportunity to remove lots of stuff
native pelican
ah makes sense, hard to pass up opportunities like that
deep wave
currently none 
vocal spire
?
solemn rivet
amazing
the code is such a mess atm
I honestly think it'd be easier to just rewrite it
deep wave
i initially wanted to steal code from modinstaller to hkmanager but i decided to just move on without
copper nacelle
ahead of you on that one
vocal spire
If you won’t do it I’ll do it
solemn rivet
that's how installer2 came about
me and 56 had this plan to rehash the installer
but I was lazy
copper nacelle
and mac deprecating 32-bit so you can't use the other one
deep wave
56 maybe add a special case for modding api now that it is un-windowsed to put it at the top of the list, and disable all other options until you install it?
copper nacelle
why
deep wave
idk i want to stop telling people to install modding api when they complain mods aren't working
deep wave
does modinstaller2 also force enable dependencies when a mod is enabled?
might be a good idea if not
copper nacelle
no
deep wave
plus if you verify game files then it just says modding api is out of date, which unfortunately i see no way around
copper nacelle
echgod
solemn rivet
you know what you should do
you should integrate installer2 to gog galaxy
so you can launch and install mods for multiple versions of hk from it
native pelican
i have been kinda interested in hacking on the mod installer, figured i might try looking at it after i've got grassy knight (grassbag's successor) to the point that I feel good spreading the good word of the grass % speedrunning category.
copper nacelle
dmca%
jolly oriole
you should integrate installer2 to gog galaxy
idk if gog would like that
solemn rivet
I mean, the solution to that problem is right there in your name
jolly oriole
it did take me a second to leave out 2 letters tbh
copper nacelle
what the fuck
bitter pollen
srry
weak lodge
ok
copper nacelle
uh huh
bitter pollen
what
ornate rivet
ignore me
ornate rivet
go to #archived-modding-help
weak lodge
ornate rivet
🐌
ornate rivet
good
bitter pollen
i dont see it in the pinned
bitter pollen
i did
copper nacelle
what
copper nacelle
then why are you still speaking
ornate rivet
the point was that you should ask those kinds of questions in #archived-modding-help
vocal spire
People be dumb again
native pelican
i am thoroughly confused. the hud elements' local scale to world scale machinery is all weird (specifically the geo counter's sprite but i suspect all those objects are guilty). despite me putting a lot of non-1 local scales in the transform heirarchy, and the renderer correctly respecting these local scales and scaling the sprite correctly, geoSpriteObject.transform.lossyScale gives a 1 vector.
been smashing against this for awhile to try and feel like i understand what's happening. no success yet.
is there some special "hud canvas specific" transform machinery i'm totally missing?
native pelican
ah wait, that's not an accurate description of what's happening. i messed up my testing and was logging lossyScale before all of my localScale muckery. i still don't know what's going on and now i'm back to not even knowing what i'm missing.
wicked spear
So... my sprite packer broke must’ve done something wrong when I put the sprite folder in the folder thing
crystal sky
Hi, a couple of friends and I have some great ideas for new charms, new, areas, and new dialogue to add to the game but none of us know the first thing about making mods. Do you think you could point us in the right direction?
vocal spire
ah wait, that's not an accurate description of what's happening. i messed up my ...
Can you show your code?
vocal spire
Hi, a couple of friends and I have some great ideas for new charms, new, areas, ...
Look at the getting started page, video tutorials page, mod class page, hooks page, adding charms ect page, and modifying scenes with utiny ripper page
For adding dialogue, do you mean adding a new conversation to a npc or adding a new npc or something else?
Or changing dialogue?
native pelican
Can you show your code?
i'll form up a small test case if i'm still stuck after trying a few things here... i'm not sure what i'm even getting stuck on right now honestly, been smashing against this a bit too long is suspect
charred topaz
@native pelican I think it's because many HUD elements in the game seem to not the normal way of displaying UI elements in Unity, which is to have a canvas object and all the UI elements inside of it. I also dealt with this when developing my "WeaverMod Settings" screen, and I just ended up adding a canvas myself and using that to display it. The method that the game uses could be using 2dToolkit, as shown here:
https://www.2dtoolkit.com/docs/latest/ui/basic_layout.html
native pelican
hmm that looks like a good read. there's these definitely have the 2k2d (or whatever that combination of letters and numbers is) components
thank you!
jolly jungle
Is the code for Customknight publicly available?
jolly oriole
jolly jungle
Thanks 
solemn rivet
You can also see how I handled it in enemyhpbar
I basically used a canvas, like nickc1 said
upbeat sun
how do i start developing mod?
ornate rivet
crystal sky
For adding dialogue, do you mean adding a new conversation to a npc or adding a ...
Thank you for helping! We aim to add a new conversation to both Tiso and Cloth along with new charms. We also aim to give Tiso a dream battle. I’ve been looking into it and I was wondering two things, is it possible to put custom music in Hollow Knight, and can you please point us in the direction of a way to make a custom sprite sheet for a new boss? We do not aim to change any existing content in the game, just add to it. And also any help with adding dialogue conversations would be greatly appreciated.
Although, now that I think of it, we do need help on making a new scene transition in Sly’s old house to take the player to a new area we are planning out. Honestly odds, ends, tips, guides, anything you can do to help us would be great!
We’re planning to call this mod The Chosen Vessel based on the cliche of
||The Pale King choosing the Hollow Knight||
But in our mod, it speaking of you, the little knight being chosen by fate
vocal spire
Cool
vocal spire
Thank you for helping! We aim to add a new conversation to both Tiso and Cloth a...
Adding custom music is easy, I think you can look on the charms page again(the page contains a bunch of stuff in SFCore) adding dialogue will require editing an fsm I think
jolly oriole
custom music is easy, the most difficult part of it was to figure out what audiomixersnapshots exist and then the construction of musiccues
charred topaz
I may have something that could help. I compiled a document with all the music related groups and snapshots, as well as their volume settings. Did this a while back when I worked getting music to work in WeaverCore.
jolly oriole
the most cursed about that table is that the action, extra, ... columns aren't sorted the same way as in the enum
jolly oriole
thx
quasi ridge
how to edit charm stats?
cedar hemlock
how to edit charm stats?
idk if you mean that
I used if (PlayerData.instance.GetBool("geo") > 100) {} and it says "Error CS0019 Operator '>' cannot be applied to operands of type 'bool' and 'int' "
can anyone help?
steady comet
Well the geo is an int so you should try using PlayerData.instance.GetInt("geo") instead I guess
jolly oriole
@copper nacelle you pasted a google drive ID again https://github.com/Ayugradow/ModInstaller/blob/master/modlinks.xml#L94
jolly oriole
idk, the repo just hosts the dll
ornate rivet
is there a special substring for the entry gate when I want the player to be in the lying down position when they return?
rn I just use "door_dreamReturn"
but the player can move around while they are in the lying down animation so I was wondering if maybe that was wrong
jolly oriole
afaik the transition and maybe a fsm on the dreamreturn thing should prohibit moving
ornate rivet
weird
it works fine when the player dies and leaves the dream but when the player wins and I do a BeginSceneTransition to leave, the player can move after the transition
jolly oriole
the game does a bit more than just beginscenetransition
the fsm i have this from is GG_Nosk_V/Boss Scene Controller - Dream Enter Next Scene
cedar hemlock
What is "SHA1"?
jolly oriole
a checksum
cedar hemlock
What do i fill in there
jolly oriole
the ckecksum of your mod (the .dll file most likely)
cedar hemlock
where do i find the 'checksum'
jolly oriole
7-zip adds a CRC SHA option to the right click menu, in which you can select sha1 and view the checksum, but there are also alternatives
like fciv (afaik a microsoft tool)
or possibly also online tools
cedar hemlock
ok
ornate rivet
I think it was HeroController.instance.EnterWithoutInput(true);
Thanks. I was using an FSM to do it but the fsm didn't have that in it.
ornate rivet
How do I change the key white defender uses to get the text at the end of the fight
jolly oriole
// index 3 is to get the amount of defeats of wd
// to use when normal wd, is the repeat convo
whiteDefenderGo.GetComponent<EnemyDeathEffectsUninfected>().corpsePrefab.LocateMyFsm("Control").GetAction<BuildString>("Set Outro Msg", 4).stringParts = new FsmString[] { "yourConvoNameHere" };
// or these two
whiteDefenderGo.GetComponent<EnemyDeathEffectsUninfected>().corpsePrefab.LocateMyFsm("Control").GetAction<CallMethodProper>("Outro Msg Repeat", 1).parameters[0] = "yourConvoNameHere";
whiteDefenderGo.GetComponent<EnemyDeathEffectsUninfected>().corpsePrefab.LocateMyFsm("Control").GetAction<CallMethodProper>("Outro Msg 1a", 1).parameters[0] = "yourConvoNameHere 1";
whiteDefenderGo.GetComponent<EnemyDeathEffectsUninfected>().corpsePrefab.LocateMyFsm("Control").GetAction<CallMethodProper>("Outro Msg 1b", 1).parameters[0] = "yourConvoNameHere 2";
thanks
vocal spire
?
ornate rivet
<@159242762082844672> you pasted a google drive ID again <https://github.com/Ayu...
he is responding to that
midnight narwhal
does anyone know what path i should use to DllImport for a mod
trim moss
Im trying to give the dash(mothwing cloak ) to the player and before they have encountered hornet using PlayerData.instance.hasDash = true; The mothwing cloak shows in player inventory but is not able to be used also when after fighting hornet the dreamrs cutsence dose not play and the gates in do not open softlocking the player.
this works for all other ablilitys like double jump
copper nacelle
canDash
trim moss
were is that in documentation
copper nacelle
I gotta say the internal classes are not exactly documented
As far as the cutscenes go you prob just need to modify an fsm
copper nacelle
not necessarily but a lot of the logic in this game is
trim moss
btw that worked
copper nacelle
nice
trim moss
how would i know if cutsences are controlled by a fsm
copper nacelle
use the fsm viewer and look at the scene
trim moss
I got fsm viewr and I dont know what level# is the hornet boss room
copper nacelle
do you have debug mod
copper nacelle
there's a scene name
deep wave
hornet 2 boss room? you mean Edge_Hornet_Sentinel_Arena?
copper nacelle
h1
copper nacelle
Sounds right
dark wigeon
I just use grep to find scenes so I don't have to open the game
copper nacelle
why
jolly oriole
<@&283547423706447872> channel spammer 667488264818655250
floral furnace
potent dirge
Are you 56?
dreamy spruce
shoutout to 56
hello my fellow Arabian friend
ornate rivet
unfortunately I'm iranian not arabian, but hi anyways friend 
solemn rivet
Amazing
steady comet
Maybe I'm being dumb but are there some FSMs missing from the FSM viewer? e.g. the scene dump for Crossroads_04 includes an FSM for the object Corpse Big Fly 1(clone) FSM name corpse but I can't find it in the FSM viewer list for Crossroads_04. (It's the same for other corpse FSMs, it seems)
steady comet
Oh thanks! 
jolly oriole
saleh did you find out?
ornate rivet
I just did it differently
jolly oriole
btw, it may have been DialogueBox.SendConvEndEvent()
ornate rivet
btw, it may have been `DialogueBox.SendConvEndEvent()`
what tells it to do that when the player presses space
shoot sorry didnt mean to ping
jolly oriole
what tells it to do that when the player presses space
i have no clue and it isn't even the right event though
full peak
Does anybody have a mod where it does nothing but remove the shade?
full peak
Are you talking to me?
native pelican
I'm so pleased with how this counter turned out. Thanks for all your help ya'll. Got a ton of help from this channel.
jolly oriole
doesn't it clash with high geo counter?
jolly jungle
Can anyone remind me what is going to change when the new updates come out of the beta?
jolly oriole
Can anyone remind me what is going to change when the new updates come out of th...
playmaker fsm
jolly oriole
some event names changed
native pelican
doesn't it clash with high geo counter?
no, i built a simple layout system. they'll all move out of the way of eachother if needed.
jolly oriole
ah ok
full peak
How easy would it be to make a mod that just gets rid of the shade?
solemn rivet
I'm so pleased with how this counter turned out. Thanks for all your help ya'll....
are you actually counting how many times the player has slain a poor unsuspecting piece of grass? Amazing
solemn rivet
How easy would it be to make a mod that just gets rid of the shade?
I don't think it'd be hard at all
but idk
never messed with it
native pelican
are you actually counting how many times the player has slain a poor unsuspectin...
the grass is guilty
they're all guilty
oak kestrel
yo does anyone know when silksong is coming out
worn eagle
yeah
copper nacelle
yeah
jolly oriole
yo does anyone know when silksong is coming out
i've compiled a short list of things all around silksong https://hk.sfgrena.de/
oak kestrel
die
ornate rivet
fungus3_39 should be fungus3_49 in the google drive with all the maps
pls fix
@ mola
native pelican
i've also been tripped up by that
jolly oriole
i never had that poggers
ornate rivet
it happens once every ten times I open the game
players will just have to live with it like I did
jolly oriole
is it because pale court?
ornate rivet
yea
jolly oriole
smh
ornate rivet
was I supposed to use an older version of SFCore for the special title screen? Because I accidentally updated it and now there's a bunch of SFCore errors at every scene
ornate rivet
ok will do
full peak
So you don't think it would be that hard. Unfortunately, a: I have no coding skill, and b: I have a mac. @solemn rivet
copper nacelle
b is irrelevant
jolly jungle
And a is fixable
native pelican
yeah i do all my mod dev on mac. don't even use vs
jolly jungle
So I'm going over traitor god to see how the texture is changed, and I see different objects reskinned into sprites found in TraitorGod.Sprites[]
Now, those sprites are, if I understood correctly, the bunch found in the Assets folder
Thing I can't find is where and how is TraitorGod.Sprites[] defined
Wait I'm an idiot 
TraitorGod is just the other file
full peak
Well how would I make a mod that just makes a shade not spawn then?
native pelican
Well how would I make a mod that just makes a shade not spawn then?
getting started progrmaming if you never have before is tough. you'll spend a lot of time just smashing against walls. but if you're down for a long frustrating experience, you'll want to install visual studio for mac and then try and install the modding api: https://radiance.host/apidocs/Getting-Started.html
there's some example mods that ship with it that you can just try building and running in-game to get the hang of what building entails
vocal spire
So nothing new I need to take into account when making a new mod?
Updated to net 4
jolly jungle
aight, thanks
jolly oriole
modding api crashes the latest beta when creating a new godseeker save
apparently also entering those
gusty dove
yo does anyone know when silksong is coming out
ik im late but silk song is coming out in 205228525
jolly oriole
crashes on normal saves as well
copper nacelle
did they change?
jolly oriole
idk how to check that
copper nacelle
hmmmmm
just dnspy it
Oh my game was dying at startup
Not even on save load
Forgot about that
Sick
jolly oriole
seems to still be netstandard
jolly oriole
afaict it crashed here
0x000001EAEB9B4C79 (Mono JIT Code) (wrapper managed-to-native) UnityEngine.GameObject:GetComponent (UnityEngine.GameObject,System.Type)
oh that's an easy fix then
jolly oriole
poggers
full peak
I'm honestly not sure if it's worth going through all the trouble just to make a mod that removes the shade.
deep wave
you could probably get easymod's code and remove everything that doesn't involve the shade mechanic
full peak
hmm... maybe
I'm trying to figure out how to access its code
I know very little about any of this
knotty monolith
full peak
I only want no-shade though. That's the problem. It's too easy for me with everything else in there.
deep wave
that's the code
ornate rivet
How exactly does the cameralockarea use the boxcollider's values to set the camera's min/max fields?
I've tried making a boxcollider that that covers the spot where I want the camera to freeze but instead of locking there, the camera moves to the (0,0) coordinate instead for some reason
I have it set like that
deep wave
I only want no-shade though. That's the problem. It's too easy for me with every...
because it's fairly trivial, i've done it for you here 
shade spawn only
ornate rivet
GameObject parentlock = GameObject.Find("CameraLockArea (1)");
BoxCollider2D lockCol = parentlock.GetComponent<BoxCollider2D>();
CameraLockArea cla = parentlock.GetComponent<CameraLockArea>();
lockCol.size = new Vector2(32.7f, 24.57f);
lockCol.offset = new Vector2(-32.123f, 0f);
cla.cameraXMin = 167f;
cla.cameraXMax = 231f;
cla.cameraYMin = cla.cameraYMax = 102f;
I tried this
wdym -1?
I printed the mins and maxes and they're just zero
dark wigeon
you can set the camera min max values to -1
ornate rivet
dark wigeon
any log statements from the game?
ornate rivet
the one above
dark wigeon
from the game not you
ornate rivet
nope
well there's
but idk if this has to do with the lock
it doesnt happen when I set the lock so...
I usually just do it in a hacky way where I hook to cameralockarea's trigger2d and the min/maxes there but I wanted to do it the right way this time
dark wigeon
when/where is this being printed and are you printing cameraXMin/max or something else
ornate rivet
I'm printing them in the trigger2d
dark wigeon
Trigger2d where?
ornate rivet
in the CameraLockArea
dark wigeon
so at the beginning of OnTriggerEnter2D you print cameramin/max?
nothing can set those values to 0 unless that trigger happens before you set the values and it's still default 0
full peak
Yo @deep wave . I appreciate the whole thing, but for some reason my shade still spawned when I died. Did I do something wrong?
deep wave
screenshot the title screen?
oh you already did in #archived-modding-help
looks like you still have it disabled/not installed
check if it's disabled in the in game mods menu
full peak
Naw I checked. It says it is enabled. I'll try turning it off then on again.
Still spawning one (1) whole shade
trim moss
The mod manager should have a refresh option so you dont have to close and open when you want to detect new mod that you manully put in the mod folder.
jolly oriole
doesn't it have the Manually install mods button?
jolly oriole
but maybe https://docs.microsoft.com/en-us/dotnet/api/system.io.filesystemwatcher is something one could consider
ornate rivet
In regards to the CameraLock problem from yesterday, I deleted the CL and made a new one with code with the exact same settings, and now it works
So maybe some of the settings were breaking in the transition from unity to bundle?
jolly oriole
idk why it would, but maybe
btw, idk if you edited the cameralockareas by hand, but for visualizing i also have an editor script for those (https://github.com/SFGrenade/ModdingHelper/blob/master/Unity Scripts/Editor/CameraLockAreaEditor.cs)
ornate rivet
ooo
limber storm
I had a question about this FSM. Why does it set Time per MP Drain to Time per MP Drain UnCH instead of just using Time per MP Drain?
I can see that there are three different values, though I'm confused why there are three in the first place instead of just two
vocal spire
Maybe different charms?
jolly oriole
they could've hardcoded it, but the fsm doesn't get unloaded or reloaded ever, so they use that to reset the time to normal when focusing without quick focus
limber storm
So the 0.0325 value just doesn't actually get used?
jolly oriole
afaik yes
leaden hedge
you either need 3
if(quickFocus)
chargeTime = chargeTimeCH;
else
chargeTime = chargeTimeUCH;
or hardcode it
if(quickFocus)
chargeTime = 0.018f;
else
chargeTime = 0.027f;
or some complicated stuff
if( (quickfocus && !wasQuickFocus) || (!quickfocus && wasQuickFocus)){
float temp = chargeTime;
chargeTime = chargeTime2;
chargeTime2 = temp;
wasQuickFocus = quickfocus;
}
the 0.0325 was probably just old code before they added charms
ornate rivet
hmmmmmmm for some reason the player doesnt take dmg any more in my custom scene
the invincibility is set to false
jolly oriole
nice
vocal spire
Cool
full peak
@deep wave Sorry about bothering you, but as I said earlier, the shade still spawns, and the game definitely detects the mod as being active. It says EaseMode 1.0.0 in the corner.
ornate rivet
Could it be because of this?
[ERROR]:[UNITY] - NullReferenceException: Object reference not set to an instance of an object
[ERROR]:[UNITY] - PlayerData.SetHazardRespawn (HazardRespawnMarker) <0x00012>
[ERROR]:[UNITY] - HeroController.FinishedEnteringScene (bool,bool) <0x00161>
[ERROR]:[UNITY] - (wrapper dynamic-method) HeroController/<EnterScene>c__Iterator0.DMD<HeroController+<EnterScene>c__Iterator0..MoveNext> (HeroController/<EnterScene>c__Iterator0) <0x0170d>
[ERROR]:[UNITY] - UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator,intptr) <0x00046>
[ERROR]:[UNITY] -
how did you make PlayerData.SetHazardRespawn throw an nre?
deep wave
<@!196347053100630016> Sorry about bothering you, but as I said earlier, the sha...
do you also have Serecore enabled?
ig i'll @full peak i've tested this and it works on my end, make sure you also have serecore enabled as it is required by the mod (doesn't stop it from loading though, there should probably be a check for that )
jolly oriole
just use a serecore method that does nothing in initialize, crashes if serecore's not present lol
full peak
Oh thats probs it
deep wave
yes but i didn't make the mod 
i just unhooked everything except shade spawning
tough wyvern
hi there, i dont want to interrup or anything, but someone here knows where or how to find the original pale king skin mod? The one that changes the spells and stuff
deep wave
when the mod is made in a nice modular fashion then just doesn't have a globalsettings 
tough wyvern
i search and search, but i only found the public one
deep wave
#modding-discussion or #archived-modding-help , but iirc the pale king is a private(?) skin for customknight
tough wyvern
<#610754780461006848> or <#462200562620825600> , but iirc the pale king is a pri...
Mmmmm, well thanks any way, i will keep searching
dire tiger
@tough wyvern It was a challenge skin and you won't be able to obtain it unless the challenge comes up again
proven cipher
If you find somebody distributing it, please inform people here, as they shouldn't really be doing that.
dire tiger
there's no point in searching for it and distributing challenge skins is scummy and against the intention of the skin makers
full peak
Yo I did it! It works! Thanks so much @deep wave and @light zodiac for helping me with all this! I appreciate it very much!
tough wyvern
<@!817759096085807145> It was a challenge skin and you won't be able to obtain i...
Curious, thanks for the tip
dire tiger
there's a chance
but I wouldn't advise keeping your hopes up
people have been pirating skins and giving them to people who didn't earn them by doing the challenges required
tough wyvern
I hope that challenge comes up again some day
dire tiger
so the skin makers feel discouraged
tough wyvern
people have been pirating skins and giving them to people who didn't earn them b...
well thats some bad shit
tough wyvern
so the skin makers feel discouraged
with reasons
jolly oriole
how tf does
foreach (var callback in AddCustomRunEffectsHook.GetInvocationList()) {}
throw an NRE?
the type of it is
public delegate (int enviromentType, GameObject runEffects) CustomRunEffectsHook(GameObject runEffectsGo);
public static CustomRunEffectsHook AddCustomRunEffectsHook;
stone elm
If no methods have been added to the event itself then it returns null. Events should generally be checked for null before usage.
no registration == nre
registered lambda == no nre
best (depending on taste) route is simple
if (AddCustomRunEffectsHook != null) {}
Is there anywhere an organised list of links to the code of all the different mods?
Or do we just need to remember who made what and look for it
vocal spire
Or do we just need to remember who made what and look for it
Yep
jolly oriole
best (depending on taste) route is simple
```cs
if (AddCustomRunEffectsHook != n...
yeah, just did it, but good to know the mechanics behind it
jolly oriole
Or do we just need to remember who made what and look for it
in most cases the code is on github
somewhere on github
prime urchin
You might be able to look in 'modlinks.xml' as some people are using a github link for their mod but other than that it's up to a simple search
jolly oriole
https://github.com/RechercheJewel/HK-Job-Change i love this repo
jolly oriole
appears to be
stone elm
They've taken the liberty of precompiling the source code for us...
deep wave
binaries in repos 
jolly jungle
Welp I can't find transtrans 
jolly oriole
that is indeed not on github
prime urchin
You can use dnSpy or similar, yeah
prime urchin
You just have to open up the .dll with it and you'll see the decompiled C# code
it's not as good as actual source code but the logic is all there and mostly clear
jolly jungle
Hm
wicked spear
Do I extract the sprite folder before I put it in
wicked spear
What's the context
When I put the sprite folder in my sprite packer won’t open but when I take the sprite folder out it starts working again
native pelican
i'm trying to know exactly which enemy gameobject spawned a particular enemy (ex: the particular aspid mother that spawned a particular hatchling). anyone know of a function that the game calls when its about to spawn these mini-enemies that i can hook into?
jolly jungle
Isn't it in the fsm somewhere?
Gimme a sec I'll find a scene with one, unless you have an example alrady
Huh
vocal spire
Hmmmmmmmmmmmmmm
vocal spire
I'll need to learn at some point anyways though
How have you been modding?
You need dnspy to look at the code of hk
Or ilspy
cedar hemlock
i also mod without looking at the games code bc i cant find how to search in dnspy
vocal spire
Search for an assembly or search in the assembly?
native pelican
Isn't it in the fsm somewhere?
i don't even know what an FSM is still 😅, haven't needed to figure it out yet... though it sure sounds state machiney.
cedar hemlock
Search for an assembly or search in the assembly?
just search everywhere
cedar hemlock
i have used all the shortcuts but couldn't find it
prime urchin
Edit > Search Assemblies once you have some open
Right Click on something > Analyze to see where it's used
vocal spire
Smh not gonna grab my pc to get the steps
native pelican
Huh
i've been a bit worried i'll have to uniquely hook into each enemy that can spawn others... i've been hoping the game always calls some "spawn my babies" function regardless of whos doing the spawning.
prime urchin
@native pelican I want to say there's a spawn state in the FSM you can hook, I'll have to look again
native pelican
<@!425331651971645460> I want to say there's a spawn state in the FSM you can ho...
how are you looking? dnspy?
jolly jungle
How have you been modding?
wdym
vocal spire
Fsm viewer
native pelican
You kinda need the code of the game to do pretty much anything in my opinion
i made a perfectly good grassy mod without ever looking at the game code 🤷♀️
vocal spire
i made a perfectly good grassy mod without ever looking at the game code 🤷♀️
Ok
How long did it take?
We’re there times where you didn’t understand what was going on?
native pelican
We’re there times where you didn’t understand what was going on?
lol this is way too leading. if you're trying to show that i would've had a faster time of it looking at the code, you may be right. i really don't know.
jolly jungle
You kinda need the code of the game to do pretty much anything in my opinion
You saw what I did though, it wasn't much
vocal spire
Good point
native pelican
oof... this sounds like it'll be a rough time. a lot of one-offs.
prime urchin
so what exactly are you trying to do?
native pelican
<https://radiance.host/apidocs/PlayMakerFSM.html>
aha! i remember that page. thank you! i'll read this now that i have much more understanding of modding things generally.
native pelican
so what exactly are you trying to do?
tryna help the folks over on fireborn discord server who wanna do silly %. their rules say that if you kill and enemy you've gotta kill all of its spawn too.
jolly oriole
tryna help the folks over on fireborn discord server who wanna do silly %. their...
most of them don't drop geo though
native pelican
are you talking about me? my pronouns are they
jolly oriole
if not all
native pelican
yeah, i think that'll be my saving grace. i gotta think about what spawns i can ignore because of that.
if there's only a few, i can probably do some one-off shenanigans
was hoping there was some nice "spawnMyChildren" function that'd take care of it across the board though so i didn't have to worry about it
but whatcha gonna do 🤷♀️
prime urchin
The hatcher has a state that sends a SPAWN event to a game object which you might be able to 'hook', but I've never tried something like that
jolly oriole
afaik (haven't looked at it though), it's handled with a sorta generic Spawn method
solemn turret
uh i kinda came here for the hollow knight mod installler
prime urchin
I also want to say that the 'Spawned' enemies are actually already spawned in the scene, just inactive
solemn turret
can anyone provide im new to this game even tho i bought it three years ago just started playing it
tall rain
Noe
jolly oriole
native pelican
I also want to say that the 'Spawned' enemies are actually already spawned in th...
ah that's good, i put nametags on all the enemies once they're created because i use their spawn positions to uniquely identify them. that will probably make this a little easier.
thank you both for those leads. i've got some new tools to play with (fsm viewer and dnspay)
i'll see what i can find
jolly oriole
is grassbag/grassy knight quality of life or functional changes? (or misc?)
deep wave
massive qol improvement. you didn't know what grass you had cut before. you do now. i don't know how i can sell this any harder
jolly oriole
alright
native pelican
is grassbag/grassy knight quality of life or functional changes? (or misc?)
I think quality of life. Grassy Knight does not make any changes to how the game behaves, and only adds the counter (and if enabled via the settings, a compass).
jolly oriole
no dependencies anymore i guess? (for grassy knight that is, as grassbag seems to be the older version)
native pelican
Oh yes, that's correct. I might've actually forgot to remove the ModCommon dependency in that PR i made... imma go check that.
Was using ModCommon to get access to the coroutine scheduler but figured out how to do it without
jolly oriole
nah you didn't forget anything, no dependencies are in here https://github.com/itsjohncs/GrassyKnight/blob/main/GrassyKnight.csproj
then it's on the mod summaries now pog
native pelican
pog! thank you!!
empty ridge
do object pools get initialized in the menu scene?
jolly oriole
certainly possible
empty ridge
i was modifying some prefab objects and noticed that some were already instantiated
guess i'll just look there first
jolly jungle
is it alright to take code from other people's mods for things like swapping out textures of things where they probably have the simplest way of doing it?
jolly oriole
let's just say that you got inspired by those mods
native pelican
i haven't seen very many licenses in mod repos... so i guess technically no. but it also feels like folks don't really mind 🤷♀️.
native pelican
oh wild, why? is that a requirement for inclusion in the mod installer?
i put grassy knight into the public domain (essentially)
prime urchin
I mainly use MPL 2.0 or MIT personally
ornate rivet
oh wild, why? is that a requirement for inclusion in the mod installer?
pretty sure it's because they all use the modding api
ornate rivet
but I don't think anyone cares unless you try to monetize your mod or something dumb like that
native pelican
pretty sure it's because they all use the modding api
the modding api uses mit which freely allows folks to make stuff using it. so things built off of it can be licensed however.
jolly oriole
i should put gplv3 on my modding helper stuff
jolly oriole
the modding api uses mit which freely allows folks to make stuff using it. so th...
from a straight license perspective yes, but TC wouldn't allow it
and it's their IP after all
jolly oriole
monetize your mod
the gpl thing is fine, as the mapi was licensed with gplv3 until some time ago
native pelican
ah i see, that'd be interesting if someone tried to do that. i feel like i've heard of related court cases... it's been a long time since i was super into licensing though.
(court cases where someone monetized some mod-like-thing and the company behind the original thing tried to stop them)
ornate rivet
I'd like to see tc try and stop me from charging 100$ for pale court
jolly oriole
ez by just not allowing you to use the name Pale Court, as that is the name of a song from hollow knight
ornate rivet
that's ok the mod is called Five Knights anyways :)
terse owl
is there a download link for the custom skin moder
ornate rivet
native pelican
i made a new license a long time ago for something i built... not the best use of time. but was fun
woeful igloo
Huh. For those who have posted mods up: My mod is now in the mod installer, but the readme file didn't seem to be up with it. It's in the zip folder on github, not sure why it wouldn't be a part of it. Any idea why?
charred topaz
Hey, I was trying to build the Hollow Knight Modding API for the latest beta Hollow Knight, was there supposed to be a ModdingAPI.zip file that contains the patched assembly?
copper nacelle
build in release
debug doesn't zip and stuff because I hate build time
if you want it to work rn exclude the hascomponent patch
Haven't fixed it yet
charred topaz
yep, that worked. Thanks
jolly jungle
that's ok the mod is called Five Knights anyways :)
Goddamnit this feels like jojo localization
copper nacelle
copper nacelle
@jolly oriole fixed it
for anyone too lazy to build for beta
I replaced the handlers with Func/Action for a bunch of stuff so rebuild might be needed on mods
Still have some I could remove tbqh
jolly oriole
poggers, though idk what handlers were changed, so ig i'll just rebuild regardless
jolly oriole
I replaced the handlers with Func/Action for a bunch of stuff so rebuild might b...
i don't find that in the commits though, did you push that?
god fucking dammit discord edit
jolly oriole
ah ok, i thought you meant more recent
copper nacelle
nah i just noticed when i actually updated my api and all my mods exploded again
jolly oriole
lol
btw @vocal spire might be interesting for you, i think i'll integrate either the item page system you sent me or something comparable in sfcore finally for "infinite" items
vocal spire
Ok
jolly oriole
also just now realized that the custom items would completely break once people save+quit lol
jolly oriole
damn, to think that i have exactly 1 field unused when saving all aspects of the delicate flower
jolly oriole
first of 3 parts done
jolly jungle
What are you trying to do?
vocal spire
Allow infinite items in the inventory
vocal spire
Grenade made sfcore SFCore allows adding items
jolly jungle
for dnspy do I just go to releases and get the zip?
vocal spire
They bug out if you add more than the original space in the inventory
vocal spire
for dnspy do I just go to releases and get the zip?
Aren’t there a bunch of files in the releases?
jolly jungle
five of them
vocal spire
I forgot which one to get
vocal spire
Just anything that’s not source probably works
jolly jungle
Alright thanks
prime urchin
You can do a GetComponentsInChildren(true) and then filter through that but yeah, unfortunate that Find doesn't have a similar overload
jolly oriole
i simply made a recursive extension method lol
jolly jungle
Which of these do I need?
ornate rivet
dnspy
jolly jungle
And only that?
jolly oriole
i mean, the bin folder is probably required to run dnspy
jolly jungle
And the third one?
jolly oriole
if you want to dnspy using the console, then yes
jolly jungle
Does this mean that anything killable with Climber in the name will be turned into a transtrans?
Even if I make a new thing of my own which for whatever reason has climber in the name?
jolly oriole
yes
but you can make it crash if you don't have the tk2dsprite monobehaviour on the go
woeful igloo
So, uhhh... if it's okay for me to ask again? How can I get my readme to work in the mod loader? I have both the mod and the readme file inside the zip file on both github and the google link, but for some reason the mod can be downloaded just fine, but the readme isn't.
native pelican
So, uhhh... if it's okay for me to ask again? How can I get my readme to work in...
i really don't know much, but i was poking around the mod-installer's code a bit ago and saw a comment talking about limited extension support: I think your readme has to end with either .md or .txt and it might be case sensistive.
jolly jungle
wait what's jewel's readme?
woeful igloo
It does end with .txt. The job change mod.
jolly oriole
welp, now you know ig
woeful igloo
Gonna go fix that. Thanks!
There, hopefully works now.
... Huh. Still says no readme exists.
Ahhhh.
So it needs to be README, not readme.
jolly oriole
that's because the installer uses https://github.com/RechercheJewel/HK-Job-Change/files/6126538/Job.change.by.Jewel.zip for the zip, you'd have to pr the modinstaller repo https://github.com/Ayugradow/ModInstaller to make the change to the modlinks to use the new link