#archived-modding-development | Hollow Knight | Page 503

vocal spire Feb 22, 2021, 10:29 PM

#

?

warm mirage Feb 22, 2021, 10:30 PM

#

I found a collision bug just above the hive (and sorry I'm using google translate)

vocal spire Feb 22, 2021, 10:30 PM

#

ok

#

I don't think this is the right place

warm mirage Feb 22, 2021, 10:33 PM

#

sorry i didn't know how to report it to the devlopper and i thought there might be one in this channel

vocal spire Feb 22, 2021, 10:34 PM

#

there is information on what to do in #hk-announcements

copper nacelle Feb 22, 2021, 10:35 PM

#

need to ref the mscorlib in the vanilla folder

#

What'd you change btw

vocal spire Feb 22, 2021, 10:36 PM

#

I thought he changed stuff in json.net

jolly oriole Feb 22, 2021, 10:39 PM

#

copper nacelle need to ref the mscorlib in the vanilla folder

did, now works

jolly oriole Feb 22, 2021, 10:39 PM

#

copper nacelle What'd you change btw

custom json.net and added charmiconlist method that monomod yeeted

#

failed to load pog

dark wigeon Feb 22, 2021, 10:40 PM

#

assetstools.net already runs on this

#

I was already talking to the guy running it

copper nacelle Feb 22, 2021, 10:40 PM

#

is the custom json.net just the dynamic method meme

jolly oriole Feb 22, 2021, 10:40 PM

#

[ERROR]:[API] - Error: System.NullReferenceException
[ERROR]:[API] -   at (wrapper managed-to-native) UnityEngine.Object.DontDestroyOnLoad(UnityEngine.Object)

jolly oriole Feb 22, 2021, 10:40 PM

#

copper nacelle is the custom json.net just the dynamic method meme

yes

vocal spire Feb 22, 2021, 10:41 PM

#

tot spoilers

dark wigeon Feb 22, 2021, 10:41 PM

#

anyway the real issue is hkworldedit

#

unity editor apparently can't read packed atlases or something

vocal spire Feb 22, 2021, 10:41 PM

#

F

dark wigeon Feb 22, 2021, 10:41 PM

#

and crashes if you select tk2d sprites

copper nacelle Feb 22, 2021, 10:41 PM

#

the monomod thing seems like it'd be fucked

dark wigeon Feb 22, 2021, 10:42 PM

#

everything else worked seamlessly though lol

vocal spire Feb 22, 2021, 10:42 PM

#

~~are we switching to bepinex?~~

jolly oriole Feb 22, 2021, 10:43 PM

#

i also know why tot crashes, 2017.4.10 assetbundle

vocal spire Feb 22, 2021, 10:43 PM

#

lol

#

modding api working sort of well pog

dark wigeon Feb 22, 2021, 10:44 PM

#

like we already have 2020.2 now running all my tools, but that's because I read fields by string, not by actual fields

#

utinyripper is going to be much more difficult since everything is manually named

#

not very easy to upgrade like assetstools' are

vocal spire Feb 22, 2021, 10:45 PM

#

~~rewriting the entire utiny ripper time?~~

jolly oriole Feb 22, 2021, 10:45 PM

#

and the modding api is also currently only sort of working, because i don't know if/what other methods have the 0 rva

dark wigeon Feb 22, 2021, 10:45 PM

#

well you wouldn't rewrite everything

#

at most you would entirely replace the class reading and leave everything else as is

jolly oriole Feb 22, 2021, 10:55 PM

#

i'll take this as working

copper nacelle Feb 22, 2021, 10:56 PM

#

you just patched the method in dnspy yeah?

#

did the dnail thing get fixed

jolly oriole Feb 22, 2021, 10:57 PM

#

i changed nothing in dnspy, the charmicon thing i made in the api, is pushed on the repo

#

but i can still dnail midair

#

just tested

#

gives me a lengthy error message

#

another 0 rva thing

copper nacelle Feb 22, 2021, 10:58 PM

#

Suffering

#

I'll just ask jade

#

Patching in the methods which disintegrate doesn't seem like the move

jolly oriole Feb 22, 2021, 10:59 PM

#

true

#

even though i have no idea who jade is, but true

copper nacelle Feb 22, 2021, 10:59 PM

#

Oh

#

It doesn't do that

#

It kills the method

#

Violently

#

That's why my game doesn't boot

jolly oriole Feb 22, 2021, 11:00 PM

#

damn

copper nacelle Feb 22, 2021, 11:01 PM

#

Yeah some of the branches go to null

#

I'll take a closer look whenever I finish my homework

vocal spire Feb 22, 2021, 11:09 PM

#

copper nacelle It kills the method

f

#

how did that happen

native pelican Feb 22, 2021, 11:49 PM

#

SlashHitHook in the modding api tells you what your slash is colliding with. Since c-dash can destroy grass, and so can spells, I want to trigger whenever any kind of hit happens. I'm trying tro figure out how to get the target from HitInstanceHook, but can't.

#

Is that possible?

leaden hedge Feb 23, 2021, 12:00 AM

#

yes

#

56 should still have the code somewhere for fixing cdash

native pelican Feb 23, 2021, 12:01 AM

#

What's 56? (I am very new to modding, sorry if this is an obvious question)

unborn flicker Feb 23, 2021, 12:01 AM

#

You can also hook Grass.Hit and related methods specific to grass components

native pelican Feb 23, 2021, 12:03 AM

#

unborn flicker You can also hook Grass.Hit and related methods specific to grass components

That'd be fine, my code already finds all the grass in the room when the room loads. Would that involve using dnspy/editing-the-binaries though? The Grass class doesn't have a Hit field according to my intellisense, but I might just be missing a reference.

unborn flicker Feb 23, 2021, 12:04 AM

#

On.Grass.Hit, On.GrassCut.OnTriggerEnter2D, possibly a few others depending on how consistent the game is.

#

The On namespace contains hooks for almost every method in the assembly, public or private

native pelican Feb 23, 2021, 12:05 AM

#

Holy wow, that is an extremely useful tip. Thank you so much.

#

Can't imagine some combination of these triggers will be insufficient, I'll smash at it now and see what I need to listen to to catch all the grass destruction 🙂

dark wigeon Feb 23, 2021, 12:29 AM

#

Did you find the exact version they use for uitoolkit then?

vocal spire Feb 23, 2021, 12:32 AM

#

native pelican What's 56? (I am very new to modding, sorry if this is an obvious question)

56 is "hk", they just changed their nickname to that

native pelican Feb 23, 2021, 12:34 AM

#

Thank you!

copper nacelle Feb 23, 2021, 12:39 AM

#

did you try dmcaing them

dark wigeon Feb 23, 2021, 12:54 AM

#

I was thinking you could just download different preview versions until you find a dll with a hash that matches or sometihng

#

yes you can check what shaders are in a game, but you can't really make the shader code readable

marble hollow Feb 23, 2021, 12:55 AM

#

hey nesquack i have a question

dark wigeon Feb 23, 2021, 12:56 AM

#

ok

marble hollow Feb 23, 2021, 12:57 AM

#

so in supersprite extractor thing u made, whenever i try to edit the skins, the new skins just overlaps the og one. is it possible to get rid of the og skin layer instead of overlapping it?

dark wigeon Feb 23, 2021, 12:59 AM

#

you can for a particular file, but there's shaders in lots of different files
I can just make a script real quick to dump all shader names

dark wigeon Feb 23, 2021, 1:00 AM

#

marble hollow so in supersprite extractor thing u made, whenever i try to edit the skins, the ...

what do you mean by this? when you edit, all sprites are put on an empty image and grabbed from the folder, nothing comes from the original spritesheet.
so if there's any sprites you don't want just delete the files

marble hollow Feb 23, 2021, 1:01 AM

#

dark wigeon what do you mean by this? when you edit, all sprites are put on an empty image a...

odd. i might be using an older version?

dark wigeon Feb 23, 2021, 1:01 AM

#

I think it's been the same way the whole time

#

like are you saying when you edit a sprite, it puts the old sprite under the new sprite?

marble hollow Feb 23, 2021, 1:02 AM

#

yeah but it only happens when i edit a specific collection instead of all

dark wigeon Feb 23, 2021, 1:02 AM

#

ok I'll check in a bit

#

📎 message.txt

#

oh that repo has all versions

#

is it something that someone manually does or is it automated

#

so when you install the package it just replaces stock UIElementsModule with the new one from the preview package?

#

I just built stock 2020.2.2f1 and the assemblies were almost identical

#

i.e. no preview package

#

right, I thought you said they did have a version of uitoolkit, my bad

#

so it should just work replacing all the dlls from a uitoolkit build but it isn't?

#

all asset data/bundles get scripts by dll filename so if the dll is there it shouldn't have problems

#

are those classes in the UIElementsModule dll for sure?

#

or whatever dll you copied

#

so you did or didn't copy them when this error happened

#

I know there's an internal list of dlls in the game files but I don't think it's usually ever used

dark wigeon Feb 23, 2021, 2:20 AM

#

guess you'll have to build the shaders into a bundle

#

I scanned all shader assets and printed their names

#

in globalgamemanagers/.assets, level, resources.assets and sharedassets files

#

you posted this earlier https://github.com/needle-mirror/com.unity.ui/tree/master/Shaders

GitHub

needle-mirror/com.unity.ui

[Mirrored from UPM, without any changes. Maintained by Needle. Not affiliated with Unity Technologies.] 📦 UI Toolkit is a set of features, resources and tools for developing user interfaces (UI). U...

#

so just put those in a project and build the bundle, then load it and it should find the shaders

#

in globalgamemanagers
in globalgamemanagers.assets
in resources.assets
Text/Sprite
in level0
in sharedassets0.assets
Skybox/Procedural
Hidden/UIE-Runtime
Text/Mobile/Distance Field SSD
Hidden/UIE-AtlasBlit
Hidden/UIE-RuntimeWorld

#

looks like maybe bundles got updated

#

assetstudio says 5 assets failed to load

#

let me update and see if they're there

#

yeah it always does that

#

yes those shaders are in there

#

idk, you would have to go find how they're referenced

#

ok Shader.Find

#

this file concerns me though https://github.com/needle-mirror/com.unity.ui/blob/master/Core/Renderer/UIRShaders.cs

GitHub

needle-mirror/com.unity.ui

[Mirrored from UPM, without any changes. Maintained by Needle. Not affiliated with Unity Technologies.] 📦 UI Toolkit is a set of features, resources and tools for developing user interfaces (UI). U...

#

it might be trying to read from a different name because the package isn't "loaded"

#

I have no idea

#

For Reference: Shader.Find API does not work with shaders loaded from AssetBundles.
don't know how outdated that is but if still true then oof

#

well you have two bad options
a. patch the game files to add your shader to the listing
b. change uitoolkit's code to read from a bundle instead

#

c. ask the devs to add uitoolkit lol

#

the easiest would be a but it would break every time the game updated
b would be much harder and would break every time uitoolkit updated
c is super easy but lol

#

big brain just include the asset patcher in the mod

#

actually hek what am I saying just runtime patch it

#

load an asset bundle and load it from there

#

wdym too slow

#

what is a mono patch

#

I don't think harmony is all that slow, even then shader loading happens on the native side

#

Yeah harmony still isn't that slow, especially when it's not in a loop or anything

#

But whatever use what works

#

they are on assets/ui toolkit/panelsettings.asset, but the names of the shaders are the same as I posted earlier

#

there's no other path on it

#

ok that works too ig

#

ofc

#

it's assetbundle.loadasset

#

can you not grab the panelsettings asset

#

then get the shader refs from there

#

this is the same bundle you sent me?

#

I'll look later

#

You should be able to load it

dark wigeon Feb 23, 2021, 6:00 AM

#

@marble hollow https://github.com/nesrak1/sseadv/releases/

marble hollow Feb 23, 2021, 6:00 AM

#

oo

dark wigeon Feb 23, 2021, 6:01 AM

#

all the code was there I just forgot to enable a flag

midnight narwhal Feb 23, 2021, 6:31 AM

#

does the line in the docs GameObject aspid = Instantiate(Aspid.preloadedGO["Aspid"]); require a reference? because otherwise Aspid doesnt exist.

#

or a using statement that visual studio doesnt suggest?

leaden hedge Feb 23, 2021, 6:44 AM

#

aspid is a static class someone else made

midnight narwhal Feb 23, 2021, 6:46 AM

#

then why is it in the docs

#

zoteanger

leaden hedge Feb 23, 2021, 6:47 AM

#

because thats not really a relevant part of the code

#

there was probably a section prior that explained how to preload

midnight narwhal Feb 23, 2021, 6:47 AM

#

i mean isnt it all relevant

leaden hedge Feb 23, 2021, 6:47 AM

#

no

#

class names aren't really relevant

#

where even is it on the docs

#

oh i see

#

https://radiance.host/apidocs/ModdingAPI.html#preload-gameobjects

#

this explains how preloaded objects work

midnight narwhal Feb 23, 2021, 6:54 AM

#

where would i find the paths to the gameobjects?

leaden hedge Feb 23, 2021, 6:56 AM

#

scene dumps

midnight narwhal Feb 23, 2021, 6:57 AM

#

k

midnight narwhal Feb 23, 2021, 7:22 AM

#

so if i were trying to access a gruzzer, would it be

public override List<(string, string)> GetPreloadNames()
        {
            return new List<(string, string)>
            {
                ("Crossroads_07", "Uninfected Parent/Fly 1")
            };
        }

or

public override List<(string, string)> GetPreloadNames()
        {
            return new List<(string, string)>
            {
                ("Crossroads_07", "Crossroads_07/Uninfected Parent/Fly 1")
            };
        }

im getting this information from the scenes.rar file that is pinned, in Crossroads_07.txt

Uninfected Parent\Fly 1
                   \--Component: Transform
                   \--GameObject layer: 11
                   \--GameObject tag: Untagged
                   \--More garbage...

rain cedar Feb 23, 2021, 7:30 AM

#

The former

native pelican Feb 23, 2021, 7:33 AM

#

What do the various fields in RectData mean? I don't usually think of a rect having a min or max.

jolly oriole Feb 23, 2021, 7:34 AM

#

are they fields or are they get properties?

#

i have no idea what RectData is, but for Rects, the various properties also change other stuff: https://docs.unity3d.com/ScriptReference/Rect.html

native pelican Feb 23, 2021, 7:37 AM

#

@jolly oriole it's part of the modding API. Here's the definition: https://github.com/seresharp/HollowKnight.Modding/blob/069d7359f624a7ddf99b5c1cd0f7761b4149665c/Assembly-CSharp/CanvasUtil.cs#L529

GitHub

seresharp/HollowKnight.Modding

Contribute to seresharp/HollowKnight.Modding development by creating an account on GitHub.

rain cedar Feb 23, 2021, 7:42 AM

#

Min/max are two opposite corners of the rectangle

native pelican Feb 23, 2021, 7:44 AM

#

Oh I see, minimum position of the two positions defining the rectangle, and maximum position.

#

Thank you!

leaden hedge Feb 23, 2021, 7:56 AM

#

rect and rectdata are the same thing

#

rectdata is just boilerplate for making rects without needing to make it line by line

leaden hedge Feb 23, 2021, 8:50 AM

#

isnt ui toolkit like miles behind in features compared to canvas

nimble lake Feb 23, 2021, 11:20 AM

#

:modders:

jolly jungle Feb 23, 2021, 11:46 AM

#

excuse me what

jolly oriole Feb 23, 2021, 12:19 PM

#

:modders:

fair rampart Feb 23, 2021, 2:21 PM

#

guys

#

some help

#

how do i fix this

deep wave Feb 23, 2021, 2:27 PM

#

base..ctor(); is supposed to call the constructor for the base class, but iirc dnspy has a panic attack when it sees it, as it reads it as another method
an alternative is to do public BossSequence() : base(), which shouldn't be flagged by dnspy

copper nacelle Feb 23, 2021, 2:28 PM

#

just get rid of it

#

it's that easy

jolly oriole Feb 23, 2021, 3:24 PM

#

I think i know why my 1.5 api doesnt quite work correctly

#

Can only test in like an hour though

copper nacelle Feb 23, 2021, 3:26 PM

#

i know exactly why it doesn't work correctly

jolly oriole Feb 23, 2021, 3:29 PM

#

32 bit or something else?

copper nacelle Feb 23, 2021, 3:30 PM

#

null br

stone elm Feb 23, 2021, 3:30 PM

#

deep wave `base..ctor();` is supposed to call the constructor for the base class, but iirc...

The alternative you offered is likely what it was before compilation and decompilation. Decompilers don't always understand constructor calls, especially since they're actually called .ctor after compiling.

deep wave Feb 23, 2021, 3:30 PM

#

afaik : base() is also implied

jolly oriole Feb 23, 2021, 3:30 PM

#

copper nacelle null br

Idk what that is short for, but doesn't sound too ez to fix

deep wave Feb 23, 2021, 3:31 PM

#

(or as far as i googled because i'm still new to c# feelspkman )

copper nacelle Feb 23, 2021, 3:31 PM

#

brfalse.s leads to a null which causes ilmerge to kill the method (extern) leading to zero rva

#

or if you don't ilmerge it just crashes immediately

#

feelsokayman

#

ilrepack throwing on a null is incredibly reasonable knowing this information

stone elm Feb 23, 2021, 3:32 PM

#

deep wave afaik `: base()` is also implied

Yes, I think we're saying the same thing anyway, haha.

jolly oriole Feb 23, 2021, 3:34 PM

#

copper nacelle ilrepack throwing on a null is incredibly reasonable knowing this information

But is it fixable?

copper nacelle Feb 23, 2021, 3:34 PM

#

i mean if you fix the br null then yeah

#

i am still of the opinion that this is the optimal opportunity to not have a 20mb assembly

#

but the br has to be fixed either way

jolly oriole Feb 23, 2021, 3:36 PM

#

Ill research that once i'm at my pc

copper nacelle Feb 23, 2021, 3:36 PM

#

it's from the prepatcher

jolly oriole Feb 23, 2021, 3:37 PM

#

Ill research that once i'm at my pc

copper nacelle Feb 23, 2021, 3:37 PM

#

Ill research that once i'm at my pc

#

ornate rivet Feb 23, 2021, 3:40 PM

#

pogtamer

copper nacelle Feb 23, 2021, 3:41 PM

#

pogtamer immensely disturbs me

ornate rivet Feb 23, 2021, 3:41 PM

#

agreed

copper nacelle Feb 23, 2021, 3:55 PM

#

oh i might've gotten it maybe

#

gaming

limber storm Feb 23, 2021, 4:03 PM

#

Am I reading this correctly that if hasXunFlower is true and givenEmilitiaFlower is false, then the FSM tries to call "FLOWER" which... doesn't exist?

copper nacelle Feb 23, 2021, 4:05 PM

#

yeah

ornate rivet Feb 23, 2021, 4:05 PM

#

:)

limber storm Feb 23, 2021, 4:05 PM

#

I wonder how often that happens... 😦

jolly oriole Feb 23, 2021, 4:17 PM

#

limber storm Am I reading this correctly that if `hasXunFlower` is true *and* `givenEmilitiaF...

Ive never seen such an advanced pm action

copper nacelle Feb 23, 2021, 4:18 PM

#

suicide

#

I did it

#

Immensely painful

#

ornate rivet Feb 23, 2021, 4:20 PM

#

epicccccc

#

dnail works?

copper nacelle Feb 23, 2021, 4:21 PM

#

Yeah

ornate rivet Feb 23, 2021, 4:21 PM

#

very nice

#

still not updating pale court though

copper nacelle Feb 23, 2021, 4:22 PM

#

you will once every other mod updates with it being a breaking change

#

🙂

jolly oriole Feb 23, 2021, 4:24 PM

#

is that a "ported" mapi or a new one?

copper nacelle Feb 23, 2021, 4:24 PM

#

ported

jolly oriole Feb 23, 2021, 4:25 PM

#

pog, but ig it would really be good to check what can be trimmed from the api

copper nacelle Feb 23, 2021, 4:25 PM

#

i am going to abuse this optimal opportunity

jolly oriole Feb 23, 2021, 4:25 PM

#

i mean, people do need to compile mods again thanks to .net 4

copper nacelle Feb 23, 2021, 4:25 PM

#

don't you worry

jolly oriole Feb 23, 2021, 4:25 PM

#

mapi 2.0 pog

#

or well, 1.5

copper nacelle Feb 23, 2021, 4:26 PM

#

suffering

jolly oriole Feb 23, 2021, 4:26 PM

#

lmk if i can help

copper nacelle Feb 23, 2021, 4:26 PM

#

you committed the new json.net yeah?

jolly oriole Feb 23, 2021, 4:27 PM

#

should

copper nacelle Feb 23, 2021, 4:27 PM

#

cool

jolly oriole Feb 23, 2021, 4:27 PM

#

let me check

#

though it might be netstandard 2 build instead of .net4

copper nacelle Feb 23, 2021, 4:27 PM

#

doesn't matter

jolly oriole Feb 23, 2021, 4:28 PM

#

yep, is pushed

copper nacelle Feb 23, 2021, 4:28 PM

#

alright

#

i'm going to commit onto the repo which has the loading actually fixed fwiw

jolly oriole Feb 23, 2021, 4:29 PM

#

if you mean https://github.com/SFGrenade/TemporaryHkBetaModdingApi, i can add you as collaborator, or do you mean on the main mapi repo?

copper nacelle Feb 23, 2021, 4:29 PM

#

my branch

#

where it has the not double-loading

jolly oriole Feb 23, 2021, 4:30 PM

#

ah ok

#

btw, i did send the dm, so on release we might be able to use normal json.net

copper nacelle Feb 23, 2021, 4:39 PM

#

maybe

#

it'd make the reflection much easier ngl

fair rampart Feb 23, 2021, 5:23 PM

#

guys

#

how do i change the dialog

#

or find it in dnspy

vocal spire Feb 23, 2021, 5:26 PM

#

fair rampart how do i change the dialog

The files for it aren’t in dnspy, but I guess you can change it. Better to do it with a mod though

fair rampart Feb 23, 2021, 5:41 PM

#

how?

vocal spire Feb 23, 2021, 5:48 PM

#

Look at how other mods change the text

fair rampart Feb 23, 2021, 5:48 PM

#

where

vocal spire Feb 23, 2021, 5:48 PM

#

GitHub

#

Also you should probably actually make a mod since with how many screenshots you posted, you seem to be doing a lot

fair rampart Feb 23, 2021, 5:49 PM

#

thx

#

i will try

#

now

#

i download a mod like eldergod

#

then i open it in visual studio?

vocal spire Feb 23, 2021, 5:50 PM

#

No...

#

Follow what the apidocs say on it

fair rampart Feb 23, 2021, 5:50 PM

#

ok?

vocal spire Feb 23, 2021, 5:51 PM

#

You don’t really open dll files

deep wave Feb 23, 2021, 5:56 PM

#

just search for the name of the mod on github, most if not all of us upload source code

fair rampart Feb 23, 2021, 6:09 PM

#

i tried saerching hollo knight but i get this

jolly oriole Feb 23, 2021, 6:09 PM

#

try just searching hollow knight and click the c# text under languages to the left

fair rampart Feb 23, 2021, 6:09 PM

#

thx

#

i didnt really get anymods that have dialog

#

i dont see the modding api

copper nacelle Feb 23, 2021, 6:20 PM

#

have you tried scrolling down

#

if you have debug installed the api is installed anyways

fair rampart Feb 23, 2021, 6:22 PM

#

bullsh8

copper nacelle Feb 23, 2021, 6:22 PM

#

me when 1.4.2.4

#

have you tried buying the gaming

fair rampart Feb 23, 2021, 6:22 PM

#

yea

#

no worrys found it

#

it didnt work

copper nacelle Feb 23, 2021, 6:31 PM

#

Shocking

deep wave Feb 23, 2021, 6:40 PM

#

generally would recommend buying the game before trying to use the large amount of free content the community provides to people who paid for the game

copper nacelle Feb 23, 2021, 6:43 PM

#

yo

jolly oriole Feb 23, 2021, 6:45 PM

#

pog

copper nacelle Feb 23, 2021, 6:46 PM

#

got actual debug info working

#

should've done this a long time ago

#

still very happy

jolly oriole Feb 23, 2021, 6:47 PM

#

is that for 1432 or 1.5?

copper nacelle Feb 23, 2021, 6:47 PM

#

1.5

#

can do either though

jolly oriole Feb 23, 2021, 6:47 PM

#

neat

copper nacelle Feb 23, 2021, 7:08 PM

#

gaming

#

this is w/out merges too

#

so the assembly is actually usable in dnspy

#

very convenient

jolly oriole Feb 23, 2021, 7:21 PM

#

did you just add the other dlls in the managed folder or how are those referenced?

copper nacelle Feb 23, 2021, 7:21 PM

#

managed

jolly oriole Feb 23, 2021, 7:22 PM

#

pog

copper nacelle Feb 23, 2021, 7:23 PM

#

Do you have System.Runtime.Serialization in your Managed folder?

#

idk if i put that there or they actually have it now

jolly oriole Feb 23, 2021, 7:23 PM

#

was already there

copper nacelle Feb 23, 2021, 7:24 PM

#

yoo

#

nice

jolly oriole Feb 23, 2021, 7:24 PM

#

which is why i also removed it from the ilmerge thing

copper nacelle Feb 23, 2021, 7:26 PM

#

makes sense

jolly jungle Feb 23, 2021, 8:42 PM

#

I have a problem I'm stumped on

#

I basically want Hive Knight to have different DNail dialogue when stunned

#

So, this is my related code

#

In Awake()

#

In my LanguageGet()

#

And in Start()

#

For some reason, it seems to only work the first time I DNail him while staggered; every time after that without quitting the game displays the three normal dialogues

#

Any ideas?

jolly oriole Feb 23, 2021, 8:46 PM

#

let me quickly rename steam things to 1432

vocal spire Feb 23, 2021, 8:48 PM

#

@jolly jungle have you tried logging what the key is?

jolly oriole Feb 23, 2021, 8:49 PM

#

you could try adding both times to the control fsm, with the stun recover staying the same, but change the stun to the Stun Start state of _control

jolly jungle Feb 23, 2021, 8:50 PM

#

vocal spire <@!427473606725861397> have you tried logging what the key is?

doing some logs now

jolly jungle Feb 23, 2021, 8:50 PM

#

jolly oriole you could try adding both times to the control fsm, with the stun recover stayin...

yeah, I thought of trying that next

#

thanks hollowknice

jolly jungle Feb 23, 2021, 9:42 PM

#

Alright

#

So, uh

#

Kinda funny

#

Basically, I didn't clean up well after me

#

And every time the fight ends, the script lingers around, I guess

#

And that resulted in this

copper nacelle Feb 23, 2021, 9:46 PM

#

Oh yeah that happens

#

Make an OnDestroy and unhook

jolly jungle Feb 23, 2021, 9:46 PM

#

Ah, thanks

#

Should work?

copper nacelle Feb 23, 2021, 9:50 PM

#

yeah

jolly jungle Feb 23, 2021, 9:54 PM

#

Woo, it worked

#

Thanks :D

solar hare Feb 23, 2021, 10:05 PM

#

so does this update mean we get to use a version of C# that isn't from the dark ages?

native pelican Feb 23, 2021, 10:08 PM

#

What do ya'll usually do to share the mods you make? I have one in some reasonable state of done-ness that I think would be fun to share

copper nacelle Feb 23, 2021, 10:08 PM

#

there's a Google drive folder and an xml you pr

#

and you could already use c# 9

solar hare Feb 23, 2021, 10:09 PM

#

oh? how does that work, when 2017 runs .net 3.5

stone elm Feb 23, 2021, 10:09 PM

#

I imagine they probably meant .NET version. 3.5 is a doozy

solar hare Feb 23, 2021, 10:10 PM

#

also yeah, i would like the api features, not just the syntax

native pelican Feb 23, 2021, 10:10 PM

#

I think I found the GDrive folder (https://drive.google.com/drive/folders/0B_b9PFqx_PR9Um9MeFZMV21oWGs) but I didn't see any mention of how to add things to it

solar hare Feb 23, 2021, 10:10 PM

#

but i'm still curious about the c# 9 thing

native pelican Feb 23, 2021, 10:10 PM

#

copper nacelle there's a Google drive folder and an xml you pr

Do you mean there's an XML file on GitHub I should open up a pull request for?

prime urchin Feb 23, 2021, 10:11 PM

#

If you put <LangVersion>9</LangVersion> in your .csproj file you can use a lot of C#9 features

copper nacelle Feb 23, 2021, 10:11 PM

#

ye

prime urchin Feb 23, 2021, 10:11 PM

#

any C#9 features that don't require runtime changes

copper nacelle Feb 23, 2021, 10:11 PM

#

But we have .net 4 now

#

and before we had backported tuples

prime urchin Feb 23, 2021, 10:11 PM

#

4.0 will be a relief hah

copper nacelle Feb 23, 2021, 10:11 PM

#

native pelican Do you mean there's an XML file on GitHub I should open up a pull request for?

yeah it's on ayugradow/modinstaller

#

yeah definitely

native pelican Feb 23, 2021, 10:12 PM

#

Ty!

solar hare Feb 23, 2021, 10:12 PM

#

yeah

copper nacelle Feb 23, 2021, 10:13 PM

#

and as far as the gdrive goes you just ask and someone puts it in or can add you

jolly oriole Feb 23, 2021, 10:13 PM

#

or you do the sfgrenade and pr another link with your mod hosted somewhere else (e.g. github)

#

or also some other mods too big for gdrive

copper nacelle Feb 23, 2021, 10:14 PM

#

yeah

#

angle self hosts

#

it's just for the sake of having them together

#

Which was more of a big deal when there wasn't an installer

native pelican Feb 23, 2021, 10:15 PM

#

I just asked for permission to edit the GDrive (I think)... I used the "ask owner to share" feature, which I've never even seen before

#

Oh, maybe that's easier, it's already on github

jolly oriole Feb 23, 2021, 10:18 PM

#

btw 56, chance you send me the 1.5 mapi you made to port mods or do you want to refactor more first?

copper nacelle Feb 23, 2021, 10:18 PM

#

I could send it but I do plan on killing more stuff

jolly oriole Feb 23, 2021, 10:19 PM

#

then have fun :D

copper nacelle Feb 23, 2021, 10:19 PM

#

like the generic mod

#

It's been like a year

jolly oriole Feb 23, 2021, 10:19 PM

#

oh god oh fuck

#

time to change all my mods to the non generic version

prime urchin Feb 23, 2021, 10:21 PM

#

iirc the generic version was for specifying settings types, right?

copper nacelle Feb 23, 2021, 10:21 PM

#

Yeah

#

You just override some properties

prime urchin Feb 23, 2021, 10:21 PM

#

was there any benefit other than not having to cast the setter value?

copper nacelle Feb 23, 2021, 10:21 PM

#

no

jolly oriole Feb 23, 2021, 10:23 PM

#

can type getfields detect fields from derived types if given the specific instance?

copper nacelle Feb 23, 2021, 10:24 PM

#

if you have like base obj = derived

#

obj.GetType() will give you the type for derived

jolly oriole Feb 23, 2021, 10:25 PM

#

poggers, gonna use that for reflection based save setting field detection

copper nacelle Feb 23, 2021, 10:25 PM

#

I think you might be able to use covariant return types for the property now too

#

Which makes it even more pointless

jolly oriole Feb 23, 2021, 10:26 PM

#

although i'm currently thinking for 1432, as 1.5 is still beta

prime urchin Feb 23, 2021, 10:26 PM

#

I want to say that covariant return types don't work for properties but maybe I did it wrong last time I tried

copper nacelle Feb 23, 2021, 10:26 PM

#

it doesn't

#

ruined

#

i wait for the day where i can make it { get; set }

prime urchin Feb 23, 2021, 10:27 PM

#

it's strange that it's not allowed

copper nacelle Feb 23, 2021, 10:27 PM

#

i assume it's because of the set

#

yeah it says it works on read-only properties

prime urchin Feb 23, 2021, 10:28 PM

#

ah

#

okay, that does make sense

jolly oriole Feb 23, 2021, 10:29 PM

#

wait a sec, i can just use _saveSettings

#

watch me add an abstract generic mod derived class to not worry about generic mods lol

copper nacelle Feb 23, 2021, 10:38 PM

#

x5fiftPrime

copper nacelle Feb 23, 2021, 11:15 PM

#

@jolly oriole what

jolly oriole Feb 23, 2021, 11:16 PM

#

about the comment, the replace, the enum name or what?

vocal spire Feb 23, 2021, 11:16 PM

#

Hello

#

🤔

copper nacelle Feb 23, 2021, 11:17 PM

#

all of the above

jolly oriole Feb 23, 2021, 11:17 PM

#

the comment: not made by me
the replace: never worked with mono before, seemed fitting
the enum name: copied from vanilla

copper nacelle Feb 23, 2021, 11:17 PM

#

i mean

#

why patch it at all

jolly oriole Feb 23, 2021, 11:18 PM

#

to make LanguageSupport possible, as it's otherwise a real spaghetti conversion between different enums & ints

copper nacelle Feb 23, 2021, 11:19 PM

#

ok

#

is it just for the one mod

#

in the api

#

x5fiftPrime

jolly oriole Feb 23, 2021, 11:20 PM

#

yes

copper nacelle Feb 23, 2021, 11:20 PM

#

bro

#

the api is so bloated

#

suffering

ornate rivet Feb 23, 2021, 11:23 PM

#

just remove the fat and it will work

copper nacelle Feb 23, 2021, 11:24 PM

#

I might just pr languagesupport at this rate

#

so i can kill more

jolly oriole Feb 23, 2021, 11:26 PM

#

let it lie on ice for a while, language is fucked in the game

#

but if you want insight:
MenuLanguageSetting.RefreshAvailableLanguages() gets either TestingLanguages[] or SupportedLanguages[] and casts to SupportedLanguages[] (not too bad, as those are duplicates of each other).
an entry gets cast into LanguageCode in MenuLanguageSetting.UpdateLanguageSetting() to switch language (so no custom thing possible as entry "34" (string) is not equal to whatever is in LanguageCode)
this gets converted to string in Language.SwitchLanguage(LanguageCode code) to check of the language is available

#

hm apparently it should work according to ms docs

copper nacelle Feb 23, 2021, 11:29 PM

#

you can cast int to enum even if there's no member

jolly oriole Feb 23, 2021, 11:30 PM

#

but not the string representation of that int

#

and apparently it's not in .net 4

#

i have to write my own thing sadge

#

can't be worse than changing json.net

copper nacelle Feb 23, 2021, 11:30 PM

#

🥴

jolly oriole Feb 23, 2021, 11:31 PM

#

probs just a function that tryparses the string to int then to languagecode, but i'll see

copper nacelle Feb 23, 2021, 11:32 PM

#

Enum.TryParse?

jolly oriole Feb 23, 2021, 11:32 PM

#

doesn't parse the string "34" to the numerical enum value 34

#

or: only does so in .net 5 and netstandard 2.1

#

https://docs.microsoft.com/en-us/dotnet/api/system.enum.parse?view=net-5.0

copper nacelle Feb 23, 2021, 11:34 PM

#

Oh you mean it'll throw

#

hook it

jolly oriole Feb 23, 2021, 11:34 PM

#

hm, tryparse apparently works in .net 4

#

for whatever reason it's different in features from parse

#

so ig you can throw the language enums out

copper nacelle Feb 23, 2021, 11:36 PM

#

:frogchamp:

jolly oriole Feb 23, 2021, 11:37 PM

#

though please not in the 1432 version

copper nacelle Feb 23, 2021, 11:37 PM

#

i ain't touching 1432

jolly oriole Feb 23, 2021, 11:37 PM

#

froggers

#

wait a sec, i could technically send tc the changes to the language thing, so it maybe doesn't have to be changed in a mod or something lol

#

but nah, tc wouldn't use that, is it literally only benefits modders and maybe even sacrifices a bit performance

copper nacelle Feb 23, 2021, 11:55 PM

#

istg

#

if this

prime urchin Feb 24, 2021, 12:15 AM

#

gotta say, doing Unity UI through code when I didn't fully understand Unity UI was a bad idea lul

#

taking an existing game UI and modifying it like that, even more so

#

but it's done, thank god

copper nacelle Feb 24, 2021, 12:58 AM

#

prime urchin Feb 24, 2021, 1:01 AM

#

good ol' refactoring

copper nacelle Feb 24, 2021, 1:01 AM

#

the power of breaking changes

#

no more obsolete

ornate rivet Feb 24, 2021, 1:01 AM

#

you can do breaking changes as much as you want so long as it doesnt break my mods

copper nacelle Feb 24, 2021, 1:02 AM

#

if your mods aren't doing terrible things they will be okish

ornate rivet Feb 24, 2021, 1:02 AM

#

good thing I'm not smart enough to do terrible things

copper nacelle Feb 24, 2021, 1:02 AM

#

i mean Mod<A, B> is pretty easy

#

or SerializableDictionary

#

or BoolValues, IntValues, etc

ornate rivet Feb 24, 2021, 1:03 AM

#

magic words

copper nacelle Feb 24, 2021, 1:03 AM

#

uh huh

prime urchin Feb 24, 2021, 1:15 AM

#

yeah, if ya got the opportunity to take breaking changes you might as well go all the way with 'em lul

tawny onyx Feb 24, 2021, 3:16 AM

#

beta version update again?(about 11 MB)

#

what's the changes

#

ok i found it on announcements

#

nvm

blazing mica Feb 24, 2021, 6:11 AM

#

wheres the point mod

#

?

jolly oriole Feb 24, 2021, 6:40 AM

#

There are a lot of points in hk

deep wave Feb 24, 2021, 6:42 AM

#

you can find a map of most of the points here https://scripterswar.com/hollowknight/map-sketch

Hollow Knight Interactive Map - Godmaster

Interactive map for the game Hollow Knight. Includes Godmaster DLC.

jolly oriole Feb 24, 2021, 9:59 AM

#

i mean, unity is partially written in c++, so i guess transforms weren't difficult to debug, as they're used pretty much everywhere

jolly oriole Feb 24, 2021, 12:29 PM

#

can't wait for the 1.5 patch to release while we have no api ready and people flocking in #archived-modding-help to ask why mods aren't working

jolly jungle Feb 24, 2021, 12:48 PM

#

Can't we start working on it now?

jolly oriole Feb 24, 2021, 12:49 PM

#

who says that the final version is the same as the current betas?

jolly jungle Feb 24, 2021, 12:49 PM

#

Ah, I guess

#

Hm

#

How fast can it be fixed once it's released?

#

Also, what will this mean for my own mods

jolly oriole Feb 24, 2021, 12:50 PM

#

at best: it's very similar, that only small changes are needed to what 56 already has
at worst: it's entirely different

jolly oriole Feb 24, 2021, 12:51 PM

#

jolly jungle Also, what will this mean for my own mods

definetly: recompile mods thanks to .net4 / netstandard2

jolly jungle Feb 24, 2021, 12:52 PM

#

Will I need to change anything, or will the changes to the api, ah, "bridge" between the old mods and the new game version? Is that the word?

#

Not sure

jolly oriole Feb 24, 2021, 12:52 PM

#

the api gets some fat trimmed

jolly jungle Feb 24, 2021, 12:52 PM

#

Point is will I need to change any code myself

#

To a large amount

#

degree*

jolly jungle Feb 24, 2021, 12:53 PM

#

jolly oriole definetly: recompile mods thanks to .net4 / netstandard2

that won't need too much work though, right?

jolly oriole Feb 24, 2021, 12:53 PM

#

jolly jungle Point is will I need to change any code myself

depending on what unique stuff you do in mods, that could be the case, but if it's just a fsm change using unity's scenechanged hook it should only require recompile

jolly oriole Feb 24, 2021, 12:54 PM

#

jolly jungle that won't need too much work though, right?

just reference the new dlls instead of old ones and you should be good to go (while not forgetting to change framework version in project settings to 4)

jolly jungle Feb 24, 2021, 1:05 PM

#

Aight, wonderful

jolly jungle Feb 24, 2021, 1:06 PM

#

jolly oriole depending on what unique stuff you do in mods, that could be the case, but if it...

Nah, nothing really special, not even loading an asset or anything

#

So should I wait for the change before releasing it?

jolly oriole Feb 24, 2021, 1:07 PM

#

i mean, we don't know when it's releasing, so you can release your mod right now and just update once 1.5 is out

jolly jungle Feb 24, 2021, 1:17 PM

#

Cool

empty ridge Feb 24, 2021, 8:16 PM

#

is it possible to swap out an audioclip in a mod's initialized(), as opposed to tracking down where the audioclip gets played?

jolly oriole Feb 24, 2021, 8:16 PM

#

afaik no

empty ridge Feb 24, 2021, 8:17 PM

#

dang 😦

jolly oriole Feb 24, 2021, 8:17 PM

#

wait nvm, depends

#

if the GO exists in initialize(), then yes

empty ridge Feb 24, 2021, 8:17 PM

#

could you explain

jolly oriole Feb 24, 2021, 8:18 PM

#

like if you want to change audioclip of something in the main menu, then doing it in initialize() works, otherwise you'd have to wait for a scene to load that has the go in it to change the audioclip

empty ridge Feb 24, 2021, 8:19 PM

#

oh gotcha

#

im trying to disable the sound that plays when the knight lands, but thats not handled in heroaudiocontroller so im gonna have to track down where that gets played

#

assuming its an fsm thing

jolly oriole Feb 24, 2021, 8:24 PM

#

1 sc

#

if you want to just mute all landing sounds:

On.HardLandEffect.OnEnable += OnHardLandEffectOnEnable;
On.SoftLandEffect.OnEnable += OnSoftLandEffectOnEnable;

in those hooks, you get the Hard-/SoftLandEffect monobehaviour, which you can use to get audio on the go the effect is attached to

#

though let me check first if there is audio on the effects GOs

#

TIL hard landing sound is easier to deactiate

#

Knight GO -> Sounds GO -> HardLanding GO -> set volume to 0 probably
Knight GO -> Sounds GO -> Landing GO -> set volume to 0 probably

#

@empty ridge

empty ridge Feb 24, 2021, 8:33 PM

#

ooooooooooooh i'll try that

#

thank you!

jolly oriole Feb 24, 2021, 8:33 PM

#

so you can hook HeroController.Start or awake and do that

empty ridge Feb 24, 2021, 8:33 PM

#

makes sense

dark wigeon Feb 24, 2021, 9:30 PM

#

didn't see this ping until now, weird
again I'm guessing Shader.Find uses the hardcoded list in globalgamemanagers which isn't something you can patch at runtime so this is probably the best way

jolly oriole Feb 24, 2021, 9:38 PM

#

are you trying that in 1432 or 1.5?

#

well, ig either way it's possible to have mod be constructed very early after game start, in which one could load assetbundles with shaders, should definetly be before the first Shader.Find

empty ridge Feb 24, 2021, 9:42 PM

#

so muting hardlanding worked perfectly, muting landing did nothing... idk private void HeroController_Start(On.HeroController.orig_Start orig, HeroController self) { AudioSource hardland = self.transform.Find("Sounds/HardLanding").GetComponent<AudioSource>(); hardland.volume = 0; AudioSource land = self.transform.Find("Sounds/Landing").GetComponent<AudioSource>(); land.volume = 0; Log("swapped sound files!"); orig(self); }

jolly oriole Feb 24, 2021, 9:42 PM

#

that's weird

#

hm

empty ridge Feb 24, 2021, 9:43 PM

#

they seem identical lol

jolly oriole Feb 24, 2021, 9:43 PM

#

may be that it get's set to volume 1 if an actual landing occurs? idk how tc coded it

empty ridge Feb 24, 2021, 9:44 PM

#

i'll poke around a little more

jolly oriole Feb 24, 2021, 9:44 PM

#

i'll search too

empty ridge Feb 24, 2021, 9:45 PM

#

its hard cause its not like a class that you can search for in dnSpy

prime urchin Feb 24, 2021, 9:46 PM

#

It looks like in the softlanding play effect, it randomizes the pitch before playing

#

HeroAudioController.PlaySound -> case HeroSounds.SOFT_LANDING

jolly oriole Feb 24, 2021, 9:47 PM

#

yea, but it doesn't touch volume

empty ridge Feb 24, 2021, 9:47 PM

#

and i hooked that method to just return immediately

jolly oriole Feb 24, 2021, 9:49 PM

#

in Initialize(), if you can find the GO Soft Land Effect, set the volume of its AudioSource to 0

#

there's also one there

empty ridge Feb 24, 2021, 9:49 PM

#

tf

#

1 sec

jolly oriole Feb 24, 2021, 9:50 PM

#

hm, idk then, never tried to add custom shaders

#

though maybe the source code of asciicamera can help

#

https://github.com/fifty-six/HollowKnight.AsciiCamera

#

yea, just saw that it does apply manually

prime urchin Feb 24, 2021, 9:53 PM

#

Hmm, the other thing I found is the SoftLandEffect class, which plays the audio clips directly

#

apparently I'm blind as you've already pointed that out lul

empty ridge Feb 24, 2021, 9:56 PM

#

it worked!!!!

#

thanks so much!

jolly oriole Feb 24, 2021, 9:56 PM

#

np

#

how the fuck do i git rebase merge conflict in cli?

copper nacelle Feb 24, 2021, 10:12 PM

#

wdym

jolly oriole Feb 24, 2021, 10:12 PM

#

don't want to deal with that, i'll just delete and reclone my repo

copper nacelle Feb 24, 2021, 10:12 PM

#

🥴

jolly oriole Feb 24, 2021, 10:12 PM

#

it's faster

copper nacelle Feb 24, 2021, 10:13 PM

#

you can reset soft like 5 commits back then reset hard then pull

jolly oriole Feb 24, 2021, 10:15 PM

#

copper nacelle Feb 24, 2021, 10:17 PM

#

git reset --soft HEAD~10

#

git reset --hard

#

git pull

#

qed

jolly oriole Feb 24, 2021, 10:20 PM

#

now i know what's wrong, i did 2 other commits in my main mapi repo for no reason

copper nacelle Feb 24, 2021, 10:21 PM

#

🥴

#

i can give you the assembly if you'd like

jolly oriole Feb 24, 2021, 10:21 PM

#

nah, just threw away my commits

#

is now up 2 date

#

ready to make new prs pog

empty ridge Feb 24, 2021, 10:32 PM

#

so apparently the last bit i added to the hook worked because it was throwing an exception

#

i can figure it out but thought that was hilarious

jolly oriole Feb 24, 2021, 10:32 PM

#

lol

dark wigeon Feb 24, 2021, 11:47 PM

#

I used asset creator to create a ScriptMapper and it successfully loads by unity (somehow lol) but as I expected, the game only uses the one loaded from globalgamemanagers for Shader.Find and I'm pretty sure it does that at startup before any scripts can execute

#

Shader.Find is using globalgamemanagers' scriptmapper asset which is a lookup table of where to find shaders by their name

#

so I just verified that giving unity another shader list wouldn't work

#

unity loaded the shaders from the list but Shader.Find still didn't work

#

asset creator let's you make assets that don't have c# classes, like ScriptMapper for example

#

afaik you can't initialize one in c#

#

there's always ways to patch around the engine but that means you have to go into native code

#

but other than that, the code is probably like

var file = loadFile("globalgamemanagers")
this.globalTable = file.getScriptManager()
...
this.globalTable.find("blah blah")

so the only way to fix that would be to modify global table's memory or hook the function that loads it in the first place

#

in any case, too much work

#

either patch globalgamemanagers or deal with the patch on shader.find

vocal spire Feb 25, 2021, 12:08 AM

#

Can someone merge this?

copper nacelle Feb 25, 2021, 12:16 AM

#

i can merge it but i won't build it

vocal spire Feb 25, 2021, 4:11 AM

#

I'll build it but what do I do after that

languid goblet Feb 25, 2021, 5:00 AM

#

vocal spire Can someone merge this?

why are you talking to yourself

vocal spire Feb 25, 2021, 1:04 PM

#

Hoo knows

solemn rivet Feb 25, 2021, 2:37 PM

#

did you build it

vocal spire Feb 25, 2021, 2:40 PM

#

No, I’m lazy

solemn rivet Feb 25, 2021, 2:43 PM

#

@ lazy

jolly oriole Feb 25, 2021, 4:38 PM

#

this possibly has something to do with threaded reflection

dark wigeon Feb 25, 2021, 5:00 PM

#

isn't dnspy repo gone? so you can't get any more mono debug dlls

#

doesn't have unity 2020.2

#

it's probably not even hard to do manually

#

you know, since there's a giant section on it

#

I have compiled versions before on my laptop

#

I can try later

#

here's hoping it still works

potent dirge Feb 25, 2021, 5:16 PM

#

what exactly is the TLS issue with the old modding-api and github anyway? Is it something like Unity 2017 just refusing to run even external dlls/libraries that does use TLS 1.2, or is it that youd rather avoid bundling external stuff like that with the api?

jolly oriole Feb 25, 2021, 5:17 PM

#

modding api tls issue?

potent dirge Feb 25, 2021, 5:20 PM

#

yea, the old modding-api (the one used for 1221 currently) had a github version helper thingy that depended on TLS 1.0/1.1 for establishing a safe connection to github to check for current versions of mods being up-to-date or not, but github removed even optional TLS 1.0/1.1 support, so now it can't connect and throws errors + tells everyone every mod is outdated pm

stone elm Feb 25, 2021, 5:22 PM

#

Sounds like something @deep wave fixed in a fork. They enabled TLS1.2 as a security protocol for the ServicePointManager. I believe that solves the problem, although I may be full of it

potent dirge Feb 25, 2021, 5:33 PM

#

I think that was a different issue related to the ModInstaller and just windows (7?) not supporting TLS1.2 out of the box, but in the modding-api case its ran with/by the game so its ran by Unity2017 rather than as its own external program

stone elm Feb 25, 2021, 5:33 PM

#

Ah, sorry, I misread you saying modding-api as ModInstaller.

potent dirge Feb 25, 2021, 5:36 PM

#

could also just strip that functionality completely out if @deep wave does her job and completely overhauls the modinstaller to work for downpatched versions as well so lazy omfg 😤 🙏

stone elm Feb 25, 2021, 5:57 PM

#

Windows 7 had it supported it just needs to be told to use it. Hence adding it to the enum in ServicePointManager.SecurityProtocol.

#

Http/WebClient follow suit based on that.

potent dirge Feb 25, 2021, 6:15 PM

#

Oh, I didn't make this, I'm looking for a solution to fixing it, and for that I want to know exactly why it wasn't fixed already etc paxitiPeek

stone elm Feb 25, 2021, 6:18 PM

#

I looked around for the code that does the update check in moddingapi and I couldn't find much (just searching through github though). If you knew where it was I could look to offer an opinion but there isn't much more I can do atm.

potent dirge Feb 25, 2021, 6:26 PM

#

I think this is the one, actually, so its just commented out but still there apolThink
https://github.com/seresharp/HollowKnight.Modding/blob/4d356a37d7133623fbb3b4066cebb8988e65490d/Assembly-CSharp/GithubVersionHelper.cs#L35

GitHub

seresharp/HollowKnight.Modding

Contribute to seresharp/HollowKnight.Modding development by creating an account on GitHub.

#

yea, that was what I was thinking, but I wanted to ask if anyone had already tried and had it not work

deep wave Feb 25, 2021, 6:54 PM

#

potent dirge could also just strip that functionality completely out if <@!196347053100630016...

why must you call me out like this PepeHands

solemn rivet Feb 25, 2021, 6:57 PM

#

wait

#

who's overhaulin what

potent dirge Feb 25, 2021, 6:57 PM

#

Bc I love u, jamie:3

#

I want to overhaul the old githubversion checker in the old 1221 api so that it works again, if possible, so I asked if anyone had tried to fix it before

#

(it's also in the current cp version, just commented out)

solemn rivet Feb 25, 2021, 6:59 PM

#

uh huh...

#

about the installer tho

#

I think back when I was first making it, we discussed about adding support for multiple installs

#

but people seems to not be too keen on it back then

#

because "people who are running multiple installs don't really need the installer"

#

specially because older patches didn't have any working mods back then

#

I think 1221 had an api that doubled as debug

copper nacelle Feb 25, 2021, 7:02 PM

#

it's still just 1221 and like the 2 1028 mods

solemn rivet Feb 25, 2021, 7:02 PM

#

yeah

#

I mean, if you guys wanna do that overhaul, be my guest

#

but I doubt it's worth the effort

copper nacelle Feb 25, 2021, 7:02 PM

#

1221 has like 3 mods people actually use too

solemn rivet Feb 25, 2021, 7:03 PM

#

oh

copper nacelle Feb 25, 2021, 7:03 PM

#

ax1uwide3

solemn rivet Feb 25, 2021, 7:03 PM

#

it has more than just a singular mod now?

#

is it a rando or something?

copper nacelle Feb 25, 2021, 7:03 PM

#

debug, hitboxes, custom knight?

solemn rivet Feb 25, 2021, 7:03 PM

#

oh right

#

wtf is wrong with my kb today

copper nacelle Feb 25, 2021, 7:03 PM

#

I mean 1221 has the real api it's just that nobody is going to maintain mods for that

potent dirge Feb 25, 2021, 7:04 PM

#

Another big part of why there aren't more mods is because it's harder to find resources for those versions

jolly oriole Feb 25, 2021, 7:04 PM

#

and because they're ancient

potent dirge Feb 25, 2021, 7:04 PM

#

Moth mentioned porting benchwarp, but tuples effort

copper nacelle Feb 25, 2021, 7:04 PM

#

that ain't effort

solemn rivet Feb 25, 2021, 7:04 PM

#

I think another reason why was because adding support for older versions might accidentally add support for pirated versions

copper nacelle Feb 25, 2021, 7:04 PM

#

you add 1 file to the mods folder

potent dirge Feb 25, 2021, 7:05 PM

#

Nah, the effort being bc they're in one and not the other, from what I read back then

copper nacelle Feb 25, 2021, 7:05 PM

#

yeah like I said

#

Put tuples in mod folder

#

Ref tuples in mod folder

#

Build against 1221 api

#

Profit

potent dirge Feb 25, 2021, 7:05 PM

#

Literally impossible :o

copper nacelle Feb 25, 2021, 7:05 PM

#

by impossible do you mean free

solemn rivet Feb 25, 2021, 7:05 PM

#

yes

copper nacelle Feb 25, 2021, 7:05 PM

#

because 1432 doesn't have native tuples either

potent dirge Feb 25, 2021, 7:06 PM

#

Yes, and I know ax2uHappy

copper nacelle Feb 25, 2021, 7:06 PM

#

They're just ilmerge'd in because me and serena found them convenient

jolly oriole Feb 25, 2021, 7:06 PM

#

1432 is also ancient though :v

copper nacelle Feb 25, 2021, 7:06 PM

#

true af

#

the faster I can stop supporting 1432 the better

solemn rivet Feb 25, 2021, 7:06 PM

#

trutru

#

you know what

#

I'm gonna lock the ss modinstaller behind a paywall

hexed violet Feb 25, 2021, 7:08 PM

#

hornet420

ornate rivet Feb 25, 2021, 7:10 PM

#

time to bring crossroads back :)

unborn flicker Feb 25, 2021, 8:08 PM

#

That was a meme cerpin. The respawn method is very different on 1221, so even with an api with monomod hooks it would have to be rewritten.

#

I do still blame 56's refactoring which added 200 tuples though. I'm pretty sure number of errors in visual studio == difficulty of fixing the code is the way it works, after all sheopride

copper nacelle Feb 25, 2021, 8:17 PM

#

better than 200 * 5 duplicated lines

unborn flicker Feb 25, 2021, 8:18 PM

#

It really was awful

potent dirge Feb 25, 2021, 9:17 PM

#

ah, imagine memeing in a public server like that D:

jolly jungle Feb 25, 2021, 9:52 PM

#

Alright

#

It's time

#

How do I get my mod onto the installer
If I happen to not have a github (or, well, I technically do, but I have no idea how to use it so, not yet)

jolly oriole Feb 25, 2021, 9:57 PM

#

upload a zip (containing the mod and a readme) somewhere (e.g. the gdrive)
make a pullrequest (PR for short) to https://github.com/Ayugradow/ModInstaller (requires github) that adds lines for your mod to be downloadable
2.1. Requires: Name, Short Description, File name (dll) and the SHA1 value of that file (per file), link to ZIP, dependency list
2.2. you could also get somebody else to do it for you

jolly jungle Feb 25, 2021, 9:58 PM

#

e.g. the gdrive
The? A specific one?

jolly oriole Feb 25, 2021, 9:58 PM

#

just said that as an example, but i meant the google drive with all the mods on it

jolly jungle Feb 25, 2021, 9:58 PM

#

So yes a specific one

jolly oriole Feb 25, 2021, 9:59 PM

#

technically you could upload it wherever you want (i use github releases)

jolly jungle Feb 25, 2021, 9:59 PM

#

Lemme make the zip first, then I'll see

jolly oriole Feb 25, 2021, 10:00 PM

#

you could just DM me the zip then

jolly jungle Feb 25, 2021, 10:00 PM

#

Any specific name the zip needs?

jolly oriole Feb 25, 2021, 10:00 PM

#

no

#

wait nvm, if you upload it to the gdrive i can just pull it from there

jolly jungle Feb 25, 2021, 10:00 PM

#

As in, the ZIP's name won't influence anything, right?

jolly oriole Feb 25, 2021, 10:00 PM

#

yes

jolly jungle Feb 25, 2021, 10:01 PM

#

It's all the .dll

#

Thanks

#

Readme file in all caps, lowercase, or title?

#

The file's name

jolly oriole Feb 25, 2021, 10:02 PM

#

i think it's not strict, but i'd name it Readme.something

#

personally i just markdown files, so it would be Readme.md

jolly jungle Feb 25, 2021, 10:03 PM

#

Title it is, then

#

markdown?

jolly oriole Feb 25, 2021, 10:03 PM

#

text, but fancy

jolly jungle Feb 25, 2021, 10:03 PM

#

Huh

#

I'll need to check that out later

#

I like fancy

jolly oriole Feb 25, 2021, 10:03 PM

#

looks like this https://github.com/TTacco/Hollow-Point/blob/master/README.md

copper nacelle Feb 25, 2021, 10:04 PM

#

do .md or .txt

#

installer doesn't recognize the other ones

jolly oriole Feb 25, 2021, 10:05 PM

#

got languagesupport working on newest 1.5 mapi

ornate rivet Feb 25, 2021, 10:05 PM

#

nice

copper nacelle Feb 25, 2021, 10:05 PM

#

nice

jolly oriole Feb 25, 2021, 10:05 PM

#

and i didn't even need tryparse lmao

jolly jungle Feb 25, 2021, 10:06 PM

#

jolly oriole looks like this <https://github.com/TTacco/Hollow-Point/blob/master/README.md>

yooo that really is fancy

#

How do I make one?

jolly oriole Feb 25, 2021, 10:06 PM

#

just text https://raw.githubusercontent.com/TTacco/Hollow-Point/master/README.md

jolly jungle Feb 25, 2021, 10:09 PM

#

Wait so I use the same text formatting, save as .md, and it comes out fancy?

jolly oriole Feb 25, 2021, 10:09 PM

#

depending on what you use to look at it, github displays it fancy, but in notepad it looks like the raw link

jolly jungle Feb 25, 2021, 10:09 PM

#

Ah

jolly jungle Feb 25, 2021, 10:25 PM

#

Alrightyyy

#

Do I just upload it to the first link in ?mods

jolly oriole Feb 25, 2021, 10:27 PM

#

https://drive.google.com/drive/folders/0B_b9PFqx_PR9Um9MeFZMV21oWGs

jolly jungle Feb 25, 2021, 10:27 PM

#

Yep, that's the one

#

So, [My name] - [Mod name]?

jolly oriole Feb 25, 2021, 10:28 PM

#

yea

jolly jungle Feb 25, 2021, 10:28 PM

#

Can't touch it shadecry

jolly oriole Feb 25, 2021, 10:28 PM

#

then dm me the zip

jolly jungle Feb 25, 2021, 10:28 PM

#

Sure thing

jolly oriole Feb 25, 2021, 10:36 PM

#

https://github.com/Ayugradow/ModInstaller/pull/55 merge please, thanks

jolly jungle Feb 25, 2021, 10:37 PM

#

Yeeee

#

This is gonna be greattt

tidal mantle Feb 26, 2021, 12:22 AM

#

Anyone have a solution for UnityEngine.UI not being referenced properly ("The type or namespace name 'Text' could not be found")? I'm definitely using UnityEngine.UI, vs is just not accepting it. I feel like I've solved this problem before, but from Unity's side, and long enough ago that I don't remember how I did it.

native pelican Feb 26, 2021, 12:24 AM

#

tidal mantle Anyone have a solution for UnityEngine.UI not being referenced properly ("The ty...

Oh wait I might know that one actually. Do you need the text rendering module?

tidal mantle Feb 26, 2021, 12:24 AM

#

native pelican Oh wait I might know that one actually. Do you need the text rendering module?

Also referenced in the project, so it shouldn't be that.

native pelican Feb 26, 2021, 12:25 AM

#

👍 that's all I've got

copper nacelle Feb 26, 2021, 12:36 AM

#

are you refing UnityEngine.UI and UnityEngine

tidal mantle Feb 26, 2021, 12:36 AM

#

Yup

prime urchin Feb 26, 2021, 12:38 AM

#

did you maybe accidentally set an alias for the referenced .dll?

tidal mantle Feb 26, 2021, 12:39 AM

#

alias is set to global only

prime urchin Feb 26, 2021, 12:39 AM

#

it'll be UnityEngine.UI, not UIModule

tidal mantle Feb 26, 2021, 12:42 AM

#

is there a UnityEngine.UI.dll somewhere I just can't find? I see a UIElementsModule and a UIModule

prime urchin Feb 26, 2021, 12:42 AM

#

should be in the folder with all the others

tidal mantle Feb 26, 2021, 12:43 AM

#

hmmmmm, new question is "why doesn't my unity install have that", but i don't think that's a question for y'all

#

The former.

copper nacelle Feb 26, 2021, 12:44 AM

#

why are you refing unity dlls for a mod

#

like unity dlls in a unity folder

#

you just ref the game ones

tidal mantle Feb 26, 2021, 12:45 AM

#

......... im a fool

#

yeah, i just clearly wasn't thinking when moving on to ui

prime urchin Feb 26, 2021, 12:55 AM

#

it happens

copper nacelle Feb 26, 2021, 6:02 AM

#

@dark wigeon not to be a bother but fwiw level308 -> Acid Box -> damages_enemies crashes the avalonia viewer if you try and open it

dark wigeon Feb 26, 2021, 6:02 AM

#

why does it crash

#

it shouldn't do that

copper nacelle Feb 26, 2021, 6:03 AM

#

that's true

dark wigeon Feb 26, 2021, 6:03 AM

#

I'm about to 💤 so see you in 13 hours

copper nacelle Feb 26, 2021, 6:03 AM

#

alright

dark wigeon Feb 26, 2021, 6:04 AM

#

beta too?

copper nacelle Feb 26, 2021, 6:04 AM

#

yeah beta release 2

dark wigeon Feb 26, 2021, 6:05 AM

#

no hk beta

copper nacelle Feb 26, 2021, 6:06 AM

#

ah

#

yeah hk beta

dark wigeon Feb 26, 2021, 3:52 PM

#

ok it was trying to read arrays but arrays aren't supported

naive nimbus Feb 26, 2021, 5:10 PM

#

Not exactly a mod, but I made this skin in Photoshop. https://drive.google.com/file/d/131ikS91yddw_Vq3sx25IgHi5Qhp2u5lL/view?usp=sharing

Google Docs

Lifeblood HK.png

#

Sorry it's not a mod, idk where else to put it

copper nacelle Feb 26, 2021, 5:20 PM

#

cool

naive nimbus Feb 26, 2021, 5:27 PM

#

Thx!

potent dirge Feb 26, 2021, 5:30 PM

#

I think it'd fit best in modding discussions, but otherwise that looks surprisingly good 👀

stiff pilot Feb 26, 2021, 6:35 PM

#

guys can u give me gun mod pls

gilded lotus Feb 26, 2021, 6:39 PM

#

try going to the right channel then maybe

knotty dagger Feb 26, 2021, 7:06 PM

#

hello guys, I'm going to try something very basic, but I don't know anything about programming... I've open the code of a mod and I just want to change a name inside for my personal usage (because I play the game in French, so just wanted to translate the boss name to fit more in the game), I've find what I have to change, I've modified it, but cannot save it. Is their a simple way to just make a simple edit onto the files packed into a dll ? I don't ask for programming help, just for knowing if it's actually doable for a beginner to save the changes made to the dll

#

(sorry if it's the bad channel to ask that)

vocal spire Feb 26, 2021, 7:10 PM

#

knotty dagger hello guys, I'm going to try something very basic, but I don't know anything abo...

If you edit it in dnspy or ilspy it’s easy to do, but if you do anything more, I suggest making/editing a mod in a c# ide such as Microsoft visual studio(community version is free) since dnspy and ilspy editing becomes hard fast(at least in my experience)

leaden hedge Feb 26, 2021, 7:12 PM

#

for dnspy you just go to file Save Module...

#

if you've managed to save the class

knotty dagger Feb 26, 2021, 7:13 PM

#

okay thanks guys, I'll try it!

jolly oriole Feb 26, 2021, 7:28 PM

#

lurkersweat

copper nacelle Feb 26, 2021, 7:43 PM

#

x5fiftM

safe hamlet Feb 26, 2021, 7:43 PM

#

what are you doing bro

jolly oriole Feb 26, 2021, 7:44 PM

#

obv nothing bad

copper nacelle Feb 26, 2021, 7:51 PM

#

top 10 anime lies

jolly oriole Feb 26, 2021, 7:54 PM

#

i couldn't help myself grubsad

copper nacelle Feb 26, 2021, 7:55 PM

#

Wtf

#

really was a top 10 anime lie

unborn flicker Feb 26, 2021, 8:03 PM

#

Modding API source:
https://github.com/seresharp/HollowKnight.Modding

GitHub

seresharp/HollowKnight.Modding

Contribute to seresharp/HollowKnight.Modding development by creating an account on GitHub.

jolly oriole Feb 26, 2021, 8:24 PM

#

copper nacelle really was a top 10 anime lie

please don't kill me, i just avoid code duplication

prime urchin Feb 26, 2021, 8:25 PM

#

the most egregious thing is that TSave is the first type parameter but listed second in the constraints

#

absolutely unusable

jolly oriole Feb 26, 2021, 8:25 PM

#

oh god oh fuck

#

somehow didn't realize that

copper nacelle Feb 26, 2021, 8:25 PM

#

that's true

#

the generic version means you have to specify a save setting type though

#

terrible

#

and you can't have two generic versions with one param so you can't say only save/global easily

jolly oriole Feb 26, 2021, 8:26 PM

#

copper nacelle Feb 26, 2021, 8:27 PM

#

did you just name them entirely differently

#

Suffering

jolly oriole Feb 26, 2021, 8:27 PM

#

i named them according to what to expect of them

copper nacelle Feb 26, 2021, 8:28 PM

#

hmmmm

#

fair enough

prime urchin Feb 26, 2021, 8:28 PM

#

was it intended that your Type variables don't have underscores?

jolly oriole Feb 26, 2021, 8:29 PM

#

prime urchin was it intended that your Type variables don't have underscores?

stole the style from 56's hellmod

copper nacelle Feb 26, 2021, 8:29 PM

#

what

#

i use underscores

#

for all of the private fields

jolly oriole Feb 26, 2021, 8:29 PM

#

oh wait yea, you didn't use the types

#

then i have no idea why i left the type types without underscores

copper nacelle Feb 26, 2021, 8:30 PM

#

nice

prime urchin Feb 26, 2021, 8:31 PM

#

that's one of those small things that would bother me the most lul

jolly oriole Feb 26, 2021, 8:31 PM

#

but it's easy to edit

safe hamlet Feb 26, 2021, 8:35 PM

#

why are they protected

copper nacelle Feb 26, 2021, 8:35 PM

#

so you can use your settings

#

the override returns a base class so you need access to the backing field

#

though you could make the argument for a public property or something

safe hamlet Feb 26, 2021, 8:37 PM

#

yeah i see it now and no protected is def better than public

jolly oriole Feb 26, 2021, 8:37 PM

#

protected is good enough, and if people ever want to derive from another mod's mod class i have lost all faith

copper nacelle Feb 26, 2021, 8:38 PM

#

🥴

safe hamlet Feb 26, 2021, 8:38 PM

#

i mean yeah

copper nacelle Feb 26, 2021, 8:38 PM

#

seal your mod classes for the hot devirtualization

jolly oriole Feb 26, 2021, 8:39 PM

#

sealed public < public sealed

jolly oriole Feb 26, 2021, 9:32 PM

#

god dammit

[DEBUG]:[API] - Trying to instantiate mod: SFCore.DontLet56SeeThis.FullSettingsMod`2[TSave,TGlobal]
[ERROR]:[API] - Error: System.MemberAccessException: Cannot create an instance of SFCore.DontLet56SeeThis.FullSettingsMod`2[TSave,TGlobal] because Type.ContainsGenericParameters is true.

it's abstract for a reason.
so either i pr it to the mapi (which you prob wouldn't like 56) or i copy paste the code into files

jolly oriole Feb 26, 2021, 9:53 PM

#

ig i'll adjust the api to not try to instantiate abstract classes

#

o my god, did tc change the fucking fsm of the control of the world map

copper nacelle Feb 26, 2021, 10:26 PM

#

I gotta say it instantiating abstract classes seems like something that should be fixed

jolly oriole Feb 26, 2021, 10:27 PM

#

yeah, just need to pr it

#

https://github.com/seresharp/HollowKnight.Modding/pull/39 merge please

floral island Feb 26, 2021, 10:32 PM

#

hol up are there grenades here

jolly oriole Feb 26, 2021, 11:12 PM

#

yes

#

i have no idea how additionalmaps worked, gives me one exception after another with 1.5

prime urchin Feb 26, 2021, 11:47 PM

#

I do the weirdest stuff and then end up just deleting it after

copper nacelle Feb 27, 2021, 12:01 AM

#

should ifnull not just return Some

prime urchin Feb 27, 2021, 12:02 AM

#

probably; I'm not experienced with functional programming and I scrapped that as soon as I realized I was once more doing more than I needed to, hah

copper nacelle Feb 27, 2021, 12:07 AM

#

understandable

stone elm Feb 27, 2021, 12:27 AM

#

Does the ModConsole print all Modding.Logger.Log statements to itself?

copper nacelle Feb 27, 2021, 12:28 AM

#

no

stone elm Feb 27, 2021, 12:29 AM

#

Okay, thanks. I'll look at its source, assuming the repo is on GH, and see how to plop text in there. Unless someone wants to give me the answer. zote

copper nacelle Feb 27, 2021, 12:30 AM

#

logger.log will just go to the normal console window

#

you can get text by like returning a string or something in a function you call

stone elm Feb 27, 2021, 12:31 AM

#

Okay, I'll dig in. Thanks!

#

?saves

finite forumBOT Feb 27, 2021, 12:31 AM

#

Saves

Windows File Paths: (Assumes Default Steam Install Path, Adjust accordingly for DRM Free or Non-Standard Steam Path)

Game Files: C:\Program Files (x86)\Steam\steamapps\common\Hollow Knight\```
** **
Mac File Paths:
```Save Files: ~/Library/Application Support/unity.Team Cherry.Hollow Knight/
Game Files: ~/Library/Application Support/Steam/steamapps/common/Hollow Knight/hollow_knight.app/```
** **
Linux File Paths:
```Save Files: ~/.config/unity3d/Team Cherry/Hollow Knight/
Game Files: ~/.local/share/Steam/steamapps/common/Hollow Knight/```

stone elm Feb 27, 2021, 1:50 AM

#

Is it presently possible to attach a debugger to HK to more easily debug mods? Apologies if this is a basic question, I'm very new to HK/Unity modding.

prime urchin Feb 27, 2021, 1:58 AM

#

Since dnSpy was archived it's a little harder because their github doesn't have the debugging .dlls anymore but I want to say someone around here has a link to one that works with HK - I don't have it myself though.

stone elm Feb 27, 2021, 2:04 AM

#

Unfortunate. I wonder what happened to cause that. Okay, well, thanks for the answer! I'll muddle through.

dark wigeon Feb 27, 2021, 2:06 AM

#

prime urchin Since dnSpy was archived it's a little harder because their github doesn't have ...

I'm going to make a new one tomorrow

prime urchin Feb 27, 2021, 2:14 AM

#

That'll be great to have

copper nacelle Feb 27, 2021, 2:18 AM

#

it 'works'

#

as in it works if you use exactly 0 on hooks and none of your mods use on hooks

#

otherwise it violently crashes the game

#

🙂

vocal spire Feb 27, 2021, 2:19 AM

#

Why does that crash

copper nacelle Feb 27, 2021, 2:19 AM

#

at least last i tried it crashed

#

on 1432

#

you can get line numbers if you use an mdb or a portable pdb though for exceptions

#

not a debugger but it's a start

prime urchin Feb 27, 2021, 2:23 AM

#

You mean using a mod's pdb or is there a special Unity HK pdb somewhere?

copper nacelle Feb 27, 2021, 2:23 AM

#

mod pdb

#

just set the debugtype to portable

#

portable works on 1.5 at least

#

i only tried mdb on 1.4

#

via mono's pdb2mdb

prime urchin Feb 27, 2021, 2:35 AM

#

The pdb doesn't seem to be working for me unless I'm missing something obvious

copper nacelle Feb 27, 2021, 2:39 AM

#

portable yeah?

prime urchin Feb 27, 2021, 2:39 AM

#

yup

copper nacelle Feb 27, 2021, 2:40 AM

#

might be 1.5 then

prime urchin Feb 27, 2021, 2:40 AM

#

gonna download Unity 2017 real quick and see if I can use pdb2mdb for it

copper nacelle Feb 27, 2021, 2:40 AM

#

pdb2mdb works for 1.4.3.2 pretty sure

#

might need the debug unity runner idr

#

you just take the exe off unity

#

very easy

#

debug exe/unityplayer

📎 Hollow_Knight.zip

#

if it doesn't work w/out those

dark wigeon Feb 27, 2021, 2:43 AM

#

you find a different way to get debugging on 2020.2?

native pelican Feb 27, 2021, 2:44 AM

#

Does anyone know how to get a game object to be a child of an existing game object and still render? I want to attach something to a game object without having to update its position every frame.

#

When I try the obvious thing and set my game object's transform.parent to the target instead of a canvas, it doesn't get rendered anymore.

copper nacelle Feb 27, 2021, 2:44 AM

#

nah i haven't tried proper debugging

prime urchin Feb 27, 2021, 2:45 AM

#

native pelican Does anyone know how to get a game object to be a child of an existing game obje...

Try SetParent with the worldPositionStays bool set to false

#

also make sure that what you're attaching to is active

native pelican Feb 27, 2021, 2:51 AM

#

prime urchin Try SetParent with the worldPositionStays bool set to false

Still nothing rendered. Here's the code I'm running if you're down to look (it's being run for every enemy at the moment): https://gist.github.com/itsjohncs/2a4df334aa3acce411c71e6753f8c1d8

copper nacelle Feb 27, 2021, 2:52 AM

#

could try a spriterenderer

#

does it work w/ no parent

native pelican Feb 27, 2021, 2:54 AM

#

I'll try a spriterenderer now, thank you. It works with a canvas as a parent. Here's my working version that does that (and it doesn't move with the object): https://gist.github.com/itsjohncs/a265531d0766692151e8509671549ef9

prime urchin Feb 27, 2021, 2:56 AM

#

Hmm, it might be because an Image is a UI element and UI elements have to have a canvas parent - I don't suppose you can parent the canvas itself to the gameobject?

native pelican Feb 27, 2021, 2:59 AM

#

I don't think I tried that, I will if my spriterenderer poking doesn't work out... still trying things with SpriteRenderer to see if that'll work

prime urchin Feb 27, 2021, 2:59 AM

#

I suppose alternatively you could have a big screenspace canvas and have images for each object that update with a world position to screen position method

native pelican Feb 27, 2021, 3:01 AM

#

Yeah, I think that's what hollow point does (was poking around in there earlier hoping that they figured this out). I could certainly get that working. It just feels kinda cludgy... like this should work afaik

prime urchin Feb 27, 2021, 3:03 AM

#

I think SpriteRenderer works in a similar way to Image so hopefully it works

#

it does seem a lot cleaner that way

native pelican Feb 27, 2021, 3:04 AM

#

Yeah I noticed that SpriteRenderer can just be given a color too, so I don't have to generate my own sprite like I was... I want this to work...

#

Not getting anywhere yet though, still just not rendering anything

native pelican Feb 27, 2021, 3:26 AM

#

Setting the canvas object's parent to the target didn't work either 😦

#

Imma give up for now but please anyone ping me if you've got other ideas. I'd love to figure out how to do this cleanly.

prime urchin Feb 27, 2021, 4:17 AM

#

well, I made a plane I guess

dark wigeon Feb 27, 2021, 4:26 AM

#

all hail the magical mono dll

📎 mono-2.0-bdwgc.dll

copper nacelle Feb 27, 2021, 4:26 AM

#

is this for debugging

dark wigeon Feb 27, 2021, 4:26 AM

#

yes

copper nacelle Feb 27, 2021, 4:26 AM

#

sick

prime urchin Feb 27, 2021, 4:26 AM

#

ver nice

dark wigeon Feb 27, 2021, 4:27 AM

#

I really only uploaded this here to send it from my laptop to my pc

#

but you can try it too

#

2020 messed up a bunch of stuff in the repo so I have no idea how stable that is ^

#

nvm it just instantly crashes

prime urchin Feb 27, 2021, 4:28 AM

#

rip

dark wigeon Feb 27, 2021, 4:28 AM

#

well I mean it built without errors

#

ah wow ok

#

huge file size difference

prime urchin Feb 27, 2021, 4:35 AM

#

native pelican Imma give up for now but please anyone ping me if you've got other ideas. I'd lo...

I was able to use a plane to achieve a similar effect - not sure how well this would work in your use case

#

position's probably off - I edited the values while in-game

native pelican Feb 27, 2021, 4:40 AM

#

prime urchin I was able to use a plane to achieve a similar effect - not sure how well this w...

Ooo very rad! Thank you! I'm betting I can interrogate the primitve object to see what's special about it to see what I was missing too.

prime urchin Feb 27, 2021, 4:44 AM

#

It uses a MeshRenderer as it's a 3D object which is why I'm a little iffy on that

#

then again, the Knight also uses a MeshRenderer (which might be why the SpriteRenderer doesn't work? not entirely certain)

native pelican Feb 27, 2021, 4:51 AM

#

The enemies I was atcching too also seemed to use meshrenderers

#

I wish I'd ever used unity before. So many mysteries.

#

Though I guess it does make it all new and interesting too 😅

dark wigeon Feb 27, 2021, 4:51 AM

#

that's a tk2d thing

native pelican Feb 27, 2021, 4:52 AM

#

I should say: I wish I'd ever used anything I'm poking at before then.

jolly oriole Feb 27, 2021, 2:16 PM

#

why the fuck does SendEventByName not find my custom event anymore?

#

how many fsm utils are there?

dark wigeon Feb 27, 2021, 4:13 PM

#

yep v4 mbe vs2017 and tried to get the code as close to the dll build date as I could like the instructions say

#

I don't know why it would be so off

#

sure

jolly oriole Feb 27, 2021, 4:16 PM

#

jolly oriole how many fsm utils are there?

because it's possible that nearly none of them work anymore with hk 1.5

copper nacelle Feb 27, 2021, 4:18 PM

#

why

#

qol seemed to work fine

#

and that is like 80% fsm modding

jolly oriole Feb 27, 2021, 4:19 PM

#

thanks to FsmTransitions apparently not using the string toState anymore, but toFsmState instead

#

from my testing at least

#

does qol have its own fsm thing?

copper nacelle Feb 27, 2021, 4:20 PM

#

vasi

#

why are you using toState when there's a public property

#

disturbing

jolly oriole Feb 27, 2021, 4:21 PM

#

is use the property

copper nacelle Feb 27, 2021, 4:22 PM

#

what

#

ok well the property works fine for me ngl

jolly oriole Feb 27, 2021, 4:22 PM

#

hm

copper nacelle Feb 27, 2021, 4:23 PM

#

any backing field

jolly oriole Feb 27, 2021, 4:24 PM

#

#

unless your playmaker version is somehow different idk why there would be differences

copper nacelle Feb 27, 2021, 4:25 PM

#

what's the get on both of them do

#

and set

jolly oriole Feb 27, 2021, 4:26 PM

#

literally just sets/gets the backing field

#

copper nacelle Feb 27, 2021, 4:28 PM

#

incredible

#

I'll check closer after I eat

#

Maybe I just didn't test anything relying on it lmao

jolly oriole Feb 27, 2021, 4:44 PM

#

lol

jolly jungle Feb 27, 2021, 5:12 PM

#

Aight

#

So there's a problem I don't know how to approach

#

I'm assuming it's caused because of differences between PCs

#

So I was watching crankytemplar's vid on buzzbo, and it seems that the spikes came out much more frequently than when I played

#

For example, the spiral spikes, that happen during the glob and bees, go around three times in the vid, while only once when I play it

#

I think it's cuz of the messy way I spawned them

#

Which is having a coroutine always active, checking a boolean every point something of a second, and spawning spikes if yes

#

boolean controlled by attacks, of course

#

So, if anyone can give a better way that won't lead to this inconsistency, and is also probably better in general, please, please tell

prime urchin Feb 27, 2021, 5:17 PM

#

initially that sounds like an issue of not using deltaTime but I dunno if you have a github or anything to look at

jolly jungle Feb 27, 2021, 5:22 PM

#

Pretty simply, seems to spawn at different rates between different pcs

#

The spikes, that is

jolly jungle Feb 27, 2021, 6:10 PM

#

Woah again?

#

Disable vsync, unlock framerate

#

What's this mean?

prime urchin Feb 27, 2021, 6:22 PM

#

In your game settings, make sure you have both vsync and the frame cap off

jolly jungle Feb 27, 2021, 6:33 PM

#

Hm

#

I think I did turn them both off a while ago

#

Or maybe I turned frame cap on, actually

#

I'll need to check

#

Thanks

dark wigeon Feb 27, 2021, 6:41 PM

#

yes I'm already using that

#

giving it the right commit is part of the build process, I can't skip that

leaden hedge Feb 27, 2021, 6:43 PM

#

post your code

#

its hard to debug, "it happens too often", without a snippet

copper nacelle Feb 27, 2021, 7:17 PM

#

really doesnt' work

#

ax1uwide3

jolly oriole Feb 27, 2021, 7:18 PM

#

btw 56, it really is "just" the tofsmstate thing that broke the entirety of additionalmaps

copper nacelle Feb 27, 2021, 7:24 PM

#

amazing

dark wigeon Feb 27, 2021, 8:37 PM

#

this is for 2020.2?

#

weird how big yours is. I even tried vs2019 to be sure and nothing really changed

#

yes I fixed the submodule thing

#

but mines way smaller than the original

#

maybe not way

#

any assertions while building?

dark wigeon Feb 27, 2021, 9:23 PM

#

yep, had the atomic ops problem tko

#

I also had a problem with dnspy's generator asserting on the patched code

#

oh lol

#

I think the atomic ops problem came when I didn't build in release x64

prime urchin Feb 28, 2021, 1:32 AM

#

Refactoring is one of those things that's annoying in the moment but oh so satisfying when you're done

jolly oriole Feb 28, 2021, 1:41 AM

#

idea for mapi: ingame mod reloading, a button somewhere that mods completely unload and scene 0 is loaded, to reinitialize mod loading

copper nacelle Feb 28, 2021, 1:43 AM

#

maybe with .net 4

#

assembly load stuff was terrible in 3.5

#

i had wanted that

jolly oriole Feb 28, 2021, 1:44 AM

#

can probably look at how to manage such a thing after monday

copper nacelle Feb 28, 2021, 1:45 AM

#

it's prob fine with appdomains in 4

#

hopefully at leaset

#

x5fiftPrime

charred topaz Feb 28, 2021, 1:45 AM

#

I recall dot net core 3.0 made it easier to do that, but I don’t think it’s still possible under .net standard 2.0

#

Unless appdomains

copper nacelle Feb 28, 2021, 1:45 AM

#

Suffering

stone elm Feb 28, 2021, 1:53 AM

#

Reloading assemblies with appdomains is nearly impossible, don't try it. hollowcry We suffered that problem with TShock for Terraria and just never accomplished it.

stone elm Feb 28, 2021, 2:50 AM

#

Legendary. I assume this allows attachment via dnSpy? Or does any debugger work out? Also, do you have a ko.fi or something similar? That's good effort, worth buying you a cup of coffee.

copper nacelle Feb 28, 2021, 3:18 AM

#

if it's like 2019 it will crash

stone elm Feb 28, 2021, 3:21 AM

#

It very well might, but I recognize effort that is above my head. I'm not the brightest bulb with some things. zote

dark wigeon Feb 28, 2021, 3:30 AM

#

yeah I was getting that exception too but I didn't want to break anything by commenting anything out

stone elm Feb 28, 2021, 3:39 AM

#

I'm running into some weird assembly loading issues with mod development. I'm pretty sure it's due to my ignorance here. Is it reasonable to reference Newtonsoft.Json.dll in a mod? It seems to lead to dependency loading hell, at least Unity isn't grabbing what it needs from the GAC. Is there a preferred JSON de/serialization alternative?

copper nacelle Feb 28, 2021, 3:41 AM

#

i mean if you want json.net for something yeah

#

if you're doing 1.5 dev

#

it's in assembly-csharp in 1.4

#

the alternative is unity's jsonutility which is kinda garbage

stone elm Feb 28, 2021, 3:43 AM

#

Well, I'm punching myself in the gut with what I'm doing, maybe. I'm referencing a general purpose library (for networking purposes) which references json.net. I absolutely do not want to reference assembly-csharp nor unity in this general purpose library.

#

Since 1.4 has json.net in the assembly, I'm going to assume unity can resolve the types and I've been dumdum for putting the dll in the folder. It's at least worth a shot, I guess. 😩

stone elm Feb 28, 2021, 5:17 AM

#

Okay, just posting since it seems appropriate to share the solution. I took a note out of SereCore's book and edited the mod I'm touching to resolve newtonsoft references to the game assembly, thus resolving the types.

proven cipher Feb 28, 2021, 10:13 AM

#

Does anybody know where the SereCore GitHub is? (Assuming there is one)

steady comet Feb 28, 2021, 10:42 AM

#

proven cipher Does anybody know where the SereCore GitHub is? (Assuming there is one)

I think it’s here https://github.com/seresharp/HollowKnight.SereCore

GitHub

seresharp/HollowKnight.SereCore

Contribute to seresharp/HollowKnight.SereCore development by creating an account on GitHub.

jolly oriole Feb 28, 2021, 1:01 PM

#

wrong chat?

#

sir, this is #archived-modding-development , #off-topic is that way

copper nacelle Feb 28, 2021, 1:04 PM

#

that's true

#

idk how you being Brazilian is of relevance

ornate rivet Feb 28, 2021, 1:09 PM

#

well gradow is Brazilian and he is god so clearly Pedrito is a follower

vocal spire Feb 28, 2021, 1:13 PM

#

zote

potent dirge Feb 28, 2021, 6:46 PM

#

is there even a single good way to set dependencies without having to screw up your csproj anyway MaggotPrime

jolly oriole Feb 28, 2021, 6:47 PM

#

change the csproj file by hand

#

i'll just take a guess and say that is for hk 1.5?

potent dirge Feb 28, 2021, 6:48 PM

#

nah its just yuri's timer mod thingy

#

but setting up these is always a hassle

jolly oriole Feb 28, 2021, 6:48 PM

#

kinda true

stone elm Feb 28, 2021, 6:50 PM

#

Put them in a DLL folder in the solution. DO NOT check in the DLLs. Then any new dev can copy their own DLLs into the folder and they auto-reference

#

Then you don't have to mess around with proj files more than the one time to reference the ones in the folder

jolly oriole Feb 28, 2021, 6:51 PM

#

yea, this is also the way modding api does it

copper nacelle Feb 28, 2021, 6:53 PM

#

I have them in a folder like one subdir back

potent dirge Feb 28, 2021, 6:56 PM

#

relative paths wooo

stone elm Feb 28, 2021, 6:59 PM

#

Just gotta be sure anyone loading the project is aware to set up the folders too. (If you used a path outside of the solution entirely.)