#archived-modding-development | Hollow Knight | Page 501

copper nacelle Feb 15, 2021, 8:00 PM

#

I can fix that

worn eagle Feb 15, 2021, 8:01 PM

#

does modifying an instantiated transform change the source transform

jolly oriole Feb 15, 2021, 8:02 PM

#

btw, you don't need to mind my pr rn, fixing a few more thing, then maybe close the pr, reset my fork and doing the changes again

worn eagle Feb 15, 2021, 8:03 PM

#

nvm

worn eagle Feb 15, 2021, 8:40 PM

#

does this seem like an okay ui?

📎 2021-02-15_15-39-35.mp4

#

oh good ol trial version

#

I'm uninstalling ivcam

jolly oriole Feb 15, 2021, 8:43 PM

#

just use obs for recording

#

but otherwise it looks nice

copper nacelle Feb 15, 2021, 8:44 PM

#

wtf

#

looks hot

worn eagle Feb 15, 2021, 8:46 PM

#

I am using obs, I think my audio settings were set weird somewhere

ornate rivet Feb 15, 2021, 8:49 PM

#

looks amazing

jolly oriole Feb 15, 2021, 9:16 PM

#

@vocal spire is there e repo for lifeblood master?

vocal spire Feb 15, 2021, 9:23 PM

#

source is lost to time

#

also no

vocal spire Feb 15, 2021, 9:25 PM

#

vocal spire source is lost to time

well it's somewhere. if I'm going to put in effort into finding it is a different question with a similar answer

copper nacelle Feb 15, 2021, 9:26 PM

#

local man does not comply with gpl

vocal spire Feb 15, 2021, 9:30 PM

#

?

jolly oriole Feb 15, 2021, 9:31 PM

#

gpl? isn't modding api mit?

copper nacelle Feb 15, 2021, 9:31 PM

#

pretty sure lbm had fsmutil

jolly oriole Feb 15, 2021, 9:31 PM

#

oh

#

well it has ModCommon so ig

copper nacelle Feb 15, 2021, 9:32 PM

#

oh yeah modcommon is a thing

#

should probably be lgpl or something considering modcommon is mit

vocal spire Feb 15, 2021, 9:34 PM

#

🤔

#

dnspy editing time

#

epic music begin now

#

also I had copied fsmutil from some other boss mod

#

you know, the good thing about specifically editing lifeblood master in dnspy is I was too dumb at the time to use GetAction, it's all copying states and changing transitions

copper nacelle Feb 15, 2021, 9:42 PM

#

in dnspy

#

why

vocal spire Feb 15, 2021, 9:43 PM

#

because I lost the source

#

and I don't want to look for it zote

jolly oriole Feb 15, 2021, 9:52 PM

#

bruh

ornate rivet Feb 15, 2021, 9:52 PM

#

time to sue him

jolly oriole Feb 15, 2021, 9:53 PM

#

kick him out of pale court

vocal spire Feb 15, 2021, 9:54 PM

#

🤔

copper nacelle Feb 15, 2021, 9:54 PM

#

now hold on that's just losing labor

vocal spire Feb 15, 2021, 9:54 PM

#

kicking the only other playmaker person out

jolly oriole Feb 15, 2021, 9:55 PM

#

oh fuck yea, there was something

ornate rivet Feb 15, 2021, 9:56 PM

#

redfrog pretends he lost the source but in reality lifebloodmaster's dll is malicious and he's desperately trying to hide it

vocal spire Feb 15, 2021, 9:56 PM

#

~~🤔 how did u know~~

ornate rivet Feb 15, 2021, 9:56 PM

#

it's true

jolly oriole Feb 15, 2021, 9:58 PM

#

the true malicious thing to do is to somehow make a c/c++ dll do all the work in a mod, that the c# dll only loads the c/c++ one and nothing else

#

so no one can read what the mod does

vocal spire Feb 15, 2021, 9:58 PM

#

I can't find a emoji that fits

#

this is a tragedy

worn eagle Feb 15, 2021, 9:59 PM

#

just use thinking for the 147th time

vocal spire Feb 15, 2021, 9:59 PM

#

ok

#

🤔

#

thank you for keeping track

leaden hedge Feb 15, 2021, 9:59 PM

#

program it in playmakerfsm

#

but change the name of every fsm action to be random garbage

vocal spire Feb 15, 2021, 9:59 PM

#

lol

leaden hedge Feb 15, 2021, 9:59 PM

#

and have one action per line of code

vocal spire Feb 15, 2021, 10:00 PM

#

that's the greatest idea ever

#

anyway when doing that lm fails to load

#

time to recreate the code I guess

#

then I can get back to finishing a terraria mod

#

so I can get back to finishing a among us mod

#

so I can get back to finishing pale court

copper nacelle Feb 15, 2021, 10:02 PM

#

why are you recreating it

vocal spire Feb 15, 2021, 10:02 PM

#

¯_(ツ)_/¯

copper nacelle Feb 15, 2021, 10:02 PM

#

dnspy has a save as solution button you know

vocal spire Feb 15, 2021, 10:02 PM

#

yeah

#

was gonna mention I might use that

copper nacelle Feb 15, 2021, 10:03 PM

#

it's good

#

I used it for moresaves

vocal spire Feb 15, 2021, 10:03 PM

#

nice

jolly oriole Feb 15, 2021, 10:03 PM

#

but things like const values and bool flags (fuck those honestly) have to be corrected

vocal spire Feb 15, 2021, 10:04 PM

#

F

copper nacelle Feb 15, 2021, 10:05 PM

#

I mean they're not wrong they're just inlined

jolly oriole Feb 15, 2021, 10:05 PM

#

yea but they look ugly

vocal spire Feb 15, 2021, 10:06 PM

#

I probably didn't use any consts

jolly oriole Feb 15, 2021, 10:09 PM

#

ah yes

📎 unknown.png

vocal spire Feb 15, 2021, 10:09 PM

#

~~oh no, my bad code is on discord~~

#

proves how bad my 3rd mod was

jolly oriole Feb 15, 2021, 10:10 PM

#

i'm still working on my 1st one though

vocal spire Feb 15, 2021, 10:10 PM

#

F

#

my first one was worse than that abomination. it was dream shield coop updated. Scary stuff..... i keep wanting to update it, but just no

#

also when you upload code to github, does the spacing ever just go weird

copper nacelle Feb 15, 2021, 10:11 PM

#

tabs become 8 spaces in length on github

#

that's why you don't use tabs

#

😤

vocal spire Feb 15, 2021, 10:12 PM

#

huh

#

would that explain https://github.com/RedFrog6002/LifeFruitCore/blob/main/LifeFruitCore.cs

GitHub

RedFrog6002/LifeFruitCore

A mod for terraria that adds an easy way for other mods to change the health UI colors and textures - RedFrog6002/LifeFruitCore

jolly oriole Feb 15, 2021, 10:12 PM

#

ctrl+f "\t", replace with " "

vocal spire Feb 15, 2021, 10:12 PM

#

ok

#

well now I have lm source again shroompog

#

📎 LifebloodMaster.dll

heavy patrol Feb 15, 2021, 10:42 PM

#

worn eagle does this seem like an okay ui?

This honestly looks like something that would be in the original game. I think you did perfect!

#

And this is coming from someone who just started playing last week haha

jolly oriole Feb 15, 2021, 10:51 PM

#

CustomKnight but with music????

📎 2021-02-15_23-48-17.mp4

valid kiln Feb 15, 2021, 10:53 PM

#

wait thats actually amazing

warm yew Feb 15, 2021, 10:54 PM

#

truly magnificent

deep wave Feb 15, 2021, 11:32 PM

#

suggestions on what to add (currently just thinking modlog & output_log)

📎 unknown.png

jolly oriole Feb 15, 2021, 11:34 PM

#

list of mods in the mods folder

vocal spire Feb 15, 2021, 11:43 PM

#

search bar for mods
having a way to search mods by a specific person
~~3. taking more inspiration from t mod loader~~

deep wave Feb 15, 2021, 11:45 PM

#

~~me not knowing what tmodloader even looks like~~

empty ridge Feb 16, 2021, 2:41 AM

#

hiiii again. i followed the tutorials on the apidocs and i kind of understand things a little better now. i'm able to make a little custom scene and import it as an assetbundle. how could i make it so that it plays my own bgm when i enter the scene?

#

sorry this must seem pretty basic 😞

copper nacelle Feb 16, 2021, 2:46 AM

#

you can create a gameobject and put an audiosource on it

empty ridge Feb 16, 2021, 2:47 AM

#

does it output to the audiomixer by default?

copper nacelle Feb 16, 2021, 2:48 AM

#

you can just set the volume to use like GameManager's audio level

#

there's a method

#

idr the exact name

empty ridge Feb 16, 2021, 2:54 AM

#

oh dang the music wasnt playing because i forgot to build the scene 😅

floral furnace Feb 16, 2021, 2:54 AM

#

GameManager.instance.GetImplicitCinematicVolume()

copper nacelle Feb 16, 2021, 2:54 AM

#

yeah but / 100f

#

iirc

#

might've been /10f

floral furnace Feb 16, 2021, 2:54 AM

#

oh wait are you supposed to divide it further

#

i just took the value directly and played it at that volume 🥴

copper nacelle Feb 16, 2021, 2:58 AM

#

maybe you don't have to

#

it is divided by 10 already in the method

#

i thought i did

#

oh well

empty ridge Feb 16, 2021, 3:18 AM

#

worked like a charm, thanks!

copper nacelle Feb 16, 2021, 3:18 AM

#

np

merry lotus Feb 16, 2021, 3:36 AM

#

So I've been thinking about slowly learning to mod the game, and I just wanted to double check a couple of things:

Are there any "recommended" ways to start learning it?
I already have https://radiance.host/apidocs/Getting-Started.html#creating-mods bookmarked
There's a few pinned messages about using specific versions of Unity, but they specifically reference various asset things (the most recent one from two years ago, says to use Unity 2017.4.10f1). Is this specifically for adding assets to the game, or do I need to change to that version before doing anything?
(The version of Unity I currently have installed looks to be Unity 2018.4.12f1; so I want to know if I need to change that before I start looking at existing mods).

copper nacelle Feb 16, 2021, 3:39 AM

#

that's just for asset bundles

#

don't need unity for anything else

floral furnace Feb 16, 2021, 3:39 AM

#

and steal source code

#

its 95% of the mods free real estate

vocal spire Feb 16, 2021, 3:40 AM

#

👍

merry lotus Feb 16, 2021, 4:04 AM

#

My current plans are just to edit some existing mods for personal use, to help with learning how it all works. So, the code will mostly be stolen lol.
If I want to edit elements that are on the menus, do I need to mess with "asset bundles"?

#

And so, if I'm not doing things with asset bundles, does that mean I don't need to use Unity at all? I can just entirely use IntelliJ? (I know the game uses C# scripts, but I just assumed that I'd somehow need to do something more than just code).

vocal spire Feb 16, 2021, 4:16 AM

#

if you aren't using assetbundles, no unity is required. if you need assetbundles depends on how you want to go about whatever you're doing. sometimes there's a single way, sometimes there are a bunch.

merry lotus Feb 16, 2021, 4:24 AM

#

I don't actually know what asset bundles are. Based on the name, I assume that they're assets, like game objects- and I don't plan on adding anything to the game that isn't already in it.

vocal spire Feb 16, 2021, 4:24 AM

#

Yep

copper nacelle Feb 16, 2021, 4:29 AM

#

Yeah, basically entirely new enemies/objects/etc

merry lotus Feb 16, 2021, 4:30 AM

#

Ah. Well that's a huge relief then!

jolly oriole Feb 16, 2021, 7:08 AM

#

empty ridge hiiii again. i followed the tutorials on the apidocs and i kind of understand th...

easiest way t add real BGM: use SFCore

https://github.com/SFGrenade/SFCore/releases/tag/v1.2 sfcoreunity.dll
put that somewhere into your unity project (so it enables you to use monobehaviours in the dll)
make GO with a collider2d trigger at the entrance of your scene
add a PatchMusicRegions behaviour on it (from sfcore)
for better functionality, also add https://raw.githubusercontent.com/SFGrenade/ModdingHelper/master/Unity Scripts/Editor/PatchMusicRegionsEditor.cs to the Editor subfolder in the assets folder
adjust values as needed

copper nacelle Feb 16, 2021, 7:32 AM

#

still no license x5fiftPrime

jolly oriole Feb 16, 2021, 7:36 AM

#

added mit to sfcore, happy now?

copper nacelle Feb 16, 2021, 7:40 AM

#

I'm never happy

#

but that is nice thank you

jolly oriole Feb 16, 2021, 7:40 AM

#

np

empty ridge Feb 16, 2021, 8:37 AM

#

ok so i got most of that right when i tried to use it earlier

#

im guessing i just didnt set some attribute right cuz id enter the collider and the music would just cut out entirely

#

glad to know im not a complete idiot zote thx for the help, i need to sleep now

jolly oriole Feb 16, 2021, 8:53 AM

#

gn!

jolly jungle Feb 16, 2021, 12:20 PM

#

Aight anyone knows why my mod doesn't appear in the topleft

jolly oriole Feb 16, 2021, 12:20 PM

#

technically, every mod dll that has a class derived by Mod should appear in the top left

#

do you have a github repo with that mod so i could take a look at it?

jolly jungle Feb 16, 2021, 12:21 PM

#

It did, when I started development

#

Then it just disappeared

#

Uh, nop

#

nope

#

I didn't start using github

#

yet

#

I mean to

#

Eventually

marble hollow Feb 16, 2021, 12:22 PM

#

im running out of ideas

jolly oriole Feb 16, 2021, 12:22 PM

#

yea ok, do you have a GetVersion method in the mod class?

marble hollow Feb 16, 2021, 12:22 PM

#

for my customknight

jolly oriole Feb 16, 2021, 12:22 PM

#

marble hollow im running out of ideas

oh no, why

jolly jungle Feb 16, 2021, 12:22 PM

#

jolly oriole yea ok, do you have a `GetVersion` method in the mod class?

Yep, yep

jolly jungle Feb 16, 2021, 12:22 PM

#

marble hollow im running out of ideas

Move onto charms shroompog

jolly oriole Feb 16, 2021, 12:22 PM

#

does it crash/throw an exception?

jolly jungle Feb 16, 2021, 12:22 PM

#

Nope, not at all

#

It simply doesn't

jolly oriole Feb 16, 2021, 12:23 PM

#

can you show the top left corner?

jolly jungle Feb 16, 2021, 12:23 PM

#

Wait I gtg I'll be back in a minute

#

yeah

#

📎 unknown.png

#

Anyhow brb

jolly oriole Feb 16, 2021, 12:28 PM

#

~~can you give the namespace / name of the mod?~~

#

~~it's possible that your mod isn't displayed if a mod loaded after it has the same namespace~~

jolly jungle Feb 16, 2021, 12:29 PM

#

Wdym namespace?

jolly oriole Feb 16, 2021, 12:29 PM

#

nvm, didn't read

jolly jungle Feb 16, 2021, 12:29 PM

#

Also I'm back btw || zotewheeze ||

jolly oriole Feb 16, 2021, 12:30 PM

#

but can you give your modlog / output_log?

jolly jungle Feb 16, 2021, 12:30 PM

#

Oh shit you're right

#

I ahven't checked that in ages

#

And after that it only prints out language keys/strings cuz I hadn't turned that off and I probably should

📎 unknown.png

jolly oriole Feb 16, 2021, 12:34 PM

#

then probably in output log

jolly jungle Feb 16, 2021, 12:36 PM

#

Should I just send the file?

jolly oriole Feb 16, 2021, 12:36 PM

#

yea

#

hm, idk what is wrong then

jolly jungle Feb 16, 2021, 12:41 PM

#

shadecry

#

Oh well

#

Seems like people will just need to forget the presence of the mod tamershrug

ornate rivet Feb 16, 2021, 1:30 PM

#

how come increasing the scenewidth on the cameracontroller doesnt fix the camera from not following you

jolly oriole Feb 16, 2021, 1:32 PM

#

cameracontroller has scenewidth?

ornate rivet Feb 16, 2021, 1:32 PM

#

GameCameras.instance.cameraController.sceneWidth

jolly oriole Feb 16, 2021, 1:32 PM

#

i just change GameManager.tilemap.width and GameManager.sceneWidth

ornate rivet Feb 16, 2021, 1:32 PM

#

that makes more sense

jolly oriole Feb 16, 2021, 1:33 PM

#

and FindObjectOfType<GameMap>().SetManualTilemap(0, 0, width, height);

#

and all that in a On.GameManager.RefreshTilemapInfo

ornate rivet Feb 16, 2021, 1:39 PM

#

hmm the camera still won't follow past the same spot

#

oh wait

#

yea

#

the camera still stops following at 160,40ish

#

private void GameManagerOnRefreshTilemapInfo(On.GameManager.orig_RefreshTilemapInfo orig, GameManager self, string targetscene)
{
    if (targetscene == DryyaScene)
    {
        Log($"wid {GameManager.instance.sceneWidth} and heigh {GameManager.instance.sceneHeight}");
        self.sceneWidth = 500;
        self.sceneHeight = 500;
        Log($"Tiled wid {self.tilemap.width} height {self.tilemap.height}");
        self.tilemap.width = 500;
        self.tilemap.height = 500;
        FindObjectOfType<GameMap>().SetManualTilemap(0, 0, 500, 500);
    }
    orig(self, targetscene);
}

jolly oriole Feb 16, 2021, 1:42 PM

#

after orig

#

in orig it sets width

ornate rivet Feb 16, 2021, 1:42 PM

#

huh so orig doesnt use the value in gamemanager?

jolly oriole Feb 16, 2021, 1:42 PM

#

like https://github.com/SFGrenade/TestOfTeamwork/blob/master/SceneChanger.cs#L104

ornate rivet Feb 16, 2021, 1:43 PM

#

alright thanks

jolly oriole Feb 16, 2021, 1:43 PM

#

np

worn eagle Feb 16, 2021, 2:50 PM

#

is there any reason the unityexplorer ui won't show up on start?

copper nacelle Feb 16, 2021, 2:59 PM

#

do you have all 3 of the dlls

worn eagle Feb 16, 2021, 3:05 PM

#

I do

#

it was working before, it stopped showing up while I was toying around with the main menu

heavy patrol Feb 16, 2021, 5:31 PM

#

Are there any good examples of how Source codes of mods should be uploaded to git hub?

vocal spire Feb 16, 2021, 5:33 PM

#

There really isn’t a good example since all of them are basically the same

heavy patrol Feb 16, 2021, 5:42 PM

#

Fair enough

worn eagle Feb 16, 2021, 5:47 PM

#

idk why Create Game is cut off but here's some progress

📎 2021-02-16_12-44-47.mp4

#

dreading implementing the mitm server

deep wave Feb 16, 2021, 5:58 PM

#

what exactly changed in newest moddingAPI that appears to have broken everything? and is it worth rolling back the version on installer vesselsip

vocal spire Feb 16, 2021, 5:59 PM

#

Time to go look at GitHub!

jolly jungle Feb 16, 2021, 6:00 PM

#

and is it worth rolling back the version on installer :vesselsip:
Probably, for now

leaden hedge Feb 16, 2021, 6:00 PM

#

how exactly is it broken

vocal spire Feb 16, 2021, 6:01 PM

#

Failed to load stuff

#

Could the problem be with globalsettings

📎 image0.png

copper nacelle Feb 16, 2021, 6:03 PM

#

this is so non descriptive

leaden hedge Feb 16, 2021, 6:03 PM

#

it works for me, with just debug mod installed

deep wave Feb 16, 2021, 6:10 PM

#

yeah but certain mods like hollow twitch refuse to load

vocal spire Feb 16, 2021, 6:15 PM

#

Got a modlog?

jolly oriole Feb 16, 2021, 6:19 PM

#

the thing with decomaster: it initializes its own json thing, with its own settings and still somehow fails

vocal spire Feb 16, 2021, 6:20 PM

#

Huh

jolly oriole Feb 16, 2021, 6:21 PM

#

https://github.com/a2659802/HollowKnight.Decoration/blob/master/DecorationMaster.cs#L39 calls https://github.com/a2659802/HollowKnight.Decoration/blob/master/Util/SerializeHelper.cs#L80 which uses a simple JsonConvert.DeserializeObject at https://github.com/a2659802/HollowKnight.Decoration/blob/master/Util/SerializeHelper.cs#L98

copper nacelle Feb 16, 2021, 6:28 PM

#

🤔

📎 unknown.png

jolly oriole Feb 16, 2021, 6:30 PM

#

imma test every commit from the globalsettings one onwards to check which one decomaster can't handle

copper nacelle Feb 16, 2021, 6:30 PM

#

any git bisect

#

this guy

jolly oriole Feb 16, 2021, 6:32 PM

#

don't worry, i know what i'm doing

copper nacelle Feb 16, 2021, 6:32 PM

#

uh huh

📎 unknown.png

jolly oriole Feb 16, 2021, 6:33 PM

#

https://github.com/seresharp/HollowKnight.Modding/commit/cfc33db275611be1bf7f5d99831a9760ff78f9ec apparently breaks deco master

copper nacelle Feb 16, 2021, 6:35 PM

#

why'd you even move the actual add component

jolly oriole Feb 16, 2021, 6:39 PM

#

because decomaster somehow crashes with the dictionary it preloaded

#

and this <#archived-modding-development message>

copper nacelle Feb 16, 2021, 6:43 PM

#

all my homies do not need to hook gamemanager.awake

jolly oriole Feb 16, 2021, 6:44 PM

#

but gamemanager also doesn't do shit until main menu is loaded

#

as it doesn't exist at that point

copper nacelle Feb 16, 2021, 6:45 PM

#

and

#

i don't get it

#

how terrible

worn eagle Feb 16, 2021, 6:58 PM

#

are there under 255 gameplay scenes in the game

jolly oriole Feb 16, 2021, 7:01 PM

#

there are nearly 500 total ones, so i doubt it would be under 255 gameplay ones, especially with mods

#

but the decomaster error is really weird, as it's a KeyNotFoundException:

[INFO]:[DecorationMaster] - Loaded Json
[ERROR]:[API] - Error: System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
[ERROR]:[API] -   at System.Collections.Generic.Dictionary`2[System.String,System.Collections.Generic.Dictionary`2[System.String,UnityEngine.GameObject]].get_Item (System.String key) [0x00000] in <filename unknown>:0 
[ERROR]:[API] -   at DecorationMaster.ObjectLoader.Load (System.Collections.Generic.Dictionary`2 preloadedObjects) [0x00000] in <filename unknown>:0 
[ERROR]:[API] -   at DecorationMaster.DecorationMaster.Initialize (System.Collections.Generic.Dictionary`2 preloadedObjects) [0x00000] in <filename unknown>:0 
[ERROR]:[API] -   at Modding.ModLoader.LoadMod (IMod mod, Boolean updateModText, Boolean changeSettings, System.Collections.Generic.Dictionary`2 preloadedObjects) [0x00000] in <filename unknown>:0 
[ERROR]:[API] -   at Modding.ModLoader+<LoadMods>d__10.MoveNext () [0x00000] in <filename unknown>:0

#

hm :/

[WARN]:[API] - Could not find object "Zote Death/Head" in scene "Fungus1_20_v02", requested by mod "DecorationMaster"

worn eagle Feb 16, 2021, 7:06 PM

#

damn now I have to send one more byte each time a scene changes 😩

worn eagle Feb 16, 2021, 7:26 PM

#

would it be wise to create a pool of player objects instead of instantiating one every time a player enters the same scene as you to prevent microstutters?

jolly oriole Feb 16, 2021, 8:14 PM

#

something in the decorationmaster preloads for some reasong depends on gamemanager so hard that it stops existing completely if gamemanager isn't there

#

wait wut

Fallback handler could not load library E:/GOG/Hollow Knight Manhunt/hollow_knight_Data/Mono/data-A84A4010.dll

jolly oriole Feb 16, 2021, 8:16 PM

#

worn eagle would it be wise to create a pool of player objects instead of instantiating one...

probably a good idea, with a start amount of the current amount of players on the server

#

simple moving of the modloading point to the previous point gives audio stuff

📎 2021-02-16_21-18-27.mp4

vocal spire Feb 16, 2021, 8:35 PM

#

👍

sage holly Feb 16, 2021, 9:06 PM

#

when assetbundling, is there a way to keep the shadders out of the bundle?

#

please ping me when answering

jolly oriole Feb 16, 2021, 9:09 PM

#

@sage holly according to https://docs.unity3d.com/Manual/AssetBundles-Browser.html, you can right click assets (or hit DEL on them) to remove them from bundles

sage holly Feb 16, 2021, 9:10 PM

#

is that safe to do? then I'll do that

jolly oriole Feb 16, 2021, 9:11 PM

#

i have never tested it (i personally don't use assetbundle browser), but according to unity's website it should be safe

sage holly Feb 16, 2021, 9:12 PM

#

ok

leaden hedge Feb 16, 2021, 9:51 PM

#

no

#

also wrong channel

empty ridge Feb 16, 2021, 10:20 PM

#

why is it that when i put my scene into the asset bundle browser, it wont let me put an audio clip in with it?

jolly oriole Feb 16, 2021, 10:21 PM

#

a bundle can either have scenes or assets in it

#

not both at the same time

empty ridge Feb 16, 2021, 10:23 PM

#

how come?

jolly oriole Feb 16, 2021, 10:23 PM

#

unity

empty ridge Feb 16, 2021, 10:23 PM

#

so its for some godly reason i couldnt comprehend

#

got it

jolly oriole Feb 16, 2021, 10:24 PM

#

i also don't know why, but unity says so

empty ridge Feb 16, 2021, 10:25 PM

#

huh

vocal spire Feb 16, 2021, 11:48 PM

#

No

#

Well

#

I could

#

But I won’t

#

That’s doable by save editing

gilded lotus Feb 16, 2021, 11:49 PM

#

keep modding ideas to #modding-discussion

hardy stump Feb 17, 2021, 12:13 AM

#

is there an existing hook that triggers on parry and maybe exposes the enemy you just parried?

#

and related to this, where is parry damage calculated and processed?

prime urchin Feb 17, 2021, 1:17 AM

#

Is it possible to preload an object which is loaded by a scene but not technically part of it? For reference I'm attempting to get "GG_Challenge_Door_Canvas" which is loaded with the GG_Atrium scene but isn't part of the scene's object hierarchy. I can probably do it manually but I'm wondering if there's a better way.

dark wigeon Feb 17, 2021, 1:27 AM

#

I think you just have to get those by reference since they don't exist in the scene to GameObject.Find

#

search shows GG_Challenge_Door (4)/Door/Unlocked Set/Inspect, Challenge UI fsm -> Open UI state -> first GameObject param to get a ref to that

#

maybe there's an easier way but that's usually what I do

prime urchin Feb 17, 2021, 1:34 AM

#

Well, when I'm in the scene I can access it via Resources.FindObjectsOfTypeAll<GameObject>() but it seems that the current preload method just checks the objects within the scene, so I'd have to preload the scene myself to do it this way. I'll see about getting it by reference as you said.

ornate rivet Feb 17, 2021, 2:23 AM

#

I've asked this question a thousand times and yet I never remember the answer but
What do I do if the player isn't taking input until I go to the pause menu once

#

I've tried RegainControl

vocal spire Feb 17, 2021, 2:33 AM

#

What changes when the player unpauses

vocal spire Feb 17, 2021, 2:34 AM

#

prime urchin Well, when I'm in the scene I can access it via `Resources.FindObjectsOfTypeAll<...

Preload the object the fsm is on and get it from the fsm

prime urchin Feb 17, 2021, 2:35 AM

#

Yeah, that works - better than what I was going to do otherwise anyway, hah

worn eagle Feb 17, 2021, 3:31 AM

#

is there a way to get your public ip address in c#? I've just been creating a web request to a site that gives it to you and parsed the response

copper nacelle Feb 17, 2021, 3:44 AM

#

that is the way

#

checkip.dyndns.org or something

#

or icanhazip.com

#

https://superuser.com/questions/1371963/is-it-possible-to-see-my-external-ip-address-without-making-an-outbound-web-requ

Super User

Is it possible to see my external IP address without making an outb...

If your connection is NAT'ed, is it possible to see your external IP address without making an outbound web request?

Any OS (Windows, Linux, etc.) is fine.

#

Every other thing seems far more inconvenient

prime urchin Feb 17, 2021, 3:48 AM

#

https://www.ipify.org/ exists and can output both IPv4 and IPv6 (optionally in json if you really want)

ipify - A Simple Public IP Address API

ipify API is a simple public IP address API, easy enough to integrate into any application in seconds.

copper nacelle Feb 17, 2021, 3:51 AM

#

that's nice

worn eagle Feb 17, 2021, 3:23 PM

#

what could cause this?

📎 unknown.png

#

apparently I triggered a breakpoint in kernelbase.dll

vocal spire Feb 17, 2021, 3:46 PM

#

I love unknown crashes too, since for some reason doing a foreach with all the doors on a map in among us to close all of them decides to crash

copper nacelle Feb 17, 2021, 3:47 PM

#

oom

worn eagle Feb 17, 2021, 3:48 PM

#

I figured, could profiling hollow_knight.exe with rider find anything?

copper nacelle Feb 17, 2021, 3:49 PM

#

no idea

jolly oriole Feb 17, 2021, 4:11 PM

#

worn eagle what could cause this?

according to 2 unknowing people on the unity forums from 2018, that may be the place where hk needs more than ~3.5 GB of memory

copper nacelle Feb 17, 2021, 5:38 PM

#

📎 unknown.png

lean ledge Feb 17, 2021, 5:41 PM

#

what happened there

copper nacelle Feb 17, 2021, 5:41 PM

#

📎 unknown.png

lean ledge Feb 17, 2021, 5:41 PM

#

hollow knight tilt controls

copper nacelle Feb 17, 2021, 5:42 PM

#

📎 unknown.png

ornate rivet Feb 17, 2021, 6:29 PM

#

📎 unknown.png

#

that moment when the l isn't capitalized

jolly oriole Feb 17, 2021, 6:30 PM

#

but the I is capitalized

ornate rivet Feb 17, 2021, 6:31 PM

#

wtf it still spawned left

leaden hedge Feb 17, 2021, 6:31 PM

#

Hirungolwe L Saleh L

jolly oriole Feb 17, 2021, 6:31 PM

#

which fsm is that even?

ornate rivet Feb 17, 2021, 6:31 PM

#

Dream Entry-Control

deep wave Feb 17, 2021, 6:32 PM

#

copper nacelle

hk but your big brother gave you the controller but won't let you sit in his gamer chair

jolly oriole Feb 17, 2021, 6:34 PM

#

try setting it to true

ornate rivet Feb 17, 2021, 6:35 PM

#

dideth

#

maybe it doesnt start at the right state

jolly oriole Feb 17, 2021, 6:38 PM

#

possible

somber cliff Feb 17, 2021, 6:38 PM

#

In my Start function on Load Scene I am running the following code:

            try
            {
                On.SceneManager.Start += OnSceneManagerStart;
            }
            catch(Exception e)
            {
                Modding.Logger.Log("--------------------------------");
                Modding.Logger.Log("EXCEPTION::::: " + e);
            }

prints: [INFO]:--------------------------------
[INFO]:EXCEPTION::::: System.InvalidCastException: Cannot cast from source type to destination type.

#

Appears to be an issue with version 1.4.3.2-58

#

a friend has version 1.4.3.2-57 and it runs fine on there side.

#

where can i grab the modding api versions to test myself? And does anyone know if anything has changes on the scenemanager start hook?

copper nacelle Feb 17, 2021, 6:39 PM

#

any stack trace

somber cliff Feb 17, 2021, 6:40 PM

#

📎 message.txt

copper nacelle Feb 17, 2021, 6:41 PM

#

suboptimal

#

can i have the dll

somber cliff Feb 17, 2021, 6:42 PM

#

hmmm...

#

can we chat privately...

jolly oriole Feb 17, 2021, 6:43 PM

#

56, have fun with code from the sanctuary

copper nacelle Feb 17, 2021, 6:44 PM

#

incredibly interesting

leaden hedge Feb 17, 2021, 6:44 PM

#

56 will steal your account

#

monkaS

ornate rivet Feb 17, 2021, 6:49 PM

#

wtf I've tried everything and the idiot still spawns on the left side

somber cliff Feb 17, 2021, 6:49 PM

#

jolly oriole 56, have fun with code from the sanctuary

he's signing an nda

ornate rivet Feb 17, 2021, 6:49 PM

#

lmao

jolly oriole Feb 17, 2021, 6:49 PM

#

ornate rivet wtf I've tried everything and the idiot still spawns on the left side

so facing right?

ornate rivet Feb 17, 2021, 6:49 PM

#

facing left

jolly oriole Feb 17, 2021, 6:49 PM

#

hm

ornate rivet Feb 17, 2021, 6:50 PM

#

does .faceright not make the knight face right?

jolly oriole Feb 17, 2021, 6:50 PM

#

i just instantiated wp03's dreamenter, which spawn you facing right

ornate rivet Feb 17, 2021, 6:50 PM

#

I'm instantiating WD's which also should just face you right

jolly oriole Feb 17, 2021, 6:50 PM

#

somber cliff he's signing an nda

don't worry, 56 finds a way to shit on your entire codebase

copper nacelle Feb 17, 2021, 6:51 PM

#

i mean if you'd like

ornate rivet Feb 17, 2021, 6:51 PM

#

I would love for 56 to shit on my code

#

he'll fix to too then :)

copper nacelle Feb 17, 2021, 6:51 PM

#

echprime

#

is a uintptr to a long an invalid cast

jolly oriole Feb 17, 2021, 6:53 PM

#

ornate rivet I'm instantiating WD's which also should just face you right

do you have a level id for wd?

#

don't want to open unity rn

#

nvm

#

but you do have a door transitionpoint in the scene, right?

ornate rivet Feb 17, 2021, 6:57 PM

#

door1 yea

#

I guess I'll just manually scale it in the end

jolly oriole Feb 17, 2021, 6:57 PM

#

with roughly these values?

📎 unknown.png

ornate rivet Feb 17, 2021, 6:58 PM

#

it's the same one the scene uses I think

jolly oriole Feb 17, 2021, 7:00 PM

#

does your transitionpoint have alwaysEnterLeft set?

ornate rivet Feb 17, 2021, 7:01 PM

#

maybe, I'll have to check

#

good thinking

#

you were right :)

#

thank you

#

I forgot this was the scene where mebi forgot to not delete the door1 so I made my own

copper nacelle Feb 17, 2021, 7:07 PM

#

somber cliff Appears to be an issue with version 1.4.3.2-58

resolved

#

-59

somber cliff Feb 17, 2021, 7:07 PM

#

wait what ?

copper nacelle Feb 17, 2021, 7:08 PM

#

api

#

updated

#

fixed

#

etc

somber cliff Feb 17, 2021, 7:08 PM

#

will you have my wifes kids ?

vocal spire Feb 17, 2021, 7:08 PM

#

🤔

copper nacelle Feb 17, 2021, 7:08 PM

#

🥴

steady comet Feb 17, 2021, 8:30 PM

#

Maybe a stupid question but why doesn't Ruins1_30 appear in the scene list in the FSM viewer?

#

Oh wait it is a stupid question, it's there but in the wrong order lmao

#

Don't mind me

jolly oriole Feb 17, 2021, 8:40 PM

#

can https://github.com/Ayugradow/ModInstaller/pull/48 be merged?

safe hamlet Feb 17, 2021, 8:42 PM

#

done

jolly oriole Feb 17, 2021, 8:42 PM

#

thanks!

merry lotus Feb 17, 2021, 8:43 PM

#

api
updated
fixed
etc
Was this update specifically to fix whatever was causing DecoMaster and HollowTwitch to not work? Can I finally delete my macro that posts a link to Zaliant's upload of -57?

Also, is there a place to see changelogs of moddingAPI? I feel like there's a few mods like that that seem to update, but with no mention of what changed, and their github pages don't seem to be up-to-date. (The other that comes to mind is QoL)

jolly oriole Feb 17, 2021, 8:46 PM

#

well, it does still not work with decomaster, but we know what causes it at least, but that change would give audio fragments, similar to how it was before preloading was muted

#

just tested it btw

merry lotus Feb 17, 2021, 8:46 PM

#

ah

jolly oriole Feb 17, 2021, 8:47 PM

#

jolly oriole well, it does still not work with decomaster, but we know what causes it at leas...

we know what causes it
well, to put it in better words, we know how it will load, still no idea why it crashes in detail as that doesn't make sense, but a prototype solution is there

ornate rivet Feb 17, 2021, 8:48 PM

#

public void PlayMusic(AudioClip clip, float vol = 0f)
{
    MusicCue musicCue = ScriptableObject.CreateInstance<MusicCue>();
    List<MusicCue.MusicChannelInfo> channelInfos = new List<MusicCue.MusicChannelInfo>();
    MusicCue.MusicChannelInfo channelInfo = new MusicCue.MusicChannelInfo();
    channelInfo.SetAttr("clip", clip);
    channelInfos.Add(channelInfo);
    musicCue.SetAttr("channelInfos", channelInfos.ToArray());
    GameManager.instance.AudioManager.ApplyMusicCue(musicCue, 0, 0, false);
}

any reason why this wont play my music in the custom scene

#

other sounds work

jolly oriole Feb 17, 2021, 8:50 PM

#

channelinfos has to be MusicCue.MusicChannelInfo[6], all 6 indizes are needed (null values possible)

ornate rivet Feb 17, 2021, 8:51 PM

#

hmm I didnt need to do this before

#

so do I just set the first index and leave the rest null?

jolly oriole Feb 17, 2021, 8:53 PM

#

yes

#

but why do you have a vol parameter if you don't even use it?

ornate rivet Feb 17, 2021, 8:56 PM

#

the old code had it

#

it still doesnt work

jolly oriole Feb 17, 2021, 8:56 PM

#

hm

#

do you have an error in either modlog or output log?

ornate rivet Feb 17, 2021, 8:57 PM

#

nope

#

maybe

#

📎 unknown.png

jolly oriole Feb 17, 2021, 8:58 PM

#

that's not important

ornate rivet Feb 17, 2021, 8:58 PM

#

this is weird, the godhome custom scenes worked just fine

jolly oriole Feb 17, 2021, 8:58 PM

#

can you log what Log($"Snapshot: {musicCue.Snapshot}") logs as a string?

ornate rivet Feb 17, 2021, 8:58 PM

#

probably doing/not doing something dumb

#

ok will do

#

tis null

jolly oriole Feb 17, 2021, 9:02 PM

#

just out of curiosity, which scene do you call that method in?

#

because i think whatever area the method is getting called in, has a audiomixersnapshot loaded which doesn't play the main track

#

and GameManager.instance.AudioManager.ApplyMusicCue for some reason does the same as your volume parameter for the applySnapshot parameter, so your easiest solution is to copy the contents of MusicRegion.FadeIn() (important parts marked)
btw, you get the audiomixersnapshot with the simple line of

var yoursnapshot = Resources.FindObjectsOfTypeAll<AudioMixer>().First(x => x.name == "Music").FindSnapshot("Main Only");

📎 unknown.png

#

@ornate rivet

ornate rivet Feb 17, 2021, 9:12 PM

#

that makes sense

jolly jungle Feb 17, 2021, 9:42 PM

#

Quick, what's the easiest way to rewire a boss's FSM to only use one attack?

jolly oriole Feb 17, 2021, 9:44 PM

#

in the state that makes decisions, manipulate the decision making

#

e.g.

var hkGO = to.Find("Hive Knight");
var hkFsm = hkGO.LocateMyFSM("Control");
var hkFsmVars = hkFsm.FsmVariables;

var srev3_1 = hkFsm.GetAction<SendRandomEventV3>("Phase 1", 1);
srev3_1.events = new FsmEvent[] { FsmEvent.FindEvent("JUMP") };
srev3_1.weights = new FsmFloat[] { 1.0f };
srev3_1.trackingInts = new FsmInt[] { hkFsmVars.FindFsmInt("Ct Jump") };
srev3_1.eventMax = new FsmInt[] { int.MaxValue };
srev3_1.trackingIntsMissed = new FsmInt[] { hkFsmVars.FindFsmInt("Ms Jump") };
srev3_1.missedMax = new FsmInt[] { 4 };

var srev3_2 = hkFsm.GetAction<SendRandomEventV3>("Phase 2", 2);
srev3_2.events = new FsmEvent[] { FsmEvent.FindEvent("JUMP") };
srev3_2.weights = new FsmFloat[] { 1.0f };
srev3_2.trackingInts = new FsmInt[] { hkFsmVars.FindFsmInt("Ct Jump") };
srev3_2.eventMax = new FsmInt[] { int.MaxValue };
srev3_2.trackingIntsMissed = new FsmInt[] { hkFsmVars.FindFsmInt("Ms Jump") };
srev3_2.missedMax = new FsmInt[] { 4 };

var srev3_3 = hkFsm.GetAction<SendRandomEventV3>("Phase 3", 1);
srev3_3.events = new FsmEvent[] { FsmEvent.FindEvent("JUMP") };
srev3_3.weights = new FsmFloat[] { 1.0f };
srev3_3.trackingInts = new FsmInt[] { hkFsmVars.FindFsmInt("Ct Jump") };
srev3_3.eventMax = new FsmInt[] { int.MaxValue };
srev3_3.trackingIntsMissed = new FsmInt[] { hkFsmVars.FindFsmInt("Ms Jump") };
srev3_3.missedMax = new FsmInt[] { 4 };

for ~~hive~~ jump knight

jolly jungle Feb 17, 2021, 9:52 PM

#

Ah, thanks

#

And then just plug in whatever I feel like

#

Thanks

#

Aight I'll need to continue tomorrow I guess

#

Didn't get to try this out yet

#

Thanks though

worn eagle Feb 17, 2021, 11:47 PM

#

is there anything else I need to do to create a pool of any gameobject besides .CreatePool()?

#

when I spawn a pooled object I get this stack trace, even when I add an ActiveRecycler component to it:

System.NullReferenceException: 
[INFO]:  at (wrapper managed-to-native) UnityEngine.GameObject:GetComponentFastPath (System.Type,intptr)
[INFO]:  at UnityEngine.GameObject.GetComponent[ActiveRecycler] () [0x00000] in <filename unknown>:0 
[INFO]:  at ObjectPool.orig_Spawn (UnityEngine.GameObject prefab, UnityEngine.Transform parent, Vector3 position, Quaternion rotation) [0x00000] in <filename unknown>:0 
[INFO]:  at ObjectPool.Spawn (UnityEngine.GameObject prefab, UnityEngine.Transform parent, Vector3 position, Quaternion rotation) [0x00000] in <filename unknown>:0 
[INFO]:  at ObjectPoolExtensions.Spawn (UnityEngine.GameObject prefab, Vector3 position) [0x00000] in <filename unknown>:0

jolly oriole Feb 17, 2021, 11:57 PM

#

ObjectPool.CreatePool(gameobject, 1); doesn't work?

#

oh, .CreatePool() is an extension, idk if it's because that, may be worth testing

#

mhm, shouldn't nullreference

worn eagle Feb 18, 2021, 12:11 AM

#

same issue with regular ObjectPool.Spawn()

jolly oriole Feb 18, 2021, 12:14 AM

#

one workaround i could see is to copy all fields of an existing ActiveRecycler to the custom one

#

and if that doesn't help i'm completely out of ideas

mellow shore Feb 18, 2021, 12:46 AM

#

hey folks, can anyone here help me figure out FSM viewer? (thanks grenade)

#

for the geo rock--what does final payout here mean?

leaden hedge Feb 18, 2021, 12:51 AM

#

see where its read, one of the states will have an intcompare

#

or some other action that reads an int

mellow shore Feb 18, 2021, 12:57 AM

#

ah... i don't know what this means

leaden hedge Feb 18, 2021, 1:11 AM

#

when you click on the boxes, and you have state selected instead of variables

#

it'll list what that box does

#

one of them will do something with final payout

heavy patrol Feb 18, 2021, 3:58 AM

#

Dumb question, how do I replace the Unknown in "MyMod: UKNOWN" where mods are displayed in the menu screen

worn eagle Feb 18, 2021, 4:02 AM

#

override GetVersion

heavy patrol Feb 18, 2021, 4:53 AM

#

Thanks!

jolly oriole Feb 18, 2021, 6:47 AM

#

mellow shore for the geo rock--what does final payout here mean?

Geo per hit * hits + final payout

jolly jungle Feb 18, 2021, 6:48 AM

#

i.e. the amount that drops when it destroys itself?

jolly oriole Feb 18, 2021, 6:50 AM

#

Names of the fsm variables, but yes

heavy patrol Feb 18, 2021, 8:15 AM

#

So I've been trying to write some code relating to FSM's, but I keep running into the issue of "PlaymakerFSM" could not be found, even though I have referenced ModCommon.dll, and used Using ModCommon.Util

#

Is there anything simple I'm missing?

jolly oriole Feb 18, 2021, 8:16 AM

#

reference PlayMaker.dll which is next to the other unity dlls from the game

heavy patrol Feb 18, 2021, 8:18 AM

#

Yes, thank you so much!

jolly oriole Feb 18, 2021, 9:24 AM

#

https://github.com/Ayugradow/ModInstaller/pull/49 that's what i get for putting a .dll link in the modlinks

heavy patrol Feb 18, 2021, 10:44 AM

#

Haha, feels bad

#

At least people can use it now lol

mellow shore Feb 18, 2021, 11:12 AM

#

thanks grenade!

jolly oriole Feb 18, 2021, 11:49 AM

#

Np

ornate rivet Feb 18, 2021, 1:05 PM

#

I'm returning from a custom scene and want to do the whole lying down animation so I was using the knight's "Dream Return" fsm, the animation plays just fine but the knight can be moved around even while they are lying down.

#

The fsm does go through a state that does relinquishctrl so idk why

worn eagle Feb 18, 2021, 1:52 PM

#

If I have a mod that uses vasi that's gpl3 and distribute the dll to a few friends, does that mean i have to make the source public and gpl3 as well?

jolly oriole Feb 18, 2021, 1:57 PM

#

~~(depending on what you need from vasi, you could just use modcommon, which is MIT)~~

copper nacelle Feb 18, 2021, 1:59 PM

#

you're supposed to distribute the source w/ the dll

#

i can change that tbh

#

i don't care

#

mpl is better for a lib

worn eagle Feb 18, 2021, 2:00 PM

#

oops

copper nacelle Feb 18, 2021, 2:00 PM

#

i still do not care do what you want

worn eagle Feb 18, 2021, 2:01 PM

#

and muh modcommon bloat

copper nacelle Feb 18, 2021, 2:02 PM

#

modcommon's fsmutil is like 80 versions behind but it's a breaking change so i won't touch it

ornate rivet Feb 18, 2021, 2:02 PM

#

rip I still use it

jolly oriole Feb 18, 2021, 2:03 PM

#

that's the thing with fsm.GetAction<T>(...), right?

copper nacelle Feb 18, 2021, 2:03 PM

#

yeah

jolly oriole Feb 18, 2021, 2:04 PM

#

then i also use that

copper nacelle Feb 18, 2021, 2:04 PM

#

i'm sorry for your loss

#

like this

#

resizes the array bigger

ornate rivet Feb 18, 2021, 2:06 PM

#

lmao

floral furnace Feb 18, 2021, 2:19 PM

#

if u read the .net docs ur lame

jolly oriole Feb 18, 2021, 2:28 PM

#

neat

copper nacelle Feb 18, 2021, 2:32 PM

#

as 🥶

jolly oriole Feb 18, 2021, 2:32 PM

#

or do you want the old c style cast?

#

according to https://stackoverflow.com/a/4926702 i'm going to change that to old c style casts

copper nacelle Feb 18, 2021, 2:33 PM

#

idk what you're doing

#

but as won't throw and you'll nre yeah

jolly oriole Feb 18, 2021, 2:35 PM

#

i'm not that much into code conventions: with a cast, is a space between the bracket and the orig value after ok? vs removes that automatically so i'm unsure

copper nacelle Feb 18, 2021, 2:36 PM

#

i do (Type) thing

#

preference

worn eagle Feb 18, 2021, 2:37 PM

#

same

copper nacelle Feb 18, 2021, 2:40 PM

#

i made vasi mplv2 now btw

worn eagle Feb 18, 2021, 2:40 PM

#

noice

jolly oriole Feb 18, 2021, 3:02 PM

#

jolly oriole neat

making it part of sfcore, just so i don't have to copy the file into every mod

copper nacelle Feb 18, 2021, 3:03 PM

#

another version frogchamp

jolly oriole Feb 18, 2021, 3:04 PM

#

nah, gonna pump every util i ever used in my mods in it before opening yet another pr

jolly jungle Feb 18, 2021, 3:05 PM

#

Why are they called Cores?

copper nacelle Feb 18, 2021, 3:05 PM

#

no i mean another fork of fsmutil

jolly oriole Feb 18, 2021, 3:05 PM

#

oh

#

oh right, there was a bit of fsmutil in the api, right?

#

hm, i thought i saw something like that

copper nacelle Feb 18, 2021, 3:07 PM

#

no

jolly oriole Feb 18, 2021, 3:07 PM

#

but then i can also have stuff like gameobject.FindGameObjectInChildren("name")

jolly oriole Feb 18, 2021, 3:08 PM

#

jolly jungle Why are they called Cores?

stole the naming scheme from other hk mods (like the predecesor of serecore) and several minecraft mods which also ended in "core"

ornate rivet Feb 18, 2021, 3:13 PM

#

core because it's a core mod, important for other mods

leaden hedge Feb 18, 2021, 3:15 PM

#

imagine calling anything descriptive

#

if i made a utility mod for my code, i'd probably call it code.dll Kappa

ornate rivet Feb 18, 2021, 3:16 PM

#

best name tbh

jolly oriole Feb 18, 2021, 3:16 PM

#

mod: mod.dll
core mod: core.dll
other mod: code.dll
other core mod: helper.dll

#

and every last piece of content in those is obfuscated to hell and back

worn eagle Feb 18, 2021, 3:17 PM

#

what happens if two mods share the same name

leaden hedge Feb 18, 2021, 3:18 PM

#

apparently i don't even need to obfuscate, canvasutil is black magic according to some Kappa

#

if the name before : Mod is the same

jolly oriole Feb 18, 2021, 3:18 PM

#

file name: impossible, windows/modinstaller will overwrite the first one with the second
namespace: works fine as long as classname is different
namespace & class name: typename error i think

leaden hedge Feb 18, 2021, 3:19 PM

#

then one of them doesn't load

#

might be both dont load

worn eagle Feb 18, 2021, 3:20 PM

#

canvasutil has been pretty useful

#

would be better if you could set fadein and fadeout speed to match that of qol but you couldn't have known that it would've existed ahead of time shermaU

stone elm Feb 18, 2021, 4:13 PM

#

Is the rando logic documented somewhere? I know it's in the mod repo in XML, I was just looking for any sort of primer to help me understand any semantics there. Is my only course of action to look at the code and semi-reverse-engineer it?

steady comet Feb 18, 2021, 4:32 PM

#

stone elm Is the rando logic documented somewhere? I know it's in the mod repo in XML, I w...

What do you mean? I don't think it's documented anywhere, but if you've seen https://github.com/homothetyhk/HollowKnight.RandomizerMod/tree/master/RandomizerMod3.0/Resources then it's fairly self explanatory (item rando uses macros.xml, waypoints.xml and items.xml; area rando also uses areas.xml for area transitions; room rando uses macros.xml, rooms.xml for transitions and items.xml)

stone elm Feb 18, 2021, 4:35 PM

#

I disagree on "it's fairly self-explanatory". I can grok a lot of it by looking at it but the actual meaning of the elements isn't noted anywhere. I know the code deserializes the XML and I could try to use that as context, that's what I mean by 'semi-reverse-engineer'. For example: what does the action element mean here? https://github.com/homothetyhk/HollowKnight.RandomizerMod/blob/master/RandomizerMod3.0/Resources/items.xml#L11

What about areaLogic vs. itemLogic? Why are they the same, what could they mean?

I'm not asking for direct answers to my questions, just wondering if there's some place in which they have already been answered that I can refer to. Otherwise I'll just put in the time and effort to figure it out, I don't want to bother someone to hold my hand. 🙄

steady comet Feb 18, 2021, 4:39 PM

#

Oh I see. I mean I assumed you were just talking about the logic (which IMO refers to the parts which tell the randomizer where it's allowed to place items), rather than the other data. AFAIK there isn't anything documented anywhere tamershrug

young walrus Feb 18, 2021, 4:40 PM

#

area, room, and item are the different modes of randomizer, so they requires slightly different logic in some cases

#

especially with room rando, b/c you can be put directly into that item's room

#

the actual item logic is just this line

#

stone elm Feb 18, 2021, 4:42 PM

#

Okay, that gives me a lot of context, thanks @young walrus. It seems best bet is to spend the time looking through it all and asking questions here if it comes down to it.

young walrus Feb 18, 2021, 4:42 PM

#

this line is for crystal heart

#

>Upper_Crystal_Peak + (SUPERDASH | (CLAW + (DASH | WINGS | AIRSTALL)) | (WINGS + SHADESKIPS))

#

upper crystal peak is just a custom variable that says you can get to upper CP. similar to "right city"

#

a way to simplify the logic chains

#

so to get to CH, you need to get to upper CP. plus one of the other conditions

#

| means or. + means and

stone elm Feb 18, 2021, 4:44 PM

#

Got it. Is Upper_Crystal_Peak defined in another file?

steady comet Feb 18, 2021, 4:44 PM

#

stone elm Got it. Is `Upper_Crystal_Peak` defined in another file?

That's the waypoint, so waypoints.xml

#

(For room rando, waypoints aren't a thing so it just uses macros in macros.xml)

#

In some cases you basically just have to figure out where the waypoints refer to - for instance it isn't necessarily obvious without looking at how they're used that "Upper_Basin", "Mid_Basin" and "Lower_Basin" refer to the bottom of the broken elevator, outside the lower tram and the basin toll bench respectively

stone elm Feb 18, 2021, 4:48 PM

#

Okay, that'll have me back here asking questions probably but it's good to know.

jolly jungle Feb 18, 2021, 6:38 PM

#

Aight, I need help finding the location of the Hive Knight's Globs

#

Their "location" is somewhere at the bottom of the screen, although I think it's at the right x-value

#

I'll send more when my pc unbluescreens itself

#

But basically yeah

#

If anyone has any ideas please tell

jolly oriole Feb 18, 2021, 6:41 PM

#

it's probably either somewhere in its fsm, or if it says something with spawnfromglobalpool, it can be spawned in a similar way

jolly jungle Feb 18, 2021, 6:44 PM

#

Wdym spawned?

#

I'm pretty sure it's the same three globs the whole fight, with the actual object staying offscreen somewhere

#

Damnit

jolly oriole Feb 18, 2021, 6:45 PM

#

i have no idea

copper nacelle Feb 18, 2021, 6:45 PM

#

they're recycled

#

oh wait no globs not bees

#

idk about the globs

jolly jungle Feb 18, 2021, 6:46 PM

#

Ooh wait what

#

Wdym the bees are recycled?

copper nacelle Feb 18, 2021, 6:46 PM

#

it's just the same bees

#

if you kill them or they go off screen they deactivate until they're put at the top again

jolly jungle Feb 18, 2021, 6:50 PM

#

Ah, yeah, makes sense

quick garden Feb 18, 2021, 7:23 PM

#

uhh, sorry, but where can i instal gun mod, i can't find it pinned

young walrus Feb 18, 2021, 7:23 PM

#

on the installer

#

also #archived-modding-help

#

this channel is for making mods

quick garden Feb 18, 2021, 7:24 PM

#

sorryyy

deep wave Feb 18, 2021, 7:35 PM

#

https://github.com/Ayugradow/ModInstaller/pull/50 fixes SSL/TLS error on win7

GitHub

Fix SSL/TLS 1.2 errors on Windows 7 by ManicJamie · Pull Request #5...

Turns out windows 7 doesn't want to use TLS 1.2 by default, because it's 🥴

empty ridge Feb 18, 2021, 10:47 PM

#

So uh, how do i add enemies to my scene?

jolly oriole Feb 18, 2021, 10:47 PM

#

preloading them, then instantiate

#

or you do the painfull task of remaking them

ornate rivet Feb 18, 2021, 10:48 PM

#

dont forget to set active and set their position to next to you lol

#

and sometimes you might have to edit the fsm, especially for bosses

empty ridge Feb 18, 2021, 10:49 PM

#

cool, i'll see what happens

#

does the same go for things like benches and geo rocks?

ornate rivet Feb 18, 2021, 11:05 PM

#

yea

#

geo rocks should be easy

worn eagle Feb 18, 2021, 11:52 PM

#

are there hooks to when a player presses an input key/button?

#

or do I have to poll for them?

jolly oriole Feb 18, 2021, 11:52 PM

#

afaik you have to poll

worn eagle Feb 18, 2021, 11:53 PM

#

pepogrub

jolly oriole Feb 18, 2021, 11:55 PM

#

but you could make your own "hook", with coroutines

prime urchin Feb 19, 2021, 12:05 AM

#

You could hook the action's IsPressed property

leaden hedge Feb 19, 2021, 1:17 AM

#

IsPressed is the poll

#

that the game does, so it only gets ran when the game itself checks for an input

prime urchin Feb 19, 2021, 1:22 AM

#

It's kinda the closest there is afaik if you want a hook but yeah, it's effectively the same thing

empty ridge Feb 19, 2021, 4:50 AM

#

ok so i tried to preload a bench and my mod failed to initialize

#

is there something wrong with this? public override List<(string, string)> GetPreloadNames() { return new List<(string, string)> { ("Crossroads_47","Restbench") }; }

#

besides formatting lol

empty ridge Feb 19, 2021, 5:12 AM

#

ok nvm, had the wrong asset name...

#

didnt know it was caps sensitive soulpensive

nimble lake Feb 19, 2021, 10:17 AM

#

when a new mod is out
:modders:

jolly oriole Feb 19, 2021, 10:23 AM

#

thanks for reminding me to make a repo for CustomBgm

nimble lake Feb 19, 2021, 10:59 AM

#

np hollowknice

jolly oriole Feb 19, 2021, 11:01 AM

#

poggers https://github.com/SFGrenade/CustomBgm/releases/tag/v1.0

worn eagle Feb 19, 2021, 1:56 PM

#

I haven't played many fighting games, so I have to ask: are the number of anticipation frames for an attack in hk comparable to that of a fighting game?

jolly oriole Feb 19, 2021, 2:03 PM

#

i would say comparable, but faster

copper nacelle Feb 19, 2021, 2:04 PM

#

should ask Katie

worn eagle Feb 19, 2021, 3:43 PM

#

wtf

copper nacelle Feb 19, 2021, 3:46 PM

#

has cyclone

stray vault Feb 19, 2021, 3:46 PM

#

yes

vocal spire Feb 19, 2021, 3:52 PM

#

has cyclone

mystic folio Feb 19, 2021, 4:10 PM

#

Hey, so I wanna replace the font sprites in Hollow Knight to recognize more non-English characters. Using TextMeshPro, what kind of file do I want from Unity exactly and would I get it into Hollow Knight?

vocal spire Feb 19, 2021, 4:25 PM

#

mystic folio Hey, so I wanna replace the font sprites in Hollow Knight to recognize more non-...

To get it into hollow knight you would just assetbundle, for the actual font though idk

mystic folio Feb 19, 2021, 4:31 PM

#

Well, I know what font Hollow Knight uses - Perpetua. I wanna generate a new font sprite for that would also include these characters: řťčůňěď; but I am unsure how to properly put it inside Hollow Knight. Do I want TextMeshPro to generate the whole custom .asset file and then somehow merge it with Hollow Knight?

vocal spire Feb 19, 2021, 4:31 PM

#

I don’t know how fonts are stored, but if you mean replacing the game’s files, not exactly the modern way of modding

#

I assume once you’ve created the font or something you’d need to assetbundle the font, then replace the original font at runtime or something

mystic folio Feb 19, 2021, 4:36 PM

#

If I could replace the font through the Modding API and not by replacing it original game files, that would be great. I'll use whatever I can get working.

pure nova Feb 19, 2021, 9:47 PM

#

What would be the best to way to change all of one enemies' FSMs? Like say I wanted to edit every crawlid in the game, what would be the way to go about doing it?

copper nacelle Feb 19, 2021, 10:02 PM

#

prob just do name contains on scene load

worn eagle Feb 19, 2021, 10:31 PM

#

so I'm trying to handle generic types for writing to packets and I'm wondering if this kind of implementation is alright

public void Write<T>(T type, object value) where T : Type
{
    if (type == typeof(byte))
        Write((byte) value);
    else if (type == typeof(byte[]))
        Write((byte[]) value);
    ...
    else if (typeof(IEnumerable).IsAssignableFrom(type))
    {
        Type listType = value.GetType().MakeGenericType(new[] {type});
        Write(listType, ((IEnumerable) value).Cast<object>().ToList());   
    }
    else
        Log($"Writing to a packet with a value of type {type.Name} is not supported.");
}

with the last branch handling lists:

public void Write<T>(T elementType, List<object> list) where T : Type
{
    foreach (object element in list)
    {
        Write(elementType, element);
    }
}

copper nacelle Feb 19, 2021, 10:32 PM

#

why are you generic over T : Type and then have a T passed in

worn eagle Feb 19, 2021, 10:33 PM

#

I'm not experienced

copper nacelle Feb 19, 2021, 10:33 PM

#

pretty sure you want just <T>(T value)

#

if you want type comparisons you can do typeof(T) == typeof(byte)

worn eagle Feb 19, 2021, 10:35 PM

#

alright

copper nacelle Feb 19, 2021, 10:35 PM

#

there's also the alternative of (value is byte)

#

idk which one is faster

worn eagle Feb 19, 2021, 10:38 PM

#

My aim is to use reflection to get some PlayerData fields and send them over to clients

prime urchin Feb 19, 2021, 10:39 PM

#

You could even do something like

switch (value)
{
    case byte b:
        Write(b);
    // other cases...
}

which may or may not be more convenient

copper nacelle Feb 19, 2021, 10:39 PM

#

yeah

#

if you're going to reflect over fields then you want just the is or the switch

#

no point in the generic because it'll be just invoked with an object

#

why are you thinking me zaliant

#

so racist

worn eagle Feb 19, 2021, 10:39 PM

#

oh I forgot to give a name to the var

#

thats why the switch didn't work

#

Maybe I should provide a big picture explanation of what I'm trying to do

empty ridge Feb 19, 2021, 10:42 PM

#

so i've gotten the geo rock and bench into my scene. i tried to do the same with a primal aspid and it worked.... but it just sits there flying.

#

what gives

pure nova Feb 19, 2021, 10:50 PM

#

copper nacelle prob just do name contains on scene load

Would the name contains be fsm.FsmName.Contains?

empty ridge Feb 19, 2021, 10:53 PM

#

empty ridge what gives

nvm, i see that its more complicated than just having the one fsm

copper nacelle Feb 19, 2021, 10:53 PM

#

i mean like ```cs
UnityEngine.SceneManagement.SceneManager.activeSceneChanged += SceneChanged;

void SceneChanged(Scene from, Sceene to) {
foreach (var go in UnityEngien.Object.FindObjectsOfType<GameObject>()) {
if (!go.name.Contains("Crawler")) continue;

 // do what you want

}
}

worn eagle Feb 19, 2021, 10:57 PM

#

poll for inputs in monobehaviour attached to knight
send inputs to server, server sends them to clients
inputs are saved to a queue in a script similar to herocontroller minus singleton bs and attached to remote player object and processed there

#

Maybe a better question for Katie to answer

copper nacelle Feb 19, 2021, 10:58 PM

#

inputs :monkaUMEGA:

#

if you drop packets that'll desync terribly

pure nova Feb 19, 2021, 10:58 PM

#

copper nacelle i mean like ```cs UnityEngine.SceneManagement.SceneManager.activeSceneChanged +...

It worked. Thanks.

copper nacelle Feb 19, 2021, 10:59 PM

#

np

worn eagle Feb 19, 2021, 10:59 PM

#

Isn't that where prediction would come in?

copper nacelle Feb 19, 2021, 10:59 PM

#

idk

#

i remember firzen linked me something on it

#

if you want that

worn eagle Feb 19, 2021, 11:01 PM

#

If you can afford to look for it

copper nacelle Feb 19, 2021, 11:02 PM

#

https://developer.valvesoftware.com/wiki/Source_Multiplayer_Networking
https://www.youtube.com/watch?v=h47zZrqjgLc

#

valve whitepaper/halo devs talk

deep wave Feb 19, 2021, 11:04 PM

#

yes, it's called Hollow Point on the installer

#

(wrong channel too, this should be in #archived-modding-help)

white terrace Feb 19, 2021, 11:04 PM

#

oh sorry

worn eagle Feb 19, 2021, 11:09 PM

#

I'm understanding a bit better what Katie meant by recreating the knight

#

Still a bit hazy on which parts exactly tho

#

hc, pd, heroanimctrler, heroaudioctrler prob, and all the fsms prob

jolly oriole Feb 20, 2021, 12:27 AM

#

is the rollback then based on the players fps or the fixedupdates?

worn eagle Feb 20, 2021, 12:32 AM

#

idk yet

jolly oriole Feb 20, 2021, 12:34 AM

#

ig fixedupdate is better, as that is 60 times per second regardless of hardware (maybe lower when toaster)

worn eagle Feb 20, 2021, 12:36 AM

#

prime urchin You could even do something like ```csharp switch (value) { case byte b: ...

so would it go something like this?

public void Write<T>(T value)
{
    switch (value)
    {
        case byte val:
            Write(val);
            break;
        case byte[] val:
            Write(val);
            break;
        ...
        case List<T> val:
            Write(val);
            break;
        default:
            Log($"Writing to a packet with a value of type {value.GetType().Name} is not supported.");
            break;
    }
}

#

not sure if the List case is handled correctly

jolly oriole Feb 20, 2021, 12:40 AM

#

if i read this correctly, the list case will never happen as List<int> would be checked for the type List<List<int>>

prime urchin Feb 20, 2021, 12:41 AM

#

I'm not entirely sure - I want to say no, but it's something to test. Alternatively, you could make an (IEnumerable<T> value) overload for the method and then just loop over and call the original Write for each item

pure nova Feb 20, 2021, 2:19 AM

#

Probably best for #modding-discussion.

pure nova Feb 20, 2021, 3:20 AM

#

UnityEngine.SceneManagement.SceneManager.activeSceneChanged += SceneChanged;

void SceneChanged(Scene from, Sceene to) {
  foreach (var go in UnityEngien.Object.FindObjectsOfType<GameObject>()) {
     if (!go.name.Contains("Crawler")) continue;

     // do what you want
  }
}```

How would I "assign" a gameobject var to what it selects?

prime urchin Feb 20, 2021, 3:31 AM

#

Well, if the 'if' statement is false, that means the 'go' variable from the loop has a GameObject that contains the name of "Crawler". You just need to assign 'go' to a GameObject variable in your class like so.

GameObject crawler;

void SceneChanged(Scene from, Scene to) {
  foreach (var go in UnityEngine.Object.FindObjectsOfType<GameObject>()) {
     if (!go.name.Contains("Crawler")) continue;

     crawler = go;
     break;
  }
}

errant geyser Feb 20, 2021, 4:27 AM

#

Hey, sorry that this is rather offtopic, but this seems to be the only channel with devs around.

Does anybody have resources on how the HK autosplitter works? I know what a pointerpath is, but I'm not sure about the specifics like how an entrypoint is found.
My motivation is that I don't own a PC and have to make that stuff work on linux; this makes it a bit hard to figure things out, especially since I have no clue about unity internals and what translates from dotnet in windows to the mono implementation and what not.
I know C#, how to decompile the IL, and how to use gdb, if that helps.

deep wave Feb 20, 2021, 4:28 AM

#

livesplit doesn't exist on linux, so its basically accepted that the autosplitter won't work

#

autosplitter repo here: https://github.com/ShootMe/LiveSplit.HollowKnight

vocal spire Feb 20, 2021, 4:29 AM

#

pure nova > ```cs > UnityEngine.SceneManagement.SceneManager.activeSceneChanged += SceneCh...

Are you trying to edit all of them

errant geyser Feb 20, 2021, 4:29 AM

#

This is not entirely true, there are efforts to create a cross-platform lib.
Which is why I kind of want to see if I can write something on my own

#

I think I found the right sections in the github repo tho, it uses hex patterns, thanks Jamie

pure nova Feb 20, 2021, 5:35 AM

#

vocal spire Are you trying to edit all of them

Yes. What Unordinal described worked, but only sometimes. It's wildly inconsistent. Sometimes they change, sometimes they don't. Sometimes if I use a different scene transition whether or not they change differs. Sometimes it doesn't matter. It's odd.

#

My code is meant to make the Crawlid bigger, give it more health, and make it faster, which I deem is enough for it to be good enough practice. Here is my code:

void SceneChanged(Scene from, Scene to)
        {
            foreach (var go in UnityEngine.Object.FindObjectsOfType<GameObject>())
            {
                if (!go.name.Contains("Crawler")) continue;

                GameObject crawler = go;

                //Makes the crawlid big.
                crawler.transform.localScale *= 1.5f;
                
                //Lifts the crawlid up a little so it doesn't clip.
                Vector3 position = crawler.transform.position;
                position.y += 1.0f;
                crawler.transform.position = position;

                //Gives it more health.
                crawler.GetComponent<HealthManager>().hp = 40;

                //Makes it faster.
                PlayMakerFSM fsm = crawler.LocateMyFSM("Crawler");
                fsm.GetAction<WalkLeftRight>("Walk", 1).walkSpeed = 8f;
                fsm.GetAction<WalkLeftRight>("Maintain", 0).walkSpeed = 8f;
                fsm.GetAction<WalkLeftRight>("Start R", 0).walkSpeed = 8f;
                fsm.GetAction<WalkLeftRight>("Start L", 0).walkSpeed = 8f;

                break;
            }
        }```
For some reason, it is only inconsistent in whether or not it changes when the FSM part is present. But it gets even weirder, (at least to me, it might make complete sense to you). It also affects whether or not it is big and has more health, even though both don't use FSM whatsoever.

#

Apologies for the wall.

winter quail Feb 20, 2021, 6:48 AM

#

is there a way to make custom knight textures quickere than manually editing each one

knotty monolith Feb 20, 2021, 6:51 AM

#

copy and paste zote

winter quail Feb 20, 2021, 6:55 AM

#

yeh but their not all the same :/

prime urchin Feb 20, 2021, 7:57 AM

#

pure nova My code is meant to make the Crawlid bigger, give it more health, and make it fa...

The break; at the end will cause the loop to end after it's found one. You'll want to remove that line if you want all objects with the name of "Crawler" to be affected.

pure nova Feb 20, 2021, 8:03 AM

#

Then I assume the one it does is the one closest to where it loads in.

deep wave Feb 20, 2021, 8:06 AM

#

doubt that proximity would make a difference to what order FindObjectsOfType returns

copper nacelle Feb 20, 2021, 8:50 AM

#

errant geyser Hey, sorry that this is rather offtopic, but this seems to be the only channel w...

the pointer paths are based on having one static reference by finding the hex and then following fields

#

so you have like GameManager.instance which is static and then you can get to any of the classes it has on fields by adding the offset of the field and then dereferencing

#

and repeat

#

which is the path part

#

If cheat engine's "mono disassembler" or whatever works on Linux then you can use that to get addresses and offsets very easily

#

besides that the other thing you'd need to change are the memory reading functions because they p/invoke winapi

#

if you have any other questions feel free to ping me

copper nacelle Feb 20, 2021, 11:08 AM

#

oh yeah and the entry point is based on that

#

There's a pdf devil has

#

UnityAutosplitters.pdf

📎 UnityAutosplitters.pdf

potent dirge Feb 20, 2021, 2:09 PM

#

deep wave livesplit doesn't exist on linux, so its basically accepted that the autosplitte...

Even if livesplit doesn't exist that's just the frontend of the autosplitter. The memory searching backend is the actually important part for performing the autosplitting

worn eagle Feb 20, 2021, 2:10 PM

#

getting some weird values with reflection

data = new ExchangeData();
var pd = PlayerData.instance;
List<string> fieldNames = pd.GetType().GetFields().Select(fi => fi.Name).ToList();
foreach (FieldInfo fi in data.GetType().GetFields())
{
    if (!fieldNames.Contains(fi.Name)) continue;
    Log("FI Name: " + fi.Name);
    Log("FI Value: " + Mirror.GetField<PlayerData, object>(pd, fi.Name));
    //Mirror.SetField(data, fi.Name, Mirror.GetField<PlayerData, object>(pd, fi.Name));
}

ExchangeData being a non singleton ver of PlayerData

[INFO]:[Hero Tracker] FI Name: version
[INFO]:[Hero Tracker] FI Value: 1.4.3.2
[INFO]:[Hero Tracker] FI Name: playTime
[INFO]:[Hero Tracker] FI Value: PlayerData
[INFO]:[Hero Tracker] FI Name: completionPercent
[INFO]:[Hero Tracker] FI Value: PlayerData
[INFO]:[Hero Tracker] FI Name: openingCreditsPlayed
[ERROR]:[UNITY] - NullReferenceException: Object reference not set to an instance of an object

#

my bad, completely flooded your post

copper nacelle Feb 20, 2021, 2:11 PM

#

if you're looping using fieldinfos there's a function which takes those directly

#

the nre is weird

#

idk if i handle boxing

#

i'll look at it

vocal spire Feb 20, 2021, 2:22 PM

#

pure nova My code is meant to make the Crawlid bigger, give it more health, and make it fa...

Why are you using a new local variable? Just use go instead of crawler, they are the same thing

copper nacelle Feb 20, 2021, 2:29 PM

#

I didn't get an NRE but I did get an InvalidCastException

worn eagle Feb 20, 2021, 2:30 PM

#

getting pd fields?

copper nacelle Feb 20, 2021, 2:30 PM

#

getting openingCreditsPlayed as an object instead of a bool

worn eagle Feb 20, 2021, 2:31 PM

#

hmm from what I've read c# primitives inherit from ValueType which inherits from System.Object/object

copper nacelle Feb 20, 2021, 2:33 PM

#

they're structs

#

but structs have an implicit inheritance from valuetype

#

but like they aren't obj references for the most part

#

that's usually handled by auto-boxing

#

Oh and the nre might be it throwing on .ToString

#

i assume you want decent performance for this yeah?

worn eagle Feb 20, 2021, 2:39 PM

#

that'd be optimal

#

boxing/unboxing is pretty expensive yeah

copper nacelle Feb 20, 2021, 2:40 PM

#

yes

#

optimally i think this would be a source generator thing

#

if there's not a huge number of fields that you want to actually exchange then it'd be significantly more performant to do this by hand

worn eagle Feb 20, 2021, 2:44 PM

#

I was afraid I'd have to do that

copper nacelle Feb 20, 2021, 2:44 PM

#

don't have to

#

just performance wise it's a decent difference

#

i wonder if there's a way to exchange generically

#

because the problem is the field iterations is at runtime so it can only call the getfield as an obj

#

Oh

#

I have a terrible idea

#

Gimme a bit

jolly oriole Feb 20, 2021, 2:46 PM

#

terrible ideas are nice

worn eagle Feb 20, 2021, 2:51 PM

#

is it a good idea to JsonConvert pd and send that large string in a packet

copper nacelle Feb 20, 2021, 2:51 PM

#

no

#

pd has so much garbage on it

worn eagle Feb 20, 2021, 2:52 PM

#

I should've said exchangedata

#

which will only have the fields necessary to build a player

copper nacelle Feb 20, 2021, 2:53 PM

#

that doesn't seem terrible but i don't do servers

worn eagle Feb 20, 2021, 2:55 PM

#

I planned on writing all the fields of exchangedata to a packet on their own but was having trouble generically handling collections so grenade suggested jsonconverting the class

copper nacelle Feb 20, 2021, 2:58 PM

#

tfw

jolly oriole Feb 20, 2021, 2:59 PM

#

maybe the entire data needed to transfer

#

oh fuck, the first two aren't even needed

potent dirge Feb 20, 2021, 3:00 PM

#

Are you working on multiplayer?

worn eagle Feb 20, 2021, 3:00 PM

#

prob gonna need stuff like has[NArt] too

#

yeah

potent dirge Feb 20, 2021, 3:00 PM

#

Isn't coordinates in playerdata, unintuitively enough?

#

Or at least shade zone and stuff

jolly oriole Feb 20, 2021, 3:01 PM

#

class ExchangeData
{
    int health;
    int maxHealth;
    int healthBlue;
    int joniHealthBlue;
    int nailDamage;
    int nailRange;
    int fireballLevel;
    int quakeLevel;
    int screamLevel;
};

i mean, the things with has{whatever} cann/will be set by local code and just the animations get synced

worn eagle Feb 20, 2021, 3:01 PM

#

potent dirge Isn't coordinates in playerdata, unintuitively enough?

coords in playerdata?

potent dirge Feb 20, 2021, 3:05 PM

#

Maybe it was changed from 1221 to 1432, but I swear I saw a ton of stuff in pd that made no sense to be in there but there it was 🥴

#

Could be wrong on player coords tho lol

jolly oriole Feb 20, 2021, 3:05 PM

#

only postitions in playerdata are

- Shade position on the map
- Dreamgate postition on the map
- Positions of the customizable map pins

#

which are also the same fields that json.net can't read and displays as (0, 0, 0)

worn eagle Feb 20, 2021, 3:07 PM

#

newtonsoft can't read vector3s?

potent dirge Feb 20, 2021, 3:07 PM

#

LUL amazing

jolly oriole Feb 20, 2021, 3:08 PM

#

no, only with custom jsonconverters, but for all unity types that would be another thing bundled in the api

worn eagle Feb 20, 2021, 3:11 PM

#

guess I'm removing any vec3s from exchangedata

#

I'm still gonna need many of the fields from pd if I'm gonna be simulating a copy of the knight entirely

#

what is marm

#

there's a marmConvoNailSmith bool

copper nacelle Feb 20, 2021, 3:32 PM

#

50k clones

#

first one is copy-paste second one is dynamic

#

https://hatebin.com/kqhsbrtkhi

#

might throw it in vasi

jolly oriole Feb 20, 2021, 3:47 PM

#

worn eagle there's a marmConvoNailSmith bool

lemm says something about the nailsmith and stores in that if lemm already said that

#

would be the language string RELICDEALER_NAILSMITH

jolly oriole Feb 20, 2021, 4:14 PM

#

56, i heard you like bundling more assemblies into the modding api, so if you have nothing better to do, this may be worth a look: https://github.com/jilleJr/Newtonsoft.Json-for-Unity.Converters

copper nacelle Feb 20, 2021, 4:23 PM

#

more merging x5fiftAleph

#

It's already way too big

#

Merging was a mistake

vocal spire Feb 20, 2021, 4:30 PM

#

🤔

copper nacelle Feb 20, 2021, 4:36 PM

#

wtf

#

Don't think me

#

I'm right it's fucking 15mb

#

And you can't even search the modded version because of merging hooks in

jolly oriole Feb 20, 2021, 4:38 PM

#

wait what

#

the whole modding api? or just the converers?

copper nacelle Feb 20, 2021, 4:39 PM

#

modding api

jolly oriole Feb 20, 2021, 4:40 PM

#

hm i think i'll look if i can "get inspired" to just do vector3 converters

copper nacelle Feb 20, 2021, 4:40 PM

#

it's mit just rob it

leaden hedge Feb 20, 2021, 5:18 PM

#

you dont need to send max hp or jonis max hp, or both jonis and current hp

#

just how much hp they have right now

#

you also don't need 3 ints for fireball level, quake level, scream level
either use 6 bools or 1 short
i guess a short you could do 1 bit for mark of pride, longnail, vs, ss, scream, shreik, ddive, ddark

#

which does 4 of those ints in one quarter the space

worn eagle Feb 20, 2021, 5:22 PM

#

so jsonconvert bad?

copper nacelle Feb 20, 2021, 5:23 PM

#

json is not particularly efficient

leaden hedge Feb 20, 2021, 5:23 PM

#

if you know the bit format of the packet you don't need identifiers

#

and you also don't need 128 bits to send 8 bits of data

#

not including the string to id it

#

which would be like another 1000bits just for that struct

worn eagle Feb 20, 2021, 5:26 PM

#

guess I'll have to crunch through bit shifting

leaden hedge Feb 20, 2021, 5:27 PM

#

you can make an array of bytes

jolly oriole Feb 20, 2021, 5:31 PM

#

[ERROR]:[API] - Failed to read save using Json.NET (GameManager::LoadGame), falling back.
[ERROR]:[API] - System.InvalidCastException: Failed to read type 'Vector3'. Expected object start, got 'StartArray' <>
[ERROR]:[API] -   at Modding.JsonConverters.PartialConverter`2[UnityEngine.Vector3,System.Single].InternalReadJson (Newtonsoft.Json.JsonReader reader, Newtonsoft.Json.JsonSerializer serializer, Boolean isNullableStruct) [0x00000] in <filename unknown>:0

good thing to test it before

leaden hedge Feb 20, 2021, 5:32 PM

#

and make a function like

public byte makebyte( bool[] b ){
  byte out = 0 ;
  for(int i = 0; i < 8; i++){
    out += b[i] * (1 << i-1);
  }
  return out;
}

#

why did i type that as bit FeelsOkayMan

#

and to get them out you do something like

public bool[] getbits( byte b ){
  bool[] out = new bool[8];
  for( int i = 0; i < 8; i++){
    out[i] = b & ((1 << i-1)) != 0
  }
  return out;
}

#

i guess you could use bit shifts to do the multiply in the other function too

#

probably faster

#

also you wouldnt send a full vector3 anyway

#

as the knights depth is known by the local player

#

so you only need to send x and y position

worn eagle Feb 20, 2021, 5:41 PM

#

fortunately I've been doing that for spawning players

leaden hedge Feb 20, 2021, 5:42 PM

#

you could probably store position in one float by doing jank

#

and losing a slight amount of precision

#

by doing float pos = ypos * widthofroom + xpos

copper nacelle Feb 20, 2021, 5:43 PM

#

if pow 2 doesn't emit a shift I'd be shocked

worn eagle Feb 20, 2021, 5:43 PM

#

this code is gonna be so indecipherable feelspkman

leaden hedge Feb 20, 2021, 5:44 PM

#

although you'd probably need some extra data for that to work

#

at which point its probably worth just doing it as halfs

worn eagle Feb 20, 2021, 5:53 PM

#

which pd fields should we keep?

#

if we're going to be simulating all remote players i wrote the controller attached to them to be more or less the same as herocontroller

#

and each player is a clone of Knight minus herocontroller, heroanimationcontroller, heroaudiocontroller, converyormovementhero, all fsms, and vignette

prime urchin Feb 20, 2021, 6:51 PM

#

Bleh, I've just learned that in Unity you should use == when checking for null and not is. There's a bit of time down the drain, hah.

#

I guess I should make use of the implicit conversion to bool after all

copper nacelle Feb 20, 2021, 6:53 PM

#

Yeah it's shit

#

Can't use ?? or ?. or is for nulls

prime urchin Feb 20, 2021, 7:02 PM

#

Yeah, I almost regret using nullability features in this now - fun times

#

I forgot what it was like to write C# without ?? and ?.

jolly oriole Feb 20, 2021, 7:45 PM

#

fuck newtonsoft, gives me "Integer": "0"
and if i try to (int) reader.Value, i get a fucking System.InvalidCastException: Cannot cast from source type to destination type

copper nacelle Feb 20, 2021, 7:48 PM

#

any int.Parse

jolly oriole Feb 20, 2021, 7:49 PM

#

my bad for the presentation of it, but it's a simple int as an object, i just logged it with " around

copper nacelle Feb 20, 2021, 7:51 PM

#

Convert.ToInt32

jolly oriole Feb 20, 2021, 8:05 PM

#

Tclass ret = ReadJson(token, (Tclass) existingValue);

how is this a NullReferenceException?

copper nacelle Feb 20, 2021, 8:06 PM

#

existingValue is passed in as what

jolly oriole Feb 20, 2021, 8:07 PM

#

technically it should be a Vector3

#

or should i just pass it as an object?

copper nacelle Feb 20, 2021, 8:08 PM

#

it's probably boxed or something if it's nreing

#

idk

#

i'd try object

jolly oriole Feb 20, 2021, 8:09 PM

#

ig this worked

#

with object

copper nacelle Feb 20, 2021, 8:09 PM

#

gg

jolly oriole Feb 20, 2021, 8:10 PM

#

and if it wasn't already obious, i made the custom converter myself, as all others either wanted values as a list (???) or didn't want to accept vector3s in a list

#

i guess i also make the change back with the point of loading mods, so that decomaster, hollowtwitch and maybe a few others work again

#

oh fuck, i also have to test saving

#

works pog

#

now only to add the other 50 types of unity

copper nacelle Feb 20, 2021, 8:15 PM

#

i mean are the other 50 even used in pd

jolly oriole Feb 20, 2021, 8:16 PM

#

not in pd, but i think i'll help others a bit if i also include stuff like vector2

copper nacelle Feb 20, 2021, 8:17 PM

#

vector2 seems reasonable

#

idk if i'd bother with the rest

#

but you do you

worn eagle Feb 20, 2021, 8:17 PM

#

Cloth component serialization pog

jolly oriole Feb 20, 2021, 8:22 PM

#

isn't that already serializable because it's a component?

#

you really want the cloth component?

#

cloth should work with just a converter for vector3's added

prime urchin Feb 20, 2021, 8:34 PM

#

got the Microsoft.Unity.Analyzers but it apparently doesn't check for 'is null' and 'is not null' so I guess I'm stuck manually find and replacing

copper nacelle Feb 20, 2021, 8:39 PM

#

just regex

jolly oriole Feb 20, 2021, 8:43 PM

#

👏 it 👏 just 👏 works 👏

#

https://github.com/fifty-six/HollowKnight.Modding/pull/12 a few tiny changes

copper nacelle Feb 20, 2021, 8:51 PM

#

do you even need the patch for StartManager

#

or was that to avoid the like 8 year cutscene at the start

#

it was to avoid the 8 year cutscene

#

good ol git blame

#

merged

jolly oriole Feb 20, 2021, 8:52 PM

#

poggers

copper nacelle Feb 20, 2021, 8:54 PM

#

why

jolly oriole Feb 20, 2021, 8:54 PM

#

... i may or may not have not added the docstring things

copper nacelle Feb 20, 2021, 8:55 PM

#

do you need the set

#

echaleph

#

is there a reason for existingValue existing

jolly oriole Feb 20, 2021, 8:58 PM

#

in case one would like to add stuff / the not replace thing

#

so currently no

copper nacelle Feb 20, 2021, 9:01 PM

#

was the private set supposed to be there

#

for the converter types

#

because it is a dead setter

worn eagle Feb 20, 2021, 9:02 PM

#

leaden hedge and make a function like ``` public byte makebyte( bool[] b ){ byte out = 0 ; ...

what happens at out += b[i] * (1 << i-1)?

copper nacelle Feb 20, 2021, 9:02 PM

#

set the bit based on bool value

#

if you have b[i] as true (i.e. 1) then you put a 1 in the spot

#

multiplication would be convenient because 0 would cancel it out

#

doesn't work as well in c# where you can't cast bools to ints

#

the 1 << (i - 1) puts the 1 i-1 bits into the byte

worn eagle Feb 20, 2021, 9:05 PM

#

pepogrub

copper nacelle Feb 20, 2021, 9:05 PM

#

yeah

#

worn eagle Feb 20, 2021, 9:05 PM

#

oh it was just pseudocode

copper nacelle Feb 20, 2021, 9:05 PM

#

i'd just do @out += b[i] ? (1 << (i - 1)) : 0;

#

i mean it'd work in like c

#

i gotta say return 0 instead of throwing really is not the play

worn eagle Feb 20, 2021, 9:06 PM

#

yeah that's true

copper nacelle Feb 20, 2021, 9:06 PM

#

shouldn't it be << i

worn eagle Feb 20, 2021, 9:12 PM

#

public static byte MakeByte(bool[] b)
{
    int bLength = b.Length;
    if (bLength >= 8) throw new Exception($"Cannot create a byte from a bool array of length {bLength}");
    byte @out = 0;
    for (int i = 0; i < 8; i++)
    {
        @out += (byte) (b[i] ? (1 << i) : 0);
    }
    return @out;
}
public static bool[] GetBits(byte b)
{
    var @out = new bool[8];
    for (int i = 0; i < 8; i++)
    {
        @out[i] = (b & (1 << i)) != 0;
    }
    return @out;
}

this look like it'd work?

copper nacelle Feb 20, 2021, 9:13 PM

#

yeah

#

do like invalidoperationexception though

#

could skip the cast if you iterate with a byte instead of an int

#

dunno if that actually changes the assembly

worn eagle Feb 20, 2021, 9:17 PM

#

idts

copper nacelle Feb 20, 2021, 9:19 PM

#

1b

#

nvm there's not a byte literal

#

terrible

worn eagle Feb 20, 2021, 9:32 PM

#

guess I should handle other data types too

#

no idea how im gonna handle things like naildamage which players might have set to 999 through debug

jolly oriole Feb 20, 2021, 9:34 PM

#

either only account for the vanilla range or use what's availablefrom the 32bit integer (so 31 bits), but i guess only allowing 12 bits is enough, as one could get 4095 naildamage with that

prime urchin Feb 20, 2021, 9:42 PM

#

You could use something like LEB128 if you really wanted

#

probably not worth the effort

#

actually I might have an implementation of it somewhere here if that's something you're interested in, gimmie a sec

#

it's been unit tested but you'd have to replace the Spans with regular arrays for .NET 3.5 https://gist.github.com/Unordinal/50480145fc1b9fe64d277e72c3b383ef

#

Usage is just LEB128.GetBytes(integer) to convert to bytes and LEB128.GetSigned(bytes) or LEB128.GetUnsigned(bytes) to convert back

copper nacelle Feb 20, 2021, 9:52 PM

#

jolly oriole <https://github.com/fifty-six/HollowKnight.Modding/pull/12> a few tiny changes

the noise thing is because you re-added the loading of menu_title but that's done in the modloader

#

so it double loads

jolly oriole Feb 20, 2021, 9:53 PM

#

oh ufkc

copper nacelle Feb 20, 2021, 9:54 PM

#

wait no

#

it's not even supposed to load menu in the modloader

#

that was moved in during the first move

#

suffering

jolly oriole Feb 20, 2021, 9:55 PM

#

imma keep my thing, i just looked at https://github.com/fifty-six/HollowKnight.Modding/commit/cfc33db275611be1bf7f5d99831a9760ff78f9ec to see how it worked, must've have missed another change

copper nacelle Feb 20, 2021, 9:55 PM

#

meme

#

i'm fixing it

jolly oriole Feb 20, 2021, 9:56 PM

#

poggers

copper nacelle Feb 20, 2021, 10:01 PM

#

this is not it

jolly oriole Feb 20, 2021, 10:01 PM

#

it's not supposed to look like that, right?

copper nacelle Feb 20, 2021, 10:01 PM

#

yeah

jolly oriole Feb 20, 2021, 10:02 PM

#

though i quite like the double or triple text the first few lines

vocal spire Feb 20, 2021, 10:02 PM

#

🤔

#

I thought it always was supposed to look like that

jolly oriole Feb 20, 2021, 11:35 PM

#

so uhm

#

i have a screenshot

#

though i have to test if i'm limited by 3.5 GB

jolly oriole Feb 21, 2021, 12:11 AM

#

@vocal spire uuwuu failed to load:

[ERROR]:[API] - Error: System.MissingMethodException: Method not found: 'FrogCore.JournalHelper.AddJournalEntry'.
[ERROR]:[API] -   at Modding.ModLoader.LoadMod (IMod mod, Boolean updateModText, Boolean changeSettings, System.Collections.Generic.Dictionary`2 preloadedObjects) [0x00000] in <filename unknown>:0 
[ERROR]:[API] -   at Modding.ModLoader+<LoadMods>d__9.MoveNext () [0x00000] in <filename unknown>:0

#

meanwhile i didn't get much over 4 GB

vocal spire Feb 21, 2021, 12:16 AM

#

fine I'll fix frogcore on the installer

#

*one day

jolly oriole Feb 21, 2021, 12:17 AM

#

i just need to utterly hug ram, can't be that hard

vocal spire Feb 21, 2021, 12:17 AM

#

hmmm

#

load some among us mods

#

oh wait nvm

#

forgot that the initialize is completely different

#

~~i be dumb~~

jolly oriole Feb 21, 2021, 12:18 AM

#

i think i'll settle for a GB of ints

vocal spire Feb 21, 2021, 12:18 AM

#

zote

jolly oriole Feb 21, 2021, 12:18 AM

#

memoryHugger = new int[268435456];

vocal spire Feb 21, 2021, 12:18 AM

#

elderC

vocal spire Feb 21, 2021, 12:19 AM

#

jolly oriole i think i'll settle for a GB of ints

~~gigabyte of bytes?~~

jolly oriole Feb 21, 2021, 12:19 AM

#

no, a GB of int values

vocal spire Feb 21, 2021, 12:19 AM

#

k

jolly oriole Feb 21, 2021, 12:21 AM

#

YES

vocal spire Feb 21, 2021, 12:21 AM

#

cool

#

I'm currently trying to take a screenshot at runtime(very fun)

#

except in code

#

it's working out and not working out

jolly oriole Feb 21, 2021, 12:25 AM

#

6.1 GB poggers

ornate rivet Feb 21, 2021, 12:26 AM

#

ok but I bet most hk players have 8 gb ram max

jolly oriole Feb 21, 2021, 12:26 AM

#

also requires some rather unique methods

#

4 GB over 4 arrays is fine, but 4 GB in a single array is too much

[ERROR]:[API] - Error: System.OutOfMemoryException: Out of memory

ornate rivet Feb 21, 2021, 12:30 AM

#

makes sense

jolly oriole Feb 21, 2021, 12:32 AM

#

seems to work fine as long as the memory used per array is <=2GB

jolly oriole Feb 21, 2021, 4:25 PM

#

oh my god, pressgtodab criples my fps from 900 to 300

worn eagle Feb 21, 2021, 4:26 PM

#

tf

jolly oriole Feb 21, 2021, 4:27 PM

#

will probably also break if one save&quits

worn eagle Feb 21, 2021, 4:28 PM

#

all it does is add an anim to the knight's anim library and poll for key down G

jolly oriole Feb 21, 2021, 4:28 PM

#

nah, before the knight is loaded it checks every frame if the instance isn't null anymore, which utterly breaks on save&quit as the knight GO gets destroyed

worn eagle Feb 21, 2021, 4:32 PM

#

pepogrub

jolly oriole Feb 21, 2021, 4:33 PM

#

but i can change that if you'd like

vocal spire Feb 21, 2021, 4:33 PM

#

F

#

Hook update on HeroController or something

#

Smh my head

jolly oriole Feb 21, 2021, 4:38 PM

#

used awake, as it's better

#

poggers

📎 PressGToDab.dll

merry lotus Feb 21, 2021, 4:41 PM

#

If you're updating Press G to Dab, then possibly add a config file to change the key?
Granted, I'm unsure how tedious that is.

jolly oriole Feb 21, 2021, 4:41 PM

#

i have no idea how i'd do that, but i'll look

#

will probably steal code from debugmod

worn eagle Feb 21, 2021, 4:42 PM

#

putting effort into a shitpost mod

patent zealot Feb 21, 2021, 4:42 PM

#

Oh my god

#

I had crystal blobbles, gatling aspid and g to dab this whole time...

#

Thats cursed

merry lotus Feb 21, 2021, 4:44 PM

#

At a basic level, I'd assume you could just read a single line of a text file. The config could literally just be that one line.
And then make the line be whatever the constant is for the input. (I'm unsure how is used in the code, but requiring it to be the constant/input-name seems like it'd remove all of the tedium)

merry lotus Feb 21, 2021, 4:45 PM

#

worn eagle putting effort into a shitpost mod

It's of upmost importance zote

vocal spire Feb 21, 2021, 4:45 PM

#

Can’t you just have the KeyCode enum with an string enum converter or whatever?

jolly oriole Feb 21, 2021, 4:46 PM

#

vocal spire Can’t you just have the KeyCode enum with an string enum converter or whatever?

or one could save it like debug does, as a simple int

vocal spire Feb 21, 2021, 4:47 PM

#

Yeah

jolly oriole Feb 21, 2021, 4:48 PM

#

but i'll just let it stay as G, otherwise the mod name is misleading

#

https://github.com/Ayugradow/ModInstaller/pull/51 pog

jolly oriole Feb 21, 2021, 5:20 PM

#

~~crystalobbles should also be rather easy to make it not eat frames,~~ with gatling aspid i'm not sure

jolly oriole Feb 21, 2021, 6:28 PM

#

holy shit is gatlingaspid ~~bad~~ good, every scene change the gamemanager gets another component

#

nvm, not another component, but another coroutine that basically doesn't stop

copper nacelle Feb 21, 2021, 6:39 PM

#

x5fiftPrime

jolly oriole Feb 21, 2021, 6:53 PM

#

should be fine (no infinite coroutines anymore, just a hook On.PlayMakerFsm.Start)

📎 GatlingAspid.dll

worn eagle Feb 22, 2021, 1:43 AM

#

pog

copper nacelle Feb 22, 2021, 1:44 AM

#

64 bit

#

Kinda pog

worn eagle Feb 22, 2021, 1:44 AM

#

also

phase 2

deep wave Feb 22, 2021, 1:44 AM

#

correct

copper nacelle Feb 22, 2021, 1:45 AM

#

correct

#

counting the spike shit as a phase is so much effort

ornate rivet Feb 22, 2021, 1:47 AM

#

oh god what if all the mods break

#

oh god

#

what if pale court breaks

worn eagle Feb 22, 2021, 1:47 AM

#

So I joined after godmaster and haven't experienced an update, will this require an api update?

copper nacelle Feb 22, 2021, 1:47 AM

#

Yeah

#

Probably just a rebuild tbh

ornate rivet Feb 22, 2021, 1:48 AM

#

will we wait for it to come out of beta?

floral furnace Feb 22, 2021, 1:48 AM

#

its still in beta tho

copper nacelle Feb 22, 2021, 1:48 AM

#

I can make a branch ig

#

Effort

#

I'll look at it

worn eagle Feb 22, 2021, 1:49 AM

#

wish there was a complete list of fixes

copper nacelle Feb 22, 2021, 1:50 AM

#

I'll assembly diff in a bit

#

After dinner

floral furnace Feb 22, 2021, 1:51 AM

#

best case scenario we dont need to update our mods either right

copper nacelle Feb 22, 2021, 1:52 AM

#

probably

floral furnace Feb 22, 2021, 1:52 AM

#

this answer does not fill me with confidence but it is understandable

worn eagle Feb 22, 2021, 2:18 AM

#

netstandard

copper nacelle Feb 22, 2021, 2:19 AM

#

YOOOOO

#

That's such a fucking improvement

ornate rivet Feb 22, 2021, 2:24 AM

#

noice

#

Jack's work no doubt

floral furnace Feb 22, 2021, 2:24 AM

#

iflj

charred topaz Feb 22, 2021, 2:51 AM

#

if it's a new version of dot net, would that also mean they are using a newer version of Unity too?

copper nacelle Feb 22, 2021, 2:53 AM

#

2020.2.2.33144

ornate rivet Feb 22, 2021, 2:53 AM

#

woah

charred topaz Feb 22, 2021, 2:53 AM

#

oh dang

copper nacelle Feb 22, 2021, 2:53 AM

#

from 2017.4.10

#

so yeah

ornate rivet Feb 22, 2021, 2:53 AM

#

WOAH

charred topaz Feb 22, 2021, 2:53 AM

#

that may brick mods that use asset bundling

ornate rivet Feb 22, 2021, 2:53 AM

#

yea

#

that was a scared woah

worn eagle Feb 22, 2021, 2:53 AM

#

🦀PALE COURT IS CANCELLED 🦀

ornate rivet Feb 22, 2021, 2:54 AM

#

ok buddy

copper nacelle Feb 22, 2021, 2:54 AM

#

🦀

worn eagle Feb 22, 2021, 2:54 AM

#

any reason for the name change

ornate rivet Feb 22, 2021, 2:54 AM

#

maybe because hk got updated

copper nacelle Feb 22, 2021, 2:55 AM

#

because someone said hk is shit

ornate rivet Feb 22, 2021, 2:55 AM

#

sigh

#

I wonder if the shader bug in assetbundling is fixed in unity 2020

#

probably right?

charred topaz Feb 22, 2021, 2:55 AM

#

shader bug?

drifting leaf Feb 22, 2021, 2:56 AM

#

People will not uppatch if they can't get pale court

ornate rivet Feb 22, 2021, 2:56 AM

#

the one where we have to manually set the material's shader in game

charred topaz Feb 22, 2021, 2:59 AM

#

I think I ran into that once where the default sprite shader was showing up as a missing shader in-game. I think i fixed it by removing it from the "Always Included Shaders" list

ornate rivet Feb 22, 2021, 2:59 AM

#

ah

worn eagle Feb 22, 2021, 3:00 AM

#

can't wait to subtly roast tc with all my bug reports