#archived-modding-development | Hollow Knight | Page 490

stiff otter Oct 13, 2020, 8:00 PM

#

thanks

vocal spire Oct 13, 2020, 8:00 PM

#

had to explain that multiple times to some people

stiff otter Oct 13, 2020, 8:34 PM

#

@vocal spire im trying to import an example mod into visual studio

#

but its not working because there is only a .csproj and no sln

vocal spire Oct 13, 2020, 8:36 PM

#

Wdym

#

IT WORKS

#

I DID IT

#

I CREATED CUSTOMKNIGHT +

#

@stiff otter send me the link to the example mod github?

stiff otter Oct 13, 2020, 8:39 PM

#

https://github.com/seanpr96/HollowKnight.Modding

GitHub

seanpr96/HollowKnight.Modding

Contribute to seanpr96/HollowKnight.Modding development by creating an account on GitHub.

#

examplemod1

#

I can't add a csproj into my solution for some reason

vocal spire Oct 13, 2020, 8:39 PM

#

📎 image0.png

#

Found a sln

stiff otter Oct 13, 2020, 8:39 PM

#

all i want to do is build to a dll and test if it works unmodified

#

huh

vocal spire Oct 13, 2020, 8:39 PM

#

Just download everything

stiff otter Oct 13, 2020, 8:39 PM

#

there are 3 example mods

vocal spire Oct 13, 2020, 8:40 PM

#

The entire example mods folder

#

Then you get your sln

stiff otter Oct 13, 2020, 8:40 PM

#

ok but I only want one example mod:|

vocal spire Oct 13, 2020, 8:40 PM

#

Just try it

stiff otter Oct 13, 2020, 8:41 PM

#

ok

vocal spire Oct 13, 2020, 8:41 PM

#

(Haven’t tried) I think if you build a project with multiple solutions, they are still separate

stiff otter Oct 13, 2020, 8:41 PM

#

uh

#

It didnt work

vocal spire Oct 13, 2020, 8:41 PM

#

What did you do?

#

Open the sln file?

stiff otter Oct 13, 2020, 8:42 PM

#

It added some stuff but they both say unloaded

#

lemme get a screenshot

#

📎 Capture.PNG

#

they dont have any contents

vocal spire Oct 13, 2020, 8:43 PM

#

Ok.........

#

There is a lot wrong here

#

You didn’t open the sln I showed you

stiff otter Oct 13, 2020, 8:44 PM

#

what do you mean

#

hold on did I fuck up

vocal spire Oct 13, 2020, 8:44 PM

#

You didn’t open the sln I showed you

#

Yes you did

#

You didn’t open the sln I showed you

stiff otter Oct 13, 2020, 8:44 PM

#

oh im so sorry

#

I opened the modding api

#

one second

#

it sort of worked but examplemod1 didnt load

vocal spire Oct 13, 2020, 8:49 PM

#

Screenshot

stiff otter Oct 13, 2020, 8:49 PM

#

project file cannot be found

#

but its right here

#

its no big deal Ill just use the other ones

vocal spire Oct 13, 2020, 8:50 PM

#

And you opened it from the Example Mods folder you downloaded

stiff otter Oct 13, 2020, 8:50 PM

#

yes

vocal spire Oct 13, 2020, 8:50 PM

#

And you didn’t remove anything or change the file structure

stiff otter Oct 13, 2020, 8:50 PM

#

nope

#

its fine

#

ill use examplemod2

vocal spire Oct 13, 2020, 8:50 PM

#

Ok

jolly oriole Oct 13, 2020, 8:51 PM

#

you could try 3, i think that is what i used as a template for my mod

vocal spire Oct 13, 2020, 8:52 PM

#

My templates go wayyy back. I think I used lightbringer as a template for dreamshield, dreamshield as a template for lm, lm as a template for Uuwuu, Uuwuu as a template for another mod, and now that mod as a template for CustomKnight+ since that mod was where I first tested the code I found for making a new tk2dspritecollectiondata

#

No wait

#

I used dreamshield as a template for lolkins and then lolkins as a template for lm

stiff otter Oct 13, 2020, 8:55 PM

#

trying 2 rn

#

YAY

#

it works

#

now to edit stuff

vocal spire Oct 13, 2020, 8:55 PM

#

Yay

stiff otter Oct 13, 2020, 8:57 PM

#

cool it even shows in the modinstaller

#

how do I change the name

#

is that hard

vocal spire Oct 13, 2020, 8:58 PM

#

Change the class name, the file name, the assembly name, and the namespace name

#

And the default namespace

stiff otter Oct 13, 2020, 8:58 PM

#

thanks

vocal spire Oct 13, 2020, 8:58 PM

#

And the solution and project names

stiff otter Oct 13, 2020, 9:00 PM

#

how would I make the base hp 3

#

lmk if there is somewhere on the docs I can look so I dont have to bother you

vocal spire Oct 13, 2020, 9:01 PM

#

Playerdata

#

Best place to set it would be creating a new save so you don’t need to calculate what to set it to every time you load a save

stiff otter Oct 13, 2020, 9:01 PM

#

so with a hook?

vocal spire Oct 13, 2020, 9:02 PM

#

Yes

#

Forgot which one

#

Lightbringer would be a good place to look

stiff otter Oct 13, 2020, 9:02 PM

#

found it

#

thanks

vocal spire Oct 13, 2020, 9:03 PM

#

Putting the finishing touches on ck+/ck2

stiff otter Oct 13, 2020, 9:07 PM

#

one more thing

vocal spire Oct 13, 2020, 9:07 PM

#

Yes?

stiff otter Oct 13, 2020, 9:07 PM

#

is there a way to set how many godseeker hearts a player has?

#

like locked masks

vocal spire Oct 13, 2020, 9:07 PM

#

Idk

stiff otter Oct 13, 2020, 9:07 PM

#

ok

jolly oriole Oct 13, 2020, 9:08 PM

#

yes

stiff otter Oct 13, 2020, 9:08 PM

#

how

jolly oriole Oct 13, 2020, 9:08 PM

#

why did i delete my message where i detailed that

vocal spire Oct 13, 2020, 9:08 PM

#

Idk

#

Why did you delete your messages

#

lol

stiff otter Oct 13, 2020, 9:08 PM

#

also if you know what is the difference between max base health and max health

vocal spire Oct 13, 2020, 9:09 PM

#

Max base health is the max health you can have without lifeblood I think

#

Idk

jolly oriole Oct 13, 2020, 9:09 PM

#

max base health is your max health without extra hearts from the hearts charm

stiff otter Oct 13, 2020, 9:09 PM

#

ok

#

so how do you add locked hearts

#

godseeker hearts

vocal spire Oct 13, 2020, 9:10 PM

#

Why would you need to do that?

#

Oh

#

I think I see what you are saying

stiff otter Oct 13, 2020, 9:10 PM

#

I want to make a mod where when you take damage twice you lose a max mask

#

but not perminantly

vocal spire Oct 13, 2020, 9:11 PM

#

Oh

stiff otter Oct 13, 2020, 9:11 PM

#

I could do it with save data but that seems hard

vocal spire Oct 13, 2020, 9:11 PM

#

Why do you need to remove godseeker masks then?

#

The only way to do it is with save data

stiff otter Oct 13, 2020, 9:11 PM

#

I would want to add a godseeker mask when you take damage twice

vocal spire Oct 13, 2020, 9:11 PM

#

Oh

stiff otter Oct 13, 2020, 9:11 PM

#

and then remove them all when you hit a bench

jolly oriole Oct 13, 2020, 9:12 PM

#

i think the godseeker masks isn't the option, as saving the current max masks in the mod and setting save data masks accordingly is the better option

stiff otter Oct 13, 2020, 9:12 PM

#

ok

#

thanks

#

actually Ill just save how many masks have been lost in game data and then re-add them so that I dont have to deal with charms or anything

#

would thank break stuff?

vocal spire Oct 13, 2020, 9:13 PM

#

Wdym re add them

stiff otter Oct 13, 2020, 9:13 PM

#

like if youve lost 2 of your max health

#

all I need to do when you hit a bench is add exactly 2 to your max health

vocal spire Oct 13, 2020, 9:14 PM

#

Well, if you have edited save data and don’t have settings, then you don’t know what the max health should be

#

Or are you just going to store the number of lost masks in a int or something

stiff otter Oct 13, 2020, 9:14 PM

#

yeah

vocal spire Oct 13, 2020, 9:14 PM

#

Ok

#

Then you should be good

#

Unless

#

The player uses alt f4

stiff otter Oct 13, 2020, 9:14 PM

#

oh hold on

#

it saves your max masks so yeah

#

ill just use savedata

vocal spire Oct 13, 2020, 9:15 PM

#

more confusion

#

Mod settings?

stiff otter Oct 13, 2020, 9:18 PM

#

yeah

#

sorry

vocal spire Oct 13, 2020, 9:18 PM

#

Ok

#

Good

stiff otter Oct 13, 2020, 9:18 PM

#

also hollow knight is now not loading

#

what

vocal spire Oct 13, 2020, 9:19 PM

#

Wait a while

stiff otter Oct 13, 2020, 9:19 PM

#

does that mean I fucked up

vocal spire Oct 13, 2020, 9:19 PM

#

Probably not

#

If you did, you can check the modlog

stiff otter Oct 13, 2020, 9:20 PM

#

its just sitting on the main title screen with no menu

vocal spire Oct 13, 2020, 9:20 PM

#

Oh

#

Null reference exception

#

Did you try to access player data in initialize by chance?

stiff otter Oct 13, 2020, 9:20 PM

#

no

jolly oriole Oct 13, 2020, 9:20 PM

#

something maybe killed the camera

stiff otter Oct 13, 2020, 9:20 PM

#

I made a modhook

#

imma try disabling and running

#

same thing

#

mod isnt running

vocal spire Oct 13, 2020, 9:21 PM

#

?

#

Then it’s another mod

stiff otter Oct 13, 2020, 9:22 PM

#

huh

#

one sec

#

I think I fucked up my mod folder

#

is there a way to reset it

vocal spire Oct 13, 2020, 9:24 PM

#

What

#

Screenshot

#

Also no

stiff otter Oct 13, 2020, 9:24 PM

#

FUCK

vocal spire Oct 13, 2020, 9:24 PM

#

Screenshot

stiff otter Oct 13, 2020, 9:24 PM

#

screenshot what

vocal spire Oct 13, 2020, 9:24 PM

#

The mods folder

stiff otter Oct 13, 2020, 9:24 PM

#

ok

#

📎 Capture1.PNG

vocal spire Oct 13, 2020, 9:25 PM

#

So?

#

You are missing Vasi

#

That’s the problem

stiff otter Oct 13, 2020, 9:25 PM

#

oh

#

thanks

#

thank you so much it worked

#

my mod doesnt tho

#

weird

#

the docs say NewGameHandler takes an int but c# says it doesnt

vocal spire Oct 13, 2020, 9:33 PM

#

did you use the wrong hook?

stiff otter Oct 13, 2020, 9:37 PM

#

nope the mod log does my things

#

my guess is that the game sets the maxhealth after that hook which would be annoying

#

it does ugh

stiff otter Oct 13, 2020, 9:58 PM

#

got it to work yay

#

@vocal spire sorry to bother again but is there any way to check if the player hits a bench?

#

like rests on it

vocal spire Oct 13, 2020, 10:14 PM

#

Yes there is a hook for it somewhere I tgink

jolly oriole Oct 13, 2020, 10:14 PM

#

some save game save hook

vocal spire Oct 13, 2020, 10:14 PM

#

There’s like a million

jolly oriole Oct 13, 2020, 10:14 PM

#

BeforeSavegameSaveHook

vocal spire Oct 13, 2020, 10:15 PM

#

Anyway, CustomKnight+ is almost done other than adding stuff people can copy for the enums in it

stiff otter Oct 13, 2020, 10:18 PM

#

so the save game hook only happens when you do a bench?

vocal spire Oct 13, 2020, 10:18 PM

#

No

stiff otter Oct 13, 2020, 10:18 PM

#

it happens other times right like when you enter the city

#

so hmm

vocal spire Oct 13, 2020, 10:18 PM

#

Any time it is before the game saves

stiff otter Oct 13, 2020, 10:18 PM

#

when does the game save

vocal spire Oct 13, 2020, 10:19 PM

#

Ex: quitting the game

stiff otter Oct 13, 2020, 10:19 PM

#

it does it all the time rihgt

#

like when you grab any item

vocal spire Oct 13, 2020, 10:19 PM

#

Just exiting and benching

#

I don’t think so

stiff otter Oct 13, 2020, 10:19 PM

#

then how come items are saved if you get one and then quit

#

OOOOH

#

yeah that makes sense

vocal spire Oct 13, 2020, 10:20 PM

#

Time to finish CustomKnight+!

stiff otter Oct 13, 2020, 10:20 PM

#

what is it

vocal spire Oct 13, 2020, 10:20 PM

#

Use your own spritesheets to make animations

#

Think CustomKnight but better

#

But it only supports animations on the knight rn

#

I have a idea for more though

stiff otter Oct 13, 2020, 11:54 PM

#

I dont know what custom knight is but that sounds cool

vocal spire Oct 13, 2020, 11:55 PM

#

I feel sorry for you

stiff otter Oct 13, 2020, 11:55 PM

#

how do you resprite content anyway

vocal spire Oct 13, 2020, 11:55 PM

#

......

stiff otter Oct 13, 2020, 11:55 PM

#

like what if I wanted to make all of greenpath dead for some reason

vocal spire Oct 13, 2020, 11:55 PM

#

Ok that’s different

#

Have you seen skins

stiff otter Oct 13, 2020, 11:55 PM

#

ive seen player skins

#

like the hollow knight skin

#

and the radiance skin

vocal spire Oct 13, 2020, 11:56 PM

#

Yeah

#

Have you ever wondered how people made those?

stiff otter Oct 13, 2020, 11:56 PM

#

I am right now

vocal spire Oct 13, 2020, 11:56 PM

#

CustomKnight

stiff otter Oct 13, 2020, 11:56 PM

#

ok

#

is it a mod?

#

is it a program?

vocal spire Oct 13, 2020, 11:56 PM

#

........................

stiff otter Oct 13, 2020, 11:57 PM

#

bruh

#

im new to this ok

vocal spire Oct 13, 2020, 11:57 PM

#

Mod

#

It’s the most common mod I have seen people ask for

stiff otter Oct 13, 2020, 11:57 PM

#

ok

#

so can you resprite other stuff

vocal spire Oct 13, 2020, 11:57 PM

#

Yes

stiff otter Oct 13, 2020, 11:57 PM

#

like how does customknight work

vocal spire Oct 13, 2020, 11:58 PM

#

You put sprite sheets in a certain spot

#

And it reads them and replaces the originals

stiff otter Oct 13, 2020, 11:58 PM

#

oh

#

so you have to mess with files in your code

#

sounds like a pain

vocal spire Oct 13, 2020, 11:58 PM

#

Look at how jngo did it

#

I actually did it in 2 lines

stiff otter Oct 13, 2020, 11:59 PM

#

jngo

#

is that a mod

vocal spire Oct 13, 2020, 11:59 PM

#

Bruh

stiff otter Oct 13, 2020, 11:59 PM

#

dont laugh

#

im new to modding

#

I only got into it because I wanted to make my own

vocal spire Oct 13, 2020, 11:59 PM

#

Used to be modding staff but left to take a break or something

#

Ok

#

They made a lot of mods and updated CustomKnight to what it is today

stiff otter Oct 14, 2020, 12:00 AM

#

so you made a fork of it?

vocal spire Oct 14, 2020, 12:00 AM

#

No.....

#

Completely different mod with completely different code

stiff otter Oct 14, 2020, 12:00 AM

#

oh

#

ok anyway

#

im having a weird problem

#

it seems like the area where you land somehow sets your maxhealth back to 5 in certain cases

vocal spire Oct 14, 2020, 12:02 AM

#

The area where you start the game?

#

Like, when you land there it resets the health?

stiff otter Oct 14, 2020, 12:02 AM

#

like It will show as 3 but if I die in kings pass it then respawns me at 3, but then it fills up to 5 again as I walk forward

vocal spire Oct 14, 2020, 12:02 AM

#

Well

stiff otter Oct 14, 2020, 12:02 AM

#

Its so strange

vocal spire Oct 14, 2020, 12:02 AM

#

The game saves

#

When you die

stiff otter Oct 14, 2020, 12:03 AM

#

I have it so it saves the right health amount

#

and it actually works

vocal spire Oct 14, 2020, 12:03 AM

#

?

stiff otter Oct 14, 2020, 12:03 AM

#

but when I walk forward it fills back up

vocal spire Oct 14, 2020, 12:03 AM

#

I’m not getting the problem

stiff otter Oct 14, 2020, 12:03 AM

#

like I respawn at 3 mhp and then it fills up to 5 for no reason

#

ill get a video

vocal spire Oct 14, 2020, 12:03 AM

#

Oh

#

I remember now

stiff otter Oct 14, 2020, 12:04 AM

#

what

#

is there a trigger there that does that

vocal spire Oct 14, 2020, 12:04 AM

#

You said you reduced the health to 3

stiff otter Oct 14, 2020, 12:04 AM

#

max health yes

vocal spire Oct 14, 2020, 12:04 AM

#

I forgot you said that

stiff otter Oct 14, 2020, 12:04 AM

#

yeah sorry

#

but you dont know what the thing causing that is

vocal spire Oct 14, 2020, 12:05 AM

#

And you set all max health values correctly?

stiff otter Oct 14, 2020, 12:05 AM

#

I assume

#

Im just setting PlayerData.instance.maxHealth

#

should I set base max health too

vocal spire Oct 14, 2020, 12:06 AM

#

Probably

stiff otter Oct 14, 2020, 12:06 AM

#

ok

#

nope

#

it happens even with other benches

#

but I haven't tried setting the base health yet

vocal spire Oct 14, 2020, 12:19 AM

#

Then it’s probably the base health since the problem is consistent

stiff otter Oct 14, 2020, 12:20 AM

#

ok

#

uhhhh

#

my screen is black now for no reason

vocal spire Oct 14, 2020, 12:20 AM

#

Starting up hk?

#

That’s normal

stiff otter Oct 14, 2020, 12:20 AM

#

im in game

vocal spire Oct 14, 2020, 12:21 AM

#

Oh

stiff otter Oct 14, 2020, 12:21 AM

#

debug menu works and shows im moving around

vocal spire Oct 14, 2020, 12:21 AM

#

Hmm

#

Did you accidentally modify anything else?

stiff otter Oct 14, 2020, 12:21 AM

#

I added debug mod

#

ill see if that was the issue

#

yes it was

#

for some reason

vocal spire Oct 14, 2020, 12:23 AM

#

Strange

#

We’re any other mods enabled other than yours and debug?

stiff otter Oct 14, 2020, 12:23 AM

#

yeah

#

hpbar and qol

vocal spire Oct 14, 2020, 12:24 AM

#

And Vasi?

stiff otter Oct 14, 2020, 12:24 AM

#

oh yeah

#

wait

vocal spire Oct 14, 2020, 12:24 AM

#

And modcommon?

stiff otter Oct 14, 2020, 12:24 AM

#

I think?

#

and yeah modcommon

#

Ok my understanding of how max health works is getting worse and worse

#

so its not reducing the max health when you take damage

vocal spire Oct 14, 2020, 12:25 AM

#

Yeah

stiff otter Oct 14, 2020, 12:25 AM

#

but for some reason it resetting to 2 when I respawn

vocal spire Oct 14, 2020, 12:25 AM

#

Wait

stiff otter Oct 14, 2020, 12:25 AM

#

so somewhere it got set to 2

vocal spire Oct 14, 2020, 12:25 AM

#

I

stiff otter Oct 14, 2020, 12:25 AM

#

but only actually updates when I respawn

vocal spire Oct 14, 2020, 12:26 AM

#

Think there is a method in HeroController

#

The numbers are correct

#

The ui isn’t updating

stiff otter Oct 14, 2020, 12:26 AM

#

ok

#

is there a way to do that

vocal spire Oct 14, 2020, 12:26 AM

#

Think there is a method in HeroController
@vocal spire

stiff otter Oct 14, 2020, 12:27 AM

#

ill look

#

theres nothing in HeroController or UiManager

#

at least that I can find

vocal spire Oct 14, 2020, 12:30 AM

#

really?
HeroController.instance.AddHealth(-1);

stiff otter Oct 14, 2020, 12:30 AM

#

ok

#

I thought you meant to update ui

#

but using a method to take stuff makes more sense?

#

except whats the method for taking max hp

vocal spire Oct 14, 2020, 12:31 AM

#

I said it was a method on herocontroller

#

why would they need one?

#

hmm

stiff otter Oct 14, 2020, 12:31 AM

#

idk

#

I do

vocal spire Oct 14, 2020, 12:31 AM

#

I see your point

stiff otter Oct 14, 2020, 12:31 AM

#

:(

vocal spire Oct 14, 2020, 12:31 AM

#

open dnspy

stiff otter Oct 14, 2020, 12:31 AM

#

what

#

HA

#

there is one!

vocal spire Oct 14, 2020, 12:32 AM

#

what is it?

stiff otter Oct 14, 2020, 12:32 AM

#

AddToMaxHealth() :|

#

should have checked first

vocal spire Oct 14, 2020, 12:32 AM

#

lol

#

I just saw it as you sent that message

stiff otter Oct 14, 2020, 12:34 AM

#

well

#

I really hope team cherry made it so negatives work

#

one more thing

vocal spire Oct 14, 2020, 12:35 AM

#

yes?

stiff otter Oct 14, 2020, 12:35 AM

#

how do I use monobehaviour stuff

vocal spire Oct 14, 2020, 12:35 AM

#

wdym

stiff otter Oct 14, 2020, 12:35 AM

#

It says I need to add a using

#

but I cant add the using they want

vocal spire Oct 14, 2020, 12:35 AM

#

using UnityEngine;

stiff otter Oct 14, 2020, 12:35 AM

#

hmm

#

doesnt work

vocal spire Oct 14, 2020, 12:35 AM

#

do you have a reference to UnityEngine.dll

#

and UnityEngine.CoreModule.dll

stiff otter Oct 14, 2020, 12:36 AM

#

how do I do that

#

Im very c# references illerate

vocal spire Oct 14, 2020, 12:36 AM

#

what c# ide are you on

stiff otter Oct 14, 2020, 12:36 AM

#

vs community

vocal spire Oct 14, 2020, 12:36 AM

#

right click references

#

click add

#

click browse

stiff otter Oct 14, 2020, 12:36 AM

#

oh yeah I can just do that

vocal spire Oct 14, 2020, 12:36 AM

#

go to the managed folder of hk

stiff otter Oct 14, 2020, 12:36 AM

#

Ive been using code so long

#

thanks

vocal spire Oct 14, 2020, 12:36 AM

#

np lol

stiff otter Oct 14, 2020, 12:47 AM

#

ugh

#

same thing

#

it doesnt update when you get hit

#

but does when you respawn

vocal spire Oct 14, 2020, 12:48 AM

#

hmm

stiff otter Oct 14, 2020, 12:48 AM

#

maybe my mod just isnt possible

vocal spire Oct 14, 2020, 12:48 AM

#

it is

#

let's try updating it manually

stiff otter Oct 14, 2020, 12:48 AM

#

wdym

vocal spire Oct 14, 2020, 12:48 AM

#

call the update yourself

stiff otter Oct 14, 2020, 12:49 AM

#

the ui update?

vocal spire Oct 14, 2020, 12:49 AM

#

yeah

stiff otter Oct 14, 2020, 12:49 AM

#

wonder how to do that

vocal spire Oct 14, 2020, 12:49 AM

#

fsm

stiff otter Oct 14, 2020, 12:49 AM

#

ive read about fsm

#

its playmaker right?

#

something to do with that?

vocal spire Oct 14, 2020, 12:49 AM

#

yeah

stiff otter Oct 14, 2020, 12:50 AM

#

did team cherry really use it for ui?

vocal spire Oct 14, 2020, 12:50 AM

#

probably

#

they used it for a lot

stiff otter Oct 14, 2020, 12:50 AM

#

rip

vocal spire Oct 14, 2020, 12:50 AM

#

they used to use it for enemy health

#

luckily they changed to monobehaviour

stiff otter Oct 14, 2020, 12:51 AM

#

huh

vocal spire Oct 14, 2020, 12:51 AM

#

I don't blame them for using it though, it costs a good amount

stiff otter Oct 14, 2020, 12:51 AM

#

Ive never really gotten why you would wanna use something like that

vocal spire Oct 14, 2020, 12:51 AM

#

because it makes making ai easier

stiff otter Oct 14, 2020, 12:51 AM

#

personally I just feel like I would want to make a system myself

#

less I have to look up

#

But who knows

#

alright I got the veiwer

jolly oriole Oct 14, 2020, 12:53 AM

#

you guys know that addhealth is for healing, and takehealth is for taking damage?

stiff otter Oct 14, 2020, 12:53 AM

#

is there takemaxhp?

jolly oriole Oct 14, 2020, 12:53 AM

#

public void AddToMaxHealth(int amount)

vocal spire Oct 14, 2020, 12:53 AM

#

yeah

#

it didn't update the ui

stiff otter Oct 14, 2020, 12:54 AM

#

doesnt work

#

I opened the healthdisplay in fsm

vocal spire Oct 14, 2020, 12:55 AM

#

which one

stiff otter Oct 14, 2020, 12:55 AM

#

10

vocal spire Oct 14, 2020, 12:55 AM

#

lol

#

ok

stiff otter Oct 14, 2020, 12:55 AM

#

why are there 10

#

what the fuck tc

jolly oriole Oct 14, 2020, 12:56 AM

#

there are 11

vocal spire Oct 14, 2020, 12:56 AM

#

yeah

stiff otter Oct 14, 2020, 12:56 AM

#

yeah

#

wtf

vocal spire Oct 14, 2020, 12:56 AM

#

probably removed

stiff otter Oct 14, 2020, 12:56 AM

#

so which is real

vocal spire Oct 14, 2020, 12:56 AM

#

maybe they were from a unused area

jolly oriole Oct 14, 2020, 12:56 AM

#

one for each mask that one can get in the base game

vocal spire Oct 14, 2020, 12:56 AM

#

all of them

stiff otter Oct 14, 2020, 12:56 AM

#

no fucking way

#

this hurts

#

I thought they were good at programming

jolly oriole Oct 14, 2020, 12:56 AM

#

it's all the same fsm

#

just different variables

stiff otter Oct 14, 2020, 12:57 AM

#

still

vocal spire Oct 14, 2020, 12:57 AM

#

you know you can broadcast a message to all of them at once(I think)

stiff otter Oct 14, 2020, 12:57 AM

#

so what am I even doing when I change stuff

vocal spire Oct 14, 2020, 12:57 AM

#

wdym

stiff otter Oct 14, 2020, 12:57 AM

#

like what do i need to do to update them through code

#

why am I here

vocal spire Oct 14, 2020, 12:57 AM

#

send a event to the fsm

#

well

#

you can leave if you want

stiff otter Oct 14, 2020, 12:58 AM

#

So do I need to change anything inside the fsm viewer

vocal spire Oct 14, 2020, 12:58 AM

#

you can't

stiff otter Oct 14, 2020, 12:58 AM

#

ok

#

I see

vocal spire Oct 14, 2020, 12:58 AM

#

if you were able to modify the asset files, then it wouldn't be a good mod

stiff otter Oct 14, 2020, 12:58 AM

#

oh I found the docs part for this

#

lemme see if I can do it on my own

vocal spire Oct 14, 2020, 12:58 AM

#

k

stiff otter Oct 14, 2020, 1:02 AM

#

me brains are hurtin

#

I think I get what this is

#

so if I just set the state to checkmaxhp I can update all of them

#

but that sounds real unstable

#

OR

#

I could add a state that checks the max hp after it gets damaged

#

before pause frame

#

would that work?

jolly oriole Oct 14, 2020, 1:05 AM

#

of each health?

stiff otter Oct 14, 2020, 1:05 AM

#

yes

jolly oriole Oct 14, 2020, 1:05 AM

#

the eaiser method of those is setting the state, but i would set the state to reinit

#

or whatever it was called

stiff otter Oct 14, 2020, 1:05 AM

#

would that break anything that was currently happening?

vocal spire Oct 14, 2020, 1:05 AM

#

might

stiff otter Oct 14, 2020, 1:05 AM

#

it seems like it could cause alot of glitches

#

the more stable method seems to be to just change the fsm

jolly oriole Oct 14, 2020, 1:06 AM

#

wouldn't be the first mod to break stuff lol

vocal spire Oct 14, 2020, 1:06 AM

#

but what would be happening to them

stiff otter Oct 14, 2020, 1:06 AM

#

I bet I can manage it

#

haha yeah but Id like it to be playable

#

at least sort of stable

jolly oriole Oct 14, 2020, 1:07 AM

#

i don't like FSMs, which is why i made classes/function that others can use so they don't interact with FSMs

stiff otter Oct 14, 2020, 1:08 AM

#

like a mod core?

#

honestly I would rather do it myself

jolly oriole Oct 14, 2020, 1:08 AM

#

https://github.com/SFGrenade/SFCore/blob/master/SFCore/CharmHelper.cs
no, you don't want to do stuff like this yourself

stiff otter Oct 14, 2020, 1:08 AM

#

mm

#

it looks fine

#

what could possibly go wrong

vocal spire Oct 14, 2020, 1:09 AM

#

everything

stiff otter Oct 14, 2020, 1:09 AM

#

and nothing more

#

seems like a good deal

jolly oriole Oct 14, 2020, 1:09 AM

#

btw @vocal spire how far are the additional inventory spaces?

vocal spire Oct 14, 2020, 1:09 AM

#

not far

jolly oriole Oct 14, 2020, 1:09 AM

#

pog

vocal spire Oct 14, 2020, 1:10 AM

#

I had an idea for another type of item tho

#

and that has been taking up my time

#

I got it working once

#

but once I added multiple, it didn't work

#

I even reverted my code, and it still wouldn't work

jolly oriole Oct 14, 2020, 1:10 AM

#

another type of item
as in "another item" or an actual new type of item?

vocal spire Oct 14, 2020, 1:10 AM

#

a new type of added item

#

sellable items/relics

#

I was able to add one to the shop

stiff otter Oct 14, 2020, 1:11 AM

#

wow

vocal spire Oct 14, 2020, 1:11 AM

#

then my previous messages happened

jolly oriole Oct 14, 2020, 1:11 AM

#

(for the player to buy or to sell?)

vocal spire Oct 14, 2020, 1:11 AM

#

sell

#

I call it shop because that's what it's called in the code

stiff otter Oct 14, 2020, 1:11 AM

#

I didnt know you could even make new content

vocal spire Oct 14, 2020, 1:11 AM

#

you can add new rooms

#

you can do basically anything now

jolly oriole Oct 14, 2020, 1:12 AM

#

ah ok, so like those ancient eggs

stiff otter Oct 14, 2020, 1:12 AM

#

wow really?

vocal spire Oct 14, 2020, 1:12 AM

#

yeah

stiff otter Oct 14, 2020, 1:12 AM

#

add new rooms?

#

damn

vocal spire Oct 14, 2020, 1:12 AM

#

yes

#

anyone is actually making a mod about that

#

there is also pale court

#

pale court is really big

stiff otter Oct 14, 2020, 1:12 AM

#

ever realize that a tool has too much utility that you don't have time for it

jolly oriole Oct 14, 2020, 1:13 AM

#

not only new rooms, but also abominations of rooms that expand dynamically the further you go

stiff otter Oct 14, 2020, 1:13 AM

#

I could add so much

vocal spire Oct 14, 2020, 1:13 AM

#

oh yeah forgot that one

stiff otter Oct 14, 2020, 1:13 AM

#

Which is stressful

vocal spire Oct 14, 2020, 1:13 AM

#

that room is fun

stiff otter Oct 14, 2020, 1:13 AM

#

Goddammit

vocal spire Oct 14, 2020, 1:13 AM

#

gonna use that room when I contemplate my life when code won't work

jolly oriole Oct 14, 2020, 1:13 AM

#

https://www.youtube.com/watch?v=CL5nNLNtXzo for reference

YouTube

SuperFlashGrenade

TestOfTeamwork Development Update [Hollow Knight]

Things are going along nicely

A scene, which dynamically enlarges the further you go.

▶ Play video

stiff otter Oct 14, 2020, 1:14 AM

#

now Im gonna spend 2 years making a complete hollowknight mix up and never finish it

#

wait

vocal spire Oct 14, 2020, 1:14 AM

#

k I'm gonna continue testing why a 100 pixel image isn't showing up as big as I hoped in customknight+

stiff otter Oct 14, 2020, 1:14 AM

#

Can I make bosses appear in different places

vocal spire Oct 14, 2020, 1:15 AM

#

yes

#

ez

stiff otter Oct 14, 2020, 1:15 AM

#

YOOO

vocal spire Oct 14, 2020, 1:15 AM

#

one of the easiest things to do

stiff otter Oct 14, 2020, 1:15 AM

#

but wouldnt it mess up the animations?

jolly oriole Oct 14, 2020, 1:15 AM

#

@vocal spire yep, there is something going on with the images in game vs otherwise imported

vocal spire Oct 14, 2020, 1:15 AM

#

making some of them work correctly tho

stiff otter Oct 14, 2020, 1:15 AM

#

Ive seen randomizers do it and have everything kinda

#

be broken

vocal spire Oct 14, 2020, 1:16 AM

#

animations are fine

#

it's the fsms that have pre determined positions for stuff

#

that mess stuff up

stiff otter Oct 14, 2020, 1:16 AM

#

so what if I wanted to have soul warrior where false knight is

#

that would be hard right?

vocal spire Oct 14, 2020, 1:16 AM

#

not hard

#

just edit where he can teleport to

stiff otter Oct 14, 2020, 1:16 AM

#

what about the death animation?

vocal spire Oct 14, 2020, 1:16 AM

#

no problem

stiff otter Oct 14, 2020, 1:16 AM

#

how he breaks the ground?

#

Dude

vocal spire Oct 14, 2020, 1:17 AM

#

I think you mean soul master

stiff otter Oct 14, 2020, 1:17 AM

#

I mean soul warrior

vocal spire Oct 14, 2020, 1:17 AM

#

but

#

he doesn't break the ground

stiff otter Oct 14, 2020, 1:17 AM

#

Like it would be cool to have two soul warriors instead of false knight

#

false knight breaks the ground

vocal spire Oct 14, 2020, 1:17 AM

#

ok

#

OHHHHH

stiff otter Oct 14, 2020, 1:17 AM

#

yeah

vocal spire Oct 14, 2020, 1:17 AM

#

yeah that would be kind of hard

stiff otter Oct 14, 2020, 1:17 AM

#

so maybe not for false knight

vocal spire Oct 14, 2020, 1:18 AM

#

can still be done

stiff otter Oct 14, 2020, 1:18 AM

#

goddammit

#

this rabbit hole is deeper than I thought

#

I wanted this to just be a fun side thing

jolly oriole Oct 14, 2020, 1:18 AM

#

yep, with soul warrior you only need to edit the fsm variables where he can teleport (min and max X value)

vocal spire Oct 14, 2020, 1:18 AM

#

imagine putting soul master in though

stiff otter Oct 14, 2020, 1:19 AM

#

That would be interesting

#

but you cant beat him without dash

vocal spire Oct 14, 2020, 1:19 AM

#

k

#

make him slow then

stiff otter Oct 14, 2020, 1:19 AM

#

maybe

vocal spire Oct 14, 2020, 1:19 AM

#

lol

#

but

stiff otter Oct 14, 2020, 1:19 AM

#

basically I want to make a hollow knight export mode

vocal spire Oct 14, 2020, 1:19 AM

#

where is the city crest

#

k

#

that's not a small project

stiff otter Oct 14, 2020, 1:20 AM

#

yes

#

i know

#

well

#

It would be if I didn't change much

#

but now that I can

#

im tempted to

#

I was just thinking that the new health mechanics would do most of the heavylifting

#

and I then make the main bosses as fast as their harder versions

vocal spire Oct 14, 2020, 1:21 AM

#

ok

#

then pair the double versions with mini bosses

#

lol

stiff otter Oct 14, 2020, 1:22 AM

#

but yeah its likely never going to be finished as It will be a much bigger project than I expect it to

vocal spire Oct 14, 2020, 1:22 AM

#

lol

stiff otter Oct 14, 2020, 1:22 AM

#

but thats ok because I have other projects I will finish, this is just for fun

vocal spire Oct 14, 2020, 1:23 AM

#

while we are on the topic of big mods that will never be finished

#

I had an idea for a holloween mod collaboration between most of the modders to make a sort of candy hunt where you must find more and more of them to get prizes from elderbug or someone

#

maybe a rogue member of the grimm troupe since nightmares and halloween go well together

stiff otter Oct 14, 2020, 1:25 AM

#

sounds big

vocal spire Oct 14, 2020, 1:25 AM

#

maybe more stuff like enemies protecting them

#

again, why I suggested a large collaboration

stiff otter Oct 14, 2020, 1:25 AM

#

but im sure you can finish it in 17 days right?

#

i wonder if somebody could mod hollow knight into silksong before silksong releases

#

ok back to modding

#

where do I modify fsm

vocal spire Oct 14, 2020, 1:25 AM

#

code

#

reference modcommon or vasi

stiff otter Oct 14, 2020, 1:26 AM

#

yes but

#

in instance?

#

ok

vocal spire Oct 14, 2020, 1:26 AM

#

wdym in instance?

stiff otter Oct 14, 2020, 1:26 AM

#

initalize

vocal spire Oct 14, 2020, 1:26 AM

#

not at all

stiff otter Oct 14, 2020, 1:26 AM

#

oh

#

ill look in modcommon

vocal spire Oct 14, 2020, 1:27 AM

#

k

#

using Modcommon.Util;

#

then you have access to all the fsm stuff

stiff otter Oct 14, 2020, 1:27 AM

#

it seems like you need to use a monobehaviour?

vocal spire Oct 14, 2020, 1:28 AM

#

no

#

you need the ActiveSceneChanged Hook on UnityEngine.SceneManagement.SceneManager

#

I think

stiff otter Oct 14, 2020, 1:28 AM

#

ugh

vocal spire Oct 14, 2020, 1:28 AM

#

can be on a monobehaviour

stiff otter Oct 14, 2020, 1:28 AM

#

ok

#

how do I find the vasi source

#

@jolly oriole how do I use sfcore

vocal spire Oct 14, 2020, 1:36 AM

#

why

stiff otter Oct 14, 2020, 1:36 AM

#

im trying it

vocal spire Oct 14, 2020, 1:36 AM

#

why do you need vasi and why do you need sfcore?

jolly oriole Oct 14, 2020, 1:36 AM

#

reference it in the project, then you can do stuff like

SFCore.whateverthefuckinamedtheclasses.function

stiff otter Oct 14, 2020, 1:36 AM

#

I was gonna look at vasi for reference but

#

@jolly oriole I did and i cant find anything useful

vocal spire Oct 14, 2020, 1:37 AM

#

are you adding a item charm or achievement or player footprint?

stiff otter Oct 14, 2020, 1:37 AM

#

you said it has functions for fsm?

vocal spire Oct 14, 2020, 1:37 AM

#

wait

#

did you say their own helper mod wasn't useful?

#

lol

jolly oriole Oct 14, 2020, 1:37 AM

#

i said that i did stuff with fsm, but functions for fsm has ModCommon

#

which i used

#

alot

stiff otter Oct 14, 2020, 1:37 AM

#

so its in modcommon

vocal spire Oct 14, 2020, 1:38 AM

#

or vasi

#

but from my use vasi is a bit more complicated

stiff otter Oct 14, 2020, 1:38 AM

#

what does vasi do

jolly oriole Oct 14, 2020, 1:38 AM

#

does vasi have fsm stuff?

vocal spire Oct 14, 2020, 1:38 AM

#

yes

#

got angry when it conflicted when i had to use both it and modcommon

#

pretty much identical though from what I have seen

#

now to find out why my globalsettings didn't load

stiff otter Oct 14, 2020, 1:39 AM

#

ok so where do I use vasi

#

like when do I set the actions and all that

#

thats all I need to know

vocal spire Oct 14, 2020, 1:40 AM

#

you can use both vasi and modcommon

#

why the sudden switch?

stiff otter Oct 14, 2020, 1:40 AM

#

just trying stuff

vocal spire Oct 14, 2020, 1:40 AM

#

ok

stiff otter Oct 14, 2020, 1:40 AM

#

It seems the most promising at the moment

#

I found the methods

#

I just need to know when to use them

vocal spire Oct 14, 2020, 1:41 AM

#

but modcommon has pretty much the same methods

stiff otter Oct 14, 2020, 1:41 AM

#

couldnt find them

#

the point still stands

vocal spire Oct 14, 2020, 1:41 AM

#

in dnspy?

stiff otter Oct 14, 2020, 1:41 AM

#

w h e n

vocal spire Oct 14, 2020, 1:41 AM

#

well

#

you find the object the fsm is on

#

you use the LocateMyFSM(fsm name) method on it

stiff otter Oct 14, 2020, 1:42 AM

#

stop

#

thats how

#

i need when

vocal spire Oct 14, 2020, 1:42 AM

#

?

#

well

stiff otter Oct 14, 2020, 1:42 AM

#

like when do I modify the values in the first place

#

at init?

vocal spire Oct 14, 2020, 1:42 AM

#

when the object is active

stiff otter Oct 14, 2020, 1:42 AM

#

Ok

vocal spire Oct 14, 2020, 1:43 AM

#

you can only modify it when it isn't null

stiff otter Oct 14, 2020, 1:43 AM

#

hmm

vocal spire Oct 14, 2020, 1:43 AM

#

because if it's null, well, it's null

stiff otter Oct 14, 2020, 1:43 AM

#

so I need to find out how to access the health stuff

vocal spire Oct 14, 2020, 1:43 AM

#

you need the ActiveSceneChanged Hook on UnityEngine.SceneManagement.SceneManager
@vocal spire

stiff otter Oct 14, 2020, 1:44 AM

#

ugh

#

I couldnt find that

#

Ive used it before in unity but it doesnt exist here

vocal spire Oct 14, 2020, 1:44 AM

#

should work when paired with an IEnumerator with a WaitWhile(()=>!GameObject.Find(object name))

#

wdym

stiff otter Oct 14, 2020, 1:44 AM

#

that hook doesnt exist on SceneManager

vocal spire Oct 14, 2020, 1:44 AM

#

it does

#

I have used it

stiff otter Oct 14, 2020, 1:44 AM

#

hold on

vocal spire Oct 14, 2020, 1:44 AM

#

others have used it

stiff otter Oct 14, 2020, 1:45 AM

#

wait

#

oh

vocal spire Oct 14, 2020, 1:45 AM

#

you can also use On.HeroController.Start

stiff otter Oct 14, 2020, 1:46 AM

#

I need to specify scenemanagement.scenemanager because there seems to be another class with the same name

#

who would do that

vocal spire Oct 14, 2020, 1:46 AM

#

since the fsms likely persist through scene transitions

#

?

#

idk, did you reference it twice?

stiff otter Oct 14, 2020, 1:46 AM

#

ugh idk cheif

#

scenemanager is weird and isnt the unity one

vocal spire Oct 14, 2020, 1:47 AM

#

which one is it?

stiff otter Oct 14, 2020, 1:47 AM

#

I was right

#

its the wrong one

#

but for some reason i have to do UnityEngine.SceneManagement.SceneManager and not just SceneManagement.SceneManager

vocal spire Oct 14, 2020, 1:48 AM

#

I mean, that's what we do

stiff otter Oct 14, 2020, 1:48 AM

#

weird

vocal spire Oct 14, 2020, 1:48 AM

#

idk where you got SceneManagement alone from but it doesn't exist for me

stiff otter Oct 14, 2020, 1:49 AM

#

yeah I guess c# is just weird like that

#

you have to do the whole thing

#

how do I get the name of the fsm

#

is it the exact same as the on in the fsm viewer

vocal spire Oct 14, 2020, 1:56 AM

#

yes

#

except for some reason after you open the fsm, it seems to remove _ from the name

stiff otter Oct 14, 2020, 1:58 AM

#

ok so would it be _healthdisplay ?

#

also how would I find the right gameobject

vocal spire Oct 14, 2020, 1:58 AM

#

health_display

stiff otter Oct 14, 2020, 1:58 AM

#

ok

vocal spire Oct 14, 2020, 1:59 AM

#

you search for it at some point after a save has started

stiff otter Oct 14, 2020, 1:59 AM

#

but how am I supposed to figure out what to search for

#

is there a scene view or something :|

vocal spire Oct 14, 2020, 1:59 AM

#

I suggest On.HeroController.Start since you probably only need to modify them once since they probably persist through rooms

#

we have the scene hiearchies

#

but

#

in fsm viewer

#

the part before the - is the go name

stiff otter Oct 14, 2020, 2:00 AM

#

oh sick

#

thats the gameobject name?

vocal spire Oct 14, 2020, 2:00 AM

#

should be

stiff otter Oct 14, 2020, 2:00 AM

#

cool

#

what variables does heroController.start take

#

or whatever they are called

#

parameters

#

nvmd I can just see the file

#

📎 hollowknightmodding.mov

vocal spire Oct 14, 2020, 2:14 AM

#

ok...... what did you do?

#

also to auto fill out hooks in vs, do the += then press tab, then press enter

vocal spire Oct 14, 2020, 3:22 AM

#

So I'm having a problem in globalsettings where in a list, a default version of the type will be added to the beginning of the list. Anyone know how to solve? I could just remove the first thing in the list but I don't wan't to mess up something when/if it gets fixed

vocal spire Oct 14, 2020, 4:04 AM

#

ok, removing seems to have fixed it, but still removed the non added stuff

languid goblet Oct 15, 2020, 9:45 PM

#

so what i'm trying to do is make the player take damage every time they kill an enemy, but in return increase soul gain

📎 unknown.png

#

the soul gain works, but the take damage part doesn't

#

and i'm pretty sure i'm hooking into the kill thing correctly

#

i thought maybe it was because i didn't have journal, so i gave myself that but it still doesn't work

vocal spire Oct 15, 2020, 9:46 PM

#

Where are you calling the add soul code?

#

Oh wait

#

Take damage is working

languid goblet Oct 15, 2020, 9:46 PM

#

line 17

vocal spire Oct 15, 2020, 9:46 PM

#

Do it in HeroController

languid goblet Oct 15, 2020, 9:47 PM

#

oh

vocal spire Oct 15, 2020, 9:47 PM

#

Will update the ui properly

languid goblet Oct 15, 2020, 9:47 PM

#

how do i do that?

copper nacelle Oct 15, 2020, 9:47 PM

#

Use HeroController.instance.TakeDamage

languid goblet Oct 15, 2020, 9:47 PM

#

oh ok

jolly oriole Oct 15, 2020, 9:48 PM

#

oh and in the onSoulGain, dont do return 33;, that would give the player 33 soul everytime they get soul, so a soul totem would give like 300 soul or something

vocal spire Oct 15, 2020, 9:48 PM

#

lol

jolly oriole Oct 15, 2020, 9:49 PM

#

https://radiance.host/apidocs/Hooks.html#soulgainhook

languid goblet Oct 15, 2020, 9:49 PM

#

oh lol

vocal spire Oct 15, 2020, 9:49 PM

#

Was gonna mention that but didn’t know if it was intentional

languid goblet Oct 15, 2020, 9:49 PM

#

i just wanted it to be from enemies

vocal spire Oct 15, 2020, 9:49 PM

#

Just add soul when you call the taking damage

languid goblet Oct 15, 2020, 9:49 PM

#

i mean, from like one hit though

vocal spire Oct 15, 2020, 9:49 PM

#

Well

#

Use on to replace the code that calls that when you hit an enemy

languid goblet Oct 15, 2020, 9:50 PM

#

oh right

#

do i need to create an object of type UnityEngine.GameObject in order to use TakeDamage

vocal spire Oct 15, 2020, 9:51 PM

#

Wdym

languid goblet Oct 15, 2020, 9:52 PM

#

TakeDamage requires four parameters

vocal spire Oct 15, 2020, 9:53 PM

#

Ohhhh

languid goblet Oct 15, 2020, 9:53 PM

#

one of them is gameobject

vocal spire Oct 15, 2020, 9:53 PM

#

Hold on

languid goblet Oct 15, 2020, 9:53 PM

#

oh wait can i do HeroController.instance.gameobject

vocal spire Oct 15, 2020, 9:53 PM

#

No

languid goblet Oct 15, 2020, 9:54 PM

#

oh

vocal spire Oct 15, 2020, 9:54 PM

#

Hold on

#

You need a hook that gets you the enemy go

languid goblet Oct 15, 2020, 9:55 PM

#

oh

#

is there something that can just update the UI?

vocal spire Oct 15, 2020, 9:57 PM

#

Look in dnspy for the code in takedamage

languid goblet Oct 15, 2020, 9:57 PM

#

uhh

vocal spire Oct 15, 2020, 9:57 PM

#

Or ilspy

languid goblet Oct 15, 2020, 9:57 PM

#

dnspy is an exe

#

i'm on mac

vocal spire Oct 15, 2020, 9:57 PM

#

Ilspy can be used on Mac I think

languid goblet Oct 15, 2020, 9:58 PM

#

oh ok

jolly oriole Oct 15, 2020, 9:59 PM

#

what is currently wanted?

vocal spire Oct 15, 2020, 9:59 PM

#

To take health from the hero when killing enemies

languid goblet Oct 15, 2020, 9:59 PM

#

when killing enemies

jolly oriole Oct 15, 2020, 10:00 PM

#

On.HealthManager.Die?

vocal spire Oct 15, 2020, 10:00 PM

#

lol

#

Good idea

#

Gives a health manager that you can get the GameObject of

copper nacelle Oct 15, 2020, 10:00 PM

#

there's the journal event in modhooks as well

vocal spire Oct 15, 2020, 10:01 PM

#

Isn’t that what they are using?

copper nacelle Oct 15, 2020, 10:01 PM

#

yeah

languid goblet Oct 15, 2020, 10:01 PM

#

i'm currently using the RecordKillForJournalHook for that

copper nacelle Oct 15, 2020, 10:01 PM

#

there's just no need for a healthmanager hook imo

vocal spire Oct 15, 2020, 10:02 PM

#

But they need a GameObject

jolly oriole Oct 15, 2020, 10:02 PM

#

apparently

copper nacelle Oct 15, 2020, 10:03 PM

#

just get the death effects parent

vocal spire Oct 15, 2020, 10:03 PM

#

That makes sense

jolly oriole Oct 15, 2020, 10:03 PM

#

shouldn't it be possible to just make a tiny filter list for "enemies" that don't count towards the health taken/soul gain gained?

vocal spire Oct 15, 2020, 10:04 PM

#

Anyway who wanna use TakeHealth(5)

#

Idk, why is that needed?

copper nacelle Oct 15, 2020, 10:04 PM

#

yeah you can just filter on the name hash

languid goblet Oct 15, 2020, 10:04 PM

#

wouldn't that just kill the player if they have 5 max health

copper nacelle Oct 15, 2020, 10:04 PM

#

yes

vocal spire Oct 15, 2020, 10:04 PM

#

That’s the point

languid goblet Oct 15, 2020, 10:04 PM

#

oh

#

is there something that i can use to update the ui?

vocal spire Oct 15, 2020, 10:05 PM

#

Ilspy

languid goblet Oct 15, 2020, 10:05 PM

#

i have no idea how to use that

#

i'm trying to figure out how to install it

vocal spire Oct 15, 2020, 10:05 PM

#

Idk either

jolly oriole Oct 15, 2020, 10:06 PM

#

is there something that i can use to update the ui?
HeroController TakeHealth should update the UI, at least i saw that here one or the other time

languid goblet Oct 15, 2020, 10:07 PM

#

oh

#

sick, it works now

#

time to figure out how to hook into hitting enemies

jolly oriole Oct 15, 2020, 10:18 PM

#

for the soul gain?

languid goblet Oct 15, 2020, 10:19 PM

#

yeah

#

you have got to be kidding me

#

ilspy is vsix and vsix files only work on windows?

copper nacelle Oct 15, 2020, 10:20 PM

#

Linux?

languid goblet Oct 15, 2020, 10:20 PM

#

mac

copper nacelle Oct 15, 2020, 10:20 PM

#

AvaloniaILSpy

languid goblet Oct 15, 2020, 10:21 PM

#

ty

copper nacelle Oct 15, 2020, 10:22 PM

#

Should probably have that pinned

#

https://github.com/icsharpcode/AvaloniaILSpy/releases cross-platform ilspy

GitHub

Releases · icsharpcode/AvaloniaILSpy

Avalonia-based .NET Decompiler (port of ILSpy). Contribute to icsharpcode/AvaloniaILSpy development by creating an account on GitHub.

copper nacelle Oct 15, 2020, 10:22 PM

#

copper nacelle https://github.com/icsharpcode/AvaloniaILSpy/releases cross-platform ilspy

jolly oriole Oct 15, 2020, 10:23 PM

#

~~one sec, wrong copy paste~~

languid goblet Oct 15, 2020, 10:23 PM

#

i.. have no clue what that does

#

is MP just soul?

copper nacelle Oct 15, 2020, 10:23 PM

#

yeah

#

any mpgainspa

#

fsm eventing by hand x5fiftPrime

jolly oriole Oct 15, 2020, 10:26 PM

#

you could hook into
On.HealthManager.TakeDamage
then do in the hook

orig(self, hitInstance);
int additionalCharge = 0;

#region literally stolen from HeroController.SoulGain(), but only this part, other part of it has hardcoded soulgain stuff
int tmpInt = PlayerData.instance.GetInt("MPReserve");
PlayerData.instance.AddMPCharge(additionalCharge);
GameCameras.instance.soulOrbFSM.SendEvent("MP GAIN");
if (PlayerData.instance.GetInt("MPReserve") != tmpInt)
{
    GameManager.instance.soulVessel_fsm.SendEvent("MP RESERVE UP");
}
#endregion

copper nacelle Oct 15, 2020, 10:27 PM

#

why wouldn't you just call mpgainspa w/ the soul amount tho

jolly oriole Oct 15, 2020, 10:29 PM

#

maybe FSM differences, checking it rn

languid goblet Oct 15, 2020, 10:30 PM

#

cool, ilspy works now

#

it wasn't working because for some reason the actual executable was a textedit document

#

@jolly oriole why couldn't i just only do PlayerData.instance.AddMPCharge(additionalCharge);?

jolly oriole Oct 15, 2020, 10:33 PM

#

ok, there are differences, the "MP GAIN" event does checks for orb flash and the focus prompt, the "MP GAIN SPA" goes directly to just filling up the orb, not checking the "Orb Flash?" and "Check Focus Prompt" FSM states

#

@languid goblet the ui wouldn't update

languid goblet Oct 15, 2020, 10:33 PM

#

oh ok

#

oh so basically if the amount of soul changes, then you tell the fsm to update

jolly oriole Oct 15, 2020, 10:34 PM

#

so ig take

orig(self, hitInstance);
int additionalCharge = 0;

HeroController.instance.AddMPChargeSpa(additionalCharge);

copper nacelle Oct 15, 2020, 10:36 PM

#

you can also ILHook SoulGain

languid goblet Oct 15, 2020, 10:36 PM

#

is additionalCharge the amount of soul i want to add

copper nacelle Oct 15, 2020, 10:36 PM

#

That just gives soul on enemy hit so you can modify the value completely

#

yes

#

the extra soul

languid goblet Oct 15, 2020, 10:37 PM

#

ok

#

so if i wanted each hit to give 33, then it'd be 22

jolly oriole Oct 15, 2020, 10:37 PM

#

i think

languid goblet Oct 15, 2020, 10:37 PM

#

alright

#

well, that's an issue

📎 unknown.png

#

maybe i could just kill the player if their health is 1

#

and then they kill an enemy

jolly oriole Oct 15, 2020, 10:41 PM

#

i thought takehealth would takecare of it

languid goblet Oct 15, 2020, 10:41 PM

#

apparently not

copper nacelle Oct 15, 2020, 10:42 PM

#

any TakeDamage

languid goblet Oct 15, 2020, 10:42 PM

#

TakeDamage has a bunch of parameters that i don't know how to find

jolly oriole Oct 15, 2020, 10:42 PM

#

yea, TakeDamage does it, although it requires way more things

copper nacelle Oct 15, 2020, 10:42 PM

#

you can just make up shit ngl

#

just create a go or pass in the knight

#

Set the collision side to unknown

#

and just make everything false

languid goblet Oct 15, 2020, 10:43 PM

#

i guess i'll try it

jolly oriole Oct 15, 2020, 10:43 PM

#

and just make everything false
the GameObject, Enum, int or int?

vocal spire Oct 15, 2020, 10:44 PM

#

lol

languid goblet Oct 15, 2020, 10:44 PM

#

what's unknown

jolly oriole Oct 15, 2020, 10:45 PM

#

CollisionSide.other i think

languid goblet Oct 15, 2020, 10:45 PM

#

ok

jolly oriole Oct 15, 2020, 10:45 PM

#

but everything except left and right works

languid goblet Oct 15, 2020, 10:46 PM

#

what's the hazardtypes

jolly oriole Oct 15, 2020, 10:46 PM

#

i think there was an enum for it

languid goblet Oct 15, 2020, 10:46 PM

#

it's asking for an int

vocal spire Oct 15, 2020, 10:46 PM

#

Well

languid goblet Oct 15, 2020, 10:47 PM

#

i guess i could try and find it with ilspy

jolly oriole Oct 15, 2020, 10:47 PM

#

use 0, or HazardType.NON_HAZARD

languid goblet Oct 15, 2020, 10:47 PM

#

oh ok

copper nacelle Oct 15, 2020, 10:48 PM

#

i would actually check but my power is out

vocal spire Oct 15, 2020, 10:48 PM

#

Oof

jolly oriole Oct 15, 2020, 10:48 PM

#

that definetly isn't quite poggers

vocal spire Oct 15, 2020, 10:49 PM

#

Reverse shroompog

languid goblet Oct 15, 2020, 10:55 PM

#

big pog
it works

📎 2020-10-15_15-54-16.mp4

#

my first mod
and it only took 2 hours zotewheeze

knotty monolith Oct 15, 2020, 10:58 PM

#

Nice!

jolly oriole Oct 15, 2020, 11:00 PM

#

amazing

languid goblet Oct 15, 2020, 11:03 PM

#

so for example does blackmoth just hook into the dash pressed and then always return true or smth

copper nacelle Oct 15, 2020, 11:08 PM

#

dash vector hook

#

for length and such

#

and then it just sets the cooldown very low

languid goblet Oct 15, 2020, 11:09 PM

#

ah ok

jolly oriole Oct 15, 2020, 11:09 PM

#

and yes, it also hooks into ModHooks.Instance.DashPressedHook

copper nacelle Oct 15, 2020, 11:11 PM

#

that's for like elegy only though yeah?

jolly oriole Oct 15, 2020, 11:12 PM

#

idk, the hook is 110 lines

copper nacelle Oct 15, 2020, 11:15 PM

#

🥴

jolly oriole Oct 15, 2020, 11:16 PM

#

but seems to be a complete rewrite on how dashes work (or ripped from other functions)

#

https://github.com/seanpr96/Blackmoth/blob/master/Blackmoth/BlackmothMod.cs#L356 if you want to take a look

copper nacelle Oct 15, 2020, 11:17 PM

#

that's not the right repo ngl

#

it's gradow's

jolly oriole Oct 15, 2020, 11:17 PM

#

it's description: "Port of Gradow's blackmoth mod to the modding api "

#

ok, looking at gradows api version now

#

that is not as long, just setting up some variables and returning true

#

ok nvm, most of it was moved into another function

copper nacelle Oct 15, 2020, 11:20 PM

#

yeah Serena's repo is from a while back when they first created and moved to the api

jolly oriole Oct 15, 2020, 11:20 PM

#

yeah, the hook in the newer version has around 160 lines of mod code

languid goblet Oct 16, 2020, 3:24 AM

#

any idea why this isn't working

📎 unknown.png

#

i looked at modlog and i think there's some sort of error every time i try to hook into the attack animation

copper nacelle Oct 16, 2020, 3:28 AM

#

what does it say

languid goblet Oct 16, 2020, 3:29 AM

#

📎 unknown.png

#

the rest is just the same thing

#

i'm assuming for every time i attacked

copper nacelle Oct 16, 2020, 3:30 AM

#

your project is built against .net 4

#

you need to target 3.5

#

It's under project settings

languid goblet Oct 16, 2020, 3:30 AM

#

oh

#

there's no option for 3.5

#

and it's targeting 3.1 currently

#

do i need a different version of visual studio or smth

copper nacelle Oct 16, 2020, 3:34 AM

#

you just need the targeting pack probably

languid goblet Oct 16, 2020, 3:35 AM

#

oh yeah also my project structure is different

📎 unknown.png

#

from the other mods and videos i saw

copper nacelle Oct 16, 2020, 3:37 AM

#

that's fine

#

Looks normal to me

languid goblet Oct 16, 2020, 3:38 AM

#

oh

dark wigeon Oct 16, 2020, 3:52 AM

#

Are you talking about .net core 3.1?

languid goblet Oct 16, 2020, 3:52 AM

#

i made a new project and copied my code over

#

because i think i was using the wrong template?

#

now .net core 3.5 is an option but when i try to build it gives me errors about version conflict

#

and also the thing is, the other test mod i made worked but this one isn’t for some reason

copper nacelle Oct 16, 2020, 4:01 AM

#

you don't want net core

#

you need net framework

languid goblet Oct 16, 2020, 4:10 AM

#

what type of project should i use then

#

i used class library

dark wigeon Oct 16, 2020, 4:18 AM

#

Class library but .net framework not .net core

languid goblet Oct 16, 2020, 4:19 AM

#

wait no it is .net framework

dark wigeon Oct 16, 2020, 4:19 AM

#

I don't think there is a .net 3.1 framework

#

Only a 3.5 framework

languid goblet Oct 16, 2020, 4:20 AM

#

📎 unknown.png

dark wigeon Oct 16, 2020, 4:20 AM

#

Yes that is fine

languid goblet Oct 16, 2020, 4:21 AM

#

these are the errors

📎 unknown.png

#

or warnings i guess

#

...ok you've got to be kidding me, it works now

#

i literally didn't change anything

#

~~how do i turn on the debug log?~~ ~~figured it out myself~~ nvm i still don't know how to get the debug log

#

sorry if i'm asking too many questions

vocal spire Oct 17, 2020, 2:17 AM

#

📎 unknown.png

viral snow Oct 17, 2020, 2:26 AM

#

cool programmer

vocal spire Oct 17, 2020, 2:26 AM

#

definately

#

didn't know what else to put there so I just went with the dumb

languid goblet Oct 17, 2020, 2:51 AM

#

HooKnows
that guy who stuffs the code full of if statements

vocal spire Oct 17, 2020, 2:51 AM

#

k

#

currently making something strange for it

languid goblet Oct 17, 2020, 2:53 AM

#

how did you add the new journal entry?

vocal spire Oct 17, 2020, 2:53 AM

#

hold on

#

private void JournalList_BuildEnemyList(On.JournalList.orig_BuildEnemyList orig, JournalList self)
{
var go = GameObject.Instantiate(self.list[4]);
go.PrintSceneHierarchyTree();
var listitem = go.GetComponent<JournalEntryStats>();
listitem.convoName = "MyJournal";
listitem.sprite = sprite2;
go.transform.Find("Portrait").GetComponent<SpriteRenderer>().sprite = sprite;
//go.transform.Find("Portrait").Find("Journal Frame(Clone)").GetComponent<SpriteRenderer>().sprite = sprite;
go.transform.Find("Name").GetComponent<SetTextMeshProGameText>().convName = "MyJournal";
self.list = self.list.Append(go).ToArray();
orig(self);
}

#

On.JournalList.BuildEnemyList += JournalList_BuildEnemyList;

languid goblet Oct 17, 2020, 2:56 AM

#

oh, that's what build enemy list does

vocal spire Oct 17, 2020, 2:56 AM

#

it doesn't cover everything yet

#

but it is enough to add a new one

languid goblet Oct 17, 2020, 2:56 AM

#

cool

vocal spire Oct 17, 2020, 2:56 AM

#

I chose 4 randomly and it's actually gruzz mother

languid goblet Oct 17, 2020, 2:57 AM

#

oh yeah
i was messing around
and i managed to make it so that every single nail slash has mop + longnail work with it

#

so
small pog i guess

vocal spire Oct 17, 2020, 2:57 AM

#

shroompog

languid goblet Oct 17, 2020, 3:00 AM

#

what references do you need

vocal spire Oct 17, 2020, 3:00 AM

#

hold on

#

I think all you need other than the usual stuff is Vasi

#

Sorry, was finishing something and the pc died

languid goblet Oct 17, 2020, 3:12 AM

#

oh ok

#

it says GameObject doesn't have PrintSceneHierarchyTree and ToArray

vocal spire Oct 17, 2020, 3:26 AM

#

@languid goblet reference modcommon too

#

Forgot to say that

languid goblet Oct 17, 2020, 3:26 AM

#

oh ok

#

still giving me an error on ToArray

vocal spire Oct 17, 2020, 3:32 AM

#

hmm

languid goblet Oct 17, 2020, 3:33 AM

#

📎 unknown.png

vocal spire Oct 17, 2020, 3:33 AM

#

using System.Linq;

languid goblet Oct 17, 2020, 3:34 AM

#

cool

#

ty

vocal spire Oct 17, 2020, 3:34 AM

#

np

languid goblet Oct 17, 2020, 3:41 AM

#

ok, small question: for my shellwood nail mod, how could i use the slashhithook to run different code depending on whether i hit an enemy or another object

vocal spire Oct 17, 2020, 3:41 AM

#

check what layer it is on and if it has a healthmanager component

#

just a healthmanager should probably do though

languid goblet Oct 17, 2020, 3:42 AM

#

so like if gameobject.healthmanage != null or smth

vocal spire Oct 17, 2020, 3:42 AM

#

yeah

languid goblet Oct 17, 2020, 3:42 AM

#

ok

vocal spire Oct 17, 2020, 3:42 AM

#

but with getcomponent

languid goblet Oct 17, 2020, 3:42 AM

#

oh ok

vocal spire Oct 17, 2020, 3:43 AM

#

gameobject.GetComponent<HealthManager>()

languid goblet Oct 17, 2020, 3:44 AM

#

thanks

vocal spire Oct 17, 2020, 3:44 AM

#

np

#

Breaking news!: Person has idea when thinking of stuff to add so something. Then they think of a whole new modded boss

📎 unknown.png

vocal spire Oct 17, 2020, 4:12 AM

#

I think I have finished setting every value in it

📎 Screenshot_93.png

#

📎 Screenshot_92.png

#

10/10 would do again

#

k gn now im sleeping

#

final code is

📎 message.txt

vocal spire Oct 17, 2020, 2:01 PM

#

K now I really want to make a helper for it for some reason even though it is the simplest thing in the world to do

#

Just something to automatically manage the hooks

vocal spire Oct 17, 2020, 5:35 PM

#

Helper code worked first try

#

Only a couple more features to add to it that deal with custom stuff in fsms

jolly oriole Oct 17, 2020, 6:10 PM

#

did it work first time with one mod using it or several?

vocal spire Oct 17, 2020, 6:11 PM

#

Haven’t tried multiple yet, but they should work