#More participants in puzzle race

35 messages · Page 1 of 1 (latest)

harsh hull
#

I made a thread to help organize the issue

#

@runic swift

harsh hull
#

object RacerRace:

val duration = 90
val maxPlayers = 10

opaque type Id = String
object Id extends OpaqueString[Id]

def make(owner: RacerPlayer.Id, puzzles: List[StormPuzzle], countdownSeconds: Int) = RacerRace(
_id = Id(ThreadLocalRandom.nextString(5)),
owner = owner,
players = Nil,
puzzles = puzzles,
countdownSeconds = countdownSeconds,
startsAt = none,
rematch = none
)

harsh hull
#

I believe I have made it so 20 can join.

#

This is a pita to test...

harsh hull
#

Alright, I have done the increase. I will make a pull request

narrow osprey
#

when changing a value, it's good to understand why it was selected in the first place

#

10 is about as much as can be displayed below the board. Add more and you increase the chances that not all racers are shown

#

players will then rightfully request that all racers are shown

#

which will lead to either restoring the previous limit or performing UI changes that I can't quite fathom atm

runic swift
harsh hull
#

Ok, yes I can understand that.
Thanks for bringing it up.

#

I could possibly envision if there are more than 10 racers split the race into two columns of 10 racers.

harsh hull
#

However, how this can be done is a good question.

thorny goblet
#

THAT'LL BE SO COOLLLLL

harsh hull
#

I was to excited to make the change, that I did not consider the other factors.

Far to impulsive...

harsh hull
# 
  <div class="centered">
    <div class="racer__race__tracks">
       <div class="racer__race__track"> .... 
  </div>
</div>
<div class="split right">
  <div class="centered">
    <div class="racer__race__tracks">
       <div class="racer__race__track"> .... 
  </div>
</div>

Would this work, theoretically?

#

It is not as clear who is in the lead, but I think it is fine, no?

harsh hull
#

after much reading through the RacerUi.scala, I think I am missing something.

    Page("Puzzle Racer")
      .css("racer")
      .i18n(_.storm)
      .js(PageModule("racer", data))
      .flag(_.zoom)
      .flag(_.zen):
        main(
          div(cls := "racer racer-app racer--play")(
            div(cls := "racer__board main-board"),
            div(cls := "racer__side")
          )
        )

I do not understand this function. I need to understand what Page(str)
and PageModule(str) is doing. I think it has something to do with rendering the race tracks. I hope so anyway, because I am at a loss otherwise.

narrow osprey
#

I don't think it's a good idea. It would add complexity to the feature and only benefit a minuscule percentage of the user base.

#

For each and every hardcoded limit in the code, you can find someone who wants it raised. It's rarely a good idea.

#

for racer tournaments with more than 10 players, I recommend using a tournament bracket system like https://challonge.com/

harsh hull
#

Ok. Thanks.

I can appreciate what you are saying.

It is adding complexity, with little gain.

Thanks for your time.

runic swift
#

Just trying to find a way to include more participants! Your thought, time, and efforts are greatly appreciated!!

runic swift
#

Ok im not trying to beat a dead horse, but what if the layout was modified?

#

That would eliminate some participants not being visible. Naturally if this isnt something you guys are interested in, no worries.

#

But Puzzle Racer is one of the many features that the competition doesnt have and making it bigger might benefit eveyone!?

timid stirrup
#

Allowing more players means more players lose though.

harsh hull
#

Think of the impact on the average happiness of puzzle rush participants