Get rid of clone inside .then_some(val.clone()).ok_or(Err(val))

[fierce blade]

Use an if expression: ```rs
if list.contains(&val) {
Ok(val)
} else {
Err(MyError::NumMissing(val))
}

[sinful trench]

Yeah, I just thought about that

I thought too much about complex solutions and didn't realize it's actually easy lol

[forest ledge]

then_some was a mistake

[fierce blade]

why does that function take ownership of val though? I feel like it might be simpler if it just accepted an &str…

[sinful trench]

Don't I need ownership if I want to create the Error Enum? Otherwise I would have to clone the &str when I create the NumMissing Error

[fierce blade]

that’s true. I usually don’t worry about cloning on errors because it’s normally a cold path anyway

[sinful trench]

Makes sense

[fierce blade]

but if it is hot, then consider taking ownership overall

[sinful trench]

Nah, you're right