Code Review: How do I write this better?

[simple totem]

I find it weird that I have to collect once more after collecting the FuturesUnordered. Is there a better way I can write this?

use futures::{stream::FuturesUnordered, StreamExt};
use reqwest::{Client, Error};

async fn get_request(url: &String, client: &Client) -> Result<String, Error> {
    client.get(url).send().await?.text().await
}

pub async fn get_requests(endpoints: &Vec<String>) -> Result<Vec<String>, Error> {
    let client = Client::new();

    endpoints
        .iter()
        .map(|url| get_request(url, &client))
        .collect::<FuturesUnordered<_>>()
        .collect::<Vec<_>>()
        .await
        .into_iter()
        .collect()
}

[radiant coral]

the last into_iter() and .collect() aren't necessary, you can use try_collect().await I think

[simple totem]

There is no try_collect() :/

[radiant coral]

it should be in TryStreamExt

[simple totem]

It's not there either, and I can't find any docs for try_collect()

[radiant coral]

maybe I was mistaken

[simple totem]

I think it requires a stream?

[radiant coral]

yeah, but FuturesUnordered impls Stream

https://docs.rs/futures/latest/futures/stream/trait.TryStreamExt.html#method.try_collect

[simple totem]

ah ok so like this

    endpoints
        .iter()
        .map(|url| get_request(url, &client))
        .collect::<FuturesUnordered<_>>()
        .try_collect()
        .await

yup this is so much better, thanks

[radiant coral]

Nice!

[faint plover]

It could also be worth considering try_join_all? https://docs.rs/futures/latest/futures/future/fn.try_join_all.html

[radiant coral]

little bit of overhead as that returns them in iteration order