How to effectively implement the job post report ? | Together Java | Page 1

rocky ledge Oct 7, 2026, 6:17 PM

#

In the context of starting the implementation of reporting job-ads, (that are against the server rules), I’d like to fully understand the existing scam report action implemented in TJ Bot (check attachment)

As discussed in #tjbot-discussion message , I must understand how the current scam-reporting flow works so I can implement a similar feature for job-ad reports, but without introducing a separate action (because there are no more free slots) peepo_sad_2 .

What I’m considering is refactoring the current “This is a scam” implementation into a more generic reporting feature that can make the action handles both scam and job-ad.

There is a suggestion, that consists of, when there is a report, the bot sends a msg to mods and renders 2 buttons so they can choose what to do, but i don't really know what would those 2 buttons mean exactly, i invite @mighty cedar to explain it, thanks.

To sum up:

What are the local requirements to test the action "this is scam"?
How to report both scam and job-ad as one (ui/ux)?
Is this feature supposed to be auditable (caught by metrics listener?)?
Thanks

tribal grailBOT Oct 7, 2026, 6:17 PM

#

<@&987246924425994290> please have a look, thanks.

rocky ledge Oct 7, 2026, 6:19 PM

#

How to effectively implement the job-ad report ?

golden steeple Oct 7, 2026, 6:24 PM

#

rocky ledge In the context of starting the implementation of reporting job-ads, (that are ag...

i don't understand, there is already "report" action

mighty cedar Oct 7, 2026, 6:26 PM

#

golden steeple i don't understand, there is already "report" action

the idea was to change this-is-scam into this-is-against-rules and then offer quick-action buttons on the message for the mods Scam, Job-ad, Dismiss

#

instead of only this-is-scam -> "is this scam?" yes/no

#

the job-ad action would then delete the message and warn the user

#

potentially also deleting more than just one message in case of shotgun job-ad spam

#

but thats advanced

#

while the scam action bans->unbans->quarantines the user

#

we can also go with ban->unban->warn for the job-ad, i wouldnt mind

#

that would solve the message auto-deletion

#

and in the future we could add even more quick-action buttons for this-is-against-rules

#

but now its scam and job-ad

wild summit Oct 7, 2026, 6:33 PM

#

why ban -> unban? why not: ban

mighty cedar Oct 7, 2026, 6:34 PM

#

bc scammers deserve to get back into their account -> quarantine
and job-ad often dont know about the rules and typically stop once being told once -> warn

#

we can also add more quick-action buttons like ban/warn to it (second row) but thats for anothe riteration as that would require doing the ban message etc in a modal instead of slash commands

#

also, ban/unban implicitly kicks from the server. often people who are bots or similar just dont even join back

#

so its effective enough

#

i havent thought it fully through it but those are the thoughts at the moment

#

the main point is to turn this-is-scam into a more general thing and mods then have quick action buttons that would represent their usual flow in that situation

#

so they can just click click instead of typing slash commands and whatnot

rocky ledge Oct 7, 2026, 6:56 PM

#

I see thanks.

Update for my questions:

What are the local requirements to test the action "this is scam"?
~~How to report both scam and job-ad as one (ui/ux)?~~
Is this feature supposed to be auditable (caught by metrics listener?)?

#

i assume i should have a second discord account to test this

#

i wonder if Discord has some feature to use temporary accounts just for tests

mighty cedar Oct 7, 2026, 6:58 PM

#

rocky ledge I see thanks. Update for my questions: - What are the local requirements to te...

What are the local requirements to test the action "this is scam"?
test server. test account
Is this feature supposed to be auditable (caught by metrics listener?)?
already done out of the box
i wonder if Discord has some feature to use temporary accounts just for tests
no

rocky ledge Oct 7, 2026, 6:59 PM

#

got it

rocky ledge Oct 7, 2026, 8:11 PM

#

guys, if the job-ad poster is warned, but keeps doing same thing again

#

do we change the behavior of the bot ?

#

like from warning to ban?

#

(could be advanced for another issue)

mighty cedar Oct 7, 2026, 8:14 PM

#

no

#

focus. do what has been explained

#

we can do more later

rocky ledge Oct 7, 2026, 8:17 PM

#

Alright. Im counting to rename the class ThisIsScamCommand, since now, it handles more than Scam

#

is that ok ?

#

hmm i'm thinking about making 3 classes

#

change the existing one into a logic container only for scam messages
create another class for the job-ad messages
create a container of the 2 other classes representing the command

#

what do you think ?

#

mighty cedar Oct 7, 2026, 8:23 PM

#

no, stay with the current class for now. rename it and add a second flow for it that would handle the other button

rocky ledge Oct 7, 2026, 8:23 PM

#

duke_thumbs_up

mighty cedar Oct 7, 2026, 8:26 PM

#

up until line 207 it stays as is (appart from renaming)
https://i.vgy.me/6Ucz7F.jpg

#

the changes happen below, when one of the buttons is clicked

#

this is the block that builds the message the mods see, with the buttons
https://i.vgy.me/Or1CKj.jpg

#

that has to be adjusted accordingly

#

into title "Potentially problematic message", buttons "Scam", "Job-Ad", "Dismiss"

rocky ledge Oct 7, 2026, 8:29 PM

#

got it

#

another question: there is a 'ReportCommand' that lets users report messages. Today If I were to introduce a new general report message command class, it might conflict with the existing one

#

so do I delete that one , or do I put the work inside of it?

mighty cedar Oct 7, 2026, 8:31 PM

#

report is fine as is

#

it has a different use case

rocky ledge Oct 7, 2026, 8:32 PM

#

i know but that different usecase can be added to this unified class

#

by just adding a button for it

mighty cedar Oct 7, 2026, 8:32 PM

#

not today

#

report is for the user to add context. this-is-against-rules is without user provided context

#

we dont want to merge that, that would make UX for the user worse

rocky ledge Oct 7, 2026, 8:33 PM

#

duke_thumbs_up

mighty cedar Oct 7, 2026, 8:33 PM

#

we can think about killing /report and then renaming this-is-against-rules to it. but that will be another step, not now

#

focus and start implementing

rocky ledge Oct 7, 2026, 8:35 PM

#

started on it already.. im gonna need some more time

#

i'll continue tomorrow. Meanwhile, any ideas or thoughts are welcome

rocky ledge Oct 9, 2026, 7:14 PM

#

BACK

#

so im currently progressing with the work

#

if id change the name of the command

#

i mean this:

private static final String COMMAND_NAME = "this-is-scam";

#

does that hurt the metrics or previous uses of it?

mighty cedar Oct 9, 2026, 7:17 PM

#

dont worry

#

rename it

rocky ledge Oct 9, 2026, 7:18 PM

#

got it, im counting to create some records and enums

#

do I put them in separate files ?

mighty cedar Oct 9, 2026, 7:18 PM

#

what?

rocky ledge Oct 9, 2026, 7:18 PM

#

i made :

public enum ReportAction {
    SCAM,
    JOB_AD,
    DISMISS
}

tribal grailBOT Oct 9, 2026, 7:18 PM

#

rocky ledge i made : ```java public enum ReportAction { SCAM, JOB_AD, DISMISS }...

Detected code, here are some useful tools:

mighty cedar Oct 9, 2026, 7:19 PM

#

i dont see why u would need such an enum. but if, put it in the file, locally

#

or do u need it elsewhere

rocky ledge Oct 9, 2026, 7:19 PM

#

it's just for the class of the command

mighty cedar Oct 9, 2026, 7:19 PM

#

i dont see why u would need it. but u know how to design code

rocky ledge Oct 9, 2026, 7:20 PM

#

got it

mighty cedar Oct 9, 2026, 7:20 PM

#

put it as close to where its used. ideally in the file, private. unless its needed outside. package private. worst case public... depending on who uses it and where

rocky ledge Oct 9, 2026, 7:24 PM

#

got it

#

there is something here for the job-ad treatment

#

in the scammer case, the user gets deleted along with their messages thanks to the easy function

private RestAction<Void> deleteMessagesByBanAndUnban(Guild guild, User target) {
    return guild.ban(target, 1, TimeUnit.DAYS)
        .reason(ACTION_REASON)
        .flatMap(_ -> guild.unban(target).reason(ACTION_REASON));
}

tribal grailBOT Oct 9, 2026, 7:25 PM

#

rocky ledge in the scammer case, the user gets deleted along with their messages thanks to t...

Detected code, here are some useful tools:

rocky ledge Oct 9, 2026, 7:26 PM

#

but for the job-ad, what we do here ? Thinkfused

mighty cedar Oct 9, 2026, 7:26 PM

#

i described this above already

#

instead of quarantine + ban + unban we do warn + ban + unban

rocky ledge Oct 9, 2026, 7:27 PM

#

u mean we keep their messages?

#

i know we would warn

#

but the messages are the point

#

we let the bot keep them ?

mighty cedar Oct 9, 2026, 7:28 PM

#

no`?

#

i literally just said

#

warn + ban + unban

#

the ban+unban is to get rid of the messages

#

just like with the scam

rocky ledge Oct 9, 2026, 7:28 PM

#

ah

#

i thought u mean we warn first, if they continue we ban

mighty cedar Oct 9, 2026, 7:29 PM

#

no, we warn, then ban, then unban

#

and for scam we quarantine, ban, then unban

rocky ledge Oct 9, 2026, 7:29 PM

#

yea

#

clear

rocky ledge Oct 9, 2026, 7:52 PM

#

the concerned channel by reports is called modmail right ?

mighty cedar Oct 9, 2026, 7:52 PM

#

its config based

#

use the same as this-is-scam used

rocky ledge Oct 9, 2026, 7:56 PM

#

i know but something looks weird here:

private Optional<TextChannel> findModMailChannel(MessageContextInteractionEvent event) {
    Guild guild = Objects.requireNonNull(event.getGuild());
    Optional<TextChannel> modMailChannel = Guilds.findTextChannel(guild, isModMailChannel);
    if (modMailChannel.isEmpty()) {
        logger.warn(
                "Cannot find the designated mod audit log channel in guild '{}' with the pattern '{}'",
                guild.getId(), config.getModAuditLogChannelPattern());
    }
    return modMailChannel;
}

tribal grailBOT Oct 9, 2026, 7:56 PM

#

rocky ledge i know but something looks weird here: ```java private Optional<TextChannel> fi...

Detected code, here are some useful tools:

rocky ledge Oct 9, 2026, 7:56 PM

#

that config.getModAuditLogChannelPattern() should be config.getModMailChannelPattern()

#

especially the method's name indicates to the modmail channel

#

it's confusing

#

on top of the class there is a predicate isModMailChannel and not isModAuditLogChannel

#

it sounded like there are 2 channels

#

look here : private MessageCreateAction reportToMods(Message message, TextChannel auditChannel) {..}

#

can i change these "auditChannel" nouns to simply "modMailChannel" ?

#

i'll do it

mighty cedar Oct 9, 2026, 8:05 PM

#

there are two channels

#

modmail and mod audit log

#

the code is correct as is

#

dont change stuff

#

play with the existing this-is-scam command in ur test server first so u understand how it works and where is what

#

then ull understand

rocky ledge Oct 9, 2026, 8:07 PM

#

done that first

mighty cedar Oct 9, 2026, 8:07 PM

#

so, then u have seen that there are two channels

#

one for modmail and one for all audit logs

rocky ledge Oct 9, 2026, 8:08 PM

#

but when i tested the command

mighty cedar Oct 9, 2026, 8:08 PM

#

two channels for different purposes

rocky ledge Oct 9, 2026, 8:08 PM

#

the only channel that got the msg was modmail

#

following the code the audit log channel is alternative right ?

mighty cedar Oct 9, 2026, 8:09 PM

#

this is not sth anyone knows adhoc. we have to dig code

rocky ledge Oct 9, 2026, 8:09 PM

#

@Override
public void onMessageContext(MessageContextInteractionEvent event) {
  // some code

    Optional<TextChannel> modAuditLog = findModMailChannel(event);

  // some code
}

tribal grailBOT Oct 9, 2026, 8:09 PM

#

rocky ledge ```java @Override public void onMessageContext(MessageContextInteractionEvent ev...

Detected code, here are some useful tools:

rocky ledge Oct 9, 2026, 8:10 PM

#

this part confuses me

#

the method says it's a modmail channel, but the variable says it's another channel

mighty cedar Oct 9, 2026, 8:10 PM

#

gimme a second

#

there:

#

#

it was originally mod audit log

#

then was changed to modmail channel by suraj kumar

#

and that PR was dirty

#

only changed half of the variable names and comments in the code

#

its supposed to be called modmail everywhere in this class

#

also here for example: https://i.vgy.me/B3Hwxw.jpg

#

etc

#

rename it everywhere in this class

#

modmail. not mod audit

rocky ledge Oct 9, 2026, 8:12 PM

#

Hmm, ok ok

#

so that means i should remove log audit channel

mighty cedar Oct 9, 2026, 8:13 PM

#

no. the channel is used by other stuff. dont kill it

rocky ledge Oct 9, 2026, 8:13 PM

#

i mean remove its use/call in this class

mighty cedar Oct 9, 2026, 8:13 PM

#

ThisIsScamCommand uses modmail channel. but the renaming in the class was only half way done

#

its just variable names and comments

#

the actual thing being used is the modmail channel

rocky ledge Oct 9, 2026, 8:14 PM

#

ok so i should rename every logAuditChannel thing into ModMailChannel right ?

mighty cedar Oct 9, 2026, 8:14 PM

#

every mention of "audit channel" or whatever in ThisIsScamCommand is supposed to be called modmail

rocky ledge Oct 9, 2026, 8:15 PM

#

duke_thumbs_up

mighty cedar Oct 9, 2026, 8:15 PM

#

or i dont know, call it just mod channel if u want to reduce "text dependencies" like that

#

then it doesnt need to be touched anymore if we rename channels again

rocky ledge Oct 9, 2026, 8:41 PM

#

alright so this method is the first one getting significant changes here

@Override
public void onButtonClick(ButtonInteractionEvent event, List<String> args) {
    Member moderator = Objects.requireNonNull(event.getMember());
    List<MessageEmbed> alertEmbeds = new ArrayList<>(event.getMessage().getEmbeds());
    AlertAction action = AlertAction.valueOf(args.get(2));

    if (action == AlertAction.DISMISS) {
        String text = "Dismissed by %s, no action executed.".formatted(moderator.getAsMention());
        event.editMessageEmbeds(withResult(alertEmbeds, text, Color.RED))
            .setComponents()
            .queue();
        return;
    }
    // TODO: handle report action
}

tribal grailBOT Oct 9, 2026, 8:41 PM

#

rocky ledge alright so this method is the first one getting significant changes here ```java...

Detected code, here are some useful tools:

mighty cedar Oct 9, 2026, 8:43 PM

#

yes. bc it can now have 3 instead of 2 buttons

#

so it needs to check which button was pressed and forward to the right action

rocky ledge Oct 9, 2026, 8:46 PM

#

alright and i check first the dismiss

#

in the prev version it checks on !isScam

mighty cedar Oct 9, 2026, 8:47 PM

#

dismiss can stay as is i think. it should just not do anything

#

remove/disable the buttons or sth i guess

#

but no harm done to the user

#

and the yes button becomes the scam button and otherwise stays as-is as well

#

and then u simply add a third button to it based on the scam button

#

which is then the job-ad button

rocky ledge Oct 9, 2026, 8:55 PM

#

which color for job-ad button

#

BTW something seems wrong in the cache

#

when i shutdown the app or remove a report msg from the modmail, then i want to report same msg again, i get "this msg was reported already"

#

ah i see, there are no invalidate to cache when failed

#

but why ?

#

peepo_think

#

nevermind

#

#

alright here we go

#

the new name is "RuleViolationAlertCommand"

#

not sure if those colors are good for buttons

viral heron Oct 9, 2026, 9:47 PM

#

try all yellow button

rocky ledge Oct 9, 2026, 9:50 PM

#

viral heron try all yellow button

can't find it

#

it doesn't exist apparently

#

even that ButtonStyle doesn't have it

viral heron Oct 9, 2026, 9:51 PM

#

weird, no way to put the color you want

#

https://javadoc.io/doc/net.dv8tion/JDA/latest/net/dv8tion/jda/api/components/buttons/ButtonStyle.html

#

a well, too bad

#

peepo_cry

rocky ledge Oct 9, 2026, 9:53 PM

#

id keep like in my screenshot

mighty cedar Oct 9, 2026, 10:00 PM

#

rocky ledge id keep like in my screenshot

make it red as well pls

#

they are both danger buttons

rocky ledge Oct 9, 2026, 10:01 PM

#

oh k

mighty cedar Oct 9, 2026, 10:01 PM

#

we will use the blue color for the second row buttons in a next iteration

#

(ban, warn, ...)

#

or wait

#

wasnt it green before?

#

and red for the NO/dismiss?

#

please check the original this-is-scam

#

we want to preserve the color coding

#

else we harm ux

rocky ledge Oct 9, 2026, 10:03 PM

#

the Yes button was green

#

but that doesn't make sense to me

mighty cedar Oct 9, 2026, 10:03 PM

#

it makes sense to me though

#

please keep it that way

#

green for the active actions, red for the abort action

rocky ledge Oct 9, 2026, 10:04 PM

#

2 green buttons for a dangerous action ?

mighty cedar Oct 9, 2026, 10:04 PM

#

yes, thanks

#

u need to view this from the perspective of the mod, who is the user for this

#

green is the active action. the one that moves the flow forward

rocky ledge Oct 9, 2026, 10:06 PM

#

mighty cedar Oct 9, 2026, 10:06 PM

#

the primary action

#

dismiss red

#

just like it was before

#

also, not "Rule Violation Alert". please stick to the UX i gave u earlier

rocky ledge Oct 9, 2026, 10:07 PM

#

BTW ive got something funny here

rocky ledge Oct 9, 2026, 10:07 PM

#

mighty cedar also, not "Rule Violation Alert". please stick to the UX i gave u earlier

u talked only about button colors

#

u didn't say anything about title shown there

mighty cedar Oct 9, 2026, 10:08 PM

#

#1557456961992130570 message

#

i did tell u how to name it

rocky ledge Oct 9, 2026, 10:09 PM

#

ah i didn't read that sorr

mighty cedar Oct 9, 2026, 10:09 PM

#

but ok, i like Rule Violation as well

#

go with Rule Violation

#

🙂

rocky ledge Oct 9, 2026, 10:09 PM

#

🙃

#

ok

#

ive found something funny, the user can report their own msg !

#

was that on purpose or escaped as an edge-case??

mighty cedar Oct 9, 2026, 10:13 PM

#

not necessary to handle this situation

rocky ledge Oct 9, 2026, 10:13 PM

#

but a user can do mistakes

#

like they select a wrong msg

mighty cedar Oct 9, 2026, 10:13 PM

#

it doesnt matter

rocky ledge Oct 9, 2026, 10:13 PM

#

ok

mighty cedar Oct 9, 2026, 10:14 PM

#

i would rather want to change the cooldown

#

thats actual friction im running into

#

but focus, this PR is about job-ad

rocky ledge Oct 9, 2026, 10:14 PM

#

we set it as env variable ?

mighty cedar Oct 9, 2026, 10:14 PM

#

we can do other stuff in another round

rocky ledge Oct 9, 2026, 10:14 PM

#

duke_thumbs_up

mighty cedar Oct 9, 2026, 10:15 PM

#

rocky ledge we set it as env variable ?

no. the problem is that i occassionally want to report multiple messages but i cant bc of the cooldown

rocky ledge Oct 9, 2026, 10:15 PM

#

feels like im doing CR to your old work LUL

mighty cedar Oct 9, 2026, 10:15 PM

#

the cooldown should for example allow reporting maybe up to 5 messages before triggering

#

but its for another round, not now

#

a similar problem exists with /report which already starts counting the cooldown even before the report is submitted. /report, then aborting the flow and trying /report again will trigger the cooldown. but that just as a note

rocky ledge Oct 9, 2026, 10:20 PM

#

got it

#

alright, i'm now in the core logic here

#

private void judgement(ButtonInteractionEvent event, AlertAction action, Guild guild, Member moderator, Member target, List<MessageEmbed> alertEmbeds) {

    Member bot = guild.getSelfMember();

    boolean canJudge;
    if (action == AlertAction.SCAM) {
        Role quarantinedRole = ModerationUtils.getQuarantinedRole(guild, config).orElse(null);
        canJudge = ModerationUtils.handleRoleChangeChecks(quarantinedRole, "quarantine", target, bot, moderator, guild, SCAM_REASON, event);
    } else {
        canJudge = ModerationUtils.handleCanInteractWithTarget("ban", bot, moderator, target, event);
    }

    canJudge = canJudge && ModerationUtils.handleHasBotPermissions("ban", Permission.BAN_MEMBERS, bot, guild, event);

    if (!canJudge) {
        logger.warn("Unable to execute judgement");
        return;
    }
    
    // TODO: execute...
}

tribal grailBOT Oct 9, 2026, 10:23 PM

#

rocky ledge ```java private void judgement(ButtonInteractionEvent event, AlertAction action,...

Detected code, here are some useful tools:

rocky ledge Oct 9, 2026, 10:23 PM

#

ive made this helper function

#

it's still in dev

#

it starts with some checks

#

ive used the handleCanInteractWithTarget() in case the case isn't scam

#

im not sure if that's the right choice

#

but it's working

mighty cedar Oct 9, 2026, 10:26 PM

#

looks weird to me but its hard to say anything really with random snippets like that

#

make a PR when ur ready then u get a proper CR

rocky ledge Oct 9, 2026, 10:27 PM

#

yea ok

mighty cedar Oct 9, 2026, 10:27 PM

#

the only tip i can give for now is to not reinvent the wheel. keep the code close to what it was

#

there is no need to change much or "improve everything" or "restructure the code"

#

it was fine as is

rocky ledge Oct 9, 2026, 10:27 PM

#

yea but here i dnt have quarantine for the job-ad

#

the changes are mostly in these methods

#

onButtonClick

mighty cedar Oct 9, 2026, 10:28 PM

#

like, there probably was some handle method that was called for the YES button (for scam)

#

and that method can stay as is, no changes needed

#

and the for job-ad button u can probably just copy that method and adjust it a bit

#

so it does warn instead of quarantine

#

etc

#

and thats it

#

no need to restructure everything

#

or whatever

#

thats all i can say for now without really seeing what u do

rocky ledge Oct 9, 2026, 10:29 PM

#

im not talking about the execution of the actions here,

mighty cedar Oct 9, 2026, 10:29 PM

#

the rest comes at CR-time.

rocky ledge Oct 9, 2026, 10:29 PM

#

ok ok

#

then i think i'll close this help thread for now

#

ive got much information and many tips

mighty cedar Oct 9, 2026, 10:30 PM

#

like, why ar eu doing this judgement of rules now

#

was this done before already or not

#

it was fine as it was

#

no need to add extras now

#

focus

#

thats what i mean

rocky ledge Oct 9, 2026, 10:30 PM

#

aah the handleConfirmedScam()

#

ok then i ll make it like this one

mighty cedar Oct 9, 2026, 10:31 PM

#

if ur going off track ull get a big CR "change everything". so ideally u stay close to whats being layed out for this

rocky ledge Oct 9, 2026, 10:31 PM

#

im doing some brute force actually

#

im keeping comparing with previous version

#

im doing rollbacks when i see something useless

#

im trying to keep only interesting parts

mighty cedar Oct 9, 2026, 10:32 PM

#

what ur saying gives me "wtf is he doing" vibes. but ok, go ahead. ill judge when i see a PR

rocky ledge Oct 9, 2026, 10:35 PM

#

alright

#How to effectively implement the job post report ?