#Code Review - Behavior Tree with Generics

1 messages · Page 1 of 1 (latest)

latent roost
#

Hi. I'd love some feedback on a small project that I am working on. It is essentially to build an automated bot that completes quests for a game and uses Behavior trees to figure out what to do.

The tree isnt fully complete. I'm just looking at the code and think specifying the type in every 'sub-tree' has made my file a little bit difficult to read and understand/maintain.

If anyone would give me feedback, it would be greatly appreciated.

https://gist.github.com/ImD4/97ac04c762755fb0667461e4db8a7c4a

Gist
CooksAssistant.java

GitHub Gist: instantly share code, notes, and snippets.

full kilnBOT
#

<@&987246883653156906> please have a look, thanks.

latent roost
#

I appreciate I have not been consistent with variable and method naming but I'm figuring it out as a I go along.

full kilnBOT
#

@latent roost

Your question has been closed due to inactivity.

If it was not resolved yet, feel free to just post a message below
to reopen it, or create a new thread.

Note that usually the reason for nobody calling back is that your
question may have been not well asked and hence no one felt confident
enough answering.

When you reopen the thread, try to use your time to improve the quality
of the question by elaborating, providing details, context, all relevant code
snippets, any errors you are getting, concrete examples and perhaps also some
screenshots. Share your attempt, explain the expected results and compare
them to the current results.

Also try to make the information easily accessible by sharing code
or assignment descriptions directly on Discord, not behind a link or
PDF-file; provide some guidance for long code snippets and ensure
the code is well formatted and has syntax highlighting. Kindly read through
https://stackoverflow.com/help/how-to-ask for more.

With enough info, someone knows the answer for sure 👍

latent roost
#

Bump

remote juniper
#

looks fine to me tbh

#

at least the class in isolation

#

I dont really know what its supposed to do, so I cant comment on if it meshes well with the rest of the system

#

only thing I can say

#

it is conventional to define your system in terms of interfaces

#

so it might be better to decide ahead of time what operations a CooksAssistant should be able to do (publicly)

#

and make that an interface

#

althought ig if the class is really minor and not open to other packages, then I guess it wouldnt matter

young shuttle
latent roost
#

thank you for feedback. I werent too sure if using generics and having to explicitly state them everywhere just made it harder to read/understand. I did start making usr of var though

young shuttle