#Review my project (Sem-1 of college)

1 messages · Page 1 of 1 (latest)

trail crane
split thistleBOT
#

<@&987246883653156906> please have a look, thanks.

mint dove
#
  1. In java we usually put the opening curly brace on the same line as the declaration of the block, not the one after that. If you're teacher told you to do otherwise then ignore this
  2. You have inconsistent spacing around operators. We usually put spaces around operators like = and +, but you don't. Again ignore if you're following a style guide given to you
  3. Your indentation is very inconsistent in many places. For example on line 38 you don't indent for the do-block (you should) and then you suddenly start doing it for line 42.
  4. The isPositiveNumber method seems a bit redundant. I'd get rid of it
  5. I'd also suggest potentially splitting out parts of your code into separate methods. Many of your methods are really long and deeply nested if properly indented, so splitting logic out can help a lot.
trail crane