<@&987246399047479336> please have a look, thanks.
#Adding to a BST
frigid saffron
First of all it's a bit weird that addHelper is a function in your BinarySearchTree class. It would be much more ideological to have another add function in Node that would basically do what addHelper does, but cleaner.
buoyant tulip
yeah i was thinking the same thing
but i think he uses an autograder for these
so i dont want to mess with things outside the problem description
frigid saffron
But yeah, since it's an assignment you don't have a choice there I guess
buoyant tulip
the logic seems sound though, right?
theres a second part where we write a main method for it
i did this
plain sphinxBOT
Detected code, here are some useful tools:
buoyant tulip
and it seemed fine
frigid saffron
yeah, logic looks "good".
buoyant tulip
as long as it works im ok with it 😭
frigid saffron
Nonetheless, here's how I would write it:
buoyant tulip
id like to see that yeah
frigid saffron
public class BinarySearchTree<T extends Comparable<T>> {
private class Node {
private final T key;
private Node left;
private Node right;
public Node(T key) {
this.key = key;
this.left = null;
this.right = null;
}
public boolean add(T key) {
if (key.compareTo(this.key) == 0) {
// already exists - you don't have to respect that case
return false;
}
if (key.compareTo(this.key) < 0) {
// insert into the left
if (left == null) { left = new Node(key); return true; }
return left.add(key);
} else {
// insertion into the right subtree
if (right == null) { right = new Node(key); return true; }
return right.add(key);
}
}
}
public BinarySearchTree() {
}
private Node root;
public boolean add(T key) {
if (root == null) {
root = new Node(key);
return true;
}
return root.add(key);
}
}
Detected code, here are some useful tools:
frigid saffron
@buoyant tulip I switched a few things around, like e.g. now the function returns boolean instead of Node (which is a private class which means you probably wouldn't want to expose it). Also you just don't need to return the node, because you don't need it for your logic and it would always just return the same root because you never care about rebalancing either.
Besides that I really didn't switch a whole lot, tried to keep it as close to the original as possible (also there's just not that much you you can do with binary trees).
plain sphinxBOT
@buoyant tulip
buoyant tulip
<@556897216208437248> I switched a few things around, like e.g. now the function...
oh I see I see
yeah that makes sense
thank you! 🙏
plain sphinxBOT
@buoyant tulip