How to get my code to let me input something? | Together Java | Page 2

wispy nebula Oct 11, 2024, 6:59 PM

#

i see. i'm adding it in the if statements right?

#

for the outcomes

timber coral Oct 11, 2024, 7:00 PM

#

yes, numPlayerWins++

wispy nebula Oct 11, 2024, 7:01 PM

#

like this?

#

        System.out.printf(CPU_MOVE, cpuMove);
        int outcome = determineWinner(playerMove, cpuMove);

        if (outcome == PLAYER_WIN_OUTCOME) {
                numPlayerWins++;
                System.out.println(PLAYER_WIN);
        } else if (outcome == CPU_WIN_OUTCOME) {
                numCPUWins++;
                System.out.println(CPU_WIN);
        } else if (outcome == TIE_OUTCOME) {
                numTies++;
                System.out.println(TIE);
        }
        numGames++;

trail basinBOT Oct 11, 2024, 7:01 PM

#

wispy nebula ```java System.out.printf(CPU_MOVE, cpuMove); int outcome = dete...

Detected code, here are some useful tools:

wispy nebula Oct 11, 2024, 7:02 PM

#

do i call the displayStats function afterwards?

timber coral Oct 11, 2024, 7:02 PM

#

wispy nebula do i call the displayStats function afterwards?

wait

timber coral Oct 11, 2024, 7:02 PM

#

wispy nebula ```java System.out.printf(CPU_MOVE, cpuMove); int outcome = dete...

before the numGames++, add the moves to the arrays

wispy nebula Oct 11, 2024, 7:03 PM

#

outside of the if statements?

timber coral Oct 11, 2024, 7:03 PM

#

yes

timber coral Oct 11, 2024, 7:04 PM

#

wispy nebula do i call the displayStats function afterwards?

we call that at the end of the while input thing

#

we don't want it repeat

wispy nebula Oct 11, 2024, 7:05 PM

#

ah ok

timber coral Oct 11, 2024, 7:07 PM

#

check if the code works

wispy nebula Oct 11, 2024, 7:10 PM

#

i think it works

timber coral Oct 11, 2024, 7:10 PM

#

show output

wispy nebula Oct 11, 2024, 7:12 PM

#

i tried to make it output the array

#

PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter> java RPS      
Let's play! What's your move? (Type the move or q to quit)
f
test
That is not a valid move. Please try again.
rock
test
Me: rock, You: rock
I chose rock. It's a tie.
[Ljava.lang.String;@7699a589
rock
test
Me: rock, You: scissors
I chose scissors. You win.
[Ljava.lang.String;@58372a00

trail basinBOT Oct 11, 2024, 7:12 PM

#

wispy nebula ```PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12...

Detected code, here are some useful tools:

wispy nebula Oct 11, 2024, 7:12 PM

#

i don't think im supposed to do that

#

is this array right?

#

        System.out.printf(CPU_PLAYER_MOVES, playerMove, cpuMove);
        System.out.printf(CPU_MOVE, cpuMove);
        int outcome = determineWinner(playerMove, cpuMove);

        if (outcome == PLAYER_WIN_OUTCOME) {
                numPlayerWins++;
                System.out.println(PLAYER_WIN);
        } else if (outcome == CPU_WIN_OUTCOME) {
                numCPUWins++;
                System.out.println(CPU_WIN);
        } else if (outcome == TIE_OUTCOME) {
                numTies++;
                System.out.println(TIE);
        }
        String [] playerMoves = new String [numGames + 1];
        int i;
        for (i = 0; i < numGames; i++) {
                playerMoves[i] = playerMove;

        }
        numGames++;

trail basinBOT Oct 11, 2024, 7:13 PM

#

wispy nebula ```java System.out.printf(CPU_PLAYER_MOVES, playerMove, cpuMove); ...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 7:13 PM

#

wispy nebula ```java System.out.printf(CPU_PLAYER_MOVES, playerMove, cpuMove); ...

no

#

you are filling the entire array with a single move

wispy nebula Oct 11, 2024, 7:14 PM

#

ah lol. do i put that in the if statement?

timber coral Oct 11, 2024, 7:14 PM

#

you have to take in account that you already are in a loop

wispy nebula Oct 11, 2024, 7:14 PM

#

i see

timber coral Oct 11, 2024, 7:14 PM

#

so you don't need the for

#

it would be just

#

playerMoves[numGames] = playerMove;

wispy nebula Oct 11, 2024, 7:14 PM

#

ohh i get it

#

do that for the cpu too?

timber coral Oct 11, 2024, 7:15 PM

#

yes

wispy nebula Oct 11, 2024, 7:16 PM

#

it will just add to the next slot in the array?

timber coral Oct 11, 2024, 7:16 PM

#

wispy nebula it will just add to the next slot in the array?

to the cpu array

#

same code but different variables

wispy nebula Oct 11, 2024, 7:16 PM

#

got it

timber coral Oct 11, 2024, 7:17 PM

#

tell me if you got IndexOutOfBoundsException

wispy nebula Oct 11, 2024, 7:17 PM

#

nope

#

do i use the displayStats function to print the array?

timber coral Oct 11, 2024, 7:18 PM

#

wispy nebula do i use the displayStats function to print the array?

no

#

it prints all the stats

#

put it after the while loop

#

and before the thanks message

wispy nebula Oct 11, 2024, 7:19 PM

#

game.displayStats();?

timber coral Oct 11, 2024, 7:20 PM

#

yes

wispy nebula Oct 11, 2024, 7:20 PM

#

ok it works

timber coral Oct 11, 2024, 7:20 PM

#

show output

#

if there are bugs

wispy nebula Oct 11, 2024, 7:21 PM

#

alright

#

PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter> java RPS      
Let's play! What's your move? (Type the move or q to quit)
rock
I chose rock. It's a tie.
rock
I chose scissors. You win.
paper
I chose paper. It's a tie.
scissors
I chose paper. You win.
q
I chose paper. Thanks for playing!
Our most recent games were:
Me: paper, You: q
Me: paper, You: scissors
Me: paper, You: paper
Me: scissors, You: rock
Me: rock, You: rock
Our overall stats are:
I won: 0.00%
You won: 40.00%
We tied: 40.00%
Thanks for playing!
Our most recent games were:
PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter> ```

trail basinBOT Oct 11, 2024, 7:21 PM

#

wispy nebula ```PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12...

Detected code, here are some useful tools:

wispy nebula Oct 11, 2024, 7:21 PM

#

it records the q part

timber coral Oct 11, 2024, 7:23 PM

#

wispy nebula it records the q part

let's check the playRPS method

wispy nebula Oct 11, 2024, 7:23 PM

#

    public void playRPS(String playerMove, String cpuMove) {
        // TODO

        // Use determineWinner to determine who won

        // Record the moves made

        // Add one to the appropriate statistics

        // Add appropriate Javadoc method header

        System.out.printf(CPU_MOVE, cpuMove);
        int outcome = determineWinner(playerMove, cpuMove);

        if (outcome == PLAYER_WIN_OUTCOME) {
                numPlayerWins++;
                System.out.println(PLAYER_WIN);
        } else if (outcome == CPU_WIN_OUTCOME) {
                numCPUWins++;
                System.out.println(CPU_WIN);
        } else if (outcome == TIE_OUTCOME) {
                numTies++;
                System.out.println(TIE);
        }
        playerMoves[numGames] = playerMove;
        cpuMoves[numGames] = cpuMove;
        numGames++;

    }```

trail basinBOT Oct 11, 2024, 7:23 PM

#

wispy nebula ```java public void playRPS(String playerMove, String cpuMove) { // ...

Detected code, here are some useful tools:

wispy nebula Oct 11, 2024, 7:23 PM

#

this is what i have

timber coral Oct 11, 2024, 7:24 PM

#

show main and isValid too

wispy nebula Oct 11, 2024, 7:24 PM

#

    public static void main(String[] args) {
        // If command line args are provided use those as the possible moves
        String[] moves = new String[args.length];
        if (args.length >= MIN_POSSIBLE_MOVES) {
            System.arraycopy(args, 0, moves, 0, args.length);
        } else {
            moves = RPS.DEFAULT_MOVES;
        }
        // Create new game and scanner
        RPS game = new RPS(moves);
        Scanner in = new Scanner(System.in);
        System.out.println(PROMPT_MOVE);

        String m = "x";
        while (!m.equals(QUIT)) {
            m = in.nextLine();
            //System.out.println("test");
            if (!game.isValidMove(m)) {
                continue;
            }
            game.playRPS(m, game.genCPUMove());

        }
        game.displayStats();

        

        // While user does not input "q", play game
        //System.out.println(GAME_NOT_IMPLEMENTED); // remove this

        // TODO: Insert the code to play the game.
        // See the writeup for an example of the game play.
        // Hint: call the methods we/you have already written
        // to do most of the work! And don't forget Javadoc.

        in.close();
    }```

trail basinBOT Oct 11, 2024, 7:24 PM

#

wispy nebula ```java public static void main(String[] args) { // If command line ...

Detected code, here are some useful tools:

wispy nebula Oct 11, 2024, 7:24 PM

#

this is my main

#

    public boolean isValidMove(String move) {
        // TODO
        // Use a loop here
        for (String m: possibleMoves) {
                if (m.equals(move) || move.equals(QUIT)) {
                        return true;
                }
        }

        System.out.println(INVALID_INPUT);
        return false;  // dummy return value so code compiles.
    }```

trail basinBOT Oct 11, 2024, 7:24 PM

#

wispy nebula ```java public boolean isValidMove(String move) { // TODO //...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 7:25 PM

#

wispy nebula ```java public boolean isValidMove(String move) { // TODO //...

strange

#

oh

wispy nebula Oct 11, 2024, 7:25 PM

#

ah it needs to be !move.equals?

timber coral Oct 11, 2024, 7:25 PM

#

I know whats the issue

timber coral Oct 11, 2024, 7:25 PM

#

wispy nebula ah it needs to be !move.equals?

yeah, lets put it in another place

timber coral Oct 11, 2024, 7:26 PM

#

wispy nebula ```java public static void main(String[] args) { // If command line ...

now this

#

while(!m.equals(QUIT))

#

lets replace it with while(true)

#

let's add the if in the while

#

that checks if its equal

timber coral Oct 11, 2024, 7:27 PM

#

timber coral that checks if its equal

if(m.equals(QUIT)) break;

#

before checking if its valid

wispy nebula Oct 11, 2024, 7:28 PM

#

so i add another if statemnt in the while loop?

timber coral Oct 11, 2024, 7:28 PM

#

wispy nebula so i add another if statemnt in the while loop?

yes

wispy nebula Oct 11, 2024, 7:29 PM

#

    public static void main(String[] args) {
        // If command line args are provided use those as the possible moves
        String[] moves = new String[args.length];
        if (args.length >= MIN_POSSIBLE_MOVES) {
            System.arraycopy(args, 0, moves, 0, args.length);
        } else {
            moves = RPS.DEFAULT_MOVES;
        }
        // Create new game and scanner
        RPS game = new RPS(moves);
        Scanner in = new Scanner(System.in);
        System.out.println(PROMPT_MOVE);

        String m = "x";
        while (true) {
            m = in.nextLine();
            //System.out.println("test");
            if (!game.isValidMove(m)) {
                continue;
            }
            if (m.equals(QUIT)) {
                break;
            }
            game.playRPS(m, game.genCPUMove());

        }
        game.displayStats();

        

        // While user does not input "q", play game
        //System.out.println(GAME_NOT_IMPLEMENTED); // remove this

        // TODO: Insert the code to play the game.
        // See the writeup for an example of the game play.
        // Hint: call the methods we/you have already written
        // to do most of the work! And don't forget Javadoc.

        in.close();
    }```

trail basinBOT Oct 11, 2024, 7:29 PM

#

wispy nebula ```java public static void main(String[] args) { // If command line ...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 7:30 PM

#

wispy nebula ```java public static void main(String[] args) { // If command line ...

lets put the is valid move after the equals quit

wispy nebula Oct 11, 2024, 7:30 PM

#

ah ok

#

i tried running it and it doesn't quit

timber coral Oct 11, 2024, 7:30 PM

#

wispy nebula ```java public boolean isValidMove(String move) { // TODO //...

and delete this || move.equals(QUIT)

wispy nebula Oct 11, 2024, 7:31 PM

#

ok got it

timber coral Oct 11, 2024, 7:32 PM

#

wispy nebula ```java public static void main(String[] args) { // If command line ...

now show your updated code

wispy nebula Oct 11, 2024, 7:32 PM

#

    public static void main(String[] args) {
        // If command line args are provided use those as the possible moves
        String[] moves = new String[args.length];
        if (args.length >= MIN_POSSIBLE_MOVES) {
            System.arraycopy(args, 0, moves, 0, args.length);
        } else {
            moves = RPS.DEFAULT_MOVES;
        }
        // Create new game and scanner
        RPS game = new RPS(moves);
        Scanner in = new Scanner(System.in);
        System.out.println(PROMPT_MOVE);

        String m = "x";
        while (true) {
            m = in.nextLine();
            //System.out.println("test");
            if (m.equals(QUIT)) {
                break;
            }
            if (!game.isValidMove(m)) {
                continue;
            }
            game.playRPS(m, game.genCPUMove());

        }
        game.displayStats();

        

        // While user does not input "q", play game
        //System.out.println(GAME_NOT_IMPLEMENTED); // remove this

        // TODO: Insert the code to play the game.
        // See the writeup for an example of the game play.
        // Hint: call the methods we/you have already written
        // to do most of the work! And don't forget Javadoc.

        in.close();
    }```

trail basinBOT Oct 11, 2024, 7:32 PM

#

wispy nebula ```java public static void main(String[] args) { // If command line ...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 7:32 PM

#

m.equals must be before isValidMove

timber coral Oct 11, 2024, 7:32 PM

#

wispy nebula ```java public static void main(String[] args) { // If command line ...

yeah now run the code

wispy nebula Oct 11, 2024, 7:33 PM

#

ok it works

#

PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter> javac RPS.java
PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter> java RPS      
Let's play! What's your move? (Type the move or q to quit)
rock
I chose rock. It's a tie.
paper
I chose scissors. I win.
scissors
I chose paper. You win.
rock
I chose paper. I win.
q
Thanks for playing!
Our most recent games were:
Me: paper, You: rock
Me: paper, You: scissors
Me: scissors, You: paper
Me: rock, You: rock
Our overall stats are:
I won: 50.00%
You won: 25.00%
We tied: 25.00%
PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter> ```

trail basinBOT Oct 11, 2024, 7:33 PM

#

wispy nebula ```java PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 7:34 PM

#

the percentages are correct

wispy nebula Oct 11, 2024, 7:34 PM

#

how do i get it to print the beginning line every time?

#

like this

#

$ java RPS
Let's play! What's your move? (Type the move or q to quit)
rock
I chose scissors. You win.
Let's play! What's your move? (Type the move or q to quit)
rock
I chose rock. It's a tie.
Let's play! What's your move? (Type the move or q to quit)
rock
I chose paper. I win.
Let's play! What's your move? (Type the move or q to quit)
q
Thanks for playing!
Our most recent games were: 
Me: paper, You: rock
Me: rock, You: rock
Me: scissors, You: rock
Our overall stats are:
I won: 33.33%
You won: 33.33%
We tied: 33.33%```

trail basinBOT Oct 11, 2024, 7:34 PM

#

wispy nebula ```$ javac RPS.java $ java RPS Let's play! What's your move? (Type the move or q...

Detected code, here are some useful tools:

wispy nebula Oct 11, 2024, 7:35 PM

#

do i just put it in the while loop?

timber coral Oct 11, 2024, 7:35 PM

#

wispy nebula ```$ javac RPS.java $ java RPS Let's play! What's your move? (Type the move or q...

put the print PROMPT in the while loop, before nextLine

timber coral Oct 11, 2024, 7:36 PM

#

wispy nebula ```java public void playRPS(String playerMove, String cpuMove) { // ...

I think there is a small issue with this but I'm not sure

#

It's not saving your moves correctly

wispy nebula Oct 11, 2024, 7:37 PM

#

is it the array size?

timber coral Oct 11, 2024, 7:37 PM

#

yeah try [numGames-1]

#

waitt

#

let me check

wispy nebula Oct 11, 2024, 7:38 PM

#

i think it broke

#

PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter> java RPS      
Let's play! What's your move? (Type the move or q to quit)
r
That is not a valid move. Please try again.
Let's play! What's your move? (Type the move or q to quit)
s
That is not a valid move. Please try again.
Let's play! What's your move? (Type the move or q to quit)
rock
I chose rock. It's a tie.
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index -1 out of bounds for length 100
        at RPSAbstract.playRPS(RPSAbstract.java:97)
        at RPS.main(RPS.java:43)
PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter>   ```

trail basinBOT Oct 11, 2024, 7:38 PM

#

wispy nebula ```PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 7:38 PM

#

nah they are correctly added

wispy nebula Oct 11, 2024, 7:39 PM

#

ok nice

#

lemme check if there's anything else

timber coral Oct 11, 2024, 7:39 PM

#

wispy nebula ```java public void playRPS(String playerMove, String cpuMove) { // ...

try not increasing numGames

#

maybe its increasing somewhere else

wispy nebula Oct 11, 2024, 7:40 PM

#

PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter> java RPS      
Let's play! What's your move? (Type the move or q to quit)
f
That is not a valid move. Please try again.
Let's play! What's your move? (Type the move or q to quit)
d
That is not a valid move. Please try again.
Let's play! What's your move? (Type the move or q to quit)
rock
I chose rock. It's a tie.
Let's play! What's your move? (Type the move or q to quit)
paper
I chose scissors. I win.
Let's play! What's your move? (Type the move or q to quit)
scissors
I chose paper. You win.
Let's play! What's your move? (Type the move or q to quit)
rock
I chose paper. I win.
Let's play! What's your move? (Type the move or q to quit)
q
Thanks for playing!
Our most recent games were:
Our overall stats are:
I won: Infinity%
You won: Infinity%
We tied: Infinity%
PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter> ```

trail basinBOT Oct 11, 2024, 7:40 PM

#

wispy nebula ```PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 7:40 PM

#

damn its worse

wispy nebula Oct 11, 2024, 7:40 PM

#

lol

timber coral Oct 11, 2024, 7:40 PM

#

let is as it was

#

can you use breakpoints?

#

idk about visual code

wispy nebula Oct 11, 2024, 7:41 PM

#

how do i use breakpoints?

timber coral Oct 11, 2024, 7:42 PM

#

wispy nebula how do i use breakpoints?

I only know how to use them in Netbeans, some people know in Eclipse and intelliJ

wispy nebula Oct 11, 2024, 7:42 PM

#

huh i'm not sure what they do

#

like the breakpoints

timber coral Oct 11, 2024, 7:42 PM

#

wispy nebula like the breakpoints

it lets you run the code line by line

wispy nebula Oct 11, 2024, 7:42 PM

#

ah i see

#

how do i use junit?

timber coral Oct 11, 2024, 7:43 PM

#

ask Simon, he knows more about that

wispy nebula Oct 11, 2024, 7:43 PM

#

ah ok

timber coral Oct 11, 2024, 7:43 PM

#

how to debug stuff

wispy nebula Oct 11, 2024, 7:43 PM

#

i tried it now i think

#

it says 12/15 tests passed

timber coral Oct 11, 2024, 7:44 PM

#

wispy nebula it says 12/15 tests passed

oh

#

show what failed

wispy nebula Oct 11, 2024, 7:45 PM

#

    @Test
    public void testPlayPokemon() {
        pokemonGame.playRPS("water", "fire");
        assertEquals(1, pokemonGame.numPlayerWins);
        assertEquals("water", pokemonGame.playerMoves[0]);
        assertEquals("fire", pokemonGame.cpuMoves[0]);
        assertEquals(1, pokemonGame.numGames);
        pokemonGame.playRPS("fire", "ice");
        assertEquals(2, pokemonGame.numPlayerWins);
        assertEquals("fire", pokemonGame.playerMoves[1]);
        assertEquals("ice", pokemonGame.cpuMoves[1]);
        assertEquals(2, pokemonGame.numGames);

        pokemonGame.playRPS("water", "electric");
        assertEquals(1, pokemonGame.numCPUWins);
        assertEquals("water", pokemonGame.playerMoves[2]);
        assertEquals("electric", pokemonGame.cpuMoves[2]);
        assertEquals(3, pokemonGame.numGames);
        pokemonGame.playRPS("fire", "water");
        assertEquals(2, pokemonGame.numCPUWins);
        assertEquals("fire", pokemonGame.playerMoves[3]);
        assertEquals("water", pokemonGame.cpuMoves[3]);
        assertEquals(4, pokemonGame.numGames);

        pokemonGame.playRPS("water", "ice");
        assertEquals(1, pokemonGame.numTies);
        assertEquals("water", pokemonGame.playerMoves[4]);
        assertEquals("ice", pokemonGame.cpuMoves[4]);
        assertEquals(5, pokemonGame.numGames);
        pokemonGame.playRPS("fire", "ground");
        assertEquals(2, pokemonGame.numTies);
        assertEquals("fire", pokemonGame.playerMoves[5]);
        assertEquals("ground", pokemonGame.cpuMoves[5]);
        assertEquals(6, pokemonGame.numGames);
    }```

trail basinBOT Oct 11, 2024, 7:45 PM

#

wispy nebula ```java @Test public void testPlayPokemon() { pokemonGame.playRP...

Detected code, here are some useful tools:

wispy nebula Oct 11, 2024, 7:45 PM

#

i think i need to make it like this

#

Here is how you should determine the outcome: All of the possible moves are stored in the array possibleMoves. Each element in the array beats the previous element in the array, and the end wraps around to the beginning. All other pairings lead to a tie. This means each move beats one move and loses to one move. For example, in the move set { "elephant", "alligator", "hedgehog", "mouse" } mouse beats hedgehog, hedgehog beats alligator, alligator beats elephant, and elephant beats mouse (all other pairings tie). Your code should be able to handle any array of possible moves with at least 3 elements.

timber coral Oct 11, 2024, 7:45 PM

#

wispy nebula ```java @Test public void testPlayPokemon() { pokemonGame.playRP...

ohh

#

to test that we should fix the winner method

#

it only works for rock paper scissors

wispy nebula Oct 11, 2024, 7:46 PM

#

i see

#

    public int determineWinner(String playerMove, String cpuMove) {
        // TODO
        if (playerMove.equals(cpuMove)) {
            return TIE_OUTCOME;
        } 
        switch (playerMove) {
            case "rock" -> {
                if (cpuMove.equals("scissors")) {
                    return PLAYER_WIN_OUTCOME;
                } else if (cpuMove.equals("paper")) {
                    return CPU_WIN_OUTCOME;
                }
            }
            case "paper" -> {
                if (cpuMove.equals("rock")) {
                    return PLAYER_WIN_OUTCOME;
                } else if (cpuMove.equals("scissors")) {
                    return CPU_WIN_OUTCOME;
                }
            }
            case "scissors" -> {
                if (cpuMove.equals("paper")) {
                    return PLAYER_WIN_OUTCOME;
                } else if (cpuMove.equals("rock")) {
                    return CPU_WIN_OUTCOME;
                }
            }
        }
        return INVALID_INPUT_OUTCOME;


        //return 0;  // replace this when you implement the method
    }```

trail basinBOT Oct 11, 2024, 7:46 PM

#

wispy nebula ```java public int determineWinner(String playerMove, String cpuMove) { ...

Detected code, here are some useful tools:

wispy nebula Oct 11, 2024, 7:47 PM

#

do i just make the strings into the array positions?

timber coral Oct 11, 2024, 7:47 PM

#

wispy nebula ```java public int determineWinner(String playerMove, String cpuMove) { ...

you have to delete the if at the top and the entire switch

wispy nebula Oct 11, 2024, 7:48 PM

#

for ties?

timber coral Oct 11, 2024, 7:48 PM

#

yes

#

and the switch

#

now

#

we have to use a thing thats calculate the distance between the player move and cpu move

#

if its 0, both are equal and its tie

wispy nebula Oct 11, 2024, 7:52 PM

#

ah ok

#

so if playerMove == cpuMove?

#

then i put tie

timber coral Oct 11, 2024, 7:53 PM

#

wispy nebula so if playerMove == cpuMove?

no

#

lets calculate the index and distance

#

there is a quick way to do that

#

int playerIndex = Arrays.asList(possibleMoves).indexOf(playerMove);```

#

this converts the possible moves array to a list and uses a method that is useful for this

#

indexOf

wispy nebula Oct 11, 2024, 7:55 PM

#

ill try that

timber coral Oct 11, 2024, 7:55 PM

#

it gets the location of the String in the array

wispy nebula Oct 11, 2024, 7:56 PM

#

it says arrays cannot be resolved

timber coral Oct 11, 2024, 7:56 PM

#

wispy nebula it says arrays cannot be resolved

import java.util.Arrays

wispy nebula Oct 11, 2024, 7:56 PM

#

wait i think my professor doesn't let me import anything else

timber coral Oct 11, 2024, 7:57 PM

#

damn

wispy nebula Oct 11, 2024, 7:57 PM

#

timber coral Oct 11, 2024, 7:57 PM

#

we will use a for loop then

#

for (int i = 0; i < possibleMoves.length; i++)

#

there we put

#

if (playerMove.equals(possibleMoves[i]) playerIndex = i;

#

it does the same thing

#

then another if for the cpuMove

wispy nebula Oct 11, 2024, 8:00 PM

#

        for (i = 0; i < possibleMoves.length; i++) {
            if (playerMove.equals(possibleMoves[i])) {
                playerIndex = i;
            } else {
                playerIndex = -1;
            }
        }```

trail basinBOT Oct 11, 2024, 8:00 PM

#

wispy nebula ```java for (i = 0; i < possibleMoves.length; i++) { if (pla...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 8:01 PM

#

wispy nebula ```java for (i = 0; i < possibleMoves.length; i++) { if (pla...

remove the else I got it wrong

wispy nebula Oct 11, 2024, 8:01 PM

#

ah ok

timber coral Oct 11, 2024, 8:01 PM

#

playerIndex must be declared with -1;

#

this for will change if its in the array

wispy nebula Oct 11, 2024, 8:01 PM

#

do i declare playerIndex with -1 before the for loop?

timber coral Oct 11, 2024, 8:02 PM

#

wispy nebula do i declare playerIndex with -1 before the for loop?

yes

#

same with cpu

wispy nebula Oct 11, 2024, 8:02 PM

#

ok got it

#

like this?

#

        int i;
        int playerIndex = -1;
        int cpuIndex = -1;
        for (i = 0; i < possibleMoves.length; i++) {
            if (playerMove.equals(possibleMoves[i])) {
                playerIndex = i;
            }
            if (cpuMove.equals(possibleMoves[i])) {
                cpuIndex = i;
            }
        }```

trail basinBOT Oct 11, 2024, 8:03 PM

#

wispy nebula ```java int i; int playerIndex = -1; int cpuIndex = -1; ...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 8:03 PM

#

wispy nebula ```java int i; int playerIndex = -1; int cpuIndex = -1; ...

we can put the int i = 0 in the for, instead of declaring it before

wispy nebula Oct 11, 2024, 8:03 PM

#

ok

timber coral Oct 11, 2024, 8:04 PM

#

now after the index are set

#

check if one of them is invalid

#

        if (playerIndex == -1 || cpuIndex == -1) {
            return INVALID_INPUT_OUTCOME;
        }```

#

-1 means it didn't found the move in the array

wispy nebula Oct 11, 2024, 8:05 PM

#

outside of the for loop?

timber coral Oct 11, 2024, 8:05 PM

#

wispy nebula outside of the for loop?

yes, after

#

now this is the most complicated stuff:java // Calculate the "distance" between player's move and cpu's move int distance = (cpuIndex - playerIndex + possibleMoves.length) % possibleMoves.length;

#

it does stuff so that it calculates the distance to the player

#

and based on that it will calculate if it wins

wispy nebula Oct 11, 2024, 8:09 PM

#

i see

#

ill try to run it now

#

wait what do i do with the distance variable afterwards?

timber coral Oct 11, 2024, 8:10 PM

#

wispy nebula wait what do i do with the distance variable afterwards?

we check if its 0, and return tie if it is

#

then, check if its bigger than the half the length of possibleMoves

#

and return player won if it is

#

else, return cpu won

wispy nebula Oct 11, 2024, 8:14 PM

#

is this right?

#

        if (playerIndex == -1 || cpuIndex == -1) {
            return INVALID_INPUT_OUTCOME;
        }

        int distance = (cpuIndex - playerIndex + possibleMoves.length) % possibleMoves.length;

        if (distance == 0) {
            return TIE_OUTCOME;
        } else if (distance >= possibleMoves.length) {
            return PLAYER_WIN_OUTCOME;
        } else if (distance <= possibleMoves.length) {
            return CPU_WIN_OUTCOME;
        }```

trail basinBOT Oct 11, 2024, 8:14 PM

#

wispy nebula ```java if (playerIndex == -1 || cpuIndex == -1) { return IN...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 8:15 PM

#

wispy nebula ```java if (playerIndex == -1 || cpuIndex == -1) { return IN...

its bigger than, not bigger or equal

wispy nebula Oct 11, 2024, 8:15 PM

#

ah ok

timber coral Oct 11, 2024, 8:15 PM

#

and just put else at the end, not else if

#

so compiler does not yell at you for not returning

wispy nebula Oct 11, 2024, 8:15 PM

#

lol ok

#

i think the junit tester broke

timber coral Oct 11, 2024, 8:16 PM

#

damn

wispy nebula Oct 11, 2024, 8:18 PM

#

wait nvm

#

but it's getting the wrong wins and losses

timber coral Oct 11, 2024, 8:18 PM

#

show

wispy nebula Oct 11, 2024, 8:18 PM

#

PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter> java RPS      
Let's play! What's your move? (Type the move or q to quit)
rock
I chose rock. It's a tie.
Let's play! What's your move? (Type the move or q to quit)
paper
I chose scissors. I win.
Let's play! What's your move? (Type the move or q to quit)
scissors
I chose paper. I win.
Let's play! What's your move? (Type the move or q to quit)
q
Thanks for playing!
Our most recent games were:
Me: paper, You: scissors
Me: scissors, You: paper
Me: rock, You: rock
Our overall stats are:
I won: 66.67%
You won: 0.00%
We tied: 33.33%
PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter> ```

trail basinBOT Oct 11, 2024, 8:18 PM

#

wispy nebula ```PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12...

Detected code, here are some useful tools:

wispy nebula Oct 11, 2024, 8:18 PM

#

i chose scissors and cpu chose paper but they won

timber coral Oct 11, 2024, 8:19 PM

#

show the code

#

for me it works

wispy nebula Oct 11, 2024, 8:20 PM

#

    public int determineWinner(String playerMove, String cpuMove) {
        // TODO
        int playerIndex = -1;
        int cpuIndex = -1;
        for (int i = 0; i < possibleMoves.length; i++) {
            if (playerMove.equals(possibleMoves[i])) {
                playerIndex = i;
            }
            if (cpuMove.equals(possibleMoves[i])) {
                cpuIndex = i;
            }
        }
        if (playerIndex == -1 || cpuIndex == -1) {
            return INVALID_INPUT_OUTCOME;
        }

        int distance = (cpuIndex - playerIndex + possibleMoves.length) % possibleMoves.length;

        if (distance == 0) {
            return TIE_OUTCOME;
        } else if (distance > possibleMoves.length) {
            return PLAYER_WIN_OUTCOME;
        } else {
            return CPU_WIN_OUTCOME;
        }

        /*if (playerMove.equals(cpuMove)) {
            return TIE_OUTCOME;
        } 
        switch (playerMove) {
            case "rock" -> {
                if (cpuMove.equals("scissors")) {
                    return PLAYER_WIN_OUTCOME;
                } else if (cpuMove.equals("paper")) {
                    return CPU_WIN_OUTCOME;
                }
            }
            case "paper" -> {
                if (cpuMove.equals("rock")) {
                    return PLAYER_WIN_OUTCOME;
                } else if (cpuMove.equals("scissors")) {
                    return CPU_WIN_OUTCOME;
                }
            }
            case "scissors" -> {
                if (cpuMove.equals("paper")) {
                    return PLAYER_WIN_OUTCOME;
                } else if (cpuMove.equals("rock")) {
                    return CPU_WIN_OUTCOME;
                }
            }
        }/* */
        //return INVALID_INPUT_OUTCOME;


        //return 0;  // replace this when you implement the method
    }
}

trail basinBOT Oct 11, 2024, 8:20 PM

#

wispy nebula ```java public int determineWinner(String playerMove, String cpuMove) { ...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 8:20 PM

#

wispy nebula ```java public int determineWinner(String playerMove, String cpuMove) { ...

it's else if (distance > possibleMoves.length / 2)

wispy nebula Oct 11, 2024, 8:20 PM

#

ah ok

#

ok it works now

#

ill try junit now

#

it still doesn't pass the pokemon tests

timber coral Oct 11, 2024, 8:21 PM

#

strange

wispy nebula Oct 11, 2024, 8:22 PM

#

i think the isValid needs to rewritten?

timber coral Oct 11, 2024, 8:22 PM

#

wispy nebula ```java @Test public void testPlayPokemon() { pokemonGame.playRP...

it may be with the array

#

what are the tests that failed

wispy nebula Oct 11, 2024, 8:23 PM

#

actually some of it works

#

I chose rock. It's a tie.
I chose scissors. It's a tie.
I chose fire. You win.
I chose ice. You win.
I chose electric. I win.
I chose water. I win.
I chose ice. You win.
I chose rock. You win.
I chose scissors. You win.
I chose paper. You win.
I chose paper. I win.

#

wait

#

I chose fire. You win.
I chose ice. You win.
I chose electric. I win.
I chose water. I win.
I chose ice. You win.
I chose rock. You win.
I chose scissors. You win.
I chose paper. You win.
I chose paper. I win.
I chose rock. I win.
I chose scissors. I win.
4
That is not a valid move. Please try again.```

timber coral Oct 11, 2024, 8:24 PM

#

that 4

wispy nebula Oct 11, 2024, 8:24 PM

#

    @Test
    public void testDetermineWinnerPokemon() {
        int outcome = pokemonGame.determineWinner("electric", "water");
        assertEquals(PLAYER_WIN_OUTCOME, outcome);

        outcome = pokemonGame.determineWinner("ice", "fire");
        assertEquals(CPU_WIN_OUTCOME, outcome);

        outcome = pokemonGame.determineWinner("water", "ice");
        assertEquals(TIE_OUTCOME, outcome);
        outcome = pokemonGame.determineWinner("ground", "ground");
        assertEquals(TIE_OUTCOME, outcome);
    }

    // Helper function to test standard output from main
    public void checkStandardOutput(String inputString, String[] args, String expectedOutput) {
        // Initalize output and input streams
        PrintStream origOut = System.out;
        InputStream origIn = System.in;
        ByteArrayOutputStream baos = new ByteArrayOutputStream();
        PrintStream newps = new PrintStream(baos);
        ByteArrayInputStream bais = new ByteArrayInputStream(inputString.getBytes());

        // Replace output and input streams for the test so we can feed input
        // and compare the output
        try {
            System.setIn(bais);
        } catch (Exception e) {
            // shouldn't happen
        }
        System.setOut(newps);
        RPS.main(args);

        System.out.flush();

        // Set output and input stream to original streams
        System.setOut(origOut);
        try {
            System.setIn(origIn);
        } catch (Exception e) {
            // shouldn't happen
        }
        String stuOutput = baos.toString().replaceAll("\\R", "\n");

        assertEquals(expectedOutput, stuOutput);
    }```

#

 at RPSTester.testDetermineWinnerPokemon(RPSTester.java:189)


I chose ground. I[t's a tie.
Let's play! What's your move? (Type the move or q to quit)```

#

    @Test
    public void testDetermineWinnerPokemon() {
        int outcome = pokemonGame.determineWinner("electric", "water");
        assertEquals(PLAYER_WIN_OUTCOME, outcome);

        outcome = pokemonGame.determineWinner("ice", "fire");
        assertEquals(CPU_WIN_OUTCOME, outcome);

        outcome = pokemonGame.determineWinner("water", "ice");
        assertEquals(TIE_OUTCOME, outcome);
        outcome = pokemonGame.determineWinner("ground", "ground");
        assertEquals(TIE_OUTCOME, outcome);
    }```

#

the water and ice one failed

timber coral Oct 11, 2024, 8:27 PM

#

wispy nebula ```java @Test public void testDetermineWinnerPokemon() { int out...

oh

#

it expects a TIE_OUTCOME

#

but determineWinner only sets tie if its 0

#

if its the same

wispy nebula Oct 11, 2024, 8:28 PM

#

ah i see

#

so i need to put != as well?

timber coral Oct 11, 2024, 8:29 PM

#

It's a bit of cheat but at the top check if player is water and cpu is ice and return tie

#

lets add exceptions like that

wispy nebula Oct 11, 2024, 8:29 PM

#

ok

#

how do i do that with the playerIndex and cpuIndex?

timber coral Oct 11, 2024, 8:30 PM

#

wispy nebula how do i do that with the playerIndex and cpuIndex?

it will probably mess up with the RPS game

#

if we do that there

timber coral Oct 11, 2024, 8:30 PM

#

timber coral It's a bit of cheat but at the top check if player is water and cpu is ice and r...

lets do like this

wispy nebula Oct 11, 2024, 8:31 PM

#

huh ok i can try putting this

#

        if (playerMove.equals("water") && cpuMove.equals("ice") {
            return TIE_OUTCOME;
        }```

timber coral Oct 11, 2024, 8:31 PM

#

wispy nebula ```java if (playerMove.equals("water") && cpuMove.equals("ice") { ...

yeah

#

I don't know about pokemon so idk what's the hierarchy of elements

wispy nebula Oct 11, 2024, 8:32 PM

#

lol me neither

#

i think in the array, the element after the current one will beat it

#

and anything else is a tie

#

it passed the water and ice test

#

this one failed

#

timber coral Oct 11, 2024, 8:35 PM

#

wispy nebula

that's a problem with the arrays

#

I don't know how to solve them

wispy nebula Oct 11, 2024, 8:36 PM

#

can we put the tie at the bottom?

#

for the else

#

so that it will tie in any other case

timber coral Oct 11, 2024, 8:36 PM

#

wispy nebula so that it will tie in any other case

at the java } else if (distance > possibleMoves.length / 2) { return PLAYER_WIN_OUTCOME; } else { return CPU_WIN_OUTCOME; }?

wispy nebula Oct 11, 2024, 8:37 PM

#

yea

timber coral Oct 11, 2024, 8:37 PM

#

nah, because its checking the distance

#

its fine at the beginning

#

the problem is the array that doesn't count correctly

#

does fire and ground beat each other or tie

#

if they tie it might be an issue

wispy nebula Oct 11, 2024, 8:39 PM

#

it says the expected is [2]

#

but the result was [1]

timber coral Oct 11, 2024, 8:39 PM

#

yeah, because it could be because it has two ties, not one

timber coral Oct 11, 2024, 8:39 PM

#

timber coral does fire and ground beat each other or tie

that being this

#

try asking Zabuzard or TaldenNZ

#

they know better

wispy nebula Oct 11, 2024, 8:41 PM

#

ok i can try but lemme check first

#

it says ground beats fire

timber coral Oct 11, 2024, 8:41 PM

#

so not a tie

wispy nebula Oct 11, 2024, 8:41 PM

#

right

#

ah wait this is the array

#

String[] pokemon = {"electric", "ground", "ice", "fire", "water"};```

#

it's supposed to tie

timber coral Oct 11, 2024, 8:45 PM

#

wispy nebula ```java String[] pokemon = {"electric", "ground", "ice", "fire", "water"};```

so

#

fire gets beaten by water

#

but not by ice (its tie) right?

wispy nebula Oct 11, 2024, 8:46 PM

#

yes

#

or ice should win

timber coral Oct 11, 2024, 8:46 PM

#

only with the one that is in front or behind

wispy nebula Oct 11, 2024, 8:46 PM

#

ah wait

#

the one in front beats the one behind it

#

and the laste one is beaten by the first one

timber coral Oct 11, 2024, 8:49 PM

#

Im trying to re code it to only compare with the one ahead or behind

#

        int oneAhead = (playerIndex + 1) % possibleMoves.length;      // Move in front (clockwise)
        int oneBehind = (playerIndex - 1 + possibleMoves.length) % possibleMoves.length;
        
        // Determine who won based on the distance    
        if (cpuIndex == oneAhead) {
            return CPU_WIN_OUTCOME;
        } else if (cpuIndex == oneBehind) {
            return PLAYER_WIN_OUTCOME;
        } else {
            return TIE_OUTCOME;
        }```

#

I think this one works

wispy nebula Oct 11, 2024, 8:51 PM

#

ah ok. just replace everything with this?

timber coral Oct 11, 2024, 8:51 PM

#

wispy nebula ah ok. just replace everything with this?

from the distance to the ifs

#

keep the for loop

wispy nebula Oct 11, 2024, 8:52 PM

#

ok nice it worked

#

but it failed one test

timber coral Oct 11, 2024, 8:52 PM

#

show

wispy nebula Oct 11, 2024, 8:53 PM

#

#

oh mb

#

i took out the invalid outcome

timber coral Oct 11, 2024, 8:53 PM

#

do you have this:java if (playerIndex == -1 || cpuIndex == -1) { return INVALID_INPUT_OUTCOME; }

wispy nebula Oct 11, 2024, 8:54 PM

#

yea i just took it out on accident

#

it says unreachable code now

timber coral Oct 11, 2024, 8:55 PM

#

wispy nebula it says unreachable code now

show

wispy nebula Oct 11, 2024, 8:55 PM

#

        int oneAhead = (playerIndex + 1) % possibleMoves.length;      // Move in front (clockwise)
        int oneBehind = (playerIndex - 1 + possibleMoves.length) % possibleMoves.length;
        
        // Determine who won based on the distance    
        if (cpuIndex == oneAhead) {
            return CPU_WIN_OUTCOME;
        } else if (cpuIndex == oneBehind) {
            return PLAYER_WIN_OUTCOME;
        } else {
            return TIE_OUTCOME;
        }

        if (playerIndex == -1 || cpuIndex == -1) {
            return INVALID_INPUT_OUTCOME;
        }```

trail basinBOT Oct 11, 2024, 8:55 PM

#

wispy nebula ```java int oneAhead = (playerIndex + 1) % possibleMoves.length; //...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 8:55 PM

#

wispy nebula ```java int oneAhead = (playerIndex + 1) % possibleMoves.length; //...

this is the order:

#

the for loop

#

check if its invalid

#

calculate the one behind and ahead

#

the ifs

timber coral Oct 11, 2024, 8:56 PM

#

timber coral 2. check if its invalid

move it

wispy nebula Oct 11, 2024, 8:56 PM

#

ok ill try it

#

ok it works now

timber coral Oct 11, 2024, 8:57 PM

#

all the checks right

wispy nebula Oct 11, 2024, 8:57 PM

#

yea

timber coral Oct 11, 2024, 8:57 PM

#

we can delete the

#

if .equals

#

at the top

wispy nebula Oct 11, 2024, 8:57 PM

#

where is that?

timber coral Oct 11, 2024, 8:57 PM

#

wispy nebula ```java if (playerMove.equals("water") && cpuMove.equals("ice") { ...

this

wispy nebula Oct 11, 2024, 8:58 PM

#

ah ok i did

timber coral Oct 11, 2024, 8:58 PM

#

how its the assignment

#

is there any other checks

wispy nebula Oct 11, 2024, 8:58 PM

#

i dont think so

#

there's only 15

#

but there is another tester on the grading site

timber coral Oct 11, 2024, 8:59 PM

#

wispy nebula but there is another tester on the grading site

what is

wispy nebula Oct 11, 2024, 8:59 PM

#

on gradescope. i'll try to see if it passes

timber coral Oct 11, 2024, 8:59 PM

#

ok

wispy nebula Oct 11, 2024, 9:03 PM

#

i got 47/100

#

timber coral Oct 11, 2024, 9:04 PM

#

wispy nebula

we have to know what they check

wispy nebula Oct 11, 2024, 9:04 PM

#

it doesn't tell me i think

#

i think the default is the rock paper scissors game

timber coral Oct 11, 2024, 9:06 PM

#

wispy nebula i got 47/100

why 47/100

#

thats a lot

wispy nebula Oct 11, 2024, 9:06 PM

#

i think it was due yesterday so it's half credit now

timber coral Oct 11, 2024, 9:06 PM

#

wispy nebula i think it was due yesterday so it's half credit now

like, 0 to 50?

wispy nebula Oct 11, 2024, 9:06 PM

#

yea

#

it would be 94/100

#

this also failed

#

hard sigil Oct 11, 2024, 9:07 PM

#

Wow what is going on in here, 1356 posts 😄

timber coral Oct 11, 2024, 9:08 PM

#

hard sigil Wow what is going on in here, 1356 posts 😄

show the output

#

is comparing what you have with what you should have in the console

#

"but was"

wispy nebula Oct 11, 2024, 9:08 PM

#

ah ok

timber coral Oct 11, 2024, 9:09 PM

#

hard sigil Wow what is going on in here, 1356 posts 😄

we are close to finishing

#

just the test things

hard sigil Oct 11, 2024, 9:09 PM

#

Pokemon game? fun

wispy nebula Oct 11, 2024, 9:09 PM

#

lol yea smth like that

#

PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter> javac RPS.java
PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter> java RPS      
Let's play! What's your move? (Type the move or q to quit)
e
That is not a valid move. Please try again.
Let's play! What's your move? (Type the move or q to quit)
r
That is not a valid move. Please try again.
Let's play! What's your move? (Type the move or q to quit)
q
Thanks for playing!
Our most recent games were:
Our overall stats are:
I won: NaN%
You won: NaN%
We tied: NaN%
PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\cse12-fa24-pa1-RPS-starter-main\starter> ```

trail basinBOT Oct 11, 2024, 9:09 PM

#

wispy nebula ```java PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\...

Detected code, here are some useful tools:

wispy nebula Oct 11, 2024, 9:09 PM

#

this is what i get for 2 invalid inputs

timber coral Oct 11, 2024, 9:10 PM

#

oh

#

I see

timber coral Oct 11, 2024, 9:10 PM

#

wispy nebula ```java PS C:\Users\Simon\Documents\UCSD\CSE 12\cse12-fa24-pa1-RPS-starter-main\...

whats the output you should have

timber coral Oct 11, 2024, 9:10 PM

#

wispy nebula this also failed

according to this

wispy nebula Oct 11, 2024, 9:11 PM

#

it says If there is an invalid move, do not update any instance variables in the game. Do not store the player move or the CPU move in the playerMoves and cpuMoves arrays. Do not update any of the game stats (numGames, numTies, numPlayerWins, numCPUWins). (Hint: Check if the move is valid before you call playRPS()and if it is not, do not call playRPS()).

timber coral Oct 11, 2024, 9:12 PM

#

wispy nebula

I mean here

#

show full pic

#

or paste text

wispy nebula Oct 11, 2024, 9:13 PM

#

timber coral Oct 11, 2024, 9:14 PM

#

wispy nebula

I see

#

it's the array that is wrong

#

show your playRPS

wispy nebula Oct 11, 2024, 9:15 PM

#

ok

#

    public void playRPS(String playerMove, String cpuMove) {
        // TODO

        // Use determineWinner to determine who won

        // Record the moves made

        // Add one to the appropriate statistics

        // Add appropriate Javadoc method header

        System.out.printf(CPU_MOVE, cpuMove);
        int outcome = determineWinner(playerMove, cpuMove);

        if (outcome == PLAYER_WIN_OUTCOME) {
                numPlayerWins++;
                System.out.println(PLAYER_WIN);
        } else if (outcome == CPU_WIN_OUTCOME) {
                numCPUWins++;
                System.out.println(CPU_WIN);
        } else if (outcome == TIE_OUTCOME) {
                numTies++;
                System.out.println(TIE);
        }
        playerMoves[numGames] = playerMove;
        cpuMoves[numGames] = cpuMove;
        numGames++;

    }  ```

trail basinBOT Oct 11, 2024, 9:16 PM

#

wispy nebula ```java public void playRPS(String playerMove, String cpuMove) { // ...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 9:17 PM

#

wispy nebula ```java public void playRPS(String playerMove, String cpuMove) { // ...

let's try putting the playerMoves[numGames] = playerMove
before the ifs

#

I don't think it will solve anything but

#

just in case

wispy nebula Oct 11, 2024, 9:18 PM

#

ok ill try

#

it still the same

timber coral Oct 11, 2024, 9:21 PM

#

Oh I see

#

for some reason

#

the bot gives a different reply

wispy nebula Oct 11, 2024, 9:22 PM

#

is it not supposed to display stats with 2 invalid moves?

#

im not sure what the text below the failed test is

timber coral Oct 11, 2024, 9:23 PM

#

in your test

#

the bot replies with ground

#

but it expected it to reply with fire

#

I don't know how to fix that

wispy nebula Oct 11, 2024, 9:25 PM

#

ah wait

#

i think the top part i need it to execute outside of the while loop as well

#

it says ```org.opentest4j.AssertionFailedError: Standard output ==> expected: <Let's play! What's your move? (Type the move or q to quit)

#

wait nvm

timber coral Oct 11, 2024, 9:26 PM

#

no, it fine

#

its the cpu that gave a different response

#

can you ask your prof about that?

#

maybe he designed the test wrong

wispy nebula Oct 11, 2024, 9:27 PM

#

huh it works for everyone else i think

#

since no one posted in the discussion

timber coral Oct 11, 2024, 9:28 PM

#

wispy nebula since no one posted in the discussion

what's the max date to send the assignment

wispy nebula Oct 11, 2024, 9:28 PM

#

i have 6 more days for late submission

timber coral Oct 11, 2024, 9:28 PM

#

oh

#

late submission

wispy nebula Oct 11, 2024, 9:28 PM

#

yea this is for half credit

#

how do u fix the other error?

timber coral Oct 11, 2024, 9:29 PM

#

wispy nebula how do u fix the other error?

what

wispy nebula Oct 11, 2024, 9:29 PM

#

this one [001 *FAILED 2.00] pokemon, invalid [002 PASSED 3.00] pokemon, ties, different choices [003 PASSED 0.50] default, invalid input, both, non-null [004 *FAILED 1.00] default, invalid input, any, null [005 PASSED 1.00] default, invalid input, any, same [006 PASSED 1.00] default, player wins, normal #1 [007 PASSED 1.00] default, player wins, normal #2 [008 PASSED 1.50] default, player wins, wrap around [009 PASSED 1.00] default, CPU wins, normal #1 [010 PASSED 1.00] default, CPU wins, normal #2 [011 PASSED 1.50] default, CPU wins, wrap around [012 PASSED 2.00] default, ties [013 PASSED 0.50] default, invalid input, player, non-null [014 PASSED 0.50] default, invalid input, CPU, non-null [015 PASSED 3.00] pokemon, player wins [016 PASSED 1.50] pokemon, ties, same choices [017 PASSED 3.00] pokemon, CPU wins

trail basinBOT Oct 11, 2024, 9:29 PM

#

wispy nebula this one ```[001 *FAILED 2.00] pokemon, invalid [002 PASSED 3.00] pokemon, ties...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 9:29 PM

#

wispy nebula this one ```[001 *FAILED 2.00] pokemon, invalid [002 PASSED 3.00] pokemon, ties...

it doesn't tell what the tests do

timber coral Oct 11, 2024, 9:30 PM

#

timber coral the bot replies with ground

it might be the same reason as this

wispy nebula Oct 11, 2024, 9:30 PM

#

ah maybe

#

i think it's when there's an invalid input

#

that it doesn't work sometimes

timber coral Oct 11, 2024, 9:32 PM

#

lets try something

#

the while loop copy it and comment it

#

just in case

wispy nebula Oct 11, 2024, 9:32 PM

#

oh i missed this

#

timber coral Oct 11, 2024, 9:32 PM

#

wispy nebula

yeah

#

I was going to tell this

#

because of the bot move

wispy nebula Oct 11, 2024, 9:33 PM

#

ah right

timber coral Oct 11, 2024, 9:33 PM

#

so String cpum = game.genCPUMove()

#

put it just after the nextLine

#

and send cpum to the playRPS

#

instead of genCPU

wispy nebula Oct 11, 2024, 9:34 PM

#

timber coral put it just after the nextLine

in the while loop?

timber coral Oct 11, 2024, 9:35 PM

#

wispy nebula in the while loop?

yes

#

in main()

wispy nebula Oct 11, 2024, 9:36 PM

#

like this?

#

    public static void main(String[] args) {
        // If command line args are provided use those as the possible moves
        String[] moves = new String[args.length];
        if (args.length >= MIN_POSSIBLE_MOVES) {
            System.arraycopy(args, 0, moves, 0, args.length);
        } else {
            moves = RPS.DEFAULT_MOVES;
        }
        // Create new game and scanner
        RPS game = new RPS(moves);
        Scanner in = new Scanner(System.in);

        String m = "x";
        while (true) {
            System.out.println(PROMPT_MOVE);
            m = in.nextLine();
            String cpuM = game.genCPUMove();
            //System.out.println("test");
            if (m.equals(QUIT)) {
                break;
            }
            if (!game.isValidMove(m)) {
                continue;
            }
            game.playRPS(m, cpuM);

        }
        game.displayStats();

        

        // While user does not input "q", play game
        //System.out.println(GAME_NOT_IMPLEMENTED); // remove this

        // TODO: Insert the code to play the game.
        // See the writeup for an example of the game play.
        // Hint: call the methods we/you have already written
        // to do most of the work! And don't forget Javadoc.

        in.close();
    }```

timber coral Oct 11, 2024, 9:37 PM

#

looks good

wispy nebula Oct 11, 2024, 9:37 PM

#

alright

wispy nebula Oct 11, 2024, 9:39 PM

#

wispy nebula

it fixed this part

#

but this one still failed

#

[002  PASSED 3.00] pokemon, ties, different choices
[003  PASSED 0.50] default, invalid input, both, non-null
[004 *FAILED 1.00] default, invalid input, any, null
[005  PASSED 1.00] default, invalid input, any, same
[006  PASSED 1.00] default, player wins, normal #1
[007  PASSED 1.00] default, player wins, normal #2
[008  PASSED 1.50] default, player wins, wrap around
[009  PASSED 1.00] default, CPU wins, normal #1
[010  PASSED 1.00] default, CPU wins, normal #2
[011  PASSED 1.50] default, CPU wins, wrap around
[012  PASSED 2.00] default, ties
[013  PASSED 0.50] default, invalid input, player, non-null
[014  PASSED 0.50] default, invalid input, CPU, non-null
[015  PASSED 3.00] pokemon, player wins
[016  PASSED 1.50] pokemon, ties, same choices
[017  PASSED 3.00] pokemon, CPU wins```

trail basinBOT Oct 11, 2024, 9:39 PM

#

wispy nebula ```[001 *FAILED 2.00] pokemon, invalid [002 PASSED 3.00] pokemon, ties, differe...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 9:40 PM

#

wispy nebula ```[001 *FAILED 2.00] pokemon, invalid [002 PASSED 3.00] pokemon, ties, differe...

whats the error log

#

yk this only tells if it passed or failed

wispy nebula Oct 11, 2024, 9:40 PM

#

i dont think im allowed to view it

#

since i can just put the exceptions for the ones that failed

timber coral Oct 11, 2024, 9:41 PM

#

wispy nebula i dont think im allowed to view it

check your assignment, if the professor tells you must do x y way, etc

wispy nebula Oct 11, 2024, 9:41 PM

#

ok ill check

#

i think the error is in determineWinner

#

timber coral Oct 11, 2024, 9:46 PM

#

wispy nebula

check the first one

#

seems easier to solve

wispy nebula Oct 11, 2024, 9:46 PM

#

yea

timber coral Oct 11, 2024, 9:47 PM

#

it also has a problem with nulls

#

but it doesn't make sense to check with nulls

#

the program itself doesn't allow it

#

but anyway

wispy nebula Oct 11, 2024, 9:47 PM

#

lol yea im not sure either

#

do i just make an if statement for that?

timber coral Oct 11, 2024, 9:48 PM

#

wispy nebula do i just make an if statement for that?

yeah return invalid if one of them is null

#

like we did with playerIndex

#

same thing

#

but with move and == null

#

put it at the top

#

of the function

wispy nebula Oct 11, 2024, 9:49 PM

#

ok got it

#

can i use ||?

timber coral Oct 11, 2024, 9:50 PM

#

wispy nebula can i use ||?

yeah

#

and == null

wispy nebula Oct 11, 2024, 9:51 PM

#

wait for the isValidMove or in main?

wispy nebula Oct 11, 2024, 9:51 PM

#

timber coral like we did with playerIndex

oh in playerIndex ok i see

#

wait it doesnt work

timber coral Oct 11, 2024, 9:54 PM

#

wispy nebula wait it doesnt work

show

wispy nebula Oct 11, 2024, 9:55 PM

#

        if (playerIndex == -1 || cpuIndex == -1) {
            return INVALID_INPUT_OUTCOME;
        }
        if (playerIndex == null) {
            return INVALID_INPUT_OUTCOME;
        }```

trail basinBOT Oct 11, 2024, 9:55 PM

#

wispy nebula ```java if (playerIndex == -1 || cpuIndex == -1) { return IN...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 9:55 PM

#

wispy nebula ```java if (playerIndex == -1 || cpuIndex == -1) { return IN...

no

#

not with playerIndex

#

with playerMove and cpuMove

#

ints cannot be null

wispy nebula Oct 11, 2024, 9:56 PM

#

i see

timber coral Oct 11, 2024, 9:56 PM

#

also

#

it should be

#

before the for loop

#

to avoid NullPointerException

wispy nebula Oct 11, 2024, 9:57 PM

#

ok i put it before the loop now

#

#

still didn't work

timber coral Oct 11, 2024, 9:59 PM

#

wispy nebula

show code

wispy nebula Oct 11, 2024, 10:00 PM

#

    public int determineWinner(String playerMove, String cpuMove) {
        // TODO
        int playerIndex = -1;
        int cpuIndex = -1;

        if (playerIndex == -1 || cpuIndex == -1) {
            return INVALID_INPUT_OUTCOME;
        }
        if (playerMove == null || cpuMove == null) {
            return INVALID_INPUT_OUTCOME;
        }

        for (int i = 0; i < possibleMoves.length; i++) {
            if (playerMove.equals(possibleMoves[i])) {
                playerIndex = i;
            }
            if (cpuMove.equals(possibleMoves[i])) {
                cpuIndex = i;
            }
        }
        

        int oneAhead = (playerIndex + 1) % possibleMoves.length;     
        int oneBehind = (playerIndex - 1 + possibleMoves.length) % possibleMoves.length;
        
        
            
        if (cpuIndex == oneAhead) {
            return CPU_WIN_OUTCOME;
        } else if (cpuIndex == oneBehind) {
            return PLAYER_WIN_OUTCOME;
        } else {
            return TIE_OUTCOME;
        }


    }```

trail basinBOT Oct 11, 2024, 10:00 PM

#

wispy nebula ```java public int determineWinner(String playerMove, String cpuMove) { ...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 10:01 PM

#

if (playerIndex == -1 || cpuIndex == -1) {
return INVALID_INPUT_OUTCOME;
}

#

should be after loop

wispy nebula Oct 11, 2024, 10:01 PM

#

ok it passed the ones that failed earilier

#

but it made a lot of other ones fail

#

wispy nebula Oct 11, 2024, 10:01 PM

#

timber coral should be after loop

ok ill change that

timber coral Oct 11, 2024, 10:04 PM

#

does it work?

wispy nebula Oct 11, 2024, 10:04 PM

#

nope it still doesnt work

timber coral Oct 11, 2024, 10:05 PM

#

wispy nebula nope it still doesnt work

show code

wispy nebula Oct 11, 2024, 10:05 PM

#

    public int determineWinner(String playerMove, String cpuMove) {
        // TODO
        int playerIndex = -1;
        int cpuIndex = -1;
        

        for (int i = 0; i < possibleMoves.length; i++) {
            if (playerMove.equals(possibleMoves[i])) {
                playerIndex = i;
            }
            if (cpuMove.equals(possibleMoves[i])) {
                cpuIndex = i;
            }
        }

        if (playerIndex == -1 || cpuIndex == -1) {
            return INVALID_INPUT_OUTCOME;
        }
        if (playerMove == null || cpuMove == null) {
            return INVALID_INPUT_OUTCOME;
        }

        int oneAhead = (playerIndex + 1) % possibleMoves.length;     
        int oneBehind = (playerIndex - 1 + possibleMoves.length) % possibleMoves.length;
        
        
            
        if (cpuIndex == oneAhead) {
            return CPU_WIN_OUTCOME;
        } else if (cpuIndex == oneBehind) {
            return PLAYER_WIN_OUTCOME;
        } else {
            return TIE_OUTCOME;
        }


    }```

trail basinBOT Oct 11, 2024, 10:05 PM

#

wispy nebula ```java public int determineWinner(String playerMove, String cpuMove) { ...

Detected code, here are some useful tools:

timber coral Oct 11, 2024, 10:05 PM

#

you just put as it was before

#

nah I'll fix it

#

    public int determineWinner(String playerMove, String cpuMove) {
        if (playerMove == null || cpuMove == null) {
            return INVALID_INPUT_OUTCOME;
        }
        int playerIndex = -1;
        int cpuIndex = -1;
        

        for (int i = 0; i < possibleMoves.length; i++) {
            if (playerMove.equals(possibleMoves[i])) {
                playerIndex = i;
            }
            if (cpuMove.equals(possibleMoves[i])) {
                cpuIndex = i;
            }
        }

        if (playerIndex == -1 || cpuIndex == -1) {
            return INVALID_INPUT_OUTCOME;
        }


        int oneAhead = (playerIndex + 1) % possibleMoves.length;     
        int oneBehind = (playerIndex - 1 + possibleMoves.length) % possibleMoves.length;
        
        
            
        if (cpuIndex == oneAhead) {
            return CPU_WIN_OUTCOME;
        } else if (cpuIndex == oneBehind) {
            return PLAYER_WIN_OUTCOME;
        } else {
            return TIE_OUTCOME;
        }


    }```

#

done

wispy nebula Oct 11, 2024, 10:06 PM

#

isn't it the same?

timber coral Oct 11, 2024, 10:06 PM

#

no

#

check it again

wispy nebula Oct 11, 2024, 10:07 PM

#

ohh ok i see it now

#

ok nice everything passeed

timber coral Oct 11, 2024, 10:09 PM

#

nice

wispy nebula Oct 11, 2024, 10:09 PM

#

alright thanks so much for the help

#

that was really hard

timber coral Oct 11, 2024, 10:10 PM

#

wispy nebula that was really hard

yeah

#

did your professor tell that you have to check for nulls?

wispy nebula Oct 11, 2024, 10:11 PM

#

no i dont think so

timber coral Oct 11, 2024, 10:11 PM

#

wispy nebula no i dont think so

damn

wispy nebula Oct 11, 2024, 10:11 PM

#

it doesn't say that anywhere in the instructions

timber coral Oct 11, 2024, 10:11 PM

#

well at least its solved now

#

👌

wispy nebula Oct 11, 2024, 10:11 PM

#

yep you helped me out a lot

#

thank you so much

timber coral Oct 11, 2024, 11:06 PM

#

you can close the thread with /help-thread close

fervent osprey Oct 12, 2024, 12:08 AM

#

bro we are doing the same thing and i am soo confused

wispy nebula Oct 12, 2024, 5:32 AM

#

timber coral you can close the thread with /help-thread close

ok i'll close it later

wispy nebula Oct 12, 2024, 5:32 AM

#

fervent osprey bro we are doing the same thing and i am soo confused

lol u go to the same school as me?

#How to get my code to let me input something?