wise solar
a little library that facilitates the injection of hooks into apps (without cooperation on the part of the host app)
https://github.com/PoetryHack/PoetryHook
there are examples in the example submodule
i am hoping for a bit of a code review; there's a lot of terrible code but i am hoping someone can give broader feedback about overall design rather than specific implementation details
😃
wicked zincBOT
<@&987246883653156906> please have a look, thanks.
wise solar
the internal code and a large amount of the annotations aren't commented very well yet so ping me if you have questions :)
worn ingot
what is your goal with this and how does it differ from sponge mixin?
wise solar
sponge mixin is dependent on the classloader used by the host app to either be the system classloader or cooperate with the injection process
among other issues, that one stands out
as for the goal idk why not lol
wise solar
among other issues, that one stands out
basically it abstracts too much away and that didn't work for what i was doing
wise solar
sponge mixin is dependent on the classloader used by the host app to either be t...
my current implementation also relies on system classloader but that was because i was too tired to not hardcode it, it would be a trivial change i just haven't had time to implement
charred mantle
int match_opcode() default -1;
boolean match_after() default false;
//MATCH_METHOD
Class<?> method_class() default void.class;
String method_name() default "";
Class<?>[] method_parameters() default {};
mm
interesting
wise solar
ngl i don't think i made that part
charred mantle
who did?
wise solar
the other author
it should be commented
what file is that
Matcher.java
yea that class is annotated with the author
i am majorsopa the other is sootysplash
wise solar
interesting
what is interesting 🤔
i didn't do the matching implementation but a lot of the basis for this project i wrote
and then sootysplash refactored it to use annotations etc
charred mantle
well the naming scheme is closer to_python than toJava
and its not much documentation for what is neccesarily a pretty deep mechanism
proud sequoia
yea they must have been dreaming of python
wise solar
yea idk why it's named like that ngl
charred mantle
the fuck is match_opcode, for instance
proud sequoia
it matches an opcode
Thank captain obvious 
wise solar
well what else do u want me to say
wise solar
do you want an answer or to be silly
charred mantle
am I swiping right on invokedynamic
proud sequoia
do you want an answer or to be silly
an answer
charred mantle
i understand that it is gonna use a bytecode for something
wise solar
and again as i originally said i don't really care about linting the code as much as overall design feedback
proud sequoia
```java
int match_opcode() default -1;
boolean match_after() default fa...
which class is this ?
charred mantle
charred mantle
/**
* @author majorsopa
* @author sootysplash
* @since 1.0.0
*/
public enum InjectLocation {
// majorsopa start
HEAD,
TAIL,
// majorsopa end
// sootysplash start
MATCH_METHOD,
MATCH_TYPE,
MATCH_FIELD
// sootysplash end
}
ay yes, // sootysplash start
this is how i know that these 3 injection locations are by sootysplash
wise solar
that is annotating the code for who did what because we extracted it from a private repo and git blame wouldn't know that 😃
charred mantle
do you want an answer or to be silly
both
charred mantle
that is annotating the code for who did what because we extracted it from a priv...
who cares
proud sequoia
```java
/**
* @author majorsopa
* @author sootysplash
* @since 1.0.0
*/
publ...
...why would you add such comments, isn't git enough ?
proud sequoia
welp
wise solar
that is annotating the code for who did what because we extracted it from a priv...
this one
wicked zincBOT
@wise solar
wise solar
.