Feedback Maple project (again)

[cursive moth]

So, I did a little bit of reworking on this project..
https://github.com/thegatesdev/maple/tree/rework
This was the original feedback question: https://discord.com/channels/272761734820003841/1150721069930516511
There yall said some interesting things so I took them into account

New stuff's on the rework branch

• Everything is immutable
• No more Java null support, everything either throws or returns an Optional
• Things are properly split into public API and implementation
• No longer storing Object for the values, instead I'm abusing OOP and only have primitive values
• No 'dynamic' or changing elements anymore cuz yeah it was stupid
• Fixed the concepts that were not well thought out (old DataType stuff replaced with Layouts)
  Looking for more general feedback on how the documentation looks and if it's understandable what's happening

[buoyant hornet]

<@&987246883653156906> please have a look, thanks.

[fresh leaf]

A couple things spring to mind:

• if you don't work for github don't use that namespace
• you really need more testcases
  -out of curiousity, why not java 21 so you can use pattern matching?

[cursive moth]

io.github works right?

I used that because JitPack builds it with com.github.username

So I thought I'd be fine, and I wanted it to be consistent

you really need more testcases
is that true? the SnakeYamlAdapter may need some extra testing for ordered maps, but otherwise every moving part has a test basically

e.g. for the DictElement class, the only moving parts are get find and each, the rest of the methods are either simple, or delegate to smth else that already works

So what did you have in mind that needed testing?

why not java 21 so you can use pattern matching
ehhh cuz the general Minecraft ecosystem is technically still on Java 17
I don't want to get issues with that

[buoyant hornet]

@cursive moth

Your question has been closed due to inactivity.

If it was not resolved yet, feel free to just post a message below
to reopen it, or create a new thread.

Note that usually the reason for nobody calling back is that your
question may have been not well asked and hence no one felt confident
enough answering.

When you reopen the thread, try to use your time to improve the quality
of the question by elaborating, providing details, context, all relevant code
snippets, any errors you are getting, concrete examples and perhaps also some
screenshots. Share your attempt, explain the expected results and compare
them to the current results.

Also try to make the information easily accessible by sharing code
or assignment descriptions directly on Discord, not behind a link or
PDF-file; provide some guidance for long code snippets and ensure
the code is well formatted and has syntax highlighting. Kindly read through
https://stackoverflow.com/help/how-to-ask for more.

With enough info, someone knows the answer for sure 👍

[cursive moth]

Oy, dunno if you've been online, but I'd love some extra feedback

• JitPack builds my project using the com.github.username namespace, is it still an issue if I use that in my project as well?
• What parts of the code do you think need more testing? I'm kinda new to this but I feel like I've tested all the moving parts

[fresh leaf]

it depends on whether you want to push your code as a jar somewhere.
You test some classes, but it's better to split them up a bit in distinct tests/more edge cases/...

[cursive moth]

it depends on whether you want to push your code as a jar somewhere.
Probably not seperately, but JitPack builds the jar and creates a maven package from it

In several places in the documentation they explicitly use the com.github.username domain

And as an organization you can optionally change it to com.yourdomain

You test some classes, but it's better to split them up a bit in distinct tests/more edge cases/
allright