ModernJava contribute problems | Together Java | Page 1

sinful gardenBOT Feb 13, 2024, 11:55 PM

#

<@&987246964494204979> please have a look, thanks.

#

Here is an AI assisted attempt to answer your question 🤖. Maybe it helps! In any case, a human is on the way 👍. To continue talking to the AI, you can use </chatgpt:1108714622413963314>.

#

It depends on the project's workflow and the specific guidelines set by the maintainers. In some projects, maintainers may assign issues to contributors, while in others, contributors can start working on issues immediately without being assigned.

To ensure a smooth contribution process, it is recommended to follow these steps:

Create an issue: Clearly describe the problem or feature you want to address in the issue. Provide as much information as possible to help others understand the problem and potential solutions.
Wait for feedback: Once you have created an issue, it is a good idea to wait for feedback from the project maintainers or other contributors. They may provide additional insights, suggestions, or guidance on how to approach the problem.
Clarify expectations: If there is no response within a reasonable time frame (usually a few days), you can politely ask for clarification on whether you should start working on the issue or if someone will assign it to you.
Get assigned (if required): If maintainers assign issues to contributors, they will likely assign it to you once they review your proposal or express interest in working on it.
Start working: Once assigned or given permission by maintainers, you can start working on the issue. Follow any guidelines provided by the project (e.g., coding style, testing requirements) and make sure to communicate your progress regularly.

Remember that each project may have its own unique contribution process, so it's always best to check their documentation or reach out to maintainers for specific instructions.

modest vine Feb 13, 2024, 11:57 PM

#

start immediately, create a PR once it's done

hybrid hawk Feb 13, 2024, 11:58 PM

#

do i change the code in develop branch?

#

sry im kinda new to these contributing things

modest vine Feb 13, 2024, 11:59 PM

#

i'd recommend creating your own branch. if things go south while developing, can always delete the branch & start over, opposed to reverting to a commit

#

but it really depends on the management of the project

hybrid hawk Feb 14, 2024, 12:00 AM

#

The repository has two main branches:

master, a stable branch mostly used for releases that receives changes only occasionally
develop, the branch where the active development takes place; receives changes frequently
Your work will be based off the develop branch.

To incorporate new commits from develop into your feature branch, use git pull --rebase or equivalent GUI action. We strongly prefer having linear history, and PRs with merge commits will have to be squashed before the merge, which results in losing all valuable commit history.

After your first contribution, you will be invited to the contributor team, and you will be able to work on the project directly, without a fork.

In that case, create a branch like this feature/name-of-your-feature, and push directly to the repo!

modest vine Feb 14, 2024, 12:00 AM

#

you can always merge your branch into dev once done, the create a PR from that

hybrid hawk Feb 14, 2024, 12:00 AM

#

its from the contributing doc

#

cant quite understand tbh

modest vine Feb 14, 2024, 12:01 AM

#

the master branch is what the team should be merging into. you would only work on the dev branch

#

however, you can branch off of the dev branch to do your development

hybrid hawk Feb 14, 2024, 12:01 AM

#

its just like 1 code of change

modest vine Feb 14, 2024, 12:01 AM

#

once you're done, you can merge your changes into dev branch & create a PR for it

#

so then just do it on the dev branch

hybrid hawk Feb 14, 2024, 12:02 AM

#

alr

#

and uhh one more question

#

how do i start LUL

#

do i git clone the repo?

#

not really fimiliar with git yet

modest vine Feb 14, 2024, 12:02 AM

#

well yeah, you'll need a clone of the repo to start

#

otherwise you wont have a copy/clone of the repo to work with

hybrid hawk Feb 14, 2024, 12:03 AM

#

alr so i git clone the repo first gotcha one sec

modest vine Feb 14, 2024, 12:03 AM

#

sounds like you should be asking about git, rather than contributing

#

do a bit of studies on how git works, can even look into topics about contributing to open source

hybrid hawk Feb 14, 2024, 12:04 AM

#

yea kinda

#

well i got the repo down

#

and then i change the things i needa change and then git commit and push?

modest vine Feb 14, 2024, 12:05 AM

#

pushing your commits wont work immediately. if it did, anyone could modify the active codebase in any way, which can be malicious

hybrid hawk Feb 14, 2024, 12:05 AM

#

makes sense

modest vine Feb 14, 2024, 12:05 AM

#

instead, the management of the codebase should decide when to "pull" the changes

#

thats why Pull Requests exist

#

you create a request for management to pull your changes

#

they can accept or decline

hybrid hawk Feb 14, 2024, 12:06 AM

#

ohhhhh

#

ok

hybrid hawk Feb 14, 2024, 12:08 AM

#

modest vine you create a request for management to pull your changes

im done with the changes, so i commit and then submit a pr?

modest vine Feb 14, 2024, 12:09 AM

#

yes

hybrid hawk Feb 14, 2024, 12:09 AM

#

thx

#

appreciate the help

hybrid hawk Feb 14, 2024, 12:44 AM

#

how do i revert a git commit

#

or more so delete the commit i made

hybrid hawk Feb 14, 2024, 12:45 AM

#

modest vine yes

should i git reset --hard or --soft

sinful gardenBOT Feb 14, 2024, 12:47 AM

#

The choice between git reset --hard and git reset --soft depends on what you want to achieve.

git reset --hard: This option will discard all changes and move the branch pointer to the specified commit. It will remove all commits and changes made after the specified commit. Use this option if you want to completely remove all changes and start fresh from a specific commit.
git reset --soft: This option will move the branch pointer to the specified commit, but keep all changes as uncommitted. It allows you to "undo" commits while keeping the changes in your working directory. Use this option if you want to undo commits but keep your changes for further modifications or recommitting.

Consider your specific situation and decide which option aligns with your desired outcome.

hybrid hawk Feb 14, 2024, 12:48 AM

#

ty gippidy

sinful gardenBOT Feb 14, 2024, 12:53 AM

#

Yes, you need to push your changes to the remote repository before you can submit a pull request. When you push your changes, they will be visible in the remote repository, and then you can create a pull request to propose those changes for merging into the main branch.

#

emote: Permission to Together-Java/ModernJava.git denied to aln-chg.
fatal: unable to access 'https://github.com/Together-Java/ModernJava/': The requested URL returned error: 403

This error message indicates that you do not have the necessary permissions to push the commit to the remote repository. There could be a few reasons for this:

Incorrect credentials: Double-check that you are using the correct username and password or access token for your GitHub account. Make sure there are no typos or mistakes in your credentials.
Insufficient access rights: Ensure that you have the appropriate permissions granted by the repository owner or administrator. If you are not a collaborator or member of the organization, you may need to request access or be added as a contributor.
Two-factor authentication (2FA) enabled: If you have enabled 2FA on your GitHub account, you will need to generate and use a personal access token instead of your regular password when pushing commits. Generate a new token with appropriate permissions and use it as your password during authentication.

To resolve this issue, try the following steps:

Verify your credentials: Double-check that you are using the correct username/password or personal access token.
Check repository permissions: Ensure that you have been granted write access to the repository by its owner.
Regenerate personal access token (if applicable): If you have 2FA enabled, generate a new personal access token with appropriate permissions and use it instead of your regular password.
Contact repository owner/administrator: If none of the above steps work, reach out to the repository owner or administrator and request assistance with granting you proper permissions.

By resolving any permission-related issues, you should be able to successfully push your commit to the remote repository on GitHub.

timid temple Feb 14, 2024, 12:53 AM

#

what's your issue ?

hybrid hawk Feb 14, 2024, 12:54 AM

#

top right button link expired one

timid temple Feb 14, 2024, 12:54 AM

#

wdym

hybrid hawk Feb 14, 2024, 12:54 AM

#

#

this one

timid temple Feb 14, 2024, 12:54 AM

#

yes ?

hybrid hawk Feb 14, 2024, 12:54 AM

#

oh wait

timid temple Feb 14, 2024, 12:54 AM

#

what's the problem ?

hybrid hawk Feb 14, 2024, 12:55 AM

#

yea so when i try to push the commit to the develop branch

#

the terminal showed this

#

one sec

#

remote: Permission to Together-Java/ModernJava.git denied to aln-chg.
fatal: unable to access 'https://github.com/Together-Java/ModernJava/': The requested URL returned error: 403

timid temple Feb 14, 2024, 12:55 AM

#

well you don't push to develop

hybrid hawk Feb 14, 2024, 12:55 AM

#

🤦 mb

#

not familiar with these

#

can you please guide me?

timid temple Feb 14, 2024, 12:56 AM

#

are you working in a fork?

hybrid hawk Feb 14, 2024, 12:56 AM

#

no, uh oh i think i mistakened what the contrubuting guideline meant

timid temple Feb 14, 2024, 12:56 AM

#

well

#

i assume you don't

hybrid hawk Feb 14, 2024, 12:56 AM

#

yes i didnt

timid temple Feb 14, 2024, 12:56 AM

#

right so

#

do you know what branches are ?

hybrid hawk Feb 14, 2024, 12:57 AM

#

yes

timid temple Feb 14, 2024, 12:57 AM

#

what are they ?

hybrid hawk Feb 14, 2024, 12:57 AM

#

your own fork that you work on?

timid temple Feb 14, 2024, 12:57 AM

#

it's not a fork

hybrid hawk Feb 14, 2024, 12:57 AM

#

and when u done u submit a pr to merge to master

#

damn

timid temple Feb 14, 2024, 12:57 AM

#

but similar yea

#

it's like a parallel universe

hybrid hawk Feb 14, 2024, 12:58 AM

#

yea

#

its a "copy" of the same thing but at a different place

timid temple Feb 14, 2024, 12:58 AM

#

there is one main branch (usually called master, develop, main, here develop)

hybrid hawk Feb 14, 2024, 12:58 AM

#

mhm

timid temple Feb 14, 2024, 12:58 AM

#

hybrid hawk its a "copy" of the same thing but at a different place

it's not a copy, it starts with the same commits but at some point diverged

hybrid hawk Feb 14, 2024, 12:58 AM

#

alright

hybrid hawk Feb 14, 2024, 12:59 AM

#

timid temple there is one main branch (usually called master, develop, main, here develop)

i mistakned the main branch as master

timid temple Feb 14, 2024, 12:59 AM

#

it's called a branch

#

because the whole thing looks like a tree

hybrid hawk Feb 14, 2024, 12:59 AM

#

yes

timid temple Feb 14, 2024, 12:59 AM

#

do you know what push and pull are ?

hybrid hawk Feb 14, 2024, 12:59 AM

#

yes

#

push is to push the commit to the remote repo

timid temple Feb 14, 2024, 1:00 AM

#

right

hybrid hawk Feb 14, 2024, 1:00 AM

#

pull im not sure

timid temple Feb 14, 2024, 1:00 AM

#

(pull is basically fetch + merge/fast forward)

hybrid hawk Feb 14, 2024, 1:01 AM

#

dang i gotta up my git knowledge by a lot

timid temple Feb 14, 2024, 1:01 AM

#

so you have the main branch

#

here develop

hybrid hawk Feb 14, 2024, 1:01 AM

#

yes

timid temple Feb 14, 2024, 1:01 AM

#

this branch is usually protected

hybrid hawk Feb 14, 2024, 1:01 AM

#

yes

timid temple Feb 14, 2024, 1:01 AM

#

because the program depends of this branch

#

so you can't just do anything to it

hybrid hawk Feb 14, 2024, 1:01 AM

#

right

timid temple Feb 14, 2024, 1:01 AM

#

hybrid hawk remote: Permission to Together-Java/ModernJava.git denied to aln-chg. fatal: una...

hence why this

hybrid hawk Feb 14, 2024, 1:02 AM

#

ohhh

#

i think i get it now, i need to create my own branch, push the commit and then submit a pr?

timid temple Feb 14, 2024, 1:02 AM

#

instead, you create your personal branch and work on it

#

then you push your branch

#

and now you will have the develop branch and your personal branch with the new features

#

so you create a PR from your branch to develop

hybrid hawk Feb 14, 2024, 1:03 AM

#

alrightyy now i get it

timid temple Feb 14, 2024, 1:03 AM

#

and a mod will review and approve this PR

#

and then merge it

#

(and optionnally delete your branch)

hybrid hawk Feb 14, 2024, 1:03 AM

#

so i did do a commit on develop branch do i just delete it?

timid temple Feb 14, 2024, 1:03 AM

#

no need

#

create a new branch

hybrid hawk Feb 14, 2024, 1:03 AM

#

oh k

#

alr one sec lemme create one

timid temple Feb 14, 2024, 1:04 AM

#

your commit will directly be on the new branch

#

then you just push it

#

and create a PR

#

then you check in the changed files and commit list that everything is correct

#

and then you wait for the review

hybrid hawk Feb 14, 2024, 1:05 AM

#

sry but how do i create a new branch

#

i mistakned it as fork

timid temple Feb 14, 2024, 1:05 AM

#

git branch MyBranch

hybrid hawk Feb 14, 2024, 1:06 AM

#

thx

#

in this case guidelines says feature/your-feature

#

so what should i name it

timid temple Feb 14, 2024, 1:06 AM

#

yes

timid temple Feb 14, 2024, 1:06 AM

#

hybrid hawk in this case guidelines says `feature/your-feature`

this ?

hybrid hawk Feb 14, 2024, 1:06 AM

#

like just literally that?

timid temple Feb 14, 2024, 1:06 AM

#

yes

hybrid hawk Feb 14, 2024, 1:06 AM

#

oh damn alr

timid temple Feb 14, 2024, 1:07 AM

#

and if git doesn't like /, use another character

#

it's not a problem, it's just a temporary branch

#

branch names that you just use for a PR are not important

hybrid hawk Feb 14, 2024, 1:07 AM

#

lemme double check with u i literally type git branch feature/your-feature

#

aight

timid temple Feb 14, 2024, 1:08 AM

#

what's more important

#

is that in your commit message

#

you start your message with [feature/your-feature] The actual commit message.

#

so people who will read the history will have an easier time to understand

#

and also do that in the name of the PR

#

for the same reason

hybrid hawk Feb 14, 2024, 1:09 AM

#

alright

#

im in my branch now

#

#

and then i do my changes and stuff

timid temple Feb 14, 2024, 1:09 AM

#

...you are supposed to put the name of your feature

hybrid hawk Feb 14, 2024, 1:10 AM

#

mb

hybrid hawk Feb 14, 2024, 1:10 AM

#

hybrid hawk lemme double check with u i literally type `git branch feature/your-feature`

this message was me double checking i have to literally type out feature/your feature

#

like literally

#

sry for causing this much issues

#

ok i chagned the branch name

#

timid temple Feb 14, 2024, 1:14 AM

#

hybrid hawk

no

#

it's literally feature

#

feature/fixing-expired-link

hybrid hawk Feb 14, 2024, 1:15 AM

#

oh k

timid temple Feb 14, 2024, 1:15 AM

#

and

#

doesn't sound like a feature to me

#

more like a bug 🤔

hybrid hawk Feb 14, 2024, 1:15 AM

#

well

#

yeah it is a bug

timid temple Feb 14, 2024, 1:15 AM

#

or improvement

hybrid hawk Feb 14, 2024, 1:15 AM

#

ye ebcause the button on top right has an expired link in it

#

and i wanna fix it by changing the link

#

would it be named anything different?

timid temple Feb 14, 2024, 1:17 AM

#

bug/fixing-expired-link

#

🤔

hybrid hawk Feb 14, 2024, 1:17 AM

#

ahh

#

makes sense

#

so the naming isnt that strict

timid temple Feb 14, 2024, 1:18 AM

#

well

#

it's feature/ because it's a feature

#

but at the end, the name of the branch isn't that important since it's gonna be deleted anyway

hybrid hawk Feb 14, 2024, 1:18 AM

#

i think i got it

timid temple Feb 14, 2024, 1:19 AM

#

what's more important are the messages of the commits and the name of the pr

hybrid hawk Feb 14, 2024, 1:19 AM

#

hybrid hawk Feb 14, 2024, 1:19 AM

#

timid temple what's more important are the messages of the commits and the name of the pr

ok i will make sure they are clear

#

i finished my change(since its only changing the link)

#

2.git commit -m "fixed the button on top right where the discord invite link is expired
3.git push origin bug/fixing-expired-link```

#ModernJava contribute problems