Confused on implementing this method | Together Java | Page 1

icy violet Dec 22, 2023, 8:17 AM

#

Am trying to implement this method and am stuck. This is for a card game. Here is my code for this part:

    public int evaluate(Card cards) {
        // Find a higher card of the suit played by the opponent
        int switc = 0;
        Card highCard = null;
        Card lowCard = null;
        for (Card card : setofcards) {
            if (card.equals(cards) && card.getFace().getValue() > cards.getFace().getValue()) { // if they equal same face and check if value of hand card > value of person card
                if (highCard == null || card.getFace().getValue() > highCard.getFace().getValue()) { // highCard = null for first loop, then compare highCard value
                    highCard = card;
                    switc = 1;
               }
            }  
        }
        
        // Find the smallest lower card of the same suit
        if (switc == 0) {
        for (Card card : setofcards) {
            if (card.equals(cards) && card.getFace().getValue() < cards.getFace().getValue()) {
                if (lowCard == null || card.getFace().getValue() < lowCard.getFace().getValue()) {
                    lowCard = card;
                }
            }
        }
    }
        
        if(lowCard != null) {
            setofcards.remove(lowCard);
            return lowCard.getFace().getValue();
        }
        else if(highCard != null) {
            setofcards.remove(highCard);
            return highCard.getFace().getValue();
        }
        else {
            // Play the lowest card in the hand
            Card lowestCard = setofcards.get(0);
            for (int i = 1; i < setofcards.size(); i++) {
                    Card set = setofcards.get(i);
                    
                    if (set.getFace().getValue() < lowestCard.getFace().getValue()) {
                        lowestCard = set;
                    }
            }
            setofcards.remove(lowestCard);
            return lowestCard.getFace().getValue();
        }       
}

Screen_Shot_2023-12-22_at_2.15.51_AM.png

delicate cryptBOT Dec 22, 2023, 8:17 AM

#

icy violet Am trying to implement this method and am stuck. This is for a card game. Here i...

Detected code, here are some useful tools:

Formatted code

public int evaluate(Card cards) {
  // Find a higher card of the suit played by the opponent
  int switc = 0;
  Card highCard = null ;
  Card lowCard = null ;
  for (Card card : setofcards) {
    if (card.equals(cards) && card.getFace().getValue() > cards.getFace().getValue()) {
      // if they equal same face and check if value of hand card > value of person card
      if (highCard == null  || card.getFace().getValue() > highCard.getFace().getValue()) {
        // highCard = null for first loop, then compare highCard value
        highCard = card;
        switc = 1;
      }
    }
  }
  // Find the smallest lower card of the same suit
  if (switc == 0) {
    for (Card card : setofcards) {
      if (card.equals(cards) && card.getFace().getValue() < cards.getFace().getValue()) {
        if (lowCard == null  || card.getFace().getValue() < lowCard.getFace().getValue()) {
          lowCard = card;
        }
      }
    }
  }
  if (lowCard != null ) {
    setofcards.remove(lowCard);
    return lowCard.getFace().getValue();
  }
  else if (highCard != null ) {
    setofcards.remove(highCard);
    return highCard.getFace().getValue();
  }
  else {
    // Play the lowest card in the hand
    Card lowestCard = setofcards.get(0);
    for (int i = 1; i < setofcards.size(); i++) {
      Card set = setofcards.get(i);
      if (set.getFace().getValue() < lowestCard.getFace().getValue()) {
        lowestCard = set;
      }
    }
    setofcards.remove(lowestCard);
    return lowestCard.getFace().getValue();
  }
}

#

<@&987246399047479336> please have a look, thanks.

#

Here is an AI assisted attempt to answer your question 🤖. Maybe it helps! In any case, a human is on the way 👍. To continue talking to the AI, you can use </chatgpt:1108714622413963314>.

#

It seems like you are trying to implement a method called evaluate for a card game. However, there are a few issues with your code.

Method Signature: The method signature should indicate that the method takes in multiple cards, not just one card. You can change the parameter type from Card to List<Card> or Card[] to represent multiple cards.
Return Type: Since you are evaluating the cards, it would be more appropriate to return a value that represents the evaluation result. The return type of the method should be changed from int to something else, depending on what you want to evaluate (e.g., boolean, String, or a custom class).
Implementation: Without knowing the specific rules of your card game and what you want to evaluate, it is difficult to provide specific guidance on how to implement this method. You need to define the logic for evaluating the cards based on your game's rules.

Here is an example of how you can modify your code:

public boolean evaluate(List<Card> cards) {
    // Implement your logic for evaluating the cards here
    // Return true or false based on the evaluation result
}

To help you further, please provide more information about your card game and what exactly you want to evaluate.

meager lily Dec 22, 2023, 8:47 AM

#

How are you stuck?

icy violet Dec 22, 2023, 8:54 AM

#

meager lily How are you stuck?

Ok so lets say I use the evaluate method in the driver code, I the hand have these cards [6♠ 4♣ 2♣ 9♦ 9♠ ]
if card played is:
Q♠

I should play 6 spades.

I'm struggling with the logic of the code.

here is something else I'm trying:

 int switc = 0;
        Card highCard = null; // dummy card
        Card lowCard = null;
        for (Card card : setofcards) {
            if (card.equals(cards) && card.getFace().getValue() > cards.getFace().getValue()) { // if they equal same face and check if value of hand card > value of person card
                if (highCard == null || card.getFace().getValue() > highCard.getFace().getValue()) { // highCard = null for first loop, then compare highCard value
                    highCard = card;
                    if(switc > 0) {
                        
                    }
                    switc++;
               }
            }  
        }

essentially we first compare if the card is a high card and find the highest card of the suit. If there are multiple highcards of the suit then we choose the lowest high card. I'm not sure how I can format the code to make this logic work

delicate cryptBOT Dec 22, 2023, 8:54 AM

#

icy violet Ok so lets say I use the evaluate method in the driver code, I the hand have the...

Detected code, here are some useful tools:

meager lily Dec 22, 2023, 9:12 AM

#

And how does the result differ from what you get?

#

you made something, what does it put out?

icy violet Dec 22, 2023, 9:31 AM

#

icy violet Am trying to implement this method and am stuck. This is for a card game. Here i...

ok so for this code, I changed up the if else statment at the end to this:

if(lowCard != null) {
            setofcards.remove(lowCard);
            return lowCard.getFace().getValue();
        }
        else if(highCard != null) {
            setofcards.remove(highCard);
            return highCard.getFace().getValue();
        }
        else {
            return 0;
        }

delicate cryptBOT Dec 22, 2023, 9:31 AM

#

icy violet ok so for this code, I changed up the if else statment at the end to this: ```ja...

Detected code, here are some useful tools:

icy violet Dec 22, 2023, 9:31 AM

#

meager lily you made something, what does it put out?

It just outputs 0

Screen_Shot_2023-12-22_at_3.31.32_AM.png

#

it seems to be skipping the first and secon if statement

#

thats interesting

meager lily Dec 22, 2023, 9:33 AM

#

what is the purpose of the dummy cards?

icy violet Dec 22, 2023, 9:33 AM

#

these two right
Card highCard = null; // dummy card
Card lowCard = null;

its to set an initial value for them

meager lily Dec 22, 2023, 9:33 AM

#

and what are you comparing to in the if condition=

meager lily Dec 22, 2023, 9:33 AM

#

icy violet these two right Card highCard = null; // dummy card Card lowCard = null;...

why?

#

you dont need them. you can just apply any logic to the cards you take out of the arry directly

icy violet Dec 22, 2023, 9:34 AM

#

hmmm I'm confused

icy violet Dec 22, 2023, 9:35 AM

#

meager lily why?

I initialized it so that I can use it as a placeholder

meager lily Dec 22, 2023, 9:35 AM

#

well, you declare a value to be null, but never overwrite that.

#

thus you get 0

icy violet Dec 22, 2023, 9:35 AM

#

for (Card card : setofcards) {
            if (card.equals(cards) && card.getFace().getValue() > cards.getFace().getValue()) { // if they equal same face and check if value of hand card > value of person card
                if (highCard == null || card.getFace().getValue() > highCard.getFace().getValue()) { // highCard = null for first loop, then compare highCard value
                    highCard = card;  // OVER HERE - highCard = card
                   
                    switc++;
               }
            }  
        }

highCard = card; // highCard = card

delicate cryptBOT Dec 22, 2023, 9:35 AM

#

icy violet ```java for (Card card : setofcards) { if (card.equals(cards) && car...

Detected code, here are some useful tools:

meager lily Dec 22, 2023, 9:35 AM

#

you can do something like this arraylist.getItem().applyMethod();

icy violet Dec 22, 2023, 9:35 AM

#

does that not overwrite the null

meager lily Dec 22, 2023, 9:36 AM

#

not sure, but I think null is not greater than anything. its just undefined.

#

but there is no need to use any null variable in the first place

#

you are using a for each loop already

#

you can contain all the logic in there.

icy violet Dec 22, 2023, 9:37 AM

#

               if (highCard == null || card.getFace().getValue() > highCard.getFace().getValue()) { // highCard = null for first loop, then compare highCard value

so how would I go about this then

meager lily Dec 22, 2023, 9:40 AM

#

i would change it to a for loop first. so you can pick an index i and compare it to i + 1. so you can call the card next in line. make sure to catch the indexOutOfBoundsException

#

and break the loop when it appears

#

and then use finally to display what you want to display or set a Card highestCard; outside of the method and write the value of your until then found lowest card to it

#

then you can work with that

#

there is no need to set a value to you variables that is = null. null is their default state.

icy violet Dec 22, 2023, 9:43 AM

#

I've never used finally before. what is it about?

#

oh seems like its used after try catch

#

concluding statement 🤷‍♂️

meager lily Dec 22, 2023, 9:44 AM

#

finally is a block of code that is executed after you do a try catch block. no matter what happens during the try catch, finally is executed in succession

icy violet Dec 22, 2023, 9:44 AM

#

👍

icy violet Dec 22, 2023, 9:45 AM

#

meager lily i would change it to a for loop first. so you can pick an index i and compare it...

Ok I will try to implement this and let you know

#

thank you

meager lily Dec 22, 2023, 9:45 AM

#

sure, I will answer if I can 🙂

icy violet Dec 22, 2023, 9:21 PM

#

meager lily sure, I will answer if I can 🙂

I tried adapting your logic to my code, I need some assistance bug catching. Not sure how to get around without initializing Card highCard = null...:

    Card winningCard = null;

    try {
        for (int i = 0; i < setofcards.size(); i++) {
            Card card = setofcards.get(i);

            if (card.getSuit() == playedCard.getSuit()) {
                if (card.getFace().getValue() > playedCard.getFace().getValue()) {
                    // If it's a winning card and no winning card so far, or if it's the lowest winning card
                    if (winningCard == null || card.getFace().getValue() < winningCard.getFace().getValue()) {
                        winningCard = card;
                    }
                } else if (card.getFace().getValue() < playedCard.getFace().getValue()) {
                    // If it's the lowest winning card of the same suit
                    if (winningCard == null || card.getFace().getValue() < winningCard.getFace().getValue()) {
                        winningCard = card;
                    }
                }
            }
        }
    } catch (IndexOutOfBoundsException e) {
        System.out.println("IndexOutOfBoundsException caught. Hand size: " + setofcards.size());
    } finally {
        if (winningCard != null) {
            // If there is a winning card, play it
            setofcards.remove(winningCard);
            return winningCard.getFace().getValue();
        } else {
            // If no winning card, play the lowest card in the hand
            Card lowestCard = setofcards.get(0);
            for (int i = 1; i < setofcards.size(); i++) {
                Card card = setofcards.get(i);
                if (card.getFace().getValue() < lowestCard.getFace().getValue()) {
                    lowestCard = card;
                }
            }
            setofcards.remove(lowestCard);
            return lowestCard.getFace().getValue();
        }
    }

delicate cryptBOT Dec 22, 2023, 9:21 PM

#

icy violet I tried adapting your logic to my code, I need some assistance bug catching. Not...

Detected code, here are some useful tools:

icy violet Dec 22, 2023, 9:21 PM

#

Examples of times it doesnt work:
Initial Hand: [4♦ A♦ 8♣ 8♠ K♠ ]
Played Card: Q♠
Evaluated Value: 8

Should've played K

Initial Hand: [8♥ K♥ 3♣ 4♠ 10♣ ]
Played Card: J♠
Evaluated Value: 4

Should've played king here (13)

Initial Hand: [A♦ K♣ 5♦ 10♣ 8♣ ]
Played Card: 6♦
Evaluated Value: 5

Should've played ace here (14)

#

It seems to only play the lowest card of the suit

meager lily Dec 22, 2023, 9:41 PM

#

you are not catching the exception, how I described. when the exception happens, you have reached the end of the array. meaning, the card you now hold as the highest card as far, is the highest card.

icy violet Dec 22, 2023, 10:14 PM

#

So is the try catch inside the for loop

mint igloo Dec 22, 2023, 10:25 PM

#

meager lily you are not catching the exception, how I described. when the exception happens,...

Why are you suggesting exception handling as a control flow? This is beyond bad.

tribal zodiac Dec 22, 2023, 10:30 PM

#

yeah. a OOB exception is always a bug in the code

#

don't provoke it, create an if-else instead

#

its not that bad though. like, it would work. it's just not a habit u should get used to at all

meager lily Dec 23, 2023, 9:53 AM

#

mint igloo Why are you suggesting exception handling as a control flow? This is beyond bad.

he is checking with the next index, if this index out of bounds the code breaks, thats pretty much it. when he is at the last entry, he cannot check the next. otherwise he would need to check each entries index if it is the last of the list, which would increase computation time and defeat almost the entire point of the for loop.
But now that you mention it, he could also just sort the list and then take the highest entry. 🤷‍♂️
I suggested what I think works best.

craggy summit Dec 23, 2023, 11:58 AM

#

icy violet I tried adapting your logic to my code, I need some assistance bug catching. Not...

please don't catch IndexOutOfBoundsException

icy violet Dec 23, 2023, 3:07 PM

#

I’ve figured it out. Just sorted the list to get the highest card

#

Thank you all!

#

.close

delicate cryptBOT Dec 23, 2023, 3:08 PM

#

icy violet .close

Looks like you attempted to use a command? Please note that we only use slash-commands on this server 🙂

Try starting your message with a forward-slash / and Discord should open a popup showing you all available commands.
A command might then look like /foo 👍

#Confused on implementing this method