cant figure out whats wrong with my code | Together Java | Page 1

urban cosmos Sep 23, 2023, 8:35 AM

#

import java.util.Scanner;
import java.lang.Integer;
public class primeAdam 
{
   public static void main(String args[])
   {
      Scanner sc=new Scanner(System.in);
      int m,n,i,j,x=0,y,z,rev;
      System.out.println("enter m val");
      m=sc.nextInt();
      System.out.println("enter n val");
      n=sc.nextInt();
      while(m>n)
      {
           System.out.println("not valid.. try again");
           System.out.println("enter m val");
           m=sc.nextInt();
           System.out.println("enter n val");
           n=sc.nextInt();
      }
      sc.close();

      System.out.println("the prime-adam no.s within the range is ");
      
      if(m>10)
      m=10;

      for(i=m;i<n;i++)
      {
          for(j=1;j<=i;i++)
          {
            if(i%j==0)
            x++;
         }
         if(x==2)
         continue;
         y=Integer.reverse(i);
         z=i*i;
         rev=y*y;

         if(z==Integer.reverse(rev))
         System.out.print(i+" ");
      }



   }
    
}

the aim of the program is to check if a. the no. is prime and b. is the no. when squared and reversed is equal to the original no when squared

spring sageBOT Sep 23, 2023, 8:35 AM

#

urban cosmos ``` java import java.util.Scanner; import java.lang.Integer; public class primeA...

Detected code, here are some useful tools:

Formatted code

javaimport java.util.Scanner;
import java.lang.Integer;

public class primeAdam {
  public static void main(String args[] ) {
    Scanner sc = new Scanner(System.in);
    int m, n, i, j, x = 0, y, z, rev;
    System.out.println("enter m val");
    m = sc.nextInt();
    System.out.println("enter n val");
    n = sc.nextInt();
    while (m > n) {
      System.out.println("not valid.. try again");
      System.out.println("enter m val");
      m = sc.nextInt();
      System.out.println("enter n val");
      n = sc.nextInt();
    }
    sc.close();
    System.out.println("the prime-adam no.s within the range is ");
    if (m > 10) m = 10;
    for (i = m; i < n; i++) {
      for (j = 1; j <= i; i++) {
        if (i % j == 0) x++;
      }
      if (x == 2) continue ;
      y = Integer.reverse(i);
      z = i * i;
      rev = y * y;
      if (z == Integer.reverse(rev)) System.out.print(i + " ");
    }
  }
}

#

<@&987246399047479336> please have a look, thanks.

spring sageBOT Sep 23, 2023, 8:35 AM

#

spring sage <@&987246399047479336> please have a look, thanks.

#

While you are waiting for getting help, here are some tips to improve your experience:

Code is much easier to read if posted with syntax highlighting and proper formatting.

If nobody is calling back, that usually means that your question was not well asked and hence nobody feels confident enough answering. Try to use your time to elaborate, provide details, context, more code, examples and maybe some screenshots. With enough info, someone knows the answer for sure.

Don't forget to close your thread using the command </help-thread close:1027500463647621170> when your question has been answered, thanks.

#

Here is an AI assisted attempt to answer your question 🤖. Maybe it helps! In any case, a human is on the way 👍. To continue talking to the AI, you can use </chatgpt:1108714622413963314>.

#

Of course! Please provide the code you need help with, and let me know what specific issues or questions you have.

urban cosmos Sep 23, 2023, 8:40 AM

#

i cant seem to find whats wrong with this code

import java.util.Scanner;
import java.lang.Integer;
public class primeAdam 
{
   public static void main(String args[])
   {
      Scanner sc=new Scanner(System.in);
      int m,n,i,j,x=0,y,z,rev;
      System.out.println("enter m val");
      m=sc.nextInt();
      System.out.println("enter n val");
      n=sc.nextInt();
      while(m>n)
      {
           System.out.println("not valid.. try again");
           System.out.println("enter m val");
           m=sc.nextInt();
           System.out.println("enter n val");
           n=sc.nextInt();
      }
      sc.close();

      System.out.println("the prime-adam no.s within the range is ");
      
      if(m>10)
      m=10;

      for(i=m;i<n;i++)
      {
          for(j=1;j<=i;i++)
          {
            if(i%j==0)
            x++;
         }
         if(x==2)
         continue;
         y=Integer.reverse(i);
         z=i*i;
         rev=y*y;

         if(z==Integer.reverse(rev))
         System.out.print(i+" ");
      }



   }
    
}

urban cosmos Sep 23, 2023, 8:40 AM

#

spring sage Of course! Please provide the code you need help with, and let me know what spec...

i cant seem to find whats wrong with this code

import java.util.Scanner;
import java.lang.Integer;
public class primeAdam 
{
   public static void main(String args[])
   {
      Scanner sc=new Scanner(System.in);
      int m,n,i,j,x=0,y,z,rev;
      System.out.println("enter m val");
      m=sc.nextInt();
      System.out.println("enter n val");
      n=sc.nextInt();
      while(m>n)
      {
           System.out.println("not valid.. try again");
           System.out.println("enter m val");
           m=sc.nextInt();
           System.out.println("enter n val");
           n=sc.nextInt();
      }
      sc.close();

      System.out.println("the prime-adam no.s within the range is ");
      
      if(m>10)
      m=10;

      for(i=m;i<n;i++)
      {
          for(j=1;j<=i;i++)
          {
            if(i%j==0)
            x++;
         }
         if(x==2)
         continue;
         y=Integer.reverse(i);
         z=i*i;
         rev=y*y;

         if(z==Integer.reverse(rev))
         System.out.print(i+" ");
      }



   }
    
}

spring sageBOT Sep 23, 2023, 8:40 AM

#

urban cosmos i cant seem to find whats wrong with this code ``` import java.util.Scanner; i...

Detected code, here are some useful tools:

Formatted code

import java.util.Scanner;
import java.lang.Integer;

public class primeAdam {
  public static void main(String args[] ) {
    Scanner sc = new Scanner(System.in);
    int m, n, i, j, x = 0, y, z, rev;
    System.out.println("enter m val");
    m = sc.nextInt();
    System.out.println("enter n val");
    n = sc.nextInt();
    while (m > n) {
      System.out.println("not valid.. try again");
      System.out.println("enter m val");
      m = sc.nextInt();
      System.out.println("enter n val");
      n = sc.nextInt();
    }
    sc.close();
    System.out.println("the prime-adam no.s within the range is ");
    if (m > 10) m = 10;
    for (i = m; i < n; i++) {
      for (j = 1; j <= i; i++) {
        if (i % j == 0) x++;
      }
      if (x == 2) continue ;
      y = Integer.reverse(i);
      z = i * i;
      rev = y * y;
      if (z == Integer.reverse(rev)) System.out.print(i + " ");
    }
  }
}

#

The code you provided is incomplete. It seems that you are trying to import the Scanner class and the Integer class from the java.util and java.lang packages respectively. However, you have not completed the import statement for the Scanner class.

To fix this issue, you need to complete the import statement for the Scanner class by adding "Scanner;" after "java.util.Scanner". The corrected code should look like this:

import java.util.Scanner;
import java.lang.Integer;

public class primeAdam {
   public static void main(String args[]) {
      Scanner sc = new Scanner(System.in);
      // rest of your code
   }
}

Additionally, make sure that you have closed all brackets and semicolons correctly in your code.

feral meteor Sep 23, 2023, 9:28 AM

#

urban cosmos ``` java import java.util.Scanner; import java.lang.Integer; public class primeA...

any error u getting?

urban cosmos Sep 23, 2023, 9:29 AM

#

feral meteor any error u getting?

No errors it compiles and runs

feral meteor Sep 23, 2023, 9:33 AM

#

urban cosmos No errors it compiles and runs

Then, give me given input, wrong output and expected output

#

You want to check for a number, but from your code I can see, you are checking in a range from m to n.. Why m > 10, m = 10 ?? Why if x == 2, then continue ??

urban cosmos Sep 23, 2023, 9:37 AM

#

feral meteor You want to check for a number, but from your code I can see, you are checking i...

that checks if the no. is a prime no

urban cosmos Sep 23, 2023, 9:38 AM

#

feral meteor Then, give me given input, wrong output and expected output

thats the thing i get no output

#

#

the code keeps on taking values from the user and does not give anything

spring sageBOT Sep 23, 2023, 9:41 AM

#

@urban cosmos

Mixing any nextXXX method with nextLine from the Scanner class for user input, will not ask you for input again but instead result in an empty line read by nextLine.

To prevent this, when reading user input, always only use nextLine. If you need an int, do

int value = Integer.parseInt(scanner.nextLine());

instead of using nextInt.

Assume the following:

Scanner scanner = new Scanner(System.in);

System.out.println("Enter your age:");
int age = scanner.nextInt();
System.out.println("Enter your name:");
String name = scanner.nextLine();

System.out.println("Hello " + name + ", you are " + age + " years old");

When executing this code, you will be asked to enter an age, suppose you enter 20.
However, the code will not ask you to actually input a name and the output will be:

Hello , you are 20 years old.

The reason why is that when you hit the enter button, your actual input is

20\n

and not just 20. A call to nextInt will now consume the 20 and leave the newline symbol \n in the internal input buffer of System.in. The call to nextLine will now not lead to a new input, since there is still unread input left in System.in. So it will read the \n, leading to an empty input.

So every user input is not only a number, but a full line. As such, it makes much more sense to also use nextLine(), even if reading just an age. The corrected code which works as intended is:

Scanner scanner = new Scanner(System.in);

System.out.println("Enter your age:");
// Now nextLine, not nextInt anymore
int age = Integer.parseInt(scanner.nextLine());
System.out.println("Enter your name:");
String name = scanner.nextLine();

System.out.println("Hello " + name + ", you are " + age + " years old");

The nextXXX methods, such as nextInt can be useful when reading multi-input from a single line. For example when you enter 20 John in a single line.

stark onyx Sep 23, 2023, 9:42 AM

#

also, dont close scanners tied to System.in

#

also, put a print into ur loop to see whether ur stuck in an infinite loop

urban cosmos Sep 23, 2023, 9:46 AM

#

stark onyx also, dont close scanners tied to System.in

oh why so?

#

vscode suggested me to do it therefore did it

urban cosmos Sep 23, 2023, 9:47 AM

#

stark onyx also, put a print into ur loop to see whether ur stuck in an infinite loop

lemme see

stark onyx Sep 23, 2023, 9:48 AM

#

urban cosmos vscode suggested me to do it therefore did it

bc vsc is a bad ide for java

urban cosmos Sep 23, 2023, 9:49 AM

#

stark onyx bc vsc is a bad ide for java

what would u suggest for java?

stark onyx Sep 23, 2023, 9:49 AM

#

urban cosmos oh why so?

it will close System.in. which can then not be reopened again anymore. ur only supposed to close resources uve opened urself, which is not the case for System.in

stark onyx Sep 23, 2023, 9:49 AM

#

urban cosmos what would u suggest for java?

70% of java coders use intellij

urban cosmos Sep 23, 2023, 9:50 AM

#

stark onyx it will close System.in. which can then not be reopened again anymore. ur only s...

oh okay got it

urban cosmos Sep 23, 2023, 9:51 AM

#

stark onyx 70% of java coders use intellij

ive tried using it but vsc seems very easy to use for me

drowsy remnant Sep 23, 2023, 9:51 AM

#

stark onyx 70% of java coders use intellij

Probably even more pepekek

urban cosmos Sep 23, 2023, 9:52 AM

#

stark onyx also, put a print into ur loop to see whether ur stuck in an infinite loop

ur right its on an infinite loop

stark onyx Sep 23, 2023, 9:52 AM

#

urban cosmos ive tried using it but vsc seems very easy to use for me

that might be the case for mini programs. but as soon as u have multiple files or anything just a bit more complex, vsc just starts to collapse and u get tons of issues

urban cosmos Sep 23, 2023, 9:53 AM

#

stark onyx that might be the case for mini programs. but as soon as u have multiple files o...

oh wow didnt know that

#

ill used to intellij then

urban cosmos Sep 23, 2023, 9:53 AM

#

urban cosmos ur right its on an infinite loop

but why is it doing so?

#

import java.util.Scanner;
import java.lang.Integer;
public class primeAdam 
{
   public static void main(String args[])
   {
      Scanner sc=new Scanner(System.in);
      int m,n,i,j,x=0,y,z,rev;
      System.out.println("enter m val");
      m=sc.nextInt();
      System.out.println("enter n val");
      n=sc.nextInt();
      while(m>n)
      {
           System.out.println("not valid.. try again");
           System.out.println("enter m val");
           m=sc.nextInt();
           System.out.println("enter n val");
           n=sc.nextInt();
      }
      

      System.out.println("the prime-adam no.s within the range is ");
      
      if(m>10)
      m=10;

      for(i=m;i<n;i++)
      {
         System.out.println("check");

         for(j=1;j<=i;i++)
         {
            if(i%j==0)
            x++;
         }
         if(x==2)
         {
   
          y=Integer.reverse(i);
          z=i*i;
          rev=y*y;
          if(z==Integer.reverse(rev))
          System.out.print(i+" ");
          
         }
         

      }

   }
}

#

this is the change i have made

#

what have i messed up

stark onyx Sep 23, 2023, 10:02 AM

#

mind sharing the input and output?

#

is it still in an infinite loop?

#

also, u should replace ur scanner nextInt, as the bot explained

#

or ull run into more issues later on

urban cosmos Sep 23, 2023, 10:05 AM

#

stark onyx is it still in an infinite loop?

yes

urban cosmos Sep 23, 2023, 10:07 AM

#

stark onyx also, u should replace ur scanner nextInt, as the bot explained

im sorry but i do not understand what it means

stark onyx Sep 23, 2023, 10:08 AM

#

urban cosmos im sorry but i do not understand what it means

read ints as int x = Integer.parseInt(scanner.nextLine())

#

not with nextInt()

drowsy remnant Sep 23, 2023, 10:09 AM

#

Did you read the bots message?

urban cosmos Sep 23, 2023, 12:11 PM

#

stark onyx not with nextInt()

Iokay I just read it one more time

#

I understand now

feral meteor Sep 23, 2023, 1:32 PM

#

urban cosmos that checks if the no. is a prime no

if x == 2, then it is prime number if i am right, then why continue? why not proceed??

urban cosmos Sep 23, 2023, 1:33 PM

#

feral meteor if x == 2, then it is prime number if i am right, then why continue? why not pro...

Whats the difference?

#

And could I proceed

feral meteor Sep 23, 2023, 1:33 PM

#

urban cosmos Whats the difference?

U want to check if the number is prime and also the other condition of sq, then number is printed, right??

#

If the number is prime, why you continue, because as per the code, x == 2 is true when number is prime

feral meteor Sep 23, 2023, 1:35 PM

#

urban cosmos ``` java import java.util.Scanner; import java.lang.Integer; public class primeA...

here

urban cosmos Sep 23, 2023, 1:37 PM

#

feral meteor U want to check if the number is prime and also the other condition of sq, then ...

Yeah

urban cosmos Sep 23, 2023, 1:38 PM

#

feral meteor If the number is prime, why you continue, because as per the code, x == 2 is tru...

I'm continuing because it has to do the other part of the code only if the no. Is prime else just go back to I loop

feral meteor Sep 23, 2023, 1:38 PM

#

urban cosmos ```java import java.util.Scanner; import java.lang.Integer; public class primeAd...

ohh u changed code here

feral meteor Sep 23, 2023, 1:42 PM

#

urban cosmos ```java import java.util.Scanner; import java.lang.Integer; public class primeAd...

ur second loop from j=1 to j<=i.... its not incrementing j, but i

#

Do you even know, what Integer.reverse() function does??

urban cosmos Sep 23, 2023, 1:45 PM

#

feral meteor Do you even know, what Integer.reverse() function does??

It reverses an integer

#

That's what I think it does

feral meteor Sep 23, 2023, 1:46 PM

#

urban cosmos It reverses an integer

that reverses the bits of an integer

#

not the number

urban cosmos Sep 23, 2023, 1:48 PM

#

feral meteor that reverses the bits of an integer

Oh wow

#

What does that mean?

#

Please explain with an example

feral meteor Sep 23, 2023, 1:50 PM

#

urban cosmos Oh wow

https://www.geeksforgeeks.org/integer-reverse-method-in-java/

GeeksforGeeks

Integer reverse() Method In Java - GeeksforGeeks

A Computer Science portal for geeks. It contains well written, well thought and well explained computer science and programming articles, quizzes and practice/competitive programming/company interview Questions.

#

Check this out

twin crescent Sep 23, 2023, 1:51 PM

#

Confused question. What do you need?

urban cosmos Sep 23, 2023, 1:56 PM

#

twin crescent Confused question. What do you need?

The code does not work... I do not get my output

#

Even after accepting m and n it prints that one line and then continues to ask for inputs from the user

placid knot Sep 23, 2023, 1:57 PM

#

can u post your current code ? the code u posted above does not have any behavior like that

feral meteor Sep 23, 2023, 1:59 PM

#

urban cosmos Even after accepting m and n it prints that one line and then continues to ask f...

U need to do umm 2 changes only

#

U are wrongly reversing the number
You are not incrementing j pointer
Change these two, and ur code will work

urban cosmos Sep 23, 2023, 2:02 PM

#

feral meteor 1) U are wrongly reversing the number 2) You are not incrementing j pointer Chan...

oh okay umm how do i make these changes

urban cosmos Sep 23, 2023, 2:02 PM

#

placid knot can u post your current code ? the code u posted above does not have any behav...

this latest one is my current code it goes on an infinite loop now

placid knot Sep 23, 2023, 2:04 PM

#

do what Deepak suggested, start with his number 2 suggestion. That shouldnt take longer then 5 seconds to fix

urban cosmos Sep 23, 2023, 2:04 PM

#

placid knot do what Deepak suggested, start with his number 2 suggestion. That shouldnt take...

sure

#

but is there any function that can reverse an int

placid knot Sep 23, 2023, 2:04 PM

#

multiple ones, including a very easy to use

#

fix your loop first

urban cosmos Sep 23, 2023, 2:06 PM

#

placid knot fix your loop first

for(i=m;i<n;i++)
      {
         System.out.println("the prime-adam no.s within the range is ");

         for(j=1;j<=i;j++)
         {
            if(i%j==0)
            x++;
         }
         if(x==2)
         {
   
          y=Integer.reverse(i);
          z=i*i;
          rev=y*y;
          if(z==Integer.reverse(rev))
          System.out.print(i+" ");
          
         }
         

      }

   }
}

#

i made the change

placid knot Sep 23, 2023, 2:06 PM

#

and did u actually run it ? 😉

urban cosmos Sep 23, 2023, 2:06 PM

#

oh Wavey

#

#

the output

feral meteor Sep 23, 2023, 2:07 PM

#

urban cosmos oh okay umm how do i make these changes

To reverse a integer, you can change it to stringBuilder and then reverse it and then change to number again, check this ..
int y = Integer.parseInt(new StringBuilder(""+i).reverse().toString());

feral meteor Sep 23, 2023, 2:11 PM

#

urban cosmos

because the reverse method of urs is shifting bits

urban cosmos Sep 23, 2023, 2:15 PM

#

feral meteor because the reverse method of urs is shifting bits

yeah i just realized

#

but what is the use of shifting bits?

#

what will it do?

#

for(j=1;j<=i;j++)
         {
            if(i%j==0)
            x++;
         }
         if(x==2)
         {
   
          y = Integer.parseInt(new StringBuilder(""+i).reverse().toString());
          z=i*i;
          rev=y*y;
          int rev1=Integer.parseInt(new StringBuilder(""+rev).reverse().toString());
          if(z==rev1)
          System.out.print(i+" ");
          
         }

#

am i right?

#

and what exactly is string builder?

urban cosmos Sep 23, 2023, 2:16 PM

#

urban cosmos am i right?

ig not cause i still get the same output

#

and wb stringbuffer?

#

would i be able to achieve this using stringbuffer?

lyric fiber Sep 23, 2023, 2:21 PM

#

urban cosmos and wb stringbuffer?

you shouldn't use a StringBuffer

urban cosmos Sep 23, 2023, 2:22 PM

#

lyric fiber you shouldn't use a StringBuffer

why?

lyric fiber Sep 23, 2023, 2:22 PM

#

urban cosmos why?

It's legacy, StringBuilder is the same but better

urban cosmos Sep 23, 2023, 2:22 PM

#

lyric fiber It's legacy, StringBuilder is the same but better

oh wow okay got it

feral meteor Sep 23, 2023, 2:47 PM

#

urban cosmos yeah i just realized

ur x is global, make it local

#

ur code should look like this!

#

import java.lang.Integer;

public class primeAdam 
{
   public static void main(String args[])
   {
      Scanner sc=new Scanner(System.in);
      System.out.println("enter m val");
      int m=sc.nextInt();
      System.out.println("enter n val");
      int n=sc.nextInt();

      while(m>n)
      {
           System.out.println("not valid.. try again");
           System.out.println("enter m val");
           m=sc.nextInt();
           System.out.println("enter n val");
           n=sc.nextInt();
      }

      System.out.println("the prime-adam no.s within the range is ");
      
      if(m>10)
        m=10;

      for(int i=m;i<n;i++)
      {
        int x = 0;

         for(int j=1;j<=i;j++)
         {
            if(i%j==0)
                x++;
         }

         if(x==2)
         {
   
          int y = Integer.parseInt(new StringBuilder(""+i).reverse().toString());
          int z=i*i;
          int rev=y*y;
          if(z == Integer.parseInt(new StringBuilder(""+rev).reverse().toString()))
            System.out.print(i+" ");
         }
      }
   }
}```

urban cosmos Sep 23, 2023, 2:53 PM

#

Sure thing lemme check this out mate

urban cosmos Sep 23, 2023, 2:56 PM

#

feral meteor ```import java.util.Scanner; import java.lang.Integer; public class primeAdam ...

WOAH! it works!!

feral meteor Sep 23, 2023, 2:58 PM

#

urban cosmos WOAH! it works!!

its just the same code, just changed those which i state above

urban cosmos Sep 23, 2023, 2:58 PM

#

feral meteor its just the same code, just changed those which i state above

yeah ive noticed where i have gone wrong

#

thanks for the help mate

feral meteor Sep 23, 2023, 2:58 PM

#

peepo_java

urban cosmos Sep 23, 2023, 2:58 PM

#

im gonne learn a lil more on string builder

#

seems interesting

feral meteor Sep 23, 2023, 2:59 PM

#

yeah, that is good if you want to play with strings, because java has immutable strings

#

and it makes string mutable

urban cosmos Sep 23, 2023, 2:59 PM

#

feral meteor and it makes string mutable

yeah!

#

anyway thanks for the help mate

#

appreciate it

feral meteor Sep 23, 2023, 2:59 PM

#

np! 🙂

#

peepo_heart

urban cosmos Sep 23, 2023, 3:00 PM

#

feral meteor np! 🙂

is it fine if i add u as a friend

#

i can learn alot from you

feral meteor Sep 23, 2023, 3:01 PM

#

obvio cat_thumbs_up

#cant figure out whats wrong with my code