Leetcode Code review

[toxic adder]

Q Link : https://leetcode.com/problems/maximum-population-year/

My Code:

class Solution {
    public int maximumPopulation(int[][] logs) {
        int max = 0, year = logs[0][0],i,j,c = 0;

        for(i = 0; i < logs.length - 1; i++)
        {
            c = 0;
            for(j = 0; j < logs.length; j++)
            {
                if(i != j)
                {
                    if(logs[i][1] - 1  >= logs[j][0])
                        c++;
                }
            }
                if(c > max)
                {
                    max = c;
                    year = logs[i][0];
                }
        }
        return year;
    }
}```

am quite sure that the issue with my code is something related to lifespan of ith person but not able to rectify the issue.

[magic basin]

Detected code, here are some useful tools:

Formatted code

class Solution {
  public int maximumPopulation(int [] [] logs) {
    int max = 0, year = logs[0] [0] , i, j, c = 0;
    for (i = 0; i < logs.length - 1; i++) {
      c = 0;
      for (j = 0; j < logs.length; j++) {
        if (i != j) {
          if (logs[i] [1]  - 1 >= logs[j] [0] ) c++;
        }
      }
      if (c > max) {
        max = c;
        year = logs[i] [0] ;
      }
    }
    return year;
  }
}

<@&987246883653156906> please have a look, thanks.

[magic basin]

While you are waiting for getting help, here are some tips to improve your experience:

Code is much easier to read if posted with syntax highlighting and proper formatting.

If nobody is calling back, that usually means that your question was not well asked and hence nobody feels confident enough answering. Try to use your time to elaborate, provide details, context, more code, examples and maybe some screenshots. With enough info, someone knows the answer for sure.

Don't forget to close your thread using the command </help-thread close:1027500463647621170> when your question has been answered, thanks.

[opal monolith]

@toxic adder why are you convinced that only the first year entry will be "max year", what if it's a death year for person 1 but still 3 folks were alive during that time out of 4. Which could mean that 2nd entry in inside array is also a possibility? Could be one of the edge cases.

[opal monolith]

actually nvm, i think im wrong here. We might be able to cover that in birth year of other entries then.

[rigid totem]

Did you solve array sum queries?? It's a similar easy version of that

[rigid totem]

Can you state ur approach please, what idea u take on solving this?

If you want to know my array sum query approach where we will use prefix sum, then I can tell you how to do it, we don't have any query, so we change it a little bit

[magic basin]

Closed the thread due to inactivity.

If your question was not resolved yet, feel free to just post a message to reopen it, or create a new thread. But try to improve the quality of your question to make it easier to help you 👍

[toxic adder]

Can u elaborate on your Q?

[toxic adder]

am comparing each and every sub array of 2d with each other for the birth <= death - 1 and then increasing the counter c to indicate that when ith person population was max but I am not able to take the lifespan of that person into account which is breaking my logic

[rigid totem]

So in between two intervals, you are countings peeps alive, right? That's also can give you answer if the data is sorted !

[rigid totem]

Let's say, a person born in 1950 and other born in 1950 too, so I can say, people who are alive in 1950 are 2

And if someone died in 2040 and other in 2045, then in 2040, population is only 1 right ?? Cause according to question, if someone died in 2040, he is not considered in this year alive

That's the mere logic, i can say

We can implement something which just counts number of alive in a year, and use a prefix sum for it

[formal birch]

just for a general readability i'd recommend formatting your code like this:

if (a > 5) {
    // 4 spaces indentation
} else {
    System.out.println("hello!");
}

[magic basin]

Detected code, here are some useful tools:

Formatted code

if (a > 5) {
  // 4 spaces indentation
}
else {
  System.out.println("hello!");
}

[formal birch]

notice how { is on the same line

that's common amongst all java code

also this is more of a personal preference thing but doing

if (a > 5)
    System.out.println("a > 5");

is bad imo since if you want to add another line inside the if block you have to fight with your IDE a bit to add the open and close curly brace

[noble smelt]

and often people dont even notice and if they dont use a proper IDE, they will have a bug they never notice

if (a > 5)
  foo
  bar

wondering why bar is always executed

[formal birch]

Also your indentation in the highlighted section is off

and I'm not entirely sure what's going on here

int max = 0, year = logs[0][0],i,j,c = 0;

other than that this entire piece of code is like 24 lines so there isn't much to criticize

[toxic adder]

why would it be off when I am checking after each tarversal till end whether the given ith person has most count

[formal birch]

it's overindented

[toxic adder]

I was expecting a add on to my current code rather than critics so that I can implement the logic

[toxic adder]

just for the sake of readability as per beginners perspective

[formal birch]

you asked for a code review, where we criticize your code?

[formal birch]

overindentation is never more readable

[toxic adder]

yea that' s a better and easier way of doing it considering the given contrants but I wanted to change the current code to know better

[formal birch]

e.g.

// correct indentation
if (a > 5) {
    Foo.bar();
    Bar.foo();
}

// incorrect indentation (less readable)
if (a > 5) {
Foo.bar();
Bar.foo();
}

[toxic adder]

ok so your pointing out the opening { starting out from the point where the body begins

[formal birch]

no

[toxic adder]

idk why but it seems more readable to me

[formal birch]

I really don't know what to tell you other than it's not

[toxic adder]

the only diff I see is the curly brace

[formal birch]

does this help? maybe text wrapping is weird

there aren't spaces before the Foo.bar() and Bar.foo() lines in the second one

[toxic adder]

yea this matters

but I dont think that's the case with my code

[formal birch]

yes it is, but you overindent instead of underindenting

[toxic adder]

anyways help me out with the logic instead
would appreciate that

[glossy arch]

@toxic adder maybe repost the entire code cleaned up and more readable, code like that ( although it looks simple ) is not always quick to understand

( esp. when using variables like i/j/c )

[toxic adder]

class Solution 
{
    public int maximumPopulation(int[][] logs)
    {
        int max = 0, year = logs[0][0],i,j,c = 0;

        for(i = 0; i < logs.length - 1; i++)
        {
            c = 0;

            for(j = 0; j < logs.length; j++)
            {
                if(i != j)
                {
                    if(logs[i][1] - 1  >= logs[j][0])
                        c++;
                }
            }
            
            if(c > max)
            {
                max = c;
                year = logs[i][0];
            }
        }
        return year;
    }
}```

[magic basin]

Detected code, here are some useful tools:

[toxic adder]

I think this shouldn't be a problem now

[glossy arch]

make your c> max print out what it finds. They way your doing it at the moment, is based on the 1st number in the array

so your initial is 2033

then its 2039,2047

[rigid totem]

Yup !!