🔒 RISC-V emulator overview

[slate onyx]

Hello! I made a RISC-V emulator with some basic aah instructions so far
https://github.com/PetrarkaR/apocacore
And I was wondering if someone could take a look at just check if this is the right way to go about decoding instructions executing them. Currently everything works, you can run the thing with
python3 cpu.py -f test.apo -r Run -d debug
Maybe the argument parsing needs some... redoing
any other possible suggestions are very much appreciated

[versed umbra]

@slate onyx

Python help channel opened

Remember to:

• Ask your Python question, not if you can ask or if there's an expert who can help.
• Show a code sample as text (rather than a screenshot) and the error message, if you've got one.
• Explain what you expect to happen and what actually happens.

:warning: Do not pip install anything that isn't related to your question, especially if asked to over DMs.

Closes after a period of inactivity, or when you send !close.

[still fulcrum]

Just to the CLI, I'd personally lean towards python3 cpu.py run -d debug test.apo i.e. a pattern with a "run" subcommand (even if it's the only subcommand) so you don't need -r, and "run" would always need a .apo file so you don't need -f.

Otherwise the code itself seems reasonable to me. @slate onyx

[slate onyx]

thanks, imma think about that, this is gonna be awesome

[still fulcrum]

As an outsider it could do with some comments. There's quite a few magic numbers in there (the shift sizes, the names of the op codes etc). Just one liners.

[slate onyx]

Well those are fixed in the documentation of the RISC ISA but aight, I guess I could make it more accessible, wont hurt, thanks sir cameron

[still fulcrum]

Also, an overall comment up the top with a URL to the RISC ISA docs on the web. That lets the reader go to your reference source.
Example: https://github.com/cameron-simpson/css/blob/d72f226a0d6a92ae15b3c35d34912f70d3ca19ba/lib/python/cs/iso14496.py#L10

[versed umbra]

lib/python/cs/iso14496.py line 10

ISO make the standard available here:```

[slate onyx]

Gonna put that in tonight, gonna be a long one, implementing all the instructions probably along with some RVV instructions

[versed umbra]

Python help channel closed for inactivity

This help channel has been closed. Feel free to create a new post in #1035199133436354600. To maximize your chances of getting a response, check out this guide on asking good questions.