class Sprite:
def __init__(self):
raise RuntimeError("Do not use Sprite constructor directly")
@classmethod
def from_src(cls, img_src: str, frame_count: int, animation_duration_ms: int):
return cls._create(img_src, frame_count, animation_duration_ms)
@classmethod
def from_surface(cls, surface: pygame.Surface, frame_count: int, animation_duration_ms: int):
return cls._create(None, frame_count, animation_duration_ms, surface)
@classmethod
def _create(cls, img_src: str, frame_count: int, animation_duration_ms: int, surface: pygame.Surface = None):
self = object.__new__(cls)
if not surface:
self._sheet = pygame.image.load(img_src)
else:
self._sheet = surface
self._frame_count = frame_count
self._animation_duration = animation_duration_ms
self._last_frame_start_time = None
self._current_frame_index = 0
# assings 0 index sprite frame initially.
# this is important just in case anything wanna access sprite frame surface before draw
self._set_frame()
return self
#🔒 How to do this more pythonic
strange frost
spiral badgerBOT
```py
class Sprite:
def __init__(self):
raise RuntimeError("Do not u...
@strange frost
Python help channel opened
gaunt sundial
```py
class Sprite:
def __init__(self):
raise RuntimeError("Do not u...
are the attributes you assign to the made instance in _create meant to be protected?
whats the point of making them protected if you don't use them within the class at all
strange frost
are the attributes you assign to the made instance in `_create` meant to be prot...
Sprite class can be created either with img_src (string) or via surface(pygame.Surface.) not both
basically this is main problem
i have from_src and from_surface factory methods
i use them to create Sprite
gaunt sundial
yeah but,
if not surface:
self._sheet = pygame.image.load(img_src)
else:
self._sheet = surface
self._frame_count = frame_count
self._animation_duration = animation_duration_ms
self._last_frame_start_time = None
self._current_frame_index = 0
why do they gotta be protected though
strange frost
yeah but,
```py
if not surface:
self._sheet = pygame.image.l...
i always create protected members
i make them public if needed
it is just my practice
gaunt sundial
in python its actually the opposite
strange frost
in python its actually the opposite
most languages it is always private first as far as i know
gaunt sundial
in python nothing is private
gaunt sundial
but i dont see you accessing them within the class so it doesnt make sense to make it protected in the first place
strange frost
but i dont see you accessing them within the class so it doesnt make sense to ma...
that class is not full code
gaunt sundial
oh
strange frost
i cannot send it is too long
gaunt sundial
!paste
spiral badgerBOT
strange frost
please just focus the factory function side it is my main problem. it looks ugly and also i cannot type return type
like this:
class Sprite:
....
@classmethod
def from_src(cls, img_src: str, frame_count: int, animation_duration_ms: int) -> Surface:
return cls._create(img_src, frame_count, animation_duration_ms)
...
that is quite an interesting class you got
you cannot create an instance yet you have methods which require an instance so you manually make an instance through the class methods and pass it to normal methods
gaunt sundial
like this:
```py
class Sprite:
....
@classmethod
def from_src(cls, img_...
yeah it wouldnt make sense because that method is return an instance of the Sprite class.
youll have to do from __future__ import annotations at the top of your file to make that sort of type hint
strange frost
pleas look this:
https://paste.pythondiscord.com/6FLQ
there was weird naming there
strange frost
yeah it wouldnt make sense because that method is return an instance of the `Spr...
i see thanks
gaunt sundial
also why dont you allow instantiation of the Sprite class?
strange frost
in other languages i just used two different overloaded constructor
strange frost
also why dont you allow instantiation of the Sprite class?
because sometimes you wanna transform sprite sheet image then create Sprite from it you know
i just let user create their own image and do whatever on it then pass sprite
sprite class just responsible to play that sprite sheet
in my case my sprite sheet character is so small so i do this:
surface = pygame.transform.scale_by(pygame.image.load("asset/Idle.png"), 4)
self._sprite = Sprite.from_surface(surface, frame_count=18, animation_duration_ms=2000)
i decided to just force user pass surface
gaunt sundial
gaunt sundial
i decided to just force user pass surface
lmao i see
gaunt sundial
https://paste.pythondiscord.com/TKXQ
this is how id do ig, i added those attributes to the init so you can get the type hint within the class atleast and fixed some typing issues
strange frost
https://paste.pythondiscord.com/TKXQ
much better but still sucks
gaunt sundial
yeah.
strange frost
python is "keep it stupid simple" language
gaunt sundial
if youre gonna force it to pass a surface only you gonna remove from_src and _create and just put it's functionality into from_surface?
gaunt sundial
oh lol
strange frost
that not surface check is not needed i will fix it
gaunt sundial
oh yeah thats much better
spiral badgerBOT
Python help channel closed for inactivity