homework project to make a top trumps game using oop, made a computer player and human player class.
for the main i did while len(humanplayer.deck) > 0 or len(computerplayer.deck) > 0: to keep the game running as long as either class still has cards but i get that error, never encountered smth like that before
#🔒 TypeError: HumanPlayer.options() takes 0 positional arguments but 1 was given
tardy trout
austere ferryBOT
homework project to make a top trumps game using oop, made a computer player and...
@tardy trout
Python help channel opened
wary ice
homework project to make a top trumps game using oop, made a computer player and...
types.GenericAlias is what you get when you do something like list[int] or set[str]
!e ```py
print(type(list[str]))
:white_check_mark: Your 3.12 eval job has completed with return code 0.
<class 'types.GenericAlias'>
class Player:
def init(self,deck):
self.deck = list[deck]
def addcardtoback(newCard,wondeck,lostdeck):
woncard = wondeck[0]
woncard.append(wondeck)
wondeck.pop[0]
newCard.append(wondeck)
lostdeck.pop[0]
austere ferryBOT
Hey @tardy trout!
wary ice
see
tardy trout
must be related to this then
human and computer class inherit the player class
i think i get some sort of error if i use square brackets for the self list though
gimme a second
wary ice
class Player:
def __init__(self,deck):
self.deck = list[deck]
def ...
self.deck = list[deck]
you're setting it to be list[T] (T being some object)
tardy trout
i think i get some sort of error if i use square brackets for the self list thou...
i mean normal brackets sorry
tardy trout
you're setting it to be `list[T]` (`T` being some object)
yep
wary ice
yep
see what i did earlier? #1328089097583071343 message
wary ice
class Player:
def __init__(self,deck):
self.deck = list[deck]
def ...
can i also suggest you rewrite your code for this? it looks quite messy to be honest
tardy trout
what would u change
wary ice
were u casting or uhhh
!e ```py
x = list[str]
x_type = type(x)
print(x_type)
:white_check_mark: Your 3.12 eval job has completed with return code 0.
<class 'types.GenericAlias'>
see
the type of list[str] is types.GenericAlias
list[str] isn't a built-in list - it's a types.GenericAlias object
tardy trout
sorta following
blazing dawn
i still wonder how GenericAlias knows what type the original has
wary ice
what would u change
- whitespace between functions
- whitespace between arguments
- consistent naming conventions for arguments (seriously tho - what is
newCard,wondeckandlostdeck? what are these names?) - preferably some typehints as annotations to make it easier for people reading your code to know the types of each variable
wary ice
i still wonder how GenericAlias knows what type the original has
!d types.GenericAlias
austere ferryBOT
blazing dawn
- whitespace between functions
- whitespace between arguments
- consistent namin...
maybe use a formatter? ruff or black
wary ice
you instantiate it WITH the original type, plus its args
tardy trout
- whitespace between functions
- whitespace between arguments
- consistent namin...
when u say white space do u just mean gaps
again im relatively new so bear wit me sorry lol
blazing dawn
just space <-
tardy trout
ok
wary ice
!e ```py
from types import GenericAlias
class Collection:
def class_getitem(cls, T: type) -> None:
return GenericAlias(cls, (T,))
collection = Collection[int]
print(collection, type(collection))
:white_check_mark: Your 3.12 eval job has completed with return code 0.
__main__.Collection[int] <class 'types.GenericAlias'>
ah shit, that should be -> GenericAlias, not -> None
blazing dawn
gg
wary ice
instinct
wary ice
again im relatively new so bear wit me sorry lol
no problem
wary ice
when u say white space do u just mean gaps
yep. whitespace is anything that isn't rendered
basically invisible characters
blazing dawn
also \n and \t
tardy trout
alright
wary ice
also \n and \t
\r, \n, \t, \f, \v and
tardy trout
in terms of the variable names ig theyd only make sense in terms of the context but yeah they could be named better
for sure
blazing dawn
`\r`, `\n`, `\t`, `\f`, `\v` and ` `
yas
tardy trout
TypeError: HumanPlayer.options() takes 0 positional arguments but 1 was given
wary ice
in terms of the variable names ig theyd only make sense in terms of the context ...
instead of wondeck and lostdeck, you can instead have winning_deck and losing_deck
tardy trout
uhhh hold up
tardy trout
instead of `wondeck` and `lostdeck`, you can instead have `winning_deck` and `lo...
ya sounds way better
dire pecan
i mean normal brackets sorry
this was the issue, right?
wary ice
TypeError: HumanPlayer.options() takes 0 positional arguments but 1 was given
not sure what this is related to
blazing dawn
TypeError: HumanPlayer.options() takes 0 positional arguments but 1 was given
can you paste the entire traceback?
wary ice
this was
dire pecan
well that is why they got a GenericAlias
tardy trout
not sure what this is related to
am i allowed to talk about multiple errors
this is a new one im getting
dire pecan
it should've been list(...)
tardy trout
like just now after changing the list thingy
dire pecan
!paste
austere ferryBOT
dire pecan
can you put the full, current code here?
dire pecan
(then paste the resultant link)
tardy trout
give criticism tho
its not that long
@blazing dawn ^
oh yeah right the project involves us creating objects
from a text file that our teacher gave us
we read the lines
of the text file
and make card objects
wary ice
am i allowed to talk about multiple errors
yeah sure. if you want to, you can change your post name to match your current error
tardy trout
sure
wary ice
sure
class Card:
def __init__(self,title,price,ram,clockspeed,year,lifespan,popularity):
self.title = str(title)
self.price = float(price)
self.ram = int(ram)
self.clockspeed = float(clockspeed)
self.year = float(year)
self.lifespan = float(lifespan)
self.popularity = float(popularity)
probably use a dataclass
!d dataclasses.dataclass
austere ferryBOT
tardy trout
TypeError: HumanPlayer.options() takes 0 positional arguments but 1 was given
austere ferryBOT
austere ferryBOT
dire pecan
!d dataclasses.dataclass
that won't be conducive to fixing their error tho
wary ice
@dataclass
class Card:
title: str
price: float
ram: int
clock_speed: float
year_released: float
lifespan: float
popularity: float
follow PEP8 or die /j
wary ice
that won't be conducive to fixing their error tho
it's worth pointing out
tardy trout
i wanna fix all the current errors before i work on optimising the program
ill look into the formatting stuff and decorators tho
our teacher is pretty shit so everything ive done ive had to research
doesnt tell us anything
wary ice
what the hell happened here
blazing dawn
ewwwwwwww
small maple
if you use a decent IDE, you usually see hints like these:
blazing dawn
what the hell happened here
while stat not in {1, 2, 3}
dire pecan
let's focus on helping them instead of roasting them
tardy trout
let's focus on helping them instead of roasting them
😭
blazing dawn
were not roasting them
wary ice
i wanna fix all the current errors before i work on optimising the program
ok your issue is not using @staticmethod
blazing dawn
its just a lot of new comers dont really do anything about formatting
wary ice
what it's trying to do is do HumanPlayer.options(instance)
blazing dawn
and i think its okay to guide them to use them
wary ice
this doesn't work because the arguments are empty
self is always the first argument in a method
!e ```py
class A:
def f(n: int) -> int:
return n
print(A.f(5))
print(A().f(5))
:x: Your 3.12 eval job has completed with return code 1.
001 | 5
002 | Traceback (most recent call last):
003 | File "/home/main.py", line 6, in <module>
004 | print(A().f(5))
005 | ^^^^^^^^
006 | TypeError: A.f() takes 1 positional argument but 2 were given
gg
wary ice
see
tardy trout
what it's trying to do is do `HumanPlayer.options(instance)`
i was tryna call upon a function in the class rather an instance though
wary ice
!e ```py
class A:
def f(n: int) -> int:
return n
print(A.f(5))
prin...
because we call it on the class and not the object, it works perfectly fine because the object is what provides self
tardy trout
or is that the same thing
wary ice
or is that the same thing
nope
wary ice
i was tryna call upon a function in the class rather an instance though
you're calling upon a function through an instance instead of a class
that's what that error means
blazing dawn
class and instance methods / attrs are super different
tardy trout
alr
blazing dawn
make it classmethod or staticmethod
small maple
There are several issues with the usage of classes and functions/methods here... the methods are basically just functions, and they access the global variables computerplayer and humanplayer ..
Those "methods" assign to humanstat etc. which are not global, but used outside (at the bottom) as if they're meant to be globals.
blazing dawn
they should attr to self
tardy trout
There are several issues with the usage of classes and functions/methods here......
should i define them outside
the class
blazing dawn
if you dont plan on sharing data across functions then yes
like this is the way to eliminate globals
theyre jucky
small maple
the problem is, that you can't change humanstat without making it global - which is bad practise.. or imho you could just get rid of classes, and simply use arguments and return values with those functions
tardy trout
that would be nice but our teacher specified that we have to make classes
wide ruin
hes my boyfriend dude..
tardy trout
make it classmethod or staticmethod
yo btw abt this
i know nothing abt methods
so basically
if i put the decorator @classmethod
above my function
does that change something
small maple
a method is a function in a class, that has "self" as first argument... staticmethod and classmethod are special kind of methods, and I don't think you should use them, if you don't understand them yet. Your teacher would 100% ask you to explain them if you did 😉
wary ice
does that change something
it's a python built-in decorator (lets you do stuff before or after a function) that turns an instance method into a class method
small maple
just stick to the basic rule for now: every single function/method in your class should have "self" as first parameter.
blazing dawn
just stick to the basic rule for now: every single function/method in your class...
^ does he even have a code editor with a good enough type checker?
tardy trout
just stick to the basic rule for now: every single function/method in your class...
yep now that works
thank u bro
NameError: name 'humanstat' is not defined
prolly cuz i defined it within the switch statement
what should i call it outside
humanstat = " " ?
actually idk
tardy trout
^ does he even have a code editor with a good enough type checker?
im using idle
small maple
that won't work. the humanstat inside of the function is a different variable from the humanstat outside of it
tardy trout
oh wait did i make 2
small maple
!e
myvar = 123
def change_myvar():
myvar = 456
change_myvar()
print(myvar)
:white_check_mark: Your 3.12 eval job has completed with return code 0.
123
changing a variable in a function doesn't actually affect the variable outside of it
unless you declare it to be a global variable inside of that function, but that is bad practise
the right way would usually to return the value instead
blazing dawn
the right way would usually to return the value instead
^ no global, return or use self
small maple
!e
myvar = 123
def change_myvar():
myvar = 456
return myvar
myvar = change_myvar() # this becomes whatever is returned
print(myvar)
:white_check_mark: Your 3.12 eval job has completed with return code 0.
456
terrible idea. get vscode or a jetbrains editor like sani
blazing dawn
terrible idea. get [vscode](https://code.visualstudio.com) or a jetbrains editor...
i mean its fun to try lol
tardy trout
thats jus what our school computers usin
wary ice
i mean its fun to try lol
i've only ever used IDLE for unit tests when i forgot how python works. there's not really much of a reason outside of that to use it
blazing dawn
i've only ever used IDLE for unit tests when i forgot how python works. there's ...
alt+m
tardy trout
AttributeError: 'HumanPlayer' object has no attribute 'options'
happens when its the players turn
blazing dawn
AttributeError: 'HumanPlayer' object has no attribute 'options'
what is options?
a method or an attribute?
also resend code
!paste
austere ferryBOT
tardy trout
hard haven
it looks like the options method is defined within your init, so it's contained to the scope of the init function. it's not part of the class, as such, but rather to that specific function. Unindent the definition for the options function to same indentation level as the init.
hard haven
you got it to work how you expected it to?
tardy trout
you got it to work how you expected it to?
i mean theres still this
NameError: name 'humanstat' is not defined
gonna read over what sani said again
cuz im not 100% sure on it
i think everything else in theory should work after that but uh
who knows
hard haven
if you're still stuck then ping me and I'll see what i can do with the code you have so far.
tardy trout
@hard haven how would i put what sani said into practice in terms of my code
sry a bit slow lol
hard haven
no worries, let me go read it quickly
what does your code look like at the moment?
@tardy trout
hard haven
Now reading through it, I'll start by creating the global variables in the program, modifying the class to interact with these, and going from there
tardy trout
thats what i was thinking but whys that bad practice like sani said
hard haven
It's usually because if you try to have multiple classes using global variables with the same name, they will affect each other
e.g. If both wanted to use a global variable called stat, it would be the same variable in the eyes of the interpreter, and they will change the same variable and cause stuff to not be cool
tardy trout
damn that sounds long
hard haven
it kinda was but its alr
I think it should work, but can you give me a cards.txt to use just to test it?
tardy trout
when the player wins they can choose their card again
i mean
the category/stat
goes for both human and computer
hard haven
I think I'm a lot closer, but still has errors. I'll paste the edited version in here and if you have any worries about it then let me know
@tardy trout https://paste.pythondiscord.com/CWDQ
This is what I have done so far, but haven't had enough time to fix the other errors occurring.
hard haven
its a dunder (double underscore) method that returns a dictionary form of the card.
i'll have to add it in later, but its the dictionary equivalent of __str__
tardy trout
ill research that
hard haven
I'm gonna go to sleep soon because it's getting late for me, so if you ping me I won't see it until like 8am GMT. Still ping me tho if you have any issues so it prioritises over other dc notifications for me
hard haven
❤️
austere ferryBOT
Python help channel closed