🔒 First Real Project. Looking For Feedback

[tepid wharf]

Oh lord, lots of firsts here. I don't know what a git is, and at this point I'm too afraid to ask lol. This is my first serious attempt at something with objects. There are a few modules, but the one that ties them together is cardBoard. Each module has a command line demo that runs if you run it, as an example of how one might use it. I feel like I learned a lot making this, but I'm totally self-taught, so I don't know how well I understand what I'm doing.

The first thing I'm looking for is anything I did really wrong. Anything that I need to change.
The second thing, though, is subjective help. What do I need to focus on improving? Could I clean anything up?

https://github.com/Sidhean/CardBoard
also it just occured to me that this is a lot to ask someone to read through. if i'm better off asking somewhere specific, please let me know!

[rapid dagger]

@tepid wharf

Python help channel opened

Remember to:

• Ask your Python question, not if you can ask or if there's an expert who can help.
• Show a code sample as text (rather than a screenshot) and the error message, if you've got one.
• Explain what you expect to happen and what actually happens.

:warning: Do not pip install anything that isn't related to your question, especially if asked to over DMs.

Closes after a period of inactivity, or when you send !close.

[lunar rampart]

This is all pretty good, particularly for a first project.
Almost everything I'd say is minor.

1: You've got an empty __init__.py, which makes this a package (should you wish it). You could move all the files down a level (eg into a folder called cardboard).

2: If you did that, then all your import deck and so forth for importing adjacent modules from your project can be relative (purely within the package) imports:

from .card import Card

and so forth.

3: We usually group our imports, roughly: stdlib (eg random), third party (eg some extra package like PIL) and local (eg card). So for example deck.py would start:

# stdlib
from random import shuffle

# local stuff
from .card import Card

and there's a bunch of tiny things.

[tepid wharf]

I see. 3 makes sense and the others give me enough to figure it out. thanks! and yeah, that "bunch of tiny things" is what i was worried about, but I'm glad nothing major jumped out at you

[rapid dagger]

Python help channel closed

This help channel has been closed and it's no longer possible to send messages here. If your question wasn't answered, feel free to create a new post in #1035199133436354600. To maximize your chances of getting a response, check out this guide on asking good questions.