fallen moat
Firstly I am absolutely amazed that my comprehension has gotten to this point, but is this the best way to iterate?
It works currently, and this is an example of ['params']['global-state'] structure:
[{'key': 'TklLT21vbkNvdW50ZXI=', 'value': {'bytes': 'AAAAAAAAAAA=', 'type': 1, 'uint': 0}}, {'key': 'TklLT21vblVJRENvdW50ZXI=', 'value': {'bytes': 'AAAAAAAAAAA=', 'type': 1, 'uint': 0}}]
graceful sandalBOT
```current_counter = [x['value']['uint'] for x in algod_client.application_info(...
@fallen moat
Python help channel opened
unkempt burrow
wth is that if thats one line than its awful for readability
undone summit
I mean, it's not too bad
unkempt burrow
i would at least try to add enters and indentation if i must have a list copm like that
fallen moat
I should indent then?
current_counter = [x['value']['uint']
for x in current_counter
if b64decode(x['key']) == b'Counter'][0] + 1```Something like this?
undone summit
You could do something like
g_state = algod_client.application_info(app_id)['params']['global-state']
current_counter = [x['value']['uint'] for x in g_state if b64decode(x['key']) == b'Counter'][0]
oh the last [0] + 1 threw me off lol
can you convert that whole struct to a dict?
like
g_state = {x['key']: x['value'] for x in algod_client.application_info(app_id)['params']['global-state']
And then you can just access the counter directly
print(g_state['Counter']['uint'])
Oh im sorry so I redacted the b'Counter' for some reason its actually b'NIKOmonCounter'
I originally was going to share in a different discord where I didn't want to disclose that
g_state = algod_client.application_info(app_id)['params']['global-state']
current_counter = [x['value']['uint'] for x in g_state
if b64decode(x['key']) == b'NIKOmonCounter'][0] + 1```So like this?
Looks OK?
undone summit
yeah seems ok. I would consider mapping the whole list of key value pairs to a dict too though
fallen moat
Becomes
{'TklLT21vbkNvdW50ZXI=': {'bytes': 'AAAAAAAAAAA=', 'type': 1, 'uint': 0}, 'TklLT21vblVJRENvdW50ZXI=': {'bytes': 'AAAAAAAAAAA=', 'type': 1, 'uint': 0}}
Methods comparison:
g_state = algod_client.application_info(app_id)['params']['global-state']
current_counter = [x['value']['uint'] for x in g_state
if b64decode(x['key']) == b'NIKOmonCounter'][0] + 1
g_state_2 = {x['key']: x['value'] for x in algod_client.application_info(app_id)['params']['global-state']}
current_counter_2 = [y['uint'] for x, y in g_state_2.items()
if b64decode(x) == b'NIKOmonCounter'][0] + 1```I feel like the original looks a little cleaner without mapping, but perhaps I'm doing it wrong
undone summit
```[{'key': 'TklLT21vbkNvdW50ZXI=', 'value': {'bytes': 'AAAAAAAAAAA=', 'type': 1...
You can b64decode the key first heh
fallen moat
g_state_2 = {b64decode(x['key']): x['value'] for x in algod_client.application_info(app_id)['params']['global-state']}
current_counter_2 = [y['uint'] for x, y in g_state_2.items()
if x == b'NIKOmonCounter'][0] + 1```g_state = {b64decode(x['key']): x['value'] for x in algod_client.application_info(app_id)['params']['global-state']}
print(g_state[b'NIKOmonCounter'])
The point of converting to dict is to avoid needing to loop through the whole array again
fallen moat
# Method 1
g_state = algod_client.application_info(app_id)['params']['global-state']
current_counter = [x['value']['uint'] for x in g_state
if b64decode(x['key']) == b'NIKOmonCounter'][0] + 1
# Method 2
g_state_2 = algod_client.application_info(app_id)['params']['global-state']
mapped_g_state_2 = {b64decode(x['key']): x['value'] for x in g_state}
current_counter_2 = [y['uint'] for x, y in mapped_g_state.items()
if x == b'NIKOmonCounter'][0] + 1
Hmm...
Could you explain please?
Method 1 loops through the array twice?
undone summit
```py
g_state = {b64decode(x['key']): x['value'] for x in algod_client.applicati...
Look at the second line here
you can access by key now
🤷 i don't know what the rest of your code looks like; i.e. if you even use this global-state thing anywhere else. But if you do, then converting to a dict first will really help
thick summit
```current_counter = [x['value']['uint'] for x in algod_client.application_info(...
I'll be honest, I would probably turn this into a full for statement. I feel there's too much going on on that line.
Or at least split it up so the [0] + 1 is happening separately.
undone summit
Yeah, i really don't like indexing a list that was created on the same line
That's what led me to the "convert the whole thing to a dict first" idea
thick summit
Also, if all you care about is the first element produced, this comprehension is wasteful since it may produce many elements that will get thrown away. An easy way to do the same operation lazily is to combine next with a generator expression:
first = next(x['value']['uint'] for x in algod_client.application_info(app_id)['params']['global-state'] if b64decode(x['key']) == b'Counter')
added = first + 1
Yeah. This is looking very golfy still
thick summit
Ya. I still don't like the look of it. A normal for loop would make it trivial to do an early exit as well.
graceful sandalBOT
Python help channel closed