🔒 pls rate my code | Python | Page 1

zinc galeBOT Sep 22, 2024, 2:27 PM

#

@young bay

Python help channel opened

Remember to:

Ask your Python question, not if you can ask or if there's an expert who can help.
Show a code sample as text (rather than a screenshot) and the error message, if you've got one.
Explain what you expect to happen and what actually happens.

:warning: Do not pip install anything that isn't related to your question, especially if asked to over DMs.

young bay Sep 22, 2024, 2:27 PM

#

#

main ```py
import time
from threading import Thread

import Modules.DataModule as DataModule
import Modules.UtilsModule as UtilsModule

def playtime() -> None:
stats = DataModule.get_stats()

while True:
    time.sleep(1)

    stats["time_spent_listening"] += 1

def main() -> None:
DataModule.load_data()

playtime_thread = Thread(target=playtime)
playtime_thread.start()

UtilsModule.check_for_mode()

UtilsModule.handle_users_input()

input()

if name == 'main':
main()

tall plume Sep 22, 2024, 2:28 PM

#

You managed to package it into a wheel file or exe?

young bay Sep 22, 2024, 2:28 PM

#

ye

#

wheel

#

im just asking if my code is good now tho

#

this is not packaged version

tall plume Sep 22, 2024, 2:29 PM

#

its simple

#

simple is good

young bay Sep 22, 2024, 2:29 PM

#

its the main script thats what its suposed to be

#

let me get the modules

tall plume Sep 22, 2024, 2:30 PM

#

why not push it to your Github and share the repo?

young bay Sep 22, 2024, 2:30 PM

#

good idea

#

gimme 1 sec

#

actual like a few min

#

is this how im supposed to do it?
https://github.com/GrawityFals/Grawify/tree/main

GitHub

GitHub - GrawityFals/Grawify

Contribute to GrawityFals/Grawify development by creating an account on GitHub.

#

im not used to github yet

tall plume Sep 22, 2024, 2:38 PM

#

its not but its a start

young bay Sep 22, 2024, 2:39 PM

#

so what did i do wrong?

tall plume Sep 22, 2024, 2:40 PM

#

When I see anyone who uses global, I go ewww
https://github.com/GrawityFals/Grawify/blob/main/Grawify 1.0 Release/Modules/DataModule.py#L23-L24

zinc galeBOT Sep 22, 2024, 2:40 PM

#

Grawify%201.0%20Release/Modules/DataModule.py lines 23 to 24

global settings
global stats```

young bay Sep 22, 2024, 2:40 PM

#

is it bad?

#

oh ye i forgot abt that

tall plume Sep 22, 2024, 2:40 PM

#

!global

zinc galeBOT Sep 22, 2024, 2:40 PM

#

Globals

When adding functions or classes to a program, it can be tempting to reference inaccessible variables by declaring them as global. Doing this can result in code that is harder to read, debug and test. Instead of using globals, pass variables or objects as parameters and receive return values.

Instead of writing

def update_score():
    global score, roll
    score = score + roll
update_score()

do this instead

def update_score(score, roll):
    return score + roll
score = update_score(score, roll)

For in-depth explanations on why global variables are bad news in a variety of situations, see this Stack Overflow answer.

young bay Sep 22, 2024, 2:40 PM

#

i was told i shoudnt use it

#

ups mb

tall plume Sep 22, 2024, 2:40 PM

#

💯

young bay Sep 22, 2024, 2:41 PM

#

so i was thinking

#

insted of using globals

#

what if i made a function for that?

#

like you ask and it returns that

#

or changes

#

would that be better?

tall plume Sep 22, 2024, 2:42 PM

#

I don't understand why you would make it a function. Its already a function. You just need to pass it in as a parameter/arg

young bay Sep 22, 2024, 2:42 PM

#

oh

#

me dumb

#

ye i get it

tall plume Sep 22, 2024, 2:42 PM

#

zinc gale

As explained and recommended here ☝️

young bay Sep 22, 2024, 2:42 PM

#

but i was thinking i was told

#

i shouldnt put things in outer most scope

#

or is it global scope

tall plume Sep 22, 2024, 2:42 PM

#

you can put things in outer scope

young bay Sep 22, 2024, 2:42 PM

#

ok

tall plume Sep 22, 2024, 2:43 PM

#

just pass it in as parameters

#

not as global

young bay Sep 22, 2024, 2:43 PM

#

so its just the keywork global that you dont like

#

i just have 1 quesiotn?

tall plume Sep 22, 2024, 2:43 PM

#

no thats not why I don't like it

tall plume Sep 22, 2024, 2:43 PM

#

zinc gale

This explains why I don't like it ☝️

young bay Sep 22, 2024, 2:43 PM

#

if i change something that is send as a parameter will it create a new copy of that or just change it

tall plume Sep 22, 2024, 2:44 PM

#

I don't understand

young bay Sep 22, 2024, 2:44 PM

#

so you said pass as parameter right

#

so if i change that like idk setings[dsds] ) = sasas

#

will it create a new version of settings

#

or update the old one

tall plume Sep 22, 2024, 2:45 PM

#

I dont think you understand what you're asking. There's no "version" when you pass them in as parameters

#

They're the same

young bay Sep 22, 2024, 2:45 PM

#

ok

#

that was my question

tall plume Sep 22, 2024, 2:46 PM

#

Yea but there's no such thing as "old version" or "new version".

#

anyways

young bay Sep 22, 2024, 2:46 PM

#

oh so there isnt?

#

gottcha

#

ye ima remove use of global keyword

tall plume Sep 22, 2024, 2:46 PM

#

Why call the function here? https://github.com/GrawityFals/Grawify/blob/main/Grawify 1.0 Release/Modules/PlaySongsModule.py#L129

zinc galeBOT Sep 22, 2024, 2:46 PM

#

Grawify%201.0%20Release/Modules/PlaySongsModule.py line 129

play_random_song_you_have_not_played()```

young bay Sep 22, 2024, 2:46 PM

#

wdym?

#

ah recursion

tall plume Sep 22, 2024, 2:46 PM

#

Its calling the function within in the function

#

Why?

young bay Sep 22, 2024, 2:47 PM

#

yes

#

so

#

when a song finishes

#

it doesnt return anything

#

and it just calls itself

#

so its like a loop

#

my logic

tall plume Sep 22, 2024, 2:47 PM

#

I guess

#

A bunch of your functions don't return anything

young bay Sep 22, 2024, 2:48 PM

#

dont ask why i did that in play_random_song_you_have_not_played func and not in play_random_song func

tall plume Sep 22, 2024, 2:48 PM

#

Which is gonna be challenging if you ever need to write unit tests

young bay Sep 22, 2024, 2:48 PM

#

tall plume A bunch of your functions don't return anything

that bad?

tall plume Sep 22, 2024, 2:49 PM

#

In this function, you could just move both of the return string and just put them outside of the if else statement https://github.com/GrawityFals/Grawify/blob/main/Grawify 1.0 Release/Modules/UtilsModule.py#L8-L21

young bay Sep 22, 2024, 2:49 PM

#

im from lua we do that alot there

zinc galeBOT Sep 22, 2024, 2:49 PM

#

Grawify%201.0%20Release/Modules/UtilsModule.py lines 8 to 21

def convert_seconds_into_hours_minutes_and_seconds(seconds: int) -> str:
    if seconds >= 3600:
        h = seconds // 3600
        m = (seconds % 3600) // 60
        s = seconds % 60

        string = f"{h} hours, {m} minutes and {s} seconds"
        return string
    else:
        m = seconds // 60
        s = seconds % 60

        string = f"{m} minutes and {s} seconds"
        return string```

young bay Sep 22, 2024, 2:49 PM

#

oh yep i see that

tall plume Sep 22, 2024, 2:49 PM

#

young bay im from lua we do that alot there

Do you unit test in Lua?

young bay Sep 22, 2024, 2:49 PM

#

what is unit

#

explain

tall plume Sep 22, 2024, 2:50 PM

#

young bay what is unit

https://youtu.be/1Lfv5tUGsn8?si=KaVwV19qeWGVkiJP

YouTube

Socratica

Unit Tests in Python || Python Tutorial || Learn Python Programming

𝙎𝙩𝙖𝙮 𝙞𝙣 𝙩𝙝𝙚 𝙡𝙤𝙤𝙥 𝙄𝙉𝙁𝙄𝙉𝙄𝙏𝙀𝙇𝙔: https://snu.socratica.com/python Unit tests are a way to make sure your code is correct. Python comes with a built-in unit test framework that makes it easy to write a lot of tests for your software. In fact, many engineers will write a series of tests before they begin coding. This approach is called “test driven...

▶ Play video

#

The "music" files you have in your Songs folder... I think you should replace them with public licensed music files.

#

You don't wanna get suspected for copyright

young bay Sep 22, 2024, 2:52 PM

#

i mean

#

so

#

those are place holder

#

you are supposed to put your own

tall plume Sep 22, 2024, 2:52 PM

#

I get it. Just replace them with public licensed ones

young bay Sep 22, 2024, 2:52 PM

#

ah gottcha

#

so like copy right free

tall plume Sep 22, 2024, 2:52 PM

#

exactly

young bay Sep 22, 2024, 2:52 PM

#

i kinda forgot abt that

#

wait

#

i watched the vid you sent me

#

and why is j i????

tall plume Sep 22, 2024, 2:53 PM

#

timestamp?

young bay Sep 22, 2024, 2:53 PM

#

1:17

#

since when is that a thing

tall plume Sep 22, 2024, 2:54 PM

#

This?

young bay Sep 22, 2024, 2:54 PM

#

yep

#

i hate this

tall plume Sep 22, 2024, 2:55 PM

#

its just math

young bay Sep 22, 2024, 2:55 PM

#

its i in math

tall plume Sep 22, 2024, 2:55 PM

#

what i?

young bay Sep 22, 2024, 2:55 PM

#

i = square root of -1

tall plume Sep 22, 2024, 2:55 PM

#

oh that

#

yeah its normal math

young bay Sep 22, 2024, 2:56 PM

#

ok but why j?

tall plume Sep 22, 2024, 2:56 PM

#

but that's not the point of the video

young bay Sep 22, 2024, 2:56 PM

#

ye ik

#

i just hate it

#

im at 3min rn

tall plume Sep 22, 2024, 2:56 PM

#

the point of the video is to test your function continuously works as you develop new features or expand existing functions

young bay Sep 22, 2024, 2:56 PM

#

ye

#

did i not do that?

tall plume Sep 22, 2024, 2:56 PM

#

j is a complex number

young bay Sep 22, 2024, 2:56 PM

#

ik that

#

ik

#

its i in math tho

tall plume Sep 22, 2024, 2:56 PM

#

young bay did i not do that?

Where? there's no tests.py file

young bay Sep 22, 2024, 2:57 PM

#

umm deleted all my test

#

am i supposed to keep em?

tall plume Sep 22, 2024, 2:57 PM

#

yea

young bay Sep 22, 2024, 2:57 PM

#

i didnt know that

#

i never got a bug with my code yet

tall plume Sep 22, 2024, 2:57 PM

#

It helps as time goes by, new Python upgrades, new versions to libraries, etc. You can quickly test which new version breaks your current which functions

young bay Sep 22, 2024, 2:58 PM

#

ah

#

i mean everything works so far

tall plume Sep 22, 2024, 2:58 PM

#

I'll take your word for that

young bay Sep 22, 2024, 2:59 PM

#

ok

#

i mean works for me

tall plume Sep 22, 2024, 2:59 PM

#

Theres no requirements.txt file?

young bay Sep 22, 2024, 2:59 PM

#

whats that?

tall plume Sep 22, 2024, 2:59 PM

#

do you know what you need to pip install all the time?

young bay Sep 22, 2024, 2:59 PM

#

ye

#

i says

#

im missing this so i insatall

tall plume Sep 22, 2024, 3:00 PM

#

requirements.txt file helps so you don't have to guess

young bay Sep 22, 2024, 3:00 PM

#

huh why would i guess

#

me confused

tall plume Sep 22, 2024, 3:00 PM

#

pip freeze > requirements.txt is a quick way to set it up

#

Then push that text file to Github

young bay Sep 22, 2024, 3:01 PM

#

i do that in pycharm or cmd?

tall plume Sep 22, 2024, 3:01 PM

#

Then later, in another computer or whatever, you can pip install -r requirements.txt

young bay Sep 22, 2024, 3:01 PM

#

oh ok

tall plume Sep 22, 2024, 3:01 PM

#

I can see that your script uses these
https://github.com/GrawityFals/Grawify/blob/main/Grawify 1.0 Release/Modules/PlaySongsModule.py#L4-L5

zinc galeBOT Sep 22, 2024, 3:01 PM

#

Grawify%201.0%20Release/Modules/PlaySongsModule.py lines 4 to 5

from mutagen.mp3 import MP3
from audioplayer import AudioPlayer```

young bay Sep 22, 2024, 3:01 PM

#

i got it

#

ye thats it

#

hey it put alot of things i dont use here:

altgraph==0.17.4
audioplayer==0.6
certifi==2024.8.30
Grawify @ file:///C:/Users/Ziga/OneDrive/Desktop/Grawify/dist/Grawify-1.0-py3-none-any.whl#sha256=b4b6c9873f8ec0ec67b28a08a0a14bc2870cc8ace0bf1d1682f2542e1955c640
mutagen==1.47.0
packaging==24.1
pefile==2024.8.26
playsound3==2.2.2
pyinstaller==6.10.0
pyinstaller-hooks-contrib==2024.8
pywin32-ctypes==0.2.3
setuptools==75.1.0

tall plume Sep 22, 2024, 3:02 PM

#

I guess remove the ones you don't need

young bay Sep 22, 2024, 3:02 PM

#

i dont even know alot of those

#

do i keep the py insatller

#

?

tall plume Sep 22, 2024, 3:03 PM

#

alright thats all of the faults I can find in your code. 5/10 its good practice project.

young bay Sep 22, 2024, 3:03 PM

#

thats decent

tall plume Sep 22, 2024, 3:03 PM

#

young bay do i keep the py insatller

Thats up to you

young bay Sep 22, 2024, 3:03 PM

#

i mean is it required?

#

or no idk

tall plume Sep 22, 2024, 3:04 PM

#

depends

young bay Sep 22, 2024, 3:04 PM

#

or that certifi

tall plume Sep 22, 2024, 3:04 PM

#

!pip certifi

zinc galeBOT Sep 22, 2024, 3:04 PM

#

certifi v2024.8.30

Python package for providing Mozilla's CA Bundle.

Released on <t:1724982904:D>.

tall plume Sep 22, 2024, 3:04 PM

#

thats a packaging lib

#

just imagine if there's another dev and they clone your repo. Do you want them to install that to help work on new features with you?

young bay Sep 22, 2024, 3:05 PM

#

no

#

i dont think i want em to steal my code

tall plume Sep 22, 2024, 3:05 PM

#

why would they?

young bay Sep 22, 2024, 3:05 PM

#

didnt you say that?

#

(im stupid pls no judge)

tall plume Sep 22, 2024, 3:06 PM

#

they wouldnt

young bay Sep 22, 2024, 3:06 PM

#

ok

tall plume Sep 22, 2024, 3:06 PM

#

If they wanted a music player, theres hundreds of other options

young bay Sep 22, 2024, 3:06 PM

#

ye ik

#

so keep?

tall plume Sep 22, 2024, 3:08 PM

#

wdym?

young bay Sep 22, 2024, 3:08 PM

#

i think i keep it then?

#

if i undrestand you

tall plume Sep 22, 2024, 3:09 PM

#

again, thats up to you. Do you believe certifi or pyinstaller lib is required to install in order to continue working on your Grawify project or not?

#

If its not, delete it

#

If it is, keep it.

young bay Sep 22, 2024, 3:09 PM

#

ima keep it then

#

this is it then ig:

audioplayer==0.6
certifi==2024.8.30
Grawify @ file:///C:/Users/Ziga/OneDrive/Desktop/Grawify/dist/Grawify-1.0-py3-none-any.whl#sha256=b4b6c9873f8ec0ec67b28a08a0a14bc2870cc8ace0bf1d1682f2542e1955c640
mutagen==1.47.0
pyinstaller==6.10.0
pyinstaller-hooks-contrib==2024.8

tall plume Sep 22, 2024, 3:10 PM

#

young bay this is it then ig: ```py audioplayer==0.6 certifi==2024.8.30 Grawify @ file:///...

Probably don't need this Grawify @ file:///C:/Users/Ziga/OneDrive/Desktop/Grawify/dist/Grawify-1.0-py3-none-any.whl#sha256=b4b6c9873f8ec0ec67b28a08a0a14bc2870cc8ace0bf1d1682f2542e1955c640

young bay Sep 22, 2024, 3:10 PM

#

oh ok

#

i upload to github now?

tall plume Sep 22, 2024, 3:12 PM

#

Did you also fix the global thing?

young bay Sep 22, 2024, 3:12 PM

#

not yet

#

gimme 1 min

#

not entierly sure how to fix it tho

tall plume Sep 22, 2024, 3:12 PM

#

Don't forget the tests.py

young bay Sep 22, 2024, 3:12 PM

#

i deleted em

tall plume Sep 22, 2024, 3:12 PM

#

Make a new one

young bay Sep 22, 2024, 3:12 PM

#

that takes a while

tall plume Sep 22, 2024, 3:13 PM

#

I guess you got work to do

#

Gambatte

young bay Sep 22, 2024, 3:13 PM

#

ye

zinc galeBOT Sep 22, 2024, 3:15 PM

#

Python help channel closed

This help channel has been closed and it's no longer possible to send messages here. If your question wasn't answered, feel free to create a new post in #1035199133436354600. To maximize your chances of getting a response, check out this guide on asking good questions.

#

🔒 pls rate my code

#🔒 pls rate my code