i finally completed my tic tac toe project, but for some reason, after making a winner variable i win after one input. hard to explain.
#🔒 tic tac toe makes me win in one move
neat wigeon
stuck flameBOT
i finally completed my tic tac toe project, but for some reason, after making a ...
@neat wigeon
Python help channel opened
neat wigeon
i just completed this tic tac toe project and it was working just fine. until it wasnt.
!pastebin
stuck flameBOT
neat wigeon
here is the code
what happend is that, when a player won,it was repeating win condition, so i had to make some adjustments and then decided to make a winner variable and assigned it None. then when the player completed the horizontal vertical or diagonal layout. it wins and the program closes
but now, before i ever use the input to assign a position, it says the first user won.
marsh fjord
if check_diagonal(board) or check_horizontal(board) or check_vertical(board) != "-":
what is this line supposed to check
none of the functions ever return anything
neat wigeon
```py
if check_diagonal(board) or check_horizontal(board) or check_vertical(boar...
if the positions taken by the users dont satisfy win condition and are filled without any "-" its a tie
marsh fjord
do you know about function calls and function returns
marsh fjord
check_diagonal(board) will always return None since you never return anything urself
this basically transfers to:
if None == True or None == True or None != "-":
and since None is not equal to "-"
it will pass
neat wigeon
no wait, i miss tolf you something
neat wigeon
```py
if check_diagonal(board) or check_horizontal(board) or check_vertical(boar...
this is the win function
marsh fjord
yes, im aware of that
neat wigeon
damn, my bad
marsh fjord
this basically transfers to:
```py
if None == True or None == True or None != "-...
it doesnt change the fact that this will always be the same
neat wigeon
but whats wrong in that?
marsh fjord
ur never returning anything from the functions ur calling
so u cant compare anything to them
neat wigeon
you mean board[0] == None?
marsh fjord
!e
def function():
pass
print(function())
if function() == "Hello":
print("function says Hello")
:white_check_mark: Your 3.12 eval job has completed with return code 0.
None
like what i see in my code is that, if certain position of the board has "X" or "O" in it and is not "-" then it declares the winner variable as the currentplayer
marsh fjord
again, ur never returning anything from the functions
neat wigeon
mm
marsh fjord
so how can it equal something else than None?
!e
def function():
pass
print(function())
:white_check_mark: Your 3.12 eval job has completed with return code 0.
None
when u dont return anything, the return value will always be None
!e
def function():
return "-"
print(function())
:white_check_mark: Your 3.12 eval job has completed with return code 0.
-
okay, so what should be the solution?
marsh fjord
in the functions you are calling, if someone has won and after you set the winner, write return True
and change the if statement to this
if check_diagonal(board) or check_horizontal(board) or check_vertical(board):
neat wigeon
that still doesnt do anything
i changed all the functions to return True
and changed the if ststement
marsh fjord
so all ur functions look like this?
def check_horizontal(board):
global winner
if (board[0] == board[1] == board[2] and board[0] != "-") or (board[3] == board[4] == board[5] and board[3] != 3) or (board[6] == board[7] == board[8] and board[0] != "-"):
winner = currentplayer
return True
def check_vertical(board):
global winner
if (board[0] == board[3] == board[6] and board[0] != "-") or (board[1] == board[4] == board[7] and board[1] != "-") or (board[2] == board[5] == board[8] and board[0]) != "-":
winner = currentplayer
return True
def check_diagonal(board):
global winner
if (board[0] == board[4] == board[8] and board[0] != "-") and (board[0] or board[6] == board[4] == board[5] and board[2] != "-"):
winner = currentplayer
return True
def check_horizontal(board):
global winner
if (board[0] == board[1] == board[2] and board[0] != "-") or (board[3] == board[4] == board[5] and board[3] != 3) or (board[6] == board[7] == board[8] and board[0] != "-"):
winner = currentplayer
return True
look over this function real quick
do you see anything off?
marsh fjord
yes
all of your check_ functions has errors
look through all of those
(check_horizontal, check_vertical, check_diagonal)
neat wigeon
IT WORKKKSSSSSSSSSSSSSSSSSSSSSSSSSS
OMG
the errors made the wole function shit in just one command hunh
wow
wait
i removed the erros, but something isnt right
marsh fjord
what is it
neat wigeon
can you run this one time and tell me why i am not able to put an icon on the 3rd row?
like when i put "X" anywhere on the third row it just declares win
marsh fjord
if (board[0] == board[4] == board[8] and board[0] != "-") and (board[0] or board[6] == board[4] == board[5] and board[2] != "-"):
theres something wrong here
neat wigeon
ah, i see it
bruh
can you look it one last time please
😭
it still hasnt changed
umm
@marsh fjord you there?
😭
!close
stuck flameBOT
Python help channel closed