🔒 Tic Tac Toe not Tic Tac Toe-ing | Python | Page 1

river spireBOT May 20, 2024, 1:30 AM

#

@devout sierra

Python help channel opened

Remember to:

Ask your Python question, not if you can ask or if there's an expert who can help.
Show a code sample as text (rather than a screenshot) and the error message, if you've got one.
Explain what you expect to happen and what actually happens.

:warning: Do not pip install anything that isn't related to your question, especially if asked to over DMs.

devout sierra May 20, 2024, 1:33 AM

#

https://paste.pythondiscord.com/JGWQ
here's my code

#

no matter what i try, i can't seem to get it to recognise a draw

#

please help :((

manic ivy May 20, 2024, 1:35 AM

#

what is happening, and what do you expect to happen

devout sierra May 20, 2024, 1:37 AM

#

i'm expecting line 109's condition to evaluate to True when all cells are filled and set outcome to 'Draw' and then loop back and reach line 99's elif to print out that it's been a draw and stop asking the user for any more input

#

it's a tic tac toe game where user's input goes against random input from the computer to fill up gameBoard 's nested arrays [[U0,U1,U2], [M0,M1,M2]...]

#

i'm sorry if it's a bit of a mess and painful to read. i'm a beginner

jovial wind May 20, 2024, 1:40 AM

#

why did you use UMD?

manic ivy May 20, 2024, 1:40 AM

#

does it print "Oh no, it's a draw!"?

devout sierra May 20, 2024, 1:41 AM

#

yup

#

supposed to

fallow canyon May 20, 2024, 1:41 AM

#

but it doesn't

devout sierra May 20, 2024, 1:42 AM

#

it dont :((

fallow canyon May 20, 2024, 1:44 AM

#

but why? lemon_thinking

#

probably that means, the outcome isn't draw.

devout sierra May 20, 2024, 1:45 AM

#

i tried popping it into win_listener() but that was making things worse

#

i tested a bunch, whenever i run into a draw it's stuck on an infinite loop

devout sierra May 20, 2024, 1:47 AM

#

jovial wind why did you use UMD?

i thought i'd do
U = up, M = mid, D = down

manic ivy May 20, 2024, 1:48 AM

#

your win_listener seems to update outcome, and it doesn't know about draws

devout sierra May 20, 2024, 1:50 AM

#

def win_listener():
global matchfin
matchfin = False

#diagonals
if gameBoard[0][0] == gameBoard[1][1] == gameBoard[2][2] != ' ':
matchfin = True
return [True, matchfin] if gameBoard[1][1] == 'X' else [False, matchfin]
elif gameBoard[0][2] == gameBoard[1][1] == gameBoard[2][0] != ' ':
matchfin = True
return [True, matchfin] if gameBoard[1][1] == 'X' else [False, matchfin]
for index, i in enumerate(gameBoard):
#row
if i.count(i[0]) == 3 and i[0] != ' ':
matchfin = True
return [True, matchfin] if i[0] == 'X' else [False, matchfin]
#columns
if gameBoard[0][index] == gameBoard[1][index] == gameBoard[2][index] != ' ':
matchfin = True
return [True, matchfin] if gameBoard[0][index] == 'X' else [False, matchfin]
if not any(cell == ' ' for row in gameBoard for cell in row): #since user plays last, check if all cells used up to avoid infinite robot loop
return 'Draw'

river spireBOT May 20, 2024, 1:50 AM

#

Hey @devout sierra!

It looks like you're trying to paste code into this channel.

Discord has support for Markdown, which allows you to post code with full syntax highlighting. Please use these whenever you paste code, as this helps improve the legibility and makes it easier for us to help you.

To do this, use the following method:
```py
print('Hello, world!')
```

This will result in the following:

print('Hello, world!')```
You can **edit your original message** to correct your code block.

devout sierra May 20, 2024, 1:51 AM

#

tried popping the condition into win_listener(), it's still stuck in an infinite loop when we draw

#

i've updated the code in the link

manic ivy May 20, 2024, 1:52 AM

#

could you make your snippet a code block

#

(like the bot suggests)

devout sierra May 20, 2024, 1:52 AM

#

  global matchfin
  matchfin = False

  #diagonals
  if gameBoard[0][0] == gameBoard[1][1] == gameBoard[2][2] != ' ':
    matchfin = True
    return [True, matchfin] if gameBoard[1][1] == 'X' else [False, matchfin]
  elif gameBoard[0][2] == gameBoard[1][1] == gameBoard[2][0] != ' ':
    matchfin = True
    return [True, matchfin] if gameBoard[1][1] == 'X' else [False, matchfin]
  for index, i in enumerate(gameBoard):
    #row
    if i.count(i[0]) == 3 and i[0] != ' ': 
      matchfin = True
      return [True, matchfin] if i[0] == 'X' else [False, matchfin]
    #columns
    if gameBoard[0][index] == gameBoard[1][index] == gameBoard[2][index] != ' ':
        matchfin = True
        return [True, matchfin] if gameBoard[0][index] == 'X' else [False, matchfin]
  if not any(cell == ' ' for row in gameBoard for cell in row): #since user plays last, check if all cells used up to avoid infinite robot loop
    return 'Draw'

#

sorry

#

this is win_listener() after putting the Draw condition in

manic ivy May 20, 2024, 1:54 AM

#

that's surprising to me. i made the same change and it seems to work

devout sierra May 20, 2024, 1:55 AM

#

that's odd. i'm using vs in case that's relevant

manic ivy May 20, 2024, 1:55 AM

#

that wouldn't change things

#

oh, that is not the kind of infinite loop i see

#

did you change anything else after sending your original code snippet

devout sierra May 20, 2024, 1:56 AM

#

should i revert the code in the link to what it was previously?

manic ivy May 20, 2024, 1:56 AM

#

if you want

devout sierra May 20, 2024, 1:56 AM

#

i only removed the condition that was under handle_input() for user at line 111

#

and placed it into win_listener()

#

okay i'll do that now

manic ivy May 20, 2024, 1:57 AM

#

ah, you'd want to keep that presumably

#

the condition that is

devout sierra May 20, 2024, 1:57 AM

#

reverted it

#

the one outside of the win_listener() you mean?

manic ivy May 20, 2024, 1:57 AM

#

yeah

#

only add the condition to win_listener

#

that should be the only change necessary

#

otherwise your bot will loop forever

#

because there are no moves for it to make

devout sierra May 20, 2024, 1:59 AM

#

yea i thought so, which was why i popped it right before so it'd continue and go back up

#

  handle_input(user_input, 'User') #user sends choice
  if not any(cell == ' ' for row in gameBoard for cell in row): #since user plays last, check if all cells used up to avoid infinite robot loop
    outcome = 'Draw'
    continue
  get_n_check_robot_input()
  handle_input(robot_input, 'Robot')  #robot sends choice
``` could it be a scope issue with outcome being assigned 'Draw' and trying to catch the value on the next iteration?

river spireBOT May 20, 2024, 1:59 AM

#

Hey @devout sierra!

It looks like you pasted Python code without syntax highlighting.

Please use syntax highlighting to improve the legibility of your code and make it easier for us to help you.

To do this, use the following method:
```py
print('Hello, world!')
```

This will result in the following:

print('Hello, world!')```
You can **edit your original message** to correct your code block.

devout sierra May 20, 2024, 1:59 AM

#

  handle_input(user_input, 'User') #user sends choice
  if not any(cell == ' ' for row in gameBoard for cell in row): #since user plays last, check if all cells used up to avoid infinite robot loop
    outcome = 'Draw'
    continue
  get_n_check_robot_input()
  handle_input(robot_input, 'Robot')  #robot sends choice

manic ivy May 20, 2024, 1:59 AM

#

did you make the change to win_listener?

devout sierra May 20, 2024, 2:00 AM

#

could it be a scope issue on the outcome being assigned 'Draw' and trying to fetch it later on the next iteration?

manic ivy May 20, 2024, 2:01 AM

#

no, you are overwriting that value

#

outcome = win_listener()

devout sierra May 20, 2024, 2:01 AM

#

oh shoot yeah

#

crap

manic ivy May 20, 2024, 2:01 AM

#

did you make the change to win_listener, as suggested?

devout sierra May 20, 2024, 2:02 AM

#

i'm not sure what to put in win_listener.

manic ivy May 20, 2024, 2:02 AM

#

devout sierra ```def win_listener(): global matchfin matchfin = False #diagonals if g...

you had it already

devout sierra May 20, 2024, 2:03 AM

#

so the condition should be in both the win_listener() func and above the robot's get_input right?

manic ivy May 20, 2024, 2:03 AM

#

yes -- the only change is to add the condition to win_listener

#

the reason is that you're overwriting the value of outcome with the return value of win_listener, but you don't check for draws inside of win_listener

fallow canyon May 20, 2024, 2:04 AM

#

checking for draw doesn't suffice though.

devout sierra May 20, 2024, 2:04 AM

#

oh shoot that did it!

#

it works!

manic ivy May 20, 2024, 2:04 AM

#

in what way

manic ivy May 20, 2024, 2:04 AM

#

devout sierra it works!

awesome!

fallow canyon May 20, 2024, 2:04 AM

#

now the robot can still win when the player did.

devout sierra May 20, 2024, 2:05 AM

#

i could just switch out the condition above the function getting robot's input to something that 'continue's if the list is full yes?

devout sierra May 20, 2024, 2:05 AM

#

fallow canyon now the robot can still win when the player did.

i don't understand. how would this happen?

manic ivy May 20, 2024, 2:06 AM

#

yeah now that you've fixed the bug, you'd probably want to refactor your code so you're not checking the same condition in two places

fallow canyon May 20, 2024, 2:06 AM

#

you're only checking for a winner after the robot did its move.

devout sierra May 20, 2024, 2:06 AM

#

but the robot can't do it's move

#

there's a continue under the condition

#

so if the list is full, i am reiterating

fallow canyon May 20, 2024, 2:06 AM

#

the robot can't do a move when the list is full.

#

but it can do a move when the player has 3 in a row.

devout sierra May 20, 2024, 2:08 AM

#

from what i've tested i haven't come across that issue.. let me try a few more real quick

#

no it seems to work just fine

manic ivy May 20, 2024, 2:08 AM

#

ideally instead of if not any(cell == ' ' for row in gameBoard for cell in row), you would check win_listener()

#

inside your main while loop

devout sierra May 20, 2024, 2:08 AM

#

yea was thinking of doing something like that but my brain is short circuiting

fallow canyon May 20, 2024, 2:09 AM

#

yes, you need to call win_listener after every move, not only after the robot's move.

manic ivy May 20, 2024, 2:09 AM

#

fwiw jenna, i don't see this scenario happening

Captura_de_pantalla_2024-05-19_a_las_10.09.41_p.m..png

#

ah nevermind

#

the bot overwrote the value at the top

devout sierra May 20, 2024, 2:10 AM

#

i think jenna's scenario would happen only if user scores a XXX and on the exact next move so does the bot?

manic ivy May 20, 2024, 2:10 AM

#

here i got it to happen

Captura_de_pantalla_2024-05-19_a_las_10.10.32_p.m..png

devout sierra May 20, 2024, 2:10 AM

#

ah shitsticks

#

i'll rewrite this whole bugger tomorrow. i think my brain is just on power saving mode today

#

@manic ivy i really appreciate you, if possible could you give me a little feedback on how my code looks?

#

readability wise

manic ivy May 20, 2024, 2:12 AM

#

how long have you been learning python

devout sierra May 20, 2024, 2:12 AM

#

about 2 months

fallow canyon May 20, 2024, 2:13 AM

#

tictactoe is one really difficult problem readability wise

manic ivy May 20, 2024, 2:13 AM

#

if you're in vscode, you should install the "ruff" extension

#

it'll help with formatting, and a bunch of lints

#

then also enable format on save

devout sierra May 20, 2024, 2:14 AM

#

fallow canyon tictactoe is one really difficult problem readability wise

yea i wasn't expecting it to be this difficult. i really underestimated it

manic ivy May 20, 2024, 2:14 AM

#

ctrl+, > text editor > formatting > format on save

devout sierra May 20, 2024, 2:15 AM

#

manic ivy if you're in vscode, you should install the "ruff" extension

oh god bless, i'll def add it

manic ivy May 20, 2024, 2:15 AM

#

are you familiar with classes?

devout sierra May 20, 2024, 2:15 AM

#

i do have prettier though, could the formatting of the two clash somehow?

devout sierra May 20, 2024, 2:15 AM

#

manic ivy are you familiar with classes?

i am but wasn't confident enough to use them in this project

manic ivy May 20, 2024, 2:16 AM

#

you'd want to avoid the global keyword basically always

#

instead, you can have your state stored in an instance of a class

manic ivy May 20, 2024, 2:17 AM

#

devout sierra i do have prettier though, could the formatting of the two clash somehow?

potentially. you should not use prettier to format python, though

devout sierra May 20, 2024, 2:17 AM

#

also i confuse python classes with javascript's so that's gonna take a bit of getting used to ;((

devout sierra May 20, 2024, 2:17 AM

#

manic ivy potentially. you should not use prettier to format python, though

oh gotcha

manic ivy May 20, 2024, 2:17 AM

#

your win_listener function is pretty complex. it's actually kinda hard for me to see at a glance what you're trying to do

#

the names of the variables ("matchfin", for index, i) make it kinda hard

devout sierra May 20, 2024, 2:18 AM

#

yea i'm sorry for putting you through that. it even takes me a minute of reading to realise what i was doing

manic ivy May 20, 2024, 2:18 AM

#

it's not really something to apologize for

#

it's just code

#

the return value could be made simpler

#

i'm kinda confused why it returns an array of booleans

#

why not return a string that is either "draw", "user", "robot", or "none"

#

also it abuses ternaries. you don't need ternaries here -- you can just use an if statement

#

matchfin is a global, so no need to return it

devout sierra May 20, 2024, 2:20 AM

#

i'm not sure what i was thinking but i guess it was supposed to be [whether the user won, whether the match had ended], not sure why i wanted 'whether the match had ended' but by the time i noticed it was redundant my brain was a bit fried and i based too many things around it

devout sierra May 20, 2024, 2:20 AM

#

manic ivy why not return a string that is either "draw", "user", "robot", or "none"

i think i'll do exactly this tomorrow

manic ivy May 20, 2024, 2:21 AM

#

more nitpicky, but get_n_check_robot_input shouldn't be able to get into an infinite loop

devout sierra May 20, 2024, 2:21 AM

#

manic ivy `matchfin` is a global, so no need to return it

oh god yea.. yikes

manic ivy May 20, 2024, 2:21 AM

#

instead of a while loop that randomly picks any position, you could just have it random.choice(filtered list of keys where positions[robot_input] == " ")

fallow canyon May 20, 2024, 2:22 AM

#

maybe remove positions or gameBoard. you only need one.

manic ivy May 20, 2024, 2:22 AM

#

that would crash if the array were empty, rather than get into an infinite loop. which is 10x easier to debug

devout sierra May 20, 2024, 2:23 AM

#

gotcha

#

this has been so helpful, i can't thank you two enough @fallow canyon @manic ivy

#

i'll remake this soon, fingers crossed i don't have to induce any more headaches because of this :'))

manic ivy May 20, 2024, 2:24 AM

#

the other big thing would be, you don't need to check the entire board after a user makes a play

#

you only need to check the row and column (and potentially diagonal) in which the move was played

#

ehh nevermind. i was looking at some old code and thought that would actually be easier to implement

fallow canyon May 20, 2024, 2:26 AM

#

but you would need to pass the position then.

manic ivy May 20, 2024, 2:26 AM

#

sure, that's just a part of making the change

#

but actually that optimization is probably more annoying to implement

devout sierra May 20, 2024, 2:27 AM

#

but if im doing this again from scratch i'd imagine it shouldn't be too hard to do

#

also is this chat going to stick around or will it get automatically deleted?

#

actually i'll just screenshot it all just in case lol

fallow canyon May 20, 2024, 2:28 AM

#

i think this chat will exist as long as the server.

#

so you can just copy the link to the chat. but a screenshot won't hurt.
https://discord.com/channels/267624335836053506/1241926097369829519

devout sierra May 20, 2024, 2:29 AM

#

got iti

manic ivy May 20, 2024, 2:29 AM

#

and do definitely install ruff. it resolved a bunch of style nits i had

devout sierra May 20, 2024, 2:29 AM

#

manic ivy and do definitely install ruff. it resolved a bunch of style nits i had

for sure

manic ivy May 20, 2024, 2:29 AM

#

other style nits, instead of (choice[0] == "U" or choice[0] == "M" or choice[0] == "D") you can just do choice[0] in "UMD". int(choice[1]) in list(range(3)) => int(choice[1]) in range(3)

devout sierra May 20, 2024, 2:30 AM

#

manic ivy other style nits, instead of `(choice[0] == "U" or choice[0] == "M" or choice[0]...

ahahahaha omg wait now i feel a little brain dead

fallow canyon May 20, 2024, 2:30 AM

#

currently you could even do choice in positions.

devout sierra May 20, 2024, 2:30 AM

#

no idea why i didn't think of that

fallow canyon May 20, 2024, 2:34 AM

#

that comes with time. finding all the ways to make things easier.

devout sierra May 20, 2024, 2:37 AM

#

fallow canyon that comes with time. finding all the ways to make things easier.

yea man. i'm finally not freaking out before starting a project so hopefully i can get there soon ;')

river spireBOT May 20, 2024, 3:37 AM

#

Python help channel closed

This help channel has been closed and it's no longer possible to send messages here. If your question wasn't answered, feel free to create a new post in #1035199133436354600. To maximize your chances of getting a response, check out this guide on asking good questions.

#🔒 Tic Tac Toe not Tic Tac Toe-ing