🔒 not able to save to database

[proud solstice]

@bot.command()
@commands.has_role('Administrator')
async def addmoney(userid, amount, user):
    try:
        test = False
        cursorobj = db.cursor()
        read = cursorobj.fetchall()
        for i in read:
            if userid in i:
                currency = int(i[2])
                currency += amount
                test = True
        if not test:
            data_insert = """INSERT INTO currency (NAME, ID, CURRENCY) VALUES (?, ?, ?);"""
            data = (user, userid, amount)
            cursorobj.execute(data_insert, data)
            db.commit()
            return f'Success! <@{userid}> has earned {amount} (1)'
        data_insert = """Update currency set CURRENCY = ? where userid = ?"""
        data = (amount, userid)
        cursorobj.execute(data_insert, data)
        db.commit()
        return f'Success! <@{userid}> has earned {amount} (2)'
    except Exception as e:
        print(e)

[paper anvil]

@proud solstice

Python help channel opened

Remember to:

• Ask your Python question, not if you can ask or if there's an expert who can help.
• Show a code sample as text (rather than a screenshot) and the error message, if you've got one.
• Explain what you expect to happen and what actually happens.

:warning: Do not pip install anything that isn't related to your question, especially if asked to over DMs.

Closes after a period of inactivity, or when you send !close.

[gloomy saffron]

oh btw

use an async version of sqlite

aiosqlite and asqlite are good picks

[proud solstice]

does that fix the error?

[formal scaffold]

except Exception as e:
print(e)
Don't ever do that. At least print the traceback and not just the exception. In this case though, I don't see why you don't just let the command crash.

[gloomy saffron]

whats the error?

[proud solstice]

welp lemme try that

[gloomy saffron]

mfs be printing the last line of the error then go "hmm i wonder what the issue is 🤔"

[proud solstice]

its just not saving into the database

[formal scaffold]

I don't really get what you're doing here with test and cursorobj.fetchall

[gloomy saffron]

the cursor doesnt even retrieve anything

[proud solstice]

the test is meant to check if the person already exists

[formal scaffold]

Actually, the more I look at this command the more confused I am.

• does returning a string from a command even do anything? don't you need to explicitly send a message instead?
• where's the Context parameter?

[proud solstice]

wdym by context parameter?

[gloomy saffron]

|| ctx ||

[formal scaffold]

what library is this?

[gloomy saffron]

returning a string doesnt do anything, yes. you're right

[gloomy saffron]

looks like dpy to me 🤷

[proud solstice]

im using this for a discord bot thing, the string is the message output from the bot

[proud solstice]

would that fix it?

[gloomy saffron]

returning a string doesnt give it bot output...

[gloomy saffron]

well a number of things need fixing

[proud solstice]

the bot reads the message sent by the person and checks if its a command, if its the addmoney command, it executes this functions, and returns the message, and sends the success message

[gloomy saffron]

1. add the ctx parameter at the start
2. use ctx.send instead of return
3. use the cursor to actually retrieve the data
4. no idea why you're using a for loop when you can just use the WHERE clause
5. remove the try-except block
6. no idea what test is supposed to do

[proud solstice]

this isnt the full code

[gloomy saffron]

why does it have command decorators then?

[proud solstice]

test is meant to check if the person is in the database, not to sure how to check

[gloomy saffron]

@bot.command()```
this turns your function into a `Command` object

[proud solstice]

ye its in there

[gloomy saffron]

just use the WHERE clause

[proud solstice]

the bot output message works, its just that it doesnt save into the message

[gloomy saffron]

!code

[paper anvil]

Formatting code on Discord

Here's how to format Python code on Discord:

```py
print('Hello world!')
```

These are backticks, not quotes. Check this out if you can't find the backtick key.

For long code samples, you can use our pastebin.

[gloomy saffron]

for context: sql SELECT price FROM groceries WHERE name = 'apple';

[gloomy saffron]

@proud solstice put your code in here

[proud solstice]

!paste

[paper anvil]

Pasting large amounts of code

If your code is too long to fit in a codeblock in Discord, you can paste your code here:
https://paste.pythondiscord.com/

After pasting your code, save it by clicking the Paste! button in the bottom left, or by pressing CTRL + S. After doing that, you will be navigated to the new paste's page. Copy the URL and post it here so others can see it.

[proud solstice]

https://paste.pythondiscord.com/4UBA

full code is a lil too long

wait how do I use the WHERE to check if a person exists?

[gloomy saffron]

you shouldnt be using on_message listeners for this

the whole reason for commands is that you can run them like <prefix>[command]

[proud solstice]

yea, I was using a random tutorial to learn about the discord bot, first time using this and databases, wanted to use this as practice

alr lemme check it out

[formal scaffold]

if you need no data but only to check if there's such a row, you'd do a SELECT 1 FROM ... WHERE ....

[gloomy saffron]

oh thats actually kinda handy ngl

[proud solstice]

what would you pt after the WHERE part though

[formal scaffold]

whatever you're searching for. user_id = ? or whatever

[proud solstice]

ohh

[gloomy saffron]

oh wait use this instead. it looks a lot more beginner friendly: https://www.sqlshack.com/exploring-the-sql-where-statement/

[proud solstice]

wait thn whats the from part used for

oh wait nvm

[gloomy saffron]

select something from table where this condition is met

[proud solstice]

wait how do I check if a erson exists, then check 1 column and set it to a variable if they exist?

[paper anvil]

Python help channel closed

This help channel has been closed and it's no longer possible to send messages here. If your question wasn't answered, feel free to create a new post in #1035199133436354600. To maximize your chances of getting a response, check out this guide on asking good questions.