#🔒 Time value not saving to .txt file?
tawny field
Oh that's neat dude
idle ivy
Hey everyone! I'm having trouble with the time value not being saved.
It is supposed to save in a .txt file, fairly simple, using this:
def save_progress(self): # Method to save player's progress to a file
# Creating a dictionary containing player's progress data
data = {
'progress': self.progress,
'level': self.level,
'xp': self.xp,
'badges': self.badges,
'streak': self.streak,
'currency': self.currency,
'total_cards': self.total_cards,
'total_time': self.total_time
}
with open('progress.txt', 'w') as file: # Opening the progress file in write mode
json.dump(data, file) # Writing data to the file in JSON format
(code annotated by chat-gpt)
However, I find it stopped working after I added Discord RPC to the mix.
Here's the RPC:
def richpresence():
client_id = "1235640528364900452" # Rich Presence client ID
RPC = Presence(client_id)
RPC.connect()
RPC.update(
details = "jpgame.py",
start = int(time.time()),
large_image = "1",
large_text = "JLG"
)
I believe maybe it has to do with the fact that I use the same library to save the time, but I have no idea how to fix it lol. Any idea? I tried debugging but there isn't even an error to start with
idle ivy
Oh that's neat dude
thanks :)
tawny field
You mention the code was annotated by ChatGPT - did you write the code yourself?
idle ivy
yes I did, but I asked ChatGPT to annotate it for me so my friend could read it better
he tried to help me previously but we didn't succeed
I asked it to remove annotations - here it is if that makes things easier to read: https://paste.pythondiscord.com/JMFA
orchid halo
yo
idle ivy
hey
orchid halo
have you heard of pystyle?
inner spoke
#black-formatter
idle ivy
no
inner spoke
<#846434317021741086>
Theres even a vscode extension with witch u only need to select it and press alt+ctrl+f or something like that
idle ivy
the output works normally
except when i close the app and restart it again, the total time has been reset
it wasn't saved or loaded from the .txt file
judging by the state of the .txt, i concluded it wasn't saved (total_time)
idle ivy
Theres even a vscode extension with witch u only need to select it and press alt...
what does that do?
idle ivy
except when i close the app and restart it again, the total time has been reset
this line
orchid halo
details = "jpgame.py",``` is this the file where the timer is located?Makes ur code look prettyer and more readible
idle ivy
```py
details = "jpgame.py",``` is this the file where the timer is located?
no that's just something I wanted to display on the rpc, I don't believe it does anything in the script
that's the file where the progress is saved
idle ivy
Makes ur code look prettyer and more readible
i'll try that
inner spoke
better? https://paste.pythondiscord.com/MTTQ
Not much changed it looks like u follow the look standards very good i only said it bc there was some talk on formatters
idle ivy
Not much changed it looks like u follow the look standards very good i only said...
oh ok, my bad
i guess nobody has an idea of what i could do? i'm kind of running out of ideas lol
inner spoke
Everything seems to be fine only thing i see is where do u update the presence and in the json u see anything hinting it isn't saved?
tawny field
i guess nobody has an idea of what i could do? i'm kind of running out of ideas ...
You do mean to write to a a new progress.txt every time right?
since you are using mode w I mean
w will set the file pointer to the beginning of the file
idle ivy
Everything seems to be fine only thing i see is where do u update the presence a...
not at all, even the cards are saved correctly, this seems to purely be a problem with the time
idle ivy
`w` will set the file pointer to the beginning of the file
if this were the problem, then the cards wouldn't save either, right?
the progress.txt is always the same file
tawny field
honestly I didn't really look at the code, just noticed the open
idle ivy
no new file is created except if it has been deleted
idle ivy
honestly I didn't really look at the code, just noticed the open
thanks for trying anyway :)
tawny field
A lot of people mean to use mode w+ but accidentally use w
idle ivy
yeah lol i myself made the mistake to use the wrong letters for a long time before realizing why my program didn't work properly
inner spoke
not at all, even the cards are saved correctly, this seems to purely be a proble...
Is the time updated in the txt?
idle ivy
it is not
tawny field
datetime isn't serializable to json though
inner spoke
U should apply some prints to check if the self total time is updated
inner spoke
datetime isn't serializable to json though
Thats why i think pickle is op but u can also just make a timestamp and turn it back at load
idle ivy
U should apply some prints to check if the self total time is updated
hm i'll try that thanks
tawny field
I'd just define a hook for json_dumps or just turn the date into a string
inner spoke
I'd just define a hook for json_dumps or just turn the date into a string
It looks like self.time is a timestamp already
1 total time only updates on exit but is saved at save 2 with pickle its unreadable but u could dump the whole game instance
timber frost
this line
when you are looking at this printed line that is labeled "tota ltime spent" you are not actually looking at the total_time variable, you are looking at elapsed_time
elapsed_time = int(time.time() - self.start_time) + self.total_time this line feeds that print
so the fact that the printed label reads "total" but the actual variable elapsed_time is whats messing with you
you also never save elapsed_time you just use it to print and then throw it away
idle ivy
really lol?
timber frost
so total_time is always zero and that elapsed_time grows during one game and then gets throwen away
yeah it appears so
idle ivy
but then why did it work previously?
oh wait maybe it is saved when i put a card in or something?
inner spoke
but then why did it work previously?
U exited with the exit command and in the exit sequence u update total time and save it
idle ivy
honestly, is there a simpler way of tracking a total time? maybe like saving the time every 5s or something? i feel like my way is inefficient as hell
timber frost
i think its okay to just calculate the time only when you are ready to use it.
no need to update itevery five seconds if its not going to be used every five seconds
inner spoke
honestly, is there a simpler way of tracking a total time? maybe like saving the...
Id save the total to the last save the time of the last save and from that we can get at save what the new value should be
timber frost
U exited with the exit command and in the exit sequence u update total time and ...
yes, this exit command "4" is the only time the total_time is actually adjusted:
elif choice == "4": # Handling program exit
# Printing program credits and exiting
print("Program Credits: Misudashi. Help for programming : Aidyn.")
self.total_time += int(
time.time() - self.start_time
) # Calculating total time spent
self.save_progress() # Saving progress before exit
sys.exit() # Exiting the program
in Japanese I typically do a lot of immersion, and so I'm mining sentences for my Anki deck while watching a YT video. In that case, I'm not actually using the program, but still want to track how many hours I've spent on it because it equates to how many hours I've spent learning the language. As soon as I stop immersing I just close the app, and when I start again I open it again with a .bat
that system sounded kinda nice but i never could make it work because i can't save total time for now lol
timber frost
i think you can still do that
if you can run the save command on the program exit then itll work as you described
idle ivy
if you can run the save command on the program exit then itll work as you descri...
isn't this what's already being done?
timber frost
if you x out of the window it will not save but if you exit with command "4" then it should save
i think
idle ivy
is there a way to detect if a terminal is killed using the top right red arrow? i feel like it would be perfect then because having to manually type 4 gets old quick
timber frost
yeah there is
import atexit
def exit_handler():
print 'My application is ending!'
atexit.register(exit_handler)
use the atexit library
idle ivy
oh that's nice
timber frost
and just put the saving process into that exit handler function
saving and updating etc
idle ivy
should it be at the end of the code or does it not matter?
timber frost
basically make the atexit callback fuinction do the same thing as "4"
it shouldnt matter as long as those lines run
when you register the handler itll be ready for you even if more code runs in later lines
i havent used it myself but it seems straightforward so if it doesnt work then we can look into it more
idle ivy
is putting 'self' there dumb?
timber frost
you will still need to register that
idle ivy
what does that mean?
timber frost
you defined the handler function but you didnt do the equivalent of this line
atexit.register(exit_handler)
timber frost
i think that will work as you have it
you might want to move the registering part to the init of that class
if it doesnt work
i think its good though
idle ivy
doesn't seem to work for some reason
timber frost
oh actually i just realized that if you run the "4" command and then you also X out of the window then it will run those saving things twice
hmm
idle ivy
oh actually i just realized that if you run the "4" command and then you also X ...
would that be a bad thing?
timber frost
you should be checking the save file to see if its updated or not that will be a much easier way to bugfix this
forexample maybe the exithandler isfailing but also maybe the save function is failing and we dont know which yet
idle ivy
you might want to move the registering part to the init of that class
then vscode doesn't like it because the exit_handler is unknown
idle ivy
timber frost
hmm
idle ivy
i don't get why though
timber frost
yeah interesting
maybe you can put the registers step outside of the class and do like
game = JapaneseLearningGame()
atexit.register(game.exit_handler)
wait i actually got an error
timber frost
brb i have to switch a load of laundry but ill return
idle ivy
brb i have to switch a load of laundry but ill return
alright thanks :)
timber frost
okay hmmmm
ill look up that error with the atexit library maybe it wont work how we wanted
dang its unclear to me
if you check the json file does it get updated ever?
time or otherwise?
idle ivy
when clicking the cross no, the time doesn't update
the cards always update because when i input them, they're saved automatically
timber frost
oh the atexit library cant handle this on windows
idle ivy
when refreshing the time does update
idle ivy
oh the atexit library cant handle this on windows
oh lol, are there others? i'll check
timber frost
pywin32 can do it
this will work the same way that we expected the atexit library to work, except using the pywin32 libary
def on_exit(signal_type):
print('caught signal:', str(signal_type))
import win32api
win32api.SetConsoleCtrlHandler(on_exit, True)
i think that can catch the X button when you close the window
timber frost
its usually best to have the imports at the top
i just copied that from a stackoverflow google search
as long as you import the library before you reference a function from it, then itll work but its best practice to put the imports at the top of the file
timber frost
looks good to me?
timber frost
the cards always update because when i input them, they're saved automatically
Im unsure what you mean by this, i dont see in your code where the cards are saved.
the only saving i see in your code is when save_progress() is called
timber frost
oh
idle ivy
looks good to me?
doesn't feel right
doesn't work anyway but idk
i just yeeted the code and replaced signal_type for self because it didn't know self and i need it for the time
idle ivy
it felt cheap, just hiding the problem and acting like it doesn't exist, i don't really know how to solve the self thing
timber frost
i was looking at the wrong self when you brought it up
idle ivy
timber frost
if it is inside the class then you will need both self and signal_type
the arent even going to use the signal_type argument but it will still get sent to that function so you have to absorb it
idle ivy
oh rly?
timber frost
yeah its how callback functions work, whatever exit signal is sent if going to be sent to that exit handler, your exit handler is allowed to just throw it away though so you dont have to use it
idle ivy
idle ivy
yeah its how callback functions work, whatever exit signal is sent if going to b...
hm i get it now
timber frost
the first argument of a class method is the reference to the instance itself andwe usually just call that instance self
idle ivy
bc the signal_type was darker i thought it was wrong but yeah it just means we're not using it lol
timber frost
see if that version works
not using it is fine but it is still gonna get sent when the function is called later
timber frost
okay i think we are debugging two separate things at once, one if the time problem and one is the exit handling problem
and we wont know if we fixed the exit handling until we are sure the time problem is fixed
so we cant do both at the same time
idle ivy
you also never save `elapsed_time` you just use it to print and then throw it aw...
also i just got what you meant with that and it actually is really funny, i always thought it worked but never implemented it
well
let me try to save time using "4" exit
timber frost
yeah the "4" exit you mean?
idle ivy
do you know what the issue was?
i have no idea
also i still have this error that pops up
timber frost
when does that error pop up? when you red X out of the console?
idle ivy
firstly the program didn't exit when i typed 4, but the error wasn't there either, and now i just checked the program and the error popped up seemingly out of nowhere
timber frost
oh okay
idle ivy
firstly the program didn't exit when i typed 4, but the error wasn't there eithe...
how is that possible? typing 4 doesn't exit the thing
like
?
am i missing something?
it does print the credits
but doesn't exit
or fails to exit maybe because of a library
timber frost
yeah maybe the exit handler is eating up the exit() call lol
put a message in your exit handler so you can see when it runs
like just a print that shows you that it ran
timber frost
but it doesnt stick open and fails to close?
idle ivy
well it just prints and doesn't do anything
timber frost
okay weird
idle ivy
i didn't see the window doing smth
timber frost
i would assume your exit handler is making that fail to close
you can comment it out and see if it still behaves the same
idle ivy
it still does
i don't get it
i tried to clean up the code
and like potential tests
still doesn't exit
timber frost
i dont understand it either but if youd like to share the code again i can give it a look over
timber frost
very weird
yeah maybe comment out the atexit library import cuz i dont see anything that makes sense
timber frost
hmmm
do you mean the error of it not closing might be because you were spamming enter?
idle ivy
no
idle ivy
also i still have this error that pops up
the error that popped up for no apparent reason at random intervals
timber frost
oh i see
so we dont care about th I/O error cuz that might have been from you, but we do care about the fact that exit() is not closing the window?
timber frost
and that never happened before right? it made sense to me that it could be from all the exit handling stuff but i really dont know
timber frost
okay so the I/O isnt from you its from something else
idle ivy
and that never happened before right? it made sense to me that it could be from ...
no, never noticed it before
timber frost
im looking around at the code for anything that could cause that
idle ivy
ok
so
it did exit without any problem
the thing was the discord rpc for some reason
i commented it and it works now i guess
timber frost
oh i was worried it was some threading thing cuz i dont have much experience there
so it is solved then?
timber frost
yeah thats a bad habbit but it definitely happens
idle ivy
i have exams tmrw so i'll prob go to sleep now and try to fix the threading this week-end
timber frost
okay it sounds like there was at least some progress haha!
idle ivy
thanks a lot for the help, i truly appreciate it
idle ivy
okay it sounds like there was at least some progress haha!
definitely!
timber frost
of course i was glad to have something to look over, fun project
good luck on exams 👍
ebon trailBOT
Python help channel closed