When set_creator() runs for a second time, it just gives me the same output as the first time it ran. I want it to be a new "instance" with a new output. So every time it runs it asks for the users input again.
#🔒 How do I get a new output from my function?
lone elbow
vital plumeBOT
When set_creator() runs for a second time, it just gives me the same output as t...
@lone elbow
Python help channel opened
junior dagger
Don't global the set list.
Return the list you create.
Do you know what shadowing is?
lone elbow
Return the list you create.
Thanks for the help! Return the list in the set_creator() function?
junior dagger
So that the call to the function becomes a reference to that list.
var = 123
var = 456```By doing the 456 line, I am shadowing the var name. It exists and I reassign it.set is a builtin name
It exists as you start up Python.
Avoid shadowing builtins.
lone elbow
Ah, I see I haven't heard that term but I do know about that. I didn't realize set was a python term.
junior dagger
It's a very useful and efficient data structure for the right kinds of tasks.
lone elbow
Return the list you create.
So when you say to return the list, do you mean in the set_creator() function? Like I should return armor_set (formerly: set)?
Thanks so much for the help
junior dagger
Create the list in the function. Return the list out of the function so the call to the function becomes a reference to that list.```py
def func():
my_list = []
...
return my_list
result = func()```
Also, in the context of your initial code, you weren't reassigning the set name. Thus, you weren't using the functionality of the global keyword.
You can reach outside of scope to look at variables, but as soon as you want to reassign a name outside of scope, you would be using the global or nonlocal keywords.
But you usually shouldn't do that, anyway.
You're recursing.
Best not, but if you do, extend your list with its return or something.
Otherwise you throw away the result.
lone elbow
You're recursing.
What should I be doing instead if I want to be able to add multiple results from the same function?
junior dagger
You already have a while loop.
You may want to give what you feed it on the while line an opportunity to change.
lone elbow
You may want to give what you feed it on the while line an opportunity to change...
Yeah that's what I was hoping to do, but even when I put it outside of the function the return value still seems to become set in stone after the first run. So I must be misunderstanding something I think
junior dagger
Show me the code as it stands.
vital plumeBOT
Hey @lone elbow!
lone elbow
armor_set = []
continue_prompt = "y"
qual_natite = {'material': "Natite", 'strength':14, 'cost': 5}
qual_steel = {'material': "Steel", 'strength':11, 'cost': 3}
all_materials = qual_steel, qual_natite
qual_helmet = {'type':"Helmet",'strength':0.25, 'cost': 2}
qual_chest = {'type':"Chest",'strength':0.35, 'cost': 2}
all_types = qual_helmet, qual_chest
myAC = 0
def type_selector():
type_input = input("What type of armor is it?:")
for types in all_types:
if type_input == types['type']:
return(types)
def material_selector():
material_input = input("What material?:")
for material in all_materials:
if material_input == material['material']:
print ("you have chosen: " + str(material['material']))
print("it has a strength of:" + str(material['strength']))
return material
def armor_select(type_values = type_selector(), material_values = material_selector()):
piece_AC = (material_values['strength'] * type_values['strength'])
piece_price = (material_values['cost'] * type_values['cost'])
full_piece = {'AC_bonus':piece_AC, 'price':piece_price, 'material':material_values['material'], 'type':type_values['type']}
return full_piece
while continue_prompt == 'y':
armor_set.append(armor_select())
print(armor_set)
continue_prompt = input("Would you like to add another piece? (y/n)")
I feel as though you may benefit from writing some classes. Have you written your own in Python, yet?
lone elbow
I feel as though you may benefit from writing some classes. Have you written you...
I haven't, no
junior dagger
Because you look like it you're trying to piece together a type system out of dictionaries.
Do you plan on ever giving arguments to a call of armour_select?
lone elbow
Do you plan on ever giving arguments to a call of armour_select?
My goal is to have armor select spit out a list of AC_bonus, price, material, and type. Then add that list to a list of all armor pieces that have been created. Then do it again, with new inputs, and add that to the list.
junior dagger
Do you ever plan on calling armor_select with different arguments?
armor_set.append(armor_select(...))```Oh, I suppose not. I could just put those within the function instead of in the brackets right?
junior dagger
Yes.
lone elbow
Yes.
ah, that worked. Honestly, I'm not sure why I had it like that in the first place. I think at some point I was thinking you needed them there in order to output them, but that's clearly not the case. Thanks!
junior dagger
Unless you plan for a function to potentially have different information to eat from call to call, a function doesn't need to have parameters.
lone elbow
and for classes, I agree those would be helpful. I'm in a python class and I think we're learning those in a couple weeks. So I'll just stick with this for now, because it's for a DnD session in a few days. Thanks for the help!
lone elbow
What campaign setting?
My own, called Nalsem. I've been making it for like four years now so it has a lot going on, and I'm always updating the mechanics to be more balanced and fun. It's loosely based on the DnD system but has become very different now.
junior dagger
and for classes, I agree those would be helpful. I'm in a python class and I thi...
Classes/types are how Python thinks. The earlier you learn what they are and why we use them, the more Python opens up to you.
lone elbow
Classes/types are how Python thinks. The earlier you learn what they are and why...
I'm excited to learn about them, I'm really enjoying python so far.
lone elbow
Because I:ve got nowhere to be if you'd like me to go over classes.
Unfortunately I have courses early tomorrow so I was just about to head to sleep now that this is solved. I appreciate the offer though, and if you want to give me a primer here that would be a great help but don't feel obligated. Thanks again!
vital plumeBOT
Python help channel closed