🔒 Code review!

[lucid garnet]

https://github.com/iamagithublearner/OptimusEncode
please let me know how to improve!
preferably using github PR system , since i want to learn github , this is my first major github project 🙂

[magic nexus]

@lucid garnet

Python help channel opened

Remember to:

• Ask your Python question, not if you can ask or if there's an expert who can help.
• Show a code sample as text (rather than a screenshot) and the error message, if you've got one.
• Explain what you expect to happen and what actually happens.

:warning: Do not pip install anything that isn't related to your question, especially if asked to over DMs.

Closes after a period of inactivity, or when you send !close.

[primal sparrow]

1. You shouldn't put a executable on your repo

Also how am I suppose to review your code using PR when you don't have one

[frank quail]

why are you catching appends and basics operations with a try block on line 82, and also keep the type hinting consistant.
At the moment the type hinting is used randomly and theres also no expected return values

[primal sparrow]

perferably use time.perf_counter instead of time.time for more accurate time if it only take small amount of time (line 118 and 120)

!d time.perf_counter

[magic nexus]

time.perf\_counter

time.perf_counter() → float```
Return the value (in fractional seconds) of a performance counter, i.e. a clock with the highest available resolution to measure a short duration. It does include time elapsed during sleep and is system-wide. The reference point of the returned value is undefined, so that only the difference between the results of two calls is valid.

Use [`perf_counter_ns()`](https://docs.python.org/3/library/time.html#time.perf_counter_ns) to avoid the precision loss caused by the [`float`](https://docs.python.org/3/library/functions.html#float) type.

New in version 3.3.

Changed in version 3.10: On Windows, the function is now system-wide.

[primal sparrow]

README.md should be included to explain how to use the repo and download dependency (HandBrakeCLI) instead of provide them

@lucid garnet

[hollow loom]

If you want symantic versioning, use the "Releases" feature of GitHub. Commit messages should be descriptive of what the changes are doing

[primal sparrow]

ye, but well then he should probably also write a pyproject.toml

[hollow loom]

Also since you mentioned Pull Requests, what you can do is add branch protection rules to master such that the only way to make changes to master is through a pull request

[primal sparrow]

and what you should do is code in that branch instead of master

[lucid garnet]

Thank you so much everyone for input, I'll try to fix all the above !
Its midnight now so hopefully tomorrow
I hope this thread doesn't get closed automatically

[manic light]

Actually looking in older threads it seems like the bot closes the thread automatically after like an hour of inactivity.

[primal sparrow]

Yes, 1 hours

[hasty arch]

The thread gets closed but not deleted. So you can reference it later.

[magic nexus]

Python help channel closed

This help channel has been closed and it's no longer possible to send messages here. If your question wasn't answered, feel free to create a new post in #1035199133436354600. To maximize your chances of getting a response, check out this guide on asking good questions.