and undocumented
#black-formatter
bright glacier
Alright, maybe I'll look into it then.
!remind 20H look into the viability of switching to poetry
late dewBOT
short forge
After a cursory google search i dont think poetry allows for custom build scripts
little parrot
its undocumented
plain atlas
1.2.0a2 is buggy enough I wouldn't recommend it for black
plain atlas
@bright glacier nvm I now have a rly buggy thing with isort
And IMHO isort is in the wrong here
from modmail.utils.threads.embeds import (
format_close_embed_to_guild, format_close_embed_to_user, format_edited_message_embed_to_guild,
format_edited_message_embed_to_user, format_generic_embed_to_guild, format_generic_embed_to_user,
format_inital_embed_to_guild, format_inital_embed_to_user, format_message_embed_to_guild,
format_message_embed_to_user,
)
vs
from modmail.utils.threads.embeds import (
format_close_embed_to_guild,
format_close_embed_to_user,
format_edited_message_embed_to_guild,
format_edited_message_embed_to_user,
format_generic_embed_to_guild,
format_generic_embed_to_user,
format_inital_embed_to_guild,
format_inital_embed_to_user,
format_message_embed_to_guild,
format_message_embed_to_user,
)
obviously one of those is superior
the first one /s
ah well, I guess I just need to turn them in to a class
little parrot
[tool.poetry.build]
script = "build.py"
generate-setup-file = false
```and you just add this to the pyproject.toml and build.py is just a normal python file where you can do whatever ie <https://gist.github.com/f5b1077b1ab30bcdf9ba70d95555a95f>huh
bright glacier
finally, that took way too long ๐ฎโ๐จ
bright glacier
Those ones are on the pull_request event.
bright glacier
Not ideal since bugs caused from the merging of the base and branch won't be caught via CI, but that seems rare.
plain atlas
I mean
I just have it required on my project to have branches up to date with the main branch before merging
bright glacier
Given how much CI we already have, limiting it is important so it doesn't take forever.
bright glacier
Oh yea, we'll probably have to add another flag as an escape mechanism, TBH not too pleased with that since we already have too many but blocking root by default is still important.
plain atlas
yeah
why / is right next to . on a keyboard and someone decided to pick the other, idk
flake8 will run on root too lol
ofc flake8 won't change all files
hm
just for fun I ran black on my venv, with the check flag obviously
I'm curious if there's any files that black won't want to reformat in my venv
1823 files would be reformatted, 707 files would be left unchanged.
well that's actually a substantial part of my venv
about 1/3 of my venv is blackified
west snow
hi is there support for Python 3.10.0rc1 yet?
bright glacier
running on 3.10rc1: yes, formatting 3.10+ syntax: no (and involves rewriting substantial amounts of the core logic sadly)
plain atlas
meanwhile: sets line length to 1 and runs black
flat krakenBOT
late dewBOT
!remind 20H look into the viability of switching to poetry
It has arrived!
plain atlas
Lmfao
A piece of useless statistics: this pull request was implemented in full during intercontinental flights. There's something very tranquil about sitting in one place for 10+ hours with no distractions.
bright glacier
That honestly sounds pretty damn nice ^^
bright glacier
Also, no I am not handling this today, don't feel like it.
!remind 3D maybe look into the viability of switching to poetry
plain atlas
That honestly sounds pretty damn nice ^^
that was ambv on from __future__ import annotations pull request for cpython ๐
bright glacier
wut
plain atlas
lol
bright glacier
!remind new 3D "maybe look into the viability of switching to poetry"
plain atlas
3d iirc
plain atlas
i actually don't know then
late dewBOT
plain atlas
nice
plain atlas
That honestly sounds pretty damn nice ^^
bright glacier
Wow, 2017 -- that feels like such a long time ago!
plain atlas
and 3.10 is releasing soon ๐
bright glacier
PEP 563 was deferred tho
bright glacier
No? Didn't the SC push the default activation of PEP 563 to 3.11?
plain atlas
No? Didn't the SC push the default activation of PEP 563 to 3.11?
wow, we used to have a py4 planned
Originally, PEP 563 was scheduled to take effect in Python 4, and this
changed recently (after the discussion in the Language Summit of 2020).
It's possible that third-party libraries and users didnโt plan to react in
the current time frame as they were not aware of this change in timing.
bright glacier
haha, that's not happening anytime soon given how much of the churn budget 2 ->3 ate
plain atlas
yeah lol
also guido has officially said there's no plans and the change would be more like 1>2
because tbf, there's not much about the current python I would change
...except for the stupid classes that were ported from Java andUseCamelCase
bright glacier
CamalCase is pretty nice IMO
late dewBOT
bright glacier
Ok yeah that's not great
bright glacier
Heya @halcyon latch, I've been thinking about the mentorship thing w/ black. I got more questions on how it could work. The details are still very fuzzy (and I should bring it up with the rest of the core team but that's for later) but I think I have something that could be an outline.
So an event like this's TL;DR would be "a day where newcomers can come to get help getting ready to make their first dives into development in the context of a real-world FOSS project". To make it work I'll need a few things, 1) excellent beginner-friendly docs, 2) the right volunteers -- basically experienced, friendly people with an strong appreciation for the learning process :D, and 3) potential good-starter issues of basically "your first pr" style with varying levels of friendly writeups. And I can just reuse this text channel since it's pre-existing :)
FWIW I don't think the black project is quite ready for something like this, I'd like to improve the development workflows and contributing documentation in general, but that's just a matter of (me) putting in the work (since they've been thought through somewhat already) :p
Open questions include:
- How should the intro docs be written like? What examples can I pull inspiration from?
- How structured should the event be? -- like obviously it's all about the newcomers and helping them make their first waves into development, but I feel like having some structure could be helpful so the ones who aren't quite sure what they want to do still have options. But then again you've said the core of it for you was "you can come and we'll be here ready to ask questions" so maybe I'm just overthinking this :)
- What other things should I know or change? I have never ever planned or ran an event remotely close of this nature and know almost nothing ๐
OH my that is one wall of text, apologies for that!
halcyon latch
SO! I've been thinking about this a bit as well as this is something enticing to me/us as a whole.
I'll totally trust your judgement on if black is ready or not. Something to keep in mind is that as a concept it can come across as fairly daunting. I think there are maybe some other projects we could convince to join in for this or even do a super easy trial run with our own stuff like lancebot/python.
I can happily create more channels for you under this category for this, even if it's just private to you and admins to slowly work out the details on this.
Intro Docs
So I'll probably have to defer to some more experienced doc writers but my thoughts are this:
There are a few different levels of intro docs: (1) Intro to contributing (aka what is git and how do I use it), (2) I'm shaky with git and I've never used it in a team, (3) I kinda know what I'm doing but how is this project structured? How do I contribute to this project specifically?
Those 3 levels can easily flow from one to another, but it might be worth having a few different resources available for those different levels. The first two I think PyDis actually has resources for, just from the code jam. The third is reliant on the project developers to create.
It should list the overall goal of the project, maybe some words about how the review cycle works, best practices for git messages, PRs, etc. How to communicate ideas for implementation, when to check in, that kind of stuff. Let me see if I can find some from the previous mentored contribution thing I did.
Event Structure
So this can depend. I've always found it helpful to have a kick-off event. Just so that there's a concrete start time that people know they can schedule around and be there for. It can you talking about this event, the resources available, and it can also be where you set the tone for the event. After that it can just... exist and be and people can float in and out.
Other things that come to mind would just be outreach and the like. Depending on who you want attending will change how early you want to start talking to other folks about this and getting their help with promoting it.
I also think it would be helpful to have a sort of wrap-up post or notes or something. Maybe include some stats/shoutouts/nice moments that happened. Something to finalize the event so it's not left in limbo. Provide gateways for further contribution and all that.
That's all that comes to mind currently. I can give it some more thought though now that I have the mental bandwidth.
@bright glacier ... sorry about that wall of text
plain atlas
lotsa walls here ๐
bright glacier
sorry, we're doing event hashing today
plain atlas
I can happily create more channels for you under this category for this, even if it's just private to you and admins to slowly work out the details on this.
TBF you might be able to create one channel and then use threads
plain atlas
sorry, we're doing event hashing today
I would personally use the cryptology library for that.
halcyon latch
The issue there with a slowburn event planning channel is the thread autoarchive
plain atlas
7 days, tho
halcyon latch
Yeah, but with a slowburn event planning channel it can easily be two weeks before circling back to a specific topic
plain atlas
find it surprising that you wouldn't send any message in 7 days lol
inb4 gives ichard manage channel permissions for this category
bright glacier
Look, I'm running like 5 different mini-projects for the psf/black project, it is very possible I could go a week without touching a specific one
plain atlas
lol
didn't you previously figure out that it was either 7 or 12 i can't remember
๐
bright glacier
it's enough where I kinda go "whelp sorry but this one is going to spend some time on the backburner" pretty regularly so I don't burn out
plain atlas
i should do that on the features I'm working on rn
this is my git history of what I've been working on
halcyon latch
@bright glacier But I'm super happy to dedicate some time to this. The rest of the year is purposely chill event-wise to give some breathing room and this kind of mentorship/engagement event is my jam
bright glacier
I think there are maybe some other projects we could convince to join in for this or even do a super easy trial run with our own stuff like lancebot/python.
I was thinking of collaborating with other projects but I wasn't sure whether it would be feasible so I left it out for brevity. I guess as a starter, maybe reaching out to the projects that share members of our team (like's Jelle's mypy) would be a good idea. This would mean we should probably move the event to a separate dedicated channel.
So I'll probably have to defer to some more experienced doc writers but my thoughts are this:
Thankfully I'm the documentation lead for the project so this is like the one area I am totally not clueless :)
The first two I think PyDis actually has resources for, just from the code jam.
Wonderful! They'll probably need some tweaking but the core content sounds great!
It should list the overall goal of the project, maybe some words about how the review cycle works, best practices for git messages, PRs, etc. How to communicate ideas for implementation, when to check in, [...]
Love it! Other things that would be good to cover include the test suite and other checks PRs must pass, the various issue types we have and how they differ, an overview of the structure of the codebase, etc.
bright glacier
inb4 gives ichard manage channel permissions for this category
I have manage message permissions for this channel so far :p
halcyon latch
I think providing some options for people to choose, but a limited amount would be beneficial to contribution.
bright glacier
RE. event structure: outreach ... since we're pretty new to this I feel this urge to keep the scale small so yeah. The people I'm trying to target are the ones who want to get their feet wet in development but don't quite know where to get started / how the cards of the trade work for the lack of a better term. So I'm not expecting too much as in sheer PR #count increases ^^
I think I prefer a general more relaxed vibe to the event, so there's no pressure (on all of us!), but including a well-defined start and end to the event sounds good. There is something to be said about good endings where even it's bittersweet, it's beautiful :D
flat krakenBOT
bright glacier
what even ... I don't understand this issue at all, anyway moving back to on topic
plain atlas
same
I'm on windows, time to investigate
mostly because I think its very much a 3.6 bug
or
does black support 3.6?
bright glacier
OK, so to summarize the details we have so far:
- We'll need varying levels of intro docs -- in particular the project-specific kind.
- Structure-wise, a clear kickoff and finale would be ideal to set expectations and the tone / wrap the event in a pretty bowtie.
- Outreach & promotion ... I'm just going to defer to the expertise, experience, and influence of PyDis for the time being.
- We should look into collaborating with other projects so the people ready to contribute have options
Finally ... I think moving to a dedicated space for event planning is probably best since these words will end up buried from day-to-day psf/black development and discussion eventually.
I don't know why I didn't assume this would get buried but it's painfully obvious to me now
plain atlas
what even ... I don't understand this issue at all, anyway moving back to on top...
looking further into it, they're getting their issue from a conda workflow on a fork of microsoft's qlib repository
bright glacier
I also don't know if that's even the official action
the official action's main logic is in a Python script so the output they provided doesn't make any sense.
plain atlas
its not
this is what I'm looking at fwiw https://github.com/microsoft/qlib/compare/main...Wangwuyi123:main
since it shows a nice diff of all of their changes to the main repo, where it works, if it exists
bright glacier
So cool, they basically want us to debug their github actions workflow ... great! /s
bright glacier
And honestly it sounds like a problem with pip and how they are using it
plain atlas
late dewBOT
.github/workflows/conda.yml line 15
os: [windows-latest, ubuntu-16.04, ubuntu-18.04, ubuntu-20.04]```that's my favorite line!
why are you testing on ubuntu-16.04
aaaaaa
although this does make me realise I probably need to start running my tests on windows... hm..
bright glacier
If I knew anything about conda I would be open (even if rather begrudgingly) to helping them out but I don't know anything about conda
plain atlas
cool, you can do it begrudgingly since https://github.com/Wangwuyi123/qlib/blob/3557c112998f291b2eea2a3a82f43bfcd493b80a/.github/workflows/test.yml is the file in question and nowhere does it mention conda! ๐
just why
late dewBOT
.github/workflows/test.yml lines 33 to 34
sudo python -m pip install black
python -m black qlib -l 120 --check --diff```I think this is the problem lol
bright glacier
WHY ARE THEY USING SUDO WITH PIP
plain atlas
also they need to set pip to not use a cache because pip is dumb
bright glacier
honestly I'd bet that using pip with sudo is the source of their problems
plain atlas
they sent that in their (poorly formatted) issue
The directory '/home/runner/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
The directory '/home/runner/.cache/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Oh nice, there's literally a line about sudo in there ^^
halcyon latch
RE. event structure: outreach ... since we're pretty new to this I feel this urg...
That works. We can share it with the orgs/people we already have close ties with and not throw it wildly into the wind~
I'll drop a category in here open to black formatter devs and admins for lax planning.
plain atlas
darn, I want access to it... ๐
plain atlas
Oh nice, there's literally a line about sudo in there ^^
I mean, its incomprehensible..
psf/black#2438 
toxic stormBOT
bright glacier
I sometimes wonder how they make connection that a failure to install black means it's black's problem
especially when the cache is at all
halcyon latch
@bright glacier channel made~ gave you some permissions that looked alright at first glance. Feel free to bug me if it needs to be adjusted
plain atlas
I commented on it
bright glacier
Alright perfect! Thank you! I'll go and figure out an intro (pun not intended :p) post so when the rest of the black / admin team comes by they hopefully aren't too confused
plain atlas
oh, huh. When did I get the contributor badge on the black repo
bright glacier
when you fixed an unnecessary backslash escape in some YAML file
plain atlas
yep, psf/black#2423
toxic stormBOT
plain atlas
how did you remember that ๐
halcyon latch
Alright perfect! Thank you! I'll go and figure out an intro (pun not intended :p...
the admin team is a little too used to me just... doing event stuff and then letting them know later >_>
bright glacier
the admin team is a little too used to me just... doing event stuff and then let...
How little of a short notice are we talking here? haha ^^
plain atlas
inb4 30 minutes sometimes
bright glacier
I mean, some folks were confused that there was a new bot so I assume not too long lol
halcyon latch
"Kat ... why are there 3 new channels in Event Planning"
"Don't worry! It'll make sense! Just uhhhh... hold on"
plain atlas
I mean, some folks were confused that there was a new bot so I assume not too lo...
there's like, 6 bots now
oh, 7.
jeez
halcyon latch
I mean, some folks were confused that there was a new bot so I assume not too lo...
I was not alone in that! Scale was my accomplice
bright glacier
7 if you count the 3.10 bot that doesn't have access here if i'm not mistaken
plain atlas
]e heh
tall condorBOT
You can only use this command in the following channel(s): #878695047112040448, #878694844212592670, #878694948810137621, #878694991784972309, #476196062214750219, #310-release-stream
bright glacier
in4b the bot says something mean to you
plain atlas
is it going to be shutdown soon enough to make that moot?
halcyon latch
It... is? It's a listed channel
plain atlas
no?
halcyon latch
OH HA. It's our test server bot commands
plain atlas
it lists #878694948810137621, #878694991784972309 but not #bot-commands
ah
that's the deleted channel
bright glacier
totally not confusing at a glance
halcyon latch
Scale set it up for me in our test server while I prepped for the event
bright glacier
I was not alone in that! Scale was my accomplice
Worked pretty well since they got the blame when Jake asked questions heh!
plain atlas
lol
so uh, is it going to be added to #bot-commands or is it not going to be kept around long enough to matter?
halcyon latch
I'll ask scale about it when he's avail, but we already have two dedicated bot command channels for it
plain atlas
right, just thinking those seem like they're going to be removed soon since that category doesn't have an emoji
bright glacier
They'll probably stay up for a little bit after the video goes up on the PyDis channel causing the next wave of traffic to to the bot command channels.
bright glacier
Weee thank you @dense jungle for the reviews ^^
I see you are trying to up your closed issue count tho ๐
dense jungle
just my unread notifs count ๐
bright glacier
How was the land of too many boxes?
dense jungle
Mostly cleared up! Except that Ikea is apparently out of bookcases so I still have some boxes of books
bright glacier
Wait what ... heh, what how is IKEA out of bookcases ๐
plain atlas
they bought them all, somehow
bright glacier
I didn't know Jelle was an avid book collector ๐ * 2
It's great finishing up that last box though, marks the end of an adventure that is moving wayyyy too much cargo and realizing you own far too much *stuff*.
bright glacier
You sure do realize just how much stuff you own when packing up things ^^
dense jungle
I think this is why
bright glacier
This site canโt be reached
The web page at https://www.vice.com/en/article/88nvva/lumber-shortage-2021-explained might be temporarily down or it may have moved permanently to a new web address.
whelp no reading for me today.
dense jungle
we did throw a lot of things away too, but the new place is bigger ๐
bright glacier
How much time are we betting before every last storage nook and cranny is filled up?
plain atlas
> **This site canโt be reached**
> The web page at https://www.vice.com/en/artic...
works for me
try refreshing
bright glacier
yeah I'm just going to assume my internet is being dumb again
Actually I just tried on my phone and it works now ๐ค
I love how they call it "the great lumber crisis of 2021", y'know gotta make it super dramatic for 'em kids these days.
plain atlas
yeah, its like saying The Great Country of Britain
dense jungle
Should we reopen this? https://github.com/psf/black/issues/2435 Cleaning trailing whitespace in docstrings is a reasonable request
The OP seems to be having some... issues though
plain atlas
@bright glacier not sure if you're still there since you're typing
plain atlas
Should we reopen this? https://github.com/psf/black/issues/2435 Cleaning trailin...
I commented on it, thanks
it was previously discussed in greater detail in this channel, as well
most notable/memorable against it was @glad pilot
clicks linked issue
well that was obvious
bright glacier
<@!429445826251587616> not sure if you're still there since you're typing
Oh I was writing up a summary to send to the event planning channel ^^
plain atlas
aha
bright glacier
I was typing here mostly because so I could reference things more easily.
plain atlas
yeah makes sense
aside: if you haven't sent it yet, I would send a message link in the event channel to the conversation had here so its easier to find later
bright glacier
oh I definitely added some links because I can't write up everything that was discussed since it's 11:55 over here
bright glacier
I don't think so but I'd probably would if it was up to me
plain atlas
Yeah, I would appreciate docstring stuff removed too
glad pilot
I'll respond to the ping by noting: yep, I don't think that Black ought to change the contents of string literals, because it has no way of knowing whether those changes will affect the program's behavior. Changes to trailing whitespace within string literals are syntactically significant.
plain atlas
I'll respond to the ping by noting: yep, I don't think that Black ought to chang...
Adding on to that, whenever formatting tests, those can be extremely and easily affected by trimmed whitespaces, in a way that has immediate results. When changing the ast of a main project, that could add a bug that lasts for months.
dense jungle
Just noting that we do in fact change the contents of docstrings (but not other strings) right now
I believe it's mostly whitespace at the beginning/end of strings
plain atlas
Is there not a way to turn that off?
dense jungle
no
plain atlas
I find that as a bad thing
docstrings are another piece of ast that is changed
which IMO should not be
dense jungle
https://github.com/psf/black/issues/2150 was where we discussed this in depth.
plain atlas
I read that.
hmmm
does https://github.com/psf/black/issues/2188 change the ast too?
dense jungle
does https://github.com/psf/black/issues/2188 change the ast too?
no, it doesn't
next oar
ai
silent void
I'll respond to the ping by noting: yep, I don't think that Black ought to chang...
how it's significant?
lament crow
it can be if the program does something with the trailing whitespace
sure it's frowned upon but Black can't really assume anything there
Black is said to produce "a valid AST that is effectively equivalent to the original"
it is IMO one of its selling features
but ye, docstrings are currently exempt from that and Black cleans up leading and trailing whitespace of docstrings
glad pilot
!e ```py
class Foo:
""" X """
print("1", "2", "3", sep=Foo.doc)
@glad pilot :white_check_mark: Your eval job has completed with return code 0.
1 X 2 X 3
Run that through black and then run it, and the output changes to 1X2X3 without any spaces.
bright glacier
--- test.py 2021-08-23 16:18:15.618015 +0000
+++ test.py 2021-08-23 16:18:19.539408 +0000
@@ -1,4 +1,5 @@
class Foo:
- """ X """
+ """X"""
+
print("1", "2", "3", sep=Foo.__doc__)
Leading and trailing spaces inside string literals are obviously syntactically significant. Black today recognizes if a string literal is a docstring and if so chooses to modify it anyway, but that can change the behavior of a valid program, since docstrings are introspectable, @silent void
plain atlas
Leading and trailing spaces inside string literals are obviously syntactically s...
tl;dr Its no longer a functionally equivalent ast, which is one of black's selling points
mint barn
no rights formatter
bright glacier
?
mint barn
its black
bright glacier
Yes black is the tool's name, but it has no relation to the race. It's used as a reference to a color and a quote from Henry Ford (which admittedly is apparently a pretty questionable figure doing some research)
molten hare
"You can have any color you want"
bright glacier
Well ford is famous for saying you can only have black
molten hare
Also, would having the repo / contributing links pinned to the channel be helpful for others?
mint barn
and walt disney was anti semetic
glad pilot
!warn 863274087010533396 That joke was wildly inappropriate. In the future, if you know something is too far, you shouldn't say it.
late dewBOT
:incoming_envelope: :ok_hand: applied warning to @mint barn.
plain atlas
!warn 863274087010533396 That joke was wildly inappropriate. In the future, if y...
are you going to delete them?
bright glacier
Also, would having the repo / contributing links pinned to the channel be helpfu...
Ahh yeah we planned to do this but none of us got around to doing that -- I should do that, thanks for the reminder!
glad pilot
*are you going to delete them?*
We generally don't delete messages unless they violate the Discord terms of service. We can, but we prefer not to, since other people have responded and deleting messages makes it harder to follow what was said
molten hare
Github Repo: https://github.com/psf/black
Docs: https://black.readthedocs.io/en/latest/
Contributing Guidelines: https://black.readthedocs.io/en/latest/contributing/
bright glacier
Thank you 
molten hare
No worries! Figured it would save someone a few minutes of searching lol
plain atlas
Yes black is the tool's name, but it has no relation to the race. It's used as a...
yeah....
granted given the current conversation I would repost it in an hour or so and pin it then lol
glad pilot
aight - if we want to pin that message, I can do some deleting to clean things up around the pinned message. @bright glacier want that?
plain atlas
I mean, the stuff above it is about how the ast is changed ๐
bright glacier
I don't really care either way shrug
glad pilot
I'll leave it alone for now, then - feel free to reach out if you want something deleted.
bright glacier
Good to know, thanks!
heavy heron
Now I'm curious, why is black named black?
molten hare
Henry Ford quote regarding car paint colors
bright glacier
"you can have any colour you want as long it's black" -- I'm paraphrasing
plain atlas
I'll leave it alone for now, then - feel free to reach out if you want something...
Ichard has manage message perms anyhow iirc lol
storm rampart
Now I'm curious, why is black named black?
Now I'm curious, why is named named "named"
bright glacier
Wait what, I can delete messages too ??? mind blown
bright glacier
I thought deletion was a higher privilege operation
storm rampart
Now I'm curious, why is named named "named"
And where did the name "name" come from. If it was named, then where did named come from?!
plain atlas
I thought deletion was a higher privilege operation
right click this message ๐
heavy heron
Ah yeah, I remember now
bright glacier
On GitHub, a lot of delete operations require more privileges compared to other things of a similar nature.
plain atlas
yeah
heavy heron
But discord
plain atlas
discord perms bad
embrace the slack
side note: discord devs use slack when discord breaks
storm rampart
Does Slack have a Bot API ๐ค
molten hare
Nah, Outlook email chains ๐ฏ
storm rampart
Nah, Outlook email chains ๐ฏ
Raw HTML gmail >>
bright glacier
and what happens if slack and discord both break; let's also move this to #ot0-fear-of-python
dense jungle
huh I can delete messages too. such power
plain atlas
Does Slack have a Bot API ๐ค
i think like github they support user account automation
molten hare
So to start with helping out at black, should I just try to get a development environment setup and then tackle a "good first issue" label?
gusty grail
Wait what, I can delete messages too ??? *mind blown*
yeah, delete message and pin message come with the same permission
bright glacier
So to start with helping out at black, should I just try to get a development en...
Sorry I got distracted in another channel. Yeah basically get an environment setup and find a good first issue, although there isn't many labeled as such. I'll quickly mark a few more as good first issue if I can.
molten hare
Sorry I got distracted in another channel. Yeah basically get an environment set...
It's all good, I should be able to find a few to get my feet wet
bright glacier
I'm very nervous and unsure how we could do this safely
heavy heron
is black supposed to do that? If I read the issue correctly, you'd go from a an erroring state to a non erroring one, meaning black would have changed the actual code, not just the format
bright glacier
Ah yeah that's not great either
I just skimmed the issue and immediately went "that sounds hard to do safely"
flat krakenBOT
bright glacier
:O Zsolt was active on the repository
dense jungle
if you mention blackd it summons him ๐
silver sluice
whaaat is this
bright glacier
The real-time communication home of psf/black, a FOSS project all about building an uncompromising Python code formatter.
Github Repo: https://github.com/psf/black
Docs: https://black.readthedocs.io/en/latest/
Contributing Guidelines: https://black.readthedocs.io/en/latest/contributing/
plain atlas
Hi
plain atlas
The real-time communication home of psf/black, a FOSS project all about building...
Github Repo: <https://github.com/psf/black>
Docs: <https://black.readthedocs.io/en/latest/>
Contributing Guidelines: <https://black.readthedocs.io/en/latest/contributing/>
Suggest: edit those in to that message and pin it ๐
bright glacier
Aren't they already in the topic?
plain atlas
Remember yesterday?
bright glacier
Yeah and what so about it?
plain atlas
ยฏ\_(ใ)_/ยฏ
plain atlas
Ahh yeah we planned to do this but none of us got around to doing that -- I shou...
This
bright glacier
Didn't I do that yesterday?
bright glacier
Fine.
bright glacier
The real-time communication home of psf/black, a FOSS project all about building...
molten hare
Nice!
plain atlas
Yay
pure sable
are you all black devs? :o
flat krakenBOT
molten hare
I'm still trying to wrap my head around how black works, so I can hopefully contribute some. Any recommendations?
flat krakenBOT
plain atlas
I'm still trying to wrap my head around how black works, so I can hopefully cont...
Tldr black is about to be rewritten somewhat due to the parser not supporting 3.10
IIRC
Which is going to need a huge internal rewrite
molten hare
Oh damn. Where should I try to learn more about the "behind the scenes" for the project?
teal goblet
What about 3.10 doesn't work?
little parrot
match cases
plain atlas
psf/black#2318
toxic stormBOT
dense jungle
match and parenthesized with are the only issues I believe. There is no new typing syntax in 3.10
plain atlas
There is.
dense jungle
though black may format the | in weird ways, it won't crash
plain atlas
Yeah that syntax
dense jungle
That is not new syntax
dense jungle
nope, pre-3.10 Python will parse it fine, it just used to not work at runtime
teal goblet
Technically, str | type(None) works :p
plain atlas
Wild
plain atlas
Technically, `str | type(None)` works :p
Works Pre 10?
dense jungle
The parser will accept it. You can use it in type annotations with from __future__ import annotations too
teal goblet
not at runtime, but pycharm doesn't complain
plain atlas
The parser will accept it. You can use it in type annotations with `from __futur...
Nope-- importing annotations still prohibits the | syntax from working for some odd reason
In my experience at least
teal goblet
will from __future__ import annotations mess up libraries that rely on annotations like pydantic?
I know it has a function update_forward_refs()
dense jungle
@mint barn It won't work in places where the code is executed at runtime, like type aliases. It definitely does work in annotations.
plain atlas
Which are Type aliases?
dense jungle
@teal goblet It does make life harder for pydantic and friends. That's part of why turning on the feature by default was deferred from 3.10
plain atlas
I think that's a different thing?
dense jungle
@mint barn MyType = str | None def f(x: MyType) -> None: ...
plain atlas
<@!171783421377511425> It does make life harder for pydantic and friends. That's...
That's deferred runtime annotations iirc
!pep 563
late dewBOT
plain atlas
But the union operator and such are different
dense jungle
Yes, from __future__ import annotations
plain atlas
Then there's stringify everything
dense jungle
With that feature on, type annotations aren't executed at runtime, so the union or operator won't throw a runtime error
mint barn
<@456226577798135808> `MyType = str | None` `def f(x: MyType) -> None: ...`
man youve been pinging the wrong person
LMFAO
its fine
dense jungle
Oops, sorry ๐
plain atlas
man youve been pinging the wrong person
Lmao I only noticed the second time
uncut patio
@plain atlasyou can also just do ```py
a = 54
b = 6
c: a | b
But only in 3.10?
dense jungle
No, in any version that supports from __future__ import annotations (so 3.7+)
bright glacier
!eval
import sys
print(sys.version_info)
a = 54
b = 6
c: a | b
print(__annotations__)
@bright glacier :white_check_mark: Your eval job has completed with return code 0.
001 | sys.version_info(major=3, minor=9, micro=6, releaselevel='final', serial=0)
002 | {'c': 54}
Looks like GitHub either changed the styling while I was sleeping or while I was eating breakfast cause wow things look a lot harsher and grayer ._.
plain atlas
You may, have switched to the gray theme, which is the one I use
bright glacier
I'm on default light.
plain atlas
Oh rats.
bright glacier
I'm mildly annoyed that I can't find the OS option to have it automatically switch between light and dark mode so all of my websites can auto pick that up.
I'd prefer light mode most of the time but dark mode is well nice at night :)
plain atlas
It's in settings somewhere
bright glacier
I'm on Ubuntu, it's probably a command line options isn't it :/
after some quick searching I think I might have a way to make it automatic, but why does it involve extensions and maybe an apt install here or there, it's literally ubuntu, one of the Linux distros for less techy people I'd've thought this would be less involved
bright glacier
molten hare
can I get a description of some kind?
#black-formatter message
This was a recently pinned message
bright glacier
Basically psf/black is one of those autoformatters that are quite popular these days.
runic hearth
damn cool
bright glacier
I mean, yeah it's impressive but it does mean the decisions we make affect a lot of people ๐
late dewBOT
!remind 72H maybe look into the viability of switching to poetry
It has arrived!
dense jungle
@bright glacier thanks for https://github.com/psf/black/issues/2407#issuecomment-906060619 this is great ๐ I had to stare at a[b:=0] for a while before I realized that's a walrus expression not a slice
heavy heron
@steel steppe please don't post rickrolls in random channels
neon loom
I mean, yeah it's impressive but it does mean the decisions we make affect a lot...
Just make the right ones. Easy.
dense jungle
The release slipped for a while, @neon loom shall we just cut a release today?
neon loom
I'm down
dense jungle
Before it's too late for 2021.8
bright glacier
Am I missing something or what's so particular about having an release in August ๐
Sorry @dense jungle I forgot to tell you that some of the new crashes need ESP to reproduce
Cooper's post above contains the list of the three files needing ESP to crash
IIRC it was test_base64, test_xml_etree, and test_tokenize
for me, test_tokenize actually never finished formatting even giving it a solid 8 minutes
I can only reproduce the crash if I set the recursion limit a bit lower from my default of 1000
dense jungle
Oh right, should have thought of that
flat krakenBOT
fleet depot
aside from line length, where can I find a list of config options
bright glacier
by passing the --help flag ^^
tidal lark
potent viper
yikes
bright glacier
FYI for getting help I'd suggest #python-discussion or a help channel #โ๏ฝhow-to-get-help ^^
Also, I just tried adding tests for the backport so unparentheized assignment expressions are allowed in slices indices, set literals & comprehensions. It hasn't gone very smoothly to say the least since parametrization is a pain with both pytest' and parameterized' implementation due to our mix of unittest and pytest style test cases.
Wait what, PEP 563 (Postponed Evaluation of Annotations) still stops people from using syntactically invalid expressions, TIL.
dense jungle
Wait what, PEP 563 (Postponed Evaluation of Annotations) still stops people from...
yes, they need to be parsed so that the parser knows where the annotation ends. There has been talk of allowing invalid syntax there via some PEG magic, but that is looking unlikely
bright glacier
Ah yea that makes sense. Should've realized that ^^
sonic tundra
!warn 860652150929883136 Can you not post rickrolls in this channel please. You were warned earlier today.
late dewBOT
:incoming_envelope: :ok_hand: applied warning to @steel steppe.
bright glacier
Hmm I wonder if that's feasible with the current design of EmptyLineTracker (or whatever the class is called)
I'm sure hacks could be added, just curious if they would be necessary or not ^^
Heya, I'd appreciate quick look over for this PR: psf/black#2416. After that I don't have anything I want to add to the release.
toxic stormBOT
dense jungle
Heya, I'd appreciate quick look over for this PR: psf/black#2416. After that I d...
Don't have a lot of time right now, but we can just merge it for now
and maybe follow up later on how to improve the thing with the version in the docs
tribal thistle
Hey @bright glacier, don't know if you've seen it yet, but check out
https://python-poetry.org/docs/master/managing-dependencies/#dependency-groups
If you're considering moving to poetry, this'll address the multiple dep files issue, without compromising on speed. It's not released yet though
flat krakenBOT
tiny rock
Hi! I made this issue 2 months ago: https://github.com/psf/black/issues/2370
This is about blank lines between functions docstring and body.
It didn't get a lot of responses, but I still think this is a cause of inconsistency.
What's your opinion about it ?
flat krakenBOT
dense jungle
seems like a bad day for our dependencies
summary: a new release of regex made black segfault for some users; a new release of setuptools-scm made black uninstallable for some
neon loom
summary: a new release of regex made black segfault for some users; a new releas...
Yeah, I do wish python somehow identified the dependency more clearly. I donโt have a suggestion tho. Itโs hard.
I donโt want to release with the pins personally - Iโm a pinning is the end users testing job IMO โฆ but agree there is benefits both ways
Im also not looking forward to mypyc set fault issues
*seg
molten hare
I'm still reading through the code and docs to wrap my head around how everything works, is most of the heavy lifting done in black/src/black/_init_.py?
I guess the "critical path" is:
main() -> reformat_code() -> format_stdin_to_stdout() -> format_file_contents() -> format_str() -> transform_line() -> run_transformer()
Or maybe I'm going a bit cross-eyed trying to read through and build understanding
dense jungle
I donโt want to release with the pins personally - Iโm a pinning is the end user...
I feel like we should pin setuptools_scm, it's just too bad a user experience if an old release suddenly fails to install
If I understand correctly there's no way for a user to fix this
If it was a runtime dependency they could just pin the version of that dep themselves, but not for install-time deps
Correct me if I'm wrong though
stuck vapor
Seems like it's fine now that the setuptools_scm release has been yanked?
dense jungle
That's true, this could happen again though
tawny bluff
Good Evening, one small question, How can i configure black to not add extra , in last always? I mean this
dense jungle
Good Evening, one small question, How can i configure black to not add extra `,`...
There is no option for that
bright glacier
If it was a runtime dependency they could just pin the version of that dep thems...
Technically they could disable build isolation and pep 518 (or whatever the right pep that handles the build-system field)
I'm personally a bit wary of pinning setuptools-scm
I'd at least prefer it to be pinned in pyproject.toml
tawny bluff
There is no option for that
Ah ok, Any possibility to get something for this in future? ๐
bright glacier
Also, wow last night was a fire wasn't it ๐ฅ
bright glacier
Ah ok, Any possibility to get something for this in future? ๐
Usually we try to minimize the amount of options black (in the same spirit as in gofmt for eg.) so it's unlikely we'll add a flag for this
dense jungle
I'm still reading through the code and docs to wrap my head around how everythin...
That sounds about right! run_transformer() is only part of the formatting pipeline though, and if I recall correctly it's only used when the --experimental-string-processing flag is used
bright glacier
doesn't run_transformer also handle right hand side splitting?
dense jungle
doesn't run_transformer also handle right hand side splitting?
Oh yes, that's right. It's the Transformer classes that are ESP-specific
bright glacier
Oh wow primer got rekted by the borked regex release
bright glacier
Im also not looking forward to mypyc set fault issues
well, yeah, these could be an issue, I do plan on pinning most of the dependencies used during the transcompilation and wheel build so hopefully this should be less of an issue?
bright glacier
Should we temporarily pin the dependencies troubles issues?
dense jungle
The setuptools one should be resolved since they yanked the bad release, right?
dense jungle
https://bitbucket.org/mrabarnett/mrab-regex/issues/421/2021827-results-in-fatal-python-error no update
bright glacier
whelp :/
lament crow
Good Evening, one small question, How can i configure black to not add extra `,`...
is this just a preference or do you have some reason for not wanting that extra , in last?
asking because there is a flag for skipping magic trailing comma handling which would not change this style but it would make it so that this extra , doesn't prevent black from shortening it in the future if it can
bright glacier
Hmm, looks like the latest release of regex has been yanked as like with setuptools-scm?
tawny bluff
is this just a preference or do you have some reason for not wanting that extra ...
I don't like it there to be honest because like in last it's just a bit irritating sometimes when i read my code. , is useless there too if there is no option after it ๐
bright glacier
the trailing comma is not used for the magic trailing comma feature, but also as a way to reduce diff noise FWIW
I don't know how important that is, but that is one of the selling points Black uses so yea
tiny rock
Hi! I made this issue 2 months ago: https://github.com/psf/black/issues/2370
Thi...
Any thoughts?
plain atlas
Hey <@!429445826251587616>, don't know if you've seen it yet, but check out
<htt...
I have a feeling that that won't be released for a while, although that is technically a feature already
plain atlas
https://bitbucket.org/mrabarnett/mrab-regex/issues/421/2021827-results-in-fatal-...
16 hours ago
account deleted
@bright glacier ffs. 2021.8.28 has been released
plain atlas
Hmm, looks like the latest release of regex has been yanked as like with setupto...
.
it feels like regex is not handled that well
bright glacier
Well it's definitely worse than how setuptools-scm handled their fire but it's good enough
I just wished the yanking happened earlier
I mean yeah I understand why you'd like a reproducer but I think preventing further harm via yanking is more important first
plain atlas
weed
bright glacier
Hmm, now since the version of black is untied to the value of - uses: psf/black@whatever should we still promote pinning?
plain atlas
wdym?
bright glacier
So there's this PR I want to resolve: psf/black#1574
toxic stormBOT
bright glacier
And it adds a comment suggesting to change the stable value for a tag
BUT since then the action allows configuration of what version of black is used
so now the action version != black version
my question is that should we still suggest pinning the action version (that just happens to be linked to black's versions because we host the action in the same repo - I know it's not the best idea don't @ me)
plain atlas
I don't have enough knowledge on this, after reading this lol
Black uses CalVer not SemVer, so a full version tag may be best.
bright glacier
My main concern is that if we suggest pinning people may assume that's also the version of black it'll use -- which is not true!
Hm, does anyone remember why setuptools-scm is defined both in pyproject.toml PLUS setup.cfg?
I guess technically it does help the people who 1) aren't using build isolation, 2) aren't using PEP 517 builds, and 3) want to use a setuptools-scm version older than 42.0, but like that seems like a tiny minority.
charred forge
So, @bright glacier
My problem is:
I downloaded the black module and then opened the Powershell in the folder that my Python file was in and then I typed in "black characters.py", and then it gave me an error.
bright glacier
What is that error?
I need to know the error message so I can figure out whether it's an installation issue, an issue with black, or something else.
charred forge
What is that error?
black: The term 'black' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
Ah sounds like an issue with your PATH.
bright glacier
an alternative is use python -m black
Basically whatever the python command you regularly use and installed to (eg. python, python3, python3.9, etc.) + -m black
instead of relying on the python scripts to be added during the pip install, you're asking Python to search the package via the normal lookup process and run the package.
charred forge
you need to add black to your PATH
How do I do so?
plain atlas
well, given that its windows, its a bit complicated, so first try what ichard suggested, and see if what they said above works
bright glacier
yeah also if you mess it up system executables can end up shadowed which well .. isn't great to say the least ๐
plain atlas
I cleaned my path yesterday
had 1800+ characters in it
and apparently there's a 2047 or 4095 character limit on some windows versions
bright glacier
>>> len(os.environ["PATH"])
225
its now 1400 which is a lot happier
bright glacier
"only" 1400 chars :p
charred forge
an alternative is use `python -m black`
It says no module named black.
plain atlas
how did you install black?
or: what command did you run to install black on windows?
@bright glacier The irony of E501
# noqa: E501
tests/modmail/utils/addons/test_sources.py:59:111: E501 line too long (113 > 110 characters)
yeesh, this is happening in my tests
@pytest.mark.parametrize("entry, user, repo, plugin, reflike, githost",
[("onerandomusername/addons planet", "onerandomusername", "addons", "planet", None, "github"),
("github onerandomusername/addons planet @master", "onerandomusername", "addons", "planet", "master", "github"),
("gitlab onerandomusername/repo planet @v1.0.2", "onerandomusername", "repo", "planet", "v1.0.2", "gitlab"),
("github onerandomusername/repo planet @master", "onerandomusername", "repo", "planet", "master", "github"),
("gitlab onerandomusername/repo planet @main", "onerandomusername", "repo", "planet", "main", "gitlab"),
("https://github.com/onerandomusername/repo planet", "onerandomusername", "repo", "planet", None, "github"),
("https://gitlab.com/onerandomusername/repo planet" , "onerandomusername", "repo", "planet", None, "gitlab"),
]
)
black makes that so much longer
@pytest.mark.parametrize(
"entry, user, repo, plugin, reflike, githost",
[
("onerandomusername/addons planet", "onerandomusername", "addons", "planet", None, "github"),
(
"github onerandomusername/addons planet @master",
"onerandomusername",
"addons",
"planet",
"master",
"github",
),
(
"gitlab onerandomusername/repo planet @v1.0.2",
"onerandomusername",
"repo",
"planet",
"v1.0.2",
"gitlab",
),
(
"github onerandomusername/repo planet @master",
"onerandomusername",
"repo",
"planet",
"master",
"github",
),
(
"gitlab onerandomusername/repo planet @main",
"onerandomusername",
"repo",
"planet",
"main",
"gitlab",
),
(
"https://github.com/onerandomusername/repo planet",
"onerandomusername",
"repo",
"planet",
None,
"github",
),
(
"https://gitlab.com/onerandomusername/repo planet",
"onerandomusername",
"repo",
"planet",
None,
"gitlab",
),
],
)
pip install black
plain atlas
hm, pip --version and then send the output of that command here.
bright glacier
I was going to say use where python and where pip but that works too
It's where right, or is it which on windows?
plain atlas
It's where right, or is it which on windows?
as a windows user, I still have no idea. I added where.exe to my profile as where. since powershell has a built in where ๐
charred forge
hm, `pip --version` and then send the output of that command here.
pip 21.2.4 from C:\Users\Gamoup\AppData\Roaming\Python\Python36\site-packages\pip (python 3.6)
Get-Command
plain atlas
and also python --version?
short forge
is PS7 equivalent of where
plain atlas
`Get-Command`
which I believe is aliased to the first word of this message ||which||
short forge
uh, which isnt a thing in ps i dont think
plain atlas
it is
its aliased
lemme double check I didn't put that in my profile
oop
yep I aliased that
charred forge
and also `python --version`?
Python 3.6.8
plain atlas
python -m pip install black && python -m black should get a working black installed then
I tend to not run pip directly since that can sometimes be for a different python
charred forge
`python -m pip install black && python -m black` should get a working black inst...
Do I run the Powershell in a different directory?
plain atlas
no, you can run it wherever
charred forge
But do I have to run it in Powershell or CMD?
charred forge
`python -m pip install black && python -m black` should get a working black inst...
It says no module named black.
bright glacier
Is the installation even working correctly?
charred forge
Is the installation even working correctly?
I might have to run cmd as administrator.
bright glacier
oh did the installation error out?
charred forge
oh did the installation error out?
Idk
bright glacier
but installing packages as administrator sounds unnecessary since you usually do user installations of python on windows
charred forge
When I check black in cmd, it says:
No Path provided. Nothing to do
well, that's good
bright glacier
you need to pass a filepath or directory to black
plain atlas
what's your full dev tool chain
bright glacier
it won't ever run automatically in the CWD because that's too unsafe
plain atlas
you need to pass a filepath or directory to black
yes I know it was a typo but: Lightweight blac: now with less K
charred forge
you need to pass a filepath or directory to black
How?
plain atlas
black . --diff which works on the CWD
bright glacier
I'd recommend the black . --diff --color option first
just so you can see what it'll do first before actually touching your files
plain atlas
ehhh, color may not work on CMD
bright glacier
well we use colorama for that reason but I guess it can still go wrong even with that?
charred forge
I'd recommend the `black . --diff --color` option first
It says:
No Python files are present to be formatted. Nothing to do โก
Oh does the current directory have any python files?
charred forge
Oh does the current directory have any python files?
No, not really
bright glacier
Well black operates on python files (so it can reformat 'em) so yea..
charred forge
Well black operates on python files (so it can reformat 'em) so yea..
I switched directories and used Powershell lmao
charred forge
I switched directories and used Powershell lmao
To fix it
plain atlas
lol
I use
- powershell with a custom profile and starship
- pyenv for windows
- pipx
- black
in that specific order
plain atlas
nice
plain atlas
I use
- powershell with a custom profile and starship
- pyenv for windows
- pip...
yes, I know this is probably somewhat overkill
but highly recommend pipx for certain dev tools
bright glacier
pipx is amazing
I used to use this setup where my Python installation wasn't on PATH nor in a standard location and then I'd would manually symlink the scripts when adding a new global python tool but pipx does it way better ^^
plain atlas
that sounds... cursed
bright glacier
TL;DR the python command is symlinked to /opt/python3.8.5/bin/python3 which isn't on PATH
plain atlas
ah
bright glacier
via update-alternatives of course
plain atlas
you built python from source..?
bright glacier
yes sir-e
bright glacier
drwxr-xr-x - root root 21 Dec 2020 python3.6.0
drwxr-xr-x - root root 26 Oct 2020 python3.6.12
drwxr-xr-x - root root 16 Sep 2020 python3.7.8
drwxr-xr-x - ichard26 ichard26 9 Sep 2020 python3.8.5
drwxr-xr-x - root root 26 Sep 2020 python3.9.0b1
drwxr-xr-x - root root 24 Dec 2020 python3.9.1
drwxr-xr-x - ichard26 ichard26 9 May 12:06 python3.9.5
drwxr-xr-x - ichard26 ichard26 9 May 12:16 python3.9.5-support
these are my python installations
yeah I know the permission setup is dumb but oh well
plain atlas
>>> pyenv versions
system
3.10.0rc1
3.7.11
* 3.8.11 (set by /home/aru/discord-modmail/modmail/.python-version)
* 3.9.6 (set by /home/aru/discord-modmail/modmail/.python-version)
those are mine
pyenv >>> building from source
plain atlas
```text
drwxr-xr-x - root root 21 Dec 2020 python3.6.0
drwxr-xr-x -...
do you never delete old versions?!
bright glacier
Yeah, sometimes I need to test out stuff on 3.6.0
plain atlas
and not 3.6.12??
bright glacier
3.6.X was painful in terms of the typing changes
also why not, they aren't that big anyway
plain atlas
you should use pyenv
bright glacier
Maybe one day
plain atlas
mostly because you could write a quick and dirty script to install all python versions ever ๐
!paste
late dewBOT
bright glacier
how would that work on linux?
does it build from source or use the system package repos?
plain atlas
List of pyenv supported python versions: https://paste.pythondiscord.com/apomokamed.txt
plain atlas
how would that work on linux?
note: it was made for linux originally
plain atlas
does it build from source or use the system package repos?
builds from source
the one for windows downloads installers from the python.org website and installs them
lament crow
and apparently there's a 2047 or 4095 character limit on some windows versions
I think it's 4095 characters on the newer Windows systems
>>> import os
>>> len(os.environ["PATH"])
2518
it is, yeah
bright glacier
!remind 16H figure out more details on that thing y'all been discussing
late dewBOT
plain atlas
!pypi that
late dewBOT
bright glacier
that's not what I was reminding myself about but sure
plain atlas
hehe
bright glacier
I don't want to share any details of this tho
bright glacier
let's just leave it at "we may or may not be planning events"
plain atlas
you do realise you could probably set the reminder in that channel then lol
although I presume you did it here intentionally
tired shard
psf/black#2360 Any updates on this? I had a working fix for this, so wanted to know
toxic stormBOT
errant barn
psf/black#2360 Any updates on this? I had a working fix for this, so wanted to k...
I'm afraid not, we still would need to agree what to do with it exactly
flat krakenBOT
flat krakenBOT
silent apex
^ isn't that just because of blank lines between import groups?
bright glacier
@dense jungle what is even going on, the case of you and I writing at the same time (although you type out a response faster than me :p) in reply to the same issue happened again
dense jungle
<@!783088578363523104> what is even going on, the case of you and I writing at t...
I guess we both got reminded of this issue when discord got a message when I merged the other PR? ๐
bright glacier
IDK, I just started going through my GitHub notifications. Moments before I looked over the PRs you merged haha
Huh, while looking at the imports I see this funky line: https://github.com/psf/black/blob/8b0680533420c2ea367860fcbb08df99317a6b44/src/black/__init__.py#L51
late dewBOT
src/black/__init__.py line 51
from black.parsing import InvalidInput # noqa F401```we should make a release for real today
dense jungle
`src/black/__init__.py` line 51
```py
from black.parsing import InvalidInput # ...
Maybe because people were doing except black.InvalidInput: in third-party code?
bright glacier
ah yeah
dense jungle
let me run on our codebase just to make sure there's no regressions
bright glacier
I should've thought of that, I literally contributed code to the black playground that used black.InvalidInput ๐
nocturne hill
bright glacier
Context?
And if you're referencing the name. Yes black is the tool's name, but it has no relation to the race. It's used as a reference to a color and a quote from Henry Ford (which admittedly is apparently a pretty questionable figure doing some research)
bright glacier
Is it worth pinning setuptools-scm?
dense jungle
Is it worth pinning setuptools-scm?
I think we should pin it when it's being used at install time
bright glacier
Alright, I'll get it merged then.
I wouldn't mind driving the release process for this one, looks like our resident BRMFN aka Cooper is a bit busy :p
plain atlas
gurd darn it
dense jungle
sounds good! the run on our codebase completed and found no problems
bright glacier
whew
plain atlas
sounds good! the run on our codebase completed and found no problems
!remind 30M r/agedlikemilk /s
bright glacier
Oh, I don't have permissions to write to the setuptools-scm PR's branch :(
plain atlas
how not
bright glacier
1โฏ git push -u https://github.com/FabianNiehaus/black.git FabianNiehaus/main
Enumerating objects: 9, done.
Counting objects: 100% (9/9), done.
Delta compression using up to 2 threads
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 700 bytes | 700.00 KiB/s, done.
Total 5 (delta 3), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (3/3), completed with 3 local objects.
To https://github.com/FabianNiehaus/black.git
! [remote rejected] FabianNiehaus/main -> FabianNiehaus/main (permission denied)
error: failed to push some refs to 'https://github.com/FabianNiehaus/black.git'
not sure, but oh well I'll just comment what I'd like to see changed even tho I literally have a commit ready locally :/
plain atlas
heh, fork their repo and make a pull request
neon loom
Im homeless but can do a release if we want
plain atlas
I wouldn't mind driving the release process for this one, looks like our residen...
ichard said they wouldn't mind doing it.
plain atlas
And seems like you have some other stuff going on right now.... take care of your self regardless
neon loom
Just fires approaching my home so Iโve left and gone to a friends. Itโs fine. Only a house. Can always get another.
plain atlas
smh
plain atlas
Just fires approaching my home so Iโve left and gone to a friends. Itโs fine. On...
true, better than staying
neon loom
Price of living in the Woods. @bright glacier - Hola if you need anything or want me to cut the PR for release. I have some time until 16:00 pacific today.
bright glacier
wait a sec, I can just open a new PR and then credit the original author so I don't have to wait for them ugh why did that take so long to cross my mind
plain atlas
wait a sec, I can just open a new PR and then credit the original author so I do...
even create a new PR with the original author's commits
dense jungle
Im homeless but can do a release if we want
Oh no! The Caldor Fire? Down here it's just smoke, hope your house survives
neon loom
Ya ya, that's the winner. I'm in Oakland. So sorry to have the smoke follow me.
I'm not "technically" homeless yet ...
It's still there
dense jungle
so close! I just moved to Orinda
neon loom
O nice. I'm going to Walnut Creek tonight to see mates.
Funnily enough Tahoe looks a lot clearer today but still AQI of ~200
https://wildwoodcommons.net - My driveway
bright glacier
Uh that's horrible, never lived on the west side so I've been disconnected from this disaster ๐
neon loom
Seems the new norm in California
bright glacier
Yeah sadly enough, seems to be getting more common for BC over here too :(
plain atlas
lmao
Image updated every minute if Cooper's Internet is Up!
well that's a disappointing way to find out if it goes down
late dewBOT
!remind 16H figure out more details on *that* thing y'all been discussing
It has arrived!
neon loom
well that's a disappointing way to find out if it goes down
My house is totally over engineered + grafana'd everything. Even my fire place has graphs.
plain atlas
what are your specs?
bright glacier
I suppose this is what happens when I'm from Canada, but I'm looking at the temperatures here and the 30C+ I'm seeing is scaring me from going outside by a little bit :p Explains the heat warning tho!
neon loom
what are your specs?
For what?
plain atlas
your server running your website
bright glacier
this guy has multiple websites :)
plain atlas
lmao
This server could not verify that you are authorized to access the document requested. Either you supplied the wrong credentials (e.g., bad password), or your browser doesn't understand how to supply the credentials required.
Lovely error message, about the browser being dumb
neon loom
I suppose this is what happens when I'm from Canada, but I'm looking at the temp...
O, that's just a Linode VPS running that shitty html and I have a systemd timer that (over a VPN) pulls the latest picture from the camera on my hosue
plain atlas
ah
bright glacier
oh lovely it just occurred to me that we planned to add a warning when formatting python 2 code.
we can push that off for 21.9b0 tho
plain atlas
what kind of warning?
plain atlas
a warning that support will be dropped or that python 2 should be dead but its your fault it isn't?
dense jungle
in more polite terms
bright glacier
"WARNING: black will drop support formatting for Python 2 $insert-date / $insert-in-X-releases"
plain atlas
ah
plain atlas
in more polite terms
"WARNING: You are formatting what we wish to be the last remaining python 2 codebase. Please stop that."
neon loom
"Why do you hate yourself enough to be dealing with python 2 still?"
bright glacier
"your business planned for this, right?"
plain atlas
the earliest that pyenv will install is 2.4
oh btw, I've been wondering. Why does a lot of stuff support 2.7 or exactly 3.5.3 ?
what was so bad with 3.0 to 3.5.2??
bright glacier
I wouldn't be surprised if they brought back compatibility shims in the bugfix versions. I don't actually know though, so don't quote me on this.
neon loom
Before 3.5 python2 was faster than 3.X - 3.5 was the first real usable 3.X release
In many ways
plain atlas
aha
bright glacier
crap, I forgot to run prettier before commiting
plain atlas
...
plain atlas
crap, I forgot to run prettier before commiting
everything feels wrong with this statement
bright glacier
huh?
plain atlas
why do you not use black to format black itself??
bright glacier
@stuck vapor whelp good job, you just saved me from a dumb mistake already :D
Check pre-commit rev in example..........................................Failed
- hook id: check-pre-commit-rev-in-example
- exit code: 1
Please set the rev in ``source_version_control.md`` to be the latest one.
Expected 21.8b0, got 21.7b0.
sorry, that was a but too abrasive
bright glacier
We use prettier for formatting everything else other than python code
like Markdown
stuck vapor
<@!633587720270381077> whelp good job, you just saved me from a dumb mistake alr...
๐ this made me smile, and more than I'm proud to admit
plain atlas
lol
bright glacier
all right pre-commit run -a passed, hopefully there isn't another problem
plain atlas
hm, what is action.yml?
bright glacier
other than my ability to type apparently
plain atlas
hm, what is action.yml?
bright glacier
hm, what is action.yml?
the definition and metadata for the official github action for black
plain atlas
ah
bright glacier
Add a CHANGELOG entry if necessary?I thought the release was the NEWS itself, no?Add / update tests if necessary?Who needs tests when you got Quora's codebase?Add new / update outdated documentation?No one reads them anyway, there's no point.
Got a bit sassy in the release PR :p
plain atlas
๐ about quora
flat krakenBOT
bright glacier
๐ about quora
we usually test the development version of black on quora's codebase to verify the code we might release isn't terribly broken
bright glacier
Remember that Jelle works at Quora?
late dewBOT
docs/usage_and_configuration/the_basics.md line 176
black, version 21.5b0```oh yeah I should add a check for that lol
plain atlas
except to be fair I'm a fan of non-existant versions on bug reports or related stuff
bright glacier
Jelle is going to be very annoyed or disappointed with me ๐ฐ .
plain atlas
that way when a person reports a bug, its obvious if they used the version already there or found their version
bright glacier
people don't like it when they can't control-C + control-P so yeah.. about that
plain atlas
why are they control p-ing?
its ctrl-v to paste
why are they printing the black docs
~yes i know it was a typo~~ ๐
bright glacier
Look, I'm driving a release at the same time, give me a break /hj.
plain atlas
~`if you're driving you should focus on the road~~
...i'll be back in a few moments when i don't want to respond with a snappy answer to everything
flat krakenBOT
plain atlas
ok.
neon loom
`docs/usage_and_configuration/the_basics.md` line 176
```md
black, version 21.5b...
I'd prefer we just remove the version here (i.e. just put X's) or automate updating it. Keep this up to date is a waste of human time
plain atlas
or make it a fake version ๐
neon loom
Yeah
bright glacier
Wait what Jelle is going to be very disappointed with me.
โฏ black --version
black, version 21.5b2
I thought my local user install of black was up to date ๐ฅ
bright glacier
I'm doing that right now.
plain atlas
i actually didn't know your black was pipx installed
bright glacier
I thought I had told you I moved to pipx yesterday?
plain atlas
I used to use this setup where my Python installation wasn't on PATH nor in a st...
i didn't put 2 + 2
okay I did some researching
plain atlas
`21.7b1`
21.5.24b as a fake version, since that's the day that black moved to this channel
elder tusk
what was so bad with 3.0 to 3.5.2??
Python 3.5.0 and 3.5.1 have some badness / missing stuff in their versions of the typing module. <3.3 was much harder to switch to from Python 2 (e.g. no unicode literals)
bright glacier
heck even typing's constant changes were an issue in 3.6.X
flat krakenBOT
plain atlas
Python 3.5.0 and 3.5.1 have some badness / missing stuff in their versions of th...
lmao
flat krakenBOT
flat krakenBOT
plain atlas
thonk
this is not a bug and is already supported, to 99%
https://pycqa.github.io/isort/docs/configuration/multi_line_output_modes.html
tldr the compatiable mode is 3.
lament crow
The magic trailing comma handling is not supported in isort
Everything else is
Best to just use the black profile
mint barn
How does black compare to VSCode?
gilded mauve
It doesn't. VSCode is an editor and black is a code formatter
But you can use one in the other
plain atlas
The magic trailing comma handling is not supported in isort
It is.
The black profile is just configuring other isort values
Ohhh wait. Okay, yeah.
lament crow
I'm talking about magic trailing comma specifically
plain atlas
Yea
lament crow
isort will put it in one line if it meets the line length limit while Black respects the existing trailing comma
causes a bit of churn in git diffs
plain atlas
Right
Hmmmm, how does the github action work
Thinking of switching to the action given that if it reports errors as annotations that would be nice
bright glacier
What kind of errors?
lament crow
annotations don't support multi-line
plain atlas
What kind of errors?
Ex black . --diff
lament crow
well, the GH Actions annotations that is
bright glacier
How would annotations be much better than just the coloured diff?
plain atlas
And printing the lines to the format which github expects for annotations
lament crow
I think the API does support the mutiline annotations
plain atlas
They show up when you view the commits, I can find one that shows some flake8 annotations soon
bright glacier
Yea, but it's a linter so it's better suited to annotations
black doesn't operate on this formatting violations -> fix them model
it just formats the file to whatever the logic makes it
lament crow
auto-fixing GH Action or app is probably better than annotations when it comes to code formatters
plain atlas
To get flake8 we pass flake8 a special format string for output, so when it outputs like that we can view it in the pr order
True
That'd be nice, ofc with an option to have it on or not.
bright glacier
Would 30 GitHub annotations all saying "this line / block of lines doesn't follow black's style" really be useful?
One per problematic file, OK, I can see the value in that, but that's simple enough to not really require first-party support.
lament crow
auto-fixing GH Action or app is probably better than annotations when it comes t...
especially this :P
but annotations are going to be more clunky than just having the action comment with a diff or having you manually go to the logs
plain atlas
Tbf that would be more useful big time
lament crow
this is a GH App feature so not something for black maintainers to do though
bright glacier
I'm already hesitant to add a JUnit XML report mode to black and atleast that has some value, even if it's of limited value
lament crow
3rd-party app could easily be made if one wanted it
but there's probably not enough demand if there isn't one already lol
bright glacier
Tbf that would be more useful big time
a "technically" working example of this is pre-commit.ci
plain atlas
True
I can't exactly use that right now tho
It can't use local hooks ๐
(Yes I know how to get around that I just don't want to rn)
Well actually
I'm using it on one project right now, since I didn't feel the need to have a work flow, and because it only needs to lint, everything else about the repo is seperate, kind of a monorepo, if you will
bright glacier
I can't use it on black either unfortunately for that reason but oh well
plain atlas
So
plain atlas
I can't use it on black either unfortunately for that reason but oh well
The way to get around it is to set the skip variable in pre-commit-config.yaml, and skip the local ones-- this is documented on pre-commit.ci
bright glacier
kinda kills the value by still requiring gha to run the local hooks imo :/
plain atlas
true...
plain atlas
ooooo
bright glacier
Weird failure re. fuzz on 3.10-dev
plain atlas
๐
bright glacier
Traceback (most recent call last):
File "/home/runner/work/black/black/fuzz.py", line 10, in <module>
import hypothesmith
File "/home/runner/work/black/black/.tox/fuzz/lib/python3.10/site-packages/hypothesmith/__init__.py", line 3, in <module>
from hypothesmith.cst import from_node
File "/home/runner/work/black/black/.tox/fuzz/lib/python3.10/site-packages/hypothesmith/cst.py", line 18, in <module>
import libcst
File "/home/runner/work/black/black/.tox/fuzz/lib/python3.10/site-packages/libcst/__init__.py", line 7, in <module>
from libcst._exceptions import MetadataException, ParserSyntaxError
File "/home/runner/work/black/black/.tox/fuzz/lib/python3.10/site-packages/libcst/_exceptions.py", line 9, in <module>
from typing_extensions import final
File "/home/runner/work/black/black/.tox/fuzz/lib/python3.10/site-packages/typing_extensions.py", line 2390, in <module>
class _ConcatenateGenericAlias(list):
File "/home/runner/work/black/black/.tox/fuzz/lib/python3.10/site-packages/typing_extensions.py", line 2394, in _ConcatenateGenericAlias
__class__ = _GenericAlias
NameError: name '_GenericAlias' is not defined
hmmm
bright glacier
ah OK, I'm not actually too worried about it since everything else passes anyway including 3.6-3.9 fuzz
little parrot
wait 3.10
bright glacier
huh?
bright glacier
cc @dense jungle know what's up here?
dense jungle
Maybe pin out typing-extensions 3.10.0.1 for now
little parrot
i must have misread
dense jungle
Hopefully we'll be able to release a fixed typing-extensions soon
Or maybe I should yank the release
then again 3.10 is unreleased so maybe it's not worth it to yank
bright glacier
Is the impact widespread on 3.10-dev? In that case, pinning on black seems like a drop in the bucket
dense jungle
I think it breaks everything uses typing-extension in 3.10
bright glacier
ah I see it was recently released
little parrot
whys the class defined for 3.10?
dense jungle
honestly I haven't really looked into what's going on
the fact that typing's CI was still on Travis and it just stopped working completely isn't helping
bright glacier
Yeah I saw that issue, looks like someone made a PR?
dense jungle
it needs some work
well looks like I'm not powerful enough to yank typing-extensions releases anyway
I can yank Black releases though
dense jungle
don't worry I'll yank all of @bright glacier 's releases