#black-formatter

1 messages ยท Page 3 of 1

dense jungle
#

the mac failure means the stable branch wasn't updated; I'll do that manually in a few days unless we get the wheels faster

slow ibex
#

How much faster mypyc-compiled black is compared to interpreted version?
Do you have some benchmarks?

dense jungle
little parrot
elder tusk
#

unfortunately, for whatever reason pre-commit doesn't use wheels and everyone seems to run black via pre-commit ๐Ÿ˜ฆ

dense jungle
flat krakenBOT
flat krakenBOT
#
yilei
[psf/black] Pull request opened: #3415 Fix a crash in preview style with assert \+ parenthesized string\.

Description

The but is in the get_leaves_inside_matching_brackets on the third line below:

assert xxxxxxxxx.xxxxxxxxx.xxxxxxxxx(
    xxxxxxxxx
).xxxxxxxxxxxxxxxxxx(), (
    "xxx {xxxxxxxxx} xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
)

Including the invisible paren, third line is ).xxxxxxxxxxxxxxxxxx()), (, that it has a matched pair then an unmatched closing paren afterwards. This PR ensures the returned leaves are actually matched.

...

flat krakenBOT
#
isac322
[psf/black] Pull request opened: #3416 fix\(type\): type annotation

Description

mypyc reports error src/black/__init__.py:670:29: error: Incompatible types in assignment (expression has type "Dict[Any, PathSpec]", variable has type "Optional[PathSpec]") [assignment] (https://github.com/isac322/docker_image_blackd/actions/runs/3663490540/jobs/6193303572#step:7:1640)

Checklist - did you ...

  • [ ] Add an entry in CHANGES.md if necessary?
  • [ ] Add / update tests if necessary?
  • [ ] Add new / update outdated documentation?
flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
#
JelleZijlstra
[psf/black] Pull request opened: #3418 Draft for Black 2023 stable style

This shouldn't be merged before 2023 (in case we want to do another 22.12 release) and shouldn't be merged until we have consensus in #3407. I'm opening it so I can evaluate the effect of the draft 2023 style without the obviously problematic bits.

Closes #3407

  • Clean up comments.py preview mode
  • Clean up preview in init.py
  • clean up normalize_invisible_parens preview
  • more in linegen.py
  • annotation_parens
  • empty_lines_before_class_or_def_with_leading_comments
  • handle_t...
#
JelleZijlstra
[psf/black] Issue opened: #3419 Preview style incorrectly removes parens from walrus in annotation 
$ black -c 'def this_is_so_dumb() -> (please := no): ...'
def this_is_so_dumb() -> (please := no):
    ...
$ black --preview -c 'def this_is_so_dumb() -> (please := no): ...'
def this_is_so_dumb() -> (please := no): ...
error: cannot format : Cannot parse: 1:32: def this_is_so_dumb() -> please := no:
$ black --version
black, 22.12.0 (compiled: yes)
Python (CPython) 3.9.14

Found this in CI for #3418, cf. #3407.

Seems like a result of #2990, cc @jpy-git.

Broader learn...

#
JelleZijlstra
[psf/black] Issue opened: #3420 Preview mode crash with \`\-\-fast\` and walrus in except clause 
$ black --fast -c '''
try: pass
except (a := 1) as (b := why_does_this_exist): pass
'''
try:
    pass
except (a := 1) as (b := why_does_this_exist):
    pass
$ black --preview --fast -c '''
try: pass
except (a := 1) as (b := why_does_this_exist): pass
'''

try: pass
except (a := 1) as (b := why_does_this_exist): pass
error: cannot format : Cannot parse: 3:9: except a := 1 as (b := why_does_this_exist):
$ black --version
black, 22.12.0 (compiled: yes)
Python (CPython) 3....
#
POEG1726
[psf/black] Issue opened: #3421 Change the '=' in function

Describe the style change
Em,actually i dont know how to configure black in file.
I use python3.7.9 before,but after i updated to python3.8.10,the style i used is gone........
I have adapted to the style used before.

I want to change the "=" style in a function,I want to add space(other place is normal)๏ผŒi think it is better.

Examples in the current Black style
![image](https://user-images.githubusercontent.com/73727028/206867703-d2a76c22-5afb-4930-be46-76e75c6ff4aa.pn...

flat krakenBOT
flat krakenBOT
flat krakenBOT
#
JelleZijlstra
[psf/black] Issue opened: #3424 Instability with line length = 8 and parenthesized string

Code:

print(
    "Long lines with inline comments which are apart of (and not the only member",
    "Arg #2",
    "Arg #3",
)

On black 22.12.0:

% black --diff tests/data/miscellaneous/long_strings_flag_disabled.py -l 8
error: cannot format tests/data/miscellaneous/long_strings_flag_disabled.py: INTERNAL ERROR: Black produced different code on the second pass of the formatter.  Please report a bug on https://github.com/psf/black/issues.  This diff might be helpfu...
#
JelleZijlstra
[psf/black] Issue opened: #3425 Crash with line\-length 18 and backslash in docstring

Code:

def multiline_backslash_2():
    """
    hey there \ """

On Black 22.12.0:

% black --diff tests/data/miscellaneous/docstring_no_string_normalization.py -l 18
error: cannot format tests/data/miscellaneous/docstring_no_string_normalization.py: INTERNAL ERROR: Black produced code that is not equivalent to the source.  Please report a bug on https://github.com/psf/black/issues.  This diff might be helpful: /var/folders/3b/k964cnv10097wzj3h7w07fww0000gp/T/blk_jh8...
bright glacier
#

Whelp, looks like I got a fair bit of reading later today

dense jungle
#

summary: don't set line length to 1

#

I'm finding this by running all test cases with --line-length=1, a generalization of psf/black#3423

toxic stormBOT
dense jungle
#

there's 10 more failures I'm looking at

bright glacier
#

oh gosh that's horrible

flat krakenBOT
#
JelleZijlstra
[psf/black] Issue opened: #3427 Crash with line\-length 6 and long line in docstring 
def x():
    """first line----------------------------------------------------------------------

    second line----------------------------------------------------------------------"""

Crashes with Black 22.12.0:

% black --diff tests/data/preview/docstring_preview.py -l 6
error: cannot format tests/data/preview/docstring_preview.py: INTERNAL ERROR: Black produced different code on the second pass of the formatter.  Please report a bug on https://github.com/psf/bla...
dense jungle
#

oh all these actually only crash in preview mode, missed that because I was running inside the black repo

slow ibex
slow ibex
flat krakenBOT
#
JelleZijlstra
[psf/black] Issue opened: #3428 Crash with comment inside implicitly concatenated string \(and \-\-line\-length 4\) 
inline_comments_func2(
    " this part does not fit into a single line? "
    # x
    "it into parts that fit in line length.",
)

On 22.12.0:

% black --diff tests/data/preview/long_strings.py -l 4 --preview
error: cannot format tests/data/preview/long_strings.py: INTERNAL ERROR: Black produced code that is not equivalent to the source.  Please report a bug on https://github.com/psf/black/issues.  This diff might be helpful: /var/folders/3b/k964cnv10097wzj3h7w07fww0...
slow ibex
# flat kraken

Why would you want to set line length to 6?
I think you can add restriction to that option (for example, line length must be >= 10) to prevent similar crashes in future

slow ibex
#

How black behaves when variable name is longer than line length? Give up and leave it as is?

dense jungle
#

granted, 20 levels of indentation is pretty crazy too

dense jungle
#

ok this is all, most of the failing test cases were duplicates

flat krakenBOT
flat krakenBOT
bright glacier
#

Thanks for landing my mypyc pr!

flat krakenBOT
#
JelleZijlstra
[psf/black] Issue opened: #3429 Additional sanity checks

Currently, Black checks that the AST of its input and output is the same (except for some narrow exceptions). This is a powerful feature that has caught many bugs (e.g. most recently #3428).

Could we add more similar checks?

  • Comment equivalence. We have had bugs in the past where certain comments get removed. Perhaps we could add a simple check that extracts all comments from the input and output (normalized for leading/trailing whitespace) and asserts that the input and output have t...
urban mural
#

yeah but

ivory quest
bright glacier
#

we're aware

#

@dense jungle what do you think about moving the stable branch?

dense jungle
#

yeah we should do it

#

I can in a little bit

bright glacier
#

I can do it if you're busy

#

It might actually be faster to spin up a GitHub Codespaces to so this because my main machine is refusing to connect to WiFi

dense jungle
#

don't worry about it, I'm just eating lunch first

bright glacier
#

Ah alright. Bon appetit!

lament crow
#

Is it still not done automatically?

dense jungle
#

it is

bright glacier
#

it is but since the mypyc jobs are busted, it doesn't run

dense jungle
#

but the macos wheel jobs failed

lament crow
#

ah

bright glacier
#

we're waiting on hatch-mypyc to properly support cross-compilation for macOS

dense jungle
#

stable branch is updated

flat krakenBOT
dense jungle
#

idea: I'd like to release a version of psf/black#3418 as 23.1a1 so people can try the new stable style more easily

toxic stormBOT
bright glacier
#

I like that

#

I also plan on writing a short blog post based on your issue highlighting the changes as a call for feedback

#

definitely best to allow people to try it themselves though

dense jungle
#

I think with that and #3430 merged we can get a solid draft

bright glacier
#

Yeah, will do so as soon as I have time.

bright glacier
late dewBOT
#
Aye aye, cap'n!

Your reminder will arrive on <t:1670874990:F>!

ID: 5468
flat krakenBOT
#
luan-xiaokun
[psf/black] Issue opened: #3431 Formatting is slow using VS Code

<!--
Please make sure that the bug is not already fixed either in newer versions or the
current development version. To confirm this, you have three options:

  1. Update Black's version if a newer release exists: pip install -U black
  2. Use the online formatter at , which will use
    the latest main branch.
  3. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .[d];
    • run `...
flat krakenBOT
#
Starwort
[psf/black] Issue opened: #3432 \[style\] Function default parameters \- ugly lambda explosion

Describe the style change

Lambdas used as default parameters for functions look really ugly when the function parameter is exploded (e.g. via a typehint being too long

Examples in the current Black style

class Foo:
    def bar(
        self,
        baz: typing.Callable[
            # long typevar name (and this comment) causes
            # declaration to be exploded
            [SpecialisationT, SpecialisationT], SpecialisationT
        ] = lambda i, j: ...
plain atlas
#

actually nvm ignore me

flat krakenBOT
flat krakenBOT
#
intgr
[psf/black] Issue opened: #3435 Crash in preview style with multiline quoted return\-position type hint

Describe the bug

When using --preview, this input causes error message "Unable to match a closing bracket to the following opening bracket: )". No issues when running without --preview

Looks similar to #3414, but I can still reproduce this issue in main branch.

To Reproduce

from typing import Generic, TypeVar

T = TypeVar("T")


class VeryLongClassNameWithAwkwardGenericSubtype(Generic[T]):
    pass


def something(
    argument: (
        "VeryLongC...
late dewBOT
flat krakenBOT
bright glacier
#

oh diff-shades on main is broken, that's ... not great

#

will look into it tomorrow

flat krakenBOT
#
lfurrer
[psf/black] Issue opened: #3436 Crash on conditional inside \# fmt: off, depending on comment indentation

Describe the bug

If a condition statement is wrapped in # fmt: off/# fmt: on, Black crashes with a parse error on the subsequent line.
The crash only occurs if the # fmt: off comment is indented the same as the wrapped condition.

To Reproduce

The following minimal code breaks parsing with Black 22.10 and later:

def do_something(x, y):
    if x:
        return x
    # fmt: off
    elif y:
    # fmt: on
        return y

And run it with these arg...

flat krakenBOT
flat krakenBOT
#
yilei
[psf/black] Issue opened: #3438 Black adds an extra blank line to an import line that ends with \`\# fmt: skip\`

<!--
Please make sure that the bug is not already fixed either in newer versions or the
current development version. To confirm this, you have three options:

  1. Update Black's version if a newer release exists: pip install -U black
  2. Use the online formatter at , which will use
    the latest main branch.
  3. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .[d];
    • run `...
flat krakenBOT
flat krakenBOT
bright glacier
#

I apologise in advance if I forget my manners. I only have time for Black when it's late and I'm tired. It's harder for me to maintain the same positive chirpy mood/tone I usually try to bring.

flat krakenBOT
#
ichard26
[psf/black] Pull request review submitted: #3439 Fix a crash when a colon line is marked between \`\# fmt: off\` and \`\# fmt: on\`

I feel like we should write developer docs on how fmt: off/on/skip work. The logic as-is is already complicated as heck and the edge cases are incredibly confusing sometimes...

Also technically this is invalid use of # fmt: off/on but that's just a limitation of Black since there's no way to represent a # fmt: on at the right indent level right after a dedent.

bright glacier
#

I 100% would not support using something as hacky as this

#

It is almost midnight now so I'm done for tonight. I'll pick up where I left off tomorrow.

flat krakenBOT
#
yilei
[psf/black] Pull request opened: #3440 Improve long values in dict literals

Description

This PR changes the preview style:

  • Wraps long values in dict literals in parentheses. Fixes #620. Fixes #808.
  • Correspondingly, parentheses around short values in dict literals are removed.
  • In preview string processing, long lambda string values are now wrapped in parentheses.
  • Wrapping dict values happens to fix #3117 where implicitly concatenated r-string dict values crash in string processing. Fixes #3117

Usually I'd like to keep the PR's scope min...

flat krakenBOT
#
hg0428
[psf/black] Issue opened: #3441 No Match Case Support for Python 3\.10\+

<!--
Please make sure that the bug is not already fixed either in newer versions or the
current development version. To confirm this, you have three options:

  1. Update Black's version if a newer release exists: pip install -U black
  2. Use the online formatter at , which will use
    the latest main branch.
  3. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .[d];
    • run `...
flat krakenBOT
flat krakenBOT
bright glacier
#

I've been feeling incredibly tired today and I wasn't able to bring myself to work on Black. I'm sorry about that, hopefully I feel better tomorrow.

#

Thanks again Jelle for keeping the show running while I'm gone.

flat krakenBOT
jolly kettle
#

black ./ --check --verbose --preview on my terminal says All done! โœจ ๐Ÿฐ โœจ 18 files would be left unchanged.
but in github action it says
Oh no! ๐Ÿ’ฅ ๐Ÿ’” ๐Ÿ’ฅ 6 files would be reformatted, 11 files would be left unchanged. Error: Process completed with exit code 1.

#

nevermind black on my pip was a bit outdated

flat krakenBOT
#
FSpanhel
[psf/black] Issue opened: #3443 \#fmt: skip is ignored

<!--
Please make sure that the bug is not already fixed either in newer versions or the
current development version. To confirm this, you have three options:

  1. Update Black's version if a newer release exists: pip install -U black
  2. Use the online formatter at , which will use
    the latest main branch.
  3. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .[d];
    • run `...
flat krakenBOT
flat krakenBOT
bright glacier
#

are you updating the preview issue with the recent merges?

dense jungle
#

I think recent merges shouldn't go into the 2023 stable style

bright glacier
#

I'm also tempted to review these PRs, but there's no way I have time for that right now ๐Ÿ˜…

dense jungle
#

since users won't have time to try them out in preview style

bright glacier
#

alright, sounds good

flat krakenBOT
#
yilei
[psf/black] Pull request opened: #3444 Fix an infinite recursion error\.

Description

This bug appears to have existed earlier. But it's now triggered on the added test after https://github.com/psf/black/pull/3440 on the complex dict value.

The infinite recursion happens when getting the second_opinion. Example traceback:

Traceback (most recent call last):
  File "/Users/yileiyang/github.com/yilei/black/src/black/__init__.py", line 1077, in format_str
    dst_contents = _format_str_once(src_contents, mode=mode)
                   ^^^^^^...
flat krakenBOT
bright glacier
#

I'll try to start working on Black again tomorrow. This week has been pretty awful, but I can make it work.

flat krakenBOT
#
dahlia
[psf/black] Pull request opened: #3445 Let string splitters respect \`East\_Asian\_Width\` property

Description

This patch changes the preview style so that string splitters respect Unicode East Asian Width property. If you are not familiar to CJK languages it is not clear immediately. Let me elaborate with some examples.

Traditionally, East Asian characters (including punctuations) have taken up space twice than European letters and stops when they are rendered in monospace typeset. Compare the following characters:

abcd...
flat krakenBOT
neon loom
#

@dense jungle or anyone else around - Anything else burning I can try help with for 23.1.0 release?

#

Got some cycles this weekend

#

Sorry I've been awol

#

Snow has been good and eating free time ๐Ÿ˜„

flat krakenBOT
#
mateuszkojro
[psf/black] Issue opened: #3447 \`'ModuleNotFoundError' No module named 'tomli'\` after installing using pip and venv

Describe the bug

After installing black using pip inside venv running it results in 'ModuleNotFoundError' No module named 'tomli' exception beeing raised:

To Reproduce

  1. Create new virtual environment and activate it
python -m venv venv

and

.\venv\Scripts\activate.ps1
  1. pip install black
  2. black --version

output:

Traceback (most recent call last):
  File "C:\Users\PC1080Ti\AppData\Local\Programs\Python\Python38\lib\r...
dense jungle
neon loom
#

(I've seen nothing - Been not paying attention except to email subject lines sorry)

#

Like when I saw complete 3.11 I was like damn I haven't done that I suck ... haha

dense jungle
neon loom
#

Do you come up here to ski? We should do dinner / go ski if you do

#

(I'm in South Lake)

neon loom
dense jungle
#

haven't in a couple of years, I've been going to Utah where a friend of ours has a house

dense jungle
#

though I need to update that branch a little

neon loom
#

Why is "Remove trailing newlines after code block open" (#3035) controversal?

#

Wow, experimental string processing still very flaky ๐Ÿ˜ That was one I'd be keen but seems it need a lot of work and stress testing. I'll see if it blows up on FB code too

#

I also agree, lets backout the super flaky parts maybe and just move it into --preview ...

#

Man diffshades does a lot - quite impressive what it tests โค๏ธ

dense jungle
neon loom
#

Seems sane to me. I dislike the useless empty line that we have all left before ...

dense jungle
neon loom
#

I'm so lazy writing python now. I ram shit all on one line I know black will fix ๐Ÿ˜„

bright glacier
#

oh hi :)

neon loom
#

It's the man, the myth, the legend

#

My lazy ass is around for a change

bright glacier
#

I'm not even writing Python anymore lol, I've been mostly writing JS ๐Ÿ˜…

neon loom
#

๐Ÿ˜ฎ

#

Yuck

#

You doing web stuff or node?

bright glacier
#

front-end only

neon loom
#

I've been writing lots of Rust ๐Ÿ˜ฆ

bright glacier
#

I don't have access to a backend so more websites on GitHub Pages.

neon loom
#

Last javascript I wrote was many jobs ago and jquery in the early 2000s. I'm old ๐Ÿ˜›

bright glacier
#

It's not a terrible language, but it takes getting used to

#

the differences in the core data structures cause me quite a bit of trouble

dense jungle
#

have you tried TypeScript?

#

I feel like it makes JS a lot better

bright glacier
#

a little bit, I'm just not a fan of the friction it adds to the edit-test cycle.

flat krakenBOT
bright glacier
#

although that's probably fixable by adding a proper bundler like vite (that uses esbuild underneath)

neon loom
#

You an async guru now writing JS?

#

flake8-bugbear finished as nothing-changed - sweet

#

I should enable preview on more of my projects ๐Ÿ˜

bright glacier
#

Oh yay, aiohttp finally supports 3.11 natively

flat krakenBOT
bright glacier
#

Was going to approve that, but that also works haha

neon loom
#

I had @dense jungle blessing. One of you two is all I need ๐Ÿ˜› But thanks.

#

Was nice of someone to nudge us!

bright glacier
late dewBOT
#

.github/workflows/ci.yaml lines 16 to 17

# aiohttp by defaults builds with Cython, but it's not marked as a build dep so we'll skip it.
AIOHTTP_NO_EXTENSIONS: 1```
neon loom
#

Ok - I'm gonna go preview some of my other OSS projects with 22.12.0

#

O nice, I did miss that. Thanks

#

Stamp is ready.

#

Get some CI time back hopefully

bright glacier
#

Nah that's my own repository

neon loom
#

O, missed that. I dumb dumb

bright glacier
#

Surprisingly none of our dependencies have broken our CI on their dev branch in the past few months (that's what the repo checks)

#

diff-shades on main is unfortunately broken

#

probably best to fallback to interpreted when the compilation of the baseline revision fails as that's mostly out of our control

#

FYI I haven't used the match statement before so that's why I haven't reviewed psf/black#3426 yet

toxic stormBOT
neon loom
# 
-                            "Continuing to next file after error downloading: " f"{url}"
+                            f"Continuing to next file after error downloading: {url}"
#

That is a nice find from --preview

neon loom
dense jungle
neon loom
#

Yeah, strange flake8 was not picking those up ...

dense jungle
#

maybe because it's part of an implicitly concatenated string

neon loom
#

I'm thankful for the bot removing my troll VP like photo from these links ... haha

dense jungle
#

don't thank the bot that was me ๐Ÿ˜›

neon loom
#

haha - You're now a bot.

bright glacier
#

I thought I was the one who removed it. We really are the same person, doing the same time at the same time :p

# 
>>> from packaging.specifiers import Specifier
>>> s = Specifier("<3.11.0a7")
>>> s.contains("3.8")
True
>>> s.contains("3.8rc1")
False
>>> s.contains("3.8.8rc1")
False
>>>

I wonder if this is the cause for psf/black#3447 (although AFAIK the version comparison logic should allow prereleases)

>>> s.contains("3.8.8rc1", prereleases=True)
True
toxic stormBOT
dense jungle
dense jungle
bright glacier
#

I'll check the pip repository

neon loom
#

Cool - TIL, I already have flake8 running --preview. Nice

#

Ok - I'm off to walk doggy. BBL - Will prob fix bandersnatch to move to latest packaging version later today so I can move to latest tox for my OSS work

bright glacier
#

the recent packaging release seems to have a few bugs FWIW

neon loom
#

Ya, need to see if that's effecting bandersnatch or if I just have to move to new APIs. Will open / submit PRs if so either way ...

flat krakenBOT
dense jungle
#

thanks, once that's in I can turn return_annotations back on in my other PR, which should be enough to get a full working draft

bright glacier
dense jungle
bright glacier
#

I'm trying

dense jungle
#

tried a few searches on pypa/pip and didn't find anything

bright glacier
#

the python version environment marker logic is implemented in packaging AFAICT

dense jungle
#

I was able to repro too on 3.10.0rc1. I ran pip install -vvvvvv with a lot of vs but it said nothing about tomli

bright glacier
#

I'm checking packaging.markers.Marker, turns out you can pass it a custom environment

# 
>>> m = Marker("python_full_version < '3.11.0a7'")
>>> m.evaluate({"python_full_version": "3.8.8rc1", "python_version": "3.8"})
False
>>> m.evaluate({"python_full_version": "3.8.8", "python_version": "3.8"})
True
late dewBOT
#

src/packaging/markers.py line 227

def evaluate(self, environment: Optional[Dict[str, str]] = None) -> bool:```
bright glacier
#

hmm, I just upgraded packaging and both are returning true now

#

I wonder if this has been fixed already

dense jungle
#

ah nice, so maybe pip just needs to update its vendored copy of packaging

bright glacier
#

I'll check

#

I'm just sending a message to the PyPA discord

bright glacier
late dewBOT
#

src/pip/_vendor/vendor.txt line 6

packaging==21.3```
bright glacier
#

I'd probably just simplify it to something like tomli>=1.0.0;python_version<"3.11", no need to worry about 3.11 alphas now
Hugo said this in the PyPA server, seems reasonable

dense jungle
#

would that prevent this bug?

#

agree that that would be better though

bright glacier
# 
>>> m = Marker("python_version < '3.11'")
>>> m.evaluate({"python_full_version": "3.8.8rc1", "python_version": "3.8"})
True
>>> m = Marker("python_full_version < '3.11.0a7'")
>>> m.evaluate({"python_full_version": "3.8.8rc1", "python_version": "3.8"})
False

On packaging 21.3

#

I'm not familiar enough with the PEP 440 comparison rules to understand why this is though.

#

I have to go now. Will be back in a few hours.

flat krakenBOT
flat krakenBOT
neon loom
#

Cool - So that branch ready for me to test Facebook code on?

flat krakenBOT
dense jungle
neon loom
#

Yeah no hurries - Plan Monday anyways

flat krakenBOT
dense jungle
bright glacier
#

I'll take a look at the 2023 stable style issue tomorrow. I already have, but I haven't looked at it in depth

quick knot
flat krakenBOT
#
FSpanhel
[psf/black] Issue opened: #3449 Provide option for formatting fluent interfaces

Consider the fluent interface

v = (
    foo_dict
    .setdefault("a", {})
    .setdefault("b", {})
    .setdefault("c", {})
    .setdefault("d", {})
)

At the moment, black formats this into


v = (
    foo_dict.setdefault("a", {})
    .setdefault("b", {})
    .setdefault("c", {})
    .setdefault("d", {})
)

The reason for the decision to put the first method call on the first line is unclear to me.
The [docs](https://black.readthedocs.io/en/stable/the_bla...

flat krakenBOT
#
FSpanhel
[psf/black] Issue opened: #3450 Option to ignore in\-line comments

Consider this code snippet

import datetime as dt

default_date = dt.date.today() - dt.timedelta(1)  # my long comment appears here # fmt: skip

After running black in https://black.vercel.app/ this becomes

import datetime as dt

default_date = dt.date.today() - dt.timedelta(
    1
)  # my long comment appears here # fmt: skip

which I find really confusing and by far inferior to the original formatting. Note that black has formatted the code althou...

flat krakenBOT
flat krakenBOT
bright glacier
#

I cannot keep up with all the activity ๐Ÿ‘€

dense jungle
#

I think I'm done for now, though there are a few more PRs that could use another look. Maybe later

bright glacier
#

(I'm currently writing a blog post for 23.1a1, I'll promote it everywhere I can once it's up)

dense jungle
#

great, thank you! maybe we can also get ambv to call it out on Twitter

bright glacier
#

I have a twitter account if you haven't noticed

#

but yes his reach would be important

dense jungle
#

me too but I bet more people follow him ๐Ÿ™‚

bright glacier
#

@dense jungle did your PR effectively undo psf/black#3044 ?

toxic stormBOT
bright glacier
#

My gut says no, but I'm getting confused with what was kept and what was not

#

Ah right, multiline docstrings

bright glacier
#

I think I'm running into a chrome rendering bug somehow

bright glacier
#

Oh huh, nothing that depends on ESP being enabled is turned on by default in 23.1a1, that includes change no.3 and no.17 (the wrapping implicitly concatenated strings in parentheses ones)

#

I should've known that earlier, but I forgot how they were implemented.

bright glacier
#

OK also no.4 is still preview only in the 2023 style since it's only relevant to ESP

bright glacier
# 
โฏ git commit -S -m "Add Black 23.1a1 blog post draft"
codespell................................................................Passed
mdformat.................................................................Passed
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
[main 8cfd475] Add Black 23.1a1 blog post draft
 1 file changed, 611 insertions(+)
 create mode 100644 content/blog/2022-12-18-please-test-black-23.1a1.md

OK, it's been written. Now I just need to review it and also prepare psf/black#3407 for the extra attention it will soon get.

toxic stormBOT
dense jungle
bright glacier
#

and 14 too, that's ESP which ain't being promoted for sure

dense jungle
bright glacier
#

Oh, I almost forgot. Ofek fixed the mislabelled platform tags on macOS bug (pypa/hatch#672) ๐ŸŽ‰

toxic stormBOT
bright glacier
#

Ideally we would've tested it out during cutting 23.1a1, but oh well. Hindsight is 20/20

dense jungle
#

maybe we'll get to make an a2

bright glacier
#

probably

dense jungle
#

or make a 22.12.1

bright glacier
#

people are going to get opinionated real quickly once word gets out we're touching the stable style :)

dense jungle
#

huh maybe psf/black#3162 does work without ESP, I am seeing it triggered on mypy code

toxic stormBOT
bright glacier
#

what changes is it making?

#

I'm surprised since AFAIK it's tied to the Preview.string_processing flag which still exists

dense jungle
#

hm somehow ESP is actually being applied, I wonder what I did wrong

#

oh I bet I already had reformatted my checkout in preview style before

bright glacier
#

are you sure the preview style isn't being enabled in some user/project configuration you have?

#

(I confused myself by doing my testing in the black repo which has the preview style enabled ducky_australia )

dense jungle
bright glacier
#

that didn't exist yet?!

#

good call

flat krakenBOT
bright glacier
#

@dense jungle if you want to review before push it to main: ichard26/ichard26.github.io#5

toxic stormBOT
bright glacier
#

I'm sure my punctuation and grammar are rough since I wrote it in bit of a rush ๐Ÿ˜…

dense jungle
#

taking a look, the first few paragraphs look good ๐Ÿ™‚

bright glacier
#

I added a brief header to your "setting the 2023 stable" issue for those jumping in without much context

#

Ah yeah, I forgot about ordering the changes in a meaningful way

#

I always end up googling half a dozen grammar questions every time I write a post :)

bright glacier
#

... did Twitter break their embeds?

flat krakenBOT
bright glacier
dense jungle
#

it's probably time to stop caring?

flat krakenBOT
bright glacier
flat krakenBOT
#
tolomea
[psf/black] Issue opened: #3452 Suboptimal line split choices in 23\.1a1

Describe the style change

I'm looking at differences between 22.8.0 and 23.1a1 on our code base, most of it looks really good โค๏ธ as always thanks for the great work

however there is one pattern of change that doesn't seem ideal, it's possible this has been flagged already, I wasn't sure what to look for.

22.8.0

            common.models.DateTimeField: (
                datetime(2020, 1, 31, tzinfo=utc) + timedelta(days=i)
            ),

23.1a1

...
flat krakenBOT
flat krakenBOT
#
JelleZijlstra
[psf/black] Issue opened: #3454 Extra newlines added before function with fmt skip on decorator

I've just tested this out with a medium-sized codebase. All as expected apart from this one issue with a comment at the end of a function getting 2 newlines added above it. Removing @decorator1 stops the comment getting moved, as does removing # fmt:skip.

https://black.vercel.app/?version=stable&state=_Td6WFoAAATm1rRGAgAhARYAAAB0L-Wj4ADZAIZdAD2IimZxl1N_WlbvK5V9KEd0suDTtKdXyoIEqib4HPPAOaGeijv-QM5F2CIWMxNomuS8WtfuVtc-CBav7wmp196mwOSJGXUmaRTdIwYr1wf881xD3biQ1s52KZSzb20ApVmRJ9H...

flat krakenBOT
neon loom
#

^^ This is not desirable I guess ...

dense jungle
#

yes

neon loom
#

Trying to log in now and see if I can delete

#

Just on work Linux box now and it's logged into nothing

#

Looks like I'll need my personal laptop to move the tag

#

Web only lets me delete

neon loom
#

Ok - reran the aciton. Seem to do what we needed.

#

Later today I'll try find some time to see if we can fix this for draft released and don't move the latest_relrese tag etc.

# 
0>, 'Connection to pypi.org timed out. (connect timeout=15)')': /simple/hatchling/
      ERROR: Could not find a version that satisfies the requirement hatchling>=1.8.0 (from versions: none)
      ERROR: No matching distribution found for hatchling>=1.8.0

Must be setuptools not liking proxy

#

Trying to run the alpha over FB code now

neon loom
#

Is there a direct way I can call hatch to build black? Seems setuptools using hatch in a proxy server environment is unhappy and I can get debug pip output to tell me what ti's trying to do exactly. I could strace I guess

dense jungle
#

PEP 701 is going to make our lives difficult unless Batuhan can unleash some more magic

#

!pep 701

late dewBOT
#
**PEP 701 - Syntactic formalization of f-strings**

Link

Status

Draft

Python-Version

3.12

Created

15-Nov-2022

Type

Standards Track

neon loom
#

๐Ÿ˜ฎ

#

Least he is all over the PEP

#

Will look at some formatting changes soon

#

I don't even know how to checkout instagram anymore. Been so long

#

Gonna post and ask other pythonistas to help test in a bit

dense jungle
#

only 400k lines?

neon loom
#

This is only sub sections of the repo

#

My dev box will run out of disk if I pull everything

#

Will try clean it up this afternoon and let it run on more of the repo overnight

dense jungle
#

thanks!

neon loom
#

Might even try remember how to checkout instagram

#

The removal of the newline for context managers + function/class definitions going to make a lot of change in our code

#

That's main change I see

flat krakenBOT
#
yilei
[psf/black] Issue opened: #3455 Black \-\-preview crashes on long dict key followed by a comment line

<!--
Please make sure that the bug is not already fixed either in newer versions or the
current development version. To confirm this, you have three options:

  1. Update Black's version if a newer release exists: pip install -U black
  2. Use the online formatter at , which will use
    the latest main branch.
  3. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .[d];
    • run `...
#
theelderbeever
[psf/black] Issue opened: #3456 Marker to bypass expected parsing problems

Is your feature request related to a problem? Please describe.

I am working in a Databricks environment and developing workflows there. Unfortunately, it awkwardly requires external dependencies to be installed in the running file in order to make them available. Sample shown below. The issue here is that in development when trying to use black to format the file black will fail with Cannot parse: 4:0: %pip install my_lib. This means the whole file can't be formatted.

neon loom
#

Sweet - Found what was eating all my space - Will kick it off over the whole repo

flat krakenBOT
#
yilei
[psf/black] Issue opened: #3457 Black \-\-preview \(ESP\) crashes with implicitly concatenated stringified generic type params

<!--
Please make sure that the bug is not already fixed either in newer versions or the
current development version. To confirm this, you have three options:

  1. Update Black's version if a newer release exists: pip install -U black
  2. Use the online formatter at , which will use
    the latest main branch.
  3. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .[d];
    • run `...
bright glacier
#

current analytics for the new blog post

image.png
flat krakenBOT
#
yilei
[psf/black] Issue opened: #3458 Black crashes with a single \`\# fmt: off\` before a dict's closing bracket

<!--
Please make sure that the bug is not already fixed either in newer versions or the
current development version. To confirm this, you have three options:

  1. Update Black's version if a newer release exists: pip install -U black
  2. Use the online formatter at , which will use
    the latest main branch.
  3. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .[d];
    • run `...
bright glacier
neon loom
bright glacier
#

It might be worth it pinging some major projects using Black too (looking at the diff-shades project list would do)

flat krakenBOT
#
yilei
[psf/black] Issue opened: #3459 Black \-\-preview \(ESP\) crashes on an implicitly concatenated f\-string

<!--
Please make sure that the bug is not already fixed either in newer versions or the
current development version. To confirm this, you have three options:

  1. Update Black's version if a newer release exists: pip install -U black
  2. Use the online formatter at , which will use
    the latest main branch.
  3. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .[d];
    • run `...
bright glacier
#

Unless someone wants to become responsible for stabilizing ESP, I agree with Jelle it should be trimmed down or removed entirely.

#

There really are a ton of lingering issues w/ ESP

half meteor
#

I want to stabilize ESP (that's why I'm filing all those bugs after running it over our codebase ๐Ÿ˜…)

dense jungle
#

I don't want it in the 2023 preview style unless we can actually stabilize it

#

Otherwise people can't use --preview to see what the next stable style will actually look like

dense jungle
bright glacier
#

I meant stabilizing as in eventually, but currently it will never become stable.

bright glacier
half meteor
#

We have enabled it on 1/5 of our code for a few weeks now (we use incremental formatting via the https://github.com/google/pyink fork so it's only formatting changed code while people making changes), but the feedbacks are overall positive

heady dirge
#

!voiceverify

bright glacier
heady dirge
#

ty whar i can tak this action ?

#

wher

flat krakenBOT
#
ricardo-dematos
[psf/black] Issue opened: #3460 Black is not honoring \#fmt: skip

<!--
Please make sure that the bug is not already fixed either in newer versions or the
current development version. To confirm this, you have three options:

  1. Update Black's version if a newer release exists: pip install -U black
  2. Use the online formatter at , which will use
    the latest main branch.
  3. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .[d];
    • run `...
flat krakenBOT
bright glacier
#

Other than psf/black#3368 and the ones I already covered, what other changes haven't been promoted?

toxic stormBOT
bright glacier
#

I'd guess psf/black#3440 is another one

toxic stormBOT
dense jungle
bright glacier
#

Perfect. I want to fix my blog post before I promote it more widely

dense jungle
flat krakenBOT
bright glacier
#

hmm, did psf/black#3430 make it into the 2023 stable style? It appears it has looking at at the 23.1a1 source code

toxic stormBOT
dense jungle
#

but it's a fixup for an earlier preview change

bright glacier
#

yup, just was curious as it's under main's changelog

#

oh and psf/black#3368 also did not make it into the stable style

toxic stormBOT
flat krakenBOT
bright glacier
dense jungle
bright glacier
#

If so I would like a quick readover and then I'll click publish

dense jungle
bright glacier
#

Thanks!

#

Not really sure if there's a category in discuss.python.org that's appropriate. The Python Help category is the best, but still isn't great.

#

I'll make a post on r/Python though.

flat krakenBOT
#
yilei
[psf/black] Pull request opened: #3462 Exclude string type annotations from ESP

Description

This PR excludes string type annotations from ESP, and also fixes crash on mismatched brackets from ESP.

  1. Unfortunately pyright doesn't support stringified annotations that span multiple lines, e.g.:
def something(
    arg,
) -> (
    "VeryLongClassNameWithAwkwardGenericSubtype[int] |"
    "VeryLongClassNameWithAwkwardGenericSubtype[str]"
):
    ...

Even though other type checkers (mypy, pytype, pyre) do support them. To be safe, we can ch...

flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
#
matthewarmand
[psf/black] Pull request opened: #3465 Add latest\_prerelease Docker Hub tag for following the latest alpha release

Description

Over here, https://github.com/psf/black/issues/3453#issuecomment-1357988758 while fixing an issue with the Docker image publishing workflow, it seemed there's a legitimate desire for a docker tag which follows alpha (prerelease) releases of Black. This PR creates a new tag to be pushed to Docker Hub going forward (latest_prerelease which will be updated with every alpha version release.

I do have another change to request along with this...

If someone comes acro...

neon loom
#

I got a lot of our code ran - with very few errors. I just need to load the config file with the directories to ignore - Will try get to that next few days

#

My internal post asking people to try hasn't rendered much action either

drowsy sonnet
# dense jungle PEP 701 is going to make our lives difficult unless Batuhan can unleash some mor...

https://discuss.python.org/t/pep-701-syntactic-formalization-of-f-strings/22046/24 is worth voting on. :)

Discussions on Python.org
PEP 701 โ€“ Syntactic formalization of f-strings

As I assume this is going to be a controversial point of the proposal I am making a poll. Question: Do you think that f-strings should allow quote reuse within the expression part? (as in fโ€ something { my_dict[โ€œkeyโ€] } something else โ€œ) poll Please take the time to read the PEP first and then the discussion so far regarding sone of the argume...

neon loom
#

I like but I feel it's going to make parsing harder for us ...

drowsy sonnet
#

Bring it up on that thread ๐Ÿค”

neon loom
#

I get very low success on these threads. Feels like a void for me, so I stopped going.

drowsy sonnet
#

I don't think it can hurt to do that (unless it's already come up)

drowsy sonnet
silent apex
#

is this the pep that makes f-strings a parser-level thing, and thus infinitely nesting strings is allowed?

drowsy sonnet
#

In other news, I'm here to say that I am excited about the formatting changes coming in next year!

#

I'm especially keen to see how the theoretical "good stability policy" is going to work out in practice. ๐Ÿ™ˆ

drowsy sonnet
neon loom
silent apex
#

right. as someone implementing a python parser, i actually figured this would make my job easier, given that i can just parse it as yet another expression node and make the lexer more general (less nesting special-casing). why does it make parsing more complicated for black? (i really need to look into how it works right now >.>)

neon loom
#

We just force larger blanket formatting diffs at the start of each year now

drowsy sonnet
#

Well, this is the first year.

#

And, I'm sure we'll see some user backlash.

flat krakenBOT
#
wookie184
[psf/black] Issue opened: #3466 Extra parentheses added even when string isn't split

Describe the bug
With preview style, a long f-string where the only spaces are in the expression bit has parentheses added even though it isn't split over lines. For example:

f(
    f'longstringwithnospacesinthestringbitbutwithspacesintheformattyfstringbithere{ 1 }',
)

becomes

f(
    (
        f"longstringwithnospacesinthestringbitbutwithspacesintheformattyfstringbithere{ 1 }"
    ),
)

I would instead expect it not to have changed. [See on black ...

#
yilei
[psf/black] Pull request opened: #3467 Significantly speedup ESP on large expressions that contain many strings

Description

Previously, when ESP 1) merges strings in StringMerger; 2) strips parens in StringParenStripper, it finds and does one transform for one string group. Each transform will create a new line with 1) one group of strings merged; 2) one group of strings' parens stripped. This new line is then re-checked by those transformers. This is O(n^2) complexity.

Since these transformers won't cause line breaks, the same transforms can be done at one pass, and it only cre...

flat krakenBOT
#
matthewarmand
[psf/black] Pull request opened: #3468 Vim plugin docs improvements

Description

This is a few documentation changes for the Vim plugin. I included them in the same PR to avoid clutter and because they're all pretty minor and easily reviewed together. I also made a commit for each thematic change, so feel free to look at specific commits if you want to see the changes in isolation. I didn't think this was a substantial enough change to warrant a CHANGES.md entry, but am happy to add one if maintainers disagree.

There are 4 main changes in here:

...

flat krakenBOT
neon loom
#

So much action !

flat krakenBOT
flat krakenBOT
flat krakenBOT
#
yilei
[psf/black] Pull request opened: #3470 Fix an issue where extra empty lines are added\.

Description

Fixes #3454.

This is actually unrelated to # fmt: skip, as this also happens when a regular standalone comment is placed between decorators.

This is a regression caused by https://github.com/psf/black/pull/3302 (Preview.empty_lines_before_class_or_def_with_leading_comments)

Checklist - did you ...

  • [x] Add an entry in CHANGES.md if necessary?
  • [x] Add / update tests if necessary?
  • [x] Add new / update outdated documentation?
flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
lament crow
#

Unsure why it even chose me

#

Is it just iterating through users until it finds 5 Twitter handle? Because I'm rather far down in the contributor list

flat krakenBOT
neon loom
#

Tears apart bandersnatch test formatting

#

I'm torn on the """ brought up to the first ( now looking at it ...

#

Sorta goes against other ways we format

flat krakenBOT
flat krakenBOT
lament crow
#

I don't think there's an issue for PEP 701 yet since it's still a draft so just putting my opinion out there

#

I guess that if someone used """ on the outside f-string then I would expect formatting to be like this:

f"""
{f"{f'{f"{f'infinite'}"}'}"}
"""
flat krakenBOT
dense jungle
#

another similar one ```% black --preview -c 'for (x := 3, y := 4) in y: pass'
for (x := 3, y := 4) in y: pass
error: cannot format <string>: Cannot parse: 1:6: for x := 3, y := 4 in y:

slow ibex
# 
>>> for (x := 3, y := 4) in y: pass
  File "<stdin>", line 1
    for (x := 3, y := 4) in y: pass
         ^^^^^^
SyntaxError: cannot assign to named expression

it is not valid syntax

dense jungle
#

yes, but we have a bunch of similar test cases already to appease fuzzers (tests/data/fast/pep_572_do_not_remove_parens.py)

flat krakenBOT
flat krakenBOT
little parrot
#

They changed reponse to reponse ๐Ÿ˜œ

bright glacier
#

ha amazing, I totally missed that ducky_sphere

#

Merry Christmas folks! (if you observe it) ducky_santa

dense jungle
#

Merry Christmas!

flat krakenBOT
bright glacier
#

I'll review your PR from today. I have it open, but I've been distracted fiddling with C :)

dense jungle
#

no hurry!

bright glacier
#

Okay time to stop fiddling with C. I split my codebase into several files and now I'm figuring out how I can get Make to automatically set up prerequisites so changes to header files don't require a clean rebuild... an initial read of the Make docs is flying over my head ๐Ÿฅด

ivory quest
#

"S" in "C" stand for "sanity" lol

flat krakenBOT
flat krakenBOT
bright glacier
#

Later on, I might take a look at some of the major PRs merged during my absence, but I'm not worried about the smaller bugfixes (they look pretty good on a surface read). I did spot a changelog error though :)

bright glacier
late dewBOT
#

CHANGES.md?plain=1 lines 23 to 26

- Fix a crash in preview advanced string processing where mixed implicitly concatenated
  regular and f-strings start with an empty span (#3463)
- Fix a crash in preview advanced string processing where a standalone comment is placed
  before a dict's value (#3469)```
little parrot
#

no

flat krakenBOT
bright glacier
#

Currently investigating hatch w/ mypyc, seems like the situation got even worse?

dense jungle
#

oh no, what's wrong?

bright glacier
#

It can be at most 10_9 AFAICT, but I have no idea why 11_0 is being selected in the first place.

#

I don't trust any of the platform tags generated by hatchling to be honest

#

I might do a test build switching back to setuptools and figure out what the platform tags should actually be for macOS.

flat krakenBOT
bright glacier
#

... Are you waiting for me to review? I can do that later tonight

#

I'm surprised you didn't merge that right after approving it

dense jungle
#

I got distracted, do you want me to wait?

bright glacier
#

sure, I can take a look after I figure out what's wrong w/ hatch

#

(battling wifi issues on my main machine right now though, ugh)

flat krakenBOT
bright glacier
#

Honestly it might be easier to just revert the hatchling PR instead of dealing with this mess

dense jungle
#

sad but that might be the right call

#

I might merge psf/black#2278 if I like what diff-shades has to say

toxic stormBOT
bright glacier
#

wow may 2021

dense jungle
#

I started at the oldest open PRs lol

bright glacier
#

I'm not concerned about the implementation at all so as long as you like the diff-shades results, feel free to merge

flat krakenBOT
bright glacier
#

it's really simple actually

flat krakenBOT
bright glacier
late dewBOT
#

src/black/linegen.py lines 152 to 153

lpar = Leaf(token.LPAR, "")
rpar = Leaf(token.RPAR, "")```
dense jungle
#

invisible parentheses?

bright glacier
#

yea, although I don't know well enough how we treat them to know whether it'd be a problem

flat krakenBOT
bright glacier
#

one thing about setuptools is that editable installs might require some tweaking since they massively changed how they work

#

reverting doesn't look too hard, but keeping the 3.6 removal changes will be a pain

flat krakenBOT
bright glacier
#

nevermind, there are 5 conflicts!

#

OK so patched hatchling seemed to fix the ARM64 build, but the universal2 and more importantly the x86_64 builds are still broken.

flat krakenBOT
mint barn
#

hal

bright glacier
#

The TL;DR is that packaging 22.0 changed how tags for Python 3.7 (and maybe 3.8?) on macOS are determined and that's causing hatchling to build wheels with platform tags pip can't install. macosx_10_16 is effectively equivalent to macosx_11_0 but pip doesn't know that since it vendors packaging 21.something.

#

Ofek is planning a new release of hatchling that bans packaging 22.0 so in theory we should be able to provide mypyc wheels for macOS soon.

ivory quest
#

This kind of issues makes me wonder why modules like packaging are not part of stdlib

flat krakenBOT
neon loom
#

can't believe @bright glacier hates CI ... Image managing black without it !

bright glacier
#

I don't actually, but writing it can be a real pain my gosh

neon loom
#

Proof

bright glacier
#

me: writes draft
gha: red all over
me: pushes a hotfix
gha: no.
me: pushes another hotfix:
gha: no.
[repeat 10 more times at least]
gha: you've proven yourself worthy, it shall work now

#

You have no idea how much time I've spent debugging hatch-mypyc. Probably north of 3-4 hours now. The #hatch channel on PyPA has been busy these past two days ๐Ÿ˜…

#

I still don't know what the proper fix is to be honest.

#

I need to learn how to SSH into a GHA runner, will finally give me access to a macOS machine. (or I could apply for access to the GCC compiler farm for once)

lament crow
bright glacier
#

Hugovk already sent me a link on how to, I haven't tried yet (need to learn how to use SSH first)

lament crow
#

Btw, if you need an M1 test machine, Cirrus CI actually has a more native ssh feature, can just use the shell from the web ui

flat krakenBOT
neon loom
#

I feel you with long debugs โ€ฆ Iโ€™ve spent weeks on things at work โ€ฆ (on and off of course)

brittle pawn
#

hi

flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
#
mkillianey
[psf/black] Issue opened: #3480 Request for a mechanism to accept more target files than the platform line length will allow

Is your feature request related to a problem? Please describe.

When using black to format long lists of files, one must use a tool like xargs to avoid triggering the platform's maximum command-line length. For example, if I want to clean up the modified files in my workspace, I can't write this:

black $(git status --porcelain | cut -c3- | grep -e '*.py$')

Because the command-line would overflow. Instead, I have to write it this way, triggering black multiple times:
`...

dense jungle
ivory quest
# flat kraken

pre-commit solves this issue nicely, since it only passes modified files to the hook

dense jungle
#

but what if you modify so many files that it exceeds the argv length limit ๐Ÿ˜„

bright glacier
#

support reading a file with paths separated by newlines /j

#

I haven't read the issue, but I wouldn't be surprised if that's the suggestion haha

ivory quest
#

I would say that this is quite a rare case to go over the args limit

bright glacier
#

the mypyc command line errors out due to a new setuptools feature, great.

flat krakenBOT
brave orchid
#

Hi folks!

Does black's CI and package publishing depend on CircleCI or is it impacted by the recent breach0 to their infrastructure?

dense jungle
#

no, never used circleci

brave orchid
#

@dense jungle Thank you! โค๏ธ It may help to put out a statement with so folks trying to ensure they aren't hit with a supply chain attack after this breach.

But I appreciate the response very much

#

I notice there aren't many dependencies black depends on much either. ๐Ÿ™‚

flat krakenBOT
flat krakenBOT
#
ZeroIntensity
[psf/black] Issue opened: #3482 Segmentation fault when trying to run \`black\`

not using the issue report format since it doesnt really fit here

originally, i was having an issue that looked like this:

> black
Traceback (most recent call last):
  File "/home/zero/.local/bin/black", line 8, in 
    sys.exit(patched_main())
  File "src/black/__init__.py", line 1481, in patched_main
KeyError: 'maybe_install_uvloop

i then updated through python3 -m pip install -U black.
now, instead when i run black (both through black and python3 -m black), i...

woeful flax
#

Can someone point me in the direction? I'm wanting to enforce black on all python code across all our repos. My understanding is that I can do that on a repo-by-repo basis by using GitHub actions as described here. So I added the .github/workflows/black.yml file to a repo and did both a pull and a push and, while nothing broke (great!), I don't know that ANYTHING happened (not so good). It was my expectation that either the file I changed would be run through black or ALL the files in the repo would be run through black.

Either of those options would be great. TIA

#

(p.s. anyone else miss decentralized mail-list communities that had searchable archives? just me?)

little parrot
#

you know you can search on discord ๐Ÿค”

silent apex
woeful flax
#

i've never once had a google hit pointing me at discord.

silent apex
woeful flax
silent apex
#

well, that action won't actually reformat your code

#

by default, it will simply check and than fail CI if the code isn't properly formatted

#

otherwise the github actions bot would have to commit to your code

woeful flax
#

OK - thanks. I misunderstood the outcome.

bright glacier
#

Also, while working on python/mypy#14409 I was looking for some evidence people do actually loop over set literals. I didn't expect I'd find an example from Black :D

image.png
toxic stormBOT
flat krakenBOT
#
kamarton
[psf/black] Issue opened: #3483 black\[d\] \- ERROR: Could not build wheels for aiohttp, frozenlist, multidict, yarl, which is required to install pyproject\.toml\-based projects

I want to install ห™black[d]ห™ in Windows 11 64 bit.

pip install 'black[d]'
...
      building 'yarl._quoting_c' extension
      error: --plat-name must be one of ('win32', 'win-amd64', 'win-arm32', 'win-arm64')
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for yarl
Failed to build aiohttp frozenlist multidict yarl
ERROR: Could not build wheels for aiohttp, frozenlist, multidict, ...
flat krakenBOT
flat krakenBOT
woeful flax
woeful flax
# woeful flax Still exploring options. Features and drawbacks to any approach. I like the ide...

Reference to "Code as (sic) law" -- https://journals.openedition.org/factsreports/4518#:~:text=As stated by Lessig (1999,individual's%20actions%20via%20technological%20means.

The Expansion of Algorithmic Governance: From Code is Law to Law is...

Introduction We are spending increasing amounts of our lives interacting within platforms, whose user base belittle that of existing nation states. And yet, their governance is very far from the v...

ivory quest
half meteor
#

https://black.readthedocs.io/en/stable/the_black_code_style/future_style.html#using-backslashes-for-with-statements

Although when the target version is Python 3.9 or higher, Black will use parentheses instead since theyโ€™re allowed in Python 3.9 and higher.
This doesn't look like implemented? https://black.vercel.app/?version=main&state=_Td6WFoAAATm1rRGAgAhARYAAAB0L-Wj4AFLAKddAD2IimZxl1N_WmufDs0LojAMwSd5y6tVHFECi48em1NmrZSWd-aOQDsyxUoj0wG4N0KjynelfrUIzSWL64h5VoX_mCOwgMPUKBe_kpQGb8ToKkTNJMhtPCsqZ-aszOI5WcjMdmBg-q7cPX3coevA_OIpFObLOmoS5kucg6QUzHvL6k7_9RcyS-tVYfqVbx0JL_U2lXGCnRBPkIbvpyjV8-xUtCGeqEUAAAA8zdsAm2iELQABwwHMAgAApxRWVrHEZ_sCAAAAAARZWg==

Black Playground

Playground for Black, the uncompromising Python code formatter.

dense jungle
#

maybe "will use" there is supposed to mean "will, when we implement this, use"

#

but it would be good to make that explicit

#

and even better to actually implement the behavior as described ๐Ÿ™‚

half meteor
#

I'll take a look at it then. Also this should be 3.10+ since it's only officially allowed in 3.10

flat krakenBOT
#
yilei
[psf/black] Issue opened: #3486 Wrap multiple context managers in parens when targeting Python 3\.10\+

So that we actually implement https://black.readthedocs.io/en/stable/the_black_code_style/future_style.html#using-backslashes-for-with-statements:

Although when the target version is Python 3.9 or higher, Black will use parentheses instead since theyโ€™re allowed in Python 3.9 and higher.

I'll work on a PR to implement this when targeting Python 3.10+ (since it's only officially allowed in 3.10 https://docs.python.org/3/whatsnew/3.10.html#parenthesized-context-managers, though accidenta...

dense jungle
half meteor
#

except when you use PYTHONOLDPARSER=1 ๐Ÿ˜› but yeah it will be fine in practice so this SG

dense jungle
#

and I don't think it was quite "accidental" as you put it in the issue, it's more like Guido and co snuck it in ๐Ÿ™‚

flat krakenBOT
#
CelestialGuru
[psf/black] Issue opened: #3487 Cannot format code with local variable name \`match\` in same line as match pattern matching expression

Describe the bug

Take this code:

import re
match = re.match(r"(?PLD|MD|HD)(?PAL|SS)", "HDSS")
match (match.group("grade"), match.group("material")):
    case ("MD" | "HD", "SS" as code):
        print("You will get here")

And run it with these arguments:

$ black file.py --target-version py310 # or --target-version py311

The resulting error is:

cannot format foo.py: Cannot parse: 3:0: match (match.group("grade"), match.group("material")):...

flat krakenBOT
flat krakenBOT
#
yilei
[psf/black] Pull request opened: #3489 Wrap multiple context managers in parentheses when targeting Python 3\.9\+

Description

Fixes #3486.

This also fixes the target version detection logic for parenthesized context managers (3.9) and match statements (3.10). But as far as I can tell, this didn't have user visible impact (until this PR).

I added a dedicated test data folder preview_context_managers, because this relies on the version detection logic when --target-version is not explicitly specified.

Checklist - did you ...

  • [x] Add an entry in CHANGES.md if neces...
flat krakenBOT
flat krakenBOT
hushed citrus
flat krakenBOT
#
nicoddemus
[psf/black] Issue opened: #3491 Cannot find full list of options in the documentation

I am porting a new project to black and wanted to consult on the options available, however I cannot find the full list of options in the documentation.

In Usage and Configuration, it states:

Youโ€™ve probably noted that not all of the options you can pass to Black have been covered. Donโ€™t worry, the rest will be covered in a later section.

However I cannot find a section describing all optio...

flat krakenBOT
flat krakenBOT
flat krakenBOT
#
yilei
[psf/black] Issue opened: #3493 Module docstrings aren't formatted, unlike other docstrings

Example: https://black.vercel.app/?version=main&state=_Td6WFoAAATm1rRGAgAhARYAAAB0L-Wj4ADgAHldAD2IimZxl1N_Wk8FsJZhkAjhyjG3tVjxJ9Gp9Zojsi1i8DVq3VtVGWVA4en-neQWZRs0Yby6Rh486UwtT5kSyua0nvj17KQw7tG7Ya2GvmqWyx6rvshnP2g3A9E7w_INJJXQ8vt9s7PWaZ1j-sQaPDU8Y6Oj32p-9QAAAAAAuYXePL9oFb0AAZUB4QEAAPc2n9yxxGf7AgAAAAAEWVo=

"""This is a module docstring.


"""


def func():
    """This is a func docstring.
    
    
    """

is formatted to:

"""This is a module docst...
flat krakenBOT
flat krakenBOT
#
jakkdl
[psf/black] Issue opened: #3494 Enforce parentheses around star unpacking containers modified with operators

Describe the style change
Star unpacking containers in combination with modifying the container with an operator has a somewhat unintuitive operation ordering, and I think should probably have enforced parentheses.

Examples in the current Black style

def foo(other_var: Any):
    my_set: set[str] = {"a", "b", "c"}
    my_list: list[int] = [0, 1]

    print("hello", *my_set | {d}, "world")
    bar(*my_list + [2])

    # TypeError if other_var is not a set,...
haughty ocean
#

Is one able to manage the way that black formats imports? Without the wrapping and having an import on each line instead

ivory quest
#

Black doesn't change imports, other than line wrapping. Use isort

flat krakenBOT
#
jceresini
[psf/black] Issue opened: #3495 Compatibility issue with isort

Describe the bug

I already reported this on the isort side in case it belongs there: https://github.com/PyCQA/isort/issues/2070

I ran black and isort --profile=black against a file and they both format the file differently

To Reproduce

Python example code:

from google.api_core.exceptions import AlreadyExists, BadRequest, ClientError, Conflict, NotFound

Run black against that file like this (Note: I have no config files for black or isort in this min...

flat krakenBOT
flat krakenBOT
flat krakenBOT
#
leaver2000
[psf/black] Issue opened: #3496 Internal error on type hinted comment with trailing space

Describe the bug

Black is encountering an INTERNAL ERROR when a type hinted comment has a trailing space.

To Reproduce

For example, take this code:
With the trailing space after # type: dict[str, str] black encounters an internal error

d = {}  # type: dict[str, str]

remove the white space character like type: dict[str, str] and the file is formatted.

And run it with these arguments:

$ black t.py 
error: cannot format t1.py: INTERNAL...
flat krakenBOT
#
felix-hilden
[psf/black] Issue opened: #3497 Multiline string concatenated to be over line length in function argument default value

Describe the bug
From #2188: When processing a multiline string in a function argument default value with --preview (ESP), it is concatenated even if it will exceed line length.

To Reproduce
Here's a [playground link](https://black.vercel.app/?version=main&state=_Td6WFoAAATm1rRGAgAhARYAAAB0L-Wj4AIZAPddAD2IimZxl1N_WlbvK5V-4XXUGvpeVcLH8iKYR8mKJ8OeVa2yGQN68ELSum2f5bZ5aTWDTpb6tVSmXkCas7K79A96W2lU3uDWQBaoO8HRG7ct00CbiHOlm1rvQ9QNG_jvTC3cqe3ZdMUVm3DNf9kK-7kHuH1ImqdVbOHxBxgAGrz2ShWgzM0...

flat krakenBOT
#
felix-hilden
[psf/black] Pull request review submitted: #1879 Improve multiline string handling

Hi! Thanks for the work and sorry for the late review on my part as well. A couple of small comments and a gentle wish below if you still have energy for this PR ๐Ÿ˜…

I'd adore it if you could explain the algorithm a bit perhaps in a comment, or even try to break it into more bite-sized pieces so that the big picture is clearer. Like finding the leaves that are inside the line (L783-L788). Took me a solid hour to start to understand, particularly the manipulation of max_level_to_update ๐Ÿ˜„ (a...

sleek canopy
#

!src

late dewBOT
flat krakenBOT
flat krakenBOT
bright glacier
#

@dense jungle in the issue linked in psf/black#3473 you mentioned that this PR doesn't fix all the similar cases. Should we keep that issue (psf/black#3472) open?

toxic stormBOT
bright glacier
#

Otherwise, I'm going to merge your PR.

dense jungle
flat krakenBOT
#
AdeliManesh
[psf/black] Issue opened: #3498 Black fails to observe the number of characters in the line

Describe the bug
I my python file a line with more than 80 characters exists but black doesn't split the line into multi lines due the line length constraint.

To Reproduce
the is my "test.py" file

graph_path_expressions_in_local_constraint_refinements = [
graph_path_expression
for refined_constraint in self._local_constraint_refinements.values()
if refined_constraint is not None
for graph_path_expression in refined_constraint.condition_as_predicate.variable...

flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
#
meliache
[psf/black] Pull request opened: #3500 Use dashes for pycodestyle max line length config

Description

The option is max-line-length with dashes, not underscores. The config option name is given in the output of pycodestyle -h, which can also be checked on https://pep8.readthedocs.io/en/stable/intro.html#example-usage-and-output:

Configuration:
    The project options are read from the [pycodestyle] section of the
    tox.ini file or the setup.cfg file located in any parent folder of the
    path(s) being processed.  Allowed options are: exclude, filename,
    ...
flat krakenBOT
#
fredrgrs
[psf/black] Issue opened: #3501 Please make emojis optional

It seems that black indiscriminently prints emojis. Could you PLEASE give us an option to disable unicode output, just like we can disable color output? Not everyone is able to or chooses to use unicode-capable terminals, and these multi-byte characters will screw up many terminals, as they can be interpreted as terminal control codes or expected to render as single characters per byte.

ivory quest
#

since plugins are unbound, new issues raised. should I fix them within my PR or open another PR fixing those?

Zrzut_ekranu_z_2023-01-17_17-57-42.png
#

I took it upon myself to "fix" #3501 (emojis)

dense jungle
ivory quest
#

it's just f'"{value}"' -> f"{value!r}" everywhere

dense jungle
#

hm !r gives single quotes so that's not necessarily safe

#

depending on what we need the quotes for

ivory quest
#

from what I can see, it's mostly output messages formatting

dense jungle
#

I think some terminals treat " in output differently so that might have been on purpose

ivory quest
#

so, should I add this error code to ignores?

faint haven
#

I think they're planning on moving it to off-by-default

#

PyCQA/flake8-bugbear#333

toxic stormBOT
flat krakenBOT
#
Secrus
[psf/black] Pull request opened: #3502 Add \-\-emoji/\-\-no\-emoji option

Description

Resolves: #3501
This PR adds a CLI option to disable emojis in output messages.

Checklist - did you ...

  • [x] Add an entry in CHANGES.md if necessary?
  • [ ] Add / update tests if necessary?
    (Didn't find any tests for the output, but can add them if necessary)
  • [ ] Add new / update outdated documentation?
    (Could use some directions as to where to put the update about new CLI option)
dense jungle
faint haven
bright glacier
ivory quest
#

I am going to add ignore in another PR, as Jelle suggested in review

flat krakenBOT
dense jungle
#

fyi @ivory quest it's generally frowned upon to force-push PR branches, since it makes it harder for reviewers to see the history. Just push a new commit, and when we merge we'll squash them together

#

(not sure if this workflow preference is true for all repos)

ivory quest
dense jungle
#

not a big deal but something to keep in mind

ivory quest
#

will remember ๐Ÿ˜„

bright glacier
#

ah CI is broken because of bugbear, that's great

#

I was wondering why the PR I was reviewing is red :D

ivory quest
#

fix is spinning on CI

ivory quest
#

fix is ready to be merged btw

flat krakenBOT
dense jungle
flat krakenBOT
flat krakenBOT
flat krakenBOT
#
jakkdl
[psf/black] Issue opened: #3504 Enforce leading vs trailing spaces in multiline strings

Describe the style change
I've repeatedly messed this up as of late, and only afterwards realized I've been horribly inconsistent on where I place the spaces in multi-line strings.

Examples in the current Black style

Black will currently not reformat either of these multi-line strings

my_string_1 = (
    "words that are in the first line "
    "words that are in the second line "
    "words that are in the third line."
)
my_string_2 = (
    "words that are i...
flat krakenBOT
#
goretkin
[psf/black] Issue opened: #3505 "unindent does not match any outer indentation level" for valid Python syntax

<!--
Please make sure that the bug is not already fixed either in newer versions or the
current development version. To confirm this, you have three options:

  1. Update Black's version if a newer release exists: pip install -U black
  2. Use the online formatter at , which will use
    the latest main branch.
  3. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .[d];
    • run `...
bright glacier
#

Yay I did something for once.

#

!remind 18H review that infer target-version PR you've been meaning to for like 2 months >.<

late dewBOT
#
You got it!

Your reminder will arrive on <t:1674161252:F>!

ID: 5570
bright glacier
#

thanks @errant barn for doing a review in the meanwhile

flat krakenBOT
late dewBOT
flat krakenBOT
lament crow
#

Cool

#

Won't happen until 24.1, I guess?

dense jungle
#

yes, or 23.1 --preview

flat krakenBOT
flat krakenBOT
#
kephircheek
[psf/black] Issue opened: #3507 Autoload vim script uses non\-specific path to python binary

<!--
Please make sure that the bug is not already fixed either in newer versions or the
current development version. To confirm this, you have three options:

  1. Update Black's version if a newer release exists: pip install -U black
  2. Use the online formatter at , which will use
    the latest main branch.
  3. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .[d];
    • run `...
flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
#
oskarkk
[psf/black] Issue opened: #3510 Formatting of long expressions in arguments

Describe the style change

#3440 (closing #620 and #808) improved handling of long expressions in dict values by putting them in parentheses, but the same values in arguments aren't always handled nicely.

Examples in the current Black style

dict(
    key_key_key_key=a_long_long_long_long_long
    * b_long_long_long_long_long
    / 100.0
)

dict(
    key_key_key_key_key_key_key_key_key=lambda: some_very_long_function_name(
        x, y, z
    )
)

...

flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
#
Olumeni1
[psf/black] Issue opened: #3512 Please be careful I love you all so I need you safe

Don't click links

Avoid clicking on any link,
What are you waiting for, my account is not safe so neglect any massage or task or change for now. Thank you all for understanding and cooperation, do not accept any changes so work with our first agreement
Work with the first instructions when created

Work with the first instructions because Olumeni1 projects has been stolen by brothers and partners working with him

Any ideas call me on 09019760402 or my Gmail wisdomolumeni32@gmail.com
I pr...

#
meliache
[psf/black] Pull request opened: #3513 Use dashes for pycodestyle max line length config

Description

Same commit as in PR #3500 but made new PR targeting main.

The option is max-line-length with dashes, not underscores. The config option name is given in the output of pycodestyle -h, which can also be checked on https://pep8.readthedocs.io/en/stable/intro.html#example-usage-and-output:

Configuration:
    The project options are read from the [pycodestyle] section of the
    tox.ini file or the setup.cfg file located in any parent folder of the
    path(s) bein...
flat krakenBOT
bright glacier
#

heh why did I not close that. I opened this issue when I got up, but I never closed it ๐Ÿ˜…

dense jungle
#

you were just being careful as the issue asked for

bright glacier
flat krakenBOT
#
echoix
[psf/black] Issue opened: #3515 Reproducible \`black \-\-help\` output for \`\-\-python\-cell\-magics\` option

<!--
Please make sure that the bug is not already fixed either in newer versions or the
current development version. To confirm this, you have three options:

  1. Update Black's version if a newer release exists: pip install -U black
  2. Use the online formatter at , which will use
    the latest main branch.
  3. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .[d];
    • run `...
flat krakenBOT
#
echoix
[psf/black] Pull request opened: #3516 Fix \`black \-\-help\` output for \`\-\-python\-cell\-magics\` option to be reproducible

Description

This small change is to fix the issue #3515. It adds a sorted(...) to the PYTHON_CELL_MAGICS set wrapped inside a string.join() in order to have a stable output in the black --help command. No other changes are required.

Checklist - did you ...

  • [ ] Add an entry in CHANGES.md if necessary? See comment below.
  • [ ] Add / update tests if necessary? : Did not find something that checks the existing output
  • [ ] Add new / update outdated documentati...
flat krakenBOT
elder tusk
bright glacier
#

it really is, shame that it seems to be getting worse slowly over time :(

bright glacier
elder tusk
#

that seems worth doing! if you send a PR to the wheel builds repo, I will review and see it through

flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
#
tgross35
[psf/black] Issue opened: #3518 Format attribute \`\# fmt: wrap\-list=16\` for specific

Is your feature request related to a problem? Please describe.

This has a design goal to solve the problem addressed in #1281, #2026, #3182: formatting of very large arrays, but in a different way than proposed.

Describe the solution you'd like

Those two issues were closed because black does not want to introduce an external argument to determine array formatting. That makes complete sense, as adding an argument would lead to fragmenting style.

Instead, I would like to s...

ivory quest
#

does black format code using \ to split long lines?

lament crow
#

Nope

#

There were plans to split with on <3.9 using \

#

I somewhat doubt anyone will want to pursue it anymore considering that 3.8 will be EOL in ~a year

#

There's also """\ which doesn't happen automatically but isn't removed by Black

#

though there are plans to allow ```
textwrap.dedent("""
text
""")

#

I'm not sure \ would ever need to be inserted by Black in such case though

ivory quest
lament crow
#

oh right, gap between 3.7 and 3.8 releases was still 1.5 years

flat krakenBOT
flat krakenBOT
exotic stratus
#

How do I prevent an exploded string from compacting back to a single line? Much like how function params can be kept as exploded by keeping , at the end.

Example:

foo: str = (
    f"This is written on "
    f"my {phone} phone, "
    f"hope the formatting is OK."
)

If line length wouldn't be reached, it collapses it to a single line. What is the , equivalent here, at strings, to keep them exploded?

Thanks in front.

#

If an explanation of "why" is required, I am using the subprocess module and would prefer to write each shell command option/flag in its own line for clarity

#

I am aware that I can pass them as a list and that it is even safer that way, but assuming I only want to pass a single element that is a string and don't want black to collapse it

exotic stratus
#

Please mention/ping me if you have a reply

flat krakenBOT
ivory quest
dense jungle
exotic stratus
#

Ah, that's slightly unfortunate

#

I have a general dislike for multi-line comments (indents considered, etc.), and "exploding" single-line comments are pretty darn sweet

flat krakenBOT
#
jimbudarz
[psf/black] Issue opened: #3521 GitHub Action: Option to scan only changed files

Is your feature request related to a problem? Please describe.

When I raise a PR, I like to have the GitHub Action for black lint my code. However, with large projects, sometimes it's unwise to lint the entire existing codebase- it's better to only lint the files that have been changed in that PR.

Describe the solution you'd like

It would be great if there were an option to only lint the files that have changed, when running the GitHub Action on a PR.

**Describe altern...

flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
#
yilei
[psf/black] Issue opened: #3525 Should Black have an opinion about sequence pattern matching syntax?

Describe the style change

In structural pattern matching, for sequence patterns, you can use either parenthesis, brackets, or just comma separated items.

Examples in the current Black style

Currently Black doesn't have an opinion and you can use any of them:

match actions:
    case ["help", "bracket"]:
        print("use brackets")
    case ("help", "paren"):
        print("use parens")
    case "help", "comma":
        print("just use comma")
 ...
late dewBOT
#
Resources

The Resources page on our website contains a list of hand-selected learning resources that we regularly recommend to both beginners and experts.

flat krakenBOT
#
rjalexa
[psf/black] Issue opened: #3526 Github action could return number of changed/formatted files

Is your feature request related to a problem? Please describe.

The official psf/black GitHub Action does not seem to return information on its run. Other related actions such as https://github.com/rickstaa/action-black returned an is_formatted flag which could be used by subsequent steps.

If you use an "open pull request" action after the formatting step, and if black did format any file, then you can automatically open a pull request and when approved the formatted code would be co...

flat krakenBOT
#
itoijala-huld
[psf/black] Issue opened: #3527 Apply excludes before normalising symlinks

Is your feature request related to a problem? Please describe.

Our project contains symlinks like this:

project
+- a
   +- b -> ../x/y
   +- other files
+- x
   +- y
      +- lots of files

We would like to avoid black spending time formatting/complaining about the same files twice, so we make the excludes regex match /a/b/.
This doesn't help because the excludes are evaluated after normalising the path to /x/y/.
We cannot put that in the excludes because we ...

glossy oak
# flat kraken

made a patch for this as it seemed to be "good use of my downtime" .. I did read contributing guidelines and pre-commits are passing but there's probably the idea needs some fleshing out even if it as accepted as feature for github action ..

flat krakenBOT
flat krakenBOT
flat krakenBOT
flat krakenBOT
#
gokberkgunes
[psf/black] Issue opened: #3530 Enforced Spacing Around Binary Operators

Problem Statement

When binary operators, such as +, -, *, /, %, are used, their priority is given to them, and spacing should be set by their priorities. The stress could be seen when people write multiplication operators with some constants; they generally tend to drop the operator and write them together, e.g., 2*x becomes 2x.

Similarly, not just general logic but also PEP8 suggests following this priority style. However, Black does not recognize the prioritization of binary ope...

sleek canopy
#

!d discord.AuditLogEntry.target

late dewBOT
flat krakenBOT
#
rasjani
[psf/black] Pull request opened: #3531 Github action now reports state of execution \#3531

Description

Adds 2 new outputs to github actions which would allow pipeline maintainer to do conditional steps based on actions black did. These variables include is_formatted which defaults to 0 if no changes where made and 1 when files where formatted. Another one is changed_files, which defaults to 0 but reports the number of files changed during the action execution.

Checklist - did you ...

  • [X ] Add an entry in CHANGES.md if necessary?
  • [X] Add / update tests i...
elder tusk
#

is there a good way to get pre-commit to use the nice mypyc compiled wheels?

flat krakenBOT
dense jungle
flat krakenBOT
flat krakenBOT
dense jungle
#

oh apparently we're affected by whatever poetry did

bright glacier
#

wait what?

dense jungle
#

though it seems to have succeeded on psf/black so I guess not

bright glacier
#

Probably the cache is avoiding the issue. TIL isort uses poetry

#

Packaging is just โœจ great โœจ ugh

flat krakenBOT
dense jungle
#

^ might as well

flat krakenBOT
elder tusk
#

the isort thing wouldn't be half as bad if..... pre-commit used wheels....

bright glacier
bright glacier
#

I am no way interacting with the pre-commit folks and as it stands there is no way for us to configure the hook installation flow enough to use a wheel from PyPI.

flat krakenBOT
#
ichard26
[psf/black] Pull request review submitted: #3531 Github action now reports state of execution \#3531

Thanks for submitting a PR but as it stands currently, this hurts UX in the general case. This captures the output of the Black invocation and never reemits it. That's already not great, but it gets worse. If Black errors out for some reason, the developer reading the logs will have no idea what's wrong since the logs will be almost entirely empty. There are two ways of fixing this:

  • Reemit the captured output (always or on a non-zero return code; I'd prefer the former)
  • Tee or someho...
bright glacier
#

@dense jungle any objections to requiring packaging unconditionally?

#

I want to merge the infer target-version PR soon (yes, actually).

dense jungle
#

as a runtime dep? I guess it should be fine since it's a light dependency

#

are we going to need a specific version range?

bright glacier
#

We're requiring 22.0 or higher. AFAIK packaging 22.0+ has no dependencies of its own.

#

I'll double check though.

# 
โฏ pip install packaging==22.0
Collecting packaging==22.0
  Using cached packaging-22.0-py3-none-any.whl (42 kB)
Installing collected packages: packaging
  Attempting uninstall: packaging
    Found existing installation: packaging 23.0
    Uninstalling packaging-23.0:
      Successfully uninstalled packaging-23.0
Successfully installed packaging-22.0

Yup. No dependencies, I remembered one thing that happened in the packaging space for once.

#

I mean, I'd prefer less dependencies too, but there aren't any good ways of avoiding it without severely degrading the feature. An extra would help, but its discoverability would be poor. I was also going to say that it could cause issues if some environments have packaging installed and others don't, but that'd be applicable to Black with this feature (aka 23+) vs Black without this feature (aka 23>=) so I dunno.

#

I think eventually, the general hope is that target-version is not configured explicitly for the vast majority of projects so it'd be best to support this by default.

#

FWIW, pytest and tox depend on packaging so it shouldn't be that bad of a dependency to pull in. Since Black is a development tool anyway, it's likely the environment already has packaging installed from some other dev tool. CI/pre-commit is the main place where this doesn't apply, but as packaging is so small it should be negligible.

flat krakenBOT
#
ichard26
[psf/black] Pull request review submitted: #3219 Infer target version based on project metadata

Let's ship this! :ship: There some tweaks that will probably have to be made, but I'm sick of letting this rot anymore. I'll deal with them in follow up PRs.

It'll be really nice to have this in 23.1.0. Thank you so, so, so much @stinodego for baring with me.

@ ichard26 I addressed your comments, I think this handles all cases properly now. Happy to address any other feedback.

I would also be interested in doing some work as a follow-up to make Black use a single target version,...

bright glacier
#

Wait what, attrs doesn't specify Black's target-version? huh maybe that's why CI is failing on the PR...

#

Oh it is the reason why. Great.

#

Hmm okay, we need to tweak the logic in black/parsing.py too.

bright glacier
#

I was really tempted to merge the PR without taking another look at it, but I diff-shades ended up finding one more failure case. Wow this was complicated.

flat krakenBOT
bright glacier
#

Man, looking at the assert-no-changes diff-shades results, django is going to get hammered by the new empty line logic.

# 
โ•ญโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€ Summary โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ•ฎ
โ”‚ 15 projects & 1236 files changed / 4001 changes [+158/-3843] โ”‚
โ”‚                                                              โ”‚
โ”‚ ... out of 2 394 690 lines, 11 482 files & 23 projects       โ”‚
โ•ฐโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ•ฏ

23.1.0 in a nutshell haha

flat krakenBOT
#
gentlegiantJGC
[psf/black] Issue opened: #3535 Threading/Subprocess Permission denied pickle

Describe the bug

I have an odd use case for Black converting Qt Designer UI files to python code and improving the output.

I have found that doing each file in a new thread and calling black in a subprocess speeds up the process a lot.

Occasionally however Black fails to reformat one or more of the files.

`error: cannot format D:\Data\GitHub\Amulet-Editor\src\amulet_editor\plugins\amulet_team_home_page\home\home_home.py: [Errno 13] Permission denied: 'C:\Users\james_000\Ap...

drowsy sonnet
#

packaging >= 22.0 should be relatively safe to depend on. I'll flag that 22.0 removed parsing for non-PEP backed version and whatnot, which triggered some folks to pin to < 22.0

Those things are gonna stop parsing after some time with pip and whatnot, so it's likely OK to just... tell them to not do that.

flat krakenBOT
bright glacier
#

Thanks for chiming in!

cinder ivy
#

Hello, why can't black format strings and docstrings?

bright glacier
#

More context please? What are you trying to format?

glossy oak
#

i have pull request open against black github action (#3531) -- i wonder if anyone here would able to shed some light for windows use-case .. On github public runners the default sys.stdout.encoding is cp1252 .. If i capture the output (and convert to utf-8) - is it safe to still output the utf-8 string buffer as-is or should i convert that into corresponding charset ? on other words, does black honor the default output chararacter encoding when it reports its status after/during the run according to active char encoding or just blindly outputs stuff as utf-8 and hopes everyone will know how to deal with that ?

glossy oak
#

^ never mind .. there was some comments on the pr and im going to rewrite the patch

bright glacier
dense jungle
bright glacier
#

It does change the stable style, but it seems best to do it now than put it off as we are already changing the stable style.

#

Yup, we can move to the 2023 preview style. That also works.

dense jungle
#

yeah I'd rather this go into preview first. Doesn't seem like a common issue, or bad enough to rush a fix

bright glacier
#

I'm going to merge psf/black#3219 in a few hours FYI.

toxic stormBOT
bright glacier
#

It's still failing assert-no-changes for attrs, but that's because of better inference of the target version (leading to the trailing comma being supported). Tying the feature to the preview style wouldn't make sense.

#

I also updated the docs in your 2023 stable style PR FYI.

dense jungle
slow ibex
#

In windows console emojis are replaces with [?] symbols
It is not powershell, it is cmd.exe

image.png
ivory quest
#

basically, cmd is stuck in stoneage era

dense jungle
#

this is a known issue

onyx delta
#

vscode set to format on save. Black seems to be working, and I've adjusted some settings.

But one I don't understand is that in my project README with spaces after list markers. Black seems to change the number of spaces to three vice one.

I suspect I'm missing a simple setting?

dense jungle
#

you are probably using some other formatter

onyx delta
#

Ahhh, good catch. I've never had the problem before and so I assumed it was Black since I had just installed it. But yeah, probably something else got changed in the process with Prettier.

Thanks.

flat krakenBOT
dense jungle
#

I was feeling lucky

#

we may have to do a bit more clean up in the changelog in a separate PR

drowsy sonnet
#

๐ŸŽ‰

bright glacier
bright glacier
#

Hmm, did someone ask a question?

ivory quest
#

I did, but found the answer in FAQ

#

so deleted it to reduce the noise

bright glacier
#

yay the FAQ turned out to be useful

#

I suggested it a long time ago on a hunch it would be useful, but I never got confirmation :>

bright glacier
#

I'll try to get my blog post wrapped up in 20 minutes.

dense jungle
#

anything I can help with?

bright glacier
#

if you're okay with it, landing psf/black#3219

toxic stormBOT
bright glacier
#

otherwise, preparing the 23.1.0 PR (aka clean up the changelog) would be appreciated

dense jungle
#

ok I'll take another look at #3219 and then work on the changelog

flat krakenBOT
bright glacier
#

Normally I'd try to preserve a good commit message before landing a PR, but time is of the essence right now so fair enough ๐Ÿ˜„

flat krakenBOT
lament crow
#

๐Ÿ™ƒ

bright glacier
#

Expectations.

#

Blog post is almost good to go. I'll put it on hold for the time being because it can always come out after the release :)

#

Time to cut 23.1.0 ๐ŸŽ‰

dense jungle
bright glacier
#

I'm waiting for the isort hook to install, but otherwise your PR LGTM Jelle.

lament crow
#

It seems likely that a lot of Americans would believe that about their timezone ๐Ÿ˜„

flat krakenBOT
dense jungle
bright glacier
#

I am Canadian thank you very much x2

lament crow
bright glacier
#

Anyway, so uh, are we missing anything? I think we're good. I wanted to take a look at psf/black#3437, but it seemed like it doesn't crop up often in practice?

toxic stormBOT
bright glacier
dense jungle
# bright glacier Anyway, so uh, are we missing anything? I think we're good. I wanted to take a l...

I can't reproduce what they're saying ```(py311) jelle@m2mb-jelle py % black --version
black, 23.1a1 (compiled: no)
Python (CPython) 3.11.1
(py311) jelle@m2mb-jelle py % black --diff lines.py
--- lines.py 2023-02-01 02:42:44.654093 +0000
+++ lines.py 2023-02-01 02:43:35.755523 +0000
@@ -1,17 +1,12 @@
def run(self):

 while True == self._doingathing:

  •    if False == self._doinganotherthing:

  •        some = code

   if (am - pm) > self._doingthisthing:
       foo = bar

   if (me - you) > self.him:

  •        if self.canUpdate:

  •            while 1 < 2:
               foo += 1

would reformat lines.py

All done! โœจ ๐Ÿฐ โœจ
1 file would be reformatted.

#

this looks fine to me

bright glacier
#

I wonder if the black playground is subtly broken.

#

Wait what, it's formatting differently than how I remembered last night. Ugh whatever.

flat krakenBOT
dense jungle
#

@bright glacier do you want to do the actual release or should I?

bright glacier
#

I don't think it matters? Feel free to do it. I'm still tweaking my blog post

#

I have time if you need to step away though.

dense jungle
#

I will do it

#

should wait for CI on main to finish first though, docker is still running

bright glacier
#

good call

dense jungle
#

ok it's done

flat krakenBOT
bright glacier
#

I did a test run of the mypyc workflow 1-2 days ago and it didn't go red, so it should just work this time. Hopefully.

dense jungle
#

and the macos tags should be for the right platform, right?

bright glacier
lament crow
#

So I guess any fixes (I don't wish you any bugs but if) will go into 23.2.0 then?

dense jungle
#

there's still 5 hours left

#

but yes most likely

bright glacier
#

I'll be asleep in 2 hours.

#

actually probably three

#

CI/CD is green so far, that's good. Phew.

dense jungle
#

and I get the right wheels on both an m2 and an x86_64 Mac

silent apex
#

out of curiosity, why is gofmt in the repository tags for black?

bright glacier
#

I'mma take a short break. I've been sitting for too long. When I come back I'll do some announcements :)

dense jungle
#

I think it's been there since the beginning. The idea was probably that Black would be "gofmt for Python".

silent apex
#

ah, in the opinionated thing. got it.

bright glacier
#

Docs are updated too, that's good.

bright glacier
#

Uhh did we actually make any changes in the 2023 stable style regarding strings? Apparently I noted it as something that got deferred because ESP got deferred in my previous post.

image.png
# 
โฏ black --version && black /tmp/test.py --diff --color -q && black /tmp/test.py --diff --color --preview -q
black, 23.1.0 (compiled: yes)
Python (CPython) 3.8.5
--- /tmp/test.py    2023-02-01 04:05:36.985801 +0000
+++ /tmp/test.py    2023-02-01 04:07:14.765644 +0000
@@ -1,4 +1,4 @@
 some_list = [
-    ' lorem ipsum dolor sit amet consectetur adipiscing elit sed do eiusmod tempor incididunt ut labore et dolore magna aliqua Ut enim ad minim',
-    ' veniam quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo',
+    " lorem ipsum dolor sit amet consectetur adipiscing elit sed do eiusmod tempor incididunt ut labore et dolore magna aliqua Ut enim ad minim",
+    " veniam quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo",
 ]
--- /tmp/test.py    2023-02-01 04:05:36.985801 +0000
+++ /tmp/test.py    2023-02-01 04:07:15.051024 +0000
@@ -1,4 +1,7 @@
 some_list = [
-    ' lorem ipsum dolor sit amet consectetur adipiscing elit sed do eiusmod tempor incididunt ut labore et dolore magna aliqua Ut enim ad minim',
-    ' veniam quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo',
+    (
+        " lorem ipsum dolor sit amet consectetur adipiscing elit sed do eiusmod tempor"
+        " incididunt ut labore et dolore magna aliqua Ut enim ad minim"
+    ),
+    " veniam quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo",
 ]

Shoot, I should've caught this.

#

Well the best we can do is to fix the 23.1.0 changelog during the next release. I'll fix the other places right now.

dense jungle
#

we can also change the release notes

#

in the actual release

bright glacier
#

GitHub Release? Not sure what release notes you're referring to.

dense jungle
#

yes

bright glacier
#

Already fixed. Blog post also fixed.

#

I'm annoyed I didn't catch that in review, but I'm also glad so far this has been the biggest mistake/oversight of arguably the most important release of the year.

#

Thanks a lot for all of the help @dense jungle. We got it in before February 1st even in my part of the world!

flat krakenBOT
trail harbor
#

Hi, I'm using Starlark language (https://bazel.build/rules/language, a dialect of Python) for configuration files in a project.
I tried to run black on one file. It succeeded, but since it's a dialect and not "pure Python", I'm not sure it will work in any case.
My question is: is it safe to use Black to format Starlark files?
Thanks!

cinder ivy
#

And using Pycharm's formatter deforms my docstring. I'm using numpy docstring btw.

flat krakenBOT
#
nijel
[psf/black] Issue opened: #3537 Black is not honoring fmt: off for comment changes

<!--
Please make sure that the bug is not already fixed either in newer versions or the
current development version. To confirm this, you have three options:

  1. Update Black's version if a newer release exists: pip install -U black
  2. Use the online formatter at , which will use
    the latest main branch.
  3. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .[d];
    • run `...
flat krakenBOT
#
ThomasWaldmann
[psf/black] Issue opened: #3538 github actions black run suddenly failing

<!--
Please make sure that the bug is not already fixed either in newer versions or the
current development version. To confirm this, you have three options:

  1. Update Black's version if a newer release exists: pip install -U black
  2. Use the online formatter at , which will use
    the latest main branch.
  3. Or run Black on your machine:
    • create a new virtualenv (make sure it's the same Python version);
    • clone this repository;
    • run pip install -e .[d];
    • run `...
elder tusk
#

you're unlikely to get a guarantee from black, so i'd say if it works it works. from that list of differences i'm not seeing anything that would fail subtly

trail harbor
#

Thanks @elder tusk !

flat krakenBOT
#
Rapptz
[psf/black] Issue opened: #3539 Style editions should be configurable

Is your feature request related to a problem? Please describe.

Black recently released v23.1 which broke CI builds due to needing to reformat everything to the new "2023" style of code (see also: https://github.com/psf/black/issues/3538)

Describe the solution you'd like

I would like to use v23.1 or higher and still maintain my old formatting to reduce churn and friction for new and old contributors to my project. This could be done using something like --style=2023 or `--st...

flat krakenBOT