vale ibex Jul 5, 2022, 10:01 PM

#

oh as in i didn't realise .set still used the deco

vale ibex Jul 5, 2022, 10:28 PM

#

this is very weird

wild prism Jul 5, 2022, 10:29 PM

#

glad to hear it, spent the last two days feeling crazy

vale ibex Jul 5, 2022, 10:31 PM

#

I've managed to get it to work once

#

no idea why

#

steping all the way through it seems fine

wild prism Jul 5, 2022, 10:31 PM

#

you should double check my boilerplate if you haven't, I'm new to redis

#

that's one more than I got

vale ibex Jul 5, 2022, 10:32 PM

#

I ruled out the lock fwiw

#

took that out sicne it was annoying to step through all the time

#

getting same issue

wild prism Jul 5, 2022, 10:34 PM

#

was the success after that?

vale ibex Jul 5, 2022, 10:36 PM

#

the success seems to be whenever I step into the redis call

#

sec I'll show

#

#763406158522220544 if you're free

molten perch Jul 5, 2022, 10:59 PM

#

You got it figured out?

#

I did, just asking.

mellow hare Jul 5, 2022, 11:00 PM

#

https://c.tenor.com/X613sHzCXL8AAAAM/nerds-shouts.gif

#

Carry on

molten perch Jul 5, 2022, 11:02 PM

#

https://gist.github.com/Rapptz/6706e1c8f23ac27c98cee4dd985c8120#interaction-with-aiohttp Same thing applies. But, yeah. Not funny.

gritty wind Jul 5, 2022, 11:26 PM

#

It’s deprecated but still used under the hood for backwards compatibility as I understand

#

It’s part of why I bumped to 1.0

slow boneBOT Jul 6, 2022, 9:21 AM

#

This is not a Modmail thread.

surreal veldt Jul 6, 2022, 9:50 AM

#

So at the time of the message I am replying to, I did the git fetch and git pull commands, and it updated my local files.
But now again the main repo was updated and I pressed fetch upstream on github, and then in vscode I did ```
PS C:\Users\tenuk\ModMail-FAQ> git pull origin
Updating 509795c..e439064
Fast-forward
classes/dropdown.py | 18 +++++++++++++-----
classes/topics.py | 50 ++++++++++++++++++++++++++++++++++++++------------
main.py | 47 ++++++++++++++++++++++++++++++++++-------------
3 files changed, 85 insertions(+), 30 deletions(-)
PS C:\Users\tenuk\ModMail-FAQ>

Even though i did this, my local files don't show the updates

gritty wind Jul 6, 2022, 11:08 AM

#

Are you on the same branch?

surreal veldt Jul 6, 2022, 11:34 AM

#

can you remind me how to check that please?

#

if it's git branch, that shows master

#

i did git fetch origin and git pull origin . Should i replace origin with master?

gritty wind Jul 6, 2022, 11:36 AM

#

Origin is correct

#

Could you link your fork

surreal veldt Jul 6, 2022, 11:38 AM

#

https://github.com/Diabolical5777/ModMail-FAQ

GitHub

GitHub - Diabolical5777/ModMail-FAQ: Simple Discord.py bot for ModM...

Simple Discord.py bot for ModMail support server. Contribute to Diabolical5777/ModMail-FAQ development by creating an account on GitHub.

gritty wind Jul 6, 2022, 11:39 AM

#

Everything looks correct

#

Do you have changes locally

surreal veldt Jul 6, 2022, 11:40 AM

#

Does this help?

gritty wind Jul 6, 2022, 11:40 AM

#

Stash it before pulling

surreal veldt Jul 6, 2022, 11:41 AM

#

is that just git stash?

gritty wind Jul 6, 2022, 11:41 AM

#

Yeah

surreal veldt Jul 6, 2022, 11:42 AM

#

it said No local changes to save

surreal veldt Jul 6, 2022, 11:43 AM

#

surreal veldt Does this help?

should I click on one of these?

#

oh wait

gritty wind Jul 6, 2022, 11:43 AM

#

Try to do git stash -u

surreal veldt Jul 6, 2022, 11:44 AM

#

I jsut realized that the original repo author duplicated a file topics.py and moved one of them to the classes folder, leaving one out (at least locally that's what I see)

austere hornet Jul 6, 2022, 2:03 PM

#

slow bone

?

wild prism Jul 6, 2022, 2:19 PM

#

this isn't a modmail thread

austere hornet Jul 6, 2022, 3:58 PM

#

I know that lol, I was just confused why Modmail sent that

surreal veldt Jul 6, 2022, 3:59 PM

#

I think there are commands specific to ModMail channels and if you use it in another channel it'll send that message

austere hornet Jul 6, 2022, 3:59 PM

#

Right so you think someone ran a Modmail command and deleted the command usage?

#

That would make sense actually

austere hornet Jul 6, 2022, 4:01 PM

#

austere hornet ?

Oh I just realized ? is the bot prefix lmao

#

Anyways, let's get on topic

wild prism Jul 6, 2022, 9:51 PM

#

are there any blockers to using modals in our bots?

vale ibex Jul 6, 2022, 9:58 PM

#

Nope, just that they don't support much atm

#

afaik only select fields can be in modals

wind ruin Jul 6, 2022, 9:58 PM

#

wild prism are there any blockers to using modals in our bots?

do any of them use slash commands / buttons etc yet though?
modals can only be sent in response to these

wind ruin Jul 6, 2022, 9:58 PM

#

vale ibex afaik only select fields can be in modals

also freeform text (both short and long)
edit; only freeform text? or the docs are outdated, idk
https://discord.com/developers/docs/interactions/receiving-and-responding

Support for components in modals is currently limited to type 4 (Text Input).

wild prism Jul 6, 2022, 9:59 PM

#

wind ruin do any of them use slash commands / buttons etc yet though? modals can only be s...

is that the difference between views and modals?

wind ruin Jul 6, 2022, 10:00 PM

#

iirc "views" are a discord.py concept that refers to message components in a normal chat message
"modal" is a term used by discord to refer to actual modal popup windows

winter bone Jul 7, 2022, 11:03 AM

#

Hi. I am a python dev with few months of experience. I am looking to volunteer for startups/ new ideas. Dm me if you are interested working with me.

jolly parcel Jul 7, 2022, 1:34 PM

#

I am looking to contribute to Snexbox possibly. Is there anything that needs to be done, has been requested, or is being worked on that I could assist with?

cold island Jul 7, 2022, 1:38 PM

#

jolly parcel I am looking to contribute to Snexbox possibly. Is there anything that needs to ...

Did you take a look at the repo? If there are approved issues you can ask to be assigned to one, and if there are open pull requests you can try reviewing them

brazen charm Jul 7, 2022, 1:39 PM

#

#dev-contrib message

jolly parcel Jul 7, 2022, 1:43 PM

#

cold island Did you take a look at the repo? If there are approved issues you can ask to be ...

the file IO seems like the most interesting to me atm

gritty wind Jul 7, 2022, 3:53 PM

#

jolly parcel the file IO seems like the most interesting to me atm

Fwiw a lot of snekbox will just be trying to figure out what techniques you can use, discussing them, and getting them approved, more than actually writing code. More than any of our other projects

If you’d like to work on it, go through the issue history, and leave a comment with what you’d like to do

vocal wolf Jul 7, 2022, 3:56 PM

#

@obtuse arrow Hello. What is your status of these PRs? bot#1940, bot#1941

dusky shoreBOT Jul 7, 2022, 3:56 PM

#

GitHub

PROpen Sync Help Cooldown role with help channel claimants
PROpen Check number of available help channels hourly

gritty wind Jul 7, 2022, 3:57 PM

#

Require CPR lol

wild prism Jul 7, 2022, 4:53 PM

#

i have what i think is a strange question:
yesterday my redis container for sir-robin was named sir-robin_redis_1
today it is named sir-robin-redis-1
....why?

cold island Jul 7, 2022, 4:54 PM

#

Uuuh did you update anything?

wild prism Jul 7, 2022, 4:54 PM

#

not that I know of

#

and as far as I can tell im starting them in exactly the same way

gritty wind Jul 7, 2022, 6:02 PM

#

Last time docker updated it was in January, is your install just really out of date :D

#

Either that or the latest version reintroduced a regression, but it’s not listed yet

vale ibex Jul 7, 2022, 6:05 PM

#

wild prism i have what i think is a strange question: yesterday my redis container for sir-...

docker-compose uses underscores docker compose uses hyphens

gritty wind Jul 7, 2022, 6:05 PM

#

(Related to an older discussion: it’s specifically a regression in docker compose vs docker-compose)

#

Yup

wild prism Jul 7, 2022, 6:07 PM

#

vale ibex `docker-compose` uses underscores `docker compose` uses hyphens

mmm I've been using docker-compose the whole time

vale ibex Jul 7, 2022, 6:07 PM

#

might have done docker compose once and then the image names have stuck if you didn't do down

#

EG you did docker compose the first time creating the container and docker-compose since

#

it'll retain the hyphens

wild prism Jul 7, 2022, 6:09 PM

#

if you do up --build does it retain the container names?

vale ibex Jul 7, 2022, 6:09 PM

#

yea afaik

#

would be easy to test though

#

I can't atm

wild prism Jul 7, 2022, 6:10 PM

#

hmm maybe i used docker compose at some point yesterday, but literally

Set-Alias -Name "dc" -Value "docker-compose"
```is in my profile

gritty wind Jul 7, 2022, 6:10 PM

#

Alias docker-compose to the space version and you’ll never have issues again 😋

vale ibex Jul 7, 2022, 6:10 PM

#

gritty wind Alias docker-compose to the space version and you’ll never have issues again 😋

I refuse to use go software

gritty wind Jul 7, 2022, 6:11 PM

#

Lmao

vale ibex Jul 7, 2022, 6:11 PM

#

I'll stay on my deprecated v1 branch

#

kek

gritty wind Jul 7, 2022, 6:11 PM

#

I just learned v1 is written in python while looking this up

vale ibex Jul 7, 2022, 6:11 PM

#

yea dude

gritty wind Jul 7, 2022, 6:11 PM

#

We need to revert

#

Downgrade all our composes plz and thx

vale ibex Jul 7, 2022, 6:12 PM

#

version number is irrelevant anyways, it's only for backwards compat

#

it's ignored in latest versions of compose

wild prism Jul 7, 2022, 6:12 PM

#

- Set-Alias -Name "dc" -Value "docker-compose"
+ Set-Alias -Name "dc" -Value "docker compose"
```because dashes are slightly easier to type

vale ibex Jul 7, 2022, 6:12 PM

#

lol

gritty wind Jul 7, 2022, 6:13 PM

#

👌

gritty wind Jul 8, 2022, 1:24 PM

#

Pycharm's docker interpreter support is simultaneously some of the most amazing and janky shit I've ever seen

#

Making it work is impossible, but when it does work

#

It's oh so sweet

cold island Jul 8, 2022, 2:33 PM

#

anything in pycharm related to docker and ssh is like that

#

I'm using VSC for the sole reason that I can't be assed to make ssh work properly in pycharm

molten perch Jul 8, 2022, 2:48 PM

#

You run the projects on an external server? 😄

gritty wind Jul 8, 2022, 3:05 PM

#

It’s snekbox

#

And good luck running that anywhere lol

cold island Jul 8, 2022, 3:16 PM

#

how do I rebase one commit at a time? like I have 5 commits I want to rebase, and I want to take one at a time and adjust it to the new base

wild prism Jul 8, 2022, 3:17 PM

#

like cherry-picking?

gritty wind Jul 8, 2022, 3:21 PM

#

Do an interactive rebase and set everything to edit

cold island Jul 8, 2022, 3:21 PM

#

Yeah I think interactive is what I'm looking for

thorny obsidian Jul 8, 2022, 11:16 PM

#

@brazen charm Question for you re:tag group + improvements stuff: Are the supported tag metadata found anywhere else besides the __init__ in the Tag class in tags.py?

From the PR I see you implemented embed and restricted, but I'm not sure if I'm missing any others.

brazen charm Jul 8, 2022, 11:20 PM

#

I don't believe any others are used. It should all be in the class for the tag so if it's not there, it's unused

surreal veldt Jul 9, 2022, 11:09 AM

#

Can the docs command support the fishhook library?

placid ermine Jul 9, 2022, 11:29 AM

#

surreal veldt Can the docs command support the fishhook library?

i don't think there's a documentation website for it

#

apart from the readme

#

which makes sense because there's like 2 public functions

outer oasis Jul 9, 2022, 11:43 AM

#

placid ermine which makes sense because there's like 2 public functions

Hmm
Could the two examples in the README fit in a tag?

outer oasis Jul 9, 2022, 2:48 PM

#

Can I get some feedback on sir-lancebot#1070 ?
I literally just stole the implementation from !remind

dusky shoreBOT Jul 9, 2022, 2:48 PM

#

GitHub

PROpen update .uwu to work with replies

vale ibex Jul 9, 2022, 2:50 PM

#

text = text or getattr(ctx.message.reference, "resolved", None)
if text is None:
    raise commands.UserInputError("Your message must have content or you must reply to a message.")
``` would this work instead?

#

I came across that logic when i was refactoring the bookmark cog myself

#

sir-lancebot#1049

dusky shoreBOT Jul 9, 2022, 2:51 PM

#

GitHub

PROpen Bookmark enhancements

vale ibex Jul 9, 2022, 2:52 PM

#

speaking of, @timid sentinel I have only now seen your suggestion. should I commit this to that branch or were you planning to pr that yourself?

outer oasis Jul 9, 2022, 2:53 PM

#

vale ibex ```py text = text or getattr(ctx.message.reference, "resolved", None) if text is...

Absolutely no idea
I've never used dpy before

#

I can give it a shot

vale ibex Jul 9, 2022, 2:54 PM

#

outer oasis Absolutely no idea I've never used dpy before

ctx.message.refernce is always present, just sometimes None

#

getattr(None, "foo", False) would return False

#

so getattr(ctx.message.reference, "resolved", None) either returns ctx.message.reference.resolved if present, or None

outer oasis Jul 9, 2022, 2:55 PM

#

I see

#

Can you give me a quick summary of Scale's comment on the issue?
I get the idea but I don't know how to actually call clean_content on a str

#

Oh hi Scale

gritty wind Jul 9, 2022, 2:57 PM

#

The general way converters work in d.py

#

They are classes

#

So you just call await clean_content(settings).convert(ctx, str)

#

But it will raise exceptions

#

I think you can safely let them propagate though

vale ibex Jul 9, 2022, 2:58 PM

#

Would ```
t.Optional[clean_content(fix_channel_mentions=True)] = None

#

I've never tried it 😅

gritty wind Jul 9, 2022, 2:58 PM

#

Possibly, but it won't fix the reply content

outer oasis Jul 9, 2022, 2:58 PM

#

Let's find out

#

Nevermind then

vale ibex Jul 9, 2022, 2:58 PM

#

ah yea true

vale ibex Jul 9, 2022, 2:59 PM

#

vale ibex ```py text = text or getattr(ctx.message.reference, "resolved", None) if text is...

you'd do that after this

gritty wind Jul 9, 2022, 2:59 PM

#

vale ibex ```py text = text or getattr(ctx.message.reference, "resolved", None) if text is...

Ideally you stick it under this lol

#

Jinx

vale ibex Jul 9, 2022, 2:59 PM

#

I instinctively started typing out a mute

#

then stopped myself kek

gritty wind Jul 9, 2022, 2:59 PM

#

Lmao

#

No one would be able to stop you 👀

vale ibex Jul 9, 2022, 2:59 PM

#

@thorny obsidian would have words though

thorny obsidian Jul 9, 2022, 3:00 PM

#

lemonshake I may not be an admin anymore but my wrath has not waned

outer oasis Jul 9, 2022, 3:00 PM

#

vale ibex ```py text = text or getattr(ctx.message.reference, "resolved", None) if text is...

So... text stayst.Optional[str], and then call clean_content this?

vale ibex Jul 9, 2022, 3:00 PM

#

yea

outer oasis Jul 9, 2022, 3:00 PM

#

👍

vale ibex Jul 9, 2022, 3:01 PM

#

raise commands.UserInputError("...") works because we have a global error handler that deals with this error and handles it nicely

outer oasis Jul 9, 2022, 3:05 PM

#

Hmmm

#

sir-lancebot    | 2022-07-09 15:04:03 | bot.exts.core.error_handler | ERROR | Unhandled command error: expected string or bytes-like object
sir-lancebot    | Traceback (most recent call last):
sir-lancebot    |   File "/usr/local/lib/python3.9/site-packages/discord/ext/commands/core.py", line 167, in wrapped
sir-lancebot    |     ret = await coro(*args, **kwargs)
sir-lancebot    |   File "/bot/bot/exts/fun/uwu.py", line 123, in uwu_command
sir-lancebot    |     await clean_content(fix_channel_mentions=True).convert(ctx, text)
sir-lancebot    |   File "/usr/local/lib/python3.9/site-packages/discord/ext/commands/converter.py", line 945, in convert
sir-lancebot    |     result = re.sub(r'<(@[!&]?|#)([0-9]{15,20})>', repl, argument)
sir-lancebot    |   File "/usr/local/lib/python3.9/re.py", line 210, in sub
sir-lancebot    |     return _compile(pattern, flags).sub(repl, string, count)
sir-lancebot    | TypeError: expected string or bytes-like object

#

I ducked up the clean_content

gritty wind Jul 9, 2022, 3:06 PM

#

Where did you put it?

outer oasis Jul 9, 2022, 3:06 PM

#

text = text or getattr(ctx.message.reference, "resolved", None)
if text is None:
  # If we weren't able to get the content of a replied message
  raise commands.UserInputError("Your message must have content or you must reply to a message.")

await clean_content(fix_channel_mentions=True).convert(ctx, text)

vale ibex Jul 9, 2022, 3:06 PM

#

Ah, yea getattr(ctx.message.reference, "resolved", None) will return the message, not the message content

gritty wind Jul 9, 2022, 3:07 PM

#

For a second I though I’d have to admit I have no idea what I’m doing

#

But Chris with the save

vale ibex Jul 9, 2022, 3:08 PM

#

getattr(ctx.message.reference, "resolved.content", None) might work

#

no idea if getattr can do a second level like that

#

I'm guessing not

outer oasis Jul 9, 2022, 3:09 PM

#

guess not

#

not it's not seeing it

#

getattr(getattr(ctx.message.reference, "resolved", None), "content", None)
```?

#

Seems to work

vale ibex Jul 9, 2022, 3:11 PM

#

yea, just a little complicated for one line lol

outer oasis Jul 9, 2022, 3:11 PM

#

Yeah
Back to the original and just leave it there then?

vale ibex Jul 9, 2022, 3:12 PM

#

text = text or getattr(ctx.message.reference, "resolved", None)
if text is None:
  # If we weren't able to get the content of a replied message
  raise commands.UserInputError("Your message must have content or you must reply to a message.")
elif isinstance(text, discord.Message):
  text = text.content 

await clean_content(fix_channel_mentions=True).convert(ctx, text)

#

maybe the other way around ```py
text = text or getattr(ctx.message.reference, "resolved", None)
if isinstance(text, discord.Message):
text = text.content

if text is None:

If we weren't able to get the content of a replied message

raise commands.UserInputError("Your message must have content or you must reply to a message.")

await clean_content(fix_channel_mentions=True).convert(ctx, text)

outer oasis Jul 9, 2022, 3:14 PM

#

vale ibex maybe the other way around ```py text = text or getattr(ctx.message.reference, "...

I'm okay with this, it's pretty clean

#

How does it look now?

vale ibex Jul 9, 2022, 3:18 PM

#

looks good

outer oasis Jul 9, 2022, 3:21 PM

#

👍
Then unless there's anything else I need to do, I declare my services fulfilled

vale ibex Jul 9, 2022, 3:22 PM

#

hah thanks, I'll give it a test once i've sorted metricity

gritty wind Jul 9, 2022, 3:22 PM

#

Does the converter cause issues when it raises exceptions?

#

If not, I think we should be good 👍

outer oasis Jul 9, 2022, 3:24 PM

#

gritty wind Does the converter cause issues when it raises exceptions?

No idea
It's my first day

vale ibex Jul 9, 2022, 3:24 PM

#

try to uwu a role ping

#

or channel ping

gritty wind Jul 9, 2022, 3:24 PM

#

Lmfao

outer oasis Jul 9, 2022, 3:24 PM

#

But after using Chris' snippet, I get pretty errors

gritty wind Jul 9, 2022, 3:24 PM

#

@everyone uwu

outer oasis Jul 9, 2022, 3:25 PM

#

gritty wind Jul 9, 2022, 3:25 PM

#

Hahaha that's perfect

vale ibex Jul 9, 2022, 3:25 PM

#

lol nice

gritty wind Jul 9, 2022, 3:27 PM

#

I wonder what happens if I reply to an image

vale ibex Jul 9, 2022, 3:28 PM

#

it should error

vale ibex Jul 9, 2022, 3:28 PM

#

vale ibex maybe the other way around ```py text = text or getattr(ctx.message.reference, "...

it's why I swapped these around lol

outer oasis Jul 9, 2022, 3:28 PM

#

Should hit the "no text provided" UserInputError?

vale ibex Jul 9, 2022, 3:28 PM

#

ye

wild prism Jul 9, 2022, 3:29 PM

#

why are we not uwuifying images???

gritty wind Jul 9, 2022, 3:29 PM

#

vale ibex it's why I swapped these around lol

.uwu

dusky shoreBOT Jul 9, 2022, 3:29 PM

#

it's w-why i swapped these a-awound wow

gritty wind Jul 9, 2022, 3:29 PM

#

wild prism why are we not uwuifying images???

Be the change

outer oasis Jul 9, 2022, 3:29 PM

#

dusky shore >>> it's w-why i swapped these a-awound wow

@thorny obsidian it is done

gritty wind Jul 9, 2022, 3:29 PM

#

lmfao just put an uwu over it

outer oasis Jul 9, 2022, 3:31 PM

#

Also - Just to confirm, there's no issues with me creating branches directly on the repo, [as opposed to forking] right?

gritty wind Jul 9, 2022, 3:32 PM

#

Yeah

#

Uhh

#

Where would one put a new route in the site api

#

These all seem to be views

#

Oh I think I figured it out

thorny obsidian Jul 9, 2022, 4:00 PM

#

outer oasis <@212644551926611969> it is done

LMFAO this is amazing, thank you shenanigans

#

I'm going to write a changelog for this and no one can stop me

thorny obsidian Jul 9, 2022, 4:03 PM

#

outer oasis Also - Just to confirm, there's no issues with me creating branches directly on ...

One of the perks of being staff~

gritty wind Jul 9, 2022, 4:35 PM

#

Can I make an HTTP request within an api view method in DRF? It's really hard to look up info because of the name conflict...

#

I did find one SO post which just said use requests (the library), does that cause issues

vale ibex Jul 9, 2022, 4:50 PM

#

Take a look how the github stats are done on the homepage

#

That should be similar

gritty wind Jul 9, 2022, 4:56 PM

#

It's a request with a custom timeout

#

Is the timeout necessary?

vale ibex Jul 9, 2022, 5:08 PM

#

Yea, otherwise it'll block the worker

gritty wind Jul 9, 2022, 5:09 PM

#

I feel like the solution here is to not use requests

#

I've seen that DRF supports async views, and I had already upgraded to httpx for other reasons 👀

vale ibex Jul 9, 2022, 5:21 PM

#

beyond my paygrade with drf lol

#

httpx good

vale ibex Jul 9, 2022, 6:30 PM

#

bot-core#98 tiny bug fix

dusky shoreBOT Jul 9, 2022, 6:30 PM

#

GitHub

PROpen Only close stats._transport if BotBase.stats was created

gritty wind Jul 9, 2022, 6:30 PM

#

Lighting fast

#

Feel free to merge

#

(once actions are done)

vale ibex Jul 9, 2022, 6:31 PM

#

tyty

vocal wolf Jul 9, 2022, 7:35 PM

#

@fallen patrol Hello. sir-lancebot#982 sir-lancebot#981 questionmark?

dusky shoreBOT Jul 9, 2022, 7:35 PM

#

GitHub

PROpen fix: subcommands inherit their parent's whitelist
PROpen Interaction tic tac toe

fallen patrol Jul 9, 2022, 8:02 PM

#

the second one was just supposed to be a retrofit, i didn't want to modify much of the original author's code

#

updated the first one

gritty wind Jul 9, 2022, 8:22 PM

#

Mark you're good to merge snekbox#147

dusky shoreBOT Jul 9, 2022, 8:22 PM

#

GitHub

PROpen Create v1 cgroups as needed

gritty wind Jul 9, 2022, 8:22 PM

#

Thanks for accommodating my messed up needs lol

tawdry vapor Jul 9, 2022, 8:50 PM

#

ty for reviewing

vale ibex Jul 9, 2022, 9:02 PM

#

https://github.com/python-discord/metricity/commit/e4491be7b5d2e2c865a6e161c6ced192e188beea ty @gritty wind

gritty wind Jul 9, 2022, 9:02 PM

#

😎

#

Still waiting for poetry to fix an ancient bug to add support for poetry versions 😔

vale ibex Jul 9, 2022, 9:03 PM

#

sad

#

metricity#18 includes quite a large refactor, I've added (what I think to be) some useful instructions for people who get some time to test it out :)

dusky shoreBOT Jul 9, 2022, 9:04 PM

#

GitHub

PROpen Migrate to botcore & extensions

gritty wind Jul 9, 2022, 9:07 PM

#

Lmfao

vale ibex Jul 9, 2022, 9:07 PM

#

lol I was getting worried why it was taking so long

#

time to add .cache to the ignore

#

casual 170k line flake8 output

gritty wind Jul 9, 2022, 9:08 PM

#

Normal friday

#

It is Saturday

#

Do we not need the flake8 annotations action anymore?

vale ibex Jul 9, 2022, 9:09 PM

#

shouldn't do, since it's a dev dep

gritty wind Jul 9, 2022, 9:09 PM

#

Oh cool

#

Btw you crashed my browser

#

Thanks

vale ibex Jul 9, 2022, 9:09 PM

#

not entirely sure what it was doing fwiw

#

it isn't in any of our other linting flows

#

and i didn't add annotations as a dev dep in this pr

gritty wind Jul 9, 2022, 9:14 PM

#

Chris chris chris

#

It doesn't start

#

Please fix

slate gorge Jul 9, 2022, 9:15 PM

#

vale ibex and i didn't add annotations as a dev dep in this pr

and i didn't add annotations

vale ibex Jul 9, 2022, 9:15 PM

#

slate gorge > and i didn't add annotations

?

slate gorge Jul 9, 2022, 9:15 PM

#

vale ibex ?

guess imma add em

vale ibex Jul 9, 2022, 9:15 PM

#

I was referring to flake8-annotations, please read the context.

gritty wind Jul 9, 2022, 9:15 PM

#

They are already there :D

slate gorge Jul 9, 2022, 9:15 PM

#

gritty wind They are already there \:D

nice

gritty wind Jul 9, 2022, 9:16 PM

#

What are we talking about

vale ibex Jul 9, 2022, 9:16 PM

#

gritty wind It doesn't start

starts fine for me?? 🤔

#

are you using docker?

gritty wind Jul 9, 2022, 9:16 PM

#

Lol dw it's the dpy update bug

vale ibex Jul 9, 2022, 9:16 PM

#

oh lol

#

get good

gritty wind Jul 9, 2022, 9:16 PM

#

Could we get dotenv

vale ibex Jul 9, 2022, 9:16 PM

#

no

slate gorge Jul 9, 2022, 9:16 PM

#

just came to ask a question, could i clone the repos for my own bot?

gritty wind Jul 9, 2022, 9:16 PM

#

Thanks

vale ibex Jul 9, 2022, 9:16 PM

#

use docker

#

thanks

vale ibex Jul 9, 2022, 9:17 PM

#

slate gorge just came to ask a question, could i clone the repos for my own bot?

all our bots are MIT licensed

slate gorge Jul 9, 2022, 9:17 PM

#

great

vale ibex Jul 9, 2022, 9:17 PM

#

gritty wind Could we get dotenv

i'm adding it now btw

#

don't get too annoyed

#

ty

gritty wind Jul 9, 2022, 9:17 PM

#

Lmao

#

Pycharm used to have a really nice plugin to auto-load them

#

But it stopped getting updatees 😔

#

Wait I know what my next project is 🌝

vale ibex Jul 9, 2022, 9:18 PM

#

wait, it's already here

gritty wind Jul 9, 2022, 9:18 PM

#

Lmao

#

I bet if you git blame, it's gonna be me too

vale ibex Jul 9, 2022, 9:18 PM

#

yea, it's a prod dep lol

gritty wind Jul 9, 2022, 9:18 PM

#

I wonder what's up with my thing

vale ibex Jul 9, 2022, 9:19 PM

#

gritty wind I bet if you git blame, it's gonna be me too

you're safe this time

gritty wind Jul 9, 2022, 9:19 PM

#

Thank

#

Oh I refreshed my token because of discord's stupid token thing

#

Lmao big brain

vale ibex Jul 9, 2022, 9:20 PM

#

lol

gritty wind Jul 9, 2022, 9:44 PM

#

Alright, I've managed to start the bot

#

That's a good sign, approved

vale ibex Jul 9, 2022, 9:44 PM

#

KomodoHype

gritty wind Jul 9, 2022, 9:48 PM

#

before vs after. Is this code optimization?

vale ibex Jul 9, 2022, 9:49 PM

#

i fixed

gritty wind Jul 9, 2022, 10:15 PM

#

Oh cool we're doing voice channels now?

vale ibex Jul 9, 2022, 10:16 PM

#

yeyeyey

#

the main reason I did metricity now

#

@viscid badge doesn't like text-in-voice right now

gritty wind Jul 9, 2022, 10:20 PM

#

https://github.com/python-discord/metricity/blob/21212e5e2e03414a824d6136112bb9414d3964c1/metricity/exts/event_listeners/_utils.py#L39

stable mountainBOT Jul 9, 2022, 10:20 PM

#

metricity/exts/event_listeners/_utils.py line 39

if not await models.Thread.get(str(thread.id)):```

gritty wind Jul 9, 2022, 10:20 PM

#

When would this be true

#

Shouldn't the listener catch it

vale ibex Jul 9, 2022, 10:21 PM

#

iirc this was a fix in case the message event was handled before the thread create event

gritty wind Jul 9, 2022, 10:21 PM

#

Cool cool

#

How long have you been working on this

#

There's so much stuff

vale ibex Jul 9, 2022, 10:22 PM

#

gritty wind How long have you been working on this

there's not that much

#

it's all from bot.py

#

just moved to Cogs

gritty wind Jul 9, 2022, 10:22 PM

#

Yeah my review strategy is copy the old content in and see the diff 🤡

vale ibex Jul 9, 2022, 10:22 PM

#

ah lol

#

there's a few small changes in there, but it's mostly copy-paste

gritty wind Jul 9, 2022, 10:22 PM

#

But no, I rather meant there's a bunch of hidden small stuff like that

#

Ye ye

vale ibex Jul 9, 2022, 10:22 PM

#

Yea

#

https://github.com/python-discord/metricity/blob/botcore-migration/metricity/exts/event_listeners/message_listeners.py#L30

stable mountainBOT Jul 9, 2022, 10:23 PM

#

metricity/exts/event_listeners/message_listeners.py line 30

if message.type in (discord.MessageType.thread_created, discord.MessageType.auto_moderation_action):```

vale ibex Jul 9, 2022, 10:23 PM

#

stable mountain `metricity/exts/event_listeners/_utils.py` line 39 ```py if not await models.Thr...

the first part of this should deal with that actually

#

it's easy to test too

vale ibex Jul 9, 2022, 10:24 PM

#

stable mountain `metricity/exts/event_listeners/_utils.py` line 39 ```py if not await models.Thr...

just remove this and make a new thread

gritty wind Jul 9, 2022, 10:25 PM

#

Alright, I think that's everything

vale ibex Jul 9, 2022, 10:25 PM

#

Yea, I was right, it's not needed, since I also guarded against that in the on_message listener

gritty wind Jul 9, 2022, 10:25 PM

#

Sick

vale ibex Jul 9, 2022, 10:26 PM

#

can also remove ```py
if from_thread and not message.channel.parent:
# This is a forum channel, not currently supported by Discord.py. Ignore it.
return

gritty wind Jul 9, 2022, 10:26 PM

#

Doesn't it make more sense to do the opposite to avoid forcing a blocking sync

vale ibex Jul 9, 2022, 10:26 PM

#

since they are supported now

#

wdym do the opposite?

gritty wind Jul 9, 2022, 10:27 PM

#

As in, don't handle thread creation in on_channel_update, and instead handle it in on_message

vale ibex Jul 9, 2022, 10:27 PM

#

thread creation has it's own event

gritty wind Jul 9, 2022, 10:27 PM

#

Oh

vale ibex Jul 9, 2022, 10:27 PM

#

it's just that it also sends a message event

gritty wind Jul 9, 2022, 10:27 PM

#

No I mean the event generates a full sync

vale ibex Jul 9, 2022, 10:27 PM

#

since the thread opener is also the first message in the thread

gritty wind Jul 9, 2022, 10:27 PM

#

As opposed to the message which just syncs the thread

#

Ultimately it's fine, I don't think the sync is that long

vale ibex Jul 9, 2022, 10:28 PM

#

yea, the standard seemed to be sync everything when a new channel is created

#

so I did the same for threads

gritty wind Jul 9, 2022, 10:28 PM

#

Alright, that's fine

vale ibex Jul 9, 2022, 10:29 PM

#

pushed a commit to remove those two guards

gritty wind Jul 9, 2022, 10:29 PM

#

How on earth did my suggestion auto resolve itself haha

#

Noice, that looks good

#

Dude the linting is lighting quick

vale ibex Jul 9, 2022, 10:30 PM

#

yea it's nice

gritty wind Jul 9, 2022, 10:30 PM

#

PR cache 💪

vale ibex Jul 9, 2022, 10:30 PM

#

I'm gonna add concurrency rules to the workflows too

#

pushed

gritty wind Jul 9, 2022, 10:34 PM

#

I'm approving, if you're happy with it, you're welcome to merge

vale ibex Jul 9, 2022, 10:35 PM

#

guess we'll find out

gritty wind Jul 9, 2022, 10:35 PM

#

Lol

vale ibex Jul 9, 2022, 10:36 PM

#

lol just noticed the deploy action doesn't wait for the lint action

#

very nice

gritty wind Jul 9, 2022, 10:36 PM

#

We never merge bad code to metricity

vale ibex Jul 9, 2022, 10:36 PM

#

@viscid badge status

gritty wind Jul 9, 2022, 10:36 PM

#

Give it a minute

vale ibex Jul 9, 2022, 10:36 PM

#

ye

gritty wind Jul 9, 2022, 10:37 PM

#

Docker desktop updated it's UI

#

It's so shit

vale ibex Jul 9, 2022, 10:37 PM

#

@viscid badge status

viscid badgeBOT Jul 9, 2022, 10:37 PM

#

Status

Hello, I'm Dave. I insert all your data into a GDPR-compliant database.

Command processing time

31156.927 ms

Last event received

<t:1657406233>

Discord API latency

9355.926 ms

#

Status

Hello, I'm Dave. I insert all your data into a GDPR-compliant database.

Command processing time

3808.356 ms

Last event received

<t:1657406233>

Discord API latency

9355.926 ms

vale ibex Jul 9, 2022, 10:37 PM

#

nice

gritty wind Jul 9, 2022, 10:37 PM

#

Yeee

#

31000 ms

#

Top notch dev-ops here

vale ibex Jul 9, 2022, 10:37 PM

#

got that dialup

molten perch Jul 9, 2022, 10:44 PM

#

Hey 👋 , if anyone is interested sir-robin#49 is waiting for reviews. It's not that big, most of the things were ported over from bot, and were tested previously.

dusky shoreBOT Jul 9, 2022, 10:44 PM

#

GitHub

PROpen Integrate Code Jam Management into Sir Robin's CJ Extension

vale ibex Jul 9, 2022, 11:02 PM

#

will take a look tomorrow

gritty wind Jul 9, 2022, 11:58 PM

#

The site test suite took ~4 minutes to run

#

Then pycharm reported it as 8s

#

Thanks pycharm

vale ibex Jul 10, 2022, 12:02 AM

#

very good

#

pycharm is fast

#

just look at the performance tests!

green oriole Jul 10, 2022, 12:22 AM

#

Hey funny devops men

#

Where is graphite data being pushed to?

#

Is it all stored by graphite?

#

I see it has a PVC

vale ibex Jul 10, 2022, 12:26 AM

#

Yea, graphite stores it

gritty wind Jul 10, 2022, 12:44 AM

#

Hm, well I've spent some time getting pytest working

#

Well, it does, but it still takes 1:14 minutes

#

Even with no migrations

#

To be fair, it's creating 8 databases lol

gritty wind Jul 10, 2022, 1:22 AM

#

I've gotta go to bed here, but in the mean time I'll drop my latest issue here. I've more or less setup pytest on site, but I'm having issues with the migrations.

If I completely disable them, the tests which test the migrations fail. If I enable them, they seem to run twice. I'm not sure how it's managing to bypass django's safety checks. I know for sure it's definitely migrated after the first time. I can open the database, and browse it. The migrations table is set correctly, and it's all there.

Running the migrations twice however is problematic, since the migrations make normally safe assumptions that we can't guarantee anymore

#

If it means anything, it fails on/after migration 47, and complains that:

    sql = 'SELECT DISTINCT "api_user"."id", "api_user"."name", "api_user"."discriminator", "api_user"."avatar_hash", "api_user"....raction"."active" AND "api_infraction"."type" = %s) GROUP BY "api_user"."id" HAVING COUNT("api_infraction"."id") >= %s'
params = ('ban', 2), ignored_wrapper_args = (False, {'connection': <django.db.backends.postgresql.base.DatabaseWrapper object at 0x0000018EE7EB4430>, 'cursor': <django.db.backends.utils.CursorWrapper object at 0x0000018EE92727F0>})

    def _execute(self, sql, params, *ignored_wrapper_args):
        self.db.validate_no_broken_transaction()
        with self.db.wrap_database_errors:
            if params is None:
                # params default might be backend specific.
                return self.cursor.execute(sql)
            else:
>               return self.cursor.execute(sql, params)
E               django.db.utils.ProgrammingError: column api_user.avatar_hash does not exist
E               LINE 1: ...", "api_user"."name", "api_user"."discriminator", "api_user"...
E                                                                            ^

green oriole Jul 10, 2022, 11:26 AM

#

Would it be possible the manage.py and the tests each run them?

gritty wind Jul 10, 2022, 12:41 PM

#

The manage would've just been calling the django runner anyway, but the pytest integration bypasses the manage anyway

surreal veldt Jul 10, 2022, 12:45 PM

#

@brisk brook would you have an update on site#702?

dusky shoreBOT Jul 10, 2022, 12:45 PM

#

GitHub

IssueClosed Username, discriminator, and avatar changes are not synced with the database

surreal veldt Jul 10, 2022, 12:45 PM

#

site#702 *

dusky shoreBOT Jul 10, 2022, 12:45 PM

#

GitHub

PROpen Subclassing bot

gritty wind Jul 10, 2022, 12:48 PM

#

gritty wind The manage would've just been calling the django runner anyway, but the pytest i...

The extension does allow you to add a custom runner which does go through the manage, but that has the same problem

brisk brook Jul 10, 2022, 3:31 PM

#

surreal veldt <@344404945359077377> would you have an update on site#702?

I don't have more comments no. Please address the comments I have made though. Can you go through all the currently unresolved ones and either leave a response or mark them resolved? Assuming you do not want to apply the feedback they include

vale ibex Jul 10, 2022, 8:43 PM

#

metricity#20 fairly small pr

dusky shoreBOT Jul 10, 2022, 8:43 PM

#

GitHub

PROpen Add support for staff channels that are not in staff categories

outer oasis Jul 10, 2022, 8:57 PM

#

vale ibex metricity#20 fairly small pr

I just noticed - Why doesn't @viscid badge have a review policy?

vale ibex Jul 10, 2022, 8:58 PM

#

guess it was just never added

gritty wind Jul 10, 2022, 8:58 PM

#

Our smaller projects don't use them

vale ibex Jul 10, 2022, 8:58 PM

#

it does require 1 member to approve before merging

gritty wind Jul 10, 2022, 8:58 PM

#

Because the builtin tools work better

gritty wind Jul 10, 2022, 10:03 PM

#

So uhhhh who understands how the site's migration tests work 👀

#

Some of these use the current model, and a historical model at the same time, which creates conflicts when any fields are added or removed

#

Yet it works somehow

#

But bumping django from 3.1 to 3.2 breaks it

#

For reference, this stuff has not been touched since 2019 lol

#

I found the PR that introduced this: site#278

dusky shoreBOT Jul 10, 2022, 10:09 PM

#

GitHub

PRMerged Validation for active infractions

gritty wind Jul 10, 2022, 10:09 PM

#

Since a migration is really snapshot in time of the migration history, this also allows us to work with the database models as they were at those two time points in the migration history (directly before and directly after applying this migration), since otherwise these tests will fail in the future if we decide to change the models.
This must be no longer true

cold island Jul 10, 2022, 10:28 PM

#

migration tests?

gritty wind Jul 10, 2022, 10:28 PM

#

We have some tests that ensure that a migration worked as expected

#

Which is... kind of strange considering migrations are historical and unchanging

#

To test the effect of the migration file, I've created a subclass of django.test.TestCase, MigrationsTestCase, that reverts the test database to the migration just prior to the one of interest. We can then inject test data, apply the migration, and test if the migration had the desired effect.

molten perch Jul 10, 2022, 10:30 PM

#

And this test breaks when bumping to 3.2? What's the error?

gritty wind Jul 10, 2022, 10:32 PM

#

The latest (current) model introduces a field, which did not exist at the time of this migration. In theory according to the comment above, this shouldn't matter because we are only using the model at the provided migration. This was true on django 3.1. For whatever reason though, bumping to 3.2 has made it so that when the test itself runs, it is using the latest model.

#

The weirdest part though

#

The creation of the object itself is done before the test starts, and that's created correctly. But for some reason between the setup function and the test itself, it has updated the model, and somehow updated the old objects

#

The exception itself isn't super useful here, as it show's what's wrong, not the root cause, but here it is:

Failure
Traceback (most recent call last):
  File "C:\Users\hassa\AppData\Local\pypoetry\Cache\virtualenvs\site-xCgAncD9-py3.9\lib\site-packages\django\db\backends\utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
psycopg2.errors.UndefinedColumn: column api_infraction.dm_sent does not exist
LINE 1: SELECT "api_infraction"."id", "api_infraction"."dm_sent" FRO...

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Github\PyDis\site\pydis_site\apps\api\tests\migrations\test_active_infraction_migration.py", line 451, in test_migration_leaves_user_with_one_active_ban_untouched
    x = model_to_dict(infraction)
...
  File "C:\Users\hassa\AppData\Local\pypoetry\Cache\virtualenvs\site-xCgAncD9-py3.9\lib\site-packages\django\db\backends\utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
django.db.utils.ProgrammingError: column api_infraction.dm_sent does not exist
LINE 1: SELECT "api_infraction"."id", "api_infraction"."dm_sent" FRO...

#

I've omitted a bit of the traceback (the portion which goes into django internals), but the rest of the cropping (FRO...) is what the traceback actually looks like

cold island Jul 10, 2022, 10:37 PM

#

It also has tests for the tests

gritty wind Jul 10, 2022, 10:37 PM

#

It's tests all the way down baby

cold island Jul 10, 2022, 10:38 PM

#

We never added anything beyond the tests for that specific migration

gritty wind Jul 10, 2022, 10:38 PM

#

I'm contemplating just... removing them

#

These are the same tests which seem to be breaking my pytest work too

cold island Jul 10, 2022, 10:38 PM

#

We can ask for Sebastiaan's opinion tomorrow, but yeah I am too

molten perch Jul 10, 2022, 10:38 PM

#

I'm currently checking out the release note for 3.2, to see if I can find something

gritty wind Jul 10, 2022, 10:38 PM

#

Btw, I tested to make sure

#

site is on 3.1.14

cold island Jul 10, 2022, 10:39 PM

#

Are we switching to pytest? 🤔

gritty wind Jul 10, 2022, 10:39 PM

#

Initially I jumped to the last 3.2, because django's versioning guarantees it doesn't change on minor versions

#

But I've tested with 3.2.0 to make sure

#

And it has the same problem

gritty wind Jul 10, 2022, 10:40 PM

#

cold island Are we switching to pytest? 🤔

Well, I haven't discussed it, I was just doing a cost assessment first. It's not a full-fledged pytest migration either, it's just switching to use the pytest runner with our unittest tests

#

We usually see a nice performance boost by switching to pytest (and changing nothing else), and then we get access to plugins like xdist which give an even larger boost

cold island Jul 10, 2022, 10:41 PM

#

ok

tawdry vapor Jul 10, 2022, 10:43 PM

#

Migrations don't modify the model. They only affect the database schema. Pretty sure that has always been the case with Django

gritty wind Jul 10, 2022, 10:47 PM

#

You are technically correct

#

Yet it's still being modified

#

And not just the model, but instances of it too, which were created before the migration

#

I've gone ahead and printed the concrete_fields of the instance that is causing the issues:

# 3.1
(<django.db.models.fields.AutoField: id>, <django.db.models.fields.DateTimeField: inserted_at>, <django.db.models.fields.DateTimeField: expires_at>, <django.db.models.fields.BooleanField: active>, <django.db.models.fields.CharField: type>, <django.db.models.fields.TextField: reason>, <django.db.models.fields.BooleanField: hidden>, <django.db.models.fields.related.ForeignKey: actor>, <django.db.models.fields.related.ForeignKey: user>)  # Setup
(<django.db.models.fields.AutoField: id>, <django.db.models.fields.DateTimeField: inserted_at>, <django.db.models.fields.DateTimeField: expires_at>, <django.db.models.fields.BooleanField: active>, <django.db.models.fields.CharField: type>, <django.db.models.fields.TextField: reason>, <django.db.models.fields.BooleanField: hidden>, <django.db.models.fields.related.ForeignKey: actor>, <django.db.models.fields.related.ForeignKey: user>)  # Test

# 3.2
(<django.db.models.fields.AutoField: id>, <django.db.models.fields.DateTimeField: inserted_at>, <django.db.models.fields.DateTimeField: expires_at>, <django.db.models.fields.BooleanField: active>, <django.db.models.fields.CharField: type>, <django.db.models.fields.TextField: reason>, <django.db.models.fields.BooleanField: hidden>, <django.db.models.fields.related.ForeignKey: actor>, <django.db.models.fields.related.ForeignKey: user>)  # Setup
(<django.db.models.fields.AutoField: id>, <django.db.models.fields.DateTimeField: inserted_at>, <django.db.models.fields.DateTimeField: expires_at>, <django.db.models.fields.BooleanField: active>, <django.db.models.fields.related.ForeignKey: user>, <django.db.models.fields.related.ForeignKey: actor>, <django.db.models.fields.CharField: type>, <django.db.models.fields.TextField: reason>, <django.db.models.fields.BooleanField: hidden>, <django.db.models.fields.BooleanField: dm_sent>)  # Test

#

What you're looking for here is the model change in 3.2-test

#

For the sake of curosity, I also printed it after the migration, but before the setup function ended
It's the same as the setup on both versions

gritty wind Jul 10, 2022, 10:56 PM

#

gritty wind The creation of the object itself is done *before* the test starts, and that's c...

This supports this theory

tawdry vapor Jul 10, 2022, 10:59 PM

#

This is what I found on the subject https://docs.djangoproject.com/en/4.0/topics/migrations/#historical-models

Migrations | Django documentation | Django

#

It's unclear how to use the historical versions

gritty wind Jul 10, 2022, 11:00 PM

#

Lol I remember looking into that when Chris was removing a field needed in a migration

#

I came to the same conclusion

#

But I think this is unrelated to what our issue is
I think because it's unclear what that even is

tawdry vapor Jul 10, 2022, 11:01 PM

#

Maybe using get_model instead of importing?

gritty wind Jul 10, 2022, 11:02 PM

#

We are using get_model

tawdry vapor Jul 10, 2022, 11:02 PM

#

In the tests?

gritty wind Jul 10, 2022, 11:02 PM

#

Yeah

#

Hmm, I've checked the instances, not the model themselves. Not sure if those have changed too

molten perch Jul 10, 2022, 11:06 PM

#

There is something here:
Assigning objects which don’t support creating deep copies with copy.deepcopy() to class attributes in TestCase.setUpTestData() is deprecated.
https://github.com/python-discord/site/blob/48617b0425bb6b4c7f253f9b44363432658c2f1c/pydis_site/apps/api/tests/migrations/base.py#L36
Maybe, make it setupClassData?

stable mountainBOT Jul 10, 2022, 11:06 PM

#

pydis_site/apps/api/tests/migrations/base.py line 36

def setUpTestData(cls):```

molten perch Jul 10, 2022, 11:06 PM

#

Just a suggestion though.

gritty wind Jul 10, 2022, 11:09 PM

#

gritty wind Hmm, I've checked the instances, not the model themselves. Not sure if those hav...

I've done that now:

Setup                   ['id', 'inserted_at', 'expires_at', 'active', 'type', 'reason', 'hidden', 'actor', 'user']
Base pre-migration      ['id', 'inserted_at', 'expires_at', 'active', 'type', 'reason', 'hidden', 'actor', 'user']
Base post-migration old ['id', 'inserted_at', 'expires_at', 'active', 'type', 'reason', 'hidden', 'actor', 'user']
Base post-migration new ['id', 'inserted_at', 'expires_at', 'active', 'type', 'reason', 'hidden', 'actor', 'user']
Test original           ['id', 'inserted_at', 'expires_at', 'active', 'type', 'reason', 'hidden', 'actor', 'user']
Test new                ['id', 'inserted_at', 'expires_at', 'active', 'type', 'reason', 'hidden', 'actor', 'user']

It does not change at any point, just the instances do

gritty wind Jul 10, 2022, 11:09 PM

#

molten perch There is something here: `Assigning objects which don’t support creating deep co...

I don't believe this is our case, but I'll try it anyway

molten perch Jul 10, 2022, 11:09 PM

#

Sorry, setUpClass

molten perch Jul 10, 2022, 11:10 PM

#

gritty wind I don't believe this is our case, but I'll try it anyway

That's the only thing that could possibly go wrong, according to the release note.

gritty wind Jul 10, 2022, 11:13 PM

#

So what am I changing

#

Well, that's done it for some reason

#

For some of the tests, some still fail

#

These are all due to the test_base tests though, which need to be rewritten, so I'll figure that out

#

The question now is whether we take the win and forget about this, or continue thinking about removing them

#

Looks like we won't get to make that decision, since setupClass terminates our database connection once it's done, which then fails everything else

hoary haven Jul 10, 2022, 11:23 PM

#

@tawdry vapor @trim cradle is something supposed to be added to the yaml resource file or is everything supposed to "just work"
this is how it looks, no padlock icon or anything

molten perch Jul 10, 2022, 11:25 PM

#

gritty wind Looks like we won't get to make that decision, since setupClass terminates our d...

Not sure why. Maybe use setUp by itself? It runs before each test, same thing as setUpTestData btw.

hoary haven Jul 10, 2022, 11:25 PM

#

i'm guessing it should be fa-lock-alt or something. will test

gritty wind Jul 10, 2022, 11:25 PM

#

That would run migrations on every test, which is... slow to say the least

tawdry vapor Jul 10, 2022, 11:26 PM

#

hoary haven i'm guessing it should be `fa-lock-alt` or something. will test

yeah probably. css class must just be wrong

hoary haven Jul 10, 2022, 11:32 PM

#

it was a paid icon so fa-lock-alt doesn't render either. i went with fa-solid fa-lock
can i learn how to rebase this branch?

outer oasis Jul 10, 2022, 11:33 PM

#

https://i.imgflip.com/6mdm1x.jpg

hoary haven Jul 10, 2022, 11:33 PM

#

i forget which branch rebases "on" to which

#

or merge commit, idc either way

outer oasis Jul 10, 2022, 11:34 PM

#

Sorry, that was bigger than intended

tawdry vapor Jul 10, 2022, 11:35 PM

#

hoary haven i forget which branch rebases "on" to which

git checkout pr-branch && git fetch origin && git merge origin/main

outer oasis Jul 10, 2022, 11:35 PM

#

hoary haven or merge commit, idc either way

You've committed directly to his branch
What do you need to rebase?

tawdry vapor Jul 10, 2022, 11:35 PM

#

If you want a rebase then change git merge to git rebase

#

I guess just to update with commits from main?

hoary haven Jul 10, 2022, 11:35 PM

#

PR was just saying it was out of date, but looks like stel took care of it

molten perch Jul 10, 2022, 11:36 PM

#

gritty wind That would run migrations on every test, which is... slow to say the least

Yeah, sure. I thought setUpTestData runs before each test, since the tests don't use TransactionTestCase, might be wrong though

outer oasis Jul 10, 2022, 11:37 PM

#

hoary haven PR was just saying it was out of date, but looks like stel took care of it

Ah
There's an "update branch" button at the bottom of the PR page
Creates a commit like Merge branch 'main' into swfarnsworth/resources that brings all new commits from the base branch into your PR

#

I think it does actually use rebase, but all you have to do is push the button

tawdry vapor Jul 10, 2022, 11:38 PM

#

I think it's always a merge

#

Actually, you get a choice

outer oasis Jul 10, 2022, 11:38 PM

#

oh
I'm wrong again

tawdry vapor Jul 10, 2022, 11:38 PM

#

But it is a merge by default

#

hoary haven Jul 10, 2022, 11:39 PM

#

i just heard the update w/ rebase button for sure has surprising effects, i think

#

okie, i don't know how to get this OK to merge now though lumi_aww is it the netlify stuff?

outer oasis Jul 10, 2022, 11:41 PM

#

hoary haven i just heard the update w/ rebase button for sure has surprising effects, i thin...

Rebase tends to cause problems because it's not very friendly

#

In the words of our esteemed Mr.@warm vigil, #voice-chat-text-0 message

hoary haven Jul 10, 2022, 11:41 PM

#

no it behaves distinctly differently in the github ui, last i saw..

outer oasis Jul 10, 2022, 11:42 PM

#

outer oasis In the words of our esteemed Mr.<@113304266269003776>, https://discord.com/chann...

Oh this is the public dev channel
Sorry for the ping sir

#

I apologized!

warm vigil Jul 10, 2022, 11:43 PM

#

You do what you want on your repo. I'm not a fan of rebasing esp on repo with a ton of other people working on it. It's a history rewrite and that may drive others insane.

gritty wind Jul 10, 2022, 11:44 PM

#

We tend to allow rebases before and after reviews

#

During reviews it can be annoying as you've said

hoary haven Jul 10, 2022, 11:44 PM

#

thanks Mark! i guess my review didn't count

tawdry vapor Jul 10, 2022, 11:44 PM

#

hoary haven okie, i don't know how to get this OK to merge now though <:lumi_aww:82329394940...

I do not believe the netlify checks are required. Only the review requirement check is

#

The netlify stuff is broken at the moment in any case

tawdry vapor Jul 10, 2022, 11:45 PM

#

hoary haven thanks Mark! i guess my review didn't count

Yes, because you committed to the branch.

gritty wind Jul 10, 2022, 11:45 PM

#

molten perch Yeah, sure. I thought `setUpTestData` runs before each test, since the tests don...

The class-level atomic block described above allows the creation of initial data at the class level, once for the whole TestCase. This technique allows for faster tests as compared to using setUp().
https://docs.djangoproject.com/en/4.0/topics/testing/tools/#django.test.TestCase.setUpTestData

outer oasis Jul 10, 2022, 11:45 PM

#

hoary haven okie, i don't know how to get this OK to merge now though <:lumi_aww:82329394940...

No, only the ones labeled requiredare actually required
In this case you can see that it's the review check that's still pending
If you click on "details", you can see the review requirements, and their current statuses

gritty wind Jul 10, 2022, 11:46 PM

#

Normally Mina would be right, but right now due to the issues, the netlify check is allowed to fail

#

Under normal circumstances, we usually require all checks to pass

hoary haven Jul 10, 2022, 11:47 PM

#

hm, this PR does not fall under content change rules?

outer oasis Jul 10, 2022, 11:48 PM

#

outer oasis No, only the ones labeled `required`are actually required In this case you can s...

For example now that Mark and I have left approvals, we've satisfied the requirements

hoary haven Jul 10, 2022, 11:48 PM

#

here's a 🍪

outer oasis Jul 10, 2022, 11:48 PM

#

And the check is now green

outer oasis Jul 10, 2022, 11:48 PM

#

outer oasis For example now that Mark and I have left approvals, we've satisfied the require...

Am I allowed to post these images in public?

tawdry vapor Jul 10, 2022, 11:49 PM

#

Yes anyone could go on GH and view it

#

It's already public is what I am trying to say

outer oasis Jul 10, 2022, 11:50 PM

#

Right right, I think you have to be a member of the org to actually see the page itself
But the same information is already available in the review-policy.yml anyways

tawdry vapor Jul 10, 2022, 11:51 PM

#

hoary haven hm, this PR does not fall under content change rules?

No because a new icon was added. Though maybe we should add that file to the list of exceptions.

hoary haven Jul 10, 2022, 11:53 PM

#

hm i suppose it's fine, it's a python file and has some code in it

#

so say hypothetically i start a branch/PR that gets a bit old, or take over a stale PR whose branch is out of date. can't i do something to make that branch be "caught up" to the commits from main?

#

i thought that's what rebasing was (mostly) for

outer oasis Jul 10, 2022, 11:56 PM

#

tawdry vapor

"Update branch"

outer oasis Jul 10, 2022, 11:58 PM

#

hoary haven i thought that's what rebasing was (mostly) for

Kind of
Merging and rebasing are two different ways of doing the same thing, combing commits from two different branches. (vastly simplified explanation)
You can use either way to update your branch with the new commits

hoary haven Jul 10, 2022, 11:58 PM

#

why not just git rebase main ?

tawdry vapor Jul 10, 2022, 11:58 PM

#

Rebasing is primarily useful for cleaning up your history. You could also use it instead of a merge, but it's not the only use case.

#

If you try git rebase -i <commit-sha> you will see there are lots of things you can do

outer oasis Jul 10, 2022, 11:59 PM

#

hoary haven why not just `git rebase main` ?

Because that rewrites history
Merging creates a new commit(s) that add on the new changes, while rebasing actually changes which commit your branch started from to pretend it actually started somewhere else

hoary haven Jul 11, 2022, 12:00 AM

#

yeah i'm familiar with rebasing while in the 1 branch

#

not so much btwn branches

outer oasis Jul 11, 2022, 12:00 AM

#

Lots and lots of git people are purists and absolutely hate changing things

#

But it's with reason

#

When you pull someone else's changes and all of a sudden git says it can't process something because your commits don't exist anymore, it can cause issues

hoary haven Jul 11, 2022, 12:05 AM

#

outer oasis Because that rewrites history Merging creates a _new_ commit(s) that add on the ...

i kind of like this though. i guess i'm not a git purist

tawdry vapor Jul 11, 2022, 12:06 AM

#

In the context of a PR it can cause GitHub to hide old reviews, or at least that used to be the case

#

It just makes it confusing for a reviewer

hoary haven Jul 11, 2022, 12:06 AM

#

i see

tawdry vapor Jul 11, 2022, 12:07 AM

#

I don't really care so much because the ship sailed long ago of keeping the history perfectly clean

#

So merge commits don't bother me

#

Also if you rebase and you're not the author of the commits, it will add you as a co-author (at least through GH; if you use commands and you really want to you can avoid that)

hoary haven Jul 11, 2022, 12:14 AM

#

yeah that's what i was going to attempt

#

one more question, i edited the PR's original message to link meta#185 and meta#180 but github only linked to 185. is there a way to link #180 after the fact?

dusky shoreBOT Jul 11, 2022, 12:17 AM

#

GitHub

IssueOpen Algorithms Github (Python)
IssueClosed Resources: Atom (the editor) is being sunset

gritty wind Jul 11, 2022, 12:18 AM

#

In the side bar of the issue, you can link the PR, then close it

#

Specifically under Development

hoary haven Jul 11, 2022, 12:18 AM

#

dunno how to do that cross-repo

patent pivot Jul 11, 2022, 12:18 AM

#

the sidebar only allows you to do same repo yea

#

fixed it

gritty wind Jul 11, 2022, 12:19 AM

#

In that case, just link it in a comment and close

patent pivot Jul 11, 2022, 12:19 AM

#

#

it's not pretty

#

but it worked

hoary haven Jul 11, 2022, 12:19 AM

#

oh just separate lines?

outer oasis Jul 11, 2022, 12:19 AM

#

AFAIK they can be on the same line

patent pivot Jul 11, 2022, 12:19 AM

#

you can do same line yea

#

last line of this

outer oasis Jul 11, 2022, 12:20 AM

#

But you can't do closes #156 #157
It has to be closes #156 closes #157

patent pivot Jul 11, 2022, 12:20 AM

#

yea

outer oasis Jul 11, 2022, 12:20 AM

#

Which is annoying

#

Feels like it'd be pretty easy to let us do that

patent pivot Jul 11, 2022, 12:22 AM

#

yea

#

at the very least supporting commas or just adjacent issue nums

gritty wind Jul 11, 2022, 12:31 AM

#

Anyone have thoughts on testing abstract models?

#

Instantiating them is undefined behavior in django, and it's explicitly disallowed in 3.2

#

From what I'm reading, you wouldn't test it in isolation anyway because you'll be testing it's inheritors

#

(The model is Message, and the only place it seems to be used is DeletedMessage)

tawdry vapor Jul 11, 2022, 12:34 AM

#

i wouldnt bother keeping the tests

#

or at least transfer them to a concrete class

gritty wind Jul 11, 2022, 1:16 AM

#

I've pushed something for now to make sure nothing has broken yet, but I still need to keep bumping the django version a bit longer

gritty wind Jul 11, 2022, 1:42 AM

#

@hardy gorge I've left a short write-up on site#740 about the migration tests. I would appreciate your input on it. I'm thinking of removing them
https://github.com/python-discord/site/pull/740#issuecomment-1179868636

dusky shoreBOT Jul 11, 2022, 1:42 AM

#

GitHub

PROpen Update Django Version To 4.0

hardy gorge Jul 11, 2022, 5:01 AM

#

gritty wind <@336843820513755157> I've left a short write-up on site#740 about the migration...

I've replied

static canyon Jul 11, 2022, 9:08 AM

#

I've been looking for an easy issue to implement so that I get back into contributing to bot, and stumbled across bot#2168.

I see someone else was already assigned (donmonc) but it's been 2 months since then with seemingly no activity on the matter, so may I take over?

dusky shoreBOT Jul 11, 2022, 9:08 AM

#

GitHub

IssueOpen Show full date & timestamp in !modpings off message

gritty wind Jul 11, 2022, 11:03 AM

#

hardy gorge I've replied

Thanks, you are amazing

broken topaz Jul 11, 2022, 12:12 PM

#

what do you guys do to read a env yaml file?

gritty wind Jul 11, 2022, 12:19 PM

#

env yaml file?

#

This seems like it's conflating two things. I think our only project which uses yaml configs is bot, and in that we load a dotenv file into the environment using python_dotenv. We have a YAML constructor which pulls keys from the environment

#

All together, it looks like this:
https://github.com/python-discord/bot/blob/main/bot/constants.py#L20-L58

broken topaz Jul 11, 2022, 12:35 PM

#

seems confusing to me

#

but why not just use pyamlenv

#

?

#

https://pypi.org/project/pyaml-env/

PyPI

pyaml-env

Provides yaml file parsing with environment variable resolution

gritty wind Jul 11, 2022, 12:43 PM

#

Because the first version was released in mid-2021, while the constructor has existed for 4 years

#

Regardless, I'm not in favor of adding dependencies without good reason. It's another thing that makes maintenance harder, compared to 30 lines of code that haven't changed in 4 years

hoary haven Jul 11, 2022, 1:07 PM

#

static canyon I've been looking for an easy issue to implement so that I get back into contrib...

that's a staff member, let me follow up with him first

#

it was gonna be his first foray into our projects so just wanna check with him

thorny obsidian Jul 11, 2022, 2:04 PM

#

How do we feel about moving all the d.py related tags under the discord tag namespace?

outer oasis Jul 11, 2022, 2:04 PM

#

What about a discord_bots namespace?

thorny obsidian Jul 11, 2022, 2:06 PM

#

It would look like this:

vale ibex Jul 11, 2022, 2:09 PM

#

do tag groups support aliases?

#

typing discord_bots each time seems annoying

outer oasis Jul 11, 2022, 2:09 PM

#

Okay, "DiscordBots", so the spacing doesn't duck it up like people do with polls

thorny obsidian Jul 11, 2022, 2:10 PM

#

vale ibex do tag groups support aliases?

not that I can see, it's based off the folder name the tags are stored in

cold island Jul 11, 2022, 2:10 PM

#

I'd still prefer discord for brevity

outer oasis Jul 11, 2022, 2:11 PM

#

I would put things directly related to Discord's UX in there
But I don't think we actually have anything for that

wild prism Jul 11, 2022, 2:12 PM

#

are they all about dpy, or discord api in general?

vale ibex Jul 11, 2022, 2:12 PM

#

they all seem d.py related, based of the tag names

thorny obsidian Jul 11, 2022, 2:13 PM

#

Looking through those related tags they're all d.py related, none are about the discord api itself

outer oasis Jul 11, 2022, 2:14 PM

#

cold island I'd still prefer discord for brevity

"dpy"? It's even briefer

brazen charm Jul 11, 2022, 2:15 PM

#

the group is still fuzzy matched so a longer name shouldn't be a big problem

thorny obsidian Jul 11, 2022, 2:17 PM

#

yeah, with the discord_bots namespace, discord as a group name works fine for pulling it up

vale ibex Jul 11, 2022, 2:19 PM

#

sounds good then

outer oasis Jul 11, 2022, 2:20 PM

#

If it'll fuzzy match, we could use Discord Bots as a more astec - astehc - asctech?

#

aesthetically, thank you Google

wild prism Jul 11, 2022, 2:21 PM

#

huh i was gonna guess asstech

vale ibex Jul 11, 2022, 2:21 PM

#

not sure how spaces would work

outer oasis Jul 11, 2022, 2:21 PM

#

That parts a given

thorny obsidian Jul 11, 2022, 2:22 PM

#

outer oasis If it'll fuzzy match, we could use `Discord Bots` as a more astec - astehc - asc...

that would involve putting a space in the folder name and as someone who frequently uses windows I avoid that shit like the plague

outer oasis Jul 11, 2022, 2:23 PM

#

thorny obsidian that would involve putting a space in the folder name and as someone who frequen...

Oh - You're parsing folder names - I forgot that part

#

Yeah, no, fuck that

#

DiscordBots it is

gritty wind Jul 11, 2022, 2:33 PM

#

I need to con an admin-core dev into reviewing site#740

dusky shoreBOT Jul 11, 2022, 2:33 PM

#

GitHub

PROpen Update Django Version To 4.0

gritty wind Jul 11, 2022, 2:33 PM

#

@vale ibex is my go to

#

It's a pretty small PR, most of the diff is deleting files :D

vale ibex Jul 11, 2022, 2:40 PM

#

gritty wind <@126811506632294400> is my go to

I'll take a look

#

if you can look at metricity#19 and metricity#20

#

both much smaller

dusky shoreBOT Jul 11, 2022, 2:40 PM

#

GitHub

PROpen Add support for staff channels that are not in staff categories
PROpen Add dependabot config

gritty wind Jul 11, 2022, 2:41 PM

#

Linting passes? Merge ✅

vale ibex Jul 11, 2022, 2:41 PM

#

lol

gritty wind Jul 11, 2022, 2:42 PM

#

What's the Projects category

#

Oh found it

vale ibex Jul 11, 2022, 2:42 PM

#

#dev-black-knight

gritty wind Jul 11, 2022, 2:42 PM

#

Thanks

vale ibex Jul 11, 2022, 2:43 PM

#

what's with this diff?

gritty wind Jul 11, 2022, 2:43 PM

#

The message model is an abstract model, so instantiating it is undefined behavior

vale ibex Jul 11, 2022, 2:43 PM

#

ahh cool

gritty wind Jul 11, 2022, 2:43 PM

#

In django 3.2 it's illegal

vale ibex Jul 11, 2022, 2:43 PM

#

you're illegal

gritty wind Jul 11, 2022, 2:43 PM

#

Thanks 🤩

vale ibex Jul 11, 2022, 2:44 PM

#

that was a pretty easy one to review lmfao

#

there was like 10 lines of actual things to look at

gritty wind Jul 11, 2022, 2:47 PM

#

Yeah lol

#

It's an evil diff size

thorny obsidian Jul 11, 2022, 3:12 PM

#

Alright, I think I figured out alt-names for our tag system

vale ibex Jul 11, 2022, 3:14 PM

#

just duplicate the file

#

easy

#

kek

thorny obsidian Jul 11, 2022, 3:15 PM

#

spray

#

I know I didn't make an issue or get it approved........ but I'm gonna open a PR anyway

vale ibex Jul 11, 2022, 3:15 PM

#

I wonder how a symlink would work

thorny obsidian Jul 11, 2022, 3:16 PM

#

I just added this as a metadata feature you can add to specify alt names and then add the alt names as part of the tag dict to search

vale ibex Jul 11, 2022, 3:16 PM

#

runing on windows host would likely complain

gritty wind Jul 11, 2022, 4:07 PM

#

So update on the static previews thing

#

I've written most of it as a github app that's managed by django

#

But now the part I didn't anticipate is that there is a portion of the process where we just sit around and wait

#

Original plan was to do this async, since I added httpx, and django 4 has support for async views

#

But not DRF apparently

#

Any thoughts?

#

I could do CF workers, but I'm keeping that as a last resort because it's much nicer on site

outer oasis Jul 11, 2022, 4:10 PM

#

gritty wind But now the part I didn't anticipate is that there is a portion of the process w...

Waiting for... a technical dependency or a bureaucratic dependency ?

gritty wind Jul 11, 2022, 4:10 PM

#

If the process happens too fast, we can't optimize it in the future

#

Lol it waits for the github build to finish

outer oasis Jul 11, 2022, 4:11 PM

#

What's wrong with CF Workers?

gritty wind Jul 11, 2022, 4:11 PM

#

Nothing, it's just that we have way fewer JS devs than python devs

outer oasis Jul 11, 2022, 4:12 PM

#

Oh right
CF doesn't support Python

gritty wind Jul 11, 2022, 4:12 PM

#

Why did I write pycharm

#

This is why you don't multitask kids

#

Well, what if I don't make this a DRF view, but just a regular view 🤔

#

It's not using the ORM, or any of the other DRF features

#

Maaaaybe I can get it to work with django's async_to_sync and DRF

outer oasis Jul 11, 2022, 4:18 PM

#

Damn - I'm going to have to learn Djagno

outer oasis Jul 11, 2022, 4:20 PM

#

gritty wind Well, what if I don't make this a DRF view, but just a regular view 🤔

Why would this be better?

I'd like to learn, but I don't want to make you to type out the whole thing, so feel free to tell me to RTFM

gritty wind Jul 11, 2022, 4:20 PM

#

Oh I don't mind explaining, but I'm not too familiar either

#

DRF doesn't support async views though

#

It's a rather new feature in django

#

There's a discussion on the DRF repo, but it's still all tentative

thorny obsidian Jul 11, 2022, 4:21 PM

#

@vocal wolf with the review of bot#2213 we will be one step closer of allowing you to invoke the new !dashmpip tag with !minusmpip =P

dusky shoreBOT Jul 11, 2022, 4:21 PM

#

GitHub

PROpen Add Aliases for Tags Support

vocal wolf Jul 11, 2022, 4:21 PM

#

lol

vocal wolf Jul 11, 2022, 4:22 PM

#

thorny obsidian <@196664644113268736> with the review of bot#2213 we will be one step closer of ...

Did you not lint before you pushed??? To the shadow realm you go.

thorny obsidian Jul 11, 2022, 4:23 PM

#

vocal wolf Did you not lint before you pushed??? To the shadow realm you go.

I did! The precommit hook didn't catch it or didn't function correctly D:

vocal wolf Jul 11, 2022, 4:23 PM

#

are you sure pre-commit is installed? That's what usually gets me

thorny obsidian Jul 11, 2022, 4:23 PM

#

Yeah, it's been installed since forever and I got pissy at it like 2 days ago

vocal wolf Jul 11, 2022, 4:24 PM

#

hmmmmmmmmm

wild prism Jul 11, 2022, 4:24 PM

#

my precommit on sir robin was borked somehow and I had to re-poetry install the other day

vale ibex Jul 11, 2022, 4:25 PM

#

gritty wind Original plan was to do this async, since I added httpx, and django 4 has suppor...

thread pool?

gritty wind Jul 11, 2022, 4:25 PM

#

I think that's more or less what the async_to_sync util does

#

It says it runs in a "sub-thread"

vale ibex Jul 11, 2022, 4:25 PM

#

yea, sounds about right

gritty wind Jul 11, 2022, 4:28 PM

#

dusky shore

Code looks functionally fine, and linting mostly passes, now waiting on the whitespace one lol

thorny obsidian Jul 11, 2022, 4:35 PM

#

@vale ibex So you're like the local king of interactive rebases. I can do that and rewrite the SHA of commits on a feature branch and it should be fine as long as it hasn't been reviewed or checkout by anyone else, right?

vale ibex Jul 11, 2022, 4:36 PM

#

Yea, rewriting history like that is fine so long as other people don't have it checked out

#

I do it quite a lot 😅

#

and yea as you said it can mess with github reviews sometimes, so usually best not to do it if there are active comments

static canyon Jul 11, 2022, 4:43 PM

#

hoary haven it was gonna be his first foray into our projects so just wanna check with him

Yeah that's fine, just lmk

thorny obsidian Jul 11, 2022, 4:43 PM

#

vocal wolf Did you not lint before you pushed??? To the shadow realm you go.

okay now we're good!

placid ermine Jul 11, 2022, 4:46 PM

#

oh COME on you didnt seriously add minus m pip lmaooo

thorny obsidian Jul 11, 2022, 4:47 PM

#

:3c you can blame @dim pelican for that suggestion

vale ibex Jul 11, 2022, 4:47 PM

#

so when you do a rebase locally, you need to git push --force

#

otherwise it will just do a merge commit in gh :D

thorny obsidian Jul 11, 2022, 4:48 PM

#

vale ibex so when you do a rebase locally, you need to git push --force

yeah I'm a moron :D I realized after

vale ibex Jul 11, 2022, 4:48 PM

#

if you wanted to fix, you could do git rebase -i HEAD~7 and drop the 4 commits you don't want

thorny obsidian Jul 11, 2022, 4:49 PM

#

I'm always a bit terrified everytime I have to use HEAD because I've never not fucked it up. So I just called it a day and let it be

vale ibex Jul 11, 2022, 4:49 PM

#

fair enough

#

also, with the fstring aliases, does the fuzzy matching not give us that for free?

thorny obsidian Jul 11, 2022, 4:51 PM

#

The issue is another tag

#

!fstring

stable mountainBOT Jul 11, 2022, 4:51 PM

#

Did you mean ...

» sql-fstring
» f-strings

vale ibex Jul 11, 2022, 4:51 PM

#

Ahh

cold island Jul 11, 2022, 5:06 PM

#

stable mountain

What if we made this a dropdown that invokes the command. No idea how smart this is

vale ibex Jul 11, 2022, 5:07 PM

#

if only you could spawn ephemeral messages from message commands

#

would be even cleaner

#

but that does sound good

thorny obsidian Jul 11, 2022, 5:09 PM

#

New tags
• !dashmpip tag showing how to install things via pip without relying on pip being on PATH.
• !regex tag for explaining what regex is and providing some of our favorite resources for testing regex.

Check out all of these tags in #bot-commands ✨

Updates & new features
•.uwu got a major facelift scofflaw_chan The new uwu-levels are off the charts. Thanks to LP and Shenanigans for the update and Bluenix, lemon, Senjan, and ToxicKidz for the review.
•.uwu will also work if you reply to a message! Thanks to Shenanigans for the change and Chrisjl and Scaleios for the review.
• .latex is now allowed in the data science and AI channel and it has amsmath support. Thanks to Chrisjl and Verboof for the changes, and wookie, fix error, and hsp for the reviews.
• !charinfo is now allowed in all channels (except for python-general). Thanks Chrisjl for the change and MrHemlock and Mark for the review.
• typing-extensions is now part of snekbox! Feel free to type-hint away~

You can check out what the above commands do in #sir-lancebot-playground as well.

I wanted to changelog .uwu, figure I should changelog everything else that we've done for a bit as well. How does it look? Will replace names with actual pings

vale ibex Jul 11, 2022, 5:10 PM

#

looks good to me

#

there's a bunch of other things been merged since the last changelog, we should try to catchup

#

This is since 2022-05-01 https://github.com/search?q=org%3Apython-discord+type%3Apr+merged%3A>%3D2022-05-01&type=Issues&ref=advsearch&l=&l=

#

dependabot does flood this a little

thorny obsidian Jul 11, 2022, 5:11 PM

#

So I was planning on not changelogging anything from Sir Robin or Forms or bot-core, just because it's not really ultra user facing like Python or Sir Lance are

outer oasis Jul 11, 2022, 5:12 PM

#

thorny obsidian **New tags** • `!dashmpip` tag showing how to install things via pip without rel...

Thank you for the changelog entry
I feel important now

placid ermine Jul 11, 2022, 5:12 PM

#

i too feel important now

wild prism Jul 11, 2022, 5:15 PM

#

isnt regex old?

thorny obsidian Jul 11, 2022, 5:15 PM

#

wild prism isnt regex old?

we are very behind on the changelogs

#

last changelog was timeit command

wild prism Jul 11, 2022, 5:15 PM

#

lol

thorny obsidian Jul 11, 2022, 5:16 PM

#

wait, did we ever changelog the uwu-fication update itself?

vale ibex Jul 11, 2022, 5:17 PM

#

thorny obsidian So I was planning on not changelogging anything from Sir Robin or Forms or bot-c...

just bot https://github.com/search?l=&p=2&q=repo%3Apython-discord%2Fbot+type%3Apr+merged%3A>%3D2022-05-01&ref=advsearch&type=Issues

just lance https://github.com/search?q=repo%3Apython-discord%2Fsir-lancebot+type%3Apr+merged%3A>%3D2022-05-01&type=Issues&ref=advsearch&l=&l=

vale ibex Jul 11, 2022, 5:17 PM

#

thorny obsidian wait, did we ever changelog the uwu-fication update itself?

nope

thorny obsidian Jul 11, 2022, 5:17 PM

#

lmfao, okay will update my text

thorny obsidian Jul 11, 2022, 5:17 PM

#

vale ibex just bot <https://github.com/search?l=&p=2&q=repo%3Apython-discord%2Fbot+type%3A...

too late, already gone through all 19 pages of the other thing lemonshake

vale ibex Jul 11, 2022, 5:17 PM

#

ah lol

thorny obsidian Jul 11, 2022, 5:17 PM

#

I think I captured everything though at least public user facing

vale ibex Jul 11, 2022, 5:17 PM

#

a lot of the bot changes are mod speciifc

thorny obsidian Jul 11, 2022, 5:17 PM

#

I do think we need a mod-specific changelog though

vale ibex Jul 11, 2022, 5:18 PM

#

we post relevant stuff in mod announcements

thorny obsidian Jul 11, 2022, 5:18 PM

#

Cause there are a fuckton of improvements and I think some went unnoticed

wild prism Jul 11, 2022, 5:18 PM

#

wot if we automated generating prompts for us to changelog things

thorny obsidian Jul 11, 2022, 5:20 PM

#

wild prism wot if we automated generating prompts for us to changelog things

how would you parse the changelog-able from the not?

placid ermine Jul 11, 2022, 5:21 PM

#

label on pr pithink

wild prism Jul 11, 2022, 5:21 PM

#

we could just generate a list of merged PRs and toss out the ones we dont want

outer oasis Jul 11, 2022, 5:21 PM

#

What part of everything gets a changelog entry do you not understand?

thorny obsidian Jul 11, 2022, 5:21 PM

#

wild prism we could just generate a list of merged PRs and toss out the ones we dont want

It's like 90% stuff we don't want
I do like the label idea

thorny obsidian Jul 11, 2022, 5:22 PM

#

outer oasis What part of _everything gets a changelog entry_ do you not understand?

Multiple 10k powered-by-nitro messages of changelogging Scale's dependabot rebase

outer oasis Jul 11, 2022, 5:22 PM

#

Have an action that runs on merge that sends an even if the merged PR has a label?

thorny obsidian Jul 11, 2022, 5:22 PM

#

The other hard part is the connection between github username and discord username for non-staff, if we wanted to 100% automate it

thorny obsidian Jul 11, 2022, 5:23 PM

#

thorny obsidian **New tags** • `!dashmpip` tag showing how to install things via pip without rel...

okee, gonna post this shortly, any last comments?

thorny obsidian Jul 11, 2022, 5:25 PM

#

placid ermine label on pr <:pithink:652247559909277706>

@vocal wolf triage lead, thoughts on adding a label on PRs we'd like to changelog so that way it's easier to find what we're interested in?

vocal wolf Jul 11, 2022, 5:26 PM

#

ye

#

I'm wondering what color it should be

placid ermine Jul 11, 2022, 5:28 PM

#

'tis a momentous decision

thorny obsidian Jul 11, 2022, 5:34 PM

#

y'all pls.... I was so close to pressing enter on the changelog. Now I have to changelog the tag aliases too ;-;

thorny obsidian Jul 11, 2022, 5:38 PM

#

vocal wolf I'm wondering what color it should be

.uwu

dusky shoreBOT Jul 11, 2022, 5:38 PM

#

i'm wondewing nyani cowow it shouwd b-be

thorny obsidian Jul 11, 2022, 6:25 PM

#

Can I get an admin or mod to pull all tag usage from grafana or whatever stats service has that available from the past 6 months?

gritty wind Jul 11, 2022, 6:51 PM

#

https://grafana.pythondiscord.com/dashboard/snapshot/TSZBmkMIaYjwaiSA1Wov2Dyy0fBV5H84?orgId=2

#

You should be able to see that page for the next hour

#

@sharp charm#6000 I'm working on a resource on site which should redirect to a download URL on github after some processing. Which status code should I use, and would it affect our SEO (I can do it in another way if that's the case)

#

Thanks discord

sharp charm Jul 11, 2022, 6:55 PM

#

wrong joe

gritty wind Jul 11, 2022, 6:55 PM

#

Yeah I figured

sharp charm Jul 11, 2022, 6:55 PM

#

@patent pivot

gritty wind Jul 11, 2022, 6:56 PM

#

Thanks

#

I literally couldn't bring this discord to find him

#

Went looking for his ID lol

sharp charm Jul 11, 2022, 6:56 PM

#

ye lol

gritty wind Jul 11, 2022, 6:57 PM

#

gritty wind <@365154655313068032>#6000 I'm working on a resource on site which should redire...

303 looks promising

thorny obsidian Jul 11, 2022, 6:59 PM

#

gritty wind <https://grafana.pythondiscord.com/dashboard/snapshot/TSZBmkMIaYjwaiSA1Wov2Dyy0f...

That count doesn't look correct, param_arg at 4k? kindling only at 114?

gritty wind Jul 11, 2022, 7:00 PM

#

Good point

#

I wonder if this is related to the injection attack we had a while back

patent pivot Jul 11, 2022, 7:01 PM

#

gritty wind <@365154655313068032>#6000 I'm working on a resource on site which should redire...

what's it going to be accessible at? pythondiscord.com/... or are we subdomaining?

#

no we are not subdomaining because we removed that

gritty wind Jul 11, 2022, 7:02 PM

#

pydis.com/api/....

patent pivot Jul 11, 2022, 7:02 PM

#

uhhhh

gritty wind Jul 11, 2022, 7:02 PM

#

It's looking like DRF won't even accept that, so I might just return the URL in the body, and handle it in the receiver end

patent pivot Jul 11, 2022, 7:02 PM

#

pick whatever you feel is most appropriate, we should get a working robots.txt for pythondiscord.com

patent pivot Jul 11, 2022, 7:02 PM

#

gritty wind It's looking like DRF won't even accept that, so I might just return the URL in ...

hmmm maybe, given a redirect probably isn't with REST principles

gritty wind Jul 11, 2022, 7:03 PM

#

thorny obsidian That count doesn't look correct, `param_arg` at 4k? `kindling` only at 114?

Btw ^

patent pivot Jul 11, 2022, 7:03 PM

#

hmmmm

gritty wind Jul 11, 2022, 7:08 PM

#

I think the table might just be wrong,

patent pivot Jul 11, 2022, 7:11 PM

#

whhmmm

#

yeah

#

why is graphite spitting out 500s like the US spitting out those golden stimmy checks

gritty wind Jul 11, 2022, 7:11 PM

#

gritty wind Jul 11, 2022, 7:12 PM

#

patent pivot why is graphite spitting out 500s like the US spitting out those golden stimmy c...

Timeouts maybe lol

#

Is this now or in general

#

Because I'm going crazy on the query console

patent pivot Jul 11, 2022, 7:12 PM

#

right now

#

ur killing my graphite man what the hell!

gritty wind Jul 11, 2022, 7:12 PM

#

It's volccy's fault for not stopping me

patent pivot Jul 11, 2022, 7:12 PM

#

time to fix this live

#

real life fixing this right now real

#

oh

#

11/07/2022 19:13:20 :: [console] Error creating stats_counts.bot.pep_fetches.375: [Errno 28] No space left on device
11/07/2022 19:13:21 :: [console] Unhandled Error
Traceback (most recent call last):
  File "/opt/graphite/lib/python3.9/site-packages/twisted/python/threadpool.py", line 260, in <lambda>
    inContext.theWork = lambda: context.call(  # type: ignore[attr-defined]
  File "/opt/graphite/lib/python3.9/site-packages/twisted/python/context.py", line 117, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/opt/graphite/lib/python3.9/site-packages/twisted/python/context.py", line 82, in callWithContext
    return func(*args, **kw)
  File "/opt/graphite/lib/carbon/writer.py", line 191, in writeForever
    writeCachedDataPoints()
--- <exception caught here> ---
  File "/opt/graphite/lib/carbon/writer.py", line 142, in writeCachedDataPoints
    state.database.create(metric, archiveConfig, xFilesFactor, aggregationMethod)
  File "/opt/graphite/lib/carbon/database.py", line 144, in create
    whisper.create(path, retentions, xfilesfactor, aggregation_method,
  File "/opt/graphite/lib/python3.9/site-packages/whisper.py", line 537, in create
    fh.write(zeroes)
builtins.OSError: [Errno 28] No space left on device

11/07/2022 19:13:21 :: [console] Error creating stats_counts.bot.channels.pythonlogoonrslashplace: [Errno 28] No space left on device

#

lol

#

@gritty wind

vale ibex Jul 11, 2022, 7:13 PM

#

Lol

#

Time to fight linode to expand the volume

patent pivot Jul 11, 2022, 7:13 PM

#

let me give this guy a little extra wiggle room

vale ibex Jul 11, 2022, 7:14 PM

#

Joe I expect every data store to have 8TB dedicated storage

#

Preferably m.2 ssds in raid0

#

Thanks

gritty wind Jul 11, 2022, 7:16 PM

#

Just save it on the local disk

#

It's not like graphite ever restarts

patent pivot Jul 11, 2022, 7:17 PM

#

oh

#

huh

#

the vol is 30GB in Linode console, but not in Kubernetes API

#

what's the actual pod saying hmm

gritty wind Jul 11, 2022, 7:17 PM

#

I can see the preview of the stream, but not the stream itself

patent pivot Jul 11, 2022, 7:17 PM

#

20GB on system

gritty wind Jul 11, 2022, 7:17 PM

#

Amazing

patent pivot Jul 11, 2022, 7:17 PM

#

so just not resized

gritty wind Jul 11, 2022, 7:18 PM

#

Change the PV :O

vale ibex Jul 11, 2022, 7:18 PM

#

Lol Yea this is postgres volume all over again

patent pivot Jul 11, 2022, 7:18 PM

#

shutting down graphite

gritty wind Jul 11, 2022, 7:18 PM

#

Yeah good riddance, it was bloatware

vale ibex Jul 11, 2022, 7:18 PM

#

We had to resize the volume manually in the node and then restart the node

gritty wind Jul 11, 2022, 7:18 PM

#

Does this mean #dev-log is gonna start popping off now

austere hornet Jul 11, 2022, 7:22 PM

#

I love how Joe is basically screensharing to himself in #dev-voice lmao

patent pivot Jul 11, 2022, 7:22 PM

#

alright should be fixed

#

no restarts needed because i am sysadmin pro

#

they should give me a medal

#

okay it should be fine now -- but those stats still seem skewwhiff, now that might be because of the storage being fucked but there might be another root cause, so it's something to keep an eye on

#

and we need to go cry to Linode that they really need to expose volume use stats

#

https://github.com/linode/linode-blockstorage-csi-driver/issues/62

GitHub

Monitoring Kubernetes PVs · Issue #62 · linode/linode-blockstorage-...

Feature Request I expected to be able to see PV stats, like diskspace free etc. I am already scraping kubelet metrics, however I didn't find any metrics named kubelet_volume_stats_* . From ...

static canyon Jul 11, 2022, 7:26 PM

#

patent pivot okay it should be fine now -- but those stats still seem skewwhiff, now that mig...

Fwiw I remember tag usage statistics being off months ago back when I was a mod

#

So if the storage was only now then there's some other issue I think

patent pivot Jul 11, 2022, 7:27 PM

#

hmmmm

static canyon Jul 11, 2022, 7:28 PM

#

I probably sent a message about itsomewhere

#

But maybe not

gritty wind Jul 11, 2022, 7:57 PM

#

It's not a storage issue, it's a query issue

#

When I pulled it up as a graph, it matched my discord search

#

My lack of understanding of graphite, and my unwillingness to learn it means I can't debug it :D

patent pivot Jul 11, 2022, 7:58 PM

#

i will take a look™️

#

soon™️

gritty wind Jul 11, 2022, 10:20 PM

#

We should get the autospec helper from bot added to botcore

#

Would love to have it on site

#

Oh, would we consider having botcore on site, for the non-bot related utilities

#

Petition: rename bot-core to pydis-core, and use it on site :D

tawdry vapor Jul 11, 2022, 10:26 PM

#

I would appreciate feedback on the approaches outlined here, or suggestions for alternatives https://github.com/python-discord/snekbox/issues/148

tawdry vapor Jul 11, 2022, 10:33 PM

#

gritty wind Petition: rename bot-core to pydis-core, and use it on site \:D

If there were more things that need to be shared with the site, then we could consider it. But for just one file I don't think it's worthwhile.

#

Hey, that rhymed.

outer oasis Jul 11, 2022, 10:53 PM

#

Can I get an issue approval on sir-lancebot#1072 ?

dusky shoreBOT Jul 11, 2022, 10:53 PM

#

GitHub

IssueOpen .uwu command incorrectly transforms emojis in their raw text form

outer oasis Jul 11, 2022, 10:54 PM

#

Only the @coredevs are supposed/allowed to add the "approved" label, right?

tawdry vapor Jul 11, 2022, 10:55 PM

#

Apparently yes. That's what its description states. But I'm not sure if that necessarily needs to be the case.

#

I guess it depends on the scope of the issue so it's easier to just put a blanket requirement of core dev approval.

gritty wind Jul 11, 2022, 10:56 PM

#

Yeah basically

#

From the internal core-dev policy:

The decision to approve an issue always falls down to a core developer decision. That is, it’s your responsibility to approve, block, or discuss issues from any technical aspect.

If the decision on approving an issue or not falls down to a policy matter (e.g: should we allow ...), then it will most likely be an organizational decision. That might mean requiring admin approval, discussion on the org-repo, or a staff meeting.

Which is more words to say what Mark has said. If an issue is created which is related to an event, it's probably fine for Kat to approve it. But there are a lot of nuances and pitfalls here, so it's easier to say ask the core dev.

tawdry vapor Jul 11, 2022, 11:01 PM

#

thorny obsidian **New tags** • `!dashmpip` tag showing how to install things via pip without rel...

Feedback for future change logs: listing the relevant contributors makes the changes noisy/difficult to read. I think it would be better to create a separate section at the end that thanks all contributors, without attributing a specific change to each one.

outer oasis Jul 11, 2022, 11:02 PM

#

every damn time I always click "assign myself" on an issue

tawdry vapor Jul 11, 2022, 11:02 PM

#

It's not just you don't worry

outer oasis Jul 11, 2022, 11:06 PM

#

@fossil veldt, sir-lancebot#1072 has been approved
Thank you for your service, both to us here in this guild, and to the advancements of uwuification algorithms as a whole

dusky shoreBOT Jul 11, 2022, 11:06 PM

#

GitHub

IssueOpen .uwu command incorrectly transforms emojis in their raw text form

fossil veldt Jul 11, 2022, 11:06 PM

#

outer oasis <@233059161401720832>, sir-lancebot#1072 has been approved Thank you for your se...

firOwO

tawdry vapor Jul 11, 2022, 11:12 PM

#

I remember looking into using phonemes instead of graphemes but it turned out that there wasn't anything that can precisely map the latter to the former. If I recall correctly things like digraphs wouldn't properly be mapped, so it was difficult to generate a word that preserved the original spelling when needed.

fossil veldt Jul 11, 2022, 11:13 PM

#

tawdry vapor I remember looking into using phonemes instead of graphemes but it turned out th...

oo I was working on that

#

is this for English?

tawdry vapor Jul 11, 2022, 11:13 PM

#

Yes

#

I'm not sure if I shared the failures of my research here or if it just stayed in my head. Don't remember the exact details at this point.

fossil veldt Jul 11, 2022, 11:14 PM

#

English is essentially the most difficult language to do this in, (even more than French, which is the 2nd worse)

#

I've made an attempt at https://github.com/ionite34/Aquila-Resolve

GitHub

GitHub - ionite34/Aquila-Resolve: Augmented Recurrent Neural Graphe...

Augmented Recurrent Neural Grapheme-to-Phoneme conversion with Inflectional Orthography. - GitHub - ionite34/Aquila-Resolve: Augmented Recurrent Neural Grapheme-to-Phoneme conversion with Inflectio...

tawdry vapor Jul 11, 2022, 11:14 PM

#

All I can find is https://github.com/python-discord/sir-lancebot/pull/260#issuecomment-523621967 which is my start

fossil veldt Jul 11, 2022, 11:15 PM

#

It is the first deep learning Grapheme-to-phoneme model to preserve input part of speech tokens during training

#

and as such can resolve sentences like: (disambiguating 'read' and 'read' correctly)

g2p.convert('I read the book, did you read it?')
>> '{AY1} {R EH1 D} {DH AH0} {B UH1 K}, {D IH1 D} {Y UW1} {R IY1 D} {IH1 T}?'

tawdry vapor Jul 11, 2022, 11:15 PM

#

Sounds very cool and also very over my head 😄

fossil veldt Jul 11, 2022, 11:15 PM

#

it also can resolve the phonemes for new graphemes / made-up words

#

such as

#

c1_reg is my model, on top are Google's espeak and Deep Phonemizer

#

those mappings are from https://en.wikipedia.org/wiki/ARPABET

tawdry vapor Jul 11, 2022, 11:18 PM

#

So how can you get the map of graphemes to phonemes cause it's unclear from the example you showed

fossil veldt Jul 11, 2022, 11:18 PM

#

essentially each phoneme definitively map to an English pronunciation, unlike graphemes

fossil veldt Jul 11, 2022, 11:19 PM

#

tawdry vapor So how can you get the map of graphemes to phonemes cause it's unclear from the ...

it was a seq2seq model

#

otherwise there are dictionaries that transform well-known words

#

there are no real rules as English pronunciation is very arbitrary

#

https://github.com/cmusphinx/cmudict

fossil veldt Jul 11, 2022, 11:20 PM

#

fossil veldt https://github.com/cmusphinx/cmudict

so just using that dictionary, you could get

cmudict['abalos'] -> AA0 B AA1 L OW0 Z

tawdry vapor Jul 11, 2022, 11:21 PM

#

Let's say there was a word like aballos, so there is a digraph ll but the phoneme is still just L. You'd need to know that L covers ll.

#

That's the problem I was facing

hoary haven Jul 11, 2022, 11:21 PM

#

dusky shore >>> i'm wondewing nyani cowow it shouwd b-be

omg "what" translates to nyani
ok carry on

fossil veldt Jul 11, 2022, 11:21 PM

#

tawdry vapor Let's say there was a word like `aballos`, so there is a digraph `ll` but the ph...

well it's not really meant to go back the other way around

#

some words have different spellings but are pronounced the same

#

having the same phonemes means the word is pronounced the same, it doesn't retain the spelling information

mellow basin Jul 11, 2022, 11:22 PM

#

hoary haven omg "what" translates to nyani ok carry on

I recon LP is behind that

tawdry vapor Jul 11, 2022, 11:23 PM

#

That was the problem. If I want to uwu-ify a word, it'd be weird if the spelling change for the letters that aren't meant to be uwu-ified. It could make the word too unrecognisable.

#

Like I see "B" phoenem and say "okay this one I just want to leave as it is", but I don't know which characters that maps to in the original word. So I could just assume it maps to "b" but that may not necessarily be true since spelling rules aren't consistent.

fossil veldt Jul 11, 2022, 11:24 PM

#

tawdry vapor That was the problem. If I want to uwu-ify a word, it'd be weird if the spelling...

I think another approach may be POS-parsing

#

or interpreting whether each word is a verb / noun / tense, etc.

#

if something is a verb, you could replace it with a uwu-fied verb

#

it's obviously lossy in terms of information, but the sentence would still be valid grammatically

tawdry vapor Jul 11, 2022, 11:27 PM

#

So, the meaning of the sentence could change, but grammatically it's still valid, and the replaced word would still sound similar to the original?

fossil veldt Jul 11, 2022, 11:31 PM

#

tawdry vapor So, the meaning of the sentence could change, but grammatically it's still valid...

I suppose.. yeah pithink but that'd have problems of its own, again the loss of information is pretty high there

#

I have half a mind to just fine tune a GPT-2 model to uwu-fy text and see what happens 👀

#

Because like, uwu-fication is not just about 1:1 word transforms fundamentally right? Sometimes you need to add whole sentence parts, or express meanings in different ways.

tawdry vapor Jul 11, 2022, 11:34 PM

#

I'm not sure. I haven't analysed uwu-fication forms carefully.

#

I thought 1:1 would be a decent result anyway

cinder venture Jul 12, 2022, 12:10 AM

#

fossil veldt I have half a mind to just fine tune a GPT-2 model to uwu-fy text and see what h...

~~GPT-J~~ RunFail

gritty wind Jul 12, 2022, 2:13 AM

#

Woah policy bot got a serious UI update

#

It now actually explains stuff

#

Genuinely mind-blowing

gritty wind Jul 12, 2022, 2:38 AM

#

@tawdry vapor have you tried running the PR locally? When I merged the normal postgres with test-postgres, the tests became slow again

#

I checked that all the settings were applied in psql, so I can't quite figure out why that would be

#

The only thing that should be different is the actual prod data, but I'm not sure how that would affect it

tawdry vapor Jul 12, 2022, 2:38 AM

#

No I have not tried it yet

#

I can in a moment

#

You want me to test it as it is now, before your merging of the services?

gritty wind Jul 12, 2022, 2:40 AM

#

Yeah give it a go, though I suspect that you might not notice an improvement either way. The benefits might only be a windows thing, since CI is already 20 seconds

#

I think I'll drop my database and try again

#

This is a little funny. I dropped my main DB, recreated it from scratch with the same arguments as the test db, on the same port as the test db, but still it managed to be slower

#

I wonder...

#

Hahahahaha no way

#

The speed loss wasn't actually from the database, but the networking adaptor

#

The speed gain was because the test DB didn't define the host

#

That would also explain why the CI was so quick

tawdry vapor Jul 12, 2022, 2:54 AM

#

Sorry I am just getting around to this

#

Do you still want me to test?

#

And what do you mean by not defning a host?

gritty wind Jul 12, 2022, 2:55 AM

#

tawdry vapor Do you still want me to test?

Well, I'd be curious to see if you can replicate the same thing I have, but you don't have to

gritty wind Jul 12, 2022, 2:55 AM

#

tawdry vapor And what do you mean by not defning a host?

We went from 127.0.0.1:port:port to port:port

#

That seems to have been the only thing that made a difference

tawdry vapor Jul 12, 2022, 2:55 AM

#

🤔 that saves almost 5 minutes?

gritty wind Jul 12, 2022, 2:56 AM

#

I honestly have no idea what's up with it lol

tawdry vapor Jul 12, 2022, 2:56 AM

#

Okay let me try

gritty wind Jul 12, 2022, 2:57 AM

#

It's entirely possible I have something borked with my networking, but I can reproducibly slow it down by adding the host back in

tawdry vapor Jul 12, 2022, 3:04 AM

#

On your branch the result was 28 seconds for tests

#

On main, for some reason poetry run task test is getting hung up on something and I'm not seeing any output

#

Oh wait I forgot to restart the db

gritty wind Jul 12, 2022, 3:05 AM

#

Make sure to compose stop and start to apply the changes

tawdry vapor Jul 12, 2022, 3:05 AM

#

Yeah I pruned in between

gritty wind Jul 12, 2022, 3:05 AM

#

Perfecto

tawdry vapor Jul 12, 2022, 3:07 AM

#

It ran 96 (out of almost 300) in 49 seconds and then failed

#

django.db.utils.ProgrammingError: relation "auth_user" does not exist
LINE 1: ...user"."is_active", "auth_user"."date_joined" FROM "auth_user...

gritty wind Jul 12, 2022, 3:07 AM

#

I kept getting that error when migrations werent done

tawdry vapor Jul 12, 2022, 3:07 AM

#

I don't think it applied migrations before the test

gritty wind Jul 12, 2022, 3:07 AM

#

Ye ye

tawdry vapor Jul 12, 2022, 3:12 AM

#

It's not done yet but it's clearly taking a lot longer on main

gritty wind Jul 12, 2022, 3:12 AM

#

Feel free to call it, I think this is enough proof

tawdry vapor Jul 12, 2022, 3:12 AM

#

Just finished: 162 seconds

gritty wind Jul 12, 2022, 3:12 AM

#

Thanks for your effort

#

Ah

tawdry vapor Jul 12, 2022, 3:12 AM

#

Almost 6x slower

gritty wind Jul 12, 2022, 3:17 AM

#

I guess docker must be doing something smarter with the networking when we don't set the IP

tawdry vapor Jul 12, 2022, 3:17 AM

#

I tested on main with the modified pg command only, and it saved a negligible 1.5 seconds

#

Not enough to even rule it out of general variance for runtimes

gritty wind Jul 12, 2022, 3:18 AM

#

Yeah

#

I'm pretty sure it's just the port stuff that's affecting it at this point

patent pivot Jul 12, 2022, 3:20 AM

#

gritty wind I guess docker must be doing something smarter with the networking when we don't...

first time docker and smart have been put together

#

phone guinness

gritty wind Jul 12, 2022, 3:21 AM

#

Nah I've been running docker on my smart watch for ages

#

Joe you understand this stuff, explain pls

patent pivot Jul 12, 2022, 3:22 AM

#

i've beeeeen

#

reading over it

#

lol

#

i'm not super sure what's going on

gritty wind Jul 12, 2022, 3:23 AM

#

Alright I've pushed the changes and overwrote the old ones

#

I resubmit for your consideration

tawdry vapor Jul 12, 2022, 3:23 AM

#

I couldn't find anyone citing similar performance issues except this https://github.com/docker/for-linux/issues/169

#

I don't think it's quite the same situation though

gritty wind Jul 12, 2022, 3:24 AM

#

I found some DNS stuff, but it seems unrelated too

surreal veldt Jul 12, 2022, 6:03 AM

#

Pretty sure that in the !regex tab, the example is a bit off

#

!regex

stable mountainBOT Jul 12, 2022, 6:03 AM

#

Regular expressions
Regular expressions (regex) are a tool for finding patterns in strings. The standard library's re module defines functions for using regex patterns.

Example
We can use regex to pull out all the numbers in a sentence:

>>> import re
>>> x = "On Oct 18 1963 a cat was launched aboard rocket #47"
>>> regex_pattern = r"[0-9]{1,3}"  # Matches 1-3 digits
>>> re.findall(regex_pattern, foo)
['18', '196', '3', '47']  # Notice the year is cut off

See Also
• The re docs - for functions that use regex
• regex101.com - an interactive site for testing your regular expression

surreal veldt Jul 12, 2022, 6:04 AM

#

The foo in the findall method should be x, or the x variable should be foo

gritty wind Jul 12, 2022, 6:16 AM

#

Yes, I think you're right

cold island Jul 12, 2022, 6:16 AM

#

Wait where did foo come from lol

#

Should definitely be x

gritty wind Jul 12, 2022, 6:17 AM

#

I say x should be foo 👀

#

We'll settle this with a duel

cold island Jul 12, 2022, 6:17 AM

#

foo is for foonctions

gritty wind Jul 12, 2022, 6:17 AM

#

lmfaooooo

#

Ok you've won

atomic ivy Jul 12, 2022, 6:18 AM

#

text would be better

cold island Jul 12, 2022, 6:18 AM

#

Probably yeah

hoary haven Jul 12, 2022, 6:36 AM

#

i think scoff might have changed things around to appease my character per line limitation on macOS so that each line of code doesn't wrap

#

idk if something's changed but it currently doesn't fit on one line anyway now lol

#

hoary haven Jul 12, 2022, 6:42 AM

#

surreal veldt The `foo` in the findall method should be `x`, or the `x` variable should be `fo...

nevermind the line he was trying to make fit was a different line. ^ @wild prism wanna fix?

cold island Jul 12, 2022, 10:50 AM

#

It's just a markdown file, I can do it from the browser, sec

#

https://github.com/python-discord/bot/pull/2214

GitHub

Fix wrong var name in regex tag by mbaruh · Pull Request #2214 · py...

outer oasis Jul 12, 2022, 1:11 PM

#

Can I get a review on sir-lancebot#1073
It was mentioned in #python-discussion here: #python-discussion message
It all LGTM, but I'm not too familiar with it yet

dusky shoreBOT Jul 12, 2022, 1:11 PM

#

GitHub

PROpen Fix incorrect type hints

frozen galleon Jul 12, 2022, 3:22 PM

#

Hey, I tried running docker-compose up for the pixels repository, but for some reason it hangs on installing poetry dependencies. Specifically, the moment it reaches sniffio dependency, it just doesn't seem to be doing anything, I tried waiting it out, but that didn't help. When installing locally poetry install is finished in just a few seconds

#

Any ideas what's going on here?

vale ibex Jul 12, 2022, 3:32 PM

#

hmmm, I'm not sure, I just tried to build the docker image and it worked fine for me

#

what version of docker & docker-compose do you have installed?

frozen galleon Jul 12, 2022, 3:33 PM

#

#

it should be up to date, it's managed by my system's package manager

#

oops, forgot sudo with the second command

vale ibex Jul 12, 2022, 3:34 PM

#

yea, those are the same versions as me, so I really don't know

#

I'm using the experimental build engine though

frozen galleon Jul 12, 2022, 3:35 PM

#

yeah me neither, it's such a weird issue

#

I know that just running postgre and redis works fine

#

so it shouldn't be a docker issue

vale ibex Jul 12, 2022, 3:35 PM

#

yea, not sure

#

is it consistent?

frozen galleon Jul 12, 2022, 3:36 PM

#

well, sometimes there is some other package that's printed last, but it always stops somewhere around sniffio

#

I think that's just because of some concurrency in poetry or something

#

like here it stopped at typing extensions

#

(I've even tried bumping down sniffio to 1.0.0 which is why the version here isn't 1.2, but that didn't help)

vale ibex Jul 12, 2022, 3:39 PM

#

yae I just cleared my docker system cache and did a docker build, and it worked fine

#

so it shouldn't be anything to do with the versions etc

frozen galleon Jul 12, 2022, 3:40 PM

#

that's so weird then

#

I don't have any local changes, this is the exact version that's on github

#

hm, building it on my ubuntu based server also works without issues, so it must be some problem with my installation, but I just can't figure out what it could be

vale ibex Jul 12, 2022, 3:46 PM

#

you could try enabling experimental builds for now