#dev-contrib | Python | Page 170

vale ibex Feb 22, 2022, 9:43 PM

#

just waiting on bot-core to be merged so I can bump that

fallen patrol Feb 22, 2022, 9:44 PM

#

In the coming weeks, the core dev team will be migrating our current bots
chris does it right then, in true disnake speed

vale ibex Feb 22, 2022, 9:44 PM

#

lol

#

I've had bot and bot-core locally for a day or two now

fallen patrol Feb 22, 2022, 9:45 PM

#

2.5 will require message_content intent btw

vale ibex Feb 22, 2022, 9:45 PM

#

we're ready

fallen patrol Feb 22, 2022, 9:46 PM

#

i mean when connecting to discord

#

but there's some very nice and very fun bugs on discord's end mmlol so we haven't bumped master to v10 yet

vale ibex Feb 22, 2022, 9:46 PM

#

Is the intent itself part of 2.4?

fallen patrol Feb 22, 2022, 9:46 PM

#

no

vale ibex Feb 22, 2022, 9:46 PM

#

ahh alr

fallen patrol Feb 22, 2022, 9:46 PM

#

since the intent isn't needed to be declared on v9 or lower

vale ibex Feb 22, 2022, 9:46 PM

#

ah oki nice

fallen patrol Feb 22, 2022, 9:47 PM

#

it'd be nice if it wasn't glitched on discord's end tho

vale ibex Feb 22, 2022, 9:47 PM

#

lol

fallen patrol Feb 22, 2022, 9:47 PM

#

my test bot on v10 with the intent disabled still got message content over the HTTP api but not the gateway

#

however if i turned on the intent, then i would not receive it over HTTP

#

but would over the gateway

vale ibex Feb 22, 2022, 9:48 PM

#

fallen patrol my test bot on v10 with the intent disabled still got message content over the H...

this sounds correct though right?

#

works the same for members

fallen patrol Feb 22, 2022, 9:48 PM

#

nope, its supposed to be both

vale ibex Feb 22, 2022, 9:48 PM

#

the other two parts, not so much lol

#

oh wait, yea i get what you mean now

fallen patrol Feb 22, 2022, 9:48 PM

#

it seems to only affect bots that had the toggle on for a while, from what I tested

vale ibex Feb 22, 2022, 9:49 PM

#

You need member/message intent enabled in api portal to get via HTTP

fallen patrol Feb 22, 2022, 9:49 PM

#

ye

vale ibex Feb 22, 2022, 9:49 PM

#

you need that + declare on connection to get from gateway

fallen patrol Feb 22, 2022, 9:49 PM

#

yeah

fallen patrol Feb 22, 2022, 9:49 PM

#

fallen patrol it seems to only affect bots that had the toggle on for a while, from what I tes...

this means that @stable mountain might be affected, same with @dusky shore

#

in which case you're in a better position to have discord fix the issue than i am

#

on a new bot account they worked properly, and were both restricted

vale ibex Feb 22, 2022, 9:51 PM

#

strange

fallen patrol Feb 22, 2022, 9:52 PM

#

very

brisk brook Feb 22, 2022, 10:01 PM

#

Small nitpick @vale ibex https://github.com/python-discord/bot-core/pull/32/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR4

Why is Discord.py 2.0a0 captialized?

#

https://tenor.com/view/disintegrating-funny-thanos-gif-22399978

Tenor

vale ibex Feb 22, 2022, 10:02 PM

#

lol

#

probably because I was capitialising all instances of Discord

#

and didn't set my regex to have a negative lookahead

clever wraith Feb 22, 2022, 10:03 PM

#

I assume you used 2.4?

vale ibex Feb 22, 2022, 10:03 PM

#

^2

#

will set to 2.4 in the bots

clever wraith Feb 22, 2022, 10:03 PM

#

wait, bot core is a thing now?

#

why no #dev-announcements

vale ibex Feb 22, 2022, 10:03 PM

#

slowly becoming a thing, yea

#

using sir-robin as a catalyst for it

#

just to make sure boiler plate stuff is in there

clever wraith Feb 22, 2022, 10:04 PM

#

yikes the docs are very white

brisk brook Feb 22, 2022, 10:04 PM

#

I am sorry my nitpicks just keeps coming

#

## 1.4.0 23rd February 2022
- Feature: Migrate to disnake over discord.py 2.0a0
- Feature: Add common monkey patches
- Support: Added intersphinx to docs.

vale ibex Feb 22, 2022, 10:04 PM

#

clever wraith yikes the docs are very white

there's a dark mode 😄

brisk brook Feb 22, 2022, 10:04 PM

#

Why is there a dot at the end of the last one 😅

clever wraith Feb 22, 2022, 10:04 PM

#

oh wonderful

brisk brook Feb 22, 2022, 10:04 PM

#

lol

clever wraith Feb 22, 2022, 10:05 PM

#

there should be a dot at the end of every line!

vale ibex Feb 22, 2022, 10:05 PM

#

brisk brook Why is there a dot at the end of the last one 😅

lol you can tell which ones scale wrote and which ones I wrote

clever wraith Feb 22, 2022, 10:05 PM

#

the tense isn't even the same lmao

fallen patrol Feb 22, 2022, 10:06 PM

#

brisk brook ```markdown ## 1.4.0 23rd February 2022 - Feature: Migrate to disnake over disco...

I mean if we're gonna nitpick it:

Feature: Migrate from discord.py 2.0a0 to disnake

clever wraith Feb 22, 2022, 10:06 PM

#

we could go for a quite a bit like that

brisk brook Feb 22, 2022, 10:06 PM

#

clever wraith there should be a dot at the end of every line!

No because there's an ordered list

clever wraith Feb 22, 2022, 10:06 PM

#

did I ever have the contrib role, I don't even remember

#

not getting pings for #dev-announcements is weird

vale ibex Feb 22, 2022, 10:07 PM

#

alright updated the changelog with some better wording and grammar

clever wraith Feb 22, 2022, 10:08 PM

#

okay but those commas at the end of each bullet item is a bit cursed

vale ibex Feb 22, 2022, 10:08 PM

#

that's for the sub list

clever wraith Feb 22, 2022, 10:09 PM

#

I think bot-core is using something later than 2.0

#

younger?

#

well a bigger semver

vale ibex Feb 22, 2022, 10:10 PM

#

it's set to ^2

clever wraith Feb 22, 2022, 10:10 PM

#

it shouldn't be ^2

vale ibex Feb 22, 2022, 10:10 PM

#

so that's >=2, <3

clever wraith Feb 22, 2022, 10:10 PM

#

like I don't even think message intents are in 2.0

vale ibex Feb 22, 2022, 10:10 PM

#

message content intent isn't released yet

clever wraith Feb 22, 2022, 10:10 PM

#

wow that heart wasn't for me, okay lemon_pensive

#

:P

vale ibex Feb 22, 2022, 10:12 PM

#

lol

clever wraith Feb 22, 2022, 10:12 PM

#

I still think you should at least pin to 2.1, iirc 2.0 was quite broken

vale ibex Feb 22, 2022, 10:12 PM

#

I was gonna just do *

#

since the bots should set the version they want

#

didn't think it was worth bothering specifying a version

clever wraith Feb 22, 2022, 10:15 PM

#

I think it could be nice to avoid problems further down the line

#

will you support third party usages?

fallen patrol Feb 22, 2022, 10:17 PM

#

clever wraith I still think you should at least pin to 2.1, iirc 2.0 was quite broken

~~there is no 2.0~~

#

2.1 is the broken version IIRC

clever wraith Feb 22, 2022, 10:17 PM

#

oh really

fallen patrol Feb 22, 2022, 10:17 PM

#

by 2.2.2 its pretty stable afaik

#

and stability is just going up from there

fallen patrol Feb 22, 2022, 10:18 PM

#

vale ibex message content intent isn't released yet

Alizee: this will be in 2.5

#

pr is disnakedev/disnake#353

dusky shoreBOT Feb 22, 2022, 10:18 PM

#

GitHub

PROpen feat: support api v10

clever wraith Feb 22, 2022, 10:18 PM

#

I see

fallen patrol Feb 23, 2022, 12:06 AM

#

catsip

tawdry vapor Feb 23, 2022, 12:13 AM

#

@hoary haven I think you can push your changes to your PR. No need to wait for the other reviewer.

hoary haven Feb 23, 2022, 12:15 AM

#

ah yes, forgot. will do

fallen patrol Feb 23, 2022, 1:11 AM

#

https://github.com/python-discord/bot-core/commit/7be96c71051ee746b80a93d83f24559bfd4f0e9a
@vale ibex if you're trying to have code on sphinx autodoc you need two `

GitHub

Alter docstrings to look better in autodocs · python-discord/bot-co...

vale ibex Feb 23, 2022, 1:13 AM

#

fallen patrol > https://github.com/python-discord/bot-core/commit/7be96c71051ee746b80a93d83f24...

where?

fallen patrol Feb 23, 2022, 1:13 AM

#

https://github.com/python-discord/bot-core/commit/7be96c71051ee746b80a93d83f24559bfd4f0e9a#diff-327747c575de28147815fbfa8a01231627c5203b09462430532481f0cde25fe2R36

#

also L42

vale ibex Feb 23, 2022, 1:14 AM

#

Ah, haven't really touched that yet

#

there's a bunch of other places that do that too

fallen patrol Feb 23, 2022, 1:14 AM

#

ah

#

I learned that the hard way, so I wanted to share it with you

vale ibex Feb 23, 2022, 1:14 AM

#

Hah yea, thanks

thorny spade Feb 23, 2022, 9:36 AM

#

is there any reason to move to disnake

#

rather than other forks

green oriole Feb 23, 2022, 11:26 AM

#

Google docstring style, I approve, I approve

sleek steppe Feb 23, 2022, 12:52 PM

#

Quick PR to avoid an attribute error when the help channel cache is empty, bot#2101

dusky shoreBOT Feb 23, 2022, 12:52 PM

#

GitHub

PROpen Make sure the regex match is not None before adding to claimaints cache

gritty wind Feb 23, 2022, 1:17 PM

#

green oriole Google docstring style, I approve, I approve

You better approve on account of you voting for it 🙃

green oriole Feb 23, 2022, 1:20 PM

#

wait did we vote on that haha

#

oh riiiight

#

that rings a bell

#

feels like it was ages ago

gritty wind Feb 23, 2022, 1:22 PM

#

I did a sprint on it, then it went dormant, so yeah probably

#

12/2

#

Which uhh

#

I think that’s December why discord

green oriole Feb 23, 2022, 1:24 PM

#

sounds about right

green oriole Feb 23, 2022, 3:40 PM

#

oh I think I remember someone talking about stopping the bot from auto-joining threads

#

yeah that was changed

#

the logging system was relying on that, how did you work around it?

#

https://github.com/python-discord/bot/blob/main/bot/exts/moderation/modlog.py#L838-L844

stable mountainBOT Feb 23, 2022, 3:44 PM

#

bot/exts/moderation/modlog.py lines 838 to 844

@Cog.listener()
async def on_thread_join(self, thread: Thread) -> None:
    """Log thread creation."""
    # If we are in the thread already we can most probably assume we already logged it?
    # We don't really have a better way of doing this since the API doesn't make any difference between the two
    if thread.me:
        return```

green oriole Feb 23, 2022, 3:44 PM

#

uhh.. did you even work around it? 😅

#

or is it logging the thread every time someone joins until the bot also joins?

vale ibex Feb 23, 2022, 3:48 PM

#

on_thread_join is only triggered on create, when the bot joins, or when a cached archived thread is unarchived

#

on_thread_member_join is when other members join

vale ibex Feb 23, 2022, 3:49 PM

#

stable mountain `bot/exts/moderation/modlog.py` lines 838 to 844 ```py @Cog.listener() async def...

this should probably be updated to use something else, maybe the created at time, rather than rely on whether the bot is in the thread or not

#

(once we migrate to disnake)

#

since I don't think that data is available in discord.py

green oriole Feb 23, 2022, 3:50 PM

#

does it log the thread twice or not, then

#

I feel like it shouldn't

vale ibex Feb 23, 2022, 3:50 PM

#

right now I imagine it will log on create and when the bot joins

#

which isn't ideal

#

we should update the modlog event to look at the created time, to try and distinguish

#

once we migrate to disnake and have access to that data

green oriole Feb 23, 2022, 3:52 PM

#

vale ibex right now I imagine it will log on create and when the bot joins

but here is the thing, the thread.me attribute should be set when the bot joins, right?

vale ibex Feb 23, 2022, 3:52 PM

#

True, but I wonder if it is done so before or after the join event is triggered

#

if it's done before, then we're probably fine as-is

green oriole Feb 23, 2022, 3:54 PM

#

yeah

#

I mean, could always try it out haha

vale ibex Feb 23, 2022, 3:54 PM

#

yup

#

don't have access to my personal machine atm though, so can't myself

sleek steppe Feb 23, 2022, 3:55 PM

#

yeah I think dpy does the event handling before dispatching the event

cold island Feb 23, 2022, 4:53 PM

#

vale ibex this should probably be updated to use something else, maybe the created at time...

What does this log?

#

Is there no thread creation event?

vale ibex Feb 23, 2022, 4:57 PM

#

on_thread_join is the only event

#

and it triggers for a few reasons

#

it logs thread creations to mod log

proper flax Feb 23, 2022, 6:27 PM

#

May I ask why disnake over pycord or nextcord?

vale ibex Feb 23, 2022, 6:29 PM

#

Right now from what we can tell, disnake is more stable currently, the features are generally well implemented, implemented consistently with existing features, and are implemented in good time

#

nextcord are working on a v3 api, which we are watching closely and may migrate over to when it's ready for general consumption

hoary haven Feb 23, 2022, 6:54 PM

#

oh did i misunderstand too? @last patio

#

what is "removing the admin app"?

last patio Feb 23, 2022, 6:55 PM

#

i am removing admins from python discord

hoary haven Feb 23, 2022, 6:55 PM

#

lol gg

last patio Feb 23, 2022, 6:55 PM

#

no, basically that app looks ... like it was supposed to be a space where we build custom functionality on the django admin

#

but all it does right now is include the django admin urls in its url config

#

and the joke is, we don't even include that application

#

it's completely dead code

placid ermine Feb 23, 2022, 7:01 PM

#

yoo is that the one i pointed out

tawdry vapor Feb 23, 2022, 7:02 PM

#

If it is, good job

hoary haven Feb 23, 2022, 7:02 PM

#

14 hours later confirming yes this works. cool!

placid ermine Feb 23, 2022, 7:03 PM

#

Aha it was #dev-contrib message

hoary haven Feb 23, 2022, 7:04 PM

#

dim pelican Feb 23, 2022, 7:04 PM

#

hoary haven

Is this public?

placid ermine Feb 23, 2022, 7:04 PM

#

Wow this mina user seems like a menace

hoary haven Feb 23, 2022, 7:05 PM

#

so it's running site locally on my machine

#

and logging into the django admin portal

#

so these are infractions on my test bot/test server

dim pelican Feb 23, 2022, 7:05 PM

#

Cool cool cool

hoary haven Feb 23, 2022, 7:06 PM

#

me testing antispam

last patio Feb 23, 2022, 7:23 PM

#

aaaaaaaaaaaaaaaaaaaaaaaaaaa

hoary haven Feb 23, 2022, 7:30 PM

#

this is fine to "leak" btw right? @patent pivot ? Thinking_chief

#

pretty sure Thinking_chief

patent pivot Feb 23, 2022, 7:31 PM

#

hoary haven this is fine to "leak" btw right? <@!165023948638126080> ? <:Thinking_chief:5855...

the admin dash?

#

yeah anyone can see it

#

if they clone site

hoary haven Feb 23, 2022, 7:31 PM

#

ye ye

patent pivot Feb 23, 2022, 7:32 PM

#

if it had our data maybe not lol but otherwise you're good

hoary haven Feb 23, 2022, 7:32 PM

#

once they have SITE_ID=1 lol

green oriole Feb 23, 2022, 7:32 PM

#

Is there even any credentials for the prod admin panel

#

It was previously tied to discord OAuth, that was pretty sick

patent pivot Feb 23, 2022, 7:33 PM

#

green oriole Is there even any credentials for the prod admin panel

owners have a super user yeah

patent pivot Feb 23, 2022, 7:33 PM

#

green oriole It was previously tied to discord OAuth, that was pretty sick

yea was a bit overkill, didn't need it considering we barely used oauth2 out of that

green oriole Feb 23, 2022, 7:35 PM

#

I mean we had that for free with the wiki OAuth so why not

patent pivot Feb 23, 2022, 7:39 PM

#

green oriole I mean we had that for free with the wiki OAuth so why not

because we ditched wiki lol

#

so then we had a whole role oauth2 system for an admin panel which 12 people could access

green oriole Feb 23, 2022, 7:40 PM

#

Yeah yeah I remember that

last patio Feb 23, 2022, 7:56 PM

#

hi @trim cradle ! did you find some time to find some time to look into https://github.com/python-discord/site/issues/497?

GitHub

Smarter Resources: Document new pipeline for suggesting resources. ...

As we complete the Smarter Resources project, we'll want to carefully document precisely how a member of the community (staff member or otherwise) can suggest a new resource to be added to ...

trim cradle Feb 23, 2022, 7:58 PM

#

right, I've been meaning to respond to that

trim cradle Feb 23, 2022, 8:03 PM

#

last patio hi <@!253696366952316929> ! did you find some time to find some time to look int...

I suppose the current pipeline is fine. It might be nice if admins ask new helpers to add themselves to the registry. As it stands, it's not clear which person or combination of people have final say.

We also haven't discussed the criteria all that much. I mentioned before that I wanted to remove one of the resources, "neural networks from scratch" because it's expensive and print-on-demand, which means that we're asking our users to take on a hefty financial risk in case the resource turns out to not be useful for them. I'd rather curate resources that are easily accessible, even among those that are paid.

Should we curate pairs of interchangeable resources? My inclination is to say that if two resources are very similar, we should only keep one. We don't want to give our users option paralysis or curate so many resources that we don't help our users refine their search any better than google would.

crude gyro Feb 23, 2022, 8:08 PM

#

I don't have the answers for those questions.

#

I'm sure we can iterate on whether the pipeline is fine or not, but the more important thing is to document what the pipeline is

#

because right now I don't think we've actually written it down anywhere.

#

or am I wrong about that? @trim cradle

trim cradle Feb 23, 2022, 8:12 PM

#

crude gyro because right now I don't think we've actually written it down anywhere.

if I haven't written it down on notion somewhere, then I don't think I have. I suppose I can do that later.

Is mentioning the registry to new helpers something you can add to the onboarding procedure? The alternative would be to periodically remind people to update it.

crude gyro Feb 23, 2022, 8:13 PM

#

probably, there are helper onboarding docs on notion

#

maybe it could be added to those?

#

but I think how to contribute a resource should be documented in the repository itself, though.

trim cradle Feb 23, 2022, 8:14 PM

#

Good point

#

I need to focus on some work stuff, but I'll see about writing something this weekend.

crude gyro Feb 23, 2022, 8:15 PM

#

that'd be good. me and @last patio are working on an epic which involves improving the overall documentation and reducing the complexity of the site repo, so this would fit neatly in there

trim cradle Feb 23, 2022, 8:16 PM

#

are Volcyy and Joe's new identities part of a thing?

crude gyro Feb 23, 2022, 8:16 PM

#

no, they're just weirdos

trim cradle Feb 23, 2022, 8:17 PM

#

but they're interrelated phenomena?

#

in either case, I'm going to have nightmares.

wild prism Feb 23, 2022, 8:25 PM

#

trim cradle if I haven't written it down on notion somewhere, then I don't think I have. I s...

i dont think mentioning it in onboarding would be sufficient
the onboarding process is a bit overwhelming and i would expect new helpers to file that under "figure it out later" and then forget about it

trim cradle Feb 23, 2022, 8:26 PM

#

wild prism i dont think mentioning it in onboarding would be sufficient the onboarding proc...

it's been almost two years since I was onboarded, and from what I remember, it was basically just "u want helper?". I guess the process is different now.

#

but I see your point.

boreal nacelle Feb 23, 2022, 8:31 PM

#

vale ibex nextcord are working on a v3 api, which we are watching closely and may migrate ...

I wouldn't hold your breath for v3, I'm certain it will take quite a while to be a viable alternative compared to Nextcord v2/Disnake

#

Far enough away IMO that I don't bring it up when people ask why they should use Nextcord

vale ibex Feb 23, 2022, 8:42 PM

#

boreal nacelle I wouldn't hold your breath for v3, I'm certain it will take quite a while to be...

Yea, we discussed this with vco when making the decision.

boreal nacelle Feb 23, 2022, 8:43 PM

#

alright, wasn't sure

vale ibex Feb 23, 2022, 8:44 PM

#

No worries 😀

sleek steppe Feb 24, 2022, 4:20 AM

#

@hoary haven @spare plaza bot#2071 was merged. thank you for that cool PR lemon_fingerguns

dusky shoreBOT Feb 24, 2022, 4:20 AM

#

GitHub

PRMerged Notify helpers without ping when dormant channels are running low

hoary haven Feb 24, 2022, 4:34 AM

#

time to test it in prod LaserKeypora

magic arch Feb 24, 2022, 5:38 AM

#

brb with my alts /s

green oriole Feb 24, 2022, 6:41 AM

#

Oh god the emojis in commits

severe tangle Feb 24, 2022, 8:12 AM

#

Lmao

spare plaza Feb 24, 2022, 10:06 AM

#

green oriole Oh god the emojis in commits

amazing, right?

#

I was expecting it to be squashed to remove the emojis

#

oofers

green oriole Feb 24, 2022, 10:08 AM

#

spare plaza amazing, right?

worried_akarys

spare plaza Feb 24, 2022, 10:08 AM

#

I even do it for my work projs

#

evilkermit

#

although, the MyPy thing should have been 📢

green oriole Feb 24, 2022, 10:10 AM

#

oh god

#

oh hey what will mister @last patio lead?

static canyon Feb 24, 2022, 10:21 AM

#

green oriole oh hey what will mister <@!196989358165852160> lead?

Basically the site repo and making it more friendly to contribute to

green oriole Feb 24, 2022, 10:21 AM

#

cool

fallen patrol Feb 24, 2022, 12:34 PM

#

spare plaza I even do it for my work projs

c'mon i can't believe you've done this

#

3rd commit down, no emoji?

spare plaza Feb 24, 2022, 12:35 PM

#

that was a colleague

#

FeelsSadMan

hoary haven Feb 24, 2022, 12:49 PM

#

i do love the 🙈 for gitignore

#

um this reminds me, should the bot contributing guide be updated to match some changes we made?

#

in config-default

sleek steppe Feb 24, 2022, 12:51 PM

#

Yes

#

Feel free to make a PR for that 👍

hoary haven Feb 24, 2022, 1:00 PM

#

yeah and possibly update to staff notion as well.. i'll try to do that today

cold island Feb 24, 2022, 2:09 PM

#

hoary haven um this reminds me, should the bot contributing guide be updated to match some c...

Not necessarily. I kept it as concise as possible, and people working on the bot will most likely not touch the help system. If they do, they probably won't need to touch that override. And if they do, they can add it 😄

#

Most of the configs on that page are mandatory

vale ibex Feb 24, 2022, 2:10 PM

#

Yea, a lot of overrides can be removed from the staff config too tbh

#

since we're not actually overriding, just setting it to the same value again

sleek steppe Feb 24, 2022, 2:11 PM

#

cold island Most of the configs on that page are mandatory

Ah, wasn’t sure how accurate it had to be

cold island Feb 24, 2022, 2:12 PM

#

yeah I just made a template for the configs you had to define to run the bot on your server

hoary haven Feb 24, 2022, 2:39 PM

#

i think we changed some though

#

like the names.. i think there was one that overlapped but i'll check

cold island Feb 24, 2022, 2:44 PM

#

oh, it does include the filters and help channels configs

#

I guess we can update it, but we can also just remove those

hoary haven Feb 24, 2022, 2:49 PM

#

i'm not looking at it right now but it would be good to include those i think. who really wants like 40 test help channels

thorny obsidian Feb 24, 2022, 2:49 PM

#

@static canyon how is reminders stalled by the mod pings PR? Also which mod pings PR?

static canyon Feb 24, 2022, 2:51 PM

#

thorny obsidian <@!442244135840382978> how is reminders stalled by the mod pings PR? Also which ...

The modpings PR introduces a converter which I use in the reminder PR

#

Lemme find the #

#

bot#2001

dusky shoreBOT Feb 24, 2022, 2:51 PM

#

GitHub

PROpen Modpings Improvements

static canyon Feb 24, 2022, 2:52 PM

#

That PR adds the DayDuration converter which I use in my PR

#

~~Although actually I think I might've since redesigned it, I'm not sure~~ nvm, it will still use this

thorny obsidian Feb 24, 2022, 2:53 PM

#

Wouldn't it make more sense to use arrow since we're shifting towards more arrow usage anyway? It'll add support for human readable stuff too

static canyon Feb 24, 2022, 2:53 PM

#

I'm just using regex because that's what the modpings pr does

#

Plus arrow doesn't have one method that would solve this

thorny obsidian Feb 24, 2022, 2:54 PM

#

I'll let core devs weigh in on this, but I really enjoy the way the epoch command does it. Since we use arrow anyway, it makes more sense to me to rely on it since it's more robust in the date times it can detect

static canyon Feb 24, 2022, 2:55 PM

#

thorny obsidian Wouldn't it make more sense to use arrow since we're shifting towards more arrow...

TL;DR; is that using regex just seemed easier when I initially did this

static canyon Feb 24, 2022, 2:56 PM

#

thorny obsidian I'll let core devs weigh in on this, but I *really* enjoy the way the epoch comm...

since it's more robust in the date times it can detect
Everything I wanted to support I've got supported with my regex stuff

vale ibex Feb 24, 2022, 2:56 PM

#

static canyon Plus arrow doesn't have one method that would solve this

no, but using a combination of two would work for nearly all circumstances

#

arrow.get() and arrow.dehumanize()

thorny obsidian Feb 24, 2022, 2:57 PM

#

static canyon > since it's more robust in the date times it can detect Everything I wanted to ...

Again, I think arrow is the better option because it's far more robust, allows additional time formats, and is way more maintainable than a very complex regex.

vale ibex Feb 24, 2022, 2:57 PM

#

Yea, regex seems bad for this.

#

at face value at least

#

if there's something this regex does that the two arrow functions don't, I'm open to hear it

hoary haven Feb 24, 2022, 2:58 PM

#

one thing i would like support for, in both !remind and .epoch, is "in 1 hour"
iirc you have to do "in 1 hours"

thorny obsidian Feb 24, 2022, 2:58 PM

#

Because for mod pings I do think it would be really helpful for people to turn it off for like 2 hours and just do !mogpings off for 2 hours or whatever the syntax needs to be

static canyon Feb 24, 2022, 2:59 PM

#

I haven't got the up-to-date version on me but this shows it working with the exception of timezone support https://paste.pythondiscord.com/gobemamilo

vale ibex Feb 24, 2022, 3:01 PM

#

so, using arrow would support everything there, and would support an offset

#

with 2 function calls

#

arrow.get() to try and interpret it as a datetime stamp (Which supports many different formats), arrow.utcnow().dehumanize() to try and interpret it as an "in 1 hour" style offset

static canyon Feb 24, 2022, 3:03 PM

#

I mean I just tried one of the things work in my regex and it doesn't work with arrow

vale ibex Feb 24, 2022, 3:03 PM

#

which is?

static canyon Feb 24, 2022, 3:03 PM

#

arrow.get("2021-11-22 12:00:30pm")
Traceback (most recent call last):
  File "<pyshell#1>", line 1, in <module>
    arrow.get("2021-11-22 12:00:30pm")
  File "C:\Users\tizzy\AppData\Local\Programs\Python\Python39\lib\site-packages\arrow\api.py", line 91, in get
    return _factory.get(*args, **kwargs)
  File "C:\Users\tizzy\AppData\Local\Programs\Python\Python39\lib\site-packages\arrow\factory.py", line 254, in get
    dt = parser.DateTimeParser(locale).parse_iso(arg, normalize_whitespace)
  File "C:\Users\tizzy\AppData\Local\Programs\Python\Python39\lib\site-packages\arrow\parser.py", line 250, in parse_iso
    raise ParserError(
arrow.parser.ParserError: Invalid time component provided. Please specify a format or provide a valid time component in the basic or extended ISO 8601 time format.```

hoary haven Feb 24, 2022, 3:04 PM

#

is this a general util that can be implemented in bot-core? so that all our bots can use it?

static canyon Feb 24, 2022, 3:04 PM

#

So we wouldn't have 12/24hr support I guess when including a date

vale ibex Feb 24, 2022, 3:04 PM

#

yea, that would work if you removed the pm

#

since it infers 24 hour clock if given a date too

static canyon Feb 24, 2022, 3:05 PM

#

It apparently doesn't work with . instead of : either

#

So like 12.30pm

#

So another fix needed if we're gonna use arrow

thorny obsidian Feb 24, 2022, 3:05 PM

#

Why would you need 12.30pm?

static canyon Feb 24, 2022, 3:05 PM

#

It's just something that was asked, to have support for extra formats

static canyon Feb 24, 2022, 3:06 PM

#

vale ibex so, using arrow would support everything there, and would support an offset

So this isn't quite true

thorny obsidian Feb 24, 2022, 3:06 PM

#

I just really don't like the idea of creating our own behemoth regex which we then have to maintain. That adds a lot of complexity and will make it more difficult to add to or adjust in the future.

static canyon Feb 24, 2022, 3:06 PM

#

But could probably be made true relatively easily

static canyon Feb 24, 2022, 3:07 PM

#

thorny obsidian I just really don't like the idea of creating our own behemoth regex which we th...

I mean you never have to touch it again once it has been implemented and works

vale ibex Feb 24, 2022, 3:07 PM

#

I'd rather say it doesn't work for those esoteric formats, rather than have a large maintenance burden on a complex regex

thorny obsidian Feb 24, 2022, 3:07 PM

#

static canyon I mean you never have to touch it again once it has been implemented and works

I mean... that's not true.

static canyon Feb 24, 2022, 3:07 PM

#

Why would you need to change it if it works?

vale ibex Feb 24, 2022, 3:07 PM

#

I've never heard of a place that uses 12.30 as a time format

thorny obsidian Feb 24, 2022, 3:07 PM

#

Ideally it's true, but realisitically it's not.

#

Because you can't guarantee that it'll just work flawlessly. There will be edge cases we don't catch, especially with more esoteric formats.

static canyon Feb 24, 2022, 3:08 PM

#

vale ibex I'd rather say it doesn't work for those esoteric formats, rather than have a la...

Which is ironic given that kat literally just said arrow has better support

#

🤷

thorny obsidian Feb 24, 2022, 3:08 PM

#

It has better support for humanized timestamps and 8601 compliant timestamps...

static canyon Feb 24, 2022, 3:08 PM

#

It's not better support, it's the same support (for iso) 🤷

vale ibex Feb 24, 2022, 3:09 PM

#

Yea, I don't think either me nor kat would have imagined saying better support also means unused formats

#

since 12,30 isn't supported either

#

neither is 12;30

#

So, since we want to have support for well known formats, arrow is the best choice for that, since it's one less thing we need to maintain, and can rely on the maintainers of arrow to do that for us

static canyon Feb 24, 2022, 3:10 PM

#

I'm fine with moving to arrow, mainly because it makes the humanize part of the issue easier, I just don't get why you both feel the need to shit on my code with reasons which aren't even correct

vale ibex Feb 24, 2022, 3:12 PM

#

We aren't shitting on your code, I'm sure it works for what you intended it to do, what I'm saying is that I don't think having it in the code base would be the best option, if one of our dependencies does what we wanted already, with minimal code changes

thorny obsidian Feb 24, 2022, 3:13 PM

#

I don't think I ever "shit" on your code. All I've been saying is that I think arrow is the better choice because it reduces maintenance burden and is robust with the timeformats it supports, including humanized time formats.

vale ibex Feb 24, 2022, 3:13 PM

#

the best code is no code, second to that is minimal code

static canyon Feb 24, 2022, 3:13 PM

#

vale ibex We aren't shitting on your code, I'm sure it works for what you intended it to d...

Right yeah, that makes sense

static canyon Feb 24, 2022, 3:14 PM

#

thorny obsidian I don't think I ever "shit" on your code. All I've been saying is that I think a...

I still don't understand the maintenance thing. Why is a regex less maintainable?

thorny obsidian Feb 24, 2022, 3:14 PM

#

static canyon I still don't understand the maintenance thing. Why is a regex less maintainable...

Because trying to understand and parse regex, including the validation of it particularly for edge cases, requires a significant amount of effort compared to 2 function calls.

static canyon Feb 24, 2022, 3:15 PM

#

Hmm

#

I don't really see how

#

Either way you've still got to test it

#

I guess it's just the understanding of the regex

tawdry vapor Feb 24, 2022, 3:16 PM

#

Arrow has a test suite for what it's worth.

static canyon Feb 24, 2022, 3:17 PM

#

tawdry vapor Arrow has a test suite for what it's worth.

Fair enough. I had implemented a test suite for my stuff but I guess as Chris said, it's better to avoid adding code where we can

tawdry vapor Feb 24, 2022, 3:17 PM

#

Yes technically if we want to be strictly black box we still need our own tests but I don't that we want to be so strict necessarily

static canyon Feb 24, 2022, 3:18 PM

#

Yeah

#

So in terms of the edge cases @vale ibex (like not supporting am/pm) how would I fix those? Just not allow am/pm input and assume 24hr?

tawdry vapor Feb 24, 2022, 3:18 PM

#

If you already wrote tests they could possibly be used still

static canyon Feb 24, 2022, 3:20 PM

#

tawdry vapor If you already wrote tests they could possibly be used still

It's specific to my regex based thing though

#

And apparently we want to be using arrow instead

#

Another thing arrow doesn't support (not having padded times)```py

arrow.get("2021-11-22 9:30:00")
Traceback (most recent call last):
File "<pyshell#7>", line 1, in <module>
arrow.get("2021-11-22 9:30:00")
File "C:\Users\tizzy\AppData\Local\Programs\Python\Python39\lib\site-packages\arrow\api.py", line 91, in get
return _factory.get(*args, **kwargs)
File "C:\Users\tizzy\AppData\Local\Programs\Python\Python39\lib\site-packages\arrow\factory.py", line 254, in get
dt = parser.DateTimeParser(locale).parse_iso(arg, normalize_whitespace)
File "C:\Users\tizzy\AppData\Local\Programs\Python\Python39\lib\site-packages\arrow\parser.py", line 250, in parse_iso
raise ParserError(
arrow.parser.ParserError: Invalid time component provided. Please specify a format or provide a valid time component in the basic or extended ISO 8601 time format.```

#

Honestly when I'm seeing the things that arrow doesn't support, it makes me want to just use the regex because that does support it

thorny obsidian Feb 24, 2022, 3:21 PM

#

You can add formats for arrow to parse.

tawdry vapor Feb 24, 2022, 3:21 PM

#

Well if the goal is the same then the test cases should be the same and ideally your tests aren't written such that they're tightly coupled to the implementation.so I assumed they can be reused

static canyon Feb 24, 2022, 3:21 PM

#

thorny obsidian You can add formats for arrow to parse.

But then I'm having to list every possible format that we allow. Rather than just using my regex which automatically accounts for all of them

static canyon Feb 24, 2022, 3:22 PM

#

tawdry vapor Well if the goal is the same then the test cases should be the same and ideally ...

Right yeah, true. I'd just need to see whether arrow objects == datetime object equivalent

tawdry vapor Feb 24, 2022, 3:23 PM

#

For the most part they are. A few attributes behave differently

static canyon Feb 24, 2022, 3:23 PM

#

I'll mess around with it and see

#

Should hopefully be fine

#

If I really need to I can account for the differences

tawdry vapor Feb 24, 2022, 3:23 PM

#

You can directly compare with datetime

static canyon Feb 24, 2022, 3:23 PM

#

mhm

tawdry vapor Feb 24, 2022, 3:23 PM

#

Or use .datetime to convert it if you must

static canyon Feb 24, 2022, 3:24 PM

#

>>> arrow.get("2021-11-22 00:00:00") == datetime.datetime.fromisoformat("2021-11-22 00:00:00")
False```oof

tawdry vapor Feb 24, 2022, 3:24 PM

#

That's probably tz diff

static canyon Feb 24, 2022, 3:25 PM

#

Right, yeah

tawdry vapor Feb 24, 2022, 3:25 PM

#

Latter is naive

static canyon Feb 24, 2022, 3:26 PM

#

tawdry vapor That's probably tz diff

>>> arrow.get("2021-11-22 00:00:00") == datetime.datetime.fromisoformat("2021-11-22 00:00:00").replace(tzinfo=datetime.timezone.utc)
True```Yep, it was

#

So I'll just have to account for naivety

#

Which I don't think will actually be an issue since my test datetimes are all set to UTC

#

>>> london_time = datetime.datetime.fromisoformat("2021-11-22-00:00:00").replace(tzinfo=pytz.timezone("Europe/London"))
>>> paris_time = datetime.datetime.fromisoformat("2021-11-22 00:01:00").replace(tzinfo=pytz.timezone("Europe/Paris"))
>>> london_time == paris_time
```how can I get this to work? Comparing different timezones (Paris is one hour ahead of London so this should be true)

tawdry vapor Feb 24, 2022, 3:31 PM

#

Not sure. I would have expected that to work.

static canyon Feb 24, 2022, 3:32 PM

#

Rip

#

Guess I'll look it up

tawdry vapor Feb 24, 2022, 3:34 PM

#

Oh well you changed the minutes instead of hours

#

It does compare correctly if you fix that and covert them to arrow objects

#

But still False with just datetime

static canyon Feb 24, 2022, 3:36 PM

#

tawdry vapor Oh well you changed the minutes instead of hours

Huh, so I did

static canyon Feb 24, 2022, 3:37 PM

#

tawdry vapor It does compare correctly if you fix that and covert them to arrow objects

How do I convert to arrow?

tawdry vapor Feb 24, 2022, 3:37 PM

#

arrow.get(dt_object)

#

No idea why datetime fails I thought it would work

cold island Feb 24, 2022, 3:58 PM

#

static canyon So I'll just have to account for naivety

I think you can assume UTC if no TZ is provided

vale ibex Feb 24, 2022, 4:09 PM

#

arrow.get does that by default iirc

cold island Feb 24, 2022, 8:20 PM

#

I have commit 91621bc7 from the bot. How can I open it on github?

patent pivot Feb 24, 2022, 8:20 PM

#

cold island I have commit `91621bc7` from the bot. How can I open it on github?

https://github.com/python-discord/bot/commit/91621bc7

GitHub

Merge pull request #2071 from minalike/feature/nonpinging-helper-no...

Notify helpers without ping when dormant channels are running low

clever wraith Feb 24, 2022, 8:27 PM

#

git show locally

cold island Feb 24, 2022, 8:42 PM

#

patent pivot https://github.com/python-discord/bot/commit/91621bc7

oh that was easier than I thought lol

static canyon Feb 24, 2022, 9:10 PM

#

If I'm working on a site PR, how can I make my bot repo interact with my local site again?

#

I namely need the clean logs part of site

#

Currently the url is showing as http://staff.web:8000/bot/logs/1

hoary haven Feb 24, 2022, 9:10 PM

#

those somehow just worked™️ for me

#

but i run locally, and only use docker for site
idk if that has smth to do with it?

static canyon Feb 24, 2022, 9:11 PM

#

🤷

#

I'm running bot with docker compose run bot and trying to access the clean logs

clever wraith Feb 24, 2022, 9:12 PM

#

Your url settings are wrong, it changed recently

#

Look at the staff server notion page, it is updated

hoary haven Feb 24, 2022, 9:13 PM

#

http://localhost:8000/staff/bot/logs/1/ for me

static canyon Feb 24, 2022, 9:14 PM

#

hoary haven http://localhost:8000/staff/bot/logs/1/ for me

Web, that works

#

Thanks

#

Now I just need to update the config file to reflect that

hoary haven Feb 24, 2022, 9:15 PM

#

this is what i have

urls:
    # PyDis site vars
    site:        &DOMAIN       "localhost:8000"
    site_api:    &API    !JOIN [*DOMAIN, "/api"]
    site_api_schema:           "http://"
    site_paste:  &PASTE  !JOIN ["paste.", "pythondiscord.com"]
    site_schema: &SCHEMA       "http://"
    site_staff:  &STAFF  !JOIN [*DOMAIN, "/staff"]

    paste_service:                      !JOIN ["https://", *PASTE, "/{key}"]
    site_logs_view:                     !JOIN [*SCHEMA, *STAFF, "/bot/logs"]```

static canyon Feb 24, 2022, 9:15 PM

#

This is what I just changed it to```yml
site: &DOMAIN "localhost:8000"
site_api: &API !JOIN [*DOMAIN, "/api"]
site_paste: &PASTE !JOIN ["paste.", "pythondiscord.com"]
site_schema: &SCHEMA "http://"
site_staff: &STAFF !JOIN [*DOMAIN, "/staff"]

paste_service:                      !JOIN ["https://", *PASTE, "/{key}"]
site_logs_view:                     !JOIN [*SCHEMA, *STAFF, "/bot/logs"]```

#

That seems to be the same

#

So should be good

#

Thanks

#

Now if I make changes to my local site repo, how do I make it so that bot will run that changed site repo?

#

Or is that just done by default?

#

Guess not lolpy aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host localhost:8000 ssl:default [Connect call failed ('127.0.0.1', 8000)] 2022-02-24 21:19:35 | bot | CRITICAL | Could not connect to site API. Is it running? ERROR: 69

sleek steppe Feb 24, 2022, 9:20 PM

#

Is the site running on localhost:8000?

static canyon Feb 24, 2022, 9:21 PM

#

I'm trying stuff right now

#

If I do docker-compose up in the site repo, it starts up

#

But then when I do docker-compose run bot in the bot repo, it says the port is already taken (it basically tries to start site even though I've already got it running)

#

PS C:\Users\tizzy\bot> docker-compose run bot
Creating network "bot_default" with the default driver
Creating bot_snekbox_1  ... done
Creating bot_postgres_1 ... done
Creating bot_redis_1    ... done
Creating bot_metricity_1 ... done
Creating bot_web_1       ...
Creating bot_web_1       ... error

ERROR: for bot_web_1  Cannot start service web: driver failed programming external connectivity on endpoint bot_web_1 (14f14a45c4ea9f680f6f3e681b9804c24b04273e679148eccf3923b9a7d427d5): Bind for 127.0.0.1:8000 failed: port is already allocated

ERROR: for web  Cannot start service web: driver failed programming external connectivity on endpoint bot_web_1 (14f14a45c4ea9f680f6f3e681b9804c24b04273e679148eccf3923b9a7d427d5): Bind for 127.0.0.1:8000 failed: port is already allocated
ERROR: Encountered errors while bringing up the project.```

#

And same thing for docker-compose up in the bot repo

hoary haven Feb 24, 2022, 9:24 PM

#

if you want an alternative, i do the steps here and use docker-compose up web only for the site, and run the bot in a local venv https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/bot/#with-the-bot-running-locally

Python Discord - Contributing to Bot

A guide to setting up and configuring Bot.

static canyon Feb 24, 2022, 9:26 PM

#

You can run additional services on the host, but this guide won't go over how to install and start them in this way. If possible, prefer to start the services through Docker to replicate the production environment as much as possible.

The site, however, is a mandatory service for the bot. Refer to the previous section and the site contributing guide to learn how to start it on the host, in which case you will need to change urls.site in config.yml to wherever the site is being hosted.

#

That second paragraph says I need to update the env var to point to where I'm running site locally

#

But I do that and then it just tries to restart it

#

Might have fixed it

#

nvm

#

I've got no clue what I'm doing now

#

If I have site running separately, it gives an error because it tries to start it up itself.

If I don't have site running separately, then site starts when I run bot, but bot fails to connect to it

#

brazen charm Feb 24, 2022, 9:37 PM

#

you can use a compose override file to prevent site from starting with bot

static canyon Feb 24, 2022, 9:38 PM

#

brazen charm you can use a compose override file to prevent site from starting with bot

What do you mean?

hoary haven Feb 24, 2022, 9:38 PM

#

static canyon > You can run additional services on the host, but this guide won't go over how ...

did you do the steps in the section preceding that though?

#

from "With the Bot Running Locally"

brazen charm Feb 24, 2022, 9:39 PM

#

static canyon What do you mean?

a docker-compose.override.yml file that changes the web service to not start if you're already running it youself. e.g. I use this to stop the bot from starting

version: "3.7"

services:

  bot:
    profiles:
      - ignore

static canyon Feb 24, 2022, 9:39 PM

#

Hmm

#

Which repo do I put that in?

#

bot I guess?

brazen charm Feb 24, 2022, 9:40 PM

#

yes, as that's where you want to prevent the site to start in

#

don't know what the relation error is though as I usually also skip metricity

static canyon Feb 24, 2022, 9:42 PM

#

So I guess I'd ignore web and postgres?

#

Currently getting thispy PS C:\Users\tizzy\bot> docker-compose up ERROR: The Compose file is invalid because: Service site has neither an image nor a build context specified. At least one must be provided. @brazen charm

brazen charm Feb 24, 2022, 9:44 PM

#

I think it's web in the bot's compose

static canyon Feb 24, 2022, 9:44 PM

#

Right, yea

#

ERROR: Service "web" was pulled in as a dependency of service "bot" but is not enabled by the active profiles. You may fix this by adding a common profile to "web" and "bot".```

#

Now this

brazen charm Feb 24, 2022, 9:45 PM

#

I guess you'll also need to override bot to not depend on web

static canyon Feb 24, 2022, 9:48 PM

#

brazen charm I guess you'll also need to override bot to not depend on web

Overrode it but same erroryml bot: << : *logging << : *restart_policy build: context: . dockerfile: Dockerfile volumes: - .:/bot:ro tty: true env_file: - .env depends_on: [] environment: BOT_API_KEY: badbot13m0n8f570f942013fc818f234916ca531

brazen charm Feb 24, 2022, 9:49 PM

#

You'll need to specify the depends_on key without the web service (and only that)

static canyon Feb 24, 2022, 9:49 PM

#

Hmm

brazen charm Feb 24, 2022, 9:49 PM

#

the override is merged into the normal compose iirc

static canyon Feb 24, 2022, 9:49 PM

#

brazen charm You'll need to specify the depends_on key without the web service (and only that...

So how do I do that?

brazen charm Feb 24, 2022, 9:50 PM

#

  bot:
    depends_on:
      - the_items_that_are_not_web

static canyon Feb 24, 2022, 9:50 PM

#

I've got that

#

Still not working

#

      depends_on:
        - snekbox
        - redis```

#

Same with just snekbox / just redis

#

Just removed from the main docker-compose for now

brazen charm Feb 24, 2022, 9:53 PM

#

Not sure if it's also merging that, maybe assigning it some normal value but that may break things

#

yeah that'll also wokr

static canyon Feb 24, 2022, 9:54 PM

#

It's still failing to connect to site

#

2022-02-24 21:54:36 | bot | CRITICAL |
...
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host localhost:8000 ssl:default [Connect call failed ('127.0.0.1', 8000)]
2022-02-24 21:54:36 | bot | CRITICAL | Could not connect to site API. Is it running?```

#

And I did do docker-compose up in site

brazen charm Feb 24, 2022, 9:56 PM

#

can you access it from the browser?

static canyon Feb 24, 2022, 9:57 PM

#

brazen charm can you access it from the browser?

Yes

#

It loads the pydis.com homepage (but on localhost)

brazen charm Feb 24, 2022, 9:59 PM

#

try 127.0.0.1 instead of localhost

static canyon Feb 24, 2022, 10:00 PM

#

Okay

static canyon Feb 24, 2022, 10:01 PM

#

brazen charm try 127.0.0.1 instead of localhost

Assuming you meant in the bot's config, that didn't work

brazen charm Feb 24, 2022, 10:02 PM

#

not sure then if http is set. I'd go through the hosts file aliases as those solved a similar issue before

static canyon Feb 24, 2022, 10:03 PM

#

what do you mean?

brazen charm Feb 24, 2022, 10:05 PM

#

https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/hosts-file/

Python Discord - Preparing Your Hosts file

How to setup your hosts file for project usage.

#

and then using pythondiscord.local

static canyon Feb 24, 2022, 10:07 PM

#

Apparently my host file already has something for 127.0.0.1

#

127.0.0.1 kubernetes.docker.internal```

brazen charm Feb 24, 2022, 10:09 PM

#

shouldn't matter

static canyon Feb 24, 2022, 10:10 PM

#

Okay, added

#

It works in the browser

#

Time to see whether bot likes it

#

Nope, it doesn't

#

Still fails to connect @brazen charm

#

aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host pythondiscord.local:8000 ssl:default [Connect call failed ('127.0.0.1', 8000)]
2022-02-24 22:10:41 | bot | CRITICAL | Could not connect to site API. Is it running?```

brazen charm Feb 24, 2022, 10:11 PM

#

what does the config look like?

static canyon Feb 24, 2022, 10:11 PM

#

site:        &DOMAIN       "pythondiscord.local:8000"
site_staff:  &STAFF  !JOIN [*DOMAIN, "/staff"]

site_logs_view:                     !JOIN [*SCHEMA, *STAFF, "/bot/logs"]```

#

Those are the three relevant bits

brazen charm Feb 24, 2022, 10:12 PM

#

is the schema set?

static canyon Feb 24, 2022, 10:13 PM

#

Right, yeah

#

site_schema: &SCHEMA       "http://"```

clever wraith Feb 24, 2022, 10:14 PM

#

I don't think it will go through the host hosts file

#

you should use web:8000

brazen charm Feb 24, 2022, 10:15 PM

#

oh it's in docker

#

glossed over that

static canyon Feb 24, 2022, 10:15 PM

#

I had that earlier and it didn't work

#

But I'll try I guess

brazen charm Feb 24, 2022, 10:15 PM

#

it may need site_web or something like that

clever wraith Feb 24, 2022, 10:16 PM

#

are you not using the COMPOSE_PROJECT_NAME env var?

static canyon Feb 24, 2022, 10:16 PM

#

I am

clever wraith Feb 24, 2022, 10:16 PM

#

it should be using the same network then

#

you can try to take stuff down (explicitely with the command) and try again

static canyon Feb 24, 2022, 10:18 PM

#

Got a massive error

#

Basicallypy web_1 | connection = Database.connect(**conn_params) web_1 | File "/usr/local/lib/python3.9/site-packages/psycopg2/__init__.py", line 127, in connect web_1 | conn = _connect(dsn, connection_factory=connection_factory, **kwasync) web_1 | psycopg2.OperationalError: FATAL: the database system is shutting down

#

Hmm that seems to have just been bad timing

#

Think it's fine

clever wraith Feb 24, 2022, 10:19 PM

#

yeah the bot started too fast

static canyon Feb 24, 2022, 10:20 PM

#

Starting pydis-testing_snekbox_1 ...
Starting pydis-testing_snekbox_1    ... error
Starting pydis-testing_redis_1      ...
WARNING: Host is already in use by another container

ERROR: for pydis-testing_snekbox_1  Cannot start service snekbox: driver failed programming external connectivity on endpoint pydis-testing_snekbox_1 (f31d95944ea3f5946d079361174a933e28803b9e4174742dfa4d9d56b30f67ab): Bind for 127.0.0.1:8060 failed: port is already allocated
Starting pydis-testing_redis_1      ... error

ERROR: for pydis-testing_redis_1  Cannot start service redis: driver failed programming external connectivity on endpoinRecreating pydis-testing_postgres_1 ... done
ed: port is already allocated
pydis-testing_metricity_1 is up-to-date

ERROR: for snekbox  Cannot start service snekbox: driver failed programming external connectivity on endpoint pydis-testing_snekbox_1 (f31d95944ea3f5946d079361174a933e28803b9e4174742dfa4d9d56b30f67ab): Bind for 127.0.0.1:8060 failed: port is already allocated

ERROR: for redis  Cannot start service redis: driver failed programming external connectivity on endpoint pydis-testing_redis_1 (b66684f7324dedefa34457a3afc0f567571f29fb0f2e1ca33acaa696ebacdd3a): Bind for 127.0.0.1:6379 failed: port is already allocated
ERROR: Encountered errors while bringing up the project.```

clever wraith Feb 24, 2022, 10:20 PM

#

can you docker ps?

static canyon Feb 24, 2022, 10:20 PM

#

static canyon Feb 24, 2022, 10:20 PM

#

clever wraith can you `docker ps`?

dc781ee168b5   ghcr.io/python-discord/metricity:latest   "bash entry_point.sh"    3 minutes ago    Restarting (1) 15 seconds ago                              pydis-testing_metricity_1
15ef75f5489a   redis:5.0.9                               "docker-entrypoint.s…"   15 minutes ago   Up 14 minutes                   127.0.0.1:6379->6379/tcp   bot_redis_1
7a9fe5630e4f   ghcr.io/python-discord/snekbox:latest     "gunicorn -c config/…"   15 minutes ago   Up 14 minutes                   127.0.0.1:8060->8060/tcp   bot_snekbox_1```

clever wraith Feb 24, 2022, 10:21 PM

#

you have something that is still up

#

you gotta take it down first

static canyon Feb 24, 2022, 10:22 PM

#

How?

clever wraith Feb 24, 2022, 10:22 PM

#

docker-compose down

static canyon Feb 24, 2022, 10:22 PM

#

I have

#

On both terminals

#

But there's still something running

clever wraith Feb 24, 2022, 10:23 PM

#

yes

#

hmm

static canyon Feb 24, 2022, 10:23 PM

#

Closed it from Docker Desktop

#

Now, let's try this again

clever wraith Feb 24, 2022, 10:24 PM

#

ah it is from before the rename

static canyon Feb 24, 2022, 10:24 PM

#

clever wraith ah it is from before the rename

Yeah

#

As soon as I start bot, the terminal where I started site gets spammed with errors

#

And then the bot terminal gets spammed too

clever wraith Feb 24, 2022, 10:25 PM

#

this is fresh instance, right?

static canyon Feb 24, 2022, 10:25 PM

#

#

The bot thing seems to just be that error

clever wraith Feb 24, 2022, 10:26 PM

#

can you docker-compose down --volumes and try again?

static canyon Feb 24, 2022, 10:26 PM

#

There was definnitely nothing running

#

I did docker ps and it was empty

clever wraith Feb 24, 2022, 10:26 PM

#

yeah but volumes

static canyon Feb 24, 2022, 10:27 PM

#

Apparently there's volumes in use

#

I can't seem to shut them down though

clever wraith Feb 24, 2022, 10:27 PM

#

hmmm

static canyon Feb 24, 2022, 10:27 PM

#

clever wraith Feb 24, 2022, 10:28 PM

#

I guess you can down first without volumes and then with

static canyon Feb 24, 2022, 10:28 PM

#

I guess they're from before the rename

#

Yeah, I removed the COMPOSE env var thing and now they're gone

#

#

#

So now I try starting site, and then bot? @clever wraith

clever wraith Feb 24, 2022, 10:29 PM

#

yep

static canyon Feb 24, 2022, 10:30 PM

#

No errors now

#

But it's stuck on bot_1 | 2022-02-24 22:30:34 | bot | INFO | Attempting site connection: 1/3

clever wraith Feb 24, 2022, 10:31 PM

#

what is your site url set to

#

and also do you get any error

static canyon Feb 24, 2022, 10:32 PM

#

static canyon No errors now

^

static canyon Feb 24, 2022, 10:32 PM

#

clever wraith what is your site url set to

web:8000

clever wraith Feb 24, 2022, 10:32 PM

#

it should timeout after a bit

#

hmm

static canyon Feb 24, 2022, 10:32 PM

#

Ah, it's on try 2/3 now

#

Just took a long time to timeout

#

As in, 60 seconds

#

So looks like it's still not working

#

bot_1        | 2022-02-24 22:30:34 | aioredis | DEBUG | Creating tcp connection to ('redis', 6379)
bot_1        | 2022-02-24 22:30:34 | bot | INFO | Attempting site connection: 1/3
bot_1        | 2022-02-24 22:31:54 | bot | INFO | Attempting site connection: 2/3
bot_1        | 2022-02-24 22:33:14 | bot | INFO | Attempting site connection: 3/3
bot_1        | ...
bot_1        | 2022-02-24 22:34:29 | bot | CRITICAL |
bot_1        | ....
bot_1        | aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host web:8000 ssl:default [None]
bot_1        | 2022-02-24 22:34:30 | bot | CRITICAL | Could not connect to site API. Is it running?``` @clever wraith

clever wraith Feb 24, 2022, 10:35 PM

#

hmm

#

schema is http?

static canyon Feb 24, 2022, 10:35 PM

#

Yeah

clever wraith Feb 24, 2022, 10:35 PM

#

can you resend your url?

static canyon Feb 24, 2022, 10:36 PM

#

urls:
    # PyDis site vars
    site:        &DOMAIN       "web:8000"
    site_api:    &API    !JOIN [*DOMAIN, "/api"]
    site_paste:  &PASTE  !JOIN ["paste.", "pythondiscord.com"]
    site_schema: &SCHEMA       "http://"
    site_staff:  &STAFF  !JOIN [*DOMAIN, "/staff"]

    paste_service:                      !JOIN ["https://", *PASTE, "/{key}"]
    site_logs_view:                     !JOIN [*SCHEMA, *STAFF, "/bot/logs"]```

#

Ah wait, I'm not using the COMPOSE env var

clever wraith Feb 24, 2022, 10:36 PM

#

what is your ALLOWED_HOSTS set to?

#

ah well, that'll do it haha

static canyon Feb 24, 2022, 10:36 PM

#

Had to remove it to get rid of the volumes

#

Forgot to add it back

#

Let's try again 🤞

#

I think it's working

#

Had a few issues but fixed them

#

Seems to be up

#

Perfect, it's up

#

Thank you very much @clever wraith! ducky_party

clever wraith Feb 24, 2022, 10:46 PM

#

cool, you're welcome

thorny spade Feb 25, 2022, 12:57 AM

#

https://github.com/python-discord/sir-lancebot/pull/1041
can anyone review?

GitHub

truncate output. by MaskDuck · Pull Request #1041 · python-discord/...

Relevant Issues

Close #990
Description
I have truncated the output using the shorten_output method, limit the output to be 99980* character.
(*) the reason why is it 99980 is there should be 20 c...

hoary haven Feb 25, 2022, 2:11 AM

#

all the front-end peeps, now's your chance to weigh in EYES site#682
is it fine to have a br inside a span? is it worth avoiding if it Still Works™️?

dusky shoreBOT Feb 25, 2022, 2:11 AM

#

GitHub

PROpen Add channel ID to message deletion logs

green oriole Feb 25, 2022, 6:07 AM

#

I think it is fine as it is, it would avoid messing with margins and stuff

thorny spade Feb 25, 2022, 10:00 AM

#

https://github.com/python-discord/sir-robin/issues/3

GitHub

Add Github Workflows · Issue #3 · python-discord/sir-robin

I'd like to port some of the Github CI workflows we have in Sir Lancebot and Python to Sir Robin. The main workflows that would be beneficial: lint & test build status embed

#

can i be assigned to this

hoary haven Feb 25, 2022, 1:16 PM

#

dusky shore

oki I've approved it as is

#

the commit title is wrong though
I think it's worth fixing but will defer to core devs

molten perch Feb 25, 2022, 5:17 PM

#

thorny spade https://github.com/python-discord/sir-robin/issues/3

Hey! Sorry, but the Events team decided, that it's best if this PR is done by a staff member!
Although, there are many issues out there, go ahead and fine another one! 🙂
Thank you, and I'm sorry for the inconvenience!

thorny obsidian Feb 25, 2022, 6:14 PM

#

!source superstarify

stable mountainBOT Feb 25, 2022, 6:14 PM

#

Command: superstarify

Temporarily force a random superstar name (like Taylor Swift) to be the user's nickname.

Source Code

Go to GitHub

thorny obsidian Feb 25, 2022, 6:15 PM

#

I know, I wanted to look at the source code myself. That was the fastest way to do so

#

It's the function above: https://github.com/python-discord/bot/blob/main/bot/exts/moderation/infraction/superstarify.py#L36

stable mountainBOT Feb 25, 2022, 6:17 PM

#

bot/exts/moderation/infraction/superstarify.py line 36

async def on_member_update(self, before: Member, after: Member) -> None:```

thorny obsidian Feb 25, 2022, 6:17 PM

#

It listens for everytime a member is trying to change their nickname. If they do and they have an active superstarify infraction, it reverts it

static canyon Feb 25, 2022, 6:29 PM

#

It is, if you're using listeners

#

@bot.event can only have one
@bot.listen() or @commands.Cog.listener() can have multiple

fallen patrol Feb 25, 2022, 8:13 PM

#

@clever wraith its not possible to remove the nickname permission from a user without having a whitelist role that gives it to everyone else unfortunately

#

hence python listens for every member update and changes the nickname back if its changed during that period

fallen patrol Feb 26, 2022, 12:09 AM

#

zig lmao

#

🥲 discord/discord-api-docs#4571

dusky shoreBOT Feb 26, 2022, 12:11 AM

#

GitHub

PROpen fix: mark channel name as nullable

stable mountainBOT Feb 26, 2022, 12:17 AM

#

You are not allowed to use that command here. Please use the #bot-commands channel instead.

sleek steppe Feb 26, 2022, 12:23 AM

#

I’m pretty sure there are some badges that are inaccessible from the API

fallen patrol Feb 26, 2022, 12:23 AM

#

^^

#

nitro isn't visible from the api, and i'm not sure about boosting

patent pivot Feb 26, 2022, 12:26 AM

#

boosting is iirc

#

!int e author.premium_since

stable mountainBOT Feb 26, 2022, 12:27 AM

#

In [49]: author.premium_since
Out[49]: 
datetime.datetime(2019, 6, 10, 19, 7, 12, 423000, tzinfo=datetime.timezone.utc)```

patent pivot Feb 26, 2022, 12:27 AM

#

slightly™️

fallen patrol Feb 26, 2022, 12:27 AM

#

patent pivot boosting is iirc

but that only shows for this server, iirc

patent pivot Feb 26, 2022, 12:27 AM

#

yea

#

!user

stable mountainBOT Feb 26, 2022, 12:28 AM

#

Haz-Mat (joe#6000)

partner hypesquad_balance early_supporter verified_bot_dev

User information

Created: <t:1459415175:R>
Profile: @patent pivot
ID: 165023948638126080

Member information

Joined: <t:1484070095:R>
Roles: <@&267627879762755584>, <@&267628507062992896>, <@&807415650778742785>, <@&587606783669829632>, <@&409416496733880320>, <@&797752289771126784>, <@&491583790448246785>, <@&721459198839357490>, <@&267630620367257601>, <@&585529568383860737>, <@&323426753857191936>, <@&295488872404484098>, <@&764802720779337729>, <@&463658397560995840>

Activity

Messages: 119,638
Activity blocks: 19,432

Infractions

Total: 0
Active: 0

patent pivot Feb 26, 2022, 12:28 AM

#

good command

cold island Feb 26, 2022, 1:13 AM

#

fallen patrol 🥲 discord/discord-api-docs#4571

mmm I might not be reading it right, but isn't it covered by the channel field having that ?? https://discord.com/developers/docs/resources/channel#channel-object

Discord Developer Portal

Discord Developer Portal — API Docs for Bots and Developers

Integrate your service with Discord — whether it's a bot or a game or whatever your wildest imagination can come up with.

fallen patrol Feb 26, 2022, 1:13 AM

#

no, that means that the field may not exist

cold island Feb 26, 2022, 1:13 AM

#

ah

fallen patrol Feb 26, 2022, 1:14 AM

#

the second ? which that pr adds means that the field may be nullable

cold island Feb 26, 2022, 1:14 AM

#

But yeah, my issue is as edge as an edge case might be 😅

fallen patrol Feb 26, 2022, 1:14 AM

#

well uh

#

it led me to find another bug in the library, and so far 2-3 discord api bugs catsip

cold island Feb 26, 2022, 1:15 AM

#

lolol

#

I thought this might happen

fallen patrol Feb 26, 2022, 1:15 AM

#

some of these bugs existing for 5+ years

fallen patrol Feb 26, 2022, 1:15 AM

#

cold island I thought this might happen

pithink

cold island Feb 26, 2022, 1:17 AM

#

nothing profound, I just figured it might not be the only place where something like that happens, and not surprised the lib has old bugs

fallen patrol Feb 26, 2022, 1:17 AM

#

true

thorny spade Feb 26, 2022, 4:14 AM

#

molten perch Hey! Sorry, but the Events team decided, that it's best if this PR is done by a ...

fallen patrol Feb 26, 2022, 7:21 AM

#

cold island mmm I might not be reading it right, but isn't it covered by the `channel` field...

I really thought I sent this easier, sorry about that https://discord.com/developers/docs/reference#nullable-and-optional-resource-fields

Discord Developer Portal

Discord Developer Portal — API Docs for Bots and Developers

Integrate your service with Discord — whether it's a bot or a game or whatever your wildest imagination can come up with.

cold island Feb 26, 2022, 10:51 AM

#

fallen patrol I really thought I sent this easier, sorry about that https://discord.com/develo...

np, I understood your explanation, thanks

placid ermine Feb 26, 2022, 11:07 AM

#

hi could i get a review on bot#2039 🥺

dusky shoreBOT Feb 26, 2022, 11:07 AM

#

GitHub

PROpen Disallow Editing Infraction Durations Into The Past

thorny spade Feb 26, 2022, 11:35 AM

#

can i got a review on sir-lancebot#1034

dusky shoreBOT Feb 26, 2022, 11:35 AM

#

GitHub

IssueOpen Add a Wordle command

thorny spade Feb 26, 2022, 11:35 AM

#

wait

#

not this

#

sir-lancebot#1041

dusky shoreBOT Feb 26, 2022, 11:36 AM

#

GitHub

PROpen truncate output.

thorny spade Feb 26, 2022, 11:36 AM

#

this one i suppose

trim cradle Feb 26, 2022, 2:39 PM

#

@last patio I'm offloading responsibility for the resource contribution guide.

last patio Feb 26, 2022, 3:05 PM

#

alright 👍

austere hornet Feb 26, 2022, 4:17 PM

#

Do you mean the !user command? If so, the "activity blocks" means how many 10-minute blocks you were active for on the server I think

crude gyro Feb 26, 2022, 5:37 PM

#

@thorny obsidian would you be willing to review https://github.com/python-discord/site/pull/683 ?

@last patio has been working on it to address some of your confusion about which different parts do what in the site project, and I'm too familiar with Django to be a reasonable reviewer.

This is just the first of many PRs, of course.

GitHub

Add a README for the project directory, remove unused apps by jchri...

Closes #676.

green oriole Feb 26, 2022, 5:54 PM

#

It could be interesting to look at some Django resources in there, I think

#

RP has a whole series on the lib I believe

thorny obsidian Feb 26, 2022, 6:02 PM

#

crude gyro <@!212644551926611969> would you be willing to review https://github.com/python-...

Of course! I can review it later today or tomorrow (parents currently visiting)

crude gyro Feb 26, 2022, 6:07 PM

#

sounds good, kat. lemon_hyperpleased

#

it'll keep for a few days

last patio Feb 26, 2022, 6:08 PM

#

lemon I have an ew pr

#

it fixes all the useless output from python manage.py test

#

so it just displays dots now as it should

crude gyro Feb 26, 2022, 6:12 PM

#

very nice

#

'I can review it, link me

last patio Feb 26, 2022, 6:16 PM

#

https://github.com/python-discord/site/pull/684

GitHub

Remove test warnings & logline, prevent introducing them again in t...

Closes #671

#

if you pass the wrong datetime kind django will now throw up with an exact stacktrace at test run time

#

and the infraction viewset was updated as well, to query aware to aware instances

crude gyro Feb 26, 2022, 6:23 PM

#

reviewed but I don't get it @last patio

last patio Feb 26, 2022, 6:24 PM

#

fixed

#

@crude gyro@crude gyro@crude gyro@crude gyro@crude gyro

crude gyro Feb 26, 2022, 6:29 PM

#

okay @last patiothis was a success.

last patio Feb 26, 2022, 6:31 PM

#

thanks

trim cradle Feb 26, 2022, 7:26 PM

#

why is there no #dev-make-site-good

#

or #dev-site-engooden

cold island Feb 26, 2022, 9:05 PM

#

https://discordpy.readthedocs.io/en/master/ext/commands/api.html?highlight=context#discord.ext.commands.Context.invoke will call the function without using converters etc.
Is there a way to call a command with conversion?

brisk brook Feb 26, 2022, 9:26 PM

#

cold island https://discordpy.readthedocs.io/en/master/ext/commands/api.html?highlight=conte...

You get the command and call await commnad.invoke(ctx)

#

https://github.com/Rapptz/discord.py/blob/master/discord/ext/commands/core.py#L885

stable mountainBOT Feb 26, 2022, 9:26 PM

#

discord/ext/commands/core.py line 885

async def invoke(self, ctx: Context) -> None:```

cold island Feb 26, 2022, 9:27 PM

#

brisk brook You get the command and call `await commnad.invoke(ctx)`

hmm yeah but then I can't specify the args

brisk brook Feb 26, 2022, 9:29 PM

#

You cannot, no. You need to modify ctx and change the args 😵‍💫

sleek steppe Feb 26, 2022, 9:36 PM

#

Is there a reason why !d discord links nextcord?

cold island Feb 26, 2022, 9:36 PM

#

brisk brook You cannot, no. You need to modify `ctx` and change the args 😵‍💫

hmmm not exactly. I bypassed the issue though, thanks!

#

!help d

stable mountainBOT Feb 26, 2022, 9:37 PM

#

Command Help

!docs [symbol_name]
Can also use: d, doc

Look up documentation for Python symbols.

Subcommands:

!docs cleardoccache <package_name>
Clear the persistent redis cache for package.
!docs deletedoc <package_name>
Removes the specified package from the database.
!docs getdoc [symbol_name]
Return a documentation embed for a given symbol.
!docs refreshdoc
Refresh inventories and show the difference.
!docs setdoc <package_name> <inventory> [base_url]
Adds a new documentation metadata object to the site's database.

cold island Feb 26, 2022, 9:37 PM

#

!docs getdoc

fervent sage Feb 26, 2022, 9:37 PM

#

Why can i use those buttons lol

stable mountainBOT Feb 26, 2022, 9:37 PM

#

All inventories (`41` total)

• blessed
• botcore
• dateutil
• discordpy
• disnake
• django
• flask

cold island Feb 26, 2022, 9:37 PM

#

fervent sage Why can i use those buttons lol

because I didn't limit it lol

#

!d discord

stable mountainBOT Feb 26, 2022, 9:38 PM

#

discord

To work with the library and the Discord API in general, we must first create a Discord Bot account.

Creating a Bot account is a pretty straightforward process.

cold island Feb 26, 2022, 9:38 PM

#

interesting

#

It might be because nextcord was the last to be added?

#

or because it's the last on the list out of the wrappers

#

!src docs

stable mountainBOT Feb 26, 2022, 9:40 PM

#

Command: docs

Look up documentation for Python symbols.

Source Code

Go to GitHub

sleek steppe Feb 26, 2022, 9:42 PM

#

fervent sage Why can i use those buttons lol

Yeah there’s an open issue for that

vale ibex Feb 26, 2022, 9:45 PM

#

cold island https://discordpy.readthedocs.io/en/master/ext/commands/api.html?highlight=conte...

You could call https://github.com/Rapptz/discord.py/blob/master/discord/ext/commands/converter.py#L1097 for each param

stable mountainBOT Feb 26, 2022, 9:45 PM

#

discord/ext/commands/converter.py line 1097

async def run_converters(ctx: Context, converter, argument: str, param: inspect.Parameter):```

cold island Feb 26, 2022, 9:52 PM

#

oh that's a thing

vale ibex Feb 26, 2022, 9:52 PM

#

Yea, but you need to pass it the converter still, and call each param

cold island Feb 26, 2022, 9:52 PM

#

But it looks a bit awkward

vale ibex Feb 26, 2022, 9:52 PM

#

so it's not much better

cold island Feb 26, 2022, 9:53 PM

#

I'm only dealing with one param at a time so it's not the end of the world, but creating that Parameter object seems annoying

#

I have a thing that works, so I'll stick with it for now

vale ibex Feb 26, 2022, 9:54 PM

#

👌

austere hornet Feb 27, 2022, 1:54 AM

#

Does anyone know something similar to wait_for() for buttons in dpy? When I try to use wait_for() it doesn't work and I also tried using this and it isn't working either:

@commands.Cog.listener()
async def on_interaction(interaction: discord.Interaction):
    await interaction.respond("houston we got an interaction")

Would appreciate some help with this. Thanks!

fallen patrol Feb 27, 2022, 3:37 AM

#

respond isn't an attribute on any interaction object in dpy

#

its send

austere hornet Feb 27, 2022, 3:55 AM

#

fallen patrol its send

Ahh, thanks

hoary haven Feb 28, 2022, 1:06 AM

#

reviews welcome on bot#2069

dusky shoreBOT Feb 28, 2022, 1:06 AM

#

GitHub

PROpen Ping Moderators On Bad Words In Username, Also Checks For Bad Words When Joining Or Switching Voicechannels

hoary haven Feb 28, 2022, 1:07 AM

#

That Title Case pain

sleek steppe Feb 28, 2022, 1:07 AM

#

that's a very long PR title lemon_eyes

hoary haven Feb 28, 2022, 1:07 AM

#

(also i'm gonna try reviewing your PR @placid ermine)

hoary haven Feb 28, 2022, 1:08 AM

#

sleek steppe that's a very long PR title <:lemon_eyes:754441879885447296>

i tried

sleek steppe Feb 28, 2022, 1:09 AM

#

hmm, what's the reason we should check usernames when joining/switching voice channels?

hoary haven Feb 28, 2022, 1:10 AM

#

we've had a couple times users in vc reported users joining with Bad Usernames
getting an alert will allow us to address these users even if they're not reported

#

i think griff originally implemented it to only be initial voice join, but looks like along the way it was changed? not too sure on this one

sleek steppe Feb 28, 2022, 1:13 AM

#

yeah, https://github.com/python-discord/bot/pull/2069#discussion_r805439538

placid ermine Feb 28, 2022, 2:25 AM

#

hoary haven (also i'm gonna try reviewing your PR <@!787351231332483102>)

🙏

fallen patrol Feb 28, 2022, 3:16 AM

#

hoary haven we've had a couple times users in vc reported users joining with Bad Usernames g...

so it seems like this is possible for a user to bypass if they change their nickname while they are in a voice channel, no?

#

join vc with clean name
change nickname
no ping, and bypassed the system

#

ooh but i did look at the code and the solution to the above should be pretty easy to implement (hopefully)

#

    @Cog.listener()
    async def on_member_update(self, before: Member, after: Member) -> None:
        if before.display_name == after.display_name:
          return
        if after.voice is None:
          return
        await self.check_bad_words_in_name(after)

#

although hm, is pydis caching voice states

#

yeah it caches the entire server

cold island Feb 28, 2022, 4:53 AM

#

fallen patrol ooh but i did look at the code and the solution to the above should be pretty ea...

Even if this wasn't possible, the goal is not to make it inescapable, but to catch more cases

fallen patrol Feb 28, 2022, 5:08 AM

#

ah, makes sense

fallen patrol Feb 28, 2022, 5:27 AM

#

although the above code paired with the existing would prevent all bypasses

clever wraith Feb 28, 2022, 4:41 PM

#

hoary haven That Title Case <:pain:901259818239655946>

I was about to say

hoary haven Feb 28, 2022, 4:47 PM

#

if i want to review someone's PR and it's on a branch of their own fork, what do i do
git remote add upstream their_repo.git ?

tawdry vapor Feb 28, 2022, 4:49 PM

#

hoary haven if i want to review someone's PR and it's on a branch of their own fork, what do...

You could, but I use

git fetch origin refs/pull/12345/head && git checkout FETCH_HEAD

Where 12345 is the PR number

#

Good enough for looking at and running the code, but not if you want to make changes and push them

#

In your ~/.gitconfig you can create an alias ```
[alias]
cpr = "!cd ${GIT_PREFIX:-.} && git fetch origin refs/pull/${1}/head && git checkout FETCH_HEAD #"

hoary haven Feb 28, 2022, 4:50 PM

#

my origin is my own fork though. i suppose i should use 'upstream' ?

tawdry vapor Feb 28, 2022, 4:50 PM

#

Yeah

hoary haven Feb 28, 2022, 4:51 PM

#

sigh i think i'm on old pwsh and && doesn't work lol

clever wraith Feb 28, 2022, 4:52 PM

#

To be honest I recommend the gh CLI client

tawdry vapor Feb 28, 2022, 4:52 PM

#

Just make it separate commands

clever wraith Feb 28, 2022, 4:52 PM

#

With it you can just do gh pr checkout 12345

#

Also I don't know if y'all are still on Linode, but they are being acquired by Akamai

#

https://www.linode.com/blog/linode/linode-and-akamai/

hoary haven Feb 28, 2022, 5:06 PM

#

gh cli sounds good

#

but thanks mark i'm now in a detached HEAD state but that's to be expected, i think

placid ermine Feb 28, 2022, 5:09 PM

#

french noblemen in 1789:

hoary haven Feb 28, 2022, 6:03 PM

#

@clever wraith preferred protocal for git operations: https vs ssh
does it matter?

brazen charm Feb 28, 2022, 6:04 PM

#

shouldn't really matter for unauthenticated

clever wraith Feb 28, 2022, 6:06 PM

#

Depends on what you use

#

If you use ssh, use ssh

#

If you use http, use http

tawdry vapor Feb 28, 2022, 6:11 PM

#

hoary haven but thanks mark i'm now in a detached HEAD state but that's to be expected, i th...

Yeah it's gonna be detatched which is what I was alluding to when I said that it's not good if you need to push changes to that branch

hoary haven Feb 28, 2022, 6:11 PM

#

GraphQL: Could not resolve to a PullRequest with the number of 2032. (repository.pullRequest)```

![shrug](https://cdn.discordapp.com/emojis/332268181517238272.webp?size=128 "shrug")

tawdry vapor Feb 28, 2022, 6:11 PM

#

No idea I don't use gh cli

hoary haven Feb 28, 2022, 6:13 PM

#

oh wait i'm using wrong number

#

no one saw that

clever wraith Feb 28, 2022, 6:14 PM

#

Haha

last patio Mar 1, 2022, 12:12 AM

#

mark that cpr thing is super smart

tawdry vapor Mar 1, 2022, 12:16 AM

#

last patio mark that cpr thing is super smart

Thank you. I am filled with joy to finally receive praise for my beautiful git aliases. They are excellent. They have saved my poor frail hands from many keystrokes.

outer oasis Mar 1, 2022, 1:33 AM

#

Where do the "GitHub Actions" embeds in #dev-log come from?

#

Selecting "Send me everything" with a webhook on GitHub only creates embeds from "GitHub"

torpid grotto Mar 1, 2022, 1:37 AM

#

outer oasis Where do the "GitHub Actions" embeds in <#622895325144940554> come from?

https://github.com/SebastiaanZ/github-status-embed-for-discord

GitHub

GitHub - SebastiaanZ/github-status-embed-for-discord: Send an enhan...

Send an enhanced GitHub Actions status embed to a Discord webhook. - GitHub - SebastiaanZ/github-status-embed-for-discord: Send an enhanced GitHub Actions status embed to a Discord webhook.

austere hornet Mar 1, 2022, 2:28 AM

#

torpid grotto https://github.com/SebastiaanZ/github-status-embed-for-discord

.bm

sleek steppe Mar 1, 2022, 3:12 AM

#

Hello, I'm looking at bot#2107, it looks good to me, but would it be better include moderators in the interaction check since we do this for pagination and deletion emojis, or leave it as-is?

dusky shoreBOT Mar 1, 2022, 3:12 AM

#

GitHub

PROpen fix: Make the help command's button only work for author

hoary haven Mar 1, 2022, 3:27 AM

#

(WAHHH the gh cli tool is so cool)

hoary haven Mar 1, 2022, 3:29 AM

#

sleek steppe Hello, I'm looking at bot#2107, it looks good to me, but would it be better incl...

do you mean how mods are able to use the paginate & trash can emojis even if it's an embed invoked by someone else?

#

i think that'd be nice. on occasion i've pushed other mods' buttons on a help embed they've invoked

#

i think we might expect the same behavior across all

sleek steppe Mar 1, 2022, 3:31 AM

#

cool cool. cc @torpid grotto

hoary haven Mar 1, 2022, 3:32 AM

#

it might even be necessary, if there are users for whatever reason spamming large embeds in python-general.. unless the trash can emoji still checks

torpid grotto Mar 1, 2022, 3:32 AM

#

First time contributing so just making sure https://github.com/python-discord/bot/blob/91621bc7ef590118e91bbb2e387db5e14128b530/bot/constants.py#L711 this is the list of IDs I use when checking correct?

stable mountainBOT Mar 1, 2022, 3:32 AM

#

bot/constants.py line 711

STAFF_ROLES = Guild.staff_roles```

hoary haven Mar 1, 2022, 3:33 AM

#

i think the one above it is the moderation role

torpid grotto Mar 1, 2022, 3:33 AM

#

Alright I'll do the moderation roles one

hoary haven Mar 1, 2022, 3:34 AM

#

(if that's what the current behavior is for other things @sleek steppe?)

sleek steppe Mar 1, 2022, 3:34 AM

#

yeah 👍

hoary haven Mar 1, 2022, 3:57 AM

#

@placid ermine can you test smth like this

#

this is the resulting log

#

is that right though? it appears to tell me that the mute has failed bc the time is in the past, nothing appears in the modlog, the user doesn't get the muted role. but i still have to unmute them to remute them correctly

#

this is bot#2039

dusky shoreBOT Mar 1, 2022, 4:01 AM

#

GitHub

PROpen Disallow Editing Infraction Durations Into The Past

hoary haven Mar 1, 2022, 4:01 AM

#

the infraction ID also still gets incremented

placid ermine Mar 1, 2022, 4:02 AM

#

interesting

#

oh.

#

so
i put my check inside the apply_infraction function
but the bot posts the infraction to the db before that function is called

#

hmm although

#

@hoary haven i think this doesnt happen for infraction edits, could you confirm that

hoary haven Mar 1, 2022, 4:16 AM

#

like will it let me edit a "failed" mute to end in the future?

#

probably?

#

#

before this the most recent infrac was 34

placid ermine Mar 1, 2022, 4:18 AM

#

mm good catch btw

hoary haven Mar 1, 2022, 4:18 AM

#

thank you :D not that we ever use iso lmao

#

#

i tried editing a valid existing mute to a date in the past, and it failed (as it should), and the original mute duration seems to hold (as it should)

placid ermine Mar 1, 2022, 4:24 AM

#

okay i think ill need to put the checks for mute, ban and voice_mute individually

#

because all the commands seem to post the infraction to the api before calling apply_infraction

#

wait

hoary haven Mar 1, 2022, 4:29 AM

#

or maybe revert the PR to just disallowing infraction edits into the past?

placid ermine Mar 1, 2022, 4:29 AM

#

huhhh

#

ohhh

#

fuck

#

i see whats wrong

#

so the flow goes something like

post infraction to site api
try to apply infraction by adding role/kicking/banning etc
if this fails, delete infraction from api
my mistake was returning immediately upon finding the duration is in the past, and thus not executing step 3

hoary haven Mar 1, 2022, 4:38 AM

#

that sounds right to me..

#

yeah, bc i can use !ban with dates in the past and it shows up in the infraction search despite the user not actually being banned

placid ermine Mar 1, 2022, 4:43 AM

#

okay so trying to apply the check between (1) and (2), skipping (2) and doing (3) is going to become pretty messy

placid ermine Mar 1, 2022, 4:43 AM

#

placid ermine okay i think ill need to put the checks for mute, ban and voice_mute individuall...

ill do this

#

(ie, before (1))

hoary haven Mar 1, 2022, 4:44 AM

#

maybe check with a core dev.. bc the portion of the code change that actually disallows editing infractions into the past works fine right?

placid ermine Mar 1, 2022, 4:46 AM

#

yeah edits work fine

hoary haven Mar 1, 2022, 4:46 AM

#

the part of disallowing past-date expirations to start with might be better in a separate issue < is what i'm unsure about

placid ermine Mar 1, 2022, 4:46 AM

#

applying doesnt

#

okay

#

ill revert that commit

#

(maybe)

fallen patrol Mar 1, 2022, 5:21 AM

#

thonk this seems new

#

NVM DO NOT USE THAT

#

github why

#

they don't use their key to sign those commits when you rebase on github 🥲

tawdry vapor Mar 1, 2022, 5:22 AM

#

This is a problem with rebasing through the site in general.

#

Including merging a PR via a rebase.

fallen patrol Mar 1, 2022, 5:24 AM

#

I was all ready to not actually start my editor and use that.... indeed, its not possible

tawdry vapor Mar 1, 2022, 5:24 AM

#

The other problem with online rebases is that it changes the committer date to the current time, so all commits appear to have happened at the same time (cause the web UI uses the committer date rather than the author date).

fallen patrol Mar 1, 2022, 5:25 AM

#

;-;

#

I mean, given this particular project the screenshot is from uses squash only, its probably fine

obsidian patio Mar 1, 2022, 8:09 AM

#

Could some core dev review this? It’s had 3 approving reviews (from staff members) for a month
https://github.com/python-discord/sir-lancebot/pull/988

dusky shoreBOT Mar 1, 2022, 8:10 AM

#

GitHub

PROpen Add Twemoji utility command

cold island Mar 1, 2022, 11:58 AM

#

placid ermine so the flow goes something like 1) post infraction to site api 2) try to apply i...

Why not make the check in the converter?

placid ermine Mar 1, 2022, 11:58 AM

#

interesting

cold island Mar 1, 2022, 11:59 AM

#

If you don't want to apply it to all ISOs, you can inherit from the ISO converter and add the check after the super call

#

like FutureISODatetime or something

placid ermine Mar 1, 2022, 12:02 PM

#

the docstring of Duration suggests that its going to be in the future https://github.com/python-discord/bot/blob/main/bot/converters.py#L349

cold island Mar 1, 2022, 12:02 PM

#

And Expiry naturally needs to use it instead

stable mountainBOT Mar 1, 2022, 12:02 PM

#

bot/converters.py line 349

async def convert(self, ctx: Context, duration: str) -> datetime:```

placid ermine Mar 1, 2022, 12:02 PM

#

wait wrong line

#

https://github.com/python-discord/bot/blob/main/bot/converters.py#L351

stable mountainBOT Mar 1, 2022, 12:02 PM

#

bot/converters.py line 351

Converts a `duration` string to a datetime object that's `duration` in the future.```

cold island Mar 1, 2022, 12:02 PM

#

Of Duration yes

#

Not ISODateTime

#

Expiry is a Union of the two

placid ermine Mar 1, 2022, 12:02 PM

#

hmm

vale ibex Mar 1, 2022, 12:06 PM

#

Does the bot use the convertor on startup when pulling infractions to schedule?

#

or does it just use the raw json from site?

placid ermine Mar 1, 2022, 12:06 PM

#

we dont need a check there do we? a bad duration shouldnt make it to the db

vale ibex Mar 1, 2022, 12:07 PM

#

It's a valid use case that on start up an infraction would be in the past

#

if it expired while the bot was down

placid ermine Mar 1, 2022, 12:07 PM

#

hmm 🤔

cold island Mar 1, 2022, 12:07 PM

#

I don't think it uses the converter

vale ibex Mar 1, 2022, 12:07 PM

#

cold island I don't think it uses the converter

Alright cool, should be fine then

cold island Mar 1, 2022, 12:07 PM

#

At least from what I recall when converting everything to TZ aware

vale ibex Mar 1, 2022, 12:08 PM

#

I can't imagine it would, since we'd need to call convert manually

cold island Mar 1, 2022, 12:08 PM

#

yeah I think I just made it use arrow.get

vale ibex Mar 1, 2022, 12:08 PM

#

👌

placid ermine Mar 1, 2022, 12:08 PM

#

so i inherit ISODateTime, call super().convert in this convert, and raise an exception if its in the past?

cold island Mar 1, 2022, 12:08 PM

#

placid ermine so i inherit ISODateTime, call super().convert in this convert, and raise an exc...

yep

placid ermine Mar 1, 2022, 12:08 PM

#

👍

cold island Mar 1, 2022, 12:08 PM

#

And change Expiry to use it instead

placid ermine Mar 1, 2022, 12:09 PM

#

right

#

and do i need to add anything in the error handler or smthn

cold island Mar 1, 2022, 12:09 PM

#

Nope, it handles BadArgument already

placid ermine Mar 1, 2022, 12:10 PM

#

cool cool

green oriole Mar 1, 2022, 12:12 PM

#

Make sure you raise BadArgument and not any built-in exception

placid ermine Mar 1, 2022, 12:16 PM

#

yeah noted

#

uhh

#

instead of sending an error message

#

if the conversion to datetime raises the exception it changes the reason to be the string

#

green oriole Mar 1, 2022, 12:25 PM

#

Oh that's interesting

#

It is because of the function signature

cold island Mar 1, 2022, 12:25 PM

#

yeah the next arg is a str

green oriole Mar 1, 2022, 12:26 PM

#

Yeah then you probably want to check it inside the command itself

#

There is probablyyyyy a way around it

#

But I personally don't think that's a good idea, although we shall ask mister zebra right there

cold island Mar 1, 2022, 12:26 PM

#

well what's the workaround

placid ermine Mar 1, 2022, 12:27 PM

#

does it do this for all exceptions or just BadArgument

cold island Mar 1, 2022, 12:27 PM

#

I think for all Discord errors?

#

not sure

#

hmm

#

Ok so

#

The issue is that the date arg is optional

#

So it does fix it for warns, mutes, etc.

#

It doesn't fix it for bans, edits, appends, instead causing unexpected behavior

placid ermine Mar 1, 2022, 12:31 PM

#

ig i could make a decorator which checks that the date arg is not in the past?

cold island Mar 1, 2022, 12:33 PM

#

That could work yeah

green oriole Mar 1, 2022, 1:16 PM

#

cold island well what's the workaround

raise a custom exception that isn't recognized by disnake, but is recognized by the error handler as BadArgument

placid ermine Mar 1, 2022, 1:17 PM

#

decorator works

placid ermine Mar 1, 2022, 2:29 PM

#

@hoary haven should be fixed now btw

hoary haven Mar 1, 2022, 2:38 PM

#

cool
one thing i noticed yesterday is that sometimes running !infr search would work and other times it wouldn't
2022-03-01 09:37:22 | bot.exts.backend.error_handler | DEBUG | Command infraction search invoked by mina✯✩✯#0001 with error CheckFailure: The check functions for command infraction search failed.
any idea why?

vale ibex Mar 1, 2022, 2:41 PM

#

Did you run it in a non-mod channel?

hoary haven Mar 1, 2022, 2:42 PM

#

yes. yes i did lol

#

time to add 🟠 emoji to category names

torpid grotto Mar 1, 2022, 3:06 PM

#

Is anyone able to review bot#2107

dusky shoreBOT Mar 1, 2022, 3:06 PM

#

GitHub

PROpen fix: Make the help command's button only work for author

brisk brook Mar 1, 2022, 3:07 PM

#

I was planning to do so later today when I get home (in an hour) 💯

#

The code looks good, just needs testing

torpid grotto Mar 1, 2022, 3:08 PM

#

So far I've tested with roles, without and with other people who aren't the author of the message

gaunt cypress Mar 1, 2022, 3:43 PM

#

Hi I was just wondering why don't we separate frontend from backend into different repository

thorny obsidian Mar 1, 2022, 3:46 PM

#

gaunt cypress Hi I was just wondering why don't we separate frontend from backend into differe...

frontend and backend for what? Site?

gaunt cypress Mar 1, 2022, 3:46 PM

#

Yep

thorny obsidian Mar 1, 2022, 3:46 PM

#

Because there's no need for that with django and how we do our markdown rendering

gaunt cypress Mar 1, 2022, 3:47 PM

#

thinkmon

#

Imo it will separate the jobs better

#

But ok I guess thanks

thorny obsidian Mar 1, 2022, 3:49 PM

#

gaunt cypress Imo it will separate the jobs better

have you looked at our site repo and how it's set up? Some things are a bit more intricately linked and wouldn't really benefit from the separation like our forms application does

gritty wind Mar 1, 2022, 8:27 PM

#

Site backend is mostly already separated anyway

#

It’s almost entirely in the API folder

#

I say almost entirely because of a couple other apps which are technically backend, but nothing backend beside the api has been worked on in years

#

That’s just admin and mod logs

sleek steppe Mar 1, 2022, 8:41 PM

#

@torpid grotto bot#2104 has been merged. Thanks for the PR!

dusky shoreBOT Mar 1, 2022, 8:41 PM

#

GitHub

IssueClosed Limit users interaction on mod embeds

sleek steppe Mar 1, 2022, 8:42 PM

#

bot#2107 *

dusky shoreBOT Mar 1, 2022, 8:42 PM

#

GitHub

PRMerged fix: Make the help command's button only work for author

torpid grotto Mar 1, 2022, 8:42 PM

#

py_guido

cold island Mar 1, 2022, 10:13 PM

#

Why are we running actions on drafts 🤔

brazen charm Mar 1, 2022, 10:15 PM

#

why not?

cold island Mar 1, 2022, 10:27 PM

#

Well, they're drafts. I'm pushing commits without expecting them to succeed

brazen charm Mar 1, 2022, 10:29 PM

#

test can be useful for others, along with the previews

#

and it's free

cold island Mar 1, 2022, 10:30 PM

#

true, I guess I'm a little annoyed by the emails 😅

tawdry vapor Mar 1, 2022, 10:32 PM

#

It's possible to disable notifications for actions

#

I don't see why one would want notifications for that generally

#

Maybe if the actions take hours

gritty wind Mar 1, 2022, 10:44 PM

#

I don’t remember if there’s a setting for it or not (there almost definitely is), but you can filter your incoming emails for a CC to ci_activity@noreply.github.com and never see another ever again

dusky shoreBOT Mar 1, 2022, 11:21 PM

#

GitHub

PROpen More Message Link Unfurls

molten perch Mar 2, 2022, 10:38 AM

#

I believe so, yes.

dim pelican Mar 2, 2022, 12:32 PM

#

@surreal veldt , @austere hornet when the command is called without a sub-command, it attempts to directly convert the string using PIL's ImageColor.getrgb(). It then sets the name based on converting the rgb value to hex, and then looking up the hex value from the referenced color list. This could be a case where the fuzzy matching has a score of at least 80, and "matches" the hex value #008000 to Black. Using .color name green works as intended

surreal veldt Mar 2, 2022, 12:42 PM

#

dim pelican <@!751814647346102303> , <@!853309207922212965> when the command is called witho...

oh okay, thanks!

#

so what's needed would be adjusting the fuzzy matching?

dim pelican Mar 2, 2022, 12:43 PM

#

Yes, but that would run the risk of then not matching other inputs that are correct

austere hornet Mar 2, 2022, 1:14 PM

#

dim pelican <@!751814647346102303> , <@!853309207922212965> when the command is called witho...

Oh I see, thanks for letting me know!

last patio Mar 2, 2022, 6:53 PM

#

site will no longer produce any warnings while running tests! Thanks to @tawdry vapor and @crude gyro for reviews. If everything is green, running tests locally will now look like this:

vale ibex Mar 2, 2022, 6:54 PM

#

last patio site will no longer produce any warnings while running tests! Thanks to <@!13707...

Can we change the dots to stickbug

crude gyro Mar 2, 2022, 6:55 PM

#

nice work @last patio, that's much cleaner

hoary haven Mar 2, 2022, 6:55 PM

#

what did it look like before?

crude gyro Mar 2, 2022, 6:55 PM

#

a deluge of irrelevant warnings and logging

tawdry vapor Mar 2, 2022, 6:55 PM

#

that's a nice word lemon

#

can I save it?

crude gyro Mar 2, 2022, 6:56 PM

#

you save what you need, Mark my good friend

tawdry vapor Mar 2, 2022, 6:56 PM

#

thanks!

crude gyro Mar 2, 2022, 6:56 PM

#

(also I don't know what that means, how do you save someone's word)

tawdry vapor Mar 2, 2022, 6:57 PM

#

haha

dim pelican Mar 2, 2022, 6:57 PM

#

Deluge™️ copyrighted by: lemon

last patio Mar 2, 2022, 7:01 PM

#

vale ibex Can we change the dots to <a:stickbug:854906946925494283>

sure

vale ibex Mar 2, 2022, 7:01 PM

#

last patio sure

thanks

tawdry vapor Mar 2, 2022, 7:01 PM

#

@last patio what did you think of my proposals in the Poetry commands issue? I am keen on the last one, which makes manage.py a Poetry script and removes the taskipy stuff

last patio Mar 2, 2022, 7:01 PM

#

no problem

last patio Mar 2, 2022, 7:03 PM

#

tawdry vapor <@!196989358165852160> what did you think of my proposals in the Poetry commands...

I think that's nice, well, personally i'm a fan of just using the stock manage.py, but I think that won't work with our setup due to how django-bulma's theming works

#

so no way around collectstatic

tawdry vapor Mar 2, 2022, 7:03 PM

#

Do you not see the value our custom one provides to new contributors?

#

Setting up an admin account, API key, etc

#

In any case that seems orthogonal to this issue

last patio Mar 2, 2022, 7:06 PM

#

tawdry vapor Do you not see the value our custom one provides to new contributors?

Mark I am the worst person to ask this. I love manual work that makes me feel like I'm in control. Having a script that sets environment variables for me is some kind of satanic bible for me. I do think it's convenient, but I haven't changed my .env file since I started work on Django back in '04

tawdry vapor Mar 2, 2022, 7:06 PM

#

This revelation does not bode well for your project lead position

last patio Mar 2, 2022, 7:07 PM

#

Thanks Mark

#

I think manage.py tasks are a nice idea though. Removing dependencies is always good

austere hornet Mar 2, 2022, 7:08 PM

#

I like the DevOps role icon!

clever wraith Mar 2, 2022, 7:09 PM

#

Pydis is moving to Amazon lambda

austere hornet Mar 2, 2022, 7:09 PM

#

Ic

tawdry vapor Mar 2, 2022, 7:09 PM

#

last patio Thanks Mark

I jest. You're great

clever wraith Mar 2, 2022, 7:09 PM

#

austere hornet Ic

It is a joke

austere hornet Mar 2, 2022, 7:09 PM

#

Ah haha

#

Yeah ik

last patio Mar 2, 2022, 7:09 PM

#

I know Mark, you too!!

#

I think site is on a really good path right now. It's getting really good to contribute

#

@tawdry vapor do you want to take a look at that issue then?

tawdry vapor Mar 2, 2022, 7:22 PM

#

It does seem like a quick issue but I don't feel comfortable making a commitment right now cause I have a busy week.

last patio Mar 2, 2022, 7:24 PM

#

no worries!

thorny spade Mar 3, 2022, 2:14 AM

#

@dim pelican i want a re-review for python-discord/sir-lancebot#1041

dusky shoreBOT Mar 3, 2022, 2:14 AM

#

GitHub

PROpen truncate output.

dim pelican Mar 3, 2022, 2:15 AM

#

Its all good, was just asking the question lol
Would having the default set in the function eliminate the need for a constant?

#

Ah I see the diff now

#

Looks good to me

thorny spade Mar 3, 2022, 2:17 AM

#

wait

#

@dim pelican

#

WE CANT DO THAT

dim pelican Mar 3, 2022, 2:18 AM

#

Hmmm?

#

How so

thorny spade Mar 3, 2022, 2:18 AM

#

https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/core/internal_eval/_internal_eval.py#L113

stable mountainBOT Mar 3, 2022, 2:18 AM

#

bot/exts/core/internal_eval/_internal_eval.py line 113

output = self.shorten_output(output)```

thorny spade Mar 3, 2022, 2:18 AM

#

this use shorten_output

#

if 99980 is the default

#

then shorten_output will be truncated to 99980 character

#

but the limit of sending message on discord is 1980 character

#

oh no

#

should i revert them

#

@dim pelican still here?

dim pelican Mar 3, 2022, 2:21 AM

#

Yeah just reading

thorny spade Mar 3, 2022, 2:21 AM

#

for example

#

!e

for x in range(20000):
  print("a")

#

yeah

#

it say truncated

dim pelican Mar 3, 2022, 2:24 AM

#

If the output is over 1980, it calls _upload_output, and the output is shortened according to the max_length. The upload would then save all of the characters up to 99980

#

And have that as a link

thorny spade Mar 3, 2022, 2:24 AM

#

ah ic

#

ok~

dim pelican Mar 3, 2022, 2:25 AM

#

But now I want to test it again lol

thorny spade Mar 3, 2022, 2:28 AM

#

lol

dim pelican Mar 3, 2022, 2:31 AM

#

Yeah.....

#

About that suggestion I made....

#

It was a bad one

#

Your original implementation works the way it should

#

I'm sorry about that

dim pelican Mar 3, 2022, 2:33 AM

#

thorny spade should i revert them

My suggestion needs to be reverted

thorny spade Mar 3, 2022, 2:34 AM

#

np

dim pelican Mar 3, 2022, 2:38 AM

#

Oh it hurts so good

thorny spade Mar 3, 2022, 2:39 AM

#

dim pelican Oh it hurts so good

wdym

dim pelican Mar 3, 2022, 2:39 AM

#

Just that I made a bad suggestion, no worries

thorny spade Mar 3, 2022, 2:40 AM

#

@dim pelican i want a re-review

dim pelican Mar 3, 2022, 2:41 AM

#

thorny spade <@!698273827448291379> i want a re-review

Nope, my review is still good, I think just one other staff member needs an approval, then a core dev

thorny spade Mar 3, 2022, 2:41 AM

#

clever wraith Mar 3, 2022, 9:34 AM

#

dim pelican Nope, my review is still good, I think just one other staff member needs an appr...

just one core dev

clever wraith Mar 3, 2022, 4:31 PM

#

@vale ibex being popular

#

I have no idea why you are showing there, there is nothing else pydis related underneath that

#

lmao

#

why make a simple markdown when you can have a pdf

clever wraith Mar 3, 2022, 4:51 PM

#

oh new toy btw

vale ibex Mar 3, 2022, 5:00 PM

#

clever wraith <@!126811506632294400> being popular

lol how weird

cold island Mar 3, 2022, 6:15 PM

#

clever wraith oh new toy btw

Ah, taking a note from gitlab, just with better UI

gritty wind Mar 3, 2022, 6:27 PM

#

If I had to pick a face for devops, we could certainly do a lot worse than chris lemon_hyperpleased

cold island Mar 3, 2022, 6:32 PM

#

I don't know about that, that's a pretty ugly face

gritty wind Mar 3, 2022, 6:33 PM

#

This is just what he looks like before shaving in the morning

#

His face smoothens out significantly

patent pivot Mar 3, 2022, 8:13 PM

#

clever wraith why make a simple markdown when you can have a pdf

tbf it comes from org which is just markdown

#

just better lol

#

https://f.jb3.dev/pdeps/0001-hosts.org

clever wraith Mar 3, 2022, 8:21 PM

#

Not latex

#

Very sadge

patent pivot Mar 3, 2022, 8:34 PM

#

clever wraith Not latex

it is latex

#

https://f.jb3.dev/pdeps/0001-hosts.tex

#

org compiles to tex

clever wraith Mar 3, 2022, 8:43 PM

#

That sounds like cheating

#

But that's decent cheating

#

:P

exotic ember Mar 3, 2022, 9:03 PM

#

anyone run into

Installing dependencies from lock file

  RuntimeError

  [BUG]  bot-core (1.2.0) is not satisfied.

  at /usr/lib/python3.10/site-packages/poetry/mixology/partial_solution.py:200 in satisfier
      196│             # As soon as we have enough assignments to satisfy term, return them.
      197│             if assigned_term.satisfies(term):
      198│                 return assignment
      199│
    → 200│         raise RuntimeError("[BUG] {} is not satisfied.".format(term))
      201│
      202│     def satisfies(self, term):  # type: (Term) -> bool
      203│         return self.relation(term) == SetRelation.SUBSET
      204│

this when running poetry install in the bot repo?

patent pivot Mar 3, 2022, 9:06 PM

#

clever wraith That sounds like cheating

tbf, pandoc does the same thing for md

clever wraith Mar 3, 2022, 9:08 PM

#

fair

dim pelican Mar 3, 2022, 9:09 PM

#

exotic ember anyone run into ``` Installing dependencies from lock file RuntimeError [B...

I had issues with doing the poetry install of bot core for Sir-Robin, I think I eventually ran pip from the venv and then did poetry install again to verify

exotic ember Mar 3, 2022, 9:12 PM

#

dim pelican I had issues with doing the poetry install of bot core for Sir-Robin, I think I ...

hmm, installing bot-core in the env still gives the error though

hoary haven Mar 3, 2022, 9:16 PM

#

i just did a fresh new pull of the bot and was able to poetry install everything fine

exotic ember Mar 3, 2022, 9:17 PM

#

:thonk:

vale ibex Mar 3, 2022, 9:17 PM

#

Are you on an old version of poetry?

#

One that might not support installing from url?

#

No idea when that was added

exotic ember Mar 3, 2022, 9:18 PM

#

Poetry version 1.1.13 should be the latest version

#

anyways I only needed local dependencies for LSP to work so I removed bot-core from poetry, did poetry install then pipped bot-core again

vale ibex Mar 3, 2022, 9:19 PM

#

How odd though

vale ibex Mar 3, 2022, 9:40 PM

#

what branch are you working on?

exotic ember Mar 3, 2022, 9:40 PM

#

@brisk brook I can't seem to reproduce https://github.com/python-discord/bot/pull/2001#pullrequestreview-860244505

exotic ember Mar 3, 2022, 9:40 PM

#

vale ibex what branch are you working on?

https://github.com/python-discord/bot/pull/2001, but I merged master on my end