#dev-contrib | Python | Page 169

static canyon Feb 17, 2022, 11:10 PM

#

Good enough

#

m = await bot.wait_for('message', check=lambda m: m.author == ctx.author and m.channel == ctx.channel) or whatever

fallen patrol Feb 17, 2022, 11:50 PM

#

it depends on when (possibly if) pydis chooses a fork

#

and you can use modals even in dpy if you want to make the raw requests yourself lolol

clever wraith Feb 17, 2022, 11:52 PM

#

I know one that isn’t technically a fork

#

https://github.com/XuaTheGrate/slash_util

GitHub

GitHub - XuaTheGrate/slash_util: A simple script to add application...

A simple script to add application command support to discord.py v2.0 - GitHub - XuaTheGrate/slash_util: A simple script to add application command support to discord.py v2.0

#

It’s made by a helper in the dpy server

fallen patrol Feb 17, 2022, 11:53 PM

#

nod

#

interesting I didn't know it grew

clever wraith Feb 18, 2022, 12:38 AM

#

Are you sure the user guesses are right?

#

Because when I try testing it, idk but it seems a lot of my guesses aren’t in that list

sleek steppe Feb 18, 2022, 12:50 AM

#

clever wraith Because when I try testing it, idk but it seems a lot of my guesses aren’t in th...

Are you using both lists?

clever wraith Feb 18, 2022, 12:50 AM

#

Not anymore, only the solutions one now

#

I have NO clue how to play this game at all I can’t test it

sleek steppe Feb 18, 2022, 12:51 AM

#

The first one seems to be the possible wordle answers, and the rest are just other words that are accepted

clever wraith Feb 18, 2022, 12:53 AM

#

sleek steppe The first one seems to be the possible wordle answers, and the rest are just oth...

Ah should I check if the given guess is in either list?

#

I’m randomly selecting from the solutions one as the word to play

#

this list doesn’t take the commonest words… shade, sodas doesn’t work

#

Update: I used or instead of and

sleek steppe Feb 18, 2022, 1:12 AM

#

clever wraith Ah should I check if the given guess is in either list?

Yes

clever wraith Feb 18, 2022, 1:13 AM

#

Yeah

#

I’m literally getting my friend to solve this wordle

#

My mind is the solar

#

works!

hoary haven Feb 18, 2022, 3:06 AM

#

another itty bitty PR bot#2096 pleading_taco

dusky shoreBOT Feb 18, 2022, 3:06 AM

#

GitHub

PROpen Add user ID to message content for all mod alerts

fallen patrol Feb 18, 2022, 8:18 AM

#

lol unreads again?

green oriole Feb 18, 2022, 8:41 AM

#

hoary haven another itty bitty PR bot#2096 <:pleading_taco:732784538488537109>

Pfff that makes things too easy if you don't have to copy the whole embed and extract the UID :P

#

Pretty sure I still have the muscle memory to do it

#

Anyway tested & approved even if that doesn't do anything lemon_cyclops

gritty wind Feb 18, 2022, 9:14 AM

#

Was there a reason for picking the question mark instead of the typical wordle orange?

#

Also from the screenshot, you had “plebe” when the word was “plume”, yet the last letter e was marked as incorrect

#

I’m guessing you’re doing an array of available letters and popping off from it if you find a match? If so, make sure to look for any greens before trying to do question marks

#

That’ll avoid these situations

green oriole Feb 18, 2022, 9:31 AM

#

Remember that the algorithm for repeated letters is a bit more complex

#

3B1B explained it in his last video

static canyon Feb 18, 2022, 9:43 AM

#

I've been looking around bot for some more bug fix PRs I can implement and stumbled across bot#2004.

The suggested fix was to add HTTPException to the supress, but the error seemed to be because the thread had already been archived by the time the bot tried to join it (based on the first line of the traceback), so wouldn't it be better to have a if thread.archived: return instead?

Although I suppose if the issue was because the thread had been archived, then that raises the question of why a thread in on_thread_join was archived.

dusky shoreBOT Feb 18, 2022, 9:43 AM

#

GitHub

IssueOpen Auto-joining threads can run into a 400

green oriole Feb 18, 2022, 10:26 AM

#

static canyon I've been looking around bot for some more bug fix PRs I can implement and stumb...

I mean this is a race condition issue, so I don't think it is going to help. By the time the event is triggered, the function receives a thread object with archived set to false, since it is brand new.

vale ibex Feb 18, 2022, 10:27 AM

#

imo we can just delete the event listener

#

the bot doesn't need to join all threads

static canyon Feb 18, 2022, 10:28 AM

#

Hmm

#

That does mean the bot won't be able to moderate those threads (thinking in terms of public threads) @vale ibex

vale ibex Feb 18, 2022, 10:29 AM

#

the bot still gets events from threads

#

even if it's not in them

static canyon Feb 18, 2022, 10:30 AM

#

Not sure if that's correct

#

Seems weird to get on_message for a channel you're not a part of

vale ibex Feb 18, 2022, 10:30 AM

#

feel free to test it yourself

static canyon Feb 18, 2022, 10:30 AM

#

Would it be able to send messages without joining?

#

E.g. the auto mute messages

vale ibex Feb 18, 2022, 10:31 AM

#

Yea

static canyon Feb 18, 2022, 10:32 AM

#

Huh

vale ibex Feb 18, 2022, 10:32 AM

#

it'll just join after sending

static canyon Feb 18, 2022, 10:32 AM

#

I suppose sending the message just makes it join

#

Yeah

vale ibex Feb 18, 2022, 10:32 AM

#

exactly like users do

static canyon Feb 18, 2022, 10:32 AM

#

That makes sense

#

Is there any reason to autojoin then?

#

And if not, why was it added in the first place?

vale ibex Feb 18, 2022, 10:33 AM

#

The only argument for it I can see is so that that bot is in the member list, so users get the prefix hint. Which isn't a strong one imo

vale ibex Feb 18, 2022, 10:33 AM

#

static canyon And if not, why was it added in the first place?

it was added under the assumption that what I just described didn't happen

static canyon Feb 18, 2022, 10:34 AM

#

Right

#

In which case I'm happy to do a PR just removing the event

#

If that's the course of action we want to take

vale ibex Feb 18, 2022, 10:35 AM

#

seems like the way to go for me, rather than investigating a race condition for a function we don't need

static canyon Feb 18, 2022, 10:35 AM

#

Yeah

#

Okay, cool

#

bot#2097 👍

dusky shoreBOT Feb 18, 2022, 10:39 AM

#

GitHub

PROpen Remove auto joining of new threads.

static canyon Feb 18, 2022, 1:11 PM

#

@vale ibex I committed your suggestion on the regex validation PR but that meant you were credited so your review now doesn't count lemon_sweat

#

bot#2094

dusky shoreBOT Feb 18, 2022, 1:11 PM

#

GitHub

PROpen Validate regex when adding to the filter_token filter

vale ibex Feb 18, 2022, 1:11 PM

#

co-authored should be fine for policy bot

#

yea

static canyon Feb 18, 2022, 1:12 PM

#

Ah, nice

#

Cool

#

Will address your reviews on the other PRs later (probably over weekend) 👍

vale ibex Feb 18, 2022, 1:15 PM

#

yea no worries, or rush 😄

#

just trying to get through a few PRs

hoary haven Feb 18, 2022, 1:16 PM

#

green oriole Pfff that makes things too easy if you don't have to copy the whole embed and ex...

lol did you know on iOS copying from embeds doesn't work at all?

#

as scoff once said

more like whyos

#

also is it fine if i do a fix up PR?
add the same for antispam alert and remove for autoban alerts maybe

vale ibex Feb 18, 2022, 2:30 PM

#

hoary haven also is it fine if i do a fix up PR? add the same for antispam alert and remove ...

for the user id in mod log stuff?

rapid swallow Feb 18, 2022, 2:30 PM

#

yep

vale ibex Feb 18, 2022, 2:30 PM

#

Sure, sounds good

hoary haven Feb 18, 2022, 2:30 PM

#

do i try and squash it with the commit already merged to main? is that desirable/worth it?

vale ibex Feb 18, 2022, 2:30 PM

#

although, if you meant fixup as in the term used for squashing commits, please don't do that 😄

hoary haven Feb 18, 2022, 2:31 PM

#

so brand new commit

vale ibex Feb 18, 2022, 2:31 PM

#

Yea

#

squashing commits in main will be a bad time

hoary haven Feb 18, 2022, 2:31 PM

#

i did not delete my fork/branch yet, can i just do it there

vale ibex Feb 18, 2022, 2:31 PM

#

since it rewrites history, and anyone with a local copy will hate you

vale ibex Feb 18, 2022, 2:31 PM

#

hoary haven i did not delete my fork/branch yet, can i just do it there

Probably best to update your fork and make a new branch

hoary haven Feb 18, 2022, 2:32 PM

#

oki

sleek steppe Feb 18, 2022, 2:32 PM

#

hoary haven also is it fine if i do a fix up PR? add the same for antispam alert and remove ...

I was gonna suggest this then I woke up and it was merged haha

hoary haven Feb 18, 2022, 2:32 PM

#

lol

#

i will specifically request a ToxicKidz Review

#

what's your github?

sleek steppe Feb 18, 2022, 2:32 PM

#

same as my username 😄

clever wraith Feb 18, 2022, 2:36 PM

#

tehe

green oriole Feb 18, 2022, 2:48 PM

#

hoary haven lol did you know on iOS copying from embeds doesn't work *at all*?

Lmfao, really

#

That's so stupid

brisk brook Feb 18, 2022, 9:08 PM

#

Congratulations tada tada tada

austere hornet Feb 18, 2022, 9:12 PM

#

Congrats @sleek steppe !!! 🎉 tada

static canyon Feb 18, 2022, 10:08 PM

#

Congrats @sleek steppe! 🎉

vocal prairie Feb 19, 2022, 1:33 AM

#

Congratulations Toxic! 🎉

austere hornet Feb 19, 2022, 1:52 AM

#

Bump

sleek steppe Feb 19, 2022, 5:49 AM

#

@hoary haven re: bot#2098, the code you linked basically just checks if the spammed message's content (in this case there's only 1 message) is too long for an embed description, and then upload the content if it is too long. I guess you could do something like first_message_content for the content variable, but it's up to you 🙂

dusky shoreBOT Feb 19, 2022, 5:49 AM

#

GitHub

PRDraft Add user ID in message content for mod-alerts, but not for autobans

hoary haven Feb 19, 2022, 12:12 PM

#

i couldn't find a way to test that section of code (test as in, watch it happen in a debugger) and that's what i've been doing to try and understand this behemoth bot haha

#

i couldn't think of ways to trigger antispam other than posting the same message repeatedly, or messages really quickly, by # of new lines, or by # of emoji

cold island Feb 19, 2022, 1:08 PM

#

hoary haven i couldn't think of ways to trigger antispam other than posting the same message...

yeah that's pretty much how you do it

hoary haven Feb 19, 2022, 3:05 PM

#

cold island yeah that's pretty much how you do it

do you know when lines 99-101 would be hit? link in above PR

#

maybe a message with lots of emoji? haven't tried that

cold island Feb 19, 2022, 3:30 PM

#

hoary haven do you know when lines 99-101 would be hit? link in above PR

If the message has too many characters

#

A message has a limit of ~4000 characters, and an embed description can contain 4098 characters iirc. But the embed also includes metadata about the alert

#

So there might not be enough characters left to display the full message

hoary haven Feb 19, 2022, 3:31 PM

#

but when would a singular message trigger antispam?

cold island Feb 19, 2022, 3:31 PM

#

newlines for example

hoary haven Feb 19, 2022, 3:32 PM

#

but look at line 89?

cold island Feb 19, 2022, 3:33 PM

#

Ah

#

That's a more recent addition

#

yeah, I suppose lots and lots of emojis

hoary haven Feb 19, 2022, 3:33 PM

#

let's try

cold island Feb 19, 2022, 3:33 PM

#

But it's good hygiene to have that condition there anyway

#

I'll make an additional commit to rename the content in the code block below, since it overlaps with the content parameter used a little later on.
Can you explain this part?

#

Is it because there's a function being called with an argument called content?

hoary haven Feb 19, 2022, 3:39 PM

#

yeah bc i'm adding a content arg to that function call right below

cold island Feb 19, 2022, 3:39 PM

#

I don't think we need to worry about the argument names of every function we call, it's fine imo

hoary haven Feb 19, 2022, 3:39 PM

#

haha that's fine too

#

i've removed the draft status

clever wraith Feb 19, 2022, 4:47 PM

#

hey @hoary haven what's the reasoning for not including the ID for autobans? I assume in the case of a potential misfire you'd want to have the UID, wouldn't you?

#

I approved since it does what it is meant to, I'm just curious

hoary haven Feb 19, 2022, 4:51 PM

#

i haven't yet seen a case where we reversed an autoban which was a misfire or a false positive (like a user copying/pasting a message they got in DMs for example) in the moment. i think 2-3x i saw such cases come in thru the appeals server though

#

thx for the review :)

clever wraith Feb 19, 2022, 5:04 PM

#

I think I can remember one, but it is extremely foggy

#

like someone posting it as an example or something

hoary haven Feb 19, 2022, 5:11 PM

#

yeah that's what i've seen 2-3x of. since these are usually users we don't know, we don't have an easy way of contacting them. i think it's easier to let them come to us via the appeal server

#

@rapid swallow when the time comes pls still get core dev approval since idk the technical details and can't provide input on that

rapid swallow Feb 19, 2022, 5:34 PM

#

yeah, ofc joe_salute

cold island Feb 19, 2022, 5:37 PM

#

If I have a string e.g "add x", how can I make the bot run the command "add" with the argument "x" as if someone invoked "!add x" in the chat? I want to avoid having to parse the string myself, and I assume discordpy already has code which does this

gritty wind Feb 19, 2022, 5:40 PM

#

Might need a bit more detail because the correct answer to this is add a command

#

You could try to get into the nitty gritty and manually call the dispatcher d.py uses to parse and dispatch commands, but you need a good reason

brazen charm Feb 19, 2022, 5:42 PM

#

there's get_command that you could use, though that requires parsing on your own to a certain degree

cold island Feb 19, 2022, 5:43 PM

#

I have a command that got invoked, but it's missing an argument. I'm making some calculation, get the missing argument, and now I want to invoke the command again with that argument appended. I'm not inside the command callback, I just have the Context object

brazen charm Feb 19, 2022, 5:44 PM

#

doesn't the context tell you the command?

cold island Feb 19, 2022, 5:45 PM

#

It does, but what do I do with that? there may have been arguments already provided

coarse pulsar Feb 19, 2022, 5:47 PM

#

cold island If I have a string e.g "add x", how can I make the bot run the command "add" wit...

bot.process_commands(...) ?

brazen charm Feb 19, 2022, 5:47 PM

#

I don't have the docs at hand at the moment, but I don't think the command would have any arguments bound? So you could reinvoke it after getting the command object from the context

coarse pulsar Feb 19, 2022, 5:47 PM

#

Although that requires prefix to be involved in

#

But it can be modified such that it doesn't need to, I believe

cold island Feb 19, 2022, 5:49 PM

#

I have the prefix so it's not a problem

cold island Feb 19, 2022, 5:49 PM

#

brazen charm I don't have the docs at hand at the moment, but I don't think the command would...

On the contrary, I want the arguments

coarse pulsar Feb 19, 2022, 5:50 PM

#

cold island I have the prefix so it's not a problem

You may then use, process_commands or get_context followed by invoke
Would you be interested in code snippet?

cold island Feb 19, 2022, 5:52 PM

#

hmm I'll probably manage, thanks

#

But yeah, this is probably what I was looking for

#

ctx.view.buffer seems to give me the original invocation as a string

cold island Feb 19, 2022, 6:33 PM

#

@placid ermine they haven't responded yet so I'm just going to merge it

placid ermine Feb 19, 2022, 6:34 PM

#

alright

hoary haven Feb 19, 2022, 6:39 PM

#

woohoo is this the latex command?

placid ermine Feb 19, 2022, 6:39 PM

#

yee

cold island Feb 19, 2022, 6:43 PM

#

.help latex

dusky shoreBOT Feb 19, 2022, 6:43 PM

#

Command Help

**```
.latex <query>

*Renders the text in latex and sends the image.*

cold island Feb 19, 2022, 6:43 PM

#

placid ermine Feb 19, 2022, 6:43 PM

#

tada

#

.latex $joe mama$

dusky shoreBOT Feb 19, 2022, 6:44 PM

#

$latex.png$

placid ermine Feb 19, 2022, 6:45 PM

#

lmao who did it

vale ibex Feb 19, 2022, 6:52 PM

#

hey @placid ermine FYI sir-lancebot#1035

dusky shoreBOT Feb 19, 2022, 6:52 PM

#

GitHub

IssueOpen KeyError: 'log'

vale ibex Feb 19, 2022, 6:53 PM

#

did you want to work on it, or should I leave it up for grabs?

placid ermine Feb 19, 2022, 6:54 PM

#

uhh

#

interesting

vale ibex Feb 19, 2022, 6:54 PM

#

from the api ```
{
'status': 'error',
'description': 'Human readable message of what went wrong',
'log': '(LaTeX rendering log, not guaranteed here)'
}

#

log may not always be there

placid ermine Feb 19, 2022, 6:54 PM

#

ugh

#

hmm

#

should i just

#

.get

vale ibex Feb 19, 2022, 6:54 PM

#

yea

placid ermine Feb 19, 2022, 6:54 PM

#

instead of[]

#

lol

#

hm

vale ibex Feb 19, 2022, 6:54 PM

#

with some deafult str

placid ermine Feb 19, 2022, 6:55 PM

#

ill do it in the morning

vale ibex Feb 19, 2022, 6:55 PM

#

foo.get("log", foo["description"]) maybe

patent pivot Feb 19, 2022, 7:22 PM

#

.latex $\frac{a}{b}$

dusky shoreBOT Feb 19, 2022, 7:22 PM

#

$latex.png$

patent pivot Feb 19, 2022, 7:22 PM

#

good bot

#

.latex $\LaTeX$

#

bad bot

#

.latex $\LaTeX$

dusky shoreBOT Feb 19, 2022, 7:22 PM

#

$latex.png$

patent pivot Feb 19, 2022, 7:22 PM

#

wtf!

placid ermine Feb 19, 2022, 7:23 PM

#

mfw

rapid swallow Feb 19, 2022, 7:57 PM

#

@vale ibex currently, if an archived thread is added to the bump list, it stays archived and auto-bumping will happen only if someone manually unarchives the thread or if the task for unarchiving is run.

should we:
i) leave it as it is
ii) spout out an error message if you try to add an archived thread to the bump list
iii) add the thread to the bump list and make the bot unarchive the thread
iv) ...

cold island Feb 19, 2022, 7:57 PM

#

coarse pulsar You may then use, `process_commands` or `get_context` followed by `invoke` Would...

this requires the message object, which contains the original message and not the one I want 😔

rapid swallow Feb 19, 2022, 7:58 PM

#

rapid swallow <@!126811506632294400> currently, if an archived thread is added to the bump lis...

and
if (ii) or (iii), can I do the do \🥺

thorny obsidian Feb 19, 2022, 7:59 PM

#

rapid swallow <@!126811506632294400> currently, if an archived thread is added to the bump lis...

I vote 3 if it's been auto-archived, spout an error if it's manually-archived or do like a confirmation prompt thing

rapid swallow Feb 19, 2022, 8:04 PM

#

thorny obsidian I vote 3 if it's been auto-archived, spout an error if it's manually-archived or...

spout an error if it's manually-archived
I dont think we can rely on audit log for this since the thread could have been archived at any point in time
we'll have to use the Chris-bro-is-the-thread-archived™️ algorithm based on archival time and last message in the thread

#

(this message is more of a note to myself or/and chris)

#

hmm, if you are adding a thread to the bump list, you definitely want it to be unarchived. So, imo rn, I dont think it matters if they thread was manually archived or auto-archived

#

so a confirmation prompt would be nice

#

or straight up unarchive the thread

vale ibex Feb 19, 2022, 8:10 PM

#

I'm not even sure the thread convertor will work for archived threads

#

but I can play around with it later anyway

#

planning to migrate it to use a site endpoint for persistance

#

Speaking of, feast your eyes on site#663

dusky shoreBOT Feb 19, 2022, 8:12 PM

#

GitHub

PROpen Add support for BumpedThreads to be stored in site

rapid swallow Feb 19, 2022, 8:12 PM

#

vale ibex I'm not even sure the thread convertor will work for archived threads

it works if you provide ID

#

i thinkk

sleek steppe Feb 19, 2022, 8:17 PM

#

I thought ThreadConverter fetches from the API, turns out it doesn't

vale ibex Feb 19, 2022, 8:18 PM

#

Yea, it doesn't I checked last time 😄

#

So if the conversion fails I could extract the id and try to fetch it

#

I'll have a play after the site pr anyways

rapid swallow Feb 19, 2022, 8:21 PM

#

alright, no problem then

cold island Feb 19, 2022, 8:31 PM

#

cold island this requires the message object, which contains the original message and not th...

I managed to hack into the mainframe 😎

vale ibex Feb 19, 2022, 8:31 PM

#

await ctx.hack()

cold island Feb 19, 2022, 8:31 PM

#

https://tenor.com/view/thumbs-up-hacker-mmi-grenoble-hackerman-gif-11287448

Tenor

brisk brook Feb 19, 2022, 9:34 PM

#

sleek steppe I thought ThreadConverter fetches from the API, turns out it doesn't

Could use MessageConverter and see if there's a thread attached to it?

sleek steppe Feb 19, 2022, 9:48 PM

#

brisk brook Could use MessageConverter and see if there's a thread attached to it?

passing a message to the command doesn’t make much sense. I think a FecthedThread subclass or something there would suffice

brisk brook Feb 19, 2022, 9:49 PM

#

Thread IDs copy their message ID ☝️

sleek steppe Feb 19, 2022, 10:07 PM

#

Ah didn’t know that

sleek steppe Feb 19, 2022, 10:10 PM

#

cold island If I have a string e.g "add x", how can I make the bot run the command "add" wit...

Fwiw, sir-lancebot’s timed command does exactly that

#

.src t

dusky shoreBOT Feb 19, 2022, 10:11 PM

#

Command: timed

Time the command execution of a command.

Source Code

Go to GitHub

cold island Feb 19, 2022, 10:11 PM

#

oh duh, how didn't I think of copy.copy

#

This is what I did lol

added = f' "{value}"'
self.ctx.view.buffer += added
self.ctx.view.end += len(added)
await self.ctx.command.reinvoke(self.ctx)```

vocal wolf Feb 19, 2022, 10:31 PM

#

@static canyon oi m8 file conflicts are a thing, pls fix thx https://github.com/python-discord/sir-lancebot/pull/1033

static canyon Feb 19, 2022, 10:32 PM

#

Yeah, I'm aware thanks

#

Been busy with family stuff past few days

#

Will get to it when I can

#

@vocal wolf

vocal wolf Feb 19, 2022, 10:33 PM

#

ah

#

ty for update

vale ibex Feb 19, 2022, 10:39 PM

#

!ban 760770208809091082 Sharing Discord token grabbers is unacceptable.

stable mountainBOT Feb 19, 2022, 10:39 PM

#

:incoming_envelope: :ok_hand: applied ban to @glossy edge permanently.

heavy spade Feb 20, 2022, 12:34 AM

#

hi

sleek steppe Feb 20, 2022, 3:49 AM

#

@vale ibex hello, I was testing bot#2078, but I came across an error (I'm surprised it wasn't found before). It seems that the _unclaim_channel function's claimant_id can be None, and it's passed to get_or_fetch_member which raises a 400 bad request error: https://github.com/python-discord/bot/blob/14bb17965765aae4ed25a339ac622594f29852ec/bot/exts/help_channels/_cog.py#L444-L448

dusky shoreBOT Feb 20, 2022, 3:49 AM

#

GitHub

PROpen Ensure claimant cache is populated on help channel init

stable mountainBOT Feb 20, 2022, 3:49 AM

#

bot/exts/help_channels/_cog.py lines 444 to 448

# It could be possible that there is no claimant cached. In such case, it'd be useless and
# possibly incorrect to lock on None. Therefore, the lock is applied conditionally.
if claimant_id is not None:
    decorator = lock.lock_arg(f"{NAMESPACE}.unclaim", "claimant_id", wait=True)
    _unclaim_channel = decorator(_unclaim_channel)```

placid ermine Feb 20, 2022, 3:59 AM

#

vale ibex foo.get("log", foo["description"]) maybe

the description is just "The server broke. This is bad.", which isnt really helpful for the user
i think the bot's response should be the "failed to render!" embed, but without the "View Logs" hyperlink

#

maybe a message like "no logs available" in its place

placid ermine Feb 20, 2022, 5:24 AM

#

sir-lancebot#1036

dusky shoreBOT Feb 20, 2022, 5:24 AM

#

GitHub

PROpen Handle Missing Logs in Latex API Response

rapid swallow Feb 20, 2022, 7:08 AM

#

brisk brook Thread IDs copy their message ID ☝️

what do you mean?

#

whoa, the ID of the thread is the same as the message from which the thread was created from

#

wack

vale ibex Feb 20, 2022, 9:31 AM

#

sleek steppe <@!126811506632294400> hello, I was testing bot#2078, but I came across an error...

Yea, that's the issue this PR is trying to solve

#

What you're describing happens when an active channel doesn't have a claimant on the cache

#

If that's still happening in that pr, I might need to move the ensure claimant call further up the init process

severe tangle Feb 20, 2022, 10:04 AM

#

Would it be better to edit the bot token detector so that it will instead upload the token to a GitHub gist instead of deleting the message? Many newbies don't really know much about all this token stuff and tend to ignore the advices to regen the token.

severe tangle Feb 20, 2022, 10:29 AM

#

The Discord API automatically detects the GitHub Repos and gists for tokens

#

Just for reference to this ^^^

clever wraith Feb 20, 2022, 10:33 AM

#

the problem that was previously raised is pydis would rely heavily on the detection system being available at all time

#

if this system stops at any point, pydis just effectively spreads the token

thorny spade Feb 20, 2022, 10:34 AM

#

hi

severe tangle Feb 20, 2022, 10:34 AM

#

If u r talking about the token detection system built in @stable mountain, then the same could happen at the current time too. The bot won't delete the message with the token if, by chance, it goes offline due to any reason

thorny spade Feb 20, 2022, 10:34 AM

#

can i be assigned?
https://github.com/python-discord/sir-lancebot/issues/1015

GitHub

Uptime command · Issue #1015 · python-discord/sir-lancebot

Description Uptime command https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/core/ping.py#L29-L40 Reasoning It look cool Proposed Implementation Use Relative timestamp of discord &a...

thorny spade Feb 20, 2022, 10:34 AM

#

severe tangle If u r talking about the token detection system built in <@!409107086526644234>,...

apparentally i dont see why should we delete the message with token if it is already invalidated

severe tangle Feb 20, 2022, 10:35 AM

#

thorny spade apparentally i dont see why should we delete the message with token if it is alr...

It isn't invalidated automatically as of now

thorny spade Feb 20, 2022, 10:35 AM

#

severe tangle It isn't invalidated automatically as of now

uc

#

*ic

severe tangle Feb 20, 2022, 10:35 AM

#

It will be invalidated when it is uploaded to GitHub

thorny spade Feb 20, 2022, 10:35 AM

#

severe tangle It will be invalidated when it is uploaded to GitHub

ik

clever wraith Feb 20, 2022, 10:35 AM

#

severe tangle If u r talking about the token detection system built in <@!409107086526644234>,...

that doesn't make any sense, if the bot is offline it won't be uploaded to discord either

#

Discord already has a native token detection, same for the pastebin

severe tangle Feb 20, 2022, 10:36 AM

#

In both the cases, the token can spread 🤷‍♂️

clever wraith Feb 20, 2022, 10:37 AM

#

the question is why Discord doesn't already have an invalidation endpoint, but oh well

stable mountainBOT Feb 20, 2022, 10:38 AM

#

Hey @thorny spade! I noticed you posted a seemingly valid Discord API token in your message and have removed your message. This means that your token has been compromised. Please change your token immediately at: https://discordapp.com/developers/applications/me

Feel free to re-post it with the token removed. If you believe this was a mistake, please let us know!

thorny spade Feb 20, 2022, 10:38 AM

#

ic

severe tangle Feb 20, 2022, 10:39 AM

#

clever wraith the question is why Discord doesn't already have an invalidation endpoint, but o...

Most probably they already have one, but only for backend use

clever wraith Feb 20, 2022, 10:39 AM

#

severe tangle Feb 20, 2022, 10:39 AM

#

I mean, there are still people who send tokens in #discord-bots and other help channels

clever wraith Feb 20, 2022, 10:39 AM

#

#

I think at some point there isn't much that can be done

severe tangle Feb 20, 2022, 10:40 AM

#

Eh they just tend to ignore that warning from the Discord client

clever wraith Feb 20, 2022, 10:40 AM

#

¯_(ツ)_/¯

severe tangle Feb 20, 2022, 10:40 AM

#

Or when they are on a mobile, since iirc, it isn't implemented on the mobile client

stable mountainBOT Feb 20, 2022, 10:42 AM

#

Hey @clever wraith! I noticed you posted a seemingly valid Discord API token in your message and have removed your message. This means that your token has been compromised. Please change your token immediately at: https://discordapp.com/developers/applications/me

Feel free to re-post it with the token removed. If you believe this was a mistake, please let us know!

clever wraith Feb 20, 2022, 10:42 AM

#

ah yeah there is no warning

severe tangle Feb 20, 2022, 10:42 AM

#

Indeed

clever wraith Feb 20, 2022, 10:42 AM

#

maybe that'll appear with the rewrite

#

one can hope

severe tangle Feb 20, 2022, 10:43 AM

#

Yups

placid ermine Feb 20, 2022, 10:56 AM

#

@green oriole wdym #dev-log message

#

oh wait, @clever wraith, I think?

#

do you mean like a logger.warning

static canyon Feb 20, 2022, 11:04 AM

#

severe tangle If u r talking about the token detection system built in <@!409107086526644234>,...

There's a difference between doing nothing and making it worse

severe tangle Feb 20, 2022, 11:05 AM

#

static canyon There's a difference between doing nothing and making it worse

Wait, mind telling me what do you mean by making it worse? Like what are you referring to here?

static canyon Feb 20, 2022, 11:06 AM

#

severe tangle Wait, mind telling me what do you mean by making it worse? Like what are you ref...

If we upload to GitHub and the server isn't online, then we're just making it worse by spreading the token

#

Whereas if our system is down, we're not making it worse, we're just not helping either

severe tangle Feb 20, 2022, 11:06 AM

#

Ah, well the server in talks here, is the Discord API server. It is hardly down, imho

static canyon Feb 20, 2022, 11:06 AM

#

If discord had some DELETE endpoint or something like they do for webhooks, then we'd use that (as we do for webhooks)

#

Really it's down to Discord to provide a better way. We're not going to be uploading to github

severe tangle Feb 20, 2022, 11:07 AM

#

Okay, was just a suggestion

static canyon Feb 20, 2022, 11:07 AM

#

Yeah, it's something that has been repeatedly suggested, and discussed quite a bit internally, but eventually we decided that it's not the route we want to take

severe tangle Feb 20, 2022, 11:08 AM

#

Ah okay cool

clever wraith Feb 20, 2022, 11:08 AM

#

placid ermine do you mean like a logger.warning

ya

placid ermine Feb 20, 2022, 11:09 AM

#

a

thorny spade Feb 20, 2022, 11:27 AM

#

thorny spade can i be assigned? https://github.com/python-discord/sir-lancebot/issues/1015

can i be assigned to this?

static canyon Feb 20, 2022, 11:30 AM

#

@thorny spade commented on the issue

#

It's not been approved yet, so not at the moment

thorny spade Feb 20, 2022, 11:31 AM

#

static canyon <@!716134528409665586> commented on the issue

ok! ❤️

clever wraith Feb 20, 2022, 11:31 AM

#

Hmmm

#

Hmmmmmm

#

.ping

#

.uptime

#

It has been deleted hasn't it

#

https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/core/ping.py#L29

stable mountainBOT Feb 20, 2022, 11:32 AM

#

bot/exts/core/ping.py line 29

@commands.command(name="uptime")```

clever wraith Feb 20, 2022, 11:33 AM

#

Why is it not working

placid ermine Feb 20, 2022, 11:33 AM

#

.help

#

interesting

clever wraith Feb 20, 2022, 11:33 AM

#

@dusky shore help

static canyon Feb 20, 2022, 11:33 AM

#

It's ded

#

The bot is just ded

placid ermine Feb 20, 2022, 11:33 AM

#

<@&267628507062992896> lance ded

static canyon Feb 20, 2022, 11:33 AM

#

A PR got merged before I got time to test it

#

I'm fixing it now

clever wraith Feb 20, 2022, 11:33 AM

#

We can't ping devops can we

static canyon Feb 20, 2022, 11:33 AM

#

I know the issue

#

#

Why git

#

I hate git sometimes

#

It's including random other commits when I go to push

clever wraith Feb 20, 2022, 11:34 AM

#

Well well

#

Who are the devops nowadays

#

Joe, Chris, Volcyy & scale?

timid sentinel Feb 20, 2022, 11:35 AM

#

what's the issue PR? Someone want to fix it or I can revert it?

placid ermine Feb 20, 2022, 11:35 AM

#

clever wraith Joe, Chris, Volcyy & scale?

yes

static canyon Feb 20, 2022, 11:35 AM

#

@timid sentinel I'm fixing it now

#

My PR got merged before I tested it

#

I even said I hadn't tested lemon_sweat

placid ermine Feb 20, 2022, 11:36 AM

#

f

static canyon Feb 20, 2022, 11:36 AM

#

And it caused everything to die

thorny spade Feb 20, 2022, 11:36 AM

#

@dusky shore

#

it is still live

timid sentinel Feb 20, 2022, 11:36 AM

#

static canyon My PR got merged before I tested it

If you haven't tested it you should either not open the PR or mark it as draft. Granted it still shouldn't have got past reviews though

clever wraith Feb 20, 2022, 11:36 AM

#

Basuc automated testing when lemon_pensive

thorny spade Feb 20, 2022, 11:37 AM

#

static canyon My PR got merged before I tested it

thorny spade Feb 20, 2022, 11:37 AM

#

clever wraith Basuc automated testing when <:lemon_pensive:754441880246419486>

agreed

static canyon Feb 20, 2022, 11:37 AM

#

@timid sentinel sir-lancebot#1037

#

Well, bot ded so doesn't link lol

#

https://github.com/python-discord/sir-lancebot/pull/1037

GitHub

Fix error in pull 1033 by TizzySaurus · Pull Request #1037 · python...

Relevant Issues

There's no issue created yet, but this is fixing this dev-alerts.

Description

Now adds a tuple to a tuple instead of a list to a tuple.
Did you:

Join the Python Discord C...

static canyon Feb 20, 2022, 11:38 AM

#

timid sentinel If you haven't tested it you should either not open the PR or mark it as draft. ...

I've not been on my laptop so haven't been able to lemon_sweat

#

But yeah, you're right

#

Was going to later today but it got merged first

thorny spade Feb 20, 2022, 11:40 AM

#

@dusky shore help

static canyon Feb 20, 2022, 11:40 AM

#

The bot's dead at the moment @thorny spade

thorny spade Feb 20, 2022, 11:40 AM

#

oh no

placid ermine Feb 20, 2022, 11:47 AM

#

.ping

dusky shoreBOT Feb 20, 2022, 11:47 AM

#

:ping_pong: Pong!

Gateway Latency: 123ms

static canyon Feb 20, 2022, 11:47 AM

#

It's back ducky_party

placid ermine Feb 20, 2022, 11:47 AM

#

ducky_party

#

also

placid ermine Feb 20, 2022, 11:48 AM

#

patent pivot .latex $\LaTeX$

.latex \LaTeX

dusky shoreBOT Feb 20, 2022, 11:48 AM

#

$latex.png$

thorny spade Feb 20, 2022, 11:48 AM

#

.help

#

apparentally gud

static canyon Feb 20, 2022, 11:49 AM

#

Merged lemon_pleased

clever wraith Feb 20, 2022, 11:55 AM

#

.uptime

#

Well, still

placid ermine Feb 20, 2022, 11:59 AM

#

.help

dusky shoreBOT Feb 20, 2022, 11:59 AM

#

Command Help

AdventOfCode
.adventofcode
All of the Advent of Code commands.

Anagram
.anagram
Given shuffled letters, rearrange them into anagrams.

AprilFoolVideos
.fool
Get a random April Fools' video from Youtube.

AvatarModify
.8bitify
Pixelates your avatar and changes the palette to an 8bit one.
.avatar_modify
Groups all of the pfp modifying commands to allow a single concurrency limit.
.avatareasterify [colours...]
This "Easterifies" the user's avatar.

placid ermine Feb 20, 2022, 11:59 AM

#

ok so bot is not down

#

.uptime

dusky shoreBOT Feb 20, 2022, 11:59 AM

#

I started up 12 minutes ago.

placid ermine Feb 20, 2022, 11:59 AM

#

🤔

clever wraith Feb 20, 2022, 12:07 PM

#

Admetly it could use a timestamp, but oh well

thorny spade Feb 20, 2022, 12:14 PM

#

clever wraith Admetly it could use a timestamp, but oh well

there is a issue about it

#

and i am asking to being assigned

clever wraith Feb 20, 2022, 12:14 PM

#

Yeah, I understand the original issue now lemon_sweat

#

The title was a bit confusing

#

What about something like "Use discord timestamp in uptime"?

static canyon Feb 20, 2022, 12:19 PM

#

clever wraith The title was a bit confusing

I updated it by the way

#

Before I saw your message so it's not exactly what you suggested but it's clearer than what it was

clever wraith Feb 20, 2022, 12:23 PM

#

Good stuff

sleek steppe Feb 20, 2022, 12:52 PM

#

vale ibex If that's still happening in that pr, I might need to move the ensure claimant c...

~~yeah, but for some reason it's still raising that error 🤔~~ nvm read that wrong

#

the error is happening inside init_available which is after the ensure cached claimant part

vale ibex Feb 20, 2022, 12:59 PM

#

Yea, should be a case of moving it up a bit then

sleek steppe Feb 20, 2022, 1:33 PM

#

The thing is, it’s possible that we’re passing None to get_or_fetch, which will always error

vale ibex Feb 20, 2022, 2:02 PM

#

sleek steppe The thing is, it’s possible that we’re passing None to get_or_fetch, which will ...

Yea, _unclaim_channel should only ever be passed an int for claimant_id, it receiving None is wrong

#

In unclaim_channel we could change the claimant_id = await _caches.claimants.get(channel.id) call to default to @stable mountain's user id if not present

#

as a safety net

vale ibex Feb 20, 2022, 2:05 PM

#

sleek steppe The thing is, it’s possible that we’re passing None to get_or_fetch, which will ...

Ahh I see why, if there are more channels than needed in the available category, it will move some to dormant by using unclaim_channel, however, those channels don't have claimants, since they're available

#

The other option is to change _unclaim_channel's signature to allow for None claimant_ids

sleek steppe Feb 20, 2022, 2:07 PM

#

yeah that makes sense

vale ibex Feb 20, 2022, 2:11 PM

#

pushed a commit

vale ibex Feb 20, 2022, 5:44 PM

#

This is annoying sir-lancebot#1039

dusky shoreBOT Feb 20, 2022, 5:44 PM

#

GitHub

PROpen Add run bot step during lint

vale ibex Feb 20, 2022, 5:45 PM

#

I renamed the job because it's not just pre-commit & flake8 anymore

#

but github is still expecting a status from the old name 😦

#

hmmmmmm @patent pivot I might need to remove this from the branch protection

#

then add back in the new name when it hits main

#

orrr, we accept it won't be accurate and don't rename the job? shrugR

patent pivot Feb 20, 2022, 5:50 PM

#

vale ibex hmmmmmm <@!165023948638126080> I might need to remove this from the branch prote...

yea I'd temp remove

vale ibex Feb 20, 2022, 5:50 PM

#

👌

#

Done

placid ermine Feb 20, 2022, 6:06 PM

#

@vale ibex @clever wraith re https://github.com/python-discord/sir-lancebot/pull/1036#discussion_r810661950
should i revert the commit then

clever wraith Feb 20, 2022, 6:40 PM

#

I've responded to the comment

fallen sleet Feb 20, 2022, 6:46 PM

#

!source ot

stable mountainBOT Feb 20, 2022, 6:46 PM

#

Sorry, an unexpected error occurred. Please let us know!

AttributeError: 'TagIdentifier' object has no attribute 'qualified_name'

fallen sleet Feb 20, 2022, 6:46 PM

#

cryingCat

static canyon Feb 20, 2022, 6:54 PM

#

That's an known issue btw @fallen sleet

fallen sleet Feb 20, 2022, 6:54 PM

#

oh okay

static canyon Feb 20, 2022, 6:55 PM

#

There's already an issue for it on the bot repo

#

!src doesn't work for tags, and when it doesn't raise an error the url it gives is wrong

tawdry vapor Feb 20, 2022, 7:05 PM

#

Thoughts on a second latex command that doesn't wrap code in a template? Won't be used that much, but we can have fun things in that bot

clever wraith Feb 20, 2022, 7:18 PM

#

placid ermine <@!126811506632294400> <@456226577798135808> re <https://github.com/python-disco...

So yeah, according to what Chris said you can revert

summer garden Feb 20, 2022, 10:31 PM

#

I'm looking at sir-lancebot#945 and trying to come up with ideas with how we would cache each user's palette in memory. The stored values should expire after a certain time. Would this be done with redis or some other approach?

dusky shoreBOT Feb 20, 2022, 10:31 PM

#

GitHub

IssueOpen Colour Command Enhancements

vale ibex Feb 20, 2022, 10:32 PM

#

current redis would allow you to expire the whole cache, but not individual members

summer garden Feb 20, 2022, 10:32 PM

#

Maybe setting a task to clear an ordinary python dict key after a certain amount of time?

vale ibex Feb 20, 2022, 10:32 PM

#

it's a redis limitation, until we migrate to KeyDB

summer garden Feb 20, 2022, 10:40 PM

#

looking forward to it then :)

brazen charm Feb 20, 2022, 10:41 PM

#

You can do expires on normal keys, though those aren't available from the normal redis cache interface iirc

hoary haven Feb 20, 2022, 10:42 PM

#

hey @static canyon, last chance to review site#624
once i pass zig's review i'm going to ask to get this merged
i did address all the points you originally raised on the first version of this PR

dusky shoreBOT Feb 20, 2022, 10:42 PM

#

GitHub

PROpen Content: update help channel guide

vale ibex Feb 20, 2022, 10:42 PM

#

yea, sorry, I should have specified, since async-rediscache uses sets, Redis doesn't support expiring individual members

#

KeyDB supports expiring individual members of a SET, SORTED SET, or HASH with the EXPIREMEMBER command

static canyon Feb 20, 2022, 11:14 PM

#

hoary haven hey <@!442244135840382978>, last chance to review site#624 once i pass zig's rev...

My laptop is currently dead so won't be able to review for 2 days at a minimum lemon_sweat

#

Thanks for addressing my points though

hoary haven Feb 20, 2022, 11:36 PM

#

help
trying to run site locally
and i get this error when doing docker-compose up

#

https://paste.pythondiscord.com/hixitareje

#

this is when running site in its current state

vale ibex Feb 20, 2022, 11:37 PM

#

run it with --build once

#

looks like your local image has an out of date version of django

hoary haven Feb 20, 2022, 11:38 PM

#

right, i have a faint memory of doing that when first setting up site Thinking_chief ok

vale ibex Feb 20, 2022, 11:38 PM

#

Yea, you'll need to run --build whenever dependencies get updated

hoary haven Feb 20, 2022, 11:39 PM

#

will i need to build again when i switch back to my older branch

vale ibex Feb 20, 2022, 11:39 PM

#

if your older branch has different dependencies/versions, yes

#

you'd need to run --build even for code changes, if it wasn't for the fact that we mount a volume in dev to make it so that you don't

#

since when you build an image, that image is then frozen

#

we mount a volume on the same path as where the code is in the image though, so that we can overwrite it on the fly in dev

#

but you can't do that for dependancies

#

well, not in any sane way

hoary haven Feb 20, 2022, 11:44 PM

#

@vale ibex i independently figured out the line break thing. you're too fast for me PensiveFluent

vale ibex Feb 20, 2022, 11:45 PM

#

hah

hoary haven Feb 20, 2022, 11:51 PM

#

was it always 2 newlines required?

#

in the original there was only 1 blank line afaict

vale ibex Feb 20, 2022, 11:53 PM

#

it varies depending on where it is relative to headings

#

since it was moved from mid-content to the end of a content block for that heading

hoary haven Feb 20, 2022, 11:56 PM

#

lol bizarre

#

ty :3 as always

vale ibex Feb 20, 2022, 11:56 PM

#

npnp 😄

#

Hah nice @fallen patrol, just came across https://github.com/DisnakeDev/disnake/commit/2b5635fb4bb2d864624332e63cb2e09bf78b3e8d

#

was looking to see if that was fixed 😄

fallen patrol Feb 20, 2022, 11:59 PM

#

it was a one liner

#

so ez chefkiss

vale ibex Feb 20, 2022, 11:59 PM

#

haha yup, waaay easier to change the src than monkeypatch

fallen patrol Feb 20, 2022, 11:59 PM

#

yep

vale ibex Feb 21, 2022, 12:00 AM

#

out of interest does disnake do anything about Discord's decision to sometimes throw 403s for typing events?

#

That's the only other monkeypatch we currently have

fallen patrol Feb 21, 2022, 12:00 AM

#

vale ibex That's the only other monkeypatch we currently have

well, root aliases as well

vale ibex Feb 21, 2022, 12:00 AM

#

I say sometimes, it only ever happened once

#

Yea, root aliases I wouldn't expect to be added to the lib

fallen patrol Feb 21, 2022, 12:01 AM

#

yeah, we don't have any special handling for discord throwing 403s when they aren't supposed to

vale ibex Feb 21, 2022, 12:01 AM

#

yea, that was annoying when they decided to do that

fallen patrol Feb 21, 2022, 12:02 AM

#

even more so, they're typing events

#

can't they like, throw a cf worker in front of that that makes it seem like it worked?

#

I doubt anyone cares if they get a 204 when typing events aren't being shown to anyone

fallen patrol Feb 21, 2022, 12:04 AM

#

vale ibex Yea, root aliases I wouldn't expect to be added to the lib

its partially possible, I suppose. I did point someone a few weeks ago to pydis's implementation who was looking to use it

vale ibex Feb 21, 2022, 12:04 AM

#

Yea, how to implement it in the lib isn't trivial

#

since failing silently is one option

#

but not ideal in all use cases

fallen patrol Feb 21, 2022, 12:05 AM

#

right

rapid swallow Feb 21, 2022, 12:30 AM

#

vale ibex Hah nice <@!717983911824588862>, just came across <https://github.com/DisnakeDev...

hahaha

austere hornet Feb 21, 2022, 1:10 AM

#

Bump

hoary haven Feb 21, 2022, 1:22 AM

#

❯ git pull
hint: You have divergent branches and need to specify how to reconcile them.
hint: You can do so by running one of the following commands sometime before
hint: your next pull:
hint: 
hint:   git config pull.rebase false  # merge (the default strategy)
hint:   git config pull.rebase true   # rebase
hint:   git config pull.ff only       # fast-forward only
hint: 
hint: You can replace "git config" with "git config --global" to set a default
hint: preference for all repositories. You can also pass --rebase, --no-rebase,
hint: or --ff-only on the command line to override the configured default per
hint: invocation.
fatal: Need to specify how to reconcile divergent branches.``` :(

#

so this branch is 270 commits behind, but the only files changed in this branch/PR are a markdown file and some images

#

if someone can walk me thru this pls let me know

fallen patrol Feb 21, 2022, 1:26 AM

#

it might be easier to restart with an up to date branch

hoary haven Feb 21, 2022, 1:28 AM

#

so for site#624 this already has pushes tho

dusky shoreBOT Feb 21, 2022, 1:28 AM

#

GitHub

PROpen Content: update help channel guide

hoary haven Feb 21, 2022, 1:29 AM

#

copy/paste my changed files, make a new up to date branch, set to track with the above remote branch,... ?

#

if it helps, it's no loss if all the commits in the above PR are squashed to 1

#

git pull --ff-only failed

vale ibex Feb 21, 2022, 1:46 AM

#

checkout main branch

#

git pull

#

then checkout the feature branch

#

and git merge main

#

the other option is to do it from github web

#

and then force pull/hard reset your local copy

hoary haven Feb 21, 2022, 1:48 AM

#

this is resulting in a commit called Merge branch 'main' into content/update-help-channel-timing

vale ibex Feb 21, 2022, 1:48 AM

#

yup

hoary haven Feb 21, 2022, 1:48 AM

#

that's what we want right

#

do i need to git push -f ?

vale ibex Feb 21, 2022, 1:49 AM

#

nah

#

you're not rewriting history

hoary haven Feb 21, 2022, 1:49 AM

#

so i made that commit and did git push

#

❯ git push
To https://github.com/python-discord/site.git
 ! [rejected]          content/update-help-channel-timing -> content/update-help-channel-timing (non-fast-forward)
error: failed to push some refs to 'https://github.com/python-discord/site.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.```

vale ibex Feb 21, 2022, 1:49 AM

#

ah, looks like you didn't pull before comitting locally

hoary haven Feb 21, 2022, 1:50 AM

#

❯ git switch main
Switched to branch 'main'
Your branch is up to date with 'origin/main'.

site on  main [?] is 📦 v1.0.0 via 🐍 v3.9.8 (.venv) 
❯ git pull
Already up to date.

vale ibex Feb 21, 2022, 1:50 AM

#

on your feature branch

#

So what that is saying is that on the feature branch, there are commits in the remote that you don't have

hoary haven Feb 21, 2022, 1:51 AM

#

checkout to feature branch and then git pull?

vale ibex Feb 21, 2022, 1:51 AM

#

and now you're trying to push new commits, and git doesn't know what to do with that

#

you'll likely have merge conflicts

#

Is what you have locally what you want?

hoary haven Feb 21, 2022, 1:51 AM

#

yeah

vale ibex Feb 21, 2022, 1:51 AM

#

then git push -f

#

it might mean that some commits get deleted in github

hoary haven Feb 21, 2022, 1:52 AM

#

i did git pull while i was on main, do i do it again on this branch?

vale ibex Feb 21, 2022, 1:52 AM

#

but if what you have locally is what you want, it doesn't matter

#

if you do, it'll complain about divergent branches again

hoary haven Feb 21, 2022, 1:54 AM

#

ok the commits for this PR are all a mess lol

vale ibex Feb 21, 2022, 1:54 AM

#

lol

hoary haven Feb 21, 2022, 1:55 AM

#

can i squash them all to 1 or 2 at this point?

#

i've force pushed

vale ibex Feb 21, 2022, 1:55 AM

#

you won't be able to squash commits before the merge commit

#

you'll need to drop the merge commit, then rebase and then merge in again

#

otherwise you'll re-write the commits from main

hoary haven Feb 21, 2022, 1:57 AM

#

i'm gonna leave it lol, pls do as you see fit when it's merged dv_bunbunBobaOwO

#

or i'll ask you tmrw. go to bed

vale ibex Feb 21, 2022, 1:59 AM

#

if you do git reset --hard a7e2bd4dc4f1bbbc3c9c8407b64e6dba5f3b0296

#

that'll reset your branch back to before you did the merge commit

#

then you can git rebase -i HEAD~13 to get your interactive rebase

hoary haven Feb 21, 2022, 2:00 AM

#

ok

vale ibex Feb 21, 2022, 2:00 AM

#

then once that's done, you can git merge main and then git push -f

hoary haven Feb 21, 2022, 2:00 AM

#

so git merge main is what you call a "merge commit"?

vale ibex Feb 21, 2022, 2:00 AM

#

yea

hoary haven Feb 21, 2022, 2:00 AM

#

ok that's not too bad

#

let' see

vale ibex Feb 21, 2022, 2:01 AM

#

that says grab the commits I'm missing from the main branch and add them to this branch as a merge commit

#

git rebase main means rewrite all the commits in the branch to be based from the HEAD of main

hoary haven Feb 21, 2022, 2:01 AM

#

and which commit is a7e2bd4dc4f1bbbc3c9c8407b64e6dba5f3b0296?

vale ibex Feb 21, 2022, 2:01 AM

#

The one before your merge commit

#

hoary haven Feb 21, 2022, 2:02 AM

#

mhm mhm

#

ok so rebase/squash my commits first, then repeat the process you said above

vale ibex Feb 21, 2022, 2:03 AM

#

Yea, drop the merge commit, do you rebasing, then add the merge commit again

#

that means the only commits you're rewriting are the ones from your branch

fallen patrol Feb 21, 2022, 2:42 AM

#

@vale ibex fyi since you were looking at disnake commits today, i just merged what i believe to be our first breaking change with dpy ~~except because so many people got confused by it, its a good change~~

#

https://github.com/DisnakeDev/disnake/commit/1fbc7df56909481565e22e3ca1e7d5f19f28b49c

GitHub

breaking: require one of message or type for creating a thread (#35...

Co-authored-by: shiftinv 8530778+shiftinv@users.noreply.github.com

vale ibex Feb 21, 2022, 2:46 AM

#

Ah cool, I'm guessing calling Message.create_thread will still work?

fallen patrol Feb 21, 2022, 2:46 AM

#

yeah

vale ibex Feb 21, 2022, 2:46 AM

#

Nice, makes sense as a change

fallen patrol Feb 21, 2022, 2:46 AM

#

that never took a type parameter

#

but ppl were trying to make private threads on messages, or not sure why it wasn't working by default (as private threads are only on level 2 boosted guilds)

#

etc

#

additionally the api removed support for having a default in api v10

fallen patrol Feb 21, 2022, 3:16 AM

#

@patent pivot why not just make it not include whitespace?

#

https://github.com/python-discord/king-arthur/commit/7a00015a61c5075f5d1131f2f06fb2e6fe353efb

#

strip_after_prefix

#

https://discordpy.readthedocs.io/en/master/ext/commands/api.html#discord.ext.commands.Bot.strip_after_prefix

patent pivot Feb 21, 2022, 3:16 AM

#

because i am shitposting at 3:16am

#

i will do that when i rewrite arthur

#

for ansible

fallen patrol Feb 21, 2022, 3:17 AM

#

mmlol

patent pivot Feb 21, 2022, 3:17 AM

#

god gives his free-est battles to his emacs clowns

#

M-x ed

radiant merlinBOT Feb 21, 2022, 3:17 AM

#

M-x ed [-GVhs] [-p string] [file]

Ed is the standard text editor.

fallen patrol Feb 21, 2022, 3:20 AM

#

M-x ed

radiant merlinBOT Feb 21, 2022, 3:20 AM

#

M-x ed [-GVhs] [-p string] [file]

Ed is the standard text editor.

placid ermine Feb 21, 2022, 3:32 AM

#

clever wraith So yeah, according to what Chris said you can revert

👍

placid ermine Feb 21, 2022, 4:11 AM

#

uhhh

#

halp

#

i pulled from upstream/main so i could resolve some conflicts

#

but

#

On branch bug/infr-duration
Your branch is ahead of 'origin/bug/infr-duration' by 101 commits.

#

the 101 commits bit sounds

#

um

#

problematic

tawdry vapor Feb 21, 2022, 4:29 AM

#

What commands did you run

placid ermine Feb 21, 2022, 4:30 AM

#

tawdry vapor Feb 21, 2022, 4:30 AM

#

And are the commits actually different hashes? It might just count merged commits as being ahead

sleek steppe Feb 21, 2022, 4:31 AM

#

placid ermine the 101 commits bit sounds

I guess that makes sense, your branch is 100 commits behind

#

placid ermine Feb 21, 2022, 4:31 AM

#

a

#

hm

#

so when i push it

#

does my PR show up as 100 commits or

tawdry vapor Feb 21, 2022, 4:31 AM

#

It shouldn't

placid ermine Feb 21, 2022, 4:31 AM

#

aight

tawdry vapor Feb 21, 2022, 4:32 AM

#

But I don't remember how the status message counts merge commits

#

If it's messed up you can still fix it so no worries

placid ermine Feb 21, 2022, 4:34 AM

#

hmm unrelated (i think) but i cant seem to run the bot
i get a ton of errors looking like

discord.ext.commands.errors.ExtensionFailed: Extension 'bot.exts.moderation.metabase' raised an error: ModuleNotFoundError: No module named 'botcore'

sleek steppe Feb 21, 2022, 4:34 AM

#

are you running with docker?

placid ermine Feb 21, 2022, 4:34 AM

#

yes

sleek steppe Feb 21, 2022, 4:34 AM

#

docker-compose up --build

placid ermine Feb 21, 2022, 4:34 AM

#

oh ok

static canyon Feb 21, 2022, 8:02 AM

#

placid ermine oh ok

(you need to do the --build whenever there's a dependency change)

placid ermine Feb 21, 2022, 8:03 AM

#

hm

static canyon Feb 21, 2022, 8:07 AM

#

The --build just reruns the docker-compose file, which ensures your dependencies are up to date

#

If there's been no changes to dependencies then you don't need the --build

hoary haven Feb 21, 2022, 2:17 PM

#

help a mac girl out and approve site#667 :D

dusky shoreBOT Feb 21, 2022, 2:17 PM

#

GitHub

PROpen Update .gitignore to ignore MacOS system files

magic arch Feb 21, 2022, 2:21 PM

#

Woo sir-robin repo exists

vale ibex Feb 21, 2022, 2:22 PM

#

The bot does too 😄 @humble leaf

#

changing around colour schemes atm and will changelog shortly

green oriole Feb 21, 2022, 2:23 PM

#

Hmm is it using the standard merge policy

#

Oh yeah it is the site

#

Can't do anything for you my friend

magic arch Feb 21, 2022, 2:24 PM

#

wooo hi sir robin, lovely to meet you

green oriole Feb 21, 2022, 2:25 PM

#

Always more bots

#

I mean it is the correct way to go for both perms and rate limits haha

magic arch Feb 21, 2022, 2:27 PM

#

that and organizing codebases

green oriole Feb 21, 2022, 2:28 PM

#

I think organization wise it isn't so bad

#

You have all your code nicely sorted in modules and stuff

rapid swallow Feb 21, 2022, 2:28 PM

#

hoary haven help a mac girl out and approve site#667 :D

I've approved but you should probably add it to your global gitignore too

hoary haven Feb 21, 2022, 2:29 PM

#

wdym by global gitignore?

#

there's such a thing?

green oriole Feb 21, 2022, 2:29 PM

#

Yeah

#

It is the core.excludesfile config option

hoary haven Feb 21, 2022, 2:29 PM

#

niice

vale ibex Feb 21, 2022, 2:29 PM

#

yea, I have git config --global core.excludesFile '~/.gitignore'

green oriole Feb 21, 2022, 2:29 PM

#

You can set it to point to an additional gitignore file

vale ibex Feb 21, 2022, 2:29 PM

#

then in ~/.gitignore I have a bunch of stuff

#

git config --global core.excludesFile "$Env:USERPROFILE\.gitignore" for windows powershell

hoary haven Feb 21, 2022, 2:30 PM

#

okioki

#

it works :D will do the same when i get home

patent pivot Feb 21, 2022, 3:35 PM

#

green oriole I think organization wise it isn't so bad

the main reason was sort of org/review policy

#

we want a bot that we can speedrun changes into without affecting availability of other stuff, events is the only thing where we've got hard concrete deadlines, so being able to rapidly prototype on a separate bot is nice

green oriole Feb 21, 2022, 3:36 PM

#

that makes a lot of sense

austere hornet Feb 21, 2022, 3:38 PM

#

Welcome @humble leaf !

thorny obsidian Feb 21, 2022, 4:20 PM

#

It also lets us add additional dependencies that wouldn't be best for lancebot

green oriole Feb 21, 2022, 4:44 PM

#

I'm curious, what kind of deps are you taking about?

thorny obsidian Feb 21, 2022, 5:46 PM

#

Snekbox, site

green oriole Feb 21, 2022, 5:52 PM

#

Ah right

#

me just looking over the rule text and being, "wait, what happened to devops again"

vale ibex Feb 21, 2022, 6:05 PM

#

lol

#

we're ansibling

hoary haven Feb 21, 2022, 6:06 PM

#

green oriole me just looking over the rule text and being, "wait, what happened to devops aga...

oo your font looks different

#

green oriole Feb 21, 2022, 6:08 PM

#

aha, that's interesting

#

I wonder if it is rendered using the system font

#

mine should be Noto

clever wraith Feb 21, 2022, 6:15 PM

#

@vale ibex https://github.com/python-discord/metricity/pull/11 wouldn't there be an issue while syncing if someone joined while the bot was down, sent a message and then left

GitHub

Message sync command by ChrisLovering · Pull Request #11 · python-d...

Adds a command to sync all messages between two given dates. This can be used if there was a bot outage, and the bot owner wants to ensure data integrity.
This could also be used to back-date what ...

vale ibex Feb 21, 2022, 6:17 PM

#

Yea, I guess there would be

#

I can add a step that checks if the user is there, and if not add them

#

since we have the user object at least

clever wraith Feb 21, 2022, 6:19 PM

#

you wont have a joined_at date tho

#

iirc that field isnt nullable

cold island Feb 21, 2022, 6:19 PM

#

Do we have some sort of agreement on when we should log with info/trace/debug? I get the debug is for granular things we don't want to see in prod, but what about info vs trace?

vale ibex Feb 21, 2022, 6:20 PM

#

I usually go with trace is for anywhere I would have but an old style print statement

#

debug is for slightly less verbose things, but still only useful in dev

#

info is anything that is good to know if prod, but isn't an issue to raise a sentry alert

vale ibex Feb 21, 2022, 6:21 PM

#

clever wraith you wont have a joined_at date tho

yea, that makes it harder

cold island Feb 21, 2022, 6:21 PM

#

vale ibex info is anything that is good to know if prod, but isn't an issue to raise a sen...

didn't get the sentry part

vale ibex Feb 21, 2022, 6:21 PM

#

warning/error/exception raises a sentry issue

#

so I'd use info for things that are useful to know in prod, but aren't things that need to be fixed

cold island Feb 21, 2022, 6:22 PM

#

ah

#

speaking of... error vs exception

vale ibex Feb 21, 2022, 6:23 PM

#

log.error supresses traceback by default iirc

vale ibex Feb 21, 2022, 6:27 PM

#

vale ibex yea, that makes it harder

I guess we could use datetime.min as a sentinel value for unknown

cold island Feb 21, 2022, 6:30 PM

#

Could also use the bot's start time

#

As a best attempt estimate

vale ibex Feb 21, 2022, 6:31 PM

#

I'd rather use a sentinel, rather than something that could look like a "real" value

cold island Feb 21, 2022, 6:31 PM

#

that's fair

vale ibex Feb 21, 2022, 6:31 PM

#

the problem is that this isn't syncing message that the bot missed while offline, it allows for arbitrary dates

#

IE we could sync messages pre aug-2020

cold island Feb 21, 2022, 6:32 PM

#

How does the syncing work?

#

Does it scrape the channels, or...

vale ibex Feb 21, 2022, 6:33 PM

#

yup

#

all channels, all threads, all archived threads

cold island Feb 21, 2022, 6:33 PM

#

And you specify a date to reach?

vale ibex Feb 21, 2022, 6:33 PM

#

it's a slow process

#

Yea, you specify two dates

cold island Feb 21, 2022, 6:33 PM

#

eeesh

vale ibex Feb 21, 2022, 6:33 PM

#

It's intended to do small ranges say if the bot had an outage

cold island Feb 21, 2022, 6:34 PM

#

yeah ik

vale ibex Feb 21, 2022, 6:34 PM

#

but there's no validation for the difference

cold island Feb 21, 2022, 6:34 PM

#

yeah, letting it run from August 2020 backwards would be... interesting 😅

vale ibex Feb 21, 2022, 6:35 PM

#

lmfao yea

#

probably wouldn't want to anyway

tawdry vapor Feb 21, 2022, 6:35 PM

#

cold island Do we have some sort of agreement on when we should log with info/trace/debug? I...

We used to have something about this in our contributing guide, but I know at some point stuff got shuffled around, so I don't know where it is anymore.

vale ibex Feb 21, 2022, 6:35 PM

#

https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/contributing-guidelines/supplemental-information/#logging

Python Discord - Supplemental Information

Additional information related to our contributing guidelines.

cold island Feb 21, 2022, 6:36 PM

#

Ah yes, the logging level "Note"

tawdry vapor Feb 21, 2022, 6:36 PM

#

I've never been totally happy with warning always going to Sentry. It makes us avoid that level even if it is semantically appropriate.

cold island Feb 21, 2022, 6:37 PM

#

I sprinkled a bunch of warnings into the filters rework if that helps 😄

tawdry vapor Feb 21, 2022, 6:37 PM

#

I guess the solution would be to either ignore stuff in Sentry or introduce a new logging level. I'm not too fussed about it though.

cold island Feb 21, 2022, 6:38 PM

#

cold island I sprinkled a bunch of warnings into the filters rework if that helps 😄

Specifically because these aren't errors, but should go to Sentry

#

Wait trace is below debug?

#

I thought it was the opposite

tawdry vapor Feb 21, 2022, 6:39 PM

#

Both trace and debug are for debugging, but trace is more spammy and detailed.

cold island Feb 21, 2022, 6:40 PM

#

TIL

tawdry vapor Feb 21, 2022, 6:41 PM

#

Trace means tracing execution, so you end up with a lot of logs saying "im in function x doing y with z argument"

cold island Feb 21, 2022, 6:41 PM

#

So when would it be appropriate to use debug instead of trace?

tawdry vapor Feb 21, 2022, 6:42 PM

#

I think I did a good job of using them in the help system, though sometimes I have wished some of those trace logs were actually showing up in our prod logs to debug some confusing situations.

#

I'll answer that in a moment

#

I view the debug level as being for bigger picture debug information. It can be used to log some initial info about an operation, but doesn't go into every single function call involved in performing that operation.

#

Since neither trace or debug are showing up in production, it's really just a matter of making it nicer for developers to filter out the spammy logs that they probably don't care about.

#

It's not an exact science. There's some intuition required for picking the right log level.

cold island Feb 21, 2022, 6:49 PM

#

yeah maybe I'll pick it up along the way

#

thanks

cold island Feb 21, 2022, 9:15 PM

#

If a message is sent in DMs, is it that message.guild is None, or that the message has no guild attribute?

green oriole Feb 21, 2022, 9:25 PM

#

cold island If a message is sent in DMs, is it that message.guild is None, or that the messa...

it is None

#

thank god Messages always have a guild attribute

#

not that relevant but I fetched it now pithink https://docs.disnake.dev/en/latest/api.html#disnake.Message.guild

#

oh that's disnake

#

works too, I guess

#

same thing either way

cold island Feb 21, 2022, 9:47 PM

#

aah, category is the missing attribute (from the channel object)

green oriole Feb 21, 2022, 10:02 PM

#

cold island aah, category is the missing attribute (from the channel object)

that would make sense, but note that it is totally possible inside the actual server

#

ah no, it would be null

#

Right, it is a field of GuildChannel but not DMChannel

#

carry on mmwhereismynose

fallen patrol Feb 22, 2022, 1:34 AM

#

green oriole Right, it is a field of `GuildChannel` but not `DMChannel`

another dpy quirk: categories have a category attribute

#

fun!

hoary haven Feb 22, 2022, 1:41 AM

#

hi @tawdry vapor could i poke you about bot#2071?
we'll need another review from someone else as well

dusky shoreBOT Feb 22, 2022, 1:41 AM

#

GitHub

PROpen Notify helpers without ping when dormant channels are running low

hoary haven Feb 22, 2022, 1:41 AM

#

oo new lance logo looks so good

tawdry vapor Feb 22, 2022, 1:42 AM

#

I'll review it right now. I haven't been keeping up with GH notifications well lately.

hoary haven Feb 22, 2022, 1:43 AM

#

wiggledance2 ty!

tawdry vapor Feb 22, 2022, 1:44 AM

#

Why did you author the PR but someone else made the commits?

#

It's not a problem; it's just odd

hoary haven Feb 22, 2022, 1:58 AM

#

griff and i were doing it together.. he was teaching me

#

he ended up just making the commits but to my fork A_Shrug_BC

#

and didn't want to open a PR.. but it wasn't like i was gonna re-write the code myself lol

tawdry vapor Feb 22, 2022, 1:59 AM

#

Are you now learned enough to finish it off yourself

hoary haven Feb 22, 2022, 1:59 AM

#

that depends lol

tawdry vapor Feb 22, 2022, 1:59 AM

#

scrap it all 😈

hoary haven Feb 22, 2022, 1:59 AM

#

lmfao

tawdry vapor Feb 22, 2022, 2:02 AM

#

It's just some minor changes

#

I need to run it to see if it works though

hoary haven Feb 22, 2022, 2:12 AM

#

do you use the staff server?

#

lmk if you want help

tawdry vapor Feb 22, 2022, 2:21 AM

#

Yeah I use it. I think I can trigger it myself pretty easily

wild prism Feb 22, 2022, 2:32 AM

#

https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/site/#configuration-in-detail

Run on the host

Running on the host is particularly useful if you wish to debug the site. The environment variables shown in a previous section need to have been configured.
what does this paragraph mean?

Python Discord - Contributing to Site

A guide to setting up and configuring Site.

vocal prairie Feb 22, 2022, 2:33 AM

#

the host is basically "outside docker"

#

directly on your own system

wild prism Feb 22, 2022, 2:35 AM

#

why is that more useful for debugging?

vocal prairie Feb 22, 2022, 2:36 AM

#

that's a good question. maybe because it might work better with e.g. the pycharm debugger? I'm not sure.

tawdry vapor Feb 22, 2022, 2:38 AM

#

It's easier to attach a debugger. I believe it's possible to attach a debugger to a process in a container but I have no idea how to do that.

wild prism Feb 22, 2022, 2:40 AM

#

do the env variables not have to be configured when you're using Docker?

tawdry vapor Feb 22, 2022, 2:41 AM

#

They have default values specified in the compose file, so you don't need to change them in that case.

wild prism Feb 22, 2022, 2:54 AM

#

im getting this when using the http://127.0.0.1:8000/admin/ link in the set-up guide

#

what's up with that

patent pivot Feb 22, 2022, 2:56 AM

#

hmmm

#

try localhost:8000

wild prism Feb 22, 2022, 2:57 AM

#

yeah that works, it just doesnt like the admin

patent pivot Feb 22, 2022, 2:57 AM

#

hmmm

#

so http://localhost:8000/admin/ doesn't work either

wild prism Feb 22, 2022, 2:57 AM

#

nope, same thing

patent pivot Feb 22, 2022, 2:57 AM

#

huh

#

i've never seen that

hoary haven Feb 22, 2022, 2:59 AM

#

i don't think /admin ever worked for me either

tawdry vapor Feb 22, 2022, 3:07 AM

#

Does the API work?

wild prism Feb 22, 2022, 3:12 AM

#

tawdry vapor Does the API work?

this is my first time anything whatsoever with the site, how do i test that?

tawdry vapor Feb 22, 2022, 3:12 AM

#

http://localhost:8000/api/healthcheck should show a page since you're running in debug mode

wild prism Feb 22, 2022, 3:13 AM

#

yeah seems to be working

tawdry vapor Feb 22, 2022, 3:13 AM

#

No idea about the admin page then

#

Apparently it also shows in prod https://www.pythondiscord.com/api/healthcheck

patent pivot Feb 22, 2022, 3:14 AM

#

hmmmm

#

https://stackoverflow.com/questions/11814059/site-matching-query-does-not-exist

Stack Overflow

Site matching query does not exist

Python noob, as in this is my first project, so excuse my unfamiliarity.

The site was working very well until I clicked "log out" on my app. After that, the website would give me this error:

#

this looks to be it

#

in prod:

pythondiscord=# SELECT * FROM django_site;
 id |        domain         |         name
----+-----------------------+-----------------------
  1 | www.pythondiscord.com | www.pythondiscord.com
(1 row)

#

so the manage.py suggestions there might do it

tawdry vapor Feb 22, 2022, 3:15 AM

#

What about SITE_ID=1 in settings

#

Would a site be created by default?

patent pivot Feb 22, 2022, 3:16 AM

#

hmmmmmm

tawdry vapor Feb 22, 2022, 3:16 AM

#

If not then we should modify the run command to create one

patent pivot Feb 22, 2022, 3:16 AM

#

we must have at some point

#

let me see what it gets init'd with

#

hmm okay so

#

yea i get the same error locally

#

and in the tableeeee

#

aahhh

#

pysite=# SELECT * FROM django_site;
 id |          domain          |           name
----+--------------------------+--------------------------
  1 | pythondiscord.local:8000 | pythondiscord.local:8000
(1 row)

#

aha @tawdry vapor https://github.com/python-discord/site/blob/3f8854ebd7daa35f9e896b95efa3e4ff7d23185d/manage.py#L89-L96

stable mountainBOT Feb 22, 2022, 3:21 AM

#

manage.py lines 89 to 96

from django.contrib.sites.models import Site
query = Site.objects.filter(id=1)
site = query.get()
if site.domain == "example.com":
    query.update(
        domain="pythondiscord.local:8000",
        name="pythondiscord.local:8000"
    )```

patent pivot Feb 22, 2022, 3:21 AM

#

i think setting SITE_ID to 1 should still work

#

let me try

#

yeah it does

#

@wild prism @hoary haven as a temporary fix, adding SITE_ID=1 to your pydis_site/settings.py should allow you to view/login/use /admin with credentials created with poetry run python manage.py createsuperuser

#

i don't think there would be any problems if we added SITE_ID 1 to prod settings.py tbh, or at least debug, but it'd make admin work out of the box

wild prism Feb 22, 2022, 3:25 AM

#

👍 working

tawdry vapor Feb 22, 2022, 3:26 AM

#

Well there you go you can make your first contribution already

wild prism Feb 22, 2022, 3:27 AM

#

poetry run python manage.py createsuperuser what's this about?

tawdry vapor Feb 22, 2022, 3:27 AM

#

You shouldn't have to do that. I am pretty sure the run command already creates one.

wild prism Feb 22, 2022, 3:27 AM

#

yeah its just admin/admin, right?

tawdry vapor Feb 22, 2022, 3:28 AM

#

I think

#

It's whatever these are https://github.com/python-discord/site/blob/3f8854ebd7daa35f9e896b95efa3e4ff7d23185d/manage.py#L61-L62

stable mountainBOT Feb 22, 2022, 3:28 AM

#

manage.py lines 61 to 62

name = os.environ["SUPER_USERNAME"]
password = os.environ["SUPER_PASSWORD"]```

tawdry vapor Feb 22, 2022, 3:28 AM

#

https://github.com/python-discord/site/blob/3f8854ebd7daa35f9e896b95efa3e4ff7d23185d/manage.py#L11-L16

stable mountainBOT Feb 22, 2022, 3:28 AM

#

manage.py lines 11 to 16

DEFAULT_ENVS = {
    "DJANGO_SETTINGS_MODULE": "pydis_site.settings",
    "SUPER_USERNAME": "admin",
    "SUPER_PASSWORD": "admin",
    "DEFAULT_BOT_API_KEY": "badbot13m0n8f570f942013fc818f234916ca531",
}```

hoary haven Feb 22, 2022, 3:55 AM

#

@tawdry vapor

A

        await channel.send(
            f"There {'is' if number_of_channels_left == 1 else 'are'} "
            f"only {number_of_channels_left} dormant channel{'' if number_of_channels_left == 1 else 's'} left. "
            "Consider participating in some help channels so that we don't run out."
        )```

or B?
```py
        if number_of_channels_left == 1:
            message = f"There is only {number_of_channels_left} dormant channel left. "
        else:
            message = f"There are only {number_of_channels_left} dormant channels left. "
        message += "Consider participating in some help channels so that we don't run out."
        await channel.send(message)```

#

i was considering A before i realized there's another plural word later in the sentence

tawdry vapor Feb 22, 2022, 3:56 AM

#

Neither

#

verb = 'is' if number_of_channels_left == 1 else 'are'
await channel.send(f"... {verb} only {number_of_channels_left} ...")```
That is better IMO

hoary haven Feb 22, 2022, 3:57 AM

#

then it's There is only 1 dormant channels left

#

also will we ever configure this to 1

tawdry vapor Feb 22, 2022, 3:57 AM

#

Oh yeah

#

I guess B is the better one

tawdry vapor Feb 22, 2022, 3:57 AM

#

hoary haven also will we ever configure this to 1

Probably not. That's why I didn't make it a requested change

hoary haven Feb 22, 2022, 3:57 AM

#

the rest is just removing some extra spaces and changing finally to else right?

tawdry vapor Feb 22, 2022, 3:57 AM

#

Yea

#

I tested it and it works fine

hoary haven Feb 22, 2022, 4:01 AM

#

also i'm wondering if this part in the config description is correct

#

# Note Discord has a hard limit of 50 channels per category, so this shouldn't be > 50
max_total_channels: 42```

#

i think 42+3 available is the true max across all 3 categories

fallen patrol Feb 22, 2022, 4:02 AM

#

its not when you think about it

#

or rather

#

it shouldn't be

#

42 should be the true max

#

this is because no one category can have more than 50 channels, so it doesn't help to have 53, because those 3 channels can never all be available at the same time

fallen patrol Feb 22, 2022, 4:04 AM

#

fallen patrol its not when you think about it

fwiw I was only confused on this 3 times mmlol

tawdry vapor Feb 22, 2022, 4:04 AM

#

hoary haven ```# Maximum number of channels across all 3 categories # Note Discord has a har...

Yes, I was running into this too. It wasn't counting available channels.

fallen patrol Feb 22, 2022, 4:05 AM

#

aah, ignore me then

tawdry vapor Feb 22, 2022, 4:06 AM

#

However, the amount of names it generates uses max_total_channels... so I am not sure what was going on.

#

Maybe my bot was bugged out and miscounted channels. Might be related to one of the names having an emoji in it still.

hoary haven Feb 22, 2022, 4:08 AM

#

right now when i hit the limit it's always
max_available: 2

max_total_channels: 4
1
i think.

sleek steppe Feb 22, 2022, 4:09 AM

#

When I tried to test that pr, I got many errors, so I updated my local branch to main, and got a new one… https://github.com/python-discord/bot/blob/main/bot/exts/help_channels/_channel.py#L185 seems like this line doesn’t check if the regex matches, causing the infamous nonetype attribute error.

stable mountainBOT Feb 22, 2022, 4:09 AM

#

bot/exts/help_channels/_channel.py line 185

user_id = CLAIMED_BY_RE.match(message.embeds[0].description).group("user_id")```

hoary haven Feb 22, 2022, 4:09 AM

#

i have no emoji in mine

tawdry vapor Feb 22, 2022, 4:10 AM

#

There is this log line f"Got {len(names)} used names: {names}" what shows for you in the console when the cog is loaded?

#

And also "f"Getting the first {count} food names from JSON."

tawdry vapor Feb 22, 2022, 4:12 AM

#

sleek steppe When I tried to test that pr, I got many errors, so I updated my local branch to...

Wouldn't it fail earlier when it does int(None)?

sleek steppe Feb 22, 2022, 4:13 AM

#

No, it fails at the .group()

tawdry vapor Feb 22, 2022, 4:13 AM

#

I was also getting errors when channels don't have claimants. It was fetching something from the cache presumably, but it returned None, so it tried to do fetch_user on None and was throwing errors.

sleek steppe Feb 22, 2022, 4:14 AM

#

Yeah, a pr was merged for that yesterday

tawdry vapor Feb 22, 2022, 4:14 AM

#

I guess the notifications PR is not up to date yet then

sleek steppe Feb 22, 2022, 4:14 AM

#

bot#2078

dusky shoreBOT Feb 22, 2022, 4:14 AM

#

GitHub

PRMerged Ensure claimant cache is populated on help channel init

patent pivot Feb 22, 2022, 4:14 AM

#

yeah I think we merged something to try recover claimants from channel content

#

if the redis cache doesn't have a key for it

sleek steppe Feb 22, 2022, 4:14 AM

#

tawdry vapor I guess the notifications PR is not up to date yet then

yeah, so I pulled from main and got the new error

hoary haven Feb 22, 2022, 4:15 AM

#

6 used names
Getting the first 4 food names from JSON.

this is from running after resetting to 6 total channels all in dormant

tawdry vapor Feb 22, 2022, 4:15 AM

#

That seems like an invalid state.

#

If the bot only generates 4 names, as you asked it to, how did it manage to create 6 channels? The only way would be if the channels already existed and you then lowered the limit. At least, that should be the only way in theory.

hoary haven Feb 22, 2022, 4:17 AM

#

uh the 6 channels were there from a previous run. i've been manually moving occupied channels to dormant before rerunning

tawdry vapor Feb 22, 2022, 4:17 AM

#

Cause the code path for new channels relies on the name queue https://github.com/python-discord/bot/blob/main/bot/exts/help_channels/_cog.py#L199-L203

And in turn https://github.com/python-discord/bot/blob/main/bot/exts/help_channels/_cog.py#L250-L254

stable mountainBOT Feb 22, 2022, 4:17 AM

#

bot/exts/help_channels/_cog.py lines 199 to 203

try:
    name = self.name_queue.popleft()
except IndexError:
    log.debug("No more names available for new dormant channels.")
    return None```
`bot/exts/help_channels/_cog.py` lines 250 to 254
```py
log.info("No candidate channels in the queue; creating a new channel.")
channel = await self.create_dormant()

if not channel:
    log.info("Couldn't create a candidate channel; waiting to get one from the queue.")```

tawdry vapor Feb 22, 2022, 4:18 AM

#

I think the description in the config is right. You just started with more channels than configured.

#

If you delete all the channels, then it should work correctly I hope.

hoary haven Feb 22, 2022, 4:19 AM

#

yeah let's try that

tawdry vapor Feb 22, 2022, 4:19 AM

#

Or delete 3, so you have 3 left, and then it should create 1 more before saying it's full (assuming you leave the cfg at 4 max)

hoary haven Feb 22, 2022, 4:19 AM

#

i did test starting with fewer channels than max, but not from 0

#

so starting from 0, it maxed at 4

#

ok

#

i'll wait for toxic's review before pushing changes? since they're very minor?

#

and yeah this notifications PR was opened and not touched since before that #2078

clever wraith Feb 22, 2022, 5:50 AM

#

#

So y’all see how pings sometimes show up like this

#

I think it’ll be better if it were to say

#

"Please send a direct message to Python Discord ModMail#6914 ( @slow bone )" or sum

rapid swallow Feb 22, 2022, 5:51 AM

#

sounds good to me

clever wraith Feb 22, 2022, 5:51 AM

#

Cuz if you were new and you don’t really understand how pings are formatted

#

It’ll look kinda strange

#

Is there any way for me to write a PR for this?

#

It’s a pretty simple pr honestly

rapid swallow Feb 22, 2022, 5:51 AM

#

not sure if we should include the nickname or username

clever wraith Feb 22, 2022, 5:51 AM

#

Hmm

#

It could be nickname assuming the person would go "Okay I need to find modmail" and they swipe to the right and see modmail

#

I’m pretty sure most people would know this anyways

hoary haven Feb 22, 2022, 5:56 AM

#

impressive ping count

rapid swallow Feb 22, 2022, 5:56 AM

#

*horrific

hoary haven Feb 22, 2022, 5:57 AM

#

but yeah this sounds good, idk if a PR will work since it's just internal.. stuff. will ask admins to action it sometime tomorrow

rapid swallow Feb 22, 2022, 5:57 AM

#

how about a screenshot

#

"Please send a direct message to Python Discord ModMail#6914 ( @slow bone )"

hoary haven Feb 22, 2022, 5:59 AM

#

it's a good idea but it would overwhelm the #rules embed for which we want the focus to be on rules

#

iirc discord doesn't allow for custom sized images does it?

rapid swallow Feb 22, 2022, 6:11 AM

#

oh
i thought it's the bot DM from when you join the server

rapid swallow Feb 22, 2022, 6:12 AM

#

clever wraith Is there any way for me to write a PR for this?

sorry, no

clever wraith Feb 22, 2022, 6:56 AM

#

Doesn't the welcome video mentions modmail?

fallen patrol Feb 22, 2022, 7:12 AM

#

hoary haven iirc discord doesn't allow for custom sized images does it?

kind of, are you talking about embed images?

thorny spade Feb 22, 2022, 8:58 AM

#

https://github.com/python-discord/sir-lancebot/issues/990

GitHub

Internal eval logs an exception if the hastebin payload is too long...

Sentry Issue: SIR-LANCEBOT-7F Relevant lines: sir-lancebot/bot/exts/core/internal_eval/_internal_eval.py Lines 96 to 98 in ec6eb2e except Exception: # 400 (Bad Request) means there are too many cha...

#

i can work on this! can i be assigned? i have commented on github and didnt have a response yet

gritty wind Feb 22, 2022, 9:57 AM

#

Assigned

#

Though I wonder which one of y’all is doing int es with 1000000 characters

clever wraith Feb 22, 2022, 10:04 AM

#

Haha

vale ibex Feb 22, 2022, 10:04 AM

#

Me 😄

#

it was when Discord was erroring out at CF level, so API calls were returning full html pages

clever wraith Feb 22, 2022, 10:05 AM

#

Too bad the Egyptian vs French boat battle didn't also include removing sea mines

#

Although wouldn't it make sense to use a thread to play minesweeper now?

#

It seems to have become quite common

#

🏓 @gritty wind as you wrote the issue

gritty wind Feb 22, 2022, 11:33 AM

#

Sure a thread sounds good

vale ibex Feb 22, 2022, 11:58 AM

#

Does battle ships have a similar issue?

#

or did we not restrict that one?

clever wraith Feb 22, 2022, 12:29 PM

#

battleship plays in DMs, but scale made sure it could still be played

#

that's the egypt vs france reference haha

gritty wind Feb 22, 2022, 12:41 PM

#

It was an epic, very slow battle

#

The delay is killer for a game lol

clever wraith Feb 22, 2022, 1:01 PM

#

it seemed as slow as an IRL battleship game haha

thorny spade Feb 22, 2022, 2:23 PM

#

python-discord/sir-lancebot#1041

dusky shoreBOT Feb 22, 2022, 2:23 PM

#

GitHub

PROpen truncate output.

thorny spade Feb 22, 2022, 2:23 PM

#

how do you think

hoary haven Feb 22, 2022, 2:39 PM

#

fallen patrol kind of, are you talking about embed images?

yes, images in embeds

clever wraith Feb 22, 2022, 2:40 PM

#

I've left a small comment, looks good apart from that

#

Although you should create a new git branch when working on a PR

#

Otherwise you may run into the risk of mixing commits between PRs, and it is a mess to fix

#

@thorny spade what do you use to interact with Git? Your IDE, the command line, github desktop, etc..

thorny spade Feb 22, 2022, 2:42 PM

#

clever wraith <@716134528409665586> what do you use to interact with Git? Your IDE, the comman...

sometime ide

#

sometime github dot com

clever wraith Feb 22, 2022, 2:42 PM

#

Oki, do you use PyCharm?

thorny spade Feb 22, 2022, 2:43 PM

#

vscode

#

#

i actually forgot to create a new branch

#

💀

thorny spade Feb 22, 2022, 2:43 PM

#

thorny spade

wdym by this

#

@clever wraith

#

@clever wraith can you reply?

placid ermine Feb 22, 2022, 2:50 PM

#

thorny spade wdym by this

set a variable like MAX_LENGTH = 99980 towards the beginning of the file and pass it as an argument, instead of hardcoding the number directly

thorny spade Feb 22, 2022, 2:55 PM

#

placid ermine set a variable like `MAX_LENGTH = 99980` towards the beginning of the file and p...

ic thanks

thorny spade Feb 22, 2022, 2:57 PM

#

placid ermine set a variable like `MAX_LENGTH = 99980` towards the beginning of the file and p...

done!

vale ibex Feb 22, 2022, 3:03 PM

#

Yea, for some context this type of things is referred to as a magic number or magic constant. It's considered to be an anti-pattern to use numbers directly within source code. It's said to be one of the oldest rules of programming.

#

So defining them as constants at the top of the file with a name, means that when they're used within the code itself there is some added context

#

which in turn makes it easier to read, understand and maintain. Especially if the same number is used in multiple places, it means you only need to change it in that one place at the top of the file

thorny spade Feb 22, 2022, 3:10 PM

#

vale ibex which in turn makes it easier to read, understand and maintain. Especially if th...

ic

#

thanks for the explanation!

vale ibex Feb 22, 2022, 3:10 PM

#

No problem!

clever wraith Feb 22, 2022, 3:13 PM

#

thorny spade <@456226577798135808>

what chris said ducky_dave

#

alas

#

hey @thorny obsidian, are you around?

placid ermine Feb 22, 2022, 4:05 PM

#

clever wraith what chris said <:ducky_dave:742058418692423772>

what about what i said 😠 ||/s||

clever wraith Feb 22, 2022, 4:06 PM

#

what you said too lemon_sentimental

thorny spade Feb 22, 2022, 4:07 PM

#

smh

cold island Feb 22, 2022, 7:37 PM

#

Hmmm I'm trying to mock a channel with a category with a specific ID MockTextChannel(category=MockCategoryChannel(id=456))
But that doesn't seem to work, channel.category.id is some MagicMock object

#

oh now it's a number

#

but it's still not the right number

#

Think I found a bug in the mock class

vale ibex Feb 22, 2022, 7:46 PM

#

🤔

#

interesting

cold island Feb 22, 2022, 7:46 PM

#

Will make sure the fix doesn't fuck up the other tests

#

Basically it chained the input args and defaults wrong, so the defaults ran over the input

vale ibex Feb 22, 2022, 7:47 PM

#

Does the ChainMap not correctly overwrite the defauit?

cold island Feb 22, 2022, 7:47 PM

#

yeah

vale ibex Feb 22, 2022, 7:47 PM

#

ahhh

#

lol i just looked at it and came to the same conclusion

#

Does the access priority from chainmap rely on the order they're passed to the constructor?

fallen patrol Feb 22, 2022, 7:49 PM

#

hoary haven yes, images in embeds

it's viewer/os dependent

#

essentially this happens if it's too large:

cold island Feb 22, 2022, 7:52 PM

#

vale ibex Does the access priority from chainmap rely on the order they're passed to the c...

apparently

vale ibex Feb 22, 2022, 7:52 PM

#

interesting

cold island Feb 22, 2022, 7:52 PM

#

The class was only ever used once and without params

vale ibex Feb 22, 2022, 7:52 PM

#

lol

cold island Feb 22, 2022, 7:53 PM

#

If the tests test our code, who will test our tests peepoCry

vale ibex Feb 22, 2022, 7:53 PM

#

you apparently

wild prism Feb 22, 2022, 7:53 PM

#

the code

#

generative adversarial network-driven development

rapid swallow Feb 22, 2022, 7:54 PM

#

fallen patrol essentially this happens if it's too large:

👁️

cold island Feb 22, 2022, 7:54 PM

#

lmao

rapid swallow Feb 22, 2022, 7:54 PM

#

!otn a generative adversarial network-driven development

stable mountainBOT Feb 22, 2022, 7:55 PM

#

:ok_hand: Added generative-adversarial-network-driven-development to the names list.

cold island Feb 22, 2022, 7:55 PM

#

aka Gandhi development

hoary haven Feb 22, 2022, 8:03 PM

#

fallen patrol essentially this happens if it's too large:

hahaha

#

i'm leaning towards the banner still, tbh

#

so long as we can size it correctly

#

and crop the unnecessary space on top

cold island Feb 22, 2022, 8:08 PM

#

🤨

hoary haven Feb 22, 2022, 8:08 PM

#

hoary haven i'm leaning towards the banner still, tbh

like look how good these look https://raw.githubusercontent.com/python-discord/branding/main/events/diwali/banner.png

#

https://raw.githubusercontent.com/python-discord/branding/main/events/holi/banner.png

vale ibex Feb 22, 2022, 8:09 PM

#

cold island 🤨

it means the files that it stashed (because they weren't staged for commit) conflicted with changes that pre-commit tried to do

cold island Feb 22, 2022, 8:10 PM

#

I don't follow lol. If it's stashed why is it conflicting

vale ibex Feb 22, 2022, 8:10 PM

#

a pre-commit fix makes a change and saves the file right

#

what that's saying is the change it was going to do conflicted with the files that weren't staged for commit

cold island Feb 22, 2022, 8:11 PM

#

how is that possible

vale ibex Feb 22, 2022, 8:11 PM

#

since when pre-commit runs it stashes un-staged files and then applies the stash after it's done

vale ibex Feb 22, 2022, 8:11 PM

#

cold island how is that possible

what fix did pre-commit try to do?

cold island Feb 22, 2022, 8:11 PM

#

The unstaged stuff is two files I'm just not adding

#

like.. they don't exist at all in remote

cold island Feb 22, 2022, 8:12 PM

#

vale ibex what fix did pre-commit try to do?

isort

vale ibex Feb 22, 2022, 8:12 PM

#

The file that it's trying to fix the import for, does that also have changes that you haven't added to the staging area?

cold island Feb 22, 2022, 8:14 PM

#

oh.. git is saying there are unstaged changes to another file... but when I pull up the diff it's... nothing

#

And now it worked.. even though I made sure it was staged before committing 🤨

#

ok, well, thanks lol

rapid swallow Feb 22, 2022, 9:20 PM

#

hoary haven i'm leaning towards the banner still, tbh

same, me too

#

#

looks fine on mobile too

#

only issue is the padding at the top

#

we can crop it with pillow or something

#

@stable mountain doesnt have pillow as a dependency atm

#

this is with the icon, i dont like how the text gets squeezed

hoary haven Feb 22, 2022, 9:26 PM

#

the embed width flexes to match the image width?

hoary haven Feb 22, 2022, 9:26 PM

#

rapid swallow

i think this would be my preference, with the extra chunk on top cropped

rapid swallow Feb 22, 2022, 9:27 PM

#

also an option

hoary haven Feb 22, 2022, 9:27 PM

#

that looks good too DogeKek i'm sure it'd be easier

cold island Feb 22, 2022, 9:30 PM

#

yeah the last one seems preferable

fallen patrol Feb 22, 2022, 9:32 PM

#

@vale ibex I'm a tad surprised, (bot-core#32) no upper bound on the disnake dependency? Or I presume that's because its a package and it will be further restricted on the dependencies that use it?

dusky shoreBOT Feb 22, 2022, 9:32 PM

#

GitHub

PROpen Disnake migration

vale ibex Feb 22, 2022, 9:33 PM

#

fallen patrol <@!126811506632294400> I'm a tad surprised, (bot-core#32) no upper bound on the ...

Yea, the package will define the version more precisely

fallen patrol Feb 22, 2022, 9:33 PM

#

👍

vale ibex Feb 22, 2022, 9:33 PM