cold island Dec 3, 2021, 4:24 PM

#

We can't tell it to not go into a package

gritty wind Dec 3, 2021, 4:24 PM

#

Ah, that doesn't really matter

cold island Dec 3, 2021, 4:24 PM

#

We can tell it to ignore each file in it it finds

gritty wind Dec 3, 2021, 4:24 PM

#

Since all sub packages will be ignored too

#

As soon as it finds an underscore anywhere in that path it'll quit

fallen patrol Dec 3, 2021, 4:25 PM

#

yep, or switch the generator to use a recursive function which can knock them out faster 🙃

#

meh your solution is better and faster

gritty wind Dec 3, 2021, 4:25 PM

#

Over optimization

gritty wind Dec 3, 2021, 4:25 PM

#

gritty wind As soon as it finds an underscore anywhere in that path it'll quit

the line after the if is continue

fallen patrol Dec 3, 2021, 4:25 PM

#

gritty wind Over optimization

I'm known for that

#

taking a break from trying to set it up, lol

gritty wind Dec 3, 2021, 4:27 PM

#

Why don't you have docker on your local machine again?

#

@cold island give this patch a shot, it seems to be working from my testing
https://paste.pythondiscord.com/evodefigog.lua

cold island Dec 3, 2021, 4:30 PM

#

Hmm... seems like the error is coming from walk_packages

gritty wind Dec 3, 2021, 4:30 PM

#

What error are you having?

cold island Dec 3, 2021, 4:33 PM

#

It's an ImportError but I only have the traceback object

#

I'll try removing the onerror

gritty wind Dec 3, 2021, 4:34 PM

#

If you send the error, could help

#

I've become deeply unfamiliar with the import system

#

... for better or for worse

cold island Dec 3, 2021, 4:35 PM

#

uuuh

gritty wind Dec 3, 2021, 4:35 PM

#

Do you still have the function?

green oriole Dec 3, 2021, 4:35 PM

#

circular references?

cold island Dec 3, 2021, 4:36 PM

#

I removed it

green oriole Dec 3, 2021, 4:36 PM

#

actually, the error would be different

short snow Dec 3, 2021, 4:36 PM

#

circular references has differnt erros

cold island Dec 3, 2021, 4:36 PM

#

There are no other mentions of that function

gritty wind Dec 3, 2021, 4:36 PM

#

It's used in a converter

#

For the ext command

green oriole Dec 3, 2021, 4:36 PM

#

lol it is used somewhere for something once

gritty wind Dec 3, 2021, 4:37 PM

#

Why do you have a greyscale santa hat. It looks like someone took a white marker to your pfp

short snow Dec 3, 2021, 4:37 PM

#

λ rg "unqualify"
bot/converters.py
22:from bot.utils.extensions import EXTENSIONS, unqualify
160:            if argument == unqualify(ext):

bot/utils/extensions.py
9:def unqualify(name: str) -> str:
21:        if unqualify(module.name).startswith("_"):

cold island Dec 3, 2021, 4:37 PM

#

Ok

#

it works!

#

it works.

green oriole Dec 3, 2021, 4:38 PM

#

gritty wind Why do you have a greyscale santa hat. It looks like someone took a white marker...

yes

#

ngl the white line makes me think paramount

short snow Dec 3, 2021, 4:39 PM

#

put on a real christmas hat and change pfp

green oriole Dec 3, 2021, 4:39 PM

#

that's my plan

short snow Dec 3, 2021, 4:39 PM

#

actually just take all event pfps together so you won't need to set it up everytime

clever wraith Dec 3, 2021, 4:47 PM

#

https://github.com/python-discord/sir-lancebot/issues/965 could someone please check this issue ?

green oriole Dec 3, 2021, 4:48 PM

#

didn't someone (@cold island or @gritty wind, maybe?) said something against a blackjack game

short snow Dec 3, 2021, 4:49 PM

#

well scal did and did not, he was not opposed to it but told it has been shot down many times in the past for gambling

clever wraith Dec 3, 2021, 4:49 PM

#

Well Scaleios did bring up its a big chance of the idea getting denied but I still would want an answer to the issue? 🤷

green oriole Dec 3, 2021, 4:51 PM

#

I'm not a true fan of it because of the gambling aspect either, yeah

#

kind of reminds me of twitch's prediction system

fallen patrol Dec 3, 2021, 4:59 PM

#

@gritty wind I got it live by modifying the docker-compose file

#

#

no more port forwarding necessary

#

...

#

@vale ibex all this to realise I can't test the partial message pr

#

I don't have a message old enough in the server to be out of the cache

brisk brook Dec 3, 2021, 5:04 PM

#

fallen patrol I don't have a message old enough in the server to be out of the cache

Can't you just restart the bot/site?

fallen patrol Dec 3, 2021, 5:04 PM

#

I think that dpy will fetch recent messages and add them to the cache

#

meh I edited the bot to disable the cache temporarily

vale ibex Dec 3, 2021, 5:05 PM

#

It doesn't, it only fills the cache on_message

fallen patrol Dec 3, 2021, 5:05 PM

#

and it doesn't work

vale ibex Dec 3, 2021, 5:05 PM

#

so send a message, kill your bot, start it again

fallen patrol Dec 3, 2021, 5:05 PM

#

vale ibex Dec 3, 2021, 5:05 PM

#

Is that in DMs?

fallen patrol Dec 3, 2021, 5:05 PM

#

vale ibex so send a message, kill your bot, start it again

I emptied the cache by passing None in the constructor

#

nope

#

wait

#

https://github.com/Rapptz/discord.py/blob/45d498c1b76deaf3b394d17ccf56112fa691d160/discord/client.py#L120-L122

stable mountainBOT Dec 3, 2021, 5:06 PM

#

discord/client.py lines 120 to 122

max_messages: Optional[:class:`int`]
    The maximum number of messages to store in the internal message cache.
    This defaults to ``1000``. Passing in ``None`` disables the message cache.```

fallen patrol Dec 3, 2021, 5:06 PM

#

I'll try setting this to 1 in case setting it to none also disables a channel cache for some reason

#

nope

vale ibex Dec 3, 2021, 5:06 PM

#

you cna leave it default, and just restart your bot after sending a message

#

Do you have more of a traceback, to see what is raising that error?

fallen patrol Dec 3, 2021, 5:07 PM

#

still fails

fallen patrol Dec 3, 2021, 5:08 PM

#

vale ibex Do you have more of a traceback, to see what is raising that error?

gimme a few minutes, I need to set up a modlog to sort through this cruft

vale ibex Dec 3, 2021, 5:08 PM

#

could you do !int e print(ctx.channel.id)

#

in that channel

fallen patrol Dec 3, 2021, 5:09 PM

#

vale ibex Dec 3, 2021, 5:13 PM

#

what about !int e print(ctx.guild._resolve_channel(ctx.channel.id))

fallen patrol Dec 3, 2021, 5:14 PM

#

nice

#

#

internal error

vale ibex Dec 3, 2021, 5:15 PM

#

interesting

gritty wind Dec 3, 2021, 5:16 PM

#

Missing a )

fallen patrol Dec 3, 2021, 5:16 PM

#

...why does it delete the response??

gritty wind Dec 3, 2021, 5:17 PM

#

That is something The ChrisMan will have to answer

fallen patrol Dec 3, 2021, 5:18 PM

#

guess i'll try to configure some of the emojis

gritty wind Dec 3, 2021, 5:18 PM

#

For a second there my brain started taking chrisman to Christmas, and i was thinking “oh wow, Chris sounds a lot like Christmas”

Then I realize I’m an idiot that hasn’t slept in a day

fallen patrol Dec 3, 2021, 5:18 PM

#

Christmasjl

fallen patrol Dec 3, 2021, 5:19 PM

#

vale ibex what about `!int e print(ctx.guild._resolve_channel(ctx.channel.id))`

it returned the channel name

vale ibex Dec 3, 2021, 5:20 PM

#

hmmm

fallen patrol Dec 3, 2021, 5:20 PM

#

fallen patrol ...why does it delete the response??

i figured out why

vale ibex Dec 3, 2021, 5:20 PM

#

oh, errros are deleted after a while

#

that's in our error handler

#

Hmmm I can't see why it's not working on your bot

fallen patrol Dec 3, 2021, 5:23 PM

#

fallen patrol i figured out why

i configured all of the channels to the same channel 🙃

vale ibex Dec 3, 2021, 5:23 PM

#

Ah

#

That shouldn't cause an issue here

#

Oh, is there another deco on that command?

fallen patrol Dec 3, 2021, 5:24 PM

#

vale ibex Dec 3, 2021, 5:24 PM

#

like a perm check or smth

fallen patrol Dec 3, 2021, 5:24 PM

#

defcon & interaction channel

vale ibex Dec 3, 2021, 5:24 PM

#

the error might be coming from there

fallen patrol Dec 3, 2021, 5:24 PM

#

reactions go brr

vale ibex Dec 3, 2021, 5:24 PM

#

lol

fallen patrol Dec 3, 2021, 5:24 PM

#

now I can try

vale ibex Dec 3, 2021, 5:24 PM

#

That makes sense now

fallen patrol Dec 3, 2021, 5:25 PM

#

and sadly the patch did not work

vale ibex Dec 3, 2021, 5:25 PM

#

Could you expand on that?

#

Since it works on my bot just fine, and you have just shown that the last time you said that it was because of configuration.

fallen patrol Dec 3, 2021, 5:26 PM

#

vale ibex Dec 3, 2021, 5:26 PM

#

What were the steps?

fallen patrol Dec 3, 2021, 5:26 PM

#

log is literally:

#

2021-12-03 12:26:01 | bot.exts.backend.error_handler | DEBUG | Command raw invoked by arl#8028 with error ChannelNotFound: Channel "None" not found.

fallen patrol Dec 3, 2021, 5:27 PM

#

vale ibex What were the steps?

would it make some sense for you to join my server, and try the bot yourself?

vale ibex Dec 3, 2021, 5:27 PM

#

So, before it hits the Message convertor, it goes through the other decorators

#

namely @in_whitelist(channels=(constants.Channels.bot_commands,), roles=constants.STAFF_PARTNERS_COMMUNITY_ROLES)

#

So, is your bot commands a valid channel that exists in your server?

fallen patrol Dec 3, 2021, 5:27 PM

#

it is, but I wasn't in that channel

#

I have the staff roles, tho

vale ibex Dec 3, 2021, 5:28 PM

#

Could you send me your config.yml and invite me to your server?

fallen patrol Dec 3, 2021, 5:29 PM

#

(your) dms are closed 🙃

vale ibex Dec 3, 2021, 5:29 PM

#

Mine are open for this server

#

Always have been

fallen patrol Dec 3, 2021, 5:29 PM

#

oh, I have them closed for this server and opened in lemon's server lmao

#

my current config https://paste.pythondiscord.com/awisilezuy.yaml

fallen patrol Dec 3, 2021, 5:40 PM

#

vale ibex namely `@in_whitelist(channels=(constants.Channels.bot_commands,), roles=constan...

update: we (okay, chris) figured out that this is the cause of the problem

#

oh

#

lol

#

tldr method name wasn't ever being called

green oriole Dec 3, 2021, 5:52 PM

#

@thorny obsidian didn't we used to have a link command for the aoc? or maybe it was for hacktoberfest

thorny obsidian Dec 3, 2021, 5:53 PM

#

green oriole <@!212644551926611969> didn't we used to have a link command for the aoc? or may...

Nope. It was for hacktoberfest. My issue references it and the PR links to the issue.

green oriole Dec 3, 2021, 5:53 PM

#

oh right, you made the issue

#

I got some things messed up

#

excellent

#

do we use Redis?

#

oh you made the PR

thorny obsidian Dec 3, 2021, 5:54 PM

#

Yes. My issue states that that should be the implementation used and my PR description says it's implemented with a redis cache.

green oriole Dec 3, 2021, 5:54 PM

#

gotcha gotcha

#

just a small nitpick that isn't worth changing, you send the log line {ctx.author} ({ctx.author.id}) is now linked to {aoc_name}. before actually setting the value, which may be a little confusing when trying to understand an error

clever wraith Dec 3, 2021, 5:58 PM

#

finally managed to get tldextract working last night

green oriole Dec 3, 2021, 5:58 PM

#

other than that, the PR looks pretty good in its current state

thorny obsidian Dec 3, 2021, 5:58 PM

#

I wanted to log that before you set it because if it somehow errors or crashes during the set for whatever reason you won't have a log of what caused it.

green oriole Dec 3, 2021, 5:59 PM

#

I'd have worded linking {ctx.author} ({ctx.author.id}) to {aoc_name} if the log line happens before the action is actually being done

#

I don't think the last two comments are really worth actioning

#

the part about the length being 0 being fine is true though, you'll just end up with an empty list

thorny obsidian Dec 3, 2021, 6:03 PM

#

Yeah, I do plan on removing that. I had in there to prevent an earlier issue that I ended up accidentally refactoring out

green oriole Dec 3, 2021, 6:03 PM

#

I see, I see

clever wraith Dec 3, 2021, 6:04 PM

#

@vale ibex when you've got time, do you mind looking at bot#1889? tldextract has been fully implemented and tested

dusky shoreBOT Dec 3, 2021, 6:04 PM

#

GitHub

PROpen feat: added url parsing to the filter

vale ibex Dec 3, 2021, 6:19 PM

#

So the reason we added tldextract was so that we could do subdomain and path parsing nicely

#

So it would make sense to change the check to be something like ```py
regex = r"\S+?.\S+"

sent_subdomain, sent_domain, sent_tld, sent_path = magic_extract_func(url)
for blacklist_url in blacklist:
filter_subdomain, filter_domain, filter_tld, filter_path = magic_extract_func(filter_url)

if filter_domain == sent_domain and filter_tld == sent_tld:
    if fitler_path and sent_path != fitler_path and filter_subdomain != sent_subdomain:
        return False, ...
    return True, ...

#

changing the url regex too, so that we match on more things

#

of course this is pseudo code, so please don't just copy-paste it verbatim and expect it to work 😄

#

@clever wraith ^

fallen patrol Dec 3, 2021, 6:25 PM

#

chris, is #778 up for grabs 🥺

vale ibex Dec 3, 2021, 6:25 PM

#

which repo?

fallen patrol Dec 3, 2021, 6:26 PM

#

@dusky shore

vale ibex Dec 3, 2021, 6:26 PM

#

Ah, I was hoping to finish off what it says on the tin and then move a lot of stuff to other issues

#

I just haven't worked through feedback

fallen patrol Dec 3, 2021, 6:26 PM

#

oh okay

#

in that case my comments can probably be moved to issues

vale ibex Dec 3, 2021, 6:27 PM

#

👍

fallen patrol Dec 3, 2021, 6:27 PM

#

...which I can then be assigned to :)

vale ibex Dec 3, 2021, 6:27 PM

#

hah yea

#

Also I do list(dict.fromkeys(my_list)) quite often to remove duplicates and retain order 😛

fallen patrol Dec 3, 2021, 6:28 PM

#

I wish there was a better way than that...

vale ibex Dec 3, 2021, 6:28 PM

#

there's also more_itertools.unique_everseen

fallen patrol Dec 3, 2021, 6:28 PM

#

like orderedset or other thing

vale ibex Dec 3, 2021, 6:29 PM

#

But that's in Python afaik, so using dict.fromkeys is better

#

since it's in the C layer

fallen patrol Dec 3, 2021, 6:32 PM

#

I didn't realise that...

clever wraith Dec 3, 2021, 6:36 PM

#

.bm 916393778166792253 intended impl

vale ibex Dec 3, 2021, 6:39 PM

#

fallen patrol chris, is #778 up for grabs 🥺

I've just pushed a commit with some fixes that I think should be done now

#

I think all of your other suggestions could be done in another PR(s)

clever wraith Dec 3, 2021, 6:40 PM

#

hi sorry if being annoying, but how long does it take until there is a deny/accepted response for my issue?

fallen patrol Dec 3, 2021, 6:41 PM

#

looks good in that case

vale ibex Dec 3, 2021, 6:41 PM

#

it depends when people are available to review it, we're all volunteers here. Different people are active at different times

#

Most activity is seen on the weekend, since that's when people tend to have the most free time

fallen patrol Dec 3, 2021, 6:41 PM

#

vale ibex I've just pushed a commit with some fixes that I think should be done now

approved

vale ibex Dec 3, 2021, 6:42 PM

#

Nice, feel free to open an issue enumerating your proposed changes, and i'll get you assigned

fallen patrol Dec 3, 2021, 6:42 PM

#

er, could you please unresolve those 3 comments that you said to make another issue because github is glitching and i can't click them...

vale ibex Dec 3, 2021, 6:42 PM

#

sure sec

#

Done

fallen patrol Dec 3, 2021, 6:42 PM

#

thanks

#

or wait

#

should I even make an issue?

#

could go straight to pr for the ratelimits and issue refactor

#

(basically I'm not sure how I should split them up into issues?)

vale ibex Dec 3, 2021, 6:44 PM

#

Yea, if you don't want to split them into different PRs, feel free to cover it in one

#

I mostly suggested an issue so that people could get context on why we wanted it

#

if you include it in the PR body that should be fine

fallen patrol Dec 3, 2021, 6:46 PM

#

total changes:

constants
move ratelimits
remove git alias
add wait for deletion
include issue number in response
move the if not message.guild check to before we scan for issues
make only one request per pull instead of two

#

yeah, an issue is probably relevant, but can make it with all of those in it

vale ibex Dec 3, 2021, 6:47 PM

#

Yea, seems fine to me

fallen patrol Dec 3, 2021, 6:47 PM

#

lol, bug or feature?

vale ibex Dec 3, 2021, 6:47 PM

#

I'd say all of those fall into feature enhancement/perf enhancements

fallen patrol Dec 3, 2021, 6:48 PM

#

👍

vale ibex Dec 3, 2021, 6:48 PM

#

the ratelimit IG is an edge case bug fix

#

but the rest aren't

fallen patrol Dec 3, 2021, 6:54 PM

#

sir-lancebot#968

dusky shoreBOT Dec 3, 2021, 6:54 PM

#

GitHub

IssueOpen github command enhancements

fallen patrol Dec 3, 2021, 6:55 PM

#

stalled 😔

#

@thorny obsidian I updated sir-lancebot#967 to be better illustrative of the changes that it is requesting.

dusky shoreBOT Dec 3, 2021, 7:01 PM

#

GitHub

IssueOpen aoc leaderboard: use a discord formatted timestamp for when the lb can be next updated

thorny obsidian Dec 3, 2021, 7:02 PM

#

fallen patrol <@!212644551926611969> I updated sir-lancebot#967 to be better illustrative of t...

I'm not sure what problem that's trying to solve. I'd like to retain the information that the leaderboard can only be refreshed in 30 minute intervals. Replacing that with a dynamic timestamp removes that information.

fallen patrol Dec 3, 2021, 7:03 PM

#

see sir-lancebot#966 for why the information of 30 minutes hasn't worked

dusky shoreBOT Dec 3, 2021, 7:03 PM

#

GitHub

IssueOpen aoc buff: remove the leaderboard command, and make it an updating message

thorny obsidian Dec 3, 2021, 7:04 PM

#

I've read through that issue and responded. People who don't read the embed will still continue to not read the embed. Making it a dynamic timestamp just obfuscates that it's on a 30 minute interval.

fallen patrol Dec 3, 2021, 7:05 PM

#

I read the embed, but as I commented above, I (and likely others) did not see that last updated tiny footer until it was pointed out

#

there are other fields in an embed which are larger than the timestamp location, which is small and appears differently on different platforms

#

i understand wanting to keep the information, and that all of the information is already there, however, the presentation ends up shadowing some of the information with the large code block above the embed

cold island Dec 3, 2021, 7:10 PM

#

Why not just move the footer right below the line "The leaderboard is refreshed every 30 minutes."

fallen patrol Dec 3, 2021, 7:10 PM

#

I like that

cold island Dec 3, 2021, 7:11 PM

#

You do lose localized time though

thorny obsidian Dec 3, 2021, 7:11 PM

#

Yeah, when I say read the embed, I do mean the full embed. There isn't always a good solution to people just not reading information provided.

Making it a dynamic timestamp just hides the fact that it's on a 30 minute timer. It's now on a ??? timer.

fallen patrol Dec 3, 2021, 7:11 PM

#

cold island You do lose localized time though

you don't, the <t:x> feature is localized

cold island Dec 3, 2021, 7:11 PM

#

Ah I guess we can make it a timestamp yeah. I was mainly thinking of relative time which I find pretty annoying sometimes

fallen patrol Dec 3, 2021, 7:12 PM

#

In my own usage of it I tend to put an F time right next to an R time

#

<t:1:F> (<t:1:R>)

cold island Dec 3, 2021, 7:13 PM

#

"
The leaderboard is refreshed every 30 minutes.
Last updated <timestamp>

<main message>
"

fallen patrol Dec 3, 2021, 7:13 PM

#

fallen patrol In my own usage of it I tend to put an F time right next to an R time

(not saying we should do that, just agreeing that the R times can be annoying)

cold island Dec 3, 2021, 7:13 PM

#

fallen patrol <t:1:F> (<t:1:R>)

Well you don't need the full datetime here

fallen patrol Dec 3, 2021, 7:13 PM

#

no i mean in my own code that's what I do 😛

fallen patrol Dec 3, 2021, 7:14 PM

#

cold island " The leaderboard is refreshed every 30 minutes. Last updated <timestamp> <main...

I like this, I can implement it if you or kutiekat signs off, although I feel like kutiekat would like to implement it

cold island Dec 3, 2021, 7:14 PM

#

!raw #dev-contrib message

stable mountainBOT Dec 3, 2021, 7:14 PM

#

== Raw message ==

<t:1:F> (<t:1:R>)

cold island Dec 3, 2021, 7:14 PM

#

<t:1:t>

fallen patrol Dec 3, 2021, 7:15 PM

#

hmm, not sure if the enum for this is on lance yet

#

no, its not

thorny obsidian Dec 3, 2021, 7:15 PM

#

fallen patrol I like this, I can implement it if you or kutiekat signs off, although I feel li...

It has nothing to do with my current open PR, why would I want to implement it?

fallen patrol Dec 3, 2021, 7:16 PM

#

i was thinking you'd make a new pr, but hey, if you sign off i can implement it 😄

thorny obsidian Dec 3, 2021, 7:16 PM

#

cold island " The leaderboard is refreshed every 30 minutes. Last updated <timestamp> <main...

Yeah, I'm fine with this. I'm just going to be very particular about keeping the information that it's on a 30 minute timer.

thorny obsidian Dec 3, 2021, 7:16 PM

#

fallen patrol i was thinking you'd make a new pr, but hey, if you sign off i can implement it ...

Why would this require me to make a new PR? It has nothing to do with the .aoc link PR.

fallen patrol Dec 3, 2021, 7:18 PM

#

well, if you were implementing it then as you said because it doesn't have anything to do with your currently open pr you would make a new one with just this change

#

I don't really understand your question, I suppose

#

But if you approve the issue, I can go ahead and implement it

thorny obsidian Dec 3, 2021, 7:23 PM

#

I'm very careful in lancebot that I don't actually PR anything that other people can work and would be a good experience for them. It's why I make issues but you almost never see me make a PR to that repo. Just because I comment on an issue or provide feedback does not mean I want to work on it.

The notable exception being things that are blocking other things I'd like to do. I PRed .aoc link because it's blocking an announcement I'd like to make and other work I'd like to do behind the scenes.

thorny obsidian Dec 3, 2021, 7:24 PM

#

fallen patrol But if you approve the issue, I can go ahead and implement it

Adding a dynamic timestamp in the main body is fine though, you can implement it.

fallen patrol Dec 3, 2021, 7:25 PM

#

cold island " The leaderboard is refreshed every 30 minutes. Last updated <timestamp> <main...

I was going to implement this and remove the footer last-updated

#

I won't implement it unless confirmed that the implementation i would use is what you want.

thorny obsidian Dec 3, 2021, 7:33 PM

#

fallen patrol I won't implement it unless confirmed that the implementation i would use is wha...

Yup. I replied to Zig's message with that saying it's fine. If the information that it's on a 30 minute timer is retained, I'm okay with a dynamic timestamp being added to indicate when it was last refreshed.

fallen patrol Dec 3, 2021, 7:35 PM

#

....er is there is a leaderboard I can test with

thorny obsidian Dec 3, 2021, 7:35 PM

#

The one you joined.

fallen patrol Dec 3, 2021, 7:35 PM

#

how do I set it up on lance 😅

thorny obsidian Dec 3, 2021, 7:37 PM

#

fallen patrol how do I set it up on lance 😅

.env file should contain this:
The structure of AOC_LEADERBOARDS is: leaderboard_code,session_cookie,lb_joincode

The leaderboard join code doesn't have to work for this since it's just DMed to a user. You just need to pull your session cookie and make sure the leaderboard ID is the same as the one you've joined.

cold island Dec 3, 2021, 7:38 PM

#

oh damn I forgot about today's puzzle

thorny obsidian Dec 3, 2021, 7:38 PM

#

cold island oh damn I forgot about today's puzzle

lol, good luck with pt 2~

cold island Dec 3, 2021, 7:38 PM

#

pain already on day 3?

thorny obsidian Dec 3, 2021, 7:41 PM

#

cold island pain already on day 3?

reading is hard Sunglaso

fallen patrol Dec 3, 2021, 7:46 PM

#

how's this? @thorny obsidian

thorny obsidian Dec 3, 2021, 7:47 PM

#

I'd prefer if it was just the timestamp because the date isn't really important. So <t:X:t> or <t:X:T>

fallen patrol Dec 3, 2021, 7:47 PM

#

oh shoot, I glossed over that

#

thorny obsidian Dec 3, 2021, 7:48 PM

#

Vote_Plus

fallen patrol Dec 3, 2021, 7:48 PM

#

as an aside, while here

#

I tried putting a language on the embed for a little bit of color

#

#

worth keeping or naw?

thorny obsidian Dec 3, 2021, 7:50 PM

#

People are going to immediately question why some people's names have color and others don't. I'd rather keep it simple

fallen patrol Dec 3, 2021, 7:50 PM

#

👍

#

sir-lancebot#969 @thorny obsidian 😄

dusky shoreBOT Dec 3, 2021, 7:57 PM

#

GitHub

PROpen nit: make last refreshed time above the rest of the embed

clever wraith Dec 3, 2021, 8:17 PM

#

vale ibex of course this is pseudo code, so please don't just copy-paste it verbatim and e...

What I have set up is more or less the same

#

It discards the subdomain and checks the tld and domain name

vale ibex Dec 3, 2021, 8:29 PM

#

Yea, the path check is the more important part

#

if there is a path present, we want it require an exact match

fallen patrol Dec 3, 2021, 8:29 PM

#

@vale ibex I forgot, was aoc subscribe gonna get killed or wait until the end of aoc this year?

vale ibex Dec 3, 2021, 8:29 PM

#

probably just wait, rather than pull the command out from under people during an event

fallen patrol Dec 3, 2021, 8:29 PM

#

cool

vale ibex Dec 3, 2021, 8:29 PM

#

lovefest can be removed though

fallen patrol Dec 3, 2021, 8:29 PM

#

can I make an issue, and mark it as deferred?

vale ibex Dec 3, 2021, 8:30 PM

#

👍

fallen patrol Dec 3, 2021, 8:30 PM

#

cool

#

sir-lancebot#970

dusky shoreBOT Dec 3, 2021, 8:35 PM

#

GitHub

IssueOpen yank role commands

fallen patrol Dec 3, 2021, 8:36 PM

#

hm

#

should the commands stay, and helpfully redirect users to use the Python command?

austere hornet Dec 3, 2021, 8:37 PM

#

dusky shore

Lmao what kind of an issue name is that

fallen patrol Dec 3, 2021, 8:37 PM

#

a good one

#

have you ever used vim?

austere hornet Dec 3, 2021, 8:38 PM

#

fallen patrol a good one

Yeah ik, not saying it's bad, I just like the word "yank"

austere hornet Dec 3, 2021, 8:38 PM

#

fallen patrol have you ever used vim?

No

fallen patrol Dec 3, 2021, 8:39 PM

#

vim is an editor, and in vim, you can yank a line of text, which will store the line in memory. You can then paste it again, which is what we're doing here. The command is yanked from lance, since we've pasted them on @stable mountain 😛

austere hornet Dec 3, 2021, 8:39 PM

#

fallen patrol vim is an editor, and in vim, you can yank a line of text, which will store the ...

Oh it's literally called "yanking"? Lmao

#

Ik what it is

#

I just never used vim

#

But yeah I get it

fallen patrol Dec 3, 2021, 8:47 PM

#

hmm, is there a standard for referencing the prefix of the other bot

#

lol @vale ibex I accidently removed my assignment 😔

#

as an implementation detail, I'm tempted to make a factory util for the embed, and just use it in both files

vale ibex Dec 3, 2021, 8:55 PM

#

Sounds fine

fallen patrol Dec 3, 2021, 8:56 PM

#

although with the delete after 20 seconds, not sure if that feature was ever ported from bot

vale ibex Dec 3, 2021, 8:58 PM

#

I was referring to the kwarg on Messageable.send

fallen patrol Dec 3, 2021, 8:58 PM

#

i seriously forgot that kwarg exists

vale ibex Dec 3, 2021, 8:59 PM

#

hah

fallen patrol Dec 3, 2021, 8:59 PM

#

but it would be neat to delete the main invoke as well, not sure

vale ibex Dec 3, 2021, 9:03 PM

#

Eh, it's fine if it doesn't

fallen patrol Dec 3, 2021, 9:06 PM

#

okay!

#

hmm, is there a standard for referencing the prefix of the other bot

#

Feel like the solution is to add a constant in constants.py lol

vale ibex Dec 3, 2021, 9:16 PM

#

I think for this, just hard code it to !

#

we're never going to change it for @stable mountain and there's no reasonable way to get it in dev

fallen patrol Dec 3, 2021, 9:17 PM

#

the reason i wonder is only because there is a pr (or issue) to remove prefixes from help messages

vale ibex Dec 3, 2021, 9:17 PM

#

yea, for commands within the bot

timid sentinel Dec 3, 2021, 9:17 PM

#

Make a bot-prefix-manager microservice /s

vale ibex Dec 3, 2021, 9:17 PM

#

since we have the prefix locally

#

but we don't for cross-bot help

fallen patrol Dec 3, 2021, 9:17 PM

#

vale ibex yea, for commands within the bot

right, so that's why I'd make it a constant so it would at least be changable with one line 😛

vale ibex Dec 3, 2021, 9:18 PM

#

Yea, a constant is fine, just no need for it to be in the config

#

config files are already filled with stuff that don't need to be configurable

fallen patrol Dec 3, 2021, 9:28 PM

#

#

i half want to implement a redis cache to be able to have a stat of how many people have used commands that are deprecated 😆

#

feature creep

#

not bad

#

vale ibex Dec 3, 2021, 9:41 PM

#

I'd say just remove the sub commands

#

and make .lovefest to lovefest(self, ctx, *_)

fallen patrol Dec 3, 2021, 10:02 PM

#

vale ibex I'd say just remove the sub commands

lol saw this after pushing, sir-lancebot#971

dusky shoreBOT Dec 3, 2021, 10:02 PM

#

GitHub

PROpen yank lovefest command

fallen patrol Dec 3, 2021, 10:05 PM

#

vale ibex I'd say just remove the sub commands

given the previous conversation I just had with kutiekat, I figured that saying it several times in the help message was worth it, as we were discussing that people don't read the entire embed

vale ibex Dec 3, 2021, 10:08 PM

#

Surely having less in the embed means they would be more likely to read it

#

and removing the repetition, since it just looks wrong

fallen patrol Dec 3, 2021, 10:12 PM

#

👍

fallen patrol Dec 3, 2021, 10:13 PM

#

vale ibex Surely having less in the embed means they would be more likely to read it

I'll change it for lovefest, but aoc is the same way, but with more commands, its more hidden

#

vale ibex Dec 3, 2021, 10:14 PM

#

Yea, for aoc that's fine, since there's more there

#

It's just there's no point in having a group if it's sub commands both do the same thing

fallen patrol Dec 3, 2021, 10:19 PM

#

so this?

fallen patrol Dec 3, 2021, 10:49 PM

#

sir-lancebot#970
sir-lancebot#971
sir-lancebot#972

dusky shoreBOT Dec 3, 2021, 10:49 PM

#

GitHub

PRDraft Yank aoc subscribe
PROpen yank lovefest command
IssueOpen yank role commands

gritty wind Dec 4, 2021, 12:22 AM

#

Why are they all different PRs lol

brisk brook Dec 4, 2021, 12:22 AM

#

So.. there's one draft, one open and one issue?

vocal prairie Dec 4, 2021, 12:23 AM

#

the first is there so that it can be merged after aoc ends, the second is ig because there's no reason to delay it, and the issue because well, issues before prs

fallen patrol Dec 4, 2021, 12:25 AM

#

gritty wind Why are they all different PRs lol

issue explains what is happening, and what we're doing
second issue is a pr which implements the function, and deprecates lovefest
third issue is a pr and a draft since chris didn't want to deprecate aoc commands during aoc

#

additionally, lance uses a set to de-dupe listed issues right now, which isn't great, so they are in a different order than i provided

#

once sir-lancebot#778 gets merged, I have sir-lancebot#968 already approved to start work on github and issue linking enhancements

dusky shoreBOT Dec 4, 2021, 12:27 AM

#

GitHub

IssueOpen github command enhancements
PROpen Merge automatic issue linking into the github cog

patent pivot Dec 4, 2021, 12:27 AM

#

is AOC ready for review?

#

undraft it if so, I’ll add the merge block label

fallen patrol Dec 4, 2021, 12:27 AM

#

👍 aight, will do

#

undrafted

patent pivot Dec 4, 2021, 12:29 AM

#

when we’re ready, lol, probably once we solidify things at the staff meeting. it’ll come in due course.

fallen patrol Dec 4, 2021, 12:29 AM

#

oh wait

patent pivot Dec 4, 2021, 12:30 AM

#

sunday

fallen patrol Dec 4, 2021, 12:30 AM

#

@vocal wolf sir-lancebot#778 needs your approval after a disapproval

dusky shoreBOT Dec 4, 2021, 12:30 AM

#

GitHub

PROpen Merge automatic issue linking into the github cog

patent pivot Dec 4, 2021, 12:30 AM

#

not sure who will be there though, so might push to next week? but it’ll be soon, just continue holding further work on api

fallen patrol Dec 4, 2021, 12:30 AM

#

~~as a reminder~~ #dev-contrib message

fallen patrol Dec 4, 2021, 12:31 AM

#

patent pivot when we’re ready, lol, probably once we solidify things at the staff meeting. it...

is the tldr that site will always feature the api?

patent pivot Dec 4, 2021, 12:31 AM

#

no

#

the tldr is we aren’t pursuing the api rewrite

austere hornet Dec 4, 2021, 12:31 AM

#

fallen patrol issue explains what is happening, and what we're doing second issue is a pr whic...

I'm sure you know this, but an issue is not the same thing as a PR 😄

#

Just saying

fallen patrol Dec 4, 2021, 12:32 AM

#

actually, all prs are issues 😛

austere hornet Dec 4, 2021, 12:32 AM

#

Oh really?

#

Ok, good to know, mb

fallen patrol Dec 4, 2021, 12:32 AM

#

Note: GitHub's REST API v3 considers every pull request an issue, but not every issue is a pull request. For this reason, "Issues" endpoints may return both issues and pull requests in the response. You can identify pull requests by the pull_request key. Be aware that the id of a pull request returned from "Issues" endpoints will be an issue id. To find out the pull request id, use the "List pull requests" endpoint.

patent pivot Dec 4, 2021, 12:32 AM

#

api will likely always be django

austere hornet Dec 4, 2021, 12:32 AM

#

fallen patrol > Note: GitHub's REST API v3 considers every pull request an issue, but not ever...

Ah gotcha

patent pivot Dec 4, 2021, 12:33 AM

#

site… might move out at some point? who knows, probably not for now, for now site will stay as is and will be DRF and templates

fallen patrol Dec 4, 2021, 12:33 AM

#

austere hornet Ah gotcha

yeah, I've done an enhancement to the github command that will only make one request, as knowing this means we don't need to make two requests ducky_party

austere hornet Dec 4, 2021, 12:34 AM

#

fallen patrol yeah, I've done an enhancement to the github command that will only make one req...

Ah I see

fallen patrol Dec 4, 2021, 12:34 AM

#

dusky shore

you can actually view these two issues for more info 😄

#

see my review on the pull, which should be summarized on the issue

austere hornet Dec 4, 2021, 12:35 AM

#

Gotcha, will do, maybe tmmrw

austere hornet Dec 4, 2021, 12:35 AM

#

dusky shore

!remind 15H read this

stable mountainBOT Dec 4, 2021, 12:35 AM

#

I got you.

Your reminder will arrive on <t:1638632142:F>!

fallen patrol Dec 4, 2021, 12:51 AM

#

@gritty wind have you heard of yarl?

#

!pypi yarl

stable mountainBOT Dec 4, 2021, 12:51 AM

#

yarl v1.7.2

Yet another URL library

fallen patrol Dec 4, 2021, 12:52 AM

#

its a dependency of aiohttp

#

so it should be safe to use in bot

gritty wind Dec 4, 2021, 12:52 AM

#

Sure, what for?

fallen patrol Dec 4, 2021, 12:52 AM

#

specifically, it can parse urls, and remove the protocols for you

gritty wind Dec 4, 2021, 12:52 AM

#

I mean, maybe, but it's a pretty easy thing to do by hand

fallen patrol Dec 4, 2021, 12:52 AM

#

why did i mention this, I should just leave a comment

#

;-;

gritty wind Dec 4, 2021, 12:52 AM

#

It's one line lol

fallen patrol Dec 4, 2021, 12:53 AM

#

since urllib.parse also exists 😛

#

but also: the last / can have some significance and imo should not be stripped if possible

gritty wind Dec 4, 2021, 12:53 AM

#

Could you clarify what situation you think that'll be relevant in

fallen patrol Dec 4, 2021, 12:54 AM

#

well, this is unfurling redirects, so if someone knows that, they can make it do a different thing if there is a last slash vs not

gritty wind Dec 4, 2021, 12:54 AM

#

It isn't, it's unrelated

#

I kaizened in the change, as outlined in the PR body

#

This is for the filter content itself

#

The way the URL search currently works is we run a regex on the message body to extract URLs (this does not modify them), then run filter in extracted_urls

#

Having protocol and trailing slashes means we end up with filters that are duplicated sometimes

fallen patrol Dec 4, 2021, 12:55 AM

#

ahhhh, okay

gritty wind Dec 4, 2021, 12:55 AM

#

Also discord forces trailing slashes on urls

fallen patrol Dec 4, 2021, 12:56 AM

#

!d urllib.parse.urlparse exists tho 😛

stable mountainBOT Dec 4, 2021, 12:56 AM

#

urllib.parse.urlparse


urllib.parse.urlparse(urlstring, scheme='', allow_fragments=True)```
Parse a URL into six components, returning a 6-item [named tuple](https://docs.python.org/3/glossary.html#term-named-tuple). This corresponds to the general structure of a URL: `scheme://netloc/path;parameters?query#fragment`. Each tuple item is a string, possibly empty. The components are not broken up into smaller parts (for example, the network location is a single string), and % escapes are not expanded. The delimiters as shown above are not part of the result, except for a leading slash in the *path* component, which is retained if present. For example:

fallen patrol Dec 4, 2021, 12:56 AM

#

and actually, that might be worth using

gritty wind Dec 4, 2021, 12:56 AM

#

No, it's not

#

Look at:

fallen patrol Dec 4, 2021, 12:57 AM

#

because of the docs for unparse, the suggested way to get a standardised rfc compliant url is to parse and unparse

gritty wind Dec 4, 2021, 12:57 AM

#

parse.urlparse("content.com")
# vs
parse.urlparse("https://content.com")

#

It's a pain in the ass to work with for situations like this, and I'm not sure what problem we're trying to solve here

fallen patrol Dec 4, 2021, 12:57 AM

#

!e ```py
from urllib import parse
print(parse.urlparse("content.com"))

vs

print(parse.urlparse("https://content.com"))

stable mountainBOT Dec 4, 2021, 12:57 AM

#

@fallen patrol :white_check_mark: Your eval job has completed with return code 0.

001 | ParseResult(scheme='', netloc='', path='content.com', params='', query='', fragment='')
002 | ParseResult(scheme='https', netloc='content.com', path='', params='', query='', fragment='')

gritty wind Dec 4, 2021, 12:57 AM

#

have fun parsing that

fallen patrol Dec 4, 2021, 12:59 AM

#

gritty wind Having protocol and trailing slashes means we end up with filters that are dupli...

this is why I would use it and then reparse:

Construct a URL from a tuple as returned by urlparse(). The parts argument can be any six-item iterable. This may result in a slightly different, but equivalent URL, if the URL that was parsed originally had unnecessary delimiters (for example, a ? with an empty query; the RFC states that these are equivalent).

gritty wind Dec 4, 2021, 12:59 AM

#

Arl, what problem are you trying to solve here

fallen patrol Dec 4, 2021, 12:59 AM

#

its a small thing, but if its not worth it, its not worth it ¯_(ツ)_/¯

fallen patrol Dec 4, 2021, 12:59 AM

#

gritty wind Arl, what problem are you trying to solve here

true

#

lol testing it and pydis has a lot of redirects

gritty wind Dec 4, 2021, 1:09 AM

#

it probably goes to pythondiscord.com followed by www.pythondiscord.com

fallen patrol Dec 4, 2021, 1:10 AM

#

yep

#

what i don't understand is how this is only 2 redirects

#

I would think there's 3...

#

left review

gritty wind Dec 4, 2021, 1:13 AM

#

pydis.com/coc -> https://pythondiscord.com/pages/code-of-conduct/ -> https://www.pythondiscord.com/pages/code-of-conduct/

Count arrows

fallen patrol Dec 4, 2021, 1:13 AM

#

ohhh, right, that makes more sense

brisk brook Dec 4, 2021, 1:21 AM

#

Yeah, you get 2 redirect responses

#

The last one yields a 200 Ok

short snow Dec 4, 2021, 1:22 AM

#

why do we need sir-lancebot#969 the footer already shows when it was last updated

dusky shoreBOT Dec 4, 2021, 1:22 AM

#

GitHub

PROpen nit: make last refreshed time above the rest of the embed

fallen patrol Dec 4, 2021, 1:23 AM

#

F I didn't link the discussion

#

@short snow edited it on the issue, also here #dev-contrib message

#

additionally, the reasoning is in issue 967, https://github.com/python-discord/sir-lancebot/issues/967#issuecomment-985756194

GitHub

aoc leaderboard: use a discord formatted timestamp for when the lb ...

Additionally, we would be able to use discord timestamps, to show a helpful message in the lb command of how long until the lb can be refreshed again. This may be worth a second and different issue...

short snow Dec 4, 2021, 1:25 AM

#

ok yeah true

#

we don't have the discord time feature utils on lance?

fallen patrol Dec 4, 2021, 1:26 AM

#

not yet, no

short snow Dec 4, 2021, 1:26 AM

#

probably worth adding

fallen patrol Dec 4, 2021, 1:26 AM

#

I could make a pr to migrate just those to the bot

#

but felt out of scope of that pr

short snow Dec 4, 2021, 1:26 AM

#

just add it your PR IMO

#

it is out scope, yeah but not really a problem ig

fallen patrol Dec 4, 2021, 1:27 AM

#

although bot#1721 exists which is refactoring the time utils so felt like holding off, and we can standardize more of the times at once

dusky shoreBOT Dec 4, 2021, 1:27 AM

#

GitHub

PROpen Refactor time utilities

short snow Dec 4, 2021, 1:27 AM

#

don't think that's going to be merging anytime soon, so not worth waiting for it

fallen patrol Dec 4, 2021, 1:27 AM

#

additionally, botcore will hopefully be ready sooner, so migrating stuff from bot isn't good unless used in more places

patent pivot Dec 4, 2021, 1:29 AM

#

botcore still has a decent way to go, shouldn't be blocking any decisions right now

fallen patrol Dec 4, 2021, 1:29 AM

#

don't get me wrong, I'll implement it if someone says to, but that's why I did it manually rather than migrate a util

patent pivot Dec 4, 2021, 1:29 AM

#

we'll let people know once that's the case

fallen patrol Dec 4, 2021, 1:29 AM

#

if you want me to migrate the util, I can easily do that

short snow Dec 4, 2021, 1:29 AM

#

yeah i understand that 👍

thorny obsidian Dec 4, 2021, 1:29 AM

#

@short snow I don't want the action of setting the name to come before we log it. If something goes wrong we'll have no log of what invoked it.

Also I'm sure if not duplicating one line of code is worth it. I think the code is readable and follows a logic that makes sense. In general, I'd rather suggestions to PRs have some sort of benefit or purpose.

short snow Dec 4, 2021, 1:31 AM

#

Sure 👍

fallen patrol Dec 4, 2021, 1:34 AM

#

thorny obsidian <@736234578745884682> I don't want the action of setting the name to come before...

what comment?

thorny obsidian Dec 4, 2021, 1:41 AM

#

I've already changed the tense, I just haven't pushed those changes to github.

#

I got earlier feedback on it.

vocal wolf Dec 4, 2021, 1:43 AM

#

dusky shore

I'll look into the code soon, all my dev stuff is on linux (am on windows)

fallen patrol Dec 4, 2021, 1:43 AM

#

neat, I'm excited for the merger

fallen patrol Dec 4, 2021, 3:01 AM

#

lol what happened? #dev-log message

#

(the md formatting)

magic arch Dec 4, 2021, 3:05 AM

#

one of the `s got cut off from the first commit with the ... and then combined with the rest

fallen patrol Dec 4, 2021, 3:21 AM

#

ahhhh

fallen patrol Dec 4, 2021, 3:47 AM

#

vocal wolf I'll look into the code soon, all my dev stuff is on linux (am on windows)

🥺

green oriole Dec 4, 2021, 5:54 AM

#

#dev-log message

#

F for markdown

stable mountainBOT Dec 4, 2021, 11:10 AM

#

It has arrived!

Here's your reminder: 8H this
[Jump back to when you created the reminder](#dev-contrib message)

small shoal Dec 4, 2021, 2:31 PM

#

I found something wrong with Python 3.10's Error message
Can I post it here??

austere hornet Dec 4, 2021, 2:32 PM

#

small shoal I found something wrong with `Python 3.10`'s `Error message` Can I post it here?...

By Python 3.10 you mean the bot?

#

Wait there is no bot like that nvm

#

There used to tho

small shoal Dec 4, 2021, 2:33 PM

#

austere hornet By Python 3.10 you mean the bot?

No, the language

vocal prairie Dec 4, 2021, 2:33 PM

#

This channel is discussion for Python Discord's project, not the language itself. Any bug reports should go to https://bugs.python.org, or if you're not sure if it's a python bug specifically, feel free to ask in #python-discussion or #internals-and-peps.

magic arch Dec 4, 2021, 2:33 PM

#

Feel free to ask about it in #python-discussion or a help channel and we might be able to explain what's happening too.

small shoal Dec 4, 2021, 2:34 PM

#

ok thanks for letting me know

stable mountainBOT Dec 4, 2021, 3:35 PM

#

austere hornet !remind 15H read this

It has arrived!

Here's your reminder: read this
[Jump back to when you created the reminder](#dev-contrib message)

thorny obsidian Dec 4, 2021, 3:39 PM

#

@vale ibex so I do agree that the error message for not being on the leaderboard should be a bit nicer. Mentioning both "run .aoc join and that the leaderboard takes 30 minutes to refresh" but I don't actually know where that error starts/propagates from.

There are a few helper functions for pulling the leaderboard and I didn't dive into troubleshooting where it actually starts.

vale ibex Dec 4, 2021, 3:42 PM

#

_helpers.py line 218

austere hornet Dec 4, 2021, 3:43 PM

#

stable mountain

!remind 5H this

stable mountainBOT Dec 4, 2021, 3:43 PM

#

Sure.

Your reminder will arrive on <t:1638650597:F>!

austere hornet Dec 4, 2021, 3:43 PM

#

stable mountain

!remind 5H this

stable mountainBOT Dec 4, 2021, 3:43 PM

#

Yeah okay.

Your reminder will arrive on <t:1638650612:F>!

thorny obsidian Dec 4, 2021, 4:04 PM

#

@vale ibex Adjusted error embed to add some more info and I incorporated your other suggested names. Should be good to go~

vale ibex Dec 4, 2021, 4:06 PM

#

noice 😄

thorny obsidian Dec 4, 2021, 4:07 PM

#

One thing I'm not quite happy about but what take some more time to think about it, is if someone recently joins the leaderboard, links their account, and then tries to call the leaderboard with no argument. It'll error on them until the leaderboard refreshes so there's no way for them to pull the leaderboard without specifying someone else's name

vale ibex Dec 4, 2021, 4:08 PM

#

Hmmmm, yea

#

An easy fix would be to just not error if no arg was given, and we're inferring name from link

#

but that's still not ideal

#

the best fix would be to not error for accounts linked since the last refresh, but would require storing when accs were linked

#

we could just use a volatile list for it actually

#

and just live with the fact that if lance reboots it might happen

thorny obsidian Dec 4, 2021, 4:10 PM

#

Hmmmm, I think for the announcement I'd like to make today I can say "once the leaderboard refreshes and you've verified you're on it, then link your account" to avoid this not-quite-so-edge edge case

vale ibex Dec 4, 2021, 4:10 PM

#

I'm gonna look at adding <@&916691790181056532> role to people when they complete the stars

#

could look at that the same time

#

We landed on the idea of giving it to people who have completed all the stars so far with a 12hr grace before we remove roles for people to have a chance

#

and then leave it running until Feb or so

thorny obsidian Dec 4, 2021, 4:13 PM

#

I'm fine with that, sounds like fun motivation finish regardless of leaderboard placement

fallen patrol Dec 4, 2021, 4:13 PM

#

vale ibex We landed on the idea of giving it to people who have completed all the stars *s...

should be 24h grace, unless you mean 12h from when the next day starts

thorny obsidian Dec 4, 2021, 4:13 PM

#

vale ibex I'm gonna look at adding <@&916691790181056532> role to people when they complet...

Do you want me to hold off on the announcement until this feature is ready?

vale ibex Dec 4, 2021, 4:13 PM

#

nah, go for the announcement, I don't think I'll have a chance today to do it

thorny obsidian Dec 4, 2021, 4:13 PM

#

okay cool cool

vale ibex Dec 4, 2021, 4:14 PM

#

fallen patrol should be 24h grace, unless you mean 12h from when the next day starts

Nah, 12h from when the new stars are available if you don't have them we remove the role

#

and when you complete, we'll add

#

just to show people who have completed the stars for today

fallen patrol Dec 4, 2021, 4:14 PM

#

sir-lancebot#969 🥺 nother lb buff

dusky shoreBOT Dec 4, 2021, 4:14 PM

#

GitHub

PROpen nit: make last refreshed time above the rest of the embed

vale ibex Dec 4, 2021, 4:26 PM

#

Seems fine from just looking at it, can test it later/tomorrow

#

working on a metricity issue while I have time today

fallen patrol Dec 4, 2021, 4:41 PM

#

👍

violet terrace Dec 4, 2021, 6:36 PM

#

does the new .aoc link command filter out @s?

fallen patrol Dec 4, 2021, 6:36 PM

#

it shouldn't, no

#

why, what's the issue?

violet terrace Dec 4, 2021, 6:36 PM

#

.aoc link @fallen patrol

dusky shoreBOT Dec 4, 2021, 6:36 PM

#

:x: Please use #aoc-bot-commands for aoc commands instead.

violet terrace Dec 4, 2021, 6:37 PM

#

@fallen patrol doesnt that let the bot ping everyone?

fallen patrol Dec 4, 2021, 6:37 PM

#

<@&267628507062992896> ^

static canyon Dec 4, 2021, 6:37 PM

#

violet terrace <@!717983911824588862> doesnt that let the bot ping everyone?

Probably not

#

allowed_mentions is a thing

patent pivot Dec 4, 2021, 6:37 PM

#

we use allowed mentions

#

yeah

#

defaults to nothing, has to explicitly say if it wants to ping people

violet terrace Dec 4, 2021, 6:38 PM

#

👍

fallen patrol Dec 4, 2021, 6:38 PM

#

patent pivot defaults to nothing, has to explicitly say if it wants to ping people

that's not true

patent pivot Dec 4, 2021, 6:38 PM

#

yes it is

fallen patrol Dec 4, 2021, 6:38 PM

#

no, i have evidence it isn;t

patent pivot Dec 4, 2021, 6:39 PM

#

not a discord default, but we certainly set it on the discord.py client

fallen patrol Dec 4, 2021, 6:39 PM

#

patent pivot Dec 4, 2021, 6:39 PM

#

we might allow user pings, definitely not roles or everyone/here

static canyon Dec 4, 2021, 6:40 PM

#

I just tested and it doesn't work so it's fine @fallen patrol

patent pivot Dec 4, 2021, 6:40 PM

#

fallen patrol Dec 4, 2021, 6:40 PM

#

@patent pivot can you open dms?

patent pivot Dec 4, 2021, 6:41 PM

#

allowed roles is any mod role

#

trust me, this is not a thing lol

fallen patrol Dec 4, 2021, 6:42 PM

#

fallen patrol

well, could I submit a pr to make it not allowed to mention any users, preventing this, at least (with a lot less urgency, ofc)?

#

or switch that output to an embed

patent pivot Dec 4, 2021, 6:42 PM

#

it’s by design, users is a significantly smaller vector than roles/everyone and we already filter on mass pinging which you’d need in the first place

fallen patrol Dec 4, 2021, 6:43 PM

#

I remember previous concerns of members abusing commands that mention other users when they had been blocked, or to annoy other members

patent pivot Dec 4, 2021, 6:43 PM

#

we do not want to default to users off

fallen patrol Dec 4, 2021, 6:43 PM

#

I mean for that specific response, lol

#

not the whole bot

patent pivot Dec 4, 2021, 6:43 PM

#

fallen patrol I remember previous concerns of members abusing commands that mention other user...

yes, but while there is a code solution for that there is also a ban hammer

fallen patrol Dec 4, 2021, 6:44 PM

#

true lol

#

@magic arch should the additional quote parsing be removed from the leaderboard command?

#

the link command doesn't have that additional quote parsing, so there's now a slight difference between the two commands

thorny obsidian Dec 4, 2021, 6:48 PM

#

fallen patrol <@!466677474672246795> should the additional quote parsing be removed from the l...

No. Because people are used to having to use quotes for the leaderboard command and I'd like to keep it for the remainder of this year

fallen patrol Dec 4, 2021, 6:48 PM

#

well, the quote command is different so its a bit odd, imo

thorny obsidian Dec 4, 2021, 6:48 PM

#

It's only going to mis-match for 1 year.

#

It's fine.

fallen patrol Dec 4, 2021, 6:48 PM

#

oki

magic arch Dec 4, 2021, 6:49 PM

#

people can deal with it, not a huge deal like kat said 😂

fallen patrol Dec 4, 2021, 6:51 PM

#

👍

stable mountainBOT Dec 4, 2021, 8:43 PM

#

austere hornet !remind 5H this

It has arrived!

Here's your reminder: this
[Jump back to when you created the reminder](#dev-contrib message)

stable mountainBOT Dec 4, 2021, 8:43 PM

#

austere hornet !remind 5H this

It has arrived!

Here's your reminder: this
[Jump back to when you created the reminder](#dev-contrib message)

austere hornet Dec 4, 2021, 8:50 PM

#

stable mountain

!remind 1D I hope I'll actually get to this at some point

stable mountainBOT Dec 4, 2021, 8:50 PM

#

Sure.

Your reminder will arrive on <t:1638737442:F>!

austere hornet Dec 5, 2021, 12:33 AM

#

Hey would anyone want to work with me on sir-lancebot#937 + sir-lancebot#956? Feel free to DM me if interested, thanks!

dusky shoreBOT Dec 5, 2021, 12:33 AM

#

GitHub

IssueOpen New ".christmasify" command
PRDraft .christmasify Command

austere hornet Dec 5, 2021, 12:35 AM

#

Preferably someone who is good with Pillow

trim cradle Dec 5, 2021, 3:00 AM

#

So the result of !user says "too many to count" if someone has a lot of activity blocks. But I want it to say "all of them"

fallen patrol Dec 5, 2021, 3:15 AM

#

trim cradle So the result of `!user` says "too many to count" if someone has a lot of activi...

I could make a pull to change that

trim cradle Dec 5, 2021, 3:16 AM

#

fallen patrol I could make a pull to change that

I think we'd both get in trouble

fallen patrol Dec 5, 2021, 3:16 AM

#

oh lol i thought you were asking someone to do it 😂

trim cradle Dec 5, 2021, 3:30 AM

#

fallen patrol oh lol i thought you were asking someone to do it 😂

I'm not calling the shots here. I'm just saying how I want things to be.

fallen patrol Dec 5, 2021, 4:04 AM

#

hmmmm

fallen patrol Dec 5, 2021, 6:49 AM

#

this intentional?

thorny obsidian Dec 5, 2021, 6:55 AM

#

Only the person who called the command can interact with it, that's an intentional decision

fallen patrol Dec 5, 2021, 6:56 AM

#

so there's no error like the subscribe command?

#

#

like, was letting the interactions fail intentional?

#

rather than showing an ephermal error to the user

gritty wind Dec 5, 2021, 7:57 AM

#

Probably just less work

#

This seems like a good utility, or if it raises an error, a global error handler

molten perch Dec 5, 2021, 9:49 AM

#

fallen patrol like, was letting the interactions fail intentional?

Yes, exactly. Only the interaction fails, so the person who issued command will still be able to interact with the view itself.
As for the error message, it could have been added, I admit. But the person who's trying to interact with a view origined from another user, gets this (small) error message anyways.

cold moon Dec 5, 2021, 9:49 AM

#

I think it should be implemented as exception and handle it in error handler

fervent sage Dec 5, 2021, 9:50 AM

#

molten perch Yes, exactly. Only the interaction fails, so the person who issued command will ...

the difference is that "This interaction failed" makes it look like the bot is broken

cold moon Dec 5, 2021, 9:51 AM

#

This interaction failed doesn’t give enough information to user.

molten perch Dec 5, 2021, 9:53 AM

#

I agree. I admit I should've added it.
Although, I don't think we should go above sending an ephemeral response.

molten perch Dec 5, 2021, 10:28 AM

#

I addressed the problem in sir-lancebot#973

dusky shoreBOT Dec 5, 2021, 10:28 AM

#

GitHub

PROpen Make error messages more consistent in the AoC daystar view

rugged zephyr Dec 5, 2021, 10:38 AM

#

hi

short snow Dec 5, 2021, 11:50 AM

#

1 suggestion) 2048 game on @dusky shore :D

#

suggestion 2) and updating the tic tac toe to use discord buttons (3*3)

#

suggestion 3) Enhancing tags to command to add button syntax mapping to links, for eg:

:button <link> text

vale ibex Dec 5, 2021, 11:53 AM

#

That 2048 game seems like it generates the images of the board, if so would be fine as long it's not too resource intensive. tic tac toe, with buttons sounds good 👍

short snow Dec 5, 2021, 11:53 AM

#

Ok that's it, thought of putting them here before opening issues

vale ibex Dec 5, 2021, 11:54 AM

#

Adding more meta data to tags has a PR open iirc, while it doesn't do exactly that, it does add some of the things that you may need

short snow Dec 5, 2021, 11:55 AM

#

short snow suggestion 3) Enhancing tags to command to add button syntax mapping to links, f...

#bot-commands message like here the computerfile video could go into a button, many tags reference a link so it might be good

#

should i open issues for them?

vale ibex Dec 5, 2021, 11:55 AM

#

Yup, sounds good 👍

#

out of the 3, I think the tac tac toe one may already have an issue

#

so just have a search first

short snow Dec 5, 2021, 11:57 AM

#

okay 👍

green oriole Dec 5, 2021, 12:05 PM

#

Can we guarantee it looks correctly on every platform?

idle delta Dec 5, 2021, 1:07 PM

#

Hey. I want to contribute an event to the AOC in Sir Lance Bot. What should I do?

green oriole Dec 5, 2021, 1:10 PM

#

I'm not sure if we have any aoc feature avaiting development (CC @thorny obsidian)

vale ibex Dec 5, 2021, 1:15 PM

#

idle delta Hey. I want to contribute an event to the AOC in Sir Lance Bot. What should I do...

Did you have something in mind, or were you looking to generally help out?

idle delta Dec 5, 2021, 1:16 PM

#

I had something in mind...

vale ibex Dec 5, 2021, 1:18 PM

#

which was....

idle delta Dec 5, 2021, 1:19 PM

#

I just want to make it such that #advent-of-code-spoilers-archive is locked when the puzzle starts and unlocked when the global leaderboard is full.

vale ibex Dec 5, 2021, 1:20 PM

#

Yea that sounds reasonable, are you familiar with the sir lancebot project, or discord bots in general?

idle delta Dec 5, 2021, 1:20 PM

#

I am familiar with discord bots.

#

I have made 1 with python.

vale ibex Dec 5, 2021, 1:21 PM

#

Ah alright cool. All of the AoC related code is in this directory https://github.com/python-discord/sir-lancebot/tree/main/bot/exts/events/advent_of_code

idle delta Dec 5, 2021, 1:22 PM

#

So where should I put this code, because it will work 24/7.. I guess.

vale ibex Dec 5, 2021, 1:22 PM

#

it would probably make the most sense to hook into the task we currently has which notifies when a new puzzle is available, that's here https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/events/advent_of_code/_helpers.py#L566

stable mountainBOT Dec 5, 2021, 1:22 PM

#

bot/exts/events/advent_of_code/_helpers.py line 566

async def new_puzzle_notification(bot: Bot) -> None:```

vale ibex Dec 5, 2021, 1:23 PM

#

idle delta So where should I put this code, because it will work 24/7.. I guess.

The usual process is to fork the repo, work on a branch of that fork with the code changes, and then PR it to the main repo. After a review, and any fixes that are required, it will be merged into the main code, and @dusky shore will be redeployed with those changes automatically

idle delta Dec 5, 2021, 1:24 PM

#

Okay, Thanks. :)

vale ibex Dec 5, 2021, 1:25 PM

#

There's a setup guide here for sir-lancebot https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/sir-lancebot/

Python Discord - Contributing to Sir Lancebot

A guide to setting up and configuring Sir Lancebot.

idle delta Dec 5, 2021, 1:31 PM

#

vale ibex it would probably make the most sense to hook into the task we currently has whi...

By the way, for which all roles should I lock it?

#

Ideally..

gritty wind Dec 5, 2021, 1:33 PM

#

Can probably do it on the everyone role

idle delta Dec 5, 2021, 1:36 PM

#

And the global leaderboard data?
(😅 Contributing to sir-lance bot for the first time, so I don't know which variable stores that..)

vale ibex Dec 5, 2021, 1:41 PM

#

That's in a redis cache in _caches.py

#

The fetch_leaderboard funciton in _helpers.py parses the cache and returns it

idle delta Dec 5, 2021, 1:43 PM

#

So when it's value == 100: the global leaderboard is full and the channel is supposed to be unlocked.

vale ibex Dec 5, 2021, 1:43 PM

#

Hmmm, I'm not actually sure if we have the global leaderboard cached or not

#

Ah, no it seems like we don't

#

Honestly, it might be easier to do it based on a timer, rather than the global leaderboard itself

#

since that would reduce the load we put on the aoc website

idle delta Dec 5, 2021, 1:45 PM

#

Hmm, we can say for 30 minutes. Since, the global leaderboard is full till then.

vale ibex Dec 5, 2021, 1:45 PM

#

Yea

#

Something to keep in mind is that our bot isn't guaranteed to always be running, since if new code it pushed, it will be redeployed with those changes

#

Since you'll be waiting for 20 minutes, and then unlocking the channel, there's a chance that during those 30 minutes the bot restarts, and that task it lost

#

So, I'd suggest that on startup of the cog, we check if the channel is locked, if so, we check if it should be locked, based on the time. If not, then unlock it

#

This is on top of the 30 minute timer to unlock too

idle delta Dec 5, 2021, 1:52 PM

#

So, what I have to do is
When notification is sent, lock the channel, then asyncio.sleep for 30 minutes. Then unlock it.

After that, in the startup of cog, we'll check if the channel is unlocked. If it is locked, then we w'll check if the time is 30 minutes after midnight EST. If it is, then unlock the channel. If it ain't.. maybe asyncio.sleep for that much time..

vale ibex Dec 5, 2021, 1:54 PM

#

yup, that sounds good

#

The first part being the main feature, the second being a safety check to protect against restarts

idle delta Dec 5, 2021, 1:56 PM

#

Yes. Now I need to figure out where to put it..

vale ibex Dec 5, 2021, 2:00 PM

#

The __init__() of the cog in _cog.py is where the reminder task is created

#

that would make for a sensible place for the safety check

austere hornet Dec 5, 2021, 2:03 PM

#

short snow suggestion 2) and updating the tic tac toe to use discord buttons (3*3)

I was actually planning to open an issue about that once my 2 current PR's are merged

austere hornet Dec 5, 2021, 2:06 PM

#

short snow 1 suggestion) 2048 game on <@!528937022996611082> :D

This is a good idea too, maybe we can both work on this together once my 2 current PR's are merged

austere hornet Dec 5, 2021, 2:07 PM

#

austere hornet I was actually planning to open an issue about that once my 2 current PR's are m...

We could work together on this one too if you want

austere hornet Dec 5, 2021, 2:13 PM

#

austere hornet Hey would anyone want to work with me on sir-lancebot#937 + sir-lancebot#956? Fe...

Also bump

thorny obsidian Dec 5, 2021, 2:21 PM

#

@vale ibex We can't automate the locking of that because it would request the global leaderboard too frequently. It's something I specifically didn't do.

vale ibex Dec 5, 2021, 2:23 PM

#

Yea, which is why I just suggested doing it on time a little further down

thorny obsidian Dec 5, 2021, 2:23 PM

#

I don't want to do that either.

vale ibex Dec 5, 2021, 2:23 PM

#

So we just lock the channel for 30 minutes after the puzzles are available

thorny obsidian Dec 5, 2021, 2:24 PM

#

If global takes 10 minutes to fill, for 20 minutes that channel is locked for no reason with a lot of good discussion not able to happen

#

As it stands there are maybe 10 people in this server who are fast enough to get on global and they're aware to not share spoilers until it's filled

#

It was a very concious decision to not automate the locking of that channel.

vale ibex Dec 5, 2021, 2:25 PM

#

So is the whole idea of locking the channel while the leaderboard fills up not worth it at all?

#

but rather, just have it be policy not to discuss current stars while the global board isn't full

thorny obsidian Dec 5, 2021, 2:26 PM

#

vale ibex but rather, just have it be policy not to discuss current stars while the global...

That's always been the policy, yeah.

vale ibex Dec 5, 2021, 2:26 PM

#

Ah alright, I think the channel topic is the only thing causing confusion here then

#

Since it implies it's completely locked out, rather than just being policy

thorny obsidian Dec 5, 2021, 2:27 PM

#

I was experimenting with the channel locking the year and decided it wasn't necessary. I haven't updated the faq or channel description yet though

vale ibex Dec 5, 2021, 2:27 PM

#

Alright cool, seems reasonable to drop it then

idle delta Dec 5, 2021, 2:36 PM

#

So... I'm going to modify somethin else then..

#

Any specific issues that I could look upon?

static canyon Dec 5, 2021, 2:48 PM

#

short snow 1 suggestion) 2048 game on <@!528937022996611082> :D

I've actually been working on a 2048 game myself this week so could you @ me in the issue? I might be able to look into adding to the bot

thorny obsidian Dec 5, 2021, 3:20 PM

#

idle delta Any specific issues that I could look upon?

If you want to work on something AoC related, I can write up an issue for something I've wanted to have~

short snow Dec 5, 2021, 3:26 PM

#

static canyon I've actually been working on a 2048 game myself this week so could you @ me in ...

sure

#

@austere hornet Will do, and I am not sure about working together as I won't be opening more PRs until I get the current ones in a merging state

austere hornet Dec 5, 2021, 3:27 PM

#

short snow <@!853309207922212965> Will do, and I am not sure about working together as I wo...

Alright, sounds good

thorny obsidian Dec 5, 2021, 3:49 PM

#

@idle delta So I was thinking of having a command .aoc mystats and that will show someone's times for day and star so far. It will also show their position on the leaderboard for that given day. Essentially this page, but customized for our leaderboard! https://adventofcode.com/2021/leaderboard/self

magic arch Dec 5, 2021, 6:21 PM

#

.aoc link should check if the input is formatted as a Discord mention and throw an error if it is

austere hornet Dec 5, 2021, 6:29 PM

#

Hmm, that sounds like a good idea

fallen patrol Dec 5, 2021, 6:29 PM

#

magic arch `.aoc link` should check if the input is formatted as a Discord mention and thro...

had the discussion yesterday, was deemed not necessary #dev-contrib message (starts there)

austere hornet Dec 5, 2021, 6:29 PM

#

Ah well there you go

magic arch Dec 5, 2021, 6:30 PM

#

I don't mean for the purpose of stopping pings, but for accidentally setting a Discord mention as their AoC name

#

I've seen multiple people do it already

thorny obsidian Dec 5, 2021, 6:32 PM

#

We could opt for more checking in the name provided for linking, although I wonder if that's an effort in futility, because people will always find new ways to misinterpret it and somehow link the wrong thing

magic arch Dec 5, 2021, 6:33 PM

#

That's another option, although it might annoy people if they need to wait 30 minutes for a leaderboard refresh before they can link

thorny obsidian Dec 5, 2021, 6:34 PM

#

Oh, I don't mean to check the leaderboard. I don't think I would ever want to verify it against the leaderboard without a fundamentally different approach to how we do this. I just mean also including checks for quotes and other common missteps

magic arch Dec 5, 2021, 6:34 PM

#

Ahh gotcha, yeah I agree

fallen patrol Dec 5, 2021, 8:29 PM

#

@vale ibex could I make a pr on python-discord/modmail to bring the development branch in par with kyb3r and add the ci workflow? 👀

#

~~nvm lol~~

patent pivot Dec 5, 2021, 8:40 PM

#

oops lol i thought there was a confirmation stage

#

development branch is still behind

#

hmmm yeah we should see if we can adopt any meaningful things from development into master

thorny obsidian Dec 5, 2021, 8:42 PM

#

Is the fetch bug something to fix upstream or something to patch first?

patent pivot Dec 5, 2021, 8:43 PM

#

what's the fetch bug

thorny obsidian Dec 5, 2021, 8:43 PM

#

I can't open a modmail thread because I'm not in modmail's cache.

patent pivot Dec 5, 2021, 8:44 PM

#

oh lol that's fuckin weird

fallen patrol Dec 5, 2021, 8:44 PM

#

👀

patent pivot Dec 5, 2021, 8:44 PM

#

hmm, we can fix it on our branch and then PR from python-discord to upstream

#

you can PR from an org fork

fallen patrol Dec 5, 2021, 8:44 PM

#

lol i just talked to chris about this

fallen patrol Dec 5, 2021, 8:45 PM

#

patent pivot hmmm yeah we should see if we can adopt any meaningful things from development i...

development got a recent bump to discord.py v2, and a few other nice buffs

thorny obsidian Dec 5, 2021, 8:45 PM

#

patent pivot hmm, we can fix it on our branch and then PR from python-discord to upstream

yeah, I suspect there may have been users who this bug also affected but probably didn't have enough stake/care enough to follow up on why there wasn't a response from modmail

fallen patrol Dec 5, 2021, 8:46 PM

#

I was about to try and troubleshoot, and write a pr for modmail, actually

#

although you'll need to apply the fix to the development branch, and backport it to stable if you wish, if you intend to send it upstream

#

given that the methods in question had some refactors in the development branch

vale ibex Dec 5, 2021, 8:47 PM

#

I'd patch it in our fork first and fix the issue

#

Then look a t committing upstream

fallen patrol Dec 5, 2021, 8:47 PM

#

yeah, makes sense

patent pivot Dec 5, 2021, 8:47 PM

#

lol whoops i opened a PR from python-discord to kyb3r

vale ibex Dec 5, 2021, 8:47 PM

#

When upstream merges, we can drop commit to avoid conflicts

fallen patrol Dec 5, 2021, 8:47 PM

#

#

very nice lmfao

patent pivot Dec 5, 2021, 8:48 PM

#

oh did I delete the dev branch on our repo lol

#

let me get it back

fallen patrol Dec 5, 2021, 8:48 PM

#

~~joe stop clicking things~~

patent pivot Dec 5, 2021, 8:48 PM

#

i'm good, nothing major fucked up yet

fallen patrol Dec 5, 2021, 8:48 PM

#

key word: yet

austere hornet Dec 5, 2021, 8:50 PM

#

lol

stable mountainBOT Dec 5, 2021, 8:50 PM

#

austere hornet !remind 1D I hope I'll actually get to this at some point

It has arrived!

Here's your reminder: I hope I'll actually get to this at some point
[Jump back to when you created the reminder](#dev-contrib message)

patent pivot Dec 5, 2021, 8:51 PM

#

okay the merge conflict is in bandit_baseline

#

never used bandit

fallen patrol Dec 5, 2021, 8:52 PM

#

same, i had it myself, and realised i didn't have it configured so it wasn't doing anything

fallen patrol Dec 5, 2021, 8:52 PM

#

patent pivot never used bandit

lie https://github.com/python-discord/site/blob/8ef403dace6783dd12a15d44fc43439cedd8ea6c/pyproject.toml#L30

stable mountainBOT Dec 5, 2021, 8:52 PM

#

pyproject.toml line 30

flake8-bandit = "~=2.1"```

fallen patrol Dec 5, 2021, 8:53 PM

#

(not that its doing anything there since I don't see configuration)

patent pivot Dec 5, 2021, 8:53 PM

#

never used bandit and generated a baseline, don't be pendantic.

fallen patrol Dec 5, 2021, 8:53 PM

#

lol

#

thing is, I ran bandit seperate from my pre-commit hook of flake8-bandit, and got 150+ errors, so like, I don't think its doing anything on site except requiring extra dependencies

#

....think I could make a pr to site to remove it?

patent pivot Dec 5, 2021, 8:55 PM

#

https://github.com/python-discord/modmail/pull/3

GitHub

Merge development into master by jb3 · Pull Request #3 · python-dis...

austere hornet Dec 5, 2021, 8:55 PM

#

stable mountain

!remind 6D too much going on

stable mountainBOT Dec 5, 2021, 8:55 PM

#

Yeah okay.

Your reminder will arrive on <t:1639256159:F>!

patent pivot Dec 5, 2021, 8:56 PM

#

fallen patrol ....think I could make a pr to site to remove it?

no

#

I don't know what you're referring to, but it is working

fallen patrol Dec 5, 2021, 8:56 PM

#

patent pivot https://github.com/python-discord/modmail/pull/3

question: would it make more sense to just edit the repo to make development the default branch? /gen

patent pivot Dec 5, 2021, 8:56 PM

#

when I run bandit -r . I get 2 low priority issues

#

one is inside a tests directory and so is excluded

#

the other is excluded with a # noqa: S105

#

oh actually both have explicit excludes

#

bandit and flake8-bandit are working as expected and I would like to continue having them on the site repository

fallen patrol Dec 5, 2021, 8:57 PM

#

👍

patent pivot Dec 5, 2021, 8:57 PM

#

these are the only issues

fallen patrol Dec 5, 2021, 8:57 PM

#

I must be mistaken or something lol

#

okay yeah

#

when i run flake8-bandit, it doesn't return any of these issues

#

#

(this is my project)

#

all of them are assert statements which would be removed by optimised compiling

#

but flake8 passes ¯_(ツ)_/¯

fallen patrol Dec 5, 2021, 8:59 PM

#

fallen patrol question: would it make more sense to just edit the repo to make development the...

@patent pivot

patent pivot Dec 5, 2021, 9:00 PM

#

uhhhh

#

we build the image off master, and having development means that we can make any necessary changes before code goes in

#

master will stay as default branch for now

fallen patrol Dec 5, 2021, 9:00 PM

#

ah, okay

#

makes sense

vale ibex Dec 5, 2021, 9:04 PM

#

patent pivot these are the only issues

were just these the conflicts you fixed?

patent pivot Dec 5, 2021, 9:04 PM

#

no this was on site

#

unrelated

#

the way I resolved conflicts was just regenerating the bandit baseline

vale ibex Dec 5, 2021, 9:04 PM

#

What was the conflict?

#

ah alright, I'm gonna merge then

patent pivot Dec 5, 2021, 9:05 PM

#

👍

fallen patrol Dec 5, 2021, 9:11 PM

#

patent pivot when I run `bandit -r .` I get 2 low priority issues

okay, bandit is working, but i can't get flake8-bandit to work-- that's why i don't think its doing anything

#

i-

#

I'm an idiot

patent pivot Dec 5, 2021, 9:13 PM

#

fallen patrol okay, bandit is working, but i can't get flake8-bandit to work-- that's why i do...

working fine here

fallen patrol Dec 5, 2021, 9:13 PM

#

yeah uh

#

I learned about 5 seconds ago, its S, not B

vale ibex Dec 5, 2021, 9:15 PM

#

hmmm, looking at the code now, it shouldn't reach that line

#

so it might have already been fixed

#

            def check(topic):
                _, user_id, other_ids = parse_channel_topic(topic)
                return recipient_id == user_id or recipient_id in other_ids

            channel = discord.utils.find(
                lambda x: (check(x.topic)) if x.topic else False,
                self.bot.modmail_guild.text_channels,
            )

            if channel:
                thread = await Thread.from_channel(self, channel)

#

So channel will only ever be truthy if there is a text channel with the user's ID in it, in the correct format

#

so, it should be fine now

#

I'm gonna bump the hash in the manifest and redeploy

#

if it's still broken, at least we get a new traceback to investigate with since the code has been moved around slightly

thorny obsidian Dec 5, 2021, 9:18 PM

#

do you need me to test it?

vale ibex Dec 5, 2021, 9:18 PM

#

Yea, that would be useful

thorny obsidian Dec 5, 2021, 9:18 PM

#

pipenv I'm just kind of tooling around while I wait for my model to train

vale ibex Dec 5, 2021, 9:18 PM

#

AH might be a bit longer

#

it seems the image no longer has git available

thorny obsidian Dec 5, 2021, 9:19 PM

#

(my model will be training for a bit)

vale ibex Dec 5, 2021, 9:19 PM

#

huh, modmail is using a git repo in requirements.txt but doesn't have git installed on the image

#

@fallen patrol have you ever been able to successfully build an image after pushing to d.py 2.0?

fallen patrol Dec 5, 2021, 9:21 PM

#

I've never built an image lmao

vale ibex Dec 5, 2021, 9:21 PM

#

fair enough, probably an issue upstream then

#

Well kyb3r/modmail#3128

dusky shoreBOT Dec 5, 2021, 9:28 PM

#

GitHub

PROpen Add git to Dockerfile

fallen patrol Dec 5, 2021, 9:31 PM

#

nice

austere hornet Dec 5, 2021, 9:32 PM

#

Hmm why are modmail notifications not going to #dev-log ? Is that on purpose?

vale ibex Dec 5, 2021, 9:33 PM

#

since that's not to our modmail

#

and for our modmail, we don't push logs since it's a fork and shouldn't really be altered from upstream too much

austere hornet Dec 5, 2021, 9:33 PM

#

Ahh I see

fallen patrol Dec 5, 2021, 9:34 PM

#

vale ibex since that's not to our modmail

different modmail when /s

vale ibex Dec 5, 2021, 9:35 PM

#

preferably soon, kyb3rs isn't the easiest to troubleshoot

fallen patrol Dec 5, 2021, 9:35 PM

#

lol yah

#

I think mine might be ready by February, but no eta

vale ibex Dec 5, 2021, 9:37 PM

#

@patent pivot you still around? kubernetes#110

dusky shoreBOT Dec 5, 2021, 9:37 PM

#

GitHub

PROpen Bump modmail up to latest version

vale ibex Dec 5, 2021, 9:40 PM

#

We should keep in mind that when we want to fetch from upstream again, we probably want to do some rebasing and cleaning up

patent pivot Dec 5, 2021, 9:41 PM

#

yea

#

merged @vale ibex

vale ibex Dec 5, 2021, 9:41 PM

#

sweet

#

arthur deployments redeploy modmail-bot

radiant merlinBOT Dec 5, 2021, 9:41 PM

#

:white_check_mark: Restarted deployment modmail-bot in namespace default.

vale ibex Dec 5, 2021, 9:41 PM

#

wait, it'll auto deploy won't it

#

or do we not do that for altered manifests

#

cluster says no

#

?about

#

now we wait

patent pivot Dec 5, 2021, 9:46 PM

#

lmfao

#

I wonder if we could have arthur patch images

slow boneBOT Dec 5, 2021, 9:46 PM

#

Modmail - About

This is an open source Discord bot that serves as a means for members to easily communicate with server administrators in an organised manner.

Uptime

0h 3m 6s

Latency

897.38 ms

Version

3.10.2

Authors

kyb3r, Taki, fourjr

Hosting Method

DOCKER

Want Modmail in Your Server?

Follow the installation guide on GitHub and join our Discord server!

Support the Developers

This bot is completely free for everyone. We rely on kind individuals like you to support us on Patreon (perks included) to keep this bot free forever!

Project Sponsors

Checkout the people who supported Modmail with command ?sponsors!

fallen patrol Dec 5, 2021, 9:46 PM

#

nice

#

lol the lag and processing:

vale ibex Dec 5, 2021, 9:50 PM

#

Yea, it takes forever to boot up

#

Hey @thorny obsidian could you try now?

thorny obsidian Dec 5, 2021, 9:50 PM

#

vale ibex Hey <@!212644551926611969> could you try now?

nothing so far

vale ibex Dec 5, 2021, 9:50 PM

#

yup, I've got a traceback

#

cheers

fallen patrol Dec 5, 2021, 9:51 PM

#

vale ibex Yea, it takes forever to boot up

you could try and figure out why but that would be a waste of time given the convoluted internals

vale ibex Dec 5, 2021, 9:52 PM

#

Yea, I'm not gonna bother

#

ah

#

ModuleNotFoundError: No module named 'lottie'

#

modmail missing a module

vocal prairie Dec 5, 2021, 10:04 PM

#

ahh

#

I've been waiting for it to respond to me for a moment

vale ibex Dec 5, 2021, 10:05 PM

#

it's just....not in the requirements???

thorny obsidian Dec 5, 2021, 10:05 PM

#

vale ibex `ModuleNotFoundError: No module named 'lottie'`

huh, is it using that for stickers?

vale ibex Dec 5, 2021, 10:05 PM

#

wtf

#

yea, we've pulled in modmail development, since it has a possible fix for the issue you're seeing

#

first it didn't have git installed in the image, and it was using git to pull d.py

#

and now lottie just isn't in the requirements

thorny obsidian Dec 5, 2021, 10:06 PM

#

honestly... kind of sounds like a dumpsterfire

vale ibex Dec 5, 2021, 10:07 PM

#

ok, latest version installs fine

#

ah nice, now it's ModuleNotFoundError: No module named 'cairosvg'

thorny obsidian Dec 5, 2021, 10:08 PM

#

dumpsterfire

vale ibex Dec 5, 2021, 10:08 PM

#

guess I'm whack-a-moleing their requirements.txt

#

12/05/21 22:09:10 __main__[1718] - ERROR: Unable to import cairosvg, report on our support server with your OS details: https://discord.gg/etJNHCQ

#

great

#

same error forcing with --platform=linux/amd64

fallen patrol Dec 5, 2021, 10:12 PM

#

damn it

#

@vale ibex you can dm me or ping me about these

vale ibex Dec 5, 2021, 10:12 PM

#

Added lottie[pdf]==0.6.10 to requirements.txt

fallen patrol Dec 5, 2021, 10:12 PM

#

i was there for this discussion

vale ibex Dec 5, 2021, 10:12 PM

#

same error

fallen patrol Dec 5, 2021, 10:13 PM

#

...did you pull the updated development branch from modmail?

vale ibex Dec 5, 2021, 10:13 PM

#

yup

#

commit c16ff261f204f5831da577d26a011db5d65d4610 (upstream/development, development)
Author: Yee Jia Rong <28086837+fourjr@users.noreply.github.com>
Date:   Mon Nov 22 20:21:56 2021 +0800

    Optimise Stop pagination

#

latest commit

fallen patrol Dec 5, 2021, 10:14 PM

#

can you check that you have a 64 bit version of python

vale ibex Dec 5, 2021, 10:16 PM

#

yup, sys.maxsize returns 9223372036854775807

fallen patrol Dec 5, 2021, 10:17 PM

#

i said they shouldn't generate lottie stickers....

#

ugh

#

what this library does is it allows lottie stickers to be generated and shown in chat

#

i'd honestly just remove its features @vale ibex

green oriole Dec 5, 2021, 10:20 PM

#

what did they change again

#

@vale ibex mind if I revert the version bump?

#

so we get modmail back and running in the meantime

fallen patrol Dec 5, 2021, 10:21 PM

#

2f762025d07c26092e90a2e4f5e45e5d6900364d

#

revert this commit: https://github.com/kyb3r/modmail/commit/2f762025d07c26092e90a2e4f5e45e5d6900364d

GitHub

Support LOTTIE images, resolves #3119 · kyb3r/modmail@2f76202

green oriole Dec 5, 2021, 10:23 PM

#

I swear to god I'll yeet those people out the building

austere hornet Dec 5, 2021, 10:23 PM

#

lmao

fallen patrol Dec 5, 2021, 10:23 PM

#

green oriole I swear to god I'll yeet those people out the building

who lol

green oriole Dec 5, 2021, 10:24 PM

#

the modmail maintainers

#

they don't use docker for the hosted bots

#

that's why they didn't realize they broke it

fallen patrol Dec 5, 2021, 10:25 PM

#

oh, yeah

#

wait why the fuck don't they use docker ;-;

#

smh taku

vocal prairie Dec 5, 2021, 10:25 PM

#

could they literally not add a docker build step to ci 😔

fallen patrol Dec 5, 2021, 10:26 PM

#

green oriole they don't use docker for the hosted bots

I just asked internally why they don't

fallen patrol Dec 5, 2021, 10:26 PM

#

fallen patrol I just asked internally why they don't

!remind 3d

stable mountainBOT Dec 5, 2021, 10:26 PM

#

Can do!

Your reminder will arrive on <t:1639002394:F>!

fallen patrol Dec 5, 2021, 10:27 PM

#

vocal prairie could they literally not add a docker build step to ci 😔

kyb3r/modmail#3098

dusky shoreBOT Dec 5, 2021, 10:27 PM

#

GitHub

PROpen Add a workflow to push to Docker hub on release

vale ibex Dec 5, 2021, 10:27 PM

#

I did it for them

#

alright, I've fixed the lotti issue

#

now onto ModuleNotFoundError: No module named 'six'

#

upsidedown_cry

austere hornet Dec 5, 2021, 10:27 PM

#

Wait what isn't modmail down? why do I see that it's online?

vocal prairie Dec 5, 2021, 10:27 PM

#

fallen patrol kyb3r/modmail#3098

not push, just to try building it

fallen patrol Dec 5, 2021, 10:27 PM

#

oh

vocal prairie Dec 5, 2021, 10:27 PM

#

austere hornet Wait what isn't modmail down? why do I see that it's online?

that's caching, reload your client and you'll see

austere hornet Dec 5, 2021, 10:28 PM

#

Ahh

fallen patrol Dec 5, 2021, 10:28 PM

#

@vale ibex ... the pipfile is good. Just need to export the requirements with pipenv

green oriole Dec 5, 2021, 10:28 PM

#

Could you

git checkout afc3051bd1a9df7ef6741874b28b233c4ec5447a
kubectl apply -f namespaces/default/modmail/bot/deployment.yaml ``` @vale ibex

#

I am getting forbidden on patch 😔

austere hornet Dec 5, 2021, 10:28 PM

#

vocal prairie that's caching, reload your client and you'll see

Ok that worked

fallen patrol Dec 5, 2021, 10:28 PM

#

no wait

#

chris

vale ibex Dec 5, 2021, 10:28 PM

#

fallen patrol <@!126811506632294400> ... the pipfile is good. Just need to export the requirem...

could you do that for me? I don't have pipenv setup

fallen patrol Dec 5, 2021, 10:28 PM

#

you do not have the most recent development branch.

#

https://github.com/kyb3r/modmail/blame/development/requirements.txt

GitHub

modmail/requirements.txt at development · kyb3r/modmail

A feature rich discord Modmail bot. Contribute to kyb3r/modmail development by creating an account on GitHub.

#

this has six, lottie, etc

#

this is not what you have.

vocal prairie Dec 5, 2021, 10:29 PM

#

fallen patrol this has six, lottie, etc

I no see them

vale ibex Dec 5, 2021, 10:29 PM

#

lottie isn't there

vocal prairie Dec 5, 2021, 10:29 PM

#

lottie, that is

vale ibex Dec 5, 2021, 10:29 PM

#

six is actually in my requirements.txt

#

but still getting that error

#

six==1.16.0; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3'

green oriole Dec 5, 2021, 10:30 PM

#

OK Chris won't roll back modmail 😔

vale ibex Dec 5, 2021, 10:30 PM

#

green oriole OK Chris won't roll back modmail 😔

I have

fallen patrol Dec 5, 2021, 10:30 PM

#

i think he did, but it takes a bit to deploy

vale ibex Dec 5, 2021, 10:30 PM

#

arthur deployments redeploy modmail-bot

radiant merlinBOT Dec 5, 2021, 10:30 PM

#

:white_check_mark: Restarted deployment modmail-bot in namespace default.

fallen patrol Dec 5, 2021, 10:30 PM

#

inherent slowness of kyb3r's bot

vale ibex Dec 5, 2021, 10:30 PM

#

I was doing the manifests

green oriole Dec 5, 2021, 10:31 PM

#

good

fallen patrol Dec 5, 2021, 10:31 PM

#

vale ibex could you do that for me? I don't have pipenv setup

gimme a minute, maybe

austere hornet Dec 5, 2021, 10:31 PM

#

Ok looks like it's up now

vale ibex Dec 5, 2021, 10:32 PM

#

?about

#

give it some time to boot

fallen patrol Dec 5, 2021, 10:32 PM

#

~~my bot isn't nearly that slow~~

#

ofc it also doesn't work yet 🙃

vale ibex Dec 5, 2021, 10:32 PM

#

It's the plugin download and setup we've found

fallen patrol Dec 5, 2021, 10:32 PM

#

ah, that makes sense, I suppose

#

Hm...

fallen patrol Dec 5, 2021, 10:33 PM

#

vale ibex It's the plugin download and setup we've found

so if the download cached the files, you would be able to mount that as a volume, and be able to persist the cache, keeping the boot time quick

#

obviously, the bot would need to support and use the cache as well

#

just asking for myself

slow boneBOT Dec 5, 2021, 10:34 PM

#

Modmail - About

This is an open source Discord bot that serves as a means for members to easily communicate with server administrators in an organised manner.

Uptime

0h 3m 10s

Latency

38992.67 ms

Version

3.10.2

Authors

kyb3r, Taki, fourjr

Hosting Method

DOCKER

Want Modmail in Your Server?

Follow the installation guide on GitHub and join our Discord server!

Support the Developers

This bot is completely free for everyone. We rely on kind individuals like you to support us on Patreon (perks included) to keep this bot free forever!

Project Sponsors

Checkout the people who supported Modmail with command ?sponsors!

fallen patrol Dec 5, 2021, 10:35 PM

#

!paste

stable mountainBOT Dec 5, 2021, 10:35 PM

#

Pasting large amounts of code

If your code is too long to fit in a codeblock in discord, you can paste your code here:
https://paste.pythondiscord.com/

After pasting your code, save it by clicking the floppy disk icon in the top right, or by typing ctrl + S. After doing that, the URL should change. Copy the URL and post it here so others can see it.

green oriole Dec 5, 2021, 10:35 PM

#

alright, seems to be good now?

fallen patrol Dec 5, 2021, 10:35 PM

#

@vale ibex https://paste.pythondiscord.com/cijoseqeje.rb

vocal prairie Dec 5, 2021, 10:36 PM

#

just dm it and it'll talk to you (this is a joke don't actually do it)

fallen patrol Dec 5, 2021, 10:36 PM

#

yes I see that duped stuff

#

but that's the direct output of pipenv

fallen patrol Dec 5, 2021, 10:36 PM

#

vocal prairie just dm it and it'll talk to you (this is a joke don't actually do it)

actually its fine to dm it once, just don't react to the check

thorny obsidian Dec 5, 2021, 10:37 PM

#

😔 if you aren't in the cache you can DM it as much as you want

fallen patrol Dec 5, 2021, 10:37 PM

#

hopefully not soon

green oriole Dec 5, 2021, 10:37 PM

#

oh hey, it is using 2.0a0 now?

fallen patrol Dec 5, 2021, 10:37 PM

#

no.

green oriole Dec 5, 2021, 10:37 PM

#

45d498c1b76deaf3b394d17ccf56112fa691d160 isn't the 2.0 hash?

fallen patrol Dec 5, 2021, 10:37 PM

#

slow bone

if it was, it would show a dev version here

vale ibex Dec 5, 2021, 10:37 PM

#

right now it isn't

#

on dev branch it is

#

but thats the thing on fire

fallen patrol Dec 5, 2021, 10:37 PM

#

I dropped the env above

vale ibex Dec 5, 2021, 10:37 PM

#

Yup, using it now

green oriole Dec 5, 2021, 10:38 PM

#

so we pushed the dev branch to prod, that's what has been happening?

fallen patrol Dec 5, 2021, 10:38 PM

#

I don't have the bot set up right now, tho

vale ibex Dec 5, 2021, 10:38 PM

#

getting the same issue with cairosvg, so working through it

fallen patrol Dec 5, 2021, 10:38 PM

#

green oriole so we pushed the dev branch to prod, that's what has been happening?

yep

#

me and joe and chris

green oriole Dec 5, 2021, 10:39 PM

#

it better not be using Py 3.9+

fallen patrol Dec 5, 2021, 10:39 PM

#

why not?

#

oh

green oriole Dec 5, 2021, 10:39 PM

#

I am going to scream, it is

fallen patrol Dec 5, 2021, 10:39 PM

#

oh god

green oriole Dec 5, 2021, 10:39 PM

#

most wheels are missing

vale ibex Dec 5, 2021, 10:40 PM

#

modmail already has g++ installed in the image

#

shrugR

green oriole Dec 5, 2021, 10:40 PM

#

It is lacking a few other stuff though

fallen patrol Dec 5, 2021, 10:41 PM

#

green oriole I am going to scream, it is

not sure if that's the problem, tho, is it?

green oriole Dec 5, 2021, 10:41 PM

#

I'm getting some error when trying to pipenv sync locally

fallen patrol Dec 5, 2021, 10:42 PM

#

the issue that someone had with cariosvg is this:

both the bit version of Python and GTK must be 64

#

this was someone self hosting on windows, so ymmv

#

side note: the logviewer will need an update as well: https://github.com/kyb3r/logviewer/pull/44

GitHub

BREAKING fix dpy2, add support old time format by lorenzo132 · Pull...

fixes internal server error, Merge whenever dev gets merged into master for modmail.

green oriole Dec 5, 2021, 10:44 PM

#

taking deep breathes

fallen patrol Dec 5, 2021, 10:44 PM

#

fallen patrol revert this commit: https://github.com/kyb3r/modmail/commit/2f762025d07c26092e90...

this might fix the lottie issues temporarily, which would at least make 2.0 runnable

#

that commit added all of the lottie support for stickers, which IMO its not that important if you get to see the image or not

#

cc @vale ibex

green oriole Dec 5, 2021, 10:45 PM

#

Let's see if we can make it run

austere hornet Dec 5, 2021, 10:45 PM

#

Lmfao

green oriole Dec 5, 2021, 10:45 PM

#

doesn't cost us much to try

vale ibex Dec 5, 2021, 10:45 PM

#

fallen patrol the issue that someone had with cariosvg is this: > both the bit version of Pyt...

well...gtk isn't even being installed onto the image at all

#

let alone 64 bit version

#

lmfao

fallen patrol Dec 5, 2021, 10:46 PM

#

green oriole doesn't cost us much to try

~~only a modmail bot that doesn't run for a little bit, but who cares~~

fallen patrol Dec 5, 2021, 10:46 PM

#

vale ibex well...gtk isn't even being installed onto the image at all

lmfao

green oriole Dec 5, 2021, 10:46 PM

#

it is running

fallen patrol Dec 5, 2021, 10:46 PM

#

not if it fails with needing missing libraries again

green oriole Dec 5, 2021, 10:47 PM

#

@slow bone is up

fallen patrol Dec 5, 2021, 10:47 PM

#

yes, i mean trying dev again with that commit reverted

#

rn its on stable

green oriole Dec 5, 2021, 10:48 PM

#

like I just said, there is no rush

fallen patrol Dec 5, 2021, 10:48 PM

#

i think the reason we were bumping to dev is to see about fixing that uncached problem with dms

green oriole Dec 5, 2021, 10:49 PM

#

it is

fallen patrol Dec 5, 2021, 10:49 PM

#

which is a bit of a rush (IMHO), as who knows how many people can't dm the bot because they aren't cached

#

but yeah, i agree

cold island Dec 5, 2021, 10:52 PM

#

@vale ibex not important for now, but I updated the clean PR

vale ibex Dec 5, 2021, 10:52 PM

#

Alright, I've got cairosvg working again

#

but now it's back to saying six doesn't exist

green oriole Dec 5, 2021, 10:53 PM

#

I have the bot running

#

just regen the requirements.txt and switch the base image to python:3.9

#

lemme grab a token from somewhere

fallen patrol Dec 5, 2021, 10:54 PM

#

vale ibex but now it's back to saying six doesn't exist

try just reverting that commit lol

#

at minimum, that should make development runnable

green oriole Dec 5, 2021, 10:54 PM

#

I just said I got it working lemon_raised_eyebrow

fallen patrol Dec 5, 2021, 10:54 PM

#

oh

vale ibex Dec 5, 2021, 10:55 PM

#

green oriole I just said I got it working <:lemon_raised_eyebrow:780477670483165244>

I'm still getting ModuleNotFoundError: No module named 'six'

fallen patrol Dec 5, 2021, 10:56 PM

#

is the base image 3.9?

vale ibex Dec 5, 2021, 10:56 PM

#

Even though six==1.16.0; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3' is right there in reqs.txt

#

yes

fallen patrol Dec 5, 2021, 10:56 PM

#

plz try reverting that commit

green oriole Dec 5, 2021, 10:56 PM

#

alright, let's move to the test server

#

I got my bot running

vale ibex Dec 5, 2021, 10:56 PM

#

We're not going to drop a commit from upstream to try and patch it being broken

#

either we fix the issue upstream, or backport the fix

fallen patrol Dec 5, 2021, 10:57 PM

#

no, i mean try reverting temporarily, to see if that's the bug

green oriole Dec 5, 2021, 10:57 PM

#

oh my god please modmail

fallen patrol Dec 5, 2021, 10:57 PM

#

its been a problem for other users too, that i want to be able to raise it being an optional feature and dependencies

vale ibex Dec 5, 2021, 10:58 PM

#

Alright, I've got it running now

fallen patrol Dec 5, 2021, 10:58 PM

#

so if you can successfully run the bot without that commit, it would help me to convince them to make it optional

vocal prairie Dec 5, 2021, 10:58 PM

#

Err, why not just run it yourself?

fallen patrol Dec 5, 2021, 10:58 PM

#

or if you can run it with it, that would also be nice too, since i can bring the steps that you did to make it work internally

fallen patrol Dec 5, 2021, 10:59 PM

#

vocal prairie Err, why not just run it yourself?

most of this is docker related, which I don't use for mine, and I currently don't have it set up ¯_(ツ)_/¯

green oriole Dec 5, 2021, 11:00 PM

#

Well I'm sorry but I think there are more pressing matters right now

#

yes that commit will fix it

#

but that's not what we're trying to do

fallen patrol Dec 5, 2021, 11:00 PM

#

green oriole but that's not what we're trying to do

so what are you trying to do, then?

green oriole Dec 5, 2021, 11:01 PM

#

get the bot running

#

with- hold on a sec

#

what is sco doing up there

fallen patrol Dec 5, 2021, 11:02 PM

#

sco?

#

oh

vale ibex Dec 5, 2021, 11:02 PM

#

alright it seems to be working alright, gonna push the fixed to the fork

fallen patrol Dec 5, 2021, 11:03 PM

#

lol i'm afraid to see them

vale ibex Dec 5, 2021, 11:03 PM

#

It's just relock reqs and remove -slim

green oriole Dec 5, 2021, 11:03 PM

#

do you need approval?

#

okay there is no branch protection i know how this is ending

fallen patrol Dec 5, 2021, 11:05 PM

#

green oriole okay there is no branch protection i know how this is ending

it already ended that way once....

vale ibex Dec 5, 2021, 11:06 PM

#

I pushed to the upstream PR

#

gonna do it on ours now

fallen patrol Dec 5, 2021, 11:07 PM

#

lol i get the same missing cairosvg version even out of a dockerfile and after manually installing it to the same venv!??

vale ibex Dec 5, 2021, 11:07 PM

#

arthur deployments redeploy modmail-bot

radiant merlinBOT Dec 5, 2021, 11:07 PM

#

:white_check_mark: Restarted deployment modmail-bot in namespace default.

vale ibex Dec 5, 2021, 11:08 PM

#

?about

slow boneBOT Dec 5, 2021, 11:08 PM

#

Modmail - About

This is an open source Discord bot that serves as a means for members to easily communicate with server administrators in an organised manner.

Uptime

0h 37m 17s

Latency

107.07 ms

Version

3.10.2

Authors

kyb3r, Taki, fourjr

Hosting Method

DOCKER

Want Modmail in Your Server?

Follow the installation guide on GitHub and join our Discord server!

Support the Developers

This bot is completely free for everyone. We rely on kind individuals like you to support us on Patreon (perks included) to keep this bot free forever!

Project Sponsors

Checkout the people who supported Modmail with command ?sponsors!

vale ibex Dec 5, 2021, 11:08 PM

#

eyes_sus

fallen patrol Dec 5, 2021, 11:08 PM

#

did you pin the version, or something?

green oriole Dec 5, 2021, 11:09 PM

#

do we even have logs anywhere for the modmail fork

vale ibex Dec 5, 2021, 11:09 PM

#

green oriole do we even have logs anywhere for the modmail fork

wdym?

green oriole Dec 5, 2021, 11:09 PM

#

webhook I mean

austere hornet Dec 5, 2021, 11:09 PM

#

What happened to @radiant merlin 's about me? I think I remember it having the link to the repo but now it's gone

#

Oh wait it's there nvm