#dev-contrib | Python | Page 153

static canyon Nov 12, 2021, 3:07 PM

#

Nope

#

I'm getting a 404

gritty wind Nov 12, 2021, 3:07 PM

#

Good

#

What's giving the 404 exactly

static canyon Nov 12, 2021, 3:08 PM

#

Everything

#

lol

#

lemme send

#

https://paste.pythondiscord.com/yusoqeyazo.properties?noredirect @gritty wind

#

Ah, I think it's /healthcheck

gritty wind Nov 12, 2021, 3:10 PM

#

It's just bot, you've now gotta change from 8000 to 8001 on bot

#

Hmm, maybe not

static canyon Nov 12, 2021, 3:10 PM

#

You told me to change to 8001 in bot here

#

So I did

gritty wind Nov 12, 2021, 3:11 PM

#

Yeah, that was correct. I was more referring to the one in your bot config

#

But you're using the docker URL, so it shouldn't matter

#

Oh your config is old

static canyon Nov 12, 2021, 3:11 PM

#

Soyml site: &DOMAIN "web:8000"should beyml site: &DOMAIN "web:8001"?

gritty wind Nov 12, 2021, 3:11 PM

#

It's correct as is now

#

But

#

what's the api URL

dim pelican Nov 12, 2021, 3:11 PM

#

Good catch, I got too caught up in it. I added a length check before stripping it off now

static canyon Nov 12, 2021, 3:11 PM

#

gritty wind what's the api URL

    site_api:    &API    !JOIN ["api.", *DOMAIN]```

gritty wind Nov 12, 2021, 3:12 PM

#

Change that to !JOIN [*DOMAIN, "/api"]

static canyon Nov 12, 2021, 3:12 PM

#

Okay

#

And then docker-compose up?

gritty wind Nov 12, 2021, 3:12 PM

#

Yeah

static canyon Nov 12, 2021, 3:13 PM

#

It's migrating stuff I think

#

Okay, so the bot is running but it doesn't have the dm_sent field @gritty wind

gritty wind Nov 12, 2021, 3:15 PM

#

Alright, what did you do where you saw it doesn't have that field

static canyon Nov 12, 2021, 3:15 PM

#

#

an int e

#

@gritty wind

gritty wind Nov 12, 2021, 3:17 PM

#

Could you send the logs from the site container again

static canyon Nov 12, 2021, 3:17 PM

#

Err

#

site isn't running

#

🤔

gritty wind Nov 12, 2021, 3:19 PM

#

Uh, what now

static canyon Nov 12, 2021, 3:19 PM

#

These are the only things running

gritty wind Nov 12, 2021, 3:19 PM

#

bot_web_1

static canyon Nov 12, 2021, 3:19 PM

#

No errors or anything

static canyon Nov 12, 2021, 3:19 PM

#

gritty wind bot_web_1

https://paste.pythondiscord.com/yasowerobe.yaml?noredirect

gritty wind Nov 12, 2021, 3:22 PM

#

Could you run docker build in the site repo again

static canyon Nov 12, 2021, 3:22 PM

#

Yep

green oriole Nov 12, 2021, 3:22 PM

#

bot_web should be the tag, bot_web_1 a container

#

you want a tag there, which should hopefully be site_web or just site

gritty wind Nov 12, 2021, 3:23 PM

#

It is using site_web

static canyon Nov 12, 2021, 3:23 PM

#

green oriole you want a tag there, which should hopefully be `site_web` or just `site`

  web:
    << : *logging
    << : *restart_policy
    image: site_web
    command: ["run", "--debug"]
    networks:
      default:
        aliases:
          - api.web
          - admin.web
          - staff.web
    ports:
      - "127.0.0.1:800:8000"
    tty: true
    depends_on:
      - metricity
    environment:
      DATABASE_URL: postgres://pysite:pysite@postgres:5432/pysite
      METRICITY_DB_URL: postgres://pysite:pysite@postgres:5432/metricity
      SECRET_KEY: suitable-for-development-only
      STATIC_ROOT: /var/www/static```

#

It's using site_web

gritty wind Nov 12, 2021, 3:24 PM

#

docker build -t site_web:latest . to rebuild

green oriole Nov 12, 2021, 3:24 PM

#

why not docker-compose build?

gritty wind Nov 12, 2021, 3:24 PM

#

Less that can go wrong

static canyon Nov 12, 2021, 3:24 PM

#

gritty wind `docker build -t site_web:latest .` to rebuild

Okay, done

#

Now what?

gritty wind Nov 12, 2021, 3:25 PM

#

docker compose start on bot, and manually verify the site is working without using bot. It's exposed on port 8001

static canyon Nov 12, 2021, 3:26 PM

#

I put it back to 8000 now

#

And it's working so 🤷

#

docker compose start on bot, and manually verify the site is working without using bot.
So cd ../bot then docker-compose up then go to 127.0.0.1:8000/api/bot/infractions or something?

#

@gritty wind

gritty wind Nov 12, 2021, 3:27 PM

#

Well, you can't just go to the URL unless you add your token

#

Do you have any http clients you can use

static canyon Nov 12, 2021, 3:28 PM

#

Just using CURL

gritty wind Nov 12, 2021, 3:28 PM

#

That works

static canyon Nov 12, 2021, 3:29 PM

#

curl: (7) Failed to connect to 127.0.0.1 port 8000: Connection refused```

#

It didn't work

gritty wind Nov 12, 2021, 3:29 PM

#

What did you run

static canyon Nov 12, 2021, 3:30 PM

#

It's port 800

#

lol

#

C:\Users\tizzy>curl -X GET https://127.0.0.1:800/api/bot/infactions -H "Authorization: Token badbot13m0n8f570f942013fc818f234916ca531"
curl: (35) schannel: next InitializeSecurityContext failed: SEC_E_INVALID_TOKEN (0x80090308) - The token supplied to the function is invalid

#

Can't remember

green oriole Nov 12, 2021, 3:32 PM

#

800 is problematic because it is a low number iirc

#

try with 8000

gritty wind Nov 12, 2021, 3:33 PM

#

It's not https

#

That's the security error

green oriole Nov 12, 2021, 3:33 PM

#

... or I just open my eyes and see it is trying to use SSL

static canyon Nov 12, 2021, 4:17 PM

#

It's because I was doing https

#

C:\Users\tizzy>curl -X GET http://127.0.0.1:800/api/bot/infractions -H "Authorization: Token badbot13m0n8f570f942013fc818f234916ca531"
[{"id":1,"inserted_at":"2021-11-12T15:14:37.005899Z","expires_at":"2021-11-12T16:14:36.931405Z","active":false,"user":407110650217627658,"actor":442244135840382978,"type":"mute","reason":"Testing x","hidden":false,"dm_sent":null}]

#

This has the dm_sent

#

So does my int e now

#

It seems to be fixed

tawdry vapor Nov 12, 2021, 5:10 PM

#

To whomever deleted their message, that is a known issue. It happens when there's an idle help channel that was created by someone else's bot.

#

Your bot didn't track who created that channel, so it just has None for the user ID.

rapid igloo Nov 13, 2021, 12:56 AM

#

dim pelican Good catch, I got too caught up in it. I added a length check before stripping i...

That's great! Let me know when you want me to review again

dim pelican Nov 13, 2021, 1:06 AM

#

rapid igloo That's great! Let me know when you want me to review again

Go for it!

fallen patrol Nov 13, 2021, 2:27 AM

#

green oriole 800 is problematic because it is a low number iirc

everything below 1024 is reserved by the sustem and requires root to bind to IIRC

#

*system

#

been looking at that....
it has some issues when closing the connection

short snow Nov 13, 2021, 6:10 AM

#

Could we auto take GitHub orgs in #black-formatter and #pyqtgraph-sprint-chat channels, if None are specified.

warm garnet Nov 13, 2021, 9:29 AM

#

Guys is there reaction role system in any of the bots in this server?

static canyon Nov 13, 2021, 9:34 AM

#

warm garnet Guys is there reaction role system in any of the bots in this server?

We've decided as a community we don't want that

warm garnet Nov 13, 2021, 9:35 AM

#

I see

#

I don't know what would be needed but will try my best

static canyon Nov 13, 2021, 9:35 AM

#

It's been brought up a number of times in #community-meta so if you look you can probably find a better explanation than what I can give

static canyon Nov 13, 2021, 9:35 AM

#

warm garnet I don't know what would be needed but will try my best

Something you could do is convert the pagination system to use 2.0 buttons instead of reactions. I believe this is something we wanted to do

#

Maybe wait for a core-dev to approve first to make sure I'm correct

warm garnet Nov 13, 2021, 9:36 AM

#

I know how to do that

#

@static canyon Btw buttons or selection menu?

static canyon Nov 13, 2021, 9:36 AM

#

static canyon Maybe wait for a core-dev to approve first to make sure I'm correct

Cc @vocal wolf if you're around

static canyon Nov 13, 2021, 9:37 AM

#

warm garnet <@442244135840382978> Btw buttons or selection menu?

I believe we wanted buttons

warm garnet Nov 13, 2021, 9:37 AM

#

I see

static canyon Nov 13, 2021, 9:37 AM

#

First Page | Previous Page | Next Page | Last Page

#

Maybe with some logic for only displaying when needed

#

E.g on first page don't display first/previous

warm garnet Nov 13, 2021, 9:38 AM

#

I see

static canyon Nov 13, 2021, 9:39 AM

#

I've not touched interactions so don't know if it's possible but I imagine it shouldn't be too difficult

warm garnet Nov 13, 2021, 9:39 AM

#

I know how to do this

#

I have made this on one of my team's bot

static canyon Nov 13, 2021, 9:39 AM

#

But yeah, wait for a core-dev to confirm before working on it (just to be safe so that you don't start working on something we don't actually want)

warm garnet Nov 13, 2021, 9:39 AM

#

Btw don't warn this time cause I used team word

#

Lol

#

I got warned due to this advertisement a hell lot time

#

Lol

warm garnet Nov 13, 2021, 9:41 AM

#

static canyon But yeah, wait for a core-dev to confirm before working on it (just to be safe s...

Sure

short snow Nov 13, 2021, 11:42 AM

#

static canyon Something you *could* do is convert the pagination system to use 2.0 buttons ins...

aru has already opened an issue on that, they have already implemented it and are willing to put it here also IIRC... Don't remember the issue number

cold island Nov 13, 2021, 11:44 AM

#

static canyon Maybe wait for a core-dev to approve first to make sure I'm correct

We didn't have unanimous agreement over that, not really high priority anyway

brisk brook Nov 13, 2021, 2:10 PM

#

short snow Could we auto take GitHub orgs in <#846434317021741086> and <#905437773044011038...

What do you mean by "auto take"?

timid sentinel Nov 13, 2021, 3:12 PM

#

you'd have to host it yourself, I don't think we'd be interested in hosting it publicly

#

We have limited resources, and it's something that could be potentially quite resource intensive with not that much benefit. Since the servers we used are sponsored for use running the server, it could potentially be unfair to use that for something not really related to the server (?) not sure on the details of the agreement though

#

Would require proper ratelimiting etc, and there would be an expectation that we could keep the service running even if demand increased (if it was used too much there would be a limit to how much we could scale it with the resources we have, and we'd then have to break stuff by taking down the service)

short snow Nov 13, 2021, 3:22 PM

#

brisk brook What do you mean by "auto take"?

like it would default to the respective org if the message is in that channel

fervent sage Nov 13, 2021, 4:03 PM

#

That would be pretty cool

molten perch Nov 13, 2021, 4:06 PM

#

Seems like a nice idea, although there should be a way to associate a specific channel with a specific github organization.
(Like an API endpoint? lemon_xd )

short snow Nov 13, 2021, 4:15 PM

#

file constant

patent pivot Nov 13, 2021, 5:07 PM

#

more work for me

#

but yeah what wookie said

#

it is nice having all evaluations in server as well, since we can monitor if things break and see why

#

opening it up reduces our visibility into that

short snow Nov 13, 2021, 5:11 PM

#

engineerman/piston

#

that's what I use

molten perch Nov 13, 2021, 6:27 PM

#

Hey! Just a quick question, httpx is BSD-3, is it compatible with MIT?
(It's a core part of the testing suite of API)

brazen charm Nov 13, 2021, 6:30 PM

#

should be fine, just need to add the license with the notice

#

oh, or just use it if you don't actually take some code from there

molten perch Nov 13, 2021, 6:37 PM

#

Alright, thank you! 🙂

molten perch Nov 13, 2021, 7:33 PM

#

Hey! I ran into a bit of a problem while implementing the async test suite for the API.
The API uses pytest, and pytest-asyncio, and it seems like the async fixtures are run with a different self than the actual test methods.
(The corresponding issue: pytest-dev/pytest-asyncio#197)
Has anyone occurred something like that?
(I've come up with a solution, that circumvents this issue, but I don't think that it's the way to go)

dusky shoreBOT Nov 13, 2021, 7:33 PM

#

GitHub

IssueOpen async method fixture is run with different self than the test method

fervent sage Nov 13, 2021, 8:51 PM

#

short snow engineerman/piston

it even supports yeethon thanks to you Kek

short snow Nov 13, 2021, 10:45 PM

#

lol

sour wolf Nov 14, 2021, 12:33 AM

#

!docs str.isupper

stable mountainBOT Nov 14, 2021, 12:33 AM

#

str.isupper


str.isupper()```
Return `True` if all cased characters [4](https://docs.python.org/3/library/stdtypes.html#id15) in the string are uppercase and there is at least one cased character, `False` otherwise.

```py
>>> 'BANANA'.isupper()
True
>>> 'banana'.isupper()
False
>>> 'baNana'.isupper()
False
>>> ' '.isupper()
False

sour wolf Nov 14, 2021, 12:33 AM

#

whats that 4 doing there

#

oh, its a link to a footnote about cased characters, could use being superscripted tbh

brazen charm Nov 14, 2021, 12:41 AM

#

should be simple to do if the href has some footnote class

fallen patrol Nov 14, 2021, 1:10 AM

#

don't mind me just want to see features

#

!guild

stable mountainBOT Nov 14, 2021, 1:10 AM

#

Server Information

Created: <t:1483877013:R>
Voice region: europe
Features: PRIVATE_THREADS, SEVEN_DAY_THREAD_ARCHIVE, THREADS_ENABLED, RELAY_ENABLED, VANITY_URL, NEWS, COMMUNITY, MEMBER_VERIFICATION_GATE_ENABLED, MEMBER_PROFILES, ANIMATED_BANNER, BANNER, ROLE_ICONS, PARTNERED, PREVIEW_ENABLED, INVITE_SPLASH, ANIMATED_ICON, DISCOVERABLE, NEW_THREAD_PERMISSIONS, THREE_DAY_THREAD_ARCHIVE, VIP_REGIONS, WELCOME_SCREEN_ENABLED
Roles: 92
Member status: status_online 41,987 status_offline 234,248

Members: 276,236

Helpers: 133
Moderation Team: 31
Admins: 15
Owners: 3
Contributors: 46
Leads: 13

Channels: 240

Category: 30
News: 8
Staff: 76
Stage_Voice: 2
Text: 113
Voice: 11

fallen patrol Nov 14, 2021, 1:10 AM

#

MEMBER_PROFILES
neat

austere hornet Nov 14, 2021, 1:25 AM

#

#bot-commands

fallen patrol Nov 14, 2021, 1:40 AM

#

austere hornet <#267659945086812160>

tldr can't

#

https://github.com/python-discord/bot/blob/a345a912a88a53123bdd5d0806530c62d5166a9a/bot/exts/info/information.py#L179-L185

stable mountainBOT Nov 14, 2021, 1:40 AM

#

bot/exts/info/information.py lines 179 to 185

# Server Features are only useful in certain channels
if ctx.channel.id in (
    *constants.MODERATION_CHANNELS, constants.Channels.dev_core, constants.Channels.dev_contrib
):
    features = f"\nFeatures: {', '.join(ctx.guild.features)}"
else:
    features = ""```

austere hornet Nov 14, 2021, 1:40 AM

#

fallen patrol tldr can't

Wdym can't? Does the command not work there?

fallen patrol Nov 14, 2021, 1:40 AM

#

see above snippet 😛

austere hornet Nov 14, 2021, 1:41 AM

#

Ah ok gotcha

patent pivot Nov 14, 2021, 1:45 AM

#

fallen patrol see above snippet 😛

PR it

fallen patrol Nov 14, 2021, 1:50 AM

#

pr what

patent pivot Nov 14, 2021, 1:51 AM

#

add features to bot-commands

fallen patrol Nov 14, 2021, 1:52 AM

#

ah

patent pivot Nov 14, 2021, 1:52 AM

#

while I don't think it's necessary, I'd rather you spam commands there than here, so either we remove dev-contrib from the list or add bot-commands

#

I think the latter is fine

fallen patrol Nov 14, 2021, 1:53 AM

#

is there a line character count on bot?

patent pivot Nov 14, 2021, 1:54 AM

#

not sure what you mean

fallen patrol Nov 14, 2021, 1:54 AM

#

nvm

#

flake8

#

its fine

austere hornet Nov 14, 2021, 2:17 AM

#

sir-lancebot#901 is finally ready for review!

dusky shoreBOT Nov 14, 2021, 2:17 AM

#

GitHub

PROpen Madlibs

austere hornet Nov 14, 2021, 2:18 AM

#

Also if someone could mark @static canyon 's requested changes as done, that would be great. Thanks!

trail pilot Nov 14, 2021, 2:30 AM

#

Does anyone know where the error handling of Sir Lancebot is?

austere hornet Nov 14, 2021, 2:31 AM

#

trail pilot Does anyone know where the error handling of Sir Lancebot is?

Cc @patent pivot maybe?

patent pivot Nov 14, 2021, 2:32 AM

#

https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/core/error_handler.py

GitHub

sir-lancebot/error_handler.py at main · python-discord/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - sir-lancebot/e...

trail pilot Nov 14, 2021, 2:33 AM

#

Thanks!

patent pivot Nov 14, 2021, 2:33 AM

#

ok_handbutflipped

fallen patrol Nov 14, 2021, 3:21 AM

#

patent pivot PR it

.... not sure i can, having some venv problems lol

#

patent pivot Nov 14, 2021, 3:21 AM

#

i don't think it's something that particularly needs a huge deal of testing

#

it's adding a constant to a list

fallen patrol Nov 14, 2021, 3:22 AM

#

its more, i need to ensure I pass pre-commit since i'm not sure if adding it would go over the line limit and im too tired to be testing that without flake8 telling me it'll pass or not

patent pivot Nov 14, 2021, 3:22 AM

#

i'll just add it

fallen patrol Nov 14, 2021, 3:23 AM

#

meh

#

okay

#

im gonna go sleep then

patent pivot Nov 14, 2021, 3:32 AM

#

https://github.com/python-discord/bot/pull/1953

GitHub

Add #bot-commands to guild features in !server by jb3 · Pull Reques...

This prevents spam in dev-contrib and dev-core from people trying to
find which Discord feature flags are enabled for Python Discord. It's
not ideal that we have to increase output size in ...

#

emacs is so great, i did all of that from emacs from the editing to committing to opening the PR and i enjoyed every step

fallen patrol Nov 14, 2021, 3:35 AM

#

;-;

fallen patrol Nov 14, 2021, 4:05 AM

#

https://github.com/python-discord/bot/blob/a345a912a88a53123bdd5d0806530c62d5166a9a/bot/exts/info/information.py#L179-L185

GitHub

bot/information.py at a345a912a88a53123bdd5d0806530c62d5166a9a · py...

The community bot for the Python Discord community - bot/information.py at a345a912a88a53123bdd5d0806530c62d5166a9a · python-discord/bot

#

<@&267628507062992896> seems there's a problem with @stable mountain and github

#

the above link is not the problem

#

but python is not automatically embedding github code links

thorny obsidian Nov 14, 2021, 4:06 AM

#

You mean the line number thing?

fallen patrol Nov 14, 2021, 4:06 AM

#

yeah

thorny obsidian Nov 14, 2021, 4:07 AM

#

I don't really think that's ultra critical though to our infrastructure

fallen patrol Nov 14, 2021, 4:07 AM

#

no, but it seems like a sign of something else

thorny obsidian Nov 14, 2021, 4:07 AM

#

So what other things have been going wonky with Python?

fallen patrol Nov 14, 2021, 4:08 AM

#

since there hasn't been any redeploys, it would be the same code, which means that the token could have expired, or the bot is being ratelimited or worse
it could also be a github issue tho

fallen patrol Nov 14, 2021, 4:09 AM

#

thorny obsidian So what other things have been going wonky with Python?

nothing yet? does there have to be?

rapid igloo Nov 14, 2021, 7:30 AM

#

patent pivot emacs is so great, i did all of that from emacs from the editing to committing t...

lemon_surprised magit forge?

static canyon Nov 14, 2021, 8:21 AM

#

austere hornet Also if someone could mark <@!442244135840382978> 's requested changes as done, ...

I'll review it again later today

#

Altho something I noticed at first glance is you never got around ro restructuring the json file

static canyon Nov 14, 2021, 8:49 AM

#

RE site#621

The lint-test check is failing since the max-line-length is configured to 100. Should I fix this, or do we want to increase the max-line-length to 120 to be consistent with the other repos?

dusky shoreBOT Nov 14, 2021, 8:49 AM

#

GitHub

PROpen Add dm_sent field to infractions model

green oriole Nov 14, 2021, 10:07 AM

#

fallen patrol <@&267628507062992896> seems there's a problem with <@!409107086526644234> and g...

It is working now, although you should ping devops for this, unless it is a perm issue

fallen patrol Nov 14, 2021, 10:08 AM

#

ah

#

i pinged admins because that's what I remember being told last time

#

ohhh it was an admin fix issue tho because help channels

#

~~guys akarys is crazy~~

molten perch Nov 14, 2021, 1:11 PM

#

Hey! I ran into a bit of a problem while implementing the async test suite for the pydis. API.
The API uses pytest, and pytest-asyncio, and it seems like the async fixtures are run with a different self than the actual test methods.
(The corresponding issue: pytest-dev/pytest-asyncio#197)
Has anyone occurred something like that?
(I've come up with a solution, that circumvents this issue, but I don't think that it's the way to go, only a last resort idea to go with.)

dusky shoreBOT Nov 14, 2021, 1:11 PM

#

GitHub

IssueOpen async method fixture is run with different self than the test method

molten perch Nov 14, 2021, 1:50 PM

#

Accessing the correct instance via a non-async-fixture. But, that's something that should be considered as a last-resort (or maybe not even that) idea.

dim pelican Nov 14, 2021, 2:00 PM

#

sir-lancebot#842 should finally be finished, or close to it if someone finds anything else that needs tweaking

dusky shoreBOT Nov 14, 2021, 2:00 PM

#

GitHub

PROpen Add color command

dim pelican Nov 14, 2021, 2:07 PM

#

Apparently color is hard

austere hornet Nov 14, 2021, 3:00 PM

#

static canyon Altho something I noticed at first glance is you never got around ro restructuri...

Yes, I couldn't figure out what exactly I needed to do, however, I did add the TypedDict class in my program (actually, Bluenix did)

#

I probably should have asked but I've been quite busy and been focusing more on getting the game itself working, and then worrying about the nitpicks. Just want you to know that I'm not purposefully ignoring your comment, I was primarily focused on getting everything else to work before focusing on the nitpicks. Does that make sense?
Also as I said, I'm still not sure exactly what I need to do, so if you could explain a little more about how exactly you wanted me to restructure the JSON, that would be great. Either ping me here or add a comment on GitHub. Thanks so much!

static canyon Nov 14, 2021, 3:30 PM

#

austere hornet Yes, I couldn't figure out what exactly I needed to do, however, I did add the T...

Basically just instead ofpy { "templates": [ ... ] }you havepy [ ... ]

#

Literally that's it

austere hornet Nov 14, 2021, 3:32 PM

#

Ohh ok lol

#

That was easy

#

I understand things more visually than reading things that's probably why I was confused

austere hornet Nov 14, 2021, 3:39 PM

#

static canyon Basically just instead of```py { "templates": [ ... ] }```you ha...

I still have a question, actually. Instead of this:

with open(madlibs_stories) as file:
    return json.load(file)["templates"]

I would do this:

with open(madlibs_stories) as file:
    return json.load(file)

Correct?

green oriole Nov 14, 2021, 3:43 PM

#

Hey @dim pelican, if that's fine with you, can I push a commit to your color PR and just merge it? I think you've spent enough time on that time 😄

dim pelican Nov 14, 2021, 3:43 PM

#

green oriole Hey <@!698273827448291379>, if that's fine with you, can I push a commit to your...

Sure! What did you want to commit? Currently it's based on my fork

green oriole Nov 14, 2021, 3:44 PM

#

the JSON file is missing the copyright notice

dim pelican Nov 14, 2021, 3:44 PM

#

I see, yeah give me a second to set you up

green oriole Nov 14, 2021, 3:44 PM

#

If you checked "allow edits from maintainers" I have push access to that branch

#

yep I do

dim pelican Nov 14, 2021, 3:46 PM

#

I invited you just in case

green oriole Nov 14, 2021, 3:49 PM

#

I feel like I borked the file

#

looks good

#

I am capturing the first core dev I see to leave a proxy approval

static canyon Nov 14, 2021, 4:07 PM

#

austere hornet I still have a question, actually. Instead of this: ```py with open(madlibs_stor...

Yeah

brisk brook Nov 14, 2021, 4:20 PM

#

#

huh

austere hornet Nov 14, 2021, 4:22 PM

#

brisk brook

Is that on my PR or Brad's?

green oriole Nov 14, 2021, 4:25 PM

#

brisk brook

qwerty isn't a core dev and chris also committed to the PR lol

austere hornet Nov 14, 2021, 4:30 PM

#

I'm getting this error when I try to commit. Does anyone know why?

#

I also got this error when I ran poetry run task precommit:

gritty wind Nov 14, 2021, 4:38 PM

#

Did you run poetry install?

austere hornet Nov 14, 2021, 4:38 PM

#

I had poetry installed for a long time I'm pretty sure

gritty wind Nov 14, 2021, 4:39 PM

#

Try “poetry install —remove-untracked”

#

The option name may be wrong, check the help

austere hornet Nov 14, 2021, 4:41 PM

#

gritty wind Try “poetry install —remove-untracked”

#

It's working now actually. Thanks Scale!

austere hornet Nov 14, 2021, 5:18 PM

#

Anyone know why I'm getting this when I try to start up my test bot? (cc @dim pelican because I think this is related to your color PR)

#

I ran pip install coloredlogs and it's still not working

dim pelican Nov 14, 2021, 5:19 PM

#

That's the colored trace logs

austere hornet Nov 14, 2021, 5:20 PM

#

....ok, and? How do I get rid of the error?

thorny obsidian Nov 14, 2021, 5:20 PM

#

are you running it via poetry or docker?

austere hornet Nov 14, 2021, 5:20 PM

#

Docker

thorny obsidian Nov 14, 2021, 5:21 PM

#

delete the image/container, then docker-compose up to rebuild it

austere hornet Nov 14, 2021, 5:21 PM

#

How do I delete the container? Inside Docker?

thorny obsidian Nov 14, 2021, 5:22 PM

#

mhm, through the docker desktop window/menu

austere hornet Nov 14, 2021, 5:22 PM

#

Actually, can't I just run docker-compose up --build?

#

Instead of deleting the container?

thorny obsidian Nov 14, 2021, 5:23 PM

#

I prefer deleting the container in most cases since sometimes caching within docker can do funky things

dim pelican Nov 14, 2021, 5:23 PM

#

Gotta compose it down or delete it to rebuild the image right?

austere hornet Nov 14, 2021, 5:24 PM

#

austere hornet Actually, can't I just run `docker-compose up --build`?

I tried this and the error went away

dim pelican Nov 14, 2021, 5:24 PM

#

austere hornet ....ok, and? How do I get rid of the error?

Also my PR was on sir-lance, not bot. And does not introduce anything related to logs.

austere hornet Nov 14, 2021, 5:24 PM

#

dim pelican Also my PR was on sir-lance, not bot. And does not introduce anything related to...

Yes ik

thorny obsidian Nov 14, 2021, 5:24 PM

#

Yeah coloredLogs has nothing to do with brad's color PR

austere hornet Nov 14, 2021, 5:24 PM

#

Oh ok, I thought it was, but I guess not

#

Thanks

vocal wolf Nov 14, 2021, 6:04 PM

#

@dim pelican is it over? Is it... done?

thorny obsidian Nov 14, 2021, 6:05 PM

#

.color

dusky shoreBOT Nov 14, 2021, 6:05 PM

#

Oxford Blue

Color information for Color Oxford Blue.

RGB

(56, 69, 85)

HSV

(213, 34, 33)

HSL

(213, 21, 28)

CMYK

(34, 19, 0, 67)

Hex

#384555

Name

Oxford Blue

thorny obsidian Nov 14, 2021, 6:05 PM

#

IT LIIIVES

dim pelican Nov 14, 2021, 6:05 PM

#

vocal wolf <@!698273827448291379> is it over? Is it... done?

F I N A L L Y

vocal wolf Nov 14, 2021, 6:06 PM

#

I'm so proud of you

austere hornet Nov 14, 2021, 6:06 PM

#

dim pelican F I N A L L Y

Lol love the enthusiasm, this command will be super helpful I'm sure

vocal wolf Nov 14, 2021, 6:06 PM

#

This was one hell of a PR

summer garden Nov 14, 2021, 6:07 PM

#

I'm assuming the bot auto updates when you push to main branch. How does that work?

vocal wolf Nov 14, 2021, 6:07 PM

#

Microsoft Azure

#

iirc

thorny obsidian Nov 14, 2021, 6:08 PM

#

It's a really good command, thanks for sticking with it brad~ (also pushing back on a lot of the scope creep >_>)

vocal prairie Nov 14, 2021, 6:08 PM

#

summer garden I'm assuming the bot auto updates when you push to main branch. How does that wo...

It's pushed directly to the k8s cluster from ghcr.io (https://git.pydis.com/bot/blob/main/.github/workflows/build.yml) via github actions https://git.pydis.com/bot/blob/main/.github/workflows/deploy.yml

dim pelican Nov 14, 2021, 6:08 PM

#

On a totally unrelated note, I probably won't be PRing anything for a while. I'll just stick to reviewing and testing

vocal wolf Nov 14, 2021, 6:08 PM

#

dim pelican On a totally unrelated note, I probably won't be PRing anything for a while. I'l...

Understandable. Take a break, please.

#

for your sanity

dim pelican Nov 14, 2021, 6:10 PM

#

vocal wolf for your sanity

*what's left of it

vocal wolf Nov 14, 2021, 6:11 PM

#

lol

trail pilot Nov 14, 2021, 6:16 PM

#

dim pelican *what's left of it

You got ~250 comments on your PR right?

#

That probably wiped a way a lot of your sanity

patent pivot Nov 14, 2021, 6:17 PM

#

summer garden I'm assuming the bot auto updates when you push to main branch. How does that wo...

i have a diagram!!!! i have a diagram!!!!!

gritty wind Nov 14, 2021, 6:18 PM

#

I don’t think we’ve been on azure since I joined the staff team ages ago lol

patent pivot Nov 14, 2021, 6:18 PM

#

oh please say i still have it

gritty wind Nov 14, 2021, 6:18 PM

#

You always do joe, it’s your speciality

patent pivot Nov 14, 2021, 6:19 PM

#

#

it is not a great diagram as i drew it live during my talk on pydis infra (https://www.youtube.com/watch?v=00CW1y-O8YQ) but it gets the process across

thorny obsidian Nov 14, 2021, 6:19 PM

#

Is that from the devops talk?

patent pivot Nov 14, 2021, 6:19 PM

#

yes

#

lol

dim pelican Nov 14, 2021, 6:21 PM

#

trail pilot You got ~250 comments on your PR right?

Yeah somewhere around there, and 139 reviews, 35 comments

patent pivot Nov 14, 2021, 6:22 PM

#

i also have this one

#

for how traffic gets from user --> us

#

it's a bit simplifed though

trail pilot Nov 14, 2021, 6:25 PM

#

dim pelican Yeah somewhere around there, and 139 reviews, 35 comments

My goodness

#

That’s a lot

patent pivot Nov 14, 2021, 6:25 PM

#

the full on version is out of date now I think

trail pilot Nov 14, 2021, 6:25 PM

#

Is it the most commented PR on sir lancebot?

patent pivot Nov 14, 2021, 6:26 PM

#

hmmmmm

#

it is

summer garden Nov 14, 2021, 6:28 PM

#

oh damn

patent pivot Nov 14, 2021, 6:31 PM

#

correct enough

#

the coredns/kubernetes api stuff is weird but the rest looks correct

#

it also omits that not all volumes are databases

#

services can have their own volumes

#

nginx ingress fetches the IP from the API, any other service, unless explicitly configured for kubernetes, fetches the IP from CoreDNS, which in turn fetches it from the Kubernetes API, so CoreDNS just wraps the Kubernetes API over DNS alongside resolving all external DNS queries (e.g. discord.com)

#

it just adds a .cluster.local. zone which it can resolve for

green oriole Nov 14, 2021, 7:16 PM

#

Who's gonna read and try to understand the whole diagram lmao

patent pivot Nov 14, 2021, 8:00 PM

#

lol

fallen patrol Nov 14, 2021, 9:45 PM

#

lol can i submit a pr for the color command to whitelist #dev-branding

patent pivot Nov 14, 2021, 9:48 PM

#

yeah

fallen patrol Nov 14, 2021, 10:13 PM

#

ok

fallen patrol Nov 14, 2021, 10:32 PM

#

which decorator is that for whitelisting a new channel in addition to the defaults??

vale ibex Nov 14, 2021, 10:44 PM

#

fallen patrol which decorator is that for whitelisting a new channel in addition to the defaul...

bot.utils.decorators.whitelist_override

fallen patrol Nov 14, 2021, 10:45 PM

#

hmmm

#

should i add #dev-branding to the config, or just whitelist this entire category

vale ibex Nov 14, 2021, 10:46 PM

#

Honestly this command seems like one that could be useful everywhere

#

Or at least in help channels and topical

#

Category seems fine for this specific change

#

But it might be worth opening an issue to see if it should be extended further after too

fallen patrol Nov 14, 2021, 10:56 PM

#

oki

#

should i also add constants.Categories.media?

fallen patrol Nov 14, 2021, 11:18 PM

#

@vale ibex the docstring seems to imply that it will also keep global check https://github.com/python-discord/sir-lancebot/blob/dea39a46437227b1ca0ec94aa00376b4167f2f02/bot/utils/decorators.py#L283-L291

stable mountainBOT Nov 14, 2021, 11:18 PM

#

bot/utils/decorators.py lines 283 to 291

def whitelist_override(bypass_defaults: bool = False, **kwargs: Container[int]) -> Callable:
    """
    Override global whitelist context, with the kwargs specified.

    All arguments from `in_whitelist_check` are supported, with the exception of `fail_silently`.
    Set `bypass_defaults` to True if you want to completely bypass global checks.

    This decorator has to go before (below) below the `command` decorator.
    """```

gritty wind Nov 15, 2021, 12:11 AM

#

If you want to enable it globally, set the role to everyone

#

The defaults part allows you to remove parts of the global whitelist, so you can disable certain commands in channels where they are otherwise enabled

fallen patrol Nov 15, 2021, 1:20 AM

#

ahhhh

fallen patrol Nov 15, 2021, 1:21 AM

#

gritty wind If you want to enable it globally, set the role to everyone

I mean, chris said to make an issue for that, but I could allow it in all in this pr ¯_(ツ)_/¯

rapid igloo Nov 15, 2021, 5:46 AM

#

dim pelican F I N A L L Y

congrats 🎉 it's a really nice feature, well done! support for alpha values and color palettes is on my todo list :P

short snow Nov 15, 2021, 6:34 AM

#

rapid igloo congrats 🎉 it's a really nice feature, well done! support for alpha values an...

I am opening an issue on enhancing the colour command, RE (https://github.com/python-discord/sir-lancebot/pull/842#pullrequestreview-790596534). Want me to include Alpha values and colour palettes also?

placid ermine Nov 15, 2021, 8:33 AM

#

holy fuck the color pr has 142 commits

fallen patrol Nov 15, 2021, 9:02 AM

#

@gritty wind are you okay.

gritty wind Nov 15, 2021, 9:03 AM

#

I hate it so much

fallen patrol Nov 15, 2021, 9:03 AM

#

you know the definition of insanity right?

gritty wind Nov 15, 2021, 9:03 AM

#

I was trying different things smh

fallen patrol Nov 15, 2021, 9:04 AM

#

force pushing multiple times and expecting different results

gritty wind Nov 15, 2021, 9:04 AM

#

I wasn’t just pushing the same thing 10 times lmao

fallen patrol Nov 15, 2021, 9:04 AM

#

;-;

#

its actually pretty funny to view #dev-log lmao

gritty wind Nov 15, 2021, 9:04 AM

#

Force pushes are the new commits

fallen patrol Nov 15, 2021, 9:04 AM

#

i do applaud this one weird check #dev-log message

#

what was up with it passing??

gritty wind Nov 15, 2021, 9:05 AM

#

It was expected to pass

#

It’s exactly like the final push

#

It’s just not a nice solution

fallen patrol Nov 15, 2021, 9:07 AM

#

ah

green oriole Nov 15, 2021, 9:08 AM

#

Scaleios just smashing that branch over and over again
🐍 🖐️ bonk
🌲 🔥

gritty wind Nov 15, 2021, 9:09 AM

#

It’s a shit branch, deserves all the punishment

green oriole Nov 15, 2021, 9:12 AM

#

poor branch

fallen patrol Nov 15, 2021, 9:17 AM

#

gritty wind It’s a shit branch, deserves all the punishment

no its not smh

#

that's my branches

#

i uh, i have several unpushed branches of code on my own project

fallen patrol Nov 15, 2021, 10:57 AM

#

+2

fallen patrol Nov 15, 2021, 11:31 AM

#

what's the deal with the wolfram command?

#

why is wolfram broken, any internal sentry errors on that?

vale ibex Nov 15, 2021, 11:31 AM

#

It's not broken

#

.wa short 2+2

dim pelican Nov 15, 2021, 11:32 AM

#

rapid igloo congrats 🎉 it's a really nice feature, well done! support for alpha values an...

Sounds good! If you run into any questions just let me know (but I'm sure you'll do just fine)

dusky shoreBOT Nov 15, 2021, 11:32 AM

#

Wolfram Alpha

4

fallen patrol Nov 15, 2021, 11:32 AM

#

...

#

what.

#

it's been breaking a lot aside from that one exact example

vale ibex Nov 15, 2021, 11:32 AM

#

Can you give an example?

fallen patrol Nov 15, 2021, 11:33 AM

#

you just saw it lol

#

.wa iirc

vale ibex Nov 15, 2021, 11:33 AM

#

Oh, that's not it breaking

#

That's wolfram saying it doesn't have an answer

fallen patrol Nov 15, 2021, 11:35 AM

#

well

#

different comment, then

#

wolfram returns what it is having trouble with

vale ibex Nov 15, 2021, 11:36 AM

#

Yea the command was made a while ago, so that either didn't exist back then, or was ignored by the person who made it

fallen patrol Nov 15, 2021, 11:36 AM

#

if it doesn't have an answer could the reply be a bit more informative

#

ah

short snow Nov 15, 2021, 12:02 PM

#

oh shit

#

my bd

#

ty akarys

green oriole Nov 15, 2021, 12:04 PM

#

joe_salute

short snow Nov 15, 2021, 12:25 PM

#

and that's it

#

finally opened them

clever wraith Nov 15, 2021, 2:07 PM

#

what is this channel for and what do you do here~?

#

i read the description

dim pelican Nov 15, 2021, 2:08 PM

#

Contribute to the open source bots we have

clever wraith Nov 15, 2021, 2:08 PM

#

and not other things?

dim pelican Nov 15, 2021, 2:08 PM

#

Like what other things?

#

Python Discord Project discussions. Don't forget to lint!
From the channel description

green oriole Nov 15, 2021, 2:22 PM

#

Don't forget to lint or... bad things happen

#

I believe you get murdered by lemon in some ways

dim pelican Nov 15, 2021, 2:23 PM

#

Eternal shame in #dev-log for failed checks

green oriole Nov 15, 2021, 2:23 PM

#

I still think there is murder included

#

Right, so @crude gyro will throw his face into your face until you die and delete your internet

#

The latter being way worse than the former

short snow Nov 15, 2021, 2:27 PM

#

Don't lie, you are still alive

green oriole Nov 15, 2021, 2:27 PM

#

I always lint before I push smh

short snow Nov 15, 2021, 2:27 PM

#

#dev-log message

#

one more lie

green oriole Nov 15, 2021, 2:28 PM

#

Smh I haven't pushed that one! Ks did!

short snow Nov 15, 2021, 2:29 PM

#

😔

#

#dev-log message 🙃 lemon do it

crude gyro Nov 15, 2021, 2:31 PM

#

murder is such a strong word

dim pelican Nov 15, 2021, 2:32 PM

#

sudo rm -rf life?

green oriole Nov 15, 2021, 2:32 PM

#

lemon will end up murdering me in due time, don't worry

short snow Nov 15, 2021, 2:33 PM

#

That's good news for alizee, she will live longer life

green oriole Nov 15, 2021, 2:34 PM

#

thonking not sure if that's how it works

austere hornet Nov 15, 2021, 2:38 PM

#

green oriole Right, so <@95872159741644800> will throw his face into your face until you die ...

Lmfao

green oriole Nov 15, 2021, 2:39 PM

#

If you are lacking context: https://soundcloud.com/lemonsaurusrex/lint-before-you-push

short snow Nov 15, 2021, 2:40 PM

#

.

austere hornet Nov 15, 2021, 2:44 PM

#

Oh wow

austere hornet Nov 15, 2021, 2:44 PM

#

green oriole If you are lacking context: <https://soundcloud.com/lemonsaurusrex/lint-before-y...

I've listened to that

green oriole Nov 15, 2021, 2:44 PM

#

Excellent

thorny obsidian Nov 15, 2021, 5:50 PM

#

@eternal owl heeeey so took a look at the Events issue and what functionality is covered by Discord's new native events functionality... and yeaaaaaaaaaaah. The discord's event functionality does accomplish everything I listed in the issue. Thank you so much for working on it though!! I super appreciate it!!!

molten perch Nov 15, 2021, 6:34 PM

#

Well, haven't done anything specific since last time. We'll implement paralel testing later on.
For now, I'm waiting for @vale ibex 's PR to be merged, then I'll push my PR that adds the reminder endpoints, but now using the newest SQLAlchemy syntax, and an async driver.

#

If that PR gets merged, and tested, we can start migrating the rest of the endpoints, based on my "template", sort of.

green oriole Nov 15, 2021, 6:36 PM

#

All of them

#

https://github.com/python-discord/api/pull/29

GitHub

Move to asyncpg instead of psycopg by ChrisLovering · Pull Request ...

This PR moves our migrations to asyncpg, adds a docker volume for migrations and adds a helper task for generating those migrations.
Simply by running poetry run task revision "Migration m...

#

I believe

molten perch Nov 15, 2021, 6:36 PM

#

Yeah, that's the one.
Just a few modifications and it's good to go.

vale ibex Nov 15, 2021, 6:59 PM

#

Can we just merge it and deal with issues after if it's blocking

#

Since its not prod anyway

thorny obsidian Nov 15, 2021, 6:59 PM

#

👉 👈 ... but if D0rs4n is blocked then I can maybe ~~con~~ convince him to do another event PR :D

molten perch Nov 15, 2021, 6:59 PM

#

Actually, it's just 2 characters and a space, and it's good to go. I can push the changes, I believe i have push perms.

vale ibex Nov 15, 2021, 6:59 PM

#

Oh it's failing linting lol

molten perch Nov 15, 2021, 7:00 PM

#

Yeah it should be postgresql. 😄

vale ibex Nov 15, 2021, 7:01 PM

#

Eh?

#

Where did I miss that lol

molten perch Nov 15, 2021, 7:01 PM

#

thorny obsidian 👉 👈 ... but if D0rs4n is blocked then I can maybe ~~con~~ convince him to do a...

Another event PR? 😏

thorny obsidian Nov 15, 2021, 7:01 PM

#

peeerhaps another AoC one that shouldn't be too bad???

molten perch Nov 15, 2021, 7:02 PM

#

vale ibex Where did I miss that lol

https://github.com/python-discord/api/blob/main/.github/workflows/lint-test.yml#L27
That's just a bogus value, will be changed in my PR. But your changed schema is refusing to accept this.

stable mountainBOT Nov 15, 2021, 7:02 PM

#

.github/workflows/lint-test.yml line 27

DATABASE_URL: postgres://pysite:pysite@postgres:5432/pysite```

molten perch Nov 15, 2021, 7:02 PM

#

thorny obsidian peeerhaps another AoC one that shouldn't be too bad???

Yeah, sure. It'll take quite a long time to get somehow my Reminder PR merged 😄

thorny obsidian Nov 15, 2021, 7:03 PM

#

sir-lancebot#325

dusky shoreBOT Nov 15, 2021, 7:03 PM

#

GitHub

IssueOpen Personal stats with something like !aoc mystats

molten perch Nov 15, 2021, 7:03 PM

#

Oh, I see. It was not completed during October. 😄

thorny obsidian Nov 15, 2021, 7:03 PM

#

yeaaaaah

vale ibex Nov 15, 2021, 7:04 PM

#

molten perch https://github.com/python-discord/api/blob/main/.github/workflows/lint-test.yml#...

Ahhh Yea didn't think of checking there, I'll sort it after dinner if you don't get there first 😅

molten perch Nov 15, 2021, 7:04 PM

#

vale ibex Ahhh Yea didn't think of checking there, I'll sort it after dinner if you don't ...

I'll wait for you, this way I can approve it 😎

molten perch Nov 15, 2021, 7:07 PM

#

thorny obsidian yeaaaaah

I see, last time I checked my session cookies did not work. Might have been a temporary problem will check.
So, I guess I can use the same dataset like the last time? 😄
(btw. How's the point system look like in AoC? 5 points each completed star? )

thorny obsidian Nov 15, 2021, 7:08 PM

#

molten perch I see, last time I checked my session cookies did not work. Might have been a te...

Wellllllllllll, that's where it gets a bit complicated to calculate

#

For N users, the first user to get each star gets N points, the second gets N-1, and the last gets 1

#

So if you have 100 people, 100 points is the max. If you have 200 people, 200 points is the max. It varies per day.

#

As people complete them, it changes how many points

#

which does give me an idea for the very end, recalculating points but only taking into account people who have completed all days

molten perch Nov 15, 2021, 7:12 PM

#

Just a quick question.
https://adventofcode.com/2019/leaderboard
Aren't those the points on the left? 😄

thorny obsidian Nov 15, 2021, 7:12 PM

#

Mhm, but the global leaderboard operates differently than the private ones

#

Global only cares about the first 100 people who finish for each day. Those people get points, everyone else gets 0

#

It's also why AoC (and subsequently us) have a hard "no spoilers until global is filled" policy

molten perch Nov 15, 2021, 7:14 PM

#

I see, then I guess the issue description is wrong.
It says that you can just find yourself by searching for it on the site with CTRL+F

gritty wind Nov 15, 2021, 7:14 PM

#

You can look on the private leaderboards which do work like that

thorny obsidian Nov 15, 2021, 7:14 PM

#

So that issue is old enough that that's when we had a single community leaderboard

#

With multiple private leaderboards you can no longer do the ctrl+f

molten perch Nov 15, 2021, 7:20 PM

#

thorny obsidian With multiple private leaderboards you can no longer do the ctrl+f

It seems like that the scores are automatically computed.
https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/events/advent_of_code/_helpers.py#L141:L148
I might be wrong, but that seems to be correct.

stable mountainBOT Nov 15, 2021, 7:20 PM

#

bot/exts/events/advent_of_code/_helpers.py lines 141 to 148

    sorted_result = sorted(results, key=operator.attrgetter("completion_time"))
    for rank, star_result in enumerate(sorted_result):
        leaderboard[star_result.member_id]["score"] += max_score - rank

# Since dictionaries now retain insertion order, let's use that
sorted_leaderboard = dict(
    sorted(leaderboard.items(), key=leaderboard_sorting_function, reverse=True)
)```

thorny obsidian Nov 15, 2021, 7:21 PM

#

molten perch It seems like that the scores are automatically computed. https://github.com/pyt...

mhm! Ves has already done the score calculation and it recalculates each time the command is called. The !aoc mystats or whatever can just use the sorted leaderboard and provide some of that info in a nicely formatted way

vale ibex Nov 15, 2021, 7:21 PM

#

Fixed the lints

molten perch Nov 15, 2021, 7:23 PM

#

thorny obsidian mhm! Ves has already done the score calculation and it recalculates each time th...

It could be also a solution, to not create a distinct command but an argument that'll format the leadearboard like

You: x y
1st: x y
2nd: x y

That's just an idea. 😄

molten perch Nov 15, 2021, 7:23 PM

#

vale ibex Fixed the lints

Thank you! 😄

vale ibex Nov 15, 2021, 7:23 PM

#

<@&409416496733880320> I request your seal of approval on api#29

dusky shoreBOT Nov 15, 2021, 7:23 PM

#

GitHub

PROpen Move to asyncpg instead of psycopg

thorny obsidian Nov 15, 2021, 7:23 PM

#

molten perch It could be also a solution, to not create a distinct command but an argument th...

mmmm, not sure I'm getting. Could you show an example?

green oriole Nov 15, 2021, 7:25 PM

#

yessss

vale ibex Nov 15, 2021, 7:26 PM

#

@patent pivot Any objections to me update the review policy in api so it uses the default?

#

well it's pushed now anyway

#

we can revert if he says otherwise

gritty wind Nov 15, 2021, 7:26 PM

#

It would mean more reviews per PR, no?

vale ibex Nov 15, 2021, 7:26 PM

#

but it won't take affect until it's in main

molten perch Nov 15, 2021, 7:27 PM

#

thorny obsidian mmmm, not sure I'm getting. Could you show an example?

Sure, so... You request the scoreboard, and you provide a parameter like my_stats and 1.
And it'll format the output accordingly.

----------------------------------------------------------
(You) 21 | Xy #112312                | 95
       1 | Anonymous #500370         | 123
       2 | Mushinako                 | 121
       3 | Square789                 | 120

(Sorry I edited this by hand)

gritty wind Nov 15, 2021, 7:27 PM

#

The default is 1 staff and 1 contrib, so like you’d just increase it

vale ibex Nov 15, 2021, 7:28 PM

#

Ah yea makes sense

#

I've dropped that commit

#

should be mergable after lint pases

molten perch Nov 15, 2021, 7:30 PM

#

Nah, we're fine. :3

vale ibex Nov 15, 2021, 7:30 PM

#

well two of them are draft lol

molten perch Nov 15, 2021, 7:32 PM

#

vale ibex well two of them are draft lol

Is creating an init.sql and mount the volumes for them, a good way for creating the test database?
I had some problems with raw SQL queries. (I spent about an hour with them, and in the end the problem turned out to be an "unurlsplitted" url passed into the engine. -_-)

#

Which projects is this?

#

Yeah, cool.
So for now issue this command flake8 --config=tox.ini

vale ibex Nov 15, 2021, 7:37 PM

#

molten perch Is creating an init.sql and mount the volumes for them, a good way for creating...

yea, that's fine, it's how we do it on site

patent pivot Nov 15, 2021, 7:38 PM

#

vale ibex <@!165023948638126080> Any objections to me update the review policy in api so i...

no opposition

molten perch Nov 15, 2021, 7:38 PM

#

vale ibex yea, that's fine, it's how we do it on site

Yeah, but how do we include it in the github.yaml?

#

Sorry, github actions.

vale ibex Nov 15, 2021, 7:38 PM

#

run it with docker in lint

#

https://github.com/python-discord/site/blob/main/.github/workflows/lint-test.yaml#L42-L43

stable mountainBOT Nov 15, 2021, 7:38 PM

#

.github/workflows/lint-test.yaml lines 42 to 43

- name: Run database using docker-compose
  run: docker-compose run -d -p 7777:5432 --name pydis_web postgres```

vale ibex Nov 15, 2021, 7:39 PM

#

Just need to update in lint too DATABASE_URL: postgresql+asyncpg://pysite:pysite@localhost:7777/pysite

molten perch Nov 15, 2021, 7:39 PM

#

Oh.. I actually went defining a service and such, since it was in the file. But that seems way easier.
I'll add it, and push my PR.

vale ibex Nov 15, 2021, 7:40 PM

#

rule 47 of coding, there's a 95% chance someone has already solved the issue you are seeing 😛

molten perch Nov 15, 2021, 7:44 PM

#

I'll keep that in mind 😂

#

I have just rebased my branch, I hope everything's alright 😂

thorny obsidian Nov 15, 2021, 7:53 PM

#

molten perch Sure, so... You request the scoreboard, and you provide a parameter like `my_sta...

oh cute, yeah I like that. Is you just call my_stats or whatever would it compute it for all the days?

molten perch Nov 15, 2021, 7:54 PM

#

I'm not sure. I've gotta check it out.

#

Yeah, it seems so. The code iterates through the sorted result, and just assigns a score to a member in leaderboard

#

I did too, conflicts are meant to be (re)solved lemon_fingerguns_shades

#

Yeah, it's a new line

gritty wind Nov 15, 2021, 8:05 PM

#

It doesn’t matter, pick either, relock, and push

#

Lock files weren’t made to be handled by humans

#

You’re more likely to break it if you try to manually resolve it tbh

vale ibex Nov 15, 2021, 8:09 PM

#

just do git checkout --theirs path/to/file

#

rather than manually fixing each line

molten perch Nov 15, 2021, 8:11 PM

#

Also, just a quick question.
Since, sqlalchemy async is quite new, I had to use a source for setting up the tests, the one that Chris sent (https://rogulski.it/blog/sqlalchemy-14-async-orm-with-fastapi/#tests) Do I have to worry about licensing or something?
(Pardon my question, I'm not good with licenses)

brazen charm Nov 15, 2021, 8:15 PM

#

gritty wind You’re more likely to break it if you try to manually resolve it tbh

you can't manually resolve it because of the hash

molten perch Nov 15, 2021, 9:09 PM

#

@thorny obsidian
There seems to be a problem here..
bot.exts.events.advent_of_code._helpers | ERROR | It seems like the fallback cookie has expired! I can't use my session cookie anymore. :/

thorny obsidian Nov 15, 2021, 9:10 PM

#

uhhhh dev tools are disabled at my work, but I can get you a new one .. WAIT

#

YOU'RE STAFF NOW

#

Just join the staff board

green oriole Nov 15, 2021, 9:10 PM

#

is the year correctly set?

#

or just.. do that lmao

thorny obsidian Nov 15, 2021, 9:10 PM

#

If you join the staff board you can grab your own session cookie

molten perch Nov 15, 2021, 9:10 PM

#

Alright, how do I do that? 😄

thorny obsidian Nov 15, 2021, 9:11 PM

#

give meeee one second and I'll send you the invite

gritty wind Nov 15, 2021, 9:11 PM

#

How and why do you block dev tools 🤔

thorny obsidian Nov 15, 2021, 9:12 PM

#

gritty wind How and why do you block dev tools 🤔

work being work

gritty wind Nov 15, 2021, 9:12 PM

#

Lol

thorny obsidian Nov 15, 2021, 9:12 PM

#

no one ever accused my employer of making sense

molten perch Nov 15, 2021, 9:16 PM

#

molten perch Also, just a quick question. Since, sqlalchemy async is quite new, I had to use ...

Anyways, could someone help me with that? I'm ready to push the API PR, that's the last thing on the list. 😄

green oriole Nov 15, 2021, 9:18 PM

#

Hmm, the code is in a repo with no license

molten perch Nov 15, 2021, 9:20 PM

#

Yeah, that's why I'm not sure. I mean I used it as a source for tests, documentation on that topic is pretty bad

green oriole Nov 15, 2021, 9:21 PM

#

Did you copy code verbatim?

molten perch Nov 15, 2021, 9:22 PM

#

I hope not? 😄
I just followed the logic most of the times. On some places changed on it.

#

I mean it's here: https://github.com/D0rs4n/api/tree/pr/reminderpoints

#

The only thing is the conftest there. That's all.

#

But there are things that are so straightforward you can't change them

green oriole Nov 15, 2021, 9:27 PM

#

Should be fine then I think

molten perch Nov 15, 2021, 9:27 PM

#

Yeah, I guess, I can't see how else I could yield an async httpx client 😄

#

I'll open an issue, just to make sure. 😄 That's the only and easiest way.

ashen isle Nov 15, 2021, 9:52 PM

#

@static canyon i implemented the suggestions from the thing. you weren't originally a reviewer so i can't request your review (😔) ples check it out? 🥺

brisk brook Nov 15, 2021, 9:53 PM

#

gritty wind How and why do you block dev tools 🤔

Google Parent Link does the same

#

It was a real pain because I was doing frontend at the time..

#

Couldn't even Inspect Element 💀

gritty wind Nov 15, 2021, 10:17 PM

#

Maybe try profile = black

#

Where do you have that

dusky shoreBOT Nov 15, 2021, 10:29 PM

#

GitHub

PROpen Make development workflow easier to use

trail pilot Nov 15, 2021, 11:13 PM

#

Hmm, quick question real quick, what do you all think of a command similar to CarlBot's highlight command, where you get a DM if a certain keyword was used

I think it could be useful for people who wanna help out somewhere or read a convo on a certain keyword (say, sockets) and they can customize which channels that would have watched, etc.

thorny obsidian Nov 15, 2021, 11:15 PM

#

We had this proposal in #community-meta and ultimately decided not to

#

I can dig up reasoning from the meeting since I don't think we've closed the issue yet

trail pilot Nov 15, 2021, 11:16 PM

#

thorny obsidian I can dig up reasoning from the meeting since I don't think we've closed the iss...

That would be nice, thanks!

static canyon Nov 15, 2021, 11:38 PM

#

ashen isle <@!442244135840382978> i implemented the suggestions from the thing. you weren't...

!remind 10h this

stable mountainBOT Nov 15, 2021, 11:38 PM

#

Sure thing!

Your reminder will arrive on <t:1637055529:F>!

brisk brook Nov 16, 2021, 12:06 AM

#

trail pilot That would be nice, thanks!

Tl;Dr too much spam at our volume (ratelimits!), there's a potential that too many people try to help at the same time (leading to a poor help experience) and then also how we would moderate what one can highlight.

trail pilot Nov 16, 2021, 12:06 AM

#

Ah, gotcha

fallen patrol Nov 16, 2021, 12:49 AM

#

the worst thing is when multiple changes are made, but only half of them are staged, and then black and flake8 complain

clever wraith Nov 16, 2021, 8:07 AM

#

https://github.blog/2021-10-27-everything-new-from-universe-2021/

The GitHub Blog

Thomas Dohmke

Everything new from Universe 2021 | The GitHub Blog

We’ve shipped more than 20,000 improvements to GitHub in the past year. Here’s a comprehensive overview of what we’re announcing at Universe.

#

I already love the command palette

stable mountainBOT Nov 16, 2021, 9:38 AM

#

static canyon !remind 10h this

It has arrived!

Here's your reminder: this
[Jump back to when you created the reminder](#dev-contrib message)

static canyon Nov 16, 2021, 9:48 AM

#

ashen isle <@!442244135840382978> i implemented the suggestions from the thing. you weren't...

Have just reviewed 👍

cold moon Nov 16, 2021, 9:56 AM

#

@static canyon I think MyPy looks weird, because official name is mypy/Mypy (#dev-log message)

static canyon Nov 16, 2021, 10:00 AM

#

Ah, I thought the name was MyPy

#

Leave it as-is then

#

I'll update my comment

static canyon Nov 16, 2021, 10:15 AM

#

bot#1959 exists now @short snow

dusky shoreBOT Nov 16, 2021, 10:15 AM

#

GitHub

PROpen Add ability to reply to message for !remind

static canyon Nov 16, 2021, 10:15 AM

#

Thanks for the issue 👍

#

I'd been putting that off for a while lol, and it was actually pretty easy

short snow Nov 16, 2021, 10:17 AM

#

yep saw it, will try reviewing soon... same, I was supposed to create it about a month back

static canyon Nov 16, 2021, 10:17 AM

#

:p

brisk brook Nov 16, 2021, 10:32 AM

#

fallen patrol the worst thing is when multiple changes are made, but only half of them are sta...

Hence why I dislike precommit

fallen patrol Nov 16, 2021, 10:36 AM

#

lol i love pre-commit

vale ibex Nov 16, 2021, 12:56 PM

#

Ideally each commit should conform to pre-commit checks. If you really need to have intermediary commits, and you have the intention to fix afterwards, then there's always --no-verify

fallen patrol Nov 16, 2021, 1:10 PM

#

vale ibex Ideally each commit should conform to pre-commit checks. If you really need to h...

honestly i try to make all of my commits conform to precommit checks and leave the program in a runnable state 😛 and have all tests fail

#

that doesn't always work out, but that goal means that any bugs will be easier to find which commit and therefore feature caused them

vale ibex Nov 16, 2021, 1:10 PM

#

Yea. That's the preferable option.

fallen patrol Nov 16, 2021, 1:11 PM

#

yepp

#

by aiming for that, its not as bad when it doesn't happen

#

and it makes using git bisect a lot easier

brisk brook Nov 16, 2021, 1:43 PM

#

vale ibex Ideally each commit should conform to pre-commit checks. If you really need to h...

Not all commits are 100% percent runnable, I think forcing you to follow these checks on the code before commiting leads to not commiting as often.

green oriole Nov 16, 2021, 2:11 PM

#

hi

dim pelican Nov 16, 2021, 2:12 PM

#

They are just posting hello in every channel they can find

hoary haven Nov 16, 2021, 3:20 PM

#

ikr right this akarys guy 🙄

dim pelican Nov 16, 2021, 3:22 PM

#

Ohhh thats awesome. I guess they got banned and purged?

static canyon Nov 16, 2021, 3:24 PM

#

dim pelican Ohhh thats awesome. I guess they got banned and purged?

Their messages were purged, yes

dusky shoreBOT Nov 16, 2021, 4:34 PM

#

GitHub

PROpen Make development workflow easier to use

vale ibex Nov 16, 2021, 4:35 PM

#

you (or black) made some changes to the migration files

#

I suggested making those changes here too, so future auto-generated migrations get them automatically https://github.com/python-discord/api/blob/main/alembic/script.py.mako

#

Yea, I had assumed as much

#

We do want that yes. But also, might as well fix the parts we can in the mako file, so that it doesn't need to

#

👌

green oriole Nov 16, 2021, 4:45 PM

#

Why are we using black?

#

Doesn't seem to match with our code style

thorny obsidian Nov 16, 2021, 4:46 PM

#

Legacy decision, Seb added it to the repo awhile ago

green oriole Nov 16, 2021, 4:47 PM

#

Do we still want it?

short snow Nov 16, 2021, 4:47 PM

#

for migrations.. I had like to have it... it keeps them formatted otherwise you get them all in single line with no indentation. It could be manually done also though, as the initial migrations is done and other changes are going to be small ones

thorny obsidian Nov 16, 2021, 4:48 PM

#

I don't think it really meshes, since we're planning on using API in conjunction with site and bot. That's going to be annoying to remember that just one service uses black and the others don't

green oriole Nov 16, 2021, 4:48 PM

#

I would personally not even lint migrations, but that's another problem I think

molten perch Nov 16, 2021, 4:49 PM

#

green oriole I would personally not even lint migrations, but that's another problem I think

I agree with that, migrations are not something that should be looked at in my personal opinion.

short snow Nov 16, 2021, 4:49 PM

#

some write migrations on their own... that includes me, yes.. I didn't know we can auto generate them and now just write it on my own

green oriole Nov 16, 2021, 4:49 PM

#

But I think we should be either yeeting black now or never do it

#

Hey @hardy gorge, what do you think about whenever we should keep black in the api or not?

molten perch Nov 16, 2021, 4:50 PM

#

I don't think we should write migrations by hand.
And I'm strongly against implementing such a process.

hardy gorge Nov 16, 2021, 4:50 PM

#

green oriole Hey <@336843820513755157>, what do you think about whenever we should keep black...

I'm strongly in favour of having black in all of our projects, if that answers your question.

green oriole Nov 16, 2021, 4:50 PM

#

There are some decent reasons to add some python code to migration

thorny obsidian Nov 16, 2021, 4:50 PM

#

(But pls, from a new contributor standpoint, it's awkward when 3 services that are supposed to talk to each other don't use the same linting tools)

hardy gorge Nov 16, 2021, 4:51 PM

#

I really like having black, even if some of the style decisions it makes are different to my personal preference. I really hate spending time arguing over this or that style.

#

It's non-constructive.

short snow Nov 16, 2021, 4:51 PM

#

I agree with seb here

green oriole Nov 16, 2021, 4:51 PM

#

Sometimes you have to actually migrate the data manually

molten perch Nov 16, 2021, 4:51 PM

#

green oriole There are some decent reasons to add some python code to migration

Indeed, but the core part of the migration is auto-generated.

green oriole Nov 16, 2021, 4:51 PM

#

Yup

molten perch Nov 16, 2021, 4:51 PM

#

If you have to modify something, then feel free to do so, but I'm not gonna remove auto-generation in favour of linting 😄

short snow Nov 16, 2021, 4:52 PM

#

huh? the inital migration is already linted

green oriole Nov 16, 2021, 4:52 PM

#

Maybe we could have a core dev + contrib discussion over using black in our projects? I think we shouldn't have a disparity in our projects

molten perch Nov 16, 2021, 4:52 PM

#

short snow huh? the inital migration is already linted

Yes, cool. I know, I did it.

green oriole Nov 16, 2021, 4:52 PM

#

molten perch If you have to modify something, then feel free to do so, but I'm not gonna remo...

Agreed

thorny obsidian Nov 16, 2021, 4:52 PM

#

(I don't care what y'all use, my concern is that it should be consistent for different repos that communicate)

short snow Nov 16, 2021, 4:52 PM

#

then, why would we need to modify it again?

molten perch Nov 16, 2021, 4:53 PM

#

short snow then, why would we need to modify it again?

I meant new migrations, not the current ones

green oriole Nov 16, 2021, 4:53 PM

#

short snow then, why would we need to modify it again?

Wasn't your point about running black on migrations to not have to care about linting?

short snow Nov 16, 2021, 4:53 PM

#

yeah and we did that for the initial migrations

#

i thought he was talking about those, not the new oens

molten perch Nov 16, 2021, 4:54 PM

#

No, we're talking about future migrations. (Or migrations ported over from site)

#

I guess we can add it, but we still have time.
We have to migrate the endpoints and the test suite first, there shouldn't be too much migrations til' then. 😄

short snow Nov 16, 2021, 4:59 PM

#

just add it as alembic hook, so they come auto formatted.. we won't need to run manually and edit them, like doublevcodes said

molten perch Nov 16, 2021, 4:59 PM

#

Sure, feel free to open an issue, and maybe later on a PR.

short snow Nov 16, 2021, 5:00 PM

#

doublevcodes is alreayd doing that on his PR

#

that;s what you meant by "make alembic do it" right? Or i got it wrong

thorny obsidian Nov 16, 2021, 5:02 PM

#

@molten perch consider yourself assigned

molten perch Nov 16, 2021, 5:03 PM

#

Alright, I can assign myself if you don't mind 😂

thorny obsidian Nov 16, 2021, 5:03 PM

#

please do, I'm not logged into my personal github at work so I can't do it until I get home

molten perch Nov 16, 2021, 5:04 PM

#

Alright, so is the idea which I proposed yesterday fine with you? (The list where (You)'re the first and then it lists the actual top scorers)

thorny obsidian Nov 16, 2021, 5:05 PM

#

molten perch Alright, so is the idea which I proposed yesterday fine with you? (The list wher...

yup!

molten perch Nov 16, 2021, 5:05 PM

#

Alright, I'll give it a try this weekend, shouldn't be so hard! 😄

short snow Nov 16, 2021, 5:05 PM

#

IIRC there is already something like mystats on the AOC site

#

https://adventofcode.com/2020/leaderboard/self

thorny obsidian Nov 16, 2021, 5:07 PM

#

short snow IIRC there is already something like mystats on the AOC site

that doesn't work with our multiple leaderboards

short snow Nov 16, 2021, 5:08 PM

#

Ah yeah, but could the format be something like that?

thorny obsidian Nov 16, 2021, 5:10 PM

#

That could probably be a thing for a future iteration. I like to see how people use the command and what kind of features they're after

#

Also we're 2 weeks away, so I want to keep the scope small since we're so close

short snow Nov 16, 2021, 5:10 PM

#

👍 right, is there a basic mock/write-up on the current proposed format

thorny obsidian Nov 16, 2021, 5:11 PM

#

I think somewhere above in this channel

molten perch Nov 16, 2021, 5:12 PM

#

molten perch Sure, so... You request the scoreboard, and you provide a parameter like `my_sta...

I think that's it. 😄

#

I edited that by hand, don't mind the indentation.

short snow Nov 16, 2021, 5:12 PM

#

uhh so it would jsut put your score on the top and rest remains the same?

molten perch Nov 16, 2021, 5:12 PM

#

Indeed.

#

Small, simple idea, yet useful. 😄

short snow Nov 16, 2021, 5:14 PM

#

rather than that, could we jsut add it to as the 11th line to the lb command?

molten perch Nov 16, 2021, 5:29 PM

#

Well, what difference would it make? This way they spot it easily.

short snow Nov 16, 2021, 5:31 PM

#

They would spot easily on both cases imo... The embed is only 10 lines long

thorny obsidian Nov 16, 2021, 5:32 PM

#

I don't think which one really matters, I'll just go with what d0rs4n prefers

short snow Nov 16, 2021, 5:34 PM

#

The command is just gonna be a duplicate... But yeah for now it's fine as we aoc is in 2 weems

molten perch Nov 16, 2021, 5:37 PM

#

Lucky, that I do not plan to create a separate command. (Read the description of my message I sent above)

short snow Nov 16, 2021, 5:39 PM

#

Mhm I didn't read that, it's ok then 👌

#

My eyes directly went on the codeblock

#

Yeah, add black as alembic hooks

short snow Nov 16, 2021, 5:41 PM

#

short snow Yeah, add black as alembic hooks

Just wait for some1 to confirm still

#

👍

dusky shoreBOT Nov 16, 2021, 10:49 PM

#

GitHub

PROpen Make development workflow easier to use

gritty wind Nov 17, 2021, 12:15 AM

#

How do we create new filterlists 🤔

#

Ooh cool, they're hardcoded into the site models

short snow Nov 17, 2021, 2:36 AM

#

yeah

green oriole Nov 17, 2021, 7:42 AM

#

gritty wind Ooh cool, they're hardcoded into the site models

First time I see someone saying oh cool at something hard-coded haha

gritty wind Nov 17, 2021, 7:43 AM

#

It makes it easy, cuz I can just search for one of the other tokens and duplicate it

fallen patrol Nov 17, 2021, 7:44 AM

#

green oriole First time I see someone saying oh cool at something hard-coded haha

i go so far to not hardcode stuff

green oriole Nov 17, 2021, 7:44 AM

#

Can we get url unfurling before a new filter list? akarys_pleading

fallen patrol Nov 17, 2021, 7:44 AM

#

unfurling?

static canyon Nov 17, 2021, 7:46 AM

#

fallen patrol unfurling?

bit.ly/xxx --> the actual url

#

"unfurling" url shorteners

#

There's a bot issue for it but I can't remember the number off the top of my head

fallen patrol Nov 17, 2021, 7:46 AM

#

i mean, that's not going to always work

green oriole Nov 17, 2021, 7:47 AM

#

Yes, it isn't a direct redirect it won't work

fallen patrol Nov 17, 2021, 7:47 AM

#

yeah like this https://rroll.to/3txzi7

Python Discord | Home

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

green oriole Nov 17, 2021, 7:47 AM

#

But if they do end up doing that, fuck it tbh

fallen patrol Nov 17, 2021, 7:48 AM

#

~~perfectly legit link pls click it thanks~~

fallen patrol Nov 17, 2021, 7:49 AM

#

green oriole But if they do end up doing that, fuck it tbh

i'm more thinking about the attack above

#

one thing the first time you go to it and a different the second

gritty wind Nov 17, 2021, 8:19 AM

#

I mean we aren’t trying to solve non-existent problems

#

The unfurl url issue has a very well defined scope internally because we need it for something specific

#

It’s also more or less ready to be pushed, but its 3 PRs, all which need reviewing

#

I’ll probably have xith bully the mod team

cold island Nov 17, 2021, 9:27 AM

#

gritty wind Ooh cool, they're hardcoded into the site models

Merge conflicts 🥲

gritty wind Nov 17, 2021, 9:50 AM

#

What am I conflicting with lmao

#

Either way it’s a one line change, so it’s relatively okay for me to recreate from scratch

cold island Nov 17, 2021, 10:01 AM

#

gritty wind What am I conflicting with lmao

the new schema

#

If we're migrating a chunk of the table it will need an update in the migrations of the other PR

gritty wind Nov 17, 2021, 10:30 AM

#

Ah, I see

#

Well, I already committed another migration like a week ago lol

#

Anyways, I've made site#625 for now, it doesn't need to be merged until the bot PR is ready, and if the other PRs are merged by then, I'd be happy to remake migrations

dusky shoreBOT Nov 17, 2021, 10:32 AM

#

GitHub

PROpen Adds Redirect Filter List

gritty wind Nov 17, 2021, 10:34 AM

#

Btw, while I have you here Zig, what do you think about this

#

I have a utility (separate of the filter itself), which allows you to invoke the unfurling manually through a command

#

Now technically, it's standalone of the filter work, but it's going to be helpful for working with the filter in cases where the filter fails

#

It's ready, so I can either include it in this PR and get it done with, or make a follow up PR so this one doesn't get delayed because of it

vale ibex Nov 17, 2021, 10:58 AM

#

I'm very much in favour of running linting against migrations files. It's code which is reasonable to assume will be looked at to debug issues, and if it's code that needs to be looked at, it should be linted to our standards.

green oriole Nov 17, 2021, 11:02 AM

#

I think we can enforce that the style of those files is reasonable through code reviews, but we shouldn't be strict about it and have the contributor edit the file because of styling

short snow Nov 17, 2021, 11:02 AM

#

why would the contributor edit it because of the styling? Alembic is running black against them so they are already partiallly linted

vale ibex Nov 17, 2021, 11:02 AM

#

Why not? Especially if we can just have black ran against them.

gritty wind Nov 17, 2021, 11:04 AM

#

Ok, just pushed the redirect filter PR, and it auto requested Akarys, joe, and Zig

Perfect

green oriole Nov 17, 2021, 11:06 AM

#

Black doesn't follow our code style though

#

In the case of the API it doesn't really matter I guess

#

@gritty wind about about domain_redirect? :3

#

I would be for simplifying the others, but i think this one should be explicit

gritty wind Nov 17, 2021, 11:08 AM

#

Do you believe redirect is not clear enough? It would require making two more commits on two separate PRs :P

#

I can look at it tonight

green oriole Nov 17, 2021, 11:09 AM

#

700 lines diff dear god

gritty wind Nov 17, 2021, 11:09 AM

#

It’s a biggin

#

And that’s before you consider the worker 🤡

green oriole Nov 17, 2021, 11:09 AM

#

it was supposed to be like 30 lines lmao

gritty wind Nov 17, 2021, 11:09 AM

#

Half of it is tests for the service lol

green oriole Nov 17, 2021, 11:10 AM

#

smhmhmh

cold island Nov 17, 2021, 2:29 PM

#

gritty wind Btw, while I have you here Zig, what do you think about this

"While I have you here", said Scaleios half an hour after I wrote something dogekek

cold island Nov 17, 2021, 2:30 PM

#

gritty wind It's ready, so I can either include it in this PR and get it done with, or make ...

Either way seems ok to me, if the functionality is the same

gritty wind Nov 17, 2021, 3:49 PM

#

Time is relative to my sleep schedule

green oriole Nov 17, 2021, 5:10 PM

#

Didn't know time could go backward, because that's really how I feel sometimes with my sleep schedule

short snow Nov 17, 2021, 5:21 PM

#

Nice, black on bot!

thorny obsidian Nov 17, 2021, 5:23 PM

#

Just a test, not certain we'll keep it yet

short snow Nov 17, 2021, 5:25 PM

#

Welp, celebrated too early

austere hornet Nov 17, 2021, 5:35 PM

#

Lol

patent pivot Nov 17, 2021, 5:35 PM

#

lol, yeah, it was just a "wonder what this'll do" thing

vale ibex Nov 17, 2021, 5:42 PM

#

This is just to see what the diff would look like and whether we would want some of these changes.

patent pivot Nov 17, 2021, 5:43 PM

#

lol

vale ibex Nov 17, 2021, 5:43 PM

#

I was hoping the PR description would be enough lol

patent pivot Nov 17, 2021, 5:43 PM

#

any further formatting decisions will be published as security advisories from private forks

#

CVE-2021-69420: Python Discord Bot was missing a trailing comma

vale ibex Nov 17, 2021, 5:43 PM

#

with an accompanying CVE

green oriole Nov 17, 2021, 5:50 PM

#

Lmfao

fallen patrol Nov 17, 2021, 6:42 PM

#

gritty wind It’s a biggin

you call 700 lines big?? wut

gritty wind Nov 17, 2021, 6:44 PM

#

See the linked PRs

#

But yeah, 300 lines of tests is a death sentence for a PR

fallen patrol Nov 17, 2021, 6:45 PM

#

👀

#

since when

gritty wind Nov 17, 2021, 6:46 PM

#

Since we’ve been doing tests on our repos

fallen patrol Nov 17, 2021, 6:46 PM

#

i guess i need to get better at smaller prs....

gritty wind Nov 17, 2021, 6:46 PM

#

The silence PR was an eye opener for me

#

I opened it when I joined staff

#

And merged it as an admin

fallen patrol Nov 17, 2021, 6:46 PM

#

iirc I have a 600 line pr of just tests

#

because previously I did not write tests

#

(not for pydis)

clever wraith Nov 17, 2021, 7:36 PM

#

Lmao

#

Was the silence PR that big

#

510 lines, not that bad

#

Wait, that one is by Num

gritty wind Nov 17, 2021, 7:50 PM

#

Bot#1297

dusky shoreBOT Nov 17, 2021, 7:50 PM

#

GitHub

PRMerged Implements Voice Channel Muting

clever wraith Nov 17, 2021, 7:51 PM

#

Oh, voice chat muting

#

Is it even used, heh

#

What the heck +600 of tests

fresh rock Nov 17, 2021, 8:06 PM

#

Hello, sorry for lame question. I wanted to play around wuith sir lancebot -> I created a discord server, created a bot, cloned a project, run docker-compose build and then up. Bot got activated but it doesnt respond to comments. I got such error msg when activating bot.

Traceback (most recent call last):
  File "/bot/bot/bot.py", line 134, in send_log
    devlog = await self.fetch_channel(constants.Channels.devlog)
  File "/usr/local/lib/python3.9/site-packages/discord/client.py", line 1491,  in fetch_channel
    data = await self.http.get_channel(channel_id)
  File "/usr/local/lib/python3.9/site-packages/discord/http.py", line 329, in request
    raise Forbidden(response, data)
discord.errors.Forbidden: 403 Forbidden (error code: 50001): Missing Access

#

Is this something wrong with .env ? Missing tokens?

thorny obsidian Nov 17, 2021, 8:08 PM

#

It looks like your bot doesn't have permissions, what permissions do you have on the bot role?

fresh rock Nov 17, 2021, 8:10 PM

#

need to check, brb

clever wraith Nov 17, 2021, 8:10 PM

#

I believe the error here is you didn't change the ID of the dev log channel

#

Because a fetch will only fail if you don't have read permissions over that channel, which the bot most probably have

fresh rock Nov 17, 2021, 8:13 PM

#

Bot permissions integer: 0 😅

#

So i should add read permissions for my channel only, right?

#

CHANNEL_DEVLOG variable in .env, right?

#

ok, I need to rethink that topic...

#

nice, got it working

#

now one more question:
bot reacts to command after ' (single quote) sign instead of . (dot) sign. Can I somehow change/fix it ?

clever wraith Nov 17, 2021, 8:38 PM

#

that's.. interesting

#

what does your env file look like?

dim pelican Nov 17, 2021, 8:39 PM

#

(minus the token)

fresh rock Nov 17, 2021, 8:40 PM

#

Im on it

#

30sec

#

omg

#

there is a PREFIX variable 😅

#

im sorry guys, learning is painful and sometimes teaching is even more painful

dim pelican Nov 17, 2021, 8:44 PM

#

Don't be sorry about it 👍

clever wraith Nov 17, 2021, 8:50 PM

#

there is no stupid question!

clever wraith Nov 17, 2021, 10:31 PM

#

wat

short snow Nov 17, 2021, 10:42 PM

#

https://github.com/python-discord/bot/pull/1446#pullrequestreview-809071287 someone merge

austere hornet Nov 17, 2021, 10:46 PM

#

That doesn't belong here (I'm sure you know that, but just in case)

#

K

brisk brook Nov 17, 2021, 10:50 PM

#

short snow https://github.com/python-discord/bot/pull/1446#pullrequestreview-809071287 some...

Oops I think I removed requests for reviews instead of adding them 🤔 😅

#

#

I am confusion

#

It seems like @green oriole, @cold moon and @sharp timber have required changes that are blocking the merge right now.

thorny obsidian Nov 17, 2021, 10:55 PM

#

The required changes aren't blocking it, you just need a core dev to actually press the button

brisk brook Nov 17, 2021, 10:57 PM

#

Oh you're right, hmm, I am probably gonna stop using the GithHub app honestly.

The only benefit is being able to comment on multiple lines lmao

vale ibex Nov 17, 2021, 10:58 PM

#

You can comment on multiple lines in github web

#

Just click and drag on the line numbers and then click the + on the last line

short snow Nov 17, 2021, 10:59 PM

#

chris 🥺

brisk brook Nov 17, 2021, 10:59 PM

#

brisk brook Nov 17, 2021, 10:59 PM

#

vale ibex Just click and drag on the line numbers and then click the + on the last line

Not on phone, that just scrolls

short snow Nov 17, 2021, 10:59 PM

#

nope...i use the web to review

brisk brook Nov 17, 2021, 11:00 PM

#

Besides, it fucks up indents with word wrap like what the-

#

#

Like bruh

#

lemon_wumpus

short snow Nov 17, 2021, 11:01 PM

#

you can disable that, its somewhere in the settings

brisk brook Nov 17, 2021, 11:05 PM

#

Okay okay okay let me see

#

Oh my God I am so stupid smh

green oriole Nov 18, 2021, 7:35 AM

#

brisk brook

Nag that's a UI bug, you don't have write perms onto main, you cannot merge

short snow Nov 18, 2021, 10:12 AM

#

someone merge enhance incidents PR 🥺

green oriole Nov 18, 2021, 11:38 AM

#

Dismissed my review

cold island Nov 18, 2021, 12:04 PM

#

Need to test it again before I merge

#

Unless someone else wants to

cursive relic Nov 18, 2021, 1:16 PM

#

can the @stable mountain bot control slowmode by itself, without the slowmode command being ran?

#

like if the chat is really fast, can it make slowmode higher automatically

brisk brook Nov 18, 2021, 1:43 PM

#

That's not a current feature

#

I know it has been discussed

green oriole Nov 18, 2021, 1:46 PM

#

we have some stats for it now

cold island Nov 18, 2021, 1:53 PM

#

My next pet project if I ever finish with the filters lol

short snow Nov 18, 2021, 2:52 PM

#

the new filters system?

cold island Nov 18, 2021, 3:12 PM

#

yeah

green oriole Nov 18, 2021, 3:39 PM

#

Hello folks! Here is a good first issue for y'all, if somebody is looking to get started with the bot, this would be a good jumping point! https://github.com/python-discord/bot/issues/1963

GitHub

Clean: _delete_found doesn't handle NotFound · Issue #1963 · python...

The _delete_found doesn't properly handle the NotFound exception, a contextlib.suppress block should be added to prevent the exception from propagating. Sentry Issue: BOT-1QH NotFound: 404 ...

short snow Nov 18, 2021, 3:40 PM

#

it would be good to include the additional frame which was skipped.

#

and you could probably add good first issue

green oriole Nov 18, 2021, 3:40 PM

#

it has good first issue

#

the last frame isn't relevant, it is the d.py dispatcher

short snow Nov 18, 2021, 3:42 PM

#

umm did you just add it pithink I couldn't see it earlier... the last frame would have included the line (L408 prob) on which the deletion happens which may be helpful

clever wraith Nov 18, 2021, 3:53 PM

#

no, like every command traceback the first frame is in discord.exts.commands.core

#

... that's so dumb, does the docs mention that

vale ibex Nov 18, 2021, 4:02 PM

#

Ah, it seems it's not part of Messageable

#

!d discord.TextChannel.delete_messages

stable mountainBOT Nov 18, 2021, 4:03 PM

#

discord.TextChannel.delete\_messages


await delete_messages(messages)```
This function is a [*coroutine*](https://docs.python.org/3/library/asyncio-task.html#coroutine).

Deletes a list of messages. This is similar to [`Message.delete()`](https://discordpy.readthedocs.io/en/master/api.html#discord.Message.delete "discord.Message.delete") except it bulk deletes multiple messages.

As a special case, if the number of messages is 0, then nothing is done. If the number of messages is 1 then single message delete is done. If it’s more than two, then bulk delete is used.

You cannot bulk delete more than 100 messages or messages that are older than 14 days old.

You must have the [`manage_messages`](https://discordpy.readthedocs.io/en/master/api.html#discord.Permissions.manage_messages "discord.Permissions.manage_messages") permission to use this.

clever wraith Nov 18, 2021, 4:03 PM

#

https://discordpy.readthedocs.io/en/stable/api.html#discord.TextChannel.delete_messages

#

it does..

#

that's so stupid

molten perch Nov 18, 2021, 6:55 PM

#

Hey!
I get this linting error when trying to lint sir lancebot

And if I try to fix it isort will revert it 😄
Is there something that I don't know of, regarding this issue? 😄

vale ibex Nov 18, 2021, 7:07 PM

#

run poetry install --remove-untracked

#

looks like flake8-import-order is still installed in your env

molten perch Nov 18, 2021, 7:07 PM

#

Oh, true. Haven't worked on lancebot for a while. My apologies. 😄

vale ibex Nov 18, 2021, 7:08 PM

#

No worries 😄

molten perch Nov 18, 2021, 8:51 PM

#

Here we go again: sir-lancebot#949 😂
I would appreciate if someone could give it a look, it's a fairly easy PR.
(Hopefully)

dusky shoreBOT Nov 18, 2021, 8:51 PM

#

GitHub

PROpen Introduce command changes in the AoC Cog

brazen charm Nov 18, 2021, 9:57 PM

#

bot#1663 also needs a review if anyone has a larger bit of time

dusky shoreBOT Nov 18, 2021, 9:57 PM

#

GitHub

PROpen Add tag groups and in file metadata

fallen patrol Nov 19, 2021, 1:24 AM

#

uhm @vale ibex since when do workflows on the .github repo run on every repo

#

cc .github#9

dusky shoreBOT Nov 19, 2021, 1:24 AM

#

GitHub

PROpen Tagger workflow

fallen patrol Nov 19, 2021, 1:25 AM

#

I've looked into that before and they've never run on all repos

#

there's some apps that do it, but nothing native

#

unless, of course, that's changed recently

patent pivot Nov 19, 2021, 1:26 AM

#

https://docs.github.com/en/actions/learn-github-actions/reusing-workflows#creating-a-reusable-workflow

GitHub Docs

Reusing workflows - GitHub Docs

#

we might need to move them into .github/workflows, but yes, it's a thing.

fallen patrol Nov 19, 2021, 1:27 AM

#

patent pivot https://docs.github.com/en/actions/learn-github-actions/reusing-workflows#creati...

so there would still need to be an action added to every repo that wants to use it

patent pivot Nov 19, 2021, 1:27 AM

#

yes, but we're not ready to roll this out anyway lol

fallen patrol Nov 19, 2021, 1:27 AM

#

gotcha, should probably be detailed in the pr lol

patent pivot Nov 19, 2021, 1:28 AM

#

it's fine as is

#

we're altering some policy, we'll publish that policy when we want to

#

i don't think we need to document the nitty gritty of rollout details on our .github repository, it's just unnecessary work

#

once we have policy in place we'll put it somewhere to explain what the label means

fallen patrol Nov 19, 2021, 4:52 AM

#

hmmmm

#

could the filter worker remove comments from prs before posting them? #black-formatter message

patent pivot Nov 19, 2021, 5:06 AM

#

maybe

#

we’ve had pretty limited success with modification so far, seems discord do some level of validation at their end, but it’s worth a shot. downside is we then have to parse all bodies whiiiiich eh… not sure I want the hassle tbqh

#

it’s an edge case

green oriole Nov 19, 2021, 6:55 AM

#

I don't think black is behind a worker anyway

gritty wind Nov 19, 2021, 9:04 AM

#

It is, for more control over what gets posted

green oriole Nov 19, 2021, 9:06 AM

#

oh cool

#

it is behind our usual worker or a custom one?

gritty wind Nov 19, 2021, 9:12 AM

#

It’s the same one

#

Hard coded into the worker

#

https://github.com/python-discord/workers/blob/main/github-filter/src/index.ts#L55

stable mountainBOT Nov 19, 2021, 9:14 AM

#

github-filter/src/index.ts line 55

let isBlackNonMainPush =```

green oriole Nov 19, 2021, 9:15 AM

#

that's cool

cursive relic Nov 19, 2021, 9:55 AM

#

Is there a feature that tells how many times a modmail thread is opened? (by some user)

green oriole Nov 19, 2021, 9:57 AM

#

yes, we can count that using ?logs

cursive relic Nov 19, 2021, 9:59 AM

#

Can I know how many times I have opened a thread?

green oriole Nov 19, 2021, 10:00 AM

#

43 times

cursive relic Nov 19, 2021, 10:01 AM

#

Thats more than I thought 😅

#

Is the @slow bone source that this server uses a open source?

green oriole Nov 19, 2021, 10:02 AM

#

?about

slow boneBOT Nov 19, 2021, 10:02 AM

#

Modmail - About

This is an open source Discord bot that serves as a means for members to easily communicate with server administrators in an organised manner.

Uptime

28d 23h 22m 1s

Latency

101.10 ms

Version

3.10.2

Authors

kyb3r, Taki, fourjr

Hosting Method

DOCKER

Want Modmail in Your Server?

Follow the installation guide on GitHub and join our Discord server!

Support the Developers

This bot is completely free for everyone. We rely on kind individuals like you to support us on Patreon (perks included) to keep this bot free forever!

Project Sponsors

Checkout the people who supported Modmail with command ?sponsors!

green oriole Nov 19, 2021, 10:02 AM

#

It is right there https://github.com/kyb3r/modmail/

GitHub

GitHub - kyb3r/modmail: A feature rich discord Modmail bot

A feature rich discord Modmail bot. Contribute to kyb3r/modmail development by creating an account on GitHub.

#

we have our own fork with CI over at https://git.pydis.com/modmail

cursive relic Nov 19, 2021, 10:04 AM

#

Thx!

short snow Nov 19, 2021, 11:21 AM

#

~~deleted~~

patent pivot Nov 19, 2021, 11:25 AM

#

lol, let's not start advertising stuff in on topic channels

short snow Nov 19, 2021, 11:26 AM

#

yeah 👍

cold island Nov 19, 2021, 11:53 AM

#

@short snow it's merged lemon_happy

#

Thank you for working on it and sticking with it for such a long time

green oriole Nov 19, 2021, 11:54 AM

#

That's the good stuff, thanks jason! pixels_snek_2 partygopher

short snow Nov 19, 2021, 11:55 AM

#

zig I am waiting for your review on modpings 🙃 lol and thanks!

cold island Nov 19, 2021, 11:55 AM

#

That might take a while, there's a bit of a queue 😅

vale ibex Nov 19, 2021, 11:55 AM

#

short snow Nov 19, 2021, 11:56 AM

#

👏

#

also we were going to squash merge it ig, atleast that's joe had said

cold island Nov 19, 2021, 11:57 AM

#

Yeah I noticed the amount of commits a moment too late. Not a big deal though

rapid swallow Nov 19, 2021, 11:58 AM

#

vale ibex

wow
!ban @short snow We've received reports that you have worked on incidents enhancement. thank

short snow Nov 19, 2021, 11:58 AM

#

banning and thanking, odd combination, thanks!

austere hornet Nov 19, 2021, 11:59 AM

#

Lmfao

#

Wait why didn't the bot actually ban him

#

?

cold island Nov 19, 2021, 12:00 PM

#

Because it's in the middle of the message

austere hornet Nov 19, 2021, 12:00 PM

#

Ah ok

short snow Nov 19, 2021, 12:17 PM

#

If no one gets to 1964, I will get to it once i get my lance PRs done

#

btw 745 needs core dev approval, bluenix did the first one

green oriole Nov 19, 2021, 1:51 PM

#

no idea what those numbers are

#

what repo is it?

patent pivot Nov 19, 2021, 1:52 PM

#

bot

#

bot#1964

dusky shoreBOT Nov 19, 2021, 1:52 PM

#

GitHub

IssueOpen Unfurl Discord links in more places

patent pivot Nov 19, 2021, 1:52 PM

#

not sure about 745

green oriole Nov 19, 2021, 1:53 PM

#

lol @vale ibex they fixed links on Android like 3 days ago, they work pretty well now

#

I'm a bit eeeeehhh on that issue, but if people want it why not

#

sir-lancebot#745 maybe?

dusky shoreBOT Nov 19, 2021, 1:54 PM

#

GitHub

PROpen Add logic for preserving unloaded Cogs.

patent pivot Nov 19, 2021, 2:04 PM

#

green oriole lol <@!126811506632294400> they fixed links on Android like 3 days ago, they wor...

cc @crude gyro to confirm, was raised in admins that they didn't work

#

oh you already pinged in core

brisk brook Nov 19, 2021, 2:04 PM

#

green oriole I'm a bit eeeeehhh on that issue, but if people want it why not

I think it's good, even if links work. They take you out of the conversation

short snow Nov 19, 2021, 2:06 PM

#

yeah those are the links, sorry forgot to include the repo

green oriole Nov 19, 2021, 2:17 PM

#

that's cool

short snow Nov 19, 2021, 2:18 PM

#

yes, thanks to bluenix for bringing that up - thread support

thorny obsidian Nov 19, 2021, 2:25 PM

#

green oriole lol <@!126811506632294400> they fixed links on Android like 3 days ago, they wor...

I still have issues though pithink

green oriole Nov 19, 2021, 2:49 PM

#

thorny obsidian I still have issues though <:pithink:652247559909277706>

Android 12 + discord beta up to date?

vale ibex Nov 19, 2021, 2:50 PM

#

Yea, that middle bit it the sticking point, it's currently in beta

#

so not "fixed" yet

thorny obsidian Nov 19, 2021, 2:51 PM

#

I don't count anything in beta as being an actual fix

green oriole Nov 19, 2021, 3:22 PM

#

well, at least a fix is coming\™️ soon\™️

tight mica Nov 19, 2021, 3:35 PM

#

patent pivot cc <@!95872159741644800> to confirm, was raised in admins that they didn't work

yes i completely agree with you

#

SIKE#

molten perch Nov 19, 2021, 5:11 PM

#

I managed to patch the issue in this PR
sir-lancebot#949 , so I would love to have some reviews on it. 😄

dusky shoreBOT Nov 19, 2021, 5:11 PM

#

GitHub

PROpen Introduce command changes in the AoC Cog

green oriole Nov 19, 2021, 5:14 PM

#

!remind 14h review after you get your freshly cutted hair

stable mountainBOT Nov 19, 2021, 5:14 PM

#

I'll allow it.

Your reminder will arrive on <t:1637392469:F>!

thorny obsidian Nov 19, 2021, 5:34 PM

#

I'll review it when I get home in like ~6 hours

fallen patrol Nov 19, 2021, 5:40 PM

#

patent pivot cc <@!95872159741644800> to confirm, was raised in admins that they didn't work

it works for me on android 100% by the second time

austere hornet Nov 19, 2021, 5:51 PM

#

green oriole !remind 14h review after you get your freshly cutted hair

Lol

trim cradle Nov 19, 2021, 6:31 PM

#

Disregarding what a bad boy in need of punishment I am for having all these mute infractions, there are too many new lines in here.

#

You could drive a truck between "Reason:" and "If you would like to discuss or appeal ..."

brisk brook Nov 19, 2021, 6:36 PM

#

I think that we could place that in the footer instead?

vale ibex Nov 19, 2021, 6:50 PM

#

because for bans we use a hyper link

#

I suggest just removing a new line

fallen patrol Nov 19, 2021, 6:56 PM

#

vale ibex because for bans we use a hyper link

if ban description else footer?

vale ibex Nov 19, 2021, 6:59 PM

#

I don't see the need to have it in two places

#

since we want to remove the new line anyway, for ban embeds

cursive relic Nov 19, 2021, 7:07 PM

#

The bot has feature to link a github issue/pr etc sirlancebot#issuenumber, where could I find the src of it?

dim pelican Nov 19, 2021, 7:07 PM

#

I think it is a webhook

vale ibex Nov 19, 2021, 7:09 PM

#

cursive relic The bot has feature to link a github issue/pr etc `sirlancebot#issuenumber`, whe...

https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/utilities/issues.py

cursive relic Nov 19, 2021, 7:09 PM

#

Ah, thank you!

green oriole Nov 19, 2021, 7:56 PM

#

Hmm since when do we have three line breaks

#

That's a recent change, my last infractions don't have that

#

@vale ibex ban me from watching the TV

vale ibex Nov 19, 2021, 7:59 PM

#

#

bot#1965 🚅

dusky shoreBOT Nov 19, 2021, 8:00 PM

#

GitHub

PROpen Remove unneeded new lines

vale ibex Nov 19, 2021, 8:02 PM

#

green oriole <@126811506632294400> ban me from watching the TV

I'm watching small ant

green oriole Nov 19, 2021, 8:02 PM

#

Oh what is he doing

#

Meh

#

Completing the pokedex

vale ibex Nov 19, 2021, 8:02 PM

#

Speedrunning completing the pokedex on the new pokemon

#

it just came out today

green oriole Nov 19, 2021, 8:02 PM

#

Oh speedrunning lol

#

Why casual plays when you can speedrun

vale ibex Nov 19, 2021, 8:03 PM

#

😄

vale ibex Nov 19, 2021, 8:03 PM

#

dusky shore

psssssssssst @trim cradle

trim cradle Nov 19, 2021, 8:03 PM

#

WHAT

vale ibex Nov 19, 2021, 8:03 PM

#

I FIX

#

YOU APPROVE

trim cradle Nov 19, 2021, 8:03 PM

#

JUST WHAT THE HELL DO YOU WANT

#

I'm at the gym

vale ibex Nov 19, 2021, 8:04 PM

#

Ah

#

well enjoy dem gains

trim cradle Nov 19, 2021, 8:04 PM

#

Sorry that was just the toxic masculinity leaving the body

vale ibex Nov 19, 2021, 8:04 PM

#

lol

trim cradle Nov 19, 2021, 8:39 PM

#

@vale ibex I approved it

#

Thanks!

vale ibex Nov 19, 2021, 8:39 PM

#

trim cradle <@!126811506632294400> I approved it

sus

#

ty

trim cradle Nov 19, 2021, 8:40 PM

#

vale ibex <:sus:779633720965595150>

you're sus

#

don't sus me

austere hornet Nov 19, 2021, 9:21 PM

#

This channel got a bit off topic ngl

clever wraith Nov 19, 2021, 9:57 PM

#

@trim cradle you commented and not approved lol

trim cradle Nov 19, 2021, 9:57 PM

#

clever wraith <@!253696366952316929> you commented and not approved lol

I was too late

clever wraith Nov 19, 2021, 9:57 PM

#

oh right

#

I just saw that

#

nice approval then

trim cradle Nov 19, 2021, 9:57 PM

#

ye

patent pivot Nov 20, 2021, 5:10 AM

#

emacs is so great

rapid igloo Nov 20, 2021, 5:17 AM

#

yus but without evil it's nothing

stable mountainBOT Nov 20, 2021, 7:14 AM

#

green oriole !remind 14h review after you get your freshly cutted hair

It has arrived!

Here's your reminder: review after you get your freshly cutted hair
[Jump back to when you created the reminder](#dev-contrib message)

green oriole Nov 20, 2021, 8:09 AM

#

!remind 2h learn how to calculate time

stable mountainBOT Nov 20, 2021, 8:09 AM

#

Yep.

Your reminder will arrive on <t:1637402985:F>!

stable mountainBOT Nov 20, 2021, 10:09 AM

#

green oriole !remind 2h learn how to calculate time

It has arrived!

Here's your reminder: learn how to calculate time
[Jump back to when you created the reminder](#dev-contrib message)

fallen patrol Nov 20, 2021, 2:33 PM

#

hmmm

#

interesting

#

I believe I've found a bug with the paginator

#

and that explains why I've found it so slow at times

#

its a simple pr to fix it...

#

first and last line in this snippet, need to delete the top line in all four if branches https://github.com/python-discord/sir-lancebot/blob/dea39a46437227b1ca0ec94aa00376b4167f2f02/bot/utils/pagination.py#L215-L221

stable mountainBOT Nov 20, 2021, 2:38 PM

#

bot/utils/pagination.py lines 215 to 221

await message.edit(embed=embed)
embed.description = paginator.pages[current_page]
if footer_text:
    embed.set_footer(text=f"{footer_text} (Page {current_page + 1}/{len(paginator.pages)})")
else:
    embed.set_footer(text=f"Page {current_page + 1}/{len(paginator.pages)}")
await message.edit(embed=embed)```

fallen patrol Nov 20, 2021, 2:39 PM

#

while at it, should probably make them if/elif for the slight efficiency boost

#

seems like the easy fix is actually

#

applying this patch to that file https://github.com/python-discord/bot/commit/3cd4c92b1e24c8cfdae8c5c68c19607c62cc01ed

GitHub

Remove unnecessary edits during pagination · python-discord/bot@3cd...

#

actually

#

there's a few other dupes in that file

#

here https://github.com/python-discord/sir-lancebot/blob/dea39a46437227b1ca0ec94aa00376b4167f2f02/bot/utils/pagination.py#L431-L441

stable mountainBOT Nov 20, 2021, 2:53 PM

#

bot/utils/pagination.py lines 431 to 441

embed.description = ""
await message.edit(embed=embed)
embed.description = paginator.pages[current_page]

image = paginator.images[current_page] or EmptyEmbed
embed.set_image(url=image)

embed.set_footer(text=f"Page {current_page + 1}/{len(paginator.pages)}")
log.debug(f"Got {reaction_type} page reaction - changing to page {current_page + 1}/{len(paginator.pages)}")

await message.edit(embed=embed)```

scenic moth Nov 20, 2021, 3:03 PM

#

#help-falafel message

this message never got pinned by bot?

gritty wind Nov 20, 2021, 3:04 PM

#

The first message was deleted (by the bot, probably because it was an attachment)

#

They sent a new message, which did not get pinned

fallen patrol Nov 20, 2021, 3:04 PM

#

okay, made a commit, prepped a pr, will submit if okayed 😄

green oriole Nov 20, 2021, 3:53 PM

#

@thorny obsidian aoc PR reviewed

gritty wind Nov 20, 2021, 3:54 PM

#

What time classes can have a TZ set? I'm assuming datetimes and time?

#

I'm trying to update the discord_timestamp utility to accept times with TZs

green oriole Nov 20, 2021, 3:55 PM

#

I time has the tzinfo, yes

thorny obsidian Nov 20, 2021, 3:59 PM

#

green oriole <@212644551926611969> aoc PR reviewed

thank you!

green oriole Nov 20, 2021, 4:00 PM

#

catthumbsup merged

gritty wind Nov 20, 2021, 4:06 PM

#

gritty wind I'm trying to update the `discord_timestamp` utility to accept times with TZs

Welp, I had the wrong way around

#

It only works with aware timestamps

#

but datetime.utcnow does not set the tz.... why what's the point

vale ibex Nov 20, 2021, 4:08 PM

#

use arrow.utcnow()

#

or datetime.utcnow(tzinfo=timezone.utc)

gritty wind Nov 20, 2021, 4:10 PM

#

just switched to datetime.now it's fewer characters lmao

#

Wait will datetime.now with the tz set get utc time, or local time and set UTC

vale ibex Nov 20, 2021, 4:11 PM

#

datetime.now will return a naive with your current time

#

not utc

gritty wind Nov 20, 2021, 4:11 PM

#

Nah it's utc it seems

#

datetime.datetime.now(tz=datetime.timezone.utc)
datetime.datetime(2021, 11, 20, 16, 11, 56, 78825, tzinfo=datetime.timezone.utc)

vale ibex Nov 20, 2021, 4:12 PM

#

nah, that likely means your container is utc then

gritty wind Nov 20, 2021, 4:12 PM

#

I'm running on my system

vale ibex Nov 20, 2021, 4:12 PM

#

well yea, that converts it

gritty wind Nov 20, 2021, 4:12 PM

#

Ah, that's what I meant

vale ibex Nov 20, 2021, 4:13 PM

#

Yea, giving it a tz will convert the local time to that tz