#dev-contrib | Python | Page 148

short snow Oct 27, 2021, 12:44 PM

#

good luck 🙃

#

Ok cool, sir-lancebot#930 is now ready for review, the only todo left is to add leaderboard support to all game cogs which would be done after the core functionality gets an approval

dusky shoreBOT Oct 27, 2021, 12:46 PM

#

GitHub

PROpen Global Leaderboard

clever wraith Oct 27, 2021, 1:11 PM

#

Hi all, regarding sir-lancebot#902, cowpy has been switched back to Apache. Does this mean I need to find another library or just do it myself?

dusky shoreBOT Oct 27, 2021, 1:11 PM

#

GitHub

PROpen feat: added cowsay

clever wraith Oct 27, 2021, 1:15 PM

#

I am no core dev or lawyer, but if they switched the license it should be fine to use, if there is any problem with that switch it is on them, that's my personal view on the matter

vale ibex Oct 27, 2021, 1:17 PM

#

Does apache require attribution? I forget

#

should be fine as apache, just might need to add a thrid party license file

clever wraith Oct 27, 2021, 1:20 PM

#

I don't think you need to attach the license since you don't vendor anything, it is a third party library compatible with MIT

clever wraith Oct 27, 2021, 1:49 PM

#

Hey @vale ibex, rapidfuzzy fully released wheels for 3.10 if you want to update the issue

vale ibex Oct 27, 2021, 1:59 PM

#

nice nice

#

oh, i already had 😄

#

just waiting on hiredis and psutil

static canyon Oct 27, 2021, 2:11 PM

#

@reef tinsel something I noticed on your PR is that you're using logging.getLogger and not bot.log.get_logger

#

You should change that

#

I'll formally request changes on the github when I'm on my laptop later

reef tinsel Oct 27, 2021, 2:13 PM

#

ok

static canyon Oct 27, 2021, 2:13 PM

#

And as for requesting reviews, it's at the top-right of the main PR tab

reef tinsel Oct 27, 2021, 2:14 PM

#

tbh it makes no difference to functionality currently anyway since im not using it lol

#

yh

#

i did look but i could find any thing to click

gritty wind Oct 27, 2021, 2:14 PM

#

not everyone can request reviews

static canyon Oct 27, 2021, 2:14 PM

#

Oh right

gritty wind Oct 27, 2021, 2:15 PM

#

If you've got time, make sure to update your base branch for your PR, so you can work out any problems before people start reviewing

reef tinsel Oct 27, 2021, 2:15 PM

#

wdym?

static canyon Oct 27, 2021, 2:16 PM

#

!remind 3h review bot#1917

stable mountainBOT Oct 27, 2021, 2:16 PM

#

You're the boss!

Your reminder will arrive on <t:1635354971:F>!

dusky shoreBOT Oct 27, 2021, 2:16 PM

#

GitHub

PROpen Patreon

gritty wind Oct 27, 2021, 2:16 PM

#

So, when you created a new branch, you started at a certain point in history

short snow Oct 27, 2021, 2:16 PM

#

gritty wind not everyone can request reviews

non staff people can rerequest reviews but not reqeust them

gritty wind Oct 27, 2021, 2:16 PM

#

Since then, the main branch had new commits

#

Which your branch doesn't have

reef tinsel Oct 27, 2021, 2:16 PM

#

aah 👍

gritty wind Oct 27, 2021, 2:17 PM

#

It's a good idea if you have time to do it, but it's not a big deal

reef tinsel Oct 27, 2021, 2:17 PM

#

done the merge - will test again now

gritty wind Oct 27, 2021, 2:18 PM

#

thanks 👍

dim pelican Oct 27, 2021, 2:19 PM

#

Is it normal for our code base to type hint the variables when they are definied?

brisk brook Oct 27, 2021, 2:20 PM

#

You generally shouldn't

#

abc: str = "abc"

#

This is useless

short snow Oct 27, 2021, 2:20 PM

#

90% of the time no, the rest 10% include cases like this where the reader is not aware of what it will contain or it is not explicitly clear

gritty wind Oct 27, 2021, 2:21 PM

#

There are some places where it can be useful (think Optional/None)

green oriole Oct 27, 2021, 2:21 PM

#

And collections

gritty wind Oct 27, 2021, 2:21 PM

#

I think something in our toolchain would warn for that

#

yeah

dim pelican Oct 27, 2021, 2:21 PM

#

@reef tinsel see above? This is the first thing that stands out to me

brisk brook Oct 27, 2021, 2:21 PM

#

short snow 90% of the time no, the rest 10% include cases like this where the reader is not...

But there it is necessary

#

See dict() because dict[Any, Any]

gritty wind Oct 27, 2021, 2:22 PM

#

I think that's what Jason is saying haha

#

Good example

green oriole Oct 27, 2021, 2:22 PM

#

Yeah

short snow Oct 27, 2021, 2:22 PM

#

Yes, the reader wouldn't know-how is the dict structured unless they go through the code

reef tinsel Oct 27, 2021, 2:23 PM

#

👍

molten perch Oct 27, 2021, 2:25 PM

#

Hey! Could someone take a look at api#23? It should be pretty straightforward by now. 😄

dusky shoreBOT Oct 27, 2021, 2:25 PM

#

GitHub

PROpen Add Alembic Migration environment to the project, patch model architecture

short snow Oct 27, 2021, 2:28 PM

#

I see some cascading options patching, which wasn't discussed on the PR, any context for that?

gritty wind Oct 27, 2021, 2:28 PM

#

Good idea, good idea

#

The mako script is just auto-gened, right?

short snow Oct 27, 2021, 2:29 PM

#

yeah

gritty wind Oct 27, 2021, 2:30 PM

#

Thx

short snow Oct 27, 2021, 2:32 PM

#

Ok @molten perch the mako script doesn't agree with black and the linter

You can update it to this

"""
${message}

Revision ID: ${up_revision}
Revises: ${down_revision | comma,n}
Create Date: ${create_date}
"""
import sqlalchemy as sa
from alembic import op
${imports if imports else ""}

# revision identifiers, used by Alembic.
revision = ${repr(up_revision)}
down_revision = ${repr(down_revision)}
branch_labels = ${repr(branch_labels)}
depends_on = ${repr(depends_on)}


def upgrade() -> None:
    ${upgrades if upgrades else "pass"}


def downgrade() -> None:
    ${downgrades if downgrades else "pass"}

thorny obsidian Oct 27, 2021, 2:33 PM

#

short snow Ok <@!263957159807549450> the mako script doesn't agree with `black` and the lin...

why are you running it against black? black isn't something we use on our repos

gritty wind Oct 27, 2021, 2:33 PM

#

That doesn't.... look right

short snow Oct 27, 2021, 2:33 PM

#

We use it on api

gritty wind Oct 27, 2021, 2:33 PM

#

I think we may use it on api yeah

#

Maybe we should just exclude the migrations directory

#

It's almost entirely autogenerated anyways

short snow Oct 27, 2021, 2:34 PM

#

Without black, migrations look horrible

gritty wind Oct 27, 2021, 2:34 PM

#

Who's looking at them

thorny obsidian Oct 27, 2021, 2:34 PM

#

why do we use black on the api?

short snow Oct 27, 2021, 2:34 PM

#

no they aren't autogenerated, only the initial one is

#

rest you write them on your own

gritty wind Oct 27, 2021, 2:34 PM

#

They are, just run generatemigrations

#

I know, I ran a ton when debugging with Dorsan

#

Would be quite underpowered and inefficient if we still had to manually write them

molten perch Oct 27, 2021, 2:37 PM

#

gritty wind Maybe we should just exclude the migrations directory

I was on the same opinion. However.. here's the discussion:https://github.com/python-discord/api/pull/23#discussion_r730518309

short snow Oct 27, 2021, 2:37 PM

#

There is a way to generate them in Alembic by diffing the sqlalchemy models, but I haven't worked with them, they aren't very accurate and most of the time one edits them manually to make them accurate. Django autogenerate are completely next level, if alembic had that support - I would have used it.

I remember this being discussed on the pr also

#

Yeah that linked discussion

#

autogenerated models

#

compare them with the current state

gritty wind Oct 27, 2021, 2:39 PM

#

I don't think Volcy's comment is accurate, at least not anymore

#

That's not correct

#

I have an auto generated migration above

#

let me get it for ya

short snow Oct 27, 2021, 2:39 PM

#

👍 .

gritty wind Oct 27, 2021, 2:39 PM

#

Deleted a table, dropped all dependencies

#

https://paste.pythondiscord.com/wowevilipu.py

#

clean migration

static canyon Oct 27, 2021, 2:40 PM

#

@gritty wind am I right in saying that guild.get_role has never had any issues with cache (aka we don't need to await guild.fetch_all_roles())?

gritty wind Oct 27, 2021, 2:40 PM

#

It's also like django with generating new files for new migrations, it doesn't overwrite anything

green oriole Oct 27, 2021, 2:40 PM

#

static canyon <@!386599446571384843> am I right in saying that `guild.get_role` has never had ...

I'd be weary of that

gritty wind Oct 27, 2021, 2:41 PM

#

I'm not sure, it's hard to know for sure beyond looking at where we use similar things, and see what works

#

Is this for the reminders issue?

short snow Oct 27, 2021, 2:41 PM

#

They are different

gritty wind Oct 27, 2021, 2:41 PM

#

Wdym?

molten perch Oct 27, 2021, 2:41 PM

#

gritty wind It's also like django with generating new files for new migrations, it doesn't o...

There are things that are not supported alembic, however those things do not apply to our case. (Like renaming a table, or a column, although that could be done manually as well if necessary)

short snow Oct 27, 2021, 2:42 PM

#

ok nvm, cascading was added alter by dorsan

static canyon Oct 27, 2021, 2:42 PM

#

gritty wind Is this for the reminders issue?

For the patreon issue

gritty wind Oct 27, 2021, 2:42 PM

#

Ah, hmm

static canyon Oct 27, 2021, 2:42 PM

#

https://github.com/python-discord/bot/blob/0b8e507c8f3ffb12f4f2129c7d83ab378c75814c/bot/exts/info/patreon.py#L29-L30

await guild.fetch_channels()
await guild.fetch_roles()```

#

I don't like this

gritty wind Oct 27, 2021, 2:43 PM

#

We use get_role in a few places, doesssn't seem to be a problem I think

#

I'm not sure

#

Fetch should be fallback at least anyways

short snow Oct 27, 2021, 2:43 PM

#

Also that patreon PR has lot of duplicated code, espcially get roles, knock them to a cog task

vale ibex Oct 27, 2021, 2:44 PM

#

wait_until_guild_available already ensures that roles, members and channels have items

#

I don't see a need for that

static canyon Oct 27, 2021, 2:45 PM

#

yeah

#

Okay, thanks

gritty wind Oct 27, 2021, 2:54 PM

#

Hm, seems deleting the table still requires manual changes

#

Alright, that's fine

sour viper Oct 27, 2021, 2:55 PM

#

hey so if i made a contribution do i get the "Contributor" role awarded ?

gritty wind Oct 27, 2021, 2:57 PM

#

So, it depends

#

A role given by staff to people who make substantial contributions

#

The role is given on a case-by-case basis, but usually a single contribution not really

sour viper Oct 27, 2021, 2:57 PM

#

ohhhh okay

gritty wind Oct 27, 2021, 2:57 PM

#

Unless you like idk... sprinted an entire project or something 😛

#

We do appreciate all contributions though, and we keep our peepers peeled

sour viper Oct 27, 2021, 2:57 PM

#

naaaaah not that big just a small fun command

vale ibex Oct 27, 2021, 2:58 PM

#

!otn a Scale's peeled peepers

stable mountainBOT Oct 27, 2021, 2:58 PM

#

:ok_hand: Added 𝖲cale’s-peeled-peepers to the names list.

gritty wind Oct 27, 2021, 2:59 PM

#

I can't believe it took this long, I've been saying it for such a long time 👀

vale ibex Oct 27, 2021, 2:59 PM

#

lol

static canyon Oct 27, 2021, 3:00 PM

#

Submitted a preliminary review @reef tinsel 👍

#

A few nitpicky things so sorry :p

reef tinsel Oct 27, 2021, 3:01 PM

#

👍 will take a look

static canyon Oct 27, 2021, 3:02 PM

#

This is probably my first in-depth review so let me know if you have any queries :p

austere hornet Oct 27, 2021, 3:06 PM

#

gritty wind I can't believe it took this long, I've been saying it for such a long time 👀

Lol

reef tinsel Oct 27, 2021, 3:08 PM

#

@static canyon when I fix these, should I do one big commit ssaying something about the review, or should I split it up?

static canyon Oct 27, 2021, 3:09 PM

#

I think split it up for now and if we decide we want to squash it later then we can 👍

reef tinsel Oct 27, 2021, 3:09 PM

#

ok 👍

dim pelican Oct 27, 2021, 3:10 PM

#

I tend to have more commits than (probably) needed

gritty wind Oct 27, 2021, 3:10 PM

#

@short snow how were you even running black to get it to error? It shouldn't pick up the mako script because it's not python

#

Hell, running black . on Dorsan's branch passes

static canyon Oct 27, 2021, 3:11 PM

#

dim pelican I tend to have more commits than (probably) needed

I noticed rofl

#

The thing is we can always squash commits, but it's had to split one commit into multiple

#

So I'll tend to do more than needed and then squash

dim pelican Oct 27, 2021, 3:12 PM

#

I think it had the main branch merged twice over the course of the PR

static canyon Oct 27, 2021, 3:13 PM

#

Do you have precommit configured by the way? @dim pelican @reef tinsel

dim pelican Oct 27, 2021, 3:13 PM

#

Yup

static canyon Oct 27, 2021, 3:14 PM

#

Good 👍

reef tinsel Oct 27, 2021, 3:16 PM

#

yep

molten perch Oct 27, 2021, 3:21 PM

#

gritty wind clean migration

So, do I exclude the migrations from the linting, or not? 😄
(Sorry, for the late ping 🙂 )

gritty wind Oct 27, 2021, 3:21 PM

#

Currently, it seems fine to keep it

#

I'm not even sure if anything is not passing?

#

Also, dockerfile still needs a newline at the end of the file

#

I'm about to press the green button, just doing some final checks on the actions

#

Exciting stuff, big news for the api

molten perch Oct 27, 2021, 3:23 PM

#

Indeed 😄 It seems like cascading works as well, so everything's fine 😄

gritty wind Oct 27, 2021, 3:24 PM

#

Does it? It's still throwing errors for me, but I figured might as well ignore them at this point

molten perch Oct 27, 2021, 3:24 PM

#

It did not throw errors for me.
When'd it throw errors for you? Can you send your code snippet that was failing?

gritty wind Oct 27, 2021, 3:25 PM

#

I did the same thing agian, just removed nomination

molten perch Oct 27, 2021, 3:25 PM

#

Oh, yeah. It's a migration problem, not cascading.

#

And, you just have to change the order, as alembic is not aware of them.

gritty wind Oct 27, 2021, 3:26 PM

#

So what was the cascading problem?

#

Typically if the cascading is working properly, dropping the nomination table should drop all columns in nomination_entry, no?

#

Like if I manually run the SQL:

drop table api_nomination cascade;```

It'll drop the table just fine

molten perch Oct 27, 2021, 3:29 PM

#

I hope so?
I only tested with single records, not whole tables. :/

reef tinsel Oct 27, 2021, 3:30 PM

#

The isort pre-commit hook will stop my commit from commiting when it changes an import order, even when it is the only "failing" thing. Could this change?

static canyon Oct 27, 2021, 3:31 PM

#

reef tinsel The isort pre-commit hook will stop my commit from commiting when it changes an ...

An import in the wrong order will cause the commit to fail linting. It makes sense to me that it stops you from comitting because of this (otherwise it's allowing a commit which it knows is "bad")

reef tinsel Oct 27, 2021, 3:32 PM

#

but all i need to do is start the commit again and it will work

#

for it sorts the imports for me

static canyon Oct 27, 2021, 3:33 PM

#

Ah right

#

Yeah, that's annoying I guess

gritty wind Oct 27, 2021, 3:34 PM

#

molten perch I hope so? I only tested with single records, not whole tables. :/

It's still not working for tables, but that's fine, seems unfixable. I'm not sure if any cascading is working tbh. Like I tried updating the value for a user_id, but that failed, because it did not cascade

reef tinsel Oct 27, 2021, 3:34 PM

#

i do understand why the isort fails, as it does give me a notice that m imports have changed, but is their a way for this kind of thing to pass, but give me the notice?

gritty wind Oct 27, 2021, 3:36 PM

#

It's designed to explicitly fail like that

molten perch Oct 27, 2021, 3:36 PM

#

gritty wind It's still not working for tables, but that's fine, seems unfixable. I'm not sur...

It should on a level.
Like If you create a Nomination, and a NominationEntry, if you delete the Nomination it cascades, and deletes the NominationEntry.

gritty wind Oct 27, 2021, 3:36 PM

#

Though, you can manually run it beforehand

gritty wind Oct 27, 2021, 3:36 PM

#

molten perch It should on a level. Like If you create a Nomination, and a NominationEntry, if...

It doesn't seem to be working like that, unless I write sql which adds cascade. Like all of the cascade seems to be operating like that

molten perch Oct 27, 2021, 3:36 PM

#

It's handled on the ORM level.

gritty wind Oct 27, 2021, 3:37 PM

#

Right, but it isn't working

thorny obsidian Oct 27, 2021, 3:37 PM

#

@trail pilot Can you provide some more guidance / an example of what you're expecting the json loaded in to look like? It's currently unclear from the code and the PR description.

gritty wind Oct 27, 2021, 3:37 PM

#

It's working for now, and it's easy enough to modify the migrations if something doesn't cascade properly, so I'll just submit an approval for now

#

Let me go check on the actions

molten perch Oct 27, 2021, 3:37 PM

#

gritty wind Right, but it isn't working

May I ask how you tested the cascading?
With RAW SQL or by creating a SQLAlchemy sessions and such?

#

I went through the cascading the other day, it seemed to work just fine.
However, I tested it using SQLAlchemy, and not by issuing SQL commands.

static canyon Oct 27, 2021, 3:45 PM

#

@reef tinsel I think you misunderstood my comment in https://github.com/python-discord/bot/pull/1917/commits/2f5aeb06e816240b08453b5cf327c6b77958a3ab

#

I meant that the top 3 should have different variable names to the bottom three

#

So like```py
tier_1_or_above_patrons = set(...)
tier_2_or_above_patrons = set(...)
tier_3_only_patrons = set(...)

tier_1_only_patrons = ...
tier_2_only_patrons = ...

reef tinsel Oct 27, 2021, 3:46 PM

#

aahok

static canyon Oct 27, 2021, 3:47 PM

#

edited @reef tinsel ^

#

Also joe is gonna reword the patreon message (see <#community-meta message>)

#

So for the two things related to that, just hold fire

gritty wind Oct 27, 2021, 3:50 PM

#

molten perch I went through the cascading the other day, it seemed to work just fine. However...

I executed a delete from the sqlalchemy connection on a user which was used in a nomination entry:

DELETE FROM api_user WHERE id={ID};

#

Deleted the user just fine, but the nomination entry was still there

#

I can also modify the PK on api_user so that the ID no longer exists, which should update in FKs, but it doesn't

molten perch Oct 27, 2021, 3:52 PM

#

But, that's not the ORM. Let me show you.

short snow Oct 27, 2021, 3:54 PM

#

gritty wind <@!736234578745884682> how were you even running black to get it to error? It sh...

Error? I never said I got an error, I just said the mako file would generate a template that doesn't agree with our linting tools, one is that there aren't any return type annotations and one is that the first line of the docstring should start on a new line if we have a multiline docstring.

Also I didn't run anything, its just what i guessed

#

also the linting tools pass as dorsan has fixed the initial migration file

gritty wind Oct 27, 2021, 3:57 PM

#

short snow also the linting tools pass as dorsan has fixed the initial migration file

yeah I saw lol

#

regardless, I don't think it's worth the bother to try and get it compatible with the code style. There are other things which I'm pretty sure will fail, but we can't fix

#

I was debating whether or not to ask Dorsan to definitely disable black on migrations, since for the most part they shouldn't need to be reviewed by humans

#

But at the same time, they already get linted so, what's the point

short snow Oct 27, 2021, 3:58 PM

#

I mostly write migrations for alembic myself, and I am sure a few others also do that... so not completely sure about that

molten perch Oct 27, 2021, 3:59 PM

#

gritty wind I can also modify the PK on api_user so that the ID no longer exists, which shou...

Okay, (sorry for the low quality way to show it 😄 ) I created a user and a Nomination(using the user that was created beforehand). (You can assume that there's only on from each of them, hence the use of .first() ) Then deleted the user, and checked the existence of the Nomination created before.

gritty wind Oct 27, 2021, 4:00 PM

#

short snow I mostly write migrations for alembic myself, and I am sure a few others also do...

If you want to torture yourself, that's fine (where does the template even fit in at this point?). My point still stands though, it doesn't make much of a difference

gritty wind Oct 27, 2021, 4:00 PM

#

molten perch Okay, (sorry for the low quality way to show it 😄 ) I created a user and a Nomi...

Thanks

short snow Oct 27, 2021, 4:02 PM

#

(torture? lol, I just didn't knew about this and now have written a lot of alembic migrations for two of my projects so I am just used to it)

#

Ok yeah, I am fine with removing black then, because the main job is done anyways

reef tinsel Oct 27, 2021, 4:07 PM

#

could someone have a look at my latest comment on bot#1917 (latest message in #dev-log )

dusky shoreBOT Oct 27, 2021, 4:07 PM

#

GitHub

PROpen Patreon

static canyon Oct 27, 2021, 4:10 PM

#

@reef tinsel not on my laptop so can't comment on GitHub but dopy """ ...... """instead

reef tinsel Oct 27, 2021, 4:10 PM

#

a little confused?

static canyon Oct 27, 2021, 4:11 PM

#

"""...."""```to```py
"""
....
"""```

#

That way it's not over the 120chars

reef tinsel Oct 27, 2021, 4:11 PM

#

that doesn't work

static canyon Oct 27, 2021, 4:11 PM

#

Wdym?

gritty wind Oct 27, 2021, 4:11 PM

#

@molten perch alright, we're getting very close now. I've asked for someone from devops to have a look at the actions so we should be ready to go soon

reef tinsel Oct 27, 2021, 4:11 PM

#

pre-commit doesn't like it

static canyon Oct 27, 2021, 4:11 PM

#

reef tinsel pre-commit doesn't like it

What does it say?

#

Add a newline? If so, add it

reef tinsel Oct 27, 2021, 4:11 PM

#

open and closing quotes should be on the same line if 1 line string

#

in otherwords, that format isn't allowed

static canyon Oct 27, 2021, 4:12 PM

#

I mean ig "every day" --> "daily"

molten perch Oct 27, 2021, 4:12 PM

#

gritty wind <@!263957159807549450> alright, we're getting very close now. I've asked for som...

Cool, thank you! 😄 So, in the end could you get those cascading working as well?

static canyon Oct 27, 2021, 4:12 PM

#

static canyon I mean ig "every day" --> "daily"

That's 4 chars less so will fix @reef tinsel

reef tinsel Oct 27, 2021, 4:13 PM

#

static canyon I mean ig "every day" --> "daily"

thx! that should save the chars - when i wrote that i initially had it too long, so it is already a little compact - another change can't hurt 🙂

static canyon Oct 27, 2021, 4:13 PM

#

Yeah, we do sometimes have to rework docstrings

gritty wind Oct 27, 2021, 4:18 PM

#

molten perch Cool, thank you! 😄 So, in the end could you get those cascading working as well...

no

#

ignore the import error lol

molten perch Oct 27, 2021, 4:21 PM

#

I'm not aware of the context. So you created a User and a NominationEntry correspondingly, right?
(Although, you'll need a Nomination for a Nomination Entry though)

gritty wind Oct 27, 2021, 4:21 PM

#

I dropped nomination completely, so I didn't need nomination

#

But yeah

#

Created a user, used it to create a nom entry

#

dropped user

#

nom entry still there

molten perch Oct 27, 2021, 4:22 PM

#

I'm not sure how.
It's supposed to return None like when you do type(user) (since you named the nominationentry user)

gritty wind Oct 27, 2021, 4:23 PM

#

I still see the entries for the nomination in the DB for the nomination, but not the user

molten perch Oct 27, 2021, 4:35 PM

#

I did the same thing, it seems to work.

gritty wind Oct 27, 2021, 4:38 PM

#

I cleared my entire environment, and started from scratch to get something reproducible

#

#

from datetime import datetime
from sqlalchemy.orm import Session
from sqlalchemy import create_engine
import os

os.environ["database_url"] = "postgresql://pysite:pysite@localhost:7777/pysite"
os.environ["auth_token"] = "my_token"

from api.core import settings
from api.core.database.models.api.bot.user import User
from api.core.database.models.api.bot.nomination import Nomination
from api.core.database.models.api.bot.nomination_entry import Nominationentry

engine = create_engine(settings.database_url)
session = Session(engine)

session.add(User(id=1, name="test name", discriminator=8000, in_guild=True, roles=[]))
session.add(User(id=2, name="test nominee", discriminator=8000, in_guild=True, roles=[]))
session.add(Nomination(active=True, user_id=2, inserted_at=datetime.now(), id=1, end_reason="", reviewed=False))
session.add(Nominationentry(id=1, reason="Something", actor_id=1, nomination_id=1))
session.commit()

user = session.query(User).first()
session.delete(user)
session.commit()
session.query(Nomination).first()
session.query(Nominationentry).first()

cold island Oct 27, 2021, 4:41 PM

#

You want nominations to disappear when dropping users?

gritty wind Oct 27, 2021, 4:41 PM

#

That's what cascade should do in theory yeah

#

Otherwise you have dangling entries

cold island Oct 27, 2021, 4:41 PM

#

Is that a good thing in this case?

gritty wind Oct 27, 2021, 4:41 PM

#

There are very few cases where users are deleted

#

And yeah, that is intended behavior

cold island Oct 27, 2021, 4:42 PM

#

Ah, I think I see

green oriole Oct 27, 2021, 4:43 PM

#

I feeeeel like for safety reasons the user shouldn't ever be dropped if it is referenced by a nomination

cold island Oct 27, 2021, 4:44 PM

#

If we want to drop info on a user then cascading sounds like a good thing

#

And for safety reasons we have blackbox

green oriole Oct 27, 2021, 4:44 PM

#

I don't think we would notice it

gritty wind Oct 27, 2021, 4:44 PM

#

Nothing does it automatically

green oriole Oct 27, 2021, 4:44 PM

#

We do drop users when they leave the guild with no infraction

gritty wind Oct 27, 2021, 4:45 PM

#

I'm pretty sure we'd only get to that point if someone requests data expunging

green oriole Oct 27, 2021, 4:45 PM

#

I think @patent pivot does that every month during the data review thing

cold island Oct 27, 2021, 4:45 PM

#

green oriole We do drop users when they leave the guild with no infraction

Do we? pithink

green oriole Oct 27, 2021, 4:46 PM

#

Okay he stopped doing those

cold island Oct 27, 2021, 4:46 PM

#

But if they leave the guild with a nomination that will stop them from being deleted in that case as well right?

gritty wind Oct 27, 2021, 4:46 PM

#

So, looking at it

#

This is the current behavior

green oriole Oct 27, 2021, 4:46 PM

#

But he used to do that

There were 216,631 records in the user table containing users from the Discord server. 12,780 of these records are users who have left the server with no infraction history, these records have been removed.

gritty wind Oct 27, 2021, 4:46 PM

#

It's the same in the current API

green oriole Oct 27, 2021, 4:47 PM

#

cold island But if they leave the guild with a nomination that will stop them from being del...

I don't know if the query accounted for that. It is a non issue anyway since he stopped those.

gritty wind Oct 27, 2021, 4:47 PM

#

https://github.com/python-discord/bot/blob/94b4ad61c203e5b8b33ace2ef639a9fb2fdea4e4/bot/exts/backend/sync/_syncers.py#L212-L223

stable mountainBOT Oct 27, 2021, 4:48 PM

#

bot/exts/backend/sync/_syncers.py lines 212 to 223

async def _sync(diff: _Diff) -> None:
    """Synchronise the database with the user cache of `guild`."""
    # Using asyncio.gather would still consume too many resources on the site.
    log.trace("Syncing created users...")
    if diff.created:
        for chunk in chunked(diff.created, CHUNK_SIZE):
            await bot.instance.api_client.post("bot/users", json=chunk)

    log.trace("Syncing updated users...")
    if diff.updated:
        for chunk in chunked(diff.updated, CHUNK_SIZE):
            await bot.instance.api_client.patch("bot/users/bulk_patch", json=chunk)```

gritty wind Oct 27, 2021, 4:48 PM

#

Syncer doesn't delete anything either

#

Only time users are deleted is when someone goes in and explicitly, manually deletes them

molten perch Oct 27, 2021, 4:49 PM

#

gritty wind

So, what's the context in that case? You have Nomination, NominationEntry and a User and you delete a User and you expect both Nom and Nomentry to be deleted?

gritty wind Oct 27, 2021, 4:50 PM

#

Well, if the user is gone, why do we still have the nomination entry

#

It would appear to be dangling

#

Actually I see why

#

I didn't delete the other user lol

#

Okay, seems to be working as intended™️

molten perch Oct 27, 2021, 4:53 PM

#

Phew 😅

#

Cool

#

Thank you for the test and all! 😄

#

In theory, I patched the actions correctly.

trail pilot Oct 27, 2021, 5:05 PM

#

thorny obsidian <@!584817706646110333> Can you provide some more guidance / an example of what y...

Yep!

example:

[
  {"number": 1, "explanation": "Lorem ipsum dolor sit amet", "answers": ["answer 1", "answer 2", "answer 3", "correct-ans"], "correct": "correct-ans"}
]

thorny obsidian Oct 27, 2021, 5:08 PM

#

have you tested your feature yet with that json?

stable mountainBOT Oct 27, 2021, 5:16 PM

#

static canyon !remind 3h review bot#1917

It has arrived!

Here's your reminder: review bot#1917
[Jump back to when you created the reminder](#dev-contrib message)

molten perch Oct 27, 2021, 5:29 PM

#

Yaay, alembic setup merged 🎉 Thank you! 😄

gritty wind Oct 27, 2021, 5:30 PM

#

I wonder if caching will properly work if you try to use the published container as a source

#

Or will we have to publish the dev one too

#

Gotta eventually test that

#

!remind 18H Test that

stable mountainBOT Oct 27, 2021, 5:31 PM

#

ROGER THAT

Your reminder will arrive on <t:1635420685:F>!

molten perch Oct 27, 2021, 5:33 PM

#

I believe so, yeah! 😄

trail pilot Oct 27, 2021, 5:48 PM

#

thorny obsidian have you tested your feature yet with that json?

Yep

thorny obsidian Oct 27, 2021, 5:51 PM

#

trail pilot Yep

the json provided will throw a key error with your current code. explanation needs to be description

trail pilot Oct 27, 2021, 5:52 PM

#

thorny obsidian the json provided will throw a key error with your current code. `explanation` n...

Ohh, oops. I thought you were asking if I had tested it with a JSON. I did not test it with that JSON because I loaded a file to test it but discord doesn’t allow file previews/downloads on phone

#

So I couldn’t give the JSON I tested it with

cold moon Oct 27, 2021, 6:35 PM

#

New?

#

I think I don't have redesigned issues yet

cold moon Oct 27, 2021, 7:27 PM

#

Everything looks old for me

brisk brook Oct 27, 2021, 7:35 PM

#

cold moon Everything looks old for me

I got the new icons (purple)

cold moon Oct 27, 2021, 7:36 PM

#

Actually yes, there are new icons, but design is same for me currently

dim pelican Oct 27, 2021, 8:17 PM

#

Can't wait to get some long messy bars for my PRs

gritty wind Oct 27, 2021, 8:18 PM

#

Just go to the git history tab

dim pelican Oct 27, 2021, 8:21 PM

#

I guess this is scary enough as it is: https://github.com/python-discord/sir-lancebot/pull/842/commits

clever wraith Oct 27, 2021, 8:32 PM

#

The heck is this

#

Does github wants to make us feel even worse about our commit higiene

trail pilot Oct 27, 2021, 8:39 PM

#

dim pelican I guess this is scary enough as it is: <https://github.com/python-discord/sir-la...

92 commits?

#

Holy crap, that’s amazing

dim pelican Oct 27, 2021, 8:57 PM

#

Atomic commits mean that you should try to reach Avogadro's number right?

clever wraith Oct 27, 2021, 9:29 PM

#

I like this

#

It would allow making releases easier to manage

#

Gah, limited betas

#

Github will end up killing me with their betas

patent pivot Oct 27, 2021, 9:34 PM

#

best way of rollouts

clever wraith Oct 27, 2021, 9:34 PM

#

For sure

patent pivot Oct 27, 2021, 9:35 PM

#

coming from someone who has run A/B for a user base of uhh

clever wraith Oct 27, 2021, 9:35 PM

#

But it is pretty argh at some point

patent pivot Oct 27, 2021, 9:35 PM

#

21 million

clever wraith Oct 27, 2021, 9:35 PM

#

Pff, that's only the population of Switzerland

#

Do they do beta testing for new chocolate brands?

#

Nah I don't

gritty wind Oct 27, 2021, 9:37 PM

#

clever wraith Do they do beta testing for new chocolate brands?

Focus groups, the betas of humanity’s greatest achievements

timid sentinel Oct 27, 2021, 9:39 PM

#

clever wraith Do they do beta testing for new chocolate brands?

If you find out let me know where I can sign up

clever wraith Oct 27, 2021, 9:40 PM

#

timid sentinel If you find out let me know where I can sign up

Sorry it is only for countries members of the European union due to food safety concerns

#

no I'm not trying to keep all the chocolate for myself

timid sentinel Oct 27, 2021, 9:41 PM

#

lol

austere hornet Oct 27, 2021, 10:37 PM

#

clever wraith *no I'm not trying to keep all the chocolate for myself*

Lol

trail pilot Oct 27, 2021, 10:59 PM

#

So, I'm trying to commit to sir-lancebot with isort added, but flake and isort keep causing conflicts for each other. flake8 doesn't like the additional newline between application relative and application while isort keeps fixing it

#

and causing that conflict

stable mountainBOT Oct 27, 2021, 11:01 PM

#

It has arrived!

Here's your reminder: .
[Jump back to when you created the reminder](#dev-contrib message)

fallen patrol Oct 27, 2021, 11:06 PM

#

stable mountain

!remind 4H do this

stable mountainBOT Oct 27, 2021, 11:06 PM

#

Of course!

Your reminder will arrive on <t:1635390387:F>!

fallen patrol Oct 27, 2021, 11:06 PM

#

At theatre

austere hornet Oct 27, 2021, 11:06 PM

#

trail pilot and causing that conflict

Hey, so I had a similar issue with that yesterday as well. See this: #dev-contrib message

trail pilot Oct 27, 2021, 11:07 PM

#

austere hornet Hey, so I had a similar issue with that yesterday as well. See this: https://dis...

Ty!

austere hornet Oct 27, 2021, 11:07 PM

#

Np

fallen patrol Oct 28, 2021, 2:12 AM

#

Hmmmmm

stable mountainBOT Oct 28, 2021, 3:06 AM

#

fallen patrol !remind 4H do this

It has arrived!

Here's your reminder: do this
[Jump back to when you created the reminder](#dev-contrib message)

reef tinsel Oct 28, 2021, 7:15 AM

#

I assume that Bot (and maybe some other bots) will require the message intent? Whatever it is, it's probably worth it to put this information on the contributing guides?

rapid igloo Oct 28, 2021, 7:16 AM

#

the Bot contributing guides has a note on that

#

https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/bot/#privileged-intents

reef tinsel Oct 28, 2021, 7:17 AM

#

doesn't mention the message intent at all there...

cold island Oct 28, 2021, 7:18 AM

#

It's not relevant until April. We'll put it there when we actually turn on the intent

static canyon Oct 28, 2021, 7:26 AM

#

@reef tinsel just had a brief look at your commits since my review and it looks pretty good 👍

Will re-review later when I'm on my laptop

#

!remind 5h4M re-review bot#1917

stable mountainBOT Oct 28, 2021, 7:26 AM

#

Alright.

Your reminder will arrive on <t:1635424255:F>!

dusky shoreBOT Oct 28, 2021, 7:26 AM

#

GitHub

PROpen Patreon

static canyon Oct 28, 2021, 7:27 AM

#

Eee

#

!reminder edit duration 3352 7h2M

stable mountainBOT Oct 28, 2021, 7:29 AM

#

Alright.

That reminder has been edited successfully!

reef tinsel Oct 28, 2021, 7:29 AM

#

good thing the bot can then 🙂

short snow Oct 28, 2021, 7:30 AM

#

deletes message what did you say, I can do maths

static canyon Oct 28, 2021, 7:30 AM

#

reef tinsel good thing the bot can then 🙂

Lol. I still need to make my issue for allowing to give end time for the command instead of using relative time

reef tinsel Oct 28, 2021, 7:30 AM

#

short snow *deletes message* what did you say, I can do maths

so can I

static canyon Oct 28, 2021, 7:31 AM

#

In fact

#

!remind 34h Issue for providing exact end time instead of relative time on !remind

stable mountainBOT Oct 28, 2021, 7:31 AM

#

Aye aye, cap'n!

Your reminder will arrive on <t:1635528701:F>!

static canyon Oct 28, 2021, 7:36 AM

#

Also @reef tinsel I'd hold fire on wookie's reviews for now since some of them I don't agree with and would like to flesh out

reef tinsel Oct 28, 2021, 7:38 AM

#

yeah

#

i'm changing things that are clearly good (i.e. api call saving and docstring updation)

static canyon Oct 28, 2021, 7:41 AM

#

Yep 👍

rapid igloo Oct 28, 2021, 8:21 AM

#

reef tinsel doesn't mention the message intent at all there...

oh I misread sorry

short snow Oct 28, 2021, 8:45 AM

#

so even you are there

#

probably

#

yeah

#

i sent a message, saw?

#

http://scottchacon.com/2011/08/31/github-flow.html

GitHub Flow – Scott Chacon

Some information by and about Scott Chacon

fallen patrol Oct 28, 2021, 9:03 AM

#

hmmm, i won't be there, but im very interested in if a branch per release is before or after a release commit is made to the default branch.
eg: is the newest release part of the main branch, or the last commit goes into the release branch?

#

makes sense

#

i need to make a release workflow to generate that last commit for me to a pr lol

short snow Oct 28, 2021, 9:07 AM

#

globe is the repo, and the content is an issue

#

*No, I am not *

fallen patrol Oct 28, 2021, 9:07 AM

#

short snow probably

@clever wraith

#

o

#

i'm not in any of these

#

should go to one

short snow Oct 28, 2021, 9:08 AM

#

this is about github actions

fallen patrol Oct 28, 2021, 9:08 AM

#

but im busy today

#

and its 5am

short snow Oct 28, 2021, 9:08 AM

#

i am free today :D

fallen patrol Oct 28, 2021, 9:08 AM

#

interesting....

fallen patrol Oct 28, 2021, 9:09 AM

#

short snow i am free today \:D

~~not anymore~~

short snow Oct 28, 2021, 9:09 AM

#

fallen patrol Oct 28, 2021, 9:24 AM

#

Er, I just noticed this is drv contrib

short snow Oct 28, 2021, 9:41 AM

#

lol, he messed it up

desert vessel Oct 28, 2021, 10:50 AM

#

does sir lancebot run on a vps? or does it run on docker?

cold moon Oct 28, 2021, 10:53 AM

#

desert vessel does sir lancebot run on a vps? or does it run on docker?

All our infrastructure is running on Linode Kubernetes

stable mountainBOT Oct 28, 2021, 11:31 AM

#

gritty wind !remind 18H Test that

It has arrived!

Here's your reminder: Test that
[Jump back to when you created the reminder](#dev-contrib message)

dim pelican Oct 28, 2021, 12:11 PM

#

Hey all, I ran into an issue this morning during my testing. How would you raise an error from a command group subcommand? Currently for sir-lancebot#842 the subcommands all call the same "create and send embed" function. If there is an error during the conversions (specifically, the case when a name cannot be found during the fuzzy matching) how do I raise and send an error embed?

dusky shoreBOT Oct 28, 2021, 12:11 PM

#

GitHub

PROpen Add color command

brisk brook Oct 28, 2021, 12:13 PM

#

What do you mean?

#

Just try/except?

clever wraith Oct 28, 2021, 12:13 PM

#

You want to raise InvalidArgument and it will send the proper error embed

#

I believe that's what you are asking

brisk brook Oct 28, 2021, 12:14 PM

#

Ah, discord.py's error yeah

#

Isn't it BadArgument?

#

!d discord.ext.commands.BadArgument

stable mountainBOT Oct 28, 2021, 12:14 PM

#

discord.ext.commands.BadArgument


exception discord.ext.commands.BadArgument(message=None, *args)```
Exception raised when a parsing or conversion failure is encountered on an argument to pass into a command.

This inherits from [`UserInputError`](https://discordpy.readthedocs.io/en/master/ext/commands/api.html#discord.ext.commands.UserInputError "discord.ext.commands.UserInputError")

gritty wind Oct 28, 2021, 12:17 PM

#

We raise our own execrations and handle it

#

Thanks autocorrect

#

Things like

#

!src sheygzbeksbd

#

Those use that

#

Iirc

#

!src src

#

Ah no you’re right

#

It’s bad argument

clever wraith Oct 28, 2021, 12:19 PM

#

Oh right, BadArgument

dim pelican Oct 28, 2021, 12:20 PM

#

Alrighty, will have to try that out. I have to take any value from the user to search for a fuzzy matched color name, but when one is not found I need to raise the BadArgument when the function is returned

clever wraith Oct 28, 2021, 12:21 PM

#

We handle them there, if you are curious https://github.com/python-discord/bot/blob/main/bot/exts/backend/error_handler.py

#

Sounds about right, yeah

dim pelican Oct 28, 2021, 12:21 PM

#

    @colour.command()
    async def name(self, ctx: commands.Context, user_colour: str) -> None:
        """Command to create an embed from a name input."""
        hex_colour = self.match_colour_name(user_colour)
        # add try / except with BadArgument
        hex_tuple = ImageColor.getrgb(hex_colour)
        await self.send_colour_response(ctx, list(hex_tuple))

clever wraith Oct 28, 2021, 1:35 PM

#

Eh, the linode dashboard is pretty fine

patent pivot Oct 28, 2021, 1:48 PM

#

unnecessary

#

the only thing we provision on our Linode dashboard is the cluster itself, volumes, load balancers, firewalls, etc are all defined inside Kubernetes

#

TF is cool, but I don't like it for infrastructure at our size and don't want to use it here

green oriole Oct 28, 2021, 1:51 PM

#

@rapid igloo feel free to PR without an issue, you have my approval

#

She asked me to have a look

rapid igloo Oct 28, 2021, 1:52 PM

#

:D thanks

#

!remind 12H make people not able to cheat in candies ^

stable mountainBOT Oct 28, 2021, 1:53 PM

#

Affirmative!

Your reminder will arrive on <t:1635472413:F>!

stable mountainBOT Oct 28, 2021, 2:31 PM

#

static canyon !remind 5h4M re-review bot#1917

It has arrived!

Here's your reminder: re-review bot#1917
[Jump back to when you created the reminder](#dev-contrib message)

static canyon Oct 28, 2021, 2:31 PM

#

!remind 1d Do this

stable mountainBOT Oct 28, 2021, 2:31 PM

#

Yeah okay.

Your reminder will arrive on <t:1635517917:F>!

keen valley Oct 28, 2021, 3:33 PM

#

Hey!
I am looking for the New idea for sir-lancebot
Everything is done
but before that I just need to ask that, is there already another such kind of feature?
I had created .gender command which will get a parameter and return the gender of that name
And exception and all, I had handled

#

gritty wind Oct 28, 2021, 3:35 PM

#

How is it determining gender

dim pelican Oct 28, 2021, 3:36 PM

#

Is gender defined by names? I don't think it is

vale ibex Oct 28, 2021, 3:36 PM

#

I don't think a command that assumes gender based on a name is something we'd be interested in

gritty wind Oct 28, 2021, 3:36 PM

#

Yup to both points

molten perch Oct 28, 2021, 3:39 PM

#

Hey! Would someone mind to assign me to api#22, just for the sake of consistency? 😁

dusky shoreBOT Oct 28, 2021, 3:39 PM

#

GitHub

IssueOpen Migrate reminders endpoint from the site API

keen valley Oct 28, 2021, 3:53 PM

#

gritty wind How is it determining gender

Using a free API

keen valley Oct 28, 2021, 3:55 PM

#

vale ibex I don't think a command that assumes gender based on a name is something we'd be...

Ohh

#

No issue

clever wraith Oct 28, 2021, 4:05 PM

#

Hope it is fine for me to assign

molten perch Oct 28, 2021, 4:12 PM

#

¯_(ツ)_/¯

molten perch Oct 28, 2021, 4:13 PM

#

clever wraith Hope it is fine for me to assign

Thanks 😄

clever wraith Oct 28, 2021, 5:18 PM

#

https://github.blog/changelog/2021-10-27-enterprise-organizations-can-now-create-custom-repository-roles/

The GitHub Blog

phanatic

Enterprise organizations can now create custom repository roles | G...

Enterprise organizations can now create custom repository roles

#

._. Why enterprise

brisk brook Oct 28, 2021, 5:25 PM

#

Bcos they pay

#

💸

clever wraith Oct 28, 2021, 5:26 PM

#

how do i install pip install -r requirements.txt

#

Hey @clever wraith! Can you please follow the instructions in #❓｜how-to-get-help to claim your very own help channel? :D

clever wraith Oct 28, 2021, 6:32 PM

#

Hey @last patio (I believe we never met, I am akarys other's identity), I wouldn't mind having a way to bypass the worker, but how do we integrate that into the hastebin UI?

patent pivot Oct 28, 2021, 6:33 PM

#

what if we did it as a confirm

#

try once, get an error and warning, try again and it goes through

last patio Oct 28, 2021, 6:35 PM

#

clever wraith Hey <@196989358165852160> (I believe we never met, I am akarys other's identity)...

well we return a string right

clever wraith Oct 28, 2021, 6:35 PM

#

How do we even code that? I guess you could set a session token

#

Yup, we do return a message to show as an error

last patio Oct 28, 2021, 6:35 PM

#

patent pivot try once, get an error and warning, try again and it goes through

joe ???? this is STATELESS web application development, we don't store state about requests here, what the hell, joe

clever wraith Oct 28, 2021, 6:35 PM

#

We could actually store state in the user cookies

last patio Oct 28, 2021, 6:35 PM

#

clever wraith Yup, we do return a message to show as an error

yeah maybe something stupid like "include the string no-token-in-here anywhere in your code to bypass"

clever wraith Oct 28, 2021, 6:36 PM

#

But honestly I don't think it is good UIs because we know most users don't know how to read

last patio Oct 28, 2021, 6:36 PM

#

we could always put "uwu gazooks! our web service inklings have determined a token! oopsie" to make it more user friendly, taken from discord's example

clever wraith Oct 28, 2021, 6:37 PM

#

Heh

last patio Oct 28, 2021, 6:37 PM

#

what happened to your other account

clever wraith Oct 28, 2021, 6:37 PM

#

I don't think too long messages display nicely though

#

My other account is fine, I'm just a plural person apparently, heh

patent pivot Oct 28, 2021, 6:38 PM

#

last patio joe ???? this is ***STATELESS*** web application development, we don't store sta...

ya cookies

clever wraith Oct 28, 2021, 6:38 PM

#

morethanone.info and all that jazz, but I'd guess you already know what plurality is

last patio Oct 28, 2021, 6:38 PM

#

fair enough

last patio Oct 28, 2021, 6:38 PM

#

patent pivot ya cookies

excellent

#

lets do it

last patio Oct 28, 2021, 6:39 PM

#

clever wraith morethanone.info and all that jazz, but I'd guess you already know what pluralit...

first time I heard of it

#

very interesting

clever wraith Oct 28, 2021, 6:39 PM

#

Well, now you know, heh

#

I'd be scared of users just pressing save twice though

#

without reading

last patio Oct 28, 2021, 6:41 PM

#

maybe we could store a timestamp in there and require like 1, 2, 3 seconds before accepting a second save?

#

or just a regular ratelimiter may not be a bad shout

clever wraith Oct 28, 2021, 7:00 PM

#

patent pivot ya cookies

Leave my choccy chip cookies alone joe

#

Hmmm

#

Do we have that many false positive on token filtering?

#

workers#13

dusky shoreBOT Oct 28, 2021, 7:10 PM

#

GitHub

PROpen Serve robots worker

clever wraith Oct 28, 2021, 7:11 PM

#

Too bad, workers#14

dusky shoreBOT Oct 28, 2021, 7:11 PM

#

GitHub

PROpen Hastebin filter

austere hornet Oct 28, 2021, 7:15 PM

#

clever wraith Leave my choccy chip cookies alone joe

Lol

clever wraith Oct 28, 2021, 7:19 PM

#

Oh, nice

#

Mind leaving a comment pls?

#

I don't even know if I am allowed to work on that PR. I think it should be fine.

patent pivot Oct 28, 2021, 7:23 PM

#

what language should proxy be written in

#

hmmmmmm

#

the thing for filtering egress traffic

#

yea

#

that's part of it

#

yes

#

basically when coredns sees a query from a pod which is marked to have it's egressing traffic filtered

#

it'll return a DNS resolution to the proxy

#

the proxy then checks if that domain is permitted

#

yeah, but having proxy do it is nicer

#

we don't want to run a whole rule evaluation on our DNS controllers

#

that's wasteful and harmful to non-filtered traffic

#

i need to check with linode how dns support is

fallen patrol Oct 28, 2021, 10:08 PM

#

clever wraith Too bad, workers#14

left a review smh

#

i wasn't supposed to send that yet

smoky adder Oct 28, 2021, 11:01 PM

#

Hello everyone, does this thread have a list of projects to contribute?

stable mountainBOT Oct 28, 2021, 11:10 PM

#

Contribute to Python Discord's Open Source Projects
Looking to contribute to Open Source Projects for the first time? Want to add a feature or fix a bug on the bots on this server? We have on-going projects that people can contribute to, even if you've never contributed to open source before!

Projects to Contribute to
• Sir Lancebot - our fun, beginner-friendly bot
• Python - our utility & moderation bot
• Site - resources, guides, and more

Where to start

Read our contributing guidelines
Chat with us in #dev-contrib if you're ready to jump in or have any questions
Open an issue or ask to be assigned to an issue to work on

stable mountainBOT Oct 29, 2021, 1:53 AM

#

rapid igloo !remind 12H make people not able to cheat in candies ^

It has arrived!

Here's your reminder: make people not able to cheat in candies ^
[Jump back to when you created the reminder](#dev-contrib message)

rapid igloo Oct 29, 2021, 1:55 AM

#

gah okay

rapid igloo Oct 29, 2021, 3:05 AM

#

done

molten perch Oct 29, 2021, 10:27 AM

#

Hey, @gritty wind! As for site#618, would you mind opening an issue in the API repo as well? So that we can keep the models up-to-date! 🙂 (If you're busy, I can open it as well)

dusky shoreBOT Oct 29, 2021, 10:27 AM

#

GitHub

PROpen Adds Failures Field To Reminders

gritty wind Oct 29, 2021, 10:51 AM

#

I’ll open it once it’s approved for site

#

It probably wouldn’t make sense to open it now when it can still change

summer garden Oct 29, 2021, 1:44 PM

#

Is there a quick way of reloading a cog after changes when using lancebot with docker?

dim pelican Oct 29, 2021, 1:45 PM

#

From your discord server, .c r <your cog>

#

Also, good catch on the color review, totally blanked when I was writing those BadArgument calls for the color ranges

short snow Oct 29, 2021, 1:53 PM

#

@dim pelican regarding your error, if you would still get it as you haven't specified trashcan emote, did you read by point 1?

#

Or by error you mean that the .colour rgb(etc) aren't being catched?

#

try adding invoke_without_command=True on the group deco

dim pelican Oct 29, 2021, 1:54 PM

#

I'll have to try it when I'm back at my testing setup

dim pelican Oct 29, 2021, 1:54 PM

#

short snow try adding `invoke_without_command=True` on the group deco

!remind 8h this

stable mountainBOT Oct 29, 2021, 1:54 PM

#

Can do!

Your reminder will arrive on <t:1635544483:F>!

short snow Oct 29, 2021, 1:55 PM

#

okay 👍

cold island Oct 29, 2021, 2:00 PM

#

@timid sentinel @last patio changes addressed in bot#1793 👉👈

dusky shoreBOT Oct 29, 2021, 2:00 PM

#

GitHub

PROpen Clean Cog Rework

stable mountainBOT Oct 29, 2021, 2:31 PM

#

static canyon !remind 1d Do this

It has arrived!

Here's your reminder: Do this
[Jump back to when you created the reminder](#dev-contrib message)

last patio Oct 29, 2021, 4:22 PM

#

oof i’ll try to review it tomorrow on my 12h shift

#

!remind 15h bot#1793

stable mountainBOT Oct 29, 2021, 4:22 PM

#

You got it!

Your reminder will arrive on <t:1635578572:F>!

dusky shoreBOT Oct 29, 2021, 4:22 PM

#

GitHub

PROpen Clean Cog Rework

stable mountainBOT Oct 29, 2021, 5:31 PM

#

static canyon !remind 34h Issue for providing exact end time instead of relative time on `!rem...

It has arrived!

Here's your reminder: Issue for providing exact end time instead of relative time on !remind
[Jump back to when you created the reminder](#dev-contrib message)

cold island Oct 29, 2021, 6:29 PM

#

last patio oof i’ll try to review it tomorrow on my 12h shift

Thanks, there's no rush 😄 just wasn't sure you saw it

left flume Oct 29, 2021, 7:37 PM

#

im new to the syntax of the bots here
i wanted to replace the reactions in the bookmark command with buttons
is this correct? https://github.com/InvisibleOS/sir-lancebot/blob/main/bot/exts/utilities/bookmark.py
i just have to make a few more changes to the text in the embeds. apart from that, i need to add a timeout as well to delete the message.

vale ibex Oct 29, 2021, 8:03 PM

#

Could you open an issue on sir-lancebot's repo with your proposed changes?

#

We can then discuss them and see if it's something we're interested in having on the bot

#

preferably this is done before you actually write any code, since then you don't waste your time if it ends up getting rejected

summer garden Oct 29, 2021, 8:21 PM

#

@dim pelican let me know if you're testing sir-lancebot#842 and things don't seem to be adding up. I think there is some confusion on the pr

dusky shoreBOT Oct 29, 2021, 8:21 PM

#

GitHub

PROpen Add color command

dim pelican Oct 29, 2021, 8:37 PM

#

summer garden <@!698273827448291379> let me know if you're testing sir-lancebot#842 and things...

omg...I see what you mean

summer garden Oct 29, 2021, 8:38 PM

#

dim pelican omg...I see what you mean

Have you noticed that embed descriptions seems to be unhelpful at best? HSB information for 20. Random information for Pigeon Post. I'm wondering if we could throw some other info in it's place

#

"random information" doesn't sound like you're giving a random color

#

I had an idea that if you use the random subcommand, a reaction pops up 🔄 so you can get a new color without retyping the command. It's probably best left for another time, once this is pushed

stable mountainBOT Oct 29, 2021, 9:54 PM

#

dim pelican !remind 8h this

It has arrived!

Here's your reminder: this
[Jump back to when you created the reminder](#dev-contrib message)

trail pilot Oct 29, 2021, 10:18 PM

#

@thorny obsidian
So, the unicode trickery is working, would we want to have syntax highlighting? I think I'd likely have to avoid keywords so we can still keep syntax highlighting, here's how it looks

trail pilot Oct 29, 2021, 10:39 PM

#

Also experimenting a feature where it shows the amount of people that have answered so far

#

The only problem with this would be ratelimits

clever wraith Oct 29, 2021, 10:56 PM

#

Yes, just rename it like you'd rename any repo

#

Hopefully\™

fallen patrol Oct 30, 2021, 12:22 AM

#

eheheehehe this reminds me of when i accidently made a repo after renaming

#

so uh the gist here is that yknow how github does the auto redirects

#

eg https://github.com/discord-python/bot goes to python discord

GitHub

GitHub - python-discord/bot: The community bot for the Python Disco...

The community bot for the Python Discord community - GitHub - python-discord/bot: The community bot for the Python Discord community

#

well what happened is i made one of those redirect repos by mistake because i made a fork of a repo with the same name ;-;

#

turns out if you delete it fast enough or something github keeps those redirects

trail pilot Oct 30, 2021, 1:04 AM

#

Hm, would you all think a .joke command would be cool, just like a simple Python joke pulled from a text file (maybe a YAML if it’s different for different chats) like "What is a backend developer’s favorite kids game?", answer is "Jenga"

summer garden Oct 30, 2021, 1:04 AM

#

that would be quite fun

trail pilot Oct 30, 2021, 1:04 AM

#

or "What did the coroutine say to the event loop?", answer is "await! I’m almost done"

#

actually that one doesn’t make much sense

#

"What is a Python programmer’s favorite song?", answer "Blank Space by Taylor Swift", these are just a few examples

austere hornet Oct 30, 2021, 1:44 AM

#

trail pilot Hm, would you all think a `.joke` command would be cool, just like a simple Pyth...

I love that idea!

rapid igloo Oct 30, 2021, 5:55 AM

#

your fork is yours and it has nothing much to do with the main repo. you can even create a fresh new repo named something ridiculous but pull main repo's commits locally, make your changes, then PR to upstream. it'd work afaik as long as the repo histories match

#

4 lines PR for reviews, anyone? sir-lancebot#931

dusky shoreBOT Oct 30, 2021, 6:05 AM

#

GitHub

PROpen Candy Game: Ignore reactions to bot messages when adding candies

gritty wind Oct 30, 2021, 6:25 AM

#

rapid igloo 4 lines PR for reviews, anyone? sir-lancebot#931

Merged

left flume Oct 30, 2021, 7:00 AM

#

any opinions on sir-lancebot#932 ?

dusky shoreBOT Oct 30, 2021, 7:00 AM

#

GitHub

IssueOpen Replace reactions in the bookmark command with buttons.

stable mountainBOT Oct 30, 2021, 7:22 AM

#

last patio !remind 15h bot#1793

It has arrived!

Here's your reminder: bot#1793
[Jump back to when you created the reminder](#dev-contrib message)

fallen patrol Oct 30, 2021, 7:35 AM

#

left a review on the colour command 😅

last patio Oct 30, 2021, 8:09 AM

#

good bot

fallen patrol Oct 30, 2021, 8:55 AM

#

last patio good bot

im not a bot smh

timid sentinel Oct 30, 2021, 9:40 AM

#

@cold island @cold island @cold island clean is heeeeere!!!

cold island Oct 30, 2021, 9:40 AM

#

oh yeeeee

#

I was actually just looking at it and noticed kwzrd's comment about time.time()

#

So many I should've changed that

#

but it seems to work blobshrug

clever wraith Oct 30, 2021, 9:42 AM

#

Clean rework is merged?

short snow Oct 30, 2021, 9:42 AM

#

yep

clever wraith Oct 30, 2021, 9:43 AM

#

Woooooo

cold island Oct 30, 2021, 9:44 AM

#

!help clean

stable mountainBOT Oct 30, 2021, 9:44 AM

#

Command Help

!clean [users] [traverse] [first_limit] [second_limit] [use_cache] [bots_only=False] [regex] [channels]
Can also use: clear, purge

*Commands for cleaning messages in channels.

If arguments are provided, will act as a master command from which all subcommands can be derived.

• users: A series of user mentions, ID's, or names.
• traverse: The number of messages to look at in each channel. If using the cache, will look at the first traverse messages in the cache.
• first_limit and second_limit: A message, a duration delta, or an ISO datetime. If a message is provided, cleaning will happen in that channel, and channels cannot be provided. If a limit is provided, multiple channels cannot be provided. If only one of them is provided, acts as clean until. If both are provided, acts as clean between.
• use_cache: Whether to use the message cache. If not provided, will default to False unless an asterisk is used for the channels.
• bots_only: Whether to delete only bots. If specified, users cannot be specified.
• regex: A regex pattern the message must contain to be deleted. The pattern must be provided enclosed in backticks. If the pattern contains spaces, it still needs to be enclosed in double quotes on top of that.
• channels: A series of channels to delete in, or an asterisk to delete from all channels.*

Subcommands:

!clean all [traverse=10] [use_cache=True] [channels]
Delete all messages, regardless of poster, stop cleaning after traversing traverse messages.
!clean between <first_limit> <second_limit> [channel]
Delete all messages within range.
!clean bots [traverse=10] [use_cache=True] [channels]
Delete all messages posted by a bot, stop cleaning after traversing traverse messages.
!clean regex <regex> [traverse=10] [use_cache=True] [channels]
Delete all messages that match a certain regex, stop cleaning after traversing traverse messages.
!clean stop
If there is an ongoing cleaning process, attempt to immediately cancel it.
!clean until <until> [channel]
Delete all messages until a certain limit.
!clean user <user> [traverse=10] [use_cache=True] [channels]
Delete messages posted by the provided user, stop cleaning after traversing traverse messages.

cold island Oct 30, 2021, 9:44 AM

#

Look at that big boy

short snow Oct 30, 2021, 9:44 AM

#

welp

clever wraith Oct 30, 2021, 9:49 AM

#

Two full screens on mobile, heh

short snow Oct 30, 2021, 9:51 AM

#

One more review :lemon_plead: bot#1446

dusky shoreBOT Oct 30, 2021, 9:51 AM

#

GitHub

PROpen Enhancing information within the incidents channel.

vocal wolf Oct 30, 2021, 10:07 AM

#

cold island !help clean

yooo

dim pelican Oct 30, 2021, 11:13 AM

#

sir-lancebot#842 needs reviews / testing. Will let the reviews come in before adding more commits.

dusky shoreBOT Oct 30, 2021, 11:13 AM

#

GitHub

PROpen Add color command

dim pelican Oct 30, 2021, 11:13 AM

#

dim pelican sir-lancebot#842 needs reviews / testing. Will let the reviews come in before ad...

!remind 5d Check, implement, test reviews for color command

stable mountainBOT Oct 30, 2021, 11:14 AM

#

Aye aye, cap'n!

Your reminder will arrive on <t:1636024440:F>!

fervent sage Oct 30, 2021, 12:00 PM

#

trail pilot Also experimenting a feature where it shows the amount of people that have answe...

e: none of the above

rapid igloo Oct 30, 2021, 12:14 PM

#

1\ngoodbye\n? :P

fervent sage Oct 30, 2021, 12:19 PM

#

yes

dim pelican Oct 30, 2021, 12:31 PM

#

Anyone else getting an error when running sir-lancebot's main branch on docker?

#

Right now it is saying it cannot find the duck game's all_cards.png. Seems like it thinks the current directory is in bot instead of sir-lancebot.

#

sir-lancebot    | FileNotFoundError: [Errno 2] No such file or directory: '/bot/bot/resources/evergreen/all_cards.png'
sir-lancebot    |
sir-lancebot    | The above exception was the direct cause of the following exception:
sir-lancebot    | discord.ext.commands.errors.ExtensionFailed: Extension 'bot.exts.fun.duck_game' raised an error: FileNotFoundError: [Errno 2] No such file or directory: '/bot/bot/resources/evergreen/all_cards.png'

clever wraith Oct 30, 2021, 12:34 PM

#

The directory is actually correct, we place our code in /bot

#

Although I'm not sure why the file isn't present

dim pelican Oct 30, 2021, 12:35 PM

#

So I should rename my local fork folder to bot instead of sir-lancebot?

#

It is definitely present: sir-lancebot\bot\resources\fun\all_cards.png

clever wraith Oct 30, 2021, 12:36 PM

#

I don't see that error in prod

#

No no, it should be correct

#

Can you try to rebuild the image?

dim pelican Oct 30, 2021, 12:37 PM

#

Yeah I've built down and up but let me try again

clever wraith Oct 30, 2021, 12:37 PM

#

Oh wait, the path is indeed wrong

#

evergreen isn't a thing anymore

#

But the code on main is correct

#

Did you pulled everything and all?

dim pelican Oct 30, 2021, 12:38 PM

#

Yeah I did pull, it didn't remove the folder locally though

#

Interesting

clever wraith Oct 30, 2021, 12:40 PM

#

What's the full traceback?

dim pelican Oct 30, 2021, 12:40 PM

#

My folders are still present locally even after the restructure

clever wraith Oct 30, 2021, 12:41 PM

#

How weird

#

Does git status give you untracked files?

dim pelican Oct 30, 2021, 12:41 PM

#

nope

clever wraith Oct 30, 2021, 12:42 PM

#

Does git log -1 give you ba4b0e4?

dim pelican Oct 30, 2021, 12:43 PM

#

No, since I'm on my fork and merged from upstream

clever wraith Oct 30, 2021, 12:44 PM

#

Aaah

#

Fork link?

dim pelican Oct 30, 2021, 12:44 PM

#

Mine?

clever wraith Oct 30, 2021, 12:45 PM

#

Whichever you are using, yes

dim pelican Oct 30, 2021, 12:45 PM

#

https://github.com/brad90four/sir-lancebot

clever wraith Oct 30, 2021, 12:46 PM

#

Okay, seems like your history is heavily messed up

dim pelican Oct 30, 2021, 12:46 PM

#

lol

clever wraith Oct 30, 2021, 12:46 PM

#

I can tell you how to fix it, but honestly I'd recommend you to just be working on the upstream

#

git fetch upstream
git checkout upstream/main
git push --force origin main
```to fix your main branch

dim pelican Oct 30, 2021, 1:12 PM

#

Had a gnarly rebase but should be good now

clever wraith Oct 30, 2021, 1:13 PM

#

Looks about right

dim pelican Oct 30, 2021, 1:17 PM

#

Thanks btw!

trail pilot Oct 30, 2021, 2:47 PM

#

fervent sage e: none of the above

Oops, I rushed the answers to test out the feature so I didn’t check for validity

molten perch Oct 30, 2021, 3:59 PM

#

Hey! Just a quick question. I'm not very familiar with django tests. Does it set up an empty database for each test? Also, is that something that we want to include in the new API?

gritty wind Oct 30, 2021, 4:03 PM

#

It restores it for each case

#

Assuming we're using django's testing utilities

#

let me check actually

#

Nah it should restore it to empty

molten perch Oct 30, 2021, 4:05 PM

#

Cool, so I guess it should do the same thing in case of the new API as well, right?

gritty wind Oct 30, 2021, 4:05 PM

#

For the new API, I think it's probably better if we don't have a test database, and just have pure unittests

#

Like I can't think of much we'd gain over a purely functional approach (and maybe mocking out DB calls if we have to?)

Django does a lot of heavy lifting to get the unittests to work properly when you're dealing with mock DBs

#

And it limits our expansion potential for things like parallelization

molten perch Oct 30, 2021, 4:11 PM

#

Okay then, but if we don't have an actual test database how are we gonna test out if it actually works? (Mocking DB calls does not seem to be a good solution for me, many things could go wrong with DB relationships and such things.)

short snow Oct 30, 2021, 4:14 PM

#

https://fastapi.tiangolo.com/advanced/testing-database/

Testing a Database - FastAPI

FastAPI framework, high performance, easy to learn, fast to code, ready for production

gritty wind Oct 30, 2021, 4:18 PM

#

molten perch Okay then, but if we don't have an actual test database how are we gonna test ou...

What you're referring to would be integration testing I believe, and I'm not sure what there is to go wrong. The way I see it, the API does one thing:

Take data, analyze it, return response

The DB comes in at the analysis step, and this is where we can use mocking. This is the code worth testing imo.

I don't really follow what can go wrong with the DB itself. Could you clarify

gritty wind Oct 30, 2021, 4:19 PM

#

short snow https://fastapi.tiangolo.com/advanced/testing-database/

You'll notice fastapi doesn't actually do anything here, this is just a general guide

#

It's still up to us to configure the creation of the DB, make sure it gets migrated, and handle cleaning

#

That's the part django handles

#

We'd also have to inject parts of this into the test cleaners so it can clean the DB between each test

molten perch Oct 30, 2021, 4:21 PM

#

gritty wind We'd also have to inject parts of this into the test cleaners so it can clean th...

Yeah, actually. I was thinking about a pytest fixture.

gritty wind Oct 30, 2021, 4:21 PM

#

It's a lot of work, and I'm not convinced integration tests will be all that useful yet

#

I'm looking through the test suite now

molten perch Oct 30, 2021, 4:23 PM

#

Actually, since the new API has to be totally compatible with the codebase of bot, I had to make a few adjustments. (like when filtering reminders you use "author__id")
So, I would be more comfortable if I had integration tests, but it's your call to be honest 😄
I'm not yet done with the reminder endpoints (Still haven't implemented the DELETE and PATCH ops.) so it's still far away.

gritty wind Oct 30, 2021, 4:23 PM

#

And I'm not seeing anything actually utilizing the integration rn

#

Mostly just mocking

gritty wind Oct 30, 2021, 4:24 PM

#

molten perch Actually, since the new API has to be totally compatible with the codebase of bo...

Could you elaborate on this

molten perch Oct 30, 2021, 4:27 PM

#

Sure,
so https://github.com/python-discord/bot/blob/main/bot/exts/utils/reminders.py#L266
Django has this double underscore syntax, although as far as I know SQLAlchemy does not.
I had to create an alias to handle this (Pydantic alias).
So, there are a few pitfalls like this. That's why I wasn't sure about how to write the tests.

stable mountainBOT Oct 30, 2021, 4:27 PM

#

bot/exts/utils/reminders.py line 266

'author__id': str(ctx.author.id)```

gritty wind Oct 30, 2021, 4:27 PM

#

Well, if it's a pydantic alias, that'd still fall under the unit testing portion, not something we need to mock out

#

On the DB side, it'd be the exact same

molten perch Oct 30, 2021, 5:05 PM

#

Okay then. I'll open a PR sooner or later. 😄

#

Although, I'm not sure why this is here, then. (btw. it's not that big of a work to set those integration tests up)
https://github.com/python-discord/api/blob/main/.github/workflows/lint-test.yml#L29:L41

stable mountainBOT Oct 30, 2021, 5:09 PM

#

.github/workflows/lint-test.yml lines 29 to 41

# Via https://github.com/actions/example-services/blob/main/.github/workflows/postgres-service.yml
# services:
#   postgres:
#     image: postgres:13
#     env:
#       POSTGRES_USER: postgres
#       POSTGRES_PASSWORD: postgres
#       POSTGRES_DB: postgres
#     ports:
#     # Assign a random TCP port
#     - 5432/tcp
#     # needed because the postgres container does not provide a healthcheck
#     options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5```

gritty wind Oct 30, 2021, 6:04 PM

#

PostgreSQL is already set up and configured for later, and simply needs to be commented out to start.
I don't think there was anything planned for it yet, just migrated from site just in case

molten perch Oct 30, 2021, 6:58 PM

#

I see, I haven't done Mocking before, so I'll have to hit up the documentation, but it's gonna be fine. 😄

trail pilot Oct 30, 2021, 6:59 PM

#

( Bit off-topic but congrats @molten perch on helper! )

molten perch Oct 30, 2021, 7:00 PM

#

Thank you! 😄

austere hornet Oct 30, 2021, 7:05 PM

#

Congrats @molten perch !

fallen patrol Oct 30, 2021, 7:40 PM

#

molten perch I see, I haven't done Mocking before, so I'll have to hit up the documentation, ...

tldr mocking is fun (please save me)

molten perch Oct 30, 2021, 8:53 PM

#

gritty wind > PostgreSQL is already set up and configured for later, and simply needs to be ...

Alright, I finished the implementation of the reminder endpoints and the first batch of tests. (The ones that test the Token Auth)
But now I'm in a bit of a confusion, what and how to test next.
So, like how would I do the Mocking if I have to create a test user and a bunch of Reminders? Or Do I even have to test those?
(like: https://github.com/python-discord/site/blob/main/pydis_site/apps/api/tests/test_reminders.py#L49)

stable mountainBOT Oct 30, 2021, 8:53 PM

#

pydis_site/apps/api/tests/test_reminders.py line 49

class ReminderCreationTests(AuthenticatedAPITestCase):```

gritty wind Oct 30, 2021, 8:55 PM

#

That's highly dependent on the code being tested. For the most part, I imagine you have the code that performs all the logic (get the request, find the appropriate action, parse arguments, etc, etc -> return some other data), and somewhere in the middle of that, you want to access database objects?

#

The simplest method to do that would be to mock the return of the database request and return your own User, reminder model, etc

#

It's basically what the current site does, it just defines the model, adds it to the DB, fetches it from the DB, and then uses that model

#

If you notice there, adding to the DB and fetching from the DB doesn't actually accomplish anything

molten perch Oct 30, 2021, 9:01 PM

#

Yeah, actually (at least for me) by just defining a fixture that creates a test database and returns a session then when the test ends it tears down everything seems like an easier solution, since the database queries are not tied to the database models, you just pass them as arguments when you query something using sqlalchemy, that makes it harder to mock this chain of method calling (I'm referring to requests such as session.query(Reminder).filter_by(content="test").all())

gritty wind Oct 30, 2021, 9:02 PM

#

I don't think so, at least in that case, why would you add anything to your test DB besides reminders that have that content

#

You don't need to verify that filter_by(content="test") will work correctly, that's a reasonable thing to take as fact

#

Also, one of the reasons I'm so hard against having a test DB is because it adds an extra layer of complexity, which we'll then have to maintain, and will make it difficult for us to do certain things (I have test parallelization mind right now, just going off the test times in site), and can lead to non-reproducible tests

#

Look at it this way, you'll either put the effort into mocking the db, or creating it, cleaning it, and maintaining it

#

It's more effort to do that latter, and imo has much less ROI

molten perch Oct 30, 2021, 9:08 PM

#

Okay, it makes sense. I think I can mock the fastapi dependency that creates db sessions this way it'll be much easier 🤔

brisk brook Oct 30, 2021, 9:09 PM

#

The dependency injection system was designed so that you could easily just pass arguments that would override the Depends

molten perch Oct 30, 2021, 9:09 PM

#

Yeah, I didn't realise it right until now. 😄

#

Thank you! 😄

gritty wind Oct 30, 2021, 9:11 PM

#

If you're still creating DB sessions, will that alleviate the aforementioned problems?

molten perch Oct 30, 2021, 9:12 PM

#

I believe so, yes!

clever wraith Oct 31, 2021, 4:57 AM

#

congrats on helper @molten perch

gritty wind Oct 31, 2021, 11:47 AM

#

More activity on metricity in the past 10 minutes than the past 10 months

#

At least we get to experience github's real time message fetching lemon_clown

#

How long does discord cache external images

#

I'd like to see my new PFP one of these days

patent pivot Oct 31, 2021, 11:56 AM

#

gritty wind More activity on metricity in the past 10 minutes than the past 10 months

HELL yeah

vale ibex Oct 31, 2021, 12:43 PM

#

@patent pivot question...should I strip tzinfo, or migrate to aware dts in db for metricity

#

since 2.0 is aware now 🤡

patent pivot Oct 31, 2021, 1:07 PM

#

vale ibex <@!165023948638126080> question...should I strip tzinfo, or migrate to aware dts...

hmmm

#

I think either is fine

#

are there any scenarios where one is better than the other

vale ibex Oct 31, 2021, 1:15 PM

#

Not really, psql stores in utc anyway, so I should just be able to set it on connection that I was aware dts

#

Just need to look around gino/sqlalch when I'm back later

#

I'll go with aware then, since it should just be a connection change, rather than shoving to strip tzinfo everywhere

green oriole Oct 31, 2021, 1:26 PM

#

gritty wind How long does discord cache external images

Infinitedly, you need to yeet the cache

gritty wind Oct 31, 2021, 1:28 PM

#

How 2 do that

green oriole Oct 31, 2021, 1:35 PM

#

gritty wind How 2 do that

What OS?

gritty wind Oct 31, 2021, 1:36 PM

#

What

#

Web 🤡

#

I’m referring to #dev-log

#

I hard reset my own cache if thats what you mean

green oriole Oct 31, 2021, 1:36 PM

#

I mean what client are you using

#

Yeah, if you use web just yeet your browser cache on the cdn domain

gritty wind Oct 31, 2021, 1:36 PM

#

Discord windows, but even following that link anywhere it’s still the old image. Are you seeing the new one?

green oriole Oct 31, 2021, 1:37 PM

#

That's weird, I do

#

Can you delete %appdata%/discord/cache

gritty wind Oct 31, 2021, 1:38 PM

#

I could try another hard reload now

#

Everything is gonna take ages to load now, brb :P

#

Pfffft it's still the old one lmao

#

I guess it's not meant to be

green oriole Oct 31, 2021, 1:41 PM

#

How weird

scenic moth Oct 31, 2021, 2:15 PM

#

how to get !d help for list.insert ?

brazen charm Oct 31, 2021, 2:17 PM

#

the docs don't define a symbol for it so you can't directly

scenic moth Oct 31, 2021, 2:34 PM

#

._.

vale ibex Oct 31, 2021, 2:35 PM

#

As far as I can see, since d.py changed how they store user's avatars, there isn't an easy way to generate a backwards-compatible hash

#

My d.py 2.0 hash:```py
In [2]: hash(ctx.author.display_avatar)
Out[2]: 1811796705115642717

My d.py 1.7 hash: `a_2970a2477a6b8a040f740abc068b4d26`

#

Ahhhh nevermind. It's now referred to as the Asset's "key"

#

IE ctx.author.display_avatar.key

green oriole Oct 31, 2021, 2:38 PM

#

I was about to say, heh

vale ibex Oct 31, 2021, 2:39 PM

#

Alright, since I'm here, opinions on whether we should store both guild and user avatars hash's in metricity?

#

CC @patent pivot

#

atm we only store the user's hash, so I could add a new column to store the guild specific hash too

brisk brook Oct 31, 2021, 2:41 PM

#

vale ibex My d.py 2.0 hash:```py In [2]: hash(ctx.author.display_avatar) Out[2]: 181179670...

Lol in the first one I think you were hashing the memory location lol

#

!e print(hash(object()))

stable mountainBOT Oct 31, 2021, 2:41 PM

#

@brisk brook :white_check_mark: Your eval job has completed with return code 0.

8792879756307

vale ibex Oct 31, 2021, 2:41 PM

#

brisk brook Lol in the first one I think you were hashing the memory location lol

nah lol, Asset implements dunder hash

brisk brook Oct 31, 2021, 2:41 PM

#

vale ibex nah lol, Asset implements dunder hash

Ah

vale ibex Oct 31, 2021, 2:41 PM

#

(which led to the confusion)

#

Since I had assumed the dunder hash of an avatar would return the same value as what used to be called the avatar_hash

#

shrugR

brisk brook Oct 31, 2021, 2:43 PM

#

I think they hash the hash though

#

!e print(hash('a_2970a2477a6b8a040f740abc068b4d26'))

stable mountainBOT Oct 31, 2021, 2:44 PM

#

@brisk brook :white_check_mark: Your eval job has completed with return code 0.

2074662032031832231

brisk brook Oct 31, 2021, 2:44 PM

#

I guess not..

vale ibex Oct 31, 2021, 2:45 PM

#

It's a hash of the cdn url now

brisk brook Oct 31, 2021, 2:45 PM

#

Ooh, I guess that makes sense

vale ibex Oct 31, 2021, 2:53 PM

#

aaaaall right, I think that's d.py 2.0 and threads working in metricity

#

nvm lol, the message event triggers before the thread create event

patent pivot Oct 31, 2021, 3:01 PM

#

vale ibex atm we only store the user's hash, so I could add a new column to store the guil...

yea sounds good to me

static canyon Oct 31, 2021, 5:22 PM

#

Why isn't the lint-test showing under checks for bot#1901?

dusky shoreBOT Oct 31, 2021, 5:22 PM

#

GitHub

PROpen Migrate to og_blurple

green oriole Oct 31, 2021, 5:23 PM

#

static canyon Why isn't the lint-test showing under `checks` for bot#1901?

it isn't running because you have conficts

static canyon Oct 31, 2021, 5:23 PM

#

Ah right

#

Now I need to remember how to resolve conflicts when it's "too complex" for doing in the website

green oriole Oct 31, 2021, 5:26 PM

#

static canyon Now I need to remember how to resolve conflicts when it's "too complex" for doin...

git fetch origin
git merge origin/main```

static canyon Oct 31, 2021, 5:27 PM

#

Thanks

#

I think I broke my bot

#

It just mutes me for every message I send saying "burst"

#

I don't even know how

green oriole Oct 31, 2021, 5:28 PM

#

LOL

#

what is your config thresold?

#

if you set it to one that'd be the issue

static canyon Oct 31, 2021, 5:29 PM

#

It looks like the value isn't resetting

static canyon Oct 31, 2021, 5:30 PM

#

green oriole what is your config thresold?

anti_spam:
    # Clean messages that violate a rule.
    clean_offending: true
    ping_everyone: true

    punishment:
        remove_after: 600
        role_id: *MUTED_ROLE

    rules:
        attachments:
            interval: 10
            max: 6

        burst:
            interval: 10
            max: 7```do you mean this?

green oriole Oct 31, 2021, 5:30 PM

#

yes

static canyon Oct 31, 2021, 5:30 PM

#

I haven't touched anything to do with antispam so I'm really confused as to why this is happening

green oriole Oct 31, 2021, 5:30 PM

#

how weird

#

is daylight saving doing some funky stuff haha

static canyon Oct 31, 2021, 5:31 PM

#

I mean maybe?

#

My laptop time is set an hour behind

#

Maybe that's why?

green oriole Oct 31, 2021, 5:31 PM

#

to me it seems like some timestamp isn't calculated correctly

#

that could be why

static canyon Oct 31, 2021, 5:32 PM

#

Thanks windows

#

It's 5pm not 4pm

#

It's even set to London timezone

#

Wtf is going on lol

green oriole Oct 31, 2021, 5:32 PM

#

10/10

static canyon Oct 31, 2021, 5:32 PM

#

The messages I'm sending are freaking out too

#

It initially shows sent time as 16:32 (laptop time) then discord corrects it

green oriole Oct 31, 2021, 5:33 PM

#

the UK is switching during the Saturday to Sunday night, right?

static canyon Oct 31, 2021, 5:33 PM

#

Yeah

green oriole Oct 31, 2021, 5:33 PM

#

how weird

static canyon Oct 31, 2021, 5:33 PM

#

I think my laptop went back an hour twice?

green oriole Oct 31, 2021, 5:33 PM

#

doesn't seem like it applied daylight saving

static canyon Oct 31, 2021, 5:33 PM

#

The thing is I was just in greece (2 hrs ahead of england) so maybe that screwed with it

#

I have no clue

green oriole Oct 31, 2021, 5:34 PM

#

have you restarted since?

static canyon Oct 31, 2021, 5:34 PM

#

yeah

#

Several times

green oriole Oct 31, 2021, 5:34 PM

#

are you dual booting?

static canyon Oct 31, 2021, 5:34 PM

#

yes

#

Win & Linux

green oriole Oct 31, 2021, 5:35 PM

#

please tell me not with ubuntu

static canyon Oct 31, 2021, 5:35 PM

#

Linux Mint

green oriole Oct 31, 2021, 5:35 PM

#

Okay, I don't know if this screws with the BIOS time or not

static canyon Oct 31, 2021, 5:35 PM

#

I mean I just manually set the time to 17:35 (correct) and I'm still getting auto-muted

green oriole Oct 31, 2021, 5:36 PM

#

even after a bot restart?

static canyon Oct 31, 2021, 5:36 PM

#

let's try

#

I restarted before realising my laptop time was fucked

green oriole Oct 31, 2021, 5:37 PM

#

my bot is starting if you wanna check

static canyon Oct 31, 2021, 5:37 PM

#

Okay, it seems to be fixed

hoary anvil Oct 31, 2021, 5:38 PM

#

@static canyon linux and windows don't play nice with bios time

#

windows sets local time and displays it, linux sets utc, stores offset, and displays calculated local

#

or vice versa

#

so they set it differently unless you live in utc all year

#

I've always had the same issue

static canyon Oct 31, 2021, 5:40 PM

#

hoary anvil so they set it differently unless you live in utc all year

I'm utc half the year and utc+1 the other half

#

And yes, it's still very much broken

hoary anvil Oct 31, 2021, 5:41 PM

#

interesting

static canyon Oct 31, 2021, 5:42 PM

#

As long as I manually set time on windows it's fine

#

But as soon as I go back to automatic, although my laptop stays the same time, the bot starts muting me

gritty wind Oct 31, 2021, 5:42 PM

#

It doesn’t like time travelers

static canyon Oct 31, 2021, 5:44 PM

#

Whhhyyyyy isn't this working

#

Okay so even setting time manually doesn't work

#

I am completely and utterly fucked

#

@hoary anvil @green oriole Do either of you know how to get around this?

green oriole Oct 31, 2021, 5:46 PM

#

pain and suffering

static canyon Oct 31, 2021, 5:46 PM

#

>>> datetime.datetime.now().hour
17```

#

Datetime still gives the right time

green oriole Oct 31, 2021, 5:47 PM

#

timedatectl set-local-rtc 1 --adjust-system-clock on Linux could help

static canyon Oct 31, 2021, 5:47 PM

#

So I honestly don't know what's happening

green oriole Oct 31, 2021, 5:47 PM

#

huh, how weird

cold island Oct 31, 2021, 5:47 PM

#

Why isn't what working

static canyon Oct 31, 2021, 5:47 PM

#

cold island Why isn't what working

I'm dual booting Win & Linux which is causing funkiness in the antispam detection

#

It keeps saying I'm breaking burst rules

cold island Oct 31, 2021, 5:48 PM

#

uuh where are you running the bot?

#

Windows?

static canyon Oct 31, 2021, 5:48 PM

#

Windows

cold island Oct 31, 2021, 5:48 PM

#

In Docker?

static canyon Oct 31, 2021, 5:48 PM

#

Yea

cold island Oct 31, 2021, 5:48 PM

#

Restart WSL?

static canyon Oct 31, 2021, 5:48 PM

#

WSL?

#

I'm not using WSL

#

I'm dual booting

#

I have a physical installation of both Windows 10 and Linx Mint on my drive

cold island Oct 31, 2021, 5:50 PM

#

Ok but you're saying you're running the bot in Windows through Docker. I'm not sure how the Linux installation is related

static canyon Oct 31, 2021, 5:50 PM

#

hoary anvil <@442244135840382978> linux and windows don't play nice with bios time

^ 🤷

green oriole Oct 31, 2021, 5:50 PM

#

cold island Ok but you're saying you're running the bot in Windows through Docker. I'm not s...

Linux and Windows doesn't use the same BIOS time system and just fuck each other up

cold island Oct 31, 2021, 5:51 PM

#

But I mean

#

Isn't the bot getting the same amount of events?

static canyon Oct 31, 2021, 5:51 PM

#

It could be something other than the dual booting

#

But I don't know what because I didn't touch any antispam code

hoary anvil Oct 31, 2021, 5:51 PM

#

static canyon <@!473859714162360320> <@!407110650217627658> Do either of you know how to get a...

sadly not

green oriole Oct 31, 2021, 5:51 PM

#

yes, except it is trying to count messages in the past 1h10s instead of 10s

cold island Oct 31, 2021, 5:52 PM

#

Wait

static canyon Oct 31, 2021, 5:52 PM

#

green oriole yes, except it is trying to count messages in the past 1h10s instead of 10s

I guess this is the case maybe I don't know

hoary anvil Oct 31, 2021, 5:52 PM

#

but I barely use windows on my main pc so idrc

cold island Oct 31, 2021, 5:52 PM

#

But what does the Linux install have to do with where the bot is running

static canyon Oct 31, 2021, 5:52 PM

#

Nothing

cold island Oct 31, 2021, 5:53 PM

#

So you're running it in Docker. Is Docker using WSL or Hyper-V?

static canyon Oct 31, 2021, 5:53 PM

#

cold island So you're running it in Docker. Is Docker using WSL or Hyper-V?

How do I tell?

cold island Oct 31, 2021, 5:53 PM

#

If you installed it recently it's probably WSL

green oriole Oct 31, 2021, 5:53 PM

#

do you have a win pro edition

static canyon Oct 31, 2021, 5:53 PM

#

green oriole do you have a win pro edition

No, home

green oriole Oct 31, 2021, 5:53 PM

#

then WSL

cold island Oct 31, 2021, 5:54 PM

#

Ok, so as a first step I suggest restarting WSL

#

If it doesn't work we can think of something else

static canyon Oct 31, 2021, 5:54 PM

#

How do I restart WSL?

cold island Oct 31, 2021, 5:54 PM

#

Don't remember the command, I'll check

green oriole Oct 31, 2021, 5:54 PM

#

wsl.exe --shutdown

cold island Oct 31, 2021, 5:54 PM

#

or that

green oriole Oct 31, 2021, 5:55 PM

#

I have speed_module_3

static canyon Oct 31, 2021, 5:55 PM

#

#

I guess restart?

cold island Oct 31, 2021, 5:55 PM

#

yeah

static canyon Oct 31, 2021, 5:56 PM

#

I just realised the logs in the terminal have time as 16: instead of 17:

#

erm```py
Traceback (most recent call last):
File "docker\api\client.py", line 214, in _retrieve_server_version
File "docker\api\daemon.py", line 181, in version
File "docker\utils\decorators.py", line 46, in inner
File "docker\api\client.py", line 237, in _get
File "requests\sessions.py", line 543, in get
File "requests\sessions.py", line 530, in request
File "requests\sessions.py", line 643, in send
File "requests\adapters.py", line 439, in send
File "urllib3\connectionpool.py", line 670, in urlopen
File "urllib3\connectionpool.py", line 392, in _make_request
File "http\client.py", line 1255, in request
File "http\client.py", line 1301, in _send_request
File "http\client.py", line 1250, in endheaders
File "http\client.py", line 1010, in _send_output
File "http\client.py", line 950, in send
File "docker\transport\npipeconn.py", line 32, in connect
File "docker\transport\npipesocket.py", line 23, in wrapped
File "docker\transport\npipesocket.py", line 72, in connect
File "docker\transport\npipesocket.py", line 52, in connect
pywintypes.error: (2, 'CreateFile', 'The system cannot find the file specified.')

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "docker-compose", line 3, in <module>
File "compose\cli\main.py", line 81, in main
File "compose\cli\main.py", line 200, in perform_command
File "compose\cli\command.py", line 60, in project_from_options
File "compose\cli\command.py", line 152, in get_project
File "compose\cli\docker_client.py", line 41, in get_client
File "compose\cli\docker_client.py", line 170, in docker_client
File "docker\api\client.py", line 197, in init
File "docker\api\client.py", line 221, in _retrieve_server_version
docker.errors.DockerException: Error while fetching server API version: (2, 'CreateFile', 'The system cannot find the file specified.')
[16568] Failed to execute script docker-compose
PS C:\Users\tizzy\bot>```

#

That happens when I docker-compose run bot

cold island Oct 31, 2021, 5:58 PM

#

Is Docker up yet?

green oriole Oct 31, 2021, 5:58 PM

#

Start docker desktop

#

It should yell at you for not being up

static canyon Oct 31, 2021, 5:59 PM

#

It is started

#

I've got it open

#

I guess I'll try to restart

#

Okay, it's running

#

And the time in the console is correct 🎉

#

That's a good sign lol

#

My mute has been auto-ended

green oriole Oct 31, 2021, 6:05 PM

#

Niice

static canyon Oct 31, 2021, 6:05 PM

#

Yeah, it all works now

#

Thanks 👍

cold island Oct 31, 2021, 6:07 PM

#

I'm guessing it was caused by the hour shift and WSL stayed in the old time or something

static canyon Oct 31, 2021, 6:08 PM

#

Yeah, maybe

gritty wind Oct 31, 2021, 6:15 PM

#

weird, wsl should've restarted when you restarted windows

static canyon Oct 31, 2021, 6:21 PM

#

@patent pivot Does the bot's API for infractions support some form of an oldest_first kwarg? If not, how would I go about implementing it? I've never touched api/database stuff before so got no clue where to look/start

patent pivot Oct 31, 2021, 6:22 PM

#

hmmm honestly not sure, never worked with DRF

static canyon Oct 31, 2021, 6:22 PM

#

eee

#

Not what I wanted to hear lol

cold island Oct 31, 2021, 6:23 PM

#

static canyon <@!165023948638126080> Does the bot's API for infractions support some form of a...

look at something that you know has it

static canyon Oct 31, 2021, 6:23 PM

#

cold island look at something that you know has it

What do you mean?

#

I don't know anything that has it lol

#

Or not at the api-level

cold island Oct 31, 2021, 6:24 PM

#

I mentioned nominations earlier

static canyon Oct 31, 2021, 6:24 PM

#

One case has reversed(...) but that won't work here because it'll be reversed of the 100 most recent -- not the actual 100 oldest

#

Yeah, everything seems to be either reversed(...) or xxx.reverse() @cold island

#

There's no comments or anything saying what it does, but 'ordering': '-inserted_at' might just do it

cold island Oct 31, 2021, 6:32 PM

#

oh yeah that

#

I knew there was something of that sort

static canyon Oct 31, 2021, 6:33 PM

#

cold island oh yeah that

Nope, that didn't work lol

cold island Oct 31, 2021, 6:33 PM

#

Didn't work as in it didn't accept the arg?

static canyon Oct 31, 2021, 6:34 PM

#

I don't know

#

The resulting embed isn't oldest first

#

Ah, it shouldn't have the -

#

So 'ordering': 'inserted_at'

cold island Oct 31, 2021, 6:36 PM

#

Looking at the viewset it should be able to accept the arg

fallen patrol Oct 31, 2021, 6:56 PM

#

@static canyon why is the bot migrating to ogblurple?

#

It's role colour is the new blurple

vocal prairie Oct 31, 2021, 6:58 PM

#

fallen patrol It's role colour is the new blurple

It's not, actually

static canyon Oct 31, 2021, 6:59 PM

#

fallen patrol It's role colour is the new blurple

Yeah, it's not

#

Our entire branding is the old blurple

#

We made the decision not to change

fallen patrol Oct 31, 2021, 7:00 PM

#

In that case, maybe just patch the blurple method to return og?

static canyon Oct 31, 2021, 7:01 PM

#

I'm confused with what's so bad about my approach

fallen patrol Oct 31, 2021, 7:02 PM

#

Future use

static canyon Oct 31, 2021, 7:02 PM

#

We don't want to be patching just for the sake of it

#

og_blurple is going to stay og_blurple 🤷

fallen patrol Oct 31, 2021, 7:02 PM

#

I don't think that ppl are always gonna remember to not use discord.Colour.blurple() and that it's going to make it past reviews

patent pivot Oct 31, 2021, 7:04 PM

#

fallen patrol I don't think that ppl are always gonna remember to not use discord.Colour.blurp...

then we fix it when people notice

#

and if it becomes problematic then we write lints for it

fallen patrol Oct 31, 2021, 7:05 PM

#

Ahhh ok

#

Seems like more work 🤷‍♀️

patent pivot Oct 31, 2021, 7:05 PM

#

we aren't going to be monkeypatching anything discord.py, if we need to make substantial changes in the future we'll fork, patching for things like this is bad practice

fallen patrol Oct 31, 2021, 7:06 PM

#

Ah

cold island Oct 31, 2021, 7:16 PM

#

Question

#

Why on the bot are we using the allowed_strings converter instead of Literal?

brazen charm Oct 31, 2021, 7:23 PM

#

because it predates the Literal converter and wasn't migrated

green oriole Oct 31, 2021, 9:28 PM

#

What do we gain by migrating?

#

lol

#

Alright, the diff will be small enough, have fun @clever wraith

#

Yup

#

Go crazy

static canyon Oct 31, 2021, 10:13 PM

#

@clever wraith if you can, wait for bot#1926 so you can do that one too

dusky shoreBOT Oct 31, 2021, 10:13 PM

#

GitHub

PROpen Add support for !infractions by <m|me|uid>

static canyon Oct 31, 2021, 10:19 PM

#

Thanks

static canyon Oct 31, 2021, 10:22 PM

#

green oriole ``` git fetch origin git merge origin/main```

I've done this, and it's showing a warning about the conflict, but I can't actually see it?

#

I open the file and there's no conflict showing

#

Oh wait, I think it's because the entire file was deleted

#

CONFLICT (modify/delete): bot/exts/utils/clean.py deleted in origin/main and modified in HEAD. Version HEAD of bot/exts/utils/clean.py left in tree.

green oriole Oct 31, 2021, 10:23 PM

#

Oh yep

static canyon Oct 31, 2021, 10:23 PM

#

So I just delete the file?

green oriole Oct 31, 2021, 10:23 PM

#

Yeah, and port the changes made in your PR to the new file

static canyon Oct 31, 2021, 10:24 PM

#

right

#

I have just realised that @cold island's PR uses the old logging.getLogger instead of bot.log.get_logger

#

I suppose I should do a new PR for that

#

@green oriole how do I now push the resolve without pushing all the commits fetched from origin?

brazen charm Oct 31, 2021, 10:33 PM

#

you push the commits from origin, because they're already on the target branch they won't show up and only the merge commit is visible

static canyon Oct 31, 2021, 10:33 PM

#

right

#

okay

#

Except I can't do that

#

Because origin is already updated? @brazen charm

clever wraith Oct 31, 2021, 10:34 PM

#

static canyon <@!407110650217627658> how do I now push the resolve without pushing all the com...

You add, commit and push

static canyon Oct 31, 2021, 10:34 PM

#

What do I add?

clever wraith Oct 31, 2021, 10:35 PM

#

The two files that had conflicts

static canyon Oct 31, 2021, 10:35 PM

#

And when I push it pushes a whole load of commits (all the ones that were fetched)

clever wraith Oct 31, 2021, 10:35 PM

#

That's normal, you are pulling main

#

That's the goal of this operation

static canyon Oct 31, 2021, 10:36 PM

#

Right okay

#

Yeah that worked

#

I was thinking it'd add each individual commit to my PR's commits but it didn't

clever wraith Oct 31, 2021, 10:37 PM

#

Nah, github does detect you pulled main

#

It has a wrinkly brain

static canyon Oct 31, 2021, 10:44 PM

#

clever wraith Nah, github does detect you pulled main

Apparently not the webhook though lol

clever wraith Oct 31, 2021, 10:44 PM

#

lol, you did push 94 commits onto the branch

#

It isn't lying

#

Github is just deceting which one are from the PR when rendering the page

static canyon Oct 31, 2021, 10:45 PM

#

Right, yeah

cursive relic Nov 1, 2021, 7:02 AM

#

there seems to be a bug at .wiki command. I was able to remove the message by pressing trashcan when eivl made the command.

#

is that supposed to happen?

gritty wind Nov 1, 2021, 7:24 AM

#

Seems intentional

#

Or at least, the call to the paginator doesn't try to limit who can modify it

cursive relic Nov 1, 2021, 7:25 AM

#

gritty wind Or at least, the call to the paginator doesn't try to limit who can modify it

oh, so it is not a bug?

gritty wind Nov 1, 2021, 7:26 AM

#

I'm not sure, it's not a bug, probably just an oversight. I wouldn't mind seeing it limited though. Would you like to open an issue or PR for that?

cursive relic Nov 1, 2021, 7:26 AM

#

I could try opening one

#

thx 😄

cursive relic Nov 1, 2021, 7:42 AM

#

Opened a issue for it

static canyon Nov 1, 2021, 9:11 AM

#

PS C:\Users\tizzy\sir-lancebot> docker-compose run sir-lancebot
Starting sir-lancebot_redis_1 ... error

ERROR: for sir-lancebot_redis_1  Cannot start service redis: driver failed programming external connectivity on endpoint sir-lancebot_redis_1 (760f41add314f5f1951a61cc7269c28aa72164d1c193aedb75d3606b489c9838): Bind for 127.0.0.1:6379 failed: port is already allocated

ERROR: for redis  Cannot start service redis: driver failed programming external connectivity on endpoint sir-lancebot_redis_1 (760f41add314f5f1951a61cc7269c28aa72164d1c193aedb75d3606b489c9838): Bind for 127.0.0.1:6379 failed: port is already allocated
ERROR: Encountered errors while bringing up the project.
```how do I fix this?

#

It's saying it's already allocated but I'm not sure why

gritty wind Nov 1, 2021, 9:12 AM

#

Do you have other docker projects running?

#

docker container ls

static canyon Nov 1, 2021, 9:14 AM

#

Errr

#

I've got bot running apparently

#

How do I stop a project? @gritty wind

gritty wind Nov 1, 2021, 9:16 AM

#

docker container stop <name>

#

if you're on windows, you can just use the UI

static canyon Nov 1, 2021, 9:17 AM

#

gritty wind `docker container stop <name>`

That gave invalid container so just used the UI

#

I guess you have to do bot_site etc.

gritty wind Nov 1, 2021, 9:17 AM

#

what name did you try

#

yeah

static canyon Nov 1, 2021, 9:17 AM

#

right

gritty wind Nov 1, 2021, 9:17 AM

#

if you want to take the entire compose down, you need the compose file

clever wraith Nov 1, 2021, 9:18 AM

#

It is bot_web_1 fwiw

cold island Nov 1, 2021, 11:33 AM

#

static canyon <@456226577798135808> if you can, wait for bot#1926 so you can do that one too

You can just change it to use Literal already, and then @clever wraith won't be blocked

brisk brook Nov 1, 2021, 12:04 PM

#

How do I change the logging level of the bot?

dim pelican Nov 1, 2021, 12:06 PM

#

Should be:

logger.setLevel("DEBUG")

Or something like that right?

brazen charm Nov 1, 2021, 12:06 PM

#

trace logging can be configured through the env var, otherwise I believe you just have to change it in the source or at runtime

clever wraith Nov 1, 2021, 12:07 PM

#

You have a LOG_LEVEL env var in most projects, otherwise just turning on debug mode should be lowering to trace

brisk brook Nov 1, 2021, 12:11 PM

#

I was hoping on changing it during runtime but yeah I see

brazen charm Nov 1, 2021, 12:12 PM

#

you can change the root logger's level with internal eval

brisk brook Nov 1, 2021, 12:12 PM

#

Yeah that's what I was trying to mess around with but couldn't figure out

brazen charm Nov 1, 2021, 12:13 PM

#

should just be getLogger().setLevel(...) and it'll propagate to every logger (if they aren't set through the trace loggers env var)

brisk brook Nov 1, 2021, 12:24 PM

#

I can't for the life of me get the bot to fetch the incidents webhook 🤔

#

Oh wait smh 🤦‍♂️

cold island Nov 1, 2021, 1:27 PM

#

@brisk brook maybe we can settle on a nice color for incidents that isn't transparent?

#

Transparent is meh

brisk brook Nov 1, 2021, 1:27 PM

#

Haha yeah

#

I was gonna suggest literally "copying" the message. So the webhook author would be the message link's author and you would remove it from the embed

#

So that it "kind of" looks like the message right there

cold island Nov 1, 2021, 1:31 PM

#

hmm

#

It adds some extra info, and I think it helps that it doesn't look like one of the reports

#

Also the purpose of the webhook author being the person reporting is that it's easier to associate the report with the embed

short snow Nov 1, 2021, 1:33 PM

#

bluenix reviewed all my 3 prs lemon_hyperpleased

#

https://github.com/python-discord/bot/pull/1446#discussion_r740201805 zig wdym by this

cold island Nov 1, 2021, 1:35 PM

#

The embed currently shows a mention of the message author

#

Some embed fields don't support mentions

#

!u

stable mountainBOT Nov 1, 2021, 1:35 PM

#

Zig (mbaruh#0278)

User information

Created: <t:1542225348:R>
Profile: @cold island
ID: 512354988157173763

Member information

Joined: <t:1582826109:R>
Roles: <@&267628507062992896>, <@&807415650778742785>, <@&267629731250176001>, <@&831776746206265384>, <@&587606783669829632>, <@&778376272509141023>, <@&267630620367257601>, <@&825337057181696020>, <@&295488872404484098>, <@&585529568383860737>, <@&764802720779337729>, <@&463658397560995840>, <@&518565788744024082>, <@&542431903886606399>

Infractions

Total: 31
Active: 0

cold island Nov 1, 2021, 1:36 PM

#

I'm guessing that title is what you were referring to? @brisk brook

brisk brook Nov 1, 2021, 1:37 PM

#

cold island I'm guessing that title is what you were referring to? <@!344404945359077377>

No https://leovoel.github.io/embed-visualizer/

cold island Nov 1, 2021, 1:37 PM

#

Ah that's interesting

#

But yeah I don't think that supports mentions either

clever wraith Nov 1, 2021, 1:38 PM

#

I think it does support a few things

#

Can you run user on a bot Zig

short snow Nov 1, 2021, 1:38 PM

#

Yeah the author name doesn't support mentions, that's why i didn't use it

clever wraith Nov 1, 2021, 1:38 PM

#

I think Ak added an emoji there