#dev-contrib | Python | Page 147

gritty wind Oct 24, 2021, 1:10 PM

#

We do?

green oriole Oct 24, 2021, 1:10 PM

#

I think it is part of our test suite actually

#

but yeah I had failing checks because of that

gritty wind Oct 24, 2021, 1:17 PM

#

@molten perch I'm taking a short dinner break, so I've posted all my comments so far

#

One thing I didn't mention is the newline at the end of files

molten perch Oct 24, 2021, 1:17 PM

#

Okay, thank you!

gritty wind Oct 24, 2021, 1:17 PM

#

I've heard rumblings of a pre-commit config soon, so we'd probably need to get those fixed

#

If you have time, you could update them now, otherwise we'll just update them when we add pre-commit

molten perch Oct 24, 2021, 1:19 PM

#

Actually, it was removed in the past. I don't know the reason though.
(api#18)

dusky shoreBOT Oct 24, 2021, 1:19 PM

#

GitHub

PRDraft Make development workflow easier to use

gritty wind Oct 24, 2021, 1:19 PM

#

Yeah, it was rediscussed here afterwards

molten perch Oct 24, 2021, 1:19 PM

#

Must have missed it :/

gritty wind Oct 24, 2021, 1:20 PM

#

When ves has some more time, I'll figure out what happened and we'll go from there

dusky shoreBOT Oct 24, 2021, 1:51 PM

#

GitHub

PRDraft Make development workflow easier to use

gritty wind Oct 24, 2021, 2:03 PM

#

@molten perch I'm running into functionality problems

#

Namely, sqlaclhemy is complaining because some of the tables have dependencies which need to be dropped to recreate the table, but they are not set to cascade

molten perch Oct 24, 2021, 2:05 PM

#

Hmm.. I set the fields to cascade..

#

Which table(s)?

gritty wind Oct 24, 2021, 2:05 PM

#

Hmm in that case, it's possible I messed something up while creating the new migration

#

It's uhh

#

I'll get the error in a pastebin

molten perch Oct 24, 2021, 2:05 PM

#

Sure

#

btw. Did you create the migrations by yourself, or had alembic generate them?

gritty wind Oct 24, 2021, 2:06 PM

#

Auto generated

#

I can share the change I made

#

constraint api_nominationentry_nomination_id_fkey on table api_nominationentry depends on table api_nomination

molten perch Oct 24, 2021, 2:07 PM

#

Nomination_entry.. of course. The most problematic one. I'll take a look at it.

molten perch Oct 24, 2021, 2:09 PM

#

gritty wind I can share the change I made

Could you please also share your migration script?

#

I think, I see what the problem might be.

gritty wind Oct 24, 2021, 2:14 PM

#

Yeah, so

#

I had to recreate it, I reset my environment lmao

#

I basically just deleted nomination.py

#

https://paste.pythondiscord.com/wowevilipu.py

#

(And all the changes that come with doing that)

molten perch Oct 24, 2021, 2:17 PM

#

I see. Hopefully I fixed the problem, I'll try to delete nomination and generate a migration to check if everything works.

gritty wind Oct 24, 2021, 2:18 PM

#

Btw I may or may not have discovered this by deleting all the models

#

It ain't pretty, but you'll find stuff like that

molten perch Oct 24, 2021, 2:26 PM

#

I might have misconfigured the cascading a bit, I'll push a patch in no time. Sorry.

gritty wind Oct 24, 2021, 2:26 PM

#

Don't apologize haha, it's all good

#

Thanks for sticking with me

molten perch Oct 24, 2021, 3:43 PM

#

gritty wind I basically just deleted nomination.py

May I ask, how you did that? You just simply deleted the file?

#

I modified the cascading, everything should be working properly, but I get
sqlalchemy.exc.NoReferencedTableError: Foreign key associated with column 'api_nominationentry.nomination_id' could not find table 'api_nomination' with which to generate a foreign key to target column 'id'
Even with the version you used to test.

gritty wind Oct 24, 2021, 3:47 PM

#

Well, that’s the non-working migration

#

But yeah, I basically deleted everything

molten perch Oct 24, 2021, 3:48 PM

#

gritty wind Well, that’s the non-working migration

I don't even get to the point where the migration gets generated.

gritty wind Oct 24, 2021, 3:48 PM

#

What did you do?

molten perch Oct 24, 2021, 3:49 PM

#

Deleted the nomination model, and ran an autogenerated revision 😄

gritty wind Oct 24, 2021, 3:49 PM

#

Did you remove all the things that referenced it?

molten perch Oct 24, 2021, 3:50 PM

#

Like.. what? 😄 I'm sort of lost here. 😄

gritty wind Oct 24, 2021, 3:51 PM

#

If you deleted nomination.py, you'd also need to delete lines 27-31, and and line 37 of nomination_entry.py and line 8 of bot.__init__.py as they all either reference the table as a foreign key, or make imports directly from the python file

molten perch Oct 24, 2021, 3:52 PM

#

Yeah, I deleted from the bot init

#

But..

#

-_-

#

Got it. Thank you.

#

For some reason, I thought everything will be solved in nomination entry...

molten perch Oct 24, 2021, 4:05 PM

#

gritty wind If you deleted `nomination.py`, you'd also need to delete lines 27-31, and and l...

It seems like, there's a confusion with alembic. It can indeed detect table removals, however it has problems when it comes to references.
The order is wrong. I modified the migration script a bit to make it work. (Basically just moved the drop table expression to the end)
(https://paste.pythondiscord.com/exibemawey.py)
Alembic is different from the Django migration tool, or whatever it's called.

gritty wind Oct 24, 2021, 4:23 PM

#

molten perch It seems like, there's a confusion with alembic. It can indeed detect table remo...

I managed to get it working without manual modifications to the generated SQL

molten perch Oct 24, 2021, 4:29 PM

#

It is not SQL actually. And when you generate them there is a comment "please adjust" so it's not a bad thing to modify them 😄

#

But, how?

gritty wind Oct 24, 2021, 4:30 PM

#

It's fine to modify them, but I have a feeling if you just modified them in the migrations, they'll be missed in the future

#

Regardless, I'm trying to distill it down to the simplest method to get this running

#

It's a combination of a few things

#

Yeah, okay I give up on this

#

Just push your solution

molten perch Oct 24, 2021, 5:03 PM

#

It's fine as it is now, you just have to modify the migrations.
(But if you're interested: https://paste.pythondiscord.com/exibemawey.py)
I also noticed, that the cascading was fine so I reverted. So.. it's ready! 😄

gritty wind Oct 24, 2021, 5:08 PM

#

Well, don't you have to push those modified migrations to your PR?

#

Or is that on the ones that drop it

#

Because if that's the case, we can also just add the cascade on the creation, and then we won't have to worry about it when dropping in the future

molten perch Oct 24, 2021, 5:30 PM

#

Well, I don't have to push new migrations. They're fine. Turns out that I did the cascading just fine, so it's OK.(But I'll do a final check on them later today jhust to make sure)

#

(And actually there's only one, an initial :D)

gritty wind Oct 24, 2021, 5:45 PM

#

What I meant was if the auto-generated migrations refuse to correctly apply the cascades

#

We can manually add them into the initial migrations

#

That way if we go to drop them in the future, we can easily do so, without running into strange errors

molten perch Oct 24, 2021, 5:52 PM

#

Okay, I'll reorganise those cascades and add them correctly.

molten perch Oct 24, 2021, 8:49 PM

#

Okay, I figured out those cascading options, and pushed a new Initial migration! 🎉

dim pelican Oct 24, 2021, 10:32 PM

#

RE: sir-lancebot#842, sorry for the messy commit history, had to do some merging. Right now I have the restructure template as a multi line comment to fill out and test with. @elder belfry sorry for the late ping, but if you want to keep chugging along we should all be on the same page thanks to @clever wraith

dusky shoreBOT Oct 24, 2021, 10:32 PM

#

GitHub

PRDraft Add color command

short snow Oct 25, 2021, 12:56 AM

#

https://github.com/python-discord/sir-lancebot/issues/913 Could I get this issue approved, I can PR a quick fix

austere hornet Oct 25, 2021, 1:03 AM

#

short snow https://github.com/python-discord/sir-lancebot/issues/913 Could I get this issue...

Remember that you can also use sir-lancebot#913, not sure what's easier for you, but just a suggestion

dusky shoreBOT Oct 25, 2021, 1:03 AM

#

GitHub

IssueOpen XKCD Failed to catches an error if ran too early

static canyon Oct 25, 2021, 1:15 AM

#

@short snow RE sir-lancebot#919 it's resolved locally

#

Hence my comment before I marked as resolved

#

I still need to decide which suggestions I want to implement (only those of migration or also fixing up the commands).

Once I've decided and done everything that I want to I'll push it all.

short snow Oct 25, 2021, 2:47 AM

#

static canyon <@736234578745884682> RE sir-lancebot#919 it's resolved locally

Yeah, you should resolve conservations after pushing them (Hello zig 😉 )

#

even i did the same earlier

#

zig told me that's better ^

short snow Oct 25, 2021, 2:48 AM

#

austere hornet Remember that you can also use sir-lancebot#913, not sure what's easier for you,...

Yeah ik, i just had the link handy so used it

static canyon Oct 25, 2021, 2:48 AM

#

Resolving just makes it easier for me to see what's still left to do 🤷

#

But I can see both sides

short snow Oct 25, 2021, 2:49 AM

#

Yeah

trail pilot Oct 25, 2021, 2:58 AM

#

Hey @thorny obsidian! Just a message for the record for a remainder about the review for sir-lancebot#910, you can review it whenever and when you’re free since we have a lot of time, I just figured I’d put this message out FTR

dusky shoreBOT Oct 25, 2021, 2:58 AM

#

GitHub

PROpen Trivia night event

elder belfry Oct 25, 2021, 7:54 AM

#

dim pelican RE: sir-lancebot#842, sorry for the messy commit history, had to do some merging...

Yeah I have seen your recent commits, and it really looks good. One thing I wanted to ask, are we going to include the random subcommand too ryt?
I have a rough idea about it, but I don't know if I would be able to do it, anytime soon.
Also, I need to apologize, I have not been able to give much time (pressure from Academics mainly), although I really really want to work on it. 😔

dim pelican Oct 25, 2021, 11:50 AM

#

elder belfry Yeah I have seen your recent commits, and it really looks good. One thing I want...

No worries at all, school comes first!
I think we need to do the random subcommand as well as the name

clever wraith Oct 25, 2021, 1:54 PM

#

Please review bot#1889

dusky shoreBOT Oct 25, 2021, 1:54 PM

#

GitHub

PROpen feat: added url parsing to the filter

cold island Oct 25, 2021, 1:57 PM

#

On my to-do

vale ibex Oct 25, 2021, 1:58 PM

#

IG one perf improvement could be to move setting message_url out of the inner loop

#

Since it's going to be the same within each match

clever wraith Oct 25, 2021, 1:59 PM

#

Ty for resolving the conflicts chris

#

I'm at school and doin it from my phone sucks

#

So the goal of this PR is to still trigger filters even if there is a user login or password that is added to the url?

#

No

#

It's to stop URLs that contain blacklisted URLs but aren't necessarily bad from triggering the filter

vale ibex Oct 25, 2021, 2:08 PM

#

it's to make sure le.co doesn't filter google.com

clever wraith Oct 25, 2021, 2:08 PM

#

Right

#

does it also support subdomains?

short snow Oct 25, 2021, 2:08 PM

#

(what happened to your other account?)

clever wraith Oct 25, 2021, 2:08 PM

#

clever wraith does it also support subdomains?

Oh

#

Shoot

#

haha

vale ibex Oct 25, 2021, 2:09 PM

#

I think subdomains will be in the path too

clever wraith Oct 25, 2021, 2:09 PM

#

Yeah they'd be in the netloc or path

clever wraith Oct 25, 2021, 2:09 PM

#

short snow (what happened to your other account?)

didn't happen anything, I'm just another identity

vale ibex Oct 25, 2021, 2:09 PM

#

if we support subdomains properly, we don't need to do the in() hack with www.

short snow Oct 25, 2021, 2:09 PM

#

ok alizee

clever wraith Oct 25, 2021, 2:09 PM

#

Alright

vale ibex Oct 25, 2021, 2:10 PM

#

Could just do an endswith check

clever wraith Oct 25, 2021, 2:10 PM

#

We do have bot#1276 but I'm not sure that requires a whole new list

dusky shoreBOT Oct 25, 2021, 2:10 PM

#

GitHub

IssueOpen Filtering - New blacklist type that catch all subdomains of domain

clever wraith Oct 25, 2021, 2:10 PM

#

vale ibex Could just do an endswith check

I'll take a look at 400 pm CDT

vale ibex Oct 25, 2021, 2:10 PM

#

Yea, we don't need that new filter list

#

we can just do that by default

#

I think we can just do ```diff

if message_url in (f"www.{blacklisted_url}", blacklisted_url):

if message_url.endswith(blacklisted_url):

clever wraith Oct 25, 2021, 2:11 PM

#

I believe that will be a boolean on the new filter system, but I may be wrong

clever wraith Oct 25, 2021, 2:11 PM

#

vale ibex Could just do an endswith check

If we aren't careful ends with might trigger learn-python

vale ibex Oct 25, 2021, 2:11 PM

#

Would it?

#

hmmm, it could

clever wraith Oct 25, 2021, 2:12 PM

#

Lemme check

#

yep it will

vale ibex Oct 25, 2021, 2:12 PM

#

Yea, seems non-trivial to fix properly

green oriole Oct 25, 2021, 2:12 PM

#

that discussion made me switch back Thonk

clever wraith Oct 25, 2021, 2:12 PM

#

!e ```py
if "https://learn-python.com".endswith("python.com"):
print("dang")

green oriole Oct 25, 2021, 2:13 PM

#

Can't we just strip the subdomain?

vale ibex Oct 25, 2021, 2:13 PM

#

since there could be mutliple domains either end so we couldn't split on .

clever wraith Oct 25, 2021, 2:13 PM

#

We'd have to to f".{blacklisted_url}" for endswith iirc

vale ibex Oct 25, 2021, 2:13 PM

#

IE google.co.uk would be stripped to co.uk

#

similarly there could be bar.foo.google.com

#

Yea, could do that

#

I think we can just do ```diff

if message_url in (f"www.{blacklisted_url}", blacklisted_url):

if message_url.endswith(f".{blacklisted_url}"):

molten perch Oct 25, 2021, 2:14 PM

#

btw. Just a quick question. There's this comment https://github.com/python-discord/bot/blob/f998353ac895f59e03c0ddf636be76ecfc964f46/bot/exts/filters/filtering.py#L484
However, it seems like the regex pattern doesn't match urls without schemes. (I might be very well wrong though)

stable mountainBOT Oct 25, 2021, 2:14 PM

#

bot/exts/filters/filtering.py line 484

# If there is a scheme in the url then `.netloc` has what we want, otherwise its `.path````

vale ibex Oct 25, 2021, 2:14 PM

#

like this?

#

but then, that wouldn't work if they don't have a .

green oriole Oct 25, 2021, 2:14 PM

#

what about checking every single fragment?

#

individually, that is

vale ibex Oct 25, 2021, 2:15 PM

#

would that work? since the blacklist could have a url like google.co.uk

#

so there would be 3 frags

clever wraith Oct 25, 2021, 2:15 PM

#

I've got some stuff to do, I'll be back

vale ibex Oct 25, 2021, 2:16 PM

#

molten perch btw. Just a quick question. There's this comment https://github.com/python-disco...

true, it requires a scheme on the user-input, but doesn't for the filtered domain

#

so we could drop that when parsing the user input

#

but would need to do it for blacklisted_url

#

since a mod could add it with or without a scheme

clever wraith Oct 25, 2021, 2:17 PM

#

molten perch btw. Just a quick question. There's this comment https://github.com/python-disco...

No, that comment regards the URLs in the blacklist, not URLs sent without a scheme

vale ibex Oct 25, 2021, 2:17 PM

#

We do it for both atm

#

no need to do it for the second one

clever wraith Oct 25, 2021, 2:18 PM

#

Don't those sent without a scheme not trigger the regex?

vale ibex Oct 25, 2021, 2:18 PM

#

No they don't

#

URL_RE = re.compile(r"(https?://[^\s]+)", flags=re.IGNORECASE)

#

there needs to be a http or https included

#

or it doesn't get filtered

clever wraith Oct 25, 2021, 2:18 PM

#

I don't know anything about regexes

vale ibex Oct 25, 2021, 2:18 PM

#

This means that it needs to start with https:// or http:// to be filtered

clever wraith Oct 25, 2021, 2:19 PM

#

So if that needs to change, I won't be much help

green oriole Oct 25, 2021, 2:19 PM

#

vale ibex would that work? since the blacklist could have a url like google.co.uk

I feel like we can convert the current blacklist to only contain the first fragment

#

is it even called fragment

#

I think name is the right term

vale ibex Oct 25, 2021, 2:20 PM

#

green oriole I feel like we can convert the current blacklist to only contain the first fragm...

So the blacklist doesn't allow dots at all, and if we want to filter it checks if the filtered domain contains the blacklisted frag anywhere?

green oriole Oct 25, 2021, 2:20 PM

#

that's my idea

vale ibex Oct 25, 2021, 2:20 PM

#

python.com vs python.org

#

so we'd add python to the blacklist?

green oriole Oct 25, 2021, 2:20 PM

#

aPES_CryLeave

#

haha

vale ibex Oct 25, 2021, 2:21 PM

#

😂

#

urls hard

cold island Oct 25, 2021, 2:21 PM

#

clever wraith I believe that will be a boolean on the new filter system, but I may be wrong

yeah that was the plan

clever wraith Oct 25, 2021, 2:22 PM

#

vale ibex urls hard

Yes they are

vale ibex Oct 25, 2021, 2:23 PM

#

https://pypi.org/project/tldextract/ possibly?

PyPI

tldextract

Accurately separate the TLD from the registered domain and subdomains of a URL, using the Public Suffix List. By default, this includes the public ICANN TLDs and their exceptions. You can optionally support the Public Suffix List's private domains as well.

#

can extract domains from the tlds

green oriole Oct 25, 2021, 2:24 PM

#

but then python is still a problem

vale ibex Oct 25, 2021, 2:25 PM

#

with this we could join hostname and tld

#

and it seperates sub domains

#

>>> ext = tldextract.extract('http://forums.bbc.co.uk')
>>> (ext.subdomain, ext.domain, ext.suffix)
('forums', 'bbc', 'co.uk')

green oriole Oct 25, 2021, 2:25 PM

#

oh that's nice

#

we could do that

vale ibex Oct 25, 2021, 2:26 PM

#

it looks like it works by making a sync request to a url to fetch all TLDs on import

green oriole Oct 25, 2021, 2:26 PM

#

or just ban .co.uk because who thought that was a good idea

clever wraith Oct 25, 2021, 2:27 PM

#

with open("dump/good.txt", "r") as f:
    Data = f.readlines()
    f.close()

with open("dump/bad.txt", "r") as f:
    content = f.readlines()

with open("dump/good.txt", "r+") as hit:
    d = hit.readlines()
    hit.seek(0)
    for i in d:
        if i != content:
            hit.write(i)
    hit.truncate()

green oriole Oct 25, 2021, 2:27 PM

#

vale ibex it looks like it works by making a sync request to a url to fetch all TLDs on im...

seems like it is vendored https://github.com/john-kurkowski/tldextract/blob/master/tldextract/.tld_set_snapshot

GitHub

tldextract/.tld_set_snapshot at master · john-kurkowski/tldextract

Accurately separate the TLD from the registered domain and subdomains of a URL, using the Public Suffix List. - tldextract/.tld_set_snapshot at master · john-kurkowski/tldextract

clever wraith Oct 25, 2021, 2:27 PM

#

why does this thing deletes every stuff from the file

#

rather than only the matching content

#

😭

vale ibex Oct 25, 2021, 2:27 PM

#

green oriole seems like it is vendored https://github.com/john-kurkowski/tldextract/blob/mast...

aha cool

green oriole Oct 25, 2021, 2:27 PM

#

Hey @clever wraith! Please see how to ask for help in #❓｜how-to-get-help

clever wraith Oct 25, 2021, 2:27 PM

#

i want it to delete only the matching content but it erases all the content of file

clever wraith Oct 25, 2021, 2:27 PM

#

green oriole Hey <@456226577798135808>! Please see how to ask for help in <#70425014302041708...

oki

vale ibex Oct 25, 2021, 2:27 PM

#

There's some requests stuff in https://github.com/john-kurkowski/tldextract/blob/master/tldextract/suffix_list.py

#

was struggling to follow along, since I'm also in a call

#

I wouldn't be against adding it as a dep

green oriole Oct 25, 2021, 2:29 PM

#

I think it is used to update the file

vale ibex Oct 25, 2021, 2:29 PM

#

Ah cool

green oriole Oct 25, 2021, 2:29 PM

#

# extract callable that falls back to the included TLD snapshot, no live HTTP fetching
no_fetch_extract = tldextract.TLDExtract(suffix_list_urls=None)```

vale ibex Oct 25, 2021, 2:30 PM

#

Ahh cool

#

Hey @clever wraith just as a summary of what we've talked about, ready for when you're back.

https://pypi.org/project/tldextract/ seems to do what we want with breaking up the domain and stripping the subdomains out, so this might be best to use in your open PR. 😄

PyPI

tldextract

Accurately separate the TLD from the registered domain and subdomains of a URL, using the Public Suffix List. By default, this includes the public ICANN TLDs and their exceptions. You can optionally support the Public Suffix List's private domains as well.

cold island Oct 25, 2021, 2:33 PM

#

Why do we want it in this PR?

clever wraith Oct 25, 2021, 2:33 PM

#

Is the BSD license compatible with MIT?

green oriole Oct 25, 2021, 2:33 PM

#

Please use suffix_list_urls=None so we don't pull a new cache every time

green oriole Oct 25, 2021, 2:34 PM

#

clever wraith Is the BSD license compatible with MIT?

yup

clever wraith Oct 25, 2021, 2:34 PM

#

Alright

vale ibex Oct 25, 2021, 2:36 PM

#

cold island Why do we want it in this PR?

So that it properly filters urls with subdomains or multi-part tlds

#

The current impl wouldn't filter a blacklisted url if it has a subdomain

#

IE if we blacklist bbc.co.uk, someone sending https://news.bbc.co.uk wouldn't get filtered

#

and trying to seperate sub-domains, domains and tlds ourselves would be hard, since we need a list of tlds

#

since tlds can be made up of multiple parts, and so can subdomains

#

maintaining one is

green oriole Oct 25, 2021, 2:40 PM

#

is anyone even able to start the bot?

vale ibex Oct 25, 2021, 2:41 PM

#

we're not interested in making a PR each month to update the list

green oriole Oct 25, 2021, 2:41 PM

#

/healthcheck doesn't seem to be a thing on the latest site container

vale ibex Oct 25, 2021, 2:41 PM

#

and why implement our own fetch and cache solution if a lib does it for us

green oriole Oct 25, 2021, 2:41 PM

#

.co.uk isn't in there

vale ibex Oct 25, 2021, 2:42 PM

#

.co.uk != .uk

green oriole Oct 25, 2021, 2:42 PM

#

it is only actual first level

#

we want seemingly TLDs

vale ibex Oct 25, 2021, 2:42 PM

#

green oriole `/healthcheck` doesn't seem to be a thing on the latest site container

we changed it aroun recently, have you re-pulled your site image?

clever wraith Oct 25, 2021, 2:42 PM

#

@vale ibex where does tldextract get its list

green oriole Oct 25, 2021, 2:42 PM

#

vale ibex we changed it aroun recently, have you re-pulled your site image?

I just did

#

the official definition?

vale ibex Oct 25, 2021, 2:43 PM

#

clever wraith <@126811506632294400> where does tldextract get its list

there's one that get's shipped with the package, and it can fetch on import too

green oriole Oct 25, 2021, 2:43 PM

#

something something root servers something something

clever wraith Oct 25, 2021, 2:43 PM

#

vale ibex there's one that get's shipped with the package, and it can fetch on import too

Alright

vale ibex Oct 25, 2021, 2:43 PM

#

Yea, there's quite a few second-level domains

#

not just co.uk

clever wraith Oct 25, 2021, 2:43 PM

#

Tldextract should work

fervent sage Oct 25, 2021, 2:44 PM

#

vale ibex .co.uk != .uk

But .co.uk is a public suffix and should be split on

clever wraith Oct 25, 2021, 2:44 PM

#

I'll take a look at home

vale ibex Oct 25, 2021, 2:44 PM

#

fervent sage But .co.uk is a public suffix and should be split on

agreed, which was my point 😄

clever wraith Oct 25, 2021, 2:45 PM

#

Wait what

fervent sage Oct 25, 2021, 2:45 PM

#

vale ibex agreed, which was my point 😄

Yeah I was agreeing tone is just hard kek

green oriole Oct 25, 2021, 2:45 PM

#

I mean that's what happened

vale ibex Oct 25, 2021, 2:45 PM

#

ah alr lol

fervent sage Oct 25, 2021, 2:45 PM

#

I mean someone did buy .co.uk and make it a tld

#

But it will be someone like verisign

vale ibex Oct 25, 2021, 2:45 PM

#

Yea, that someone was the queen

#

she deals with all uk domains

fervent sage Oct 25, 2021, 2:45 PM

#

But not verisign

green oriole Oct 25, 2021, 2:45 PM

#

I'll turn wungus.net into a TLD

clever wraith Oct 25, 2021, 2:46 PM

#

Lol

green oriole Oct 25, 2021, 2:46 PM

#

it is actually so much simpler than it sounds

#

anyway, any idea why I cannot start the site?

#

well, start the bot that depends on the site /healthcheck endpoint

brazen charm Oct 25, 2021, 2:47 PM

#

Did you update your config for the migration from subdomains

fervent sage Oct 25, 2021, 2:47 PM

#

green oriole I'll turn wungus.net into a TLD

You cant

vale ibex Oct 25, 2021, 2:47 PM

#

site_api:    &API    !JOIN [*DOMAIN, "/api"]
site_staff:  &STAFF  !JOIN [*DOMAIN, "/staff"]

green oriole Oct 25, 2021, 2:48 PM

#

Well, that would probably be why haha

fervent sage Oct 25, 2021, 2:48 PM

#

.co.uk isn't technically a tld either, it's just a public domain that people can have subdomains on

green oriole Oct 25, 2021, 2:48 PM

#

pff it is my role to be pedantic like that alec

fervent sage Oct 25, 2021, 2:48 PM

#

I'm the infrastructure nerd when Joe's away smh

green oriole Oct 25, 2021, 2:49 PM

#

Dude I don't have 2€/domain to spare

brisk brook Oct 25, 2021, 2:49 PM

#

fervent sage .co.uk isn't technically a tld either, it's just a public domain that people can...

Same with ddns.net

green oriole Oct 25, 2021, 2:49 PM

#

I can host my own nameservers, easy

vale ibex Oct 25, 2021, 2:49 PM

#

Cloudflare for SaaS is sick

green oriole Oct 25, 2021, 2:49 PM

#

guess it zorks

fervent sage Oct 25, 2021, 2:49 PM

#

Cloudflare ~~for SaaS~~ is sick

green oriole Oct 25, 2021, 2:49 PM

#

works, not zorks

vale ibex Oct 25, 2021, 2:50 PM

#

finally managed to convince our devops guys to migrate to cloudflare properly

#

we still use godaddy dns

green oriole Oct 25, 2021, 2:50 PM

#

hold on do we

vale ibex Oct 25, 2021, 2:50 PM

#

we being my org

green oriole Oct 25, 2021, 2:50 PM

#

ah

fervent sage Oct 25, 2021, 2:51 PM

#

No

#

Lol

vale ibex Oct 25, 2021, 2:51 PM

#

It's actually cheaper for us to move to cloudflare too

#

since we're being shafted by godaddy on domain renewals

fervent sage Oct 25, 2021, 2:51 PM

#

I'm in my CF shirt rn dogekek

brisk brook Oct 25, 2021, 2:51 PM

#

Do you ever change clothes?

fervent sage Oct 25, 2021, 2:51 PM

#

Yes

patent pivot Oct 25, 2021, 2:52 PM

#

i don't use their dns, but my organisation uses them to register domains

brisk brook Oct 25, 2021, 2:52 PM

#

Anytime we talk CF you have it lmaooo

patent pivot Oct 25, 2021, 2:52 PM

#

we pay a brand agency who registers our trademark under as many TLDs as they can

fervent sage Oct 25, 2021, 2:52 PM

#

I just happen to be in my CF shirt at most times when people talk about cf

#

By coincidence lol

brisk brook Oct 25, 2021, 2:52 PM

#

Literally the only thing in your wardrobe

patent pivot Oct 25, 2021, 2:52 PM

#

i think they've registered about 400 domains in our name using our trademark

#

lol

fervent sage Oct 25, 2021, 2:52 PM

#

I have 3 tech company shirts and they're all I wear

vale ibex Oct 25, 2021, 2:52 PM

#

Do you eventually xfer renewals to CF?

patent pivot Oct 25, 2021, 2:52 PM

#

nah, there isn't a point

vale ibex Oct 25, 2021, 2:53 PM

#

We've got a few hundred in godaddy atm and renewals are hyper marked up

fervent sage Oct 25, 2021, 2:53 PM

#

I need to be easily spottable for nerds

patent pivot Oct 25, 2021, 2:53 PM

#

some of them don't even have DNS records, they literally just sit there and be registered

vale ibex Oct 25, 2021, 2:53 PM

#

Ah lol

patent pivot Oct 25, 2021, 2:53 PM

#

our rate hasn't changed with the brand agency so I guess they're footing whatever markup there is lol

vale ibex Oct 25, 2021, 2:53 PM

#

we use them all, and we can get 2 orders of magnitude cheaper renewals by changing to CF domains

fervent sage Oct 25, 2021, 2:54 PM

#

Isn't GoDaddy like the mother of toxic domain registrars

patent pivot Oct 25, 2021, 2:55 PM

#

they're pretty bad

#

but they're enterprise

green oriole Oct 25, 2021, 2:57 PM

#

How do I make this not awful?

patent pivot Oct 25, 2021, 2:57 PM

#

they have enough funds to be a CA and operate several TLDs

#

not something feasible

clever wraith Oct 25, 2021, 2:57 PM

#

green oriole guess it zorks

What on earth

patent pivot Oct 25, 2021, 2:58 PM

#

green oriole How do I make this not awful?

store links elsewhere

#

we can't do this because we don't have host access

green oriole Oct 25, 2021, 2:58 PM

#

Even if I do, it is still awful

patent pivot Oct 25, 2021, 2:58 PM

#

well, we do, but I don't want to install software onto the host

green oriole Oct 25, 2021, 2:58 PM

#

I kind of want to just slap a txt file

cold island Oct 25, 2021, 2:58 PM

#

green oriole How do I make this not awful?

Why not make it a multiline string 🤔

green oriole Oct 25, 2021, 2:59 PM

#

because the links are so long you need to use line continuations

patent pivot Oct 25, 2021, 2:59 PM

#

Note that this container is being run with a lot of privilege -- sharing the host's filesystem, pid and network namespaces, due to portions of the benchmark applying to the running host.
pass

cold island Oct 25, 2021, 2:59 PM

#

Oh

patent pivot Oct 25, 2021, 3:00 PM

#

we can't really change much of what it throws up

#

like

#

docker is managed by linode

cold island Oct 25, 2021, 3:00 PM

#

Yeah I think what you have rn is good enough or separate the links like joe said

#

You can also stop the line before the link

#

So that the entire link is in its own line

patent pivot Oct 25, 2021, 3:01 PM

#

#

oh wait

#

this is the wrong cluster

#

lmfoa

#

score is the same for pydis one

#

well, the 68% is, the actual categories are different

#

but i think that

#

posting a chart of vulns in a public channel

#

is not a great idea, lol

#

lol

#

i mean

#

nothing stands out to me looking at the output

#

dusky shoreBOT Oct 25, 2021, 3:10 PM

#

GitHub

IssueOpen Issue/PR hyperlink embed upgrade

molten perch Oct 25, 2021, 3:10 PM

#

Actually, I am. It's just halted by another PR

#

However, if the Alembic PR gets merged, I might give more attention to the api. So I guess you can take it 😄

#

I did! 🎉

green oriole Oct 25, 2021, 3:28 PM

#

i-

#

OH I AM GONNA BE MAD FLAKE8

#

I mean it runs

#

lol

#

Will I really have to noqa this

vale ibex Oct 25, 2021, 3:32 PM

#

green oriole Will I really have to noqa this

try bumping flake8 in dev deps?

green oriole Oct 25, 2021, 3:33 PM

#

but it doesn't fail locally

vale ibex Oct 25, 2021, 3:33 PM

#

oh wut

green oriole Oct 25, 2021, 3:33 PM

#

I mean I can try

#

oh, I think I know what it is

#

akarys@mojito ~/P/pybot (filters/autoban) [1]> git merge origin/main --no-commit
Auto-merging bot/exts/moderation/infraction/_scheduler.py
Auto-merging bot/exts/filters/filtering.py
Automatic merge went well; stopped before committing as requested
akarys@mojito ~/P/pybot (filters/autoban|MERGING)> poetry run task lint
Check for merge conflicts................................................Passed
Check Toml...............................................................Passed
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
check blanket noqa.......................................................Passed
isort (python)...........................................................Passed
Flake8...................................................................Failed
- hook id: flake8
- exit code: 1

bot/exts/filters/filtering.py:378:33: F821 undefined name 'datetime'

#

That's a sneaky one

vale ibex Oct 25, 2021, 3:35 PM

#

lol

green oriole Oct 25, 2021, 3:35 PM

#

yup

#

haha

vale ibex Oct 25, 2021, 3:36 PM

#

Mine's very imaginative ```powershell
PS C:\Users\Chris> whoami
desktop-fec9jn0\chris

green oriole Oct 25, 2021, 3:36 PM

#

Wow

clever wraith Oct 25, 2021, 4:09 PM

#

vale ibex Mine's very imaginative ```powershell PS C:\Users\Chris> whoami desktop-fec9jn0\...

LAPTOP-EAR30CUE 😎

short snow Oct 25, 2021, 4:14 PM

#

bot#1446 needs another staff/contrib approval, would appreciate a review :D

dusky shoreBOT Oct 25, 2021, 4:14 PM

#

GitHub

PROpen Enhancing information within the incidents channel.

cold island Oct 25, 2021, 4:21 PM

#

green oriole That's a sneaky one

What was it?

green oriole Oct 25, 2021, 4:28 PM

#

cold island What was it?

Github Actions pulls main before running checks, and main actually removed that import

gritty wind Oct 25, 2021, 4:43 PM

#

Why is your branch out of date before the reviewing starts though lemon_pensive

vale ibex Oct 25, 2021, 4:49 PM

#

@clever wraith what @molten perch is trying to say is that there's no point doing message_url = message_url.netloc or message_url.path

#

since we only match on urls with protocols, the thing we want to compare will always be in message_url.netloc

clever wraith Oct 25, 2021, 4:50 PM

#

Oh

#

But hold on

vale ibex Oct 25, 2021, 4:50 PM

#

We need to do blacklisted_url = blacklisted_url.netloc or blacklisted_url.path since blacklisted domains may not have protocols

clever wraith Oct 25, 2021, 4:50 PM

#

Thats only on blacklisted, right?

vale ibex Oct 25, 2021, 4:51 PM

#

Yea

#

but if we add tldextract, we won't have this at all anyway

#

since it'll do the splitting for us

austere hornet Oct 25, 2021, 5:00 PM

#

clever wraith `LAPTOP-EAR30CUE` 😎

Haha

green oriole Oct 25, 2021, 5:30 PM

#

gritty wind Why is your branch out of date before the reviewing starts though <:lemon_pensiv...

For once I can totally blame that one of the admins since y'all wanted to discuss this PR haha

gritty wind Oct 25, 2021, 5:40 PM

#

Lol

fallen patrol Oct 25, 2021, 6:52 PM

#

hey would it be worth making an upstream pr to improve the mocks for dpy?

hoary anvil Oct 25, 2021, 6:52 PM

#

dpy is unmaintained

#

so I doubt it would be accepted

fallen patrol Oct 25, 2021, 6:53 PM

#

clarification: upstream is pydis/bot

hoary anvil Oct 25, 2021, 6:53 PM

#

oops

fallen patrol Oct 25, 2021, 6:53 PM

#

nah if you didn't understand other ppl would've thought the same

vale ibex Oct 25, 2021, 6:53 PM

#

wdym upstream?

#

Are you forking our bot for something?

fallen patrol Oct 25, 2021, 6:53 PM

#

i've taken the mocks for my own project, but improved on them to the point where I think they would be benefical to pydis as well

#

no, i only took the mocks

vale ibex Oct 25, 2021, 6:54 PM

#

Ah right, then it's not really upstream

#

feel free to open an issue with your suggested improvements though

fallen patrol Oct 25, 2021, 6:55 PM

#

well, i'm curious if they're worth it to pydis

#

what i've done is made it so eg: MockTextChannel.send() returns a MockMessage

fallen patrol Oct 25, 2021, 6:57 PM

#

vale ibex feel free to open an issue with your suggested improvements though

if its worth it, i can make it

vale ibex Oct 25, 2021, 7:04 PM

#

No idea how that impacts personally, as I haven't worked with our tests much

#

That's why I suggested raising an issue with your proposed improvements, so that others can comment

fallen patrol Oct 25, 2021, 7:05 PM

#

ahhhhh i thought you said pr 😓

#

Well

#

Will make an issue later regardless

fallen patrol Oct 25, 2021, 7:09 PM

#

vale ibex feel free to open an issue with your suggested improvements though

!remind 8H

stable mountainBOT Oct 25, 2021, 7:09 PM

#

Missing required argument

content

#

Command Help

!remind [mentions]... <expiration> <content>
Can also use: reminder, reminders, remindme

*Commands for managing your reminders.

The expiration duration of !remind new supports the following symbols for each unit of time: - years: Y, y, year, years - months: m, month, months - weeks: w, W, week, weeks - days: d, D, day, days - hours: H, h, hour, hours - minutes: M, minute, minutes - seconds: S, s, second, seconds

For example, to set a reminder that expires in 3 days and 1 minute, you can do !remind new 3d1M Do something.*

Subcommands:

!remind delete <id_>
Delete one of your active reminders.
!remind edit
Commands for modifying your current reminders.
!remind list
View a paginated embed of all reminders for your user.
!remind new [mentions]... <expiration> <content>
Set yourself a simple reminder.

fallen patrol Oct 25, 2021, 7:10 PM

#

vale ibex feel free to open an issue with your suggested improvements though

!remind 8H .

stable mountainBOT Oct 25, 2021, 7:10 PM

#

Yep.

Your reminder will arrive on <t:1635217808:F>!

fallen patrol Oct 25, 2021, 7:11 PM

#

!remind 8H make issue to make content of replies optional and use message reference as content, in addition to replying to that instead

stable mountainBOT Oct 25, 2021, 7:11 PM

#

No problem.

Your reminder will arrive on <t:1635217861:F>!

molten perch Oct 25, 2021, 7:25 PM

#

Hey! Can I get reviews on api#23? 🤓 (It's all fixed up, should work fine)

dusky shoreBOT Oct 25, 2021, 7:25 PM

#

GitHub

PROpen Add Alembic Migration environment to the project, patch model architecture

trail bough Oct 25, 2021, 7:36 PM

#

Hey guys
I want to suggest we daily have a topic to discuss so that we all know and have knowledge from each other

gritty wind Oct 25, 2021, 7:38 PM

#

Ideas like that are better proposed in #community-meta. We used to have something like that previously, but it didn’t work out and we decommissioned it. Feel free to ask in meta if you want more details

brisk brook Oct 25, 2021, 7:59 PM

#

I haven't reviewed in a while and I don't think Xithrius has requested my review for many more PRs. So which ones need review?

Other than DOrs3n's PR (I generally dislike ORMs quite a lot so I won't touch on that sorry).

I do have some PRs waiting in my notifications on GitHub that needs testing before approving but the only free time I have today and tomorrow morning is on my phone and maybe school laptop.. so I can do a code review

#

@austere hornet do you maybe want some pointers along the way on your PR?

austere hornet Oct 25, 2021, 8:03 PM

#

brisk brook <@853309207922212965> do you maybe want some pointers along the way on your PR?

Hi, so I am running in to one problem where when I try to add fields to an embed and update a certain field, upon editing the message, it deletes the field entirely. I haven't committed my changes, so if you don't mind, can I DM you my Python file?

brisk brook Oct 25, 2021, 8:05 PM

#

Well you can send the important part of the code here, if you do want to send me the file give me 10 minutes or so to finish up my math homework and boot up my laptop

trail pilot Oct 25, 2021, 8:16 PM

#

brisk brook I haven't reviewed in a while and I don't think Xithrius has requested my review...

Oh, could you review sir-lancebot#910? I saw your comments and I'm implementing them, but wondering if you had any more

dusky shoreBOT Oct 25, 2021, 8:16 PM

#

GitHub

PROpen Trivia night event

patent pivot Oct 25, 2021, 11:10 PM

#

yea, we don't need it lol

#

not right now

#

don't see a major use for them

#

would rather filter outbound traffic tbqh

patent pivot Oct 25, 2021, 11:28 PM

#

https://monzo.com/blog/controlling-outbound-traffic-from-kubernetes

Monzo

Controlling outbound traffic from Kubernetes

We recently finished a major networking project which let us control internal traffic in our platform. And we've been thinking about how we can add similar security to network traffic leaving our platform.

#

monzo style

#

lol

#

trust, as it gets deeper, it is not simple

#

it's simple to describe, hard to build

#

we'll probably go with some sort of egress proxy similar to how istio run it

#

we can get away with only supporting HTTP and SNI, and I don't expect our production traffic to move to ECH anytime soon

#

it's in that blog post

#

they inspect HTTP Host header for HTTP or SNI for HTTPS

#

and allow based on a set of rules

#

I think I'll build a Rust service that can HA on each of our nodes

#

need to figure out how to push traffic towards it though

#

One approach, used by Istio, is to run an egress proxy inside Kubernetes. This egress proxy would inspect the traffic sent to it, figure out the destination, determine whether the destination was allowed (given the source) and then pass it on. To determine destinations for encrypted traffic, it has to use the SNI (Server Name Indication) field for encrypted (TLS) traffic. For unencrypted web traffic — which is becoming increasingly rare — it can simply inspect the HTTP Host header.

#

yep

#

we'll run one proxy on each node

#

might even run 2 per node

#

with a topology key

#

uhh

#

i mean

#

it can be lol

#

but topology is also very much in computer science, and the word topology just means "how certain things are arranged"

#

so in our case, a topology key tells Kubernetes how to lay out pods on our nodes

#

if I use a topology key that has an antiAffinity to node names, then Kubernetes will try it's best never to run the application on the same node if we mark it for HA

dim pelican Oct 25, 2021, 11:43 PM

#

sir-lancebot#842 is ready for you! Get some color / colour in your life

dusky shoreBOT Oct 25, 2021, 11:43 PM

#

GitHub

PROpen Add color command

patent pivot Oct 25, 2021, 11:43 PM

#

example is alertmanager: if we scale alertmanager kubernetes will place the new instance onto the node with the least alertmanager instances

#

https://github.com/python-discord/kubernetes/blob/main/namespaces/monitoring/alerts/alertmanager/deployment.yaml#L17-L30

stable mountainBOT Oct 25, 2021, 11:44 PM

#

namespaces/monitoring/alerts/alertmanager/deployment.yaml lines 17 to 30

affinity:
  podAntiAffinity:
    preferredDuringSchedulingIgnoredDuringExecution:
    - podAffinityTerm:
        labelSelector:
          matchExpressions:
          - key: app
            operator: In
            values:
            - alertmanager
        namespaces:
        - monitoring
        topologyKey: kubernetes.io/hostname
      weight: 100```

patent pivot Oct 25, 2021, 11:44 PM

#

our alertmanager config is probably the most complex thing we've got in the cluster

#

my SD solution was pretty solid https://github.com/python-discord/kubernetes/blob/main/namespaces/monitoring/alerts/alertmanager/initscript.yaml

#

I think DNS hijack is prooooobably the easiest way to configure the proxies

summer garden Oct 25, 2021, 11:50 PM

#

dim pelican sir-lancebot#842 is ready for you! Get some `color` / `colour` in your life

I love it

short snow Oct 26, 2021, 12:39 AM

#

brisk brook I haven't reviewed in a while and I don't think Xithrius has requested my review...

preseving unloaded cogs and modpings schedule :D

trail pilot Oct 26, 2021, 2:52 AM

#

dim pelican sir-lancebot#842 is ready for you! Get some `color` / `colour` in your life

Ooh, nice work! Left a review with one or two things but it's an approval from me

stable mountainBOT Oct 26, 2021, 3:10 AM

#

fallen patrol !remind 8H .

It has arrived!

Here's your reminder: .
[Jump back to when you created the reminder](#dev-contrib message)

stable mountainBOT Oct 26, 2021, 3:11 AM

#

fallen patrol !remind 8H make issue to make content of replies optional and use message refere...

It has arrived!

Here's your reminder: make issue to make content of replies optional and use message reference as content, in addition to replying to that instead
[Jump back to when you created the reminder](#dev-contrib message)

fallen patrol Oct 26, 2021, 5:02 AM

#

stable mountain

bot#1911

dusky shoreBOT Oct 26, 2021, 5:02 AM

#

GitHub

IssueOpen Upgrade the test suite mocks

static canyon Oct 26, 2021, 5:49 AM

#

I'm very confused as to why the tests on bot#1901 are failing. From running the test it seems I need to change'0.65 0.64 242' to '0.63 0.48 218' but I don't understand why or what these values repressent

dusky shoreBOT Oct 26, 2021, 5:49 AM

#

GitHub

PROpen Migrate to og_blurple

rapid igloo Oct 26, 2021, 6:20 AM

#

It seems that they are HSL color values, '0.65 0.64 242' looks like the og_blurple color and the other one looks like the rebranded blurple

short snow Oct 26, 2021, 6:21 AM

#

@static canyon we can use ctx.invoked_command to get the alias/command which was sued

rapid igloo Oct 26, 2021, 6:22 AM

#

I don't think that would include the subcommand (or the parent command, forgot which)

short snow Oct 26, 2021, 6:23 AM

#

that's just the parent command IIRC

#

which is what we need

rapid igloo Oct 26, 2021, 6:23 AM

#

are you talking about hackstats link?

short snow Oct 26, 2021, 6:25 AM

#

#dev-log message

rapid igloo Oct 26, 2021, 6:25 AM

#

oh right ok

rapid igloo Oct 26, 2021, 6:34 AM

#

rapid igloo It seems that they are HSL color values, `'0.65 0.64 242'` looks like the `og_bl...

Actually only '0.65 0.64 242' looks like HSL https://imagecolorpicker.com/color-code/6b67df
no idea what the other value is https://imagecolorpicker.com/color-code/2d66c8

clever wraith Oct 26, 2021, 6:46 AM

#

So did the autoban feature work or we broke everything hehe

#

I don't see any fix PR, that's a good first sign

static canyon Oct 26, 2021, 7:00 AM

#

clever wraith So did the autoban feature work or we broke everything hehe

Don't think we've actually had any triggers yet

clever wraith Oct 26, 2021, 7:01 AM

#

So sad

static canyon Oct 26, 2021, 7:01 AM

#

You could always send yourself to test it :p

clever wraith Oct 26, 2021, 7:01 AM

#

Haha

static canyon Oct 26, 2021, 7:01 AM

#

Wouldn't recommend though lol

clever wraith Oct 26, 2021, 7:01 AM

#

I could use our alt, since it won't ping

static canyon Oct 26, 2021, 7:01 AM

#

rapid igloo Actually only `'0.65 0.64 242'` looks like HSL https://imagecolorpicker.com/colo...

Yeah, it's kinda confusing me

static canyon Oct 26, 2021, 7:01 AM

#

clever wraith I could use our alt, since it won't ping

Yeah, it doesn't ping

#

And I can unban

clever wraith Oct 26, 2021, 7:02 AM

#

My alt already has like ten infractions, half of them being kicks lol

#

It may be already banned though

static canyon Oct 26, 2021, 7:02 AM

#

short snow <@!442244135840382978> we can use `ctx.invoked_command` to get the alias/command...

Right yeah, if that works then +1

clever wraith Oct 26, 2021, 7:03 AM

#

Aw, I don't have access to the test server so I can't give you the ID

#

I need to get that invite

#

The account is named Ishiro with a the weeknd profile picture, could you check it isn't banned?

static canyon Oct 26, 2021, 7:03 AM

#

What's the account name#discrim and I can get (send in DMs if you don't want to share publicly)

clever wraith Oct 26, 2021, 7:04 AM

#

No idea what the discrim is

static canyon Oct 26, 2021, 7:04 AM

#

Ishiro isn't in the test server

clever wraith Oct 26, 2021, 7:05 AM

#

Guess I yeeted it during my last testing

static canyon Oct 26, 2021, 7:05 AM

#

clever wraith Guess I yeeted it during my last testing

Is this it?

gentle harness Oct 26, 2021, 7:08 AM

#

Yus

clever wraith Oct 26, 2021, 7:10 AM

#

So it did work if y'all are curious

rapid igloo Oct 26, 2021, 7:12 AM

#

:o shouldnt the PR already be tested?

clever wraith Oct 26, 2021, 7:14 AM

#

Well it has been tested locally but not in prod yet

short snow Oct 26, 2021, 7:28 AM

#

how many alts do you have akarys 👀

clever wraith Oct 26, 2021, 7:28 AM

#

Only one

#

That account is not an alt

#

https://morethanone.info/

More Than One

A Plural 101

short snow Oct 26, 2021, 7:30 AM

#

hmm

molten perch Oct 26, 2021, 8:37 AM

#

feel free to break api#23 as well 🤓

dusky shoreBOT Oct 26, 2021, 8:37 AM

#

GitHub

PROpen Add Alembic Migration environment to the project, patch model architecture

molten perch Oct 26, 2021, 8:47 AM

#

I found a way to fix it. 😄 (partial solution :/ )

clever wraith Oct 26, 2021, 10:22 AM

#

@clever wraith I guess it would require patching the command rather that the code to ask for a confirmation instead, I don't know which monkey patch is the worse

#

I feel like patching annotations is a bit dodgy though

#

Also yeah I was thinking of a simple ❌/✅ modal, asking to run ?close 0s sounds unintuivive

#

I would even say we should ask for that confirmation for any close, since it happens we just run close when meaning to run another command

clever wraith Oct 26, 2021, 10:35 AM

#

clever wraith I feel like patching annotations is a bit dodgy though

Ultimately I just needed to update the annotation to use a new converter, I could've patched the command itself but that's pointless when patching the annotations gets me the same behaviour in a simpler manner

#

man, I discovered that running command.update borks the command when it's a part of a cog, not the most fun

#

Heh

clever wraith Oct 26, 2021, 10:37 AM

#

clever wraith I would even say we should ask for that confirmation for any close, since it hap...

Im not sure about that, i don't think we do that enough to justify needing confirmation - but we could ask more mods

clever wraith Oct 26, 2021, 10:58 AM

#

clever wraith Im not sure about that, i don't think we do that enough to justify needing confi...

I know Akarys does that quote often when trying to run ?cancel haha

reef tinsel Oct 26, 2021, 11:03 AM

#

Hi! I just updated my copy of Bot to the latest, which including moving discord.py to v2

It is now having this error (ImportError: cannot import name 'Thread' from 'discord' (/usr/local/lib/python3.9/site-packages/discord/__init__.py)) when starting, and exiting straight away:

https://paste.pythondiscord.com/gusamahata.sql

This is happening in random cogs each time, presumably the first one trying to import this.

Could someone help?

vale ibex Oct 26, 2021, 11:03 AM

#

Do you run using docker?

reef tinsel Oct 26, 2021, 11:04 AM

#

yes - running docker-compose up to start

vale ibex Oct 26, 2021, 11:04 AM

#

great, you'll need to do docker-compose build first

reef tinsel Oct 26, 2021, 11:04 AM

#

aah

vale ibex Oct 26, 2021, 11:04 AM

#

this rebuilds the image with the updated dependancies

reef tinsel Oct 26, 2021, 11:04 AM

#

makes sense

vale ibex Oct 26, 2021, 11:05 AM

#

Actually, there are also some site changes, so I suggest you do docker-compose pull too

#

then docker-compose up

reef tinsel Oct 26, 2021, 11:05 AM

#

👍

short snow Oct 26, 2021, 11:06 AM

#

@dim pelican You should resolve the requested changes after you push them

vale ibex Oct 26, 2021, 11:06 AM

#

Also, for those site changes you will need to update your confil.yml file too @reef tinsel

dim pelican Oct 26, 2021, 11:06 AM

#

short snow <@!698273827448291379> You should resolve the requested changes after you push t...

Yup, I thought I did....

Running out the door now so I'll need to check everything a bit later (and away from my testing setup until the end of the day 😟 )

short snow Oct 26, 2021, 11:07 AM

#

Yeah that's perfectly fine, no hurrries

#

you can take your time

vale ibex Oct 26, 2021, 11:07 AM

#

Under the urls section, set site_api to site_api: &API !JOIN [*DOMAIN, "/api"] and site_staff to site_staff: &STAFF !JOIN [*DOMAIN, "/staff"]

short snow Oct 26, 2021, 11:07 AM

#

just remember next time 👍

#

Doesn't the new contrib guide cover this? (chris)

reef tinsel Oct 26, 2021, 11:07 AM

#

vale ibex Under the urls section, set `site_api` to `site_api: &API !JOIN [*DOMAIN, ...

👍

vale ibex Oct 26, 2021, 11:07 AM

#

short snow Doesn't the new contrib guide cover this? (chris)

yes, but it's easier for me to just say what the differences are, rather than send them a link and tell them to read the whole thing

reef tinsel Oct 26, 2021, 11:12 AM

#

thx chris - bot working now! the patreon additions should come by the end of half term!

vale ibex Oct 26, 2021, 11:12 AM

#

Nice 😄

fervent sage Oct 26, 2021, 11:49 AM

#

scottish half term just ended Kek

reef tinsel Oct 26, 2021, 11:50 AM

#

regarding bot#1765

with the monthly post, should we send the tier 1 supporters first, or the tier 3 first. (we decided on a seperate message for each one here: #dev-contrib message)

Discord

Discord - A New Way to Chat with Friends & Communities

Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

dusky shoreBOT Oct 26, 2021, 11:50 AM

#

GitHub

IssueOpen Shoutout our patreon supporters!

reef tinsel Oct 26, 2021, 11:50 AM

#

half term started at 12:00 last thusday (it actually started 10 mins early lol) and finishes on sunday this term

#

(just for my school, other schools ear here do different things)

short snow Oct 26, 2021, 11:51 AM

#

Mine finished on this sunday 😄

static canyon Oct 26, 2021, 12:19 PM

#

reef tinsel regarding bot#1765 with the monthly post, should we send the tier 1 supporters...

Imo it makes most sense for tier 1 first

#

That way it's sequential but also the tier 3 will be the last seen when the messages "move up" from other activity

reef tinsel Oct 26, 2021, 12:37 PM

#

ok

#

i was defaulting to tier 1 first, just asked to get a sense of what other people wanted 🙂

short snow Oct 26, 2021, 12:39 PM

#

@clever wraith I just went ahead and tried out the functionality, yours thoughts on this.

Its how the leaderboard will interact the core leaderabord functionality

#

and could i get assigned to the issue

clever wraith Oct 26, 2021, 12:40 PM

#

That looks good, I'd just rename that function to increment_points rather than change

short snow Oct 26, 2021, 12:40 PM

#

ah wait, that could isn't fully updated

#

the funciton name is right

#

#

it would be like this

#

lambda before: before + 10 instead of 10

clever wraith Oct 26, 2021, 12:41 PM

#

Well, I would say we should have an increment utility function, for clarity sake

#

I don't think we will need to do any other operation anyway

#

Also beware that you have a potential race condition there, I wonder if we could solve this using a Redis transaction

short snow Oct 26, 2021, 12:42 PM

#

yeah, its not final, i doesn't even check if a cache alrady exists and just forms a new one rn

clever wraith Oct 26, 2021, 12:43 PM

#

Okay, cool

short snow Oct 26, 2021, 12:43 PM

#

and that to_dict is just for debug, i am removing it

clever wraith Oct 26, 2021, 12:44 PM

#

Don't forget to also add a maximum of points earned per (user, game, day)

#

Morning all

#

I'll be doing some work on bot#1889 after school, otherwise Ill be busy today

dusky shoreBOT Oct 26, 2021, 12:44 PM

#

GitHub

PROpen feat: added url parsing to the filter

short snow Oct 26, 2021, 12:46 PM

#

clever wraith Don't forget to also add a maximum of points earned per (user, game, day)

would that be per game, or overall

clever wraith Oct 26, 2021, 12:47 PM

#

Per game I'd say, so you must play different things and cannot just spam .quiz alone

short snow Oct 26, 2021, 12:47 PM

#

Right, would you like to have another cache for that, or should i merge it with the main one (per day leaderboard)

clever wraith Oct 26, 2021, 12:48 PM

#

I would say another leaderboard

short snow Oct 26, 2021, 12:48 PM

#

👍 kk

rapid igloo Oct 26, 2021, 1:18 PM

#

dusky shore

Re: https://github.com/python-discord/bot/pull/1889#discussion_r735661695
I think .hostname would be good enough for message_url since the matched group contains the scheme. However for blacklist urls that may not have a scheme I generally check if .hostname is None, then re-parse with https:// prefix if so

vale ibex Oct 26, 2021, 1:21 PM

#

Yea, agreed. We're changing direction with that PR anyway, due to sub domains see #dev-contrib message

rapid igloo Oct 26, 2021, 1:21 PM

#

vale ibex Yea, agreed. We're changing direction with that PR anyway, due to sub domains se...

is that the same message linked in the last PR comment?

vale ibex Oct 26, 2021, 1:21 PM

#

Yea

rapid igloo Oct 26, 2021, 1:22 PM

#

👍 tldextract probably handles the scheme thing so that's good

vale ibex Oct 26, 2021, 1:22 PM

#

Yup 😄

rapid igloo Oct 26, 2021, 1:25 PM

#

vale ibex IE if we blacklist bbc.co.uk, someone sending https://news.bbc.co.uk wouldn't g...

curious what advantage tldextract provides over just splitting the two hostnames by . and comparing the tuple or list? (sorry if this was discussed above the linked message since I didn't read much far before it)

vale ibex Oct 26, 2021, 1:26 PM

#

you can have sub-sub domains

#

and tlds can have multiple parts

#

IE news.bbc.co.uk

#

and web.www.google.com (this isn't real, just an example)

#

so there isn't a reliable way to get the actual domain without a full list of tlds

rapid igloo Oct 26, 2021, 1:28 PM

#

so if google.com is blacklisted, we want web.www.google.com to match? or is it the other way round like www.google.com blacklisted and wanting google.com to match?

clever wraith Oct 26, 2021, 1:28 PM

#

I'm sure the BBC is trying to be a pain on purpose

vale ibex Oct 26, 2021, 1:29 PM

#

Yea, in the blacklist we have domains+tlds

#

and we want to match all sub domains

clever wraith Oct 26, 2021, 1:29 PM

#

www should be stripped in my opinion, it should be counted as if it was the root domain

rapid igloo Oct 26, 2021, 1:29 PM

#

vale ibex and we want to match all sub domains

so it's the former of which I've listed?

vale ibex Oct 26, 2021, 1:29 PM

#

Yea

#

but we don't want to block google domain directly, ignoring the tld

#

since python.com and python.org are a thing

#

so we want to block python.com but not python.org

#

so we want to make sure the domains match exactly, and the tlds match exactly, and ignore any subdomains when matching

steady junco Oct 26, 2021, 1:35 PM

#

It's been a week I think when I opened my issue and I got no comment till now
Is this common 🤔?

static canyon Oct 26, 2021, 1:36 PM

#

steady junco It's been a week I think when I opened my issue and I got no comment till now I...

What's the issue?

steady junco Oct 26, 2021, 1:36 PM

#

.src

steady junco Oct 26, 2021, 1:37 PM

#

static canyon What's the issue?

https://github.com/python-discord/sir-lancebot/issues/920 This

GitHub

Funny gif command · Issue #920 · python-discord/sir-lancebot

This is a command for Sir Lancebot to send a funny gif from tenor. There can be a cooldown on the command. The cooldown will be decided by other people, I think 5sec cooldown for the command is goo...

static canyon Oct 26, 2021, 1:41 PM

#

Have made a request internally for someone to take a look 👍

#

Give it a few more days

rapid igloo Oct 26, 2021, 1:56 PM

#

vale ibex so we want to make sure the domains match exactly, and the tlds match exactly, a...

okay that clears up a bit for me (though I still don't understand why comparing hostnames isn't enough but it's ok)

vale ibex Oct 26, 2021, 1:58 PM

#

It is enough, there just isn't a reliable way to extract hostnames for all cases without a list of tlds

reef tinsel Oct 26, 2021, 3:02 PM

#

does anyone have any idea as to why this is happenning? (code snippets coming shortly, depending on how my internet/computer play ball 🙂 )

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/discord/ext/commands/core.py", line 167, in wrapped
    ret = await coro(*args, **kwargs)
  File "/bot/bot/exts/info/patreon.py", line 170, in current_supporters_command
    await self.send_current_supporters(ctx.channel)
  File "/bot/bot/exts/info/patreon.py", line 108, in send_current_supporters
    embed.add_field(actual_tier_1_members[0]) #.mention
TypeError: add_field() takes 1 positional argument but 2 were given

vale ibex Oct 26, 2021, 3:04 PM

#

add_field() requires you to use named args

#

not positional

#

add_field(name="foo", value="bar")

reef tinsel Oct 26, 2021, 3:05 PM

#

aah

#

got quite a few to change then, as i Have about 7 of these in this code atm 😉

#

good thing is i can copy paste

#

i assume that name is the title of the field

#

having done a quick test, it is

#

and it cannot be an empty string

#

how should I do the lists of members for the patreon (bot#1765) - I was planning on doing basically this: embed.add_field(value = member.mention) @vale ibex ?

dusky shoreBOT Oct 26, 2021, 3:20 PM

#

GitHub

IssueOpen Shoutout our patreon supporters!

brisk brook Oct 26, 2021, 3:21 PM

#

Just format something pretty in the description no?

vale ibex Oct 26, 2021, 3:21 PM

#

You could just do ```py
embed = discord.Embed(
title="Tier 1 patrons",
description="\n".join(tier1_patrons)
)

#

Since we're going with 3 embeds

reef tinsel Oct 26, 2021, 3:22 PM

#

that could work, guess i'd still overflow into a second emebd if limits got hit?

static canyon Oct 26, 2021, 3:22 PM

#

reef tinsel and it cannot be an empty string

Fyi if you want it to be empty you can set to "\u200b" which is a zero-width space

vale ibex Oct 26, 2021, 3:23 PM

#

I don't think we need to worry about that, since we're having each tier in it's own embed

#

and each embed description can support 4096 chars

#

!e print(4096//37)

stable mountainBOT Oct 26, 2021, 3:24 PM

#

@vale ibex :white_check_mark: Your eval job has completed with return code 0.

vale ibex Oct 26, 2021, 3:24 PM

#

so we could support ~100 patrons in each tier with just 1 embed

reef tinsel Oct 26, 2021, 3:24 PM

#

were those messages referring to me or tizzy chris?

vale ibex Oct 26, 2021, 3:24 PM

#

you

reef tinsel Oct 26, 2021, 3:25 PM

#

ok

#

so i include handling for over 110 patrons or assume that it will never happen?

vale ibex Oct 26, 2021, 3:25 PM

#

nah I wouldn't bother for now

reef tinsel Oct 26, 2021, 3:25 PM

#

ok

vale ibex Oct 26, 2021, 3:25 PM

#

since it's not over 110 patrons, it's over 110 in a single tier

reef tinsel Oct 26, 2021, 3:26 PM

#

so if it does get to that point (or close) we can upgrade from there 🙂

#

yes

#

i agree it is unlikely that it will happen 🙂

static canyon Oct 26, 2021, 3:28 PM

#

vale ibex nah I wouldn't bother for now

Would it be worth just doingpy if len(tier_members) > 110: log.warning("Tier {x} has more than 110 members. May fail to generate embed due to character length.")or something?

vale ibex Oct 26, 2021, 3:29 PM

#

ehh it's technically not 110

#

@vale ibex

#

!raw 902579684552871947

stable mountainBOT Oct 26, 2021, 3:29 PM

#

== Raw message ==

@vale ibex

vale ibex Oct 26, 2021, 3:29 PM

#

so it's an id(20 chars) +4

#

so 24 per name, plus one for a new line

#

!e print(4096//25)

stable mountainBOT Oct 26, 2021, 3:30 PM

#

@vale ibex :white_check_mark: Your eval job has completed with return code 0.

vale ibex Oct 26, 2021, 3:30 PM

#

20 is worst case too

#

we're at 18/19 atm

brisk brook Oct 26, 2021, 3:30 PM

#

Don't we want to include the name?

vale ibex Oct 26, 2021, 3:31 PM

#

we're gonna do a mention

brisk brook Oct 26, 2021, 3:31 PM

#

That doesn't actually ping the user or send a mentions objects, meaning that for mobile client they will all render as "invalid-user"

reef tinsel Oct 26, 2021, 3:31 PM

#

goood point

vale ibex Oct 26, 2021, 3:31 PM

#

we don't want it to ping

reef tinsel Oct 26, 2021, 3:32 PM

#

but the rendering point is a problem

vale ibex Oct 26, 2021, 3:32 PM

#

and for the latter we don't have a better solution unless we do both

#

which isn't great either

reef tinsel Oct 26, 2021, 3:33 PM

#

we could do the mention, and if we get too many complaints change it?

brisk brook Oct 26, 2021, 3:33 PM

#

vale ibex which isn't great either

Is it not? Do we really not have enough characters?

vale ibex Oct 26, 2021, 3:35 PM

#

I meant on a pure looks point of view, including both the name and mention would look overkill for anyone who isn't on mobile, and may have a similar number of questions raised about it

#

but I guess I'm also biased since I never use mobile Discord, due to these issues and more

reef tinsel Oct 26, 2021, 3:36 PM

#

i will do the mentions only for now, send screenshots of it on desktop, ipad and android phone (the 3 devices I have :-)), and we can decide

#

whats best

#

sorry for the cut off

brisk brook Oct 26, 2021, 3:51 PM

#

Chrisjl#2655 (@vale ibex)

#

That looks alright- no?

reef tinsel Oct 26, 2021, 3:52 PM

#

id say it looks fine, even without having had the mobile problems

#

does anyone have any idea as to why guild.get_role(ROLE).members is returning [], even though it clearly has a member (me)?

#

i can confirm that ROLE is a valid role, as the exact same variable is working elsewhere

cold island Oct 26, 2021, 3:54 PM

#

Uuuh I think it's an intent thing

#

You're working on sir lance?

reef tinsel Oct 26, 2021, 3:54 PM

#

nope, bot

cold island Oct 26, 2021, 3:54 PM

#

Did you turn on intents for your bot?

reef tinsel Oct 26, 2021, 3:54 PM

#

bot has the members intent enable in the portal

cold island Oct 26, 2021, 3:54 PM

#

hmm

#

Is this called inside some command?

reef tinsel Oct 26, 2021, 3:55 PM

#

i also assume that they are enabled in the mains script

cold island Oct 26, 2021, 3:55 PM

#

Or while a cog is initializing

reef tinsel Oct 26, 2021, 3:55 PM

#

cold island Is this called inside some command?

yes

#

it is inside a function called by a command function (currently useless, but for a reason)

cold island Oct 26, 2021, 3:56 PM

#

What do you get when you do guild.members?

reef tinsel Oct 26, 2021, 3:58 PM

#

it is returning an empty list (it should be 2 members - myself and my copy of bot)

thorny obsidian Oct 26, 2021, 3:59 PM

#

brisk brook Chrisjl#2655 (<@126811506632294400>)

I'm not really a fan of how that looks to be honest.

brisk brook Oct 26, 2021, 4:02 PM

#

Oh?

#

It's too duplicated- or?

thorny obsidian Oct 26, 2021, 4:03 PM

#

The name#disc just doesn't look that nice and the (mention) doesn't either. Either it should be the mention or just the name.

cold island Oct 26, 2021, 4:03 PM

#

We do the opposite in other parts of the bot, like @cold island (mbaruh#0278)

reef tinsel Oct 26, 2021, 4:05 PM

#

cold island We do the opposite in other parts of the bot, like <@!512354988157173763> (mbaru...

if we're doing something similar elsewhere in Bot already, then I guess we can do that, following the same pattern?

green oriole Oct 26, 2021, 4:11 PM

#

Mention in embeds make mobile users feel very bad about themselves

static canyon Oct 26, 2021, 4:11 PM

#

cold island We do the opposite in other parts of the bot, like <@!512354988157173763> (mbaru...

I prefer this format too

cold island Oct 26, 2021, 4:16 PM

#

reef tinsel it is returning an empty list (it should be 2 members - myself and my copy of bo...

Yeah I'm not sure. It should be resolved by the members intent

#

Maybe someone over at #discord-bots has an idea

fallen patrol Oct 26, 2021, 4:21 PM

#

bot#1911 @vale ibex 🙃

dusky shoreBOT Oct 26, 2021, 4:21 PM

#

GitHub

IssueOpen Upgrade the test suite mocks

vale ibex Oct 26, 2021, 4:22 PM

#

vale ibex No idea how that impacts personally, as I haven't worked with our tests much

. @fallen patrol

fallen patrol Oct 26, 2021, 4:23 PM

#

Ye the point was I made it and I think I linked to the correct discussion

static canyon Oct 26, 2021, 4:26 PM

#

reef tinsel if we're doing something similar elsewhere in Bot already, then I guess we can d...

I'd say so, yeah

#

And then we'd need to figure out what the worst-case for reaching embed description char limit for the warning

molten perch Oct 26, 2021, 5:17 PM

#

Wow. Would love to see them on api#23 lemon_fingerguns_shades

dusky shoreBOT Oct 26, 2021, 5:17 PM

#

GitHub

PROpen Add Alembic Migration environment to the project, patch model architecture

green oriole Oct 26, 2021, 5:19 PM

#

Huh, interesting choice with purple closed

#

I guess we should start to use those tags more often CC @vocal wolf

reef tinsel Oct 26, 2021, 5:20 PM

#

cold island Maybe someone over at <#343944376055103488> has an idea

turns out the problem was I was using fetch_guild rather than get_guild 🙂

reef tinsel Oct 26, 2021, 5:22 PM

#

brisk brook That doesn't actually ping the user or send a `mentions` objects, meaning that f...

Both my iPad and my android phone are rendering the mention well

brisk brook Oct 26, 2021, 5:23 PM

#

But that's because you're testing with yourself and bot

reef tinsel Oct 26, 2021, 5:23 PM

#

Aah, does it work well with myself?

brisk brook Oct 26, 2021, 5:24 PM

#

Well that's you, and the bot should also be in cache

reef tinsel Oct 26, 2021, 5:24 PM

#

Aah, so if I’m not in cache thats when the problems happen?

brisk brook Oct 26, 2021, 5:24 PM

#

reef tinsel Aah, so if I’m not in cache thats when the problems happen?

Exactly

reef tinsel Oct 26, 2021, 5:24 PM

#

How do I remove myself from cache lol

#

(Ik i can’t)

#

(Probably)

vocal wolf Oct 26, 2021, 5:46 PM

#

green oriole I guess we should start to use those tags more often CC <@196664644113268736>

What tags?

static canyon Oct 26, 2021, 6:13 PM

#

I suppose this also means the icons for @dusky shore linking github issues/prs should be updated

green oriole Oct 26, 2021, 6:25 PM

#

vocal wolf What tags?

Won't fix and duplicate, as it will change the issue status icon

vocal wolf Oct 26, 2021, 6:28 PM

#

green oriole Won't fix and duplicate, as it will change the issue status icon

We don't use them that often already, and I'm looking out for those issues/PRs.

green oriole Oct 26, 2021, 6:29 PM

#

I think we should be using them more though, especially won't fix

#

They have relevance now

vocal wolf Oct 26, 2021, 6:29 PM

#

Alright, but they already don't happen that often. Usually there's something to fix, and duplicates are very rare.

green oriole Oct 26, 2021, 6:32 PM

#

I was thinking about issues we do close without submitting a PR, I think that's how the new branding is designed, you want the icon to be purple if you have a PR that fixed it, otherwise just gray?

vocal wolf Oct 26, 2021, 6:34 PM

#

I guess

green oriole Oct 26, 2021, 6:37 PM

#

Oh, it isn't a thing right now

#

That was just an example they need to figure out the details of those different closed states

#

Cool

green oriole Oct 26, 2021, 7:27 PM

#

@vale ibex we said we didn't want to store that in Redis lul

reef tinsel Oct 26, 2021, 7:28 PM

#

bot#1765

dusky shoreBOT Oct 26, 2021, 7:28 PM

#

GitHub

IssueOpen Shoutout our patreon supporters!

reef tinsel Oct 26, 2021, 7:28 PM

#

does this look good?

green oriole Oct 26, 2021, 7:29 PM

#

I think that looks decent, although I would add some wording on why Patreon is relevant for us and stuff like that

dim pelican Oct 26, 2021, 7:29 PM

#

Ahhhh light mode! My eyes! ||\s|| But I agree that it looks pretty good

vale ibex Oct 26, 2021, 7:30 PM

#

green oriole <@126811506632294400> we said we didn't want to store that in Redis lul

Store what in redis?

reef tinsel Oct 26, 2021, 7:30 PM

#

green oriole I think that looks decent, although I would add some wording on why Patreon is r...

could you provide an idea for this?

green oriole Oct 26, 2021, 7:30 PM

#

vale ibex Store what in redis?

IDs of DM bookmarks

vale ibex Oct 26, 2021, 7:30 PM

#

That's not what I've stored in redis

#

I used redis to store the IDs of the messages you have bookmarked

#

so you can't bookmark the same message twice accidentally

green oriole Oct 26, 2021, 7:31 PM

#

reef tinsel could you provide an idea for this?

I am currently on mobile, can't worte that right now, sorry lemon_cut

vale ibex Oct 26, 2021, 7:31 PM

#

sir-lancebot#826

dusky shoreBOT Oct 26, 2021, 7:31 PM

#

GitHub

IssueOpen Duplicate bookmark prevention

green oriole Oct 26, 2021, 7:31 PM

#

Aah

reef tinsel Oct 26, 2021, 7:31 PM

#

green oriole I am currently on mobile, can't worte that right now, sorry <:lemon_cut:78565045...

ok 🙂 - I can't think of anything, so if someone can write anything just @ me!

vale ibex Oct 26, 2021, 7:32 PM

#

This is what we say on our actual patreon page ```
We'd like to be able to offer excellent prizes for all of our events. Stuff like t-shirts, stickers, microcontrollers that support CircuitPython, or maybe even a mechanical keyboard. We believe that this would help motivate more people to participate in our events, and we believe these events are a great way to learn how to work in teams with strangers, learn about source control, and just generally get out of your comfort zone and learn something new.

While we rely on sponsorships to cover things like hosting, we will need actual hard cash if we're going to be able to pay for these prizes. But let me make this clear: We are non-profit. 100% of our earnings will be put towards improving the community in one way or another.

stable mountainBOT Oct 26, 2021, 7:34 PM

#

Patreon supporters
Here is a full list of this months Python Discord patrons!

We use the money from Patreon to offer excellent prizes for all of our events. Stuff like t-shirts, stickers, microcontrollers that support CircuitPython, or maybe even a mechanical keyboard. We believe these events are a great way to learn how to work in teams with strangers, learn about source control, and just generally get out of your comfort zone and learn something new.

You can also support us on Patreon here!

vale ibex Oct 26, 2021, 7:35 PM

#

seems a bit too wordy

reef tinsel Oct 26, 2021, 7:35 PM

#

yeah

green oriole Oct 26, 2021, 7:36 PM

#

That text could 100% use an update

vale ibex Oct 26, 2021, 7:36 PM

#

!embed Patreon supporters
Here is a full list of this months Python Discord patrons!

We use the money from Patreon to offer excellent prizes for all of our events. Stuff like t-shirts, stickers, microcontrollers that support CircuitPython, or maybe even a mechanical keyboard.

You can read more about how Patreon supports us, or even support us yourself, on our Patreon page here!

stable mountainBOT Oct 26, 2021, 7:36 PM

#

Patreon supporters
Here is a full list of this months Python Discord patrons!

We use the money from Patreon to offer excellent prizes for all of our events. Stuff like t-shirts, stickers, microcontrollers that support CircuitPython, or maybe even a mechanical keyboard.

You can read more about how Patreon supports us, or even support us yourself, on our Patreon page here!

vale ibex Oct 26, 2021, 7:36 PM

#

That seems a bit better

reef tinsel Oct 26, 2021, 7:36 PM

#

👍

#

hmmm, now to fit that into the line length limit 🙂

green oriole Oct 26, 2021, 7:38 PM

#

Did we ever buy someone a keyboard lol

austere hornet Oct 26, 2021, 7:39 PM

#

Lol

reef tinsel Oct 26, 2021, 7:40 PM

#

lol

vale ibex Oct 26, 2021, 7:42 PM

#

green oriole Did we ever buy someone a keyboard lol

We did 😄

#

I think a laptop at one point too

green oriole Oct 26, 2021, 7:42 PM

#

Wow

vocal wolf Oct 26, 2021, 7:44 PM

#

vale ibex I think a laptop at one point too

Someone did a codejam entirely on their phone and won 2nd or 3rd place, so we asked the other winners if they wanted to accumulate their prizes into a laptop for the guy, eventually sent one out.

vale ibex Oct 26, 2021, 7:44 PM

#

Yup 😄

#

iirc lemon put a decent amount of his own money down on it too

green oriole Oct 26, 2021, 7:49 PM

#

haha, that's awesome

#

didn't hear about that one anywhere

austere hornet Oct 26, 2021, 8:06 PM

#

vocal wolf Someone did a codejam entirely on their phone and won 2nd or 3rd place, so we as...

Wow

#

Was it this year or in previous years?

clever wraith Oct 26, 2021, 8:44 PM

#

vocal wolf Someone did a codejam entirely on their phone and won 2nd or 3rd place, so we as...

What a god

vocal wolf Oct 26, 2021, 8:59 PM

#

austere hornet Was it this year or in previous years?

many years ago

austere hornet Oct 26, 2021, 9:09 PM

#

vocal wolf many years ago

Ah ok

cold island Oct 26, 2021, 10:01 PM

#

Do we have a datetime -> Discord timestamp command? should I just make one?

#

I see there's an issue

austere hornet Oct 26, 2021, 10:04 PM

#

Hi, I'm having some weird issue with isort. I pip installed it and ran isort . in the project root (sir-lancebot\bot) but I'm still getting this error? What should I do?

cold island Oct 26, 2021, 10:05 PM

#

I'd just use a full path rather than relative

#

Although it's an interesting problem

austere hornet Oct 26, 2021, 10:09 PM

#

Still getting same error

cold island Oct 26, 2021, 10:13 PM

#

Well it looks like you still have a relative import

austere hornet Oct 26, 2021, 10:14 PM

#

Wdym by "relative import"?

green oriole Oct 26, 2021, 10:15 PM

#

you need to run poetry install --remove-untracked @austere hornet

austere hornet Oct 26, 2021, 10:16 PM

#

Ohh

#

Ok

#

Finally

#

Tysm

#

@green oriole and @cold island

short snow Oct 27, 2021, 12:48 AM

#

How do you clear the buttons of a discord ui View once the interaction is complete?

patent pivot Oct 27, 2021, 12:49 AM

#

I have some code in KA which does that

#

uhhh

patent pivot Oct 27, 2021, 12:49 AM

#

short snow How do you clear the buttons of a discord ui View once the interaction is comple...

https://github.com/python-discord/king-arthur/blob/main/arthur/exts/cloudflare/zones.py#L22-L24

stable mountainBOT Oct 27, 2021, 12:49 AM

#

arthur/exts/cloudflare/zones.py lines 22 to 24

def disable_select(self) -> None:
    """Disable the select button."""
    self.children[0].disabled = True```

patent pivot Oct 27, 2021, 12:49 AM

#

that's my approach, call that from the interaction function and then do this https://github.com/python-discord/king-arthur/blob/main/arthur/exts/cloudflare/zones.py#L52-L54

stable mountainBOT Oct 27, 2021, 12:49 AM

#

arthur/exts/cloudflare/zones.py lines 52 to 54

self.disable_select()

await interaction.message.edit(view=self)```

short snow Oct 27, 2021, 12:50 AM

#

👍 Thanks

short snow Oct 27, 2021, 1:18 AM

#

🎉

#

Could I get hacktoberfest accepted label on that PR?

patent pivot Oct 27, 2021, 1:59 AM

#

short snow Could I get hacktoberfest accepted label on that PR?

👍

stable barn Oct 27, 2021, 3:37 AM

#

how can i dev contribute?

rapid igloo Oct 27, 2021, 3:39 AM

#

!contribute

stable mountainBOT Oct 27, 2021, 3:39 AM

#

Contribute to Python Discord's Open Source Projects
Looking to contribute to Open Source Projects for the first time? Want to add a feature or fix a bug on the bots on this server? We have on-going projects that people can contribute to, even if you've never contributed to open source before!

Projects to Contribute to
• Sir Lancebot - our fun, beginner-friendly bot
• Python - our utility & moderation bot
• Site - resources, guides, and more

Where to start

Read our contributing guidelines
Chat with us in #dev-contrib if you're ready to jump in or have any questions
Open an issue or ask to be assigned to an issue to work on

fallen patrol Oct 27, 2021, 5:29 AM

#

@static canyon which project had coveralls cut?

short snow Oct 27, 2021, 6:02 AM

#

Looks like GitHub changed their icons again

#

someone is doing a lot of ducky_bike

static canyon Oct 27, 2021, 6:56 AM

#

fallen patrol <@!442244135840382978> which project had coveralls cut?

Wdym?

fallen patrol Oct 27, 2021, 6:57 AM

#

when coveralls was down it was removed from a project

#

which project was that

static canyon Oct 27, 2021, 6:57 AM

#

#dev-log message this?

#

Oh wait you mean that

#

I know what you mean

#

If you look at git history of the file it'll show

#

@fallen patrol https://github.com/python-discord/bot/commit/802fa0dd29f35d4cf02c7be88dcec01d9ab67729#diff-87ee5504a3e25ac558b343724c905f2f7949e8cec3d92b9c4300bb922afa164f

GitHub

Remove coveralls from lint-test · python-discord/bot@802fa0d

#

bot#1838

dusky shoreBOT Oct 27, 2021, 6:59 AM

#

GitHub

PRMerged Remove coveralls from lint-test

fallen patrol Oct 27, 2021, 6:59 AM

#

thanks!

#

!close

#

...

rapid igloo Oct 27, 2021, 6:59 AM

#

lmao

fallen patrol Oct 27, 2021, 6:59 AM

#

im gonna go sleep now cya

static canyon Oct 27, 2021, 6:59 AM

#

lol

fallen patrol Oct 27, 2021, 7:01 AM

#

static canyon <@717983911824588862> https://github.com/python-discord/bot/commit/802fa0dd29f35...

!remind 16H .

stable mountainBOT Oct 27, 2021, 7:01 AM

#

Absolutely!

Your reminder will arrive on <t:1635375667:F>!

short snow Oct 27, 2021, 7:06 AM

#

fallen patrol !close

👀

#

lie

#

fallen patrol Oct 27, 2021, 7:13 AM

#

shh

vale ibex Oct 27, 2021, 7:49 AM

#

patent pivot that's my approach, call that from the interaction function and then do this htt...

You can also just do view=None and not bother with the disabling

#

There's a synchronous .stop() method on the view of you are worried about hanging callback listeners

short snow Oct 27, 2021, 8:42 AM

#

#bot-commands message why isn't this working?

vale ibex Oct 27, 2021, 8:48 AM

#

There's a 2000 char and 15 line limit

short snow Oct 27, 2021, 8:49 AM

#

Oh, it should post a message then ig

vale ibex Oct 27, 2021, 8:49 AM

#

We could. It's this line here that does the check https://github.com/python-discord/bot/blob/main/bot/exts/info/code_snippets.py#L252

stable mountainBOT Oct 27, 2021, 8:49 AM

#

bot/exts/info/code_snippets.py line 252

if 0 < len(message_to_send) <= 2000 and message_to_send.count('\n') <= 15:```

short snow Oct 27, 2021, 8:54 AM

#

Ok, want me to open a quick PR?

static canyon Oct 27, 2021, 8:55 AM

#

short snow Oh, it should post a message then ig

If it did, I'd rather it self-deletes after like 3 seconds or something

#

I wouldn't want it to stay

short snow Oct 27, 2021, 8:56 AM

#

yeah

static canyon Oct 27, 2021, 8:56 AM

#

3 seconds should be enough for the message author to understand why it didn't link

#

Maybe 5 tops depending on the length of the message

short snow Oct 27, 2021, 8:57 AM

#

Is it possible to send those ephemeral messages without views? Like those system messages

static canyon Oct 27, 2021, 8:57 AM

#

I'd also invert the if statement

short snow Oct 27, 2021, 8:57 AM

#

yeah reduce one indentation

static canyon Oct 27, 2021, 8:57 AM

#

Mhm

short snow Oct 27, 2021, 8:58 AM

#

lemme see how its implemented in views

static canyon Oct 27, 2021, 8:58 AM

#

short snow Is it possible to send those ephemeral messages without views? Like those system...

I don't think so, but could be wrong

gritty wind Oct 27, 2021, 8:58 AM

#

You can send it as a regular user message

#

but not a system message

#

Would undermine the whole system part of that

short snow Oct 27, 2021, 8:59 AM

#

Yeah even I don;t think, but just now i got those invite people notification in the channel list and saw the ephemeral message. So thought about that

vale ibex Oct 27, 2021, 9:00 AM

#

afaik ephemeral messages can only be sent in response to an interaction

gritty wind Oct 27, 2021, 9:00 AM

#

Yeah

static canyon Oct 27, 2021, 9:01 AM

#

short snow Ok, want me to open a quick PR?

I'd still open an issue first btw

short snow Oct 27, 2021, 9:01 AM

#

Hmm yeah, interactions without any UI component could be used though?

fervent sage Oct 27, 2021, 9:08 AM

#

short snow Hmm yeah, interactions without any UI component could be used though?

huh?

#

the point of an interaction is that its user generated by interacting (hence the name) with a ui component

short snow Oct 27, 2021, 9:15 AM

#

Ah yeah

clever wraith Oct 27, 2021, 9:34 AM

#

@gritty wind how long were the reminders you talked about?

gritty wind Oct 27, 2021, 9:34 AM

#

7D1M

#

That's the latest one

#

But it varies

#

I also had one that was a year

#

let me look

clever wraith Oct 27, 2021, 9:34 AM

#

That's interesting

#

!source remind

stable mountainBOT Oct 27, 2021, 9:35 AM

#

Command: remind

Commands for managing your reminders.

Source Code

Go to GitHub

gritty wind Oct 27, 2021, 9:35 AM

#

24H

#

And one that was 10H but literally disappeared as soon as I made it

#

I tried to cancel it right after

clever wraith Oct 27, 2021, 9:35 AM

#

Huh, how weird

#

Did you check those two reminders got actually inserted?

gritty wind Oct 27, 2021, 9:35 AM

#

How would I do that though

clever wraith Oct 27, 2021, 9:35 AM

#

Metabase

#

Lemme check something

gritty wind Oct 27, 2021, 9:36 AM

#

Not sure what you mean

#

I can check the DB itself, but the object is deleted

#

By the time I know a problem exists, it's too late

clever wraith Oct 27, 2021, 9:36 AM

#

I mean after you created the reminders, did you checked they got inserted?

gritty wind Oct 27, 2021, 9:36 AM

#

No, it doesn't seem reasonable to check after all my reminders 😅

#

It's why I'm making these changes

vale ibex Oct 27, 2021, 9:37 AM

#

I propose we make use of the active flag

gritty wind Oct 27, 2021, 9:37 AM

#

So we can check later on

#

yeah see

clever wraith Oct 27, 2021, 9:37 AM

#

Because we do not check the return code when performing a POST on the site, so for all we know the site may be erroring and we are dropping that silently

gritty wind Oct 27, 2021, 9:37 AM

#

bot#1915

dusky shoreBOT Oct 27, 2021, 9:37 AM

#

GitHub

IssueOpen Make adding autoban filters easier.

gritty wind Oct 27, 2021, 9:37 AM

#

16 not 15

#

I'm testing it and then pushing

vale ibex Oct 27, 2021, 9:37 AM

#

cool

gritty wind Oct 27, 2021, 9:37 AM

#

Well, doesn't the api wrapper throw an error on bot if the api errors

#

Yeah, it does

#

I know as much because I'm currently erroring on my test bot

#

For unrelated reasons

clever wraith Oct 27, 2021, 9:38 AM

#

Don't you have to pass raise_for_error=True or something like that?

gritty wind Oct 27, 2021, 9:38 AM

#

Default is true

#

https://github.com/python-discord/bot/blob/5408b78bdf61e6109aaad940757497cae02eaab6/bot/api.py#L79

stable mountainBOT Oct 27, 2021, 9:39 AM

#

bot/api.py line 79

async def get(self, endpoint: str, *, raise_for_status: bool = True, **kwargs) -> dict:```

clever wraith Oct 27, 2021, 9:39 AM

#

Oh cool

gritty wind Oct 27, 2021, 9:40 AM

#

I suppose I haven't checked for that error

#

I only looked at logs for the delivery time

#

Maybe it's being swallowed up by sentry

#

Hmm no, the command error handler would handle this I think

#

And also I got confirmation receipts

clever wraith Oct 27, 2021, 9:41 AM

#

Maybe check the site sentry too?

gritty wind Oct 27, 2021, 9:45 AM

#

Nothing there

gritty wind Oct 27, 2021, 10:12 AM

#

Still haven't managed to test things because it took ages to get metricity running

#

I've updated my build script so it just takes care of itself now
https://paste.pythondiscord.com/udejejahim.less

clever wraith Oct 27, 2021, 10:13 AM

#

What PR is this for, out of curiosity?

gritty wind Oct 27, 2021, 10:13 AM

#

bot#1916

dusky shoreBOT Oct 27, 2021, 10:13 AM

#

GitHub

IssueOpen Missing Reminders

gritty wind Oct 27, 2021, 10:14 AM

#

It's not directly related, I just need to have metricity running to make reminders work

#

That's my local build script because building metricity is honestly a PITA

#

At least if I want to use my API's DB, which... why would I want anything else

#

yet still, it refuses to coperate

#

Why is metricity not adding my user to the DB

#

Misconfigured guild it would seem

clever wraith Oct 27, 2021, 10:17 AM

#

You need metricity for that, huh

gritty wind Oct 27, 2021, 10:18 AM

#

The API request has a user FK, the bot will try to set it to my actual user ID

#

It's why I wanted metricity in bot, you do actually need it if you're working with bot directly

#

I mean, the API is still complaining, but at least the user exists now

vale ibex Oct 27, 2021, 10:19 AM

#

Do you run everything in docker scale?

#

or some stuff locally

gritty wind Oct 27, 2021, 10:19 AM

#

Yeah

#

Well, just the bot locally

vale ibex Oct 27, 2021, 10:19 AM

#

you can set USE_METRICTY=true in your .env

#

and it will run metricity

gritty wind Oct 27, 2021, 10:20 AM

#

Right, I'm running metricity from a separate docker container, because I do mess around with metricity as well

#

It's why I have site in a separate compose too

#

It's not the "normal" workflow, so it's just me complaining. If it was, I would've gotten it fixed 🤡

vale ibex Oct 27, 2021, 10:21 AM

#

because you don't want to pull latest, but locally build?

gritty wind Oct 27, 2021, 10:21 AM

#

The build script does pull latest, just sometimes I want to make modifications to metricity directly, which means running it manually as well

#

Right now I don't have any changes

vale ibex Oct 27, 2021, 10:22 AM

#

you cna just change the image name to the name of the local image in the bot's compose

#

rather than messing with different compose files

gritty wind Oct 27, 2021, 10:22 AM

#

I see

#

Does the API use a different non-metricity user DB

#

If so, why, and WHYYYYYY

#

and why is my user not in it yet

#

Yeah, no data in that DB

#

Now how do I populaet it

#

sync?

vale ibex Oct 27, 2021, 10:23 AM

#

yea, there are two DBs pysite and metricity

#

Yea

#

!help sync

stable mountainBOT Oct 27, 2021, 10:23 AM

#

Command Help

!sync
Run synchronizations between the bot and site manually.

Subcommands:

!sync roles
Manually synchronise the guild's roles with the roles on the site.
!sync users
Manually synchronise the guild's users with the users on the site.

gritty wind Oct 27, 2021, 10:24 AM

#

Why do we have two user DBs

vale ibex Oct 27, 2021, 10:24 AM

#

vale ibex you cna just change the image name to the name of the local image in the bot's c...

IE in bot there is image: ghcr.io/python-discord/site:latest if I wanted to test local changes, I'd change this to site_site_1

#

since this is the name of my site image

vale ibex Oct 27, 2021, 10:24 AM

#

gritty wind Why do we have two user DBs

wdym?

gritty wind Oct 27, 2021, 10:25 AM

#

not DBs, tables bleh

vale ibex Oct 27, 2021, 10:25 AM

#

in metricity?

gritty wind Oct 27, 2021, 10:25 AM

#

Like we could definitely just have metricity and site write to the same DB when it comes to users

cold island Oct 27, 2021, 10:25 AM

#

One in metricity and one in site

vale ibex Oct 27, 2021, 10:25 AM

#

Ah right, yea

gritty wind Oct 27, 2021, 10:25 AM

#

Right, there is nothing stopping us from accessing one from both apps and halve the size of the DB(s)

vale ibex Oct 27, 2021, 10:26 AM

#

You can't do queries across dbs

gritty wind Oct 27, 2021, 10:26 AM

#

We can connect multiple DBs

#

Also funny thing

#

Sync passed and there are 0 users in table :)

vale ibex Oct 27, 2021, 10:27 AM

#

gritty wind We can connect multiple DBs

you can, but you can't join between two tables in different dbs

#

so if the users table was in pysite, metricity wouldn't have access to it sql side

gritty wind Oct 27, 2021, 10:27 AM

#

I mean like we can query either DB from either app

#

So two conns

cold island Oct 27, 2021, 10:27 AM

#

Wdym

gritty wind Oct 27, 2021, 10:27 AM

#

Joining user table on metricity, and on site

cold island Oct 27, 2021, 10:27 AM

#

Metricity doesn't query pysite

vale ibex Oct 27, 2021, 10:28 AM

#

what scale is suggesting is that we only have 1 users table right?

gritty wind Oct 27, 2021, 10:28 AM

#

Right, I know, but there is nothing stopping us from making it do that

cold island Oct 27, 2021, 10:28 AM

#

There is

gritty wind Oct 27, 2021, 10:28 AM

#

It's a table with > like a million entries at this point 🤡

cold island Oct 27, 2021, 10:28 AM

#

Metricity isn't used just here

vale ibex Oct 27, 2021, 10:28 AM

#

If the users table was in pysite, you couldn't run a query for all metricity messages from a user sql side

#

you'd need to pull all messages, then all users from the two db and then do the filter in python

gritty wind Oct 27, 2021, 10:29 AM

#

METRICITY_URI
USERS_URI

Set them to the same thing if you want to use it for your own purposes lol

gritty wind Oct 27, 2021, 10:29 AM

#

vale ibex If the users table was in pysite, you couldn't run a query for all metricity mes...

Fair enough on that ig

gritty wind Oct 27, 2021, 10:29 AM

#

gritty wind Sync passed and there are 0 users in table \:)

Any ideas for this

vale ibex Oct 27, 2021, 10:29 AM

#

That's just one example, but yea there's more use cases that would block it

vale ibex Oct 27, 2021, 10:30 AM

#

gritty wind Any ideas for this

is your metricity bot running?

cold island Oct 27, 2021, 10:30 AM

#

gritty wind Any ideas for this

The URI is misconfigured maybe

gritty wind Oct 27, 2021, 10:30 AM

#

It is, but the metricity DB is unrelated apaprently

#

It's the site DB

#

Metricity one is populated fine

cold island Oct 27, 2021, 10:30 AM

#

oh

gritty wind Oct 27, 2021, 10:30 AM

#

Site is connected to postgres

vale ibex Oct 27, 2021, 10:30 AM

#

oh, site api isn't populated on sync

#

that's populated when users get infracted iirc

cold island Oct 27, 2021, 10:31 AM

#

Hmm that doesn't sound right

vale ibex Oct 27, 2021, 10:31 AM

#

oh wait now, there's two syncers

#

the sync cog does talk to pysite

#

metricity has it's own sync

gritty wind Oct 27, 2021, 10:31 AM

#

I ran !sync roles and !sync users after

#

It worked after syncing users again

#

And finally, reminders are working 🤡

#

When deleting reminders (!remind delete) do we want to keep them in DB but deactivate, or do we want to remove them

cold island Oct 27, 2021, 10:45 AM

#

gritty wind When deleting reminders (!remind delete) do we want to keep them in DB but deact...

I don't think there's a reason to keep them

dim pelican Oct 27, 2021, 10:57 AM

#

sir-lancebot#842 is ready for testing and reviews

dusky shoreBOT Oct 27, 2021, 10:57 AM

#

GitHub

PROpen Add color command

dim pelican Oct 27, 2021, 11:09 AM

#

Yeah, I was using ctx.invoked_subcommand instead of ctx.invoked_with trying to get the "mode" that it used

#

Now it shows in the embed what the user called it with

dim pelican Oct 27, 2021, 11:47 AM

#

#

#

trail pilot Oct 27, 2021, 11:51 AM

#

dim pelican

This looks really cool! One thing - could you capitalize Rgb to RGB and maybe add some sort of emphasization for the color name, like RGB information for Storm Dust or RGB information for Storm Dust

dim pelican Oct 27, 2021, 11:52 AM

#

Sure thing, won't be able to test until the end of the day though (unless someone has sir-lance set up and can use gh pr checkout 842)

austere hornet Oct 27, 2021, 11:54 AM

#

trail pilot This looks really cool! One thing - could you capitalize Rgb to RGB and maybe ad...

Yeah, I like that idea. But anyhow this is really cool @dim pelican !

dim pelican Oct 27, 2021, 11:55 AM

#

Its been a wild ride for sure. My first try was a mess lol

austere hornet Oct 27, 2021, 11:55 AM

#

dim pelican Sure thing, won't be able to test until the end of the day though (unless someon...

I do have sir-lancebot set up but I'm not at home lol

austere hornet Oct 27, 2021, 11:56 AM

#

dim pelican Its been a wild ride for sure. My first try was a mess lol

That's pretty much always the case. First PR can be intimidating, even for me since I'm working on my first PR too!

#

I've messed up a bunch too so

#

We're all in this together lol

dim pelican Oct 27, 2021, 11:58 AM

#

Oh the best part is that the color command will be like my 3rd (?) contrib to sir-lance

vocal prairie Oct 27, 2021, 11:59 AM

#

dim pelican

Out of curiosity, why do you have the NAME in a code block? I feel like since it's just plain text, it doesn't need to be that way.

#

But if it looks better, of course

dim pelican Oct 27, 2021, 11:59 AM

#

vocal prairie Out of curiosity, why do you have the NAME in a code block? I feel like since it...

Cause we make a dictionary mapping of the field names and values:

        for colour_space, value in colour_conversions.items():
            colour_embed.add_field(
                name=colour_space.upper(),
                value=f"`{value}`",
                inline=True
            )

#

I could add an if to exclude the name value

#

Now I'm trying to remember what I've done for sir-lance...
Realpython, Teapot, WTF Python and I guess Color now

short snow Oct 27, 2021, 12:30 PM

#

go to Pull requests tab on github

#

and seee

#

https://github.com/pulls?q=is%3Apr+is%3Aopen+author%3Abrad90four+archived%3Afalse+sort%3Aupdated-desc+

dim pelican Oct 27, 2021, 12:33 PM

#

Yeah that's where I remembered Teapot lol. Just gotta set is:closed author:brad90four

short snow Oct 27, 2021, 12:33 PM

#

I have got 149 total PRs 👀 - though some are test PRs

clever wraith Oct 27, 2021, 12:36 PM

#

Heh, 185

short snow Oct 27, 2021, 12:37 PM

#

Ok someone has 300, guess

clever wraith Oct 27, 2021, 12:37 PM

#

My guess would be Sebastiaan

short snow Oct 27, 2021, 12:38 PM

#

I didn't see his, it was joe

vale ibex Oct 27, 2021, 12:40 PM

#

my public ones are at 234

reef tinsel Oct 27, 2021, 12:43 PM

#

short snow I have got 149 total PRs 👀 - though some are test PRs

0 for me lol - but going to go up in the enxt few hours :-)