vale ibex Oct 14, 2021, 4:26 PM

#

rather than waiting to commit

gritty wind Oct 14, 2021, 4:28 PM

#

On phone but

#

It seems like a few of those liens are going over the line limit

fallen patrol Oct 14, 2021, 4:29 PM

#

Heads up don't merge bot#1872 until I review 😂
King Arthur had three pull requests for isort stuff

green oriole Oct 14, 2021, 4:30 PM

#

gritty wind It seems like a few of those liens are going over the line limit

Shouldn't be, it passed linting locally

gritty wind Oct 14, 2021, 4:30 PM

#

Neat

green oriole Oct 14, 2021, 4:30 PM

#

Bear in mind we use a 120 chars limit on the bot

gritty wind Oct 14, 2021, 4:30 PM

#

Does anything handle unused imports

fallen patrol Oct 14, 2021, 4:30 PM

#

gritty wind It seems like a few of those liens are going over the line limit

Yes, there is a very particular configuration

gritty wind Oct 14, 2021, 4:30 PM

#

Handle/fail on

green oriole Oct 14, 2021, 4:31 PM

#

So here I'd rather not warn inside the IDE, so you don't try to fix them manually

green oriole Oct 14, 2021, 4:31 PM

#

gritty wind Does anything handle unused imports

Yes, flake8-tidy-import

gritty wind Oct 14, 2021, 4:32 PM

#

green oriole So here I'd rather not warn inside the IDE, so you don't try to fix them manuall...

Hmm that’d probably be annoying

#

go to commit, wait half a minute, what’s that? Failed because import order

patent pivot Oct 14, 2021, 4:32 PM

#

(are we going to use pre-commit forever)

#

given that we're not using it on API

gritty wind Oct 14, 2021, 4:32 PM

#

With the warning it’s clear before you have to commit

green oriole Oct 14, 2021, 4:34 PM

#

gritty wind > go to commit, wait half a minute, what’s that? Failed because import order

The precommit hook will fix it for you

#

So like

#

You just commit and that's it

gritty wind Oct 14, 2021, 4:34 PM

#

But then you have to commit twice

#

It doesn’t fix stuff for me

#

If pre-commit fails, I have to run it twice

green oriole Oct 14, 2021, 4:34 PM

#

Depending on how you stage you have to run twice, yes

gritty wind Oct 14, 2021, 4:34 PM

#

Even if I don’t change anything

green oriole Oct 14, 2021, 4:35 PM

#

patent pivot (are we going to use pre-commit forever)

What are the alternatives? I think it does its job currently

gritty wind Oct 14, 2021, 4:35 PM

#

It does it for every single commit for me, even if I have everything staged… I accidentally checked out in CRLF

green oriole Oct 14, 2021, 4:35 PM

#

Would you still prefer to manually sort your imports rather than running a command twice?

gritty wind Oct 14, 2021, 4:35 PM

#

I mean

#

You don’t have to manually sort

#

You just manually run super

thorny obsidian Oct 14, 2021, 4:36 PM

#

(I would, running a command twice is unintuitive for me)

gritty wind Oct 14, 2021, 4:36 PM

#

Isort*

green oriole Oct 14, 2021, 4:36 PM

#

Well, let's keep the plugin then I guess?

gritty wind Oct 14, 2021, 4:36 PM

#

This isn’t even a problem for me, pycharm sorts everything for me before I even get to pre-commit

#

I’m fine with keeping it yeah, I just want to keep the flake warning as well

patent pivot Oct 14, 2021, 4:37 PM

#

green oriole What are the alternatives? I think it does its job currently

the alternative is nothing, I'm just saying that we removed pre-commit from api because we didn't see a huge use for it

green oriole Oct 14, 2021, 4:37 PM

#

Fair enough, but then we have a GPL dev dep

patent pivot Oct 14, 2021, 4:37 PM

#

i would also like to have the flake waring

#

that's fine

gritty wind Oct 14, 2021, 4:37 PM

#

Tbh pre-commit would be a much better tool if it was configured client side only

patent pivot Oct 14, 2021, 4:38 PM

#

GPL dev deps are fine, it's about redistribution, we use gcc in some capacity in a bunch of our images

green oriole Oct 14, 2021, 4:38 PM

#

patent pivot the alternative is nothing, I'm just saying that we removed pre-commit from api ...

Eh, honestly it is a decent way to prevent failing linting. If one doesn't want to use it, sure, just don't install it? I personally really like it, I always forget to manually lint

gritty wind Oct 14, 2021, 4:38 PM

#

That way everyone can follow their preferences and needs

green oriole Oct 14, 2021, 4:38 PM

#

I mean, you can do that

#

Just make your own

gritty wind Oct 14, 2021, 4:38 PM

#

You mean my own bash script?

green oriole Oct 14, 2021, 4:39 PM

#

Yes, and hook up into whatever precommit system you want

gritty wind Oct 14, 2021, 4:39 PM

#

Precommit integrates nicely with venvs and version management, it’s still more convenient than scripts

#

Also that other thing I told you way back when 🤡

fallen patrol Oct 14, 2021, 4:39 PM

#

gritty wind You mean my own bash script?

Or even precommit if it's not used by the repo

green oriole Oct 14, 2021, 4:40 PM

#

I am too much of a 🤡 to remember what you said back then

gritty wind Oct 14, 2021, 4:40 PM

#

I don’t want to learn bash or w/e

green oriole Oct 14, 2021, 4:40 PM

#

lol I mean you can make a python precommit hook

#

Like, actually pure python

fallen patrol Oct 14, 2021, 4:41 PM

#

If you want your own hooks on a repo which doesn't use pre commit I can help you set it up

#

Yeah, you can make precommit run anything

green oriole Oct 14, 2021, 4:41 PM

#

I believe there is also a way to alter the script precommit creates to use your own config file

fallen patrol Oct 14, 2021, 4:41 PM

#

Probably that too

green oriole Oct 14, 2021, 4:41 PM

#

So you still have the pyprecommit framework but your own config

fallen patrol Oct 14, 2021, 4:41 PM

#

Ye

#

Pre commit is super awesome

#

I've written my own scripts to check things and they're great :)

green oriole Oct 14, 2021, 4:44 PM

#

I knew the way we cache dependencies would bite us in the arse at some point

fallen patrol Oct 14, 2021, 4:44 PM

#

Wdym

molten perch Oct 14, 2021, 4:44 PM

#

Yeah, actually why don't we use pre-commit on the API? I just saw that it was removed, but no reason whatsoever.

green oriole Oct 14, 2021, 4:45 PM

#

Because I cannot install dev packages then normal packages

#

Hmm

#

Or maybe I can (?)

fallen patrol Oct 14, 2021, 4:46 PM

#

@green oriole do you use black?

green oriole Oct 14, 2021, 4:46 PM

#

Yeah we only need to check licenses when the cache key changes

#

Cool

#

No I don't use black

fallen patrol Oct 14, 2021, 4:46 PM

#

ah

green oriole Oct 14, 2021, 4:46 PM

#

I am a control freak remember

fallen patrol Oct 14, 2021, 4:46 PM

#

that's why you used an isort configuration that hates black /hj

green oriole Oct 14, 2021, 4:48 PM

#

I mean, who cares, we don't use black

fallen patrol Oct 14, 2021, 4:49 PM

#

true, i suppose

#

what you configured does also hate git diffs tho

gritty wind Oct 14, 2021, 4:51 PM

#

Who checks git diffs on these imports

fallen patrol Oct 14, 2021, 4:51 PM

#

this is the biggest setting change that I would add TM

#

gritty wind Oct 14, 2021, 4:51 PM

#

Why is that just not default

fallen patrol Oct 14, 2021, 4:51 PM

#

not sure

gritty wind Oct 14, 2021, 4:52 PM

#

I mean, it’ll still fail later on because of flake but like

fallen patrol Oct 14, 2021, 4:52 PM

#

i mean, it could be turned off for pre-commit

#

but like

#

for general usage, sorting them with a file that already has errors could cause more :P

gritty wind Oct 14, 2021, 4:53 PM

#

I mean, that sounds like a pretty niche case unless you have isort on save

#

Which again seems pretty useless

green oriole Oct 14, 2021, 4:54 PM

#

fallen patrol what you configured does also hate git diffs tho

How does it hate diffs

#

It generated a 700 lines diff at first

fallen patrol Oct 14, 2021, 4:54 PM

#

no trailing commas 🥲

green oriole Oct 14, 2021, 4:54 PM

#

Oh, maybe we should add those

#

Well I guess it is very niche here

gritty wind Oct 14, 2021, 4:55 PM

#

But then you break compatibility with my ide and I actually have to use it 🥲

fallen patrol Oct 14, 2021, 4:57 PM

#

review filed

#

And I cannot look at replies rn

#

Because as soon as I did so, WINDOWS UPDATE

green oriole Oct 14, 2021, 5:00 PM

#

So do we want trailing commas or not? I know this is in our code style, but it isn't something I personally like, and since isort will try to fill a new line before moving to the next one it is probably something that will only happen every 36th day of the month, sooo

gritty wind Oct 14, 2021, 5:05 PM

#

I’m biased, but no

thorny obsidian Oct 14, 2021, 5:33 PM

#

@static canyon @green oriole
I'm not gonna add periods to the end of the points in where to start because that'll offend my sensibilities

green oriole Oct 14, 2021, 5:33 PM

#

Hahaha

#

Lgtm

static canyon Oct 14, 2021, 5:48 PM

#

thorny obsidian <@!442244135840382978> <@!407110650217627658> I'm not gonna add periods to the ...

Looks good 👍

#

Do we maybe want to mention about reviewing PRs?

#

That's still participating to OSS and is just as important imo so think it fits the tag

green oriole Oct 14, 2021, 5:53 PM

#

I don't think a first time contributor should be reviewing in general

vale ibex Oct 14, 2021, 5:53 PM

#

It's also in the contrib guide

#

green oriole Oct 14, 2021, 5:54 PM

#

And in #dev-announcements :P

static canyon Oct 14, 2021, 6:00 PM

#

green oriole I don't think a first time contributor should be reviewing in general

True

thorny obsidian Oct 14, 2021, 6:09 PM

#

bot#1833 tag speedrun time?

dusky shoreBOT Oct 14, 2021, 6:09 PM

#

GitHub

PROpen !contribute tag

celest charm Oct 14, 2021, 6:29 PM

#

@clever wraith yep it's still an issue

#

[nsfw]||python.com|| is the domain we filter

#

yeah, we filter python.com but the filter also catches everything ending with it

thorny obsidian Oct 14, 2021, 6:30 PM

#

(... why would you intentionally trigger a known filter?)

celest charm Oct 14, 2021, 6:31 PM

#

sorry, I wasn't sure it was still an issue

slim widget Oct 14, 2021, 6:31 PM

#

FYI this is not the Python website (and is NSFW). (In case you didn't know.)

celest charm Oct 14, 2021, 6:31 PM

#

just to make sure

thorny obsidian Oct 14, 2021, 6:31 PM

#

celest charm sorry, I wasn't sure it was still an issue

no, not you doublevcodes

celest charm Oct 14, 2021, 6:31 PM

#

ah

#

lmao

thorny obsidian Oct 14, 2021, 6:32 PM

#

It does, it pings the mods

celest charm Oct 14, 2021, 6:33 PM

#

I absolutely agree, @azure loom

thorny obsidian Oct 14, 2021, 6:36 PM

#

what other tags can I work on now...

molten perch Oct 14, 2021, 6:37 PM

#

Hey! Could someone take a look at api#22? The issue hasn't been approved.

dusky shoreBOT Oct 14, 2021, 6:37 PM

#

GitHub

IssueOpen Migrate reminders endpoint from the site API

green oriole Oct 14, 2021, 6:40 PM

#

celest charm I absolutely agree, <@!898273292979413052>

I really wonder who would name their alt "le alt"

vocal wolf Oct 14, 2021, 7:58 PM

#

@molten perch AoC thingy merged.

molten perch Oct 14, 2021, 7:58 PM

#

🎉 Thank you! 😄

brisk brook Oct 14, 2021, 8:14 PM

#

green oriole I don't think a first time contributor should be reviewing in general

I disagree, I think we should encouraging reviews. Anybody can review and it truly helps

trail pilot Oct 14, 2021, 8:14 PM

#

Also, I think a first time contributor =/= someone who doesn't know much about code and its quality.

Most first time contributors have adequate experience with Python and even if they can't attest to style as much, they can definitely review on logic, etc.

static canyon Oct 14, 2021, 8:16 PM

#

I think the issue is more that they won't be familiar with how our codebase works

celest charm Oct 14, 2021, 8:17 PM

#

I have no idea how the codebase works and I still do occasional reviews somehow 🤷

trail pilot Oct 14, 2021, 8:18 PM

#

celest charm I have no idea how the codebase works and I still do occasional reviews somehow ...

Wait, what's your GH name? decorator-factory?

dim pelican Oct 14, 2021, 8:18 PM

#

Is there any harm with a "bad" review from someone that is just getting started though? Seems like a good place to get started really

celest charm Oct 14, 2021, 8:19 PM

#

trail pilot Wait, what's your GH name? decorator-factory?

yes

austere hornet Oct 14, 2021, 8:19 PM

#

trail pilot Also, I think a first time contributor =/= someone who doesn't know much about c...

Is that a not equal sign?

trail pilot Oct 14, 2021, 8:19 PM

#

austere hornet Is that a not equal sign?

Yep

trail pilot Oct 14, 2021, 8:19 PM

#

dim pelican Is there any harm with a "bad" review from someone that is just getting started ...

True! Everyone starts somewhere

#

And people learn from their mistakes

austere hornet Oct 14, 2021, 8:19 PM

#

trail pilot Yep

K just checking

summer garden Oct 14, 2021, 8:20 PM

#

If they have questions about the code, doesn't that mean that maybe the code could be more clear or could use some comments?

summer garden Oct 14, 2021, 8:21 PM

#

dim pelican Is there any harm with a "bad" review from someone that is just getting started ...

I agree. I could argue that you can gain something from even a "bad" review

austere hornet Oct 14, 2021, 8:22 PM

#

brisk brook I disagree, I think we should encouraging reviews. Anybody can review and it tru...

I agree with this. As Fronto said, even if a first time contributor makes a review and makes a mistake, they will learn from it hopefully and eventually will master code reviews 😄

#

So I'm in favor of having first time contributors leave reviews

austere hornet Oct 14, 2021, 8:23 PM

#

summer garden If they have questions about the code, doesn't that mean that maybe the code cou...

I'm not sure, depends on the person that's reviewing I think

summer garden Oct 14, 2021, 8:24 PM

#

no harm in adding to the conversation innit?

brisk brook Oct 14, 2021, 8:24 PM

#

static canyon I think the issue is more that they won't be familiar with how our codebase work...

That's okay, in-general you don't need to.

Most changes are new fun commands so as you're looking over the diff you get a complete picture.

summer garden Oct 14, 2021, 8:24 PM

#

austere hornet I'm not sure, depends on the person that's reviewing I think

Yes I know what you mean, I'm not sure I explained myself well

brisk brook Oct 14, 2021, 8:25 PM

#

Ngl I still can't find my way around the bot

static canyon Oct 14, 2021, 8:25 PM

#

dim pelican Is there any harm with a "bad" review from someone that is just getting started ...

I mean I guess for non-staff it's not a massive issue since the reviews don't count for much, but I personally would prefer no review over a bad one

dim pelican Oct 14, 2021, 8:27 PM

#

Yeah I can get that, having a bad review could derail the overall PR process.

summer garden Oct 14, 2021, 8:27 PM

#

dim pelican Yeah I can get that, having a bad review could derail the overall PR process.

How come?

#

In terms of chaos and confusion?

thorny obsidian Oct 14, 2021, 8:28 PM

#

vocal wolf <@!263957159807549450> AoC thingy merged.

WHOOOOOO

static canyon Oct 14, 2021, 8:28 PM

#

brisk brook That's okay, in-general you don't need to. Most changes are new fun commands so...

They may not be familiar with style guide etc. I guess, but then that would likely be picked up by someone else who is familiar (and PRs need a core-dev approval anyway so they should notice)

dim pelican Oct 14, 2021, 8:28 PM

#

Well let's say I have a PR open and I need some reviews. If there is a "bad" review, it could spawn a chain of conversation that would be more about the errors in the review, rather than focusing on the content of the PR

vocal wolf Oct 14, 2021, 8:29 PM

#

thorny obsidian WHOOOOOO

Yeah BOIIIIIIIIIIIIIIIIIIIIII

thorny obsidian Oct 14, 2021, 8:29 PM

#

Also, the tag is just an entry point. I don't think it needs to cover all possible ways to contribute. More a way to get people here

dim pelican Oct 14, 2021, 8:29 PM

#

Which could be a great learning experience for the "new" person leaving the review, but would not be super productive for the person with the open PR

static canyon Oct 14, 2021, 8:30 PM

#

Speaking of reviews, can I please get a second one on bot#1860? I'd like to get it merged before I work on bot#1864

(CC @brisk brook if you're able to 👉 👈)

dusky shoreBOT Oct 14, 2021, 8:30 PM

#

GitHub

PROpen Attempt infraction before DMing
IssueOpen Add DM Sent field to infraction details

dim pelican Oct 14, 2021, 8:30 PM

#

I'm still in favor of someone trying to get involved with the whole ecosystem with reviewing though

brisk brook Oct 14, 2021, 8:31 PM

#

static canyon I mean I guess for non-staff it's not a massive issue since the reviews don't co...

Nah, I get what you mean if this is someone who comes along and tries to nudge the PR in different ways.

But even someone who opens the PR, reads the code and then asks some questions about different things helps reaffirm the author's beliefs in how things were done.

vocal wolf Oct 14, 2021, 8:33 PM

#

why does github light theme look so bad

sleek steppe Oct 14, 2021, 8:34 PM

#

I personally like the light mode lol

vocal wolf Oct 14, 2021, 8:34 PM

#

the labels just don't look right

#

like they're a solid color

static canyon Oct 14, 2021, 8:35 PM

#

brisk brook Nah, I get what you mean if this is someone who comes along and tries to nudge t...

My worry here is that the beliefs the user instils in the PR author go against our general dev-flow / style guide (e.g. recommending inline trailing commas etc.)

#

It's then a pain to have to "correct" them

brisk brook Oct 14, 2021, 8:38 PM

#

I don't see that painful, it's a learning experience for everyone involved

static canyon Oct 14, 2021, 8:41 PM

#

Can be confusing for the PR author though

#

But I'm not completely against this

clever wraith Oct 14, 2021, 8:47 PM

#

celest charm [nsfw]||`python.com`|| is the domain we filter

Christ, I can see why

vale ibex Oct 14, 2021, 8:47 PM

#

oh lol sorry @gritty wind clicked disable automerge instead of merge in main

#

so now I get the merge credit instead 😅

celest charm Oct 14, 2021, 8:51 PM

#

clever wraith Christ, I can see why

If my software career doesn't work out I have a backup plan 😉

clever wraith Oct 14, 2021, 8:56 PM

#

I didn't see a \s lemon_eyes lemon_grimace

clever wraith Oct 14, 2021, 8:57 PM

#

vale ibex so now I get the merge credit instead 😅

Your master plan paid off

vocal wolf Oct 14, 2021, 8:57 PM

#

https://github.com/python-discord/bot/pull/1602 @sleek steppe what's the status of this PR?

thorny obsidian Oct 14, 2021, 8:58 PM

#

!contribute

stable mountainBOT Oct 14, 2021, 8:58 PM

#

Contribute to Python Discord's Open Source Projects
Looking to contribute to Open Source Projects for the first time? Want to add a feature or fix a bug on the bots on this server? We have on-going projects that people can contribute to, even if you've never contributed to open source before!

Projects to Contribute to
• Sir Lancebot - our fun, beginner-friendly bot
• Python - our utility & moderation bot
• Site - resources, guides, and more

Where to start

Read our contributing guidelines
Chat with us in #dev-contrib if you're ready to jump in or have any questions
Open an issue or ask to be assigned to an issue to work on

thorny obsidian Oct 14, 2021, 8:58 PM

#

yeaaaaaah buddy

vocal wolf Oct 14, 2021, 8:58 PM

#

We went from 26 to 21 PRs in the span of an hour

#

https://github.com/python-discord/bot/pull/1663

GitHub

Add tag groups and in file metadata by Numerlor · Pull Request #166...

Introduces tag groups described in #1545.
When matching a tag with a group, the group is matched with no minimum amount of chars (unlike a tag that has to have 3 chars of its name) to allow a short...

#

This PR has been in the works for a while. If anyone's available for reviews, please do so.

vale ibex Oct 14, 2021, 9:00 PM

#

Hey @static canyon are you around?

#

want to merge bot#1831 but I want to squash the last commit in it

dusky shoreBOT Oct 14, 2021, 9:00 PM

#

GitHub

PROpen Add CustomLogger to prevent IDE lint warnings when calling log.trace.

static canyon Oct 14, 2021, 9:03 PM

#

vale ibex want to merge bot#1831 but I want to squash the last commit in it

Yep, gimme a few mins

vale ibex Oct 14, 2021, 9:03 PM

#

cool cool

#

I can do it if you're not around

static canyon Oct 14, 2021, 9:03 PM

#

I can do 👍

vale ibex Oct 14, 2021, 9:03 PM

#

👌

static canyon Oct 14, 2021, 9:07 PM

#

I'll also merge main into it in case there's any new getLogger that have been added

vale ibex Oct 14, 2021, 9:07 PM

#

Might as well rebase onto main to avoid another merge commit

static canyon Oct 14, 2021, 9:08 PM

#

Already done it but can squash

vale ibex Oct 14, 2021, 9:08 PM

#

Ah no worries

#

you can't squash now since you've got public commits in there

static canyon Oct 14, 2021, 9:10 PM

#

ah right

#

Well then I messed up lol

thorny obsidian Oct 14, 2021, 9:10 PM

#

vocal wolf We went from 26 to 21 PRs in the span of an hour

the magic of our triage lead and friends✨

static canyon Oct 14, 2021, 9:11 PM

#

I can still do I think

#

Yeah erm I might've fucked up @vale ibex

vale ibex Oct 14, 2021, 9:16 PM

#

uhhhh

#

ah yea, I see now

#

1 sec

#

What was the changes you made?

#

just squash the last commit?

vocal wolf Oct 14, 2021, 9:17 PM

#

uh oh

static canyon Oct 14, 2021, 9:17 PM

#

Yeah, I think so

vocal wolf Oct 14, 2021, 9:17 PM

#

reflog time?

vale ibex Oct 14, 2021, 9:18 PM

#

Which commit did you want to sqush it into?

#

I've got a copy locally so I can just fix my end and forcepush

static canyon Oct 14, 2021, 9:18 PM

#

"Fix Newlines"
"Address Review"

becoming

"Fix newlines and address review"

#

CC @vale ibex

vale ibex Oct 14, 2021, 9:19 PM

#

kk that should be it

#

if you git pull -f locally it should be fine

static canyon Oct 14, 2021, 9:19 PM

#

Perfect, thanks lemon_sweat

vale ibex Oct 14, 2021, 9:20 PM

#

no worries 😄

static canyon Oct 14, 2021, 9:20 PM

#

I believe that's the squash you were after

vale ibex Oct 14, 2021, 9:20 PM

#

Just fyi I've been down this path before, which is why I never merge main until the very last second lol

#

always prefer to rebase onto main

static canyon Oct 14, 2021, 9:20 PM

#

Yeah fair enough lol

static canyon Oct 14, 2021, 9:20 PM

#

vale ibex always prefer to rebase onto main

How do I do that?

vale ibex Oct 14, 2021, 9:20 PM

#

while you have main checkedout git pull

#

to make sure your local main is up to date

#

then checkout your branch and git rebase main

static canyon Oct 14, 2021, 9:21 PM

#

Right, thanks 👍

#

Rebasing onto Main

Checkout main branch
git pull to ensure it's upto date
Checkout branch you're working on
git rebase main to rebase onto main

static canyon Oct 14, 2021, 9:22 PM

#

static canyon __Rebasing onto Main__ - Checkout `main` branch - `git pull` to ensure it's upt...

.bm rebasing onto main

vale ibex Oct 14, 2021, 9:24 PM

#

Did you say you wanted to add the rest now too? if not I can merge this pr

static canyon Oct 14, 2021, 9:25 PM

#

What do you mean by the rest?

vale ibex Oct 14, 2021, 9:25 PM

#

static canyon I'll also merge main into it in case there's any new `getLogger` that have been ...

this

static canyon Oct 14, 2021, 9:25 PM

#

There wasn't any new getLoggers

#

Or at least I didn't see any

vale ibex Oct 14, 2021, 9:25 PM

#

ah nice

#

Ah, it's ignoring my approval since I forcepushed those commits

#

@vocal wolf could you +1 on my behalf?

vocal wolf Oct 14, 2021, 9:26 PM

#

ye

vale ibex Oct 14, 2021, 9:26 PM

#

bot#1831

dusky shoreBOT Oct 14, 2021, 9:26 PM

#

GitHub

PROpen Add CustomLogger to prevent IDE lint warnings when calling log.trace.

static canyon Oct 14, 2021, 9:27 PM

#

Tyty

#

fyi @vale ibex sir-lancebot#889 is just a one-line config change if you could approve that too pls 👉 👈

dusky shoreBOT Oct 14, 2021, 9:30 PM

#

GitHub

PROpen Change pascal's triangle image

static canyon Oct 14, 2021, 9:31 PM

#

It has 2 approvals but one is non-staff

#

Ah, @vocal prairie beat you to it, thanks 😄

vocal prairie Oct 14, 2021, 9:33 PM

#

Huh, why isn't it merging. Auto merge is on and all checks have passed.

static canyon Oct 14, 2021, 9:34 PM

#

🤔

vocal prairie Oct 14, 2021, 9:34 PM

#

Oh, maybe it's the "Update Branch" thing?

static canyon Oct 14, 2021, 9:34 PM

#

It shouldn't be but I can try I guess

vocal prairie Oct 14, 2021, 9:35 PM

#

Hmm, looks like it was

#

Weird

static canyon Oct 14, 2021, 9:35 PM

#

Hmm yeah

#

I guess that makes sense (ensures there's no conflicts)

vocal wolf Oct 14, 2021, 9:35 PM

#

It is because of the update branch button.

static canyon Oct 14, 2021, 9:36 PM

#

mhm, it got merged when I pressed 👍

#

Well that's 5 of my PRs merged all at once :p

timid sentinel Oct 14, 2021, 9:41 PM

#

vocal wolf https://github.com/python-discord/bot/pull/1663

!remind 17h This if it hasn't happened already

stable mountainBOT Oct 14, 2021, 9:41 PM

#

Okay.

Your reminder will arrive on <t:1634308879:F>!

timid sentinel Oct 14, 2021, 9:47 PM

#

Will also try and find some time to take a look at bot#1721 and bot#1815, not sure if there might be some conflicts between those

dusky shoreBOT Oct 14, 2021, 9:47 PM

#

GitHub

PROpen Migrate to Discord 2.0a0
PROpen Refactor time utilities

timid sentinel Oct 14, 2021, 9:47 PM

#

I've been avoiding the time utilities one because timezones are hard lemon_sweat

thorny obsidian Oct 14, 2021, 9:50 PM

#

you should totally look at the discord 2.0 migration >_> we already have 2 PRs waiting on it

vale ibex Oct 14, 2021, 9:52 PM

#

not my fault

#

kek

trail pilot Oct 14, 2021, 9:56 PM

#

Oh also a possible feature for sir-lancebot that's waiting for thread support for Python

#

(Hangman mulitplayer in threads)

#

I feel like quiz should be in threads too

timid sentinel Oct 14, 2021, 9:56 PM

#

i'll probably just take a look at the code there and try out a few core bot features, and leave the rest of the testing to prod py_guido

trail pilot Oct 14, 2021, 9:56 PM

#

It takes over the entire channel

vale ibex Oct 14, 2021, 9:58 PM

#

Looking at the d.py 2.0 PR, it seems we've gone for removing the tzinfo from all of the aware datetimes

#

instead I think we should use arrow.utcnow() to get the current time

#

since that can be compared with aware timestamps

#

Anyway I've been testing and looking around for a bit the past few day, and those two missing tzs in my request are all I've found

thorny obsidian Oct 14, 2021, 10:23 PM

#

has a functionality test of the 2.0 migration happened yet?

vale ibex Oct 14, 2021, 10:23 PM

#

That's what I was referring to, I've done a functinoality test of sorts

#

not sure if that's what you were referring to

thorny obsidian Oct 14, 2021, 10:24 PM

#

Just like, spinning it up and running through all the major commands and scenarios

vale ibex Oct 14, 2021, 10:24 PM

#

yea

thorny obsidian Oct 14, 2021, 10:24 PM

#

which stuff have you tested specifically?

vale ibex Oct 14, 2021, 10:27 PM

#

filtering, infractions, otn, help channels, defcon, voice gate, slowmode, silence, modlog, mod pings, clean, reminders, snekbox, talentpool, syncers

thorny obsidian Oct 14, 2021, 10:28 PM

#

okay cool cool

austere hornet Oct 14, 2021, 10:45 PM

#

stable mountain

Nice work @thorny obsidian !!

stable mountainBOT Oct 14, 2021, 11:41 PM

#

It has arrived!

Here's your reminder: that and that
[Jump back to when you created the reminder](#dev-contrib message)

clever wraith Oct 15, 2021, 2:12 AM

#

.bm 897962493920567316

dusky shoreBOT Oct 15, 2021, 2:12 AM

#

That was a mistake.

Your input was invalid: You must either provide a valid message to bookmark, or reply to one.

The lookup strategy for a message is as follows (in order):

Lookup by '{channel ID}-{message ID}' (retrieved by shift-clicking on 'Copy ID')
Lookup by message ID (the message must have been sent after the bot last started)
Lookup by message URL

Usage:```
.bookmark [target_message] [title=Bookmark]

clever wraith Oct 15, 2021, 2:12 AM

#

.bm 897962493920567316 Question format

dusky shoreBOT Oct 15, 2021, 2:12 AM

#

That was a mistake.

Your input was invalid: You must either provide a valid message to bookmark, or reply to one.

The lookup strategy for a message is as follows (in order):

Lookup by '{channel ID}-{message ID}' (retrieved by shift-clicking on 'Copy ID')
Lookup by message ID (the message must have been sent after the bot last started)
Lookup by message URL

Usage:```
.bookmark [target_message] [title=Bookmark]

clever wraith Oct 15, 2021, 2:12 AM

#

shoot

#

.bm #dev-contrib message trivianight format

vocal prairie Oct 15, 2021, 2:13 AM

#

clever wraith .bm 897962493920567316 Question format

if it's not in this channel, you need to do channelid-messageid

clever wraith Oct 15, 2021, 2:14 AM

#

the bot restarted since then

#

so it was being stinky

#

cc @trail pilot

trail pilot Oct 15, 2021, 2:23 AM

#

clever wraith cc <@!584817706646110333>

IT got deleted

clever wraith Oct 15, 2021, 2:23 AM

#

lmao

cold moon Oct 15, 2021, 4:40 AM

#

Idea - could we make @dusky shore react to messages using lemon_halloween when someone write "lemon" during halloween? We already have some much reactions, but currently they are default emojis.

short snow Oct 15, 2021, 4:58 AM

#

How about allowing several "mods" for the pfpmod? Like first apply 8bitify then spookyavatar?

green oriole Oct 15, 2021, 5:04 AM

#

brisk brook I disagree, I think we should encouraging reviews. Anybody can review and it tru...

I do think a contributor should do at least one code review before reviewing, but we are in dire needs of reviews, I think we can agree on that

vocal prairie Oct 15, 2021, 5:20 AM

#

one code review before reviewing
Can you clarify what you mean by that?

brisk brook Oct 15, 2021, 6:21 AM

#

@static canyon can you remind me what PR did you need me to review again?

static canyon Oct 15, 2021, 6:40 AM

#

brisk brook <@442244135840382978> can you remind me what PR did you need me to review again?

It was already reviewed! Dawn (iirc) did it last night

#

If you'd like to review something I do still have other PRs open needing review

#

bot#1874, bot#1845, sir-lancebot#899 and sir-lancebot#900

dusky shoreBOT Oct 15, 2021, 6:44 AM

#

GitHub

PROpen Fix community/staff members not being able to mention users in !remind
PROpen Handle edge case of message.author being a discord.User when claiming a help channel.
PROpen Update role constants
PROpen Fix AttributeErrors in tic-tac-toe command

static canyon Oct 15, 2021, 6:46 AM

#

Top priority being probably either the top or bottom ^

brisk brook Oct 15, 2021, 6:54 AM

#

They all look good other than the few comments I made

#

Just need testing

static canyon Oct 15, 2021, 6:55 AM

#

Thanks 👍

#

Will take a look when I get into school

brisk brook Oct 15, 2021, 6:58 AM

#

Yeah I would test this on my school laptop, but that requires Docker and I am not sure whether I want to install that together with WSL.

static canyon Oct 15, 2021, 6:59 AM

#

Fair enough

obsidian patio Oct 15, 2021, 7:20 AM

#

static canyon bot#1874, bot#1845, sir-lancebot#899 and sir-lancebot#900

bot#1874 is ready to be merged now

#

bot#1874

static canyon Oct 15, 2021, 7:22 AM

#

Ty

#

Have asked a core-dev to merge it 👍

green oriole Oct 15, 2021, 7:24 AM

#

vocal prairie > one code review before reviewing Can you clarify what you mean by that?

err, one code contrib

static canyon Oct 15, 2021, 7:26 AM

#

green oriole err, one code contrib

(i.e. someone should do at least one PR before doing a code review)

static canyon Oct 15, 2021, 7:26 AM

#

obsidian patio bot#1874 is ready to be merged now

It hath been merged, thanks 👍

obsidian patio Oct 15, 2021, 7:27 AM

#

Hope we don’t break the bot lol

static canyon Oct 15, 2021, 7:27 AM

#

lol

#

~~It wouldn't be my first time~~

brisk brook Oct 15, 2021, 8:15 AM

#

static canyon (i.e. someone should do at least one PR before doing a code review)

Literally where is my code PR

static canyon Oct 15, 2021, 8:16 AM

#

You made bot#1821 so you've done issues

dusky shoreBOT Oct 15, 2021, 8:16 AM

#

GitHub

IssueClosed Too strict markdown escape in PythonNews

static canyon Oct 15, 2021, 8:16 AM

#

brisk brook Literally where is my code PR

sir-lancebot#873 PR

dusky shoreBOT Oct 15, 2021, 8:16 AM

#

GitHub

PRMerged Remove multiplayer mode and correctly check current channel

static canyon Oct 15, 2021, 8:17 AM

#

hehe

#

Although granted you'd done reviews etc. before then lol

green oriole Oct 15, 2021, 8:18 AM

#

didn't you contribute to pixels before

brisk brook Oct 15, 2021, 8:21 AM

#

Oh right, this was like after 80% of my total reviews lol

brisk brook Oct 15, 2021, 8:21 AM

#

green oriole didn't you contribute to pixels before

Hmm, one big review or Chris' PR and that access token stuff yeah. I think I reviewed quite a lot before that though

green oriole Oct 15, 2021, 9:29 AM

#

I unborked https://github.com/python-discord/bot/pull/1872

GitHub

Experiment: add Isort to our toolchain by Akarys42 · Pull Request #...

What is Isort?
PyCQA/ISORT is a fantastic hyper configurable tool that will magically sort your imports so you don't have to care about them.
It also comes with a precommit hook. Quite an a...

green oriole Oct 15, 2021, 9:46 AM

#

Woo woo, 2.0 ready to be merged!

vale ibex Oct 15, 2021, 9:48 AM

#

green oriole Woo woo, 2.0 ready to be merged!

eyes_sus

green oriole Oct 15, 2021, 9:49 AM

#

lol, fixing fixing

austere hornet Oct 15, 2021, 11:04 AM

#

Haha

vale ibex Oct 15, 2021, 11:17 AM

#

Once d.py 2.0 is merged, I'll rebase my two PRs onto main so that I can use the new get logger function, otherwise @static canyon will be mad at me

#

😄

static canyon Oct 15, 2021, 11:20 AM

#

vale ibex Once d.py 2.0 is merged, I'll rebase my two PRs onto main so that I can use the ...

:p

#

@vale ibex are you free to help with a query I have RE structuring?

vale ibex Oct 15, 2021, 11:31 AM

#

I'm semi free, so can answer questions sure

#

Just in a work call

static canyon Oct 15, 2021, 11:33 AM

#

vale ibex I'm semi free, so can answer questions sure

I've got an issue with sir-lancebot#861 in regards to structuring the change of moving all commands to be a subcommand of a new Hacktoberfest cog.

The best thing I've got at the moment (with inspiration from Akarys) is this:```py
...

from hacktoberfest.issues import issues_command
from hacktoberfest.stats import link_stats_command, stats_command, unlink_stats_command
from hacktoberfest.timeleft import timeleft_command

class Hacktoberfest(commands.Cog):
def init(...):
...

@commands.group(...)
async def hacktoberfest(...):
    ...

@hacktoberfest.command(...)
async def issues(...):
    await hacktoberfest_issues(...)

@hacktoberfest.group(...)
async def stats(...):
    await stats_command(...)

@stats.command(...)
async def link(...):
    await stats_link_command(...)

@stats.command(...):
async def unlink(...):
    await stats_unlink_command(...)

@hacktoberfest.command(...)
async def timeleft(...):
    await hacktoberfest_timeleft(...)

def setup(...):
...```Does this look good? The idea is that the actual handling will still be done in the respective files, so that we don't end up with one massive file with everything in it

dusky shoreBOT Oct 15, 2021, 11:33 AM

#

GitHub

IssueOpen .timeleft command should be a subcommand of hacktoberfest

vale ibex Oct 15, 2021, 11:34 AM

#

There's nothing inherently wrong with that no

#

If they do start getting big, you could always split it into two cogs

static canyon Oct 15, 2021, 11:36 AM

#

I mean the idea is that hacktoberfestissues, hacktoberfeststats timeleft becomes hacktoberfest issues hacktoberfest stats hacktoberfest timeleft. All the same top-level command group so really needs to be one cog

#

The above seems to be the best, so will go with it

vale ibex Oct 15, 2021, 11:36 AM

#

👌

static canyon Oct 15, 2021, 11:36 AM

#

Thanks 👍

#

I'll work on that now since I've got a bit of free time

#

This is actually gonna be more complicated than I thought, because of class attrs etc.

#

Currently all the hacktoberfest commands are their own cog. The way I was planning to move all of these into one parent command (.hacktoberfest) was by importing the main function and calling it, but since the functions are within a class I can't do this.

Should I just remove the class from each file? The issue with that is that I need to figure out what to do with class attributes (the hacktoberfest issues class has a bunch of cache attributes). I guess I could just have the cache variables as global variables?

Alternatively I could have a singleton instance for each class which gets imported, so e.g. from bot.exts.events.hacktoberfest.issues import issues then issues.main_function()

CC @vale ibex

vale ibex Oct 15, 2021, 12:02 PM

#

you could keep the issues class around as it's own file, remove the commands from it and instantiate it within the cog

#

So it becomes a normal oop class for storing state

static canyon Oct 15, 2021, 12:02 PM

#

Right, yeah

#

Instantiate within the Hacktoberfest cog __init__?

vale ibex Oct 15, 2021, 12:03 PM

#

Sure, or have an init task if you need async stuff

static canyon Oct 15, 2021, 12:04 PM

#

So like```py
class Hacktoberfest(...):
def init(self, ...):
self.issues_cog = HacktoberfestIssues()
self.stats_cog = HacktoberfestStats()
self.timeleft_cog = HacktoberfestTimeleft()
...
@hacktoberfest.command()
async def hacktoberfest_issues(...):
self.issues_cog.main_command(...)

vale ibex Oct 15, 2021, 12:04 PM

#

That seems overkill

#

I can't imagine time_left is anything complicated

#

it's just calculating a timedelta right?

static canyon Oct 15, 2021, 12:06 PM

#

It's 3 functions

#

        """
        Calculates the time left until the end of Hacktober.

        Whilst in October, displays the days, hours and minutes left.
        Only displays the days left until the beginning and end whilst in a different month.

        This factors in that Hacktoberfest starts when it is October anywhere in the world
        and ends with the same rules. It treats the start as UTC+14:00 and the end as
        UTC-12.
        """```

vale ibex Oct 15, 2021, 12:06 PM

#

Yea, those could just be helper functions in another file, no need to have a whole class

static canyon Oct 15, 2021, 12:06 PM

#

But it's already a class is my point (it's its own cog)

vale ibex Oct 15, 2021, 12:07 PM

#

There's nothing stopping you from changing that

static canyon Oct 15, 2021, 12:07 PM

#

Right, okay

vale ibex Oct 15, 2021, 12:07 PM

#

The goal of this is to merge all 3 cogs into one cog right?

static canyon Oct 15, 2021, 12:07 PM

#

vale ibex The goal of this is to merge all 3 cogs into one cog right?

Yes

vale ibex Oct 15, 2021, 12:08 PM

#

So ou have a few things here, there's the main cog class, that you will need

#

then you have the option to have another class which can store state, if needed

#

and you could also have util functions if it's easier, and those could live in the cog itself, or another file

static canyon Oct 15, 2021, 12:08 PM

#

The thing is I don't want everything in one file

#

If I move all utils into one file then that's basically all the cogs just moved into a utils file

vale ibex Oct 15, 2021, 12:09 PM

#

Sure, then you could have 3, one for the main cog, one for a class that can store state and have class funcs and then a third for utils funcs that don't live in either

static canyon Oct 15, 2021, 12:09 PM

#

Wdym by "store state"?

vale ibex Oct 15, 2021, 12:10 PM

#

You said one of the current cogs has quite a lot of class vars for caching right?

#

That what I was referring to

static canyon Oct 15, 2021, 12:10 PM

#

Yeah, hacktoberfest issuespy def __init__(self, bot: Bot): self.bot = bot self.cache_normal = None self.cache_timer_normal = datetime.datetime(1, 1, 1) self.cache_beginner = None self.cache_timer_beginner = datetime.datetime(1, 1, 1)

#

Think it's used for caching different issues

vale ibex Oct 15, 2021, 12:11 PM

#

Take the talentpool in @stable mountain as an example, it has the main cog file in _cog.py, which has all the commands, then it has the _review.py file which has a class for scheduling reviews

#

So for this, you could have a cog which contains all the commands, maybe a few helper utils, then you could have another file with a cache class

static canyon Oct 15, 2021, 12:13 PM

#

Each cog has its own helpers is the thing

#

So if I only have one utils/helpers file, then I'm basically just merging all the cogs which is exactly what I want to avoid

#

I mean maybe I can semi-tidy by splitting into classes within _utils.py, so like```py

_utils.py

class HacktoberfestIssuesUtils:
...

class HacktoberfestStatsUtils:
...

class HacktoberfestTimeleftUtils:
...```

#

So the three files would be _cache.py, _cog.py and _utils.py:```py

_cache.py

class IssuesCache:
"""Handles cache for .hacktoberfest issues command"""
...

# _cog.py
class Hacktoberfest:
    """Handles hacktoberfest commands."""

    ...
``````py
# _utils.py
class HacktoberfestIssuesUtils:
    """Stores util functions for `.hacktoberfest issues`."""
    ...

class HacktoberfestStatsUtils:
    """Stores util functions for `.hacktoberfest stats`."""
    ...

class HacktoberfestTimeleftUtils:
    """Stores util functions for `.hacktoberfest timeleft`."""
```

static canyon Oct 15, 2021, 12:17 PM

#

static canyon So the three files would be `_cache.py`, `_cog.py` and `_utils.py`:```py # _cach...

Thoughts? @vale ibex

#

And then have all the util functions as classmethods (think that's the right term) so that I don't need an instance (can just do HacktoberfesIssuesUtils.get_issues(...) etc.)

vale ibex Oct 15, 2021, 12:18 PM

#

Sure, that could work

static canyon Oct 15, 2021, 12:19 PM

#

That's what I'll go for then, unless someone says otherwise before I implement tonight (in ~6-8 hours)

#

!remind 8h ^ if not already started

stable mountainBOT Oct 15, 2021, 12:19 PM

#

I'll allow it.

Your reminder will arrive on <t:1634329176:F>!

brazen charm Oct 15, 2021, 12:20 PM

#

Is it really necessary to namespace them?

#

It's also preferred to use modules for that instead of abusing classes

brisk brook Oct 15, 2021, 12:54 PM

#

static canyon I mean maybe I can semi-tidy by splitting into classes within `_utils.py`, so li...

🤨

static canyon Oct 15, 2021, 1:13 PM

#

brazen charm It's also preferred to use modules for that instead of abusing classes

So 3 separate util files?

#

I guess that makes sense, just not sure if that's the tidiest way

brisk brook Oct 15, 2021, 1:17 PM

#

Why is there a need for namespacing?

#

Isn't it just a handful of utils files?

static canyon Oct 15, 2021, 1:18 PM

#

brisk brook Isn't it just a handful of utils files?

what do you mean?

brisk brook Oct 15, 2021, 1:18 PM

#

I mean methods

#

How many methods are there you need in this utils file?

static canyon Oct 15, 2021, 1:20 PM

#

brisk brook How many methods are there you need in this utils file?

stats has 329 lines of utils (10 methods)
issues has 61 lines of utils (2 methods)
timeleft has 17 lines of utils (2 methods)

Total of 407 lines over 14 methods

brisk brook Oct 15, 2021, 1:29 PM

#

Won't the name of the methods give away quite easy what purpose it serves?

I don't mind this being in one file. 400 lines is a quite okay length.

static canyon Oct 15, 2021, 1:31 PM

#

Not always, e.g. there's in_hacktober, build_embed etc.

#

But I guess I can separate them by just a comment

#

# _utils.py

## Issue utils
...

# Stat utils
...

## Timeleft utils
...```

#

So the three files would be _cache.py, _cog.py and _utils.py:```py

_cache.py

class IssuesCache:
"""Handles cache for .hacktoberfest issues command"""
...

# _cog.py
class Hacktoberfest:
    """Handles hacktoberfest commands."""

    ...
``````py
# _utils.py
## utils for `.hacktoberfest issues`
    ...

## utils for `.hacktoberfest stats`
    ...

## utils for `hacktoberfest timeleft`
    ...
```

brisk brook Oct 15, 2021, 1:37 PM

#

static canyon Not always, e.g. there's `in_hacktober`, `build_embed` etc.

build_xyz_embed()

brisk brook Oct 15, 2021, 1:38 PM

#

static canyon So the three files would be `_cache.py`, `_cog.py` and `_utils.py`:```py # _cach...

That sounds good

static canyon Oct 15, 2021, 1:38 PM

#

👍

#

What about constants? @brisk brook

#

Create a _constants.py?

brisk brook Oct 15, 2021, 1:40 PM

#

Depends on how many, I'd say they may fit in the utils.py file or just cog.py

static canyon Oct 15, 2021, 1:41 PM

#

There's 11 I think

#

@brisk brook ^

#

I'd be fine with it going at the top of one of those two files

#

Just not sure which

brisk brook Oct 15, 2021, 1:49 PM

#

static canyon Just not sure which

Put it in the file with the least amount of lines then

static canyon Oct 15, 2021, 1:49 PM

#

Yeah, fair enough

#

That would be _cog.py

stable mountainBOT Oct 15, 2021, 2:41 PM

#

timid sentinel !remind 17h This if it hasn't happened already

It has arrived!

Here's your reminder: This if it hasn't happened already
[Jump back to when you created the reminder](#dev-contrib message)

molten perch Oct 15, 2021, 3:09 PM

#

Hey! Could a core-dev take a look at api#22? If it's good to go, I'd like to work on it during the weekend.

dusky shoreBOT Oct 15, 2021, 3:09 PM

#

GitHub

IssueOpen Migrate reminders endpoint from the site API

gritty wind Oct 15, 2021, 3:10 PM

#

Is the DB migration part of #22?

#

It seems not, so what’s the blocker for the migration

vale ibex Oct 15, 2021, 3:17 PM

#

Hey @cold island would you mind if I merge main into your site#591 PR? or would you rather rebase onto main locally?

dusky shoreBOT Oct 15, 2021, 3:17 PM

#

GitHub

PROpen Restructure bot contributing guide

vale ibex Oct 15, 2021, 3:17 PM

#

mostly for the static preview

molten perch Oct 15, 2021, 3:18 PM

#

gritty wind It seems not, so what’s the blocker for the migration

The lack of approval! 😄

gritty wind Oct 15, 2021, 3:19 PM

#

I c

cold island Oct 15, 2021, 4:46 PM

#

vale ibex Hey <@!512354988157173763> would you mind if I merge main into your site#591 PR?...

I don't mind either way

vale ibex Oct 15, 2021, 4:55 PM

#

cold island I don't mind either way

👌 I've just merged main into it

gritty wind Oct 15, 2021, 4:56 PM

#

The fact you didn't have 3K conflicts is nothing short of a miracle

#

Are the � in that PR intentional

#

They appear as question marks for me

vale ibex Oct 15, 2021, 5:06 PM

#

yes

#

!charinfo �

stable mountainBOT Oct 15, 2021, 5:06 PM

#

Character Info

\ufffd : REPLACEMENT CHARACTER - �

vale ibex Oct 15, 2021, 5:06 PM

#

It's used as a placeholder to show parts of the config.yml you need to replace

gritty wind Oct 15, 2021, 5:06 PM

#

lmao that's perfect

#

thanks zig, very cool

fallen patrol Oct 15, 2021, 5:26 PM

#

gritty wind Are the `�` in that PR intentional

You aren't the first to ask...
@cold island perhaps a comment at the top of the config file is in order

vale ibex Oct 15, 2021, 5:27 PM

#

There is...

#

fallen patrol Oct 15, 2021, 5:28 PM

#

Nope, that's in the guide.

#

I mean at the top of config.yml

vale ibex Oct 15, 2021, 5:28 PM

#

#

This is literally on top of the yml

fallen patrol Oct 15, 2021, 5:29 PM

#

Wait... The config.yml file is not in the bot repo

vale ibex Oct 15, 2021, 5:29 PM

#

in the same collapsible element

fallen patrol Oct 15, 2021, 5:29 PM

#

Dumb me

#

Everywhere that file appears it has the explanation at the top

vale ibex Oct 15, 2021, 5:29 PM

#

it only appears once

stable mountainBOT Oct 15, 2021, 8:19 PM

#

static canyon !remind 8h ^ if not already started

It has arrived!

Here's your reminder: ^ if not already started
[Jump back to when you created the reminder](#dev-contrib message)

molten perch Oct 15, 2021, 9:51 PM

#

Hey! Could a core-dev take a look at api#22 and possibly approve the issue? 😄
(Sorry for the continuous issue bumping 😄 )

dusky shoreBOT Oct 15, 2021, 9:51 PM

#

GitHub

IssueOpen Migrate reminders endpoint from the site API

solemn kayak Oct 15, 2021, 10:03 PM

#

Mobile devices place tables of content right at the bottom of the page in the guides on the website (for an example see Hemlock’s code review guide). This makes them sort of pointless for mobile users since they have to scroll through the entire page to click a link on the TOC. Is this something worth making an issue for?

verbal basalt Oct 16, 2021, 4:30 AM

#

that's funny in python, I really think it's a bug, at least in version 3.8.1:
when I instantiate a class Line, when I call a line.append(token), it instead of appending to the individual list of the instantiated class, it is doing append to the class(object), thus getting all the "line" (instantiated object) with the same elements in the token list.
code:
class Line:
def init(self, number, idx, string, tokens=list()):
self.num, self.idx, self.cols = number, idx, len(string)
self.tokens, self.string = tokens, string
self.ident_level = 0
while string.startswith('\t'):
self.ident_level += 1
string = string[1:]

lines = []
line = Line(1, 0, "test")
line.tokens.append(1)
lines.append(line)
line = Line(2, 0, "test 2")
line.tokens.append(2)
lines.append(line)

for line in lines:
print(line.tokens)

Console:

[1, 2]
[1, 2]

sharp timber Oct 16, 2021, 4:38 AM

#

!mutable-defaults

stable mountainBOT Oct 16, 2021, 4:38 AM

#

Mutable Default Arguments

Default arguments in python are evaluated once when the function is
defined, not each time the function is called. This means that if
you have a mutable default argument and mutate it, you will have
mutated that object for all future calls to the function as well.

For example, the following append_one function appends 1 to a list
and returns it. foo is set to an empty list by default.

>>> def append_one(foo=[]):
...     foo.append(1)
...     return foo
...

See what happens when we call it a few times:

>>> append_one()
[1]
>>> append_one()
[1, 1]
>>> append_one()
[1, 1, 1]

Each call appends an additional 1 to our list foo. It does not
receive a new empty list on each call, it is the same list everytime.

To avoid this problem, you have to create a new object every time the
function is called:

>>> def append_one(foo=None):
...     if foo is None:
...         foo = []
...     foo.append(1)
...     return foo
...
>>> append_one()
[1]
>>> append_one()
[1]

Note:

• This behavior can be used intentionally to maintain state between
calls of a function (eg. when writing a caching function).
• This behavior is not unique to mutable objects, all default
arguments are evaulated only once when the function is defined.

sharp timber Oct 16, 2021, 4:39 AM

#

They should show up if you run flake8

#

TLDR the __init__ line is run once, so a list is created only once, and thus the same list is passed to all of the instances of that class as a default argument

fallen patrol Oct 16, 2021, 5:11 AM

#

vale ibex it only appears once

Which is everywhere that file appears :P

#

~~it's technically twice tho~~ once in deployment and once in repo

short snow Oct 16, 2021, 7:15 AM

#

How about moving the explaination of the config to the config on the repo and just embedding that on site?

#

so we won't need to change it at two places

vale ibex Oct 16, 2021, 7:21 AM

#

This file doesn't appear in the repo, the repo only has the config defaults. There are no replacement chars in that.

We don't want to split the contrib guide up into two places, as that would just make it harder for new contribs

green oriole Oct 16, 2021, 7:21 AM

#

molten perch Hey! Could a core-dev take a look at api#22 and possibly approve the issue? 😄 ...

Sure thing, you don't need approval for porting issues like this, since the original has been approved and we told you you should port to the new API :)

molten perch Oct 16, 2021, 7:22 AM

#

Cool! Thank you! 😎

short snow Oct 16, 2021, 7:25 AM

#

vale ibex This file doesn't appear in the repo, the repo only has the config defaults. The...

no the default_config.yml file which zig included in the guide and added some explanation comments in it.

And we won't be splitting it, we would just embed the file present in the repo on the site, like GitHub does when you link code lines

#

https://deploy-preview-591--pydis-static.netlify.app/pages/guides/pydis-guides/contributing/bot/#configyml

Python Discord - Contributing to Bot

A guide to setting up and configuring Bot.

#

Also could we add a go back to top option on the site?

vale ibex Oct 16, 2021, 7:26 AM

#

Yea, that's the file that we changed, we added replacement chars to highlight what values need to be changed

#

So that if someone tried to load the bot without changing it would error

short snow Oct 16, 2021, 7:27 AM

#

dev_guild:
    id: &DEV_GUILD_ID   1234536798 # �

    categories:
        logs:           &DEV_LOGS               1234536798 # �

#

something like this?

#

Or we would need to add a note to the pr template if someone changed the conifg, please change it on site too

vale ibex Oct 16, 2021, 7:28 AM

#

That could work, but work requires a lot of comments, since we explain a lot of things about this file in the guide

#

Since its different if its running locally or in docker

short snow Oct 16, 2021, 7:29 AM

#

It won't be a problem to include that on the repo?

#

no just the file, nothing else

#

like the dropdown part of the section

vale ibex Oct 16, 2021, 7:29 AM

#

That's not all of the explanation

#

Theres more below

#

When helping a new contrib, I'd rather be able to link them to a page on site and have them read properly formatted sentences and paragraphs, rather than comments in a yml file

short snow Oct 16, 2021, 7:31 AM

#

Yeah i know lemme explain again what i am saying, currently if we add a new variable we would need to change it in two places on the site (after this pr) and the bot. So rather than changing it on two places if we "embed" the dropdown part of the section i linked above to just show the file contents of the default config file present on the github we won't be required to change it at two places then

#

rest of the stuff would remain the same

#

This part of the seciton

#

Like in my enhance incidents pr, i added a webhook config variable, so i would now need to even add it on the site also

vale ibex Oct 16, 2021, 7:34 AM

#

Ah right, I'm not sure about adding more dynamic content back onto the site

short snow Oct 16, 2021, 7:34 AM

#

offtopic You are back with your OG profile 👀

vale ibex Oct 16, 2021, 7:34 AM

#

After the effort we made to make it static

short snow Oct 16, 2021, 7:35 AM

#

Not sure how we would do it 🤷‍♂️ but was just a idea. If it is possible would be awesome

vale ibex Oct 16, 2021, 7:35 AM

#

Yea it does sound like it would be useful for when new vars are added

#

Just need to weigh that up against the fact that it won't error on boot if a new contrib forgets to change a replacement char

short snow Oct 16, 2021, 7:37 AM

#

short snow ```yml dev_guild: id: &DEV_GUILD_ID 1234536798 # � categories: ...

we could just add the replacement chars in comments after the config of this server

#

Like it is possible to embed github gists, is it possible for files also?

gritty wind Oct 16, 2021, 7:37 AM

#

I don’t really think it’s a big deal to have it in two places

#

It’s edited once every blue moon anyways

#

And the number of times we add something a contrib has to edit is even lower

short snow Oct 16, 2021, 7:38 AM

#

True 👍

molten perch Oct 16, 2021, 8:16 AM

#

I can do it, if no-one else wants to. Have a nice vacation! 😄

sand bone Oct 16, 2021, 9:09 AM

#

!run

#

!code

stable mountainBOT Oct 16, 2021, 9:09 AM

#

Here's how to format Python code on Discord:

```py
print('Hello world!')
```

These are backticks, not quotes. Check this out if you can't find the backtick key.

sand bone Oct 16, 2021, 9:10 AM

#

!run
import request

r = requests.get('https://google.com')
print(r.cookies['1P_JAR'])

#

!run

import request

r = requests.get('https://google.com/%27)
print(r.cookies['1P_JAR'])

vale ibex Oct 16, 2021, 9:50 AM

#

sand bone !run import request r = requests.get('https://google.com') print(r.cookies['1P...

It's !eval but please run that in #bot-commands 😄

gritty wind Oct 16, 2021, 9:51 AM

#

Hi, please use #bot-commands for testing

#

^^

brazen charm Oct 16, 2021, 10:51 AM

#

@vale ibex looks like I was a bit slow with the comment on the isort PR, should I open a new one for it?

#

it also looks like isort is only available through it being a dep of flake8-isort which we can depend on but doesn't feel ideal

vale ibex Oct 16, 2021, 11:00 AM

#

Ah yea, missed that. that makes sense for sure 😄

#

Wait, this fails flake8 when running locally

#

How did it pass in the action

#

PS C:\Users\Chris\src\bot> poetry run task lint
Check for merge conflicts................................................Passed
Check Toml...............................................................Passed
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
check blanket noqa.......................................................Passed
isort (python)...........................................................Passed
Flake8...................................................................Failed
- hook id: flake8
- exit code: 1

bot/exts/info/doc/_parsing.py:15:1: I202 Additional newline in a group of imports. 'from . import MAX_SIGNATURE_AMOUNT' is identified as Application Relative and 'from bot.utils.helpers import find_nth_occurrence' is identified as Application.
bot/exts/info/doc/__init__.py:3:1: I202 Additional newline in a group of imports. 'from ._redis_cache import DocRedisCache' is identified as Application Relative and 'from bot.bot import Bot' is identified as Application.
bot/exts/info/doc/_cog.py:26:1: I202 Additional newline in a group of imports. 'from . import NAMESPACE, PRIORITY_PACKAGES, _batch_parser, doc_cache' is identified as Application Relative and 'from bot.utils.scheduling import Scheduler' is identified as Application.
bot/exts/info/doc/_batch_parser.py:18:1: I202 Additional newline in a group of imports. 'from . import _cog, doc_cache' is identified as Application Relative and 'from bot.utils import scheduling' is identified as Application.
bot/api.py:9:1: I202 Additional newline in a group of imports. 'from .constants import Keys, URLs' is identified as Application Relative and 'from bot.log import get_logger' is identified as Application.
bot/exts/info/doc/_html.py:10:1: I202 Additional newline in a group of imports. 'from . import MAX_SIGNATURE_AMOUNT' is identified as Application Relative and 'from bot.log import get_logger' is identified as Application.

#

Running the exact command from the action ```
PS C:\Users\Chris\src\bot> poetry run flake8 --format='::error file=%(path)s,line=%(row)d,col=%(col)d::[flake8] %(code)s: %(text)s'
::error file=.\bot\api.py,line=9,col=1::[flake8] I202: Additional newline in a group of imports. 'from .constants import Keys, URLs' is identified as Application Relative and 'from bot.log import get_logger' is identified as Application.
::error file=.\bot\exts\info\doc_batch_parser.py,line=18,col=1::[flake8] I202: Additional newline in a group of imports. 'from . import _cog, doc_cache' is identified as Application Relative and 'from bot.utils import scheduling' is identified as Application.
::error file=.\bot\exts\info\doc_cog.py,line=26,col=1::[flake8] I202: Additional newline in a group of imports. 'from . import NAMESPACE, PRIORITY_PACKAGES, batch_parser, doc_cache' is identified as Application Relative and 'from bot.utils.scheduling import Scheduler' is identified as Application.
::error file=.\bot\exts\info\doc_html.py,line=10,col=1::[flake8] I202: Additional newline in a group of imports. 'from . import MAX_SIGNATURE_AMOUNT' is identified as Application Relative and 'from bot.log import get_logger' is identified as Application.
::error file=.\bot\exts\info\doc_parsing.py,line=15,col=1::[flake8] I202: Additional newline in a group of imports. 'from . import MAX_SIGNATURE_AMOUNT' is identified as Application Relative and 'from bot.utils.helpers import find_nth_occurrence' is identified as Application.
::error file=.\bot\exts\info\doc_init.py,line=3,col=1::[flake8] I202: Additional newline in a group of imports. 'from ._redis_cache import DocRedisCache' is identified as Application Relative and 'from bot.bot import Bot' is identified as Application.

#

pithink

green oriole Oct 16, 2021, 11:18 AM

#

vale ibex ``` PS C:\Users\Chris\src\bot> poetry run task lint Check for merge conflicts......

pip install --remove-untracked and reinstall poetry lol

#

There is prooobably a better way to do it

#

Basically flake8-import-order doesn't get uninstalled while it should

#

poetry run pip uninstall flake8-import-order perhaps?

vale ibex Oct 16, 2021, 11:22 AM

#

ahh

vale ibex Oct 16, 2021, 11:42 AM

#

green oriole `pip install --remove-untracked` and reinstall poetry lol

poetry has that now actually

#

poetry install --remove-untracked

#

Oh, great poetry has borked installing from cache in windows in the latest release

#

https://github.com/python-poetry/poetry/issues/4163

GitHub

ValueError, whl in cache does not exist when running poetry install...

I am on the latest Poetry version. I have searched the issues of this repo and believe that this is not a duplicate. If an exception occurs when executing a command, I executed it again in debug mo...

#

So now I need to delete my cache any time I want to install something 🙃

green oriole Oct 16, 2021, 12:07 PM

#

Noice

gritty wind Oct 16, 2021, 12:13 PM

#

Y'all update your poetries?

#

I installed it when setting up my PC and haven't though about it since lol

vale ibex Oct 16, 2021, 12:13 PM

#

Yea, I just updated mine now

#

which caused these issues

#

so I'm just gonna downgrade

gritty wind Oct 16, 2021, 12:13 PM

#

Ah yis

#

Tell me what you downgrade to

#

May as well upgrade now before I forget

vale ibex Oct 16, 2021, 12:16 PM

#

I went down to 1.0.8

green oriole Oct 16, 2021, 12:16 PM

#

I never upgrade those until they break

#

Perhaps I should install them using the Arch package so they get updated

viscid canopy Oct 16, 2021, 2:08 PM

#

Add pydantic to supported Python modules

#

In !eval command

vale ibex Oct 16, 2021, 3:04 PM

#

Hey @gritty wind mind if I remake bot#1285? The fork is deleted and it's quite of out date 😅

dusky shoreBOT Oct 16, 2021, 3:04 PM

#

GitHub

PROpen Formats Per-Command Help Output

vale ibex Oct 16, 2021, 3:04 PM

#

not sure if you still had that patch that you mentioned around, if not i could take a look

vale ibex Oct 16, 2021, 3:21 PM

#

It seems all that's needed it to change the regex you have now (?<!\n)\n(?!\n) to (?<!\n)\n(?![\n\u2003])"

#

since we use \u2003 in the docstrings we want to break

static canyon Oct 16, 2021, 3:30 PM

#

sir-lancebot    | 10/16/21 15:28:40 - async_rediscache.types.base CRITICAL: can't get a pool connection as the RedisCache instance does not have a namespace.
sir-lancebot    | 10/16/21 15:28:40 - root DEBUG: Error Encountered: NoNamespaceError - can't get a pool connection as the RedisCache instance does not have a namespace., Command: hacktoberfest stats, Author: TizzySaurus#9615, Channel: bot-commands
sir-lancebot    | 10/16/21 15:28:40 - bot.exts.core.error_handler ERROR: Unhandled command error: can't get a pool connection as the RedisCache instance does not have a namespace.
sir-lancebot    | Traceback (most recent call last):
sir-lancebot    |   File "/usr/local/lib/python3.9/site-packages/discord/ext/commands/core.py", line 167, in wrapped
sir-lancebot    |     ret = await coro(*args, **kwargs)
sir-lancebot    |   File "/bot/bot/exts/events/hacktoberfest/_cog.py", line 63, in stats
sir-lancebot    |     if await self.linked_accounts.contains(author_id):
sir-lancebot    |   File "/usr/local/lib/python3.9/site-packages/async_rediscache/types/base.py", line 260, in wrapper
sir-lancebot    |     result = await coroutine_object
sir-lancebot    |   File "/usr/local/lib/python3.9/site-packages/async_rediscache/types/cache.py", line 123, in contains
sir-lancebot    |     with await self._get_pool_connection() as connection:
sir-lancebot    |   File "/usr/local/lib/python3.9/site-packages/async_rediscache/types/base.py", line 110, in _get_pool_connection
sir-lancebot    |     raise NoNamespaceError(error_message)
sir-lancebot    | async_rediscache.types.base.NoNamespaceError: can't get a pool connection as the RedisCache instance does not have a namespace.
```does anyone know how I can fix this? I'm not exactly sure what the code causing this error is

vocal prairie Oct 16, 2021, 3:31 PM

#

Did you enable USE_FAKEREDIS?

vale ibex Oct 16, 2021, 3:31 PM

#

How are you creating the redis cache?

static canyon Oct 16, 2021, 3:31 PM

#

vocal prairie Did you enable USE_FAKEREDIS?

Yes

static canyon Oct 16, 2021, 3:31 PM

#

vale ibex How are you creating the redis cache?

class Hacktoberfest(commands.Cog):
    def __init__(self, bot: Bot):
        self.bot = bot

        # Caches for `.hacktoberfest stats`
        self.linked_accounts = RedisCache()```

vale ibex Oct 16, 2021, 3:32 PM

#

Ah, it needs to be a class attribute, rather than in the init

static canyon Oct 16, 2021, 3:33 PM

#

vale ibex Ah, it needs to be a class attribute, rather than in the init

class ...:
    linked_accounts = RedisCache()```?

vale ibex Oct 16, 2021, 3:33 PM

#

I think it's so that it can get the namespace

#

yea, like that

static canyon Oct 16, 2021, 3:33 PM

#

Aight

brisk brook Oct 16, 2021, 3:35 PM

#

vale ibex Ah, it needs to be a class attribute, rather than in the init

Do you know why that is?

static canyon Oct 16, 2021, 3:35 PM

#

That seems to work, just fixing some other things

vale ibex Oct 16, 2021, 3:36 PM

#

brisk brook Do you know why that is?

    Please note that for automatic namespacing, this class MUST be created as a
    class attribute to properly initialize the instance's namespace. See
    `__set_name__` for more information about how this works.

#

from asyncredis cache

#

    def __set_name__(self, owner: Any, attribute_name: str) -> None:
        """
        Set the namespace to Class.attribute_name.

        Called automatically when this class is assigned to a class attribute.

        This class MUST be created as a class attribute, otherwise it will raise
        exceptions whenever a method is used. This is because it uses this
        method to create a namespace like `MyCog.my_class_attribute` which is
        used as a hash name when we store stuff in Redis, to prevent collisions.

        The namespace is only set the first time a class attribute gets assigned
        to a RedisCache instance. Assigning a class attribute to an existing
        instance will not overwrite the namespace and the additional class
        attribute will act as an alias to the original instance.
        """
        if not self._local_namespace:
            self._local_namespace = f"{owner.__name__}.{attribute_name}"

brisk brook Oct 16, 2021, 3:37 PM

#

Oh, it automatically gives it a name from the class and variable?

vale ibex Oct 16, 2021, 3:37 PM

#

yea

brisk brook Oct 16, 2021, 3:37 PM

#

Huh

vale ibex Oct 16, 2021, 3:37 PM

#

that's if you want to use auto-namespacing

#

you could also do RedisCache(namespace="foo")

static canyon Oct 16, 2021, 3:38 PM

#

Should I use constants.Client.prefix over ctx.prefix (on lancebot)?

vale ibex Oct 16, 2021, 3:38 PM

#

but that comes with a chance of collision

vale ibex Oct 16, 2021, 3:39 PM

#

static canyon Should I use `constants.Client.prefix` over `ctx.prefix` (on lancebot)?

the only time they'd be different is if the user invoked lance via mention

#

if that matters, then sure use constants

static canyon Oct 16, 2021, 3:39 PM

#

Yeah, suppose I should then

vale ibex Oct 16, 2021, 3:39 PM

#

👌

static canyon Oct 16, 2021, 3:52 PM

#

How exactly does detection of a valid hacktober pr thing work for .hackstats? It doesn't seem to being working

gritty wind Oct 16, 2021, 4:08 PM

#

vale ibex It seems all that's needed it to change the regex you have now `(?<!\n)\n(?!\n)`...

I have no idea how taxing that regex is, so I actually opted for "u2003" in ...

#

Meant to ping there @vale ibex

#

Though, thinking about it now

#

This isn't very time sensitive

#

So it's fine

#

Also yeah, feel free to take over

#

Xith poked me about that PR at least 10 times, I feel bad keeping him waiting

vale ibex Oct 16, 2021, 4:09 PM

#

I can't imagine it would be more taxing that running all of our filter tokens on every message

#

since it just runs when you invoke help lol

gritty wind Oct 16, 2021, 4:09 PM

#

lmao true true

#

Hey github finally fixed the thing

#

vale ibex Oct 16, 2021, 4:11 PM

#

neat

gritty wind Oct 16, 2021, 4:13 PM

#

OT: I'm still not used to your new-old PFP, keeps throwing me off

vale ibex Oct 16, 2021, 4:13 PM

#

lol

#

It took me longer than i care to admit to find it again

#

Since I never actually saved it

gritty wind Oct 16, 2021, 4:13 PM

#

lol did you save it this time

vale ibex Oct 16, 2021, 4:14 PM

#

Yea, it's saved...until I delete it

#

I tend to clear out folders often lol

gritty wind Oct 16, 2021, 4:14 PM

#

Hah see you back here in 4 months

vale ibex Oct 16, 2021, 4:15 PM

#

Barneylaugh

static canyon Oct 16, 2021, 4:43 PM

#

@thorny obsidian do you have any idea how the .hackstats command is supposed to work? It doesn't seem to work anymore

vale ibex Oct 16, 2021, 4:46 PM

#

.src hackstats

dusky shoreBOT Oct 16, 2021, 4:46 PM

#

Command: hacktoberstats

Display an embed for a user's Hacktoberfest contributions.

Source Code

Go to GitHub

vale ibex Oct 16, 2021, 4:47 PM

#

It looks like you're supposed to link your github acc to your user, and then it searched for closed PRs via the github api

#

.hackstats link ChrisLovering

dusky shoreBOT Oct 16, 2021, 4:48 PM

#

@vale ibex, your GitHub username has been added

vale ibex Oct 16, 2021, 4:48 PM

#

.hackstats

dusky shoreBOT Oct 16, 2021, 4:48 PM

#

No valid Hacktoberfest PRs found for 'ChrisLovering'

vale ibex Oct 16, 2021, 4:48 PM

#

yea

thorny obsidian Oct 16, 2021, 4:48 PM

#

I have actually no idea how it works. I know there's a PR or an issue open to fix how it was finding it for last year.

vale ibex Oct 16, 2021, 4:50 PM

#

you link your github acc, it pulls all your PRs from october this year, and looks if any have hacktoberfest-accepted label

#

and don't have invalid or spam

#

get_october_prs is the important function there

cold moon Oct 16, 2021, 4:51 PM

#

Does it check for repository topics?

vale ibex Oct 16, 2021, 4:51 PM

#

Yea

#

https://github.com/python-discord/sir-lancebot/blob/210a97a4eee9a4babc26366f71d13edcd21b6f9c/bot/exts/events/hacktoberfest/hacktoberstats.py#L188-L210

#

There's still some code in there from last year, since that only happened after oct3

#

that isn't applicable this year

cold moon Oct 16, 2021, 4:53 PM

#

Yes, it does not work for me too. I have 2 PRs but this show none

static canyon Oct 16, 2021, 4:54 PM

#

cold moon Yes, it does not work for me too. I have 2 PRs but this show none

Okay, good, so it's not just me

vale ibex Oct 16, 2021, 4:54 PM

#

It seems this is the wrong way around https://github.com/python-discord/sir-lancebot/blob/210a97a4eee9a4babc26366f71d13edcd21b6f9c/bot/exts/events/hacktoberfest/hacktoberstats.py#L288-L296

stable mountainBOT Oct 16, 2021, 4:54 PM

#

bot/exts/events/hacktoberfest/hacktoberstats.py lines 288 to 296

if jsonresp2.get("names") is None:
    log.error(f"Error fetching topics for {shortname}: {jsonresp2['message']}")
    continue  # Assume the repo doesn't have the `hacktoberfest` topic if API  request errored

# PRs after oct 3 that doesn't have 'hacktoberfest-accepted' label
# must be in repo with 'hacktoberfest' topic
if "hacktoberfest" in jsonresp2["names"]:
    hackto_topics[shortname] = True  # Cache result in the dict for later use if needed
    outlist.append(itemdict)```

vale ibex Oct 16, 2021, 4:54 PM

#

it's checking topics and continue if there aren't any

static canyon Oct 16, 2021, 4:54 PM

#

In which case I'll just move it and not fix; will leave the fixing up to someone else

vale ibex Oct 16, 2021, 4:55 PM

#

there might be more, this function is quite complicated for what it's doing

#

Might be easier to just refactor it

static canyon Oct 16, 2021, 4:55 PM

#

Yeah, I was looking through the code and just couldn't really figure it out

vale ibex Oct 16, 2021, 4:55 PM

#

I think the one I linked above is the issue your seeing

static canyon Oct 16, 2021, 4:55 PM

#

I think it's out of scope for this PR to be fixing it anyway

static canyon Oct 16, 2021, 4:56 PM

#

stable mountain `bot/exts/events/hacktoberfest/hacktoberstats.py` lines 288 to 296 ```py if json...

It doesn't even reach that far

#

The first if statement stops it

vale ibex Oct 16, 2021, 4:56 PM

#

Ah

static canyon Oct 16, 2021, 4:57 PM

#

https://github.com/python-discord/sir-lancebot/blob/210a97a4eee9a4babc26366f71d13edcd21b6f9c/bot/exts/events/hacktoberfest/hacktoberstats.py#L230

stable mountainBOT Oct 16, 2021, 4:57 PM

#

bot/exts/events/hacktoberfest/hacktoberstats.py line 230

if "message" in jsonresp:```

vale ibex Oct 16, 2021, 4:57 PM

#

What is the resp?

static canyon Oct 16, 2021, 4:57 PM

#

It's either that because there's an error or https://github.com/python-discord/sir-lancebot/blob/210a97a4eee9a4babc26366f71d13edcd21b6f9c/bot/exts/events/hacktoberfest/hacktoberstats.py#L242 because there's no matching

stable mountainBOT Oct 16, 2021, 4:57 PM

#

bot/exts/events/hacktoberfest/hacktoberstats.py line 242

if jsonresp["total_count"] == 0:```

static canyon Oct 16, 2021, 4:58 PM

#

Before I changed stuff, it was the latter

#

It just never found anything

#

My laptop has died so can't really debug anymore

vale ibex Oct 16, 2021, 4:58 PM

#

Hah no worries

cold island Oct 16, 2021, 8:11 PM

#

@vale ibex addressed review in site#591

dusky shoreBOT Oct 16, 2021, 8:11 PM

#

GitHub

PROpen Restructure bot contributing guide

cold island Oct 16, 2021, 8:17 PM

#

@thorny obsidian do you want to check out the current state of the guide before it's merged?

cold island Oct 16, 2021, 9:08 PM

#

@tawdry vapor should docker-compose be capitalized as well?

tawdry vapor Oct 16, 2021, 9:25 PM

#

Not sure. Look at Docker's documentation to see how they refer to it

vocal prairie Oct 16, 2021, 9:26 PM

#

The docs refer to it as "Docker Compose"

cold island Oct 16, 2021, 9:48 PM

#

@tawdry vapor how do you define an extension?

tawdry vapor Oct 16, 2021, 9:49 PM

#

The same way discord.py defines it. Those commands operate using load_extension, unload_extension,, etc

#

I suppose an extension is any module with a setup function that has a certain signature.

cold island Oct 16, 2021, 9:51 PM

#

Yeah, I'm just thinking that extension is more accurate, but a cog is probably a more familiar term. I'll try just linking to the dpy page on extensions

tawdry vapor Oct 16, 2021, 9:51 PM

#

You can write that it "reloads the cog" but you need to make it clear that the extension's name should be given rather than the cog's

#

Maybe mention the list command so users can get an idea of which extensions are available

cold island Oct 16, 2021, 9:52 PM

#

That's a good idea

#

Is it accurate to say that cogs are parts of extensions?

tawdry vapor Oct 16, 2021, 9:54 PM

#

They can be, not necessarily.

#

Extensions can lack cogs, and cogs can be defined outside extensions.

sleek steppe Oct 16, 2021, 9:55 PM

#

You can use extensions without cogs and vice versa

tawdry vapor Oct 16, 2021, 9:55 PM

#

Though in practice I do not think we ever do this.

cold island Oct 16, 2021, 9:55 PM

#

yeah I don't think so

#

So I guess I can say "in this bot"

tawdry vapor Oct 16, 2021, 9:56 PM

#

Can you just defer this explanation to "!help ext", or is the documentation not detailed enough for it?

cold island Oct 16, 2021, 9:56 PM

#

!help ext

stable mountainBOT Oct 16, 2021, 9:56 PM

#

Command Help

!extensions
Can also use: c, cog, cogs, ext, exts

Load, unload, reload, and list loaded extensions.

Subcommands:

!extensions list
Get a list of all extensions, including their loaded status.
!extensions load [extensions...]
Load extensions given their fully qualified or unqualified names.
!extensions reload [extensions...]
Reload extensions given their fully qualified or unqualified names.
!extensions unload [extensions...]
Unload currently loaded extensions given their fully qualified or unqualified names.

tawdry vapor Oct 16, 2021, 9:56 PM

#

!help extensions reload

stable mountainBOT Oct 16, 2021, 9:56 PM

#

Command Help

!extensions reload [extensions...]
Can also use: extensions r, reload

*Reload extensions given their fully qualified or unqualified names.

If an extension fails to be reloaded, it will be rolled-back to the prior working state.

If '*' is given as the name, all currently loaded extensions will be reloaded.
If '**' is given as the name, all extensions, including unloaded ones, will be reloaded.*

tawdry vapor Oct 16, 2021, 9:56 PM

#

Maybe not

cold island Oct 16, 2021, 10:24 PM

#

Pushed changes

static canyon Oct 16, 2021, 10:37 PM

#

If I'm working on a PR that's about restructuring, and all restructuring is complete but there's an issue with the code from before the restructure, am I okay to still PR knowing there's code in it that doesn't work?

Basically I'm moving all the hacktoberfest commands into one file, but .hackstats is currently broken and so the "restructured" version is still broken (since same actual code for it).

#

I've tried debugging the issue with .hackstats a bit but couldn't really figure it out, and don't particularly have the time to properly debug and fix it

cold island Oct 16, 2021, 10:39 PM

#

Just clarify it in the PR

static canyon Oct 16, 2021, 10:40 PM

#

👍

#

In which case, I can PR now :p

static canyon Oct 16, 2021, 10:51 PM

#

static canyon In which case, I can PR now :p

In fact, there's a little bit more refining I may need to do, so will wait until tomorrow

short snow Oct 17, 2021, 12:00 AM

#

@cold island I can take over the scheduler PR if you and xith don't mind

vocal wolf Oct 17, 2021, 12:46 AM

#

short snow <@!512354988157173763> I can take over the scheduler PR if you and xith don't mi...

Too be completely honest I think your two large PRs (enhancing incidents, mod schedule) should be finished before any other large PRs are taken.

short snow Oct 17, 2021, 12:55 AM

#

Yeah, I was talking after that as I really wanted this feature to be available :D, even preserving unloaded cogs is there ^-^ and my issue on pydis/api. I will wait lol

rapid igloo Oct 17, 2021, 4:10 AM

#

thorny obsidian I have actually no idea how it works. I know there's a PR or an issue open to fi...

yeah last year it shouldn't check for topics or hacktoberfest-accepted if the PR is from before Oct 3, this year I'm assuming the before Oct 3 shoudn't exist anymore which would mean it should show more than the valid PRs so I'm not sure why it isn't working

#

I definitely should've made more meaningful commit messages when I was working on this last year 🤦‍♀️

rapid igloo Oct 17, 2021, 4:15 AM

#

vale ibex It seems this is the wrong way around https://github.com/python-discord/sir-lanc...

it's checking for the hacktoberfest topic and if the request errored or if there aren't any topics at all we would continue/skip to to next one. Line 294 would just be checking the topic and then "caching" it for that repo

rapid igloo Oct 17, 2021, 4:17 AM

#

vale ibex Might be easier to just refactor it

The whole thing can definitely be refactored, just that no one was reviewing the PR at the time so I was more focused on getting it to work well

rapid igloo Oct 17, 2021, 4:41 AM

#

static canyon <@!212644551926611969> do you have any idea how the `.hackstats` command is supp...

currently debugging it

#

ok I found the problem: https://github.com/python-discord/sir-lancebot/blob/210a97a4eee9a4babc26366f71d13edcd21b6f9c/bot/exts/events/hacktoberfest/hacktoberstats.py#L229 seems like it's something wrong with _fetch_url that when I provide the params manually so the line is jsonresp = await self._fetch_url(base_url+"?q="+query_params, REQUEST_HEADERS, {}) it works perfectly

stable mountainBOT Oct 17, 2021, 4:52 AM

#

bot/exts/events/hacktoberfest/hacktoberstats.py line 229

jsonresp = await self._fetch_url(base_url, REQUEST_HEADERS, {"q": query_params})```

cold island Oct 17, 2021, 6:15 AM

#

short snow <@!512354988157173763> I can take over the scheduler PR if you and xith don't mi...

For it to be actually useful, I wanted it to handle arbitrary arguments in the rescheduling function. I wrote the code for it, but it required changing about half the code in that file, and overall both the implementation and the API felt somewhat clumsy to me, which is why I think I'd rather close it for now. Ultimately it's just a QoL thing and doesn't block anything.

short snow Oct 17, 2021, 7:17 AM

#

cold island For it to be actually useful, I wanted it to handle arbitrary arguments in the r...

Hmm alright, I would still go through it when I get sometime after finishing few of my PRs. If I get a good idea of the API and implementation, I would give it a go.

static canyon Oct 17, 2021, 7:50 AM

#

rapid igloo ok I found the problem: https://github.com/python-discord/sir-lancebot/blob/210a...

.bm hackstats issue

#

I'll see if that fixes it later tonight, thanks 👍

#

!remind 11h ^ if not already done

stable mountainBOT Oct 17, 2021, 7:50 AM

#

ROGER THAT

Your reminder will arrive on <t:1634496654:F>!

rapid igloo Oct 17, 2021, 8:00 AM

#

static canyon I'll see if that fixes it later tonight, thanks 👍

I could've opened a PR for it but it didn't feel like a neat fix so I'm digging into aiohttp source code to see if they changed something with the params. By the way FYI I've also added = {} to the headers and params arguments for _fetch_url so they're optional, in case you also get an error like I did.

static canyon Oct 17, 2021, 8:01 AM

#

Yeah, I did notice params was missing in 2 cases

#

Please don't PR though, since I'll have to completely rewrite anyway due to the restructure

#

If you just send the fix here I'll commit on my restructure branch and add you as co-author to give you credit

#

@rapid igloo

rapid igloo Oct 17, 2021, 8:03 AM

#

okay :)

#

do you want a patch or

#

it's just changing the line which I've said above and then making headers and params optional

static canyon Oct 17, 2021, 8:05 AM

#

I'd be looking for a fix inside (what's currently) the hackstats file

static canyon Oct 17, 2021, 8:05 AM

#

rapid igloo it's just changing the line which I've said above and then making `headers` and ...

This will do if you aren't able to find anything "tidier" so to speak

rapid igloo Oct 17, 2021, 8:05 AM

#

yeah I'll have a closer look tonight (in like 4 hours for me)

static canyon Oct 17, 2021, 8:06 AM

#

Sounds good 👍

#

Thanks for looking into this

rapid igloo Oct 17, 2021, 8:07 AM

#

np, it was me who did most (60%?) of the hackstats stuff last year anyway so I'm responsible :p

green oriole Oct 17, 2021, 8:07 AM

#

2.0 migration let's go! partygopher please do jump into #763406158522220544 if you wanna hang out with us

short snow Oct 17, 2021, 8:16 AM

#

green oriole 2.0 migration let's go! <a:partygopher:472490455096098827> please do jump into <...

🥺

#

ty

green oriole Oct 17, 2021, 8:20 AM

#

!echo am I alive?

stable mountainBOT Oct 17, 2021, 8:20 AM

#

am I alive?

green oriole Oct 17, 2021, 8:21 AM

#

short snow Oct 17, 2021, 8:21 AM

#

ducky_party

vale ibex Oct 17, 2021, 8:21 AM

#

!int e print(discord.version)

stable mountainBOT Oct 17, 2021, 8:21 AM

#

In [2]: print(discord.__version__)
2.0.0a```

short snow Oct 17, 2021, 8:22 AM

#

@green oriole what theme is that?

#

k

#

i keep on changing my themes, don't like staying on one lol

green oriole Oct 17, 2021, 8:24 AM

#

@vale ibex https://github.com/python-discord/bot/pull/1877

GitHub

Modlog: remove tzinfo from member_join by Akarys42 · Pull Request #...

#

and also @cold moon 🥺

vocal wolf Oct 17, 2021, 8:24 AM

#

what's going on over there

green oriole Oct 17, 2021, 8:24 AM

#

Breking the infra! Merging d.py 2.0

vocal wolf Oct 17, 2021, 8:24 AM

#

oh no

#

is that today

short snow Oct 17, 2021, 8:25 AM

#

right now 🙃

vocal wolf Oct 17, 2021, 8:25 AM

#

oh it was 10 minutes ago

vale ibex Oct 17, 2021, 8:25 AM

#

yup 😄

#

Just dealing with snags now

#

only found 1 so far

vocal wolf Oct 17, 2021, 8:26 AM

#

we do a little bit of trolling

#

@vale ibex I'm here what's going on

#

are we breaking anything at this current time

#

LOL

#

hey man, you did it to me before

#

I'm taking my revenge

fervent sage Oct 17, 2021, 8:28 AM

#

smh i wanna break stuff too

vocal wolf Oct 17, 2021, 8:28 AM

#

The triage report this week is going to be wack

#

not enough time

vale ibex Oct 17, 2021, 8:29 AM

#

https://github.com/search/advanced?q=org%3Apython-discord+type%3Apr+merged%3A>%3D2021-10-07&type=Issues

vocal wolf Oct 17, 2021, 8:29 AM

#

black magic

vale ibex Oct 17, 2021, 8:30 AM

#

https://github.com/search/advanced?q=org%3Apython-discord+type%3Apr+merged%3A>%3D2021-10-10&type=Issues

vocal wolf Oct 17, 2021, 8:30 AM

#

10-10, yeah

#

4 pages

#

wack

green oriole Oct 17, 2021, 8:32 AM

#

seems like it is working #user-log message

vocal wolf Oct 17, 2021, 8:32 AM

#

was static previews this or last week

hoary anvil Oct 17, 2021, 8:32 AM

#

frenzied typing from akarys

vale ibex Oct 17, 2021, 8:35 AM

#

vale ibex https://github.com/python-poetry/poetry/issues/4163

for reference

vocal wolf Oct 17, 2021, 8:36 AM

#

All the merged stuff:

Sir-Lancebot:
https://github.com/python-discord/sir-lancebot/pull/908
https://github.com/python-discord/sir-lancebot/pull/904
https://github.com/python-discord/sir-lancebot/pull/889
https://github.com/python-discord/sir-lancebot/pull/860
https://github.com/python-discord/sir-lancebot/pull/857

Site:
https://github.com/python-discord/site/pull/609

vale ibex Oct 17, 2021, 8:36 AM

#

poetry install --remove-untracked

#

PS C:\Users\Chris\src\bot> poetry install --remove-untracked
Installing dependencies from lock file

Package operations: 0 installs, 2 updates, 0 removals

• Updating filelock (3.3.0 -> 3.3.1)
• Updating discord.py (1.7.3 -> 2.0.0a0 https://github.com/Rapptz/discord.py/archive/45d498c1b76deaf3b394d17ccf56112fa691d160.zip)

Installing the current project: bot (1.0.0)

vocal wolf Oct 17, 2021, 8:37 AM

#

--remove-untracked Removes packages not present in the lock file.

#

from the man page

#

Sorry not man pages, I mean poetry install --help

vocal wolf Oct 17, 2021, 8:38 AM

#

vocal wolf All the merged stuff: Bot: <https://github.com/python-discord/bot/pull/1875> <h...

These are all the PRs merged from the last week @vale ibex

#

what have we done

vale ibex Oct 17, 2021, 8:38 AM

#

lol

#

we good devs

green oriole Oct 17, 2021, 8:38 AM

#

We speedy devs

vocal wolf Oct 17, 2021, 8:38 AM

#

I can hear both of you typing these messages

#

lmfao

desert vessel Oct 17, 2021, 8:38 AM

#

wassup chris

vale ibex Oct 17, 2021, 8:39 AM

#

bot#1871

dusky shoreBOT Oct 17, 2021, 8:39 AM

#

GitHub

PROpen Modlog ignore channels mods can't view

vocal wolf Oct 17, 2021, 8:39 AM

#

bruh moment

desert vessel Oct 17, 2021, 8:39 AM

#

is that your typing speed or random mashing?

vocal wolf Oct 17, 2021, 8:39 AM

#

mashing

#

def

hoary anvil Oct 17, 2021, 8:39 AM

#

@green oriole why do you use git switch instead of git checkout?

vocal wolf Oct 17, 2021, 8:39 AM

#

4 lines is not 25-13

#

how dare you

#

.wa 25-13

dusky shoreBOT Oct 17, 2021, 8:39 AM

#

Wolfram Alpha

desert vessel Oct 17, 2021, 8:39 AM

#

vocal wolf def

xD

vocal wolf Oct 17, 2021, 8:39 AM

#

it's 12

#

you LIED chris I cannot believe this

desert vessel Oct 17, 2021, 8:40 AM

#

xD

vale ibex Oct 17, 2021, 8:40 AM

#

lol, most of it is docstring and function name refactor

hoary anvil Oct 17, 2021, 8:40 AM

#

vocal wolf it's 12

my, how we can calculate

vale ibex Oct 17, 2021, 8:40 AM

#

there's like 4 functional lines changed

desert vessel Oct 17, 2021, 8:40 AM

#

i need a good vim configuration ;-;

#

btw is there no dev-voice-chat ?

hoary anvil Oct 17, 2021, 8:40 AM

#

no

#

sadly

desert vessel Oct 17, 2021, 8:40 AM

#

rip

#

this is where admins hang out, i see 😂

green oriole Oct 17, 2021, 8:41 AM

#

I like how WA thinks we cannot do basic maths oh wait, we can't

vale ibex Oct 17, 2021, 8:41 AM

#

bot#1876

dusky shoreBOT Oct 17, 2021, 8:41 AM

#

GitHub

PROpen Formats Help Command Output

desert vessel Oct 17, 2021, 8:42 AM

#

.wa 34+1

#

oof

hoary anvil Oct 17, 2021, 8:42 AM

#

@desert vessel why did you react to your own message

desert vessel Oct 17, 2021, 8:42 AM

#

hoary anvil <@!786599434960109568> why did you react to your own message

im jobless hehe

vocal wolf Oct 17, 2021, 8:42 AM

#

.wa 5-4

dusky shoreBOT Oct 17, 2021, 8:42 AM

#

Wolfram Alpha

vocal wolf Oct 17, 2021, 8:42 AM

#

we have to know

#

my god it's 1

desert vessel Oct 17, 2021, 8:42 AM

#

XD

fervent sage Oct 17, 2021, 8:42 AM

#

vocal wolf my god it's 1

no wolfram is lying

#

its actually 6

desert vessel Oct 17, 2021, 8:43 AM

#

how-

#

lol

vocal wolf Oct 17, 2021, 8:43 AM

#

math

#

@vale ibex I reviewed

clever wraith Oct 17, 2021, 8:44 AM

#

.wa 69*69

vocal wolf Oct 17, 2021, 8:44 AM

#

uhhhhhhh

#

1871

#

I wasn't listening what happened

#

40 minute triage report?

vale ibex Oct 17, 2021, 8:46 AM

#

xith what is your github email

#

i will co author locally

vocal wolf Oct 17, 2021, 8:46 AM

#

xithrius@gmail.com

vale ibex Oct 17, 2021, 8:46 AM

#

so that I can rebase too

#

kk

vocal wolf Oct 17, 2021, 8:47 AM

#

@cold island Welcome, to Jurassic park

#

and there he goes

#

probably because I didn't spell it right

#

next project

#

github in the terminal

#

in rust

short snow Oct 17, 2021, 8:48 AM

#

isn't gitui already there pithink

vocal wolf Oct 17, 2021, 8:48 AM

#

is it

cold island Oct 17, 2021, 8:48 AM

#

vocal wolf probably because I didn't spell it right

Yeah, I didn't mean to enter Jurrasic park

short snow Oct 17, 2021, 8:48 AM

#

lol

vocal wolf Oct 17, 2021, 8:48 AM

#

short snow isn't gitui already there <:pithink:652247559909277706>

I mean like PR stuff, not local git stuff

#

@vale ibex wanna squash modlog ignore channels mods can't view pr

short snow Oct 17, 2021, 8:49 AM

#

Oh nice

vocal wolf Oct 17, 2021, 8:49 AM

#

you've done nothing wrong

#

just wondering

#

5 commits, idk if you want to or not

#

yeah chris you broke github how dare you

#

@vale ibex wait I retract my approval

#

grammar incoming

short snow Oct 17, 2021, 8:50 AM

#

oh no, i got merge conflcits

#

smh

#

enhance incidents

#

@vocal wolf can i squash down the PR? It is anyways going to be squash merged

vocal wolf Oct 17, 2021, 8:51 AM

#

which one

short snow Oct 17, 2021, 8:51 AM

#

bot#1446

dusky shoreBOT Oct 17, 2021, 8:51 AM

#

GitHub

PROpen Enhancing information within the incidents channel.

short snow Oct 17, 2021, 8:51 AM

#

or you would do it while merging

vocal wolf Oct 17, 2021, 8:51 AM

#

let me stare at diff for 2 seconds

short snow Oct 17, 2021, 8:51 AM

#

smol diff

vocal wolf Oct 17, 2021, 8:51 AM

#

verdict

#

do what you must

short snow Oct 17, 2021, 8:52 AM

#

nice verdict

vale ibex Oct 17, 2021, 8:52 AM

#

words of wisdom, as always

vocal wolf Oct 17, 2021, 8:52 AM

#

@vale ibex done

#

no what do you mean

green oriole Oct 17, 2021, 8:53 AM

#

My only answer will be

#

ducky_bike

vocal wolf Oct 17, 2021, 8:53 AM

#

mmmmmmmmmmmmmmm

#

I can't fukin english

short snow Oct 17, 2021, 8:54 AM

#

whats wrong with pycharm 🤦‍♂️

vocal wolf Oct 17, 2021, 8:55 AM

#

short snow whats wrong with pycharm 🤦‍♂️

It's written in Java

short snow Oct 17, 2021, 8:55 AM

#

lemon_unamused

vocal wolf Oct 17, 2021, 8:55 AM

#

lmao

short snow Oct 17, 2021, 8:56 AM

#

only that line has got these weird errors 🤦‍♂️

cold island Oct 17, 2021, 8:56 AM

#

@short snow why did you resolve https://github.com/python-discord/bot/pull/1446#discussion_r730295509 🤔

short snow Oct 17, 2021, 8:56 AM

#

Cause i am pushing that change right now

cold island Oct 17, 2021, 8:57 AM

#

We agreed to only resolve stuff when the changes are pushed :\

short snow Oct 17, 2021, 8:57 AM

#

Yeah 🤦‍♂️

hoary anvil Oct 17, 2021, 8:57 AM

#

@green oriole shouldn't it be either "That's all for now; feel free..." or "That's all for now. Feel free...", instead of "That's all for now, feel free..."?

short snow Oct 17, 2021, 8:57 AM

#

btw how do you squash all the commtis of a pr

cold island Oct 17, 2021, 8:58 AM

#

Don't squash now though

#

Will make reviewing a pain

vocal wolf Oct 17, 2021, 8:58 AM

#

which one we talking about

#

oh nvm

#

@vale ibex I've approved

short snow Oct 17, 2021, 8:58 AM

#

The diff is short so i thought it would be okay

vocal wolf Oct 17, 2021, 8:58 AM

#

forgot to ping before

cold island Oct 17, 2021, 8:58 AM

#

Better to squash before merging

green oriole Oct 17, 2021, 8:58 AM

#

@short snow https://www.notion.so/pythondiscord/Squashing-a-Pull-Request-191e8efa2fbb4d72840fd17ca37cf7fa

Python Discord on Notion

Squashing a Pull Request

This guide will explain how to remove some commits from a Pull Request (or any branch for that matter) in order to slim the PR.

short snow Oct 17, 2021, 8:59 AM

#

green oriole <@!736234578745884682> https://www.notion.so/pythondiscord/Squashing-a-Pull-Requ...

.bm

#

ty

vocal wolf Oct 17, 2021, 8:59 AM

#

alright

#

I'm putting that massive message on notion

vocal wolf Oct 17, 2021, 8:59 AM

#

vocal wolf All the merged stuff: Bot: <https://github.com/python-discord/bot/pull/1875> <h...

this one

#

but parsed

#

and sorted

hoary anvil Oct 17, 2021, 9:00 AM

#

@green oriole archived libraries are a pain, huh

#

yeah exactly

#

which is the precise reason it got archived lol

#

the poor lad

short snow Oct 17, 2021, 9:02 AM

#

vocal wolf It's written in Java

YOU ARE WRONG, it is because the left side of the := walrus operator has to be a NAME and can't be anything else

hoary anvil Oct 17, 2021, 9:02 AM

#

short snow YOU ARE WRONG, it is because the left side of the `:=` walrus operator has to be...

caps lock alert

short snow Oct 17, 2021, 9:02 AM

#

that was needed lol

brisk brook Oct 17, 2021, 9:04 AM

#

short snow bot#1446

I would usually prefer not to because it messes with the "Mark as viewed" stuff in GitHub. Usually it's fine to just squash when merging.

vocal wolf Oct 17, 2021, 9:09 AM

#

short snow YOU ARE WRONG, it is because the left side of the `:=` walrus operator has to be...

lmao

#

@vale ibex oh no don't say that

#

you said those words

#

"It should just work"

#

you've cursed us

short snow Oct 17, 2021, 9:13 AM

#

what the heck did just happen lemon_enraged

#

nice, thankyou very much

#

task test

#

git merge upstream/main and that happened

vocal wolf Oct 17, 2021, 9:14 AM

#

@vale ibex notion embed how

#

yeah I got it before

#

now it ain't there wack

short snow Oct 17, 2021, 9:15 AM

#

gimme a minute, i reset it to my branch, doing it again (correctly)

clever wraith Oct 17, 2021, 9:16 AM

#

Is there any tutorial for the 2.0 stuff?

#

i've found the docs for it, but that just describes the api

green oriole Oct 17, 2021, 9:16 AM

#

not that we know

#

gotta :rtfm:

vale ibex Oct 17, 2021, 9:17 AM

#

Yea, most of my learning was stumbling through the docs 😦

short snow Oct 17, 2021, 9:17 AM

#

I just go through the release diff

short snow Oct 17, 2021, 9:18 AM

#

short snow what the heck did just happen <:lemon_enraged:754441880074453073>

i did the exact same thing but it works now 👀 except did poetry install before to get the new dep updates

vocal wolf Oct 17, 2021, 9:21 AM

#

@vale ibex nooooo you can't say thaaaaaaaaaat

Also: My triage report is 1/3 done.

vale ibex Oct 17, 2021, 9:22 AM

#

I've forgotten the context already lol

vocal wolf Oct 17, 2021, 9:22 AM

#

"It should just work"

vale ibex Oct 17, 2021, 9:22 AM

#

ah 😄

vocal wolf Oct 17, 2021, 9:22 AM

#

If you tell me to worry I'm going to worry more

#

false

vale ibex Oct 17, 2021, 9:26 AM

#

False*

vocal wolf Oct 17, 2021, 9:26 AM

#

sorry I've been doing too much rust lately

vale ibex Oct 17, 2021, 9:26 AM

#

lol

vocal wolf Oct 17, 2021, 9:26 AM

#

I'm a bit rusty on python, if you will

vale ibex Oct 17, 2021, 9:26 AM

#

blasphemy

vocal wolf Oct 17, 2021, 9:28 AM

#

@green oriole oof

#

precommit

#

bottom is travis

#

precommit is an actual ci system what you mean

#

https://pre-commit.ci/

vale ibex Oct 17, 2021, 9:43 AM

#

!help tmute

stable mountainBOT Oct 17, 2021, 9:43 AM

#

Query "tmute" not found.

Did you mean:
mute
tempmute
unmute
time

vale ibex Oct 17, 2021, 9:43 AM

#

!help mute

stable mountainBOT Oct 17, 2021, 9:43 AM

#

Command Help

!tempmute <user> [duration] [reason]
Can also use: mute

*Temporarily mute a user for the given reason and duration.

A unit of time should be appended to the duration.
Units (∗case-sensitive):
y - years
m - months∗
w - weeks
d - days
h - hours
M - minutes∗
s - seconds

Alternatively, an ISO 8601 timestamp can be provided for the duration.

If no duration is given, a one hour duration is used by default.*

vale ibex Oct 17, 2021, 9:44 AM

#

!help eval

stable mountainBOT Oct 17, 2021, 9:44 AM

#

Command Help

!eval [code]
Can also use: e

*Run Python code and get the results.

This command supports multiple lines of code, including code wrapped inside a formatted code
block. Code can be re-evaluated by editing the original message within 10 seconds and
clicking the reaction that subsequently appears.

We've done our best to make this sandboxed, but do let us know if you manage to find an
issue with it!*

vale ibex Oct 17, 2021, 9:44 AM

#

before

#

!help mute

stable mountainBOT Oct 17, 2021, 9:48 AM

#

Command Help

!tempmute <user> [duration] [reason]
Can also use: mute

*Temporarily mute a user for the given reason and duration.

A unit of time should be appended to the duration. Units (∗case-sensitive):
y - years
m - months∗
w - weeks
d - days
h - hours
M - minutes∗
s - seconds

Alternatively, an ISO 8601 timestamp can be provided for the duration.

If no duration is given, a one hour duration is used by default.*

vale ibex Oct 17, 2021, 9:48 AM

#

!help eval

stable mountainBOT Oct 17, 2021, 9:48 AM

#

Command Help

!eval [code]
Can also use: e

*Run Python code and get the results.

This command supports multiple lines of code, including code wrapped inside a formatted code block. Code can be re-evaluated by editing the original message within 10 seconds and clicking the reaction that subsequently appears.

We've done our best to make this sandboxed, but do let us know if you manage to find an issue with it!*

vale ibex Oct 17, 2021, 9:48 AM

#

after

#

much better

short snow Oct 17, 2021, 9:51 AM

#

@cold island should be fixed now, was probably me resolving before I pushed the commit and then doing something. I Will keep that in mind now 👍

timid sentinel Oct 17, 2021, 9:52 AM

#

Since we're on a merging spree, bot#1795 and bot#1863 are there if anyone is looking for a review 😄

dusky shoreBOT Oct 17, 2021, 9:52 AM

#

GitHub

PROpen Fixed delayed logs and made some other minor refactors
PROpen Prevent repetitive stale inventory warnings from erroneously generated inventories

fervent sage Oct 17, 2021, 9:53 AM

#

timid sentinel Since we're on a merging spree, bot#1795 and bot#1863 are there if anyone is loo...

lmao

#

i just reviewed one without seeing this

#

amazing timing

timid sentinel Oct 17, 2021, 9:53 AM

#

lmao, perfect timing

#

also thanks

vocal wolf Oct 17, 2021, 9:54 AM

#

@timid sentinel squashing

timid sentinel Oct 17, 2021, 9:54 AM

#

👍

#

jumping in with the merge

fervent sage Oct 17, 2021, 9:56 AM

#

yo what http_session.get(doc_item.url, raise_for_status=True) i never knew that was a valid kwarg

#

nice

#

raises an exception for 4xx and 5xx status codes

vocal wolf Oct 17, 2021, 9:57 AM

#

oh my god

#

Sir lance has more PRs open than bot

#

impossible

#

yes

#

at this point I have no idea if that's a joke

#

or they were actually serious

fervent sage Oct 17, 2021, 9:58 AM

#

tell me you use discord too much without saying you use discord too much:

vocal wolf Oct 17, 2021, 9:58 AM

#

yeah

#

there's only one way

#

pog 2 cakes

#

jesus

#

12 PRs now

#

28 to 12 in a week

#

my god

fervent sage Oct 17, 2021, 10:02 AM

#

doesnt feel real does it

vocal wolf Oct 17, 2021, 10:02 AM

#

can we beat the record low of 11

fervent sage Oct 17, 2021, 10:03 AM

#

~~when you wake up from this dream xith you're gonna be so depressed~~

vocal wolf Oct 17, 2021, 10:03 AM

#

no I know this is real because I'm eating cereal at 3am

fervent sage Oct 17, 2021, 10:03 AM

#

oh

#

fair

timid sentinel Oct 17, 2021, 10:03 AM

#

I have no voice at the moment but hey @green oriole @vale ibex :D

fervent sage Oct 17, 2021, 10:03 AM

#

i miss eating cereal at 3am

#

how long until bot#1446 gets merged KEKW

dusky shoreBOT Oct 17, 2021, 10:03 AM

#

GitHub

PROpen Enhancing information within the incidents channel.

vocal wolf Oct 17, 2021, 10:03 AM

#

timid sentinel I have no voice at the moment but hey <@!407110650217627658> <@!1268115066322944...

pog no mic

short snow Oct 17, 2021, 10:04 AM

#

fervent sage how long until bot#1446 gets merged <:KEKW:826376132910907402>

should be soon now

vocal wolf Oct 17, 2021, 10:04 AM

#

fervent sage how long until bot#1446 gets merged <:KEKW:826376132910907402>

once things are resolved

short snow Oct 17, 2021, 10:04 AM

#

also someone review https://github.com/python-discord/sir-lancebot/pull/745

GitHub

Add logic for preserving unloaded Cogs. by Shivansh-007 · Pull Requ...

This PR makes a Redis cache in bot.bot to store all the unloaded extensions, on every unload and load this cache would be edited in the desired manner, either removing it from it or adding it in th...

green oriole Oct 17, 2021, 10:04 AM

#

https://github.com/redis/hiredis-py/pull/117

GitHub

Add support for Python 3.10 by Akarys42 · Pull Request #117 · redis...

From what I can see, this should add support for Python 3.10
Closes #116

short snow Oct 17, 2021, 10:04 AM

#

(i mentioned bluenix's reviews rn btw)

green oriole Oct 17, 2021, 10:04 AM

#

https://github.com/maxbachmann/RapidFuzz/issues/141

GitHub

[Feature Request] rapidfuzz wheel for python 3.10 · Issue #141 · ma...

Hi there, Since python 3.10 has been released officially now, I have moved few of my personal projects over to that version, which also makes use of rapidfuzz. From what I have tested, installing r...

cold moon Oct 17, 2021, 10:04 AM

#

Do we have Merge Sunday?

green oriole Oct 17, 2021, 10:05 AM

#

apparently haha

vale ibex Oct 17, 2021, 10:05 AM

#

Jus to give xith the minimum amount of time for his triage update 😄

cold moon Oct 17, 2021, 10:05 AM

#

~~Let's do this monthly~~

cold island Oct 17, 2021, 10:05 AM

#

short snow <@!512354988157173763> should be fixed now, was probably me resolving before I p...

Still no strip 🙃

fervent sage Oct 17, 2021, 10:05 AM

#

the meeting is just gonna be a triage update at this point

green oriole Oct 17, 2021, 10:05 AM

#

twiiter DM to pycares

brisk brook Oct 17, 2021, 10:05 AM

#

cold moon Do we have Merge Sunday?

This is when it all goes to shit

vocal wolf Oct 17, 2021, 10:06 AM

#

I do hope I wake up in time for the meeting

#

because it's currently 3am and the meeting is in like 8 hours

fervent sage Oct 17, 2021, 10:06 AM

#

go

#

bed

cold island Oct 17, 2021, 10:07 AM

#

vocal wolf I do hope I wake up in time for the meeting

go sleep bonk

fervent sage Oct 17, 2021, 10:07 AM

#

now

vocal wolf Oct 17, 2021, 10:07 AM

#

no I'm having fun

brisk brook Oct 17, 2021, 10:07 AM

#

green oriole https://github.com/maxbachmann/RapidFuzz/issues/141

Yeah btw can we review the tag groups PR before the staff meeting?

Literally have went through that code so many times I am going cross eyed. Just needs quite extensive testing but I haven't gotten to that lol

vocal wolf Oct 17, 2021, 10:07 AM

#

3:07am @green oriole