#dev-contrib | Python | Page 143

vale ibex Oct 12, 2021, 3:39 PM

#

or whatever the names are

#

The cog itself should then have some async init task to resolve the IDs to names for showing in the buttons themselves

#

that won't work, since you need to wait for the guild to be available

#

otherwise the role cache will be empty

#

yes

#

think it's something like bot.wait_until_guild_available()

#

yes, you can, which is why I suggested an async init task

#

no, you'd do something like this ```py

class Something(comamnds.Cog):
def init(self, bot):
self.bot = bot
utils.scheduling.create_task(init_cog(), self.bot.loop)

async def init_cog(self):
    await self.bot.wait_until_guild_available()
    ...

wind ruin Oct 12, 2021, 3:46 PM

#

You can add methods to make Tasks await until something before they run the first time, if you are actually using tasks and not just the entire cog

vale ibex Oct 12, 2021, 3:47 PM

#

Yea, we have a helper for that

#

updated the snippet

#

since this is an init task, there's no need to use d.py's task ext

wind ruin Oct 12, 2021, 3:48 PM

#

I mean like ```py
class MyCog(commands.Cog):

@tasks.loop(minutes=10)
async def new_comments(self):


@new_comments.before_loop
async def before_new_comments(self):
    await self.bot.db_loaded.wait()

wind ruin Oct 12, 2021, 3:48 PM

#

vale ibex no, you'd do something like this ```py class Something(comamnds.Cog): def _...

but yeah, that works

thorny obsidian Oct 12, 2021, 3:49 PM

#

@vale ibex while you're here, what are your thoughts on the feasibility of having this cover some of Sir Lance's roles? Too much effort to be worth it?

green oriole Oct 12, 2021, 3:49 PM

#

So like lovefest and all?

vale ibex Oct 12, 2021, 3:49 PM

#

it wouldn't be too bad, we'd need to implement a similar month gate

green oriole Oct 12, 2021, 3:50 PM

#

Okay, another idea

#

Can we make a static message with permanent buttons?

vale ibex Oct 12, 2021, 3:50 PM

#

this could also have the month number in it, then in the init it checks the current month and only adds those that match, or without a month number

patent pivot Oct 12, 2021, 3:50 PM

#

on this note: would rather keep it almost solely role IDs, and if we implement date gating then that as well, names should be picked up from the cache since we'll use different colored buttons and emotes to signify if the user currently has a role

#

no need for descriptions

patent pivot Oct 12, 2021, 3:51 PM

#

green oriole Can we make a static message with permanent buttons?

that is a possibility, yes, it's just a bit harder to maintain and a bit weirder to integrate into the library

green oriole Oct 12, 2021, 3:51 PM

#

I see. My idea was to have a message in #roles about it

thorny obsidian Oct 12, 2021, 3:52 PM

#

I think I'd rather keep as much compatibility with the current !subscribe as we can for the first iteration of this

#

So we still direct people to run this command for themselves

#

Otherwise that's a lot of messages in a lot of places we have to change

green oriole Oct 12, 2021, 3:53 PM

#

Well, we could add a tag saying we moved it, like we have

#

!free

#

Okay, we apparently removed it haha

short snow Oct 12, 2021, 4:18 PM

#

what about description of the role?

#

oh joe said that

vale ibex Oct 12, 2021, 4:45 PM

#

Yea, no need for a description, we're just using buttons so want the text to be relatively small. The name should be descriptive enough

stable mountainBOT Oct 12, 2021, 5:23 PM

#

It has arrived!

Here's your reminder: that
[Jump back to when you created the reminder](#dev-contrib message)

austere hornet Oct 12, 2021, 6:38 PM

#

stable mountain

!remind 2H still in school smh

stable mountainBOT Oct 12, 2021, 6:38 PM

#

No problem.

Your reminder will arrive on <t:1634071083:F>!

austere hornet Oct 12, 2021, 7:16 PM

#

!remind delete 3266

stable mountainBOT Oct 12, 2021, 7:16 PM

#

Okay.

That reminder has been deleted successfully!

austere hornet Oct 12, 2021, 7:18 PM

#

@green oriole So I ran the pre-commit command but lint is still failing and I can't figure out why

#

It's actually flake8 that's failing

trail pilot Oct 12, 2021, 7:22 PM

#

Those are PEP8 guidelines

austere hornet Oct 12, 2021, 7:23 PM

#

trail pilot Those are PEP8 guidelines

Yeah, I understand

#

But I still can't seem to understand what in the guidelines I am still "breaking" so to speak

fallen patrol Oct 12, 2021, 7:24 PM

#

you have a syntax error on line 62

#

that needs to be fixed before the rest of them can be fixed

#

since as of now, the code literally will not work

austere hornet Oct 12, 2021, 7:24 PM

#

fallen patrol that needs to be fixed before the rest of them can be fixed

True

trail pilot Oct 12, 2021, 7:24 PM

#

On the right hand side it should let you know what to fix. I.e on line 84, you’ll want to continue the line to the next one so it isn’t breaking the PEP8 guideline on line lengths

fallen patrol Oct 12, 2021, 7:25 PM

#

and you can't have mixed tabs and spaces

#

what IDE are you using?

austere hornet Oct 12, 2021, 7:25 PM

#

fallen patrol what IDE are you using?

Sublime Text

fallen patrol Oct 12, 2021, 7:25 PM

#

patent pivot on this note: would rather keep it almost solely role IDs, and if we implement d...

what about changing it entirely and instead of a command, a permanent message in #roles?

austere hornet Oct 12, 2021, 7:25 PM

#

fallen patrol and you can't have mixed tabs and spaces

Yeah ik

austere hornet Oct 12, 2021, 7:26 PM

#

fallen patrol you have a syntax error on line 62

What is the syntax error on line 62? The brackets? Btw I'm working on sir-lancebot#901

dusky shoreBOT Oct 12, 2021, 7:26 PM

#

GitHub

PRDraft Madlibs

fallen patrol Oct 12, 2021, 7:27 PM

#

filtered_blanks = [if min_length < len(random_template["blanks"]) < max_length]

#

what is this trying to do?

fallen patrol Oct 12, 2021, 7:28 PM

#

austere hornet Sublime Text

https://www.sublimetext.com/docs/indentation.html#basic_settings

austere hornet Oct 12, 2021, 7:28 PM

#

I understand it's a syntax error, I don't understand where though

austere hornet Oct 12, 2021, 7:28 PM

#

fallen patrol https://www.sublimetext.com/docs/indentation.html#basic_settings

Thanks

#

I actually already had that same website open @fallen patrol 😆

fallen patrol Oct 12, 2021, 7:30 PM

#

austere hornet I understand it's a syntax error, I don't understand where though

what are you trying to do in that line

austere hornet Oct 12, 2021, 7:32 PM

#

fallen patrol what are you trying to do in that line

I want the user playing the game to be able to enter a range of numbers between 5 and 15 blanks (inputs) so that the bot chooses a random story from the JSON file based on what the user entered.
Ex: .madlibs 7 10

#

Does that make sense?

fallen patrol Oct 12, 2021, 7:33 PM

#

austere hornet What is the syntax error on line 62? The brackets? Btw I'm working on sir-lanceb...

no, what is line 62 trying to do?

thorny obsidian Oct 12, 2021, 7:34 PM

#

fallen patrol what about changing it entirely and instead of a command, a permanent message in...

See my message below for concerns with that

austere hornet Oct 12, 2021, 7:34 PM

#

fallen patrol no, what is line 62 trying to do?

Wait hold up

#

I think I know what I did wrong

fallen patrol Oct 12, 2021, 7:35 PM

#

thorny obsidian See my message below for concerns with that

below what....

austere hornet Oct 12, 2021, 7:35 PM

#

random_template isn't defined

thorny obsidian Oct 12, 2021, 7:35 PM

#

Below the message you replied to

vale ibex Oct 12, 2021, 7:35 PM

#

Just stubbing out the button command, is there already a pyweek role Kat?

#

I can't see one, but not sure if I'm blind 😂

thorny obsidian Oct 12, 2021, 7:35 PM

#

vale ibex Just stubbing out the button command, is there already a pyweek role Kat?

Nope, not yet

vale ibex Oct 12, 2021, 7:35 PM

#

Alr, I'll make one

#

preference on name?

#

PyWeek Announcements?

thorny obsidian Oct 12, 2021, 7:36 PM

#

Yeah, don't want to limit it to participants

vale ibex Oct 12, 2021, 7:36 PM

#

👍

#

<@&897568414044938310>

fallen patrol Oct 12, 2021, 7:37 PM

#

thorny obsidian See my message below for concerns with that

see the message akarys sent for my response

thorny obsidian Oct 12, 2021, 7:38 PM

#

Yeah I'd still prefer to keep it is as a command you run instead of a permanent message

#

Even if we have the subscribe redirect it's still subpar UX for not a lot of benefit

#

Dang @vale ibex that's lightning fast

fallen patrol Oct 12, 2021, 7:41 PM

#

vale ibex <@&897568414044938310>

ping!

vale ibex Oct 12, 2021, 7:41 PM

#

thorny obsidian Dang <@126811506632294400> that's lightning fast

It's not done just yet, still stubbed out

#

just wanted to push before I closed it for the night

#

Just need to define button behaviour and then add buttons to a view

fallen patrol Oct 12, 2021, 7:44 PM

#

reviewed

austere hornet Oct 12, 2021, 7:47 PM

#

austere hornet `random_template` isn't defined

Actually I was wrong about that @fallen patrol

#

I fixed it and it's still saying syntax error

#

This is what I did

gritty wind Oct 12, 2021, 7:50 PM

#

Your syntax error is that if

#

If you want an if on one line, you can use a ternary, but from my limited understanding of your code you're just using it to convert to bool right?

#

Use bool()

#

!e [if 1 == 1]

stable mountainBOT Oct 12, 2021, 7:51 PM

#

@gritty wind :x: Your eval job has completed with return code 1.

001 |   File "<string>", line 1
002 |     [if 1 == 1]
003 |      ^^
004 | SyntaxError: invalid syntax

gritty wind Oct 12, 2021, 7:51 PM

#

vs

#

!e [bool(1 == 1)]

stable mountainBOT Oct 12, 2021, 7:51 PM

#

@gritty wind :warning: Your eval job has completed with return code 0.

[No output]

austere hornet Oct 12, 2021, 7:51 PM

#

Ah

gritty wind Oct 12, 2021, 7:51 PM

#

obviously tho, 1 == 1 is already a bool

austere hornet Oct 12, 2021, 7:51 PM

#

Ok

gritty wind Oct 12, 2021, 7:51 PM

#

so no real need for calling bool there, or the if

austere hornet Oct 12, 2021, 7:52 PM

#

Ok, got it, thanks Scale!

austere hornet Oct 12, 2021, 8:34 PM

#

Does anyone know what this means? f-string is missing placeholders

#

line 51

vale ibex Oct 12, 2021, 8:34 PM

#

you're using a f string but it doesn't have any {var_name} in it

#

so there's no need for it to be an f string

austere hornet Oct 12, 2021, 8:35 PM

#

vale ibex so there's no need for it to be an f string

Ah, ok, got it, thanks!

vale ibex Oct 12, 2021, 10:15 PM

#

bot#1868 is actually ready for review now if anyone was interested

dusky shoreBOT Oct 12, 2021, 10:15 PM

#

GitHub

PRDraft Subscribe with buttons

vale ibex Oct 12, 2021, 10:16 PM

#

going to leave it as draft since it's based on top of another PR

fallen patrol Oct 12, 2021, 10:22 PM

#

vale ibex bot#1868 is actually ready for review now if anyone was interested

ready for review now
oops...

vale ibex Oct 12, 2021, 10:23 PM

#

fallen patrol > ready for review now oops...

?

fallen patrol Oct 12, 2021, 10:23 PM

#

since i reviewed it earlier lol

vale ibex Oct 12, 2021, 10:23 PM

#

ah

vale ibex Oct 12, 2021, 10:39 PM

#

ah lol sorry @fallen patrol didn't realise it kicks you out

fallen patrol Oct 12, 2021, 10:57 PM

#

vale ibex ah lol sorry <@!717983911824588862> didn't realise it kicks you out

ye its pretty annoying, since your edit didn't even touch where i was ;-;

gritty wind Oct 12, 2021, 11:00 PM

#

I personally like automatic dismissal, because it ensures things don’t sneak by, which I’ve had done to me

#

Just because I approved what you had before you changed it, doesn’t mean I’ll approve it after

vale ibex Oct 12, 2021, 11:04 PM

#

Yea I like auto dismissal too, but this was me kicking arl out of a review by pushing changes

fallen patrol Oct 12, 2021, 11:04 PM

#

yeah

#

i did it to bast earlier ;-;

gritty wind Oct 12, 2021, 11:07 PM

#

Ahh

#

Yeah that’s uh

#

Questionable 😅

fallen patrol Oct 12, 2021, 11:12 PM

#

gritty wind Questionable 😅

its poor design on github's part

#

the fact that a partial review can't be added to once a new commit is pushed doesn't make much sense

clever wraith Oct 13, 2021, 1:05 AM

#

hey all

#

for cowsay

#

i was wondering how i should give the available cows to a user

#

oh

#

nvm

clever wraith Oct 13, 2021, 2:12 AM

#

hey @vocal wolf, the module im using for cowsay doesnt have a license listed in the meta info on pypi, what do i do? this forces the checks to fail

vocal wolf Oct 13, 2021, 2:23 AM

#

clever wraith hey <@!196664644113268736>, the module im using for cowsay doesnt have a license...

https://github.com/jeffbuttars/cowpy/blob/master/LICENSE

clever wraith Oct 13, 2021, 2:23 AM

#

yeah the license is apache

vocal wolf Oct 13, 2021, 2:23 AM

#

oh sorry I thought you were searching for the license

#

welllllll

#

maybe find an alternative?

fallen patrol Oct 13, 2021, 2:34 AM

#

vocal wolf maybe find an alternative?

the license is compatiable with the project

#

it could be ignored

vocal wolf Oct 13, 2021, 2:34 AM

#

is it? I thought we're only accepting MIT

#

let me take another look

fallen patrol Oct 13, 2021, 2:34 AM

#

!src

stable mountainBOT Oct 13, 2021, 2:34 AM

#

Bot's GitHub Repository

Repository

Go to GitHub

fallen patrol Oct 13, 2021, 2:35 AM

#

https://github.com/python-discord/bot/blob/06e90af5e19d9dd83ae44ac2ae0eb3eeb43349e2/.github/workflows/lint-test.yml#L19-L26

stable mountainBOT Oct 13, 2021, 2:35 AM

#

.github/workflows/lint-test.yml lines 19 to 26

ALLOWED_LICENSE: Apache Software License;
  BSD License;
  GNU Library or Lesser General Public License (LGPL);
  ISC License (ISCL);
  MIT License;
  Mozilla Public License 2.0 (MPL 2.0);
  Public Domain;
  Python Software Foundation License```

vocal wolf Oct 13, 2021, 2:35 AM

#

yeah

#

hmmm

fallen patrol Oct 13, 2021, 2:35 AM

#

first one is apache

#

wait

#

cowsay

#

.src

#

i hate u lance

#

k

#

https://github.com/python-discord/sir-lancebot/blob/0b4751d30dc4902211a7ddb62392039466bbbc35/.github/workflows/lint.yaml#L20-L28

stable mountainBOT Oct 13, 2021, 2:36 AM

#

.github/workflows/lint.yaml lines 20 to 28

ALLOWED_LICENSES: Apache Software License;
  BSD;  BSD License;
  GNU Library or Lesser General Public License (LGPL);
  Historical Permission Notice and Disclaimer (HPND);
  ISC License (ISCL);
  MIT License;
  Mozilla Public License 2.0 (MPL 2.0);
  Public Domain;
  Python Software Foundation License```

fallen patrol Oct 13, 2021, 2:36 AM

#

https://github.com/python-discord/sir-lancebot/actions/runs/1335560443

GitHub

feat: added cowsay · python-discord/sir-lancebot@4f53b94

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - feat: added co...

#

!pypi pip-licenses

stable mountainBOT Oct 13, 2021, 2:37 AM

#

pip-licenses v3.5.3

Dump the software license list of Python packages installed with pip.

fallen patrol Oct 13, 2021, 2:37 AM

#

--ignore-packages

vocal wolf Oct 13, 2021, 2:37 AM

#

Apache Software License != Apache License maybe?

fallen patrol Oct 13, 2021, 2:38 AM

#

fallen patrol https://github.com/python-discord/sir-lancebot/actions/runs/1335560443

this is the run

#

this is the problem #dev-contrib message

#

it isn't listed whatsoever

#

pft

#

brb

vocal wolf Oct 13, 2021, 2:40 AM

#

https://github.com/jeffbuttars/cowpy/issues/16

GitHub

Upload `LICENSE` to PyPi. · Issue #16 · jeffbuttars/cowpy

Would you mind uploading the license markdown file to PyPi? Thanks!

#

maybe this will work lol

fallen patrol Oct 13, 2021, 2:43 AM

#

yeah

#

I just noticed something that I do not like about pip-licenses lol

#

brb

fallen patrol Oct 13, 2021, 2:59 AM

#

ah

#

that's why

#

raimon49/pip-licenses#108

dusky shoreBOT Oct 13, 2021, 2:59 AM

#

GitHub

IssueOpen allow to check from requirements.txt file without installing

fallen patrol Oct 13, 2021, 2:59 AM

#

reason why its not added: pip saves the license data when a package is installed.

short snow Oct 13, 2021, 3:24 AM

#

vocal wolf maybe this will work lol

won't, the package is dead 😔

vocal wolf Oct 13, 2021, 3:34 AM

#

short snow *won't*, the package is dead 😔

The maintainer is still an active user, so we have hope.

clever wraith Oct 13, 2021, 3:41 AM

#

@vocal wolf if all else fails i can fork and add the license

#

but imma head to bed tonight, bye all

short snow Oct 13, 2021, 3:50 AM

#

vocal wolf The maintainer is still an active user, so we have hope.

ah yeah, or we could just ignore the package for the time being if they don't respond.

clever wraith Oct 13, 2021, 3:31 PM

#

@vocal wolf another option would be to allow the UNKNOWN license if they don't respond

green oriole Oct 13, 2021, 3:35 PM

#

clever wraith <@196664644113268736> another option would be to allow the UNKNOWN license if th...

What's the context?

clever wraith Oct 13, 2021, 3:36 PM

#

clever wraith hey <@!196664644113268736>, the module im using for cowsay doesnt have a license...

@green oriole start from here

green oriole Oct 13, 2021, 3:37 PM

#

The workflow isn't detecting the license correctly?

gritty wind Oct 13, 2021, 4:12 PM

#

I don’t particularly like that solution, and would prefer an explicit ignore for any libraries that are unknown

clever wraith Oct 13, 2021, 4:15 PM

#

green oriole The workflow isn't detecting the license correctly?

No the guy didn't specify the license in pypi

molten perch Oct 13, 2021, 4:18 PM

#

Hey! Can I have some opinions on api#22? 🙂

dusky shoreBOT Oct 13, 2021, 4:18 PM

#

GitHub

IssueOpen Migrate reminders endpoint from the site API

short snow Oct 13, 2021, 4:19 PM

#

"a PR should come up anytime now" -- you are working on it?

#

Okay cool! Also i reviewed your PR

#

and you got a poetry.lock conflict 🙃

molten perch Oct 13, 2021, 4:24 PM

#

Yeah, because my model PR was merged a few days after that PR had been opened.

thorny obsidian Oct 13, 2021, 4:51 PM

#

but...but... @vale ibex how will I spam buttons now 🥺

vale ibex Oct 13, 2021, 4:52 PM

#

you can still spam buttons lol

#

you can only spawn the buttons every 10s

thorny obsidian Oct 13, 2021, 5:11 PM

#

so what docker containers do you have running and what's the status of them?

placid ermine Oct 13, 2021, 5:11 PM

#

how do you use snekbox again
i ran

❯ docker run --ipc=none --privileged -p 8060:8060 ghcr.io/python-discord/snekbox

and then

requests.post(r"https://localhost:8060/eval", json={"input": "print('test')"})

but that just gives me a huge error https://paste.pythondiscord.com/egejevozer.py
logs: https://paste.pythondiscord.com/juhalobani.apache

tawdry vapor Oct 13, 2021, 5:12 PM

#

Use http instead of https

vale ibex Oct 13, 2021, 5:12 PM

#

thorny obsidian so what docker containers do you have running and what's the status of them?

me?

thorny obsidian Oct 13, 2021, 5:13 PM

#

vale ibex me?

lol no, was beating hsp to posting his message

vale ibex Oct 13, 2021, 5:13 PM

#

oh lol

placid ermine Oct 13, 2021, 5:15 PM

#

tawdry vapor Use http instead of https

ahh thanks

green oriole Oct 13, 2021, 5:18 PM

#

Or self sign certs lol

fallen patrol Oct 13, 2021, 5:19 PM

#

...and i just got distracted and closed a tab with a review

vale ibex Oct 13, 2021, 5:26 PM

#

github saves inprogress reviews

#

so if you open the review again it should still be there

brisk brook Oct 13, 2021, 5:43 PM

#

Do you guys get email notifications from GitHub?

#

I am not sure if I want to turn it off 🤔

#

They're all marked as Important which is a bit :/

dim pelican Oct 13, 2021, 5:45 PM

#

I do, I tried to make a rule that labels them and moves them to a special folder but it has not quite worked out the way I thought it would in gmail

#

In outlook it would be easy

vale ibex Oct 13, 2021, 5:45 PM

#

works fine for me

thorny obsidian Oct 13, 2021, 5:47 PM

#

I have all emails off from github except if something I pushed failed a workflow

#

The important stuff is already posted to other channels and places that I check daily, so the email is just extra clutter imo

brisk brook Oct 13, 2021, 5:48 PM

#

vale ibex works fine for me

Ah, where is this setup?

dim pelican Oct 13, 2021, 5:49 PM

#

In settings, see all settings, then Filters tab

austere hornet Oct 13, 2021, 5:49 PM

#

fallen patrol ...and i just got distracted and closed a tab with a review

Oof, hate when that happens

vocal wolf Oct 13, 2021, 6:27 PM

#

@clever wraith they responded. License now exists in PyPi: https://pypi.org/project/cowpy/

#

https://github.com/jeffbuttars/cowpy/issues/16

clever wraith Oct 13, 2021, 6:28 PM

#

Ty xith

vocal wolf Oct 13, 2021, 6:28 PM

#

np

#

re-running the workflow on the PR now

#

hmm

#

still failed

#

ah

#

@clever wraith I think you need to update cowpy to 1.1.1

gritty wind Oct 13, 2021, 6:33 PM

#

This is why I dislike non-exact requirements, it's unclear when you need to relock, or when something significant changes smh

vale ibex Oct 13, 2021, 6:36 PM

#

vocal wolf <https://github.com/jeffbuttars/cowpy/issues/16>

uhhh, that repo now has 2 licenses

vocal wolf Oct 13, 2021, 6:36 PM

#

yeah they have the one in the repo and the one in pypi

vale ibex Oct 13, 2021, 6:36 PM

#

An Apache 2.0 added 6 years ago, and an MIT one added jsut now

vocal wolf Oct 13, 2021, 6:36 PM

#

apache and mit

#

lol

vale ibex Oct 13, 2021, 6:36 PM

#

the repo itself has 2

vocal wolf Oct 13, 2021, 6:36 PM

#

interesting

clever wraith Oct 13, 2021, 6:38 PM

#

vocal wolf <@456226577798135808> I think you need to update cowpy to `1.1.1`

On it

vale ibex Oct 13, 2021, 6:39 PM

#

I've commented on that issue anyway

#

hopefully they'll remove the incorrect license

#

and hopefully the incorrect one isn't the MIT one lol

clever wraith Oct 13, 2021, 6:41 PM

#

Funky

#

So

#

Poetry is being picky and saying that cowpy v1.1.1 doesn't exist

#

Bad poetry

vocal wolf Oct 13, 2021, 6:42 PM

#

vale ibex Oct 13, 2021, 6:42 PM

#

It just let me add it fine locally

#

are you typing literally v1.1.1?

#

it needs to be just 1.1.1

clever wraith Oct 13, 2021, 6:43 PM

#

I know

#

thorny obsidian Oct 13, 2021, 6:43 PM

#

Chris, how difficult is it to use the Discord button components?

vale ibex Oct 13, 2021, 6:44 PM

#

thorny obsidian Chris, how difficult is it to use the Discord button components?

in what way?

clever wraith Oct 13, 2021, 6:44 PM

#

I'm removing and re-adding

#

Should maybe work

thorny obsidian Oct 13, 2021, 6:44 PM

#

I'm thinking of speccing out the Python Trivia night stuff and like... how to do that

clever wraith Oct 13, 2021, 6:44 PM

#

There we go

#

That worked

thorny obsidian Oct 13, 2021, 6:45 PM

#

So I guess my question is sort of batching time blocks where I look at which buttons are pressed

#

So like, for the next 5 minutes I will look at which buttons are pressed and make it count towards X. 10 minutes later I do the same thing but it counts towards Y because it's a different question.

vale ibex Oct 13, 2021, 6:45 PM

#

I'd make each question have a different message with answers

#

rather than reusing buttons

clever wraith Oct 13, 2021, 6:46 PM

#

Well fuck

thorny obsidian Oct 13, 2021, 6:46 PM

#

soooo something like
.trivia 2 would start question 2, spit out the question and spawn the buttons with the associated answers?

vale ibex Oct 13, 2021, 6:46 PM

#

that way you can do ```py
message = await ctx.send("answer:" view=answers_view)
bot.utils.scheduling.create_task(disable_later(message), self.bot.loop)

#

yea

#

after you send the question, create a task to disable the buttons after a defined time

thorny obsidian Oct 13, 2021, 6:47 PM

#

okay that makes sense. You can just like... spawn a button view to do that, right?

clever wraith Oct 13, 2021, 6:47 PM

#

Check failed again

vale ibex Oct 13, 2021, 6:47 PM

#

yea, you'd define a view with the data you need to store, then define the model of a single button

clever wraith Oct 13, 2021, 6:47 PM

#

Checked pypi API, license is listed

thorny obsidian Oct 13, 2021, 6:48 PM

#

Okay, cool cool

vale ibex Oct 13, 2021, 6:48 PM

#

then each command will create a view with a set of buttons

clever wraith Oct 13, 2021, 6:48 PM

#

Updated and locked for 1.1.1

thorny obsidian Oct 13, 2021, 6:48 PM

#

Time to scope out how to load in questions and do the answer reveal thing

vale ibex Oct 13, 2021, 6:48 PM

#

yeaa 😄

#

I'd suggest a list of dicts

#

to store the emssage and answers

#

along with the correct answer

#

then you can use the index to refer to the question itself

thorny obsidian Oct 13, 2021, 6:49 PM

#

Yeah, I think I'm going to expect the question/answers to be in json format, we can load it in behind the scenes so we never have to commit the questions

vale ibex Oct 13, 2021, 6:49 PM

#

nicenice

thorny obsidian Oct 13, 2021, 6:51 PM

#

Okay, a few questions:

Can buttons be like... specific to users? So it shows the buttons to everyone, when user A clicks a button it disappears/locks out the buttons but only for user A. User B can still press the buttons.
Can you only schedule the buttons to disappear? Can you send a command to force it closed/gone?
You can tell who pressed the button right? I feel like that's a given "duh" but wanted to make sure

clever wraith Oct 13, 2021, 6:52 PM

#

@vocal wolf I found the license problem

#

The license for cowpy is in LICENSE.md, not LICENSE so pip- licenses doesn't find it

vale ibex Oct 13, 2021, 6:54 PM

#

No, but this could give users the opportunity to change their answer before the time runs out
You could use a command, it would significantly simplify the implementation if we enforce that only 1 question is active at a time, that we we can just store a reference to that message as a self attr, and then just disable the stored one on command
Yes

#

Actually, for 1, we could make it so that after the first interaction, further interactions for that user fail with an ephemeral message

#

but we can't have buttons look different for different users

thorny obsidian Oct 13, 2021, 6:58 PM

#

okay, but we can do like a "you can't keep changing your answer" type of thing

clever wraith Oct 13, 2021, 7:00 PM

#

Also, the license isn't listed in metadata

#

So

#

I committed some metadata gore to get it working locally

fallen patrol Oct 13, 2021, 7:00 PM

#

would be easier to make a whitelist of packages

#

and then pin the version in requirements in case the license changes in the future

vale ibex Oct 13, 2021, 7:01 PM

#

thorny obsidian okay, but we can do like a "you can't keep changing your answer" type of thing

yea, you can. could even have it so that the user has X opportunities to change their answer, and output the remaining retries

clever wraith Oct 13, 2021, 7:01 PM

#

It looks like he used poetry to upload the package and he doesn't list the license there

#

So I found the problem

gritty wind Oct 13, 2021, 7:04 PM

#

fallen patrol would be easier to make a whitelist of packages

I don’t see how that would work. We technically already have a whitelist - known as our lockfike - but the workflow is there to stop us from missing deps

#

Which has happened/almost happened before

#

Anyways, since they are willing to fix things, and quickly, I say we get everything fixed upstream then worry about it

vale ibex Oct 13, 2021, 7:57 PM

#

oh lol

#

oSo I updated the channel IDs to the new values

#

but still getting the error from lance

#

turns out we overwrite them with env vars in prod

#

arthur deployments redeploy sir-lancebot

radiant merlinBOT Oct 13, 2021, 7:59 PM

#

:white_check_mark: Restarted deployment sir-lancebot in namespace default.

vale ibex Oct 13, 2021, 8:00 PM

#

deleted the env vars and rebooted, all is well now

vocal wolf Oct 13, 2021, 8:02 PM

#

all is well

#

all is good

molten perch Oct 13, 2021, 8:05 PM

#

About Advent of Code.. could someone take a look at sir-lancebot#857? 😄

dusky shoreBOT Oct 13, 2021, 8:05 PM

#

GitHub

PROpen Add support to query AoC results in respect of days and stars

trail pilot Oct 13, 2021, 8:22 PM

#

Could someone also take a look at:
sir-lancebot#860?

dusky shoreBOT Oct 13, 2021, 8:22 PM

#

GitHub

PROpen Challenges

trail pilot Oct 13, 2021, 8:23 PM

#

very close to a merge

#

just one more core dev approval

vocal wolf Oct 13, 2021, 8:23 PM

#

117 commits holy crap

trail pilot Oct 13, 2021, 8:23 PM

#

vocal wolf 117 commits holy crap

Haha yeah

#

There was a lot of great feedback

#

Oh shoot should I have grouped them in better

vocal wolf Oct 13, 2021, 8:25 PM

#

I shall test this PR

trail pilot Oct 13, 2021, 8:25 PM

#

vocal wolf I shall test this PR

Sounds great, thank you so much :D

vocal wolf Oct 13, 2021, 8:26 PM

#

man I haven't used poetry for a while lol

#

almost forgot how to use it

#

lmao

trail pilot Oct 13, 2021, 8:27 PM

#

OH also while you're here Xith, this is a bit off topic but how good is CLion for Rust? I think i've seen you use it for rust but i'm not too sure

vocal wolf Oct 13, 2021, 8:27 PM

#

CLion servers for Rust are really bad sometimes. I'd suggest vscode instead with the rust-analyzer extension.

trail pilot Oct 13, 2021, 8:28 PM

#

Ah alright

vocal wolf Oct 13, 2021, 8:31 PM

#

@trail pilot I haven't worked with the new discord ui before. If a user interacts with the dropdown menu, does it only show the changes on their side?

#

Or does everyone see the new embed?

trail pilot Oct 13, 2021, 8:31 PM

#

vocal wolf Or does everyone see the new embed?

everyone sees it

vocal wolf Oct 13, 2021, 8:31 PM

#

hmmm

trail pilot Oct 13, 2021, 8:31 PM

#

I wonder if I could just only allow the author to change it

vocal wolf Oct 13, 2021, 8:31 PM

#

yeah

trail pilot Oct 13, 2021, 8:31 PM

#

Alright that sounds good, I'll commit that rn

vocal wolf Oct 13, 2021, 8:31 PM

#

wait

#

but at the same time, what if others want to see information?

trail pilot Oct 13, 2021, 8:31 PM

#

Hm

vocal wolf Oct 13, 2021, 8:32 PM

#

I think we should leave it like this for now and see if we need to change it in the future

trail pilot Oct 13, 2021, 8:32 PM

#

vocal wolf I think we should leave it like this for now and see if we need to change it in ...

Alright that sounds good

#

was there anything off putting you noticed with the command

vocal wolf Oct 13, 2021, 8:32 PM

#

still testing, that's what I just saw right off the bat

#

I really do like these buttons though

trail pilot Oct 13, 2021, 8:33 PM

#

vocal wolf I really do like these buttons though

Thank you!

vocal wolf Oct 13, 2021, 8:33 PM

#

In general, that is, but also here. Good idea to use a dropdown.

#

Buttons being a feature in Discord is neat

trail pilot Oct 13, 2021, 8:34 PM

#

vocal wolf Buttons being a feature in Discord is neat

Yeah I agree, I like the new Discord UI and the gates it opens up

vocal wolf Oct 13, 2021, 8:34 PM

#

yep

trail pilot Oct 13, 2021, 8:35 PM

#

vocal wolf yep

I wonder if the tic tac toe could be refacotre wiht button

vocal wolf Oct 13, 2021, 8:35 PM

#

someone in my old cs club did that on the day of discord.js getting button functionality

#

it was very quick lol

vocal prairie Oct 13, 2021, 8:36 PM

#

trail pilot I wonder if the tic tac toe could be refacotre wiht button

That would be really really nice, reactions are way more complicated than just arranging the buttons in a tic tac toe format

vocal wolf Oct 13, 2021, 8:37 PM

#

@trail pilot For the languages embed, should we have a maximum height for amount of languages?

brisk brook Oct 13, 2021, 8:38 PM

#

I would like if I could run the command for someone

trail pilot Oct 13, 2021, 8:39 PM

#

vocal wolf <@!584817706646110333> For the languages embed, should we have a maximum height ...

Idts, because it will never go over the limit from my testing honestly

brisk brook Oct 13, 2021, 8:39 PM

#

Still, only I should be able to change it. But hiding it seems to defeat a bit of the purpose and limits the uses

trail pilot Oct 13, 2021, 8:39 PM

#

And language names are fairly shor

vocal wolf Oct 13, 2021, 8:39 PM

#

Yeah I'm not worried about width, just about height.

trail pilot Oct 13, 2021, 8:41 PM

#

vocal wolf Yeah I'm not worried about width, just about height.

in my testing, i got at most 20 languages which never exceeded the limit

#

descriptions have a 1024 character limit

vocal wolf Oct 13, 2021, 8:41 PM

#

but at the same time, the main description embed is sometimes large

trail pilot Oct 13, 2021, 8:42 PM

#

vocal wolf but at the same time, the main description embed is sometimes large

That's true, however I don't think it'll be used in general so it won't be too much of a worry about flooding

vocal wolf Oct 13, 2021, 8:42 PM

#

right

trail pilot Oct 13, 2021, 8:50 PM

#

vocal wolf right

anything else you've noticed while testing?

vocal wolf Oct 13, 2021, 8:50 PM

#

nope, just going through the code now

green oriole Oct 13, 2021, 8:51 PM

#

You do a functional test before doing a code review xith?

trail pilot Oct 13, 2021, 8:57 PM

#

vocal wolf nope, just going through the code now

ah alright

vocal wolf Oct 13, 2021, 8:57 PM

#

green oriole You do a functional test before doing a code review xith?

ye

green oriole Oct 13, 2021, 8:57 PM

#

Interesting, I like to do the opposite

vocal wolf Oct 13, 2021, 8:58 PM

#

To see what can be improved about the UI and if I run into any errors so I can include that in the code review/discussion

thorny obsidian Oct 13, 2021, 8:59 PM

#

Yeah, I always prefer testing the thing before the code review

clever wraith Oct 13, 2021, 8:59 PM

#

hey all, regarding sir-lancebot#902, it looks like it'll need whitelisting. The license isn't listed in metadata even though it appears to be on the pypi page

dusky shoreBOT Oct 13, 2021, 8:59 PM

#

GitHub

PROpen feat: added cowsay

vale ibex Oct 13, 2021, 9:00 PM

#

we need to wait for that to be fixed upstream

#

we can't merge in something with an unknown license

clever wraith Oct 13, 2021, 9:03 PM

#

alright

#

but, the package is dead

#

we already know the license

vocal wolf Oct 13, 2021, 9:03 PM

#

wdym the package is dead?

#

the author updated it a couple hours ago

clever wraith Oct 13, 2021, 9:03 PM

#

or well, inactive

vale ibex Oct 13, 2021, 9:03 PM

#

We don't though, since there are two licenses in the repo

#

once that is compatible with our project, and one that isn't

clever wraith Oct 13, 2021, 9:04 PM

#

are they not both compatible though?

vale ibex Oct 13, 2021, 9:04 PM

#

afaik Apache 2.0 isn't?

#

I might be wrong on that

vocal wolf Oct 13, 2021, 9:04 PM

#

There be a difference between dead and no one seeking improvements

vale ibex Oct 13, 2021, 9:05 PM

#

Yea, Apache 2.0 isn't compatible

clever wraith Oct 13, 2021, 9:05 PM

#

?

#

im reading it and it looks like it be good

#

Bloody apache

vale ibex Oct 13, 2021, 9:08 PM

#

The Apache license adds a bunch more requirements to use

clever wraith Oct 13, 2021, 9:09 PM

#

Lovely

#

I'll open an issue

trail pilot Oct 13, 2021, 9:10 PM

#

i wonder if you could just use ascii art yourself?

#

try and make your own impl if you wanted to

clever wraith Oct 13, 2021, 9:10 PM

#

Cowsay is a pain in the ass

vocal wolf Oct 13, 2021, 9:11 PM

#

@molten perch AoC thingy reviewed.

trail pilot Oct 13, 2021, 9:11 PM

#

why is the python stdlib kinda inconsistent

#

logging.getLogger uses camelCase

#

yet other things use snake_case

#

ig it's just too hard to go to PEP8 at this point

#

so they keep it as is

thorny obsidian Oct 13, 2021, 9:12 PM

#

convention and it's old

trail pilot Oct 13, 2021, 9:12 PM

#

Fair enough

trail pilot Oct 13, 2021, 9:12 PM

#

trail pilot ig it's just too hard to go to PEP8 at this point

they don't accept PRs on PEP8ing, I'm guessing?

clever wraith Oct 13, 2021, 9:13 PM

#

Love it when national cs competitions using py 3.x have raw_input() in examples

thorny obsidian Oct 13, 2021, 9:13 PM

#

It doesn't impact functionality and would affect a lot of codebases for no good reason

brazen charm Oct 13, 2021, 9:13 PM

#

vale ibex The Apache license adds a bunch more requirements to use

what requirements? I can only see the redistribution point which applies to the work or its derivatives

austere hornet Oct 13, 2021, 9:14 PM

#

clever wraith Love it when national cs competitions using py 3.x have raw_input() in examples

Hm...

brisk brook Oct 13, 2021, 9:14 PM

#

trail pilot `logging.getLogger` uses camelCase

I remember seeing that brought up in #internals-and-peps. Basically it came from Java and no one has bothered to fix it.

Additionally, at this point it is a huge breaking change because of how many codebases use it. So it most likely won't ever change

trail pilot Oct 13, 2021, 9:14 PM

#

True

clever wraith Oct 13, 2021, 9:15 PM

#

brisk brook I remember seeing that brought up in <#709904092280914030>. Basically it came fr...

If there's ever a python 4 it is possible that they might change it

brisk brook Oct 13, 2021, 9:15 PM

#

That's when they can change it. They probably won't, because that'll be annoying to update.

molten perch Oct 13, 2021, 9:16 PM

#

vocal wolf <@!263957159807549450> AoC thingy reviewed.

Thank you! 😄

vocal wolf Oct 13, 2021, 9:17 PM

#

@trail pilot I think we maybe perhaps should squash the challenges PR

trail pilot Oct 13, 2021, 9:17 PM

#

vocal wolf <@!584817706646110333> I think we maybe perhaps should squash the challenges PR

Yeah, would you all do that or do I have to do it on my end?

#

Cause 117 commits is quite a bit

vocal wolf Oct 13, 2021, 9:17 PM

#

I can do it from github

#

when merging

trail pilot Oct 13, 2021, 9:17 PM

#

alright awesome

#

does it look good?

vocal wolf Oct 13, 2021, 9:17 PM

#

uhhh

#

one change, I have reviewed

#

well technically 3 changes

trail pilot Oct 13, 2021, 9:17 PM

#

vocal wolf well technically 3 changes

Where are the other two?

vocal wolf Oct 13, 2021, 9:18 PM

#

well

trail pilot Oct 13, 2021, 9:18 PM

#

I only see log instead of logger

vocal wolf Oct 13, 2021, 9:18 PM

#

now logger isn't defined

trail pilot Oct 13, 2021, 9:18 PM

#

Ah yea

#

let me fix that

vocal wolf Oct 13, 2021, 9:18 PM

#

logger.info on other lines will be wack

trail pilot Oct 13, 2021, 9:19 PM

#

vocal wolf `logger.info` on other lines will be wack

I think it was just logger.error

#

which I fixed

vocal wolf Oct 13, 2021, 9:19 PM

#

nice

trail pilot Oct 13, 2021, 9:20 PM

#

ugh

#

status embed fail

#

in the future should I group my commits?

#

I think I committed too many times lol

vocal wolf Oct 13, 2021, 9:20 PM

#

trail pilot status embed fail

?

trail pilot Oct 13, 2021, 9:21 PM

#

It says "status embed fail" from time to time

#

oh nvm

#

it succeeded

vocal wolf Oct 13, 2021, 9:21 PM

#

the workflow?

trail pilot Oct 13, 2021, 9:21 PM

#

Yep

vocal wolf Oct 13, 2021, 9:21 PM

#

yeah it does that

#

lol

trail pilot Oct 13, 2021, 9:21 PM

#

@brisk brook also, thank you so so so much for all the reviews you did with the challenges PR. You were very thorough and you are an amazing reviewer

#

and the Hangman PR too

#

I just realized i requested the review at the same time Xith approved already, oops

vocal wolf Oct 13, 2021, 9:23 PM

#

heh

trail pilot Oct 13, 2021, 9:23 PM

#

also if it isn't too much effort, would you mind marking in #changelog when it's merged? though to be fair you've been reviewing for quite a bit so feel free to do it when you're fine with doing so

vocal wolf Oct 13, 2021, 9:24 PM

#

oh yeah I was already thinking of how many mentions I'm going to do lol

#

alright it's merged, time to see if it connects and doesn't die

#

I don't know who "tooboredtocode" is on discord, though

green oriole Oct 13, 2021, 9:25 PM

#

Woo woo, challenge command!

trail pilot Oct 13, 2021, 9:25 PM

#

vocal wolf I don't know who "tooboredtocode" is on discord, though

@remote wigeon

vocal wolf Oct 13, 2021, 9:25 PM

#

ah

#

ty

trail pilot Oct 13, 2021, 9:25 PM

#

no problemo

vocal wolf Oct 13, 2021, 9:27 PM

#

.help challenge

dusky shoreBOT Oct 13, 2021, 9:27 PM

#

Command Help

**```
.challenge [language=python] [query]

**Can also use:** `kata`

*The challenge command pulls a random kata (challenge) from codewars.com.

The different ways to use this command are:
`.challenge <language>` - Pulls a random challenge within that language's scope.
`.challenge <language> <difficulty>` - The difficulty can be from 1-8,
1 being the hardest, 8 being the easiest. This pulls a random challenge within that difficulty & language.
`.challenge <language> <query>` - Pulls a random challenge with the query provided under the language
`.challenge <language> <query>, <difficulty>` - Pulls a random challenge with the query provided,
under that difficulty within the language's scope.*

trail pilot Oct 13, 2021, 9:27 PM

#

:D

#

Thanks to everyone who helped out with this PR!

thorny obsidian Oct 13, 2021, 9:28 PM

#

So for Python Trivia Night no database storage is needed. You just need to be able to accept a json file and convert it into a list of dicts or something similar

trail pilot Oct 13, 2021, 9:28 PM

#

thorny obsidian So for Python Trivia Night no database storage is needed. You just need to be ab...

Ah awesome

#

I think I can already imagine how it would work

#

just trivianight as a group

#

and then a few subcommands

#

would discord.py allow # as a valid command name?

thorny obsidian Oct 13, 2021, 9:29 PM

#

mhm! I think the only parts that may require some more thought is the scoreboard calculation.

Also the # is just a placeholder, it would be a specific number

#

so like .trivianight 3 would pull up the third question

trail pilot Oct 13, 2021, 9:29 PM

#

thorny obsidian mhm! I think the only parts that *may* require some more thought is the scoreboa...

Ahh

#

could I edit the functionality a bit to do .trivianight question 3?

#

so I can keep it organized as subcommands

vocal wolf Oct 13, 2021, 9:30 PM

#

who's onerandomusername again? I keep forgetting

trail pilot Oct 13, 2021, 9:30 PM

#

vocal wolf who's `onerandomusername` again? I keep forgetting

@fallen patrol

thorny obsidian Oct 13, 2021, 9:30 PM

#

aru / arl

summer garden Oct 13, 2021, 9:30 PM

#

How does one set up their environment to be able to contribute to lancebot? I've been wrestling with poetry for a little while. Do i need docker?

vocal wolf Oct 13, 2021, 9:30 PM

#

ty

trail pilot Oct 13, 2021, 9:30 PM

#

summer garden How does one set up their environment to be able to contribute to lancebot? I've...

You don't need it though it is preferred and easy to set up

#

!contributor

thorny obsidian Oct 13, 2021, 9:30 PM

#

summer garden How does one set up their environment to be able to contribute to lancebot? I've...

nah, not for lance.

trail pilot Oct 13, 2021, 9:30 PM

#

Oh the tag in't added yet

thorny obsidian Oct 13, 2021, 9:30 PM

#

oh yeah... I should do that contribute tag

#

What parts of setting it up for lancebot are you having trouble with?

summer garden Oct 13, 2021, 9:31 PM

#

Pycharm isn't recognizing the poetry command yet I've added it to my env path

vocal wolf Oct 13, 2021, 9:31 PM

#

#changelog is done

thorny obsidian Oct 13, 2021, 9:31 PM

#

hmmmmm, which one of the core devs/regular contributors uses PyCharm a lot...

fallen patrol Oct 13, 2021, 9:31 PM

#

vocal wolf who's `onerandomusername` again? I keep forgetting

Yeah ik it's a shitty username 😔

green oriole Oct 13, 2021, 9:31 PM

#

I use intellij lol

vocal wolf Oct 13, 2021, 9:31 PM

#

fallen patrol Yeah ik it's a shitty username 😔

nahhh

summer garden Oct 13, 2021, 9:32 PM

#

It seems to work in cmd prompt and powershell but not in any of the pycharm terminals

fallen patrol Oct 13, 2021, 9:32 PM

#

Well okay, but it's definitely a random username

vocal wolf Oct 13, 2021, 9:32 PM

#

thorny obsidian hmmmmm, which one of the core devs/regular contributors uses PyCharm a lot...

@trim cradle

vocal prairie Oct 13, 2021, 9:32 PM

#

I think Scale uses PyCharm as well

fallen patrol Oct 13, 2021, 9:32 PM

#

Ye

clever wraith Oct 13, 2021, 9:33 PM

#

thorny obsidian hmmmmm, which one of the core devs/regular contributors uses PyCharm a lot...

pablo?

trim cradle Oct 13, 2021, 9:33 PM

#

vocal wolf <@!253696366952316929>

Wa

vocal wolf Oct 13, 2021, 9:33 PM

#

a wa

trim cradle Oct 13, 2021, 9:33 PM

#

A qwa!

vocal wolf Oct 13, 2021, 9:33 PM

#

You use PyCharm, yeah?

trim cradle Oct 13, 2021, 9:33 PM

#

Yes

clever wraith Oct 13, 2021, 9:33 PM

#

~~#dev-contrib~~

thorny obsidian Oct 13, 2021, 9:33 PM

#

trail pilot so I can keep it organized as subcommands

oh yeah feel free. I am not married at all to my suggestions, I just put there as a starting off point so people can get a solid idea of what I'm after. So feel free to adjust to what makes sense.

Also bug me if you have any questions about how it should function and what not.

vocal wolf Oct 13, 2021, 9:33 PM

#

People have questions me thinks

summer garden Oct 13, 2021, 9:33 PM

#

trim cradle Yes

Could you give me a hand with setting up poetry with pycharm? It's not being recognized by the terminal

trim cradle Oct 13, 2021, 9:34 PM

#

My license expires in a few days so I've been hitting up my project leads asking them to buy it for me.

trail pilot Oct 13, 2021, 9:34 PM

#

thorny obsidian oh yeah feel free. I am not married at all to my suggestions, I just put there a...

Sounds great, I'll create a branch on my local for and start messing around, could you assign kronifer and I to the issue?
And in the future if DM Friends wants to join in

trim cradle Oct 13, 2021, 9:34 PM

#

summer garden Could you give me a hand with setting up poetry with pycharm? It's not being rec...

You have to install the poetry plugin

clever wraith Oct 13, 2021, 9:34 PM

#

trim cradle My license expires in a few days so I've been hitting up my project leads asking...

so who other than vester is that?

thorny obsidian Oct 13, 2021, 9:34 PM

#

trail pilot Sounds great, I'll create a branch on my local for and start messing around, cou...

yup! Thank you for picking this up~

trail pilot Oct 13, 2021, 9:34 PM

#

No problem

#

It was perfect timing lol

summer garden Oct 13, 2021, 9:34 PM

#

trim cradle You have to install the poetry plugin

I've installed it and it works in regular cmd prompt and powershell

trail pilot Oct 13, 2021, 9:35 PM

#

My PR just got finished

trim cradle Oct 13, 2021, 9:35 PM

#

clever wraith so who other than vester is that?

I'm talking about at work

clever wraith Oct 13, 2021, 9:35 PM

#

oh im stupid

#

lmao

trim cradle Oct 13, 2021, 9:35 PM

#

No I was actually thinking about the coincidence myself.

trim cradle Oct 13, 2021, 9:35 PM

#

summer garden I've installed it and it works in regular cmd prompt and powershell

There's a poetry plugin for pycharm

summer garden Oct 13, 2021, 9:35 PM

#

Oh gotcha gotcha. Will have a look

trim cradle Oct 13, 2021, 9:35 PM

#

I'll be back in a few minutes. Doing leg day because can't stop won't stop

summer garden Oct 13, 2021, 9:36 PM

#

Got it. Thanks a bunch, Stelercus

vale ibex Oct 13, 2021, 9:37 PM

#

thorny obsidian oh yeah feel free. I am not married at all to my suggestions, I just put there a...

Would you want the leaderboard to persist across bot reboots?

thorny obsidian Oct 13, 2021, 9:38 PM

#

vale ibex Would you want the leaderboard to persist across bot reboots?

nah, as long as we can somewhat ensure the bot won't restart mid-event

vale ibex Oct 13, 2021, 9:38 PM

#

Sure

trim cradle Oct 13, 2021, 9:38 PM

#

@summer garden no problem, just ping me if you have a question

fallen patrol Oct 13, 2021, 9:39 PM

#

thorny obsidian nah, as long as we can somewhat ensure the bot won't restart mid-event

I mean, it could restart at any time. If a pr was merged or something

#

How long are the events

trail pilot Oct 13, 2021, 9:40 PM

#

thorny obsidian nah, as long as we can somewhat ensure the bot won't restart mid-event

When is the expected date for the event btw?

#

Like an estimate

thorny obsidian Oct 13, 2021, 9:40 PM

#

This one will range between 45 minute - 90 minutes if I had to guess start to finish

thorny obsidian Oct 13, 2021, 9:40 PM

#

trail pilot When is the expected date for the event btw?

January / February time range

trail pilot Oct 13, 2021, 9:40 PM

#

Awesome

#

And what kind of questions?

#

Harder questions about the internals, or easier questions

thorny obsidian Oct 13, 2021, 9:41 PM

#

No idea! I'm going to be querying staff for some questions and probably the community if necessary

trail pilot Oct 13, 2021, 9:41 PM

#

Alright, sounds good

#

I'm guessing we won't be able to participate?

#

kron and i

#

Since we're going to be putting the questions into the JSON etc?

clever wraith Oct 13, 2021, 9:42 PM

#

id assume so

thorny obsidian Oct 13, 2021, 9:42 PM

#

But the json will look something liiiike:

{
  '1':
    'question': 'sdfsdfs',
    'options':['ad','sfsd', 'sdf', 'hsrhas'],
    'answer': 'sdf' 
}

trail pilot Oct 13, 2021, 9:42 PM

#

ah alright

vale ibex Oct 13, 2021, 9:42 PM

#

I guess the questions themselves don't matter so much, more the fact that they will be multiple choice

thorny obsidian Oct 13, 2021, 9:42 PM

#

You will be able to participate! Part of the magic of my requested implementation is that the json itself won't be committed. It'll be loaded in via command

trail pilot Oct 13, 2021, 9:42 PM

#

What if we just made placeholder questions and we could still participate if the core dev would be actually adding the questions

vale ibex Oct 13, 2021, 9:42 PM

#

Ah kat beat me to it

trail pilot Oct 13, 2021, 9:42 PM

#

thorny obsidian You will be able to participate! Part of the magic of my requested implementatio...

Ohh awesome

vocal prairie Oct 13, 2021, 9:42 PM

#

trail pilot Since we're going to be putting the questions into the JSON etc?

I think that the json isn't hardcoded, it's coming through another way

trail pilot Oct 13, 2021, 9:43 PM

#

Oh I get it!

#

you just load the json via a command

thorny obsidian Oct 13, 2021, 9:43 PM

#

Toxic implemented a similar thing for the code jam teams and I liked it a lot

trail pilot Oct 13, 2021, 9:43 PM

#

.trivianight load

{"hello": 2}

for example?

thorny obsidian Oct 13, 2021, 9:43 PM

#

mhm or just a straight up file

#

let me seeee if I can find the example

trail pilot Oct 13, 2021, 9:43 PM

#

The former might be easier because I'm not sure if discord.py will actually catch the file in the message

fallen patrol Oct 13, 2021, 9:44 PM

#

thorny obsidian This one will range between 45 minute - 90 minutes if I had to guess start to fi...

Ah, in that case the bot could do some fuckery with the hastebin or smth to preserve a leader board, or use redis

clever wraith Oct 13, 2021, 9:44 PM

#

trail pilot The former might be easier because I'm not sure if discord.py will actually catc...

it will, but it would be a bit messy

thorny obsidian Oct 13, 2021, 9:44 PM

#

trail pilot The former might be easier because I'm not sure if discord.py will actually catc...

it will actually! let me grab a screenshot and toxic's code thing

vocal prairie Oct 13, 2021, 9:44 PM

#

!src codejam create is Toxic's implementation with CSV

stable mountainBOT Oct 13, 2021, 9:44 PM

#

Command: codejam create

Create code-jam teams from a CSV file or a link to one, specifying the team names, leaders and members.

Source Code

Go to GitHub

trail pilot Oct 13, 2021, 9:45 PM

#

oh that's cool

clever wraith Oct 13, 2021, 9:45 PM

#

also i assume that command would have to be locked to certain roles @thorny obsidian

trail pilot Oct 13, 2021, 9:45 PM

#

I have a lot of questions, sorry haha
what does "configured channel" mean?

#

because I'm wondering how we have dropdowns only be native to the user

#

Oh wait it's going to be buttons

#

and dropdowns

thorny obsidian Oct 13, 2021, 9:45 PM

#

trail pilot Oct 13, 2021, 9:45 PM

#

which are specific to users

austere hornet Oct 13, 2021, 9:46 PM

#

trail pilot

It's going to be a specific channel created for the event I would assume

trail pilot Oct 13, 2021, 9:46 PM

#

thorny obsidian

ooh I didn't know dpy could catch that

thorny obsidian Oct 13, 2021, 9:46 PM

#

This will happen in a special channel, or honestly just the channel the thing is started in. It doesn't even need to be configured

trail pilot Oct 13, 2021, 9:47 PM

#

I'm gonna make something in paint.net so I can understand what's gonna be going on for it

thorny obsidian Oct 13, 2021, 9:47 PM

#

trail pilot ooh I didn't know dpy could catch that

this is Toxic's code which handled that: https://github.com/python-discord/bot/blob/main/bot/exts/events/code_jams/_cog.py

thorny obsidian Oct 13, 2021, 9:47 PM

#

trail pilot because I'm wondering how we have dropdowns only be native to the user

this will just be buttons, visible to everyone. We just need to record their first interaction with the button, and then the second if there is one. Interactions after that should fail if it's the same question still

clever wraith Oct 13, 2021, 9:48 PM

#

!codejam create

trail pilot Oct 13, 2021, 9:48 PM

#

thorny obsidian this will just be buttons, visible to everyone. We just need to record their fir...

can you send ephermals with buttons btw?

clever wraith Oct 13, 2021, 9:48 PM

#

its role locked of course

thorny obsidian Oct 13, 2021, 9:48 PM

#

trail pilot can you send ephermals with buttons btw?

yes, I think. Only because I've seen Chris do it though

trail pilot Oct 13, 2021, 9:48 PM

#

I think it oculd just be after one interaction if the user tries again they'll be faced with the epheremal as stated

#

wait what will the second interactoin be more?

#

be for*

thorny obsidian Oct 13, 2021, 9:49 PM

#

I'll allow people to change their answer once in case they misclicked or misread

austere hornet Oct 13, 2021, 9:49 PM

#

clever wraith its role locked of course

Yeah I think it's only for the Event Team

sleek steppe Oct 13, 2021, 9:49 PM

#

trail pilot can you send ephermals with buttons btw?

Yeah any interaction response

austere hornet Oct 13, 2021, 9:49 PM

#

austere hornet Yeah I think it's only for the Event Team

Judging by this

sleek steppe Oct 13, 2021, 9:49 PM

#

Admin locked

thorny obsidian Oct 13, 2021, 9:49 PM

#

Yeah, this should be admin + event lead locked

austere hornet Oct 13, 2021, 9:50 PM

#

thorny obsidian Yeah, this should be admin + event lead locked

Ok, got it

sleek steppe Oct 13, 2021, 9:51 PM

#

thorny obsidian Yeah, this should be admin + event lead locked

Nope, just locked to admin

thorny obsidian Oct 13, 2021, 9:51 PM

#

sleek steppe Nope, just locked to admin

I mean for this new trivianight command, it should extend to event lead

sleek steppe Oct 13, 2021, 9:51 PM

#

oh ok, it looked like they were talking about the codejam create command

thorny obsidian Oct 13, 2021, 9:51 PM

#

codejam create I'm fine with keeping admin locked since it can be a lot

trail pilot Oct 13, 2021, 9:52 PM

#

#

how does this look for the workflow?

#

it's a bit messy

#

oh i forgot trivianight stop

thorny obsidian Oct 13, 2021, 9:52 PM

#

I may not want to delete the json entry, I can imagine a scenario where we may want to revisit a question by forcing it

trail pilot Oct 13, 2021, 9:52 PM

#

ah

#

i can add a visited flag

#

to it

#

maybe the json also has a visited key

thorny obsidian Oct 13, 2021, 9:52 PM

#

perfect, that'll work

#

Also, if it simplifies it: the .trivianight start doesn't have to create a channel. We can just invoke it in an existing one

trail pilot Oct 13, 2021, 9:53 PM

#

Ah

#

Ok I think I can understand how this'll work

#

Not as complicated as I originally thought

#

this is probably going to have to be carefully reviewed though, considering one small error might ruin the event as a whole

thorny obsidian Oct 13, 2021, 9:55 PM

#

OH! Could you also add this command now that I'm thinking about it:
.trivianight list will list out the loaded questions with an indication of which ones have been selected?
Also the .trivianight # for forcing a specific one

#

I'll comment on the issue with this too

austere hornet Oct 13, 2021, 9:55 PM

#

trail pilot this is probably going to have to be carefully reviewed though, considering one ...

Yeah lol

trail pilot Oct 13, 2021, 9:55 PM

#

thorny obsidian OH! Could you also add this command now that I'm thinking about it: `.trivianigh...

Could you elaborate on trivianight list?

austere hornet Oct 13, 2021, 9:55 PM

#

thorny obsidian OH! Could you also add this command now that I'm thinking about it: `.trivianigh...

Yeah, I like that idea

timid sentinel Oct 13, 2021, 9:55 PM

#

writes to trivianight.json- I don't think you should need to be writing to any files, should just be sorted as a dict or w/e, unless I'm misunderstanding something, am sort of jumping in without reading the full context lemon_sweat

trail pilot Oct 13, 2021, 9:56 PM

#

timid sentinel `writes to trivianight.json`- I don't think you should need to be writing to any...

the only thing I'm worried about is how it would have to linger around

thorny obsidian Oct 13, 2021, 9:56 PM

#

It'll produce a list of the questions that are currently loaded, with an indication of which ones have been used already soooo:
.trivianight list

Q1: "sdfasdfsadf" | :x:
Q2: "dsgaslikdgij" | :checkmark:
Q3: "asdfjk;sidfja;" | :x:

trail pilot Oct 13, 2021, 9:56 PM

#

because load occurs beore start

#

unless we have start take the json as an argument

#

Wait I think i'm confused

#

The resouces should be lignering around as lnog as the bot is online and the resources are in a global state within the class (class variable in the cog perhaps)

sleek steppe Oct 13, 2021, 9:58 PM

#

yeah the class variable is fine

trail pilot Oct 13, 2021, 9:59 PM

#

the cog is only ever ran as a single instance, right?

timid sentinel Oct 13, 2021, 10:00 PM

#

Well you could just have it as an instance variable on the cog, something like self.questions = ...

sleek steppe Oct 13, 2021, 10:01 PM

#

trail pilot the cog is only ever ran as a single instance, right?

yep

trail pilot Oct 13, 2021, 10:01 PM

#

timid sentinel Well you could just have it as an instance variable on the cog, something like `...

Or that yea

#

either way would work

sleek steppe Oct 13, 2021, 10:01 PM

#

oh yeah that's what I meant, the instance variable

trail pilot Oct 13, 2021, 10:02 PM

#

also for the trivianight stop, should there be an embed with just the scoreboard or scoreboard and winners

thorny obsidian Oct 13, 2021, 10:02 PM

#

I'll trust your judgement on that

trail pilot Oct 13, 2021, 10:03 PM

#

Alright

summer garden Oct 13, 2021, 10:09 PM

#

how do I go about running lancebot locally for testing?

static canyon Oct 13, 2021, 10:10 PM

#

summer garden how do I go about running lancebot locally for testing?

Have you read the guide on our website?

#

https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/sir-lancebot/

Python Discord - Contributing to Sir Lancebot

A guide to setting up and configuring Sir Lancebot.

austere hornet Oct 13, 2021, 10:10 PM

#

static canyon https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/sir-lancebo...

Dang you beat me to it

summer garden Oct 13, 2021, 10:10 PM

#

Ah i have not. I got distracted setting up poetry. Thanks I'll have a read of this!

austere hornet Oct 13, 2021, 10:10 PM

#

I was gonna post it too lol

static canyon Oct 13, 2021, 10:22 PM

#

@trail pilot fyi we just got an error with your challenges code. Apparently (kata_information["rank"]["name"] can be None (not sure in what circumstances), so it does None.replace here, raising an AttributeError: https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/utilities/challenges.py#L168

stable mountainBOT Oct 13, 2021, 10:22 PM

#

bot/exts/utilities/challenges.py line 168

color=MAPPING_OF_KYU[int(kata_information["rank"]["name"].replace(" kyu", ""))],```

static canyon Oct 13, 2021, 10:22 PM

#

I assume you'll want to work on that, but if not then no worries 👍

trail pilot Oct 13, 2021, 10:29 PM

#

static canyon I assume you'll want to work on that, but if not then no worries 👍

Oh no! I assume we could just say that it ran into an error and log it? and catch the exception?

#

I can make a quick fix now if that's fine

static canyon Oct 13, 2021, 10:29 PM

#

It's probably better to actually handle that

#

["rank"]["name"] is used in multiple cases, so we should dig deeper into what the root issue is and how to solve it

trail pilot Oct 13, 2021, 10:30 PM

#

Hmm

#

I don't know why it would be none tho

#

maybe because there is no page?

#

but it just doesn't catch it

static canyon Oct 13, 2021, 10:30 PM

#

You'd have to debug that 🤷

trail pilot Oct 13, 2021, 10:30 PM

#

alright, I'll see what I can come up with

#

It got past the page though, that's weird

trail pilot Oct 13, 2021, 10:35 PM

#

static canyon <@!584817706646110333> fyi we just got an error with your challenges code. Appar...

Oh god, I think I know why

#

the language I used that raised that error is in beta for codewars.com

#

So the API might not have its rank and what not

static canyon Oct 13, 2021, 10:36 PM

#

Yeah, that would potentially make sense

trail pilot Oct 13, 2021, 10:36 PM

#

Should I just entirely take out beta languages?

#

that is infact the reason why

#

These languages are fairly uncommon anyways

#

"beta": [
        "agda", "bf", "cfml", "cobol", "commonlisp", "elm", "erlang", "factor",
        "forth", "fortran", "haxe", "idris", "julia", "nim", "objective-c", "ocaml",
        "pascal", "perl", "powershell", "prolog", "purescript", "r", "raku", "reason", "solidity", "vb.net"
    ]

static canyon Oct 13, 2021, 10:37 PM

#

Is it possible to just not display the section causing the error?

trail pilot Oct 13, 2021, 10:37 PM

#

static canyon Is it possible to just not display the section causing the error?

I think I might be able to just default it to 8 kyu

#

Because it deals with the colors

static canyon Oct 13, 2021, 10:37 PM

#

Or use a "Unable to retrieve {thing} for languages in BETA mode"

austere hornet Oct 13, 2021, 10:37 PM

#

trail pilot ```py "beta": [ "agda", "bf", "cfml", "cobol", "commonlisp", "elm", "erl...

Oh yeah for sure those languages definitely don't look very popular

trail pilot Oct 13, 2021, 10:38 PM

#

static canyon Or use a "Unable to retrieve {thing} for languages in BETA mode"

That sounds fine with me

#

I could just check in the very beginning if the language is in beta

#

and send an error embed

#

oh wait

static canyon Oct 13, 2021, 10:38 PM

#

Imo it's better to keep functionality where possible

trail pilot Oct 13, 2021, 10:38 PM

#

nvm

#

I see what you're saying

#

Alright working on the change right now and should I just put up a PR for it?

static canyon Oct 13, 2021, 10:39 PM

#

if name := ...["rank"]["name"]:
    embed_colour = ...  # use name var instead of re-indexing
else:
    embed_colour = ...  # set to default```

static canyon Oct 13, 2021, 10:39 PM

#

trail pilot Alright working on the change right now and should I just put up a PR for it?

Lemme see if I can get an admin to make the error into an issue rq

trail pilot Oct 13, 2021, 10:39 PM

#

Awesome

#

it works now!

#

difficulty field

static canyon Oct 13, 2021, 10:43 PM

#

static canyon Lemme see if I can get an admin to make the error into an issue rq

I've got to go to bed now but have made a request. Asked them to ping you here when it's done to lyk 👍

trail pilot Oct 13, 2021, 10:43 PM

#

I'll remove the period and do beta

static canyon Oct 13, 2021, 10:43 PM

#

trail pilot it works now!

Nice!

static canyon Oct 13, 2021, 10:44 PM

#

trail pilot I'll remove the period and do `beta`

I think "for beta languages." (Keep period and reword slightly)

static canyon Oct 13, 2021, 10:44 PM

#

trail pilot difficulty field

Is it definitely not possible to get difficulty for beta languages?

trail pilot Oct 13, 2021, 10:45 PM

#

static canyon Is it definitely not possible to get difficulty for beta languages?

Yep

static canyon Oct 13, 2021, 10:46 PM

#

Then yeah, that looks good with the sight reword I mentioned above

trail pilot Oct 13, 2021, 10:46 PM

#

Sounds good, sorry for not catching the error earlier!

static canyon Oct 13, 2021, 10:46 PM

#

(Make sure it still works as expected for non-beta languages)

static canyon Oct 13, 2021, 10:47 PM

#

trail pilot Sounds good, sorry for not catching the error earlier!

No worries! We all miss things lol

trail pilot Oct 13, 2021, 10:47 PM

#

Hm, there is another bug that isn't breaking but is still weird

#

.challenge perl only works sometimes

#

Like the website will only load in beta languages at times.. weird

static canyon Oct 13, 2021, 10:47 PM

#

You're welcome to look into that if you'd like

#

But doesn't seem to be a massive issue

#

(Unless it's like ratelimitting or something)

trail pilot Oct 13, 2021, 10:48 PM

#

i know the issue I thikn

static canyon Oct 13, 2021, 10:49 PM

#

Anyway I really should be going to bed.

If you'd like to fix that too in the PR then go ahead (just make sure to mention in the PR) 👍

trail pilot Oct 13, 2021, 10:49 PM

#

static canyon Anyway I really should be going to bed. If you'd like to fix that too in the PR...

Oh yeah, cya!

#

Yeah I can't figure out why it won't work

#

Nvm I know the issue

#

Fixed it!

#

I should not have set the level by random, as that might lead to no katas shown

austere hornet Oct 13, 2021, 11:02 PM

#

Why did Lance react to this with a candy?? #sir-lancebot-playground message

trail pilot Oct 13, 2021, 11:03 PM

#

austere hornet Why did Lance react to this with a _candy_?? https://discord.com/channels/267624...

Its candy collection system, it's random

austere hornet Oct 13, 2021, 11:03 PM

#

trail pilot Its candy collection system, it's random

Huh, ok

summer garden Oct 13, 2021, 11:16 PM

#

regarding sir-lancebot#907, is this simply a case of using a dict.get() with a default value, rather than a []?

dusky shoreBOT Oct 13, 2021, 11:16 PM

#

GitHub

IssueOpen TypeError: object of type 'NoneType' has no len()

fallen patrol Oct 14, 2021, 12:25 AM

#

summer garden regarding sir-lancebot#907, is this simply a case of using a `dict.get()` with a...

ye pretty much

#

sir-lancebot#908

dusky shoreBOT Oct 14, 2021, 12:26 AM

#

GitHub

PROpen Fix GH-907

short snow Oct 14, 2021, 12:31 AM

#

another dict.get() issue, if anyone wants to handle, haven't created an issue yet

fallen patrol Oct 14, 2021, 12:46 AM

#

that seems a little harder to fix, actually

#

looks like it hasn't fetched the latest comic yet

trail pilot Oct 14, 2021, 12:55 AM

#

Are you allowed to open a PR without an issue? I wanted to open a PR regarding a fix for the .challenge command as it errors out at times

austere hornet Oct 14, 2021, 12:58 AM

#

trail pilot Are you allowed to open a PR without an issue? I wanted to open a PR regarding a...

Yes as long as you link the relevant discussion in Discord

trail pilot Oct 14, 2021, 1:02 AM

#

austere hornet Yes as long as you link the relevant discussion in Discord

I need core deva pproval

fallen patrol Oct 14, 2021, 1:02 AM

#

trail pilot Are you allowed to open a PR without an issue? I wanted to open a PR regarding a...

What's the issue

trail pilot Oct 14, 2021, 1:03 AM

#

i think

trail pilot Oct 14, 2021, 1:03 AM

#

fallen patrol What's the issue

AttributeError

#

because sometimes with a beta language the kata will have the rank as none

thorny obsidian Oct 14, 2021, 1:03 AM

#

You can go ahead, we're just waiting on an admin/core dev to open it via sentry

trail pilot Oct 14, 2021, 1:03 AM

#

thorny obsidian You can go ahead, we're just waiting on an admin/core dev to open it via sentry

Ah alright

fallen patrol Oct 14, 2021, 1:03 AM

#

Ah

trail pilot Oct 14, 2021, 1:03 AM

#

So should I make the PR?

thorny obsidian Oct 14, 2021, 1:03 AM

#

Yeah go for it, you can blame me

trail pilot Oct 14, 2021, 1:04 AM

#

sir-lancebot#909

dusky shoreBOT Oct 14, 2021, 1:04 AM

#

GitHub

PROpen Fixing GH 860 (.challenge)

trail pilot Oct 14, 2021, 1:05 AM

#

thorny obsidian Yeah go for it, you can blame me

Oh also question, for the trivianight, should the multiple choice be a button or a dropdown?

#

buttons or a dropdown*

thorny obsidian Oct 14, 2021, 1:05 AM

#

mmmmm... let's go with buttons. Just to make it more fun

vocal prairie Oct 14, 2021, 1:05 AM

#

Just from an outside perspective, if there's not more than 5/6 options, I'd like buttons, easier to click

trail pilot Oct 14, 2021, 1:05 AM

#

Awesome!

#

I always got misled since discord said ephermals only worked for slash commands

#

but turns out it works for buttons too

trail pilot Oct 14, 2021, 1:09 AM

#

thorny obsidian mmmmm... let's go with buttons. Just to make it more fun

also, this is more of a question about the event itself, and i'm not sure if it's disclosed

but will this be more of a 'fun' event or one with prizes like pydis merch like the code jam?

#

(Sorry for all the questions)

thorny obsidian Oct 14, 2021, 1:10 AM

#

probably more of a fun and casual event, possibly with a temporary Trivia Night Champion role

#

questions are good!

trail pilot Oct 14, 2021, 1:10 AM

#

thorny obsidian probably more of a fun and casual event, possibly with a temporary Trivia Night ...

Ah alright, thanks!

#

Las tquestion -- how will the scoring work?

#

or will there be a score key in the json?

thorny obsidian Oct 14, 2021, 1:12 AM

#

greaaaat question. I think for the first iteration all questions are valued the same, so no worries there. I need to have a think about it and figure out a decent scoring system that accounts for questions attempted, questions answered correctly, and maybe even speed

trail pilot Oct 14, 2021, 1:13 AM

#

thorny obsidian greaaaat question. I think for the first iteration all questions are valued the ...

Oh yeah I forgot about the speed

I have an idea --
for the scoreboard, maybe it's a view?

there are buttons that show you the leaderboard by points, speed, etc.
and if you click on a button, it'll send an ephermal of that certain leaderboard

thorny obsidian Oct 14, 2021, 1:13 AM

#

That'd be neat

trail pilot Oct 14, 2021, 1:14 AM

#

and speed should also factor in correct answers and the second time you press a button if you do interact again, i presume?

thorny obsidian Oct 14, 2021, 1:14 AM

#

Yeah, although I'm fine if you want to leave that part out for a future iteration/version

trail pilot Oct 14, 2021, 1:15 AM

#

I think I could just give it all a shot at one go and any future suggestions could be added in later

#

I don't think speed should be too complicatd

#

complicated

#

just a time.perf_counter()

#

Another question - could I make a folder for the trivianight event? there will be so many views it'll be complicaetd

#

actually nevermind

#

i'll need to keep it in one file

thorny obsidian Oct 14, 2021, 1:17 AM

#

yup! Probably should have specified this but you can make a trivianight folder under the events/ folder and go nuts

trail pilot Oct 14, 2021, 1:18 AM

#

thorny obsidian yup! Probably should have specified this but you can make a trivianight folder u...

The only problem would be sharing resources

#

the views need to communicate with the scoreboard

#

I may just keep it in one file but have it well documented

thorny obsidian Oct 14, 2021, 1:19 AM

#

can that be done on the class/instance level and import the relevant files? (I have no idea how views work)

trail pilot Oct 14, 2021, 1:20 AM

#

thorny obsidian can that be done on the class/instance level and import the relevant files? (I h...

I think we could just set up the views in different files, import them, set instance attributes for the scoreboard, and it should work

#

Should there be a group chat with you, Kron and I so we don't end up flooding this chat haha

#

Regarding the trivianight event

thorny obsidian Oct 14, 2021, 1:21 AM

#

nah, that's what this channel is made for so no worries

trail pilot Oct 14, 2021, 1:21 AM

#

thorny obsidian nah, that's what this channel is made for so no worries

Oh alright, great

#

I just wanted to make sure that no one else would get annoyed by all these message

#

s

#

anyways I'm gonna draw out a flowchart

#

something like this

#

arrows are imports (trivianight.py imports question and scoreboard

thorny obsidian Oct 14, 2021, 1:26 AM

#

@vale ibex you are smarter with views than I am, can you take a look at the above?

vocal wolf Oct 14, 2021, 1:36 AM

#

#

I don't think I've ever gotten myself as a suggestion for reviewers

thorny obsidian Oct 14, 2021, 1:38 AM

#

get reviewing!

short snow Oct 14, 2021, 1:40 AM

#

short snow another `dict.get()` issue, if anyone wants to handle, haven't created an issue ...

.remind 22H

#

uhh

vocal wolf Oct 14, 2021, 1:40 AM

#

wrong bot

short snow Oct 14, 2021, 1:40 AM

#

!remind 22H

stable mountainBOT Oct 14, 2021, 1:40 AM

#

Missing required argument

content

short snow Oct 14, 2021, 1:40 AM

#

short snow another `dict.get()` issue, if anyone wants to handle, haven't created an issue ...

!remind 22H

stable mountainBOT Oct 14, 2021, 1:40 AM

#

Missing required argument

content

short snow Oct 14, 2021, 1:40 AM

#

what

#

!remind 22H that and that

stable mountainBOT Oct 14, 2021, 1:41 AM

#

No problem.

Your reminder will arrive on <t:1634254872:F>!

short snow Oct 14, 2021, 1:41 AM

#

trail pilot something like this

which issue?

short snow Oct 14, 2021, 1:44 AM

#

trail pilot Are you allowed to open a PR without an issue? I wanted to open a PR regarding a...

Maybe it's just me, but the language list and tags list can sometimes get long how about make them into pagination or add them as inline fields pithink

#

can take up the whole vertical space

short snow Oct 14, 2021, 1:45 AM

#

short snow which issue?

found it nvm

trail pilot Oct 14, 2021, 1:46 AM

#

short snow which issue?

sir-lancebot#903 i think

dusky shoreBOT Oct 14, 2021, 1:46 AM

#

GitHub

IssueOpen Python Trivia Night Command(s)

short snow Oct 14, 2021, 1:46 AM

#

shouldn't the trivia event be done in DMs? Or people can see each other's answer

#

oh nvm

#

ok the issue sounds fun, "Users will be able to press the buttons to select their answer and should be allowed to change their answer once." does discord have some functionality for this or you are planning to use cache?

trail pilot Oct 14, 2021, 1:52 AM

#

short snow ok the issue sounds fun, "Users will be able to press the buttons to select thei...

it would just be a simple dictionary honestly

#

for that question

short snow Oct 14, 2021, 1:52 AM

#

bot restarts, whole thing gone 🙃

trail pilot Oct 14, 2021, 1:53 AM

#

bot won't restart mid event

#

that's a guarantee

thorny obsidian Oct 14, 2021, 1:54 AM

#

Yeah, I don't need it to persist as long as we can somewhat ensure the bot won't restart mid-event. Which is as simple as "core devs, please don't merge anything on lance for the next 90 minutes"

short snow Oct 14, 2021, 1:54 AM

#

Hmm alright

#

From the issue i get we first load the questions and then start the event, how about loading the questions in the same command as .trivianight start?

thorny obsidian Oct 14, 2021, 1:57 AM

#

I want to load the questions in a private channel, but then initialize the event in the channel that will be visible to everyone

#

I want a clear distinction between prepping for it and then actually starting the event

short snow Oct 14, 2021, 1:58 AM

#

Ah 👍

trail pilot Oct 14, 2021, 2:03 AM

#

I have a question - is it fine if code is a bit overachieving if it makes accessing it much more easier?

#

I'm implementing __getitem__ and __setitem__ for a scoreboard class for the trivia night so accessing it via across classes is much esaier

thorny obsidian Oct 14, 2021, 2:04 AM

#

go for it~ This is also a learning/practice opportunity for you

trail pilot Oct 14, 2021, 2:04 AM

#

since it holds a view and that view holds dictionaries so it would be very long in terms of length to accessing it

#

I think I'm gonna set up a draft PR for the trivia night event if that's fine

short snow Oct 14, 2021, 2:06 AM

#

This is how I would go about doing this. A class for a "trivia event" would contain the questions list for that particular event. The list would be of a question object.

@dataclass
class Question:
  question: str
  options: set[str]
  answer: str
  # Leaderboard for the particular question
  leaderboard: dict[str]

Where leaderboard is mapping the user discord ID to their points, for points I was thinking of them being relative to the time taken by the user to answer, like 5 sec 100 points, 10 seconds 70 points.

Now buttons, buttons would only be used for questions, the leaderboard would be just listing the first 10 users and others can be seen through a Pastebin link or something, like how AoC happens. On answering a question, the user would be added to the leaderboard of the question - if he got it wrong then 0 points or time relative points (using some formula). So now we can even ensure that they don't respond twice/can change their answer.

The time for the question would be taken when doing next. If the question is passed while running it then we can check if it is done already - if yes ask for confirmation through discord buttons -- if confirmed clear the leaderboard and send the question again.

I am having per question leaderboard here so that it can help to check no changing or double answers and we can have per question leaderboard views like we are having for AoC.

short snow Oct 14, 2021, 2:06 AM

#

trail pilot something like this

responding to this, I haven't worked with discord views so not sure about them.

trail pilot Oct 14, 2021, 2:09 AM

#

I think for now the first iteration will just have a set # of points for all questions

short snow Oct 14, 2021, 2:09 AM

#

I didn't get you pithink

trail pilot Oct 14, 2021, 2:11 AM

#

short snow I didn't get you <:pithink:652247559909277706>

For now, all questions will have a set # of points

#

that will be awarded if the user gets it correct

#

sir-lancebot#910 is up!

This is a draft for now just so that I set it up early on and I don't end up procrastinating making the PR

dusky shoreBOT Oct 14, 2021, 2:13 AM

#

GitHub

PRDraft Trivia night event

short snow Oct 14, 2021, 2:13 AM

#

ah, but what do you think about the rest

trail pilot Oct 14, 2021, 2:14 AM

#

short snow ah, but what do you think about the rest

Hm, I was honestly thinking having a link to the view for the question, and having the question be a class on its own

#

I'll show you what I'm thinking for example

#

https://github.com/python-discord/sir-lancebot/blob/3a8bceb8d91c6c239ea3d05912d72f486a0750ae/bot/exts/events/trivianight/scoreboard.py

GitHub

sir-lancebot/scoreboard.py at 3a8bceb8d91c6c239ea3d05912d72f486a075...

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - sir-lancebot/s...

#

something like this

short snow Oct 14, 2021, 2:15 AM

#

Whaat would the question class contain

#

link to the view, link to view the scoreboard?

trail pilot Oct 14, 2021, 2:16 AM

#

short snow Whaat would the question class contain

it would have the view for the question along with some other information

#

the view should contain the majority of the information, the question class is just sort of an "intercepting" class in the sense that it just abstracts away having to access the view for everythign

#

I finally get to use dunders other than __init__ and __repr__ in prod for once haha

fallen patrol Oct 14, 2021, 4:42 AM

#

short snow bot restarts, whole thing gone 🙃

inb4 power outage or crash on lance during those 90 minutes

#

no actually

#

datacenter fire 🥲

plush wedge Oct 14, 2021, 4:45 AM

#

is there a special tag for hacktober?

#

if so, how do i add it? github isn't letting me add any tags

gritty wind Oct 14, 2021, 5:22 AM

#

Add a comment on your PR asking for it

#

Non-triagers can’t add tags

brisk brook Oct 14, 2021, 6:21 AM

#

gritty wind Non-triagers can’t add tags

No I can

gritty wind Oct 14, 2021, 6:22 AM

#

You are staff

#

Triage here is referring to a permission we have on staff for most of our repos

#

By default you can’t add labels to anything on GitHub yourself

#

Someone with perms needs to

plush wedge Oct 14, 2021, 6:27 AM

#

Ah

brisk brook Oct 14, 2021, 6:32 AM

#

gritty wind By default you can’t add labels to anything on GitHub yourself

Oh I see yes

green oriole Oct 14, 2021, 6:43 AM

#

Hello @trail pilot! I heard you wanted to work on sir-lancebot#912, right?
If so, can you please comment on the issue and ping me back so I can assign you? Thank you!

dusky shoreBOT Oct 14, 2021, 6:43 AM

#

GitHub

IssueOpen AttributeError: 'NoneType' object has no attribute 'replace'

molten perch Oct 14, 2021, 7:13 AM

#

Hey! @hardy gorge (sorry for the ping).
What do you think about api#22 , is it fine to start implementing such an endpoint?

dusky shoreBOT Oct 14, 2021, 7:13 AM

#

GitHub

IssueOpen Migrate reminders endpoint from the site API

brisk brook Oct 14, 2021, 7:39 AM

#

Congrats @static canyon

static canyon Oct 14, 2021, 7:51 AM

#

Thanks! 🎉 ducky_party

#

Congrats to you too 😄

#

You've been doing some great work with all those reviews :p

short snow Oct 14, 2021, 7:54 AM

#

molten perch Hey! <@336843820513755157> (sorry for the ping). What do you think about api#22...

IMO it shouldn't be a problem, as we are planning to shift all API endpoints to it eventually and were waiting for the DB setup originally.

#

And congrats bluenix and tizzy

#

btw bluenix i have requested reviews on preserving unloaded cogs and incidents enhacement pr

vale ibex Oct 14, 2021, 8:01 AM

#

trail pilot something like this

I'm not sure they need to be in different files at all, the scoreboard just needs to be a simple command that outputs an embed from a class variable of scores, the question view will be ~10 lines of code and the button view ~50

#

If you take a look at my subscribe PR on bot I have then all in one file and it's alright, I imagine the view and buttons for this will be simpler, since they don't need to self update

#

If it does get too big though, feel free to split out the view and button class into their own models file

static canyon Oct 14, 2021, 8:26 AM

#

@trail pilot fyi I've linked sir-lancebot#909 to the sentry issue (sir-lancebot#912) and also left a review 👍

Would be great if you can edit your PR message to say "Closes #912" so that the issue will be automatically closed upon PR merge

dusky shoreBOT Oct 14, 2021, 8:26 AM

#

GitHub

IssueOpen AttributeError: 'NoneType' object has no attribute 'replace'
PROpen Fixing GH 860 (.challenge)

static canyon Oct 14, 2021, 8:27 AM

#

Maybe also update the title of the PR to like "Solve GH 912"

vale ibex Oct 14, 2021, 8:35 AM

#

I've updated the PR description

static canyon Oct 14, 2021, 8:35 AM

#

vale ibex I've updated the PR description

Ah, ty 👍

#

TIL I can edit it myself rofl

vale ibex Oct 14, 2021, 8:35 AM

#

oh lol

#

I've updated the PR title to be more descriptive too

static canyon Oct 14, 2021, 8:35 AM

#

tyty

short snow Oct 14, 2021, 8:44 AM

#

Hey @cold island What's the status for bot#1570? Should I wait my PR (#1634) for it or it is gonna take sometime?

dusky shoreBOT Oct 14, 2021, 8:44 AM

#

GitHub

PROpen Add a persistent scheduler

fallen patrol Oct 14, 2021, 9:36 AM

#

@vale ibex could you uh sir-lancebot#908

dusky shoreBOT Oct 14, 2021, 9:36 AM

#

GitHub

PROpen Fix GH-907

fallen patrol Oct 14, 2021, 9:36 AM

#

I can't edit it to actually link 907 rn

vale ibex Oct 14, 2021, 9:37 AM

#

fallen patrol I can't edit it to actually link 907 rn

updated to solve the sentry issue too

#

mentioning the issue in the PR description auto-links it 😄

fallen patrol Oct 14, 2021, 9:38 AM

#

Thanks

#

Ye, I realised I hadn't done that

vale ibex Oct 14, 2021, 9:38 AM

#

oh, "Closes GH-907" was already there before I edited

#

I just added the solves line

fallen patrol Oct 14, 2021, 9:38 AM

#

Ah lmao

#

I don't think 907 was actually assigned to me lol

vale ibex Oct 14, 2021, 9:38 AM

#

wasn't assigned to anyone 😛

fallen patrol Oct 14, 2021, 9:39 AM

#

Or anyone for that matter ¯\_(ツ)_/¯

#

Ye

vale ibex Oct 14, 2021, 9:39 AM

#

Yea, doesn't really matter, issue assignments are more useful if the fix is going to take a while, so that two people don't work on the same thing

fallen patrol Oct 14, 2021, 9:39 AM

#

Yeah

#

I made the edit on github

#

Except because I'm so accustomed to black, I actually made the edit, copied the line, ran it through black, and then pasted it back into github

vale ibex Oct 14, 2021, 9:40 AM

#

surprised it passed the trailing whitespace check then lol

#

Github loves adding those

fallen patrol Oct 14, 2021, 9:40 AM

#

I initially had typed ''

#

And not ""

vale ibex Oct 14, 2021, 9:40 AM

#

A_Spray2_REH

fallen patrol Oct 14, 2021, 9:40 AM

#

It's unfortunate how bad my coding style is without black

vale ibex Oct 14, 2021, 9:41 AM

#

hah, I'm the same with my spelling, spellcheck has made it so that I can just spew out words and fix them later

fallen patrol Oct 14, 2021, 9:41 AM

#

dict.get('thing','' )

vale ibex Oct 14, 2021, 9:42 AM

#

dict.get(issue, 'body', '')

fallen patrol Oct 14, 2021, 9:42 AM

#

But with isort and black, I don't have to worry about any of this at all :)

#

No, what I instead do is change the isort and black settings constantly

vale ibex Oct 14, 2021, 9:43 AM

#

😄

fallen patrol Oct 14, 2021, 9:43 AM

#

Wish I was kidding

#

I added a second blank like under all of my imports in a pr, so 25+ files edited to add... \n

#

Isort is a very nice tool

brisk brook Oct 14, 2021, 9:45 AM

#

I love Isort

summer garden Oct 14, 2021, 10:32 AM

#

fallen patrol ye pretty much

Awh shoot you stole it from me 😝

cold island Oct 14, 2021, 10:32 AM

#

short snow Hey <@!512354988157173763> What's the status for bot#1570? Should I wait my PR (...

Nah don't wait for it, I'll deal with merging

trail pilot Oct 14, 2021, 10:37 AM

#

static canyon <@!584817706646110333> fyi I've linked sir-lancebot#909 to the sentry issue (sir...

Sorry I wasn't awake, I made all the changes you requested!

static canyon Oct 14, 2021, 10:39 AM

#

I'll take a look shortly 👍

short snow Oct 14, 2021, 10:40 AM

#

cold island Nah don't wait for it, I'll deal with merging

Ok thanks 🙃

cc @brisk brook regarding your comment

trail pilot Oct 14, 2021, 10:44 AM

#

static canyon I'll take a look shortly 👍

Thank you for all the reviews that you do! Congrats on your well-deserved Contributor (and congrats to @brisk brook too 🎊 !)

static canyon Oct 14, 2021, 10:46 AM

#

        if query is not None and "," in query:
            query_splitted = query.split("," if ", " not in query else ", ")

            if len(query_splitted) > 2:
                raise commands.BadArgument(
                    "There can only be one comma within the query, separating the difficulty and the query itself."
                )

            query, level = query_splitted
            params["q"] = query
            params["r[]"] = f"-{level}"
        elif query is not None and query.isnumeric():
            params["r[]"] = f"-{query}"
        elif query is not None:
            params["q"] = query```I don't particularly like the repeated `query is not None` here. Is there something we can do about that? @trail pilot

trail pilot Oct 14, 2021, 10:46 AM

#

static canyon ```py if query is not None and "," in query: query_splitted ...

I was thinking about that too, but if we didn't want it to repeat, we'd have to put the if statement in the beginning with the pass

#

if query is None:
  pass
elif ...

#

What do you think?

static canyon Oct 14, 2021, 10:48 AM

#

What do you want to do when query is None?

trail pilot Oct 14, 2021, 10:48 AM

#

there should be no parameters

static canyon Oct 14, 2021, 10:48 AM

#

hmm

#

if query is not None:
    if "," in query:
        ...

    elif query.isnumeric():
        ...

    else:
        params["q"] = query```I guess this works

trail pilot Oct 14, 2021, 10:49 AM

#

Oh wait

#

that does work

brisk brook Oct 14, 2021, 10:49 AM

#

What do you want to happen if query is None?

static canyon Oct 14, 2021, 10:49 AM

#

Assuming the else is correct

static canyon Oct 14, 2021, 10:50 AM

#

brisk brook What do you want to happen if `query` is None?

#dev-contrib message

brisk brook Oct 14, 2021, 10:50 AM

#

I don't remember, can we return early when this happens?

static canyon Oct 14, 2021, 10:50 AM

#

Nope

#

There's other code below it

#

https://github.com/python-discord/sir-lancebot/blob/196c451c867bc78beab2492b963b7d9a1f6a13f5/bot/exts/utilities/challenges.py#L284

trail pilot Oct 14, 2021, 10:51 AM

#

Committed

static canyon Oct 14, 2021, 10:54 AM

#

You no longer have anything checking against language. Is that intentional?

#

It was originallypy if language and not query: level = f"-{choice([1, 2, 3, 4, 5, 6, 7, 8])}" params["r[]"] = level

trail pilot Oct 14, 2021, 10:55 AM

#

static canyon You no longer have anything checking against `language`. Is that intentional?

Yes, because I removed the random choice for the level since that led to no results when there were results

#

no langauge and no params would just lead to https://codewars.com/kata/search/(langauge)

static canyon Oct 14, 2021, 10:56 AM

#

right, okay

#

As long as that's intended

#

By the way it's better to use the imperative for commits

#

So remove instead of removed etc.

#

Have approved, thanks @trail pilot 👍

trail pilot Oct 14, 2021, 11:04 AM

#

static canyon Have approved, thanks <@!584817706646110333> 👍

Np

#

Btw I tested on my end and everything works fine

trail pilot Oct 14, 2021, 11:06 AM

#

vale ibex I'm not sure they need to be in different files at all, the scoreboard just need...

I was thinking to take advantage of the modular structure of events so that the code wasn’t hard to read, as packing both views in and the trivia night cog will get lengthy

#

The challenges PR reached to 300 lines with the view included and without it was ~220

vale ibex Oct 14, 2021, 11:06 AM

#

Yea, you could have the view and button model in a separate file to the commands itself if it makes the file easier to parse

#

and extra 80 lines in a separate class isn't bad though, since they're clearly separated

trail pilot Oct 14, 2021, 11:07 AM

#

True

vale ibex Oct 14, 2021, 11:07 AM

#

I don't imagine this to take 80 lines though

trail pilot Oct 14, 2021, 11:07 AM

#

Though it’s also easier to follow requested changes on my end

vale ibex Oct 14, 2021, 11:07 AM

#

probably don't even need to subclass view at all

trail pilot Oct 14, 2021, 11:07 AM

#

Yea, I’m planning on having the bare classes be in different files but the functionality linked in the trivia night cog

trail pilot Oct 14, 2021, 11:08 AM

#

vale ibex probably don't even need to subclass view at all

I think you need those for buttons though, right?

#

Or you could just subclass the button itself

vale ibex Oct 14, 2021, 11:08 AM

#

you can subclass the button sure

#

not sure if the view needs to be subclassed or not

#

you may find it easier to do so to store some question data

#

but that's depending on your implementation

trail pilot Oct 14, 2021, 11:09 AM

#

vale ibex not sure if the view needs to be subclassed or not

It’s easier on my end since I have the buttons which use the button decorator, and I can still pack in normal functionality for the view like the points and speed leaderboard dictionaries

#

Though I can take it out

#

That’s fine with me

vale ibex Oct 14, 2021, 11:10 AM

#

Yea, I'd suggest subclassing button, rather than using the decorator for this

#

that way you can just define the base behaviour of a button and then init it with the label etc

trail pilot Oct 14, 2021, 11:10 AM

#

Alright

#

I have to head to school but when I come back I can make the changes and get started on the trivia night cog

vale ibex Oct 14, 2021, 11:11 AM

#

Yea no worries 🙂

trail pilot Oct 14, 2021, 11:11 AM

#

vale ibex Yea no worries 🙂

Thanks for the feedback by the way!

vale ibex Oct 14, 2021, 11:12 AM

#

no worries, I've recently gone through the struggle of learning the new ui stuff, so it's all fresh in my head 😛

trail pilot Oct 14, 2021, 11:12 AM

#

The UI is pretty amazing honestly

#

So many different features

vale ibex Oct 14, 2021, 11:12 AM

#

yea it's nice

austere hornet Oct 14, 2021, 11:21 AM

#

Congrats @static canyon and @brisk brook !! I knew it would happen someday py_strong 😋

vocal prairie Oct 14, 2021, 11:21 AM

#

Congrats @static canyon and @brisk brook!

trail pilot Oct 14, 2021, 11:25 AM

#

vale ibex yea it's nice

My favorite feature is either the drop down or the ephemeral

clever wraith Oct 14, 2021, 1:02 PM

#

Congrats to @static canyon and @brisk brook on contributor

thorny obsidian Oct 14, 2021, 1:37 PM

#

@static canyon @cold island thoughts?

green oriole Oct 14, 2021, 1:59 PM

#

Looks good so far, can we add a sentence at the end saying to ask us in #dev-contrib if they have any question?

thorny obsidian Oct 14, 2021, 2:06 PM

#

In addition to the "Chait with us in #dev-contrib ..." thing?

green oriole Oct 14, 2021, 2:26 PM

#

hmm, maybe change it "to ask what to work on" tooo "if you are ready to jump into it or have some questions". Something along the lines of that.

static canyon Oct 14, 2021, 3:15 PM

#

green oriole hmm, maybe change it "to ask what to work on" tooo "if you are ready to jump int...

I think "any questions" > "some questions"

static canyon Oct 14, 2021, 3:17 PM

#

thorny obsidian <@!442244135840382978> <@!512354988157173763> thoughts?

Maybe an exclamation mark instead of period at end of first paragraph and periods at the end of the 3 "where to start" bullets, and then with Akary's suggestion I think that's pretty good 👍

green oriole Oct 14, 2021, 3:34 PM

#

@vale ibex use the magic label!

vale ibex Oct 14, 2021, 3:34 PM

#

lol I was in the process of adding the labels 😂

green oriole Oct 14, 2021, 3:35 PM

#

Hah

green oriole Oct 14, 2021, 4:16 PM

#

So currently, manually sorting imports is a pain, right? Well, I tried to make it painless! Lmk what you think https://github.com/python-discord/bot/pull/1872

GitHub

Experiment: add Isort to our toolchain by Akarys42 · Pull Request #...

What is Isort?
PyCQA/ISORT is a fantastic hyper configurable tool that will magically sort your imports so you don't have to care about them.
It also comes with a precommit hook. Quite an a...

vale ibex Oct 14, 2021, 4:17 PM

#

green oriole So currently, manually sorting imports is a pain, right? Well, I tried to make i...

isort is GPL 😅

green oriole Oct 14, 2021, 4:17 PM

#

ohno

#

@vale ibex https://github.com/PyCQA/isort/blob/main/LICENSE

GitHub

isort/LICENSE at main · PyCQA/isort

A Python utility / library to sort imports. Contribute to PyCQA/isort development by creating an account on GitHub.

#

Dude, don't get me scared like that

#

It is MIT

vale ibex Oct 14, 2021, 4:20 PM

#

the precommit is yea

#

you added flake8-isort tho

#

!pypi flake8-isort

stable mountainBOT Oct 14, 2021, 4:20 PM

#

flake8-isort v4.1.1

flake8 plugin that integrates isort .

brazen charm Oct 14, 2021, 4:21 PM

#

we're using it as a tool, the license should be irrelevant

green oriole Oct 14, 2021, 4:21 PM

#

Right

#

The precommit is also MIT

#

We can yeet the flake8 plugin

vale ibex Oct 14, 2021, 4:22 PM

#

Yea, what Numerlor says is true though,

#

Maybe we ignore dev deps in the linter?

#

Since they never ship

green oriole Oct 14, 2021, 4:23 PM

#

Eh, I would rather not take any chance and just remove it

#

The precommit is already checking for it

vale ibex Oct 14, 2021, 4:24 PM

#

Does isort also remove the need for import order?

green oriole Oct 14, 2021, 4:24 PM

#

Yup

#

Since the CI will fail if any hook modifies any file

vale ibex Oct 14, 2021, 4:24 PM

#

cool, we could remove that then

green oriole Oct 14, 2021, 4:24 PM

#

Besides the two of them aren't compatible

vale ibex Oct 14, 2021, 4:24 PM

#

oh, you did

green oriole Oct 14, 2021, 4:24 PM

#

Import order is already removed, yeah

vale ibex Oct 14, 2021, 4:26 PM

#

The package can be useful during dev for your ide to warn you