#dev-contrib | Python | Page 142

fallen patrol Oct 7, 2021, 4:13 PM

#

I think it's possible to lose the cache if a second instance of the bot is run at the same time

#

So it may be a deployment race issue

molten perch Oct 7, 2021, 4:47 PM

#

At first it is, yeah. It should fire up the postgres and api containers.

#

I don't really know. I only added the posgres part. However it didn't take so long for me.

clever wraith Oct 7, 2021, 5:02 PM

#

Why

molten perch Oct 7, 2021, 5:03 PM

#

It must be the Token Authentication Middleware.

#

But as of now, there's nothing that you would need from the API.
You can test the models with just an interactive python interpreter.

#

Well.. I resorted to a very inconsistent solution.. I exec'd inside the api container and ran an interactive python shell 😂
It's a temporary solution. But you can install the modules as well and connect to the database that you're running in the container.
(ofc. you'll need to create the engine and a session to test out the models, (that'll be a dependency in the actual API))

#

No, but you can run python

molten perch Oct 7, 2021, 5:35 PM

#

It seems like with one of the last commits I introduced a minor error, I pushed a fix, and it successfully built the relationships. The only thing to test is the embed validation. 🙂

#

But you can always check the relationships, just to make sure. lemon_fingerguns_shades

#

I don't think so, no.
https://docs.sqlalchemy.org/en/14/dialects/postgresql.html#sqlalchemy.dialects.postgresql.JSONB

#

Yeah, you have to create one.

#

I mean, you don't have to test the checks that are fairly straightforward. More like the ones that are more.. difficult.

#

That Constraint was generated from the actual database that is being used now. So, I don't think we should modify, there's a validation on the ORM side anyways.

#

Have you created a role with that id?

#

Hmm, have you run Base.metadata.create_all(bind=engine)?

#

Well.. yes. 😄

#

you can also use the "metadata" variable from the database package.

#

👍

austere hornet Oct 7, 2021, 6:43 PM

#

Hmm weird

#

I've seen it since I downloaded it a month ago iirc

#

Yeah

#

Ahhh

#

Ok

molten perch Oct 7, 2021, 6:50 PM

#

Even the embed validation?

#

Nevermind, it should work anyways. Thank you for the rest! 🙂

#

😆 Even better.

dusky shoreBOT Oct 7, 2021, 6:54 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

stable mountainBOT Oct 7, 2021, 7:08 PM

#

Sure thing!

Your reminder will arrive on <t:1633637323:F>!

dusky shoreBOT Oct 7, 2021, 7:08 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

trail pilot Oct 7, 2021, 7:25 PM

#

Would any core dev in their free time look at sir-lancebot#860? I think it just needs one more core dev approval before a merge

dusky shoreBOT Oct 7, 2021, 7:25 PM

#

GitHub

PROpen Challenges

gritty wind Oct 7, 2021, 7:32 PM

#

Ughhhhh joeeee git completely wiped out all my work when I merged the new main in :P

#

I'm gonna be dealing with merge conflicts for weeks 🤡

vocal wolf Oct 7, 2021, 7:33 PM

#

joe needs more e's in his name

dim pelican Oct 7, 2021, 7:39 PM

#

FYI the topic refresh reaction doesn't seem to be working in #sir-lancebot-playground

gritty wind Oct 7, 2021, 7:39 PM

#

Ok managed to unfuck it

vocal wolf Oct 7, 2021, 7:39 PM

#

@vale ibex What do you think of the state of this PR? https://github.com/python-discord/sir-lancebot/pull/555

vocal wolf Oct 7, 2021, 7:40 PM

#

dim pelican FYI the topic refresh reaction doesn't seem to be working in <#60724757960812135...

@vale ibex another ping. Does the user have to manually remove their own reaction for it to work?

#

.topic

dusky shoreBOT Oct 7, 2021, 7:40 PM

#

**What is your earliest memory of Easter?**

Suggest more topics here!

vocal wolf Oct 7, 2021, 7:40 PM

#

yep

dim pelican Oct 7, 2021, 7:40 PM

#

hmmm

vale ibex Oct 7, 2021, 7:42 PM

#

vocal wolf <@!126811506632294400> another ping. Does the user have to manually remove their...

yea, didn't add a call to remove the user's reaction

#

I could lie and say it was on purpose to avoid extra api calls, but it was just an oversight lol

vocal wolf Oct 7, 2021, 7:44 PM

#

prob should add remove reaction stuff so that we can reroll it multiple times easily

vale ibex Oct 7, 2021, 7:44 PM

#

yea, sounds like a good idea

vale ibex Oct 7, 2021, 7:44 PM

#

vocal wolf <@!126811506632294400> What do you think of the state of this PR? <https://githu...

uhhhh, don't remember ever looking over it myself

vocal wolf Oct 7, 2021, 7:45 PM

#

it's the oldest one on sir lance

static canyon Oct 7, 2021, 7:48 PM

#

Hey @brisk brook I completely forgot about bot#1836, I'm not able to do it tonight but I'll try to do it tomorrow

dusky shoreBOT Oct 7, 2021, 7:48 PM

#

GitHub

PROpen Fix typos and grammar in tags

static canyon Oct 7, 2021, 7:48 PM

#

Will ping you when I do 👍

#

!remind 24h Do this if haven't already ^

stable mountainBOT Oct 7, 2021, 7:48 PM

#

Yep.

Your reminder will arrive on <t:1633722532:F>!

dusky shoreBOT Oct 7, 2021, 7:52 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

patent pivot Oct 7, 2021, 7:57 PM

#

yeah, probably a more generous one than normal projects for now though

#

1 staff review & devops for devops files

molten perch Oct 7, 2021, 8:01 PM

#

They do. Afaik. contribs count as staff.

patent pivot Oct 7, 2021, 8:02 PM

#

hmmmm

#

for now we'll say staff only 1 review

#

i am proposing a 1 review requirement

molten perch Oct 7, 2021, 8:03 PM

#

Could you also look into that suggestion? https://github.com/python-discord/api/pull/17#issuecomment-933739292

patent pivot Oct 7, 2021, 8:04 PM

#

i'm fine with a notice like that yep, just need someone to draft it up

#

do which bit

#

not a form, just an addition to the template

#

https://policy-bot.pythondiscord.com/details/python-discord/api/17 policy ready

GitHub

Build software better, together

GitHub is where people build software. More than 65 million people use GitHub to discover, fork, and contribute to over 200 million projects.

#

just needs a basic one then

#

what did you change, what issues does it address, checkboxes

stable mountainBOT Oct 7, 2021, 8:08 PM

#

It has arrived!

Here's your reminder: Bump api#17
[Jump back to when you created the reminder](#dev-contrib message)

green oriole Oct 7, 2021, 8:10 PM

#

For what

#

Ah, uhh

#

Like in python?

patent pivot Oct 7, 2021, 8:17 PM

#

markdown

#

not yaml

#

we don't want a form

#

we just want a markdown file

#

so google moved us over to www.

#

that got picked up fast, google bot loves us

gritty wind Oct 7, 2021, 8:23 PM

#

What's the standard error for something considered a "programming error" (I'm thinking opposed to runtime error). I'm trying to raise an error if someone (programmer) passes a value to a function that isn't an expected input (the input is basically an enum)

#

The arg is always of type str, just that str is one a set of three possible values

#

Think a literal

stable mountainBOT Oct 7, 2021, 8:25 PM

#

ValueError


exception ValueError```
Raised when an operation or function receives an argument that has the right type but an inappropriate value, and the situation is not described by a more precise exception such as [`IndexError`](https://docs.python.org/3/library/exceptions.html#IndexError "IndexError").

gritty wind Oct 7, 2021, 8:25 PM

#

Right, that's technically correct, but it doesn't feel like it expressed the right idea

green oriole Oct 7, 2021, 8:25 PM

#

gritty wind What's the standard error for something considered a "programming error" (I'm th...

ValueError?

gritty wind Oct 7, 2021, 8:25 PM

#

more precise exception such as...

#

Does enum raise anything

green oriole Oct 7, 2021, 8:25 PM

#

I'd just use valueerror and call it a day

#

TypeError perhaps?

#

One of the two

gritty wind Oct 7, 2021, 8:26 PM

#

This is mostly to please intelisense anyways

#

It's always a str, so I'd just leave that to the type annotations

green oriole Oct 7, 2021, 8:26 PM

#

!d TypeError

stable mountainBOT Oct 7, 2021, 8:26 PM

#

TypeError


exception TypeError```
Raised when an operation or function is applied to an object of inappropriate type. The associated value is a string giving details about the type mismatch.

This exception may be raised by user code to indicate that an attempted operation on an object is not supported, and is not meant to be. If an object is meant to support a given operation but has not yet provided an implementation, [`NotImplementedError`](https://docs.python.org/3/library/exceptions.html#NotImplementedError "NotImplementedError") is the proper exception to raise.

Passing arguments of the wrong type (e.g. passing a [`list`](https://docs.python.org/3/library/stdtypes.html#list "list") when an [`int`](https://docs.python.org/3/library/functions.html#int "int") is expected) should result in a [`TypeError`](https://docs.python.org/3/library/exceptions.html#TypeError "TypeError"), but passing arguments with the wrong value (e.g. a number outside expected boundaries) should result in a [`ValueError`](https://docs.python.org/3/library/exceptions.html#ValueError "ValueError").

green oriole Oct 7, 2021, 8:26 PM

#

Yeah, use that one

dusky shoreBOT Oct 7, 2021, 8:28 PM

#

GitHub

PROpen Add a pull request template

gritty wind Oct 7, 2021, 8:28 PM

#

Rewrote the function so I never hit that error branch 🤡

green oriole Oct 7, 2021, 8:28 PM

#

lol

#

That solves it

dusky shoreBOT Oct 7, 2021, 8:30 PM

#

GitHub

PROpen Add a pull request template

patent pivot Oct 7, 2021, 8:30 PM

#

uhhh

#

i think we should use comments with a brief description of the content instead of examples

#

and we don't need an extra section I don't think for api

#

under the i confirm section

#

or

#

hm

#

sure, keep the section, add a comment above both telling people how to actually check it

#

also just shared this in staff but here is migration to www for all to enjoy

#

html comments

#

yea

#

probably not necessary

#

actually

#

we do on other repos

#

just stay in check with the other repos

#

lol

patent pivot Oct 7, 2021, 8:41 PM

#

patent pivot i think we should use comments with a brief description of the content instead o...

there was this

#

put the comments inside the blocks, also that "must be completed" bit can go, you just need to tell users how to actually check the boxes

#

yea

#

but say "replace with [x] to check boxes"

#

wrong bracket on line 10 otherwise lgtm

dusky shoreBOT Oct 7, 2021, 8:53 PM

#

GitHub

PROpen Add a pull request template

gritty wind Oct 7, 2021, 8:56 PM

#

Guys can someone explain how the redirects app works?

#

Like

#

roles_redirect:
    original_path: pages/roles/
    redirect_route: "content:page_category"
    redirect_arguments: ["server-info/roles"]

#

what's what here

#

redirect route is fine

#

but wth is original_path and redirect_argument

#

Like if I go to the main pydis site now, /pages/roles works with no redirect, but /server-info/roles 404s

patent pivot Oct 7, 2021, 8:57 PM

#

uhhh

#

no it doesn't

gritty wind Oct 7, 2021, 8:57 PM

#

https://www.pythondiscord.com/server-info/roles

patent pivot Oct 7, 2021, 8:57 PM

#

https://www.pythondiscord.com/pages/roles redirects to https://www.pythondiscord.com/pages/server-info/roles/

Python Discord - Python Discord Server Roles

Information on the various roles at Python Discord.

Python Discord - Python Discord Server Roles

Information on the various roles at Python Discord.

gritty wind Oct 7, 2021, 8:57 PM

#

I c

patent pivot Oct 7, 2021, 8:57 PM

#

it loads the content:page_category app (mounted at /pages/) with the arg of server-info/roles

#

nope, we need to split out API before we consider anything major for Django site

gritty wind Oct 7, 2021, 8:59 PM

#

I mean, what is there to consider until the API is done

#

right

patent pivot Oct 7, 2021, 8:59 PM

#

ah, well we do have an issue open that talks about moving to a python ssg

vocal prairie Oct 7, 2021, 9:00 PM

#

site#500 does briefly discuss that in steps 2, 3, and 4

dusky shoreBOT Oct 7, 2021, 9:00 PM

#

GitHub

IssueOpen Long-term: Deploy previews!

thorny obsidian Oct 7, 2021, 9:01 PM

#

patent pivot ah, well we do have an issue open that talks about moving to a python ssg

so question that I've been chewing on, with an ssg if I wanted to have a bit more of a dynamic/easy-to-update-without-a-pr calendar for events, is that possible? What does that look like?

vale ibex Oct 7, 2021, 9:02 PM

#

just hook into google calendar at this point lol

#

wouldn't be overly difficult with a decent scope

thorny obsidian Oct 7, 2021, 9:02 PM

#

vale ibex just hook into google calendar at this point lol

but that would require some shared calendar which we don't really have

patent pivot Oct 7, 2021, 9:02 PM

#

some form of calendar is the answer

vale ibex Oct 7, 2021, 9:03 PM

#

thorny obsidian but that would require some shared calendar which we don't really have

Anything we do is going to mean we need to make/setup something though right?

vocal prairie Oct 7, 2021, 9:03 PM

#

You could probably connect it to Notion (I think the API could do that)

patent pivot Oct 7, 2021, 9:03 PM

#

or just follow jamstack and have another database somewhere with all our events

patent pivot Oct 7, 2021, 9:03 PM

#

vocal prairie You could probably connect it to Notion (I think the API could do that)

that's a possibility

#

https://jamstack.org/

Jamstack.org

For fast and secure sites | Jamstack

What is the Jamstack? Why use the Jamstack? How do I get started? Learn what the Jamstack is all about and why it's the best approach for building faster, more secure websites.

thorny obsidian Oct 7, 2021, 9:04 PM

#

vale ibex Anything we do is going to mean we need to make/setup something though right?

well yeah, but I was curious if there's some accepted tech already used in similar situations I wasn't aware of. I considered gcalendar but the issue there is who owns it? How do you get easy access? Currently getting access to stuff that only owners or admins have access to is a bit of a headache and waiting game

patent pivot Oct 7, 2021, 9:04 PM

#

we would likely go for a python ssg so I don't know how much dynamic stuff we can get in there as opposed to if we did something like gatsby

gritty wind Oct 7, 2021, 9:04 PM

#

K, update on current static site: I've got redirects working (sort of, it doesn't update the URL, just displays the content as if you were redirected). Now we're just waiting on notion

patent pivot Oct 7, 2021, 9:04 PM

#

do you mean waiting on netlify

gritty wind Oct 7, 2021, 9:04 PM

#

bleh

#

too many n companies

patent pivot Oct 7, 2021, 9:04 PM

#

yeah they approved this morning lol forgot to tell you

gritty wind Oct 7, 2021, 9:04 PM

#

Joe!

#

Okay nice nice

patent pivot Oct 7, 2021, 9:04 PM

#

i am only like

#

8 hours late

gritty wind Oct 7, 2021, 9:04 PM

#

Lol it's alright

thorny obsidian Oct 7, 2021, 9:05 PM

#

patent pivot we would likely go for a python ssg so I don't know how much dynamic stuff we ca...

what's the benefits of a ssg over something a bit more dynamic?

gritty wind Oct 7, 2021, 9:05 PM

#

Static previews :O

thorny obsidian Oct 7, 2021, 9:05 PM

#

... time to google then

gritty wind Oct 7, 2021, 9:05 PM

#

Basically like what we had on forms

#

Where a PR would publish to a site, and anyone could access it

#

Without spinning up the project themselves

#

You're two days late bud 😛

thorny obsidian Oct 7, 2021, 9:06 PM

#

patent pivot Oct 7, 2021, 9:06 PM

#

thorny obsidian what's the benefits of a ssg over something a bit more dynamic?

you can have a dynamic jamstack app with ssg, that's where you use something like react.js or gatsby, but we likely wouldn't be doing down that route

vocal prairie Oct 7, 2021, 9:06 PM

#

thorny obsidian what's the benefits of a ssg over something a bit more dynamic?

This is a pretty good explanation or some of the benefits: https://jamstack.org/why-jamstack/

patent pivot Oct 7, 2021, 9:06 PM

#

we'd be using a python ssg which takes in templates (probably some sort of jinja thing) and spits out HTML

#

we can throw JS in there, but it'd only be fairly primitive browser JS compared to what all the fancy frameworks are doing nowadays

#

or we source events from somewhere at build time I guess

#

and then just have to rebuild site to add new events

thorny obsidian Oct 7, 2021, 9:07 PM

#

patent pivot you can have a dynamic jamstack app with ssg, that's where you use something lik...

hurm, we'd want to go for a python one because it's python or some other reason?

patent pivot Oct 7, 2021, 9:07 PM

#

gritty wind Oct 7, 2021, 9:07 PM

#

Can I like

#

get on your team

patent pivot Oct 7, 2021, 9:07 PM

#

thorny obsidian hurm, we'd want to go for a python one because it's python or some other reason?

we already have trouble getting js contribs for forms, main site being js too would likely drop contribution through the floor

vocal prairie Oct 7, 2021, 9:07 PM

#

thorny obsidian hurm, we'd want to go for a python one because it's python or some other reason?

Since the site is already in the Django template language, we'd need to use a SSG builder specifically for that

patent pivot Oct 7, 2021, 9:07 PM

#

gritty wind get on your team

yea let me see if i can do like github or something

patent pivot Oct 7, 2021, 9:07 PM

#

vocal prairie Since the site is already in the Django template language, we'd need to use a SS...

nah, this could involve a rewrite to something else

gritty wind Oct 7, 2021, 9:07 PM

#

Also that's not a lot of minutes 😕

#

Considering each deploy takes ~3 mins

patent pivot Oct 7, 2021, 9:08 PM

#

just as a matter of principle we would like to stick with python

thorny obsidian Oct 7, 2021, 9:08 PM

#

patent pivot we already have trouble getting js contribs for forms, main site being js too wo...

makes sense. Okay, time to do some more thinking and tooling around with other potential solutions

patent pivot Oct 7, 2021, 9:08 PM

#

gritty wind Also that's not a lot of minutes 😕

lemons workaround here was to build everything in github actions and then use the cli tool to deploy, you can still use different flags to get previews and whatnot

vocal prairie Oct 7, 2021, 9:08 PM

#

patent pivot nah, this could involve a rewrite to something else

Oh, I didn't realize that was being considered

thorny obsidian Oct 7, 2021, 9:08 PM

#

vocal prairie Oh, I didn't realize that was being considered

yeah, this is me asking for how this idea I have could fit into a far future project

gritty wind Oct 7, 2021, 9:09 PM

#

patent pivot lemons workaround here was to build everything in github actions and then use th...

That was my original - nice solution, but it required constantly approving the CI tool, and secrets aren't propagated to PRs, so we can't get previews

patent pivot Oct 7, 2021, 9:09 PM

#

ahh

gritty wind Oct 7, 2021, 9:09 PM

#

Unless there is some way to log into netlify cli with PRs?

patent pivot Oct 7, 2021, 9:09 PM

#

hmmmm

#

https://github.com/netlify/actions

GitHub

GitHub - netlify/actions

Contribute to netlify/actions development by creating an account on GitHub.

#

this bit specifically https://github.com/netlify/actions/tree/master/cli

gritty wind Oct 7, 2021, 9:10 PM

#

Right, but that won't get the secret will it?

dusky shoreBOT Oct 7, 2021, 9:10 PM

#

GitHub

PROpen Add a pull request template

gritty wind Oct 7, 2021, 9:10 PM

#

At least from my tests on my repo, the secrets aren't give to PRs

patent pivot Oct 7, 2021, 9:10 PM

#

oh you're right yeah

#

hmmm isn't that where you can rnu the pull_request_target things?

#

https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#pull_request_target

GitHub Docs

Events that trigger workflows - GitHub Docs

gritty wind Oct 7, 2021, 9:11 PM

#

Yeah, but that feels like dropping a layer of security, and I'm not sure if it's worth it yet

patent pivot Oct 7, 2021, 9:11 PM

#

yea

gritty wind Oct 7, 2021, 9:11 PM

#

If I fix caching, we should drop the time significantly from 3 minutes

patent pivot Oct 7, 2021, 9:11 PM

#

👍

gritty wind Oct 7, 2021, 9:11 PM

#

But, worst case scenario we're looking at ~300 builds a month

#

Would that be enough

#

Me and 50 commits

patent pivot Oct 7, 2021, 9:12 PM

#

we did a bit of trolling

gritty wind Oct 7, 2021, 9:13 PM

#

I'll clean up the branch and PR it while you get on the teams part joe

#

kthxbrb

vocal prairie Oct 7, 2021, 9:13 PM

#

commented again, sorry for all the disjointed stuff

#

How does removing the word "OR" change that?

#

I clicked the plus on that line 🤷‍♂️

patent pivot Oct 7, 2021, 9:18 PM

#

@gritty wind do you have a netlify account

gritty wind Oct 7, 2021, 9:18 PM

#

Oui

#

I uhh

patent pivot Oct 7, 2021, 9:18 PM

#

dm me the email on it

gritty wind Oct 7, 2021, 9:19 PM

#

Right, one sec

dusky shoreBOT Oct 7, 2021, 9:25 PM

#

GitHub

PROpen Add a pull request template

gritty wind Oct 7, 2021, 9:38 PM

#

lol nice

#

it was probably just bot.prefix at some point

#

Perhaps before it got the ping

#

Yup that's it

#

Game added october 2020, mention added august 21

austere hornet Oct 7, 2021, 10:09 PM

#

Same with Fronto's

#

Ah

gritty wind Oct 7, 2021, 10:14 PM

#

Is there any way for an HTML redirect to copy a fragment of the request URL?

i.e:
if someone makes a request to /a/b/resource_name, and I want to direct them to c/resource_name, is it possible to have /a/b/<anything> go to /c/<anything>

#

Ideally avoiding JS

#

Nah, just pure HTML

#

The whole "dynamic" part of the app doesn't super fly with the static site :P

#

The other alternative is generating tons of extra HTML files

late wolf Oct 7, 2021, 10:18 PM

#

sry for that

gritty wind Oct 7, 2021, 10:18 PM

#

The first google result will be an IBM link if you're curious lol

late wolf Oct 7, 2021, 10:19 PM

#

gritty wind The first google result will be an IBM link if you're curious lol

I found this page: https://css-tricks.com/redirect-web-page/ don't know if thats what u were looking for

#

but anyway, umm what are the fonts available in sir lancebot?

gritty wind Oct 7, 2021, 10:20 PM

#

Thanks

#

Seems that page suggests you use JS hm

#

Wdym by fonts

late wolf Oct 7, 2021, 10:21 PM

#

uh for image drawn using pillow

late wolf Oct 7, 2021, 10:21 PM

#

gritty wind Seems that page suggests you use JS hm

UH it also had html

gritty wind Oct 7, 2021, 10:23 PM

#

This is the part I'm referring to:

It's not an ideal solution and it's discouraged to use at all

late wolf Oct 7, 2021, 10:23 PM

#

right

#

So like, ex: I want to use fire code for typeface command which has the text displayed on an image, how would I do that?

late wolf Oct 7, 2021, 10:23 PM

#

late wolf uh for image drawn using pillow

For this

gritty wind Oct 7, 2021, 11:28 PM

#

https://www.youtube.com/watch?v=evthRoKoE1o
Y'all know this ^ video?

Well:
https://615f80944a7c1b0b247418a2--pydis-static.netlify.app/pages/resources/guides 🙂

https://615f80944a7c1b0b247418a2--pydis-static.netlify.app/pages/resources/videos 😄

https://615f80944a7c1b0b247418a2--pydis-static.netlify.app/pages/resources/interactive :| ???

https://615f80944a7c1b0b247418a2--pydis-static.netlify.app/pages/resources/reading 😭

austere hornet Oct 7, 2021, 11:45 PM

#

gritty wind <https://www.youtube.com/watch?v=evthRoKoE1o> Y'all know this ^ video? Well: <h...

Lmfao

hoary haven Oct 7, 2021, 11:47 PM

#

still want something? sir-lancebot#881

dusky shoreBOT Oct 7, 2021, 11:47 PM

#

GitHub

PROpen Duckduckduckgoose

hoary haven Oct 7, 2021, 11:47 PM

#

@clever wraith

clever wraith Oct 8, 2021, 12:31 AM

#

Oh ty

cursive relic Oct 8, 2021, 5:18 AM

#

why does @dusky shore react when .topic is ran? And why nothing happens when someone reacts to it as well, if anything is supposed to happen.

green oriole Oct 8, 2021, 5:46 AM

#

.topic

dusky shoreBOT Oct 8, 2021, 5:46 AM

#

**What's the best pastry?**

Suggest more topics here!

green oriole Oct 8, 2021, 5:46 AM

#

It does work

#

Did we mess up the check?

#

@cursive relic can you run topic and then click the reaction?

cursive relic Oct 8, 2021, 5:47 AM

#

.topic

#

uuh

green oriole Oct 8, 2021, 5:47 AM

#

lol

#

Okay, #sir-lancebot-playground

#

.source topic

dusky shoreBOT Oct 8, 2021, 5:47 AM

#

Command: topic

Responds with a random topic to start a conversation.

Source Code

Go to GitHub

brisk brook Oct 8, 2021, 5:48 AM

#

I think it is by design that I can't refresh it if it was Akarys who triggered the command.

cursive relic Oct 8, 2021, 5:49 AM

#

I can't refresh if I do it myself tho

green oriole Oct 8, 2021, 5:49 AM

#

https://github.com/python-discord/sir-lancebot/blob/e8e6067666b6b2b0f3d4ff07906942860c2baaf4/bot/exts/utilities/conversationstarters.py#L77

stable mountainBOT Oct 8, 2021, 5:49 AM

#

bot/exts/utilities/conversationstarters.py line 77

if is_moderator or user.id == message.author.id:```

green oriole Oct 8, 2021, 5:49 AM

#

Hmmm

#

!e print(False or 42 == 42)

stable mountainBOT Oct 8, 2021, 5:50 AM

#

@green oriole :white_check_mark: Your eval job has completed with return code 0.

True

green oriole Oct 8, 2021, 5:50 AM

#

Is it raising an error perhaps

#

Aha, it does

#

Wait, that's unrelated lol

cursive relic Oct 8, 2021, 5:51 AM

#

so there is just smth wrong but no error is raised?

green oriole Oct 8, 2021, 5:52 AM

#

Yeah

#

There is a logic error here I believe, but I can't spot it

#

It probably need proper debugging

#

Would you like to open an issue?

cursive relic Oct 8, 2021, 5:53 AM

#

does it raise error on last line, it raises False anyways

#

https://github.com/python-discord/sir-lancebot/blob/e8e6067666b6b2b0f3d4ff07906942860c2baaf4/bot/exts/utilities/conversationstarters.py#L80

stable mountainBOT Oct 8, 2021, 5:54 AM

#

bot/exts/utilities/conversationstarters.py line 80

return False```

cursive relic Oct 8, 2021, 5:54 AM

#

green oriole Would you like to open an issue?

Never opened one before

#

if you'd like to guide me on that, then I can surely open it

vocal prairie Oct 8, 2021, 5:56 AM

#

If you go here, the comments should explain it: https://github.com/python-discord/sir-lancebot/issues/new?assignees=&labels=type%3A+bug&template=bug-report.md&title=

cursive relic Oct 8, 2021, 5:58 AM

#

ah thx

#

uuh I'm bad at writing all the info. I can't come up with anything

#

All I came up with was ```
When user reacts to bots reaction, nothing happens on it.

green oriole Oct 8, 2021, 6:01 AM

#

Yup! If you need feedback on what to write, feel free to ask. It doesn't have to be really detailed, this is a simple issue

green oriole Oct 8, 2021, 6:01 AM

#

cursive relic All I came up with was ``` When user reacts to bots reaction, nothing happens on...

You should say that it does work with mods

cursive relic Oct 8, 2021, 6:01 AM

#

oh, right

green oriole Oct 8, 2021, 6:01 AM

#

If you feel like it, you can even link to the relevant portion of the code

cursive relic Oct 8, 2021, 6:01 AM

#

the check code part?

green oriole Oct 8, 2021, 6:02 AM

#

Yup

cursive relic Oct 8, 2021, 6:02 AM

#

as a link?

green oriole Oct 8, 2021, 6:02 AM

#

Do you know how to highlight lines on github?

#

If so, you can click copy perma link and paste the link in your issue

cursive relic Oct 8, 2021, 6:03 AM

#

hmm I don't think I know how to do it

green oriole Oct 8, 2021, 6:03 AM

#

If not.. I'll let someone else guide you through because I am late to my class

cursive relic Oct 8, 2021, 6:03 AM

#

Oh, have a good class. I will wait if someone knows how to write that

green oriole Oct 8, 2021, 6:03 AM

#

But what you should ask yourself when writing an issue is "What information do I need to give someone who doesn't know anything about the bug so they know what is the error and what we explored so far"

#

A'ight, bai

cursive relic Oct 8, 2021, 6:07 AM

#

Cya, I will try to add that info

fresh rock Oct 8, 2021, 6:17 AM

#

Hello, I am a newcomer, totally green. Trying to set everything up according to https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/sir-lancebot/ and I wonder if using gitpod is an alternative to using docker locally? Eg I run gitpod workspace and clone repo from CLI inside of it?

Python Discord - Contributing to Sir Lancebot

A guide to setting up and configuring Sir Lancebot.

cursive relic Oct 8, 2021, 6:29 AM

#

Any other information I should add? I can't come up with anything

hardy gorge Oct 8, 2021, 6:30 AM

#

What would be the reason for loading them dynamically?

cursive relic Oct 8, 2021, 6:32 AM

#

cursive relic Any other information I should add? I can't come up with anything

I can't really come up with anything that should be added

hardy gorge Oct 8, 2021, 6:38 AM

#

I don't think I would normally do that in a work project, since it adds some complexity, introduces a bit of magic, but does not seem to add that much over explicitly listing the subrouters

#

It's also easier to temporarily disable routers for debugging purposes if you have an explicit list

#

But I also don't see a great harm in it

cursive relic Oct 8, 2021, 7:41 AM

#

what do I put here?

green oriole Oct 8, 2021, 7:42 AM

#

You could put for example

Use .topic without any mod role

Click the reaction

Nothing happens

cursive relic Oct 8, 2021, 7:43 AM

#

Oh I think I will put that I there

#

I have explained what happens/what should happen. And platform desktop/mobile. And also the one who can implement it.

#

what about here?

green oriole Oct 8, 2021, 7:48 AM

#

Here, if you don't know how the bug is caused, you can remove that section

cursive relic Oct 8, 2021, 7:49 AM

#

I had this on desc, should I remove it? ```
There may be a problem on a check function here. But it's just a wild guess.

#

now it looks like this and I think it's good enough, I'd like to know if it is before making it

green oriole Oct 8, 2021, 7:55 AM

#

Lgtm

cursive relic Oct 8, 2021, 7:58 AM

#

sir-lancebot#894 is now opened

dusky shoreBOT Oct 8, 2021, 7:58 AM

#

GitHub

IssueOpen issue on .topic reaction

cursive relic Oct 8, 2021, 8:08 AM

#

it was weird opening a issue first time

green oriole Oct 8, 2021, 8:09 AM

#

That's a good learning experience :D

static canyon Oct 8, 2021, 8:12 AM

#

@cursive relic it's supposed to work for both the message author and moderators. If you're not either of those, then it won't work (as intended) https://github.com/python-discord/sir-lancebot/pull/880/commits/515c6390563f33a02af2e46fe6f3d13b15353a0a#diff-ace24dfc4bb3c55afff79de98551d97f9f6a0ecbd7b4d51d15ea1e32e2a0df2dR77

GitHub

Add a 2 minute cooldown to the topic command by ChrisLovering · Pul...

Relevant Issues

Closes #868
Description

Using the command while it's on cooldown will hit the error handler, which sends an error message showing how long is left on the cooldown, which ...

cursive relic Oct 8, 2021, 8:13 AM

#

If I try to do it myself it wont work

#

I can show it in #sir-lancebot-playground

static canyon Oct 8, 2021, 8:28 AM

#

Well I know what the issue is

#

It's listening for a reaction from message.author which is the bot

#

But then the bot doesn't trigger it either because there's an if statement stopping that

#

I'll fix this later today @cursive relic, thanks for the report + issue 👍

cursive relic Oct 8, 2021, 8:30 AM

#

Good to know, thx!

fresh rock Oct 8, 2021, 8:44 AM

#

hey, not sure if this is a right channel - I'd like to start with Lancebot and got a workflow question: can I insert my bot's token into a cloned sir-lancebot's repo and 'simulate' full lancelot on my server? Or should I develop my own bot locally and later in further steps merge it to lancebot?

#

got a bit lost, sry for noob question

static canyon Oct 8, 2021, 8:55 AM

#

fresh rock hey, not sure if this is a right channel - I'd like to start with Lancebot and g...

You can fork the GitHub repo and run the entirety of @dusky shore on your bot by using your own bot token

#

You just specify the token in the env/config file (can't remember which)

fresh rock Oct 8, 2021, 8:58 AM

#

oh wow thank you

static canyon Oct 8, 2021, 8:59 AM

#

fresh rock oh wow thank you

If you aren't already aware, there's a guide for this on our website under the "Contributing" section

fresh rock Oct 8, 2021, 9:00 AM

#

yes I am, I got lost following that guide

static canyon Oct 8, 2021, 9:00 AM

#

https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/sir-lancebot/

Python Discord - Contributing to Sir Lancebot

A guide to setting up and configuring Sir Lancebot.

fresh rock Oct 8, 2021, 9:03 AM

#

so maybe you could guide in one more issue - as I understand a gitpod is an alternative to local docker develpment, am I right?

#

If im using docker, shall I separately install poetry?

static canyon Oct 8, 2021, 9:07 AM

#

@brisk brook have just pushed the asyncio-tag changes to bot#1836

dusky shoreBOT Oct 8, 2021, 9:07 AM

#

GitHub

PROpen Fix typos and grammar in tags

static canyon Oct 8, 2021, 9:07 AM

#

fresh rock If im using docker, shall I separately install poetry?

If you're using docker, you need poetry

#

Gitpod is alternative to docker, yes -- I use docker myself so can only help with that

fresh rock Oct 8, 2021, 9:08 AM

#

ok, thank you

static canyon Oct 8, 2021, 9:15 AM

#

static canyon You just specify the token in the env/config file (can't remember which)

It's in the .env btw```c
BOT_TOKEN="YOUR_TOKEN_HERE"

#

You may have to create the file if it doesn't already exist

fresh rock Oct 8, 2021, 9:16 AM

#

exactly

#

it does not exist

static canyon Oct 8, 2021, 9:16 AM

#

Yeah, just create it then

#

It's because we've configured it so that git ignores .env files so you don't accidently upload your token etc.

#

And so the .env file isn't there when you clone/fork

fresh rock Oct 8, 2021, 9:17 AM

#

ok, so i got to touch .env and set all these https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/sir-lancebot/env-var-reference/#general-variables, right?

Python Discord - Sir-Lancebot Environment Variable Reference

The full environment variable reference for Sir-Lancebot.

static canyon Oct 8, 2021, 9:18 AM

#

Yeah, you do

#

It's a pain I know; we're working on something to make the setup easier

fresh rock Oct 8, 2021, 9:18 AM

#

ok, and once it's done I need to run main.py ?

static canyon Oct 8, 2021, 9:19 AM

#

For reference, this is my .env file```c
BOT_TOKEN="MY_TOKEN"
BOT_DEBUG=true
BOT_GUILD=476190141161930753
PREFIX="'"

USE_FAKEREDIS=true

AOC_ROLE_ID=651730380898041862
BOT_ADMIN_ROLE_ID=476190234653229056
LOVEFEST_ROLE_ID=795910065424171028
ROLE_HELPERS=476190429960732672

AOC_CHANNEL_ID=476190141161930755
AOC_COMMANDS_CHANNEL_ID=476196062214750219
CHANNEL_ANNOUNCEMENTS=476196024512413698
CHANNEL_COMMUNITY_BOT_COMMANDS=476196062214750219
CHANNEL_DEVLOG=476196115432210443
CHANNEL_REDDIT=476197119762366464
REDDIT_WEBHOOK=637295388998500352```

#

You may not need all of those though

static canyon Oct 8, 2021, 9:19 AM

#

fresh rock ok, and once it's done I need to run __main__.py ?

No, you do docker-compose build and then docker-compose up in the terminal (make sure you're in the bot's root directory first)

fresh rock Oct 8, 2021, 9:20 AM

#

ohhh, ok, sry for noob questions

#

thank you vm

static canyon Oct 8, 2021, 10:15 AM

#

@vale ibex is there a reason you put this wait_for in a while True: loop? https://github.com/python-discord/sir-lancebot/pull/880/files#diff-ace24dfc4bb3c55afff79de98551d97f9f6a0ecbd7b4d51d15ea1e32e2a0df2dR84-R95

#

I guess so you can re-roll multiple times, but then surely once it timeouts we want to break the loop?

vale ibex Oct 8, 2021, 10:17 AM

#

Yea, there should be a break after the supress block

static canyon Oct 8, 2021, 10:17 AM

#

👍

#

Right, time to test now

static canyon Oct 8, 2021, 10:44 AM

#

cursive relic why does <@!528937022996611082> react when `.topic` is ran? And why nothing happ...

Fixed in sir-lancebot#895, thanks again 👍

dusky shoreBOT Oct 8, 2021, 10:44 AM

#

GitHub

PROpen .topic command improvements

cursive relic Oct 8, 2021, 10:44 AM

#

Thx, it was weird opening a issue

static canyon Oct 8, 2021, 12:31 PM

#

@vale ibex with the suppresses, would it bepy with suppress(discord.NotFound): await message.edit(embed=self._build_topic_embed(message.channel.id)) await message.remove_reaction(reaction, user)orpy with suppress(discord.NotFound): await message.edit(embed=self._build_topic_embed(message.channel.id)) with suppress(discord.NotFound): await message.remove_reaction(reaction, user)?

#

I suppose the prior since if the message is deleted there's no point trying to remove the reaction

#

Or perhaps a try/except would be better, because then we can break

#

akapy try: await message.edit(embed=self._build_topic_embed(message.channel.id)) except discord.NotFound: break else: with suppress(discord.NotFound): await message.remove_reaction(reaction, user)

#

I think I prefer the try/except/else

clever wraith Oct 8, 2021, 12:39 PM

#

Morning all

dim pelican Oct 8, 2021, 12:40 PM

#

Morning GitPodifer

clever wraith Oct 8, 2021, 12:41 PM

#

Lol

#

Morning brad

vale ibex Oct 8, 2021, 1:09 PM

#

static canyon <@!126811506632294400> with the `suppress`es, would it be```py with suppress(dis...

Yea, the former preferably

#

both would work

#

I'm pretty sure if the first line raises an error the context manager will break anyway

#

rather than try the second line

#

worth double checking but I think that's the defined behaviour

#

!e ```py
from contextlib import suppress

with suppress(ValueError):
int("t")
print("context manager continues")

stable mountainBOT Oct 8, 2021, 1:15 PM

#

@vale ibex :warning: Your eval job has completed with return code 0.

[No output]

vale ibex Oct 8, 2021, 1:15 PM

#

yea, thought so

static canyon Oct 8, 2021, 1:15 PM

#

What about what I said with the try/except/else? @vale ibex

#

So that we get a break when the message is deleted

vale ibex Oct 8, 2021, 1:15 PM

#

what I showed above is that supress does that for us

#

if the first line raises NotFound, the second line isn't evaulated

static canyon Oct 8, 2021, 1:16 PM

#

supress will exit the while True: loop?

vale ibex Oct 8, 2021, 1:16 PM

#

oh, you're referring to the while true

static canyon Oct 8, 2021, 1:16 PM

#

yeah

vale ibex Oct 8, 2021, 1:16 PM

#

I think we just add the break outside the suppress

static canyon Oct 8, 2021, 1:16 PM

#

but then it'll always break

#

Which we don't want

#

We only want to break when the message is deleted

vale ibex Oct 8, 2021, 1:16 PM

#

can you show the code here?

static canyon Oct 8, 2021, 1:17 PM

#

static canyon aka```py try: await message.edit(embed=self._build_topic_embed(message.chann...

^

vale ibex Oct 8, 2021, 1:17 PM

#

I'm not quite following, probably because I don't remember

#

nah, the whole func

static canyon Oct 8, 2021, 1:17 PM

#

    async def _listen_for_refresh(
        self,
        command_invoker: Union[discord.User, discord.Member],
        message: discord.Message
    ) -> None:
        await message.add_reaction("🔄")
        while True:
            try:
                reaction, user = await self.bot.wait_for(
                    "reaction_add",
                    check=partial(self._predicate, command_invoker, message),
                    timeout=60.0
                )
            except asyncio.TimeoutError:
                with suppress(discord.NotFound):
                    await message.clear_reaction("🔄")
                break
            else:
                try:
                    await message.edit(embed=self._build_topic_embed(message.channel.id))
                except discord.NotFound:
                    break
                else:
                    with suppress(discord.NotFound):
                        await message.remove_reaction(reaction, user)```

vale ibex Oct 8, 2021, 1:18 PM

#

ah right ok, i get it now

#

lemme think

#

    async def _listen_for_refresh(
        self,
        command_invoker: Union[discord.User, discord.Member],
        message: discord.Message
    ) -> None:
        await message.add_reaction("🔄")
        while True:
            try:
                reaction, user = await self.bot.wait_for(
                    "reaction_add",
                    check=partial(self._predicate, command_invoker, message),
                    timeout=60.0
                )
            except asyncio.TimeoutError:
                with suppress(discord.NotFound):
                    await message.clear_reaction("🔄")
                break

            try:
                await message.edit(embed=self._build_topic_embed(message.channel.id))
            except discord.NotFound:
                break
            with suppress(discord.NotFound):
                await message.remove_reaction(reaction, user)

#

I think this is more readable, rather than the else blocks on the tries

#

since they're not needed and lead to more indentation

static canyon Oct 8, 2021, 1:22 PM

#

right, yeah. If we're breaking then the else isn't needed

vale ibex Oct 8, 2021, 1:22 PM

#

yea

static canyon Oct 8, 2021, 1:22 PM

#

Okay, will go for that and then re-push

vale ibex Oct 8, 2021, 1:22 PM

#

👌

static canyon Oct 8, 2021, 1:24 PM

#

Pushed 👍

#

Btw, can I make a separate PR for changing constants.py to use config for moderator role and owner role instead of hardcoding to the ids for this server?

vale ibex Oct 8, 2021, 1:25 PM

#

I don't think this else block is needed either https://github.com/python-discord/sir-lancebot/pull/895/files#diff-ace24dfc4bb3c55afff79de98551d97f9f6a0ecbd7b4d51d15ea1e32e2a0df2dR102

vale ibex Oct 8, 2021, 1:26 PM

#

static canyon Btw, can I make a separate PR for changing `constants.py` to use config for mode...

Yea, that's a good idea, lancebot has that in a few places, so feel free to commit them to env vars when needed

#

as long as you keep the defaults

static canyon Oct 8, 2021, 1:26 PM

#

yep

static canyon Oct 8, 2021, 1:27 PM

#

vale ibex I don't think this else block is needed either https://github.com/python-discord...

Pushed as well

static canyon Oct 8, 2021, 1:29 PM

#

vale ibex Yea, that's a good idea, lancebot has that in a few places, so feel free to comm...

Also should I change moderator to moderation_team?

green oriole Oct 8, 2021, 1:29 PM

#

If I can have a review on https://github.com/python-discord/sir-lancebot/pull/893#pullrequestreview-774930941 I'd greatly appreciate, the logs are unreadable atm

GitHub

Candy collection: fix positional arg being passed as kword by Akary...

Relevant Issues

Approved by myself
Description

Removed the id keyword. This caused a TypeError to be raised, as the id argument could only be used as a positional argument and not by keyword.
Di...

#

Thank you sir jl

vale ibex Oct 8, 2021, 1:29 PM

#

static canyon Also should I change `moderator` to `moderation_team`?

Yea, just do them in two commits

#

IE one to change the name in all the places, another to make it pull form env var

#

will make it easier to review

static canyon Oct 8, 2021, 1:30 PM

#

Right, okay

#

And finallypy admin = int(environ.get("BOT_ADMIN_ROLE_ID", 267628507062992896))should I rename the value to be ROLE_ADMIN so it's consistent with the others? @vale ibex

vale ibex Oct 8, 2021, 1:32 PM

#

I'd argue that if they're in a Role class, having a role suffix at all is redundant

static canyon Oct 8, 2021, 1:32 PM

#

vale ibex I'd argue that if they're in a Role class, having a `role` suffix at all is redu...

The variables don't, the envs do

#

Since in the .env there's no "classes"

vale ibex Oct 8, 2021, 1:32 PM

#

yea, envs make sense, since there's no context

static canyon Oct 8, 2021, 1:32 PM

#

I'm referring to that here

vale ibex Oct 8, 2021, 1:32 PM

#

I assumed you were referring to the variable name not having the role suffix

static canyon Oct 8, 2021, 1:32 PM

#

get("BOT_ADMIN_ROLE_ID", ...) --> get("ROLE_ADMIN", ...)

vale ibex Oct 8, 2021, 1:33 PM

#

Ah, I thought you were referring to the variable name not being consistent

static canyon Oct 8, 2021, 1:34 PM

#

i.e. without changing it would be```py
class Roles(NamedTuple):
owner = int(environ.get("ROLE_OWNER", 267627879762755584))
admin = int(environ.get("BOT_ADMIN_ROLE_ID", 267628507062992896))
moderation_team = int(environ.get("ROLE_MODERATION_TEAM", 267629731250176001))
helpers = int(environ.get("ROLE_HELPERS", 267630620367257601))
core_developers = int(environ.get("ROLE_CORE_DEVELOPERS", 587606783669829632))
everyone = int(environ.get("BOT_GUILD", 267624335836053506))

vale ibex Oct 8, 2021, 1:34 PM

#

changing actualy env var names isn't a good idea since it may lead to confusion to contribs since their .env won't work anymore

static canyon Oct 8, 2021, 1:34 PM

#

vale ibex Ah, I thought you were referring to the variable name not being consistent

The env-variable named

static canyon Oct 8, 2021, 1:35 PM

#

vale ibex changing actualy env var names isn't a good idea since it may lead to confusion ...

Eh, I guess.

#

I'll leave it then

#

Also I suppose the contributing docs would need to be updated

#

i.e. https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/sir-lancebot/env-var-reference/#general-variables

Python Discord - Sir-Lancebot Environment Variable Reference

The full environment variable reference for Sir-Lancebot.

vale ibex Oct 8, 2021, 1:36 PM

#

yea, there's no need to update them before this gets merged

#

since you're adding more options, rather than removing them

static canyon Oct 8, 2021, 1:36 PM

#

mhm

vale ibex Oct 8, 2021, 1:36 PM

#

it may also be something that wants to wait for Zig's pr to be merged too

#

since I'm not sure if it would conflict

static canyon Oct 8, 2021, 1:36 PM

#

static canyon Also I suppose the contributing docs would need to be updated

It was more a question of "can I do this by submitting a PR or does joe/admin have to do?"

vale ibex Oct 8, 2021, 1:36 PM

#

Yea, anyone can submit to that

#

it's on the site repo

static canyon Oct 8, 2021, 1:37 PM

#

👍

#

I guess the changes would need to be reflected in https://github.com/python-discord/site/blob/main/pydis_site/apps/content/resources/guides/pydis-guides/contributing/sir-lancebot/env-var-reference.md#L7 and https://github.com/python-discord/site/blob/main/pydis_site/apps/content/resources/guides/pydis-guides/contributing/sir-lancebot.md#L67

#

(In those files)

vale ibex Oct 8, 2021, 1:42 PM

#

seems about right yea

#

not sure if Zig's PR changed those files or not

static canyon Oct 8, 2021, 1:43 PM

#

I'll check before I do the PR

static canyon Oct 8, 2021, 1:59 PM

#

vale ibex not sure if Zig's PR changed those files or not

If you're referring to site#591 that only touches @stable mountain stuff, so no, it doesn't touch the two files in question

dusky shoreBOT Oct 8, 2021, 1:59 PM

#

GitHub

PROpen Restructure bot contributing guide

static canyon Oct 8, 2021, 2:42 PM

#

Have pushed these changes to site#607 and sir-lancebot#896; think I've linked them as best as I can (just mentioning the other issue)

CC @vale ibex

dusky shoreBOT Oct 8, 2021, 2:42 PM

#

GitHub

PROpen Sir-Lancebot env changes
PROpen Update constants.Roles

late wolf Oct 8, 2021, 4:43 PM

#

def convert_to_image(text:str, filename) -> discord.File:
    """Converts the given text into an image."""
    im = Image.new("RGB", (1200, 1024), "black")
    font = ImageFont.truetype('bot/resources/fun/FiraCode-Retina.ttf')

    draw_image = Image.Draw(im)
    text = text.split()
    split_text_evenly = '\n'.join(
    ' '.join(text[i : i + 8]) for i in range(0, len(text), 8)
        )  
    draw_image.multiline_text(
            (10, 10), 
            split_text_evenly,
            font=font,
            fill=255
        )

    buffer = BytesIO() 
    im.save(buffer, format="PNG")
    return discord.File(buffer, filename=filename)

Should this function be ran in an executor?

molten perch Oct 8, 2021, 5:03 PM

#

Would someone mind to take a look at sir-lancebot#857 ? It's close to be merged.

dusky shoreBOT Oct 8, 2021, 5:03 PM

#

GitHub

PROpen Add support to query AoC results in respect of days and stars

dusky shoreBOT Oct 8, 2021, 6:05 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

molten perch Oct 8, 2021, 6:11 PM

#

If I may, I think we should migrate a few endpoints to FastAPI to get used to the context etc. etc.(We should also test to those endpoints) (and migrate the models first of all 😉 )
(Also, we can just introduce a decorator to temporarily disable routers based on a list.)

dusky shoreBOT Oct 8, 2021, 6:43 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

clever wraith Oct 8, 2021, 6:43 PM

#

@vocal wolf , cowsay was closed because the branch was stale and a new branch was created. ill open a new PR once the rewrite with cowpy is donw

#

done

vocal wolf Oct 8, 2021, 6:44 PM

#

clever wraith <@!196664644113268736> , cowsay was closed because the branch was stale and a ne...

ok

dusky shoreBOT Oct 8, 2021, 6:45 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

clever wraith Oct 8, 2021, 6:45 PM

#

the branch was 2 months old lemon_sweat

dusky shoreBOT Oct 8, 2021, 6:49 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

vocal wolf Oct 8, 2021, 6:55 PM

#

I don't know SQLAlchemy

stable mountainBOT Oct 8, 2021, 7:48 PM

#

static canyon !remind 24h Do this if haven't already ^

It has arrived!

Here's your reminder: Do this if haven't already ^
[Jump back to when you created the reminder](#dev-contrib message)

trail pilot Oct 8, 2021, 8:39 PM

#

What happened to sir-lancebot#778?

dusky shoreBOT Oct 8, 2021, 8:39 PM

#

GitHub

PROpen Merge automatic issue linking into the github cog

trail pilot Oct 8, 2021, 8:39 PM

#

It seems like it's been approved for a while

#

Also, when threads can be used by the Python bot, I think the quiz command and hangman command (multiplayer, suggested by Bluenix in sir-lancebot#872) should migrate to threads because quiz uses the entire channel

dusky shoreBOT Oct 8, 2021, 8:42 PM

#

GitHub

IssueOpen Reintroduce hangman multiplayer

trail pilot Oct 8, 2021, 8:42 PM

#

What do you all think?

brisk brook Oct 8, 2021, 9:05 PM

#

Yeah I think all of those commands should use threads

patent pivot Oct 8, 2021, 9:13 PM

#

which PR?

dusky shoreBOT Oct 8, 2021, 9:28 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

patent pivot Oct 8, 2021, 9:28 PM

#

looks fine to me?

#

#

uhhh can’t right now, maybe later

#

!remind 2h that

stable mountainBOT Oct 8, 2021, 9:30 PM

#

Okay.

Your reminder will arrive on <t:1633735820:F>!

molten perch Oct 8, 2021, 9:40 PM

#

Yaay, thank you for the PR campaign 😆

static canyon Oct 8, 2021, 9:41 PM

#

@thorny obsidian for sir-lancebot#861 which of these two were you envisioning (or something else)?

dusky shoreBOT Oct 8, 2021, 9:41 PM

#

GitHub

IssueOpen .timeleft command should be a subcommand of hacktoberfest

thorny obsidian Oct 8, 2021, 9:53 PM

#

static canyon <@!212644551926611969> for sir-lancebot#861 which of these two were you envision...

Uhhhh, I would probs want everything hacktoberfest related to be under the hacktoberfest subgroup just to ensure we don't clutter the command namespace

#

That way if we ever did want a future .stats command to pull fun pydis stats it won't conflict (as a hypothetical example)

static canyon Oct 8, 2021, 9:55 PM

#

Right, okay

#

There's also the fact that current there's 3 different files for hacktoberfest (excluding __init__.py)

#

One file for issue-finder, one for hacktoberstats, and one for timeleft.

If we want to move them all into the hacktoberfest subcommand namespace then I'm guessing we'll have to combine these files into one file (which will be messy)? @thorny obsidian

#

Unless imports work I guess

#

There's no actual "hacktoberfest" command currently so we'd need to decide how to structure it all

#

I don't like the idea of having it all in one big file (said file would be ~650 lines)

thorny obsidian Oct 8, 2021, 10:06 PM

#

Hmmmm, let me take a look after I'm done working and I may be able to provide better clarification

static canyon Oct 8, 2021, 10:06 PM

#

Ping me when you respond please as I'm going to bed now, so will look when I wake up 👍

dim pelican Oct 8, 2021, 10:13 PM

#

Hey Rick, got time to push that color file?

#

Not that I'll likely have time to work on it over the weekend lol

stable mountainBOT Oct 8, 2021, 10:14 PM

#

Aye aye, cap'n!

Your reminder will arrive on <t:1633774440:F>!

dim pelican Oct 8, 2021, 10:14 PM

#

No worries, !sleep -force doublevcodes

#

oof

austere hornet Oct 8, 2021, 10:15 PM

#

Lmao

dim pelican Oct 8, 2021, 10:15 PM

#

shoulda sudo'd

stable mountainBOT Oct 8, 2021, 11:30 PM

#

patent pivot !remind 2h that

It has arrived!

Here's your reminder: that
[Jump back to when you created the reminder](#dev-contrib message)

fervent sage Oct 9, 2021, 8:29 AM

#

dim pelican No worries, `!sleep -force doublevcodes`

unpopular opinion: -word should be annihilated in favour of --word

#

-word removes the whole benefit of being able to do multiple flags following a single -

stable mountainBOT Oct 9, 2021, 10:14 AM

#

It has arrived!

Here's your reminder: push colour file smh
[Jump back to when you created the reminder](#dev-contrib message)

late wolf Oct 9, 2021, 1:33 PM

#

Uh, the bot just randomly sent this in my test server.
wut just happened?

vocal prairie Oct 9, 2021, 1:38 PM

#

Sir Lancebot doesn't have any functionality like that, are you sure it isn't a different bot?

late wolf Oct 9, 2021, 1:39 PM

#

Absolutely, cause thats the only one there.

sir-lancebot  | 10/09/21 11:59:09 - bot.exts.fun.typerace TRACE: Running convert_to_image in an executor
sir-lancebot  | 10/09/21 11:59:59 - bot.exts.holidays.halloween.spookyreact DEBUG: Ignoring reactions on self message. Message ID: 896366383984701480

vocal prairie Oct 9, 2021, 1:40 PM

#

Oh wait, that probably is a Sir Lance command, nvm

#

I thought you meant as an unprovoked message

#

You most likely accidentally triggered one of the commands inside the cog, that's all

molten perch Oct 9, 2021, 1:47 PM

#

It seems to be a loop that runs every day in October. 😄
https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/holidays/halloween/spookynamerate.py#L215:L216

stable mountainBOT Oct 9, 2021, 1:47 PM

#

bot/exts/holidays/halloween/spookynamerate.py lines 215 to 216

@tasks.loop(hours=24.0)
async def announce_name(self) -> None:```

late wolf Oct 9, 2021, 1:47 PM

#

ah

vocal prairie Oct 9, 2021, 1:47 PM

#

...why? I don't see what's the point in that.

molten perch Oct 9, 2021, 1:48 PM

#

It's a game. 😄

vocal prairie Oct 9, 2021, 1:48 PM

#

Yeah, but do we really want an unprovoked message every 24 hours? Or is it a core part of the game to happen that often?

#

Oh I see, it's sort of like a leaderboard

#

I personally think it would be better to have that as a command rather than a looped message

molten perch Oct 9, 2021, 1:52 PM

#

I mean, it's sort of the point of the game that it runs every day, and everyone can play. Then the next day it announces the winners of the last day as well.

timid sentinel Oct 9, 2021, 2:05 PM

#

what's up with the <function when mentioned or... bit, seems like bot.command_prefix isn't a string? Is that something that changed at some point?

molten perch Oct 9, 2021, 2:51 PM

#

timid sentinel what's up with the `<function when mentioned or...` bit, seems like `bot.command...

Yes, it was. https://discordpy.readthedocs.io/en/master/ext/commands/api.html?highlight=when_mentioned#discord.ext.commands.when_mentioned_or
It seems like that function returns another callable.

timid sentinel Oct 9, 2021, 2:54 PM

#

I think we should just be using constants.Client.prefix instead

molten perch Oct 9, 2021, 2:55 PM

#

Might be the best, this callable it returns needs: a bot instance, and a message as arguments, I'm not sure why though.

vale ibex Oct 9, 2021, 2:56 PM

#

timid sentinel I think we should just be using `constants.Client.prefix` instead

It allows you to do things like

#

@stable mountain help

stable mountainBOT Oct 9, 2021, 2:56 PM

#

Command Help

Big Brother
!bigbrother
Monitors users by relaying their messages to the Big Brother watch channel.
!bigbrother unwatch <user> <reason>
Stop relaying messages by the given user.
!bigbrother watch <user> <reason>
Relay messages sent by the given user to the #big-brother channel.

Bot
!echo [channel] <text>
Repeat the given message in either a specified channel or the current channel.
!embed [channel] <text>
Send the input within an embed to either a specified channel or the current channel.

BotSource
!source [source_item]
Display information and a GitHub link to the source code of a command, tag, or cog.

Branding
!branding
Control the branding cog.

Clean
!clean
Commands for cleaning messages in channels.

timid sentinel Oct 9, 2021, 2:56 PM

#

yeah the problem is that we're using bot.command_prefix in help commands to show the user the prefix

vale ibex Oct 9, 2021, 2:57 PM

#

Yea, in the help command we should just use the constant then

timid sentinel Oct 9, 2021, 2:57 PM

#

yep

molten perch Oct 9, 2021, 2:58 PM

#

This function(the one that gets returned) also returns the prefix, but I don't think it's worth the effort at all, when we can use the constant 😄

gritty wind Oct 9, 2021, 3:05 PM

#

We have quite a few commands that send stuff like this for different months

#

We have for valentine too

#

Thing is, it goes into #sir-lancebot-playground

#

The probability anyone’s ever seen that hovers between 0 and zilch

#

But you’ll have seen it if you tested the bots in those months

#

We have a lot of inexplicable stuff like that, most very old

#

There’s that candy minigame which adds random candy emotes to certain messages, and keeps a leaderboard for who clicks them

#

But without context (which it always will be) it’s just confusing and pointless

dusky shoreBOT Oct 9, 2021, 3:33 PM

#

GitHub

IssueOpen Long-term: Deploy previews!

gritty wind Oct 9, 2021, 3:42 PM

#

@hardy gorge would you like to get one in first?

last patio Oct 9, 2021, 3:48 PM

#

I can also merge it, up to you

hardy gorge Oct 9, 2021, 4:10 PM

#

If it's been reviewed, it's fine to merge it

dusky shoreBOT Oct 9, 2021, 4:13 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

last patio Oct 9, 2021, 4:19 PM

#

merged master

#

gonn await for CI and then merge

molten perch Oct 9, 2021, 4:26 PM

#

Wow, Thank you! @last patio

vocal prairie Oct 9, 2021, 4:40 PM

#

You can click "edit" in the upper right (the one you click to change the name" and change the branch iirc

#

oh wait, yeah, oops

gritty wind Oct 9, 2021, 5:01 PM

#

If you really wanted, you can merge your new branch into your main, but there is no problem with opening/closing provided you don't have any reviews yet

cold moon Oct 9, 2021, 5:42 PM

#

@mellow hare About https://github.com/python-discord/site/issues/605 , so we need to create new infraction type voicemute and rename all current voiceban infractions to voicemute in DB?

GitHub

Add new infraction type to backend · Issue #605 · python-discord/si...

In regards to python-discord/bot#1849 The linked issue will do the following: Rename the current voiceban command to voicemute Create a new command called voiceban So we will need to add a relevant...

green oriole Oct 9, 2021, 7:07 PM

#

cold moon <@!98195144192331776> About https://github.com/python-discord/site/issues/605 , ...

Yup!

#

You can use a RunPython step inside your migration for that

patent pivot Oct 9, 2021, 7:13 PM

#

do we use enums for infractions?

#

can't we use something like ALTER TYPE colors RENAME VALUE 'purple' TO 'mauve';

#

from https://www.postgresql.org/docs/10/sql-altertype.html

PostgreSQL Documentation

ALTER TYPE

ALTER TYPE ALTER TYPE — change the definition of a type Synopsis ALTER TYPE name action [, ... ] ALTER …

cold moon Oct 9, 2021, 7:15 PM

#

I don't think so. Looks like just choices at code side.

green oriole Oct 9, 2021, 7:21 PM

#

patent pivot can't we use something like `ALTER TYPE colors RENAME VALUE 'purple' TO 'mauve';...

Raw SQL bad though

patent pivot Oct 9, 2021, 7:21 PM

#

raw SQL for the whole application is bad because then generally no one does migrations

#

but for migrations raw SQL is fairly common providing the ORM understands the before and after

patent pivot Oct 9, 2021, 7:22 PM

#

cold moon I don't think so. Looks like just choices at code side.

yea it's possible we don't use enums, will double check once home though

#

!remind 1h that

stable mountainBOT Oct 9, 2021, 7:22 PM

#

Of course!

Your reminder will arrive on <t:1633810943:F>!

green oriole Oct 9, 2021, 7:24 PM

#

I feel like using python for this is way simpler and will avoid making django understand one type is gone but the other isn't, and it actually has to recreate voice_ban but it has to add voice_mute to its internal registry

molten perch Oct 9, 2021, 7:45 PM

#

@cold moon Would you mind opening an issue in the API repository regarding your recent model changes? I believe a pull request template was added to indicate this, but it's relatively new. 😄

cold moon Oct 9, 2021, 7:53 PM

#

molten perch <@!446310592425361418> Would you mind opening an issue in the API repository reg...

I think work hasn't started yet to migrate endpoints to new API, only offtopic names.

molten perch Oct 9, 2021, 7:54 PM

#

No, it hasn't but a PR has just been merged, that migrated models from Django the SQLAlchemy.
That's the reason why https://github.com/python-discord/site/blob/main/.github/PULL_REQUEST_TEMPLATE/pull_request.md was added yesterday.

cold moon Oct 9, 2021, 7:57 PM

#

Oh, looks like if you create PR using recent push notification, then you don't see templates.

#

I will open issue tomorrow

#

!remindme 12h this

stable mountainBOT Oct 9, 2021, 7:57 PM

#

Of course!

Your reminder will arrive on <t:1633852671:F>!

stable mountainBOT Oct 9, 2021, 8:22 PM

#

patent pivot !remind 1h that

It has arrived!

Here's your reminder: that
[Jump back to when you created the reminder](#dev-contrib message)

vale ibex Oct 9, 2021, 10:17 PM

#

It's shouldn't do no

#

Shouldn't really take >5 seconds

#

Do you have a branch I can checkout?

#

alright

#

sure, send me the config

gritty wind Oct 9, 2021, 10:21 PM

#

Did you google how to make your own search engine?

#

Happens to the best of us

#

Just sign the non-compete form - provided you can find it

vale ibex Oct 9, 2021, 10:23 PM

#

Do you share the network with others?

gritty wind Oct 9, 2021, 10:23 PM

#

Lol are you on a pub network

vale ibex Oct 9, 2021, 10:23 PM

#

Yea, then it's likely that either you, or someone on that network is sending traffic that looks like automated scraping

#

it could also be from an extension you have

vale ibex Oct 9, 2021, 10:45 PM

#

I think it's the --diff arg on the flake8 call that's causing the issue

#

flake8 will wait to be passed a diff via stdin

#

pre-commit itself does the pruning of files anyway, so there's no need to use --diff

#

So I'd just go for ```yaml
repos:

repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.0.1
hooks:
- id: check-merge-conflict
- id: check-toml
- id: check-yaml
- id: end-of-file-fixer
- id: trailing-whitespace
  args: [--markdown-linebreak-ext=md]
repo: https://github.com/pre-commit/pygrep-hooks
rev: v1.9.0
hooks:
- id: python-check-blanket-noqa
repo: local
hooks:
- name: Black
  description: Runs Black within the project environment
  id: black
  entry: poetry run black . --check
  language: system
  types: [python]
  require_serial: true
- name: Flake8
  description: Runs Flake8 within the project environment
  id: flake8
  entry: poetry run flake8
  language: system
  types: [python]
  require_serial: true

stable mountainBOT Oct 9, 2021, 10:49 PM

#

No problem.

Your reminder will arrive on <t:1633855761:F>!

vale ibex Oct 9, 2021, 10:49 PM

#

vale ibex pre-commit itself does the pruning of files anyway, so there's no need to use --...

yea, fwiw, what I mean here is that the pre-commit hooks only get ran against files that are staged

#

and that's managed by pre-commit

gritty wind Oct 9, 2021, 10:52 PM

#

Oooooooooooookay it's taken some work but I've now gotten static previews PR open

#

I'll hammer out some caching stuff, but it should be otherwise basically good to review

#

site#609

dusky shoreBOT Oct 9, 2021, 10:52 PM

#

GitHub

PRDraft Static Previews

vale ibex Oct 9, 2021, 10:52 PM

#

oh nice nice

gritty wind Oct 9, 2021, 10:52 PM

#

I'd also like thoughts on the redirects app

#

I've left a comment there describing the problem

#

I tend to agreetothis

vale ibex Oct 9, 2021, 10:53 PM

#

What do we use redirects for in the site?

gritty wind Oct 9, 2021, 10:53 PM

#

I think an old article or guide still had an old URL

#

which is fine, it just goes through a redirect on the main site

#

but that's not easy here

#

Let me find it

vale ibex Oct 9, 2021, 10:54 PM

#

Ahh yea, there's also https://www.pythondiscord.com/pages/*/ -> https://www.pythondiscord.com/*/

gritty wind Oct 9, 2021, 10:55 PM

#

Funny enough, I got all page redirects working

#

It's just "two" that don't work yet

vale ibex Oct 9, 2021, 10:55 PM

#

Ah right, are they important? or can they just be removed

gritty wind Oct 9, 2021, 10:55 PM

#

/resources/reading, etc

gritty wind Oct 9, 2021, 10:56 PM

#

gritty wind <https://www.youtube.com/watch?v=evthRoKoE1o> Y'all know this ^ video? Well: <h...

I wrote this about the /resources/<w/e> problem

#

I also wrote this to open every single redirect for testing:
https://paste.pythondiscord.com/uhomeduhuz.py

#

Acc I may have fixed /events/resources, gotta check real quick

vale ibex Oct 9, 2021, 10:57 PM

#

lol

#

Just saw that post

gritty wind Oct 9, 2021, 10:58 PM

#

Nop, /events/resources is still broken :)

#

Acctually... I'm not seeing a redirect called /events/resources

#

Must've imagined that one

#

I also just figured out the other issue, so now it's down to /resources/<...>

#

How come every time I complain about something, it just works

full fractal Oct 9, 2021, 11:20 PM

#

bot_1        | Traceback (most recent call last):
bot_1        |   File "/bot/bot/api.py", line 66, in maybe_raise_for_status
bot_1        |     response_json = await response.json()
bot_1        |   File "/usr/local/lib/python3.9/site-packages/aiohttp/client_reqrep.py", line 1097, in json
bot_1        |     raise ContentTypeError(
bot_1        | aiohttp.client_exceptions.ContentTypeError: 0, message='Attempt to decode JSON with unexpected mimetype: text/html', url=URL('http://api.web:8000/healthcheck')
bot_1        | 
bot_1        | During handling of the above exception, another exception occurred:
bot_1        | 
bot_1        | Traceback (most recent call last):
bot_1        |   File "/bot/bot/bot.py", line 251, in login
bot_1        |     await self.ping_services()
bot_1        |   File "/bot/bot/bot.py", line 99, in ping_services
bot_1        |     await self.api_client.get("healthcheck")
bot_1        |   File "/bot/bot/api.py", line 80, in get
bot_1        |     return await self.request("GET", endpoint, raise_for_status=raise_for_status, **kwargs)
bot_1        |   File "/bot/bot/api.py", line 75, in request
bot_1        |     await self.maybe_raise_for_status(resp, raise_for_status)
bot_1        |   File "/bot/bot/api.py", line 70, in maybe_raise_for_status
bot_1        |     raise ResponseCodeError(response=response, response_text=response_text)
bot_1        | bot.api.ResponseCodeError: Status: 404 Response: <!DOCTYPE html>

what did I fuck up this time 😦

#

I'm trying to setup an instance of the @stable mountain bot using the staff bot test server (and its instructions) and I get this error at startup...

gritty wind Oct 9, 2021, 11:23 PM

#

What do you see if you navigate to http://api.web:8000/healthcheck

#

http://api.web:8000/healthcheck

#

Maaay have to change api.web to localhost to give me an answer

#

Ah actually, I do know

#

Either your bot or site is out of date

#

Make sure to pull main

full fractal Oct 9, 2021, 11:25 PM

#

I did gh repo clone python-discord/bot earlier today ...

#

sigh

brazen charm Oct 9, 2021, 11:25 PM

#

weren't subdomains removed recently or something like that

gritty wind Oct 9, 2021, 11:25 PM

#

Yup, but I think that happened yesterday

#

hmm hm

#

Ah it might be your config

full fractal Oct 9, 2021, 11:25 PM

#

FWIW these instructions were super unclear: https://www.notion.so/pythondiscord/config-yml-1673fcd1232048b5a9bd2cc47c2f2769#146b7bb32d37483e96fd01dce64a8ec3

brazen charm Oct 9, 2021, 11:25 PM

#

try web:8000/api for the url

gritty wind Oct 9, 2021, 11:26 PM

#

That wouldn't get updated with the clone

full fractal Oct 9, 2021, 11:27 PM

#

bot_1        | Traceback (most recent call last):
bot_1        |   File "/usr/local/lib/python3.9/runpy.py", line 197, in _run_module_as_main
bot_1        |     return _run_code(code, main_globals, None,
bot_1        |   File "/usr/local/lib/python3.9/runpy.py", line 87, in _run_code
bot_1        |     exec(code, run_globals)
bot_1        |   File "/bot/bot/__main__.py", line 15, in <module>
bot_1        |     bot.instance.run(constants.Bot.token)
bot_1        |   File "/usr/local/lib/python3.9/site-packages/discord/client.py", line 723, in run
bot_1        |     return future.result()
bot_1        |   File "/usr/local/lib/python3.9/site-packages/discord/client.py", line 702, in runner
bot_1        |     await self.start(*args, **kwargs)
bot_1        |   File "/usr/local/lib/python3.9/site-packages/discord/client.py", line 665, in start
bot_1        |     await self.login(*args, bot=bot)
bot_1        |   File "/bot/bot/bot.py", line 256, in login
bot_1        |     await self.cache_filter_list_data()
bot_1        |   File "/bot/bot/bot.py", line 87, in cache_filter_list_data
bot_1        |     full_cache = await self.api_client.get('bot/filter-lists')
bot_1        |   File "/bot/bot/api.py", line 80, in get
bot_1        |     return await self.request("GET", endpoint, raise_for_status=raise_for_status, **kwargs)
bot_1        |   File "/bot/bot/api.py", line 75, in request
bot_1        |     await self.maybe_raise_for_status(resp, raise_for_status)
bot_1        |   File "/bot/bot/api.py", line 67, in maybe_raise_for_status
bot_1        |     raise ResponseCodeError(response=response, response_json=response_json)
bot_1        | bot.api.ResponseCodeError: Status: 401 Response: {'detail': 'Invalid token.'}

well I got progress but I'm confused at what token I managed to mess up

gritty wind Oct 9, 2021, 11:27 PM

#

I'm trying to update the test server config now to work with the changes

#

What do you have in your .env file

#

Just for BOT_API_KEY

full fractal Oct 9, 2021, 11:28 PM

#

BOT_TOKEN=$insert-bot-token

#

wrong name?

gritty wind Oct 9, 2021, 11:29 PM

#

Right, so there is another token for the site, but luckily that's static for dev environments

#

BOT_API_KEY=badbot13m0n8f570f942013fc818f234916ca531

#

BOT_TOKEN is fine

full fractal Oct 9, 2021, 11:30 PM

#

it seems to be working now

#

there's a lot questionable errors still but oh well

gritty wind Oct 9, 2021, 11:31 PM

#

Could you share them? We may be able to work through some of them now

full fractal Oct 9, 2021, 11:31 PM

#

#476197264667181057 message

gritty wind Oct 9, 2021, 11:32 PM

#

Hm that's curious

full fractal Oct 9, 2021, 11:32 PM

#

2021-10-09 23:29:40 | bot.exts.moderation.watchchannels.bigbrother | ERROR | Failed to fetch webhook with id `609535034474496063`
bot_1        | Traceback (most recent call last):
bot_1        |   File "/bot/bot/exts/moderation/watchchannels/_watchchannel.py", line 107, in start_watchchannel
bot_1        |     self.webhook = await self.bot.fetch_webhook(self.webhook_id)
bot_1        |   File "/usr/local/lib/python3.9/site-packages/discord/client.py", line 1493, in fetch_webhook
bot_1        |     data = await self.http.get_webhook(webhook_id)
bot_1        |   File "/usr/local/lib/python3.9/site-packages/discord/http.py", line 248, in request
bot_1        |     raise Forbidden(r, data)
bot_1        | discord.errors.Forbidden: 403 Forbidden (error code: 50013): Missing Permissions
bot_1        | 2021-10-09 23:29:40 | bot.exts.moderation.watchchannels.bigbrother | ERROR | Failed to start the watch channel; unloading the cog.

gritty wind Oct 9, 2021, 11:32 PM

#

Oh

full fractal Oct 9, 2021, 11:32 PM

#

I think it's related to this part of the log

gritty wind Oct 9, 2021, 11:32 PM

#

Ok so I don't have any roles on that server

#

But could you give your bot the super bot role?

#

If not, I gave it admin anyway so it should work now I hope

#

Seems you can't either, will have to wait for Mark to do that

full fractal Oct 9, 2021, 11:33 PM

#

yeah I can't either as just an admin

#

I've rarely worked with an application that spits out as many log entries as this one

#

a bit of a firehose ^^

gritty wind Oct 9, 2021, 11:35 PM

#

Hah that's true

#

I've gone ahead and fixed the other issue, so no one else should hit it now 🤞

full fractal Oct 9, 2021, 11:37 PM

#

Make sure to update the following if you are running the bot on docker
Site URL: `site: &DOMAIN "localhost:8000"`to `web:8000
snekbox_eval_api` URL: `"http://localhost:8060/eval"` to `"http://snekbox:8060/eval"`

What is this all about by the way?

brazen charm Oct 9, 2021, 11:37 PM

#

the contributing guide will also need updating for the urls

gritty wind Oct 9, 2021, 11:38 PM

#

So if you're running on docker, there's the config var on line 359 that needs the URL to be specifically set to use docker

#

That is, if the actual bot application itself is running on docker, it'll use the internal routing system, i.e the website with name web will be on http://web...

gritty wind Oct 9, 2021, 11:39 PM

#

brazen charm the contributing guide will also need updating for the urls

I can't do that rn, but would be great if someone gets to it

full fractal Oct 9, 2021, 11:39 PM

#

Right, I did change the snekbox URL

gritty wind Oct 9, 2021, 11:39 PM

#

!remind 12H update contributing guides for new url

stable mountainBOT Oct 9, 2021, 11:39 PM

#

Okay.

Your reminder will arrive on <t:1633865971:F>!

full fractal Oct 9, 2021, 11:39 PM

#

full fractal ``` Make sure to update the following if you are running the bot on docker Site ...

does feel a bit weirdly worded, no?

gritty wind Oct 9, 2021, 11:40 PM

#

It could use some work for sure

#

It would probably look better if not forced onto one line as it is now

#

Thoughts on that?

full fractal Oct 9, 2021, 11:42 PM

#

still broken but I have to go for the moment, thanks @gritty wind for helping ^^

gritty wind Oct 9, 2021, 11:43 PM

#

If you're referring to the first part, it means the bot calculated a ping time to be negative (most likely meaning your system time is not in sync with discord's)

#

I've found that it's almost guaranteed to be the case on docker

#

Haven't found a fix

full fractal Oct 9, 2021, 11:44 PM

#

There was another error in the logs but my memory sucks

gritty wind Oct 9, 2021, 11:44 PM

#

I'll be here if you ever feel like debugging again

full fractal Oct 9, 2021, 11:44 PM

#

web_1        | Exception occurred during processing of request from ('172.18.0.7', 56860)
web_1        | Traceback (most recent call last):
web_1        |   File "/usr/local/lib/python3.9/socketserver.py", line 683, in process_request_thread
web_1        |     self.finish_request(request, client_address)
web_1        |   File "/usr/local/lib/python3.9/socketserver.py", line 360, in finish_request
web_1        |     self.RequestHandlerClass(request, client_address, self)
web_1        |   File "/usr/local/lib/python3.9/socketserver.py", line 747, in __init__
web_1        |     self.handle()
web_1        |   File "/usr/local/lib/python3.9/site-packages/django/core/servers/basehttp.py", line 174, in handle
web_1        |     self.handle_one_request()
web_1        |   File "/usr/local/lib/python3.9/site-packages/django/core/servers/basehttp.py", line 182, in handle_one_request
web_1        |     self.raw_requestline = self.rfile.readline(65537)
web_1        |   File "/usr/local/lib/python3.9/socket.py", line 704, in readinto
web_1        |     return self._sock.recv_into(b)
web_1        | ConnectionResetError: [Errno 104] Connection reset by peer

this is probably safe to ignore, yeah?

gritty wind Oct 9, 2021, 11:46 PM

#

Yeah that's an error from discord

#

It just likes to disconnect with no warning

vocal prairie Oct 10, 2021, 12:18 AM

#

For the redirects issues, are these for prod or only for the previews?

gritty wind Oct 10, 2021, 12:22 AM

#

Just previews

vocal prairie Oct 10, 2021, 12:24 AM

#

Oh ok

full fractal Oct 10, 2021, 1:10 AM

#

Success! I've played around with Daylily for like 30 minutes and I haven't seen an error (other than me being stupid with commands)

clever wraith Oct 10, 2021, 2:07 AM

#

Just noticed the word "scat" can be used in the .anagram command, not too sure bout that one

static canyon Oct 10, 2021, 2:11 AM

#

clever wraith Just noticed the word "scat" can be used in the .anagram command, not too sure b...

What's the issue with that?

#

Only meaning I'm aware of is like "scat!" when you're telling an animal/someone to go away

deep sparrow Oct 10, 2021, 2:13 AM

#

it can also mean poop

#

not really 'explicit' though

static canyon Oct 10, 2021, 2:14 AM

#

Yeah, just "poop" doesn't seem bad to me

stable mountainBOT Oct 10, 2021, 7:57 AM

#

cold moon !remindme 12h this

It has arrived!

Here's your reminder: this
[Jump back to when you created the reminder](#dev-contrib message)

cold moon Oct 10, 2021, 7:58 AM

#

!remindme 3h this again

stable mountainBOT Oct 10, 2021, 7:58 AM

#

Alright.

Your reminder will arrive on <t:1633863494:F>!

stable mountainBOT Oct 10, 2021, 8:49 AM

#

It has arrived!

Here's your reminder: remember this
[Jump back to when you created the reminder](#dev-contrib message)

static canyon Oct 10, 2021, 10:11 AM

#

thorny obsidian Hmmmm, let me take a look after I'm done working and I may be able to provide be...

Have you had time to think this through?

I've been thinking on it a bit, and perhaps everything in one file wouldn't be too bad since there are other commands which end up doing this (some stretching past 700 lines).

green oriole Oct 10, 2021, 10:14 AM

#

Yeah, nah, let's not put them into one file

#

I don't mind how we organize the interface, I just don't want any file that has more than 400 lines

static canyon Oct 10, 2021, 10:32 AM

#

green oriole I don't mind how we organize the interface, I just don't want any file that has ...

Well there's already plenty of those lol

#

Even the help command is 562 lines https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/core/help.py

#

4 of the exts/fun are over 400 lines, one of which is 675 lines

#

Yes, we want to avoid it where we can, but I'm not really sure we can avoid it here

green oriole Oct 10, 2021, 10:37 AM

#

We can either split out utilities in other files, or have each command be its own file, all joined under a single cog

static canyon Oct 10, 2021, 10:38 AM

#

green oriole We can either split out utilities in other files, or have each command be its ow...

How would the latter work? (since I believe all the functions are commands)

green oriole Oct 10, 2021, 10:39 AM

#

Just have the command defer all the work to an imported function

gritty wind Oct 10, 2021, 10:41 AM

#

I don't think we should add structural complexity just to avoid having too many lines

#

It's a bit uhh

#

How do I put this

#

Superstitious

#

Fewer lines is ideal, but it isn't a big deal if we go over. Remember the goal here is to keep things understandable and approachable. More lines hurts that, but so does structural complexity

#

I've worked extensively on the silence cog, and I needed to pull out graphs just to understand what the hell it was doing

green oriole Oct 10, 2021, 10:44 AM

#

I don't think it is structure complexity to split it up

gritty wind Oct 10, 2021, 10:44 AM

#

It is when you start splitting functions up into more and more calls just to save a bit of space

green oriole Oct 10, 2021, 10:45 AM

#

I mean, it is one very simple level of indirection

gritty wind Oct 10, 2021, 10:46 AM

#

One level which will do the following:

Add an import
Make you go to a new file where you are splitting the interface and logic

#

Ultimately, it'll probably be fine with whatever you go with, but in general we shouldn't just make commands wrappers for other functions in the name of a "shorter" file

stable mountainBOT Oct 10, 2021, 10:58 AM

#

cold moon !remindme 3h this again

It has arrived!

Here's your reminder: this again
[Jump back to when you created the reminder](#dev-contrib message)

cold moon Oct 10, 2021, 10:58 AM

#

!remindme 4h again...

stable mountainBOT Oct 10, 2021, 10:58 AM

#

You got it!

Your reminder will arrive on <t:1633877921:F>!

brisk brook Oct 10, 2021, 11:08 AM

#

Lol

#

Stop procrastinating!

gritty wind Oct 10, 2021, 11:25 AM

#

Hey @last patio you wouldn't happen to know how to specify CMD from a shell in docker build would you?

#

Or actually

#

I see the problem now

#

command is used on run lol

#

Nah that's not what I'm trying to do. I have a default CMD specified in the dockerfile, but I'm trying to override it when building the image from the command line

green oriole Oct 10, 2021, 11:29 AM

#

I don't think that's feasible without adding like a second stage build to override it

last patio Oct 10, 2021, 11:29 AM

#

I think docker commit is what you want: build the existing image, docker commit a layer on top of it

green oriole Oct 10, 2021, 11:29 AM

#

ooh, smart

#

yeah, you just push a layer on top of the file

#

docker commit --change "CMD ['hello'] $perv_tag $new_tag"

gritty wind Oct 10, 2021, 11:31 AM

#

I just ended up slapping my run in a conditional

#

The thing is, I need this to happen in the build stage not the run stage

green oriole Oct 10, 2021, 11:32 AM

#

using commit you create a new image

gritty wind Oct 10, 2021, 11:32 AM

#

I think you're missing my point

#

I don't actually want to modify the CMD it turns out

#

Since that is only used when running

#

I want this done during the build stage

green oriole Oct 10, 2021, 11:33 AM

#

Okay, I guess the question is why you want to modify it

gritty wind Oct 10, 2021, 11:34 AM

#

Well, I'm trying to combine the static build dockerfile with the normal docker file

#

When doing a static build, it runs a different command to the normal docker file

#

This'll probably be easier to understand once I push the changes

green oriole Oct 10, 2021, 11:36 AM

#

probably haha

stable mountainBOT Oct 10, 2021, 11:39 AM

#

gritty wind !remind 12H update contributing guides for new url

It has arrived!

Here's your reminder: update contributing guides for new url
[Jump back to when you created the reminder](#dev-contrib message)

mint nebula Oct 10, 2021, 11:58 AM

#

https://github.com/python-discord/sir-lancebot/blob/8a410f3abd39a1b48c514d32651a50d4bdced492/bot/exts/avatar_modification/avatar_modify.py#L291
can I add a user param to it? 🥺

stable mountainBOT Oct 10, 2021, 11:58 AM

#

bot/exts/avatar_modification/avatar_modify.py line 291

async def spookyavatar(self, ctx: commands.Context) -> None:```

vale ibex Oct 10, 2021, 11:59 AM

#

mint nebula https://github.com/python-discord/sir-lancebot/blob/8a410f3abd39a1b48c514d32651a...

For what purpose?

mint nebula Oct 10, 2021, 11:59 AM

#

vale ibex For what purpose?

to spookify other's profile picture?

vale ibex Oct 10, 2021, 12:00 PM

#

Ah right, then no we purposefully removed the ability to do that

mint nebula Oct 10, 2021, 12:00 PM

#

Noted, 👍

vale ibex Oct 10, 2021, 12:00 PM

#

We no longer allow any commands that parrot back arbitrary images via the bot, or anything that allows members to run commands against other members without their permission.

mint nebula Oct 10, 2021, 12:01 PM

#

i was going to make a pr on it, glad i asked first

vale ibex Oct 10, 2021, 12:02 PM

#

👍

#

It's always good to ask here, or raise an issue first, before investing time in making a code change

gritty wind Oct 10, 2021, 12:03 PM

#

Another question for one Mr. @last patio I've left a comment on the usage of __all__. I tried now setting the all in the init to not have the helper functions, but it seems I can still import them with no problems.

I don't think they should be used from there if someone wants to use them

#

What do you think?

last patio Oct 10, 2021, 12:05 PM

#

Yeah, nothing will prevent you from importing them. Same for __, but since that's a convention linters will actively warn against it. We can't fully "hide it" in Python anyways, so it's really up to you about how we deal with it

timid sentinel Oct 10, 2021, 12:18 PM

#

If you just want to indicate it shouldn't be imported I think it should be a single rather than double underscore before the name.

cold moon Oct 10, 2021, 1:21 PM

#

brisk brook Stop procrastinating!

School...

vale ibex Oct 10, 2021, 2:14 PM

#

Checkout the readme 😄

#

git.pydis.com/patsy

patent pivot Oct 10, 2021, 2:20 PM

#

messages from help channels

vale ibex Oct 10, 2021, 2:21 PM

#

Could have sworn I put this in the readme

#

but now I realise I put it in the k8s readme

#

Some of it is here https://github.com/python-discord/patsy#purpose

GitHub

GitHub - python-discord/patsy

Contribute to python-discord/patsy development by creating an account on GitHub.

#

I'll pad it out with more

gritty wind Oct 10, 2021, 2:22 PM

#

vale ibex Oct 10, 2021, 2:23 PM

#

yupyup

#

that's it

#

Alright, pushed more to the readme

stable mountainBOT Oct 10, 2021, 2:58 PM

#

cold moon !remindme 4h again...

It has arrived!

Here's your reminder: again...
[Jump back to when you created the reminder](#dev-contrib message)

green oriole Oct 10, 2021, 3:55 PM

#

well at first we were supposed to do stuff for d.py 2.0

#

but we didn't

cold moon Oct 10, 2021, 4:01 PM

#

Can anyone help me with opening this issue in API repo about voice mute model changes? I'm currently busy with school stuff.

molten perch Oct 10, 2021, 4:03 PM

#

Of course, I'll open the issue.

full fractal Oct 10, 2021, 4:42 PM

#

When updating the bot's code, is a container rebuild for bot_bot_1 always necessary to pull in the updates?

#

I feel like I saw something about a faster way but I don't remember

vocal prairie Oct 10, 2021, 4:43 PM

#

No, docker compose up without --build will work because the bot source code is stored as a volume

#

So the container itself will be cached, so it'll be faster

vale ibex Oct 10, 2021, 4:45 PM

#

heh, I'm glad I pinned this, it's been asked a lot recently

#

,

full fractal Oct 10, 2021, 4:47 PM

#

I've only done sudo (which docker-compose) up ... is that the wrong command?

#

(I don't have rootless docker set up ATM)

vale ibex Oct 10, 2021, 4:47 PM

#

did you stop the container before doing that?

full fractal Oct 10, 2021, 4:48 PM

#

^CGracefully stopping... (press Ctrl+C again to force)
Stopping bot_bot_1       ... done
Stopping bot_web_1       ... done
Stopping bot_snekbox_1   ... done
Stopping bot_redis_1     ... done
Stopping bot_postgres_1  ... done

~/programming/oss/bot on  main [!] is 📦 v1.0.0 via  v3.8.5 took 3m16s792ms 
❯ sudo docker container ls --all
CONTAINER ID   IMAGE                                     COMMAND                  CREATED        STATUS                       PORTS     NAMES
ac18a4d9500a   bot_bot                                   "python3 -m bot"         17 hours ago   Exited (0) 19 seconds ago              bot_bot_1
174aca225190   ghcr.io/python-discord/site:latest        "python manage.py ru…"   18 hours ago   Exited (137) 8 seconds ago             bot_web_1
5a9e384a0b37   ghcr.io/python-discord/metricity:latest   "bash entry_point.sh"    18 hours ago   Exited (0) 3 minutes ago               bot_metricity_1
323de1e0ab48   ghcr.io/python-discord/snekbox:latest     "gunicorn -c config/…"   18 hours ago   Exited (0) 18 seconds ago              bot_snekbox_1
4a156024b581   redis:5.0.9                               "docker-entrypoint.s…"   18 hours ago   Exited (0) 18 seconds ago              bot_redis_1
f38cafd4ccaf   postgres:13-alpine                        "docker-entrypoint.s…"   18 hours ago   Exited (0) 20 seconds ago              bot_postgres_1

#

preassumably?

vale ibex Oct 10, 2021, 4:48 PM

#

yea, that should just work then

#

is it not pulling code changes in?

full fractal Oct 10, 2021, 4:49 PM

#

it doesn't seem to be, I added a runtimerror within the set_command method of bot.exts.info.doc and it's not crashing :/

vale ibex Oct 10, 2021, 4:50 PM

#

huh that's really odd, I don't think running it as sudo should have any affect

#

but also I run on a windows host so can't be sure

#

can you shove a error log in say the dunder init of bot and see if it appears?

full fractal Oct 10, 2021, 4:53 PM

#

web_1        | Applying migrations.
web_1        | Operations to perform:
web_1        |   Apply all migrations: admin, api, auth, authtoken, contenttypes, home, sessions, sites, staff
web_1        | Running migrations:
web_1        |   No migrations to apply.
web_1        | Collecting static files.
bot_1        | 2021-10-10 16:53:07 | bot.monkey_patches | DEBUG | Patching send_typing, which should fix things breaking when discord disables typing events. Stay safe!
bot_1        | 2021-10-10 16:53:07 | discord.client | WARNING | PyNaCl is not installed, voice will NOT be supported
bot_1        | 2021-10-10 16:53:07 | bot | ERROR | please show up >.<
bot_1        | 2021-10-10 16:53:08 | deepdiff.diff | INFO | jsonpickle is not installed. The to_json_pickle and from_json_pickle functions will not work.If you dont need those functions, there is nothing to do.
web_1        | Creating a superuser.
bot_1        | 2021-10-10 16:53:08 | bot | INFO | Cog loaded: Big Brother
web_1        | Admin superuser already exists.
bot_1        | 2021-10-10 16:53:08 | bot | INFO | Cog loaded: Clean

#

yup 🤷

#

please show up in the middle

vale ibex Oct 10, 2021, 4:53 PM

#

yea

#

not sure why your exception isn't being hit then

full fractal Oct 10, 2021, 4:54 PM

#

whelp then it's debugging time before I even develop a bugfix :p

vale ibex Oct 10, 2021, 4:54 PM

#

Where did you add the error? when you run the command, does it just add the doc fine?

full fractal Oct 10, 2021, 4:55 PM

#

diff --git a/bot/exts/info/doc/_cog.py b/bot/exts/info/doc/_cog.py
index e7710db2..c3268c32 100644
--- a/bot/exts/info/doc/_cog.py
+++ b/bot/exts/info/doc/_cog.py
@@ -396,6 +396,7 @@ class DocCog(commands.Cog):
             "inventory_url": inventory_url
         }
         await self.bot.api_client.post("bot/documentation-links", json=body)
+        raise RuntimeError("no")
 
         log.info(
             f"User @{ctx.author} ({ctx.author.id}) added a new documentation package:\n"

vale ibex Oct 10, 2021, 4:56 PM

#

#

I did the same and it raised the error when I ran the command

full fractal Oct 10, 2021, 4:57 PM

#

I moved it up and now it's crashing 🤷

#

vale ibex Oct 10, 2021, 4:57 PM

#

how odd

full fractal Oct 10, 2021, 4:58 PM

#

I'm just going to assume PEBKAC unless I hit something similar again 😄

vale ibex Oct 10, 2021, 4:58 PM

#

hah hopefully 😄

#

It's an issue I run into quite often

full fractal Oct 10, 2021, 4:58 PM

#

problem exists between keyboard and chair
-> me doing a dumb-dumb somewhere

vale ibex Oct 10, 2021, 4:58 PM

#

aka layer 8 issue

full fractal Oct 10, 2021, 5:08 PM

#

f.ext r doc

#

f.ping

#

well there goes my latency again

vale ibex Oct 10, 2021, 5:08 PM

#

wrong server kek

full fractal Oct 10, 2021, 5:08 PM

#

oh lol

#

I can't be the first one to do that riggghhttt 👀

vale ibex Oct 10, 2021, 5:09 PM

#

nope haha

full fractal Oct 10, 2021, 5:09 PM

#

phew

full fractal Oct 10, 2021, 5:49 PM

#

well, let's see how many review comments a 9 lines PR will get :D #dev-log message

#

oh fun I forgot to push my changes

brisk brook Oct 10, 2021, 6:21 PM

#

full fractal well, let's see how many review comments a 9 lines PR will get :D https://discor...

Challenge accepted

full fractal Oct 10, 2021, 6:22 PM

#

Hello I am here to bikeshed, please stay calm.
awesome

placid ermine Oct 10, 2021, 6:25 PM

#

what does the api response json look like

timid sentinel Oct 10, 2021, 6:28 PM

#

{'package': ['documentation link with this package already exists.']}

#

It would be sorta nice if the api gave error codes, checkin' in strings always feels a bit meh

vale ibex Oct 10, 2021, 6:30 PM

#

{'package': 'pyth', 'base_url': '', 'inventory_url': 'https://docs.python.org/2/objects.inv'} on success

vocal wolf Oct 10, 2021, 9:01 PM

#

@vale ibex is there any specific reason why we haven't merged bot#1865 (stalling for something, another thing is broken, etc)?

dusky shoreBOT Oct 10, 2021, 9:01 PM

#

GitHub

PROpen Handle 400 when setting pre-existing doc package

vale ibex Oct 10, 2021, 9:03 PM

#

Yea, there's a typo in the message and wookie had a could do for extra handling

#

Once the typo is fixed I'd be fine with merging and Richard has the option to do wookie's suggestion

#

Hmm, wookie's suggestion might be better fixed in the site

#

so it gives a meaningful error

thorny obsidian Oct 10, 2021, 9:07 PM

#

core devs pls provide any additional constraints/implementation details: https://github.com/python-discord/bot/issues/1866

GitHub

Change `!subscribe` to Buttons for sub-roles · Issue #1866 · python...

This is coming from python-discord/meta#150. Context For recurring events where users might want to be notified about happenings, I'd like to add roles where we can ping people about inform...

full fractal Oct 10, 2021, 9:08 PM

#

vale ibex Hmm, wookie's suggestion might be better fixed in the site

I'll be busy with some other stuff so once I fix the typo merging seems like the better call

vale ibex Oct 10, 2021, 9:09 PM

#

👌

full fractal Oct 10, 2021, 9:09 PM

#

what's the current api response if it's too long right now?

vale ibex Oct 10, 2021, 9:09 PM

#

wookie said it's the exact same

full fractal Oct 10, 2021, 9:09 PM

#

well that's not great

vale ibex Oct 10, 2021, 9:09 PM

#

yea, i think we shouldn't special case it here

#

the problem is the site reports the wrong message

#

so we should fix the site api

full fractal Oct 10, 2021, 9:10 PM

#

Agreed.

thorny obsidian Oct 10, 2021, 9:17 PM

#

So I considered that, but it's a lot more interaction required to bulk subscribe/unsubscribe vs toggle buttons

vale ibex Oct 10, 2021, 9:17 PM

#

The idea with buttons is that they can be toggle buttons, so when a user clicks them, the text updates to reflect that they now have the role, and the user cna click again to remove the role

#

it'll be 2 for now

#

can't see it going over 5

thorny obsidian Oct 10, 2021, 9:19 PM

#

Off the top of my head: Announcements, PyWeek, Python Trivia Night, Code Jam, maybe even Pixels

vale ibex Oct 10, 2021, 9:19 PM

#

The idea is it'll be useful for ad hoc events where we want a temp self-assignable role for announements

thorny obsidian Oct 10, 2021, 9:19 PM

#

A lot of this will be blurry with if it should be in lance

vale ibex Oct 10, 2021, 9:19 PM

#

So even if there are more, they won't be all the time

#

we could add it to the branding cog and have that cog validate the id

#

So in the event md you'd also specify an announcements role id

full fractal Oct 10, 2021, 9:23 PM

#

shoot, I just realized I didn't escape the package name in my error handler, it's probably fine?

#

other than some fun markup presumably nothing bad could happen?

vale ibex Oct 10, 2021, 9:24 PM

#

Yea, it'll be fine. The command itself is mod only, and the bot has strict allowed_mentions

#

so it won't cause issues

#

ofc nothing wrong with belt and braces though

timid sentinel Oct 10, 2021, 9:27 PM

#

IIRC the package name is checked against a regex (smth like [_0-9a-z]) before the request as well so there's your braces 😛

vale ibex Oct 10, 2021, 9:28 PM

#

package_name_validator = RegexValidator(
    regex=r"^[a-z0-9_]+$",
    message="Package names can only consist of lowercase a-z letters, digits, and underscores."
)

#

so it is 😄

timid sentinel Oct 10, 2021, 9:29 PM

#

vale ibex wookie said it's the exact same

I think it does indicate that the error is caused by it being too long in the response, sorry, should have been more clear

vale ibex Oct 10, 2021, 9:29 PM

#

Ahhh alright

timid sentinel Oct 10, 2021, 9:31 PM

#

timid sentinel I think it does indicate that the error is caused by it being too long in the re...

I think it's pretty unlikely we'll encounter that error unless the server changes to a Welsh server or something though lol

#

It would be nice if the site api gave error codes for these sorts of things

#

Maybe that's something we could have in the new API

fallen patrol Oct 10, 2021, 10:00 PM

#

timid sentinel Maybe that's something we could have in the new API

perhaps even through all endpoints

#

like

#

every response with an error supplies an error code

dim pelican Oct 10, 2021, 11:22 PM

#

RE: sir-lancebot#859, it should be good to go. Just pending reviews from Xith and Dennis

dusky shoreBOT Oct 10, 2021, 11:22 PM

#

GitHub

PROpen Add WTF Python Command

dim pelican Oct 10, 2021, 11:31 PM

#

@vocal wolf what do you think about #859 and sir-lancebot#860 (only one of these are mine)

dusky shoreBOT Oct 10, 2021, 11:31 PM

#

GitHub

PROpen Challenges

fallen patrol Oct 10, 2021, 11:50 PM

#

small update on that poetry bug from previously, to solve it for myself I wrote a script that parses the poetry.lock file to export a requirements.txt in my ci, since it only takes a second to run rather than poetry taking around 15 seconds to run.

patent pivot Oct 11, 2021, 12:00 AM

#

for those that didn't see scaleios' project yet 😃 https://github.com/python-discord/site/pull/612

GitHub

Adds Redirects To Static Builds by HassanAbouelela · Pull Request #...

This PR continues the work done in #609, but adds redirects.
I've left quite a few comments there about redirects, and this is where I ended up now. It's kind of complicated, and no...

#

specifically: https://deploy-preview-612--pydis-static.netlify.app/

Python Discord | Home

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

static deploy previews for site!

gritty wind Oct 11, 2021, 12:43 AM

#

I want to hire banks PR full time please

patent pivot Oct 11, 2021, 1:17 AM

#

HELL yeah

#

i'm just ultra hype around this it's so cool

#

i still don't know how it works

gritty wind Oct 11, 2021, 1:24 AM

#

Joe I’m not convinced you didn’t come up with this after the first admin meeting

#

It’s an html scrapper

patent pivot Oct 11, 2021, 1:25 AM

#

i mean i won't not take the credit sometimes my brain waves are just that immense that i forget my idea

#

but i just pumped out buzz words you did the dirty work

gritty wind Oct 11, 2021, 1:26 AM

#

Between the both of us, we make a functional person

patent pivot Oct 11, 2021, 1:28 AM

#

exactly, the hivemind continues

molten perch Oct 11, 2021, 1:03 PM

#

Hey! Do I need some kind of formal approval to implement api#19 and api#20? They're fairly easy changes. 😄

dusky shoreBOT Oct 11, 2021, 1:03 PM

#

GitHub

IssueOpen Add new Infraction type Voice Mute - Model changes inherited from site.
Add dm_sent field to infractions database model

static canyon Oct 11, 2021, 1:07 PM

#

@molten perch fyi I'm planning to do api#20 myself

dusky shoreBOT Oct 11, 2021, 1:07 PM

#

GitHub

IssueOpen Add dm_sent field to infractions database model

molten perch Oct 11, 2021, 1:07 PM

#

Oh sorry then.

#

I'll implement the other.

static canyon Oct 11, 2021, 1:08 PM

#

No worries; I would've assigned myself but for some reason I can't on the API repo

short snow Oct 11, 2021, 3:12 PM

#

Hello long time, I would start mentioning the review changes from Sunday 🙂

molten perch Oct 11, 2021, 3:13 PM

#

short snow Hello long time, I would start mentioning the review changes from Sunday 🙂

Hey! Are you also planning to implement the OffTopic names Endpoint for the API?(and the corresponding tests, as well)

short snow Oct 11, 2021, 3:21 PM

#

yeah

molten perch Oct 11, 2021, 3:35 PM

#

Could someone take a look at sir-lancebot#857? It's close to the finish. 😄

dusky shoreBOT Oct 11, 2021, 3:35 PM

#

GitHub

PROpen Add support to query AoC results in respect of days and stars

molten perch Oct 11, 2021, 6:45 PM

#

Hey! Is there a consensus about whether the API is going to use Async SQLAlchemy, or not?

fallen patrol Oct 11, 2021, 8:21 PM

#

static canyon No worries; I would've assigned myself but for some reason I can't on the API re...

ngl but the other repos have in their template if you want to do it yourself

clever wraith Oct 11, 2021, 9:17 PM

#

Hi all, sir-lancebot#699 will be delayed due to my laptop being in need of repair.

dusky shoreBOT Oct 11, 2021, 9:17 PM

#

GitHub

PRClosed Cowsay

clever wraith Oct 11, 2021, 9:17 PM

#

Or whatever the new pr number is

short snow Oct 11, 2021, 11:42 PM

#

molten perch Hey! Are you also planning to implement the OffTopic names Endpoint for the API?...

Alembic setup is still remaining, so if you had like to do it you may go ahead as I don't think ves is getting enough time to do it

austere hornet Oct 12, 2021, 1:37 AM

#

Anyone know why lint is failing on sir-lancebot#901?

dusky shoreBOT Oct 12, 2021, 1:37 AM

#

GitHub

PRDraft Madlibs

dim pelican Oct 12, 2021, 1:38 AM

#

What happens if you manually run flake8?

sleek steppe Oct 12, 2021, 1:39 AM

#

austere hornet Anyone know why lint is failing on sir-lancebot#901?

bot/exts/fun/madlibs/madlibs_templates.json does not end with a newline and there is a bunch of trailing whitespace

austere hornet Oct 12, 2021, 1:40 AM

#

sleek steppe `bot/exts/fun/madlibs/madlibs_templates.json` does not end with a newline and th...

Ohhh

austere hornet Oct 12, 2021, 1:40 AM

#

dim pelican What happens if you manually run flake8?

How do you do that?

fallen patrol Oct 12, 2021, 1:40 AM

#

er

#

flake8

sleek steppe Oct 12, 2021, 1:41 AM

#

Also if flake8 was not skipped then it probably would have just caught a syntaxerror

patent pivot Oct 12, 2021, 1:41 AM

#

poetry run task lint

vocal prairie Oct 12, 2021, 1:41 AM

#

austere hornet How do you do that?

poetry run pre-commit run -a should run it for you, along with the rest of the pre-commit hooks

austere hornet Oct 12, 2021, 1:41 AM

#

patent pivot `poetry run task lint`

K thx

austere hornet Oct 12, 2021, 1:41 AM

#

vocal prairie `poetry run pre-commit run -a` should run it for you, along with the rest of the...

K thx

vocal prairie Oct 12, 2021, 1:42 AM

#

Oh wait, poetry run task lint is equivalent, nvm

sleek steppe Oct 12, 2021, 1:42 AM

#

You can also do poetry run precommit to install the hooks so you can't commit without the lint passing

austere hornet Oct 12, 2021, 1:43 AM

#

sleek steppe You can also do `poetry run precommit` to install the hooks so you can't commit ...

Oh ok thx

fallen patrol Oct 12, 2021, 1:43 AM

#

also if you don't want to wait for them to install the first time

#

poetry run pre-commit install --install-hooks

dim pelican Oct 12, 2021, 1:43 AM

#

The command that I was thinking of was flake8 madlibs.py

austere hornet Oct 12, 2021, 1:44 AM

#

fallen patrol `poetry run pre-commit install --install-hooks`

Ok thx

#

Also @sleek steppe I don't see any whitespace in the JSON, maybe I'm missing something?

sleek steppe Oct 12, 2021, 1:45 AM

#

If you're committing locally then you can just run the lint

#

and it will fix the whitespace automatically

austere hornet Oct 12, 2021, 1:46 AM

#

sleek steppe and it will fix the whitespace automatically

Oh ok thx

austere hornet Oct 12, 2021, 1:50 AM

#

patent pivot `poetry run task lint`

I get this when I run that:

patent pivot Oct 12, 2021, 1:50 AM

#

have you installed deps?

#

poetry install

austere hornet Oct 12, 2021, 1:50 AM

#

Oh wait I don't think so hold up

short snow Oct 12, 2021, 1:50 AM

#

brad helper 👀 congo

austere hornet Oct 12, 2021, 1:52 AM

#

@patent pivot Now I get this:

patent pivot Oct 12, 2021, 1:54 AM

#

uhh yeah you need git, so you'll need git bash or however you get git on windows

austere hornet Oct 12, 2021, 1:54 AM

#

patent pivot uhh yeah you need git, so you'll need git bash or however you get git on windows

Oh ok

short snow Oct 12, 2021, 2:07 AM

#

Found a uncaught error in xkcd command sir-lancebot

#

Will open an issue in sometime, if someone didn't

full fractal Oct 12, 2021, 2:15 AM

#

short snow brad helper 👀 congo

We've had a lot of new staff recently 😄

#

brad, mina, and me in past three weeks IIRC

#

ah and etrotta too

austere hornet Oct 12, 2021, 2:18 AM

#

Congrats to all of you! (ok ok, I know it's off topic)

#

So @patent pivot I installed git and poetry run task lint works now, but I'm getting this and can't figure out on what lines the errors are happening

patent pivot Oct 12, 2021, 2:21 AM

#

not much I can tell you other than what it says, you should be using 4 spaces for indentation but have used tabs, so it's flagging it up as a complaint

austere hornet Oct 12, 2021, 2:21 AM

#

patent pivot not much I can tell you other than what it says, you should be using 4 spaces fo...

Oh ok let's see what I can do

#

So you're saying I have to physically type 4 spaces for each indentation instead of tab even if tab gives you exactly 4 spaces?

thorny obsidian Oct 12, 2021, 2:23 AM

#

unless your editor is converting a tab to 4 spaces, a tab is not guaranteed to give you 4 spaces equivalent

#

A system can configure a tab to display as any amount of spaces

austere hornet Oct 12, 2021, 2:24 AM

#

thorny obsidian A system can configure a tab to display as any amount of spaces

Ok got it thx

short snow Oct 12, 2021, 3:19 AM

#

full fractal We've had a lot of new staff recently 😄

oh even you are a helper, didn't notice lol, congo!

vocal prairie Oct 12, 2021, 3:23 AM

#

austere hornet So you're saying I have to physically type 4 spaces for each indentation instead...

Also, if you're not using an editor that can convert tabs to spaces, you probably should. It makes it MUCH easier.

short snow Oct 12, 2021, 3:24 AM

#

copy madlibs code put it into black formatter online, halff the lint errors would be solved

#

also enable pre-commit, which would run the linter before commiting

green oriole Oct 12, 2021, 6:26 AM

#

Hey @austere hornet, can you please set up a pre-commit hook to avoid having all of those failed lints?

#

poetry run task precommit

green oriole Oct 12, 2021, 6:27 AM

#

short snow copy madlibs code put it into black formatter online, halff the lint errors woul...

We don't use Black's style

short snow Oct 12, 2021, 6:37 AM

#

I know we don't use them, but it would remove the tabs errors and long lines -- half of them, the rest can be followed by flake8

green oriole Oct 12, 2021, 6:38 AM

#

Long line wouldn't be using the right length though

#

and some of the style changes will have to be reverted

short snow Oct 12, 2021, 6:45 AM

#

yeah

rapid igloo Oct 12, 2021, 10:01 AM

#

I think autopep8 might be better to fix the errors since it reads config files like tox.ini, .flake8 if present

gritty wind Oct 12, 2021, 10:31 AM

#

Autopep8 does not follow enough of our style guide - and actively goes against it in some places - that I would not be comfortable adding it.

For instance, here is a file that violates almost every single rule in our style guide:
https://paste.pythondiscord.com/aqofeforiq.py

Here is how autopep8 handled it (max-aggressivness):
https://paste.pythondiscord.com/okeyaredim.yaml

Here is how it should look like according to our style guide:
https://paste.pythondiscord.com/qaxuhinifi.py

#

Now, I ran it on the entire codebase, and it generated a minimal diff, so I'm assuming it can follow our style guide when the code is already properly formatted, but for the people that would benefit most from this, I think it would be very confusing.

Why is linting failing, I ran the formatter?
"Well, you see, the formatter doesn't actually follow our style guide"

#

That is to say, we could consider a formatter, just not autopep8

#

We have actually considered #black-formatter a while back
https://paste.pythondiscord.com/newelopeno.yaml

#

But that will still require modifications to the style guide - just not as significant as autopep8

dim pelican Oct 12, 2021, 10:52 AM

#

short snow brad helper 👀 congo

Thanks!

austere hornet Oct 12, 2021, 11:21 AM

#

vocal prairie Also, if you're not using an editor that can convert tabs to spaces, you probabl...

Yeah, makes sense. I might look into that

austere hornet Oct 12, 2021, 11:21 AM

#

green oriole Hey <@!853309207922212965>, can you please set up a pre-commit hook to avoid hav...

Yes, will do in a few hours hopefully

green oriole Oct 12, 2021, 11:21 AM

#

Cool!

austere hornet Oct 12, 2021, 11:23 AM

#

green oriole Hey <@!853309207922212965>, can you please set up a pre-commit hook to avoid hav...

!remind 6H that

stable mountainBOT Oct 12, 2021, 11:23 AM

#

Yeah okay.

Your reminder will arrive on <t:1634059397:F>!

austere hornet Oct 12, 2021, 11:23 AM

#

Oops didn't mean to ping that time

rapid igloo Oct 12, 2021, 12:14 PM

#

gritty wind Now, I ran it on the entire codebase, and it generated a minimal diff, so I'm as...

I guess it would be amazing if trivial things like formatting errors could be fixed with script. I'm not sure why there are few formatters that uses flake8's errors... the advantage of black (despite not following the style guide fully) of course, is that it can be used in CI to --check whether the code is properly formatted and help you fix it automatically during development or before committing. maybe I'm missing something big here, but it isn't that hard to parse flake8 output and automatically fix (known) formatting errors[^1], so one could possibly have a scripted that accepts flake8 output as stdin so it can fix the trivial things? especially things like trailing whitespace. (Actually doesn't pre-commit automatically fix up some things?)

^1: as I understand it linting != formatter check -- so of course linter could fail after formatter is run (but yeah thanks for pointing out, autopep8 is actually worse than black. I didn't used a concrete example like you did when trying it out)

Of course one could argue this is the job for the IDE (and sure for stuff like trailing whitespace it makes total sense) but not everyone may be using a python-dedicated editor or have really good python support setup. For example, I use nvim with python LSP and it warns me unused variable, line too long etc. but it doesn't take into account config files in the project.

gritty wind Oct 12, 2021, 12:18 PM

#

I hear you, but yeah for the most trivial of things, we do use extra formatters to fix them (though they don't take into account flake8). Trailing whitespace, missing newlines, wrong file endings are all fixed by pre-commit.

Having built a tool which fixes exactly one flake8 error (single to double quotes), it can get pretty complex.

Regardless, I don't see it as too much of a problem. I'm in the habit of writing okay-ish looking python code before any formatting, and any errors are pointed out to me before I commit (pre-commit), so I almost always never mess up linting. Ofc that isn't always viable, for instance, it won't help when commiting from the github UI, but I believe it's always viable where an automatic formatting script is.

#

One more tool we can add with little difficulty is some sort of import manager, possibly isort. I think Akarys was looking into that, but that's one error less

#

There is also the fact that for the case in question, it seems pre-commit wasn't set up before commiting, and linting was not run at all, and obv for those cases we can't do anything

molten perch Oct 12, 2021, 1:35 PM

#

short snow Alembic setup is still remaining, so if you had like to do it you may go ahead a...

You mean the Alembic setup or the endpoint?
(Sorry for the late answer)

short snow Oct 12, 2021, 1:36 PM

#

alembic setup, and its fine

molten perch Oct 12, 2021, 3:01 PM

#

Oh,it has already been assigned to @clever wraith .

green oriole Oct 12, 2021, 3:08 PM

#

gritty wind One more tool we can add with little difficulty is some sort of import manager, ...

oh yes, I shall do that

thorny obsidian Oct 12, 2021, 3:23 PM

#

Is the Python d.py 2.0 PR planning on being merged this upcoming weekend?

green oriole Oct 12, 2021, 3:24 PM

#

If it is reviewed before this weekend, hell yeah

short snow Oct 12, 2021, 3:33 PM

#

thorny obsidian Is the Python d.py 2.0 PR planning on being merged this upcoming weekend?

for your subscription command issue, how about we configure the roles in the config, something like this:

roles:
  pyweek-announcements:
    id: 1234567890987654321
    about: "Get notified about pyweek announcements!"

vale ibex Oct 12, 2021, 3:36 PM

#

I don't think these should be in config

thorny obsidian Oct 12, 2021, 3:37 PM

#

@vale ibex you had some opinions about this. Should these roles be defined in the config or would something like constants.py make more sense? -- lol you beat me to it

vale ibex Oct 12, 2021, 3:37 PM

#

we should have the role ID's in config, the ones that are used by the subscribe command should be a constant in the cog file itself

green oriole Oct 12, 2021, 3:38 PM

#

Agreed

thorny obsidian Oct 12, 2021, 3:38 PM

#

Yeah, that makes sense to me. I want to be explicit in the file itself which roles are being added, not by running down some yml file

vale ibex Oct 12, 2021, 3:39 PM

#

yea, in the cog file I expect there to be something like ```py
ANNOUNEMENT_ROLES = (
constants.Roles.subscribe_role,
contsants.Roles.pyweek,
)