#dev-contrib | Python | Page 141

fallen patrol Oct 4, 2021, 5:24 PM

#

Wow.

vale ibex Oct 4, 2021, 5:27 PM

#

they did it at the CF level too, so all typing called just get 403'd

#

which means any command that triggers typing fails, since the typing call errors

fallen patrol Oct 4, 2021, 5:30 PM

#

Lmao

#

That's

#

Uh

fallen patrol Oct 4, 2021, 5:31 PM

#

vale ibex which means any command that triggers typing fails, since the typing call errors

Thanks now I need to make all of my commands that use typing catch it

vale ibex Oct 4, 2021, 5:31 PM

#

I'm currently monkey patching d.py

#

this also means @slow bone just doens't work at all

fallen patrol Oct 4, 2021, 5:31 PM

#

Since typing is a bonus, not a feature

#

Jeez

vale ibex Oct 4, 2021, 5:31 PM

#

so I'll port this patch over there

fallen patrol Oct 4, 2021, 5:31 PM

#

I think mine does right now lmao

#

Since I only listen for typing events on two places in one method

#

:)

#

You pushing this patch to pypi?

vale ibex Oct 4, 2021, 5:34 PM

#

no, was just going to monkey patch it in bot

#

but now we're looking into dropping any requests that match https://discord.com/api/*/typing at the point of egress from our cluster

fallen patrol Oct 4, 2021, 5:40 PM

#

ah

fallen patrol Oct 4, 2021, 5:40 PM

#

vale ibex but now we're looking into dropping any requests that match `https://discord.com...

that's annoying ngl

patent pivot Oct 4, 2021, 5:44 PM

#

we can't do it anyway, or not quickly

#

we don't break tls by default nor do we have SNI filtering ready

#

we can only block IPs

fallen patrol Oct 4, 2021, 5:44 PM

#

that would work /s
just block discord's IPs
now you won't have any bugs

#

honestly this is probably related to facebook and whatsapp being down

#

ppl using discord because they can't use those

patent pivot Oct 4, 2021, 5:47 PM

#

probably

fallen patrol Oct 4, 2021, 5:50 PM

#

gritty wind Oct 4, 2021, 5:57 PM

#

If for the API, UTC is probably the most logical

#

Or you could be nice and use my TZ :)))

patent pivot Oct 4, 2021, 5:57 PM

#

utc+5:45 yea

#

no utc utc is great

gritty wind Oct 4, 2021, 5:58 PM

#

Oh

#

Yeah thanks

patent pivot Oct 4, 2021, 5:59 PM

#

we should change out the template probably, make it a bit more pydis

#

oh uh, no, i'd keep those

gritty wind Oct 4, 2021, 6:17 PM

#

Probably just set the formatter there to the one we use, and don't include root. Then in the actual program set up the logging for the project itself

molten perch Oct 4, 2021, 6:18 PM

#

Don't you need the models before? I mean it would make sense to have the models, and then set up the migration environment.

#

Oh, okay. Cool. 😄

gritty wind Oct 4, 2021, 6:25 PM

#

So what are these loggers for

#

When are they used basically

#

Okay, in that case it doesn't matter much

#

The only real change you can make is set the formatting string from pydis projects, but that's not really necessary

#

as is is fine

fallen patrol Oct 4, 2021, 6:33 PM

#

@vale ibex there's a proper thing to check rather than 403s

#

https://discord.com/developers/docs/topics/opcodes-and-status-codes#json

Discord Developer Portal

Discord Developer Portal — API Docs for Bots and Developers

Integrate your service with Discord — whether it's a bot or a game or whatever your wildest imagination can come up with.

#

40006

patent pivot Oct 4, 2021, 6:34 PM

#

is that the code they are actually giving

#

because we've been getting cloudflare 403s

patent pivot Oct 4, 2021, 6:35 PM

#

fallen patrol <@126811506632294400> there's a proper thing to check rather than 403s

we can check that as well in future, but the error today which is the one we are targeting is not this.

gritty wind Oct 4, 2021, 6:35 PM

#

It would be that code if it was actually the API returning that

fallen patrol Oct 4, 2021, 6:35 PM

#

Well

patent pivot Oct 4, 2021, 6:36 PM

#

lol

fallen patrol Oct 4, 2021, 6:36 PM

#

patent pivot we can check that as well in future, but the error today which is the one we are...

If that's what you're getting

#

Then it should check if it was a cloudflare 403

gritty wind Oct 4, 2021, 6:36 PM

#

It really doesn't matter

patent pivot Oct 4, 2021, 6:36 PM

#

we aren't expecting a 403 anywhere else

#

it's fine as it is.

#

this is a fix to work around something discord deployed in a way they probably shouldn't have

fallen patrol Oct 4, 2021, 6:36 PM

#

gritty wind It really doesn't matter

It does, cf will ban bot temporarily if too many legit 403s

patent pivot Oct 4, 2021, 6:37 PM

#

and that's why we've got a warning on it

gritty wind Oct 4, 2021, 6:37 PM

#

That's why we're logging, also this is not something we're expecting to happen often

#

Especially not from the typing endpoint

green oriole Oct 4, 2021, 6:37 PM

#

I'm really whatever about catching other errors

#

It is a temp fix

gritty wind Oct 4, 2021, 6:37 PM

#

If we're getting global 403s on all other endpoints, those will still work as normal

patent pivot Oct 4, 2021, 6:38 PM

#

yeah

#

and then we just move it to another node mmLul

fallen patrol Oct 4, 2021, 6:39 PM

#

Ah

gritty wind Oct 4, 2021, 6:40 PM

#

We migrate away from linode

green oriole Oct 4, 2021, 6:40 PM

#

bigbrain

fallen patrol Oct 4, 2021, 6:40 PM

#

The ban should be upp

thorny obsidian Oct 4, 2021, 6:40 PM

#

at some point I'm pretty joe can just "yo... can you unban? kthxbai"

green oriole Oct 4, 2021, 6:40 PM

#

Tbh we can deploy another node super easily lol

fallen patrol Oct 4, 2021, 6:40 PM

#

Since they have 3 nodes, and bans last 30 minutes per IP

patent pivot Oct 4, 2021, 6:40 PM

#

yeah i have a button that says recycle node

green oriole Oct 4, 2021, 6:40 PM

#

It takes like 5 minutes

patent pivot Oct 4, 2021, 6:40 PM

#

we have as many nodes as we want lol

fallen patrol Oct 4, 2021, 6:40 PM

#

Ofc the second time it goes to 90 minutes

gritty wind Oct 4, 2021, 6:41 PM

#

Is it like on your desk, under your bed, etc?

green oriole Oct 4, 2021, 6:41 PM

#

Oh true, there is recycle too

fallen patrol Oct 4, 2021, 6:41 PM

#

fallen patrol Ofc the second time it goes to 90 minutes

Don't ask how I know 👀

green oriole Oct 4, 2021, 6:41 PM

#

gritty wind Is it like on your desk, under your bed, etc?

Big red button hidden behind a painting

fallen patrol Oct 4, 2021, 6:41 PM

#

thorny obsidian at some point I'm pretty joe can just "yo... can you unban? kthxbai"

Honestly I don't expect discord to actually unban Joe's IP in cloudflare lmao

patent pivot Oct 4, 2021, 6:42 PM

#

where my image

fallen patrol Oct 4, 2021, 6:42 PM

#

You deleted

#

Or someone did

patent pivot Oct 4, 2021, 6:42 PM

#

fallen patrol Oct 4, 2021, 6:43 PM

#

Is someone making the pr for Lance bot too?

#

!eval 5

stable mountainBOT Oct 4, 2021, 6:43 PM

#

@fallen patrol :warning: Your eval job has completed with return code 0.

[No output]

patent pivot Oct 4, 2021, 6:43 PM

#

not as critical but probably at some point

fallen patrol Oct 4, 2021, 6:43 PM

#

Ok

green oriole Oct 4, 2021, 6:43 PM

#

Heh, I vote for letting sir lance be broken for now

#

Who cares, it almost doesn't use typing events

#

Even if it does, not a big harm

fallen patrol Oct 4, 2021, 6:44 PM

#

Oof, gotta fix modmail too lmao

#

Have fun with that 👀

patent pivot Oct 4, 2021, 6:46 PM

#

or i could just

#

?config set user_typing false

slow boneBOT Oct 4, 2021, 6:46 PM

#

Success

Set user_typing to 0.

patent pivot Oct 4, 2021, 6:46 PM

#

lol

fallen patrol Oct 4, 2021, 6:46 PM

#

I'm pretty sure that won't fix it lmao

#

Yep

#

Did not fix it

patent pivot Oct 4, 2021, 6:48 PM

#

any idea why?

fallen patrol Oct 4, 2021, 6:48 PM

#

Bot uses a shitton of typing requests

patent pivot Oct 4, 2021, 6:49 PM

#

?config set user_typing true

slow boneBOT Oct 4, 2021, 6:49 PM

#

Success

Set user_typing to 1.

patent pivot Oct 4, 2021, 6:49 PM

#

alright we'll monkeypatch

fallen patrol Oct 4, 2021, 6:49 PM

#

Since you already have a fork, it's worth just patching it to not make any requests lmao

patent pivot Oct 4, 2021, 6:49 PM

#

we just need to update our fork

fallen patrol Oct 4, 2021, 6:49 PM

#

Ye

patent pivot Oct 4, 2021, 6:49 PM

#

or we copy the change from bot which is easier

fallen patrol Oct 4, 2021, 6:49 PM

#

I'd like, just patch the method to not do anything

#

Since the bot uses it in a crazy number of places

#

Actually

#

@patent pivot one sec, don't do anything

#

You can just monkeypatch with an eval command if you want

patent pivot Oct 4, 2021, 6:52 PM

#

oh lol devops just merged a PR

fallen patrol Oct 4, 2021, 6:52 PM

#

Ah okay

#

The unofficial kyb3r modmail monkeypatch is this

#

from discord.context_managers import Typing

class MTyping(Typing):
    def __init__(self, messageable):
       ...

    async def do_typing(self):
       ...

    def __enter__(self):
       ...

    def __exit__(self, exc_type, exc, tb):
       ...

    async def __aenter__(self):
       ...

    async def __aexit__(self, exc_type, exc, tb):
       ...

def typing(self):
    return MTyping(self)
async def e(*a):
  ...
discord.abc.Messageable.typing = typing
discord.abc.Messageable.trigger_typing = e

#

And that can just be evaled

#

Although that will work for any bot, actually

gritty wind Oct 4, 2021, 7:12 PM

#

Who's familiar with our redirects apps

#

Need someone to help me debug the tests

#

As in, can you recall every single piece of it from memory

#

Nah lol

#

I have my work pushed on:
http://github.com/hassanabouelela/site-1/

GitHub

GitHub - HassanAbouelela/site-1: pythondiscord.com - A Django and B...

pythondiscord.com - A Django and Bulma web application. - GitHub - HassanAbouelela/site-1: pythondiscord.com - A Django and Bulma web application.

#

if you have a look at apps/redirect/tests.py, I have that test skipped

#

If I remove the skip, the tests fail with:

Failure
Traceback (most recent call last):
File "pydis_site\apps\redirect\tests.py", line 54, in test_redirects
self.assertEqual(1, len(resp.redirect_chain))
AssertionError: 1 != 0

#

That * 37

#

It's probably something stupid like me forgetting to load the app or something

#

I wonder if the app has to be loaded before the others

#

Yeah that's exactly it

#

Okay I hate life a little right now

austere hornet Oct 4, 2021, 7:20 PM

#

Lmao

dusky shoreBOT Oct 4, 2021, 7:25 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

molten perch Oct 4, 2021, 7:26 PM

#

Depends on the reviews 😄 So unfortunately, I don't.

fervent sage Oct 4, 2021, 8:12 PM

#

Hi

dusky shoreBOT Oct 4, 2021, 8:29 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

#

GitHub

IssueOpen Alembic project setup

patent pivot Oct 4, 2021, 8:37 PM

#

alembic/versions generally

#

I’m not sure what you mean

#

I’ve never had to explicitly configure offline migration stuff with alembic

fervent sage Oct 4, 2021, 8:48 PM

#

My review wouldn't mean anything, I hate sqlalchemy and have barely used it

#

Awful orm imo

patent pivot Oct 4, 2021, 8:48 PM

#

we don’t need this

#

sqlalchemy is neat

remote wigeon Oct 4, 2021, 8:49 PM

#

incoming @fervent sage, but i dislike orms in general

#

KEKW

#

granted i really only played with them in rust not so much in python, but still

#

horrible experience

vale ibex Oct 4, 2021, 8:50 PM

#

volcyy

#

volcyy is great

patent pivot Oct 4, 2021, 8:51 PM

#

remote wigeon incoming <@!297045071457681409>, but i dislike orms in general

we have a policy here that all projects have to be able to migrate themselves so generally no raw sql unless we use an sql migration manager as well

vale ibex Oct 4, 2021, 8:51 PM

#

he's joe's outsourced prom dev

patent pivot Oct 4, 2021, 8:51 PM

#

it’s why we added an orm to pixels

vale ibex Oct 4, 2021, 8:52 PM

#

patent pivot it’s why we added an orm to pixels

~~I haven't done this yet~~

#

but will before we run the next event lol

remote wigeon Oct 4, 2021, 8:52 PM

#

patent pivot we have a policy here that all projects have to be able to migrate themselves so...

fair enough, though you can write migrations by hand

thorny obsidian Oct 4, 2021, 8:52 PM

#

joe does not need to be a human migration tool

fervent sage Oct 4, 2021, 8:52 PM

#

Why can't there be any good orms lol

thorny obsidian Oct 4, 2021, 8:52 PM

#

vale ibex but will before we run the next event lol

(You got time... .... but not too much time)

remote wigeon Oct 4, 2021, 8:52 PM

#

fervent sage Why can't there be any good orms lol

its really really really (really) hard

vale ibex Oct 4, 2021, 8:52 PM

#

yea, we had always planned for it to be a recurring event

vale ibex Oct 4, 2021, 8:53 PM

#

fervent sage Why can't there be any good orms lol

https://github.com/tiangolo/sqlmodel

GitHub

GitHub - tiangolo/sqlmodel: SQL databases in Python, designed for s...

SQL databases in Python, designed for simplicity, compatibility, and robustness. - GitHub - tiangolo/sqlmodel: SQL databases in Python, designed for simplicity, compatibility, and robustness.

dusky shoreBOT Oct 4, 2021, 8:53 PM

#

GitHub

IssueOpen Alembic project setup

vale ibex Oct 4, 2021, 8:53 PM

#

it totally isn't based off sql alchemy

thorny obsidian Oct 4, 2021, 8:53 PM

#

We even have pixels tentatively scheduled~

vale ibex Oct 4, 2021, 8:53 PM

#

you would be correct

patent pivot Oct 4, 2021, 8:53 PM

#

remote wigeon fair enough, though you can write migrations by hand

yeah, it’s generally less work to use an orm though, as kat says the policy is no Joe as human migration tool

brisk brook Oct 4, 2021, 9:00 PM

#

I am honestly curious how the hand-crafted SQL used for Pixels will be with SQLAlchemy...

vale ibex Oct 4, 2021, 9:01 PM

#

I'm curious too lmfao

dusky shoreBOT Oct 4, 2021, 9:01 PM

#

GitHub

PRMerged Test of actions

gritty wind Oct 4, 2021, 9:01 PM

#

Nah joe memorized all the code and types it out by hand on demand

patent pivot Oct 4, 2021, 9:03 PM

#

brisk brook I am honestly curious how the hand-crafted SQL used for Pixels will be with SQLA...

we can do raw sql migrations

vale ibex Oct 4, 2021, 9:08 PM

#

the view is what I'm worried about

#

went through a few revisions to make sure it was performant

brisk brook Oct 4, 2021, 9:16 PM

#

vale ibex the view is what I'm worried about

That's exactly what I was thinking about

#

I don't even know where to start with it haha

vale ibex Oct 4, 2021, 9:16 PM

#

It might be alright with numpy

#

or some thing like that

#

hmmm that loses a lot from the init of the cache though

#

yea, needs more thought lol

brisk brook Oct 4, 2021, 9:18 PM

#

Ah, true. How does SQLAlchemy handle ON CONSTRAINT? Will we have to have a try/except?

molten perch Oct 4, 2021, 9:25 PM

#

brisk brook Ah, true. How does SQLAlchemy handle `ON CONSTRAINT`? Will we have to have a try...

I think so, yes.

brisk brook Oct 4, 2021, 9:26 PM

#

Bruh

cold island Oct 4, 2021, 9:26 PM

#

https://615b32be1025c010fb532b0e--pydis-static.netlify.app/pages/guides/pydis-guides/contributing/bot
Gives me "page not found"

gritty wind Oct 4, 2021, 9:27 PM

#

Strange

#

Sir-lance works

#

I assumed they’d all work in that case

cold island Oct 4, 2021, 9:27 PM

#

lol the one page that matters

#

rules doesn't work either

#

https://615b32be1025c010fb532b0e--pydis-static.netlify.app/pages/rules/

gritty wind Oct 4, 2021, 9:28 PM

#

I’m aware of most things not working, just thought that one did

cold island Oct 4, 2021, 9:29 PM

#

ic

gritty wind Oct 4, 2021, 9:29 PM

#

Interestingly sir-lance stuff is a folder unlike bot

#

Okay brb

#

@cold island omgomgomg that observation seems to have fixed most things

#

https://615b73e3d95f950b1f2ab31d--pydis-static.netlify.app/

#

Pushed the fix, so unless anyone finds anything else that's broken, the only thing left is CI

cold island Oct 4, 2021, 9:44 PM

#

gritty wind <https://615b73e3d95f950b1f2ab31d--pydis-static.netlify.app/>

Did you mean to use the main branch or mine?

gritty wind Oct 4, 2021, 9:44 PM

#

right, so I have to deploy manually, forgot to deploy yours

#

Ugh are all events links broken

#

Alright, I think I know where to go

#

Oh yeah I did zilch on events lmao

#

Wait where are the event pages on the repo

cold island Oct 4, 2021, 9:47 PM

#

uuuh sec

gritty wind Oct 4, 2021, 9:47 PM

#

found ittt

#

wait no i didn't

cold island Oct 4, 2021, 9:48 PM

#

pydis_site/templates/events/pages/

vocal prairie Oct 4, 2021, 9:48 PM

#

https://github.com/python-discord/site/tree/main/pydis_site/templates/events/pages

gritty wind Oct 4, 2021, 9:48 PM

#

but... how do those urls even resolve

cold island Oct 4, 2021, 9:49 PM

#

django magic I guess

#

You'd need to ask kosa or ks

gritty wind Oct 4, 2021, 9:49 PM

#

I need to unwrap that magic 🤡

#

Alright, at least I have something to go off of

fallen patrol Oct 4, 2021, 9:49 PM

#

Lmao

gritty wind Oct 4, 2021, 9:59 PM

#

https://615b790fb7ab6715673660c2--pydis-static.netlify.app/
How's this

Also preach y'all for being my dedicated QA

#

I don't even

#

Brb again

#

Um

#

Where did you find that link

#

https://615b790fb7ab6715673660c2--pydis-static.netlify.app/pages/guides/pydis-guides/contributing/site/

#

It seems to be a redirect, which wouldn't work with this

#

Alright, that's a tougher challenge

#

Getting redirects to work statically hmm

#

For sure lol

stable mountainBOT Oct 4, 2021, 10:10 PM

#

It has arrived!

Here's your reminder: Test sir-lancebot#860
[Jump back to when you created the reminder](#dev-contrib message)

dim pelican Oct 4, 2021, 10:15 PM

#

Yup

#

Getting 3.10 installed at home now

#

Might try to play with starship

patent pivot Oct 4, 2021, 10:22 PM

#

btw @gritty wind how are you actually doing these

gritty wind Oct 4, 2021, 10:22 PM

#

Which aspect

patent pivot Oct 4, 2021, 10:23 PM

#

the whole shazam

gritty wind Oct 4, 2021, 10:23 PM

#

The static building is distill_django which does basically what you had in mind

patent pivot Oct 4, 2021, 10:23 PM

#

bundling the site into a static bnudle

#

ahh

gritty wind Oct 4, 2021, 10:23 PM

#

It basically scrapes the site at startup into html

#

https://github.com/meeb/django-distill

patent pivot Oct 4, 2021, 10:23 PM

#

interesting

gritty wind Oct 4, 2021, 10:23 PM

#

I'm not sure if making redirects is worth it or not

#

On the one hand, they are used on the site

#

On the other, I can't even begin to fathom how they work

#

Also the library I'm using doesn't support 301, so I have to handle them by hand

cold island Oct 4, 2021, 10:36 PM

#

I think for now being able to view the right page is good enough

dim pelican Oct 4, 2021, 11:07 PM

#

stable mountain

@trail pilot
I keep getting this error when trying to get Sir-Lance running from the docker file (I did poetry install and have the added dependencies)

sir-lancebot    | discord.ext.commands.errors.ExtensionFailed: Extension 'bot.exts.utilities.challenges' raised an error: ModuleNotFoundError: No module named 'bs4'
sir-lancebot exited with code 1

vale ibex Oct 4, 2021, 11:09 PM

#

When you did docker-compose up did you add --build?

#

In most of our projects we define volumes within the docker compose. This means any code changes don't require you to rebuild docker images.
However, changes to dependencies or the Dockerfile itself still require you to docker-compose up --build to rebuild the image and get those changes in

dim pelican Oct 4, 2021, 11:10 PM

#

C:\Users\Brad\Desktop\python\programming\sir-lancebot>docker-compose up --build
Building sir-lancebot
[+] Building 0.0s (1/2)
 => ERROR [internal] load build definition from Dockerfile                                                         0.0s
 => => transferring dockerfile: 786B                                                                               0.0s
------
 > [internal] load build definition from Dockerfile:
------
failed to solve with frontend dockerfile.v0: failed to read dockerfile: error from sender: open \\?\C:\Users\Brad\Desktop\python\programming\sir-lancebot\lib64: Access is denied.
ERROR: Service 'sir-lancebot' failed to build : Build failed

vale ibex Oct 4, 2021, 11:11 PM

#

That's not good

dim pelican Oct 4, 2021, 11:11 PM

#

Do I need to compose down?

vale ibex Oct 4, 2021, 11:11 PM

#

Maybe

#

You'd need to stop the container

#

Not sure about a down

dim pelican Oct 4, 2021, 11:11 PM

#

Same error (it was stopped and built down)

vale ibex Oct 4, 2021, 11:12 PM

#

Never seen that one before

dim pelican Oct 4, 2021, 11:12 PM

#

I just swapped back to my wtf-python branch and built it back up

vale ibex Oct 4, 2021, 11:12 PM

#

Can you link the pr?

dim pelican Oct 4, 2021, 11:13 PM

#

sir-lancebot#860

dusky shoreBOT Oct 4, 2021, 11:13 PM

#

GitHub

PROpen Challenges

dim pelican Oct 4, 2021, 11:13 PM

#

I was trying out the gh pr checkout 860 command to test things locally

vale ibex Oct 4, 2021, 11:13 PM

#

Huh can't see anything that should cause an error like that

#

I'm on mobile, so can't trouble shoot too much

#

I can look tomorrow if you're still having issues

dim pelican Oct 4, 2021, 11:23 PM

#

Yeah its pretty weird. I can run it just fine with my own branch

#

Even the docker-compose up --build

green oriole Oct 5, 2021, 6:17 AM

#

dim pelican ```sh C:\Users\Brad\Desktop\python\programming\sir-lancebot>docker-compose up --...

chown $USER . PensiveMassive

obtuse arrow Oct 5, 2021, 9:38 AM

#

@kindred oriole Check out this message in particular: #dev-contrib message

#

If you're still confused about anything after reading that, go ahead and ask here.

kindred oriole Oct 5, 2021, 9:39 AM

#

Hi. Are there any projects/repositories on the Python Discord GitHub that are designed to help introduce someone with intermediate level experience to contributing to open source software projects? I have 9 years experience coding in Python but little experience actually writing functioning code. I want to learn the ropes, but don't know where to start, and was given the advice to join a project on the Python Discourse GitHub. Sorry for being so long-winded. Thanks in advance!

kindred oriole Oct 5, 2021, 9:39 AM

#

obtuse arrow <@!893177523012247575> Check out this message in particular: https://discord.com...

Ok I didn't see that, I already wrote my comment.

obtuse arrow Oct 5, 2021, 9:39 AM

#

Haha, no worries.

kindred oriole Oct 5, 2021, 9:42 AM

#

I guess I got my answer, it says what projects are for Beginners etc.

vale ibex Oct 5, 2021, 10:00 AM

#

@timid sentinel did you try this?

timid sentinel Oct 5, 2021, 10:04 AM

#

would that fix the circular import problem? I think that would still cause contants.py and services.py to be ran before logging is set up

vale ibex Oct 5, 2021, 10:05 AM

#

we setup the log in the init right?

#

Ah, I think I can see the issue now

#

not sure if this fix would deal with that or not

cold island Oct 5, 2021, 10:06 AM

#

kindred oriole I guess I got my answer, it says what projects are for Beginners etc.

To be clear, the "level" is about knowledge of Python and some specialized frameworks. For example our site uses django extensively. But if you see something on the bot repo that interests you more than on lancebot (for example), there's nothing preventing you from trying your hand with one of the issues there, we'll help you set up the project anyway if you need it.

#

The contributing page mentions our three "main" repos, but we have other repos as well which might interest you more depending on your knowledge. You can browse them at https://git.pydis.com

kindred oriole Oct 5, 2021, 10:07 AM

#

cold island To be clear, the "level" is about knowledge of Python and some specialized frame...

I've been advised to start learning d.py at first, I will look at that, then bot creation, then look at the project. Thanks!

timid sentinel Oct 5, 2021, 10:42 AM

#

vale ibex Ah, I think I can see the issue now

It could be a sensible thing to do anyway, although as the logging relies on constants.py I don't think we could have logging there unless we make logging just read any config from env vars directly or something.
With the stuff in the utils folder it's a bit weird as logging doesn't actually need most of it, but by accessing the one file it needs runs some others as a side affect (because the utils/__init__.py is run)

#

Actually, if we definite get_logger in the bot init file that might fix it, rather than importing it

dim pelican Oct 5, 2021, 10:56 AM

#

green oriole `chown $USER .` <:PensiveMassive:603311277736984627>

wtf

That was it

green oriole Oct 5, 2021, 10:56 AM

#

Lmao really

#

Chown is a thing on windows?

dim pelican Oct 5, 2021, 11:03 AM

#

WSL2 😎

static canyon Oct 5, 2021, 11:09 AM

#

timid sentinel Actually, if we definite get_logger in the bot init file that might fix it, rath...

That's a possibility yeah

#

Assuming you mean moving from bot.utils.logging to bot.__init__

#

Maybe even having it in bot.log?

#

Maybe defining in bot.log and then importing in bot.__init__? bot.log already gets imported

#

That way there wouldn't be any circular imports

timid sentinel Oct 5, 2021, 11:43 AM

#

static canyon Maybe defining in `bot.log` and then importing in `bot.__init__`? `bot.log` alre...

that should work, yeah. sounds good. whether we want to import get_logger from bot or bot.log I wouldn't mind. I don't think it would make any difference technically. Defining it in bot.log sounds good regardless though.

#

And then just remove all logging from constants.py, or replace them with simple prints?

green oriole Oct 5, 2021, 11:48 AM

#

dim pelican WSL2 😎

Haha, perfect

static canyon Oct 5, 2021, 12:02 PM

#

timid sentinel And then just remove all logging from `constants.py`, or replace them with simpl...

I'd probably replace them all with print

#

Will work on that later (probably tonight)

gritty wind Oct 5, 2021, 1:03 PM

#

Is there a specific way to mark a python file as having compatibility with only a certain python version?

#

I can't just do it using a package or poetry or whatever because it's just a utility script sitting along side the main project

cold island Oct 5, 2021, 1:12 PM

#

Not sure I understand the situation

#

What happens if the Python version is incompatible

gritty wind Oct 5, 2021, 1:13 PM

#

Well, the file may not run. If someone adds a walrus to it, it will just error out where it's used because walrus isn't valid in 3.8

#

I have no control over the environment it will be run in, that's managed

#

I left a comment at the very top of the file saying as much, but I'd like an enforcement method if possible

green oriole Oct 5, 2021, 1:14 PM

#

Check sys.version and exit if it isn't right?

gritty wind Oct 5, 2021, 1:15 PM

#

Hm, not a bad idea

#

Though it will only stop developers that actually test it

#

which is never a guarantee

cold island Oct 5, 2021, 1:15 PM

#

If the project depends on it, that means the project is incompatible with 3.8 isn't it?

green oriole Oct 5, 2021, 1:15 PM

#

You can also add version specifiers in poetry

gritty wind Oct 5, 2021, 1:16 PM

#

It's a utility script that lives alongside the project. Let me explain better:

Site uses 3.9
Netlify uses 3.8

I need to run a python script on netlify, which I need to keep in the site repo

cold island Oct 5, 2021, 1:16 PM

#

gritty wind Well, the file may not run. If someone adds a walrus to it, it will just error o...

walrus was introduced in 3.8

gritty wind Oct 5, 2021, 1:16 PM

#

Oh lol

#

Uhh... just think of any 3.9 features haha

#

Anyways, it's probably okay as is

green oriole Oct 5, 2021, 1:19 PM

#

gritty wind Uhh... just think of any 3.9 features haha

list[int]

gritty wind Oct 5, 2021, 1:19 PM

#

😱

green oriole Oct 5, 2021, 1:19 PM

#

It will raise value error?

cold island Oct 5, 2021, 1:19 PM

#

TypeError

green oriole Oct 5, 2021, 1:22 PM

#

ValueError = TypeError

#

Now my statement is right

thorny obsidian Oct 5, 2021, 2:28 PM

#

@patent pivot what's the process for updating snekbox to 3.10 (or really any new python version)? I would expect it to be a PR after testing locally to make sure the packages are happy with 3.10, but I feel like I'm missing something else.

gritty wind Oct 5, 2021, 2:29 PM

#

We discussed it this morning in a mod channel

#

The first main blocker is that 3.10 hasn't been released on docker hub yet, so we'll have to wait for that.

In terms of what needs actual testing, we'll want to try out the libraries. Most of the errors are probably going to happen during installation, so they're easy to catch. Some libraries just won't have wheels, and for those our best option is either to drop them, or halt the entire upgrade process

thorny obsidian Oct 5, 2021, 2:31 PM

#

why did it come up in a mod channel in the first place pithink

gritty wind Oct 5, 2021, 2:32 PM

#

mod-channel -> modmail thread
and the answer to that is because someone opened a modmail for it lol

patent pivot Oct 5, 2021, 2:39 PM

#

thorny obsidian <@!165023948638126080> what's the process for updating snekbox to 3.10 (or reall...

as scale said:

wait for docker
see if deps install (right now I think we rely on wheels for almost all deps, not all of them will have 3.10, so we might have to have some workarounds)
upgrade docker image and run tests, no actual snekbox functionality should change with this

dim pelican Oct 5, 2021, 3:25 PM

#

RE: sir-lancebot#842 I am just a bit lost on the re-structure

dusky shoreBOT Oct 5, 2021, 3:25 PM

#

GitHub

PRDraft Add color command

vale ibex Oct 5, 2021, 3:36 PM

#

I can take a look if you like

dim pelican Oct 5, 2021, 3:38 PM

#

Go for it, there is a decent conversation chain too.

Also for the docker issue last night, got that fixed.

vale ibex Oct 5, 2021, 3:38 PM

#

ah nice

dim pelican Oct 5, 2021, 3:39 PM

#

dim pelican wtf That was it

.
For reference

vale ibex Oct 5, 2021, 3:44 PM

#

Did you mark is so that contribs can edit?

dim pelican Oct 5, 2021, 3:44 PM

#

I can try lol
I started the PR before I was a helper so it is on my fork

vale ibex Oct 5, 2021, 3:45 PM

#

Yea, I'm not sure if you can set it afterwards or not

#

Akarys might know

green oriole Oct 5, 2021, 3:45 PM

#

When you edit the PR you have a button "Allow edit from maintainers" to do that

dim pelican Oct 5, 2021, 3:46 PM

#

green oriole Oct 5, 2021, 3:46 PM

#

It gives people with write access to the target repo write access to your fork on that specific branch

#

So there you go

#

Chris should have write access

chrome cradle Oct 5, 2021, 3:46 PM

#

python

vale ibex Oct 5, 2021, 3:46 PM

#

kk that should be it

#

could you do git pull -f

green oriole Oct 5, 2021, 3:47 PM

#

Wait wait wait

#

Make sure your local branch is clean first

dim pelican Oct 5, 2021, 3:47 PM

#

From origin or upstream

vale ibex Oct 5, 2021, 3:47 PM

#

yea, have you got anything locally that isn't pushed?

dim pelican Oct 5, 2021, 3:47 PM

#

Started a color 2.0 to sketch out my thoughts, but not worth keeping. No commits or anything to push

vale ibex Oct 5, 2021, 3:48 PM

#

kk cool

#

I've made edits directly on your branch

#

on your fork

#

so you should just be able to git pull -f

green oriole Oct 5, 2021, 3:48 PM

#

I'd git stash before

#

Juuuust in case

dim pelican Oct 5, 2021, 3:48 PM

#

git pull origin color-677 had no issues

#

Time for upstream?

vale ibex Oct 5, 2021, 3:49 PM

#

did it actually pull anything?

#

since I rebased, I'd expect you to need to -f

dim pelican Oct 5, 2021, 3:49 PM

#

From https://github.com/brad90four/sir-lancebot
 * branch              color-677  -> FETCH_HEAD
Merge made by the 'recursive' strategy.
 .gitpod.yml                                        |   5 +
 README.md                                          |   1 +
 bot/constants.py                                   |   3 +-
 bot/exts/core/extensions.py                        |   2 +-
 .../events/hacktoberfest/hacktober-issue-finder.py |   8 +-
 bot/exts/fun/hangman.py                            | 182 +++++
 bot/exts/fun/quack.py                              |  75 ++
 bot/exts/holidays/halloween/spookyreact.py         |   8 +-
 bot/exts/holidays/valentines/lovecalculator.py     |   3 +-
 bot/exts/utilities/bookmark.py                     |  13 +-
 bot/exts/utilities/emoji.py                        |   4 +-
 bot/resources/fun/hangman_words.txt                | 877 +++++++++++++++++++++
 12 files changed, 1164 insertions(+), 17 deletions(-)
 create mode 100644 .gitpod.yml
 create mode 100644 bot/exts/fun/hangman.py
 create mode 100644 bot/exts/fun/quack.py
 create mode 100644 bot/resources/fun/hangman_words.txt

vale ibex Oct 5, 2021, 3:49 PM

#

cool, that looks like it

#

you should be good now

#

I've rebased your branch onto sirlance main

dim pelican Oct 5, 2021, 3:49 PM

#

Alrighty

vale ibex Oct 5, 2021, 3:51 PM

#

fwiw I didn't make any code changes on your cog, so you might need to update it for the new paths to things

dim pelican Oct 5, 2021, 3:52 PM

#

Should be ok, still have the referenced color name / hex color file in the PR that hasn't been added yet

#

But what I was hung up on was how to restructure the color.py file based on LX and Bluenix's recommendations. I can't wrap my head around what to restructure in a sensible way

#

https://github.com/python-discord/sir-lancebot/pull/842#pullrequestreview-763534999

vale ibex Oct 5, 2021, 3:55 PM

#

ohhh, when you said restructure, I thought you were referring to the restructure we did to lance recently

dim pelican Oct 5, 2021, 3:56 PM

#

Haha no, I got that one handled earlier 👍

#

I wish it was that one, would definitely make my life a bit easier

green oriole Oct 5, 2021, 3:59 PM

#

I find the cog fairly okay-ish organized

vale ibex Oct 5, 2021, 4:00 PM

#

i think what the suggestion is for there to be one group command color

green oriole Oct 5, 2021, 4:00 PM

#

What could help is:

Separate color transformation into another file
Use a dictionary to select the right function
Make use of colorsys when available

vale ibex Oct 5, 2021, 4:00 PM

#

and then have each mode be a subcommand of that

green oriole Oct 5, 2021, 4:00 PM

#

Oh, I thought it was about the code lemon_eyes

vale ibex Oct 5, 2021, 4:00 PM

#

Rather than have this ```py
if mode.lower() == "hex":
await self.hex_to_rgb(ctx, user_color)
elif mode.lower() == "rgb":
rgb_color = self.tuple_create(user_color)
await self.color_embed(ctx, rgb_color)
elif mode.lower() == "hsv":
await self.hsv_to_rgb(ctx, user_color)
elif mode.lower() == "hsl":
await self.hsl_to_rgb(ctx, user_color)
elif mode.lower() == "cmyk":
await self.cmyk_to_rgb(ctx, user_color)
elif mode.lower() == "name":

green oriole Oct 5, 2021, 4:01 PM

#

If we convert this to a dict, it will be waaayyy less duplicate code

#

Like, multiplying subcommands is way more copy paste than that

vale ibex Oct 5, 2021, 4:01 PM

#

at that point you wouldn't have the functions though

#

the functions would be the sub commands

dim pelican Oct 5, 2021, 4:02 PM

#

"Main" color command: parses user input with regex -> goes to sub command?

cold island Oct 5, 2021, 4:02 PM

#

match case hyperlemon

vale ibex Oct 5, 2021, 4:02 PM

#

so you'd have !colour be the parent group command

#

and then have commands under that for each conversion

green oriole Oct 5, 2021, 4:03 PM

#

The PR clearly says it is !color

dim pelican Oct 5, 2021, 4:03 PM

#

Color with an alias for colour

vale ibex Oct 5, 2021, 4:03 PM

#

lemme write a quick basic

#

Akarys was trying to be funny

#

ignore the italian

green oriole Oct 5, 2021, 4:03 PM

#

vale ibex ignore the italian

!colore

timid sentinel Oct 5, 2021, 4:04 PM

#

time to request changes to change the command to !colour and auto-ban for !color /s

vale ibex Oct 5, 2021, 4:05 PM

#

@commands.group(aliases=("colour",))
async def color(self, ctx: commands.Context) -> None:
    await invoke_help_command(ctx)

@color.command(name="hex")
async def hex_to_rgb(self, ctx: commands.Context, hex_string: str) -> None:
    ...

@color.command(name="hsv")
async def hsv_to_rgb(self, ctx: commands.Context, h: int, s: int, v: int) -> None:
    ...

#

each color.command is a subcommand of color

dim pelican Oct 5, 2021, 4:05 PM

#

Oh

vale ibex Oct 5, 2021, 4:06 PM

#

that way each sub command can have different input

#

and describe what it expects

green oriole Oct 5, 2021, 4:07 PM

#

hello docstring copy pasting

vale ibex Oct 5, 2021, 4:07 PM

#

lol

dim pelican Oct 5, 2021, 4:08 PM

#

So instead of static methods or class methods they would be sub-commands. Would they get called directly from when the user uses the color command or would it be able to be called from the "main" command?

vale ibex Oct 5, 2021, 4:08 PM

#

Calling .color would just show the doc string of the group command

#

calling .color hex would call that function directly

dim pelican Oct 5, 2021, 4:09 PM

#

Like if the user does .colour rgb(255,0,0) I will need to regex that to match the "mode" and parse it to get the rgb values

vale ibex Oct 5, 2021, 4:09 PM

#

they'd need to do .color rgb 255 0 0

#

no regex

dim pelican Oct 5, 2021, 4:09 PM

#

Well, I'll need to handle all of the cases

vale ibex Oct 5, 2021, 4:09 PM

#

yea, each mode would have it's own sub command

dim pelican Oct 5, 2021, 4:09 PM

#

🤯

#

So no regex if we do subcommands

vale ibex Oct 5, 2021, 4:10 PM

#

exactly

dim pelican Oct 5, 2021, 4:10 PM

#

Ahh

#

How would I handle sending the user's input to the correct sub-command?

#

Negatory

vale ibex Oct 5, 2021, 4:13 PM

#

dim pelican How would I handle sending the user's input to the correct sub-command?

the fuinction args of each subcommand become the accepted input

#

Discord handles calling the right arg, and will error if the user input doesn't match the args

dim pelican Oct 5, 2021, 4:14 PM

#

https://discordpy.readthedocs.io/en/latest/faq.html#how-do-i-make-a-subcommand

vale ibex Oct 5, 2021, 4:14 PM

#

vale ibex ```py @commands.group(aliases=("colour",)) async def color(self, ctx: commands.C...

EG in this case you would do .color hex FFFFFF and .color hsv 255 0 0

#

and discord.py would just work

dim pelican Oct 5, 2021, 4:15 PM

#

That is sorta what I have with my "modes" if/else structure

#

LX brought up the point to handle rgb(100,100,100) or rgb (100,100,100) or rgb 100,100,100 or rgb 100 100 100 etc

vale ibex Oct 5, 2021, 4:16 PM

#

yea, so in this case, you would force the last one with sub commands

#

the good thing about doing it this way, is that the help text gets automatically generated with what the input should look like

#

!mute 3

stable mountainBOT Oct 5, 2021, 4:16 PM

#

Bad argument

Could not convert "user" into UnambiguousMember or UnambiguousUser.
3 is not a User mention, a User ID or a Username in the format name#discriminator.

#

Command Help

!tempmute <user> [duration] [reason]
Can also use: mute

*Temporarily mute a user for the given reason and duration.

A unit of time should be appended to the duration.
Units (∗case-sensitive):
y - years
m - months∗
w - weeks
d - days
h - hours
M - minutes∗
s - seconds

Alternatively, an ISO 8601 timestamp can be provided for the duration.

If no duration is given, a one hour duration is used by default.*

vale ibex Oct 5, 2021, 4:17 PM

#

!tempmute <user> [duration] [reason] describes the interface

#

and the stuff below that is the docstring for that subcommand

#

you cant perma mute

dim pelican Oct 5, 2021, 4:17 PM

#

!src tempmute

stable mountainBOT Oct 5, 2021, 4:17 PM

#

Command: tempmute

Temporarily mute a user for the given reason and duration.

Source Code

Go to GitHub

dim pelican Oct 5, 2021, 4:20 PM

#

Ok, good stuff to chew on

#

Might need to break a lot of things before they are working again

#

@elder belfry CC for you, had a convo about the PR

dim pelican Oct 5, 2021, 4:24 PM

#

dim pelican Haha no, I got that one handled earlier 👍

Starts here

late wolf Oct 5, 2021, 4:25 PM

#

Using python3.9 (3.9.7)
installing dependencies from lock file

No dependencies to install

Even though it says no dependencies to install I am getting discord.ext.command.errors.ExtensionFailed: Extension: 'bot.exts.fun.typerace' raised an error: ModuleNotFoundError: No module named 'markovify'.
Why?

static canyon Oct 5, 2021, 4:28 PM

#

We're able to edit a mute to be permanent, but not permamute directly If I remember correctly

clever wraith Oct 5, 2021, 4:29 PM

#

site#594 needs reviews

dusky shoreBOT Oct 5, 2021, 4:29 PM

#

GitHub

PROpen docs: Added site documentation for editing sir lancebot on Gitpod

dim pelican Oct 5, 2021, 4:31 PM

#

clever wraith site#594 needs reviews

Should the shell commands be swapped? Need to add the remote and then rename it right?

clever wraith Oct 5, 2021, 4:32 PM

#

No, you rename the pydis origin to upstream and then add your own origin

dim pelican Oct 5, 2021, 4:33 PM

#

Copy, since you are assuming someone is following this the first time and has forked & cloned the repo locally

clever wraith Oct 5, 2021, 4:33 PM

#

Yeah

#

Or just cloned it on GitHub

#

Forked*

late wolf Oct 5, 2021, 4:36 PM

#

late wolf ``` Using python3.9 (3.9.7) installing dependencies from lock file No dependenc...

markovify exists in poetry.lock as well

clever wraith Oct 5, 2021, 4:39 PM

#

Try poetry update

late wolf Oct 5, 2021, 4:43 PM

#

I still get the same error

clever wraith Oct 5, 2021, 4:46 PM

#

Ty brad

dim pelican Oct 5, 2021, 4:51 PM

#

late wolf I still get the same error

Is this a bot that you have running in Docker?

late wolf Oct 5, 2021, 4:51 PM

#

yes

dim pelican Oct 5, 2021, 4:51 PM

#

Have you reloaded the cog in your test server?

late wolf Oct 5, 2021, 4:51 PM

#

wdym?

dim pelican Oct 5, 2021, 4:52 PM

#

Or stopped the docker container and then started it again since you did your poetry install

late wolf Oct 5, 2021, 4:52 PM

#

That I have not

#

Leme restart

dim pelican Oct 5, 2021, 4:53 PM

#

.c r <your command you are testing>
Is what you would run in your test server to reload the cog (assuming this is universal and not just for sir-lancebot)

late wolf Oct 5, 2021, 5:04 PM

#

The error happens when I run the bot itself

dim pelican Oct 5, 2021, 5:07 PM

#

Hmmm, is this for a PR? I don't see that file in the main branch.

late wolf Oct 5, 2021, 5:07 PM

#

No this is not for a pr

#

well it kinda is?

late wolf Oct 5, 2021, 5:08 PM

#

dim pelican Hmmm, is this for a PR? I don't see that file in the main branch.

Wdym

dim pelican Oct 5, 2021, 5:08 PM

#

https://github.com/python-discord/sir-lancebot/tree/main/bot/exts/fun

GitHub

sir-lancebot/bot/exts/fun at main · python-discord/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - sir-lancebot/b...

#

I don't see a typerace.py there

late wolf Oct 5, 2021, 5:08 PM

#

yes cause well its in my forked repo?

dim pelican Oct 5, 2021, 5:08 PM

#

👍

#

What do your imports look like in your file?

late wolf Oct 5, 2021, 5:10 PM

#

import urllib.request

import markovify
import discord
from discord.ext import commands

from bot.bot import Bot

#

I think it involves docker, but I have no clue. I don't think there is anything wrong within the edited files.

timid sentinel Oct 5, 2021, 5:16 PM

#

Are you sure markovify is in the poetry.lock? Did you run poetry add markovify?

late wolf Oct 5, 2021, 5:16 PM

#

Well I deleted the images and ran docker compose up and now its working

late wolf Oct 5, 2021, 5:16 PM

#

timid sentinel Are you sure markovify is in the poetry.lock? Did you run `poetry add markovify`...

Yes

#

I have no clue what was happening before

vale ibex Oct 5, 2021, 5:17 PM

#

if you change dependencies, you need to do docker-compose up --build

late wolf Oct 5, 2021, 5:17 PM

#

oh

brisk brook Oct 5, 2021, 5:17 PM

#

Damm Chris I was gonna say that 😦

brisk brook Oct 5, 2021, 5:17 PM

#

vale ibex if you change dependencies, you need to do docker-compose up --build

I usually use docker-compose build though. I don't remember if I managed to get that to work honestly

vale ibex Oct 5, 2021, 5:18 PM

#

vale ibex In most of our projects we define volumes within the docker compose. This means ...

#

build works too

#

the message I just pinned explains why

dim pelican Oct 5, 2021, 5:19 PM

#

You would think that Helper you explained that to would be able to help others with the same problem 😅

vale ibex Oct 5, 2021, 5:20 PM

#

😄

#

yea

vale ibex Oct 5, 2021, 5:39 PM

#

Depends how complex it is

#

Yea that seems like most of it would go by making it a sub command

#

Alr

brisk brook Oct 5, 2021, 5:43 PM

#

Wait I am confused, wasn't Brad working on this?

dim pelican Oct 5, 2021, 5:44 PM

#

All good, doublev has volunteered to help out

#

I have been struggling with getting the new structure "on paper"

dim pelican Oct 5, 2021, 6:15 PM

#

Sweet, LX had mentioned maybe pulling those out of the class and into the module level, so that way we can remove the staticmethod calls.

I guess those would then need to be ~~moved back~~ called in to the subcommands?

#

Would it return a tuple explicitly from the "if all 0" check?

#

Uh where is that

#

That will later be used to look up a color name, so it is good to have the "#" there

molten perch Oct 5, 2021, 6:56 PM

#

Hey! I would really appreciate if someone could take a look at api#17 , it still needs a "few" reviews.

dusky shoreBOT Oct 5, 2021, 6:56 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

static canyon Oct 5, 2021, 7:11 PM

#

How can I "undo" pushed commits, without locally deleting the changes made? I'm wanting to split a commit into two commits to make it tidier and not sure how to do this

late wolf Oct 5, 2021, 7:11 PM

#

uh u can use soft reset using head

#

so something like git reset --soft HEAD~1 which will remove your last commit.

static canyon Oct 5, 2021, 7:15 PM

#

Thank you

static canyon Oct 5, 2021, 7:15 PM

#

late wolf so something like `git reset --soft HEAD~1` which will remove your last commit.

And I'm guessing HEAD~2 will revert last two commits?

late wolf Oct 5, 2021, 7:15 PM

#

ye

slim widget Oct 5, 2021, 7:17 PM

#

Did you see my comment here, and the comments that followed it? https://github.com/python-discord/sir-lancebot/pull/842#issuecomment-927134556

#

Has the plan changed?

static canyon Oct 5, 2021, 7:26 PM

#

late wolf ye

yeah that worked perfectly, thank you very much 👍

#

That's a lot of god damn conflicts

trail pilot Oct 5, 2021, 7:30 PM

#

Could anyone who can dismiss the reviews on sir-lancebot#860 which requested changes since I implemented those changes?

dusky shoreBOT Oct 5, 2021, 7:30 PM

#

GitHub

PROpen Challenges

slim widget Oct 5, 2021, 7:33 PM

#

Ah right, I see. So the plan now is to use command arguments for the colour components, and not to support e.g. ```
.color rgb(0, 0, 0)

#

👍

static canyon Oct 5, 2021, 7:33 PM

#

How do I resolve conflicts when I can't even see them? 🤔

#

I think it's like 90 conflicts

#

bot#1831

dusky shoreBOT Oct 5, 2021, 7:34 PM

#

GitHub

PROpen Add CustomLogger to prevent IDE lint warnings when calling log.trace.

slim widget Oct 5, 2021, 7:34 PM

#

I'm happy with that. It does negate the need for parsing the input yourself with regexes, which can be a pain 😄

vocal prairie Oct 5, 2021, 7:34 PM

#

~~It's probably just merging in the restructure~~ nvm it's bot not lance

slim widget Oct 5, 2021, 7:35 PM

#

Although, can we get a comment on the PR stating this explicitly? So that anyone contributing/reviewing can see what the intended behaviour is.

static canyon Oct 5, 2021, 7:36 PM

#

static canyon How do I resolve conflicts when I can't even see them? 🤔

Someone please help lol

brisk brook Oct 5, 2021, 7:36 PM

#

static canyon How do I resolve conflicts when I can't even see them? 🤔

Do it locally

#

Which PR is it?

static canyon Oct 5, 2021, 7:36 PM

#

brisk brook Do it locally

How though? I don't know how to view the conflicts in PyCharm

static canyon Oct 5, 2021, 7:36 PM

#

dusky shore

This PR ^

dim pelican Oct 5, 2021, 7:37 PM

#

Hey Blue, is your recent comment regarding limiting the length of the user input?

brisk brook Oct 5, 2021, 7:37 PM

#

Well- just that it literally matches anything lol

#

Did you read my comment 😂

brisk brook Oct 5, 2021, 7:39 PM

#

static canyon This PR ^

Huh, interesting that you got so many conflicts

#

I think you should simply rebase from main. If there are conflicts Git will walk you through them

late wolf Oct 5, 2021, 7:39 PM

#

static canyon How do I resolve conflicts when I can't even see them? 🤔

uh can't see u those conflicts using git?
Its says can't show in editor

static canyon Oct 5, 2021, 7:39 PM

#

brisk brook I think you should simply rebase from `main`. If there are conflicts Git will wa...

How do I do that?

dim pelican Oct 5, 2021, 7:40 PM

#

brisk brook Did you *read my comment* 😂

Can't tell if it is a bug or a feature 🤣

I'll add a minimum certainty too

vocal wolf Oct 5, 2021, 7:41 PM

#

static canyon That's a lot of god damn conflicts

Which PR is this?

static canyon Oct 5, 2021, 7:41 PM

#

vocal wolf Which PR is this?

bot#1831

dusky shoreBOT Oct 5, 2021, 7:41 PM

#

GitHub

PROpen Add CustomLogger to prevent IDE lint warnings when calling log.trace.

vocal wolf Oct 5, 2021, 7:42 PM

#

my god

static canyon Oct 5, 2021, 7:42 PM

#

I know

#

rofl

vocal wolf Oct 5, 2021, 7:42 PM

#

uhhhhhhhhh

static canyon Oct 5, 2021, 7:42 PM

#

I can't even see what the conflicts are

vocal wolf Oct 5, 2021, 7:42 PM

#

is it even worth it to continue with this specific PR?

static canyon Oct 5, 2021, 7:42 PM

#

vocal wolf is it even worth it to continue with this specific PR?

Well it depends on what the conflicts are

vocal wolf Oct 5, 2021, 7:42 PM

#

it does

#

and also the amount of them

late wolf Oct 5, 2021, 7:43 PM

#

static canyon Well it depends on what the conflicts are

static canyon Oct 5, 2021, 7:43 PM

#

I can't even see the conflicts at the moment

late wolf Oct 5, 2021, 7:43 PM

#

These?

static canyon Oct 5, 2021, 7:43 PM

#

It could literally just be because I'm changing the import or something

vocal wolf Oct 5, 2021, 7:43 PM

#

vocal wolf is it even worth it to continue with this specific PR?

@static canyon I thought you already looked into them, that's why I made this comment

static canyon Oct 5, 2021, 7:43 PM

#

vocal wolf <@!442244135840382978> I thought you already looked into them, that's why I made...

Looked into what?

vocal wolf Oct 5, 2021, 7:43 PM

#

the conflicts

static canyon Oct 5, 2021, 7:43 PM

#

As I keep saying, I can't even view the conflicts

vocal prairie Oct 5, 2021, 7:44 PM

#

static canyon It could literally just be because I'm changing the import or something

I'd guess it's from a PR like this one: https://github.com/python-discord/bot/pull/1825

brisk brook Oct 5, 2021, 7:44 PM

#

smh Numerlor 😤

vocal wolf Oct 5, 2021, 7:47 PM

#

static canyon As I keep saying, I **can't even view** the conflicts

I understand, I just thought you had previously been able to look into them. I hope everything goes well here, prob best to make a backup branch locally.

static canyon Oct 5, 2021, 7:48 PM

#

I don't think I'm explaining myself properly because no one seems to understand.

I need to know how to view what the conflicts are. How can I view them?

dim pelican Oct 5, 2021, 7:48 PM

#

brisk brook Did you *read my comment* 😂

Hey Blue, I currently have the certainty set at 50, I'm thinking to bump it to 75?

late wolf Oct 5, 2021, 7:48 PM

#

static canyon I don't think I'm explaining myself properly because no one seems to understand....

There really isn't a how?
When I click on the pr at the bottom it just shows the conflicting files

trail pilot Oct 5, 2021, 7:48 PM

#

There is a how

late wolf Oct 5, 2021, 7:48 PM

#

oh there is

brisk brook Oct 5, 2021, 7:48 PM

#

dim pelican Hey Blue, I currently have the certainty set at 50, I'm thinking to bump it to 7...

You can see my testing in the testing server. Maybe give it a try with the same inputs?

static canyon Oct 5, 2021, 7:48 PM

#

late wolf There really isn't a how? When I click on the pr at the bottom it just shows the...

I'm not asking what the conflicting files are.

late wolf Oct 5, 2021, 7:49 PM

#

oh

#

sorry then

static canyon Oct 5, 2021, 7:49 PM

#

I'm asking what the actual conflicts within those files are

trail pilot Oct 5, 2021, 7:49 PM

#

I think how I used to do it in pycharm is just pull main and then it'll tell me all the merge conflicts and I manually went through it, but there was a much better way than that

#

I think a git gui has a much better way

late wolf Oct 5, 2021, 7:50 PM

#

Just wanted to drop this cause thought it might be helpful: https://www.atlassian.com/git/tutorials/using-branches/merge-conflicts

vocal wolf Oct 5, 2021, 7:50 PM

#

static canyon I don't think I'm explaining myself properly because no one seems to understand....

iirc if you try git rebase -i origin/main after git fetch you should be able to go through the conflicts, might not be the best way to do it though if you want to just view them

static canyon Oct 5, 2021, 7:51 PM

#

vocal wolf iirc if you try `git rebase -i origin/main` after `git fetch` you should be able...

So git fetch, then git rebase -i origin/main?

vocal wolf Oct 5, 2021, 7:51 PM

#

ye

static canyon Oct 5, 2021, 7:51 PM

#

Thanks, I'll try that

vocal wolf Oct 5, 2021, 7:55 PM

#

static canyon So `git fetch`, then `git rebase -i origin/main`?

this would be more for resolving conflicts though

static canyon Oct 5, 2021, 7:57 PM

#

Yeah, I'm wanting to resolve them

#

25 conflicts, and they all seem to be easy fixes

brisk brook Oct 5, 2021, 8:04 PM

#

Yeah so what that will do @static canyon since you haven't worked a lot with Git is that it re-applies the commits onto the new head.

That means that when the branch originally branched off (also called based on) will change. Moving the whole thing by re-comitting the commits.

Essentially what Git will do is take your changes and apply them on the new base/head (which you decide is the newest commit of main). As if you would commit the same changes there again.

#

This of course can have conflicts because Git is working with old commits, which is exactly what we want. You will have to force-push after this though

dim pelican Oct 5, 2021, 8:07 PM

#

Did ya break it

static canyon Oct 5, 2021, 8:07 PM

#

brisk brook Yeah so what that will do <@!442244135840382978> since you haven't worked a lot ...

Right yeah, that makes sense. Thanks for the explanation 👍

dim pelican Oct 5, 2021, 8:09 PM

#

Add this after line 66:

buffer.seek(0)

#

I don't think you need the await on line 67

#

noice

#

Could you test it with

.colour rgb (100,0,0)
.colour rgb(100,0,0)
.colour rgb 100, 0, 0
.colour rgb 100 0 0

#

But should it?

austere hornet Oct 5, 2021, 8:13 PM

#

Lmao

gritty wind Oct 5, 2021, 8:15 PM

#

@cold island ziggy zig zig more pings for my favorite zebra.

I did a thing:

https://github.com/HassanAbouelela/site-1/pull/8

I still haven't looked into redirects, but the guides should be live and building automatically

dim pelican Oct 5, 2021, 8:15 PM

#

Alrighty, I was under the impression to be as flexible as possible when it came to handling the user input

gritty wind Oct 5, 2021, 8:15 PM

#

I can see your beautiful collapsible elements :O

#

disclaimer: Not a euphemism

austere hornet Oct 5, 2021, 8:17 PM

#

gritty wind <@!512354988157173763> ziggy zig zig more pings for my favorite zebra. I did a ...

Lol

dim pelican Oct 5, 2021, 8:26 PM

#

Welcome to the color madness

#

Anyways, gotta go!

vale ibex Oct 5, 2021, 8:33 PM

#

Yea, that seems about right

cold island Oct 5, 2021, 8:33 PM

#

gritty wind <@!512354988157173763> ziggy zig zig more pings for my favorite zebra. I did a ...

It's not my branch lol

vale ibex Oct 5, 2021, 8:34 PM

#

It might be worth looking into using inline fields, so that you use more width, rather than making a long embed

gritty wind Oct 5, 2021, 8:34 PM

#

hm?

cold island Oct 5, 2021, 8:34 PM

#

The preview

#

It should be of my PR?

#

oooh

gritty wind Oct 5, 2021, 8:34 PM

#

Yeah

cold island Oct 5, 2021, 8:34 PM

#

@gritty wind sorry

#

I slandered you

#

Looked at the wrong page

gritty wind Oct 5, 2021, 8:35 PM

#

Haha it's a bit confoosing

cold island Oct 5, 2021, 8:35 PM

#

Very cool 👌

#

You want to add that to the site repo?

#

I think it will confusing with so many numbers

vale ibex Oct 5, 2021, 8:36 PM

#

Is there a sixth mode we can add, so the columns are balenced?

#

it would make the embed look better

cold island Oct 5, 2021, 8:37 PM

#

YIQ? lol

vale ibex Oct 5, 2021, 8:37 PM

#

YcbCr YUV

#

https://en.wikipedia.org/wiki/List_of_color_spaces_and_their_uses

#

kek

#

sounds good

vocal wolf Oct 5, 2021, 8:38 PM

#

@static canyon very nice job on fixing conflicts.

gritty wind Oct 5, 2021, 8:38 PM

#

cold island You want to add that to the site repo?

That's the idea once I hammer out a few bugs

vale ibex Oct 5, 2021, 8:38 PM

#

not sure about the brackets though, we should probably keep those

cold island Oct 5, 2021, 8:38 PM

#

gritty wind That's the idea once I hammer out a few bugs

very nais

gritty wind Oct 5, 2021, 8:38 PM

#

I just found more missing urls

cold island Oct 5, 2021, 8:40 PM

#

I always remember it as "intensity" for some reason

#

yeah

clever wraith Oct 5, 2021, 8:45 PM

#

When someone has time could they merge site#594? All checks and approvals are there

dusky shoreBOT Oct 5, 2021, 8:45 PM

#

GitHub

PROpen docs: Added site documentation for editing sir lancebot on Gitpod

slim widget Oct 5, 2021, 8:47 PM

#

Have you tried putting them in code-blocks?

#

Like (255, 255, 255)

gritty wind Oct 5, 2021, 8:47 PM

#

I have site#599 blocking my changes for static previews. It's just updating http links to https. Would appreciate a review :D

I need a review from an admin or Kat

dusky shoreBOT Oct 5, 2021, 8:47 PM

#

GitHub

PROpen Switches HTTP Links To HTTPS

slim widget Oct 5, 2021, 8:48 PM

#

That sometimes makes things look neater.

static canyon Oct 5, 2021, 8:49 PM

#

vocal wolf <@!442244135840382978> very nice job on fixing conflicts.

ty 😄
And thanks for the assistance with viewing them

clever wraith Oct 5, 2021, 8:50 PM

#

What the hell is YIQ

#

I don't know shit about it

cold island Oct 5, 2021, 8:53 PM

#

hmmm can you try with code blocks and brackets?

clever wraith Oct 5, 2021, 8:53 PM

#

@clever wraith where are you testing this?

#

I've got a feeling a lot of people are gonna try .colour hex b00b69

slim widget Oct 5, 2021, 8:54 PM

#

clever wraith I've got a feeling a lot of people are gonna try `.colour hex b00b69`

Is this not currently supported?

static canyon Oct 5, 2021, 8:54 PM

#

bot#1798 and bot#1806 seem to have fallen through the cracks unnoticed. I opened them just over a month ago, and they never got the second required review. Would appreciate any reviews anyone can give 👍

dusky shoreBOT Oct 5, 2021, 8:54 PM

#

GitHub

PROpen Apply infractions before DMing
PROpen Prevent role hierarchy issues with infractions

slim widget Oct 5, 2021, 8:55 PM

#

Ohhh right 😄

clever wraith Oct 5, 2021, 8:55 PM

#

slim widget Is this not currently supported?

No it is

slim widget Oct 5, 2021, 8:55 PM

#

Nevermind

dim pelican Oct 5, 2021, 8:55 PM

#

The sixth should be the name

slim widget Oct 5, 2021, 8:55 PM

#

Just oblivious as always 😄

#

I wonder what colour that is though 🤔

#

Ah

#

Quite a nice colour actually.

#

Kind of fuchsia.

vale ibex Oct 5, 2021, 8:56 PM

#

YIQ is a float

slim widget Oct 5, 2021, 8:56 PM

#

Alright, that sounds like a good idea 👍

vale ibex Oct 5, 2021, 8:56 PM

#

which is why it's weird

#

IE its 0.0-1.0

#

#

maybe just round to 2 d.p and it'll be fine

cold island Oct 5, 2021, 9:05 PM

#

You can just multiply by 255 and round it

vocal wolf Oct 5, 2021, 9:05 PM

#

static canyon ty 😄 And thanks for the assistance with viewing them

ok_handbutflipped

austere hornet Oct 5, 2021, 9:09 PM

#

Prob mine too ngl

cold island Oct 5, 2021, 9:09 PM

#

Go do your homework

elder belfry Oct 5, 2021, 9:25 PM

#

dim pelican I can try lol I started the PR before I was a helper so it is on my fork

damm congrats on becoming helper lemon_hearteyes

austere hornet Oct 5, 2021, 9:37 PM

#

What timezone are you in?

#

Oh ok

#

Ikr

dusky shoreBOT Oct 5, 2021, 9:38 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

dim pelican Oct 5, 2021, 9:51 PM

#

elder belfry damm congrats on becoming helper <:lemon_hearteyes:754441880149688511>

Thanks! Sorry for the delay lol

cold island Oct 5, 2021, 10:01 PM

#

@gritty wind so for how long does the netifly link work

gritty wind Oct 5, 2021, 10:01 PM

#

It's supposed to be a permalink

cold island Oct 5, 2021, 10:02 PM

#

Is there like... a limit?

gritty wind Oct 5, 2021, 10:02 PM

#

From forms experience, they basically work forever

cold island Oct 5, 2021, 10:02 PM

#

interesting

#

It should create a link only when site content changes I think

#

And not API stuff

gritty wind Oct 5, 2021, 10:03 PM

#

That granularity really isn't feasible, but creating deployments doesn't cost anything

cold island Oct 5, 2021, 10:03 PM

#

alr

gritty wind Oct 5, 2021, 10:04 PM

#

Either way, it'll eventually be moot once we separate API out

cold island Oct 5, 2021, 10:04 PM

#

yeah

gritty wind Oct 5, 2021, 10:24 PM

#

Just flexing on you poor, non preview-having peeps at this point 🦾

patent pivot Oct 5, 2021, 11:06 PM

#

hi - super quick review https://github.com/python-discord/site/pull/601

GitHub

Add www.pythondiscord.com to ALLOWED_HOSTS by jb3 · Pull Request #6...

Preparing for our move to www.pythondiscord.com

#

just adding www.pythondiscord.com to ALLOWED_HOSTS, literally one line

#

actually might need to change PARENT_HOST as well, cc @gritty wind does that change stuff you're doing?

gritty wind Oct 5, 2021, 11:07 PM

#

So what’s allowed-hosts used for

patent pivot Oct 5, 2021, 11:08 PM

#

ALLOWED_HOSTS is just a django filtering step to control what hosts can be used to access django

#

PARENT_HOST i'm not sure about, but we need to change it from pythondiscord.com to www.pythondiscord.com

gritty wind Oct 5, 2021, 11:08 PM

#

PARENT_HOST isn’t easily available during build time, so I use a mock value, which is string replace after the compilation is done

#

I don’t think hosts are enforced with the static build

patent pivot Oct 5, 2021, 11:08 PM

#

so here https://github.com/python-discord/site/blob/main/pydis_site/settings.py#L201

stable mountainBOT Oct 5, 2021, 11:08 PM

#

pydis_site/settings.py line 201

PARENT_HOST = env('PARENT_HOST', default='pythondiscord.com')```

gritty wind Oct 5, 2021, 11:08 PM

#

Okay that should be fine

patent pivot Oct 5, 2021, 11:09 PM

#

alright sweet

gritty wind Oct 5, 2021, 11:09 PM

#

Do you need an

#

Approval thumb

patent pivot Oct 5, 2021, 11:09 PM

#

uhhh once i change this yea

gritty wind Oct 5, 2021, 11:09 PM

#

Why are we going to www anyways lol

clever wraith Oct 5, 2021, 11:10 PM

#

clever wraith When someone has time could they merge site#594? All checks and approvals are th...

Bump

patent pivot Oct 5, 2021, 11:10 PM

#

gritty wind Why are we going to www anyways lol

me and chris read https://www.yes-www.org/why-use-www/ and it sounded about right

Why use www?

gritty wind Oct 5, 2021, 11:11 PM

#

Nice

#

It’s missing a review from a core dev Kronifer

#

Oh is it just content

#

Alright you’re good to go

#

Did something break Joe

patent pivot Oct 5, 2021, 11:21 PM

#

lol nah

#

chris told me i was wrong

#

hmmm

#

so

#

https://www.pythondiscord.com/ works fine

Python Discord | Home

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

but

#

the links are all built without www

gritty wind Oct 5, 2021, 11:23 PM

#

Yeah parent host sets that lol

vale ibex Oct 5, 2021, 11:24 PM

#

iirc parent hosts would also mean subdomains get put under www too

#

if we put www in there

#

do we use CommonMiddleware?

#

if so, we can set PREPEND_WWW to true

patent pivot Oct 5, 2021, 11:25 PM

#

oh wait

#

maybe we use DEFAULT_HOST

gritty wind Oct 5, 2021, 11:26 PM

#

Maybe

#

Yeah that

patent pivot Oct 5, 2021, 11:26 PM

#

gritty wind Oct 5, 2021, 11:26 PM

#

I’ve only had bad experiences with django host tbh when do we remove sub domains smh

patent pivot Oct 5, 2021, 11:26 PM

#

lol soon soon

#

maybe this?

vale ibex Oct 5, 2021, 11:33 PM

#

seems about right

patent pivot Oct 5, 2021, 11:37 PM

#

cc @vale ibex @gritty wind https://github.com/python-discord/site/pull/602

GitHub

Update hosts.py to default to www by jb3 · Pull Request #602 · pyth...

Attempt two at #601

gritty wind Oct 5, 2021, 11:37 PM

#

Is any of this actually testable

vale ibex Oct 5, 2021, 11:37 PM

#

incident_investigating

patent pivot Oct 5, 2021, 11:37 PM

#

lol

#

probably

gritty wind Oct 5, 2021, 11:38 PM

#

Could deploy it on my own domain, buuuuutt it’s easier to just approve and see if it breaks

vale ibex Oct 5, 2021, 11:39 PM

#

it entrely breaks dev lol

patent pivot Oct 5, 2021, 11:39 PM

#

fuck

#

lol

vale ibex Oct 5, 2021, 11:39 PM

#

since it pushes to www.pythondiscord.local/*

patent pivot Oct 5, 2021, 11:39 PM

#

shit

#

okay

#

hm

vale ibex Oct 5, 2021, 11:42 PM

#

IG we just need to get contribs to add www. to hosts?

#

like we do for other sub domains

patent pivot Oct 5, 2021, 11:42 PM

#

I guess, or we conditional in development

vale ibex Oct 5, 2021, 11:44 PM

#

I'd rather deal with hosts, rather than conditional it

patent pivot Oct 5, 2021, 11:49 PM

#

hmm yea

patent pivot Oct 5, 2021, 11:50 PM

#

vale ibex IG we just need to get contribs to add www. to hosts?

if you set this up does it work as intended

vale ibex Oct 5, 2021, 11:51 PM

#

hmmmm

#

did we remove that subdomain?

#

or is this a problem

patent pivot Oct 5, 2021, 11:51 PM

#

as expected

#

there is no /

#

try http://api.pythondiscord.local:8000/bot/

vale ibex Oct 5, 2021, 11:52 PM

#

gives me django auto docs

patent pivot Oct 5, 2021, 11:52 PM

#

yea then it works

vale ibex Oct 5, 2021, 11:52 PM

#

nice

patent pivot Oct 5, 2021, 11:53 PM

#

approval pls

#

we will see if it works

vale ibex Oct 5, 2021, 11:55 PM

#

ah, yea 😄

patent pivot Oct 5, 2021, 11:58 PM

#

yeah that's fixed the links

vale ibex Oct 5, 2021, 11:59 PM

#

should we redirect to www. too?

#

or is that the next part of your master plan

patent pivot Oct 6, 2021, 12:00 AM

#

vale ibex should we redirect to www. too?

just did to

vale ibex Oct 6, 2021, 12:01 AM

#

is there some rollout delay?

patent pivot Oct 6, 2021, 12:02 AM

#

vale ibex is there some rollout delay?

cache

#

try now

#

hmmm it's 302'ing

#

i want 308

vale ibex Oct 6, 2021, 12:03 AM

#

yea lgtm now

#

on 302s

vocal prairie Oct 6, 2021, 12:03 AM

#

What's the difference between a 302 and a 308?

vale ibex Oct 6, 2021, 12:03 AM

#

this at CF level?

#

browsers cache 308s more irrc

vocal prairie Oct 6, 2021, 12:04 AM

#

oh ok

patent pivot Oct 6, 2021, 12:04 AM

#

kube ingress

#

308 is permanent yea, 302 is temporary

vale ibex Oct 6, 2021, 12:04 AM

#

I think 308 also means search engines replace their indexes too

patent pivot Oct 6, 2021, 12:05 AM

#

yeah

vocal prairie Oct 6, 2021, 12:05 AM

#

Oh that's interesting

patent pivot Oct 6, 2021, 12:10 AM

#

alright I think banks has found the answer

#

need to put on some 80s pop to write nginx configuration

vale ibex Oct 6, 2021, 12:10 AM

#

A_YeahIDidIt_REH

patent pivot Oct 6, 2021, 12:13 AM

#

@vale ibex i think

#

this

#

no that 302s what

vale ibex Oct 6, 2021, 12:16 AM

#

Yea I have no clue with nginx ingress lol

#

Should read up on it at some point

#

But I'm in bed now, so today is not that day kek

patent pivot Oct 6, 2021, 12:17 AM

#

lmfao

#

i will resolve this i will do everything it takes

#

oh I know why

#

forgot a location block around it

#

alright solved it I think

#

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  annotations:
    nginx.ingress.kubernetes.io/auth-tls-verify-client: "on"
    nginx.ingress.kubernetes.io/server-snippet: |
      location ~* / {
        return 308 https://www.pythondiscord.com$request_uri;
      }
    nginx.ingress.kubernetes.io/auth-tls-secret: "kube-system/mtls-client-crt-bundle"
    nginx.ingress.kubernetes.io/auth-tls-error-page: "https://www.youtube.com/watch?v=dQw4w9WgXcQ"
  name: www-redirect
spec:
  tls:
  - hosts:
      - "pythondiscord.com"
    secretName: pythondiscord.com-tls
  rules:
  - host: pythondiscord.com
    http:
      paths:
      - path: /(.*)
        pathType: Prefix
        backend:
          service:
            name: site
            port:
              number: 80

#

that was the answer

#

pretty clean in the end tbqh

vale ibex Oct 6, 2021, 12:24 AM

#

Nice nice

patent pivot Oct 6, 2021, 12:24 AM

#

writing a #dev-announcements about the hosts recommended changes

vale ibex Oct 6, 2021, 12:24 AM

#

Good idea

#

We might mention it in contributing guides too

patent pivot Oct 6, 2021, 12:25 AM

#

hmmm i'd hang fire on that for now, me and volcyy might get subdomain removal through in coming weeks which means we don't need to care for this

vale ibex Oct 6, 2021, 12:25 AM

#

Ah nice

patent pivot Oct 6, 2021, 12:27 AM

#

okay I checked google docs, the 308 should be enough to indicate content move

trail pilot Oct 6, 2021, 1:07 AM

#

What is everyone's thoughts on changing out reactions to a view for some games in sir-lancebot

austere hornet Oct 6, 2021, 1:17 AM

#

trail pilot What is everyone's thoughts on changing out reactions to a view for some games i...

Sorry, I don't understand. Could you please rephrase it a little maybe?

dim pelican Oct 6, 2021, 1:18 AM

#

Instead of reactions doing the pagination, having different views in a dropdown type thing?

austere hornet Oct 6, 2021, 1:25 AM

#

dim pelican Instead of reactions doing the pagination, having different views in a dropdown ...

Oh oh ok yeah that would look a lot better

trail pilot Oct 6, 2021, 1:45 AM

#

dim pelican Instead of reactions doing the pagination, having different views in a dropdown ...

I was more thinking using views for stuff like tic-tac-toe and the likes

austere hornet Oct 6, 2021, 1:48 AM

#

trail pilot I was more thinking using views for stuff like tic-tac-toe and the likes

What do you mean by "views"?

trail pilot Oct 6, 2021, 1:49 AM

#

views are discord's new UI

austere hornet Oct 6, 2021, 1:50 AM

#

Aahh

#

Ok

#

Well

summer kettle Oct 6, 2021, 5:39 AM

#

Hello
I am interested in contributing. Is there something I can help with, or somewhere I can read up on what needs assistance?

obsidian patio Oct 6, 2021, 5:43 AM

#

@patent pivot why migrate to using www?

gritty wind Oct 6, 2021, 6:38 AM

#

obsidian patio <@165023948638126080> why migrate to using www?

me and chris read https://www.yes-www.org/why-use-www/ and it sounded about right

Me is joe

Why use www?

winged sigil Oct 6, 2021, 7:42 AM

#

I just see a 404 no sign of a 308 for this url: https://www.pythondiscord.com/rules

#

@patent pivot this

static canyon Oct 6, 2021, 7:45 AM

#

winged sigil I just see a 404 no sign of a 308 for this url: https://www.pythondiscord.com/ru...

It's /pages/rules

#

But yeah, /rules used to redirect to /pages/rules

#

Redirect from /guides to /pages/guides etc. are also broken

gritty wind Oct 6, 2021, 7:52 AM

#

Are those CF redirects or in app redirects hmm

#

CF

obsidian patio Oct 6, 2021, 8:04 AM

#

gritty wind > me and chris read https://www.yes-www.org/why-use-www/ and it sounded about ri...

Alrighty, thanks

#

Makes sense, even though I love the clean look of not using www

fervent sage Oct 6, 2021, 8:21 AM

#

no need to sue ww specifically

#

use h instead, which is beautiful

green oriole Oct 6, 2021, 9:11 AM

#

I think we broke the short urls, didn't we

#

Okay, it just doesn't use short urls on www.pydis.com, @patent pivot might want to add a CF route for that one

remote wigeon Oct 6, 2021, 9:49 AM

#

fervent sage no need to sue ww specifically

apex domains go brr

patent pivot Oct 6, 2021, 10:08 AM

#

uhhh

patent pivot Oct 6, 2021, 10:08 AM

#

gritty wind Are those CF redirects or in app redirects hmm

those are in app

winged sigil Oct 6, 2021, 10:16 AM

#

static canyon It's /pages/rules

I did what this message said to try: #dev-announcements message

remote wigeon Oct 6, 2021, 10:26 AM

#

aaaaaaaaaa @patent pivot you made me have an iternal debate about www or no-www again

patent pivot Oct 6, 2021, 10:31 AM

#

I don't get why redirects aren't processing

gritty wind Oct 6, 2021, 10:31 AM

#

The redirects app is black magic

#

Is it imaginable that we drop them in the future

#

I really don’t like the idea of having to maintain them forever just to keep backwards compatibility

remote wigeon Oct 6, 2021, 10:36 AM

#

why dont you just do a pagerule that redirects non www to www

gritty wind Oct 6, 2021, 10:38 AM

#

The redirection in general already works

#

But we have separate dynamic redirection rules which are not designed with that in mind

#

And seem to be unable to parse the links with www

remote wigeon Oct 6, 2021, 10:38 AM

#

hmmmm

#

strange

green oriole Oct 6, 2021, 10:39 AM

#

patent pivot I don't get why redirects aren't processing

Default redirect is working, but short links aren't working on www.pydis.com, which makes me think the worker has a misconfigurated route

patent pivot Oct 6, 2021, 10:40 AM

#

No theu are both broken

#

oh no maybe not

green oriole Oct 6, 2021, 10:40 AM

#

I can make them work

patent pivot Oct 6, 2021, 10:41 AM

#

why doesn't /rules work on pythondiscord.com, I could have sworn it did

green oriole Oct 6, 2021, 10:41 AM

#

Unless it is some form of caching on my device

#

https://pydis.com/rules

Python Discord - Python Discord Rules

The rules of our community.

#

This works without problem

#

https://pythondiscord.com/rules has never been a thing

#

The problem is https://www.pydis.com/rules does not work

patent pivot Oct 6, 2021, 10:43 AM

#

ah right

remote wigeon Oct 6, 2021, 10:46 AM

#

green oriole The problem is https://www.pydis.com/rules does not work

not sure if the www rules apply for short url domains

green oriole Oct 6, 2021, 10:46 AM

#

Currently it doesn't, but I think it should

remote wigeon Oct 6, 2021, 10:46 AM

#

why

#

you get none of the advantages and a longer url

#

unlike the normal domain where there's technical advantages

green oriole Oct 6, 2021, 10:57 AM

#

Well, I could see some people trying to access it using that url

#

it doesn't hurt to support it here too

clever wraith Oct 6, 2021, 12:40 PM

#

Morning all!

green oriole Oct 6, 2021, 1:19 PM

#

P0 approval needed: https://github.com/python-discord/bot/pull/1859

GitHub

Revert "Apply infractions before DMing" by Akarys42 · Pull Request ...

Reverts #1806
This causes notes to send DMs

cold island Oct 6, 2021, 1:31 PM

#

merged

green oriole Oct 6, 2021, 1:37 PM

#

Thank you mister pig zebra

#

And mister owl

cold island Oct 6, 2021, 1:38 PM

#

Why isn't the bot connecting #dev-log message

#

Well now it did

green oriole Oct 6, 2021, 2:44 PM

#

I actually wonder why it took so long to connect

#

I don't even see the startup sequence in the logs

gritty wind Oct 6, 2021, 2:50 PM

#

CI?

#

Or is there anything in the k8s action

green oriole Oct 6, 2021, 2:54 PM

#

In the grafana log

slim widget Oct 6, 2021, 3:35 PM

#

You done this?

slim widget Oct 6, 2021, 4:27 PM

#

Ah it's no problem. I can do it, if you like?

slim widget Oct 6, 2021, 5:22 PM

#

Great stuff 👍

dusky shoreBOT Oct 6, 2021, 5:44 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

patent pivot Oct 6, 2021, 5:44 PM

#

more or less

molten perch Oct 6, 2021, 5:56 PM

#

Unfortunately, it is not. At least 2 approving reviews are required by reviewers with write access. :/

#

However, there's a reason to those checks. 🙂
No, you don't.

#

Or.. be patient. 😄
It has to be reviewed thoroughly, anyways. 🙂

cold island Oct 6, 2021, 6:18 PM

#

@molten perch @clever wraith Contributors count

molten perch Oct 6, 2021, 6:22 PM

#

cold island <@!263957159807549450> <@456226577798135808> Contributors count

The check where contributors count has not been setup on the api repo, as far as I see.

sleek steppe Oct 6, 2021, 6:30 PM

#

Yes, it uses the GitHub branch protection rather than the policy bot check

cold island Oct 6, 2021, 6:33 PM

#

molten perch The check where contributors count has not been setup on the api repo, as far as...

o rly

#

The API repo? I don't know anything about fast API

dim pelican Oct 6, 2021, 6:39 PM

#

^ Or how to test it

trail pilot Oct 6, 2021, 6:41 PM

#

Oh, could any of the members on sir-lancebot dismiss a few stale reviews?

#

on sir-lancebot#860

dusky shoreBOT Oct 6, 2021, 6:41 PM

#

GitHub

PROpen Challenges

trail pilot Oct 6, 2021, 6:41 PM

#

Because I implemented the changes on both of them

molten perch Oct 6, 2021, 6:42 PM

#

Actually, you can. However, not the API itself, but the SQLAlchemy models. 😄

dim pelican Oct 6, 2021, 6:43 PM

#

trail pilot Oh, could any of the members on sir-lancebot dismiss a few stale reviews?

you mean @timid sentinel and @static canyon right?

trail pilot Oct 6, 2021, 6:43 PM

#

dim pelican you mean <@!493839819168808962> and <@!442244135840382978> right?

yep

#

I implemented the changes for both those reviews

green oriole Oct 6, 2021, 6:46 PM

#

You should ask @hardy gorge

static canyon Oct 6, 2021, 6:46 PM

#

I've dismissed both reviews so they won't block the PR @trail pilot

green oriole Oct 6, 2021, 6:47 PM

#

Why asking Sebastiaan?

#

He is in charge of the fastapi project

trail pilot Oct 6, 2021, 6:47 PM

#

static canyon I've dismissed both reviews so they won't block the PR <@!584817706646110333>

Thank you!

patent pivot Oct 6, 2021, 6:49 PM

#

uhhh… like all our other projects lol

trail pilot Oct 6, 2021, 6:49 PM

#

trail pilot Thank you!

Now all that's left is an approval from a core dev

patent pivot Oct 6, 2021, 6:49 PM

#

👍

#

it’s fine to do imo, we do it on all other projects

static canyon Oct 6, 2021, 7:15 PM

#

dim pelican Oct 6, 2021, 7:15 PM

#

#

No problem, I have lots of practice with that

dusky shoreBOT Oct 6, 2021, 7:16 PM

#

GitHub

PRDraft Make development workflow easier to use

hardy gorge Oct 6, 2021, 7:37 PM

#

Sounds good

patent pivot Oct 6, 2021, 8:01 PM

#

ya i'm gonna start shortly

#

cc <@&409416496733880320> hello migrating

green oriole Oct 6, 2021, 8:02 PM

#

hello migrating I am dad

patent pivot Oct 6, 2021, 8:06 PM

#

arthur cj trigger blackbox

radiant merlinBOT Oct 6, 2021, 8:06 PM

#

:tools: Pick a CronJob to trigger

radiant merlinBOT Oct 6, 2021, 8:06 PM

#

radiant merlin :tools: Pick a CronJob to trigger

🌬️ Spawned job blackbox-895401745872715807

austere hornet Oct 6, 2021, 8:08 PM

#

Why did @radiant merlin 's avatar change to a sun??

patent pivot Oct 6, 2021, 8:08 PM

#

austere hornet Why did <@861747395632037890> 's avatar change to a sun??

it's the KA icon

austere hornet Oct 6, 2021, 8:09 PM

#

patent pivot it's the KA icon

Oh it is? I remember it used to be a photo of King Arthur

last patio Oct 6, 2021, 8:14 PM

#

👋

dusky shoreBOT Oct 6, 2021, 8:15 PM

#

GitHub

PRDraft Make development workflow easier to use

molten perch Oct 6, 2021, 8:20 PM

#

I didn't know about that. However, I still believe it would be more convenient.

patent pivot Oct 6, 2021, 8:43 PM

#

arthur deploy ls

radiant merlinBOT Oct 6, 2021, 8:43 PM

#

Deployments in namespace default

+----------+------------------------+------------+
|  Status  | Deployment             |  Replicas  |
|----------+------------------------+------------|
|    🔴    | bitwarden              |    0/0     |
|    🟢    | black-knight           |    1/1     |
|    🟢    | bot                    |    1/1     |
|    🟢    | code-jam-management    |    1/1     |
|    🟢    | forms-backend          |    2/2     |
|    🟢    | ghost                  |    1/1     |
|    🟢    | grafana                |    1/1     |
|    🟢    | grafana-image-renderer |    1/1     |
|    🟢    | graphite               |    1/1     |
|    🟢    | h-asgi                 |    1/1     |
|    🟢    | hastebin               |    1/1     |
|    🟢    | king-arthur            |    1/1     |
|    🟢    | logcord                |    1/1     |
|    🔴    | metabase               |    0/0     |
|    🔴    | metricity              |    0/0     |
|    🟢    | modmail-bot            |    1/1     |
|    🟢    | modmail-web            |    1/1     |
|    🟢    | mongodb                |    1/1     |
|    🟢    | olli                   |    1/1     |
|    🔴    | pixels                 |    0/0     |
|    🟢    | policy-bot             |    1/1     |
|    🟢    | postgres               |    1/1     |
|    🟢    | prestashop             |    1/1     |
|    🟢    | public-stats           |    1/1     |
|    🟢    | quackstack             |    1/1     |
|    🟢    | redis                  |    1/1     |
|    🟢    | sir-lancebot           |    1/1     |
|    🔴    | site                   |    0/0     |
|    🟢    | snekbox                |    1/1     |
|    🟢    | thread-bot             |    1/1     |
+----------+------------------------+------------+

last patio Oct 6, 2021, 8:44 PM

#

https://www.gnu.org/software/emacs/manual/html_node/emacs/Amusements.html

#

14

vocal prairie Oct 6, 2021, 8:47 PM

#

PG 14 is out? I feel like 13 was released 3 months ago

#

Even though it's been like a year

patent pivot Oct 6, 2021, 8:48 PM

#

yes

stable mountainBOT Oct 6, 2021, 8:48 PM

#

README.md?plain=1 line 10

CI Tested PostgreSQL versions: `9.4`, `9.5`, `9.6`, `10`, `11`, `12`, `13````

patent pivot Oct 6, 2021, 8:56 PM

#

newly released

#

https://www.yes-www.org/why-use-www/

Why use www?

clever wraith Oct 6, 2021, 9:08 PM

#

last patio https://www.gnu.org/software/emacs/manual/html_node/emacs/Amusements.html

emacs backward is scame

vale ibex Oct 6, 2021, 9:13 PM

#

yo, can I get a quick approval on bot#1862

dusky shoreBOT Oct 6, 2021, 9:13 PM

#

GitHub

PROpen Add appeal categories to mod categories

trail pilot Oct 6, 2021, 9:13 PM

#

Could a core-dev look at sir-lancebot#860 when they're free? I think a core dev approval is the last one it needs before it can be merged

dusky shoreBOT Oct 6, 2021, 9:13 PM

#

GitHub

PROpen Challenges

twilit juniper Oct 6, 2021, 9:15 PM

#

that bothers me so much

trail pilot Oct 6, 2021, 9:19 PM

#

twilit juniper that bothers me so much

Oh that's switched now

#

The dropdown is above the button

twilit juniper Oct 6, 2021, 9:20 PM

#

Sorry lol I didn't read the whole PR

trail pilot Oct 6, 2021, 9:20 PM

#

twilit juniper Sorry lol I didn't read the whole PR

You're fine!

vale ibex Oct 6, 2021, 9:24 PM

#

I can, but it wouldn't do anything lol

#

anyone who authored a commit is skipped by policy bot

gritty wind Oct 6, 2021, 9:24 PM

#

Why would he do reviews when he can tell people to do them and they just happen

vale ibex Oct 6, 2021, 9:24 PM

#

this is true

#

@gritty wind you do review now

gritty wind Oct 6, 2021, 9:25 PM

#

What's appeals 2

#

#895417395261341766

#

How rude

vale ibex Oct 6, 2021, 9:25 PM

#

gritty wind What's appeals 2

electric boogaloo

#

just from that screenshot no

#

what repo?

#

What are you trying to do?

#

not too sure

#

I'm not familiar with that repo

#

probably best off asking Seb

#

or just try adding it back and see if you run into issues

#

pre-commit isn't even in the deps

#

So there might have been something Seb was trying to check in a pre-commit hook that wasn't working

#

seems like a pretty similar setup to our other repos

#

I imagine it would just work if you copied from python or lance and added black.

#

one is guitar hero, the other is the best public transport the world has ever seen

patent pivot Oct 6, 2021, 9:47 PM

#

https://github.com/python-discord/site/pull/604

GitHub

Update ALLOWED_HOSTS to include internal address by jb3 · Pull Requ...

gritty wind Oct 6, 2021, 9:50 PM

#

The arrows show where there was a diversion in the tree

#

So from one branch to another

#

Dots are commits

patent pivot Oct 6, 2021, 9:51 PM

#

arthur deploy restart bot

radiant merlinBOT Oct 6, 2021, 9:51 PM

#

:warning: Please confirm you want to restart deploy/bot in default

radiant merlinBOT Oct 6, 2021, 9:51 PM

#

radiant merlin :warning: Please confirm you want to restart `deploy/bot` in `default`

:white_check_mark: Restarted deployment bot in namespace default.

patent pivot Oct 6, 2021, 10:05 PM

#

no more hosts file 🎉

clever wraith Oct 7, 2021, 12:33 AM

#

Anybody got something in need of reviews

austere hornet Oct 7, 2021, 12:46 AM

#

Have you reviewed api#17? I've heard it's a big one rn

dusky shoreBOT Oct 7, 2021, 12:46 AM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

dusky shoreBOT Oct 7, 2021, 1:38 AM

#

GitHub

PRMerged Set logging level for async-rediscache to warning

dim pelican Oct 7, 2021, 1:38 AM

#

sir-lancebot#859 should be ready to test again (RE: matching anything, I have now set if a user query is over 50 characters it will not match, but the limit on the score from rapidfuzz needs to stay around ~60 for things to not break)

dusky shoreBOT Oct 7, 2021, 1:38 AM

#

GitHub

PROpen Add WTF Python Command

vocal prairie Oct 7, 2021, 1:38 AM

#

Are you sure that's the right number- nvm

dim pelican Oct 7, 2021, 1:39 AM

#

No no that is definitely sir-lance with the problem, not me with a typo

green oriole Oct 7, 2021, 8:02 AM

#

Are those... metro lines?

patent pivot Oct 7, 2021, 8:14 AM

#

green oriole Are those... metro lines?

tube map lol

green oriole Oct 7, 2021, 9:57 AM

#

What's the difference lemon_cowboy

static canyon Oct 7, 2021, 10:12 AM

#

green oriole What's the difference <:lemon_cowboy:894978461716852788>

What the French call the métro we call the tube/underground. They're basically the same

green oriole Oct 7, 2021, 10:29 AM

#

Why the heck do you have so many lines wtf

static canyon Oct 7, 2021, 11:49 AM

#

Yeah, there's a lot lol

timid sentinel Oct 7, 2021, 12:08 PM

#

tube map is very cool

green oriole Oct 7, 2021, 1:27 PM

#

Da heck

green oriole Oct 7, 2021, 1:47 PM

#

lol

#

I think I can name every single station here

#

Let's move to ot though

dusky shoreBOT Oct 7, 2021, 3:08 PM

#

GitHub

PRMerged Add "Now playing" status

dim pelican Oct 7, 2021, 3:08 PM

#

I can't review what I can't test

...or can I?

molten perch Oct 7, 2021, 3:11 PM

#

If you have some experience with SQLAlchemy or with ORMs overall, you can test out the validations. It'd a huge help.
I've added Postgresql to the compose file, so it should work just fine.

#

¯_(ツ)_/¯

dim pelican Oct 7, 2021, 3:13 PM

#

Time to learn SQLAlchemy I guess...
I can review content, but without really testing I would leave my review as "comments" rather than approval. I think it is a more robust review that way

molten perch Oct 7, 2021, 3:14 PM

#

dim pelican Time to learn SQLAlchemy I guess... I can review content, but without really tes...

That'd be the best. It's not that hard, I believe.

dim pelican Oct 7, 2021, 3:14 PM

#

molten perch That'd be the best. It's not that hard, I believe.

I appreciate the optimism in my abilities lemon_bald

#

Nope, mods and higher

#

!otn s rick

static canyon Oct 7, 2021, 3:19 PM

#

What are you looking for?

dim pelican Oct 7, 2021, 3:20 PM

#

I'm guessing if he has any ot names

static canyon Oct 7, 2021, 3:21 PM

#

I can confirm that is indeed a thing

#

👍

dusky shoreBOT Oct 7, 2021, 3:41 PM

#

GitHub

PROpen Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

molten perch Oct 7, 2021, 3:43 PM

#

Just a note for your functional review: relationships, and the embed validations are number one priorities. 🙂

austere hornet Oct 7, 2021, 3:46 PM

#

Pretty sure that was there for a long time

fallen patrol Oct 7, 2021, 4:11 PM

#

@vale ibex can you pls check the cache length? I have an idea on why the cache isn't fully populated

#

len(guild.members) iirc

vale ibex Oct 7, 2021, 4:13 PM

#

fallen patrol <@126811506632294400> can you pls check the cache length? I have an idea on why ...

we've been checking it every so often, it's fine now

#

it must have been a one off issue