#dev-contrib | Python | Page 132

patent pivot Sep 4, 2021, 8:52 AM

#

yeah

#

okay going to merge django prom

green oriole Sep 4, 2021, 9:04 AM

#

Thank you thank you

desert vessel Sep 4, 2021, 1:13 PM

#

hey people

#

sir-lancebot isnt startin on m1 macs

#

rapidfuzz is causing it to crash

#

any workarounds ?

green oriole Sep 4, 2021, 1:14 PM

#

what error do you get?

#

also have you ran docker-compose build recently

desert vessel Sep 4, 2021, 1:15 PM

#

i dont even have docker installed on this computer

#

it was working fine

#

before

#

i run poetry run task start everytime

stable mountainBOT Sep 4, 2021, 1:17 PM

#

Hey @desert vessel!

Uh-oh! It looks like your message got zapped by our spam filter. We currently don't allow .txt attachments, so here are some tips to help you travel safely:

• If you attempted to send a message longer than 2000 characters, try shortening your message to fit within the character limit or use a pasting service (see below)

• If you tried to show someone your code, you can use codeblocks
(run !code-blocks in #bot-commands for more information) or use a pasting service like:

https://paste.pythondiscord.com

desert vessel Sep 4, 2021, 1:17 PM

#

yikes

#


 File "~/Library/Caches/pypoetry/virtualenvs/sir-lancebot-b_NkKrJV-py3.9/lib/python3.9/site-packages/rapidfuzz/process.py", line 4, in <module>
    from rapidfuzz.cpp_process import extract, extractOne, extract_iter
ImportError: dlopen(~/Library/Caches/pypoetry/virtualenvs/sir-lancebot-b_NkKrJV-py3.9/lib/python3.9/site-packages/rapidfuzz/cpp_process.cpython-39-darwin.so, 2): no suitable image found.  Did find:
        ~/Library/Caches/pypoetry/virtualenvs/sir-lancebot-b_NkKrJV-py3.9/lib/python3.9/site-packages/rapidfuzz/cpp_process.cpython-39-darwin.so: mach-o, but wrong architecture
        ~/Library/Caches/pypoetry/virtualenvs/sir-lancebot-b_NkKrJV-py3.9/lib/python3.9/site-packages/rapidfuzz/cpp_process.cpython-39-darwin.so: mach-o, but wrong architecture

#

here

vale ibex Sep 4, 2021, 1:26 PM

#

you'll need to run docker with x86 arch, since some deps won't work on arm

#

I know @patent pivot and @vocal wolf were dealing with this recently

#

Can't remember what the command was

desert vessel Sep 4, 2021, 1:27 PM

#

it was working just fine a week back

vale ibex Sep 4, 2021, 1:27 PM

#

we recently switched to rapidfuzz from fuzzywuzzy, due to licensing

desert vessel Sep 4, 2021, 1:27 PM

#

oh

#

https://www.piwheels.org/project/rapidfuzz/

piwheels - rapidfuzz

rapid fuzzy string matching

patent pivot Sep 4, 2021, 1:30 PM

#

vale ibex I know <@!165023948638126080> and <@!196664644113268736> were dealing with this ...

yeah I think you had to --platform linux/amd64 @desert vessel

desert vessel Sep 4, 2021, 1:30 PM

#

eh i think i can do this

desert vessel Sep 4, 2021, 1:30 PM

#

patent pivot yeah I think you had to `--platform linux/amd64` <@!786599434960109568>

alright :D

vale ibex Sep 4, 2021, 1:30 PM

#

patent pivot yeah I think you had to `--platform linux/amd64` <@!786599434960109568>

was that the thing that worked in the end, or was it the env var before the command

#

I forget

#

i wonder if it's worth forcing this in the Dockerfile with FROM --platform=linux/amd64 python:3.9-slim

desert vessel Sep 4, 2021, 1:33 PM

#

btw, chris im sorry, im still working on the pr, things just broke with rapid fuzz, im running it on docker now

vale ibex Sep 4, 2021, 1:33 PM

#

don't be sorry, like I've said before, there's no rush on any of our issues

#

if something is really an urgent fix, then it would likely be a staff member dealing with it

desert vessel Sep 4, 2021, 1:33 PM

#

isnt there like a time limit ?

vale ibex Sep 4, 2021, 1:33 PM

#

no time limit no.

desert vessel Sep 4, 2021, 1:33 PM

#

oh

#

welp

#

my bad

vale ibex Sep 4, 2021, 1:34 PM

#

If things are taking a while we may reach out to see if you are still planning on working on it

desert vessel Sep 4, 2021, 1:34 PM

#

ah alright

vale ibex Sep 4, 2021, 1:34 PM

#

Just in case things have changed and you aren't interested

desert vessel Sep 4, 2021, 1:34 PM

#

Hmm k

gritty wind Sep 4, 2021, 1:36 PM

#

Is there no way to run on host with the M1s?

green oriole Sep 4, 2021, 1:36 PM

#

Yes, but it is next level pain

#

I would recommend some platform emulators like qemu

vale ibex Sep 4, 2021, 1:37 PM

#

vale ibex i wonder if it's worth forcing this in the Dockerfile with `FROM --platform=linu...

thoughts on doing this on all our dockerfiles?

patent pivot Sep 4, 2021, 1:37 PM

#

vale ibex was that the thing that worked in the end, or was it the env var before the comm...

for docker run that works, otherwise you need the env var

vale ibex Sep 4, 2021, 1:38 PM

#

patent pivot for docker run that works, otherwise you need the env var

yea, thought so

green oriole Sep 4, 2021, 1:38 PM

#

vale ibex thoughts on doing this on all our dockerfiles?

Sure, I don't mind. There are no downsides to this, are there?

patent pivot Sep 4, 2021, 1:38 PM

#

gritty wind Is there no way to run on host with the M1s?

run on host works yeah, but no wheels are built for M1

#

So containers fail because no gcc

#

which is obscure-ish

#

so you can set docker to emulate amd64

vale ibex Sep 4, 2021, 1:38 PM

#

none that I can imagine, just standardises the platform, so we won't have to worry about some not having wheels

patent pivot Sep 4, 2021, 1:38 PM

#

vale ibex i wonder if it's worth forcing this in the Dockerfile with `FROM --platform=linu...

oh is that a thing

#

I'm pro on that

vale ibex Sep 4, 2021, 1:39 PM

#

yupper

#

it works on my machine, but I think we should have someone on arm test it too before merging

desert vessel Sep 4, 2021, 1:39 PM

#

gritty wind Is there no way to run on host with the M1s?

im trying 😂

#

we need to get it to install rapidfuzz

green oriole Sep 4, 2021, 1:40 PM

#

green oriole I would recommend some platform emulators like qemu

Bascially docker run --rm --privileged multiarch/qemu-user-static:register, except it will only work on AMD64 because ??

desert vessel Sep 4, 2021, 1:41 PM

#

#

which i may or may not have done

vale ibex Sep 4, 2021, 1:41 PM

#

Thats on your host though right?

#

rather than docker

desert vessel Sep 4, 2021, 1:41 PM

#

vale ibex Thats on your host though right?

yep

vale ibex Sep 4, 2021, 1:41 PM

#

Could you edit the first line in the Dockerfile to FROM --platform=linux/amd64 python:3.9-slim and then try docker-compose up --build

desert vessel Sep 4, 2021, 1:41 PM

#

ok so it installs

#

but doesnt run

desert vessel Sep 4, 2021, 1:42 PM

#

vale ibex Could you edit the first line in the Dockerfile to `FROM --platform=linux/amd64 ...

sure

#

its building now

vale ibex Sep 4, 2021, 1:43 PM

#

cool

desert vessel Sep 4, 2021, 1:43 PM

#

:0

vale ibex Sep 4, 2021, 1:43 PM

#

if it works, I'll PR the change to all our repos

desert vessel Sep 4, 2021, 1:43 PM

#

you guys pr'ing

#

or shall i ?

desert vessel Sep 4, 2021, 1:43 PM

#

vale ibex if it works, I'll PR the change to all our repos

sure :D

vale ibex Sep 4, 2021, 1:43 PM

#

Did it start fine?

desert vessel Sep 4, 2021, 1:44 PM

#

still building 😂

#

first time build takes time

vale ibex Sep 4, 2021, 1:44 PM

#

ah yea might take a bit

desert vessel Sep 4, 2021, 1:44 PM

#

yee

#

nothing is cached on my mac

#

cuz i removed and installed docker just now

#

docker*

vale ibex Sep 4, 2021, 1:45 PM

#

hah I know the feeling, I recently deleted my cache and freed up ~70GB

desert vessel Sep 4, 2021, 1:45 PM

#

xD

vale ibex Sep 4, 2021, 1:45 PM

#

docker system prune --all --volumes

desert vessel Sep 4, 2021, 1:45 PM

#

ON NO

vale ibex Sep 4, 2021, 1:45 PM

#

running this every so often now lol

desert vessel Sep 4, 2021, 1:45 PM

#

i forgor to set USE_FAKEREDIS to true

#

😂

#

im very smart

vale ibex Sep 4, 2021, 1:45 PM

#

that's fine, if it's hitting that error it means it built just fine

#

anyway, if you're using docker you shouldn't need to

#

since real redis exists

desert vessel Sep 4, 2021, 1:46 PM

#

thats excellent

#

it builds

vale ibex Sep 4, 2021, 1:46 PM

#

cool

desert vessel Sep 4, 2021, 1:47 PM

#

merge conflicts smh

#

i cant commit the same thing and pull the same line

#

AHHHH screw git

#

chris, lemme know when you push, i'll have to reclone

#

:D

vale ibex Sep 4, 2021, 1:48 PM

#

Are you on a branch on your fork?

desert vessel Sep 4, 2021, 1:49 PM

#

yep

vale ibex Sep 4, 2021, 1:49 PM

#

Once this PR is merged, you'll just need to pull from upstream, and then git rebase main while you have your branch checked out

desert vessel Sep 4, 2021, 1:50 PM

#

ah, alright

#

tysmm

vale ibex Sep 4, 2021, 1:50 PM

#

I'm going through all our repos now and PRing this, so might take a minute

#

alr, that's all the repos I have checkout locally

desert vessel Sep 4, 2021, 2:16 PM

#

awesome

stable mountainBOT Sep 4, 2021, 3:10 PM

#

It has arrived!

Here's your reminder: :thusky:
[Jump back to when you created the reminder](#dev-contrib message)

celest charm Sep 4, 2021, 3:11 PM

#

damn @green oriole, you're making a linked list of reminders

#

I don't really have an opinion on this tbh, but then I'm not really contributing anything to the bot 🙂

trail pilot Sep 4, 2021, 4:12 PM

#

What does the "good first issue" label mean? On PRs at least

thorny obsidian Sep 4, 2021, 4:14 PM

#

It's a good issue for those who are new to contributing/haven't contributed to OSS before. It's not overly complex, has well defined scope and requirements, and shouldn't involve in-depth knowledge of the project itself.

trail pilot Sep 4, 2021, 4:17 PM

#

thorny obsidian It's a good issue for those who are new to contributing/haven't contributed to O...

Ah alright

austere hornet Sep 4, 2021, 4:31 PM

#

@vale ibex Question for you: do you think a mad libs generator would be ok for @dusky shore ?

vale ibex Sep 4, 2021, 4:35 PM

#

Doesn't sound like something we'd be against as a concept

#

I'd suggest writing up an issue describing what you plan to do 😄

austere hornet Sep 4, 2021, 4:35 PM

#

vale ibex I'd suggest writing up an issue describing what you plan to do 😄

Alr, thanks

desert vessel Sep 4, 2021, 5:00 PM

#

!remind 9h gotta work on the pr and fix rapidfuzz on m1 macs and good morning future me

stable mountainBOT Sep 4, 2021, 5:00 PM

#

You got it!

Your reminder will arrive on <t:1630807244:F>!

trail pilot Sep 4, 2021, 5:04 PM

#

I have a question - how hard is it to add a new dependency?

#

I want to use bs4 for something

#

in sir lancebot

brazen charm Sep 4, 2021, 5:08 PM

#

you add it to pyproject.toml relock and check if everything works

molten perch Sep 4, 2021, 5:08 PM

#

It's not hard to add a dependency, but judging by my experience with BS4, I'm not sure how that could work with discord.py.

brazen charm Sep 4, 2021, 5:09 PM

#

executors

trail pilot Sep 4, 2021, 5:22 PM

#

We have BS4 for the python discord bot I think

trail pilot Sep 4, 2021, 5:22 PM

#

brazen charm you add it to pyproject.toml relock and check if everything works

ah alright, thank you

thorny obsidian Sep 4, 2021, 5:23 PM

#

@vale ibex did d.py v2 change their embed params?

#

vale ibex Sep 4, 2021, 5:23 PM

#

Nah, footer isn't part of the init

#

You need to call set_footer() on the embed obj

brisk brook Sep 4, 2021, 5:24 PM

#

Anybody else have like 50 sequential Docker Desktop updates?

thorny obsidian Sep 4, 2021, 5:24 PM

#

Is that new to v2 or has it always been like that?

vale ibex Sep 4, 2021, 5:24 PM

#

For a while afaik

#

I didn't use it before 1.5 tho

thorny obsidian Sep 4, 2021, 5:24 PM

#

huh, curious how this hasn't been caught then

brisk brook Sep 4, 2021, 5:25 PM

#

If only you used a static type checker 💅

vale ibex Sep 4, 2021, 5:27 PM

#

thorny obsidian huh, curious how this hasn't been caught then

4Shrug

thorny obsidian Sep 4, 2021, 5:28 PM

#

I may need help debugging ddg

trail pilot Sep 4, 2021, 5:32 PM

#

Hm, ran into this while trying to update the pyproject.toml and after docker-compose build

thorny obsidian Sep 4, 2021, 5:36 PM

#

hurmmmm

#

need to do some investigating

trail pilot Sep 4, 2021, 5:40 PM

#

trail pilot Hm, ran into this while trying to update the pyproject.toml and after docker-com...

Would anyone know as to why this is happening?

brisk brook Sep 4, 2021, 5:43 PM

#

Did you just add bs4 as a dependency?

brazen charm Sep 4, 2021, 5:43 PM

#

what version is fakeredis on?

trail pilot Sep 4, 2021, 5:44 PM

#

brisk brook Did you just add bs4 as a dependency?

Yep,

vocal wolf Sep 4, 2021, 5:44 PM

#

vale ibex I know <@!165023948638126080> and <@!196664644113268736> were dealing with this ...

oh that pain, let me get the command

trail pilot Sep 4, 2021, 5:44 PM

#

brazen charm what version is fakeredis on?

async-rediscache = {extras = ["fakeredis"], version = "~=0.1.4"}
version 0.1.4

brazen charm Sep 4, 2021, 5:44 PM

#

aioredis was pinned recently because it had a new major version, and there are some issues with how async-rediscache pins its deps so it may have updated something inadvertently

#

that's async-rediscache not fakeredis

vocal wolf Sep 4, 2021, 5:45 PM

#

@desert vessel DOCKER_DEFAULT_PLATFORM=linux/amd64 docker-compose up (and whatever arguments you want afterward, probably --build to force build)

trail pilot Sep 4, 2021, 5:45 PM

#

brazen charm that's async-rediscache not fakeredis

It says fakeredis in the extras though I think, unless I'm interpreting it wrong with what extras mean

#


[tool.poetry.dependencies]
python = "^3.9"
aiodns = "~=2.0"
arrow = "~=1.1.0"
fuzzywuzzy = "~=0.17"
beautifulsoup4 = "~=4.9"
pillow = "~=8.1"
sentry-sdk = "~=0.19"
PyYAML = "~=5.4"
"discord.py" = "~=1.7.2"
async-rediscache = {extras = ["fakeredis"], version = "~=0.1.4"}
emojis = "~=0.6.0"
matplotlib = "~=3.4.1"
lxml = "~=4.4"

this is the entire part of the dependencies of the pyproject.toml i edited on my fork to add beautifulsoup4 and lxml

thorny obsidian Sep 4, 2021, 5:46 PM

#

oh @vocal wolf feel free to delete my spam above

vocal wolf Sep 4, 2021, 5:46 PM

#

thorny obsidian oh <@!196664644113268736> feel free to delete my spam above

questionmark?

brazen charm Sep 4, 2021, 5:47 PM

#

Yes, but that tells us nothing about what version is actually being used after you relocked; do pip show on the package or look into the lockfile

trail pilot Sep 4, 2021, 5:47 PM

#

brazen charm Yes, but that tells us nothing about what version is actually being used after y...

ah alright

#

Version 1.6 for fakeredis

brisk brook Sep 4, 2021, 5:47 PM

#

^ this Xith

brazen charm Sep 4, 2021, 5:48 PM

#

ah your pyproject is fairly outdated, merge master into your branch

trail pilot Sep 4, 2021, 5:48 PM

#

Yeah, I need to update stuff like rapidfuzz and what not

#

and will do

brazen charm Sep 4, 2021, 5:49 PM

#

I believe it should work fine after you merge and aioredis gets a version constraint

vocal wolf Sep 4, 2021, 5:49 PM

#

thorny obsidian oh <@!196664644113268736> feel free to delete my spam above

it be gone.

clever wraith Sep 4, 2021, 5:56 PM

#

Why does gpl wanna make my life hell

trail pilot Sep 4, 2021, 5:56 PM

#

brazen charm I believe it should work fine after you merge and aioredis gets a version constr...

Well I merged and fixed merge conflicts, but turns out that poetry won't like it if you update its lock file since it had a ton of merge conflicts

brazen charm Sep 4, 2021, 5:56 PM

#

don't resolve those, just resolve conflicts in the pyproject and relock before commiting the merge

trail pilot Sep 4, 2021, 5:57 PM

#

ah alright

clever wraith Sep 4, 2021, 5:59 PM

#

@green oriole regarding cowsay, I found a somewhat drop in replacement using the Apache license. Can I use that instead or is it like GPL in that it's incomparable with MIT?

trail pilot Sep 4, 2021, 5:59 PM

#

brazen charm don't resolve those, just resolve conflicts in the pyproject and relock before c...

Well I didn't even edit the poetry.lock anymore and it's still telling me it can't read the lock file

#

I only fixed the merge conflicts in the TOML

clever wraith Sep 4, 2021, 5:59 PM

#

clever wraith <@407110650217627658> regarding cowsay, I found a somewhat drop in replacement u...

Sorry for the ping btw

celest charm Sep 4, 2021, 6:00 PM

#

clever wraith Why does gpl wanna make my life hell

.randomcase free software is when you can't do anything with it

dusky shoreBOT Sep 4, 2021, 6:00 PM

#

freE sOFTWARe is WhEn YOu cAN't Do anYTHiNg WITh iT

clever wraith Sep 4, 2021, 6:00 PM

#

Lmfao

clever wraith Sep 4, 2021, 6:01 PM

#

celest charm .randomcase free software is when you can't do anything with it

Feels

austere hornet Sep 4, 2021, 6:11 PM

#

dusky shore >>> freE sOFTWARe is WhEn YOu cAN't Do anYTHiNg WITh iT

Lmao

thorny obsidian Sep 4, 2021, 6:21 PM

#

@vale ibex I think I caught everything, lance is running in my test server if you wanna have at it.
The only commands I haven't rested so far are those that are month locked and those that need an API key

#

(if anyone else wants to help test the restructure, let me know and I can send over my test server invite link)

cold island Sep 4, 2021, 6:26 PM

#

thorny obsidian <@!126811506632294400> I think I caught everything, lance is running in my test ...

You can temporarily remove the month lock

thorny obsidian Sep 4, 2021, 6:26 PM

#

yeah, I'm just a bit lazy atm >_>

vocal wolf Sep 4, 2021, 6:26 PM

#

Are we restructuring sir lance atm?

#

if not, what's happening?

cold island Sep 4, 2021, 6:26 PM

#

Yis

vocal wolf Sep 4, 2021, 6:27 PM

#

veri nais

#

Thank you, @thorny obsidian!

thorny obsidian Sep 4, 2021, 6:27 PM

#

so far:

vocal wolf Sep 4, 2021, 6:27 PM

#

an entire folder for snakes? what's in there lol

cold island Sep 4, 2021, 6:28 PM

#

I'd place int e under core

vocal wolf Sep 4, 2021, 6:28 PM

#

also, should games_fun be renamed to just fun?

cold island Sep 4, 2021, 6:29 PM

#

cold island I'd place int e under core

Or utilities. What's in utilities?

austere hornet Sep 4, 2021, 6:31 PM

#

thorny obsidian so far:

Nice

cold island Sep 4, 2021, 6:31 PM

#

Also, can't the avatar stuff and snakes be under fun?

vale ibex Sep 4, 2021, 6:33 PM

#

thorny obsidian <@!126811506632294400> I think I caught everything, lance is running in my test ...

I'm out atm, can test it later tonight or tomorrow if you can push it to github

thorny obsidian Sep 4, 2021, 6:33 PM

#

So snakes is a whole slew of commands. It was from one of the code jams, so was unsure if we wanted to keep it separate

#

utilities:

#

avatar_modification has holiday stuff as well as fun stuff, so I wanted to bring it up a level since it is a bit of an odd ext

vale ibex Sep 4, 2021, 6:35 PM

#

Yea, I merged a bunch of commands into one cog, so they could share logic

vocal wolf Sep 4, 2021, 6:39 PM

#

thorny obsidian So `snakes` is a whole slew of commands. It was from one of the code jams, so wa...

I see

thorny obsidian Sep 4, 2021, 6:40 PM

#

vocal wolf an entire folder for snakes? what's in there lol

there is sooo much

vocal wolf Sep 4, 2021, 6:40 PM

#

oh god lol

#

yep, that folder does need to exist indeed

thorny obsidian Sep 4, 2021, 6:40 PM

#

I'm fine with moving it under fun, was just unsure if we wanted to give it a bit more visibility due to it being the product of a jam

cold island Sep 4, 2021, 6:45 PM

#

Personally I think placing it under fun is fine

#

The cog is notoriously under-maintained, so making it stand out doesn't appeal to me

thorny obsidian Sep 4, 2021, 6:48 PM

#

any objection to me adding some READMEs to folders to help explain stuff? Like a README for that cog to explain its history

cold island Sep 4, 2021, 6:48 PM

#

thorny obsidian utilities:

Ah I see. int e can go under core then yep

cold island Sep 4, 2021, 6:49 PM

#

thorny obsidian any objection to me adding some READMEs to folders to help explain stuff? Like a...

Sounds great

austere hornet Sep 4, 2021, 6:50 PM

#

thorny obsidian any objection to me adding some READMEs to folders to help explain stuff? Like a...

I like that idea!

cold island Sep 4, 2021, 6:51 PM

#

@thorny obsidian I'd consider adding an events ext and placing aoc and hacktoberfest there

#

What's under trivia?

cold island Sep 4, 2021, 6:53 PM

#

thorny obsidian utilities:

Maybe ping should be under core as well

#

And source

thorny obsidian Sep 4, 2021, 6:55 PM

#

cold island What's under trivia?

right now trivia_quiz, but it's also going to house the trivia night idea I want to do

#

I may move trivia_quiz under fun, we'll see

cold island Sep 4, 2021, 6:56 PM

#

The trivia night stuff can be another thing to put under events

#

Basically separate the nice-to-have stuff, the stuff we use to run the bot, and stuff we use to run the community

tough imp Sep 4, 2021, 7:08 PM

#

trail pilot Well I didn't even edit the poetry.lock anymore and it's still telling me it can...

The lockfile probably got corrupted by git adding the <<< >>> bits; I think you can probably just remove it & relock afresh? On the other hand if it's trying to read the lockfile before a lock maybe its contents affect the resolution somehow 🤷

#

well realitically you can either take yours or theirs, and relock, or just delete the lockfile and relock

#

its not obvious to me how the latter could be worse

#

#

ah its prob reading it because of this feature

trail pilot Sep 4, 2021, 7:30 PM

#

tough imp The lockfile probably got corrupted by git adding the <<< >>> bits; I think you ...

Worked

#

Thanks!

tough imp Sep 4, 2021, 7:32 PM

#

awesome

vocal prairie Sep 4, 2021, 7:37 PM

#

@thorny obsidian If you're not doing it already, I think it might be nice to normalize spaces in file names. For example, these two (in the main branch of the repo) use different styles

fervent sage Sep 4, 2021, 7:55 PM

#

I'd argue conflip is one word at this point

#

Whereas connect four definitely isn't

clever wraith Sep 4, 2021, 7:56 PM

#

Ah yes conflip

vocal prairie Sep 4, 2021, 7:57 PM

#

fervent sage I'd argue conflip is one word at this point

That's fine, but I'm not talking about those specific cases, which ones can be put up to whoever's judgement

#

But there is inconsistency. Like, conversationstarters.py certainly isn't one word

fervent sage Sep 4, 2021, 8:04 PM

#

Yeah

trail pilot Sep 4, 2021, 8:11 PM

#

Yeah iirc all file names should be lowercase and have underscores in them (correct me if I’m wrong though)

celest charm Sep 4, 2021, 8:27 PM

#

you are correct

#

well, they don't need to have underscores in them if it's one word (like math)

vale ibex Sep 4, 2021, 8:35 PM

#

mat_h.py

celest charm Sep 4, 2021, 8:38 PM

#

vale ibex mat_h.py

h

static canyon Sep 4, 2021, 9:25 PM

#

@brisk brook what exactly did you mean by your comment on bot#1804?

dusky shoreBOT Sep 4, 2021, 9:25 PM

#

GitHub

PROpen Add support for !infraction last

static canyon Sep 4, 2021, 9:25 PM

#

"Can we just get a comment that the Infraction converter special-cases last as getting the last infraction from the author?"

#

Where would such a comment go?

clever wraith Sep 4, 2021, 9:30 PM

#

vale ibex mat_h.py

Why do you tag your mats by letter

static canyon Sep 4, 2021, 9:30 PM

#

Also for bot#1806 we seem to always use tuples for in checks, as apposed to sets (can only see one case which uses a direct set) -- will add the comment though

dusky shoreBOT Sep 4, 2021, 9:30 PM

#

GitHub

PROpen Apply infractions before DMing

brisk brook Sep 4, 2021, 9:33 PM

#

static canyon Where would such a comment go?

Do we have more room in the doc-string?

#

Otherwise it would fit fine just above the embed I think?

static canyon Sep 4, 2021, 9:34 PM

#

brisk brook Do we have more room in the doc-string?

Which docstring?

brisk brook Sep 4, 2021, 9:35 PM

#

For the command group

static canyon Sep 4, 2021, 9:37 PM

#

Hmm

#

I mean it's clear in the converter that last is handled separately

#

    async def infraction_group(self, ctx: Context, infraction: Infraction = None) -> None:
        """
        Infraction manipulation commands.
        
        If `infraction` is passed then this command fetches that infraction.
        NB: `Infraction` converter supports 'l', 'last' and 'recent' to get most recent infraction made by `ctx.author`.
        """
```something like this? @brisk brook

brisk brook Sep 4, 2021, 9:41 PM

#

static canyon ```py async def infraction_group(self, ctx: Context, infraction: Infraction ...

I usually prefer doc-strings that read like a page

    async def infraction_group(self, ctx: Context, infraction: Infraction = None) -> None:
        """
        Infraction manipulation commands.
        
        If `infraction` is passed then this command fetches that infraction. The `Infraction` converter also
        supports 'l', 'last' and 'recent' to get most recent infraction made by `ctx.author`.
        """

static canyon Sep 4, 2021, 9:43 PM

#

That's gonna be way past the linting 120 chars though

#

193 to be exact

#

Ah wait nvm there's a newline there

#

Think I'll go with```py
"""
Infraction manipulation commands.

    If `infraction` is passed then this command fetches that infraction. The `Infraction` converter
    supports 'l', 'last' and 'recent' to get the most recent infraction made by `ctx.author`.
    """```

brisk brook Sep 4, 2021, 10:14 PM

#

How does that look with the help command now @static canyon?

static canyon Sep 4, 2021, 10:15 PM

#

brisk brook How does that look with the help command now <@!442244135840382978>?

#

fine imo

#

Maybe "'l', 'last' and 'recent'" but that's ott I think

brisk brook Sep 4, 2021, 10:24 PM

#

I think that's good yeah

thorny obsidian Sep 5, 2021, 12:41 AM

#

hurm, so troubleshooting something. One of lancebot's commands creates a local image and inserts it into an embed. If the embed gets edited, the image gets duplicated outside of the embed. Is there a way around this while generating the image on the fly and not pre-hosting it somewhere?

exotic ember Sep 5, 2021, 1:02 AM

#

sounds like a discord bug, which command is it?

thorny obsidian Sep 5, 2021, 1:05 AM

#

.ddg, it only happens when it's a local image, if you go to edit it it doubles the image. The only way I can find around it is to host the image from the start, which is difficult with this game

#

this is what it looks like in my test server: #778705917050486835 message
The only thing that changes with that code is the footer of the embed is edited

fervent sage Sep 5, 2021, 1:11 AM

#

.src ddg

dusky shoreBOT Sep 5, 2021, 1:11 AM

#

Command: duckduckduckgoose

Generate a board, send the game embed, and end the game after a time limit.

Source Code

Go to GitHub

stable mountainBOT Sep 5, 2021, 2:00 AM

#

desert vessel !remind 9h gotta work on the pr and fix rapidfuzz on m1 macs and good morning fu...

It has arrived!

Here's your reminder: gotta work on the pr and fix rapidfuzz on m1 macs and good morning future me
[Jump back to when you created the reminder](#dev-contrib message)

desert vessel Sep 5, 2021, 2:02 AM

#

Thank God

#

Cool

desert vessel Sep 5, 2021, 2:03 AM

#

stable mountain

!remind 12h this, I'll be out today

stable mountainBOT Sep 5, 2021, 2:03 AM

#

Sure thing!

Your reminder will arrive on <t:1630850581:F>!

clever wraith Sep 5, 2021, 2:12 AM

#

my anagrams command uses an api to check if an word exists but is it possible if u guys would ummm download a txt file instead with a lot of words

#

hey @fervent sage, ive encountered a few problems with quackstack's seeding and component layering, any chance you could take a look at the issues?

#

krofner do be typin

#

thats me

#

hey cat

fervent sage Sep 5, 2021, 2:13 AM

#

clever wraith hey <@!297045071457681409>, ive encountered a few problems with quackstack's see...

will do

clever wraith Sep 5, 2021, 2:14 AM

#

tysm

#

sorry for pinging

fervent sage Sep 5, 2021, 2:14 AM

#

I should be project lead for quackstack KEKW

#

nah i like pings

clever wraith Sep 5, 2021, 2:14 AM

#

lol

fervent sage Sep 5, 2021, 2:14 AM

#

gives me smth to do

fervent sage Sep 5, 2021, 2:14 AM

#

fervent sage nah i like pings

*within reason

clever wraith Sep 5, 2021, 2:16 AM

#

dw i wont raid the server to ping you lmao

#

On another note, .quack is open to PRs!!

#

reviewa

#

reviews

#

oops

thorny obsidian Sep 5, 2021, 2:20 AM

#

you're going to be in for a painful merge commit

brazen charm Sep 5, 2021, 2:21 AM

#

should be easy to resolve with a new file

clever wraith Sep 5, 2021, 2:21 AM

#

uh oh

clever wraith Sep 5, 2021, 2:24 AM

#

thorny obsidian you're going to be in for a painful merge commit

why?

thorny obsidian Sep 5, 2021, 2:24 AM

#

I'm in the midst of significantly revamping lance's entire structure.

clever wraith Sep 5, 2021, 2:26 AM

#

oh

#

christ

fervent sage Sep 5, 2021, 2:26 AM

#

clever wraith hey <@!297045071457681409>, ive encountered a few problems with quackstack's see...

should be resolved by quackstack#65

dusky shoreBOT Sep 5, 2021, 2:26 AM

#

GitHub

PROpen Fix beak overlay & random seed colour bugs

clever wraith Sep 5, 2021, 2:27 AM

#

fervent sage should be resolved by quackstack#65

ill review now

short snow Sep 5, 2021, 2:28 AM

#

just 26sec late

#

😔

clever wraith Sep 5, 2021, 2:28 AM

#

one thing, you should maybe link those two issues i opened

fervent sage Sep 5, 2021, 2:28 AM

#

clever wraith one thing, you should maybe link those two issues i opened

updated

clever wraith Sep 5, 2021, 2:28 AM

#

Looks good!

clever wraith Sep 5, 2021, 2:30 AM

#

short snow just 26sec late

lol alec beat you to it

#

ty alec, im heading out for tonight

fervent sage Sep 5, 2021, 2:32 AM

#

night

clever wraith Sep 5, 2021, 2:34 AM

#

Ty

trail pilot Sep 5, 2021, 3:18 AM

#

cpython#1

#

cpython#65

#

aw, it doesn't work for anything

placid ermine Sep 5, 2021, 3:23 AM

#

python/cpython#1

dusky shoreBOT Sep 5, 2021, 3:23 AM

#

GitHub

PRMerged Support "bpo-" in Misc/NEWS

placid ermine Sep 5, 2021, 3:23 AM

#

perhaps

thorny obsidian Sep 5, 2021, 3:23 AM

#

It does you just need to specify the owner/org if it's not pydis repos

trail pilot Sep 5, 2021, 4:10 AM

#

ah alright

#

Also I feel like there should be a topic_add command to sirlancebot kind of like how otn adds a name to the possible names, so it isn't that every time that you need to make an issue to add more topics

something like where helpers and higher or moderators and higher are the only ones who can add topics

thorny obsidian Sep 5, 2021, 4:15 AM

#

I'd prefer it go through a PR review. Off-topic names are silly and only channel names. The topics aren't quite that.
Plus I'm not sure how the interface would work for specifying topics for different channels.

fallen patrol Sep 5, 2021, 4:46 AM

#

thorny obsidian I'd prefer it go through a PR review. Off-topic names are silly and only channel...

Well, with the current state of Lance it's kind of impossible

#

(no database kind of makes it impossible)

thorny obsidian Sep 5, 2021, 4:47 AM

#

We do have redis on Lance though and with our settings it's persistent enough

patent pivot Sep 5, 2021, 6:48 AM

#

fallen patrol (no database kind of makes it impossible)

Yeah, as Kat says we've got redis

#

with our configuration in the event of power loss max data loss is 1 second before outage

#

we fsync to disk every second and use append only storage so the database gets rebuilt

patent pivot Sep 5, 2021, 6:56 AM

#

trail pilot Also I feel like there should be a topic_add command to sirlancebot kind of like...

This already happens without the name for a formal proposals system, someone suggests a name to an admin and it gets added, we don't do issues for off topic names since a lot of suggestions were pretty low quality or not appropriate when we use a GitHub discussion publicly

stable mountainBOT Sep 5, 2021, 7:15 AM

#

Hey @clever wraith!

It looks like you tried to attach file type(s) that we do not allow (.html). We currently allow the following file types: .gif, .jpg, .jpeg, .mov, .mp4, .mpg, .png, .mp3, .wav, .ogg, .webm, .webp, .flac, .m4a.

Feel free to ask in #community-meta if you think this is a mistake.

green oriole Sep 5, 2021, 8:44 AM

#

clever wraith <@407110650217627658> regarding cowsay, I found a somewhat drop in replacement u...

Yep, that should work

static canyon Sep 5, 2021, 10:51 AM

#

Does anyone understand what is meant by this comment on sir-lancebot#732? https://github.com/python-discord/sir-lancebot/pull/732#discussion_r631796170
"You should be importing the Cog at runtime to prevent side effects like defining RedisCache instances too early."

dusky shoreBOT Sep 5, 2021, 10:51 AM

#

GitHub

PRDraft Music Command

brisk brook Sep 5, 2021, 11:02 AM

#

The redis cache is connected when the event loop is running (when the bot starts)

#

But the comment is wrong, it is okay to import the cog like that

vale ibex Sep 5, 2021, 11:05 AM

#

Yea, we sometimes put the import statement inside the setup function to avoid side affects, since as creating redis caches before the event loop is running

#

EG the help channels cog

#

but since I can't spot anything that would mean we need to do this for this cog

#

it could be useful to do it for future proofing, but not needed right now afaik

short snow Sep 5, 2021, 11:15 AM

#

vale ibex it could be useful to do it for future proofing, but not needed right now afaik

yeah, that's the reason I had put it there and just to keep "package" cogs to be consistent.

static canyon Sep 5, 2021, 11:20 AM

#

vale ibex Yea, we sometimes put the import statement inside the setup function to avoid si...

So instead of```py
from ... import Cog

def setup(...):
bot.add_cog(Cog(bot))doingpy
def setup(...):
from ... import Cog
bot.add_cog(Cog(bot))```?

#

Also for adding a requirement to sir-lancebot do I just put it in the Pipfile? I want to add aiohttp -- getting warnings from Pycharm even though it's part of discord.py

vale ibex Sep 5, 2021, 11:24 AM

#

static canyon So instead of```py from ... import Cog def setup(...): bot.add_cog(Cog(bot)...

yea

vale ibex Sep 5, 2021, 11:24 AM

#

static canyon Also for adding a requirement to sir-lancebot do I just put it in the `Pipfile`?...

we already have aiohttp, as you say it's part of d.py

#

might be worth double checking what venv pycharm is using

#

maybe do another poetry install

#

but for reference, if you want to add a new dep, then you can add it to the pyproject.toml file, and then poetry lock

static canyon Sep 5, 2021, 11:27 AM

#

Thoughts on hanging indent in docstring to indicate it's part of the previous line?```py
"""
API method data.

An API method is immutable (frozen) by design, to avoid editing constant values.  However,
  the time of when a request was made is used with caching.  A mutable protected
  attribute can update request info while the other attributes remain immutable.
"""

vale ibex Sep 5, 2021, 11:27 AM

#

I don't like it.

#

I'd rather it just read like a normal paragraph

static canyon Sep 5, 2021, 11:27 AM

#

Yeah, okay

static canyon Sep 5, 2021, 11:27 AM

#

vale ibex but for reference, if you want to add a new dep, then you can add it to the pypr...

Apparently the fork I'm using doesn't have the pyproject.toml lol

vale ibex Sep 5, 2021, 11:27 AM

#

The issue might be that sir-lancebot#732 is very out of date compared to main

dusky shoreBOT Sep 5, 2021, 11:27 AM

#

GitHub

PRDraft Music Command

vale ibex Sep 5, 2021, 11:28 AM

#

you should try and rebase it to origin/main

#

Ah, it's on a fork

#

You'll need to get the fork owner to fetch changes from upstream

#

or you can push this branch to the main repo

static canyon Sep 5, 2021, 11:29 AM

#

vale ibex You'll need to get the fork owner to fetch changes from upstream

I can do that myself I think

vale ibex Sep 5, 2021, 11:30 AM

#

Ah cool, what is output by git remote -v

static canyon Sep 5, 2021, 11:30 AM

#

vale ibex Sep 5, 2021, 11:30 AM

#

ah yea, that'll do it

#

rather than doing it from command line

static canyon Sep 5, 2021, 11:30 AM

#

I mean from commandline may be better idk

vale ibex Sep 5, 2021, 11:31 AM

#

nah, that'll be fine

static canyon Sep 5, 2021, 11:31 AM

#

Okay

vale ibex Sep 5, 2021, 11:31 AM

#

once you've done that, locally you'll need to check out main branch, and do a git pull

#

then checkout your branch and do git rebase main

static canyon Sep 5, 2021, 11:31 AM

#

👍

#

Lemme do that rq

vale ibex Sep 5, 2021, 11:31 AM

#

the rebase will likely raise conflicts due to the changes in the branch

static canyon Sep 5, 2021, 11:33 AM

#

C:\Users\tizzy\magicandcode-sir-lancebot>git rebase main
error: could not apply 32c85810... Add Last.fm credentials
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 32c85810... Add Last.fm credentials
Auto-merging bot/constants.py
CONFLICT (modify/delete): Pipfile.lock deleted in HEAD and modified in 32c85810... Add Last.fm credentials. Version 32c85810... Add Last.fm credentials of Pipfile.lock left in tree.
CONFLICT (modify/delete): Pipfile deleted in HEAD and modified in 32c85810... Add Last.fm credentials. Version 32c85810... Add Last.fm credentials of Pipfile left in tree.

vale ibex Sep 5, 2021, 11:33 AM

#

you should see in pycharm now there are some files showing as having conflicts

static canyon Sep 5, 2021, 11:34 AM

#

It's not showing what those conflicts are though

#

Pipfile and Pipfile.lock show as having conflicts

vale ibex Sep 5, 2021, 11:34 AM

#

the conflicts are the pipfile and pip lock

#

so yea, just delete those entriely

#

since we don't use them anymore

#

then stage those deletes and run git rebase --continue

static canyon Sep 5, 2021, 11:38 AM

#

How do I stage the deletes?

vale ibex Sep 5, 2021, 11:38 AM

#

git add <filepath>

static canyon Sep 5, 2021, 11:38 AM

#

Tried doing git add Pipfile but it says file not found (because I deleted)

vale ibex Sep 5, 2021, 11:39 AM

#

try git rm Pipfile

static canyon Sep 5, 2021, 11:39 AM

#

C:\Users\tizzy\magicandcode-sir-lancebot>git rm Pipfile
fatal: pathspec 'Pipfile' did not match any files```

#

Or rm then delete maybe?

vale ibex Sep 5, 2021, 11:40 AM

#

git rm will delete

#

do yea, maybe restore the files and then do git rm

#

I usually do this part via the vscode gui lol

static canyon Sep 5, 2021, 11:42 AM

#

error: could not apply 339e834e... WIP: Implement async music toplist command
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 339e834e... WIP: Implement async music toplist command
CONFLICT (modify/delete): Pipfile.lock deleted in HEAD and modified in 339e834e... WIP: Implement async music toplist command. Version 339e834e... WIP: Implement async music toplist comma
nd of Pipfile.lock left in tree.
CONFLICT (modify/delete): Pipfile deleted in HEAD and modified in 339e834e... WIP: Implement async music toplist command. Version 339e834e... WIP: Implement async music toplist command of
 Pipfile left in tree.

#

Guess I can just do "Accept Theirs"

vale ibex Sep 5, 2021, 11:42 AM

#

yea, that'll work

static canyon Sep 5, 2021, 11:43 AM

#

Successfully rebased and updated refs/heads/feature/music-cog.

#

Guess it worked

vale ibex Sep 5, 2021, 11:43 AM

#

nice

static canyon Sep 5, 2021, 11:43 AM

#

ty

#

now poetry install works 👍

#

It's safe to use list[x] instead of typing.List[x] etc. btw right? @vale ibex

vale ibex Sep 5, 2021, 11:44 AM

#

yup

static canyon Sep 5, 2021, 11:44 AM

#

👍

#

from bot.utils.pagination import ImagePaginator
from . import api, utils```should the `.` import have a blankline before it?

cold island Sep 5, 2021, 11:47 AM

#

hmmm

#

I don't think we do relative imports anywhere

vale ibex Sep 5, 2021, 11:47 AM

#

nope

#

usually we go for from bot import api, utils

cold island Sep 5, 2021, 11:47 AM

#

Can you switch to the full path?

vale ibex Sep 5, 2021, 11:47 AM

#

oh wait, yea will need the full path

static canyon Sep 5, 2021, 11:49 AM

#

.api isn't bot.api here

#

It's exts.evergreen.music.app.api in sir-lancebot

cold island Sep 5, 2021, 11:49 AM

#

yeah, whatever path it is

static canyon Sep 5, 2021, 11:50 AM

#

vale ibex usually we go for `from bot import api, utils`

Can't do this though

cold island Sep 5, 2021, 11:50 AM

#

I don't follow

cold island Sep 5, 2021, 11:50 AM

#

static canyon It's `exts.evergreen.music.app.api` in sir-lancebot

If this is the path, then import from here

static canyon Sep 5, 2021, 11:50 AM

#

Instead of from . import api, utils do from bot.exts.evergreen.music.app import api, utils?

cold island Sep 5, 2021, 11:51 AM

#

yeah

static canyon Sep 5, 2021, 11:51 AM

#

Hmm

#

Why though?

#

What's the benefit?

brisk brook Sep 5, 2021, 11:52 AM

#

Consistency

cold island Sep 5, 2021, 11:52 AM

#

just more uniform with how we write code in the repo

static canyon Sep 5, 2021, 11:52 AM

#

Fair enough

brisk brook Sep 5, 2021, 11:52 AM

#

But other than that I agree, I use relative imports everywhere I can. It helps type checkers and easier to follow generally

static canyon Sep 5, 2021, 11:54 AM

#

Is this import order correct? (all import before doing any from)py import asyncio import logging import time from dataclasses import dataclass, field from typing import Any, Optional from urllib.parse import urlencode

brisk brook Sep 5, 2021, 11:54 AM

#

Yes

static canyon Sep 5, 2021, 11:54 AM

#

👍

tough imp Sep 5, 2021, 11:54 AM

#

you can configure pycharm to auto sort

#

or rather just figure out the key binding

#

the linter is configured for pycharm import sorting

static canyon Sep 5, 2021, 11:55 AM

#

Yeah, I think I have just not done for this fork

#

from discord.ext.commands import Cog, Context, group
from discord.ext.commands.errors import BadArgument
```should I shorten this to```py
from discord.ext.commands import BadArgument, Cog, Context, group
```?

brisk brook Sep 5, 2021, 11:57 AM

#

Yes those are the same I believe

static canyon Sep 5, 2021, 11:59 AM

#

Yeah, they are

#

Just wanted to make sure there wasn't a reason to keep the .errors

static canyon Sep 5, 2021, 12:21 PM

#

Ah... It's trying to push all the commits from rebasing main. Is that okay? @vale ibex

brazen charm Sep 5, 2021, 12:23 PM

#

Yes, it needs to push the rebased commits of they don't exist on the branch you're pushing to

#

If you didn't change any of the commits from main it's fine

static canyon Sep 5, 2021, 12:24 PM

#

👍

#

🤔

vale ibex Sep 5, 2021, 12:27 PM

#

You'll need to git push --force

#

since you've altered history with the rebase

static canyon Sep 5, 2021, 12:27 PM

#

Right

static canyon Sep 5, 2021, 1:02 PM

#

Can I please get some reviews on bot#1798, bot#1804 and bot#1806? All three are ready to be merged, just need the reviews 👍

dusky shoreBOT Sep 5, 2021, 1:02 PM

#

GitHub

PROpen Apply infractions before DMing
PROpen Add support for !infraction last
PROpen Prevent role hierarchy issues with infractions

austere hornet Sep 5, 2021, 1:48 PM

#

Could some also review sir-lancebot#843? It looks like 3 people have already been assigned, just haven't gotten to doing the review yet, which is fine. Here is your reminder ig lol. Thanks so much!

dusky shoreBOT Sep 5, 2021, 1:48 PM

#

GitHub

PROpen Hangman

short snow Sep 5, 2021, 1:49 PM

#

i see you have the images in resources but you are using links instead?

#

Basically you aren't using the images, but I would not like to use links here and images stored in resources rather

#

Also did you have a look at the pythondiscord style guide?

#

Also am not sure about top 1000 words, but maybe we can use the dictionary api to get some words of the day or something?

trail pilot Sep 5, 2021, 2:00 PM

#

patent pivot This already happens without the name for a formal proposals system, someone sug...

Ah alright

trail pilot Sep 5, 2021, 2:00 PM

#

short snow i see you have the images in resources but you are using links instead?

Ah, let me delete those

trail pilot Sep 5, 2021, 2:01 PM

#

short snow Also am not sure about top 1000 words, but maybe we can use the dictionary api t...

Most dictionary APIs require an API key

stable mountainBOT Sep 5, 2021, 2:03 PM

#

desert vessel !remind 12h this, I'll be out today

It has arrived!

Here's your reminder: this, I'll be out today
[Jump back to when you created the reminder](#dev-contrib message)

desert vessel Sep 5, 2021, 2:03 PM

#

stable mountain

Thanks for this, im starting now 😂

stable mountainBOT Sep 5, 2021, 2:04 PM

#

:incoming_envelope: :ok_hand: applied mute to @novel yacht until <t:1630851239:f> (9 minutes and 58 seconds) (reason: duplicates rule: sent 4 duplicated messages in 10s).

desert vessel Sep 5, 2021, 2:04 PM

#

@tranquil topaz

#

oops, sorry

#

i wanted to report spam

#

forgot about the auto mute

elder belfry Sep 5, 2021, 2:04 PM

#

While running sir-lancebot via docker-compose I'm getting this recurring error, How can I resolve it? Thanks in advance!!

...
sir-lancebot    | 09/05/21 14:00:30 - bot.bot INFO: Cog loaded: CoinFlip
sir-lancebot    | Traceback (most recent call last):
sir-lancebot    |   File "/usr/local/lib/python3.9/site-packages/discord/ext/commands/bot.py", line 660, in _load_from_module_spec
sir-lancebot    |     spec.loader.exec_module(lib)  # type: ignore
sir-lancebot    |   File "<frozen importlib._bootstrap_external>", line 850, in exec_module
sir-lancebot    |   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
sir-lancebot    |   File "/bot/bot/exts/evergreen/color.py", line 5, in <module>
sir-lancebot    |     import pillow
sir-lancebot    | ModuleNotFoundError: No module named 'pillow'
sir-lancebot    | 
sir-lancebot    | The above exception was the direct cause of the following exception:
sir-lancebot    | 
sir-lancebot    | Traceback (most recent call last):
sir-lancebot    |   File "/usr/local/lib/python3.9/runpy.py", line 197, in _run_module_as_main
sir-lancebot    |     return _run_code(code, main_globals, None,
sir-lancebot    |   File "/usr/local/lib/python3.9/runpy.py", line 87, in _run_code
sir-lancebot    |     exec(code, run_globals)
sir-lancebot    |   File "/bot/bot/__main__.py", line 31, in <module>
sir-lancebot    |     bot.load_extension(ext)
sir-lancebot    |   File "/usr/local/lib/python3.9/site-packages/discord/ext/commands/bot.py", line 732, in load_extension
sir-lancebot    |     self._load_from_module_spec(spec, name)
sir-lancebot    |   File "/usr/local/lib/python3.9/site-packages/discord/ext/commands/bot.py", line 663, in _load_from_module_spec
sir-lancebot    |     raise errors.ExtensionFailed(key, e) from e
sir-lancebot    | discord.ext.commands.errors.ExtensionFailed: Extension 'bot.exts.evergreen.color' raised an error: ModuleNotFoundError: No module named 'pillow'
sir-lancebot exited with code 1

desert vessel Sep 5, 2021, 2:05 PM

#

elder belfry While running `sir-lancebot` via `docker-compose` I'm getting this recurring err...

did you run docker-compose up --build

elder belfry Sep 5, 2021, 2:05 PM

#

desert vessel did you run `docker-compose up --build`

no just docker-compose up as in the guide..

desert vessel Sep 5, 2021, 2:05 PM

#

mind sharing your dockerfile ?

#

its not able to install pillow 🤔

elder belfry Sep 5, 2021, 2:06 PM

#

desert vessel mind sharing your dockerfile ?

FROM python:3.9-slim

# Set pip to have cleaner logs and no saved cache
ENV PIP_NO_CACHE_DIR=false \
    POETRY_VIRTUALENVS_CREATE=false

# Install Poetry
RUN pip install --upgrade poetry

WORKDIR /bot

# Copy dependencies and lockfile
COPY pyproject.toml poetry.lock /bot/

# Install dependencies and lockfile, excluding development
# dependencies,
RUN poetry install --no-dev --no-interaction --no-ansi

# Set SHA build argument
ARG git_sha="development"
ENV GIT_SHA=$git_sha

# Copy the rest of the project code
COPY . .

# Start the bot
CMD ["python", "-m", "bot"]

# Define docker persistent volumes
VOLUME /bot/bot/log /bot/data

I have just cloned the project..

desert vessel Sep 5, 2021, 2:06 PM

#

oh

elder belfry Sep 5, 2021, 2:08 PM

#

desert vessel did you run `docker-compose up --build`

Even this one is resulting in the same error...

#

Should I have to manually go into the container and install it?? pithink

desert vessel Sep 5, 2021, 2:08 PM

#

so i have a sm0l fix

#

find a file called pyproject.toml

#

search the file for pillow

#

lemme know if it is there

elder belfry Sep 5, 2021, 2:10 PM

#

desert vessel lemme know if it is there

yep it's there

...
arrow = "~=1.1.0"
pillow = "~=8.1"
sentry-sdk = "~=0.19"
...

static canyon Sep 5, 2021, 2:10 PM

#

Have you run poetry install? @elder belfry

desert vessel Sep 5, 2021, 2:10 PM

#

i dont think thats needed while running with docker

#

but yeah

#

do that

static canyon Sep 5, 2021, 2:11 PM

#

It shouldn't be, but worth trying 🤷

desert vessel Sep 5, 2021, 2:11 PM

#

static canyon It shouldn't be, but worth trying 🤷

true :D

elder belfry Sep 5, 2021, 2:11 PM

#

static canyon Have you run `poetry install`? <@!785193141971451974>

Umm nope, I will do it now..

desert vessel Sep 5, 2021, 2:12 PM

#

this is a silly thing but make sure you are in sir-lancebot directory while running docker-compose up

elder belfry Sep 5, 2021, 2:12 PM

#

desert vessel this is a silly thing but make sure you are in `sir-lancebot` directory while ru...

yes I'm..

desert vessel Sep 5, 2021, 2:13 PM

#

alright

#

wookie is typing, :P

#

he'll probs know whats wrong

elder belfry Sep 5, 2021, 2:13 PM

#

static canyon Have you run `poetry install`? <@!785193141971451974>

And it didn't work😅 ...

desert vessel Sep 5, 2021, 2:13 PM

#

yiiiikes

#

i have a dirty fix

timid sentinel Sep 5, 2021, 2:13 PM

#

Try without docker maybe? poetry run task start

static canyon Sep 5, 2021, 2:13 PM

#

elder belfry And it didn't work😅 ...

Wdym by "didn't work"?

elder belfry Sep 5, 2021, 2:14 PM

#

static canyon Wdym by "didn't work"?

I mean, i'm getting the module not found error..

desert vessel Sep 5, 2021, 2:14 PM

#

FROM --platform=linux/amd64 python:3.9-slim
# Set pip to have cleaner logs and no saved cache
ENV PIP_NO_CACHE_DIR=false \
    POETRY_VIRTUALENVS_CREATE=false

# Install Poetry
RUN pip install --upgrade poetry

WORKDIR /bot

# Copy dependencies and lockfile
COPY pyproject.toml poetry.lock /bot/

# Install dependencies and lockfile, excluding development
# dependencies,
RUN poetry install --no-dev --no-interaction --no-ansi
RUN pip install pillow
# Set SHA build argument
ARG git_sha="development"
ENV GIT_SHA=$git_sha

# Copy the rest of the project code
COPY . .

# Start the bot
CMD ["python", "-m", "bot"]

# Define docker persistent volumes
VOLUME /bot/bot/log /bot/data

desert vessel Sep 5, 2021, 2:14 PM

#

desert vessel ```docker FROM --platform=linux/amd64 python:3.9-slim # Set pip to have cleaner ...

Can you copy this

#

to your docker file

static canyon Sep 5, 2021, 2:14 PM

#

elder belfry I mean, i'm getting the module not found error..

Did the poetry install work though?

desert vessel Sep 5, 2021, 2:14 PM

#

and run it again?

elder belfry Sep 5, 2021, 2:14 PM

#

static canyon Did the `poetry install` work though?

yeah it worked

desert vessel Sep 5, 2021, 2:15 PM

#

pip install pillow

#

run this

desert vessel Sep 5, 2021, 2:15 PM

#

desert vessel ```docker FROM --platform=linux/amd64 python:3.9-slim # Set pip to have cleaner ...

try this tho, its a very straightforward fix

#

or so i think

static canyon Sep 5, 2021, 2:15 PM

#

desert vessel `pip install pillow`

Pillow

brazen charm Sep 5, 2021, 2:15 PM

#

Do you have any changes in any files? The container on main is fine and doing hacks won't help if the issue is elsewhere (and can't be pushed anyway)

desert vessel Sep 5, 2021, 2:15 PM

#

static canyon * `Pillow`

its pillow?

desert vessel Sep 5, 2021, 2:15 PM

#

brazen charm Do you have any changes in any files? The container on main is fine and doing ha...

yyeah

#

my bad

static canyon Sep 5, 2021, 2:16 PM

#

desert vessel its `pillow`?

No it's not...

brazen charm Sep 5, 2021, 2:16 PM

#

pip doesn't care about case

desert vessel Sep 5, 2021, 2:16 PM

#

y- yeah

static canyon Sep 5, 2021, 2:16 PM

#

oh, fair enough

desert vessel Sep 5, 2021, 2:16 PM

#

so the color file is raising this error, have you modified this file by chance ?

elder belfry Sep 5, 2021, 2:16 PM

#

brazen charm Do you have any changes in any files? The container on main is fine and doing ha...

yeah I'm working on something which is not in the main

desert vessel Sep 5, 2021, 2:17 PM

#

elder belfry yeah I'm working on something which is not in the main

oh hmmm

brazen charm Sep 5, 2021, 2:17 PM

#

Do you have that pushed somewhere?

desert vessel Sep 5, 2021, 2:17 PM

#

^ for reference ?

short snow Sep 5, 2021, 2:17 PM

#

trail pilot Ah, let me delete those

Umm don't delete those, but use them instead of the links IMO

trail pilot Sep 5, 2021, 2:18 PM

#

short snow Umm don't delete those, but use them instead of the links IMO

That wouldn’t work because local files means I have to use the send command every time

#

I tried it earlier but it looks really ugly

elder belfry Sep 5, 2021, 2:18 PM

#

brazen charm Do you have that pushed somewhere?

yeah,here https://github.com/brad90four/sir-lancebot/tree/color-677

trail pilot Sep 5, 2021, 2:18 PM

#

Editing is much smoother than having to delete and post the file everytime

desert vessel Sep 5, 2021, 2:18 PM

#

elder belfry yeah,here <https://github.com/brad90four/sir-lancebot/tree/color-677>

Cool, lemme see whats up with that

#

oh wait

#

its PIL

#

not pillow i believe

#

import PIL

#

i have an m1 mac, so i cant test locally cuz of rapidfuzz :(

elder belfry Sep 5, 2021, 2:23 PM

#

desert vessel `import PIL`

Ahh yeah, i totally forget it

desert vessel Sep 5, 2021, 2:23 PM

#

haha, no problem :D

#

is this vscode or the code?

elder belfry Sep 5, 2021, 2:23 PM

#

desert vessel haha, no problem :D

tysm 🎉

desert vessel Sep 5, 2021, 2:23 PM

#

of course! i love helping :D

#

@elder belfry you might wanna fix this

#

i have to go in 5 mins :(

#

ping me for anything

elder belfry Sep 5, 2021, 2:24 PM

#

desert vessel <@!785193141971451974> you might wanna fix this

yes I will look into it

desert vessel Sep 5, 2021, 2:24 PM

#

i can stay up after i come back and help you fix these errors

#

if you're not through them

#

i'll be on phone, so ping me if you need me :D

elder belfry Sep 5, 2021, 2:25 PM

#

desert vessel i'll be on phone, so ping me if you need me :D

yeah I will lemon_happy

desert vessel Sep 5, 2021, 2:32 PM

#

@elder belfry can you tell me how to use the command

#

i may have fixed the whole thing

#

.colour #000000

#

that isnt working

elder belfry Sep 5, 2021, 2:33 PM

#

desert vessel <@!785193141971451974> can you tell me how to use the command

ahh actually I'm not the one who has written that file, so I don't know yet..

desert vessel Sep 5, 2021, 2:33 PM

#

in my server

desert vessel Sep 5, 2021, 2:33 PM

#

elder belfry ahh actually I'm not the one who has written that file, so I don't know yet..

oh right

stable mountainBOT Sep 5, 2021, 2:34 PM

#

Hey @desert vessel!

It looks like you tried to attach a Python file - please use a code-pasting service such as https://paste.pythondiscord.com

elder belfry Sep 5, 2021, 2:34 PM

#

desert vessel that isnt working

yeah I think it's not finished yet, it's just a layout..

#

And moving that file to somewhere else has just fixed the issue..

desert vessel Sep 5, 2021, 2:34 PM

#

@elder belfry screw it, here is the fixed version : https://paste.pythondiscord.com/ixasirikat.py

desert vessel Sep 5, 2021, 2:34 PM

#

elder belfry And moving that file to somewhere else has just fixed the issue..

awesome!

elder belfry Sep 5, 2021, 2:35 PM

#

desert vessel <@!785193141971451974> screw it, here is the fixed version : https://paste.pytho...

thank you so much 🎉 🎉 I will look into it

desert vessel Sep 5, 2021, 2:35 PM

#

elder belfry thank you so much 🎉 🎉 I will look into it

<3

#

remember to change the aias

#

alias*

#

i kept it as bruv

#

cuz nothing else came to my mind

#

alright, cya

#

i gtg

clever wraith Sep 5, 2021, 2:53 PM

#

green oriole Yep, that should work

Tysm

clever wraith Sep 5, 2021, 3:18 PM

#

Hey @timid sentinel , thanks for the review. I'll get to it as soon as possible. Unfortunately I'm offline so that might not be until tomorrow

timid sentinel Sep 5, 2021, 3:21 PM

#

clever wraith Hey <@493839819168808962> , thanks for the review. I'll get to it as soon as pos...

No rush at all, the next day is still a pretty fast response to a review 😅

brazen charm Sep 5, 2021, 3:22 PM

#

There's no rush with PRs and reviews for non critical code, larger prs can sit around for a few weeks

clever wraith Sep 5, 2021, 3:22 PM

#

Okay good, ty 😄

thorny obsidian Sep 5, 2021, 3:24 PM

#

Soon ™️ I'm going to push and open a PR for the lance restructure

clever wraith Sep 5, 2021, 3:53 PM

#

@timid sentinel ive decided to manually append the seed to the request url as if i dont the command errors if a seed isn't given, and i dont want to have to set a specific seed

#

tfw you forget to run poetry run pre-commit install

timid sentinel Sep 5, 2021, 4:10 PM

#

clever wraith <@!493839819168808962> ive decided to manually append the seed to the request ur...

You can write it to only pass in the seed as a param if you want to set it, something like this

clever wraith Sep 5, 2021, 4:11 PM

#

wow im stupid

timid sentinel Sep 5, 2021, 4:18 PM

#

Not stupid lemon_pensive

thorny obsidian Sep 5, 2021, 4:20 PM

#

elmoburn The PR has been created

short snow Sep 5, 2021, 4:30 PM

#

vale ibex Sep 5, 2021, 4:59 PM

#

actually, I've spotted a few more places @thorny obsidian, give me a few minutes and I'll update the comment

#

alr, that should be it

thorny obsidian Sep 5, 2021, 5:23 PM

#

@vale ibex fixed! thanks for catching that

clever wraith Sep 5, 2021, 5:27 PM

#

thorny obsidian <a:elmoburn:737726333798449172> The PR has been created

uh oh fiery elmo

#

huh

brazen charm Sep 5, 2021, 5:31 PM

#

clever wraith Sep 5, 2021, 5:31 PM

#

oh

#

quackstack#65

dusky shoreBOT Sep 5, 2021, 5:32 PM

#

GitHub

PROpen Fix beak overlay & random seed colour bugs

clever wraith Sep 5, 2021, 5:32 PM

#

would be nice to have merged with .quack

patent pivot Sep 5, 2021, 5:40 PM

#

@clever wraith we're not doing CLI on quack-stack

clever wraith Sep 5, 2021, 5:41 PM

#

alright

patent pivot Sep 5, 2021, 5:41 PM

#

not at the current moment anyway

#

we'll get a nice API together, integrate lancebot and then anyone can use the public API with a CLI and w/e

#

@fervent sage where did you land for S3?

clever wraith Sep 5, 2021, 5:41 PM

#

eh ill make an unnoficial one then for fun

patent pivot Sep 5, 2021, 5:42 PM

#

👍

#

expect things to change in coming weeks

fervent sage Sep 5, 2021, 5:47 PM

#

clever wraith eh ill make an unnoficial one then for fun

i kinda made half of one yesterday KEKW

fervent sage Sep 5, 2021, 5:47 PM

#

patent pivot <@!297045071457681409> where did you land for S3?

Haven't had much of chance to implement it, been mostly in london with you or asleep KEKW

patent pivot Sep 5, 2021, 5:49 PM

#

lol this is true

thorny obsidian Sep 5, 2021, 5:59 PM

#

joeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee, can you add the new non-staff contribs to the review policy thing pls?

vale ibex Sep 5, 2021, 6:01 PM

#

i already did it 😄

thorny obsidian Sep 5, 2021, 6:03 PM

#

vale ibex i already did it 😄

hmmmm why is D0rs4n's approval not a green checkmark then

vale ibex Sep 5, 2021, 6:03 PM

#

which pr?

thorny obsidian Sep 5, 2021, 6:04 PM

#

sir-lancebot#851

dusky shoreBOT Sep 5, 2021, 6:04 PM

#

GitHub

PROpen Restructure Sir Lancebot

molten perch Sep 5, 2021, 6:04 PM

#

The policy-bot took my review in account.

brazen charm Sep 5, 2021, 6:04 PM

#

wouldn't they need to be a member for that

thorny obsidian Sep 5, 2021, 6:04 PM

#

it's counting Chris's for core dev & staff, but not yours

vale ibex Sep 5, 2021, 6:04 PM

#

ugh, policy bot is case sensitive

#

i'll pr a fix

thorny obsidian Sep 5, 2021, 6:05 PM

#

brazen charm wouldn't they need to be a member for that

we have a way to count non-member's review with policy bot

brazen charm Sep 5, 2021, 6:05 PM

#

yeah I'm just thinking of the checkmark on the GUI

molten perch Sep 5, 2021, 6:05 PM

#

I thought 1/2 approvals required meant that I was okay.

vale ibex Sep 5, 2021, 6:06 PM

#

.github#5

dusky shoreBOT Sep 5, 2021, 6:06 PM

#

GitHub

PROpen fix capitialisation of a contrib in policy bot

vale ibex Sep 5, 2021, 6:06 PM

#

molten perch I thought `1/2 approvals required` meant that I was okay.

1 is from me, since you are a contrib, you'd count as the second

#

but policy bot is case sensitive

molten perch Sep 5, 2021, 6:07 PM

#

Oh, I thought you only count as core-dev, and not the both of them.

vale ibex Sep 5, 2021, 6:07 PM

#

yea, it's two staff/contrib requirements

#

and one of them needs to be a core dev

molten perch Sep 5, 2021, 6:07 PM

#

Oh, okay. I see 😄

vocal wolf Sep 5, 2021, 6:18 PM

#

dusky shore

uh oh

#

it's happening, isn't it

thorny obsidian Sep 5, 2021, 6:21 PM

#

elmoburn

vocal wolf Sep 5, 2021, 6:27 PM

#

awcPythonk

thorny obsidian Sep 5, 2021, 6:30 PM

#

hey ...
hey @vocal wolf
... you should uhhhhhhhhh
review that lance PR :3c

vocal wolf Sep 5, 2021, 6:30 PM

#

200

#

files

thorny obsidian Sep 5, 2021, 6:30 PM

#

:3c

vocal wolf Sep 5, 2021, 6:30 PM

#

now that's a lot of damage

#

how tf do we have so many files in sir lance?

#

I'm guessing a lot are resource files

thorny obsidian Sep 5, 2021, 6:31 PM

#

snakes. resources. so many games.

#

SO. MANY. GAMES.

#

did you know we have a gamerec command?

#

.gamrec

vocal wolf Sep 5, 2021, 6:31 PM

#

so what you're saying is AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAHHHHHHHHHHH

thorny obsidian Sep 5, 2021, 6:31 PM

#

.gamerec

dusky shoreBOT Sep 5, 2021, 6:31 PM

#

Recommendation: Doom II https://rawg.io/games/doom-ii

Doom 2 was one of the first FPS games that I truly enjoyed. It offered awesome weapons, terrifying demons to kill, and a great atmosphere to do it in.

thorny obsidian Sep 5, 2021, 6:31 PM

#

It loops through the same 4 games

vocal wolf Sep 5, 2021, 6:31 PM

#

lmao

clever wraith Sep 5, 2021, 6:34 PM

#

done a really simple, garbage quackstack cli

#

!pypi quack-cli

stable mountainBOT Sep 5, 2021, 6:34 PM

#

quack-cli v0.2.0

A CLI for the Quackstack API

clever wraith Sep 5, 2021, 6:34 PM

#

.gamerec

vocal wolf Sep 5, 2021, 6:37 PM

#

@clever wraith oi m8 what's going to happen to this PR? sir-lancebot#699

dusky shoreBOT Sep 5, 2021, 6:37 PM

#

GitHub

PROpen Cowsay

clever wraith Sep 5, 2021, 6:38 PM

#

vocal wolf <@456226577798135808> oi m8 what's going to happen to this PR? sir-lancebot#699

!pypi cowpy is our replacement

stable mountainBOT Sep 5, 2021, 6:38 PM

#

cowpy v1.1.0

A cowsay clone for python in one file.

clever wraith Sep 5, 2021, 6:38 PM

#

im gonna get on it soon

brisk brook Sep 5, 2021, 6:38 PM

#

thorny obsidian hmmmm why is D0rs4n's approval not a green checkmark then

Only people part of the organization and considered "maintainers" or "contributors" (not sure what the official term is for GitHub) will get a green checkmark

vocal wolf Sep 5, 2021, 6:38 PM

#

thanks

thorny obsidian Sep 5, 2021, 6:38 PM

#

brisk brook Only people part of the organization and considered "maintainers" or "contributo...

nah, it was just cause our review bot policy is case sensitive

#

Chris has a PR to fix it

brisk brook Sep 5, 2021, 6:39 PM

#

I am talking about this

thorny obsidian Sep 5, 2021, 6:41 PM

#

The thing that I cared about was why it wasn't counting here and turning this green:

green oriole Sep 5, 2021, 6:43 PM

#

Because you aren't in the org

#

But the policy bot will still count it

#

Don't worry

thorny obsidian Sep 5, 2021, 6:44 PM

#

yeaaaaah, this is the part I care about

#

what does it conflict with? I pulled it yesterday and there haven't been any merges since

vale ibex Sep 5, 2021, 6:45 PM

#

no conflict, but it will need to be updated

#

I merged a PR to the Dockerfile yesterday

#

I've done that now

thorny obsidian Sep 5, 2021, 6:46 PM

#

It's a protected branch and only authorized users can merge

#

vale ibex Sep 5, 2021, 6:46 PM

#

merge conflicts are a special term for issues that git can't resolve itself

#

Stonks_REH

thorny obsidian Sep 5, 2021, 6:47 PM

#

saddab I used to be able to merge

#

all the opens one conflict with the type annotations PR anyhow

#

this is just... like an order of magnitude worse

#

Def not with lance, I think it's still being evaluated for python

dry folio Sep 5, 2021, 6:49 PM

#

hey guys, does anyone know where's the logic for whitelist overrides on lancy? all i found so far is whitelist_override, in_whitelist_check, and whitelist_check, but i'm wondering if there's more

#

the structure is a little confusing lol, i'm trying to make .bm available for everyone everywhere

thorny obsidian Sep 5, 2021, 6:52 PM

#

heeeey @vale ibex and/or @vocal wolf it miiight be worth making a dev announcement about this since it's a substantial change for existing contribs?

clever wraith Sep 5, 2021, 6:52 PM

#

Lovely time to fix my .quack pr

vocal wolf Sep 5, 2021, 6:52 PM

#

thorny obsidian heeeey <@!126811506632294400> and/or <@!196664644113268736> it miiight be worth ...

yeah that's a good idea, I'll do it after staff meeting.

brisk brook Sep 5, 2021, 6:54 PM

#

I think I have some co-authored commits into both bots

clever wraith Sep 5, 2021, 6:55 PM

#

uhhhhhhh i just tried to pull main and no dice

vocal wolf Sep 5, 2021, 6:55 PM

#

@thorny obsidian welp I guess the restructure is done

clever wraith Sep 5, 2021, 6:55 PM

#

oh im dumb i needed to pull upstream

#

woohoo merged the restructure

#

also

#

if you have time please look at sir-lancebot#849

dusky shoreBOT Sep 5, 2021, 7:00 PM

#

GitHub

PROpen .quack

vale ibex Sep 5, 2021, 7:00 PM

#

thorny obsidian heeeey <@!126811506632294400> and/or <@!196664644113268736> it miiight be worth ...

Yass

vocal wolf Sep 5, 2021, 7:04 PM

#

@thorny obsidian do you have that list of labels that you suggested for @dusky shore's repo?

clever wraith Sep 5, 2021, 7:07 PM

#

rip didn't get pinged on the dev announcements 😔

molten perch Sep 5, 2021, 7:24 PM

#

I might've spotted something. It seems like cogs under the folder events are not loaded in.
(It worked before merging the restructure <#sir-lancebot-playground message>)

brazen charm Sep 5, 2021, 7:34 PM

#

Looks like it's missing the an init with a setup entrypoint

#

There's also a missed old import in the aoc helpers file

molten perch Sep 5, 2021, 7:36 PM

#

Yeah, spotted that as well. I was gonna fix it in my next PR there's a missing .event

#

I think I'll open an issue for that, just for the sake of consistency.

vale ibex Sep 5, 2021, 7:58 PM

#

we should directly PR that

#

I'll do it now

vale ibex Sep 5, 2021, 7:58 PM

#

molten perch Yeah, spotted that as well. I was gonna fix it in my next PR there's a missing `...

What's missing a .event?

clever wraith Sep 5, 2021, 7:58 PM

#

Lol merged that suggestion and now I get an EOF error

molten perch Sep 5, 2021, 8:00 PM

#

vale ibex What's missing a .event?

Import in the aoc helper file

fallen patrol Sep 5, 2021, 8:00 PM

#

wouldn't that, yknow, been caught just by nature of running the bot?

molten perch Sep 5, 2021, 8:00 PM

#

It should be ‘exts.event.[…]’

vale ibex Sep 5, 2021, 8:02 PM

#

Gonna abuse the fact that staff meeting is happening an push for reviews

trail pilot Sep 5, 2021, 8:02 PM

#

Yay

#

The PR I made has just been waiting for reviews but it's been two to three days since I put the PR up so I'm fine waiting since it's only been a few days

fervent sage Sep 5, 2021, 8:24 PM

#

@vale ibex a review for a review 🥺
https://github.com/python-discord/quackstack/pull/65

GitHub

Fix beak overlay & random seed colour bugs by vcokltfre · Pull Requ...

This PR fixes the following bugs:

The duck's beak appearing above the rest of its body.
The colours being inconsistent across generations, despite having the same seed.

This time the PR i...

clever wraith Sep 5, 2021, 8:26 PM

#

fervent sage <@!126811506632294400> a review for a review 🥺 https://github.com/python-disco...

I've been trying really hard to get you reviews lol

fervent sage Sep 5, 2021, 8:26 PM

#

Ty :P

clever wraith Sep 5, 2021, 8:27 PM

#

Lol it didn't count

#

The shit

#

Your review didn't trigger policy bot

#

https://github.com/python-discord/quackstack/pull/65

GitHub

Fix beak overlay & random seed colour bugs by vcokltfre · Pull Requ...

This PR fixes the following bugs:

The duck's beak appearing above the rest of its body.
The colours being inconsistent across generations, despite having the same seed.

This time the PR i...

#

Yeah

#

Idk

vale ibex Sep 5, 2021, 8:34 PM

#

We recently added django_prometheus to the site repo. This now causes the site to fail to build during local dev for bot, since it relies on metricity db to exist.
This is because the bot repo pulls site from site:latest on ghcr, so it doesn't run the init.sql file to create metricity relations

I'm thinking we copy the init file into the bot repo and add a volume to postgres via the dockercompose file.

this seems like the easiest solution, since changes to this init file are unlikely to happen. any thoughts on better solutions?

brisk brook Sep 5, 2021, 8:37 PM

#

Wait why aren't the SQL queries ran?

vale ibex Sep 5, 2021, 8:38 PM

#

brisk brook Wait why aren't the SQL queries ran?

Migrations are done by the site

#

but the init for metricity aren't in django migrations

#

https://github.com/python-discord/site/blob/main/postgres/init.sql

brisk brook Sep 5, 2021, 8:38 PM

#

vale ibex but the init for metricity aren't in django migrations

Can't we add it? I feel like that should be a migration?

vale ibex Sep 5, 2021, 8:39 PM

#

I'm not too familiar with django migrations, metricity isn't a django model

brisk brook Sep 5, 2021, 8:42 PM

#

Why does the site work if it doesn't run the metricity queries?

vale ibex Sep 5, 2021, 8:44 PM

#

we don't want it in the site image, since we want it in the postgres image

#

we could have the site do the migration, but we'd need to make sure it doesn't run in prod

green oriole Sep 5, 2021, 8:44 PM

#

@vale ibex why don't we make the site run the script itself if it starts in dev mode rather than psql, so we don't have to deal with keeping the file up to date in two repos

vale ibex Sep 5, 2021, 8:45 PM

#

we already have an if self.debug in the site manager init

#

I'll take a look at doing that

green oriole Sep 5, 2021, 8:46 PM

#

I had a bad experience with prod even vars, so if we can avoid it, uuuh, that'd be nice pithink

vocal wolf Sep 5, 2021, 8:46 PM

#

https://github.com/python-discord/sir-lancebot/pull/850 needs revivew. Smol PR.

#

I typed all those out manually.

#

no clipboard used besides file names

#

lol

#

well it had to be done

green oriole Sep 5, 2021, 8:48 PM

#

vocal wolf <https://github.com/python-discord/sir-lancebot/pull/850> needs revivew. Smol PR...

I want that to be controlled by the debug env var but I'm not logged into github Sadge

#

lol, I'm sure it can wait until tomorrow

#

Sure, if you can fix it

#

It is an internal discord bug iirc

vocal wolf Sep 5, 2021, 8:52 PM

#

~~@brisk brook Did you happen to test what happens if the moderator had no previous infractions?~~

~~Context: https://github.com/python-discord/bot/pull/1804#pullrequestreview-746602907~~

Nevermind, I forgot that I pruned all docker stuff recently so I have a clean database. We're good, it works.

#

shipit

patent pivot Sep 5, 2021, 8:52 PM

#

vale ibex We recently added django_prometheus to the site repo. This now causes the site t...

hol up why does it rely on that

#

discord problem

#

my code works, theirs doesn't

#

it works in comments, but not PR approvals

#

lol, nah, it is indeed broken

vale ibex Sep 5, 2021, 8:54 PM

#

patent pivot hol up why does it rely on that

no idea

#

I have a fix

#

    @staticmethod
    def run_metricity_init() -> None:
        """
        Initilise metricity when running in debug mode.

        This is done at run time, since other projects (Like Python bot)
        rely on the site initilising it's on db, rather than relying on
        an init.sql volume.
        """
        import psycopg2
        # The database URL has already been validated in `wait_for_postgres()`
        conn = psycopg2.connect(database_url=os.environ["DATABASE_URL"])
        conn.autocommit = True
        with conn as cursor:
            cursor.execute(open("postgres/init.sql").read())

#

lovely

patent pivot Sep 5, 2021, 8:55 PM

#

no thnk u

#

nah, don't, we really don't need that

patent pivot Sep 5, 2021, 8:55 PM

#

vale ibex ```py @staticmethod def run_metricity_init() -> None: """ ...

hmmmm, does this mean we need to update bot & site if we change that

vale ibex Sep 5, 2021, 8:56 PM

#

this is in site

patent pivot Sep 5, 2021, 8:56 PM

#

hmmmmmmm

#

ahhhhhhh

vale ibex Sep 5, 2021, 8:56 PM

#

once I commit any new images will have it

patent pivot Sep 5, 2021, 8:56 PM

#

ahhhhhhhhhhhhhhhhhhhhhhhhhhhh

#

smart

#

I like it

brisk brook Sep 5, 2021, 8:56 PM

#

vocal wolf ~~<@!344404945359077377> Did you happen to test what happens if the moderator ha...

https://github.com/python-discord/bot/blob/08dcaee81993ab8d1d9d30c6582a37ea740d0614/bot/converters.py#L564-L569

stable mountainBOT Sep 5, 2021, 8:56 PM

#

bot/converters.py lines 564 to 569

if not infractions:
    raise BadArgument(
        "Couldn't find most recent infraction; you have never given an infraction."
    )
else:
    return infractions[0]```

patent pivot Sep 5, 2021, 8:56 PM

#

good programmer with a good idea, that's what I like to see

brisk brook Sep 5, 2021, 8:56 PM

#

Raises BadArgument yeah

vale ibex Sep 5, 2021, 8:56 PM

#

I just need to update the init.sql to make sure it only runs if there isn't any data already

vocal wolf Sep 5, 2021, 8:56 PM

#

yeah, just tested it

#

very nice

timid sentinel Sep 5, 2021, 8:56 PM

#

Thanks! lemon_pleased

vale ibex Sep 5, 2021, 9:03 PM

#

👌

#

i was going to use self.prepare_server() to do this, but this check means it doesn't run when in debug mode. Does anyone with mroe django knowledge than I know if it's safe to remove this check now?
https://github.com/python-discord/site/blob/main/manage.py#L159-L161

stable mountainBOT Sep 5, 2021, 9:07 PM

#

manage.py lines 159 to 161

# Prevent preparing twice when in dev mode due to reloader
if not self.debug or in_reloader:
    self.prepare_server()```

vale ibex Sep 5, 2021, 9:07 PM

#

I can understand not running it when reloading, but nto sure about the debug part

green oriole Sep 5, 2021, 9:08 PM

#

patent pivot good programmer with a good idea, that's what I like to see

Technically two devs. Or I am Chris alt. Or Chris talked about it and I am blind.

patent pivot Sep 5, 2021, 9:08 PM

#

in that ccase two excellent minds

#

but ultimatley

#

both are part of the devops hive mind

#

heard of docker swarm? yeah that's my devops team.

#

docker swarm do-my-work

green oriole Sep 5, 2021, 9:09 PM

#

vale ibex I can understand not running it when reloading, but nto sure about the debug par...

Eh we wont be reloading outside of dev so this p much redundant

vale ibex Sep 5, 2021, 9:09 PM

#

yea I was gonna change this to just check for in_reloader

#

Scale

green oriole Sep 5, 2021, 9:09 PM

#

Haha the devops swarm

vale ibex Sep 5, 2021, 9:09 PM

#

or is it joe

#

shrugR

vale ibex Sep 5, 2021, 9:10 PM

#

vale ibex yea I was gonna change this to just check for in_reloader

I'm gonna do this and people can complain in PR if they want

green oriole Sep 5, 2021, 9:11 PM

#

It was both back in March

#

Huh, we didn't transfer crispy to lemon, didn't know that

patent pivot Sep 5, 2021, 9:12 PM

#

scale

#

my position in python discord is chief thought leader

#

i'm like julian assange but ethical

#

technically the truth

#

smart config

green oriole Sep 5, 2021, 9:14 PM

#

patent pivot i'm like julian assange but ethical

With the number of pods you murdered you aren't very ethical sir

patent pivot Sep 5, 2021, 9:14 PM

#

this is true

cold island Sep 5, 2021, 9:14 PM

#

patent pivot smart config

it's a config that is smart

green oriole Sep 5, 2021, 9:14 PM

#

Look at the PR

patent pivot Sep 5, 2021, 9:14 PM

#

an idea to try simplify config on all our bots — I think we had some level of plans with bootrapping certain things but I forget

green oriole Sep 5, 2021, 9:14 PM

#

The PR

cold island Sep 5, 2021, 9:14 PM

#

We like smart things ablobshrug

green oriole Sep 5, 2021, 9:15 PM

#

We never got any project lead for that one lol

#

I may pick it up later on, yeah

#

Mark contributed as much as I did tbh

#

If not more

patent pivot Sep 5, 2021, 9:17 PM

#

pro i think

#

the $20/mo one

#

uhhhhh

#

i mean to us, nothing

green oriole Sep 5, 2021, 9:18 PM

#

The infra cost nothing lol

patent pivot Sep 5, 2021, 9:18 PM

#

yea

#

if we paid, cloudflare is $20/mo, Linode would be around $2000/yr, domains are around $36/yr (all 4 combined, we recently transferred to Cloudflare & enabled DNSSEC)

#

uhhhh

#

Sentry would be a few hundred

#

DNSSEC has been enabled since January, just not on a registrar that had the records, lol

#

Notion would be a few hundred too

green oriole Sep 5, 2021, 9:20 PM

#

Github would be pricy if we had an actual team plan, not the open source one

#

Actually don't we have team pro since we have a special status or something

patent pivot Sep 5, 2021, 9:21 PM

#

ah yeah that too

#

sponsorships

#

we have a lot of good relations with these companies

green oriole Sep 5, 2021, 9:21 PM

#

Plus we have Joe

#

Who not only has the number of bojo but also biden's

#

The linode support are good people

patent pivot Sep 5, 2021, 9:23 PM

#

Linode are great — always lovely to chat to about sponsorships & really helpful with any problems too

#

I think I put one of the support interactions on a public postmortem a while ago

green oriole Sep 5, 2021, 9:24 PM

#

On the disk going zoom, yeah

#

That was a fun outage

#

How many days without an incident are we at

patent pivot Sep 5, 2021, 9:24 PM

#

#

uhhhhh

#

july 11th was the major one

green oriole Sep 5, 2021, 9:24 PM

#

What happened again?

patent pivot Sep 5, 2021, 9:24 PM

#

i don't think we've had anything quite as significant ssince

#

django connection surge

green oriole Sep 5, 2021, 9:24 PM

#

Was that the disk one

patent pivot Sep 5, 2021, 9:25 PM

#

yeah

#

it knocked a node into unresponsive

#

but didn't let the volumes unmount healthily

green oriole Sep 5, 2021, 9:25 PM

#

Right

patent pivot Sep 5, 2021, 9:25 PM

#

so I had to do some debugging with linode API and even mounting to a temporary VM and doing fsck.ext4

#

lol

green oriole Sep 5, 2021, 9:27 PM

#

https://linodestore.com/products/217710

#

Kind of works?

#

I am still waiting on my cloudflare swag

#

I hope it will include socks

#

What did you get it for?

patent pivot Sep 5, 2021, 9:29 PM

#

do not understand lol

green oriole Sep 5, 2021, 9:30 PM

#

They have a ticket system, emails, phone numbers..

#

Hah, nice

vale ibex Sep 5, 2021, 9:33 PM

#

vale ibex ```py @staticmethod def run_metricity_init() -> None: """ ...

ok lol, it was much more complicated than this

green oriole Sep 5, 2021, 9:34 PM

#

Hahaha

vale ibex Sep 5, 2021, 9:34 PM

#

gonna push in a sec, just writing a commit message

#

you can enjoy my pain

#

site#583 🙃

dusky shoreBOT Sep 5, 2021, 9:36 PM

#

GitHub

PROpen Initialise metricity at runtime

green oriole Sep 5, 2021, 9:37 PM

#

Haha that's quite funny

#

It looks good though

vale ibex Sep 5, 2021, 9:38 PM

#

Yea, postgres doesn't have CREATE DATABASE IF NOT EXISTS

#

I'm going to bed now though, so feel free to roast my changes

#

oh lol, even CI is complaining that metricity doesn't exist

#

not sure how we feel about running that in debug mode tho

#

that push should fix it

green oriole Sep 5, 2021, 9:46 PM

#

Almost

vale ibex Sep 5, 2021, 9:46 PM

#

Hmm no

#

The CI is failing here as CI doesn't have metricity either, and django-prometheus now requires it as part of django.setup()

We have two options here, either we can run this new run_metricity_init() func during CI, or we can always run it.

Running it in CI makes the most sense, as it's lower risk

green oriole Sep 5, 2021, 9:46 PM

#

Agreed

#

I think it does make sense here

#

We want the CI env to be as close as possible to the prod env

vale ibex Sep 5, 2021, 9:49 PM

#

alr lets see if this does it

#

wait, no

#

copy-paste error

#

I noticed before CI failed, so it doesn't count

remote wigeon Sep 5, 2021, 9:52 PM

#

vale ibex Yea, postgres doesn't have CREATE DATABASE IF NOT EXISTS

well how should that work, when you need the database to make the connection to begin with KEKW

vale ibex Sep 5, 2021, 9:52 PM

#

you run it while connected to another db

remote wigeon Sep 5, 2021, 9:53 PM

#

sounds like an extra step to me

#

its not like you expect a create postgres server if not exists KEKW

vale ibex Sep 5, 2021, 9:53 PM

#

ahh right I see the issue, in CI we only do migrations, rather than running

#

so this code never hits

green oriole Sep 5, 2021, 9:53 PM

#

remote wigeon its not like you expect a create postgres server if not exists <:KEKW:7278253084...

I mean.. that's kind of what k8s is here for

remote wigeon Sep 5, 2021, 9:54 PM

#

fair ig

vale ibex Sep 5, 2021, 9:54 PM

#

hmmm, not too sure what to do here

#

CI runs ```
python manage.py makemigrations --check
python manage.py migrate
coverage run manage.py test --no-input
coverage report -m

#

but fails on python manage.py migrate since it needs metricity

#

and we only run our custom logic when running, rather than migrating

#

I need to head to bed now anyway, so feel free to leave suggestions in the PR

trail pilot Sep 6, 2021, 12:07 AM

#

What does this mean? aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host discord.com:443 ssl:default [No address associated with hostname], this occurs if I keep my fork running for a while wihtout closing it

clever wraith Sep 6, 2021, 12:47 AM

#

Big Programming languages are coming to steal your freedom! They are becoming higher level by the minute!!! They are lying to the people by not telling us what’s going on and abstracting stuff!!!! I NEED TO SEE RAw pointers FOR MY FREEDOM …… RETURN TO COBOL And THEY HIDE WHAT EVERYTHING MEANS BEHIND “DOCUMENTATION” WHO READS IT??? ITS LIKE THE TOS

@trail pilot explain

cold island Sep 6, 2021, 1:06 AM

#

trail pilot What does this mean? `aiohttp.client_exceptions.ClientConnectorError: Cannot con...

Fork of what?

clever wraith Sep 6, 2021, 2:03 AM

#

hey @brisk brook what did you mean by a converter

trail pilot Sep 6, 2021, 2:26 AM

#

clever wraith > Big Programming languages are coming to steal your freedom! They are becoming ...

It was sarcasm and I think this is the wrong chat lmao

trail pilot Sep 6, 2021, 2:26 AM

#

cold island Fork of what?

sir lancebot fork

left flume Sep 6, 2021, 3:03 AM

#

so since you'll just be sticking to discord.py 2, context menus will not be used on this server, isn't it?

short snow Sep 6, 2021, 3:41 AM

#

oh no, restructure PR merged

#

argh

desert vessel Sep 6, 2021, 3:52 AM

#

ahhhhhhh

#

screw docker

brisk brook Sep 6, 2021, 5:23 AM

#

clever wraith hey <@!344404945359077377> what did you mean by a converter

Discord.py converter

patent pivot Sep 6, 2021, 5:43 AM

#

short snow argh

sometimes this is just file renames, merging with CLI is generally fairly alright, but GitHub web editor can't pick up file renames

#

When I was restructuring kube repo I got that a lot but when I ran git merge main it actually figured out the renames even if I'd modified the content

vale ibex Sep 6, 2021, 8:55 AM

#

I figured out how to fix site#583

dusky shoreBOT Sep 6, 2021, 8:55 AM

#

GitHub

PROpen Initialise metricity at runtime

vale ibex Sep 6, 2021, 9:37 AM

#

agreed

cold island Sep 6, 2021, 9:46 AM

#

left flume so since you'll just be sticking to discord.py 2, context menus will not be used...

Upgrading to dpy 2 is just a way to get some of the new features such as threads and buttons.

But we're not planning on sticking with dpy forever, as it will gradually become more and more out of date. But we are sticking with it in the near future.

If we ever want something that we can't get with dpy, we might look elsewhere, depending on how much we want it.

tl;dr: the bot development ecosystem in Python is a bit hectic right now, we're not in a rush.

vale ibex Sep 6, 2021, 10:12 AM

#

because this small change only really needs 1 commit

#

probably should have kept them separate and then squashed, but oh well

vale ibex Sep 6, 2021, 10:31 AM

#

@timid sentinel Was looking at the talentpool comment you left. I was thinking of removing the refresh cache from reschedule_reviews entirely and doing it on init

#

we already refresh the cache whenever someone is added or removed from the pool too, so I don't think it's needed in there

timid sentinel Sep 6, 2021, 11:43 AM

#

@vale ibex yeah that sounds good

green oriole Sep 6, 2021, 11:46 AM

#

I typed https://git.pydis.com/seasonalbot in my browser and took a good second to realize it wasn't right

#

Actually the link works, oh well

brisk brook Sep 6, 2021, 11:53 AM

#

rip SeasonalBot 2021

vale ibex Sep 6, 2021, 12:00 PM

#

timid sentinel <@126811506632294400> yeah that sounds good

alright done. I also migrated the tasks to @brazen charm's scheduling.create_task() util, since it adds a callback to log errors

green oriole Sep 6, 2021, 12:06 PM

#

Man, when I woke up today I was really like "What a nice day! I am so excited to replace 51 avatar_url by avatar.url"

#

so much fun

#

why such a silly breaking change

vale ibex Sep 6, 2021, 12:09 PM

#

lol

#

rebuilding bot is such a pain atm

#

since I need to manually migrate metricity each time I rebuild site lol

#

lancebot isn't too bad nice easy setup

#

bot is a bit harder since you need to setup all the channels, emojis and webhooks

green oriole Sep 6, 2021, 12:11 PM

#

47 passed, 210 errors in 8.60s
oh that's fun

#

they removed default arguments for context.bot and context.view ;-;

#

I will actually cry

vale ibex Sep 6, 2021, 12:15 PM

#

lmfao

sacred fossil Sep 6, 2021, 12:15 PM

#

Finally free enough to boot back to Linux. Re: sir-lancebot#785, how should I resolve the file conflict? Pull down the new tree, re-fix and force-push?

dusky shoreBOT Sep 6, 2021, 12:15 PM

#

GitHub

PROpen Correct an off-by-one bug due to bisect.bisect()

brazen charm Sep 6, 2021, 12:16 PM

#

you can start merging, move the file and then commit the merge; or rewriting the commit with a force pusha lso works

sacred fossil Sep 6, 2021, 12:17 PM

#

Isn't force-pushing kinda frowned upon? I don't know the exact details as I only saw the practice mentioned in memes with a general negative remark

brazen charm Sep 6, 2021, 12:17 PM

#

What are the stats for usage of the tag content search commands?

vale ibex Sep 6, 2021, 12:17 PM

#

force pushing to public branches is bad, since it messes with people's local copies, force pushing branches is fine as long as other people working on the branch (if any) are told

sacred fossil Sep 6, 2021, 12:18 PM

#

and there's only me on my branch, that should be good?

vale ibex Sep 6, 2021, 12:18 PM

#

yupyup

sacred fossil Sep 6, 2021, 12:18 PM

#

it's force-pushing time

vale ibex Sep 6, 2021, 12:19 PM

#

brazen charm What are the stats for usage of the tag content search commands?

wdym by tag searching?

brazen charm Sep 6, 2021, 12:19 PM

#

the tag search command

vale ibex Sep 6, 2021, 12:20 PM

#

oh lol didn't even know that existed

#

1 sec

green oriole Sep 6, 2021, 12:21 PM

#

It is looking a bit better, I guess

vale ibex Sep 6, 2021, 12:25 PM

#

hmmmmmm

#

#

all 0s

#

sounds wrong

#

!tags search star

stable mountainBOT Sep 6, 2021, 12:25 PM

#

Here are the tags containing the given keyword:

» decorators
» microsoft-build-tools
» modmail
» repl
» seek
» star-imports
» windows-path

vale ibex Sep 6, 2021, 12:25 PM

#

lemme see if this shows up

#

ah ok

#

#

last 90 days

brazen charm Sep 6, 2021, 12:27 PM

#

What's on the y axis?

vale ibex Sep 6, 2021, 12:28 PM

#

default output from graphite

#

IE I have no idea

#

maybe @patent pivot can give us a cool function to make this make sense?

brazen charm Sep 6, 2021, 12:28 PM

#

I was thinking or removing it if it had no uses as it's around 80 lines to maintain but if it's used occasionally it's fine to keep

patent pivot Sep 6, 2021, 12:28 PM

#

@vale ibex change stats for stats_counts

vale ibex Sep 6, 2021, 12:29 PM

#

#

nice nice

#

green oriole Sep 6, 2021, 12:33 PM

#

.....

#

no it's not

cold island Sep 6, 2021, 12:34 PM

#

what context makes it bad?

#

where is this even from

brazen charm Sep 6, 2021, 12:37 PM

#

there's a template pinned here, not sure how up to date it is

cold island Sep 6, 2021, 12:37 PM

#

search for discord.new in this channel

brazen charm Sep 6, 2021, 12:37 PM

#

you can just create a couple of channels and roles and set multiple keys to those

green oriole Sep 6, 2021, 12:37 PM

#

it is from the d.py source code

#

how they map external data to internal resources

#

https://discord.new/zmHtscpYN9E3

#

erm

vale ibex Sep 6, 2021, 12:47 PM

#

to give all permissions in guild, but not be picked up by the bot

#

IE, a superuser has full access to the server, but is still treated as a normal user as far as the bot is concerned

#

so you can test filters as an example

humble isle Sep 6, 2021, 12:50 PM

#

just tryinm to get 50 messages

vale ibex Sep 6, 2021, 12:53 PM

#

humble isle just tryinm to get 50 messages

?

green oriole Sep 6, 2021, 12:59 PM

#

I am really curious how d.py managed to change their HSV calculation between the two versions

vale ibex Sep 6, 2021, 1:02 PM

#

Did they change it more than adding the optional seed for the random colour?

green oriole Sep 6, 2021, 1:06 PM

#

apparently, the test for the role embed is failing

vale ibex Sep 6, 2021, 1:10 PM

#

🤔

#

odd

brisk brook Sep 6, 2021, 1:14 PM

#

green oriole I am really curious how d.py managed to change their HSV calculation between the...

Wat

#

That's because they change the Blurple colors?

molten perch Sep 6, 2021, 1:19 PM

#

You have to sign them.
https://docs.github.com/en/github/authenticating-to-github/managing-commit-signature-verification/signing-commits

vale ibex Sep 6, 2021, 1:20 PM

#

The green tick when approving is only for users in the org

#

yea, thats it 😄

#

wasn't too bad to setup

brisk brook Sep 6, 2021, 1:28 PM

#

What are you doing exactly?

#

Generating GPG key?

elder belfry Sep 6, 2021, 1:31 PM

#

I guess u need to choose option 1

green oriole Sep 6, 2021, 1:31 PM

#

brisk brook That's because they change the Blurple colors?

not a single clue shrugs

#

I personally use RSA/RSA

#

do you have a key in ~/.gnupg

#

also

[discord-2.0 2fbe252d] Migrate to Discord.py 2.0a0
 28 files changed, 174 insertions(+), 139 deletions(-)

umbral rose Sep 6, 2021, 1:36 PM

#

how to solve this error

green oriole Sep 6, 2021, 1:36 PM

#

Hey @umbral rose, please have a look at #❓｜how-to-get-help

patent pivot Sep 6, 2021, 1:37 PM

#

wew

#

lol

green oriole Sep 6, 2021, 1:39 PM

#

64 is like nothing

patent pivot Sep 6, 2021, 1:39 PM

#

yeah rust or node is significantly more lol

brazen charm Sep 6, 2021, 1:48 PM

#

it inserts the values from the restart policy

green oriole Sep 6, 2021, 1:59 PM

#

if y'all could have a shot at https://github.com/python-discord/bot/pull/1815 , I would really really really appreciate it. Beside it is our last blocker at starting to use threads publicly abelwink

GitHub

Migrate to Discord 2.0a0 by Akarys42 · Pull Request #1815 · python...

Since the Discord.py repository has been archived, we can switch to the latest commit of 2.0a0, knowing no breaking change will occur (still pinned to the commit just in case).
This PR fixes any pr...

#

anything

#

just has to be set

brazen charm Sep 6, 2021, 2:02 PM

#

I think it's on by default

molten perch Sep 6, 2021, 2:02 PM

#

I think it has to be "true"
debug = environ.get("BOT_DEBUG", "true").lower() == "true"

#

I might be wrong, though.

gritty wind Sep 6, 2021, 2:03 PM

#

the second value in the get is the default, so if not set will default to on

#

I mean, a lot of those things were already under evergreen, so they were never technically seasons

#

If you have a better term, you can PR it

left flume Sep 6, 2021, 2:50 PM

#

cold island Upgrading to dpy 2 is just a way to get some of the new features such as threads...

Hmmm, I see

keen valley Sep 6, 2021, 3:00 PM

#

https://github.com/python-discord/sir-lancebot/blob/main/bot/bot.py#L40

stable mountainBOT Sep 6, 2021, 3:00 PM

#

bot/bot.py line 40

self.loop.create_task(self.send_log(self.name, "Connected!"))```