#dev-contrib | Python | Page 131

gritty wind Sep 2, 2021, 9:34 PM

#

I mean, we can if we wanted to. Just throw a translator in front of the compose 🤡

fallen patrol Sep 2, 2021, 9:35 PM

#

wytf

#

https://pypi.pythondiscord.com

#

why is this a thing

fervent sage Sep 2, 2021, 9:35 PM

#

gritty wind I mean, we can if we wanted to. Just throw a translator in front of the compose ...

joe wouldnt let you

patent pivot Sep 2, 2021, 9:35 PM

#

nope — docker-compose doesn't super closely mirror prod either. only code jam management accounts for the fact that none of our services cacn write to disk https://github.com/python-discord/code-jam-management/blob/main/docker-compose.yml#L15-L16

stable mountainBOT Sep 2, 2021, 9:35 PM

#

docker-compose.yml lines 15 to 16

read_only: true  # Prod uses a read-only fs, override this locally if it helps with debugging
user: "1000"  # Prod uses a non-root user, override this locally if it helps with debugging```

static canyon Sep 2, 2021, 9:35 PM

#

hmmmm lol

#

That's very scuffed/cursed

gritty wind Sep 2, 2021, 9:35 PM

#

That part was more an example, it's just that mypy picked up that stub as the typing for import logging, so whenever you do it, it think's it's importing that stub, not the actual logging file

vale ibex Sep 2, 2021, 9:35 PM

#

Kompose 🤡

patent pivot Sep 2, 2021, 9:36 PM

#

fallen patrol why is this a thing

we had plans to use it at some point to host a package — we don't now and I removed the service without removing DNS lol

gritty wind Sep 2, 2021, 9:36 PM

#

Anyways, this was for the fun of playing with the typing system/mypy, not as practical as your solution lol

static canyon Sep 2, 2021, 9:36 PM

#

yeah lol

#

So for the actual solution I'd need to have a util get_logger and then the actual custom logger itself

gritty wind Sep 2, 2021, 9:37 PM

#

That sounds about right

patent pivot Sep 2, 2021, 9:37 PM

#

we could use https://github.com/kubernetes/kompose but don't

GitHub

GitHub - kubernetes/kompose: Go from Docker Compose to Kubernetes

Go from Docker Compose to Kubernetes. Contribute to kubernetes/kompose development by creating an account on GitHub.

#

oh chris already mentioned it lol

#

a terrifying tool

gritty wind Sep 2, 2021, 9:38 PM

#

You may also be able to use a find-and-replace on logging.getLogger(__name__) to migrate almost the entire code base

#

There are 19 instances of not that

fallen patrol Sep 2, 2021, 9:40 PM

#

hm, does pydis have S3 buckets from aws?

patent pivot Sep 2, 2021, 9:40 PM

#

it's smart, but then people use it to deploy apps which is not what it's for

patent pivot Sep 2, 2021, 9:40 PM

#

fallen patrol hm, does pydis have S3 buckets from aws?

S3, yes, AWS, no

gritty wind Sep 2, 2021, 9:40 PM

#

Didn't we have some for that quackstack nonsense

patent pivot Sep 2, 2021, 9:40 PM

#

we uses Linode

fallen patrol Sep 2, 2021, 9:40 PM

#

kubernetes#53

dusky shoreBOT Sep 2, 2021, 9:40 PM

#

GitHub

PRMerged Migrate backup config to blackbox v2.

fervent sage Sep 2, 2021, 9:40 PM

#

nonsense
eXcuSe mE

patent pivot Sep 2, 2021, 9:41 PM

#

yep

fervent sage Sep 2, 2021, 9:41 PM

#

yeah

gritty wind Sep 2, 2021, 9:41 PM

#

It's quacky

patent pivot Sep 2, 2021, 9:41 PM

#

https://github.com/python-discord/kubernetes/blob/main/blackbox/blackbox-configmap.yaml

GitHub

kubernetes/blackbox-configmap.yaml at main · python-discord/kuberne...

Kubernetes manifests for Python Discord services. Contribute to python-discord/kubernetes development by creating an account on GitHub.

#

we backup to Frankfurt, Newark and Singapore

#

Redis, PostgreSQL and MongoDB

fallen patrol Sep 2, 2021, 9:42 PM

#

so how exactly is it a backup if its hosted by the same place wat

patent pivot Sep 2, 2021, 9:42 PM

#

what

#

it's georedundant

#

we could lose 2/3 of the earth lol

fervent sage Sep 2, 2021, 9:43 PM

#

patent pivot we could lose 2/3 of the earth lol

challenge?

gritty wind Sep 2, 2021, 9:43 PM

#

More likely linode goes bankrupt before then

#

Or humanity loses electricity and we revert to the stone age

patent pivot Sep 2, 2021, 9:44 PM

#

yep

#

arthur cj trigger

fervent sage Sep 2, 2021, 9:44 PM

#

or humanity just goes

radiant merlinBOT Sep 2, 2021, 9:44 PM

#

:tools: Pick a CronJob to trigger

radiant merlinBOT Sep 2, 2021, 9:44 PM

#

radiant merlin :tools: Pick a CronJob to trigger

🌬️ Spawned job blackbox-883105023993729054

patent pivot Sep 2, 2021, 9:45 PM

#

fallen patrol so how exactly is it a backup if its hosted by the same place wat

#

the only one in the same DC as us is the frankfurt one

#

the other two are completely separate

fallen patrol Sep 2, 2021, 9:45 PM

#

ah

fallen patrol Sep 2, 2021, 9:46 PM

#

radiant merlin :tools: Pick a CronJob to trigger

hm, how is it not possible for me to choose something from this dropdown without an edited tag

gritty wind Sep 2, 2021, 9:46 PM

#

Default permission maybe?

#

At least that's the case for other interactions

fallen patrol Sep 2, 2021, 9:47 PM

#

I mean, if y'all have the use application commands perm off in the server that might be why

patent pivot Sep 2, 2021, 9:47 PM

#

fallen patrol hm, how is it not possible for me to choose something from this dropdown *withou...

components don't have an edited if only the view changes

fallen patrol Sep 2, 2021, 9:47 PM

#

ah, ty

#

so the bot edited the dropdown to be disabled

#

cool

patent pivot Sep 2, 2021, 9:47 PM

#

ended up being pretty alright tbqh

fallen patrol Sep 2, 2021, 9:47 PM

#

arthur source

static canyon Sep 2, 2021, 9:47 PM

#

# bot/bot/log.py
import logging

TRACE_LEVEL = 5


class CustomLogger:
    def trace(self: logging.Logger, msg: str, *args, **kwargs) -> None:
        """
        Log 'msg % args' with severity 'TRACE'.

        To pass exception information, use the keyword argument exc_info with
        a true value, e.g.

        logger.trace("Houston, we have an %s", "interesting problem", exc_info=1)
        """
        if self.isEnabledFor(TRACE_LEVEL):
            self._log(TRACE_LEVEL, msg, args, **kwargs)


logging.TRACE = TRACE_LEVEL
logging.addLevelName(logging.TRACE, "TRACE")

logging.setLoggerClass(CustomLogger)

...  # log_file_format_stuff

_set_trace_loggers()
``````py
# bot/bot/utils/log.py
import logging
import typing as t

from bot.log import CustomLogger


def get_logger(name: str = None) -> CustomLogger:
    return t.cast(CustomLogger, logger.getLogger(name))``````py
# bot/bot/exts/moderation/infraction.py
from bot.utils import get_logger

log = get_logger()
...
log.trace(...)
```does this seem right? @gritty wind

fallen patrol Sep 2, 2021, 9:48 PM

#

fallen patrol arthur source

^ could this be a command, like lance and bot

#

arthur help

#

ah, not easily

#

since its a global check if core dev

gritty wind Sep 2, 2021, 9:48 PM

#

It might not be necessary to set logging.TRACE = TRACE_LEVEL

patent pivot Sep 2, 2021, 9:48 PM

#

arthur jsk source cj trigger

radiant merlinBOT Sep 2, 2021, 9:48 PM

#

📎 jobs.py

gritty wind Sep 2, 2021, 9:49 PM

#

everything else looks right

patent pivot Sep 2, 2021, 9:49 PM

#

I would add it but it's way easier if I just have a global devops check

gritty wind Sep 2, 2021, 9:49 PM

#

perhaps keep it in the setup_loggers function though (the functional stuff)

trim cradle Sep 2, 2021, 9:49 PM

#

arthur hi

#

arthur help

#

that bastard!

static canyon Sep 2, 2021, 9:49 PM

#

yeah the logging.TRACE onwards for /log.py would be in setup()

gritty wind Sep 2, 2021, 9:50 PM

#

lgtm then

static canyon Sep 2, 2021, 9:50 PM

#

gritty wind It might not be necessary to set `logging.TRACE = TRACE_LEVEL`

It is since it's used elsewhere in the setup

trim cradle Sep 2, 2021, 9:50 PM

#

I changed my name because I'm so fucking mad at king arthur.

gritty wind Sep 2, 2021, 9:50 PM

#

Fair enough

static canyon Sep 2, 2021, 9:51 PM

#

Ah

#

self._log(...) this will have to change, presumably to logging.Logger._log(...)?

patent pivot Sep 2, 2021, 9:52 PM

#

radiant merlin 🌬️ Spawned job `blackbox-883105023993729054`

hey winner

gritty wind Sep 2, 2021, 9:52 PM

#

self._log = bot.utils.get_logger(...)

#

Replace the dots with whatever is already there

#

The references toself._log don't need to change

patent pivot Sep 2, 2021, 9:53 PM

#

when they release nice permissions

#

yes but that sucks

static canyon Sep 2, 2021, 9:55 PM

#

gritty wind `self._log = bot.utils.get_logger(...)`

And what about if self.isEnabledFor(TRACE_LEVEL):?

patent pivot Sep 2, 2021, 9:55 PM

#

they have stuff in the works

fallen patrol Sep 2, 2021, 9:55 PM

#

patent pivot when they release nice permissions

cough if cough

patent pivot Sep 2, 2021, 9:56 PM

#

no, it's when

#

lol

fallen patrol Sep 2, 2021, 9:56 PM

#

they will release them but not soon enough

patent pivot Sep 2, 2021, 9:56 PM

#

¯_(ツ)_/¯

#

yeah

#

i have a sample of the metrics somewhere

#

uhhh

fallen patrol Sep 2, 2021, 9:57 PM

#

fallen patrol they will release them but not soon enough

Since, 8 months until message content is privileged, and all bots need to use application commands [yes ik this server is not affected] and library devs have to implement it first and then bots can but whatever.

#

seriously discord is not that great on their management

patent pivot Sep 2, 2021, 9:58 PM

#

https://cdn.discordapp.com/attachments/675756741417369640/881208098008731739/Screenshot_2021-08-28_at_17.06.19.png

fallen patrol Sep 2, 2021, 9:59 PM

#

githubpreview.dev?

gritty wind Sep 2, 2021, 9:59 PM

#

static canyon And what about `if self.isEnabledFor(TRACE_LEVEL):`?

What about it?

#

It should be fine as is I think

patent pivot Sep 2, 2021, 9:59 PM

#

fallen patrol githubpreview.dev?

github codespaces port forwarding

fallen patrol Sep 2, 2021, 9:59 PM

#

ah, codespaces

#

paid 😔

patent pivot Sep 2, 2021, 10:01 PM

#

tyty, applied!

#

maybe I should make the changes to the k8s repo now for this

static canyon Sep 2, 2021, 10:02 PM

#

Well CustomLogger isn't inheriting anything so isEnabledFor doesn't exist

#

@gritty wind ^

gritty wind Sep 2, 2021, 10:02 PM

#

CustomLogger should be inheriting Logger

static canyon Sep 2, 2021, 10:02 PM

#

Right

#

class CustomLogger(logging.Logger)?

gritty wind Sep 2, 2021, 10:02 PM

#

Yeah

#

I have that one from earlier up

#

class Logger(logging.Logger):
    def trace(self: logging.Logger, msg: str, *args, **kwargs) -> None:
        """
        ...
        """
        if self.isEnabledFor(5):
            self._log(5, msg, args, **kwargs)

#

Just needs a renaming, and a new docstring for the class itself

static canyon Sep 2, 2021, 10:03 PM

#

So I don't need to redefine self._log?

static canyon Sep 2, 2021, 10:03 PM

#

gritty wind `self._log = bot.utils.get_logger(...)`

^

gritty wind Sep 2, 2021, 10:04 PM

#

You do still need to set it to utils.get_logger, but for something like self._log.trace() you can leave that

patent pivot Sep 2, 2021, 10:04 PM

#

okay, changes made https://pythondiscord.com/metrics now 403s

gritty wind Sep 2, 2021, 10:04 PM

#

Basically, self._log is the CustomLogger, which is returned by the utils function

patent pivot Sep 2, 2021, 10:05 PM

#

i can yeah — I was going to implement first and add another PR in which introduces those things

static canyon Sep 2, 2021, 10:05 PM

#

gritty wind Basically, self._log is the CustomLogger, which is returned by the utils functio...

But then isn't that just self? Because self._log is within CustomLogger

gritty wind Sep 2, 2021, 10:06 PM

#

To rephrase from the begenning, the only thing you need to change is logging.getLogger(T) -> utils.get_logger(T)

#

Which self._log are you referring to

static canyon Sep 2, 2021, 10:06 PM

#

def _monkeypatch_trace(self: logging.Logger, msg: str, *args, **kwargs) -> None:
    """
    Log 'msg % args' with severity 'TRACE'.

    To pass exception information, use the keyword argument exc_info with
    a true value, e.g.

    logger.trace("Houston, we have an %s", "interesting problem", exc_info=1)
    """
    if self.isEnabledFor(TRACE_LEVEL):
        self._log(TRACE_LEVEL, msg, args, **kwargs)```I'm moving this into `CustomLogger`

gritty wind Sep 2, 2021, 10:06 PM

#

Ah, I see

#

Yeah that one can stay as is

#

I was referring to the ones we use in our code (such as https://github.com/python-discord/bot/blob/c2122316e5a34a2b9776e5e965a9434e748ab601/bot/utils/scheduling.py#L44)

stable mountainBOT Sep 2, 2021, 10:07 PM

#

bot/utils/scheduling.py line 44

self._log.trace(f"Scheduling task #{task_id}...")```

gritty wind Sep 2, 2021, 10:07 PM

#

Unrelated to the one in the CustomLogger class

static canyon Sep 2, 2021, 10:07 PM

#

Ah right

#

def _set_trace_loggers() -> None:
    """
    Set loggers to the trace level according to the value from the BOT_TRACE_LOGGERS env var.

    When the env var is a list of logger names delimited by a comma,
    each of the listed loggers will be set to the trace level.

    If this list is prefixed with a "!", all of the loggers except the listed ones will be set to the trace level.

    Otherwise if the env var begins with a "*",
    the root logger is set to the trace level and other contents are ignored.
    """
    level_filter = constants.Bot.trace_loggers
    if level_filter:
        if level_filter.startswith("*"):
            logging.getLogger().setLevel(logging.TRACE)

    ...
        ...
            logging.getLogger(logger_name).setLevel(logging.DEBUG)

    ...
        ...
            logging.getLogger(logger_name).setLevel(logging.TRACE)
```will I have to change each of these `logging.getLogger()` to `bot.utils.get_logger()`?

celest charm Sep 2, 2021, 10:09 PM

#

Does sir-lancebot currently accept new commands? Or is in in the process of restructuring?

static canyon Sep 2, 2021, 10:11 PM

#

static canyon ```py def _set_trace_loggers() -> None: """ Set loggers to the trace lev...

I don't think so right? Since logging.getLogger() will return the CustomLogger?

thorny obsidian Sep 2, 2021, 10:12 PM

#

celest charm Does sir-lancebot currently accept new commands? Or is in in the process of rest...

what are you thinking of? I was planning on doing the restructure this weekend

#

voice chat shenanigans

celest charm Sep 2, 2021, 10:12 PM

#

thorny obsidian what are you thinking of? I was planning on doing the restructure this weekend

oh, it can wait then

#

I wanted to propose a command for fetching info about a software license.

#

Like, you type .license mit, and you get an embed similar to this

patent pivot Sep 2, 2021, 10:14 PM

#

https://github.com/python-discord/meta has issue forms

#

I'm not sure about Lance, we might have some ideas in terms of what we want on there so I'd hang fire for now

celest charm Sep 2, 2021, 10:14 PM

#

well, I thought way too much about LGPL and this idea came to me, yeah

patent pivot Sep 2, 2021, 10:15 PM

#

celest charm I wanted to propose a command for fetching info about a software license.

could wrap github api

#

https://api.github.com/licenses

#

https://api.github.com/licenses/mit

celest charm Sep 2, 2021, 10:16 PM

#

yeah

#

but many are missing, that's just 12

#

I'll check the api docs

#

we will not ship the command without WTFPL

patent pivot Sep 2, 2021, 10:18 PM

#

celest charm but many are missing, that's just 12

yeah they list the most popular, but it has an API entry for it https://api.github.com/licenses/wtfpl

gritty wind Sep 2, 2021, 10:19 PM

#

static canyon ```py def _set_trace_loggers() -> None: """ Set loggers to the trace lev...

If that instance is going to be using trace, it needs to use the utils function (this is only for typehinting). To make things less confusing, I think it makes sense to always use it

#

(mypy can't pick up that getLogger won't return the default Logger argument, that's why we need the second function to tell it we're using CustomLogger)

celest charm Sep 2, 2021, 10:21 PM

#

patent pivot yeah they list the most popular, but it has an API entry for it https://api.gith...

Hm... how come there's no endpoint to fetch all of them? And if I can only fetch 12, how come the endpoint supports pagination?

patent pivot Sep 2, 2021, 10:21 PM

#

because the root is for displaying ones github considers "featured"

#

lol, that's true actually

celest charm Sep 2, 2021, 10:21 PM

#

ha

#

more like Loser GPL ikr

patent pivot Sep 2, 2021, 10:22 PM

#

doesn't have agpl either

#

ahhh hold on

#

it does have them

#

it just versions them https://api.github.com/licenses/lgpl-2.1

celest charm Sep 2, 2021, 10:23 PM

#

The Github API is a wrapper around the licensee ruby gem, seems a bit strange to make a wrapper about the api lol

patent pivot Sep 2, 2021, 10:23 PM

#

https://api.github.com/licenses/agpl-3.0

#

if you put https://api.github.com/licenses?featured=false you get more

celest charm Sep 2, 2021, 10:28 PM

#

patent pivot if you put https://api.github.com/licenses?featured=false you get more

I get nine

celest charm Sep 2, 2021, 10:44 PM

#

Yeah, we can just take https://github.com/licensee/licensee/tree/master/vendor/choosealicense.com/_licenses

#

which is what github uses by proxy

#

and we'll convert it to JSON somehow

fallen patrol Sep 2, 2021, 10:45 PM

#

looks like github actually uses spdx

celest charm Sep 2, 2021, 10:45 PM

#

maybe

#

they mentioned licensee somewhere

fallen patrol Sep 2, 2021, 10:46 PM

#

https://spdx.org/licenses/

celest charm Sep 2, 2021, 10:46 PM

#

we can also rewrite the bot in Ruby so that it uses licensee

fallen patrol Sep 2, 2021, 10:46 PM

#

a nearly full list of licenses

celest charm Sep 2, 2021, 10:46 PM

#

oh, nice

#

https://github.com/spdx/license-list-data/blob/master/json/licenses.json

#

but it doesn't have useful info

#

maybe we should hand-pick the most used licenses and just manually decsribe them

fallen patrol Sep 2, 2021, 10:47 PM

#

my chain: https://choosealicense.com/ -> edit on github -> submodule
license-list-XML @ b7470fc -> read readme and find https://spdx.org/licenses/

#

wait here's the machine readable licenses https://github.com/spdx/license-list-data

GitHub

GitHub - spdx/license-list-data: Various data formats for the SPDX ...

Various data formats for the SPDX License List including RDFa, HTML, Text, and JSON - GitHub - spdx/license-list-data: Various data formats for the SPDX License List including RDFa, HTML, Text, and...

clever wraith Sep 2, 2021, 10:49 PM

#

Hey quick question, does quackstack let you supply a seed

#

For .quack

fervent sage Sep 2, 2021, 10:49 PM

#

no

fallen patrol Sep 2, 2021, 10:50 PM

#

celest charm but it doesn't have useful info

it does tho, but you have to make a request for it

clever wraith Sep 2, 2021, 10:50 PM

#

fervent sage no

Lovely

fervent sage Sep 2, 2021, 10:50 PM

#

it will soon i hope

fallen patrol Sep 2, 2021, 10:50 PM

#

its all of the "detailsUrl": keys

clever wraith Sep 2, 2021, 10:50 PM

#

So I'll have to randomly generate color values for now

fervent sage Sep 2, 2021, 10:51 PM

#

github isnt loading for me so i cant link the pr

stable mountainBOT Sep 2, 2021, 10:51 PM

#

src/models.py line 49

variation: int```

fervent sage Sep 2, 2021, 10:51 PM

#

but im waiting on a pr to be merged before i can add the seed

#

quackstack#52 maybe

dusky shoreBOT Sep 2, 2021, 10:51 PM

#

GitHub

PROpen feat: make quackstack package-ready

fervent sage Sep 2, 2021, 10:51 PM

#

ye

fallen patrol Sep 2, 2021, 10:51 PM

#

stable mountain `src/models.py` line 49 ```py variation: int```

meta: why is this feature on @stable mountain when @dusky shore does pr linking?

#

these should be merged smh

fervent sage Sep 2, 2021, 10:52 PM

#

fallen patrol these should be merged smh

create an issue on bot perhaps

fallen patrol Sep 2, 2021, 10:52 PM

#

also would merge issues.py and githubinfo.py into one cog as well

fervent sage Sep 2, 2021, 10:53 PM

#

imo it should all go in the main Python bot, since it's less of a fun community thing and a fairly important server feature

fallen patrol Sep 2, 2021, 10:54 PM

#

.issue 778

#

asdf

#

also this

#

sir-lancebot#778

dusky shoreBOT Sep 2, 2021, 10:55 PM

#

GitHub

PROpen Merge automatic issue linking into the github cog

brazen charm Sep 2, 2021, 10:57 PM

#

my opinion on this last time it was brought up was that most of the things that re not event specific and have to be allowed outside of the normal lancebot channels should be implemented on @stable mountain but I had no idea where to make the issue and forgot about it

fallen patrol Sep 2, 2021, 10:58 PM

#

speaking of which, I have a large review to make on 778

fallen patrol Sep 2, 2021, 10:58 PM

#

brazen charm my opinion on this last time it was brought up was that most of the things that ...

ig meta

static canyon Sep 2, 2021, 11:01 PM

#

bot_1       | Traceback (most recent call last):
bot_1       |   File "/usr/local/lib/python3.9/runpy.py", line 188, in _run_module_as_main
bot_1       |     mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
bot_1       |   File "/usr/local/lib/python3.9/runpy.py", line 147, in _get_module_details
bot_1       |     return _get_module_details(pkg_main_name, error)
bot_1       |   File "/usr/local/lib/python3.9/runpy.py", line 111, in _get_module_details
bot_1       |     __import__(pkg_name)
bot_1       |   File "/bot/bot/__init__.py", line 8, in <module>
bot_1       |     from bot import log
bot_1       |   File "/bot/bot/log.py", line 12, in <module>
bot_1       |     from bot import constants
bot_1       |   File "/bot/bot/constants.py", line 21, in <module>
bot_1       |     from .utils.logging import get_logger
bot_1       |   File "/bot/bot/utils/__init__.py", line 2, in <module>
bot_1       |     from bot.utils.services import send_to_paste_service
bot_1       |   File "/bot/bot/utils/services.py", line 6, in <module>
bot_1       |     from bot.constants import URLs
bot_1       | ImportError: cannot import name 'URLs' from partially initialized module 'bot.constants' (most likely due to a circular import) (/bot/bot/constants.py)```I've now got this error I need to fix

#

A circular import issue

fervent sage Sep 2, 2021, 11:01 PM

#

clever wraith Lovely

I'll have a pr ready for seeded ducks in an hour or two

clever wraith Sep 2, 2021, 11:02 PM

#

Tysm

#

That'll be very helpful

static canyon Sep 2, 2021, 11:03 PM

#

bot.constants needs bot.utils.logging
bot.utils.logging needs bot.utils.services
bot.utils.services needs bot.constants

clever wraith Sep 2, 2021, 11:04 PM

#

static canyon bot.constants needs bot.utils.logging bot.utils.logging needs bot.utils.services...

Messy

static canyon Sep 2, 2021, 11:04 PM

#

clever wraith Messy

Not even

#

It's just the way the code is structured from before I made my adjustments

#

Actually there's no log.trace in bot.constants so it doesn't truly need bot.utils.logging

#

So I guess I'll just leave it

#

Mypy will detect the wrong thing but it won't matter because it only breaks on log.trace which doesn't appear in the file

fervent sage Sep 2, 2021, 11:10 PM

#

Okie would appreciate reviews on quackstack#60 it adds suck seeds and also fixes a fuck up I made when not updating the dockerfile Facepalm

dusky shoreBOT Sep 2, 2021, 11:10 PM

#

GitHub

PROpen feat: add the ability to set seeds for ducks

static canyon Sep 2, 2021, 11:10 PM

#

Eh feck

#

I've fixed the issue but docker is still running the old code

fervent sage Sep 2, 2021, 11:12 PM

#

look

#

typing is hard

#

at least i didnt do it in the PR name KEKW

static canyon Sep 2, 2021, 11:13 PM

#

Restarting docker completely cause just the container didn't seem tow rok

clever wraith Sep 2, 2021, 11:13 PM

#

Ty Alec, reviewed

static canyon Sep 2, 2021, 11:16 PM

#

It's still running old code @clever wraith

#

Hmm different error nvm

fervent sage Sep 2, 2021, 11:18 PM

#

ty

static canyon Sep 2, 2021, 11:19 PM

#

nvm this really just isn't working

patent pivot Sep 2, 2021, 11:19 PM

#

oh

static canyon Sep 2, 2021, 11:20 PM

#

Either docker is running old code or I'm just blind and can't see the difference in the error

patent pivot Sep 2, 2021, 11:20 PM

#

https://github.com/python-discord/kubernetes/pull/95

GitHub

Move all manifests into namespaced folders by jb3 · Pull Request #9...

This PR prevents us adding a bunch of folders to the root of the Kubernetes repository by moving manifests into folders based on the namespace they are deployed to.

static canyon Sep 2, 2021, 11:21 PM

#

Right I think

#

bot.log imports bot.ext.utils.logging
bot.ext.utils.logging imports bot.log

patent pivot Sep 2, 2021, 11:21 PM

#

i'll need to PR like

#

a lot of files after

#

#

every repo that clones k8s as a part of deployment needs a path update

#

@fervent sage 🤨

#

ERROR: Error loading ASGI app. Could not import module "main".

fervent sage Sep 2, 2021, 11:23 PM

#

see second line of PR lol

static canyon Sep 2, 2021, 11:23 PM

#

Ugh this is such bs lol

fervent sage Sep 2, 2021, 11:23 PM

#

its only 33% my fault

#

2 other people approved the PR

#

mmLol

patent pivot Sep 2, 2021, 11:24 PM

#

ah lol

static canyon Sep 2, 2021, 11:24 PM

#

File "/bot/bot/constants.py", line 21, in <module>
bot_1 | from .utils.logging import get_logger

This line doesn't exist anymore so why is it in the error message? @clever wraith

#

Yes

#

This is what's actually L21

#

docker-compose up bot is the command I'm running

patent pivot Sep 2, 2021, 11:25 PM

#

ping me when quackstack PR is ready for devops sign off

#

i'll rollback the deploy for now

#

this is nice

fervent sage Sep 2, 2021, 11:26 PM

#

updated

static canyon Sep 2, 2021, 11:27 PM

#

okay

#

lemme try

patent pivot Sep 2, 2021, 11:27 PM

#

merged

fervent sage Sep 2, 2021, 11:28 PM

#

im glad you clicked merge joe

#

now I dont have to feel as bad if it breaks

#

kek

patent pivot Sep 2, 2021, 11:28 PM

#

lmfao

static canyon Sep 2, 2021, 11:29 PM

#

Okay that seemed to work, thanks @clever wraith

patent pivot Sep 2, 2021, 11:29 PM

#

seems to be back https://quackstack.pythondiscord.com/docs

static canyon Sep 2, 2021, 11:30 PM

#

lol

fervent sage Sep 2, 2021, 11:30 PM

#

the duck with my user id as seed is https://quackstack.pydis.com/static/2c386ef22551eb34a3f793f2ad56c63abacf2756.png

#

lmao

fallen patrol Sep 2, 2021, 11:30 PM

#

patent pivot every repo that clones k8s as a part of deployment needs a path update

So 11 concurrent prs (minimum) need to be merged?

fervent sage Sep 2, 2021, 11:30 PM

#

thats awful

patent pivot Sep 2, 2021, 11:31 PM

#

fallen patrol So 11 concurrent prs (minimum) need to be merged?

yes but I can override policy checks

fallen patrol Sep 2, 2021, 11:31 PM

#

Jeez

patent pivot Sep 2, 2021, 11:31 PM

#

it's 10-20 mins work

#

I don't need to get approvals

fallen patrol Sep 2, 2021, 11:31 PM

#

Ik but still

celest charm Sep 2, 2021, 11:31 PM

#

patent pivot seems to be back https://quackstack.pythondiscord.com/docs

is there a way to switch to swagger? ~~or is it not fastapi?~~ (it is, it's in the title)

fallen patrol Sep 2, 2021, 11:31 PM

#

patent pivot I don't need to get approvals

Right and if it breaks, it would be broken anyhow

patent pivot Sep 2, 2021, 11:32 PM

#

it won't break, but yeah I guess lol

fervent sage Sep 2, 2021, 11:32 PM

#

celest charm is there a way to switch to swagger? ~~or is it not fastapi?~~ (it is, it's in t...

https://quackstack.pythondiscord.com/swagger_docs

celest charm Sep 2, 2021, 11:32 PM

#

thx

fervent sage Sep 2, 2021, 11:32 PM

#

I think swagger looks ugly as fuck so I made redoc the default

celest charm Sep 2, 2021, 11:32 PM

#

lemon_sentimental

patent pivot Sep 2, 2021, 11:32 PM

#

I had to override https://github.com/python-discord/site/pull/487 because it had 250 commits

GitHub

Dewikify! by kosayoda · Pull Request #487 · python-discord/site

This PR removes wiki features and django-allauth authentication from the site.

Event pages and sidebars are static pages at pydis_site/templates/events/pages
Resources are now loaded from .yaml fi...

fallen patrol Sep 2, 2021, 11:32 PM

#

fervent sage I think swagger looks ugly as fuck so I made redoc the default

/ugly_duck_docs

fallen patrol Sep 2, 2021, 11:33 PM

#

patent pivot I had to override https://github.com/python-discord/site/pull/487 because it had...

Why did that need an override?

patent pivot Sep 2, 2021, 11:33 PM

#

github api can't handle over 250 commits

#

so policy bot got unhappy

fallen patrol Sep 2, 2021, 11:33 PM

#

So how would that limit policy bot

patent pivot Sep 2, 2021, 11:33 PM

#

because it can't see the commits, lol

#

it has a bunch of checks that it runs on commit authors https://github.com/palantir/policy-bot#approval-rules

GitHub

GitHub - palantir/policy-bot: A GitHub App that enforces approval p...

A GitHub App that enforces approval policies on pull requests - GitHub - palantir/policy-bot: A GitHub App that enforces approval policies on pull requests

#

so it needs to see all commits

#

it doesn't work lol

#

works with everything but that

celest charm Sep 2, 2021, 11:35 PM

#

This is my user ID as seed

fervent sage Sep 2, 2021, 11:35 PM

#

lmao i forgot about this

#

x-powered-by: Joe Banks

patent pivot Sep 2, 2021, 11:36 PM

#

the best 23 bytes in the whole of python discord infrastructure

celest charm Sep 2, 2021, 11:36 PM

#

with joe's user ID as seed:

#

hmm weird, that's the SQLite one

patent pivot Sep 2, 2021, 11:37 PM

#

lmfao

#

hm I wonder why I diddn't get paged that quackstack had keeled over and died

celest charm Sep 2, 2021, 11:38 PM

#

it's actually really cool that it follows HATEOAS

fervent sage Sep 2, 2021, 11:38 PM

#

HATEOAS?

celest charm Sep 2, 2021, 11:38 PM

#

https://en.wikipedia.org/wiki/HATEOAS

#

stupid acronym, but still

#

basically, using URLs for referencing other resources

fervent sage Sep 2, 2021, 11:39 PM

#

ah yeah

#

Im quite happy with it that way

#

it didnt feel right to return a raw image from that endpoint

#

wouldnt make sense

celest charm Sep 2, 2021, 11:39 PM

#

github does that as well

fervent sage Sep 2, 2021, 11:39 PM

#

yeah i thought of that when i saw the wikipedia example

#

there's a massive object with stuff like repo_org: url, repo_stars: url, ...

celest charm Sep 2, 2021, 11:40 PM

#

yep

fervent sage Sep 2, 2021, 11:40 PM

#

/duck?seed

celest charm Sep 2, 2021, 11:41 PM

#

this

#

read the docs lemon_enraged

fervent sage Sep 2, 2021, 11:41 PM

#

oh crap im stupid

#

I added seed

#

into the place where seed will be ignored

#

if the duck config is provided the seed is provided

celest charm Sep 2, 2021, 11:41 PM

#

wait... it's ignored?

fervent sage Sep 2, 2021, 11:41 PM

#

but if the duck config is provided

#

the random is never used

patent pivot Sep 2, 2021, 11:42 PM

#

we should move qs to S3

fallen patrol Sep 2, 2021, 11:42 PM

#

fervent sage oh crap im stupid

Time to update review requirements for quackstack ig

fervent sage Sep 2, 2021, 11:42 PM

#

I'd like to just let everyone know that my head right now

patent pivot Sep 2, 2021, 11:42 PM

#

i will provision creds

fervent sage Sep 2, 2021, 11:42 PM

#

is just screaming

#

over and over

patent pivot Sep 2, 2021, 11:42 PM

#

upload to S3 on generation

#

return link

fallen patrol Sep 2, 2021, 11:42 PM

#

patent pivot we should move qs to S3

Why? And what

#

Ah

#

Makes sense

patent pivot Sep 2, 2021, 11:43 PM

#

fallen patrol Why? And what

because i don't want to serve images at scale from my infrastructure

fervent sage Sep 2, 2021, 11:43 PM

#

time to make another pr...

patent pivot Sep 2, 2021, 11:43 PM

#

pick a region

#

frankfurt

#

selected thanks

celest charm Sep 2, 2021, 11:44 PM

#

patent pivot because i don't want to serve images at scale from my infrastructure

joe: pydis, can we have scale?
pydis: we have scale at home
scale at home:
someone downloads a duck image once per minute

fervent sage Sep 2, 2021, 11:44 PM

#

quackstack#61 blob_pain

dusky shoreBOT Sep 2, 2021, 11:44 PM

#

GitHub

PROpen fix: use seed on the correct duck generators

patent pivot Sep 2, 2021, 11:45 PM

#

okay https://quackstack.eu-central-1.linodeobjects.com/ok-and.gif

fervent sage Sep 2, 2021, 11:45 PM

#

S3 is aioboto3 yes?

patent pivot Sep 2, 2021, 11:45 PM

#

yeah just like

#

any S3 client that you fancy

fervent sage Sep 2, 2021, 11:46 PM

#

Ok, now it should work correctly

patent pivot Sep 2, 2021, 11:46 PM

#

quackstack integration test when

fervent sage Sep 2, 2021, 11:46 PM

#

😅

celest charm Sep 2, 2021, 11:46 PM

#

patent pivot any S3 client that you fancy

~~botocore~~ nvm, i thought it only supported py2

patent pivot Sep 2, 2021, 11:46 PM

#

we generate ducks in CI and attach them as build artefacts

fervent sage Sep 2, 2021, 11:47 PM

#

@patent pivot could I have some s3 creds to test with

#

i think you mentioned in the past about that

clever wraith Sep 2, 2021, 11:48 PM

#

Rick go to bed

patent pivot Sep 2, 2021, 11:48 PM

#

yea one sec

clever wraith Sep 2, 2021, 11:49 PM

#

It's like 12am where you are

celest charm Sep 2, 2021, 11:50 PM

#

it's 3am here https://quackstack.eu-central-1.linodeobjects.com/ok-and.gif

clever wraith Sep 2, 2021, 11:50 PM

#

650 https://quackstack.eu-central-1.linodeobjects.com/ok-and.gif

celest charm Sep 2, 2021, 11:50 PM

#

i like how they both eat in sync

clever wraith Sep 2, 2021, 11:50 PM

#

Lmao

#

It loops perfectly

celest charm Sep 2, 2021, 11:51 PM

#

for some reason they autosynchronize on firefox

clever wraith Sep 2, 2021, 11:51 PM

#

That's hilarious

#

Ew he's eating ruffles

patent pivot Sep 2, 2021, 11:52 PM

#

nah, django_prometheus is inside django

#

it just adds an endpoint to django

clever wraith Sep 2, 2021, 11:53 PM

#

Oh boy

#

What's the revelation

patent pivot Sep 2, 2021, 11:53 PM

#

lol

#

updated exporters list

clever wraith Sep 2, 2021, 11:54 PM

#

@brisk belfry inb4 dpy 2.0 won't ever be released

#

Also Guinevere wasn't a sir

#

A bit unrelated joe, but when will the code jam roles be taken away

patent pivot Sep 2, 2021, 11:55 PM

#

it's named after Sir Bedevere

clever wraith Sep 2, 2021, 11:55 PM

#

Oh

#

I'm an idiot

patent pivot Sep 2, 2021, 11:55 PM

#

clever wraith <@874081689243107389> inb4 dpy 2.0 won't ever be released

lancebot is on d.py 2.0 and python will be soon too, despite it not being officially released

patent pivot Sep 2, 2021, 11:55 PM

#

clever wraith A bit unrelated joe, but when will the code jam roles be taken away

good Q

thorny obsidian Sep 2, 2021, 11:55 PM

#

Soon ™️ Waiting back on 1 more prize thing

clever wraith Sep 2, 2021, 11:55 PM

#

patent pivot lancebot is on d.py 2.0 and python will be soon too, despite it not being offici...

Oh yay lancebot can use threads

clever wraith Sep 2, 2021, 11:56 PM

#

thorny obsidian Soon ™️ Waiting back on 1 more prize thing

Ah

patent pivot Sep 2, 2021, 11:56 PM

#

lol, sure

#

what are you fixing

#

lol

#

some are

#

I'm considering moving our internal docs onto k8s

#

#

right now it's notion, but some stuff could be migrated

#

github

#

probably published through jekyll to github pages or something

#

something like https://python-discord.github.io/olli/

Olli

Olli searches your Loki logs and relays matching terms to Discord.

#

nope

#

yea

fallen patrol Sep 3, 2021, 12:20 AM

#

test

fervent sage Sep 3, 2021, 12:21 AM

#

fuck s3 and fuck boto3

#

I will now go back to trying to make it work and screaming into the void

fallen patrol Sep 3, 2021, 12:26 AM

#

my internet connection

#

lol

#

trying to review a pr and had this channel open ¯_(ツ)_/¯

#

reviewed lance 778

#

left a second review since I missed some things lol

desert vessel Sep 3, 2021, 5:19 AM

#

sirlance#778

#

sirlancebot#778

vocal wolf Sep 3, 2021, 6:31 AM

#

desert vessel sirlancebot#778

sir-lancebot#778

dusky shoreBOT Sep 3, 2021, 6:31 AM

#

GitHub

PROpen Merge automatic issue linking into the github cog

desert vessel Sep 3, 2021, 6:31 AM

#

ty <3

vocal wolf Sep 3, 2021, 6:31 AM

#

np m8

vocal wolf Sep 3, 2021, 7:42 AM

#

@clever wraith What are your plans for https://github.com/python-discord/sir-lancebot/pull/699#pullrequestreview-739158725?

reef tinsel Sep 3, 2021, 7:53 AM

#

Working on bot#1765 - completed the first part. Could I have some feedback on the message:

dusky shoreBOT Sep 3, 2021, 7:53 AM

#

GitHub

IssueOpen Shoutout our patreon supporters!

cold island Sep 3, 2021, 8:04 AM

#

My personal opinion:

Can be made equivalent to the nitro message, i.e <user> just became a tier 1 patron!
This can be posted as an embed, and then the second line can become a hyperlink.

#

Possibly with a preceding 🎉 on the first line

stable mountainBOT Sep 3, 2021, 8:13 AM

#

🎉
@cold island just became a tier 1 patron!
Support us on patreaon @ https://www.patreon.com/python_discord

cold island Sep 3, 2021, 8:14 AM

#

"patreaon"

vale ibex Sep 3, 2021, 8:14 AM

#

lol ofc spelt right tho kek

cold island Sep 3, 2021, 8:14 AM

#

And with a nice color

#

What's the patreon color

vale ibex Sep 3, 2021, 8:14 AM

#

Maybe the 🎉 in the content, rather than the embed

#

so it's bigger

vale ibex Sep 3, 2021, 8:15 AM

#

cold island What's the patreon color

we could make the colour the same as the role colour

#

I wonder if it would worth sorting out pydis.com/patreon as a link shorten

cold island Sep 3, 2021, 8:15 AM

#

seems like a good idea

vale ibex Sep 3, 2021, 8:15 AM

#

oh, it already is

cold island Sep 3, 2021, 8:15 AM

#

lol

vale ibex Sep 3, 2021, 8:15 AM

#

@patent pivot is always a step ahead

stable mountainBOT Sep 3, 2021, 8:17 AM

#

🎉 @vale ibex just became a tier 1 patron!
Support us on patreon

cold island Sep 3, 2021, 8:18 AM

#

And with a capital P

vale ibex Sep 3, 2021, 8:20 AM

#

!int e ```py
await ctx.send(
embed=discord.Embed(
title=":tada: @vale ibex just became a tier 1 patron!",
descritpion="Support us on Patreon",
colour=0x46e6e8
)
)

stable mountainBOT Sep 3, 2021, 8:20 AM

#

:tada: <@126811506632294400> just became a tier 1 patron!

vale ibex Sep 3, 2021, 8:20 AM

#

ah, no mentions in titles

#

that a bit big anyway

#

!int e ```py
await ctx.send(
content=":tada:",
embed=discord.Embed(
description="@vale ibex just became a tier 1 patron!\nSupport us on Patreon",
colour=0x46e6e8
)
)

stable mountainBOT Sep 3, 2021, 8:21 AM

#

:tada:

@vale ibex just became a tier 1 patron!
Support us on Patreon

vale ibex Sep 3, 2021, 8:21 AM

#

hmm that's a bit big

#

so yea, I think I like your suggestion more zig

reef tinsel Sep 3, 2021, 8:40 AM

#

ok!

#

also, my alternative message when someone already has a patreon role:

#

maybe something like:

@reef tinsel just changed to a tier 2 patron!

?

vale ibex Sep 3, 2021, 8:44 AM

#

Hmm, I don't think we need to deal with that

#

X just became a tier 2 patron! still works imo

reef tinsel Sep 3, 2021, 8:51 AM

#

(the colour is black because that is the colour of my tier 1 role)

vale ibex Sep 3, 2021, 8:51 AM

#

could you try it with the 🎉 on the same line as the next?

vale ibex Sep 3, 2021, 8:52 AM

#

stable mountain

like this suggeiston

reef tinsel Sep 3, 2021, 8:52 AM

#

as in without the \n before the mention?

vale ibex Sep 3, 2021, 8:52 AM

#

ye

#

(with a space tho)

#

yes

#

along with a monthly update too

#

which shows all of our current patrons

#

bot#1765 for reference

dusky shoreBOT Sep 3, 2021, 8:57 AM

#

GitHub

IssueOpen Shoutout our patreon supporters!

reef tinsel Sep 3, 2021, 9:07 AM

#

(I am sorting out something for school next week, so will do the on the next line now, but may take some time again for any other adjsutments

#

#

a comparison to the 2 locations for the 🎉

static canyon Sep 3, 2021, 9:09 AM

#

I think it looks better inline

stable mountainBOT Sep 3, 2021, 9:11 AM

#

@static canyon just became a tier 1 patron! 🎉
Support os on Patreon

static canyon Sep 3, 2021, 9:11 AM

#

And yeah it looks better with the emoji before

#

Maybe make the tier {tier} bold

stable mountainBOT Sep 3, 2021, 9:12 AM

#

🎉 @static canyon just became a tier 1 patron!
Support us on Patreon

#

🎉 @static canyon just became a Tier 1 patron!
Support us on Patreon

static canyon Sep 3, 2021, 9:13 AM

#

stable mountain

I think this one looks the best (2 messages up if the reply isn't loading for you)

#

CC @reef tinsel

vale ibex Sep 3, 2021, 9:20 AM

#

reef tinsel (I am sorting out something for school next week, so will do the on the next lin...

no problem on the time scale thing btw, we all volunteers here, so we understand that life comes first 😄 Take your time.

reef tinsel Sep 3, 2021, 9:29 AM

#

#

the last 3 revisions

#

I agree with tizzy that the last one looks the best

vale ibex Sep 3, 2021, 9:30 AM

#

yup, agreed

reef tinsel Sep 3, 2021, 9:31 AM

#

I am happy with this for now then, and will start working on the monthly post after going to the dentist!

vale ibex Sep 3, 2021, 9:33 AM

#

nice 😄

fervent sage Sep 3, 2021, 10:23 AM

#

its open to everyone

gritty wind Sep 3, 2021, 10:23 AM

#

Only contribs+ can speak

vale ibex Sep 3, 2021, 10:43 AM

#

I'm a little lost with why this test is failing, I'm not too familiar with django testing site#577

dusky shoreBOT Sep 3, 2021, 10:43 AM

#

GitHub

PROpen Timeout when fetching GitHub repository metadata

vale ibex Sep 3, 2021, 10:43 AM

#

Is this because the timeout const doesn't exist during testing?

#

or is there something I need to do to the requests mock

#

it's easier to read in the list of 100s of branches lol

molten perch Sep 3, 2021, 11:01 AM

#

Maybe it’s coverage? I can’t check the exact error, just the tasks, so I’m just guessing by reading the code.

vale ibex Sep 3, 2021, 11:07 AM

#

It's a failed test due to not returning the meta data

#

it seems to be hitting the except block and returning {}

vale ibex Sep 3, 2021, 11:46 AM

#

Ah, I've sorted the tests

dim pelican Sep 3, 2021, 11:46 AM

#

What was the issue?

vale ibex Sep 3, 2021, 11:46 AM

#

The requests mock was expecting the url to be arg[0]

#

but I was explicitly passing it as the url kwarg

dim pelican Sep 3, 2021, 11:47 AM

#

Ahh you made it too easy to test

#

"here is this keyword arg that is what you want"
"I'd rather the 0th index of a list please"

vale ibex Sep 3, 2021, 11:48 AM

#

yea, this mock is very specific to the particular part I edited, so I'm just going to put it back as arg[0]

dim pelican Sep 3, 2021, 11:52 AM

#

For little guys like me, what are the most helpful things to tackle? I've done two things for sir-lance but haven't touched on the bot or site yet

vale ibex Sep 3, 2021, 11:53 AM

#

setting up the bot is a bit of a chore right now, so expect to spend a bit of time on that

#

We provide a template server in the contrib guides, but even then setting up all the channel, role and webhook ids in the config can take a while

#

but there are a bunch of issues on the repos if you're looking for something to do

austere hornet Sep 3, 2021, 12:20 PM

#

You can talk cuz you are a contributor

reef tinsel Sep 3, 2021, 1:40 PM

#

Hi! Does anyone have any good ideas for testing bot#1765 part 2 (monthly message)?

By this I mean, I cannot test how it will handle going over embed limits in my guild of 2 members?

dusky shoreBOT Sep 3, 2021, 1:40 PM

#

GitHub

IssueOpen Shoutout our patreon supporters!

vale ibex Sep 3, 2021, 1:43 PM

#

make 3 lists of names and output those, instead of role.members

#

If you just want to test it looks right

#

Right now, we also have no tier 3 patrons, so that list shouldn't appear at all

#

rather than showing a title with no one under it

reef tinsel Sep 3, 2021, 1:44 PM

#

ok

#

i will probably start by just having a title with no-one under it, to simplify the code to make it easier to debug

vale ibex Sep 3, 2021, 1:45 PM

#

sure

#

fwiw, I would use Embed.add_field

#

to add the lists

#

and then just not add the field if there is no one with that role

#

like ```py
embed = discord.Embed(
title="Mothly Patreon update!",
description="Big thank you to this months patrons!\nSupport us on Patreon",
colour=some_colour
)
if patreon_role_1.members:
embed.add_field(name, value)
if patreon_role_2.members:
embed.add_field(name, value)
if patreon_role_3.members:
embed.add_field(name, value)
await ctx.send(embed=embed)

#

ofc this is super simplified

brisk brook Sep 3, 2021, 1:52 PM

#

Plus- this may exhaust the embed limits

vale ibex Sep 3, 2021, 1:53 PM

#

possibly, the limit is 4k right?

fervent sage Sep 3, 2021, 1:53 PM

#

4096 in description, 6k overall

#

1024 in fields

reef tinsel Sep 3, 2021, 1:54 PM

#

brisk brook Plus- this may exhaust the embed limits

yes, thats why I need to be careful

#

is a mention worth the number of chars in id + 3 (<, @, >) or another number of chars?

#

ie, is it worth 19 chars or another number

gritty wind Sep 3, 2021, 1:55 PM

#

I feel like it’d be easier to just swallow the bullet now and add splitting

#

I’d like the mentions personally

vale ibex Sep 3, 2021, 1:55 PM

#

we could send 3 embeds

#

one for each tier

reef tinsel Sep 3, 2021, 1:55 PM

#

we could

vale ibex Sep 3, 2021, 1:55 PM

#

When we bump to 2.0 we can send them all in one msg too

brisk brook Sep 3, 2021, 1:56 PM

#

How?

reef tinsel Sep 3, 2021, 1:56 PM

#

i was going to do some calcs to work out the columns, but it would be a lot easier on the code to do separate embeds!

reef tinsel Sep 3, 2021, 1:56 PM

#

brisk brook How?

up to 10 embeds in a message

vale ibex Sep 3, 2021, 1:57 PM

#

yea, api v9 (maybe added in v8 shrugR ) supports up to 10 embeds per msg

#

discord.py 2.0 exposes this with an embeds kwarg on Messageable.send

#

which is a list of embeds

fervent sage Sep 3, 2021, 1:59 PM

#

vale ibex yea, api v9 (maybe added in v8 <:shrugR:727587457046151301> ) supports up to 10 ...

yep, v9

reef tinsel Sep 3, 2021, 2:00 PM

#

for this line continuation, how should I do the indentation/brackets? like this, or something else?

vale ibex Sep 3, 2021, 2:01 PM

#

message = (
    f"some content "
    f"some other content"
)

#

that's how I usually do it

reef tinsel Sep 3, 2021, 2:01 PM

#

ok

slim widget Sep 3, 2021, 2:01 PM

#

Any PRs/issues I can work on? Need something to do.

vale ibex Sep 3, 2021, 2:03 PM

#

uhhh possibly

#

might be worth asking joe in #dev-black-knight

#

since there might be some useful things to be done there

brazen charm Sep 3, 2021, 2:05 PM

#

Could also use a third opinion on some of the unresolved conversations in bot#1663

dusky shoreBOT Sep 3, 2021, 2:05 PM

#

GitHub

PROpen Add tag groups and in file metadata

elder belfry Sep 3, 2021, 2:07 PM

#

Hey @dim pelican Can I partner with you on sir-lancebot#677 pithink

dusky shoreBOT Sep 3, 2021, 2:07 PM

#

GitHub

IssueOpen Create a colo[u]r command

dim pelican Sep 3, 2021, 2:07 PM

#

slim widget Any PRs/issues I can work on? Need something to do.

I have a random collection of things if you want to take a look

sir-lancebot#833 should almost be good to go
I had an open question on whether or not sir-lancebot#834 was in the right place
site#574 might be a helpful thing as well

dusky shoreBOT Sep 3, 2021, 2:07 PM

#

GitHub

PROpen Teapot support - Continues PR #610
IssueOpen Add .gitmessage to allow for consistent commit messages
Add more details on how to start / reload a bot during testing

dim pelican Sep 3, 2021, 2:07 PM

#

elder belfry Hey <@!698273827448291379> Can I partner with you on sir-lancebot#677 <:pithink:...

Sure thing!

elder belfry Sep 3, 2021, 2:08 PM

#

dim pelican Sure thing!

lemon_hyperpleased

gritty wind Sep 3, 2021, 2:24 PM

#

Chris you’ve gotta add the reactions for us😔

#

I can never find that confetti cannon one

vale ibex Sep 3, 2021, 2:24 PM

#

lol

dim pelican Sep 3, 2021, 2:24 PM

#

Lol right? I was going crazy for a second :\tada:\

#

So there are a total of 10 contributors?

gritty wind Sep 3, 2021, 2:25 PM

#

There are ~10 non helper contributors

#

!role Contributor

stable mountainBOT Sep 3, 2021, 2:25 PM

#

Contributors info

ID

295488872404484098

Colour (RGB)

#55cc6c

Colour (HSV)

0.37 0.58 204

Member count

43

Position

12

Permission code

6442450944

gritty wind Sep 3, 2021, 2:25 PM

#

43 in total

dim pelican Sep 3, 2021, 2:26 PM

#

Ahh I see, dang that seems like a rare role to get

vale ibex Sep 3, 2021, 2:27 PM

#

There's definitely rarer ones lol

#

There's a bunch with just 1 member

#

some with 0 too lol

#

super rare

gritty wind Sep 3, 2021, 2:27 PM

#

Aren’t those all patreon colors 🤡

vale ibex Sep 3, 2021, 2:28 PM

#

lol, out of the 3 with 0, tier 3 patreon is one of them

gritty wind Sep 3, 2021, 2:28 PM

#

Ohh no some pretty cool ones

fervent sage Sep 3, 2021, 2:29 PM

#

I should totally be given a role called 'Too Many Sideprojects' KEKW

dim pelican Sep 3, 2021, 2:30 PM

#

One day maybe I will have a colorful username

thorny obsidian Sep 3, 2021, 2:31 PM

#

Smh Chris, copying my badly phrased "what I think a core dev is" =P

vale ibex Sep 3, 2021, 2:31 PM

#

lol yup

#

none of the work, all the credit

#

😄

thorny obsidian Sep 3, 2021, 2:35 PM

#

Also congrats to the new contribs! Very well deserved :D

short snow Sep 3, 2021, 2:35 PM

#

congrats new contribs

#

I SEE SOMETHING BAD https://github.com/python-discord/bot/pull/1791/files

#

thorny obsidian Sep 3, 2021, 2:38 PM

#

If someone wants something to work on that I can guarantee will be used this year and will be greatly appreciated by me if this is implemented: sir-lancebot#321

dusky shoreBOT Sep 3, 2021, 2:38 PM

#

GitHub

IssueOpen AoC: Leaderboard per star

short snow Sep 3, 2021, 2:40 PM

#

If anyone has got sometime, needs one more approval:
https://github.com/python-discord/sir-lancebot/pull/618

molten perch Sep 3, 2021, 2:46 PM

#

thorny obsidian If someone wants something to work on that I can guarantee will be used this yea...

I'd be glad to implement this, however I need some time to familiarise myself with AoC first, if it's not a problem. (Haven't really participated before.)

thorny obsidian Sep 3, 2021, 2:47 PM

#

molten perch I'd be glad to implement this, however I need some time to familiarise myself w...

I would ultra appreciate this :D
And that's totially fine, this feature doesn't need to be available until Dec 1 anyhow~

If you have any questions about it or want me to explain it and get you sample data let me know

brisk brook Sep 3, 2021, 2:47 PM

#

gritty wind I can never find that confetti cannon one

It's called tada

clever wraith Sep 3, 2021, 2:50 PM

#

Thanks everyone! Congratulations Wookie and the others lemon_pleased

clever wraith Sep 3, 2021, 2:50 PM

#

short snow

What about it?

thorny obsidian Sep 3, 2021, 2:51 PM

#

Qwerty you're the mod QoL fixer.
You: Why does this interface suck for mods?
Mods: I dunno, it's always been like that. Would be nice if it wasn't.
You: Well I fixed it!
Mods: :O

short snow Sep 3, 2021, 2:55 PM

#

Doesn't follow the pydis style guide, isn't mentioned as an example there, but you get the idea about the brackets on a new line, see: https://pythondiscord.com/pages/guides/pydis-guides/contributing/style-guide/#bracket-and-item-arrangement

Python Discord - Style Guide

Coding conventions for our Open Source projects.

slim widget Sep 3, 2021, 2:58 PM

#

vale ibex since there might be some useful things to be done there

Oh yeah, I totally forgot I said I'd help with that 👀 I think when I first looked at it, it all went a bit over my head.

thorny obsidian Sep 3, 2021, 2:59 PM

#

@molten perch So I'm going to go ahead and explain, broadly, AoC and specifically how we implement multiple leaderboards.
Advent of Code is a a Programming Challenge Advent Calendar. Each day, starting on Dec 1, for 25 (I think) days, a challenge is released. People are given input data, they must solve the challenge, and then submit their result. It starts off pretty alright and then quickly gets more difficult. There are also 2 parts to each challenge. So a total of 48 or 50 challenges to solve.

There is a global AoC leaderboard, which ranks people based on how many Stars (challenges completed) and how quickly they get the stars. The global leaderboard is very, very competitive.

The community can also create their own private leaderboards to compete against friends and coworkers. These are limited to 200 people per leaderboard. This is what we use. But, because of our community's size, we actually need to have multiple leaderboards. So last year, Seb had to rewrite our whole codebase for AoC to accommodate multiple leaderboards. We query each leaderboard, record in Redis the user ID, which days they completed, and how many stars they got on that day, and how quickly they got those stars.

From there, we re-rank the whole dataset and rescore to create our own PyDis Mega Leaderboard. So for the per-day AoC stats, this is actually the data you want to use. It just requires from thinking and shuffling and scoring, per-day to do so. It's also probably smart to store the day's results in some sort of cache so the computation doesn't have to be continually re-run.

... so that's my thoughts on it.

#

To help test the feature I can get you access to last year's multiple leaderboards with the cookie session tokens so you can query it directly yourself

molten perch Sep 3, 2021, 3:04 PM

#

thorny obsidian <@!263957159807549450> So I'm going to go ahead and explain, broadly, AoC and sp...

Thank you for the explanation!

molten perch Sep 3, 2021, 3:04 PM

#

thorny obsidian To help test the feature I can get you access to last year's multiple leaderboar...

That'd be really helpful, thank you! 🙂

dim pelican Sep 3, 2021, 3:05 PM

#

elder belfry <:lemon_hyperpleased:754441879822663811>

Hey what is your github user name? I'm going to give you access to my fork. I'm working on branch color-677 for this

elder belfry Sep 3, 2021, 3:05 PM

#

dim pelican Hey what is your github user name? I'm going to give you access to my fork. I'm ...

it's CyberCitizen01

elder belfry Sep 3, 2021, 3:07 PM

#

dim pelican Hey what is your github user name? I'm going to give you access to my fork. I'm ...

umm hey btw do we have to wait until the issue is assigned or it doesn't matter..

dim pelican Sep 3, 2021, 3:07 PM

#

elder belfry umm hey btw do we have to wait until the issue is assigned or it doesn't matter....

I'm probably jumping the gun a bit

thorny obsidian Sep 3, 2021, 3:08 PM

#

I'll assign y'all now~

#

@elder belfry can you also comment on the issue so I can assign you to it as well?

elder belfry Sep 3, 2021, 3:09 PM

#

thorny obsidian <@!785193141971451974> can you also comment on the issue so I can assign you to ...

okay i'll do it in just a min

thorny obsidian Sep 3, 2021, 3:11 PM

#

happy coding y'all~

#

... I should stop procrastinating and actually work >_>

dim pelican Sep 3, 2021, 3:12 PM

#

Woo! Fastest assignor in the west

thorny obsidian Sep 3, 2021, 3:12 PM

#

Also, I'm going to do a major restructure of lance's ext tomorrow evening. So either aim to have the PR merged by then or plan to have a gnarly conflict to resolve

dim pelican Sep 3, 2021, 3:13 PM

#

thorny obsidian Also, I'm going to do a major restructure of lance's ext tomorrow evening. So ei...

Definitely going to be the latter

thorny obsidian Sep 3, 2021, 3:14 PM

#

@patent pivot (and also others who know reviewbot well, fuck it @vale ibex you too)
Can we have wookie's core dev vote count retro-actively for like... the past 3 days or nah?

vale ibex Sep 3, 2021, 3:15 PM

#

you can click the details button next to policy bot for it to reevaluate

thorny obsidian Sep 3, 2021, 3:15 PM

#

I don't think I have that power anymore

#

looking specifically at sir-lancebot/833

vale ibex Sep 3, 2021, 3:15 PM

#

uhhhh, it's github oauth so I think any staff can

#

sir-lancebot#833

dusky shoreBOT Sep 3, 2021, 3:16 PM

#

GitHub

PROpen Teapot support - Continues PR #610

vale ibex Sep 3, 2021, 3:16 PM

#

ah, joe hasn't added wookie to core dev team yet

#

(joe/owners I mean)

#

The act of opening this page reevaluates

thorny obsidian Sep 3, 2021, 3:16 PM

#

ooooh

#

okay, I wasn't sure if there was something else I was supposed to do

austere hornet Sep 3, 2021, 3:17 PM

#

Wait he is a core dev now

thorny obsidian Sep 3, 2021, 3:17 PM

#

My aim is to help merge as many open lance PRs as I can before I do the exts/ restructure

vale ibex Sep 3, 2021, 3:17 PM

#

yea, there's a team in github that deals with the policy bot stuff

vale ibex Sep 3, 2021, 3:17 PM

#

thorny obsidian My aim is to help merge as many open lance PRs as I can before I do the exts/ re...

good idea

#

<@&267627879762755584> Could someone add wookie to https://github.com/orgs/python-discord/teams/core-developers

austere hornet Sep 3, 2021, 3:18 PM

#

@vale ibex He is already added

vale ibex Sep 3, 2021, 3:19 PM

#

austere hornet <@!126811506632294400> He is already added

that's their discord role

#

I added that

fervent sage Sep 3, 2021, 3:19 PM

#

discord roles != github

austere hornet Sep 3, 2021, 3:19 PM

#

Ohhh sorry I didn't know mb

dim pelican Sep 3, 2021, 3:21 PM

#

General question: should I open a PR with an empty file and then build it out in collaboration or wait until there is a full file ready to go?

vale ibex Sep 3, 2021, 3:21 PM

#

feel free to open a draft PR

#

whatever works best for your collab

dim pelican Sep 3, 2021, 3:23 PM

#

Thanks!

thorny obsidian Sep 3, 2021, 3:24 PM

#

Okay, PRs I'm going to try to help move along this weekend:

Teapot
Wikiguess
unloaded cogs preservation (I'll try my best for this one but no promises)

vale ibex Sep 3, 2021, 3:24 PM

#

fwiw a draft PR is a special type of PR, it marks it as not ready for review, it's useful for people to see it's not ready

#

when you're creating a PR, there is an arrow next to the create PR button, you can click that to select draft PR instead

short snow Sep 3, 2021, 3:24 PM

#

both my PRs on lance, akarys_heart

vale ibex Sep 3, 2021, 3:25 PM

#

or you can click this button to convert an open PR into a draft

thorny obsidian Sep 3, 2021, 3:25 PM

#

I'd appreciate a core dev review on sir-lancebot#745 since I think kosa is still busy with hella life stuff

dusky shoreBOT Sep 3, 2021, 3:25 PM

#

GitHub

PROpen Add logic for preserving unloaded Cogs.

dim pelican Sep 3, 2021, 3:26 PM

#

vale ibex when you're creating a PR, there is an arrow next to the create PR button, you c...

Whoops! Gonna have to fix that after lunch

short snow Sep 3, 2021, 3:27 PM

#

Also kat I won't be able to mention the changes as of now due to school stuff atleast for 2 weeks, after that I can

#

so you could review some other PRs too if ou want

#

(unless they are a approval) lol

thorny obsidian Sep 3, 2021, 3:28 PM

#

That's fine~ If they're ready though without major changes I'll do my best to get them merged to avoid an annoying conflict

short snow Sep 3, 2021, 3:29 PM

#

👍

austere hornet Sep 3, 2021, 3:32 PM

#

Just curious, what do these messages mean exactly? #dev-log message

brazen charm Sep 3, 2021, 3:33 PM

#

the bot reconnected after it was deployed

austere hornet Sep 3, 2021, 3:33 PM

#

brazen charm the bot reconnected after it was deployed

Ohhh I see now

thorny obsidian Sep 3, 2021, 3:33 PM

#

When we merge PRs, we re-deploy the bot so it has those new features. That's just letting us know when it's back online

austere hornet Sep 3, 2021, 3:33 PM

#

thorny obsidian When we merge PRs, we re-deploy the bot so it has those new features. That's jus...

Ahh I see now

#

Thanks

clever wraith Sep 3, 2021, 3:37 PM

#

@cold island re:https://github.com/python-discord/bot/issues/1757 which endpoint would that be? I only see endpoints which accept a snowflake (GET /bot/users/snowflake)

GitHub

Fallback to site DB on searches by username · Issue #1757 · python-...

We sometimes need to query user data such as the user or infractions embed, when all we have is the username. Since the site DB stores user ID's and usernames, and already has an endpoint t...

keen valley Sep 3, 2021, 3:42 PM

#

I am getting a Error, while configuring sir-lance

(sir-lancebot-e4XN2zlu-py3.9) PS M:\ADMIN\Critical Data\Python-discord\sir-lancebot> poetry run task start
Found .env file, loading environment variables from it.
09/03/21 21:10:03 - root INFO: Logging initialization complete
Traceback (most recent call last):
  File "c:\python39\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "M:\ADMIN\Critical Data\Python-discord\sir-lancebot\bot\__main__.py", line 7, in <module>
    from bot.bot import bot
  File "M:\ADMIN\Critical Data\Python-discord\sir-lancebot\bot\bot.py", line 202, in <module>
    loop.run_until_complete(redis_session.connect())
  File "c:\python39\lib\asyncio\base_events.py", line 642, in run_until_complete
    return future.result()
  File "C:\Users\ADMIN\AppData\Local\pypoetry\Cache\virtualenvs\sir-lancebot-e4XN2zlu-py3.9\lib\site-packages\async_rediscache\session.py", line 138, in connect
    self._pool = await pool_constructor
  File "C:\Users\ADMIN\AppData\Local\pypoetry\Cache\virtualenvs\sir-lancebot-e4XN2zlu-py3.9\lib\site-packages\aioredis\commands\__init__.py", line 188, in create_redis_pool
    pool = await create_pool(address, db=db,
  File "C:\Users\ADMIN\AppData\Local\pypoetry\Cache\virtualenvs\sir-lancebot-e4XN2zlu-py3.9\lib\site-packages\aioredis\pool.py", line 58, in create_pool    
    await pool._fill_free(override_min=False)
  File "C:\Users\ADMIN\AppData\Local\pypoetry\Cache\virtualenvs\sir-lancebot-e4XN2zlu-py3.9\lib\site-packages\aioredis\pool.py", line 383, in _fill_free    
    conn = await self._create_new_connection(self._address)
  File "C:\Users\ADMIN\AppData\Local\pypoetry\Cache\virtualenvs\sir-lancebot-e4XN2zlu-py3.9\lib\site-packages\aioredis\connection.py", line 111, in create_connection
    reader, writer = await asyncio.wait_for(open_connection(
  File "c:\python39\lib\asyncio\tasks.py", line 442, in wait_for
    return await fut
  File "C:\Users\ADMIN\AppData\Local\pypoetry\Cache\virtualenvs\sir-lancebot-e4XN2zlu-py3.9\lib\site-packages\aioredis\stream.py", line 23, in open_connection
    transport, _ = await get_event_loop().create_connection(
  File "c:\python39\lib\asyncio\base_events.py", line 1017, in create_connection
    infos = await self._ensure_resolved(
  File "c:\python39\lib\asyncio\base_events.py", line 1396, in _ensure_resolved
    return await loop.getaddrinfo(host, port, family=family, type=type,
  File "c:\python39\lib\asyncio\base_events.py", line 856, in getaddrinfo
    return await self.run_in_executor(
  File "c:\python39\lib\concurrent\futures\thread.py", line 52, in run
    result = self.fn(*self.args, **self.kwargs)
  File "c:\python39\lib\socket.py", line 953, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno 11001] getaddrinfo failed

#

What should I do?

brazen charm Sep 3, 2021, 3:43 PM

#

Either run redis or set the env var (name should be somewhere in the contributing guide) to false

keen valley Sep 3, 2021, 3:45 PM

#

https://pythondiscord.com/pages/guides/pydis-guides/contributing/sir-lancebot/env-var-reference/#debug-variables

Python Discord - Sir-Lancebot Environment Variable Reference

The full environment variable reference for Sir-Lancebot.

#

In this
which one should I keep False?

brazen charm Sep 3, 2021, 3:46 PM

#

set USE_FAKEREDIS to true

cold island Sep 3, 2021, 3:47 PM

#

clever wraith <@!512354988157173763> re:https://github.com/python-discord/bot/issues/1757 whic...

lemme check

keen valley Sep 3, 2021, 3:48 PM

#

brazen charm set USE_FAKEREDIS to true

That's Work
Thank you!

brazen charm Sep 3, 2021, 3:48 PM

#

I believe the viewset will need to be changed

vale ibex Sep 3, 2021, 3:50 PM

#

site#577 is a nice simple one to test if someone wants to review it

dusky shoreBOT Sep 3, 2021, 3:50 PM

#

GitHub

PROpen Timeout when fetching GitHub repository metadata

vale ibex Sep 3, 2021, 3:50 PM

#

this fixes an issue that causes a worker to go unresponsive and abort

cold island Sep 3, 2021, 3:57 PM

#

clever wraith <@!512354988157173763> re:https://github.com/python-discord/bot/issues/1757 whic...

Hmm yeah I don't see anything in https://github.com/python-discord/site/blob/main/pydis_site/apps/api/viewsets/bot/user.py so it might need to be added

viscid coral Sep 3, 2021, 4:08 PM

#

#

Maybe enable it for help channles?

trail pilot Sep 3, 2021, 5:09 PM

#

Could I get assigned this issue sir-lancebot#599

It’s been up for grabs and I don’t think anyone has interest in getting assigned that issue

dusky shoreBOT Sep 3, 2021, 5:09 PM

#

GitHub

IssueOpen Hangman Game Command

static canyon Sep 3, 2021, 5:13 PM

#

bot.bot.Bot inherits commands.Bot
commands.Bot inherits discord.Client
discord.Client has a http attribute.

Mypy raises an error when you do bot.http, stating error: "Bot" has no attribute "http" even though it exists (in the superclass' superclass). Does anyone know how to fix this?

static canyon Sep 3, 2021, 5:18 PM

#

static canyon `bot.bot.Bot` inherits `commands.Bot` `commands.Bot` inherits `discord.Client` `...

It doesn't seem to be inheritance that's the issue, since the following works fine:```py
class Ham:
x = 1

class Spam(Ham):
pass

class Foo(Spam):
pass

class Bar(Foo):
pass

b = Bar()
print(b.x)

austere hornet Sep 3, 2021, 5:18 PM

#

Don't think this is the right channel for that

hazy niche Sep 3, 2021, 5:18 PM

#

austere hornet Don't think this is the right channel for that

am just new here, not sure where shall i share projects for showcases

static canyon Sep 3, 2021, 5:19 PM

#

hazy niche am just new here, not sure where shall i share projects for showcases

We don't ~~allow showcasing of projects~~ have a channel dedicated to showcasing projects anymore. We used to, but it became too much of a moderation burden with people sharing forkbombs etc.

hazy niche Sep 3, 2021, 5:19 PM

#

oh, thanks i got it, will take it down for sure

#

thanks for the advice

static canyon Sep 3, 2021, 5:20 PM

#

That's not strictly true actually, you can still share in an off-topic channel as long as the project doesn't violate any of our rules (namely rule 5) and you're not just "advertising" it, but asking for feedback etc.

clever wraith Sep 3, 2021, 5:21 PM

#

cold island Hmm yeah I don't see anything in https://github.com/python-discord/site/blob/mai...

I'll open an issue for it then, it seems like there's no way to fetch that info from a username currently and we'd need to add something like this:

    @action(
        detail=False,
        methods=["GET"],
        url_path=r"username/(?P<name>[^#]{,32})#(?P<discriminator>[0-9]{4})"
    )
    def get_by_username(self, request, name, discriminator):
        user = get_object_or_404(User, name=name, discriminator=discriminator)
        return Response(UserSerializer(user).data, status=status.HTTP_200_OK)

This allows for GET bot/users/username/Qwerty#0001 but this is just what I came up with an hour of tinkering around and having no prior experience in Django, so there's probably a better way

static canyon Sep 3, 2021, 5:29 PM

#

class Spam():
    x = 1

class Foo(Spam):
    pass

class Bar(Foo):
    pass


b = Bar()
print(b.x)```this code works just fine with mypy (and Pycharm) but for some reason `bot.http` gives an error saying `"Bot" has no attribute "http"`, where:
`bot.bot.Bot` inherits `commands.Bot`
`commands.Bot` inherits `discord.Client`
`discord.Client` has a `http` attribute.

Does anyone have any idea as to how to fix this?.

#

So it seems to stem down to the fact that neither Pycharm nor mypy recognises that discord.Client has a http attribute.

#

class Client:
    r"""
    ...
    Attributes
    -----------
    ws
        The websocket gateway the client is currently connected to. Could be ``None``.
    loop: :class:`asyncio.AbstractEventLoop`
        The event loop that the client uses for HTTP requests and websocket operations.
    """
    def __init__(self, *, loop=None, **options):
        ...
        self.http = HTTPClient(connector, proxy=proxy, proxy_auth=proxy_auth, unsync_clock=unsync_clock, loop=self.loop)
        ...```why doesn't mypy/pycharm recognise that `Client().http` is valid?

#

So apparently the stubs are missing it

#

Which is why it doesn't work

brazen charm Sep 3, 2021, 5:43 PM

#

Doesn't seem like a good idea to rely on stubs that don't properly reflect the current interface of the library

static canyon Sep 3, 2021, 5:44 PM

#

I added to the stubs and now it works perfectly

#

Tbf the stubs are still updated, I guess they just missed one?

#

I've made a PR to the library so maybe it'll get merged 🤷

fallen patrol Sep 3, 2021, 5:54 PM

#

which library

brazen charm Sep 3, 2021, 5:55 PM

#

How active is the development on what you're using? My main concern here is that if there's a larger mistake like that then I'd expect more smaller for example from changing signatures

static canyon Sep 3, 2021, 5:57 PM

#

fallen patrol which library

https://github.com/bryanforbes/discord.py-stubs/pull/108

static canyon Sep 3, 2021, 5:57 PM

#

brazen charm How active is the development on what you're using? My main concern here is that...

I mean discord.py is no longer getting updated (read-only repo) so there won't be any new missing items

#

It's just anything that's already missing, such as discord.Client().http

fallen patrol Sep 3, 2021, 5:59 PM

#

static canyon I mean discord.py is no longer getting updated (read-only repo) so there won't b...

is this on lance or bot?

fallen patrol Sep 3, 2021, 5:59 PM

#

static canyon I added to the stubs and now it works perfectly

er, i mean this to reply

static canyon Sep 3, 2021, 5:59 PM

#

fallen patrol is this on lance or bot?

Locally for bot

#

You can't actually edit site-packages for the bots (files aren't tracked)

fallen patrol Sep 3, 2021, 5:59 PM

#

ah, for bot

#

so, v2 is supposed to be entirely type hinted

static canyon Sep 3, 2021, 6:00 PM

#

v2 is never coming though

fallen patrol Sep 3, 2021, 6:00 PM

#

which means if wait until bot is updated to v2 99% of the typing stubs for bot shall be gone

fallen patrol Sep 3, 2021, 6:00 PM

#

static canyon v2 is never coming though

you know that @dusky shore is on v2 now, right?

static canyon Sep 3, 2021, 6:00 PM

#

Well, it's not v2

#

It's a beta v2

fallen patrol Sep 3, 2021, 6:01 PM

#

semantics... not like I'm always gonna call it beta v2

#

brazen charm Sep 3, 2021, 6:02 PM

#

is the non stable fully typed or only partially as it was being written?

vale ibex Sep 3, 2021, 6:04 PM

#

I haven't encountered anything missing type hints while I've been using it

fallen patrol Sep 3, 2021, 6:04 PM

#

fallen patrol Sep 3, 2021, 6:09 PM

#

static canyon v2 is never coming though

When bot is upgraded to the currently workable state of discord.py v2.0.0a (which while it is discontinued, has no major notable bugs), the library is almost entirely typehinted, which means that you don't have to worry about client.http being typed and needing stubs. If you wait, it will be less work to add whatever you're adding to bot.

static canyon Sep 3, 2021, 6:12 PM

#

Hmm I mean it just removes the need for a single dependency

#

And I don't need to add this stub

vale ibex Sep 3, 2021, 6:14 PM

#

for context, we're planning to upgrade the bot this weekend/next

#

since lancebot hasn't had any issues so far

static canyon Sep 3, 2021, 6:15 PM

#

Yeah

#

I suppose I'll just have it locally

fallen patrol Sep 3, 2021, 6:19 PM

#

vale ibex for context, we're planning to upgrade the bot this weekend/next

huh, when you upgrade, you can probably change !snf to type hinted with Object

#

because discord.Object has a converter in 2.0

vale ibex Sep 3, 2021, 6:19 PM

#

Nice

#

I imagine in the PR that we upgrade we will just fix the breaking changes

#

but there is going to be plenty to upgrade over time 😄

fallen patrol Sep 3, 2021, 6:20 PM

#

yeah

#

I have a personal bot which translated: is sir-lance and bot melded together with the best usable commands between the two of them

#

vale ibex Sep 3, 2021, 6:20 PM

#

but yea, hadn't seen that converter yet, it's good to know 😄

fallen patrol Sep 3, 2021, 6:21 PM

#

No, I'm not hiding where the sources of this bot are 😄

vale ibex Sep 3, 2021, 6:21 PM

#

lol

fallen patrol Sep 3, 2021, 6:21 PM

#

but its extremely useful to have a meld of bot and lance

#

specifically pypi, pep, and the github commands

vale ibex Sep 3, 2021, 6:22 PM

#

Ah cool 😄

fallen patrol Sep 3, 2021, 6:22 PM

#

yeppp

clever wraith Sep 3, 2021, 6:27 PM

#

vocal wolf <@456226577798135808> What are your plans for <https://github.com/python-discord...

I'm on vacation, I'll get to this Sunday-ish

#

@fervent sage thanks for seeding ducks! Tested, works great

#

I'll get to .quack soon

stable mountainBOT Sep 3, 2021, 6:28 PM

#

Quack quack

clever wraith Sep 3, 2021, 6:29 PM

#

Lol Ty python

dim pelican Sep 3, 2021, 6:32 PM

#

Question, is it possible to temporarily ignore the pre-commit checks while working on a draft file? I am assuming I will be committing a bunch while the file is worked on between me and another, and I like to use # TODO tags which the flake8 catches.

austere hornet Sep 3, 2021, 6:32 PM

#

stable mountain Quack quack

Lmao

dim pelican Sep 3, 2021, 6:32 PM

#

*Once the file is more workable I would probably squash the commits prior to review

brisk brook Sep 3, 2021, 6:32 PM

#

The answer is no,

#

You'll have to do # TODO: XYZ # noqa

dim pelican Sep 3, 2021, 6:33 PM

#

Just add # noqa at the end?

vale ibex Sep 3, 2021, 6:34 PM

#

you can add --no-verify to your commit

#

pretty sure that skips pre-commit too

dim pelican Sep 3, 2021, 6:36 PM

#

vale ibex you can add --no-verify to your commit

This worked, thanks!

vale ibex Sep 3, 2021, 6:38 PM

#

you can do poetry run task lint to lint everything

#

since pre-commit won't pick up the things you skipped now

clever wraith Sep 3, 2021, 6:45 PM

#

brisk brook You'll have to do `# TODO: XYZ # noqa`

Doesn't noqa fail precommit

brisk brook Sep 3, 2021, 6:45 PM

#

Oh right, you need to specify a specific error too?

clever wraith Sep 3, 2021, 6:45 PM

#

Yeah

#

It'll fail the blanket noqa

dim pelican Sep 3, 2021, 6:53 PM

#

I get the T000 and F401 errors
(Todo note found and imported but not used)
Would I then do #noqa: T000 on the lines with the Todo note?

brazen charm Sep 3, 2021, 6:56 PM

#

why are todos checked

dim pelican Sep 3, 2021, 6:57 PM

#

¯_(ツ)_/¯
Also, the #noqa: T000 at the end of the comment does not suppress the error

clever wraith Sep 3, 2021, 6:58 PM

#

Hey @fervent sage, noticed a visual bug with some quackstack duck I generated

fallen patrol Sep 3, 2021, 7:05 PM

#

vale ibex you can add --no-verify to your commit

erp-

#

don't do that

#

do not do that 🥺

#

SKIP=flake8 git commit

dim pelican Sep 3, 2021, 7:05 PM

#

fallen patrol `SKIP=flake8 git commit`

oh

fallen patrol Sep 3, 2021, 7:06 PM

#

setting the SKIP variable will skip that hook

#

meaning that you don't need to skip all of the hooks, just that hook in particular

vale ibex Sep 3, 2021, 7:06 PM

#

not in windows 😦

dim pelican Sep 3, 2021, 7:06 PM

#

vale ibex not in windows 😦

oh

fallen patrol Sep 3, 2021, 7:08 PM

#

sets up venv on windows

#

sigh, this is gonna take some time to test pre-commit

vale ibex Sep 3, 2021, 7:09 PM

#

PS C:\Users\Chris\src\sir-lancebot> SKIP=flake8 git commit
SKIP=flake8: The term 'SKIP=flake8' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

fallen patrol Sep 3, 2021, 7:09 PM

#

yeah that's a you problem i think

#

I've gotten it to work b4

vale ibex Sep 3, 2021, 7:10 PM

#

you'd ned to do ```
$env:SKIP='flake8'; git commit

fallen patrol Sep 3, 2021, 7:10 PM

#

hurm...

vale ibex Sep 3, 2021, 7:10 PM

#

at least on powershell

fallen patrol Sep 3, 2021, 7:10 PM

#

what's your ps version

vale ibex Sep 3, 2021, 7:10 PM

#

7.1.4

fallen patrol Sep 3, 2021, 7:10 PM

#

oh good, not a 5 user

vale ibex Sep 3, 2021, 7:10 PM

#

hah ye

fallen patrol Sep 3, 2021, 7:11 PM

#

I've configured 5 to look like this

#

old and outdated, so I know instantly if I'm using it

#

huh, oops

#

and aside

#

this just helped me find a problem with my pre-commit config

#

tldr Mixed line ending on windows goes boom

vale ibex Sep 3, 2021, 7:13 PM

#

lol yup

fallen patrol Sep 3, 2021, 7:13 PM

#

vale ibex you'd ned to do ``` $env:SKIP='flake8'; git commit ```

yeah 😦

#

pretty sure on windows tho git actually saves them as one and converts them b4 commiting but idr

vale ibex Sep 3, 2021, 7:14 PM

#

I just have autocrlf = input in my global git conf

#

it just works

fallen patrol Sep 3, 2021, 7:15 PM

#

where

#

what's the cmd

vale ibex Sep 3, 2021, 7:15 PM

#

git config --global core.autoclrf "input"

#

from memory

#

so yea if it doesn't work, don't blame me

#

kek

austere hornet Sep 3, 2021, 7:19 PM

#

@vale ibex Would you mind taking a look at #dev-contrib message ? I am planning to work with Frontogenesis on that issue but nobody has assigned it to him yet. Could you please assign the issue to him? Thanks so much! (His username is Shom770)

vale ibex Sep 3, 2021, 7:20 PM

#

Done 👌

austere hornet Sep 3, 2021, 7:20 PM

#

vale ibex Done 👌

Thanks!

fallen patrol Sep 3, 2021, 7:22 PM

#

vale ibex git config --global core.autoclrf "input"

ran this, my computer is now firing cls at me send help

#

hm, chris, can I report an easy way to get around filters to your dms?

vale ibex Sep 3, 2021, 7:22 PM

#

probably best to @slow bone

fallen patrol Sep 3, 2021, 7:23 PM

#

eh.. it involves the 2.0 update

#

so not terribly important, but will be easy in the future

vale ibex Sep 3, 2021, 7:23 PM

#

Sure, it likely won't be me who does the update, but the mods can relay the concerns to the core devs

trail pilot Sep 3, 2021, 7:24 PM

#

vale ibex Done 👌

Thank you!

#

Are you allowed to make a PR if you already have an issue assigned to you when your ready for it

#

You’re*

static canyon Sep 3, 2021, 7:24 PM

#

trail pilot Are you allowed to make a PR if you already have an issue assigned to you when y...

Yep

#

If it's been approved then just PR whenever it's ready

trail pilot Sep 3, 2021, 7:26 PM

#

Sounds good

#

Pretty nervous for the code reviews for when my PR rolls around

#

My code is a bit messy

static canyon Sep 3, 2021, 7:27 PM

#

It's fine, we're here to help 👍

#

We also have linting which should help out

#

And any concerns you have you can ask here

elder belfry Sep 3, 2021, 7:30 PM

#

While making a JSON file to store the combined data about common colour names and their hex values from https://xkcd.com/color/rgb/ and https://github.com/ryanzec/name-that-color/blob/master/lib/ntc.js#L116-L1681 , for the issue sir-lancebot#677, I found out that there's already 2 JSON files, xkcd_colours.json and html_colours.json in bot/resources/evergreen/ for the .decorateegg command.

What I propose is, we should combine all of them and also retain the fact it's from html or xkcd or ryanzec colour list, probably by making an object in JSON file with fields for html, xkcd, & ryanzec , so that we no longer require separate files for similar data and also make a helper function (probably at bots/utils/helpers.py) to find the best hex colour code for a colour name given by the user. As I believe it maybe used for other commands in the future.

dusky shoreBOT Sep 3, 2021, 7:30 PM

#

GitHub

IssueOpen Create a colo[u]r command

dim pelican Sep 3, 2021, 7:31 PM

#

elder belfry While making a `JSON` file to store the combined data about common colour names ...

Sounds good to me, have you been able to fork / clone my repo/branch?

elder belfry Sep 3, 2021, 7:32 PM

#

dim pelican Sounds good to me, have you been able to fork / clone my repo/branch?

yes I have cloned it.

dim pelican Sep 3, 2021, 7:33 PM

#

You can try to do a test commit and add that JSON file to the branch

elder belfry Sep 3, 2021, 7:36 PM

#

dim pelican Sounds good to me, have you been able to fork / clone my repo/branch?

Details will need to be hashed out and
decided on with CyberCitizen01.
And btw, We can decide upon the required details either here or DMs

elder belfry Sep 3, 2021, 7:39 PM

#

elder belfry While making a `JSON` file to store the combined data about common colour names ...

Should I make separate issue for this?
As some changes would be required in .decorateegg command also.

dim pelican Sep 3, 2021, 8:19 PM

#

Sorry in advance for anyone watching #dev-log , sir-lancebot#842 will be failing the flake8/lint workflow for a little while

dusky shoreBOT Sep 3, 2021, 8:19 PM

#

GitHub

PRDraft Add color command

austere hornet Sep 3, 2021, 8:21 PM

#

dim pelican Sorry in advance for anyone watching <#622895325144940554> , sir-lancebot#842 wi...

No worries

vale ibex Sep 3, 2021, 8:32 PM

#

dim pelican Sorry in advance for anyone watching <#622895325144940554> , sir-lancebot#842 wi...

you can add [no ci] to your commit message and it won't run any workflows

#

https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/

#

will be useful while you're still developing

static canyon Sep 3, 2021, 8:38 PM

#

from discord import Embed, Emoji, Member, Message, NoMoreItems, PartialMessage, TextChannel

from bot.constants import Guild

...
    @staticmethod
    def _random_ducky(guild: Guild) -> Union[Emoji, str]:
        """Picks a random ducky emoji. If no duckies found returns :eyes:."""
        duckies = [emoji for emoji in guild.emojis if emoji.name.startswith("ducky")]
        ...
```this gives an error because `bot.constants.Guild` doesn't have a `.emojis` attribute. What's the best way to solve this? I'm guessing doing something like```py
from discord import Embed, Emoji, Guild, Member, Message, NoMoreItems, PartialMessage, TextChannel  # add `Guild` import

from bot.constants import Guild as PydisGuild  # rename to `PydisGuild` so it doesn't override discord.Guild import```but want to know what others think

brazen charm Sep 3, 2021, 8:40 PM

#

both of those feel like they'd benefit from being namespaced

static canyon Sep 3, 2021, 8:41 PM

#

namespaced?

#

As in ```py
import discord
from discord import ...

import bot.constants
from bot.constants import ...

discord.Guild
bot.constants.Guild```?

brazen charm Sep 3, 2021, 8:41 PM

#

from bot import constants would probably be enough but yes

static canyon Sep 3, 2021, 8:41 PM

#

Right, yeah

trim cradle Sep 3, 2021, 9:00 PM

#

Can anyone who is familiar with the dewikification redirects hmu in #843084396666945566?

#

or here if you can't see that channel.

green oriole Sep 3, 2021, 9:14 PM

#

It is super recent

fallen patrol Sep 3, 2021, 9:15 PM

#

green oriole It is super recent

...February

green oriole Sep 3, 2021, 9:16 PM

#

Well, then they changed something recently about it

static canyon Sep 3, 2021, 9:25 PM

#

https://github.com/python-discord/bot/blob/main/bot/exts/moderation/modpings.py#L116 is it safe to assume that moderators_role will never be None here?

stable mountainBOT Sep 3, 2021, 9:25 PM

#

bot/exts/moderation/modpings.py line 116

if mod in self.moderators_role.members:```

static canyon Sep 3, 2021, 9:26 PM

#

It gets set inside the task loop https://github.com/python-discord/bot/blob/main/bot/exts/moderation/modpings.py#L38

stable mountainBOT Sep 3, 2021, 9:26 PM

#

bot/exts/moderation/modpings.py line 38

self.moderators_role = self.guild.get_role(Roles.moderators)```

vale ibex Sep 3, 2021, 9:29 PM

#

Is there await until guild available call before it?

brazen charm Sep 3, 2021, 9:29 PM

#

it's an on_command

vocal wolf Sep 3, 2021, 9:29 PM

#

@vale ibex wookie approved of talent pool, should we merge?

vale ibex Sep 3, 2021, 9:29 PM

#

Ah, then yes

vocal wolf Sep 3, 2021, 9:29 PM

#

very cool

brazen charm Sep 3, 2021, 9:29 PM

#

I'm not very knowledgeable with how discord.py works but that sounds like the guild should be available together with the role if the bot is accepting commands

vale ibex Sep 3, 2021, 9:29 PM

#

Yea, on_messages don't fire until guild is ready

static canyon Sep 3, 2021, 9:29 PM

#

👍

green oriole Sep 3, 2021, 9:29 PM

#

Do we yeet whatever the talent pool is named right now?

vocal wolf Sep 3, 2021, 9:29 PM

#

merging now

green oriole Sep 3, 2021, 9:30 PM

#

Cool

vale ibex Sep 3, 2021, 9:30 PM

#

vocal wolf <@!126811506632294400> wookie approved of talent pool, should we merge?

🚢

vocal wolf Sep 3, 2021, 9:30 PM

#

shipit

#

I'm gonna go get food, hopefully it doesn't explode

green oriole Sep 3, 2021, 9:31 PM

#

Watch the github datacenter actually explode

vocal wolf Sep 3, 2021, 9:31 PM

#

lol

#

merged

green oriole Sep 3, 2021, 9:35 PM

#

Seems to be fine

#

Talent pool has almost 800k messages, kind of crazy

#

Now we need to write a mod announcement and archive the channel

gritty wind Sep 3, 2021, 9:37 PM

#

That's finally gone?

#

Nice

green oriole Sep 3, 2021, 9:37 PM

#

Yep

#

Despite almost never looking at that channel, it feels weird knowing it is gone now

#

Like this channel has been here loooooong before I joined the staff, which will be almost a year ago now

gritty wind Sep 3, 2021, 9:39 PM

#

Like

#

You're right but

#

I always found it kinda useless 👀

green oriole Sep 3, 2021, 9:40 PM

#

Oh I know

vocal prairie Sep 3, 2021, 9:51 PM

#

Congrats Qwerty, Dorsan, Rick, and wookie! 🎉

static canyon Sep 3, 2021, 9:56 PM

#

How comes https://github.com/python-discord/bot/blob/main/bot/utils/time.py#L66 doesn't raise an error even though there's no args attribute?

stable mountainBOT Sep 3, 2021, 9:56 PM

#

bot/utils/time.py line 66

raise ValueError(f"Format can only be one of {', '.join(TimestampFormats.args)}, not {format}.")```

static canyon Sep 3, 2021, 9:57 PM

#

https://github.com/python-discord/bot/blob/main/bot/utils/time.py#L26-L39

stable mountainBOT Sep 3, 2021, 9:57 PM

#

bot/utils/time.py lines 26 to 39

class TimestampFormats(Enum):
    """
    Represents the different formats possible for Discord timestamps.

    Examples are given in epoch time.
    """

    DATE_TIME = "f"  # January 1, 1970 1:00 AM
    DAY_TIME = "F"  # Thursday, January 1, 1970 1:00 AM
    DATE_SHORT = "d"  # 01/01/1970
    DATE = "D"  # January 1, 1970
    TIME = "t"  # 1:00 AM
    TIME_SECONDS = "T"  # 1:00:00 AM
    RELATIVE = "R"  # 52 years ago```

green oriole Sep 3, 2021, 9:59 PM

#

It is an attribute auto-generated by the enum metaclass

gritty wind Sep 3, 2021, 9:59 PM

#

I thought so too but

#

!e ```py
import enum

class Test(enum.Enum):
...

Test.args

stable mountainBOT Sep 3, 2021, 9:59 PM

#

@gritty wind :x: Your eval job has completed with return code 1.

001 | Traceback (most recent call last):
002 |   File "<string>", line 6, in <module>
003 |   File "/usr/local/lib/python3.9/enum.py", line 429, in __getattr__
004 |     raise AttributeError(name) from None
005 | AttributeError: args

green oriole Sep 3, 2021, 10:00 PM

#

Uuhh idk it seemed to work haha

#

!e
import enum

class Test(enum.Enum):
abc = 42

Test.args

stable mountainBOT Sep 3, 2021, 10:00 PM

#

@green oriole :x: Your eval job has completed with return code 1.

001 | Traceback (most recent call last):
002 |   File "<string>", line 6, in <module>
003 |   File "/usr/local/lib/python3.9/enum.py", line 429, in __getattr__
004 |     raise AttributeError(name) from None
005 | AttributeError: args

gritty wind Sep 3, 2021, 10:00 PM

#

I'm so confused right now

green oriole Sep 3, 2021, 10:01 PM

#

shrugs

gritty wind Sep 3, 2021, 10:01 PM

#

How did this even make it into main

#

Tests are failing

#

Oh no, that's just github funkiness

#

Alright, tests are not failing

green oriole Sep 3, 2021, 10:03 PM

#

Seems like __members__.values() is what we would want

gritty wind Sep 3, 2021, 10:03 PM

#

I mean, I don't see any function that feeds user input into that

#

Why do we even need the check

tawdry vapor Sep 3, 2021, 10:04 PM

#

It's a bogus check and I removed it

#

There were several problems with that function

gritty wind Sep 3, 2021, 10:04 PM

#

Oh?

green oriole Sep 3, 2021, 10:04 PM

#

Because uuuhhh better checking than not checking?

static canyon Sep 3, 2021, 10:05 PM

#

@vale ibex fwiw I've gotten the bot down from 1.6k errors with mypy to 1,073

green oriole Sep 3, 2021, 10:05 PM

#

I don't know, I am really sorry for all the time related code I wrote it is hot garbage

tawdry vapor Sep 3, 2021, 10:05 PM

#

gritty wind Oh?

https://github.com/python-discord/bot/pull/1721/commits/ac5a5e0acbc38dbd5d512e0925fbf9d7b6d526d3

gritty wind Sep 3, 2021, 10:05 PM

#

Ah

#

I don't think I've seen a PR before with that few lines changed have that many files changed

green oriole Sep 3, 2021, 10:06 PM

#

The only thing I am still happy about is the use of the enum

fallen patrol Sep 3, 2021, 10:08 PM

#

static canyon <@!126811506632294400> fwiw I've gotten the bot down from 1.6k errors with mypy ...

Why is pydis trying to add mypy to Bot?

static canyon Sep 3, 2021, 10:08 PM

#

fallen patrol Why is pydis trying to add mypy to Bot?

Because why not 🤷

green oriole Sep 3, 2021, 10:08 PM

#

I don't think we are adding mypy

static canyon Sep 3, 2021, 10:08 PM

#

bot#1773

dusky shoreBOT Sep 3, 2021, 10:08 PM

#

GitHub

IssueOpen Add mypy to the codebase

green oriole Sep 3, 2021, 10:08 PM

#

At least I am strongly opposed to it

#

Just the amount of type changes and additional checks would be pain

#

Maybe if we do a rewrite one day

#

!remind 10h Wrote your thoughts on the issue

stable mountainBOT Sep 3, 2021, 10:09 PM

#

Alright.

Your reminder will arrive on <t:1630742995:F>!

trail pilot Sep 3, 2021, 10:10 PM

#

Am I allowed to make a PR if I was assigned to an issue already?

static canyon Sep 3, 2021, 10:10 PM

#

trail pilot Am I allowed to make a PR if I was assigned to an issue already?

yes

trail pilot Sep 3, 2021, 10:10 PM

#

And does the issue need to be fully done or can it just be at a playable stage (i'm doing a hangman issue and it is mainly complete)

static canyon Sep 3, 2021, 10:10 PM

#

If it's not fully complete you can do a "Draft PR"

green oriole Sep 3, 2021, 10:10 PM

#

Opening before being done is even better, using a draft PR

trail pilot Sep 3, 2021, 10:10 PM

#

I think it is doing everything it should be doing, so I'll just send it as a PR

green oriole Sep 3, 2021, 10:11 PM

#

You have to click the little drop-down next to the create pull request button

trail pilot Sep 3, 2021, 10:11 PM

#

Though I didn't add the executioner version because I feel like that should be its own issue and separate from the overall game, it adds a bit too much

#

Not sure if I should though

#

The original issue creator wanted there to be a guesser/executioner, though executioner feels a bit too wide of a scope, so I don't know if I should add it

fallen patrol Sep 3, 2021, 10:12 PM

#

trail pilot And does the issue need to be fully done or can it just be at a playable stage (...

tldr the only limitation to making a pr is that you must have one commit

#

you cannot make a pr without having at least one commit

#

if its not ready to be merged, mark the pr as a draft upon creation

fallen patrol Sep 3, 2021, 10:13 PM

#

dusky shore

oh no

clever wraith Sep 3, 2021, 10:47 PM

#

trail pilot Though I didn't add the executioner version because I feel like that should be i...

Executioner might be a bit morbid

trail pilot Sep 3, 2021, 10:56 PM

#

clever wraith Executioner might be a bit morbid

it's just a fancy word for the user chooses the word in hangman and then can give hints or whatever

trail pilot Sep 3, 2021, 11:22 PM

#

Flake8 is failing because of this, weird

gritty wind Sep 3, 2021, 11:23 PM

#

Are you using poetry?

#

And do you have it installed globally (I.E somewhere on your path)

trail pilot Sep 3, 2021, 11:24 PM

#

gritty wind Are you using poetry?

I do not have it installed, I presume I should do pip install -U poetry first?

gritty wind Sep 3, 2021, 11:24 PM

#

Yeah

#

You may be better off starting with the getting started guide

#

It’ll walk you through all the things you need to do

trail pilot Sep 3, 2021, 11:24 PM

#

I used Docker though

#

So I presumed I didn't need poetry

gritty wind Sep 3, 2021, 11:25 PM

#

Docker is fine for running

#

But for tests, or linting

#

You’ll kind of need to have poetry

#

You could do it on docker

#

But you’ll have to put in extra work

#

(Either install poetry inside docker, or run pre-commit skipping flake, and run flake manually)

#

You can use ‘SKIP=flake8 pre-commit’ to do the second approach

trail pilot Sep 3, 2021, 11:27 PM

#

Thank you!

#

Yeah this keeps failing

#

Which is weird because flake8 locally does not show any errors

#

it just errors out from github actions

gritty wind Sep 3, 2021, 11:29 PM

#

This isn’t flake

#

It’s precommit

trail pilot Sep 3, 2021, 11:30 PM

#

Oh is it cause the fixing end of files failed

brazen charm Sep 3, 2021, 11:30 PM

#

you're missing a newline at the end

gritty wind Sep 3, 2021, 11:30 PM

#

trail pilot Flake8 is failing because of this, weird

What’s the rest of the screenshot

trail pilot Sep 3, 2021, 11:30 PM

#

That's it

gritty wind Sep 3, 2021, 11:30 PM

#

No scrolling up?

trail pilot Sep 3, 2021, 11:30 PM

#

#

gritty wind Sep 3, 2021, 11:30 PM

#

The screenshot I replied to from earlier

brazen charm Sep 3, 2021, 11:30 PM

#

brazen charm you're missing a newline at the end

weird that github doesn't show it, is that only for code files?

trail pilot Sep 3, 2021, 11:30 PM

#

brazen charm weird that github doesn't show it, is that only for code files?

Probably, anyways I'll fix that

#

Sorry for the stupid questions

dim pelican Sep 3, 2021, 11:51 PM

#

Just to make sure, did you check out that setup and contributing guide? I followed it without understanding and eventually got poetry and pre-commit working

clever wraith Sep 3, 2021, 11:51 PM

#

trail pilot it's just a fancy word for the user chooses the word in hangman and then can giv...

Ah

trail pilot Sep 3, 2021, 11:52 PM

#

dim pelican Just to make sure, did you check out that setup and contributing guide? I follow...

Yep

#

I just never installed poetry... oops

#

I thought it was a separate thing haha

#

Also what would you all think of a possible challenge command on sir lancebot that gets a random kata from codewars?

dim pelican Sep 4, 2021, 12:19 AM

#

Maybe just to send a link to a specific Kyu level

fallen patrol Sep 4, 2021, 12:45 AM

#

why do I not do that

fallen patrol Sep 4, 2021, 12:45 AM

#

trail pilot Yeah this keeps failing

thanks, this found a bug in my own ci

austere hornet Sep 4, 2021, 12:56 AM

#

fallen patrol thanks, this found a bug in my own ci

That's what happens all the time lmao

fallen patrol Sep 4, 2021, 12:56 AM

#

yepppppp

#

found like 3 from this

#

it takes about 1 second longer to run flake8 with poetry run flake8

#

even if I'm already in the venv

brazen charm Sep 4, 2021, 1:05 AM

#

You must have write perms to the repository

#

which would at least have to be a staff contrib

fallen patrol Sep 4, 2021, 1:17 AM

#

brazen charm You must have write perms to the repository

well technically you can write your name on it but it just won't count for anything

clever wraith Sep 4, 2021, 1:17 AM

#

So that's your dream rick?

fallen patrol Sep 4, 2021, 1:18 AM

#

I presume only core devs get on the codeowners file

#

no, no it is not

#

thinking of disabling it for my repo

#

currently blocks too many of prs since it was added hastly

brazen charm Sep 4, 2021, 1:18 AM

#

from the prs I open it just seems to make auto reviews and then mostly people out of those that were auto requested review

clever wraith Sep 4, 2021, 1:19 AM

#

A dream come true

fallen patrol Sep 4, 2021, 1:22 AM

#

I didn't say it was bad lol

#

i.. didn't say that either

#

I said no, in response to you saying "Being in CODEOWNERS is legendary"

trail pilot Sep 4, 2021, 1:41 AM

#

dim pelican Maybe just to send a link to a specific Kyu level

hm, that would be a bit boring though since the user could just go themselves

fallen patrol Sep 4, 2021, 2:43 AM

#

I have a question about the guild command

#

!guild

stable mountainBOT Sep 4, 2021, 2:44 AM

#

Server Information

Created: <t:1483877013:R>
Voice region: europe
Features: PARTNERED, NEWS, VANITY_URL, PREVIEW_ENABLED, ANIMATED_ICON, BANNER, DISCOVERABLE, SEVEN_DAY_THREAD_ARCHIVE, RELAY_ENABLED, ROLE_ICONS, COMMUNITY, PRIVATE_THREADS, VIP_REGIONS, INVITE_SPLASH, THREE_DAY_THREAD_ARCHIVE, THREADS_ENABLED, WELCOME_SCREEN_ENABLED, MEMBER_VERIFICATION_GATE_ENABLED, NEW_THREAD_PERMISSIONS
Roles: 90
Member status: status_online 37,123 status_offline 211,457

Members: 248,580

Helpers: 124
Moderation Team: 32
Admins: 14
Owners: 3
Contributors: 43
Leads: 14

Channels: 237

Category: 32
News: 9
Staff: 59
Stage_Voice: 1
Text: 127
Voice: 9

fallen patrol Sep 4, 2021, 2:44 AM

#

Channels: 237
can @stable mountain see all of the channels in the server?

sullen phoenix Sep 4, 2021, 3:16 AM

#

yes, @stable mountain has administrative powers

#

@fallen patrol

fallen patrol Sep 4, 2021, 3:17 AM

#

Huh, didn't know that

green oriole Sep 4, 2021, 4:39 AM

#

You don't need admin to count every channel either way

fallen patrol Sep 4, 2021, 5:07 AM

#

green oriole You don't need admin to count every channel either way

Maybe not right now.... ¯_(ツ)_/¯

green oriole Sep 4, 2021, 5:22 AM

#

Well I wish you'd need to read the channel to receive it, but I doubt it is changing anytime soon

fallen patrol Sep 4, 2021, 5:37 AM

#

perhaps....

stable mountainBOT Sep 4, 2021, 8:09 AM

#

green oriole !remind 10h Wrote your thoughts on the issue

It has arrived!

Here's your reminder: Wrote your thoughts on the issue
[Jump back to when you created the reminder](#dev-contrib message)

green oriole Sep 4, 2021, 8:10 AM

#

Eh

#

!remind 7h thusky

stable mountainBOT Sep 4, 2021, 8:10 AM

#

Sure thing!

Your reminder will arrive on <t:1630768221:F>!

green oriole Sep 4, 2021, 8:10 AM

#

I meant this but sure

patent pivot Sep 4, 2021, 8:16 AM

#

hello, all deploys are off for now while I do a bunch of CI job migrations, expect a flurry of PRs

patent pivot Sep 4, 2021, 8:49 AM

#

all the repo paths

#

yeah I'm on the train now