#dev-contrib | Python | Page 130

thorny obsidian Aug 31, 2021, 3:33 PM

#

yup! That's how it works. When you make a new branch you're essentially saying "from this point on, I want to make a new feature, but not prevent other development of the main branch, so I'll do it in a different area". Having the same commits there to maintain commit history is important

vale ibex Aug 31, 2021, 3:34 PM

#

Yea, the way to do it is to make a branch, do some changes, then go back to main and branch from there again

#

rather than branching from your branch

desert vessel Aug 31, 2021, 3:34 PM

#

A new branch is basically a copy of your existing branch where you can add stuff like one branch can be for dev and the other can be for prod

dim pelican Aug 31, 2021, 3:34 PM

#

I have a fork of the repo, and my main branch has a few changes like more things in the .gitignore, .gitmessage etc. I want to keep those in my main branch of the fork, but when I make a new branch to work on an issue / PR it pulls from my forked main. I've learned I have to force pull / over write the new branch from the upstream main once I create it

thorny obsidian Aug 31, 2021, 3:36 PM

#

aaah. Hmmmm, for that, if I want to start a branch at a later commit I usually use a GUI since it lets me select a commit and do a "start branch from here" option

#

Chris might know something better

dim pelican Aug 31, 2021, 3:37 PM

#

Here is the issue I ran into: creating a branch from my main: https://github.com/python-discord/sir-lancebot/pull/832

And then properly setting it up: https://github.com/python-discord/sir-lancebot/pull/833

green oriole Aug 31, 2021, 3:37 PM

#

You'd want to checkout upstream/main and make a branch

#

git checkout upstream/main
git checkout -b $name

dim pelican Aug 31, 2021, 3:38 PM

#

Ahh instead of making a branch on my fork

#

I don't think I can make a new branch on the upstream though

green oriole Aug 31, 2021, 3:38 PM

#

Basically the branch you have checked out will be the forking point of your branch, if you following the tree analogy

green oriole Aug 31, 2021, 3:39 PM

#

dim pelican I don't think I can make a new branch on the upstream though

It won't create anything on the upstream, you can push to your fork after

#

Checking out upstream/main means "go to the commit that the branch main on the upstream points to"

dim pelican Aug 31, 2021, 3:40 PM

#

Gotcha, it just uses the upstream main as it's base "reference". Then the new branch inherits everything from there, and when I link a PR I point it to that branch of the upstream / origin?

green oriole Aug 31, 2021, 3:40 PM

#

Yeah, you will make a PR from the newly created branch

dim pelican Aug 31, 2021, 3:41 PM

#

I guess the only thing I'm not following is will that new branch be on my fork (brad90four/sir-lancebot) or the upstream (python-discord/sir-lancebot)

green oriole Aug 31, 2021, 3:42 PM

#

When you create a new branch locally, it doesn't have any knowledge of which repo it is pointing to

#

When you first push, you link it to the remote branch

dim pelican Aug 31, 2021, 3:42 PM

#

You should have heard a loud "click" just then

green oriole Aug 31, 2021, 3:42 PM

#

git push -u origin $name will link it to the branch named $name on the origin remote

#

Haha, nice

dim pelican Aug 31, 2021, 3:43 PM

#

Damn, just when I thought I sorta knew my way around git

fervent sage Aug 31, 2021, 3:43 PM

#

you never know your way around git

#

you can be a world expert in git and still not know

green oriole Aug 31, 2021, 3:43 PM

#

Haha, git is a complex topic. Not even Linus knows his way around it.

dim pelican Aug 31, 2021, 3:44 PM

#

git fetch
git checkout upstream/main
git checkout -b <new_branch>
... # code
git add <changes>
git commit
git push -u origin <new_branch>

For my future reference, gonna bm this

green oriole Aug 31, 2021, 3:45 PM

#

I would recommend adding a git fetch at the top

#

So you know upstream/main is up to date

dim pelican Aug 31, 2021, 3:46 PM

#

Thank you, gotta keep practicing those git muscles

#

In the meantime, if anyone is interested:

#

sir-lancebot#833

dusky shoreBOT Aug 31, 2021, 3:47 PM

#

GitHub

PROpen Teapot support - Continues PR #610
IssueOpen Add .gitmessage to allow for consistent commit messages

dim pelican Aug 31, 2021, 3:47 PM

#

sir-lancebot#834

dusky shoreBOT Aug 31, 2021, 3:47 PM

#

GitHub

IssueOpen Add .gitmessage to allow for consistent commit messages

fervent sage Aug 31, 2021, 3:47 PM

#

time for me to practise my lancebot setup muscles

#

see how many PRs i can thoroughly review in a day KEKW

dim pelican Aug 31, 2021, 4:02 PM

#

Oh scheiße my PR is borked @fervent sage

#

I hope that recent commit works

vale ibex Aug 31, 2021, 4:10 PM

#

lmfao

#

trusting my in-git suggestion

green oriole Aug 31, 2021, 4:10 PM

#

lol, nice

vale ibex Aug 31, 2021, 4:10 PM

#

is that a force push I hear in the distance

desert vessel Aug 31, 2021, 4:10 PM

#

vale ibex is that a force push I hear in the distance

hehehe

desert vessel Aug 31, 2021, 4:10 PM

#

fervent sage see how many PRs i can thoroughly review in a day <:KEKW:730356155074871407>

target: 17

#

jk

vale ibex Aug 31, 2021, 4:11 PM

#

Maybe add the last commit as a fixup to f31d196

#

if you're gonna force push anyway

desert vessel Aug 31, 2021, 4:11 PM

#

i have so many open issues and pr's, i cant keep track of what im doing :(

vale ibex Aug 31, 2021, 4:12 PM

#

I find github notifications are good

desert vessel Aug 31, 2021, 4:12 PM

#

vale ibex I find github notifications are good

they are too many of em :(

vale ibex Aug 31, 2021, 4:12 PM

#

Since you can also see

dim pelican Aug 31, 2021, 4:12 PM

#

Too good, I don't like the constant emails on things I commented on

desert vessel Aug 31, 2021, 4:12 PM

#

vale ibex Since you can also see

OOooo

desert vessel Aug 31, 2021, 4:12 PM

#

dim pelican Too good, I don't like the constant emails on things I commented on

im guessing you can unsubscribe ?

#

but that would disable all mails

#

heh

fervent sage Aug 31, 2021, 4:13 PM

#

vale ibex Since you can also see

KEKW

dim pelican Aug 31, 2021, 4:13 PM

#

I do, for all the ones Ive commented on. But it does it by default as far as I can tell

desert vessel Aug 31, 2021, 4:13 PM

#

ah yes, the glory

vale ibex Aug 31, 2021, 4:13 PM

#

I try to keep on top of my notifications lol

desert vessel Aug 31, 2021, 4:13 PM

#

vale ibex Since you can also see

where do i find this-

vale ibex Aug 31, 2021, 4:13 PM

#

Click the bell icon in the top right

desert vessel Aug 31, 2021, 4:13 PM

#

vale ibex I try to keep on top of my notifications lol

:D

#

how did i not know that till now-

#

:sus:

#

isnt this assigned

#

aaaaa

vale ibex Aug 31, 2021, 4:15 PM

#

likely because you don't have a notification from that

#

Does it appear when you click assigned on the left?

desert vessel Aug 31, 2021, 4:15 PM

#

vale ibex likely because you don't have a notification from that

oh hmmm

#

nop

#

green oriole Aug 31, 2021, 4:16 PM

#

vale ibex is that a force push I hear in the distance

Not home rn Sadge

vale ibex Aug 31, 2021, 4:16 PM

#

ahh, I'd do it but then I wouldn't be counted as a reviewer lol

vale ibex Aug 31, 2021, 4:17 PM

#

desert vessel oh hmmm

https://github.com/issues/assigned might be what you're looking for then

desert vessel Aug 31, 2021, 4:18 PM

#

vale ibex https://github.com/issues/assigned might be what you're looking for then

ty <3

green oriole Aug 31, 2021, 4:18 PM

#

vale ibex ahh, I'd do it but then I wouldn't be counted as a reviewer lol

If you keep me as the commit author and you as the co-author it should be fine

desert vessel Aug 31, 2021, 4:20 PM

#

fun fact: i found a bug in the linux kernel so i wanted to open a pr fixing it, but i went through the pr and the styling process and i quickly gave up

#

😂

vale ibex Aug 31, 2021, 4:23 PM

#

green oriole If you keep me as the commit author and you as the co-author it should be fine

😦

#

since I pushed it it counts me as committing it I guess?

dim pelican Aug 31, 2021, 4:23 PM

#

¯_(ツ)_/¯

vale ibex Aug 31, 2021, 4:24 PM

#

Yea, I know that worked

green oriole Aug 31, 2021, 4:24 PM

#

Huh

vale ibex Aug 31, 2021, 4:24 PM

#

I'm disqualified from policy bot though

green oriole Aug 31, 2021, 4:24 PM

#

Hey @patent pivot, can you approve https://github.com/python-discord/sir-lancebot/pull/835 for Chris please?

GitHub

Migrate to Discord 2.0a0 by Akarys42 · Pull Request #835 · python-d...

Since the Discord.py repository has been archived, we can switch to the latest commit of 2.0a0, knowing no breaking change will occur (still pinned to the commit just in case).
This commit also sol...

#

He is being locked by policy bot and we need a devops to approve

dim pelican Aug 31, 2021, 4:25 PM

#

I like that commit message

patent pivot Aug 31, 2021, 4:26 PM

#

Approved 👽

vale ibex Aug 31, 2021, 4:26 PM

#

BlobHeart

green oriole Aug 31, 2021, 4:26 PM

#

!otn a my brother from another mother ChrisJL

stable mountainBOT Aug 31, 2021, 4:26 PM

#

:ok_hand: Added my-brother-from-another-mother-𝖢hris𝖩𝖫 to the names list.

vale ibex Aug 31, 2021, 4:26 PM

#

lol

green oriole Aug 31, 2021, 4:26 PM

#

Thank you sir Joe

patent pivot Aug 31, 2021, 4:26 PM

#

anytime

green oriole Aug 31, 2021, 4:28 PM

#

Oh actually it didn't devops approval but that works too lol

fervent sage Aug 31, 2021, 4:30 PM

#

woo dpy2.0 in a couple minutes

#

big excite

vale ibex Aug 31, 2021, 4:30 PM

#

time to rewrite all the games with buttons

green oriole Aug 31, 2021, 4:31 PM

#

lol

fervent sage Aug 31, 2021, 4:31 PM

#

theres no time for that, you must contribute to my discord lib instead mmLol

#

whip

vale ibex Aug 31, 2021, 4:32 PM

#

how come?

#

you should just be able to copy most of what exists in sirlance or bot

green oriole Aug 31, 2021, 4:33 PM

#

Do we really have to, though? Threadevere most probably won't be around for too long anymore, and doesn't have any user facing command

vale ibex Aug 31, 2021, 4:33 PM

#

True

#

I'm not against removing the help command entirely lol

desert vessel Aug 31, 2021, 4:33 PM

#

vale ibex how come?

help.py isnt even in the file tree

#

or my vscode is screwed

vale ibex Aug 31, 2021, 4:33 PM

#

we don't have custom help in @brisk belfry

#

it's the default discord.py

desert vessel Aug 31, 2021, 4:34 PM

#

desert vessel Aug 31, 2021, 4:34 PM

#

vale ibex it's the default discord.py

oh

#

wow, i thought vsc was screwed when i saw help.py being a part of /Library/Framwork/Python3.9

vale ibex Aug 31, 2021, 4:35 PM

#

😛

fallen patrol Aug 31, 2021, 4:35 PM

#

green oriole Do we really have to, though? Threadevere most probably won't be around for too ...

why not?

desert vessel Aug 31, 2021, 4:35 PM

#

vale ibex you should just be able to copy most of what exists in sirlance or bot

copy pasta is hard :(

fallen patrol Aug 31, 2021, 4:35 PM

#

its really not 👀

vale ibex Aug 31, 2021, 4:35 PM

#

fallen patrol why not?

we're planning to upgrade the bot to 2.0 at some point

#

when that happens @brisk belfry's cogs will be moved there

fallen patrol Aug 31, 2021, 4:36 PM

#

ah

desert vessel Aug 31, 2021, 4:36 PM

#

most of the imports are referring to the files in the local bot repo so yeah

fallen patrol Aug 31, 2021, 4:36 PM

#

I'm running a custom @dusky shore on v2 right now btw

#

haven't had any bugs so far

vale ibex Aug 31, 2021, 4:36 PM

#

We just bumped lance to 2.0

desert vessel Aug 31, 2021, 4:36 PM

#

but sir-threadevere isnt opening threads 😂

vale ibex Aug 31, 2021, 4:36 PM

#

#dev-log message

fallen patrol Aug 31, 2021, 4:36 PM

#

oh damn

#

I should uh, repull

desert vessel Aug 31, 2021, 4:36 PM

#

vale ibex https://canary.discord.com/channels/267624335836053506/622895325144940554/882301...

🥳

fallen patrol Aug 31, 2021, 4:36 PM

#

since you found all of the bugs that I haven't yet, probably

desert vessel Aug 31, 2021, 4:37 PM

#

desert vessel but sir-threadevere isnt opening threads 😂

atleast for me

vale ibex Aug 31, 2021, 4:37 PM

#

fallen patrol since you found all of the bugs that I haven't yet, probably

there weren't too many

#

just check the PR 😄

desert vessel Aug 31, 2021, 4:37 PM

#

it should make a thread in the nomination channel, correct ?

vale ibex Aug 31, 2021, 4:37 PM

#

sir-lancebot#835

dusky shoreBOT Aug 31, 2021, 4:37 PM

#

GitHub

PRMerged Migrate to Discord 2.0a0

desert vessel Aug 31, 2021, 4:37 PM

#

desert vessel it should make a thread in the nomination channel, correct ?

like for every message ?

vale ibex Aug 31, 2021, 4:37 PM

#

desert vessel it should make a thread in the nomination channel, correct ?

when a nomination vote is posted yea

fallen patrol Aug 31, 2021, 4:37 PM

#

you got all of the timestamp issues too, right?

vale ibex Aug 31, 2021, 4:37 PM

#

not all messages, no

vale ibex Aug 31, 2021, 4:38 PM

#

fallen patrol you got all of the timestamp issues too, right?

Didn't touch anything regrading timestamps

desert vessel Aug 31, 2021, 4:38 PM

#

vale ibex not all messages, no

wut

vale ibex Aug 31, 2021, 4:38 PM

#

Don't think we relied on them being naive/aware

fallen patrol Aug 31, 2021, 4:38 PM

#

welp you probably have a broken bug in there somewhere

vale ibex Aug 31, 2021, 4:38 PM

#

in lance at least

vale ibex Aug 31, 2021, 4:38 PM

#

desert vessel wut

Only when a nomination vote is posted

patent pivot Aug 31, 2021, 4:38 PM

#

fallen patrol you got all of the timestamp issues too, right?

more context?

vale ibex Aug 31, 2021, 4:38 PM

#

patent pivot more context?

all dates are aware now

fallen patrol Aug 31, 2021, 4:38 PM

#

vale ibex Don't think we relied on them being naive/aware

.

patent pivot Aug 31, 2021, 4:38 PM

#

is there anywhere you think we'd hit them?

#

yea

desert vessel Aug 31, 2021, 4:38 PM

#

vale ibex Only when a nomination vote is posted

oh okay, whats the command for that hehe

patent pivot Aug 31, 2021, 4:39 PM

#

but I don't think as Chris says we rely on that

#

so I don't think where are a tonne of bugs

vale ibex Aug 31, 2021, 4:39 PM

#

desert vessel oh okay, whats the command for that hehe

it's in @stable mountain, not threadbot

fallen patrol Aug 31, 2021, 4:39 PM

#

these, possibly? https://github.com/python-discord/sir-lancebot/blob/e6e280cd13236647ffcaa35f522baeb747fbf97e/bot/exts/halloween/hacktober-issue-finder.py#L55-L58

stable mountainBOT Aug 31, 2021, 4:39 PM

#

bot/exts/halloween/hacktober-issue-finder.py lines 55 to 58

    if (ctx.message.created_at - self.cache_timer_beginner).seconds <= 60:
        log.debug("using cache")
        return self.cache_beginner
elif (ctx.message.created_at - self.cache_timer_normal).seconds <= 60:```

desert vessel Aug 31, 2021, 4:39 PM

#

vale ibex it's in <@!409107086526644234>, not threadbot

im using the py bot in my server too, nomination doesnt work

wise oriole Aug 31, 2021, 4:39 PM

#

hi, I've read that d.py as a library is going to stop being developed? Would that affect this server's bots?

fervent sage Aug 31, 2021, 4:39 PM

#

no

vale ibex Aug 31, 2021, 4:40 PM

#

you should be able to type this and it'll work ```
@vale ibex for Helper!

Nomintated by:
react :+1: for approval, or :-1: for disapproval

fallen patrol Aug 31, 2021, 4:40 PM

#

nope those are, here https://github.com/python-discord/sir-lancebot/blob/e6e280cd13236647ffcaa35f522baeb747fbf97e/bot/exts/halloween/hacktober-issue-finder.py#L31

stable mountainBOT Aug 31, 2021, 4:40 PM

#

bot/exts/halloween/hacktober-issue-finder.py line 31

self.cache_timer_normal = datetime.datetime(1, 1, 1)```

fervent sage Aug 31, 2021, 4:40 PM

#

at least, not in the near future

desert vessel Aug 31, 2021, 4:40 PM

#

wise oriole hi, I've read that d.py as a library is going to stop being developed? Would tha...

We've upgraded to v2 which is stable for now

#

sir-lancebot#835

dusky shoreBOT Aug 31, 2021, 4:40 PM

#

GitHub

PRMerged Migrate to Discord 2.0a0

desert vessel Aug 31, 2021, 4:40 PM

#

vale ibex you should be able to type this and it'll work ``` <@126811506632294400> for Hel...

weird, i did that

wise oriole Aug 31, 2021, 4:40 PM

#

but the api is gonna be changing, and the api wrapper is not keeping up with it, thus losing its 100% coverage

wise oriole Aug 31, 2021, 4:40 PM

#

desert vessel We've upgraded to v2 which is stable for now

oh

brazen charm Aug 31, 2021, 4:41 PM

#

it will affect the bots at some point, but not in a everything suddenly breaks way

desert vessel Aug 31, 2021, 4:41 PM

#

^

#

bruv yeet it, im making another server and trying

#

:sadge:

#

anw, i'll do the pr of the sir-lancebot one and go to sleep

#

gn people :D

green oriole Aug 31, 2021, 4:44 PM

#

desert vessel :sadge:

False

#

Watch him ignore me

vale ibex Aug 31, 2021, 4:45 PM

#

😄

green oriole Aug 31, 2021, 4:46 PM

#

Phew

fallen patrol Aug 31, 2021, 4:48 PM

#

hm... if you're switching to dpy 2 you maybe want to update the paginator to use interactions 😛

green oriole Aug 31, 2021, 4:48 PM

#

Ye ye

#

If only we had an issue for it 🥺

vale ibex Aug 31, 2021, 4:49 PM

#

paginator is the obvious one

#

but we'll do that separate from the actual upgrade on Python

green oriole Aug 31, 2021, 4:50 PM

#

Yeah, let's minimize the breakage if it does break :D

#

We aren't time stressed, we can do it step by step

cold island Aug 31, 2021, 4:55 PM

#

So are buttons just part of the message, and you can change which buttons appear by just editing it?

vale ibex Aug 31, 2021, 4:57 PM

#

Yup

#

You can attach them as part of the message send api request, so no extra call

#

And then clicking a button triggers a callback

fallen patrol Aug 31, 2021, 4:57 PM

#

yeah

vale ibex Aug 31, 2021, 4:58 PM

#

https://github.com/python-discord/sir-threadevere/pull/4/files#diff-3036c6f31d313d9a057412a2955587d49f5ad410d5e31c0877bdbf5f5548aaadR46-R105

fallen patrol Aug 31, 2021, 4:58 PM

#

I just merged a pr to my bot to add an interaction paginator, if anyone wants inspiration 😛

#

https://github.com/discord-modmail/modmail/commit/0a329ff6f72edd05a56b4886a260b2a5cffa1c08

vale ibex Aug 31, 2021, 4:58 PM

#

vale ibex https://github.com/python-discord/sir-threadevere/pull/4/files#diff-3036c6f31d31...

This is a view with two buttons

fallen patrol Aug 31, 2021, 4:58 PM

#

huh

vale ibex Aug 31, 2021, 4:58 PM

#

You just add the class like this https://github.com/python-discord/sir-threadevere/pull/4/files#diff-fd6662a3d35e3682fc8427840f61ab56eac5b7c05a63a402d55311d269eaef9cR120-R124

fallen patrol Aug 31, 2021, 4:59 PM

#

        if self.lock.locked():
            await interaction.response.send_message(
                ":x: Processing another user's button press, try again later.",
                ephemeral=True,
            )
``` could you explain?

#

I didn't use a lock on mine 👀

vale ibex Aug 31, 2021, 4:59 PM

#

Anyone can click buttons, a lock means that it only processes one at a time

#

The use case for this view is to send an email to a user, so I want to avoid 2 people clicking a button triggering 2 emails

fallen patrol Aug 31, 2021, 5:00 PM

#

ah, lock is probably not necessary for a paginator, then?

vale ibex Aug 31, 2021, 5:00 PM

#

nope

fallen patrol Aug 31, 2021, 5:00 PM

#

whew

#

thought I missed a horrible bug

vale ibex Aug 31, 2021, 5:00 PM

#

😛

fallen patrol Aug 31, 2021, 5:00 PM

#

since i just merged the pr after a successful review

#

like

#

#

hell yeah it works great

#

green oriole Aug 31, 2021, 5:04 PM

#

... There is only one page?

fallen patrol Aug 31, 2021, 5:04 PM

#

yeah?

#

There's not a boatload of extensions yet smh

green oriole Aug 31, 2021, 5:04 PM

#

I guess it does work then

fallen patrol Aug 31, 2021, 5:04 PM

#

smh

#

and the help command is still default so can't show it there 😔

vale ibex Aug 31, 2021, 5:05 PM

#

How did you test it worked with the buttons ?

fallen patrol Aug 31, 2021, 5:06 PM

#

wrote a custom cog as a plugin

#

#

with multiple options 🙂

cold island Aug 31, 2021, 5:07 PM

#

So bulky though

fallen patrol Aug 31, 2021, 5:07 PM

#

its better when you aren't paginating 5 characters

green oriole Aug 31, 2021, 5:07 PM

#

Yeah, I guess it is more bulky than reactions

fallen patrol Aug 31, 2021, 5:08 PM

#

well yeah

cold island Aug 31, 2021, 5:08 PM

#

I guess that's more mobile friendly

fallen patrol Aug 31, 2021, 5:09 PM

#

the buttons are actually smaller on mobile

#

On android:

celest charm Aug 31, 2021, 5:14 PM

#

fallen patrol

I clicked on the image 🤦

fallen patrol Aug 31, 2021, 5:14 PM

#

Lmao

fallen patrol Aug 31, 2021, 5:15 PM

#

celest charm I clicked on the image 🤦

If you'd like to test it I can invite you to the server

brisk brook Aug 31, 2021, 5:18 PM

#

@cold island seems like your apology wasn't accepted

cold island Aug 31, 2021, 5:20 PM

#

lol

#

I accidently hit approval instead of request changes

fallen patrol Aug 31, 2021, 5:25 PM

#

I commented on your review

cold island Aug 31, 2021, 5:34 PM

#

fallen patrol I commented on your review

I understand what it does, but the link doesn't say anything about the last argument being optional being bad

fallen patrol Aug 31, 2021, 5:34 PM

#

Oh, true

cold island Aug 31, 2021, 6:24 PM

#

Thanks @brisk brook, your explanation happened to solve something I was just doing 😄 👌

brisk brook Aug 31, 2021, 6:25 PM

#

Ah lemon_infant

fallen patrol Aug 31, 2021, 6:56 PM

#

the last person to get it became a helper a week later lol

severe tangle Aug 31, 2021, 7:07 PM

#

Hey @vocal wolf, so what should be done about bot#1786?

#

bot#1786

dusky shoreBOT Aug 31, 2021, 7:07 PM

#

GitHub

PROpen Rewording botvars.md tag

vocal wolf Aug 31, 2021, 7:08 PM

#

wait until it gets reviewed, I guess

severe tangle Aug 31, 2021, 7:08 PM

#

By Stelercus?

vocal wolf Aug 31, 2021, 7:10 PM

#

dusky shore

@trim cradle ready for re-review.

trim cradle Aug 31, 2021, 7:11 PM

#

vocal wolf <@!253696366952316929> ready for re-review.

yay

#

@vocal wolf I'm not authorized to merge the pull request and I'm really upset about it.

vocal wolf Aug 31, 2021, 7:15 PM

#

lmfao

vocal wolf Aug 31, 2021, 7:15 PM

#

trim cradle <@!196664644113268736> I'm not authorized to merge the pull request and I'm real...

have you tried turning it off and on again?

trim cradle Aug 31, 2021, 7:15 PM

#

vocal wolf have you tried turning it off and on again?

no

vocal wolf Aug 31, 2021, 7:16 PM

#

tis a shame

trim cradle Aug 31, 2021, 7:16 PM

#

lemon_angrysad

severe tangle Aug 31, 2021, 7:16 PM

#

lmao

dim pelican Aug 31, 2021, 7:24 PM

#

@timid sentinel this is what I get for trying to push commits away from my clone set up

fallen patrol Aug 31, 2021, 7:43 PM

#

vocal wolf have you tried turning it off and on again?

don't say that! Microsoft might unintentionally reboot azure!

vocal wolf Aug 31, 2021, 7:43 PM

#

pithink

fallen patrol Aug 31, 2021, 7:43 PM

#

(windows and linux github actions all run on azure)

timid sentinel Aug 31, 2021, 7:52 PM

#

dim pelican <@!493839819168808962> this is what I get for trying to push commits away from m...

No worries no worries.

fallen patrol Aug 31, 2021, 7:58 PM

#

did something happen to https://www.notion.so/pythondiscord/Squashing-a-Pull-Request-191e8efa2fbb4d72840fd17ca37cf7fa ?

Python Discord on Notion

Squashing a Pull Request

This guide will explain how to remove some commits from a Pull Request (or any branch for that matter) in order to slim the PR.

#

it now doesn't show all of the info it used to

#

#

@vale ibex you initially publicized this ^

vale ibex Aug 31, 2021, 8:01 PM

#

What do you think it missing?

fallen patrol Aug 31, 2021, 8:01 PM

#

look at my screenshot

vale ibex Aug 31, 2021, 8:01 PM

#

That screenshot looks like it looks now, just with code blocks removed

fallen patrol Aug 31, 2021, 8:01 PM

#

like this:
<picture should be here>

#

well, they aren't showing up for me 🤔

#

even changed browsers

vale ibex Aug 31, 2021, 8:02 PM

#

Try https://pythondiscord.notion.site/Squashing-a-Pull-Request-191e8efa2fbb4d72840fd17ca37cf7fa

fallen patrol Aug 31, 2021, 8:02 PM

#

https://pythondiscord.notion.site/Squashing-a-Pull-Request-191e8efa2fbb4d72840fd17ca37cf7fa

#

-i

#

that's where I am?!

#

yet clicking that link worked??

dim pelican Aug 31, 2021, 8:03 PM

#

I see two photos in the guide?

vale ibex Aug 31, 2021, 8:03 PM

#

fallen patrol https://pythondiscord.notion.site/Squashing-a-Pull-Request-191e8efa2fbb4d72840fd...

shrugR

fallen patrol Aug 31, 2021, 8:04 PM

#

whatevs

austere hornet Aug 31, 2021, 8:07 PM

#

@vale ibex So I did some thinking about the Mastermind issue and decided that I would try something else. So I thought of a different idea and created a new issue for it. If you are available, could you please take a look at sir-lancebot#836? Would much appreciate it. Tysm!

dusky shoreBOT Aug 31, 2021, 8:07 PM

#

GitHub

IssueOpen Add Hangman game command

austere hornet Aug 31, 2021, 8:07 PM

#

Btw I hope that this is not already on Sir Lancebot - 😬

vocal wolf Aug 31, 2021, 8:10 PM

#

@vale ibex gitkraken is so good for merge conflicts holy crap

#

I've never had such an easy time fixing them up for a squash

dim pelican Aug 31, 2021, 8:40 PM

#

I know what I'm going to checkout next

static canyon Aug 31, 2021, 9:08 PM

#

I'm working on bot#1787 and have come across an issue. My API request is returning a non-expanded version of users, where I need the expanded version (examples below). How can I make it return expanded users?

Infraction search (expanded):py [{'id': 1, 'inserted_at': '2021-08-31T20:37:12.255534Z', 'expires_at': None, 'active': False, 'user': {'id': 442244135840382978, 'name': 'TizzySaurus', 'discriminator': 9615, 'roles': [476190141161930753, 476190408871772171, 476190357927886848, 637792718852063282], 'in_guild': True}, 'actor': {'id': 442244135840382978, 'name': 'TizzySaurus', 'discriminator': 9615, 'roles': [476190141161930753, 476190408871772171, 476190357927886848, 637792718852063282], 'in_guild': True}, 'type': 'note', 'reason': 'testing', 'hidden': True}]Infraction (non-expanded):py [{'id': 1, 'inserted_at': '2021-08-31T20:37:12.255534Z', 'expires_at': None, 'active': False, 'user': 442244135840382978, 'actor': 442244135840382978, 'type': 'note', 'reason': 'testing', 'hidden': True}]

dusky shoreBOT Aug 31, 2021, 9:08 PM

#

GitHub

PROpen Add support for searching infractions by infraction id

cold island Aug 31, 2021, 9:09 PM

#

@static canyon Found it

static canyon Aug 31, 2021, 9:10 PM

#

So /infractions/{infr_id} would be /infractions/expanded/{infr_id}?

#

@cold island

cold island Aug 31, 2021, 9:10 PM

#

You can try

static canyon Aug 31, 2021, 9:10 PM

#

yep, true

cold island Aug 31, 2021, 9:11 PM

#

Btw @brisk brook did you happen to test it before approving?

brisk brook Aug 31, 2021, 9:12 PM

#

Which one?

cold island Aug 31, 2021, 9:12 PM

#

Infraction by ID

brisk brook Aug 31, 2021, 9:12 PM

#

No, if you need me to I'll do that tomorrow

static canyon Aug 31, 2021, 9:12 PM

#

bot_1       | 2021-08-31 21:12:14 | bot.exts.backend.error_handler | DEBUG | API responded with 404 for command infraction```I'll try `/infractions/{infr_id}/expanded` and see what happens

cold island Aug 31, 2021, 9:13 PM

#

brisk brook No, if you need me to I'll do that tomorrow

I mean more in the sense of, you should probably test before approving

brisk brook Aug 31, 2021, 9:13 PM

#

Ah, right

fallen patrol Aug 31, 2021, 9:24 PM

#

static canyon So `/infractions/{infr_id}` would be `/infractions/expanded/{infr_id}`?

Appending to the end of the route would mean /expanded after anything you already have :P

static canyon Aug 31, 2021, 9:25 PM

#

Yeah

#

And it does work at the end

austere hornet Aug 31, 2021, 9:33 PM

#

Question: If I want to assign myself an issue, but I won't have time to implement the new feature for a long time, is it ok to still assign myself the issue or should I wait until I have time and then assign myself?

cold island Aug 31, 2021, 9:34 PM

#

Preferably the latter

austere hornet Aug 31, 2021, 9:34 PM

#

cold island Preferably the latter

Alr, thanks

cold island Aug 31, 2021, 9:37 PM

#

Think about it this way: issues are opened for things we want to see implemented. If you're assigning yourself without intending to work on it in the near future then you're effectively stalling the feature/bug fix

dim pelican Aug 31, 2021, 9:51 PM

#

Is sir-lancebot#834 in the right place? Or should this be in meta or .github?

dusky shoreBOT Aug 31, 2021, 9:51 PM

#

GitHub

IssueOpen Add .gitmessage to allow for consistent commit messages

austere hornet Aug 31, 2021, 10:59 PM

#

cold island Think about it this way: issues are opened for things we want to see implemented...

Yeah, that makes all the sense. Thanks

desert vessel Sep 1, 2021, 1:56 AM

#

green oriole False

i was sleeping-

vocal prairie Sep 1, 2021, 2:02 AM

#

@desert vessel You don't need to close the issue, what I said just means that it should probably wait a little bit. It's a great idea.

desert vessel Sep 1, 2021, 2:02 AM

#

vocal prairie <@!786599434960109568> You don't need to close the issue, what I said just means...

oh,

#

as xithrus mentioned, wasnt this solved in another pr ?

#

#

@vocal prairie here ^

vocal prairie Sep 1, 2021, 2:04 AM

#

No, that just adds the tag group functionality, which could be used to implement this feature.

desert vessel Sep 1, 2021, 2:04 AM

#

oh well,

#

i've reopened it for now

#

thanks for the clarification!

short snow Sep 1, 2021, 2:12 AM

#

i just noticed seb doesn't have the project leads role, isn't he the project lead for API?

#

sir-lancebot#618 Rebasing upstream main into my branch, I have messed up the whole commit history 😔 What should I do now? Let it stay? And rebased it to get the new cs/python quiz questions and the rapidfuzz change

dusky shoreBOT Sep 1, 2021, 2:22 AM

#

GitHub

PROpen Wikiguess Game

fallen patrol Sep 1, 2021, 2:43 AM

#

first off, don't do anything else locally. There are ways to fix it from where you are

#

The previous commits still exist in your local copy. but any commands you run to fix it can fuck it up and get them gone

#

@short snow^

short snow Sep 1, 2021, 2:50 AM

#

umm probably, also what's the correct way to rebase to not let such things happen in future

fallen patrol Sep 1, 2021, 3:09 AM

#

short snow umm probably, also what's the correct way to rebase to not let such things happe...

imo git rebase -i

#

which is an interactive rebase

dim pelican Sep 1, 2021, 10:24 AM

#

Also git reflog to check where the HEAD was at when the changes were made, then git reset (or revert?) HEAD~<number to reset to>

vocal wolf Sep 1, 2021, 10:33 AM

#

dim pelican Also `git reflog` to check where the HEAD was at when the changes were made, the...

I usually do resets by hash and not by relative to head since it's harder to mess up

old shard Sep 1, 2021, 10:40 AM

#

.bm doesn't seem to be working

cold island Sep 1, 2021, 10:43 AM

#

.bm 882575523195281408

vale ibex Sep 1, 2021, 10:45 AM

#

incident_investigating

#

Ah, permissions_in has been removed in d.py 2.0

#

Go forth and review sir-lancebot#838

dusky shoreBOT Sep 1, 2021, 10:55 AM

#

GitHub

PROpen Use permissions_for over permissions_in

dim pelican Sep 1, 2021, 11:34 AM

#

vocal wolf I usually do resets by hash and not by relative to head since it's harder to mes...

Well if there is one thing I'm good at, its messing up some git 😉

I'll have to give the git rebase -i a try, and probably start using the commit hash for the git reset

short snow Sep 1, 2021, 11:51 AM

#

Due to my half-yearly exams, I will be going on a 1 and a half month break after the end of this week. So if anyone has got some time, it would great to get my PRs complete 🙂 Thanks!

dusky shoreBOT Sep 1, 2021, 11:51 AM

#

GitHub

PROpen Use permissions_for over permissions_in

static canyon Sep 1, 2021, 11:57 AM

#

    async def cog_command_error(self, ctx: Context, error: commands.CommandError) -> None:
        """Handles errors for commands within this cog."""
        ...

        elif isinstance(error, commands.ConversionError):
            await ctx.send(f":x: A corresponding infraction for {XXXX} could not be found.")

        ...```does anyone know how I can get the value that failed the conversion from the error?

vale ibex Sep 1, 2021, 12:10 PM

#

You should be able to str() the error to get what was passed into the error when it was raised

#

what actually gets passed into the raise error depends on the converter

static canyon Sep 1, 2021, 12:25 PM

#

vale ibex what actually gets passed into the raise error depends on the converter

It's the Infraction converter so what gets returned is just the 404 error

#

Something like Status: 404 Response: {'detail': 'Not found.'}

vale ibex Sep 1, 2021, 12:26 PM

#

look like it's raising a BadArguement inside the converter

#

you could create the error, add a custom attr and then raise it I guess

static canyon Sep 1, 2021, 12:27 PM

#

vale ibex you could create the error, add a custom attr and then raise it I guess

That's what I'm doing atm

vale ibex Sep 1, 2021, 12:28 PM

#

This is what I'm seeing atm ```py
class Infraction(Converter):
"""
Attempts to convert a given infraction ID into an infraction.

Alternatively, `l`, `last`, or `recent` can be passed in order to
obtain the most recent infraction by the actor.
"""

async def convert(self, ctx: Context, arg: str) -> t.Optional[dict]:
    """Attempts to convert `arg` into an infraction `dict`."""
    if arg in ("l", "last", "recent"):
        params = {
            "actor__id": ctx.author.id,
            "ordering": "-inserted_at"
        }

        infractions = await ctx.bot.api_client.get("bot/infractions", params=params)

        if not infractions:
            raise BadArgument(
                "Couldn't find most recent infraction; you have never given an infraction."
            )
        else:
            return infractions[0]

    else:
        return await ctx.bot.api_client.get(f"bot/infractions/{arg}")

#

is this the converter you're talking about?

#

So I'm guessing the 404 is from that final line

#

so you could add some logic there to raise if it returns a 404 there

#

api_client.get handles a 404 locally and raises a ResponseCodeError

static canyon Sep 1, 2021, 12:35 PM

#

I'll show what I'm doing in a second

#

class Infraction(...):
    async def convert(...):
        ...
        else:
            try:
                return await ctx.bot.api_client.get(f"bot/infractions/{arg}/expanded")
            except ResponseCodeError as e:
                if e.status == 404:
                    raise BadArgument(f"Failed to convert '{arg}' to an infraction.", arg)
                raise e
``````py
async def cog_command_error(...):
    ....
    elif isinstance(error, commands.BadArgument):
        await ctx.send(f":x: Could not find a corresponding infraction for `{error.args[1]}`.")
    ...``` @vale ibex this is what I'm doing now

#

So i catch the error in the converter and raise a different error with arg, which is caught in cog_command_error

#

Which results in this behaviour

vale ibex Sep 1, 2021, 12:40 PM

#

What's the desired behaviour?

static canyon Sep 1, 2021, 12:40 PM

#

I'm happy with what I've got now

vale ibex Sep 1, 2021, 12:40 PM

#

Ah cool

static canyon Sep 1, 2021, 12:40 PM

#

Just not sure if there's a tidier way that you/anyone can think of

vale ibex Sep 1, 2021, 12:41 PM

#

to avoid error.args[1] I wonder if you can do ```py
bad_arg_error = BadArgument(f"Failed to convert '{arg}' to an infraction.")
bad_arg_error.infr_search = arg
raise bad_arg_error
...
f":x: Could not find a corresponding infraction for {error.infr_search}."

static canyon Sep 1, 2021, 12:42 PM

#

Hmm

vale ibex Sep 1, 2021, 12:42 PM

#

not saying one is better than the other

static canyon Sep 1, 2021, 12:43 PM

#

It gives a linting error in the handler saying BadArgument has no attribute 'infr_search'

vale ibex Sep 1, 2021, 12:44 PM

#

hmmm, guess you can't do that then

static canyon Sep 1, 2021, 12:44 PM

#

Although I think the actual test lint passes (poetry run task lint)

static canyon Sep 1, 2021, 12:44 PM

#

static canyon Although I think the actual test lint passes (`poetry run task lint`)

Yeah, it does

#

So I've got the option

#

Although I do personally prefer just using .args[1]

#

Yeah, I'll keep it .args[1]

vale ibex Sep 1, 2021, 12:47 PM

#

👌

desert vessel Sep 1, 2021, 12:48 PM

#

can someone help me with this

#

i have pylance installed

#

but there are no suggestions

brazen charm Sep 1, 2021, 12:52 PM

#

you could create a subclass of the exception to properly set the attribute

desert vessel Sep 1, 2021, 12:53 PM

#

alright 👍

#

for me, vscode autosuggestion generally dont work

static canyon Sep 1, 2021, 12:53 PM

#

vale ibex 👌

I've tweaked things around a bit but am happy now so going to commit and push 👍

vale ibex Sep 1, 2021, 12:53 PM

#

Wait, doesn't the api wrapper deal with errors in maybe_raise_for_status already

#

So it should be raising ResponseCodeError for 404 already afaik

brazen charm Sep 1, 2021, 12:55 PM

#

It'll go to the generic "According to the API, your request is malformed." message for api errors

#

(or whatever is appropriate for the error code)
Not sure how helpful that is

vale ibex Sep 1, 2021, 12:56 PM

#

True

#

The reason I mention it is since ResponseCodeError already has custom attrs

#

so you could add another one for the endpoint url and then get it from there

static canyon Sep 1, 2021, 12:57 PM

#

I've already done this now lemon_sweat

#

My head hurts too much to change it now lol

#

Just gonna push this because it works and I've spent way too many hours on this already

vale ibex Sep 1, 2021, 1:00 PM

#

Sure

static canyon Sep 1, 2021, 1:02 PM

#

bot#1804 is finally up

dusky shoreBOT Sep 1, 2021, 1:02 PM

#

GitHub

PROpen Add support for !infraction last

static canyon Sep 1, 2021, 1:03 PM

#

I did not expect that to take almost 2 hours lol

dim pelican Sep 1, 2021, 2:58 PM

#

Is it more common to ping people in GitHub or here to request a re-review?

short snow Sep 1, 2021, 2:59 PM

#

re-request on github

#

trivia_night 👀 esoteric_challenges 👀

#

are these hints to the next events @thorny obsidian

thorny obsidian Sep 1, 2021, 3:07 PM

#

haha yup. Those are future events. Still in the planning stages though. I'm trying to scope out the functionality for it and that lead me to... well this issue

#

short snow Sep 1, 2021, 3:07 PM

#

weeeee

#

wait when did u loose our your admin role

thorny obsidian Sep 1, 2021, 3:08 PM

#

#changelog

short snow Sep 1, 2021, 3:08 PM

#

Oh 😔

dim pelican Sep 1, 2021, 3:19 PM

#

@fervent sage sir-lancebot#833 is ready for you, there have been some changes since my last requested review and now

dusky shoreBOT Sep 1, 2021, 3:19 PM

#

GitHub

PROpen Teapot support - Continues PR #610

fallen patrol Sep 1, 2021, 7:03 PM

#

Ignore me, sorry

#

!guild

stable mountainBOT Sep 1, 2021, 7:03 PM

#

Server Information

Created: <t:1483877013:R>
Voice region: europe
Features: DISCOVERABLE, ANIMATED_ICON, BANNER, ROLE_ICONS, INVITE_SPLASH, PREVIEW_ENABLED, NEWS, VIP_REGIONS, PARTNERED, VANITY_URL, PRIVATE_THREADS, MEMBER_VERIFICATION_GATE_ENABLED, RELAY_ENABLED, COMMUNITY, NEW_THREAD_PERMISSIONS, THREADS_ENABLED, SEVEN_DAY_THREAD_ARCHIVE, THREE_DAY_THREAD_ARCHIVE, WELCOME_SCREEN_ENABLED
Roles: 90
Member status: status_online 53,398 status_offline 194,213

Members: 247,611

Helpers: 124
Moderation Team: 31
Admins: 14
Owners: 3
Contributors: 40
Leads: 14

Channels: 241

Category: 32
News: 9
Staff: 65
Stage_Voice: 1
Text: 125
Voice: 9

fallen patrol Sep 1, 2021, 7:04 PM

#

Role icons O.o

#

Don't see events on there tho

patent pivot Sep 1, 2021, 10:32 PM

#

no — it should use allowed mentions

#

eh

#

i mean

#

why

#

it can't ping anyone

trail pilot Sep 1, 2021, 10:36 PM

#

Question - would a .project command in sir lancebot be useful?

I know we already have !projects, but this is an assumption that most people won't really take their time to check out the webpage and actually find a project they link

The .project command I'm thinkinig of would just get a single idea from a YAML with different categories, like 'beginner', 'intermediate', and 'advanced'

cold island Sep 1, 2021, 10:36 PM

#

It can't

#

It uses allowed mentions and I just checked now with a few roles to make sure

trail pilot Sep 1, 2021, 10:37 PM

#

trail pilot Question - would a .project command in sir lancebot be useful? I know we alread...

A potential downside as someone mentioned earlier would be that this would spawn questions like 'how do I know if I'm advanced?', etc

#

I'm wondering what your all's thoughts are because I think it's probably better to talk here before making an issue for something that may not even be needed

cold island Sep 1, 2021, 10:56 PM

#

We turned down previous suggestion to maintain our own list of projects

#

So I don't think this is much different

#

There are great resources out there, Ned's list is one of them

trail pilot Sep 1, 2021, 10:56 PM

#

Ah, alright

#

Thanks for letting me know

cold island Sep 1, 2021, 11:01 PM

#

If you had a way to pull from an existing list (without burdening the host), that would be something to consider

trail pilot Sep 1, 2021, 11:16 PM

#

cold island If you had a way to pull from an existing list (without burdening the host), tha...

so using bs4 I'm guessing, like how the python bot uses bs4 for the Python documentation module?

cold island Sep 2, 2021, 12:13 AM

#

If whatever that is has a public API then better. And with caching so it's only fetched once while the bot is up.

I don't know how good this is, but if it's interesting to you you can open an issue so that it can be discussed more thoroughly, preferably with the website you'd like to fetch the projects from.

trim cradle Sep 2, 2021, 12:48 AM

#

Traceback (most recent call last):
  File "/home/steele/.cache/pypoetry/virtualenvs/site-AnmfhEHv-py3.9/lib/python3.9/site-packages/environ/environ.py", line 273, in get_value
    value = self.ENVIRON[var]
  File "/usr/lib/python3.9/os.py", line 679, in __getitem__
    raise KeyError(key) from None
KeyError: 'SECRET_KEY'

Tell me the secret

patent pivot Sep 2, 2021, 12:56 AM

#

just need to set a dummy secret key env var

trim cradle Sep 2, 2021, 1:04 AM

#

patent pivot just need to set a dummy secret key env var

SECRET_KEY=joeiscool
DATABASE_URL=whattheresmore
METRICITY_DB_URL=youliedtomejoe

patent pivot Sep 2, 2021, 1:10 AM

#

true i lied 😔

#

we'll just hardcode the secret key and operate pythondiscord.com on a trust basis from hereon

trim cradle Sep 2, 2021, 1:29 AM

#

Anyway a bunch of tests failed. I suggest that you force approve my PR and then we'll fix it in prod.

vale ibex Sep 2, 2021, 10:13 AM

#

@reef tinsel

#

This would be the best place to ask questions/get feedback on designs 😄

reef tinsel Sep 2, 2021, 10:13 AM

#

👍

vale ibex Sep 2, 2021, 10:13 AM

#

ref bot#1765 for others out of the loop

dusky shoreBOT Sep 2, 2021, 10:13 AM

#

GitHub

IssueOpen Shoutout our patreon supporters!

reef tinsel Sep 2, 2021, 10:25 AM

#

Does the bot have any slash commands? (In other words, do I need to add application.commands for inviting to my server?

vale ibex Sep 2, 2021, 10:26 AM

#

Nope, no slash commands in any of our main bots atm

#

since d.py doesn't support them

reef tinsel Sep 2, 2021, 10:26 AM

#

Ok!

#

Having had a look at the patreon page, I presume the 3 tiers you mention correspond to the ones that gives the cosmetic role colour?

vale ibex Sep 2, 2021, 10:38 AM

#

yup yup

#

The role IDs are in the issue

reef tinsel Sep 2, 2021, 10:38 AM

#

Yep

#

What ext should I put the code in?

vale ibex Sep 2, 2021, 10:40 AM

#

I'd make a new one

reef tinsel Sep 2, 2021, 10:40 AM

#

Ok

vale ibex Sep 2, 2021, 10:40 AM

#

I think putting it in the info folder makes the most sense

reef tinsel Sep 2, 2021, 10:43 AM

#

I guess I should add some config in config.yml-guilds-roles so that it is easy to set this up for testing in development guilds?

vale ibex Sep 2, 2021, 10:43 AM

#

Yea, add the role ids in the issue into the config-default.yml

#

then it can be overridden to your test server IDs in the config.yml file

reef tinsel Sep 2, 2021, 10:44 AM

#

👍

reef tinsel Sep 2, 2021, 11:29 AM

#

When I run docker-compose up, I get some sort of file not found error:

What might be the problem?

#

Traceback (most recent call last):
  File "docker\api\client.py", line 214, in _retrieve_server_version
  File "docker\api\daemon.py", line 181, in version
  File "docker\utils\decorators.py", line 46, in inner
  File "docker\api\client.py", line 237, in _get
  File "requests\sessions.py", line 543, in get
  File "requests\sessions.py", line 530, in request
  File "requests\sessions.py", line 643, in send
  File "requests\adapters.py", line 439, in send
  File "urllib3\connectionpool.py", line 670, in urlopen
  File "urllib3\connectionpool.py", line 392, in _make_request
  File "http\client.py", line 1255, in request
  File "http\client.py", line 1301, in _send_request
  File "http\client.py", line 1250, in endheaders
  File "http\client.py", line 1010, in _send_output
  File "http\client.py", line 950, in send
  File "docker\transport\npipeconn.py", line 32, in connect
  File "docker\transport\npipesocket.py", line 23, in wrapped
  File "docker\transport\npipesocket.py", line 72, in connect
  File "docker\transport\npipesocket.py", line 52, in connect
pywintypes.error: (2, 'CreateFile', 'The system cannot find the file specified.')

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "docker-compose", line 3, in <module>
  File "compose\cli\main.py", line 81, in main
  File "compose\cli\main.py", line 200, in perform_command
  File "compose\cli\command.py", line 60, in project_from_options
  File "compose\cli\command.py", line 152, in get_project
  File "compose\cli\docker_client.py", line 41, in get_client
  File "compose\cli\docker_client.py", line 170, in docker_client
  File "docker\api\client.py", line 197, in __init__
  File "docker\api\client.py", line 221, in _retrieve_server_version
docker.errors.DockerException: Error while fetching server API version: (2, 'CreateFile', 'The system cannot find the file specified.')
[15916] Failed to execute script docker-compose

short snow Sep 2, 2021, 11:30 AM

#

docker environment is running

reef tinsel Sep 2, 2021, 11:30 AM

#

I don't have any experience with docker, so I don't know what you mean?

short snow Sep 2, 2021, 11:32 AM

#

"docker" isn't running on your system and docker-compsoe is trying to interact with it basically

#

are you using docker desktop?

reef tinsel Sep 2, 2021, 11:33 AM

#

i installed the docker on this page https://docs.docker.com/desktop/windows/install/ earlier this morning

Docker Documentation

Install Docker Desktop on Windows

How to install Docker Desktop for Windows

vale ibex Sep 2, 2021, 11:33 AM

#

make sure docker desktop is running

reef tinsel Sep 2, 2021, 11:33 AM

#

so i presume yes to our question

reef tinsel Sep 2, 2021, 11:33 AM

#

vale ibex make sure docker desktop is running

aah, it isn't open, I guess that might be why 🙂

short snow Sep 2, 2021, 11:33 AM

#

you would see a docker icon on the taskbar on the right hand corner, like ⤵️

vale ibex Sep 2, 2021, 11:34 AM

#

yea, it doesn't need to be fully open, as long as it's started and the icon in on your taskbar, it's fine

short snow Sep 2, 2021, 11:34 AM

#

https://media.discordapp.net/attachments/635950537262759947/880785935552364604/unknown.png?width=44&height=49

#

credit: chris

#

lol

reef tinsel Sep 2, 2021, 11:37 AM

#

docker is telling me something about WSL, do I need WSL, or can I use docker without this?

vale ibex Sep 2, 2021, 11:38 AM

#

Yea, you'll need to have wsl unless you have windows pro and can use hyper-v

#

hyper-v is slower anyway, so you likely want wsl

reef tinsel Sep 2, 2021, 11:38 AM

#

ok

vale ibex Sep 2, 2021, 11:38 AM

#

the link you posted above has info on how to setup the wsl2 backend

green oriole Sep 2, 2021, 11:39 AM

#

Hyper-V is also windows pro edition only

short snow Sep 2, 2021, 11:39 AM

#

offtopic, but why does it need wsl2 backend or hyper-v?

green oriole Sep 2, 2021, 11:39 AM

#

But you already said that

#

🏃

thorny obsidian Sep 2, 2021, 11:39 AM

#

Because it needs to run on a linux system at some point.

gritty wind Sep 2, 2021, 11:39 AM

#

Different arch for windows

green oriole Sep 2, 2021, 11:39 AM

#

It needs a running Linux kernel, yeah

gritty wind Sep 2, 2021, 11:39 AM

#

Actually the getting started guide explains that in the first paragraph https://docs.docker.com/desktop/windows/wsl/

green oriole Sep 2, 2021, 11:40 AM

#

Containers are just an abstraction made around various kernel isolation systems

#

All of your containers are in fact running on the host kernel, just in different groups

vale ibex Sep 2, 2021, 11:41 AM

#

docker desktop is just a glorified VM manager kek

green oriole Sep 2, 2021, 11:41 AM

#

That's the main difference with regular VMs

reef tinsel Sep 2, 2021, 11:41 AM

#

once i've installed WSL, will I also need to install a version of linux, or will docker manage that for me?

short snow Sep 2, 2021, 11:42 AM

#

Ah, (https://superuser.com/questions/889472/docker-containers-have-their-own-kernel-or-not explains why)

green oriole Sep 2, 2021, 11:42 AM

#

You need to install any version of WSL2 and you are good to go

gritty wind Sep 2, 2021, 11:42 AM

#

Just WSL, though you may find other things helpful for other projects

#

for docker, just wsl though

reef tinsel Sep 2, 2021, 11:42 AM

#

ok, so no need to install a linux

gritty wind Sep 2, 2021, 11:42 AM

#

no

green oriole Sep 2, 2021, 11:42 AM

#

WSL is Linux

vale ibex Sep 2, 2021, 11:43 AM

#

"Windows subsystem for linux"

reef tinsel Sep 2, 2021, 11:43 AM

#

im confused

gritty wind Sep 2, 2021, 11:43 AM

#

I know, which is why I said no 🤡

reef tinsel Sep 2, 2021, 11:43 AM

#

because i on the wsl page it says something about installing a linux

#

https://docs.microsoft.com/en-gb/windows/wsl/install-win10#step-4---download-the-linux-kernel-update-package in step 6

Install WSL on Windows 10

Learn how to install Linux distributions on your Windows 10 machine, with a Bash terminal, including Ubuntu, Debian, SUSE, Kali, Fedora, Pengwin, and Alpine.

gritty wind Sep 2, 2021, 11:43 AM

#

WSL is linux like Akarys mentioned, you just need to install it

green oriole Sep 2, 2021, 11:44 AM

#

Installing WSL goes in two step, enabling it then installing a specific distro from the store

gritty wind Sep 2, 2021, 11:44 AM

#

That's an update fie you have to install

vale ibex Sep 2, 2021, 11:44 AM

#

WSL is a backend for linux, if you want access to a linux environment, then you need to install a linux distro too. But since you just want it for docker, no need to install a distro

gritty wind Sep 2, 2021, 11:44 AM

#

green oriole Installing WSL goes in two step, enabling it then installing a specific distro f...

You don't need step 2 for docker

#

Source: I just set up a new PC

green oriole Sep 2, 2021, 11:45 AM

#

Oh that's interesting

#

I guess it boots up it's own WSL distro, which makes more sense when you think about it

vale ibex Sep 2, 2021, 11:45 AM

#

yup yup

gritty wind Sep 2, 2021, 11:45 AM

#

It does yeah

C:\Users\hassa>wsl -l --all
Windows Subsystem for Linux Distributions:
docker-desktop (Default)
Ubuntu
docker-desktop-data

#

Ubuntu is ubuntu 20 from the store

dim pelican Sep 2, 2021, 11:52 AM

#

When you are all testing changes, do you have to stop and reload docker? That is what I've been doing but didn't know if there was a different way

vale ibex Sep 2, 2021, 11:53 AM

#

yea, or reload the cog

short snow Sep 2, 2021, 11:53 AM

#

while working on the bot?

#

yeah I reloed the cog

#

!c r <cog> or .c r <cog>

vale ibex Sep 2, 2021, 11:53 AM

#

to make it faster you can do docker-compose up bot

#

or sir-lancebot if you're working on that

#

that will mean when you ctrl+c to stop it, the other things still run in the background

#

so starting it back up is faster

dim pelican Sep 2, 2021, 11:55 AM

#

Sweet, I figured I was doing something clunky

#

~~Is .bm whitelisted yet?~~ it is not

vale ibex Sep 2, 2021, 11:56 AM

#

in help channels yes, not in all channels yet

#

there's an issue for it

short snow Sep 2, 2021, 11:57 AM

#

@vocal wolf Uhhh just to inform you as you are the triage lead, from tomorrow I am going on a break due to my half-yearly exams for a month (or a bit more). So in case some of PR gets on high priority, any1 can takeover it if I don't respond.

reef tinsel Sep 2, 2021, 12:17 PM

#

vale ibex Yea, add the role ids in the issue into the config-default.yml

Should I add the roles like this:

roles:
patreon_tier_1
patreon_tier_2
patreon_tier_3

Or:
roles:
patreon:
tier_1
tier_2
tier_3
?

vale ibex Sep 2, 2021, 12:17 PM

#

the former

reef tinsel Sep 2, 2021, 12:17 PM

#

Ok

brazen charm Sep 2, 2021, 12:43 PM

#

dim pelican When you are all testing changes, do you have to stop and reload docker? That is...

the bots can also easily be ran without docker for faster restarts, attaching a debugger etc.

dim pelican Sep 2, 2021, 12:45 PM

#

brazen charm the bots can also easily be ran without docker for faster restarts, attaching a ...

🤯 Wait what? I thought that docker was what allowed the bots to "live" and respond in discord. All that I know about Docker or running bots comes from the contributing guide and a little extra googling

brazen charm Sep 2, 2021, 12:46 PM

#

Docker is there to make the setup easier and reproducible, but for the bots itself it's already fairly easy through poetry

#

I have redis, postgres and the site running in docker and the bot has a run config in pycharm and is ran directly

dim pelican Sep 2, 2021, 12:47 PM

#

Hmmmmm, I use VS Code but you are saying I just run the __main__.py to make the bot live

short snow Sep 2, 2021, 12:47 PM

#

poetry run task start ^^ would do that

#

yeah

gritty wind Sep 2, 2021, 12:47 PM

#

dim pelican Hmmmmm, I use VS Code but you are saying I just run the `__main__.py` to make th...

Run it as a module like rick mentioned

short snow Sep 2, 2021, 12:47 PM

#

but inside the venv

#

I only use docker for redis when needed, otherwise run everything normally

dim pelican Sep 2, 2021, 12:48 PM

#

Wow I'm over here like "Well I made a small change, let's stop Docker, then run it again to test"

gritty wind Sep 2, 2021, 12:48 PM

#

The default docker compose does load all changes from your harddrive

short snow Sep 2, 2021, 12:48 PM

#

and for changes to cogs, i would reload the cog

gritty wind Sep 2, 2021, 12:48 PM

#

Though I personally do what Numerlor does

brazen charm Sep 2, 2021, 12:49 PM

#

reloading the extension usually works and is faster than a normal restart too, but there are things that will persist

dim pelican Sep 2, 2021, 12:51 PM

#

To summarize for my future self:

Options:

Run Docker, make change, Stop Docker, Run Again (bad) docker start -d snekbox redis postgres web
poetry run task start from the root, if outside the venv
task start if inside the venv
py -m <bot/sir-lancebot> from the root, inside the venv
Set up a run task (automatically run py -m <bot/sir-lancebot>)
If changing a cog, reload cog from the discord channel with !c r <cog> or .c r <cog>

brazen charm Sep 2, 2021, 12:52 PM

#

You shouldn't run the main file directly as it won't initialize the package

#

pycharm can be set up to run a module, not sure about vscode

dim pelican Sep 2, 2021, 12:53 PM

#

What is the setup for that run task?

brazen charm Sep 2, 2021, 12:53 PM

#

probably python -m bot

dim pelican Sep 2, 2021, 12:54 PM

#

So like my new edit above?

gritty wind Sep 2, 2021, 12:54 PM

#

The python extension for VSCode makes it possible, but I haven't played around with it much

#

What you have looks right

dim pelican Sep 2, 2021, 12:55 PM

#

Sweet, going to bookmark that for myself

gritty wind Sep 2, 2021, 12:55 PM

#

Maybe add a note about starting the other tasks too

#

docker start -d snekbox redis postgres web should do ya

#

or an override

short snow Sep 2, 2021, 12:56 PM

#

dim pelican To summarize for my future self: Options: 1. Run Docker, make change, Stop Dock...

if you do poetry run you don't need to be inside the venv, poetry run would run it inside the environment for you. Basically poetry run <command> runs that command inside the venv

#

so you can run task start if you are inside teh venv

#

no, remove the poetry, just task start (context: they edited the msg)

#

yep

dim pelican Sep 2, 2021, 12:59 PM

#

Time to open an issue on site to add this to the contributing guidelines lol. Surely other people have gone through what I'm running into

dim pelican Sep 2, 2021, 1:31 PM

#

site#574

dusky shoreBOT Sep 2, 2021, 1:31 PM

#

GitHub

IssueOpen Add more details on how to start / reload a bot during testing

clever wraith Sep 2, 2021, 1:33 PM

#

Congrats @solar locust on contributor

dim pelican Sep 2, 2021, 2:24 PM

#

You are now DD

clever wraith Sep 2, 2021, 2:58 PM

#

Yes

#

Shoot

reef tinsel Sep 2, 2021, 3:27 PM

#

is this the correct syntax for getting a role id? (saved in config.yml)

from bot.constants import Guild

patreon_tier_1_role = Guild.roles.patreon_tier_1

vale ibex Sep 2, 2021, 3:28 PM

#

it would be ```py
from bot.constants import Roles
patreon_tier_1_role = Roles.patreon_tier_1

#

look at constants.py

reef tinsel Sep 2, 2021, 3:29 PM

#

ok

#

looking at constants.py, do I need to add my 3 roles to the Roles class?

#

I presume so

vale ibex Sep 2, 2021, 3:30 PM

#

yup yup

#

constants.py is what reads the yml files

#

and makes the constants available to the project

short snow Sep 2, 2021, 3:43 PM

#

2 new contribs 🎉

vale ibex Sep 2, 2021, 3:43 PM

#

maybe more, news to come soon

#

just waiting on some responses, have an announcement prepped

short snow Sep 2, 2021, 3:44 PM

#

Ooo

warm vigil Sep 2, 2021, 4:10 PM

#

Hey, is any of PyDis bots slated to move over to slash commands via HTTP?

vale ibex Sep 2, 2021, 4:11 PM

#

no plans for it atm, no

#

our short term plans are to migrate to d.py 2.0 for the other interactions

#

and then wait a few weeks/months to see what other libs arise

#

ideally we don't want to re-write our bots

warm vigil Sep 2, 2021, 4:12 PM

#

ok, it's fine, we are having VC discussion about if your bot is call and response, get ahead of curve, switch to slash commands over HTTP

brazen charm Sep 2, 2021, 4:12 PM

#

@vale ibex site#571 will also need to be merged before the optional base url can be used w/o an error

dusky shoreBOT Sep 2, 2021, 4:12 PM

#

GitHub

PROpen Allow the base_url of a documentation link to be empty

vale ibex Sep 2, 2021, 4:13 PM

#

brazen charm <@!126811506632294400> site#571 will also need to be merged before the optional ...

ah, missed that, will look now

#

out of interest was there a need to swap the field order?

vocal wolf Sep 2, 2021, 4:22 PM

#

short snow <@!196664644113268736> Uhhh just to inform you as you are the triage lead, from ...

Good luck on your exams!

brazen charm Sep 2, 2021, 4:26 PM

#

vale ibex out of interest was there a need to swap the field order?

it wasn't necessary, but the optional filed looked weird in the admin panel when it was in the middle

vale ibex Sep 2, 2021, 4:27 PM

#

yea makes sense

vocal wolf Sep 2, 2021, 4:31 PM

#

@brisk brook about the __init__ return annotations, there was about 20 that had been annotated and about 50 that had not been.

#

So I just went ahead and removed the 20 annotations

brisk brook Sep 2, 2021, 4:31 PM

#

Yeah, any plans for how we should keep this consistent?

vocal wolf Sep 2, 2021, 4:32 PM

#

no plans as of now

brisk brook Sep 2, 2021, 4:32 PM

#

Alright

vocal wolf Sep 2, 2021, 4:32 PM

#

hopefully people just notice other files, not sure how we should enforce it

#

enforce it automatically, that is

brisk brook Sep 2, 2021, 4:32 PM

#

Yeah, we'll just have to remember it.

vale ibex Sep 2, 2021, 4:32 PM

#

add mypy

#

kek

vocal wolf Sep 2, 2021, 4:33 PM

#

lol

brisk brook Sep 2, 2021, 4:33 PM

#

I don't think there's a way to setup some CI or tool to check only that

vocal wolf Sep 2, 2021, 4:33 PM

#

I feel like there might be...?

#

ooh

#

regex in a workflow?

brisk brook Sep 2, 2021, 4:33 PM

#

Should we change this page? https://pythondiscord.com/pages/guides/pydis-guides/contributing/style-guide/

Python Discord - Style Guide

Coding conventions for our Open Source projects.

brisk brook Sep 2, 2021, 4:33 PM

#

vocal wolf regex in a workflow?

That's true,

#

There has to be a simple regex CI

vale ibex Sep 2, 2021, 4:33 PM

#

ehhh, I'm not too fond of having something in the style guide that we can't enforce via pre-commit or linting

#

since it's sort of hidden to contribs until PR

vocal wolf Sep 2, 2021, 4:34 PM

#

If def __init__$.*$ -> None finds anything, workflow fails, but an entire workflow just for that is probably not worth it

vale ibex Sep 2, 2021, 4:34 PM

#

I'd be up for adding mypy tbh, if it wasn't for the huge change we'd need to make to the current repo

#

even then I'm still on the side of adding it

vocal wolf Sep 2, 2021, 4:35 PM

#

and we're also removing seasons soon

brazen charm Sep 2, 2021, 4:35 PM

#

the ignore could just be removed from the plugin settings to the annotation is used everywhere

brisk brook Sep 2, 2021, 4:35 PM

#

vale ibex ehhh, I'm not too fond of having something in the style guide that we can't enfo...

Pretty sure the linting doesn't disallow this ```py
def long_function_name_that_is_taking_up_too_much_space(var_one, var_two, var_three, # didn't drop a line after the brackets
var_four, var_five, var_six,
var_seven, var_eight):
print(var_one)

Even though it's specified in the style guide

brisk brook Sep 2, 2021, 4:35 PM

#

vocal wolf If `def __init__$.*$ -> None` finds anything, workflow fails, but an entire wo...

Might grow in the future?

brazen charm Sep 2, 2021, 4:35 PM

#

vale ibex ehhh, I'm not too fond of having something in the style guide that we can't enfo...

reminded me that bot#1641 is still open

dusky shoreBOT Sep 2, 2021, 4:35 PM

#

GitHub

IssueOpen Add flake8-quotes to linting workflow

vocal wolf Sep 2, 2021, 4:36 PM

#

@brisk brook by this: https://github.com/python-discord/sir-lancebot/pull/802#discussion_r700807663 are you talking about https://docs.python.org/3/library/typing.html?highlight=typing final#typing.Final

brisk brook Sep 2, 2021, 4:37 PM

#

Yup

vocal wolf Sep 2, 2021, 4:37 PM

#

I haven't seen many annotations for constants

#

We don't use typing.Final within Sir lance at all

brisk brook Sep 2, 2021, 4:38 PM

#

I am pretty neutral on it, we don't really use strict type checking so the benefit of a failing workflow from breaking those rules are gone. But I thought I'd bring it up

#

Also yes I mean for all constants, it was just those lines that reminded me of it

vocal wolf Sep 2, 2021, 4:39 PM

#

according to my regex search in pycharm, we've never annotated constants

#

unless I've messed up my regex search

brisk brook Sep 2, 2021, 4:39 PM

#

No I don't think we have

#

So yeah we might as well keep it like that, not a big deal

vocal wolf Sep 2, 2021, 4:41 PM

#

ye

dim pelican Sep 2, 2021, 4:41 PM

#

Wait are Numerlor and Bluenix not contributors?

#

Sorry for the ot tangent

vocal wolf Sep 2, 2021, 4:44 PM

#

@brisk brook another ping. For https://github.com/python-discord/sir-lancebot/pull/802#discussion_r700813542, could you elaborate on what you think should be done?

brisk brook Sep 2, 2021, 4:45 PM

#

So previously we did import typing as t. So code that used Iterable would be as follows: def test(arg: t.Iterable[str]), is this not the case?

#

The diff was being weird on my phone, but I see now that you have indeed changed it

#

I'll make it as resolved

vocal wolf Sep 2, 2021, 4:48 PM

#

uhhhhh

#

let me check what it previously was

vocal wolf Sep 2, 2021, 4:48 PM

#

brisk brook So previously we did `import typing as t`. So code that used `Iterable` would be...

It seems that it was always t.Iterable and nothing else.

brisk brook Sep 2, 2021, 4:48 PM

#

This diff didn't show up for me

#

So I thought you only changed the import, and not the code that used it

vocal wolf Sep 2, 2021, 4:49 PM

#

according to git blame it was like this ever since I created the file

vocal wolf Sep 2, 2021, 4:50 PM

#

brisk brook This diff didn't show up for me

github do be wack sometimes

#

@brisk brook final ping. For https://github.com/python-discord/sir-lancebot/pull/802#discussion_r700803591, it's only used as an annotation for self.match: Optional[Match] = None. Should it still be changed to __class_getitem__ regardless?

brisk brook Sep 2, 2021, 4:56 PM

#

Even better, Optional[re.Match] should work

vocal wolf Sep 2, 2021, 5:00 PM

#

brisk brook Even better, `Optional[re.Match]` should work

Alright cool. When was this deprecated? I currently am not finding anything on it.

brisk brook Sep 2, 2021, 5:01 PM

#

https://docs.python.org/3/library/typing.html#typing.Match

vocal wolf Sep 2, 2021, 5:01 PM

#

ah, that's why

#

was searching in re docs lol

brisk brook Sep 2, 2021, 5:03 PM

#

😅

vocal wolf Sep 2, 2021, 5:15 PM

#

This PR is getting ridiculous, there's just so many things that I'm not catching

#

This one https://github.com/python-discord/sir-lancebot/pull/802

#

@clever wraith oh no

#

wait why are we wanting to annotate tuples but haven't covered dicts?

#

uhhhhhh

#

I am thinking about this one lol

gritty wind Sep 2, 2021, 5:36 PM

#

A lot of those can’t be easily modeled just with dicts

#

I’d be for something like pydantic if it helps

vocal wolf Sep 2, 2021, 5:36 PM

#

Probably should be annotated only if it's not almost immediately realized by the program itself.

gritty wind Sep 2, 2021, 5:37 PM

#

But I personally prefer dicts that are annotated, because otherwise they are kinda a PITA to work with

dim pelican Sep 2, 2021, 5:37 PM

#

Pain In The Ass

gritty wind Sep 2, 2021, 5:37 PM

#

Yup

#

What is this referring to

dim pelican Sep 2, 2021, 5:37 PM

#

or delicious pocket bread, depends on the context

gritty wind Sep 2, 2021, 5:38 PM

#

I mean, good annotations can be quite delicious

dim pelican Sep 2, 2021, 5:40 PM

#

This part?

only if it's not almost immediately realized by the program itself.

molten perch Sep 2, 2021, 5:42 PM

#

There are cases when dict is already nested like tuple[int, dict] in that case it might be helpful to annotate, but to be totally honest, it'd look a bit "scary" to newcommers.

brazen charm Sep 2, 2021, 5:42 PM

#

TypedDicts would be nice for all the api interactions

molten perch Sep 2, 2021, 5:51 PM

#

brazen charm `TypedDict`s would be nice for all the api interactions

I believe, for that matter we could use Pydantic then, (as it was mentioned earlier. )
As far as I can see it has a mypy plugin, as well.

celest charm Sep 2, 2021, 5:59 PM

#

or dataclasses and dataclass-factory, it's much smaller than pydantic AFAICT

static canyon Sep 2, 2021, 6:00 PM

#

@celest charm ```py
import random
from typing import Optional

def return_int_or_none() -> Optional[int]:
if random.randint(0, 1) == 0:
return 1
return None

def expects_int(arg: int) -> None:
return

var = return_int_or_none()
assert isinstance(var, int)
expects_int(var)```this works perfectly with the assert, but doesn't work without it

#

Question is, do we want to assert or just an if?

gritty wind Sep 2, 2021, 6:00 PM

#

What if you add an explicit type hint to the variable

celest charm Sep 2, 2021, 6:01 PM

#

it will fail

#

because that's a lie

#

there are also casts

static canyon Sep 2, 2021, 6:02 PM

#

celest charm there are also `cast`s

casts?

celest charm Sep 2, 2021, 6:02 PM

#

https://docs.python.org/3/library/typing.html#typing.cast

static canyon Sep 2, 2021, 6:03 PM

#

Hmm

#

Sopy var: t.cast[int, var] = always_returns_int_although_linter_doesnt_realise()?

celest charm Sep 2, 2021, 6:04 PM

#

no, it's a function

#

cast(int, var)

#

it doesn't actually do anything -- it just signals to the typechecker

static canyon Sep 2, 2021, 6:05 PM

#

@celest charm ```py
import random
from typing import Optional, cast

def return_int_or_none(val: str) -> Optional[int]:
if val == "return":
return 1

def expects_int(arg: int) -> None:
return

var = return_int_or_none("return") # val=="return" so will always return 1 but linter doesn't realise
cast(int, var)
expects_int(var)```so like this?

#

Sorry had the ping copied in that

celest charm Sep 2, 2021, 6:05 PM

#

var = return_int_or_none("return")  # val=="return" so will always return `1`
expects_int(cast(int, var))

#

no worries, I like pings 🙂

static canyon Sep 2, 2021, 6:05 PM

#

right, yeah

#

So in cases where we know it's going to be correct, use cast, and when we're not sure, use assert?

static canyon Sep 2, 2021, 6:07 PM

#

celest charm ```py var = return_int_or_none("return") # val=="return" so will always return ...

This works 👍

celest charm Sep 2, 2021, 6:07 PM

#

cast is useful for stuff like list[tuple[T, int]] which you can't really assert on

static canyon Sep 2, 2021, 6:07 PM

#

Right yeah

celest charm Sep 2, 2021, 6:08 PM

#

assert should also be used only in places where the condition should only be false in the presence of a bug

static canyon Sep 2, 2021, 6:08 PM

#

So potentially even```py
def expects_int(arg: cast(int, arg)) -> None:
return

expects_int(var)```?

celest charm Sep 2, 2021, 6:08 PM

#

???

static canyon Sep 2, 2021, 6:08 PM

#

celest charm `cast` is useful for stuff like `list[tuple[T, int]]` which you can't really `as...

Is that what you meant by this?

celest charm Sep 2, 2021, 6:09 PM

#

You can't put cast into annotations

static canyon Sep 2, 2021, 6:09 PM

#

That doesn't seem right actually

#

Yeah

celest charm Sep 2, 2021, 6:09 PM

#

No I mean, you can't do isinstance(x, list[tuple[T, int]]), But if you believe that it is the case, do cast(list[tuple[T, int]], x)

static canyon Sep 2, 2021, 6:10 PM

#

Right

static canyon Sep 2, 2021, 6:10 PM

#

static canyon So in cases where we know it's going to be correct, use `cast`, and when we're n...

Is this broadly speaking correct btw?

celest charm Sep 2, 2021, 6:10 PM

#

If we're not sure, throw a normal exception

static canyon Sep 2, 2021, 6:10 PM

#

Well that's what assert would do if it was wrong

celest charm Sep 2, 2021, 6:11 PM

#

assert is not for error-checking, it's for establishing some invariant. In production you can disable asserts

#

well, it depends on where it is used

static canyon Sep 2, 2021, 6:13 PM

#

def return_int_or_none() -> Optional[int]:
    if random.randint(0, 1) == 0:
        return 1

var = return_int_or_none()  # we don't know if `var` is an `int` or `None`, so we `assert` to check
assert isinstance(var, int)
expects_int(var)

##

def return_int_or_none(val: str) -> Optional[int]:
    if val == "return":
        return 1

var = return_int_or_none("return")  # we know it's an `int` so use `cast`
expects_int(cast(int, var))```

#

Or would the top be likepy if not isinstance(var, int): raise TypeError("we need an int") expects_int(var)?

celest charm Sep 2, 2021, 6:14 PM

#

static canyon Or would the top be like```py if not isinstance(var, int): raise TypeError("...

yes

static canyon Sep 2, 2021, 6:14 PM

#

Right

celest charm Sep 2, 2021, 6:14 PM

#

well... the example is a bit contrived

#

asserts are usually internal checks, while the errors on the boundary of your function/class should be proper exceptions

dim pelican Sep 2, 2021, 6:15 PM

#

Is it bad that I've only used assert in unit testing?

static canyon Sep 2, 2021, 6:16 PM

#

celest charm `assert`s are usually internal checks, while the errors on the boundary of your ...

Yeah, that makes sense

#

I'm trying to think of something

celest charm Sep 2, 2021, 6:17 PM

#

def inv_sqrt(x: float) -> float:
    if x <= 0:
        raise ValueError("nope, that's not going to fly here")

    sqrt = x ** 0.5
    assert not isinstance(sqrt, complex)
    assert sqrt > 0
    return 1 / sqrt

#

also a bit contrived, but eh

static canyon Sep 2, 2021, 6:18 PM

#

def expects_tuple_of_list_of_int_or_str(arg: tuple[list[Union[int, str]]]) -> None:
    return

var = returns_expected_or_none()  # how do I validate `var` is the expected here?
expects_tuple_of_list_of_int_or_str(var)```

celest charm Sep 2, 2021, 6:19 PM

#

jesus take the wheel

static canyon Sep 2, 2021, 6:19 PM

#

There are situations like that in the bot code

#

So we'd have to deal with that

celest charm Sep 2, 2021, 6:20 PM

#

why would you need to validate the return type of that thing?

static canyon Sep 2, 2021, 6:21 PM

#

I suppose it's or_none so we can just do if var is not None

celest charm Sep 2, 2021, 6:21 PM

#

in that case yes, check if it's none

#

sometimes the invariant is really way too complex, so you'll have to ignore some errors

static canyon Sep 2, 2021, 6:22 PM

#

And when you say "ignore some errors" do you mean add a literal # ignore: [err_type] to the end of the line?

#

Or do you mean "as a human, ignore it"

celest charm Sep 2, 2021, 6:22 PM

#

static canyon And when you say "ignore some errors" do you mean add a literal `# ignore: [err_...

this

static canyon Sep 2, 2021, 6:22 PM

#

right, okay

#

Jesus this is gonna take a while lol

celest charm Sep 2, 2021, 6:23 PM

#

I still wonder if we should put effort into all this

#

are we planning to do it for sir-lancebot as well?

static canyon Sep 2, 2021, 6:24 PM

#

for role_id in role_ids:
    if (role := guild.get_role(role_id)) is not None:
        members += len(role.members)
    else:
        raise NonExistentRoleError(role_id)

return {name or role.name.title(): members}  # `role` is `Role` but linter thinks it's `Optional[Role]`
```so how would I cast here?

celest charm Sep 2, 2021, 6:25 PM

#

cast(Role. role).name.title()
or
assert role is not None before that

#

actually, the correct error would be: "role is possibly unbound"

#

which is what pyright gives

static canyon Sep 2, 2021, 6:25 PM

#

cast(Role, role) (type goes first)

celest charm Sep 2, 2021, 6:26 PM

#

oh, right

#

fixed

static canyon Sep 2, 2021, 6:26 PM

#

The error mypy gives is error: Item "None" of "Optional[Role]" has no attribute "name"

#

So I'd do {name or cast(Role, role).name.title(): members}

celest charm Sep 2, 2021, 6:27 PM

#

yeah

molten perch Sep 2, 2021, 6:27 PM

#

celest charm or dataclasses and `dataclass-factory`, it's much smaller than pydantic AFAICT

Yeah, that seems like a good solution. But is it worth to port everything to dataclasses(and use d-factory)? However, it would type annotations and testing much easier.

celest charm Sep 2, 2021, 6:27 PM

#

testing? pithink

vocal wolf Sep 2, 2021, 6:27 PM

#

We don't want to enforce dictionary type hinting since it'll get bloated very fast (large type annotations), so most dictionaries will remain the same.

molten perch Sep 2, 2021, 6:28 PM

#

I was thinking about pattern matching(might've used the wrong word), realised it's a nonsense for now. I played to much with it 😄

celest charm Sep 2, 2021, 6:30 PM

#

It will add more code, but it does buy us explicitness (and checking that the API actually returns what we expect)

#

we could remove all type annotations, and the code would become more compact

static canyon Sep 2, 2021, 6:30 PM

#

error: Value of type "Infraction" is not indexable```
```py
async def ...(..., infraction: Infraction, ...) -> ...:
     ...
     infraction['id']
     infraction['active']```
Can I fix these with a `cast` as well? mypy thinks `infraction` is of type `Infraction` but it's actually a `dict`

#

I think there was an issue which might fix that actually

celest charm Sep 2, 2021, 6:31 PM

#

static canyon ```py error: Value of type "Infraction" is not indexable``` ```py async def ...(...

Why is it hinted as Infraction then?

static canyon Sep 2, 2021, 6:31 PM

#

celest charm Why is it hinted as `Infraction` then?

It's a dpy converter

celest charm Sep 2, 2021, 6:31 PM

#

ahh

#

yeah we did fix it somehow, right?

#

so that's to be fixed in a different place

molten perch Sep 2, 2021, 6:32 PM

#

celest charm we could remove all type annotations, and the code would become more compact

Indeed, but it sounds like a “spring cleanup” sized PR, and would trash all the typing annotations that have been added.

celest charm Sep 2, 2021, 6:32 PM

#

I wasn't implying we should do that

static canyon Sep 2, 2021, 6:32 PM

#

It was numerlor that fixed iirc

celest charm Sep 2, 2021, 6:33 PM

#

celest charm I wasn't implying we should do that

I meant that type annotations add more code, but they buy explicitness and static analysis

static canyon Sep 2, 2021, 6:33 PM

#

bot#106

dusky shoreBOT Sep 2, 2021, 6:33 PM

#

GitHub

IssueClosed Django API Support: Prettier HTTP error responses

static canyon Sep 2, 2021, 6:34 PM

#

Ah right

#

I need to do likepy Infraction = dictat the bottom of constants.py I think

#

Which in fact is already there

#

Hmm

#

It doesn't seem to be working

molten perch Sep 2, 2021, 6:36 PM

#

celest charm I wasn't implying we should do that

In case you decided so in the future, I would be a partner in this.

celest charm Sep 2, 2021, 6:37 PM

#

I will never vouch for removing all type annotations, no...

vocal wolf Sep 2, 2021, 6:37 PM

#

ok

#

I hope I'm done with this annotation PR

static canyon Sep 2, 2021, 6:37 PM

#

vocal wolf I *hope* I'm done with this annotation PR

~~my one on bot next~~

vocal wolf Sep 2, 2021, 6:37 PM

#

pretty sure bot is fine

#

at least mostly

static canyon Sep 2, 2021, 6:37 PM

#

It's not lol

vocal wolf Sep 2, 2021, 6:37 PM

#

well

#

damn

static canyon Sep 2, 2021, 6:38 PM

#

xD

#

Do you have any ideas about Infraction not being indexable? @celest charm

celest charm Sep 2, 2021, 6:38 PM

#

I have no idea

static canyon Sep 2, 2021, 6:38 PM

#

Welp fk

#

Numerlor's PR should've fixed it but it isn't working

celest charm Sep 2, 2021, 6:41 PM

#

celest charm I meant that type annotations add more code, but they buy explicitness and stati...

Example from xkcd: latest_comic_info is hinted as Dict[str, Union[str, int]]
It's not clear at all what's in this dict, you just have to go to the API docs. It goes completely contrary to our style guide that mandates docstrings and type annotations even on functions/classes which are totally clear without them (like setup() or cog classes)

Instead, you can just do something like ```py
@dataclass
class Xkcd:
num: int
day: str
month: str
year: str
safe_title: str
img: str

and use a library or a hand-written utility function to create these from a json dict

#

.source xkcd

dusky shoreBOT Sep 2, 2021, 6:41 PM

#

Command: xkcd

Getting an xkcd comic's information along with the image.

Source Code

Go to GitHub

celest charm Sep 2, 2021, 6:44 PM

#

I'm not saying we should refactor the code to do that, just some rationale as to why it might make sense to write in this way

molten perch Sep 2, 2021, 6:44 PM

#

Anyways, you wouldn’t remove the typehints totally, just use a different approach. (like in fastapi)

celest charm Sep 2, 2021, 6:45 PM

#

what are you talking about?

molten perch Sep 2, 2021, 6:45 PM

#

You said using a library like that would mean removing typehints totally

celest charm Sep 2, 2021, 6:45 PM

#

Hm?

molten perch Sep 2, 2021, 6:45 PM

#

celest charm I will never vouch for removing all type annotations, no...

Here.

static canyon Sep 2, 2021, 6:45 PM

#

@brazen charm you PRd bot#1731 which I think is what I need here but it doesn't seem to be working

My issue is that in a command I'm typehinting an argument to the Infraction class, and then subscripting it (infraction['active'], infraction['id'] etc.).

Unfortunately mypy is raising an error for this, stating that Value of type "Infraction" is not indexable, despite us having Infraction = t.Optional[dict] in constants.py, which should cover for this. Fwiw I changed to Infraction = dict in case it was the Optional breaking it but still same issue.

The docs do state that mypy supports TYPE_CHECKING so that shouldn't be the issue either.

Please ping on response

dusky shoreBOT Sep 2, 2021, 6:45 PM

#

GitHub

PRMerged Add converter typehints

celest charm Sep 2, 2021, 6:46 PM

#

molten perch Here.

oh, I thought by <#dev-contrib message> you said that you'd like to remove all type annotations from code

#

I think there's some misunderstanding between us

molten perch Sep 2, 2021, 6:47 PM

#

No, not at all. I meant implementing this dataclass-dataclass factory solution. I looked up the library.

celest charm Sep 2, 2021, 6:48 PM

#

well, I'm not sure other people would approve of that

#

after all, that's an extra dependency

molten perch Sep 2, 2021, 6:48 PM

#

Yes, valid point..

celest charm Sep 2, 2021, 6:49 PM

#

and sir-lancebot is a bot for adding fun features, not proving theorems at compile time or something

#

so it's more or less fine to write in a jesus-take-the-wheel style

reef tinsel Sep 2, 2021, 7:12 PM

#

Hi! I am working on bot#1765

I a getting an error while trying to get a role object for a certain role.

I am using

role = discord.Role(id = id)

However this causing an error, presumably because that's not the way to get a role object from an id?

What should I use?

dusky shoreBOT Sep 2, 2021, 7:12 PM

#

GitHub

IssueOpen Shoutout our patreon supporters!

static canyon Sep 2, 2021, 7:19 PM

#

Yeah, you don't get roles like that

#

You do guild.get_role(id)

reef tinsel Sep 2, 2021, 7:20 PM

#

static canyon You do `guild.get_role(id)`

ok

static canyon Sep 2, 2021, 7:20 PM

#

And if you don't have guild then you get that from self.bot.get_guild(constants.Guild.id)

#

You'll also likely need to make sure neither of those are None

reef tinsel Sep 2, 2021, 7:20 PM

#

thank you!

static canyon Sep 2, 2021, 7:20 PM

#

Since if they aren't in cache they'll both return None

reef tinsel Sep 2, 2021, 7:34 PM

#

static canyon Since if they aren't in cache they'll both return `None`

if they aren't in the cache, is there any way for me to load them in?

static canyon Sep 2, 2021, 7:36 PM

#

If you 100% need them then you can do get or fetch

#

i.e role = guild.get_role(id) or await guild.fetch_role(id)

reef tinsel Sep 2, 2021, 7:37 PM

#

ok

static canyon Sep 2, 2021, 7:37 PM

#

Just don't do that when getting Users

vale ibex Sep 2, 2021, 7:38 PM

#

as long as you add await self.bot.wait_until_guild_available() at the start, you should be able to get the roles just fine

reef tinsel Sep 2, 2021, 7:38 PM

#

i only need to get the roles - so the user problem shouldn't be a proble

vale ibex Sep 2, 2021, 7:38 PM

#

since that ensures the role, member and channel caches are populated

brazen charm Sep 2, 2021, 7:39 PM

#

static canyon <@!184351770636582913> you PRd bot#1731 which I think is what I need here but it...

Not sure I haven't checked with mypy, it may have problems with the type checking assignments overwriting existing vars with incompatible types

static canyon Sep 2, 2021, 7:42 PM

#

brazen charm Not sure I haven't checked with mypy, it may have problems with the type checkin...

Ugghhh error: Cannot assign to a type that's the issue

#

mypy doesn't allow for x = type from the looks of it

Or rather, mypy doesn't understand that it's saying "interpret x as y"

dim pelican Sep 2, 2021, 7:43 PM

#

@vocal wolf congrats on that monster PR

vocal wolf Sep 2, 2021, 7:43 PM

#

hell I didn't squash

#

I swear I pressed it

brazen charm Sep 2, 2021, 7:50 PM

#

static canyon mypy doesn't allow for `x = type` from the looks of it Or rather, mypy doesn't ...

Don't know what the nicest way to go around that would be if it's something important; a big if/else on the TYPE_CHECKING would work but I don't think we really want that in the code

static canyon Sep 2, 2021, 7:50 PM

#

brazen charm Don't know what the nicest way to go around that would be if it's something impo...

wdym "a big if/else on the TYPE_CHECKING"?

brazen charm Sep 2, 2021, 7:51 PM

#

static canyon wdym "a big if/else on the TYPE_CHECKING"?

if typing.TYPE_CHECKING:
    # assign names to return values
else:
    # define classes

static canyon Sep 2, 2021, 7:51 PM

#

Hmm

#

I get what you mean

brazen charm Sep 2, 2021, 7:52 PM

#

I'm not familiar with mypy and not that experienced with typing overall so there could be some way around that

static canyon Sep 2, 2021, 7:53 PM

#

It does work but definitely not clean

#

I think subclassing the converters also works but again, not nice

brazen charm Sep 2, 2021, 7:55 PM

#

The initial approach I had in mind with monkeypatching dpy to understand Annotated should work but I don't think we want to change to that unless it's decided that the bot will use mypy (and there isn't a nicer way with the TYPE_CHECKING)

static canyon Sep 2, 2021, 7:56 PM

#

I'll leave these errors for last then

fallen patrol Sep 2, 2021, 7:59 PM

#

dim pelican Is it bad that I've only used `assert` in unit testing?

tldr it depends on the testing framework

#

I think that because pydis uses pytest to run the tests its fine

#

pytest actually rewrites all assert statements

dim pelican Sep 2, 2021, 8:01 PM

#

fallen patrol tldr it depends on the testing framework

Yeah that makes sense. I guess at the time I wrote that I was curious if it was a common thing to use assert outside of a testing scenario

fallen patrol Sep 2, 2021, 8:02 PM

#

ah, idk 🤷‍♀️

static canyon Sep 2, 2021, 8:17 PM

#

Does anyone know how to make mypy recognise log.trace as valid? It currently gives error: "Logger" has no attribute "trace" and this isn't exactly an error we can specify to ignore by adding # ignore [attr-defined] after each call

CC @celest charm since you were helping with mypy earlier

celest charm Sep 2, 2021, 8:18 PM

#

I have no idea

#

maybe make custom stubs for logging? idk how that works

static canyon Sep 2, 2021, 8:22 PM

#

Hmm interesting idea

brisk brook Sep 2, 2021, 8:26 PM

#

dim pelican Yeah that makes sense. I guess at the time I wrote that I was curious if it was ...

Assert is pretty good debugging stuff, you can completely remove them for 0 performance hit

#

So instead of adding sanity checks with it statements and raising errors, use asserts

static canyon Sep 2, 2021, 8:27 PM

#

static canyon Does anyone know how to make `mypy` recognise `log.trace` as valid? It currently...

Just found this article which shows different approaches, but none of them are particularly tidy https://sam.hooke.me/note/2020/03/mypy-and-verbose-logging/

brisk brook Sep 2, 2021, 8:28 PM

#

Sanity checks (if I used the term correctly) is just checks you put in your code to make sure things are as you expect them. Like after a complicated operation you expect certain lists to be empty, etc. You can use asserts there which will raise an error if it isn't the case.

gritty wind Sep 2, 2021, 8:33 PM

#

Possibly importing the logger, or using the one on the bot instance

#

Not sure what’ll happen to the names then though

#

Maybe you could define a custom logger class which just inherits logger, and adds grace (I think we already do this)

#

Anyways, none of this is probably relevant since we were considering removing trace all together

#

Where did we fall on that

brazen charm Sep 2, 2021, 8:35 PM

#

I think it is useful, and can now be used properly with the loggers being controlled through the env var

static canyon Sep 2, 2021, 8:36 PM

#

As much as removing it would make life easy, I do think it's useful

static canyon Sep 2, 2021, 8:40 PM

#

gritty wind Maybe you could define a custom logger class which just inherits logger, and add...

We don't do this btw. We use logging.addLevelName and then logging.Logger.trace = _monkeypatch_trace

#

And that will still have the same issue anyway apparently (according to the article I linked above)

fallen patrol Sep 2, 2021, 8:41 PM

#

gritty wind Maybe you could define a custom logger class which just inherits logger, and add...

you don't.

#

Sadly.

#

and even so, even if you do set a logger class, mypy will still complain because the logging.getLogger method is typed wrongly

#

but there is this

#

!d logging.setLoggerClass

stable mountainBOT Sep 2, 2021, 8:44 PM

#

logging.setLoggerClass


logging.setLoggerClass(klass)```
Tells the logging system to use the class *klass* when instantiating a logger. The class should define `__init__()` such that only a name argument is required, and the `__init__()` should call `Logger.__init__()`. This function is typically called before any loggers are instantiated by applications which need to use custom logger behavior. After this call, as at any other time, do not instantiate loggers directly using the subclass: continue to use the [`logging.getLogger()`](https://docs.python.org/3.10/library/logging.html#logging.getLogger "logging.getLogger") API to get your loggers.

fallen patrol Sep 2, 2021, 8:44 PM

#

so you can subclass logging.Logger and all logger instances will be of that class

#

--

#

(why the fuck is it klass)

brazen charm Sep 2, 2021, 8:45 PM

#

because class is invalid

patent pivot Sep 2, 2021, 8:46 PM

#

yeah klass or _class are quite common substitutes

static canyon Sep 2, 2021, 8:47 PM

#

fallen patrol !d logging.setLoggerClass

Don't think this even helps here

fallen patrol Sep 2, 2021, 8:47 PM

#

brazen charm because class is invalid

ah right, reserved keyword 🤦‍♀️

brisk brook Sep 2, 2021, 8:48 PM

#

Can you import that logger class and always do log: MyLogger = logger.getlogger(__name__)?

fallen patrol Sep 2, 2021, 8:48 PM

#

yeah, that's what I do

#

however

#

mypy will still complain about that assignment statement

static canyon Sep 2, 2021, 8:48 PM

#

I mean it's a one off thing so we can just # ignore imo

fallen patrol Sep 2, 2021, 8:49 PM

#

brisk brook Can you import that logger class and always do `log: MyLogger = logger.getlogger...

arguably doing it this way and ignoring just this is better

static canyon Sep 2, 2021, 8:50 PM

#

Potentially, see bot#1773

dusky shoreBOT Sep 2, 2021, 8:50 PM

#

GitHub

IssueOpen Add mypy to the codebase

static canyon Sep 2, 2021, 8:50 PM

#

fallen patrol yeah, that's what I do

So how exactly does it work? In terms of code

#

Found 1423 errors in 100 files (checked 128 source files)
"fun" is not the right word

#

mhm

#

That's what I'm doing lol

#

I've gotten a fair amount of things worked out

#

But there's still big roadblocks, like the fact we have a custom log.trace which gives an error every time it's used

static canyon Sep 2, 2021, 8:54 PM

#

fallen patrol !d logging.setLoggerClass

This seems to be our best bet for fixing that but not sure how to use it

fallen patrol Sep 2, 2021, 8:54 PM

#

static canyon So how exactly does it work? In terms of code

shadfhasdf

#

i sent it in my dev channel on my server lmao

#

so, I don't use mypy as of right now, but codewise

#

# modmail/__init__.py
from modmail.log import ModmailLogger
logging.TRACE = 5
logging.NOTICE = 25
logging.addLevelName(logging.TRACE, "TRACE")
logging.addLevelName(logging.NOTICE, "NOTICE")
``````py
# modmail/log.py in full
import logging
from typing import Any


class ModmailLogger(logging.Logger):
    """Custom logging class implementation."""

    def trace(self, msg: Any, *args, **kwargs) -> None:
        """
        Log 'msg % args' with severity 'TRACE'.

        To pass exception information, use the keyword argument exc_info with
        a true value, e.g.

        logger.trace("Houston, we have a %s", "low-level problem", exc_info=1)
        """
        self.log(logging.TRACE, msg, *args, **kwargs)

    def notice(self, msg: Any, *args, **kwargs) -> None:
        """
        Log 'msg % args' with severity 'NOTICE'.

        To pass exception information, use the keyword argument exc_info with
        a true value, e.g.

        logger.notice("Houston, we have a %s", "not-quite-a-warning problem", exc_info=1)
        """
        self.log(logging.NOTICE, msg, *args, **kwargs)

#

Those docstrings were taken directly from the library in order to keep consistency between custom levels and built in levels

#

In retrospec, I would probably move the stuff from init.py to modmail/log.py

static canyon Sep 2, 2021, 8:55 PM

#

Where do you use setLoggerClass?

#

.gh repo discord-modmail/modmail

dusky shoreBOT Sep 2, 2021, 8:56 PM

#

discord-modmail

modmail

A Modmail bot for Discord. Allowing safe moderator conversations with server members one server at a time.

fallen patrol Sep 2, 2021, 8:56 PM

#

https://github.com/discord-modmail/modmail/blob/main/modmail/__init__.py handles most of the logging stuff right now

static canyon Sep 2, 2021, 8:59 PM

#

ty

gritty wind Sep 2, 2021, 9:01 PM

#

Here is a working solution that doesn't require humdereds of ignors:

#

import logging
import typing

logging.addLevelName(5, "trace")


class Logger(logging.Logger):
    def trace(self: logging.Logger, msg: str, *args, **kwargs) -> None:
        """
        Log 'msg % args' with severity 'TRACE'.

        To pass exception information, use the keyword argument exc_info with
        a true value, e.g.

        logger.trace("Houston, we have an %s", "interesting problem", exc_info=1)
        """
        if self.isEnabledFor(5):
            self._log(5, msg, args, **kwargs)


if typing.TYPE_CHECKING:
    def get_logger(name: str = None) -> Logger:
        return logging.getLogger(name)  # type: ignore

    logging.getLogger = get_logger


if __name__ == '__main__':
    logging.setLoggerClass(Logger)
    logging.getLogger(__name__).trace("test")

#

That trace function is ripped straight from the bot, it isn't new code

#

The hack in the type_checking block is factually correct

fallen patrol Sep 2, 2021, 9:02 PM

#

but now you have to use a custom get_logger method?

gritty wind Sep 2, 2021, 9:02 PM

#

No?

#

logging.setLoggerClass(Logger)

fallen patrol Sep 2, 2021, 9:02 PM

#

oh wait

#

aside from hacky I kind of like it 👀

gritty wind Sep 2, 2021, 9:02 PM

#

It should require no other code changes

static canyon Sep 2, 2021, 9:03 PM

#

Nice

#

~~Where do I copy-paste this into?~~

gritty wind Sep 2, 2021, 9:03 PM

#

One sec, I'll get you a patch lol

fallen patrol Sep 2, 2021, 9:03 PM

#

I don't get how this works: ( see my comment )

if typing.TYPE_CHECKING:
    # this method isn't the same name as getLogger
    def get_logger(name: str = None) -> Logger:
        return logging.getLogger(name)  # type: ignore

    logging.getLogger = get_logger

gritty wind Sep 2, 2021, 9:04 PM

#

It doesn't have to be

#

It's just a pointer

fallen patrol Sep 2, 2021, 9:04 PM

#

??

gritty wind Sep 2, 2021, 9:04 PM

#

What matters to mypy here is that the annotated return of logging.getLogger is now the custom logger class

static canyon Sep 2, 2021, 9:04 PM

#

yeah

fallen patrol Sep 2, 2021, 9:04 PM

#

ah

#

i wonder if this could get into the stdlib lol

#

and use a typevar on the return of getLogger

tough imp Sep 2, 2021, 9:07 PM

#

gritty wind ```py import logging import typing logging.addLevelName(5, "trace") class Log...

This wouldn't work in another module though, right?

static canyon Sep 2, 2021, 9:07 PM

#

I think that's what logging.setLoggerClass(Logger) is for

tough imp Sep 2, 2021, 9:08 PM

#

well it works but it doesn't fool the type checker is what I mean 😅

static canyon Sep 2, 2021, 9:08 PM

#

Then each time you do logger: Logger = logging.getLogger(__name__), and this has the custom class so will work

tough imp Sep 2, 2021, 9:08 PM

#

wouldn't it be nicer to have a custom log_utils.get_logger func that wraps logging.getLogger?

#

and overrides the return type

#

then import that everywhere instead of logging.getLogger

#

and you get rid of the camel case too 😌

static canyon Sep 2, 2021, 9:09 PM

#

So you're suggesting logger = log_utils.get_logger(__name__) instead of logger: bot.log.Logger = logging.getLogger(__name__)?

tough imp Sep 2, 2021, 9:09 PM

#

yeah

#

just seems like less trouble

static canyon Sep 2, 2021, 9:09 PM

#

hmm

gritty wind Sep 2, 2021, 9:10 PM

#

tough imp This wouldn't work in another module though, right?

It should in theory work in all modules, let me test

#

provided this is loaded before them

tough imp Sep 2, 2021, 9:10 PM

#

yeah it will work in the sense that you'll get your logger

#

but a type checker wouldn't see the if TYPE_CHECKING block from another module, right

gritty wind Sep 2, 2021, 9:11 PM

#

Hmm it feels like it should

#

Let me test a bit

tough imp Sep 2, 2021, 9:12 PM

#

I guess it also depends on which type checker is being used

static canyon Sep 2, 2021, 9:12 PM

#

mypy is the one we're thinking of adding

gritty wind Sep 2, 2021, 9:13 PM

#

Yeah mypy had no problem

#

Provided I add this to Init

trim cradle Sep 2, 2021, 9:13 PM

#

how does one run the site tests in the docker container?

gritty wind Sep 2, 2021, 9:13 PM

#

The type checking block

trim cradle Sep 2, 2021, 9:13 PM

#

sudo docker exec 5a3e85b3e32e "poetry run task lint" did not work

tough imp Sep 2, 2021, 9:13 PM

#

ah that surprises me

static canyon Sep 2, 2021, 9:13 PM

#

gritty wind Provided I add this to Init

What's your import + getLogger in the other module?

gritty wind Sep 2, 2021, 9:13 PM

#

Let me get this uploaded somewhere you can play with it

tough imp Sep 2, 2021, 9:13 PM

#

I've never really used mypy though so maybe I'm underestimating it

gritty wind Sep 2, 2021, 9:13 PM

#

What supports multi file code

#

I could always push my finalized solution to a branch

static canyon Sep 2, 2021, 9:14 PM

#

gritty wind What supports multi file code

~~repl.it~~

gritty wind Sep 2, 2021, 9:14 PM

#

Well, wait a minute. I have a __main__, __init__, and a regular python file in a module. I told mypy to run as a module, but it's saying it found 1 file

static canyon Sep 2, 2021, 9:15 PM

#

lol

gritty wind Sep 2, 2021, 9:15 PM

#

Did it actually lint everything or not is the Q

static canyon Sep 2, 2021, 9:15 PM

#

If it says 1 source file it only checked that one file

gritty wind Sep 2, 2021, 9:15 PM

#

Well, you're right it'll be check

#

How would I get it running over a module

#

It says -m is an option

#

But that seems false

static canyon Sep 2, 2021, 9:16 PM

#

mypy -m x.py I think?

gritty wind Sep 2, 2021, 9:16 PM

#

-m MODULE, --module MODULE Type-check module; can repeat for more modules

#

That is what I used hmm

#

package maybe

#

Ah that's done it

#

Okay, sadly didn't work

static canyon Sep 2, 2021, 9:17 PM

#

f

static canyon Sep 2, 2021, 9:17 PM

#

static canyon So you're suggesting `logger = log_utils.get_logger(__name__)` instead of `logge...

Then we need one of these two

gritty wind Sep 2, 2021, 9:17 PM

#

That is a nice solution

static canyon Sep 2, 2021, 9:17 PM

#

mhm

#

That's probs what I'd do (the first of the two)

gritty wind Sep 2, 2021, 9:18 PM

#

That's the price we pay for staticness

patent pivot Sep 2, 2021, 9:19 PM

#

hi pls test n review https://github.com/python-discord/site/pull/575

GitHub

Add Django Prometheus by jb3 · Pull Request #575 · python-discord/s...

Adds Django Prometheus and installs the necessary middleware and URL paths for reporting.

#

more metrics for the Joe Banks Gobbler™️

brazen charm Sep 2, 2021, 9:25 PM

#

trim cradle `sudo docker exec 5a3e85b3e32e "poetry run task lint"` did not work

Looking at it I'm not sure if you can directly because dev deps aren't installed to the container; otherwise it'd be docker-compose run web test I believe

trim cradle Sep 2, 2021, 9:26 PM

#

ooo something's happening

fallen patrol Sep 2, 2021, 9:28 PM

#

@patent pivot https://github.com/python-discord/.github/blob/main/review-policies/core-developers.yml#L102-L103

stable mountainBOT Sep 2, 2021, 9:28 PM

#

review-policies/core-developers.yml lines 102 to 103

- ".github/workflows/*"
- "Dockerfile"```

fallen patrol Sep 2, 2021, 9:28 PM

#

should pyproject.toml be a part of this or no?

patent pivot Sep 2, 2021, 9:28 PM

#

hmmmmm

#

nah

fallen patrol Sep 2, 2021, 9:29 PM

#

most of the time, it would be removing or adding a dependency

patent pivot Sep 2, 2021, 9:29 PM

#

because then every PR that adds a dep needs a sign off from devops

fallen patrol Sep 2, 2021, 9:29 PM

#

ah

#

ok

patent pivot Sep 2, 2021, 9:29 PM

#

if people feel it needs an explicit devops review they can add the label

fallen patrol Sep 2, 2021, 9:31 PM

#

huh

#

does that mean that docker-compose.yml is not used when deploying any of pydis's stuff?

#

since presumably if it was used, it would be on that list

brazen charm Sep 2, 2021, 9:32 PM

#

That's for dev

gritty wind Sep 2, 2021, 9:32 PM

#

@static canyon @tough imp I found a solution that does work for all files in a module, but this is more of a curiosity than something that wouldn't get your head decapitated:

In a logging.pyi, I added:

from logged import CustomLogger

def getLogger(name: str = None) -> CustomLogger:
    ...

This ofc raised errors when I tried using anything else in the logging library, but to get around that, you can use (this is in __init__.py):

from Lib import logging
logging.something_not_in_stub()

and nothing will complain anymore. Other files can use the normal import logging with no problem

#

Again, don't suggest this

#

HIGHLY ILLEGAL

fervent sage Sep 2, 2021, 9:33 PM

#

since all of pydis' stuff is on k8s, compose files will never be used in prod

patent pivot Sep 2, 2021, 9:34 PM

#

patent pivot if people feel it needs an explicit devops review they can add the label

lol — well it will work when now I fixed review requests

tough imp Sep 2, 2021, 9:34 PM

#

gritty wind <@!442244135840382978> <@!144912469071101952> I found a solution that does work ...

neutralcharli

#

i dont follow

#

you called a function that doesnt exist and it solved the problem?