green oriole Aug 17, 2021, 4:30 PM

#

So you are a devops? Name every url on our servers

brisk brook Aug 17, 2021, 4:30 PM

#

Oh you're a programmer? Name every error

vale ibex Aug 17, 2021, 4:30 PM

#

green oriole So you are a devops? Name every url on our servers

kubectl get ingress -a

fallen patrol Aug 17, 2021, 4:30 PM

#

green oriole So you are a devops? Name every url on our servers

Oh, you're akarys? name what exit code 69 is.

vale ibex Aug 17, 2021, 4:30 PM

#

brisk brook Oh you're a programmer? Name every error

BaseException

fallen patrol Aug 17, 2021, 4:31 PM

#

vale ibex BaseException

Wrong. BaseException

vale ibex Aug 17, 2021, 4:31 PM

#

this

green oriole Aug 17, 2021, 4:31 PM

#

fallen patrol Oh, you're akarys? name what exit code 69 is.

EX_UNAVAILABLE (69) A service is unavailable. This can occur if a sup port program or file does not exist. This can also be used as a catchall message when something you wanted to do doesn't work, but you don't know why.

vale ibex Aug 17, 2021, 4:31 PM

#

nice ctrl c ctrl v

fallen patrol Aug 17, 2021, 4:31 PM

#

Yeah it looks bad

green oriole Aug 17, 2021, 4:32 PM

#

tyty

#

Blame the manual

fallen patrol Aug 17, 2021, 4:32 PM

#

Where'd you copy it from

#

Need it for reference

green oriole Aug 17, 2021, 4:32 PM

#

https://www.freebsd.org/cgi/man.cgi?query=sysexits&apropos=0&sektion=0&manpath=FreeBSD+4.3-RELEASE&format=html

fallen patrol Aug 17, 2021, 4:32 PM

#

Like legit, working on a startup sequence thing so

tough imp Aug 17, 2021, 4:32 PM

#

when something you wanted to do doesn't work, but you don't know why.
thats like, everything ever for me

fallen patrol Aug 17, 2021, 4:33 PM

#

Ikr

#

Oh god I am such an idiot

#

Aaaaaaaaaaaa

#

So tl;dr I wondered why nothing was printed to console

#

Because I was grabbing all of the stdout into my eval command

green oriole Aug 17, 2021, 4:38 PM

#

That does sound problematic

green oriole Aug 17, 2021, 4:39 PM

#

vale ibex kubectl get ingress -a

Error from server (Forbidden): ingresses.networking.k8s.io is forbidden: User "system:serviceaccount:default:akarys" cannot list resource "ingresses" in API group "networking.k8s.io" in the namespace "default"

#

Interesting url

vale ibex Aug 17, 2021, 4:39 PM

#

https://tenor.com/view/skillissue-skill-issue-gif-22125481

Tenor

green oriole Aug 17, 2021, 4:39 PM

#

Ikr

fallen patrol Aug 17, 2021, 4:44 PM

#

vale ibex https://tenor.com/view/skillissue-skill-issue-gif-22125481

Shush this didn't just happen to me

fallen patrol Aug 17, 2021, 4:44 PM

#

green oriole That does sound problematic

I had to resort to logging statements, can you imagine?

clever wraith Aug 17, 2021, 4:46 PM

#

green oriole EX_UNAVAILABLE (69) A service is unavailable. This can occur if a sup port ...

lol

fallen patrol Aug 17, 2021, 4:46 PM

#

@stable mountain actually uses that so yeah

dry folio Aug 17, 2021, 5:07 PM

#

green oriole EX_UNAVAILABLE (69) A service is unavailable. This can occur if a sup port ...

lmfao

patent pivot Aug 17, 2021, 5:08 PM

#

why do we use freebsd exit codes lol

sharp timber Aug 17, 2021, 5:08 PM

#

@cold island I think we should take inspiration from git

#

class Msg:
  last_channel: Msg
  next_channel: Msg
  last_user: Msg
  next_user: Msg
  message: discord.Message


history = Dict[int, Msg]

cold island Aug 17, 2021, 5:10 PM

#

Ah, so that's what you mean by a dict - linked list combo

sharp timber Aug 17, 2021, 5:11 PM

#

Yes

cold island Aug 17, 2021, 5:11 PM

#

What will the keys be?

sharp timber Aug 17, 2021, 5:11 PM

#

Well, there would be channel ID

#

But we could also have one for Message id

cold island Aug 17, 2021, 5:11 PM

#

hmmm.. I don't particularly care about the channel

sharp timber Aug 17, 2021, 5:11 PM

#

Stuff like clean would though

#

to clean a particular channel you just go to channel_history[channel.id] then go through last_channel until you hit whatever threshold

cold island Aug 17, 2021, 5:12 PM

#

Yeah but the dpy cache exists either way no?

sharp timber Aug 17, 2021, 5:12 PM

#

True, although I was thinking we'd just rely on this instead of both

cold island Aug 17, 2021, 5:13 PM

#

A simple linked list runs into the same issues I have with the current cache

#

Which is bad random access and no slicing

sharp timber Aug 17, 2021, 5:13 PM

#

Right, although that's what the dict is for

#

random access

cold island Aug 17, 2021, 5:14 PM

#

I don't need a dict for that though, it's just indices

sharp timber Aug 17, 2021, 5:15 PM

#

Well, either the messages are stored contiguously in a list/array structure, and indices work, or they're not, and someone, somewhere needs a dictionary

#

and contiguous doesn't really work for deleting from the middle

#

If we just want to delete from the front/end we could code up a circular buffer cache

cold island Aug 17, 2021, 5:15 PM

#

I want to preserve deletions, so if we're making the same cache with deletions I'd rather just rely on the existing cache

sharp timber Aug 17, 2021, 5:16 PM

#

ah, ok

#

What are the plans for evicting from this cache?

cold island Aug 17, 2021, 5:16 PM

#

Just a size constraint

sharp timber Aug 17, 2021, 5:16 PM

#

circular buffer

#

the builtin deque is a linked list

cold island Aug 17, 2021, 5:17 PM

#

Why does it need to be circular?

sharp timber Aug 17, 2021, 5:17 PM

#

to avoid reallocation

cold island Aug 17, 2021, 5:18 PM

#

I don't follow probably

sharp timber Aug 17, 2021, 5:18 PM

#

a ring buffer offers O(1) prepend, append, 0 delete, end delete

#

a python list offers O(1) append and end delete, but O(size) 0 delete and prepend

#

list:
  .insert(0) -> O(size)
  .append() -> O(1)
  .popleft() -> O(size)
  .pop() -> O(1)
  [random] -> O(1)
  growing -> amortized
deque:
  .insert(0) -> O(1)
  .append() -> O(1)
  .popleft() -> O(1)
  .pop() -> O(1)
  [random] -> O(size)
  growing -> no cost
circular:
  .insert(0) -> O(1)
  .append() -> O(1)
  .popleft() -> O(1)
  .pop() -> O(1)
  [random] -> O(1)
  growing -> amortized

cold island Aug 17, 2021, 5:20 PM

#

I'm probably just unfamiliar with the data structure. Do you have a reference or something

sharp timber Aug 17, 2021, 5:20 PM

#

https://upload.wikimedia.org/wikipedia/commons/f/fd/Circular_Buffer_Animation.gif

cold island Aug 17, 2021, 5:21 PM

#

How is random access kept at O(1)?

sharp timber Aug 17, 2021, 5:22 PM

#

It's backed by an array

#

to access the Nth element, you go to slot (start + n) % length

cold island Aug 17, 2021, 5:23 PM

#

Then how is 0 delete O(1)?

sharp timber Aug 17, 2021, 5:23 PM

#

start += 1

#

now accessing indices is shifted one element right, as if it were deleted

#

Presumably, for GC purposes, we'd set the element to None too

cold island Aug 17, 2021, 5:24 PM

#

Ah, so you allocate the max size in advance

sharp timber Aug 17, 2021, 5:24 PM

#

yes, or you grow whenever your start pointer bumps into your end pointer if you want to be unbounded

cold island Aug 17, 2021, 5:25 PM

#

We're in Python yeah? 😅

sharp timber Aug 17, 2021, 5:25 PM

#

Yeah, but same deal :P

#


class RingBuffer:
  MAXLEN = 10
  slots: List[T] = [None] * MAXLEN
  start_slot: int = 0
  end_slot: int = 0

  def push(self, thing: T):
    self.start_slot -= 1
    self.slots[self.start_slot] = thing

  def popleft(self, thing: T) -> T:
    fetch = self.slots[self.start_slot]
    self.slots[self.start_slot] = None 
    self.start_slot += 1
    return fetch

  def append(self, thing: T):
    self.end_slot += 1
    self.slots[self.end_slot] = thing

  def pop(self, thing: T) -> T:
    fetch = self.slots[self.end_slot]
    self.slots[self.end_slot] = None 
    self.end_slot -= 1
    return fetch

#

This is basically it, without bounds checks

cold island Aug 17, 2021, 5:29 PM

#

Hmmm we'll need to discuss it a bit more about deciding to use our own cache

#

Seems like an interesting idea though

sharp timber Aug 17, 2021, 5:30 PM

#

It's a criminally underused data structure in higher languages

#

It's very popular in embedded and similar because it gives you flexibility without needing linked lists, as well as backpressure if it fills up

#

But the benefits (IE: O(1) in push/pop/pull/append) it grants are useful at any algorithmic level

cold island Aug 17, 2021, 5:31 PM

#

I'll see if I can make a good case for it and make a poll for the core devs

sharp timber Aug 17, 2021, 5:31 PM

#

inserting and deleting the middle though is still bad, although you could have it only move half if you really wanted to do that work

#

kk

cold island Aug 17, 2021, 5:33 PM

#

Yeah it wouldn't fit if we used deletions, but if we don't care about removing deleted messages that looks like something that should work

sharp timber Aug 17, 2021, 5:33 PM

#

If we were doing insert/delete then we'd want to look into a rope, but yeah

brisk brook Aug 17, 2021, 5:35 PM

#

cold island hmmm.. I don't particularly care about the channel

We need the channel for Discord to be able to find the message

sharp timber Aug 17, 2021, 5:35 PM

#

Yeah, but we have that on the message object

cold island Aug 17, 2021, 5:35 PM

#

yeah

sharp timber Aug 17, 2021, 5:35 PM

#

the question is really going backwards, from "we have channel ID and want latest message from cache"

#

which if we're not doing is fine to leave out that.. index

#

because I guess it is an index

light holly Aug 17, 2021, 5:38 PM

#

i have a rope implemented

#

if you need one

fallen patrol Aug 17, 2021, 5:43 PM

#

what feature are you implemented?

cold island Aug 17, 2021, 6:24 PM

#

A message cache

fervent sage Aug 17, 2021, 6:25 PM

#

O(1) access but also ordered and iterable?

cold island Aug 17, 2021, 6:28 PM

#

Yes

#

But without removing deleted messages

brisk brook Aug 17, 2021, 6:30 PM

#

cold island But without removing deleted messages

Oh right, they get overwritten?

cold island Aug 17, 2021, 6:33 PM

#

Nope, they just stay there

#

They get naturally removed as newer messages arrive at the head of the cache

#

As any other message

brisk brook Aug 17, 2021, 6:34 PM

#

Yeah that's what I mean

cold island Aug 17, 2021, 6:34 PM

#

Ah

#

Then yes

brisk brook Aug 17, 2021, 6:38 PM

#

Ahh, yeah I still am not sure how easy it will be to add

#

Like it is possible, but so far I know you have a general preference over not monkey-patching 😅

#

Here is where it is defined really https://github.com/Rapptz/discord.py/blob/master/discord/state.py#L217

stable mountainBOT Aug 17, 2021, 6:40 PM

#

discord/state.py line 217

self._messages = self.max_messages and deque(maxlen=self.max_messages)```

brisk brook Aug 17, 2021, 6:41 PM

#

But it also gets re-created when the bot leaves a guild as seen here: https://github.com/Rapptz/discord.py/blob/master/discord/state.py#L1048

stable mountainBOT Aug 17, 2021, 6:41 PM

#

discord/state.py line 1048

self._messages = deque((msg for msg in self._messages if msg.guild != guild), maxlen=self.max_messages)```

fervent sage Aug 17, 2021, 6:46 PM

#

brisk brook Like it is possible, but so far I know you have a general preference over *not* ...

we already monkey patch for root aliases iirc so /shrug

brisk brook Aug 17, 2021, 6:47 PM

#

fervent sage we already monkey patch for root aliases iirc so /shrug

What do you mean by root aliases?

fervent sage Aug 17, 2021, 6:47 PM

#

off the top of my head, take !tp add, a root alias for that is !nominate, meaning it doesnt need to be invoked as a group member

brisk brook Aug 17, 2021, 6:50 PM

#

Ah

vale ibex Aug 17, 2021, 6:51 PM

#

Yea, we subclass discord.ext.commands.Command to add a new kwarg root_aliases

#

Then we overwrite add_command in our sub class of Cog to iterate through the root_aliases and add them to the list of commands

cold island Aug 17, 2021, 7:01 PM

#

Setting self.max_messages to None seems simple enough

brisk brook Aug 17, 2021, 7:02 PM

#

cold island Setting self.max_messages to None seems simple enough

That will cause there to exist no message cache at all?

cold island Aug 17, 2021, 7:02 PM

#

Or maybe there's a way to tell it to not cache in the first place

cold island Aug 17, 2021, 7:02 PM

#

brisk brook That will cause there to exist no message cache at all?

Yeah the idea is to have our own after all

#

Not to patch dpy's

vale ibex Aug 17, 2021, 7:07 PM

#

cold island Or maybe there's a way to tell it to not cache in the first place

Setting it to None disables the caching entirely

cold island Aug 17, 2021, 7:08 PM

#

Yes. We don't use it at all at the moment though

#

Unlike root aliases which is just subclassing, it will be a very involved monkey patch that is subject to issues every time that file is updated with new code

#

So we can just disable the dpy caching and have it as a cog

vale ibex Aug 17, 2021, 7:10 PM

#

Yea

gritty wind Aug 17, 2021, 7:12 PM

#

We make use of it in evals

#

Or at least, internal ones

#

Alternatively, may I suggest we just leave it as is, and maintain our own for whatever we want?

#

So have 2 caches

brazen charm Aug 17, 2021, 7:15 PM

#

doesn't dpy also make use of it for something which may be useful? Having a separate cache for what it's needed or implementing the seq/deque interface to directly replace dpy's cache sounds like it'd make more sense

cold island Aug 17, 2021, 7:18 PM

#

We can keep the existing cache yeah

#

Not sure what dpy uses it for

fervent sage Aug 17, 2021, 7:21 PM

#

cold island Not sure what dpy uses it for

on_message_delete, on_message_edit, on_reaction_add, on_reaction_remove, etc.

cold island Aug 17, 2021, 7:23 PM

#

Yeah but parse_message_delete in https://github.com/Rapptz/discord.py/blob/feae059c6858e419552ec4096f1ad2692bb4c484/discord/state.py#L518 checks if there's a cache

stable mountainBOT Aug 17, 2021, 7:23 PM

#

discord/state.py line 518

def parse_message_delete(self, data):```

cold island Aug 17, 2021, 7:23 PM

#

Wrong line

#

https://github.com/Rapptz/discord.py/blob/feae059c6858e419552ec4096f1ad2692bb4c484/discord/state.py#L523

stable mountainBOT Aug 17, 2021, 7:23 PM

#

discord/state.py line 523

if self._messages is not None and found is not None:```

cold island Aug 17, 2021, 7:24 PM

#

So as far as I can see those events will update the cache, if there is one

brisk brook Aug 17, 2021, 7:25 PM

#

Yes, so it handles that case

#

But those events will not propogate

#

As of right now, it will break wait_for_deletion https://github.com/python-discord/bot/blob/main/bot/utils/messages.py#L97-L105

stable mountainBOT Aug 17, 2021, 7:26 PM

#

bot/utils/messages.py lines 97 to 105

try:
    try:
        await bot.instance.wait_for('reaction_add', check=check, timeout=timeout)
    except asyncio.TimeoutError:
        await message.clear_reactions()
    else:
        await message.delete()
except discord.NotFound:
    log.trace(f"wait_for_deletion: message {message.id} deleted prematurely.")```

cold island Aug 17, 2021, 7:28 PM

#

Ugh I see

#

Why does it need the cache to dispatch the event

brisk brook Aug 17, 2021, 7:32 PM

#

cold island Why does it need the cache to dispatch the event

Because a reaction_add event looks like this: https://discord.com/developers/docs/topics/gateway#message-reaction-add

Discord Developer Portal

Discord Developer Portal — API Docs for Bots and Developers

Integrate your service with Discord — whether it's a bot or a game or whatever your wildest imagination can come up with.

cold island Aug 17, 2021, 7:32 PM

#

So dpy searches for the message in the cache

#

ok

#

Thanks for the explanation

brisk brook Aug 17, 2021, 7:38 PM

#

cold island So dpy searches for the message in the cache

Yup, and this is the case for most other events. reaction_remove is the word offender with having close to no information https://discord.com/developers/docs/topics/gateway#message-reaction-remove-message-reaction-remove-event-fields

Discord Developer Portal

Discord Developer Portal — API Docs for Bots and Developers

Integrate your service with Discord — whether it's a bot or a game or whatever your wildest imagination can come up with.

gritty wind Aug 17, 2021, 7:43 PM

#

We can use raw events (and we do for some things) if we really wanted to get rid of the cache

#

But we don’t have a compelling reason yet I don’t think

clever wraith Aug 17, 2021, 7:45 PM

#

@vale ibex i resolved the lint errors on cowsay

brisk brook Aug 17, 2021, 7:45 PM

#

It's a scary and easy trap to fall into though, trying to debug the bot and wondering why your events don't dispatch

dusky shoreBOT Aug 17, 2021, 10:40 PM

#

GitHub

PROpen Make cloudflare purge command use interactions

patent pivot Aug 17, 2021, 10:41 PM

#

very epic

#

i am goig to merge without testing because i live oon the edge

#

wait lint is failing @clever wraith

#

lol

green oriole Aug 17, 2021, 10:42 PM

#

So hello Richard haha

#

You do have a ghost ping

vale ibex Aug 17, 2021, 10:43 PM

#

just delete half of it

patent pivot Aug 17, 2021, 10:43 PM

#

lmfao

green oriole Aug 17, 2021, 10:45 PM

#

Make the limit 102 and hate it back

#

lol

#

If it passes I'm giving you a virtual cookie

#

No cookie, too bad

#

I gotta say though, I really appreciate you taking time to work on both smarter resources and arthur, tysm! 🍪

#

I am also on phone though haha

#

Actually https://github.com/python-discord/king-arthur/pull/5/files#diff-0b5ee0627d493b02a3b76c0d707b069def866a5aaf63d8fde71fd4c1aca8e282R11

#

I always forget we have that

#

Get what?

#

It automatically appears in the file tab

#

We use a special format when reporting lint error instructing github to add those comments

fervent sage Aug 17, 2021, 11:08 PM

#

patent pivot i am goig to merge without testing because i live oon the edge

living on the edge... now thats what i call webscale!

green oriole Aug 17, 2021, 11:08 PM

#

Yeah sure

#

they are in the whole org

patent pivot Aug 17, 2021, 11:47 PM

#

arthur zone purge

#

what is the command

#

arthur zones purge

radiant merlinBOT Aug 17, 2021, 11:47 PM

#

Pick which zone(s) that should have their cache purged :cloud_lightning:

patent pivot Aug 17, 2021, 11:47 PM

#

wait emote in wrong place

#

lol

#

oo yea that isn't working

#

@clever wraith that code you removed for the devops check is actually meaningufl lol

gritty wind Aug 17, 2021, 11:49 PM

#

Smh alias zone

patent pivot Aug 17, 2021, 11:50 PM

#

hmmmm

#

I think we should be dynamically calculating the options

#

okay i'm gonna rewrite this a bit

#

I don't think using _is_devops is worth it

wind ruin Aug 17, 2021, 11:56 PM

#

radiant merlin Pick which zone(s) that should have their cache purged :cloud_lightning:

may I ask, what are you using for it?
discord.py v2.0 unstable stuff, some of the libraries or custom made?

patent pivot Aug 17, 2021, 11:56 PM

#

dpy v2

#

I'm also removing multiple options from cache purge

clever wraith Aug 18, 2021, 12:23 AM

#

arthur help

#

Please

#

Help me

patent pivot Aug 18, 2021, 12:23 AM

#

@clever wraith updates made

#

arthur zones purge

radiant merlinBOT Aug 18, 2021, 12:23 AM

#

:cloud: Pick which zone(s) that should have their cache purged

radiant merlinBOT Aug 18, 2021, 12:23 AM

#

radiant merlin :cloud: Pick which zone(s) that should have their cache purged

:white_check_mark: Cache cleared! The Cloudflare cache for pythondiscord.com was cleared.

dry folio Aug 18, 2021, 2:28 AM

#

radiant merlin :cloud: Pick which zone(s) that should have their cache purged

WTF WTF DISCORD BOTS HAVE SELECTIONS NOW?!

fallen patrol Aug 18, 2021, 2:28 AM

#

radiant merlin :cloud: Pick which zone(s) that should have their cache purged

bad king arthur

fallen patrol Aug 18, 2021, 2:28 AM

#

patent pivot <@456226577798135808> updates made

seriously, you don't let the user know they can't use a component?

#

so bad

#

smh

#

(/s)

radiant merlinBOT Aug 18, 2021, 8:07 AM

#

arthur ed [-GVhs] [-p string] [file]

Ed is the standard text editor.

green oriole Aug 18, 2021, 8:14 AM

#

akarys_rotate 🍪

#

I need to make akarys_heart but with a cookie

#

they all are joe

celest charm Aug 18, 2021, 9:25 AM

#

clever wraith Aug 18, 2021, 3:50 PM

#

if any core dev/contributor has time, could they get around to merging sir-lancebot#760 ? its been approved and just needs a merge

dusky shoreBOT Aug 18, 2021, 3:50 PM

#

GitHub

PROpen Adds .reverse

gritty wind Aug 18, 2021, 3:51 PM

#

12 participants :O

#

@vale ibex good to merge?

clever wraith Aug 18, 2021, 3:52 PM

#

wait what oops

gritty wind Aug 18, 2021, 3:52 PM

#

Discord isn’t letting me mention wokie lol

vale ibex Aug 18, 2021, 3:53 PM

#

smh wookie approving and not merging

cold island Aug 18, 2021, 3:53 PM

#

Because it's wookie not wokie smh

vale ibex Aug 18, 2021, 3:53 PM

#

i click green

gritty wind Aug 18, 2021, 3:54 PM

#

cold island Because it's wookie not wokie smh

Schsjdvehv

#

I typed it like that to please the autocorrect gods

vale ibex Aug 18, 2021, 3:54 PM

#

lol

clever wraith Aug 18, 2021, 3:56 PM

#

time to test

#

it works

patent pivot Aug 18, 2021, 4:51 PM

#

    async def interaction_check(self, interaction: Interaction) -> bool:
        """Check the interactor is authorised."""
        if interaction.user.id == self.authorization:
            return True

        await interaction.response.send_message(
            generate_error_message(description="You are not authorized to perform this action."),
            ephemeral=True,
        )

        return False

#

generate_error_message puts a ❌ on it

#

I like the x

#

arthur responses will always start with an emote

#

it does yeah, because it uses generate_error_message

#

arthur deploy restart xyz

radiant merlinBOT Aug 18, 2021, 4:57 PM

#

:no_entry_sign: What is the airspeed velocity of an unladen swallow? Whatever the answer may be, it's certainly faster than you could select a confirmation option.

patent pivot Aug 18, 2021, 4:57 PM

#

give that a try

#

i mean click the buttons

#

yeppers

#

don't standardise too much

fervent sage Aug 18, 2021, 4:59 PM

#

joe

#

thats BK not KA

#

smh

patent pivot Aug 18, 2021, 4:59 PM

#

true true

#

because it's nice to have flexibility in future

#

there is no point standardising to the extreme now if I need to come back inn a month and undo it all

#

@clever wraith before you get started, an idea of what PRs you want to make would be nice, just so all revisions are approved and we don't have to remove some later on

thorny obsidian Aug 18, 2021, 5:12 PM

#

(this really sounds like y'all should use issues to properly scope changes before work starts Sunglaso )

patent pivot Aug 18, 2021, 5:12 PM

#

yeah, I'd say open issues for other proposed changes, standardising the view is fine but I don't think it's a big deal

#

actually, I think I'd rather explicitly define checks

#

we can standardise the logic, but it feelss like that is something that could slip through reviews & cause problems

patent pivot Aug 18, 2021, 5:21 PM

#

patent pivot actually, I think I'd rather explicitly define checks

(cc @clever wraith)

patent pivot Aug 18, 2021, 5:58 PM

#

yeah, I don't think Arthur is in need of any refactors right now

#

I can have a crack at it

#

we also have another new service in mind for devops but more on that in time

#

stuff to do with downtime monitoring on non-http services

#

batch

#

same namespace the cronjob is in

molten perch Aug 18, 2021, 6:13 PM

#

Hey, could a core dev take a look at that issue? I would appreciate it! 😄
api#16

dusky shoreBOT Aug 18, 2021, 6:13 PM

#

GitHub

IssueOpen Migrate models based on the current Database Schema to SQLAlchemy

patent pivot Aug 18, 2021, 6:21 PM

#

assume default if not specified

celest charm Aug 18, 2021, 6:27 PM

#

patent pivot I like the x

but she doesn't like me back 😔

clever wraith Aug 18, 2021, 7:07 PM

#

celest charm but she doesn't like me back 😔

😢

patent pivot Aug 18, 2021, 8:28 PM

#

kubectl create job test-job --from=cronjob/a-cronjob

fallen patrol Aug 18, 2021, 9:55 PM

#

@sharp timber Hey, I've noticed that the fuzz for invalid commands is a bit too sensitive sometimes, looks like its set to 60% sensitivity in https://github.com/python-discord/bot/blob/173203ff54b62e311070dcae94a26b64e14a5fb4/bot/exts/info/help.py#L129
I've done stuff myself, and in my own projects, I set it to 80%

stable mountainBOT Aug 18, 2021, 9:55 PM

#

bot/exts/info/help.py line 129

result = process.extract(default_process(string), choices, scorer=fuzz.ratio, score_cutoff=60, processor=None)```

green oriole Aug 18, 2021, 9:55 PM

#

Do you have examples of inaccuracies?

fallen patrol Aug 18, 2021, 9:56 PM

#

#

#

seems like a simple change of 60% to 80% isn't a solution, as it should have suggested "paste" for that one

vale ibex Aug 18, 2021, 10:00 PM

#

I don't see an issue with having a lower threshold, since we list all of the suggestions anyway

#

it seems the issue is that it isn't matching at all in the second screenshot

#

It seems like that threshold is lower, because we have another fuzz with a higher threshold that auto-runs them

#

EG

#

!pastr

stable mountainBOT Aug 18, 2021, 10:12 PM

#

Pasting large amounts of code

If your code is too long to fit in a codeblock in discord, you can paste your code here:
https://paste.pydis.com/

After pasting your code, save it by clicking the floppy disk icon in the top right, or by typing ctrl + S. After doing that, the URL should change. Copy the URL and post it here so others can see it.

gritty wind Aug 18, 2021, 11:23 PM

#

I don’t think this’ll work in this instance

#

This instance being the example you’ve provided

#

The examples are all tags

#

And tags use different scoring than what you linked

#

In fact it uses a custom built scorer

#

https://github.com/python-discord/bot/blob/5a7256fe0852cc19aeeb7a8b57c73bfba2fd2ace/bot/exts/info/tags.py#L85

stable mountainBOT Aug 18, 2021, 11:25 PM

#

bot/exts/info/tags.py line 85

def _get_suggestions(self, tag_name: str, thresholds: Optional[List[int]] = None) -> List[str]:```

gritty wind Aug 18, 2021, 11:26 PM

#

Thanks python. Very cool.

green oriole Aug 19, 2021, 5:02 AM

#

vale ibex It seems like that threshold is lower, because we have another fuzz with a highe...

This is for tags, yeah

#

Not for normal commands

vale ibex Aug 19, 2021, 9:07 AM

#

https://github.com/python-discord/bot/pull/1756/files

#

fixed

#

👌

cold island Aug 19, 2021, 11:25 AM

#

@patent pivot question, why does Metricity store usernames but not discrims?

patent pivot Aug 19, 2021, 11:40 AM

#

cold island <@!165023948638126080> question, why does Metricity store usernames but not disc...

We didn't ever need them, open to adding them though

cold island Aug 19, 2021, 11:49 AM

#

Hmm yeah, I would be interested in having them

patent pivot Aug 19, 2021, 11:50 AM

#

cold island Hmm yeah, I would be interested in having them

PR should be pretty simple, just adding discriminator to the models & adding a migration and then updating the data inserted

#

make sure it defaults to 0000 though because users that left won't have one

cold island Aug 19, 2021, 11:52 AM

#

The site might actually have what I want

brisk brook Aug 19, 2021, 12:03 PM

#

patent pivot make sure it defaults to 0000 though because users that left won't have one

Isn't that a possible combination though?

vale ibex Aug 19, 2021, 12:04 PM

#

Nah, discord doesn't allow it

brisk brook Aug 19, 2021, 12:09 PM

#

Ah, it was 0001 I was thinking about

patent pivot Aug 19, 2021, 12:46 PM

#

PR a fix that was generated by copilot LOL

cold island Aug 19, 2021, 12:49 PM

#

lol that was generated by copilot?

patent pivot Aug 19, 2021, 1:44 PM

#

cold island lol that was generated by copilot?

yea lol was one of the few things i accepted

green oriole Aug 19, 2021, 2:37 PM

#

Why did you accept it lol

vale ibex Aug 19, 2021, 2:39 PM

#

It's free code!

fervent sage Aug 19, 2021, 2:46 PM

#

vale ibex Nah, discord doesn't allow it

well :)

#

there are people with 0000s

vale ibex Aug 19, 2021, 2:49 PM

#

not by choice though right? kek

green oriole Aug 19, 2021, 4:09 PM

#

fervent sage there are people with 0000s

Webhooks only though, right?

brisk brook Aug 19, 2021, 4:20 PM

#

With a smallint you have -32768 to +32767

#

Just set it to -1

#

Or is it gonna be stored as a string?

#

Make it nullable?

fervent sage Aug 19, 2021, 4:44 PM

#

green oriole Webhooks only though, right?

nope, users

#

result of a thing a while ago where having your account disabled and re-enabled would give you a 0000 discrim

fallen patrol Aug 19, 2021, 6:42 PM

#

fervent sage result of a thing a while ago where having your account disabled and re-enabled ...

why did discord not run a migration for these users?

fervent sage Aug 19, 2021, 6:44 PM

#

cause it doesnt matter

green oriole Aug 19, 2021, 7:27 PM

#

lemon#0000 when

celest charm Aug 19, 2021, 7:46 PM

#

green oriole lemon#0000 when

Lemon indexing is 1-based

#

because he is written in lua

cold island Aug 19, 2021, 8:31 PM

#

Hmmm the anti spam cog sometimes refuses to work for me for some reason on my test bot, not sure why

vale ibex Aug 19, 2021, 8:43 PM

#

Any errors?

cold island Aug 19, 2021, 9:07 PM

#

Nope

#

Just... doesn't mute

patent pivot Aug 19, 2021, 9:12 PM

#

@clever wraith am I good to take a crack at cronjobs

#

👍

vale ibex Aug 19, 2021, 9:24 PM

#

cold island Just... doesn't mute

that's odd

#

have you tried adding trace logs to that cog?

#

I just have BOT_TRACE_LOGGERS=* in my .env because I'm lazy

cold island Aug 19, 2021, 9:39 PM

#

The issue is that it just doesn't see the channel history for some reason

vale ibex Aug 19, 2021, 9:43 PM

#

🤔

cold island Aug 19, 2021, 9:47 PM

#

This returns an empty list

vale ibex Aug 19, 2021, 9:59 PM

#

that's...odd

vale ibex Aug 19, 2021, 10:12 PM

#

cold island This returns an empty list

not sure if you have notifications turn off in the test server, but I think I found the issue 😄 #476196547324018688 message

cold island Aug 19, 2021, 10:15 PM

#

Ah, I do. Thanks

static canyon Aug 20, 2021, 8:15 AM

#

I've found a few instances where the value passed for the lines parameter of the pagination util isn't t.List[str] as described by the typehint. Is this something I should open a PR for to fix? Instances of this below:```
list[str] | tuple[str]: https://sourcegraph.com/github.com/python-discord/bot/-/blob/bot/exts/recruitment/talentpool/_cog.py?L160

dict_values[str] | tuple[str]: https://sourcegraph.com/github.com/python-discord/bot/-/blob/bot/exts/moderation/watchchannels/_watchchannel.py?L318

tuple[str]: https://sourcegraph.com/github.com/python-discord/bot/-/blob/bot/exts/moderation/infraction/management.py?L258-L261

tuple[str]: https://sourcegraph.com/github.com/python-discord/bot/-/blob/bot/exts/info/site.py?L136

tuple[str]: https://sourcegraph.com/github.com/python-discord/bot/-/blob/bot/exts/utils/utils.py?L79```

#

Not sure if this is something we want to fix to keep the code accurate or whether it's a case of "it works so don't bother"

brisk brook Aug 20, 2021, 8:23 AM

#

Just use Sequence[str]

static canyon Aug 20, 2021, 8:25 AM

#

brisk brook Just use `Sequence[str]`

So you think it's worth opening a PR to fix this?

brisk brook Aug 20, 2021, 8:27 AM

#

I don't see anything wrong with it, might as well. You could take the time to run mypy and Pyright on strict and correct some other type hints.

#

That way you'd fix them in batch

static canyon Aug 20, 2021, 8:27 AM

#

Yeah, I suppose

#

~~That is, if I knew how to do that~~

brisk brook Aug 20, 2021, 8:30 AM

#

Just install mypy through pip, then restart your console and do mypy bot, bot being the folder of course

#

Pyright I am not sure, but mypy should be easy enough I think

static canyon Aug 20, 2021, 8:31 AM

#

I'll do mypy then 👍

#

Basically all the errors are just this @brisk brook

#

No clue what that means

#

"Skipping analyzing" or "Library stubs not installed"

brisk brook Aug 20, 2021, 8:33 AM

#

You need to go pip install discord.py-stubs

#

Discord.py doesn't have type hints, so Mypy is saying "I can't find typehints, and there are no stubs that tell me the typings either"

static canyon Aug 20, 2021, 8:35 AM

#

Right yeah fair enough

#

What about the errors towards bottom for "dateutil"?

#

These ones

brisk brook Aug 20, 2021, 8:38 AM

#

Huh, I don't know if there are stubs for dateutil, try doing pip install dateutil-stubs. They're usually called that

#

Otherwise you can ignore those, it's not a module that's used a lot, so it's fine.

static canyon Aug 20, 2021, 8:42 AM

#

Yeah, there's no matches so will just ignore that

static canyon Aug 20, 2021, 8:42 AM

#

brisk brook You need to go `pip install discord.py-stubs`

Still getting these two after this```
bot\exts\moderation\infraction\management.py:9: error: Skipping analyzing "discord.ext": found module but no type hints or library stubs
bot\exts\moderation\infraction\management.py:10: error: Skipping analyzing "discord.ext.commands": found module but no type hints or library stubs

#

Is there a separate library for that or something?

brisk brook Aug 20, 2021, 8:44 AM

#

https://github.com/bryanforbes/discord.py-stubs

GitHub

GitHub - bryanforbes/discord.py-stubs: discord.py stubs

discord.py stubs. Contribute to bryanforbes/discord.py-stubs development by creating an account on GitHub.

#

NOTE: Because discord.py uses namespace packages for its extensions, mypy must be configured to use namespace packages either with the --namespace-packages command line flag, or by setting namespace_packages = True in your mypy configuration file. See the import discovery section of the mypy documentation for more details.

static canyon Aug 20, 2021, 8:45 AM

#

How can I ignore certain errors, such as error: "Logger" has no attribute "trace"?

#

Since that's just because the bot uses some custom Logger thing

#

I suppose I can ignore all attribute errors but then might ignore something I don't want ignored

static canyon Aug 20, 2021, 8:52 AM

#

brisk brook Huh, I don't know if there are stubs for dateutil, try doing `pip install dateut...

Apparently it's types-python-dateutil (got from running mypy --install-types)

#

150 errors at the moment @brisk brook lol

#

Some seem legit and others I'm not so sure

brisk brook Aug 20, 2021, 9:05 AM

#

Lmaooo

#

Take a quick look at the ones that stand out, I don't think the goal is to make the bot pass the type checker

#

Just clean up issues similar to the first one we started talking about

static canyon Aug 20, 2021, 9:06 AM

#

👍

#

I don't know how to work on two branches at once with the bot so I'll wait for my current PR to get merged first so I don't accidentally mess stuff up

cold island Aug 20, 2021, 12:07 PM

#

Hmmm a question about order. bot.utils has a cache.py file, but I want to add the cache logic I wrote to that directory in a separate file. What should I do about that? 🤔

brazen charm Aug 20, 2021, 12:20 PM

#

cold island Hmmm a question about order. `bot.utils` has a `cache.py` file, but I want to ad...

So you want to put a separate unrelated cache under bot.utils but the current cache is taking up the name?

cold island Aug 20, 2021, 12:42 PM

#

brazen charm So you want to put a separate unrelated cache under bot.utils but the current ca...

yeah lol

brazen charm Aug 20, 2021, 12:49 PM

#

cold island yeah lol

What kind of a cache it is? maybe there is a name or location that'd fit it more than just a plain cache, or the current cache module could be renamed to lru_cache if I remember its contents correctly

cold island Aug 20, 2021, 12:50 PM

#

It caches messages

#

Currently for the antispam cog but has other potential uses

#

and yeah the other file is an lru cache for async functions

#

Hmmm.. why are we not using it more often 🤔

#

But yeah, I guess I'll rename one of them or both

#

thanks

brazen charm Aug 20, 2021, 12:58 PM

#

cold island Hmmm.. why are we not using it more often 🤔

for the most part redis is used because of its persistence, or handling for stale data would be needed, I'm not sure if there are many more uses for it

cold island Aug 20, 2021, 1:02 PM

#

Currently it's used only in the pep cog. Which makes sense because links to peps don't really change

#

It could be used to save a few API calls to the rules endpoint. It's not a big deal either way

short snow Aug 20, 2021, 2:19 PM

#

uhh why don't we sue lru cachec itself for caching the pep urls?

brazen charm Aug 20, 2021, 2:31 PM

#

because it'd cache the coro returned by the coroutine function

short snow Aug 20, 2021, 2:41 PM

#

yeah, (i thought it was containing some other caching logic, just saw it is a custom async implementation for lru cache)

tawdry vapor Aug 20, 2021, 3:10 PM

#

cold island It caches messages

It could also go in utils/messages.py or just stay in the cog if it doesn't seem like it could be used anywhere else.

cold island Aug 20, 2021, 3:11 PM

#

tawdry vapor It could also go in `utils/messages.py` or just stay in the cog if it doesn't se...

It's over 200 lines and the inner logic of the class is irrelevant to anything that uses it, so I'd rather keep it in a separate file.

fallen patrol Aug 20, 2021, 6:32 PM

#

cold island It's over 200 lines and the inner logic of the class is irrelevant to anything t...

over 200 lines
This is when #esoteric-python python could help (I'm kidding pls don't)

cold island Aug 20, 2021, 6:44 PM

#

Hmm how do I run the bot tests in pycharm?

brazen charm Aug 20, 2021, 6:45 PM

#

right click on the tests dir and run tests, though I think the cwd may need to be changed to the project root

fallen patrol Aug 20, 2021, 6:45 PM

#

poetry run task test?

cold island Aug 20, 2021, 6:55 PM

#

brazen charm right click on the tests dir and run tests, though I think the cwd may need to b...

Hmm yeah the cwd was the issue. Thanks

cold island Aug 20, 2021, 7:00 PM

#

fallen patrol `poetry run task test`?

I meant through the pycharm UI

fallen patrol Aug 20, 2021, 7:00 PM

#

oh idk lol sorry

cold island Aug 20, 2021, 7:01 PM

#

np, Numerlor's answer was what I needed

fervent sage Aug 20, 2021, 7:04 PM

#

cold island I meant through the pycharm UI

~~use ui to open terminal, follow aru's advice kek ~~ /s

gritty wind Aug 20, 2021, 7:14 PM

#

Pro tip: edit the template to include the cwd, that way all your future suites have it

#

Top notch ux after that by just clicking the bright green button beside file/suite/test name

cold island Aug 20, 2021, 8:04 PM

#

gritty wind Pro tip: edit the template to include the cwd, that way all your future suites h...

That's a good tip

fallen patrol Aug 20, 2021, 8:19 PM

#

fervent sage ~~use ui to open terminal, follow aru's advice <:kek:585617800257863727> ~~ /s

where I started:

"which [vscode] ext do you use for git?"
where I am:
"I type out most of my git commands"

#

(two quotes from me at different times)

green oriole Aug 20, 2021, 8:36 PM

#

I do everything via my terminal and you won't make me go out of the 80s era

remote wigeon Aug 20, 2021, 8:38 PM

#

lol

#

terminal rules

green oriole Aug 20, 2021, 8:42 PM

#

lol @eternal owl the link to the issue on your draft PR is broken, could you please correct it?

fallen patrol Aug 20, 2021, 9:07 PM

#

green oriole I do everything via my terminal and you won't make me go out of the 80s era

@Moderators this guy is obviously using a tui to connect to discord which is against ToS

fallen patrol Aug 20, 2021, 10:01 PM

#

FIGURED THIS OUT:
#dev-contrib message
tl;dr the reason that the bots aren't getting typing events is because its a discord.py bug

patent pivot Aug 20, 2021, 10:03 PM

#

fallen patrol FIGURED THIS OUT: https://canary.discord.com/channels/267624335836053506/6359505...

no it isn't

#

what

#

!int socket

stable mountainBOT Aug 20, 2021, 10:03 PM

#

WebSocket statistics

Receiving 2.01 events per second.

TYPING_START

22,558

MESSAGE_CREATE

17,241

GUILD_MEMBER_UPDATE

10,309

MESSAGE_UPDATE

2,117

VOICE_STATE_UPDATE

1,426

CHANNEL_CREATE

1,175

MESSAGE_REACTION_ADD

839

CHANNEL_UPDATE

758

MESSAGE_DELETE

589

CHANNEL_PINS_UPDATE

405

GUILD_MEMBER_ADD

315

MESSAGE_REACTION_REMOVE_ALL

269

GUILD_MEMBERS_CHUNK

251

GUILD_MEMBER_REMOVE

219

MESSAGE_REACTION_REMOVE_EMOJI

178

MESSAGE_REACTION_REMOVE

82

GUILD_JOIN_REQUEST_DELETE

49

GUILD_BAN_ADD

8

CHANNEL_DELETE

7

RESUMED

4

GUILD_CREATE

3

GUILD_UPDATE

2

READY

1

GUILD_BAN_REMOVE

1

patent pivot Aug 20, 2021, 10:03 PM

#

we get typing events lol

#

it was discord end

fallen patrol Aug 20, 2021, 10:03 PM

#

for dms

#

no, believe you me, I legit just talked to danny lol

patent pivot Aug 20, 2021, 10:04 PM

#

oh right, you didn't specify DMs lol, the thing you mentioned was not a discord.py bug

#

the message from kat was referencing a platform bug

fallen patrol Aug 20, 2021, 10:04 PM

#

ah

patent pivot Aug 20, 2021, 10:05 PM

#

we have never / will never use dm typing for python

#

https://github.com/python-discord/bot/blob/main/bot/bot.py#L116

stable mountainBOT Aug 20, 2021, 10:05 PM

#

bot/bot.py line 116

intents.dm_typing = False```

patent pivot Aug 20, 2021, 10:05 PM

#

lol

fallen patrol Aug 20, 2021, 10:05 PM

#

lol

patent pivot Aug 20, 2021, 10:06 PM

#

we still don't receive user_update which again I think is platform

fallen patrol Aug 20, 2021, 10:25 PM

#

ah

cold island Aug 20, 2021, 11:47 PM

#

Someone around who's familiar with the antispam cog? I'm a bit puzzled by how it was designed

brazen charm Aug 21, 2021, 12:13 AM

#

last time I was going to work with it I was heavily considering a rewrite first, but some other issue came up

cold island Aug 21, 2021, 12:17 AM

#

Yeah... I'm looking at this commit https://github.com/python-discord/bot/commit/14a67c187a38b9748fee375e15cfc9f6aa10fc6f and I can't really understand what problem it was trying to solve

brisk brook Aug 21, 2021, 12:42 AM

#

Isn't that the code that actually groups messages?

#

So, say I was spamming in a channel. Without that code it would count as multiple spams because I used multiple messages.

#

This code sets up queues and those deletion contexts, which are simply groups of messages?

#

Or am I thinking about it incorrectly?

cold island Aug 21, 2021, 12:52 AM

#

The code was already there, it was moved to a dedicated class

#

I just can't understand the commit message, because it works just fine on deleted messages

#

And also I don't see any call to a deleted messages endpoint, it just uploads them to a log

#

I'd assume from the code itself it's trying to prevent multiple log messages for the same spam event

#

Yeah if I strip the guards it tries to log it multiple times if I keep spamming after the filter is triggered

green oriole Aug 21, 2021, 7:11 AM

#

cold island Yeah... I'm looking at this commit https://github.com/python-discord/bot/commit/...

This one is to prevent a race condition where two messages are sent, and they both trigger anti-spam I believe

short snow Aug 21, 2021, 7:19 AM

#

There is one problem, in the wikipedia quess game, the extract includes the full name but the title only includes the first and last name

#

another one, there is no specific differentiation between such articles so i can't filter these out

#

this is how i form the questions currently

#

ok looks like those are the only two things i need to catch now

#

for names maybe we can get the match between the first and the last name, and remove that completel?

short snow Aug 21, 2021, 8:14 AM

#

I need to interact with the message cache to check for a deleted message, how can I access https://github.com/python-discord/bot/blob/main/bot/exts/moderation/modlog.py#L44

stable mountainBOT Aug 21, 2021, 8:14 AM

#

bot/exts/moderation/modlog.py line 44

self._cached_deletes = []```

short snow Aug 21, 2021, 8:21 AM

#

actually, I don't think we should do that since the deleted messages are only viewable by mod+ (ig) and incidents can be seen by helpers

#

cc: @sharp timber

green oriole Aug 21, 2021, 8:24 AM

#

short snow I need to interact with the message cache to check for a deleted message, how ca...

I'm not sure if we should rely on the cache. Maybe we could try it and fallback to scraping the history of the channel? Either way self.bot.get_cog("ModLog")._cached_deletes

green oriole Aug 21, 2021, 8:25 AM

#

short snow actually, I don't think we should do that since the deleted messages are only vi...

We know, if an helper tries to click the link they would get a 403 page, which isn't a problem. It is a pain to find a linked message in the deletion logs, and #incidents is more of a mod tool either way.

clever wraith Aug 21, 2021, 8:25 AM

#

hi

green oriole Aug 21, 2021, 8:26 AM

#

Hello!

short snow Aug 21, 2021, 8:26 AM

#

so i will just link to the message link and not display its content

#

hello 😄

green oriole Aug 21, 2021, 8:26 AM

#

Oh, Bast wanted to display the message directly

clever wraith Aug 21, 2021, 8:26 AM

#

iam new to this server can i get some roles

green oriole Aug 21, 2021, 8:26 AM

#

Yeah, I feel like we should instead link to the log entry, although I'd like to hear Bast's input

green oriole Aug 21, 2021, 8:27 AM

#

clever wraith iam new to this server can i get some roles

They are all described in #roles :)

clever wraith Aug 21, 2021, 8:27 AM

#

tq @green oriole

green oriole Aug 21, 2021, 8:28 AM

#

I don' t think we would be able to even show the content of deleted messages to helpers without a privacy police amendment, but I would have to double check that. I don't think it makes sense either way, that should be a mod only information.

short snow Aug 21, 2021, 8:28 AM

#

we could scrap the channel history but then we would need to parse the embed and then how many messages would be iterate through, finding messages a week back also can be a lot of messages.

Actually finding old messages isn't possible if we see the cache also since it won't retain them after restarts 🤷‍♂️

clever wraith Aug 21, 2021, 8:28 AM

#

@green oriole r u talking to me

green oriole Aug 21, 2021, 8:28 AM

#

I am taking to Jason

clever wraith Aug 21, 2021, 8:29 AM

#

oh sorry

green oriole Aug 21, 2021, 8:31 AM

#

short snow we could scrap the channel history but then we would need to parse the embed and...

Well, I feel like we could assume that if a helper has a link to a deleted message it is in the last 50 entries or so. If it isn't, oh well, we can search manually.

Also we need to keep in memory what messages are linked in the incident channel, and if one of those messages are deleted then we want to link it. Kind of the other way around.

clever wraith Aug 21, 2021, 8:31 AM

#

@green oriole i want roles and and i wanna learn python coding here

short snow Aug 21, 2021, 8:34 AM

#

green oriole Well, I feel like we could assume that if a helper has a link to a deleted messa...

Right, I don't think I get you for the second part do you mean if a staff links a deleted message then we should show the link to log entry? That's what i am doing rn

green oriole Aug 21, 2021, 8:36 AM

#

I also mean the other way around, consider the following case:

Someone sends a message X
A staffer links the message X in #incidents
The message X gets deleted
I would want the bot to add a link to the deletion log of the message X in incidents

short snow Aug 21, 2021, 8:37 AM

#

oh, so if a message gets deleted after linking? I would need to edit the modlog on message delete trigger then

green oriole Aug 21, 2021, 8:38 AM

#

clever wraith <@!407110650217627658> i want roles and and i wanna learn python coding here

Cool, you could ask for resources in #python-discussion! As for the roles, everything is described in #roles.

clever wraith Aug 21, 2021, 8:39 AM

#

cant u give me roles @green oriole

green oriole Aug 21, 2021, 8:39 AM

#

short snow oh, so if a message gets deleted after linking? I would need to edit the modlog ...

Yep! Or you could add an on_message_delete listener to the incident cog, that could keep things more simple I would say? Not sure, it may be hard to get the link to the log

green oriole Aug 21, 2021, 8:39 AM

#

clever wraith cant u give me roles <@!407110650217627658>

I don't have the permissions to do so, and even if I did you didn't do anything worth of a role, as described in #roles

clever wraith Aug 21, 2021, 8:40 AM

#

how do i get roles bud

green oriole Aug 21, 2021, 8:41 AM

#

I already told you to read #roles, I can't say better than that

clever wraith Aug 21, 2021, 8:41 AM

#

oh ok dont get angry

short snow Aug 21, 2021, 8:42 AM

#

green oriole Yep! Or you could add an on_message_delete listener to the incident cog, that co...

Possibly yes 😄 I will do that

#

thanks

clever wraith Aug 21, 2021, 8:44 AM

#

ok @green oriole where can i learn coding now

green oriole Aug 21, 2021, 8:44 AM

#

!resources you can have a look at our resources list

stable mountainBOT Aug 21, 2021, 8:44 AM

#

Resources

The Resources page on our website contains a list of hand-selected learning resources that we regularly recommend to both beginners and experts.

clever wraith Aug 21, 2021, 8:45 AM

#

ok

trim cradle Aug 21, 2021, 8:46 AM

#

@clever wraith to be clear, we do not give out roles randomly. If you have any other questions about roles, please ask in #community-meta. Thanks in advance!

clever wraith Aug 21, 2021, 8:47 AM

#

trim cradle <@456226577798135808> to be clear, we do not give out roles randomly. If you hav...

ok

cold island Aug 21, 2021, 12:06 PM

#

If I have a formula with -1 in two places, should I collapse it into a -2, or keep it separate if it makes the formula clearer?

#

I suppose I can put part of it in a separate variable to make it less obvious

#

Yeah ok, I know what to do

green oriole Aug 21, 2021, 12:17 PM

#

ducky_yellow

cold island Aug 21, 2021, 12:22 PM

#

Exactly lol

fervent sage Aug 21, 2021, 12:34 PM

#

It works lol

sharp timber Aug 21, 2021, 4:26 PM

#

green oriole Yeah, I feel like we should instead link to the log entry, although I'd like to ...

Yeah, this is completely reasonable. I was coming from the perspective that we'd want to show the message content (which is a point of the feature), with the gist that if we're forwarding message content then we need to be careful not to accidentally forward stuff if, say, someone accidentally has the wrong link in their buffer and pastes a link to a mod message, and that it would also (separately) be nice to get links to deleted message items.

timid sentinel Aug 21, 2021, 6:37 PM

#

!mute 503580753947394060

stable mountainBOT Aug 21, 2021, 6:37 PM

#

:incoming_envelope: :ok_hand: applied mute to @buoyant gulch until <t:1629574634:f> (59 minutes and 59 seconds).

tawdry vapor Aug 21, 2021, 7:58 PM

#

You're in the wrong channel. You can discuss it in #python-discussion if you want.

short snow Aug 22, 2021, 12:33 AM

#

short snow There is one problem, in the wikipedia quess game, the extract includes the full...

bump :D

#

can two messages in the different channels have the same id?

fallen patrol Aug 22, 2021, 12:46 AM

#

no

#

all messages are different ids

#

except that some things can share message ids

short snow Aug 22, 2021, 12:48 AM

#

ummm like?

#

rather than looking through the message history or the deleted cache, can i just make the deleted messages endpoint on the site GETable?

#

could probably add an addiontional key to deletedmessage_set for the modlog entry message link

short snow Aug 22, 2021, 2:42 AM

#

for any admin: do you explicitly set permission for helpers to read #incidents?

#

if yes that would make my life easier to check if the role can read the channel or not

vocal wolf Aug 22, 2021, 2:58 AM

#

short snow for any admin: do you explicitly set permission for helpers to read <#7142142122...

The roles that can read/write to the channel are partners, python community, and everyone above and including helpers

short snow Aug 22, 2021, 2:59 AM

#

is it explicitly set, like it is green ✅ for their role? if that isn't and it is based on a category then discord.py sets the permission to None and I would need to look a level higher to get the true value

vocal wolf Aug 22, 2021, 3:01 AM

#

The green checkmark for helpers is set for view channel and send messages

#

it is not synced with the category that the channel is in

short snow Aug 22, 2021, 3:04 AM

#

that should work I think, thanks xith :D

vocal wolf Aug 22, 2021, 3:26 AM

#

short snow that should work I think, thanks xith \:D

np

celest charm Aug 22, 2021, 3:49 AM

#

it does seem a bit surreal that people are contributing to features they can't even use 👀

short snow Aug 22, 2021, 5:00 AM

#

celest charm it does seem a bit surreal that people are contributing to features they can't e...

lol

severe tangle Aug 22, 2021, 5:08 AM

#

So I messaged in a help channel but @stable mountain didn't send me a DM regarding that channel... I have my DMs on and the setting enabled 7408_shrekstare

fallen patrol Aug 22, 2021, 5:35 AM

#

@vale ibex a heads up, the method used here https://github.com/python-discord/thread-bot/blame/main/bot/utils/helpers.py#L65 is already deprecated

GitHub

thread-bot/bot/utils/helpers.py at main · python-discord/thread-bot

Thread Bot. Contribute to python-discord/thread-bot development by creating an account on GitHub.

#

https://github.com/python-discord/thread-bot/tree/main/bot/utils/helpers.py#L65

#

🤔

#

!ping

stable mountainBOT Aug 22, 2021, 5:36 AM

#

You are not allowed to use that command here. Please use the #bot-commands channel instead.

fallen patrol Aug 22, 2021, 5:36 AM

#

ah

#

https://github.com/python-discord/thread-bot/blob/main/bot/utils/helpers.py#L65

stable mountainBOT Aug 22, 2021, 5:36 AM

#

bot/utils/helpers.py line 65

for thread in await channel.active_threads():```

fallen patrol Aug 22, 2021, 5:36 AM

#

!source Github

stable mountainBOT Aug 22, 2021, 5:36 AM

#

Bad argument

Unable to convert 'Github' to valid command, tag, or Cog.

static canyon Aug 22, 2021, 8:02 AM

#

Is bot#1742 okay to be merged now that it has passed all checks? (should probably unlink bot#1757 first though since it won't actually solve)

dusky shoreBOT Aug 22, 2021, 8:02 AM

#

GitHub

PROpen Remove redundant converters and renamed FetchedMember to MemberOrUser
IssueOpen Fallback to site DB on searches by username

cold island Aug 22, 2021, 8:06 AM

#

So.. There's an issue here

#

If it doesn't solve it, that means we still need the FetchedUser and FetchedMember converters, just with a different functionality

static canyon Aug 22, 2021, 8:08 AM

#

FetchedMember is still there, just renamed and will fallback to a discord.User (when the user isn't in server and ID was provided)

#

FetchedUser was removed

cold island Aug 22, 2021, 8:09 AM

#

static canyon FetchedMember is still there, just renamed and will fallback to a discord.User (...

I know, but if FetchedUser is returned in another form then it's not just Member or User anymore

static canyon Aug 22, 2021, 8:10 AM

#

cold island I know, but if FetchedUser is returned in another form then it's not just Member...

Then we update the variable I guess?

#

To like UserIdentifier or something

#

Which will be Union[discord.Member, discord.User, DatabaseUser]

cold island Aug 22, 2021, 8:11 AM

#

Hmm I suppose

static canyon Aug 22, 2021, 8:11 AM

#

I think it makes more sense to create a DatabaseUser class than a FetchUser which tries User then fallsback to what would be DatabaseUser

#

Since I don't think we want a converter to be able to return multiple different types

#

From a quick look in converters.py there isn't any converter with this behaviour currently (other than the Unions like MemberOrUser) , and I think it should stay this way

#

Otherwise a converter type becomes ambiguous

#

Does that seem right? @cold island

vocal wolf Aug 22, 2021, 8:17 AM

#

@static canyon have you learned how to squash commits? If so, please do when this PR is ready to be merged.

If you haven't learned how to, here's a guide: https://www.notion.so/pythondiscord/Squashing-a-Pull-Request-191e8efa2fbb4d72840fd17ca37cf7fa

static canyon Aug 22, 2021, 8:36 AM

#

vocal wolf <@!442244135840382978> have you learned how to squash commits? If so, please do ...

Which commits in particular need to be squished? The top abomination was squashed by Chrisjl but there's probably some after that which should be squished too tbf

vocal wolf Aug 22, 2021, 8:37 AM

#

The top stuff is still there. Will Chris be doing it at the end of the PR, or did he just forget to force push?

static canyon Aug 22, 2021, 8:37 AM

#

He did force push

#

vocal wolf Aug 22, 2021, 8:38 AM

#

#

I'm still seeing all this, maybe github is borked?

static canyon Aug 22, 2021, 8:38 AM

#

I see that too

vocal wolf Aug 22, 2021, 8:38 AM

#

I think Chris squashed something else

static canyon Aug 22, 2021, 8:39 AM

#

Yeah possibly

#

CC @vale ibex (if you can remember)

#

I'll squash if it needs to be done since learning opportunity lol

vocal wolf Aug 22, 2021, 8:42 AM

#

be sure to make a backup in case things go sideways

#

aka checkout to another branch, then switch back to the branch you intend to squash a bunch

short snow Aug 22, 2021, 8:46 AM

#

@vocal wolf I think the issue was approved when I started working on it and later it moved to planning

molten perch Aug 22, 2021, 8:47 AM

#

My god, I think I may have did something wrong.

vocal wolf Aug 22, 2021, 8:47 AM

#

oh dear

#

I see what you may have done wrong

molten perch Aug 22, 2021, 8:48 AM

#

I set the default option to be rebase

#

It seems like I shouldn't have.

vocal wolf Aug 22, 2021, 8:48 AM

#

git reset --hard d697860f22d13063a064ebc5982dea2dc127b0f0

#

that's when everything was normal in your PR

#

@molten perch

short snow Aug 22, 2021, 8:48 AM

#

same was the case for me, when i rebased main branch to my PR all this mess happened

#

(regarding enhancing incidents pr)

vocal wolf Aug 22, 2021, 8:49 AM

#

short snow <@!196664644113268736> I think the issue was approved when I started working on ...

It shall be made clear within the issue next time.

short snow Aug 22, 2021, 8:50 AM

#

Right, I also like the status:approved label on an issue to make it even clearer, like how it is done on sir lancebot

vocal wolf Aug 22, 2021, 8:51 AM

#

oh that's what I was forgetting about labels

vocal wolf Aug 22, 2021, 8:51 AM

#

short snow Right, I also like the status:approved label on an issue to make it even clearer...

we do have it on bot

short snow Aug 22, 2021, 8:51 AM

#

yeah but it isn't used

vocal wolf Aug 22, 2021, 8:52 AM

#

because it's new

#

@molten perch do you need help with fixing up your PR?

molten perch Aug 22, 2021, 8:54 AM

#

I'm on it, it should be fine any minute 😂

vocal wolf Aug 22, 2021, 8:54 AM

#

alright

molten perch Aug 22, 2021, 8:54 AM

#

Never happened before 😄

vale ibex Aug 22, 2021, 8:55 AM

#

vocal wolf I think Chris squashed something else

I force pushed, but forgot to tell @static canyon to reset the local branch

vocal wolf Aug 22, 2021, 8:55 AM

#

it happens at least once to every dev

vocal wolf Aug 22, 2021, 8:55 AM

#

vale ibex I force pushed, but forgot to tell <@442244135840382978> to reset the local bra...

ah

vale ibex Aug 22, 2021, 8:56 AM

#

It might be easier to just squash merge tbh

molten perch Aug 22, 2021, 8:57 AM

#

vocal wolf it happens at least once to every dev

It seems like, I can't 😄 I managed to hard reset my local branch, but I can't seem to get it to the remote one.

vocal wolf Aug 22, 2021, 8:57 AM

#

molten perch It seems like, I can't 😄 I managed to hard reset my local branch, but I can't s...

git push --force?

molten perch Aug 22, 2021, 8:57 AM

#

Everything up-to-date

vocal wolf Aug 22, 2021, 8:58 AM

#

are you sure you're on the right branch?

#

and in the right repo?

static canyon Aug 22, 2021, 8:58 AM

#

vale ibex It might be easier to just squash merge tbh

Wdym?

#

What do I need to do to squash the abomination?

molten perch Aug 22, 2021, 8:58 AM

#

vocal wolf are you sure you're on the right branch?

Oh yeah, I was still in rebase mode, so I was in no branch

vocal wolf Aug 22, 2021, 8:59 AM

#

molten perch Oh yeah, I was still in rebase mode, so I was in no branch

ah

molten perch Aug 22, 2021, 8:59 AM

#

Phew 😅 Thank you! 😄

vocal wolf Aug 22, 2021, 8:59 AM

#

np lol

#

much better

molten perch Aug 22, 2021, 9:00 AM

#

vocal wolf much better

So embarassing. Never happened before, this rebasing made everything chaotic. Sorry! 🙂

vocal wolf Aug 22, 2021, 9:00 AM

#

molten perch So embarassing. Never happened before, this rebasing made everything chaotic. So...

It's no problem, really. I tried reviving a 2 year old PR and ended up doing the same thing, but instead with 3k commits.

brisk brook Aug 22, 2021, 9:01 AM

#

static canyon I'll squash if it needs to be done since learning opportunity lol

It's actually very simple:

First, pick a commit to base on. If the tree looks like this:
A - B - C - D - E - F

And you want to squash A and B, then copy the SHA of C.

Now do git rebase -i MY_SHA_FOR_C, it will open a textfile in your editor where you can change the verb to the left of the SHAs.

In this case you want to squash A and B, but more importantly, you want to squash A into B. So change pick to squash or s for A.

Finally save and close the file, it will open another that will allow you to specify the commit message. Edit it and save, then the rebase should finish

vocal wolf Aug 22, 2021, 9:01 AM

#

it happens to all of us

#

and if it hasn't already, it will eventually

static canyon Aug 22, 2021, 9:02 AM

#

brisk brook It's actually very simple: First, pick a commit to base on. If the tree looks l...

Can I do like "move commit a,b,d into g"? (skipping commits)

molten perch Aug 22, 2021, 9:03 AM

#

vocal wolf and if it hasn't already, it will eventually

😂 Alright, fortunately that's what git made for! 🙂

static canyon Aug 22, 2021, 9:03 AM

#

I guess not since that would also change c,e,f

vocal wolf Aug 22, 2021, 9:04 AM

#

molten perch 😂 Alright, fortunately that's what git made for! 🙂

Remember to always refer to the website https://dangitgit.com/en

static canyon Aug 22, 2021, 9:04 AM

#

I want to "group" these into "Remove redundant..." "Update..." and "Remove unused..." (13 commits into 3)

brisk brook Aug 22, 2021, 9:05 AM

#

static canyon Can I do like "move commit a,b,d into g"? (skipping commits)

Yes, you can reorder the commits by moving the lines around. So say you want the order to be A - C - B - D.

You'll change ```
pick A Some text
pick B Other thing
pick C I don't know
pick D Final message

Into ```
pick A Some text
pick C I don't know
pick B Other thing
pick D Final message

#

You can also squash at the same time, so let's say we want it to be A - D. The file will look like this: ```
pick A Some text
squash C I don't know
squash B Other thing
pick D Final message

Now we squash C and B *into* D. So C, B, and D all become the same commit

vale ibex Aug 22, 2021, 9:06 AM

#

static canyon Wdym?

We have the option to squash everything into 1 commit when merging to main via the github ui

#

But using the opportunity to learn could be good

static canyon Aug 22, 2021, 9:07 AM

#

brisk brook You can also squash at the same time, so let's say we want it to be A - D. The f...

Right yeah that seems to make sense. I won't be able to actually do this for quite a few hours but am I okay to @ you when I do?

static canyon Aug 22, 2021, 9:07 AM

#

vale ibex But using the opportunity to learn could be good

Yeah, I would like to at least try

#

If I fail then we can do that lol

cold island Aug 22, 2021, 9:07 AM

#

static canyon Does that seem right? <@!512354988157173763>

Yeah that's fine 👍

vale ibex Aug 22, 2021, 9:07 AM

#

The reason it went wrong before is because I squashed on my local branch and pushed, but forgot to tell you to reset your local branch, so the next time you pushed, you pushed all of the other commits too

vocal wolf Aug 22, 2021, 9:07 AM

#

@static canyon make dat backup if you haven't already

brisk brook Aug 22, 2021, 9:07 AM

#

static canyon Right yeah that seems to make sense. I won't be able to actually do this for qui...

Feel free

static canyon Aug 22, 2021, 9:08 AM

#

vocal wolf <@!442244135840382978> make dat backup if you haven't already

dat backup?

#

Like copy all the files?

brisk brook Aug 22, 2021, 9:08 AM

#

vale ibex But using the opportunity to learn could be good

I mean, we still want to keep some of the history. Rather than just getting one commit

vocal wolf Aug 22, 2021, 9:09 AM

#

While on your branch that you're trying to squash, before you do anything major with the git history rewriting, git checkout -b backup-remove-redundant-converters or whatever you prefer. Then checkout back to the branch that you want to do all the crazy stuff on and continue from there.

static canyon Aug 22, 2021, 9:13 AM

#

vocal wolf While on your branch that you're trying to squash, before you do anything major ...

Right, so making an duplicate branch in case things go south?

vocal wolf Aug 22, 2021, 9:13 AM

#

ye

static canyon Aug 22, 2021, 9:13 AM

#

👍

vocal wolf Aug 22, 2021, 9:13 AM

#

@molten perch ty for PR, works very well

static canyon Aug 22, 2021, 9:13 AM

#

vocal wolf While on your branch that you're trying to squash, before you do anything major ...

.bm

static canyon Aug 22, 2021, 9:13 AM

#

brisk brook It's actually very simple: First, pick a commit to base on. If the tree looks l...

.bm

short snow Aug 22, 2021, 9:15 AM

#

lots of review requests 👀

vocal wolf Aug 22, 2021, 9:16 AM

#

@slim widget you available?

#

If so, please review this here thingy: https://github.com/python-discord/bot/pull/1749

short snow Aug 22, 2021, 9:17 AM

#

and this https://github.com/python-discord/bot/pull/1634

vocal wolf Aug 22, 2021, 9:18 AM

#

short snow *and this <https://github.com/python-discord/bot/pull/1634>*

I think we already have enough people reviewing that tbh

short snow Aug 22, 2021, 9:21 AM

#

only akarys that i know of

molten perch Aug 22, 2021, 9:23 AM

#

vocal wolf <@!263957159807549450> ty for PR, works very well

My pleasure! 😄

vocal wolf Aug 22, 2021, 9:25 AM

#

short snow only akarys that i know of

I'd like the other one to be finished first before allocating people to this PR.

green oriole Aug 22, 2021, 9:31 AM

#

I will see if I can allocate some time for modpings schedule next week

#

This is totally selfish but I really want this feature :3

green oriole Aug 22, 2021, 9:32 AM

#

vocal wolf If so, please review this here thingy: <https://github.com/python-discord/bot/pu...

Also it is being merged

vocal wolf Aug 22, 2021, 9:34 AM

#

cool

green oriole Aug 22, 2021, 9:37 AM

#

!remind @molten perch 10s partygopher

stable mountainBOT Aug 22, 2021, 9:37 AM

#

Absolutely!

Your reminder will arrive <t:1629625061:R> and will mention 1 other(s)!

stable mountainBOT Aug 22, 2021, 9:37 AM

#

green oriole !remind <@263957159807549450> 10s <a:partygopher:472490455096098827>

@molten perch

It has arrived!

Here's your reminder: :partygopher:
[Jump back to when you created the reminder](#dev-contrib message)

molten perch Aug 22, 2021, 9:38 AM

#

Yaay, can you delete your message before the reminder arrives? Just to make sure 😄

#

Oh, wait I can also 😄

stable mountainBOT Aug 22, 2021, 9:39 AM

#

Can do!

Your reminder will arrive <t:1629625157:R>!

#

@vocal wolf

It has arrived!

Here's your reminder: test
[Jump back to when you created the reminder](#dev-contrib message)

molten perch Aug 22, 2021, 9:39 AM

#

Perfect :3

vocal wolf Aug 22, 2021, 9:39 AM

#

now I'm realizing

#

does the embed need a link if it replies?

molten perch Aug 22, 2021, 9:40 AM

#

I think @tawdry vapor mentioned it in one of the issues.

vocal wolf Aug 22, 2021, 9:40 AM

#

what was the conclusion?

molten perch Aug 22, 2021, 9:40 AM

#

https://github.com/python-discord/bot/issues/1748

GitHub

Allow reminders in all channels · Issue #1748 · python-discord/bot

Currently the reminder feature is restricted to #bot-commands for non-staff which makes it a bit less convenient to use quickly and be able to jump back to the conversation itself without copying t...

vocal wolf Aug 22, 2021, 9:41 AM

#

ah

#

for consistency, that's understandable

molten perch Aug 22, 2021, 9:41 AM

#

So, I took the liberty and added it 😄

brisk brook Aug 22, 2021, 9:41 AM

#

vocal wolf does the embed need a link if it replies?

When a lot of messages has been sent, it could sometimes show up as "Message could not be resolved". I think the link should be there

green oriole Aug 22, 2021, 9:41 AM

#

And we got a sentry

There was an error when trying to reply to a reminder invocation message, 400 Bad Request (error code: 50035): Invalid Form Body
In message_reference: Unknown message, fall back to using jump_url

green oriole Aug 22, 2021, 9:42 AM

#

stable mountain <@196664644113268736>

Which is from this one it seems like

vocal wolf Aug 22, 2021, 9:42 AM

#

oh we didn't need that high of a log level then

green oriole Aug 22, 2021, 9:42 AM

#

Actually

#

Don't you need an non empty message to be able to reply?

#

!remind 1s test

stable mountainBOT Aug 22, 2021, 9:42 AM

#

Yep.

Your reminder will arrive <t:1629625379:R>!

stable mountainBOT Aug 22, 2021, 9:42 AM

#

green oriole !remind 1s test

It has arrived!

Here's your reminder: test
[Jump back to when you created the reminder](#dev-contrib message)

green oriole Aug 22, 2021, 9:43 AM

#

Nope

#

That is weird

#

Yeah, we should lower the log level to like info

vocal wolf Aug 22, 2021, 9:43 AM

#

I make fast PR

molten perch Aug 22, 2021, 9:44 AM

#

Yeah, I'm not sure why I left it on "error" level, right after that it falls back to the jump_url behaviour 😄

#

So, it's expected.. I believe.

green oriole Aug 22, 2021, 9:46 AM

#

I've just noticed your branch name for the reply PR, this is a galaxy brain move

molten perch Aug 22, 2021, 9:46 AM

#

I thought no-one would notice py_guido

vocal wolf Aug 22, 2021, 9:47 AM

#

@green oriole k here https://github.com/python-discord/bot/pull/1761

green oriole Aug 22, 2021, 9:48 AM

#

Already approved

#

I am speed

vocal wolf Aug 22, 2021, 9:48 AM

#

vocal wolf <@!407110650217627658> k here <https://github.com/python-discord/bot/pull/1761>

@vale ibex review

green oriole Aug 22, 2021, 9:48 AM

#

LOL I like how this is an order

vale ibex Aug 22, 2021, 9:49 AM

#

joe_salute

green oriole Aug 22, 2021, 9:50 AM

#

Review now, or.. I can't find a great pun

vale ibex Aug 22, 2021, 9:50 AM

#

Akarys is review boss

#

Xith is review master

vocal wolf Aug 22, 2021, 9:51 AM

#

vale ibex Xith is review master

joe_salute

#

I've never approved on mobile before, is it even possible?

#

within the github app

#

ok

#

no

#

that's not fair lmao

vale ibex Aug 22, 2021, 9:52 AM

#

kek

vocal wolf Aug 22, 2021, 9:52 AM

#

I disabled it, how did you still merge??

vale ibex Aug 22, 2021, 9:52 AM

#

I manually merged

vocal wolf Aug 22, 2021, 9:52 AM

#

ah fuck

green oriole Aug 22, 2021, 9:52 AM

#

lol I reviewed quite a few little PRs on mobile

vale ibex Aug 22, 2021, 9:52 AM

#

vocal wolf Aug 22, 2021, 9:52 AM

#

github didn't give me that option

#

wait I disabled it and that gave you the power to do so

#

damn

vale ibex Aug 22, 2021, 9:53 AM

#

lol

green oriole Aug 22, 2021, 9:53 AM

#

lol you glitched github

vocal wolf Aug 22, 2021, 9:53 AM

#

oh now it says re-enabled, thanks github, I, the troller, got trolled

#

lol

green oriole Aug 22, 2021, 9:53 AM

#

Auto merge is quite buggy if the PR switches to a mergeable state

vocal wolf Aug 22, 2021, 9:54 AM

#

@vale ibex ty anyways

green oriole Aug 22, 2021, 9:54 AM

#

Yeah, you get exactly that

#

If you refresh it goes away and you have the green button

stable mountainBOT Aug 22, 2021, 9:54 AM

#

No problem.

Your reminder will arrive <t:1629626103:R>!

#

@vocal wolf

It has arrived!

Here's your reminder: test
[Jump back to when you created the reminder](#dev-contrib message)

vocal wolf Aug 22, 2021, 9:55 AM

#

it good now

#

no error

slim widget Aug 22, 2021, 10:26 AM

#

vocal wolf If so, please review this here thingy: <https://github.com/python-discord/bot/pu...

Sorry, just saw this.

vocal wolf Aug 22, 2021, 10:27 AM

#

it is the np

slim widget Aug 22, 2021, 10:28 AM

#

Akarys is fast 😄

clever wraith Aug 22, 2021, 10:39 AM

#

Hi

green oriole Aug 22, 2021, 12:36 PM

#

Hello

static canyon Aug 22, 2021, 4:31 PM

#

brisk brook Yes, you can reorder the commits by moving the lines around. So say you want the...

I'm on my laptop now, how do move these around? What's the terminal command?

#

I have a-l and I want to make it intopy a b m # 3 commits into one c d e f g i k # 7 commits into one h j l # 3 commits into one

brisk brook Aug 22, 2021, 4:34 PM

#

So copy the SHA of commit M

#

Then do git rebase -i MY_SHA

static canyon Aug 22, 2021, 4:35 PM

#

So if the commit is https://github.com/python-discord/bot/pull/1742/commits/cbb5914bf8fa510550d9b2b6cb1b0569ccea396c then the SHA is the cbb59...396c right?

brisk brook Aug 22, 2021, 4:36 PM

#

Yup

static canyon Aug 22, 2021, 4:37 PM

#

PS C:\Users\tizzy\bot> git rebase -i cbb5914bf8fa510550d9b2b6cb1b0569ccea396c
error: cannot rebase: You have unstaged changes.
error: Please commit or stash them```

#

It's because I changed the config-default.yml but don't want to commit that change

vocal prairie Aug 22, 2021, 4:37 PM

#

You can stash it then

#

I forget the exact syntax, but git stash --help should tell you

brazen charm Aug 22, 2021, 4:39 PM

#

what did you change the default config for?

static canyon Aug 22, 2021, 4:39 PM

#

brazen charm what did you change the default config for?

So that I didn't get a whole load of env issues when running a linter or something

brazen charm Aug 22, 2021, 4:39 PM

#

the user config file should take priority for all keys

static canyon Aug 22, 2021, 4:39 PM

#

I changed bot: token from !ENV "BOT_TOKEN" to just "BOT_TOKEN" so that I didn't get errors about missing env variable

vocal prairie Aug 22, 2021, 4:40 PM

#

Why use the config-default.yml for that, why not just use config.yml?

static canyon Aug 22, 2021, 4:40 PM

#

There isn't a config.yml

brazen charm Aug 22, 2021, 4:41 PM

#

you're supposed to create it, it's not a tracked file

static canyon Aug 22, 2021, 4:41 PM

#

So revert the change in config-default.yml and make the change in config.yml instead?

brisk brook Aug 22, 2021, 4:41 PM

#

Just do git stash, then git stash pop when you're done

brazen charm Aug 22, 2021, 4:42 PM

#

yes, just copying the changed part of the config to config.yml should work fine

static canyon Aug 22, 2021, 4:42 PM

#

So having config.yml asyml bot: token: "BOT TOKEN"?

brazen charm Aug 22, 2021, 4:43 PM

#

yeah I think that should work

static canyon Aug 22, 2021, 4:44 PM

#

Okay, done

#

It still thinks there's a change in the config-default.yml so I'll have to stash anyway

brazen charm Aug 22, 2021, 4:44 PM

#

revert the file

static canyon Aug 22, 2021, 4:44 PM

#

How?

brisk brook Aug 22, 2021, 4:45 PM

#

Just stash it, reverting is a bit scary

static canyon Aug 22, 2021, 4:45 PM

#

I'll just stash for now since I'm meant to be doing squashing right now lol

brazen charm Aug 22, 2021, 4:45 PM

#

git checkout config-default.yml

#

if they keep the changes around stashing for every change to the branch will be a pita

static canyon Aug 22, 2021, 4:47 PM

#

brazen charm `git checkout config-default.yml`

Did this 👍

#

Now git diff isn't showing the file so guess it worked

static canyon Aug 22, 2021, 4:47 PM

#

brisk brook Then do `git rebase -i MY_SHA`

Right, what do I do after this?

brisk brook Aug 22, 2021, 4:48 PM

#

Do you see a file open?

#

Can you copy and send the contents so I have a better idea

static canyon Aug 22, 2021, 4:48 PM

#

brisk brook Can you copy and send the contents so I have a better idea

#

As text:

📎 message.txt

brisk brook Aug 22, 2021, 4:50 PM

#

In subcommands, if you give it aliases like: append -> a you still need to do group a. Root aliases allow you to set an alias so for example agroup will call the subcommand

brisk brook Aug 22, 2021, 4:50 PM

#

static canyon

Perfect, start with reordering them as you wish. Remember that commits squash down so you will have to reorder them to be next to each other

static canyon Aug 22, 2021, 4:52 PM

#

brisk brook Perfect, start with reordering them as you wish. Remember that commits squash do...

Can I also edit commit messages?

#

For the ones I'm going to use as a base

#

(Just out of interest)

brisk brook Aug 22, 2021, 4:52 PM

#

So when you squash you will get a chance to edit the message

static canyon Aug 22, 2021, 4:53 PM

#

Actually no

brisk brook Aug 22, 2021, 4:53 PM

#

Otherwise you can change the verb pick to edit. This will stop the rebase and allow you to amend the commit

static canyon Aug 22, 2021, 4:53 PM

#

I think I rebased the wrong thing

#

It's showing commits made after not before

#

#

It's showing from the first one made after (the bottom in image)

#

@brisk brook

brisk brook Aug 22, 2021, 4:54 PM

#

And you want to change the first few?

static canyon Aug 22, 2021, 4:54 PM

#

Yes

#

Everything before (and including) cbb5914

#

I rebased cbb5914 and it's showing everything after

brisk brook Aug 22, 2021, 4:55 PM

#

Then delete all lines in the file, save, and quit it.

#

Let's abort and try again

static canyon Aug 22, 2021, 4:55 PM

#

brisk brook Then delete all lines in the file, save, and quit it.

"quit it"?

brisk brook Aug 22, 2021, 4:56 PM

#

static canyon "quit it"?

Close the file, it's open in an editor so close that tab

static canyon Aug 22, 2021, 4:56 PM

#

PS C:\Users\tizzy\bot> git rebase -i cbb5914bf8fa510550d9b2b6cb1b0569ccea396c
error: nothing to do```seems to have worked

#

So I guess I need to git rebase -i 6dfe53b... (the top commit)?

brisk brook Aug 22, 2021, 4:57 PM

#

static canyon Everything *before* (and including) cbb5914

So remember, a Git commit history is a one-way timeline (append-only).

You can't do something before a commit and have it not change subsequentl commits.

What you'll have to do is pick more commits to rebase, but just change the bottom ones you don't want to change.

brisk brook Aug 22, 2021, 4:58 PM

#

static canyon So I guess I need to `git rebase -i 6dfe53b...` (the top commit)?

Is that "Remove redundant converters"?

static canyon Aug 22, 2021, 4:58 PM

#

brisk brook Is that "Remove redundant converters"?

Yes

brisk brook Aug 22, 2021, 4:58 PM

#

Pick the one before it

static canyon Aug 22, 2021, 4:58 PM

#

There isn't one before it

#

That's the first commit I made to the branch

brisk brook Aug 22, 2021, 5:00 PM

#

static canyon There isn't one before it

There is, it's in the bot's branch.

\   |
 \  |
  \ |
   \|
     |     <- This commit

Left is your branch, right is the bot branch. GitHub only shows the difference, that is, the commits you have but the main branch doesn't.

#

Yes, those are normal discord.py names

static canyon Aug 22, 2021, 5:01 PM

#

Right

#

So I need to find when I made the branch I guess

#

(How do I do that? xD)

#

#dev-log works I guess

brisk brook Aug 22, 2021, 5:02 PM

#

static canyon So I need to find when I made the branch I guess

This is probably easiest done locally, from the perspective of Git. Where your branch still is a straight line.

#

Do git log and press ENTER to scroll

static canyon Aug 22, 2021, 5:02 PM

#

#dev-log message this is it

brisk brook Aug 22, 2021, 5:02 PM

#

I don't know, you're really not meant to haha

brisk brook Aug 22, 2021, 5:03 PM

#

static canyon https://discord.com/channels/267624335836053506/622895325144940554/8750317835388...

I don't think so?

static canyon Aug 22, 2021, 5:03 PM

#

brisk brook I don't think so?

That's the last commit before I opened the branch

#

Because the message after it is me opening the branch

#

Although that's in a branch, not main, so nvm I guess

brisk brook Aug 22, 2021, 5:04 PM

#

static canyon Although that's in a branch, not `main`, so nvm I guess

Exactly. I think this might be it? https://github.com/python-discord/bot/commit/d5ee28133f8e792526716b07d25cbf6e4faba3a1

GitHub

Merge pull request #1738 from python-discord/dynamic-dormant-messag...

Make DORMANT_MSG Dynamic

static canyon Aug 22, 2021, 5:04 PM

#

#dev-log message this I guess

brisk brook Aug 22, 2021, 5:05 PM

#

I opened the commit you linked above, and pressed Parent

brisk brook Aug 22, 2021, 5:05 PM

#

static canyon https://discord.com/channels/267624335836053506/622895325144940554/8750432835192...

You don't really know though, when did you create the branch?

static canyon Aug 22, 2021, 5:06 PM

#

brisk brook You don't really know though, when did you create the branch?

11th aug #dev-log message

brisk brook Aug 22, 2021, 5:06 PM

#

Like I said, just type git log and find the commit before "Remove redundant converters"

#

Git will know

patent pivot Aug 22, 2021, 5:07 PM

#

wait this issn't stafff liunge LOL

static canyon Aug 22, 2021, 5:08 PM

#

brisk brook Like I said, just type `git log` and find the commit before "Remove redundant co...

#

So the one you linked from the looks of it

#

6dfe is my first, d5ee is the one before

#

So git rebase -i d5ee...? @brisk brook

brisk brook Aug 22, 2021, 5:10 PM

#

Yep!

static canyon Aug 22, 2021, 5:12 PM

#

Right okay

#

This is what I've got

📎 message.txt

#

I just need to group them together right?

brisk brook Aug 22, 2021, 5:14 PM

#

I am on my phone ATM, I can't read that text file. A screenshot will be fine

static canyon Aug 22, 2021, 5:14 PM

#

Okay

#

Before:

green oriole Aug 22, 2021, 5:15 PM

#

Change every pick except the first one to squash

gritty wind Aug 22, 2021, 5:15 PM

#

This is the point where I plug GUIs

static canyon Aug 22, 2021, 5:15 PM

#

After (have only changed order)

gritty wind Aug 22, 2021, 5:16 PM

#

Git User Interfaces*

#

I don’t think git will handle that particularly wel

#

Maybe it’ll just ignore it

#

You don’t need to change the order though

brazen charm Aug 22, 2021, 5:17 PM

#

changing the rebase actions is relatively fine, but for resolving the conflicts that may come up I'd always go through a gui

gritty wind Aug 22, 2021, 5:19 PM

#

I’ve got some fun aftermath stuff from today’s PATMA event

#

This is the entirety of the sentry error log for the bot. The 403s were just misconfigurations of perms. It speaks to the quality of @stable mountain since the code is just copied from there 😛

static canyon Aug 22, 2021, 5:20 PM

#

static canyon After (have only changed order)

What exactly do I need to do now?

gritty wind Aug 22, 2021, 5:21 PM

#

For squashing, keep the order the same, and just change the ‘pick’ beside each commit

#

For commits you want to keep, leave it as pick

#

For ones you want squashed into others, use squash instead of pick

#

Then save and close the file

#

There are other keywords that are used for things that aren’t squashing

#

You may be able to see them in a comment somewhere, possibly in your terminal

brazen charm Aug 22, 2021, 5:23 PM

#

they are in the generated file

gritty wind Aug 22, 2021, 5:24 PM

#

More event stuff. This is my DO panel for snekbox (just snekbox, the bot ran in a separate instance). It managed really well as far as I could tell. You can actually see right about when the event started 🤡. No major problems though (now if they’d just pay for my personal cloud)

static canyon Aug 22, 2021, 5:29 PM

#

gritty wind For ones you want squashed into others, use squash instead of pick

But how does it know what to squash into what?

static canyon Aug 22, 2021, 5:30 PM

#

static canyon I have a-l and I want to make it into```py a b m # 3 commits into one c d e f g...

This is what I'm trying to do @gritty wind

gritty wind Aug 22, 2021, 5:33 PM

#

It’ll merge them into the commits on top (older) of them

#

For instance, if you have commits a, b, c, d (a being oldest), squashing b and c will result in:

a, b, c
d

#

Trying to jump up to the message, but mobile is being funky

#

I see your message now

#

So, if your oldest commit is a, you’d want to make sure you have b and m right below it, set a to pick, b and m to squash, and you’ll end get what you want

#

You may end up with conflicts though

#

An alternative to this approach is to reset your current branch to the base revision you checked out from using ‘soft’

#

What that’ll do is it’ll drop all your commits, but keep the actual current version of things

static canyon Aug 22, 2021, 5:37 PM

#

gritty wind For instance, if you have commits a, b, c, d (a being oldest), squashing b and c...

Which is why I need to reorder the commits?

gritty wind Aug 22, 2021, 5:37 PM

#

Yeah

static canyon Aug 22, 2021, 5:37 PM

#

static canyon After (have only changed order)

Which is what I'm doing here, right?

#

Do I need to change to squash too or just reorder?

gritty wind Aug 22, 2021, 5:38 PM

#

I believe so, tho I only saw the abbreviated titles, not the actual commit names

gritty wind Aug 22, 2021, 5:38 PM

#

static canyon Do I need to change to `squash` too or just reorder?

Yeah, you need to change to squash

#

Or tennis if you’re into that

static canyon Aug 22, 2021, 5:46 PM

#

Lol

static canyon Aug 22, 2021, 5:46 PM

#

gritty wind For instance, if you have commits a, b, c, d (a being oldest), squashing b and c...

Will the commit have the name of a?

gritty wind Aug 22, 2021, 5:46 PM

#

You’ll get another prompt to edit the message

#

It’ll show all three together, and you get to mold them as you like

static canyon Aug 22, 2021, 5:47 PM

#

Right yeah

#

I'll do that now

#

How do I delete a commit? @gritty wind

#

I have duplicates from when Chrisjl squashed earlier but forgot to tell me I had to reset my local branch or something

gritty wind Aug 22, 2021, 5:53 PM

#

So are you deleting them just from history, or do you want to remove the changes too

static canyon Aug 22, 2021, 5:53 PM

#

Hmm

#

Just history, because there wasn't any changes made (the ones I'm deleting are squashes)

gritty wind Aug 22, 2021, 5:54 PM

#

Okay

#

You can just squash them into any other commit, and provided the same code existed at the commit you’re merging to, it’ll disappear from history

#

I.E if commit C has the same code as commit B, squashing C into B will make it disappear (you just need to remove the message)

#

Fixup may also do this thing, but I’ve never used it

gritty wind Aug 22, 2021, 5:57 PM

#

gritty wind An alternative to this approach is to reset your current branch to the base revi...

Have you considered this? I find it usually the best option when you’re basically completely rewriting your branch

static canyon Aug 22, 2021, 5:57 PM

#

I'm interested in doing it this way just cause I'm learning a lot about git

gritty wind Aug 22, 2021, 5:58 PM

#

In that case, do look into fixup haha

static canyon Aug 22, 2021, 6:00 PM

#

I'm so scared I'm gonna do this wrong lol

#

But I guess that's why I made the backup branch

brisk brook Aug 22, 2021, 6:04 PM

#

static canyon But I guess that's why I made the backup branch

You do also have GitHub

static canyon Aug 22, 2021, 6:05 PM

#

Think this is right

#

2,3 merges into 1
5,6,7,8,9 merges into 4
11,12,13 merges into 10
15 merges into 14

brisk brook Aug 22, 2021, 6:10 PM

#

Yes that looks good

static canyon Aug 22, 2021, 6:17 PM

#

Thanks 👍

#

Will confirm when I go back upstairs

static canyon Aug 22, 2021, 6:35 PM

#

Where do I write it? @brisk brook

#

Bottom of file I guess? (L31)

brisk brook Aug 22, 2021, 6:40 PM

#

static canyon Where do I write it? <@!344404945359077377>

There's 3 lines that don't have a #.

#

The first line will be the commit message, if you have more lines under it those will become the description

static canyon Aug 22, 2021, 6:40 PM

#

👌

#

So like this? @brisk brook

brisk brook Aug 22, 2021, 6:42 PM

#

Remove the other uncommented lines, you don't need them

static canyon Aug 22, 2021, 6:42 PM

#

brisk brook Remove the other uncommented lines, you don't need them

So this?

static canyon Aug 22, 2021, 6:58 PM

#

PS C:\Users\tizzy\bot> git rebase -i d5ee28133f8e792526716b07d25cbf6e4faba3a1
...
error: could not apply a0f079d7... Rename converter from FetchedMember to MemberOrUser
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply a0f079d7... Rename converter from FetchedMember to MemberOrUser
Auto-merging bot/errors.py
CONFLICT (content): Merge conflict in bot/errors.py
Auto-merging bot/converters.py
PS C:\Users\tizzy\bot>```

#

I got an error

#

Not really sure what the conflict is

fallen patrol Aug 22, 2021, 7:01 PM

#

open that file in a gui editor

brisk brook Aug 22, 2021, 7:02 PM

#

static canyon ``` PS C:\Users\tizzy\bot> git rebase -i d5ee28133f8e792526716b07d25cbf6e4faba3a...

What happened was that when you reordered it Git couldn't merge the two files. You probably changed two things at the same time

#

You will see something like: ```
<<<<<<<< AAAAHHHHH
from collections import abc

from collections.abc import XYZ

AAAHHHGGG

fallen patrol Aug 22, 2021, 7:04 PM

#

AAAAHHHHH
wait what

static canyon Aug 22, 2021, 7:16 PM

#

Right okay

#

I may have done it

brisk brook Aug 22, 2021, 7:16 PM

#

Great, now do git add bot/errors.py

#

And then git rebase --continue

static canyon Aug 22, 2021, 7:17 PM

#

Yeah I've done a whole load of conflicts

#

Now got the Successfully rebased and updated refs/heads/remove-redundant-converters.message

#

No clue what to do now though lol @brisk brook

brisk brook Aug 22, 2021, 7:18 PM

#

Do git log and check the history

static canyon Aug 22, 2021, 7:19 PM

#

I appear to still have a duplicate (top and bottom)

#

Ah wait no I know why

#

I now need to remove 3 commits from the history

#

Right okay

static canyon Aug 22, 2021, 7:24 PM

#

brisk brook Do `git log` and check the history

I think it's good locally

brisk brook Aug 22, 2021, 7:25 PM

#

Ah okay

static canyon Aug 22, 2021, 7:26 PM

#

So what do I do now?

fallen patrol Aug 22, 2021, 7:27 PM

#

git push presumably

static canyon Aug 22, 2021, 7:27 PM

#

Hopefully I'm in the correct branch and stuff

fallen patrol Aug 22, 2021, 7:27 PM

#

then uh, git status

fallen patrol Aug 22, 2021, 7:27 PM

#

static canyon Hopefully I'm in the correct branch and stuff

to check this, do git status

#

something like this:

static canyon Aug 22, 2021, 7:28 PM

#

PS C:\Users\tizzy\bot> git push
To github.com:python-discord/bot.git
 ! [rejected]          remove-redundant-converters -> remove-redundant-converters (non-fast-forward)
error: failed to push some refs to 'github.com:python-discord/bot.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
PS C:\Users\tizzy\bot>```

fallen patrol Aug 22, 2021, 7:28 PM

#

ergh

#

uh

#

git fetch

static canyon Aug 22, 2021, 7:28 PM

#

But I don't want to

brazen charm Aug 22, 2021, 7:28 PM

#

you changed the history, you need to force the push

fallen patrol Aug 22, 2021, 7:28 PM

#

oh

static canyon Aug 22, 2021, 7:28 PM

#

brazen charm you changed the history, you need to force the push

git push -f?

fallen patrol Aug 22, 2021, 7:29 PM

#

ye

fallen patrol Aug 22, 2021, 7:29 PM

#

static canyon But I don't want to

git fetch doesn't make a commit

#

git fetch just checks if there's been any changes on the remotes

#

I think you're thinking of git pull

static canyon Aug 22, 2021, 7:30 PM

#

Ah right I was thinking of git pull (I didn't want to change my local copy)

#

Yeah

fallen patrol Aug 22, 2021, 7:30 PM

#

which internally runs git fetch && git merge (tldr)

static canyon Aug 22, 2021, 7:30 PM

#

👍

#

Ty

fallen patrol Aug 22, 2021, 7:31 PM

#

as an aside I tend to run git fetch --prune which removes references to deleted branches on the default remote

static canyon Aug 22, 2021, 7:35 PM

#

31 comments to 15 😄

#

It looks like everything's correct too which is always nice

#

Can someone please confirm that I've done this squashing correctly on bot#1742?

dusky shoreBOT Aug 22, 2021, 7:37 PM

#

GitHub

PROpen Remove redundant converters and renamed FetchedMember to MemberOrUser

static canyon Aug 22, 2021, 7:42 PM

#

Also @green oriole I forgot "solves" isn't a term for linking a PR with an issue so bot#1763 has to be closed (not sure how to manually link them)

dusky shoreBOT Aug 22, 2021, 7:42 PM

#

GitHub

IssueOpen Weird stage state causes users to not have a .joined_at attribute

green oriole Aug 22, 2021, 7:42 PM

#

Oh

#

I am not logged in on that device, can someone close it please?

static canyon Aug 22, 2021, 7:43 PM

#

green oriole I am not logged in on that device, can someone close it please?

If it's just a case of closing I can do that but wasn't sure whether I needed to link it to the PR first

green oriole Aug 22, 2021, 7:44 PM

#

Oh, of course you can, I'm silly

#

You can just say "Solved by #XXX" and close

static canyon Aug 22, 2021, 7:44 PM

#

Okay 👍

static canyon Aug 22, 2021, 7:44 PM

#

static canyon Can someone please confirm that I've done this squashing correctly on bot#1742?

Can you double check this pls if you get a chance

brisk brook Aug 22, 2021, 8:16 PM

#

#

Should these perhaps be squashed?

static canyon Aug 22, 2021, 8:44 PM

#

They are all different fixes

#

But I suppose they could be

#

I think the rename should be separate at least

#

The last three were a case of "commit, lint failed. Fix the lint issue, commit, etc.."

cold island Aug 22, 2021, 8:49 PM

#

@static canyon made one last requested change

#

Otherwise looks good

static canyon Aug 22, 2021, 8:50 PM

#

Yeah, just fixed it ^^

cold island Aug 22, 2021, 8:50 PM

#

Cool

#

@vale ibex I don't have too much experience with that, but are you sure https://github.com/python-discord/bot/pull/1762/files#diff-ea2117893ba180856952bc6c6734b882f9554bc4dfe169bcc344b5d65054fc95R45 will work as intended?
Looking at https://discordpy.readthedocs.io/en/stable/ext/commands/api.html#discord.ext.commands.Cog.cog_command_error it seems to expect a CommandError

static canyon Aug 22, 2021, 8:53 PM

#

cold island <@!442244135840382978> made one last requested change

I believe you need to re-review for it to acknowledge it's been changed btw

cold island Aug 22, 2021, 8:56 PM

#

Yeah I know, was just going over the commits one last time

static canyon Aug 22, 2021, 8:56 PM

#

👍

vale ibex Aug 22, 2021, 8:58 PM

#

cold island <@!126811506632294400> I don't have too much experience with that, but are you s...

it works, I guess the typehint isn't correct though

#

I copied it from elsewhere

cold island Aug 22, 2021, 8:59 PM

#

Does changing the typehint change the exceptions being directed to the function?

vale ibex Aug 22, 2021, 9:00 PM

#

Calling type() on that error still shows it as a commanderror

#

so it doesn't seem like it

#

guess they don't pass through converters

cold island Aug 22, 2021, 9:00 PM

#

Odd

vale ibex Aug 22, 2021, 9:00 PM

#

cold island Aug 22, 2021, 9:00 PM

#

Well I'm not sure how to functionally test it

vale ibex Aug 22, 2021, 9:00 PM

#

with buttons that remove themselves after being clicked

#

🎉

vale ibex Aug 22, 2021, 9:01 PM

#

cold island Well I'm not sure how to functionally test it

uhhh, you can test it using your metabase username and password implicitly via the export

#

Actually, you can test the share too, as long as you choose a question that's already marked as publicly shareable

brisk brook Aug 22, 2021, 9:02 PM

#

vale ibex with buttons that remove themselves after being clicked

You can edit the message 😔

vale ibex Aug 22, 2021, 9:02 PM

#

brisk brook You can edit the message 😔

that's how I'm doing it lol

#

I just thought I'd mention it since @radiant merlin doesn't remove his buttons kek

static canyon Aug 22, 2021, 9:21 PM

#

Should I make a quick PR for bot#1750? It's just changing the time format used

dusky shoreBOT Aug 22, 2021, 9:21 PM

#

GitHub

IssueOpen Use DAY_TIME or DATE_TIME timestamp format for reminders

vale ibex Aug 22, 2021, 9:21 PM

#

Go for it 😄

#

Also, small note that I've finished implementing the interactions side of this, buttons are really nice to work with in d.py

fallen patrol Aug 22, 2021, 9:26 PM

#

uh

#

static canyon Aug 22, 2021, 9:33 PM

#

bot#1766 reviews please (literally just changing a timestamp format)

dusky shoreBOT Aug 22, 2021, 9:33 PM

#

GitHub

PROpen Update time format in reminder message to DAY_TIME from RELATIVE

brazen charm Aug 22, 2021, 9:37 PM

#

fallen patrol

Probably match a member, should we move the mentions to the end?

vale ibex Aug 22, 2021, 9:37 PM

#

fallen patrol

I'm guessing the user converter got greedy, and there are people named 3D and maybe

fallen patrol Aug 22, 2021, 9:37 PM

#

I mean

#

hm

static canyon Aug 22, 2021, 9:37 PM

#

~~There is a user named 3D because I accidentally muted them the other day~~

vale ibex Aug 22, 2021, 9:38 PM

#

I wonder if we should be stricter with those converters, since we don't really want to match strings there

fallen patrol Aug 22, 2021, 9:38 PM

#

vale ibex I'm guessing the user converter got greedy, and there are people named 3D and ma...

feels the fix in that case would be to make a param user converter to be only checking for mentions or IDs

vale ibex Aug 22, 2021, 9:38 PM

#

yea, that's my thought too

#

remove the str option for that converter

static canyon Aug 22, 2021, 9:38 PM

#

!src remind

stable mountainBOT Aug 22, 2021, 9:38 PM

#

Command: remind

Commands for managing your reminders.

Source Code

Go to GitHub

fallen patrol Aug 22, 2021, 9:39 PM

#

!remind Chrisjl#2655 1s test

stable mountainBOT Aug 22, 2021, 9:39 PM

#

Naw.

You can't mention other members/roles in your reminder!

fallen patrol Aug 22, 2021, 9:39 PM

#

!remind 3D 1s test

stable mountainBOT Aug 22, 2021, 9:39 PM

#

No way, José.

You can't mention other members/roles in your reminder!

fallen patrol Aug 22, 2021, 9:39 PM

#

yep, its a user

static canyon Aug 22, 2021, 9:39 PM

#

MentionOrID is already a converter so I guess you can use that

vale ibex Aug 22, 2021, 9:39 PM

#

!remind A Real Username#8028 1s test

brazen charm Aug 22, 2021, 9:39 PM

#

it's using the dpy converters for members

fallen patrol Aug 22, 2021, 9:39 PM

#

should switch to using those instead, then

vale ibex Aug 22, 2021, 9:39 PM

#

lol

fallen patrol Aug 22, 2021, 9:39 PM

#

!remind "A Real Username#8028" 1s test

vale ibex Aug 22, 2021, 9:40 PM

#

oh yea, it's using the user converter there

static canyon Aug 22, 2021, 9:40 PM

#

It uses Union[discord.Member, discord.Role]

#dev-contrib

You will see something like: ``` <<<<<<<< AAAAHHHHH from collections import abc

You will see something like: ```
<<<<<<<< AAAAHHHHH
from collections import abc